In my PR the mypy check fails on parts | Home Assistant | Page 1

void prism Oct 12, 2023, 10:52 AM

#

Looks like mypy suddenly found some issues with typing

#

For the Need type annotation for "_attributes" (hint: "_attributes: Dict[<type>, <type>] = ...") [var-annotated] ones, you should add a type to it

#

so instead of self._attributes = {} you should do self._attributes: dict[str, Any] = {}

#

For Incompatible types in assignment (expression has type "bool", variable has type "None") [assignment], you're initializing self._current_action with self._current_action = None which makes it with type None, you can change the initializiation to self._current_action: bool | None = None

#

No overload variant of "get" of "dict" matches argument type "None" [call-overload]: self._current_mode is currently typed None as that's how its initialized. You should type it as str

#

There are quite some issues, maybe it's worth it making a preliminary PR where you complete the typing to avoid these issues in the future

ionic hollow Oct 12, 2023, 10:57 AM

#

Looks like the check only validated changed files, right?

void prism Oct 12, 2023, 10:57 AM

#

(as some issues can require more work, for example the call-overload one, you initialize it with None (iirc), and if you type it str | None, you have to make sure the code can handle if the variable is None)

#

yes

#

Also, just glanced quick over your PR. I would suggest splitting of the creation of the base entity to a separate PR

#

And I see a lot of other stuff happening in general

ionic hollow Oct 12, 2023, 11:02 AM

#

quite some changes are required by formatters which makes review a bit hard in my eyes.

void prism Oct 12, 2023, 11:03 AM

#

Yep I can imagine

#

But like, also for reviewing the code itself, this PR is doing a lot imo

#

too much

ionic hollow Oct 12, 2023, 11:04 AM

#

Ok, then I'll try to split it.

void prism Oct 12, 2023, 11:04 AM

#

Do you want me to suggest some steps you can make before this PR is easy to do?

ionic hollow Oct 12, 2023, 11:05 AM

#

Yes, please!

void prism Oct 12, 2023, 11:08 AM

#

Add typing. Start on dev and add typing to the function calls. I also see some stuff that can be moved outside of the constructor (for example, if you are doing self._current_action = None, you can also move this outside of a constructor). This might require some change in logic as you now have to take care of nullables.
Introduce the base entity, preferably without _attr_has_entity_name = True, as that usually leads to a bigger change.
add _attr_has_entity_name = True
this PR

#

And it might look like some nitpicking, but this way you can focus on one thing at a time and the review process will go a lot quicker as we're not changing stuff all over the place

ionic hollow Oct 12, 2023, 11:11 AM

#

Thanks, I will have a look now.

void prism Oct 12, 2023, 11:11 AM

#

Feel free to reach out if you have questions or want to discuss 🙂

ionic hollow Oct 12, 2023, 11:20 AM

#

Is there a way to run the validation (pre-commit run --all-files ) just for this component?

#

And mypy fails locally as it's not found. Is this something I need to install or build?

void prism Oct 12, 2023, 11:59 AM

#

eeuuuh

#

You can run ruff etc normally

#

I think there is a way to run pre-commit on a certain folder

#

make sure you have run script/setup

void prism Oct 12, 2023, 1:07 PM

#

Can you maybe explain what you mean with multiple devices?

ionic hollow Oct 12, 2023, 6:11 PM

#

Here or on the PR?

void prism Oct 12, 2023, 6:11 PM

#

oh nvm, I read the PR itself and it became clear

#

haha

#

I usually skip the whole PR and dive into the code, but that's just me

ionic hollow Oct 12, 2023, 6:12 PM

#

I just added another PR for the entity name: https://github.com/home-assistant/core/pull/101895/files

void prism Oct 12, 2023, 6:12 PM

#

I saw it

#

Already left a comment, you can change that in every place

ionic hollow Oct 12, 2023, 6:27 PM

#

Ok.
Regarding the first PR, you would be fine without special device name handling and all the has_multiple_devices stuff?

void prism Oct 12, 2023, 7:08 PM

#

I think so, but I'm also open do have a quick discussion with Robert to exchange toughts

void prism Oct 12, 2023, 7:38 PM

#

Spoke him, we'll discuss this tomorrow

void prism Oct 13, 2023, 8:30 AM

#

Am now discussing it with Frenck and Robert, we think showing no serial number in the name is the way to go

#

but to help with identifying the device, we think adding a serial number to the device_info

#

and show it in the frontend

#

This would be a new core feature

#

and we will work on the proposal and implementation of that

ionic hollow Oct 13, 2023, 9:48 PM

#

Ok, then I'll remove the serial completely for now. For me it works that way too as I have different models.

void prism Oct 18, 2023, 5:53 PM

#

Nice work on the PRs btw 🙂

#

@ionic hollow

#

btw, do you have a working dev environment?

ionic hollow Oct 18, 2023, 6:19 PM

#

No not really 😇

void prism Oct 18, 2023, 6:19 PM

#

need help setting up?

ionic hollow Oct 18, 2023, 6:20 PM

#

Pytest seems not to work correct.

void prism Oct 18, 2023, 6:21 PM

#

well more like, having pre-commit working is a blessing

#

and makes life a lot better

ionic hollow Oct 18, 2023, 6:22 PM

#

yes, thats working

#

I know next to nothing about python and how to setup a workspace. I've installed python via brew, but seems like mac has also it's own version.

#

pytest always complains about missing dependencies.

void prism Oct 18, 2023, 6:25 PM

#

but how come you always have that much black and ruff stuff?

ionic hollow Oct 18, 2023, 6:26 PM

#

I sometimes do changes in GH directly

void prism Oct 18, 2023, 6:26 PM

#

ah right

#

how do you run pytest?

ionic hollow Oct 18, 2023, 6:27 PM

#

directly in vscode

#

with the command you gave me

#

pytest ./tests/components/vicare --snapshot-update
or only pytest

void prism Oct 18, 2023, 6:27 PM

#

ah

#

the first one only runs vicare tests

#

and that one works completely right?

#

can you try pip -V

ionic hollow Oct 18, 2023, 6:29 PM

#

No, it gives

ImportError while loading conftest '/Users/.../private/home-assistant-core/tests/conftest.py'.
tests/conftest.py:36: in <module>
    from . import patch_time  # noqa: F401, isort:skip
tests/patch_time.py:7: in <module>
    from homeassistant import runner, util
homeassistant/runner.py:17: in <module>
    from . import bootstrap
homeassistant/bootstrap.py:19: in <module>
    from . import config as conf_util, config_entries, core, loader
homeassistant/config.py:20: in <module>
    from . import auth
homeassistant/auth/__init__.py:17: in <module>
    from . import auth_store, jwt_wrapper, models
homeassistant/auth/jwt_wrapper.py:13: in <module>
    from jwt import DecodeError, PyJWS, PyJWT
E   ImportError: cannot import name 'DecodeError' from 'jwt' (/opt/homebrew/lib/python3.11/site-packages/jwt/__init__.py)

#

pip3 -V
pip 23.2.1 from /opt/homebrew/lib/python3.11/site-packages/pip (python 3.11)

void prism Oct 18, 2023, 6:31 PM

#

pip3 install -r requirements.txt

#

pip3 install -r requirements_test.txt

#

try running those 2

ionic hollow Oct 18, 2023, 6:33 PM

#

Ah.. that helped! Is that not done via ./scrips/setup?

void prism Oct 18, 2023, 6:33 PM

#

it should be

#

haha

ionic hollow Oct 18, 2023, 6:35 PM

#

Ok, thanks for the help. And I will try to do changes only with pre-commit 😉

void prism Oct 18, 2023, 6:38 PM

#

I mean, you do you, but you seemt to be struggling with it so maybe you didnt know about it

ionic hollow Oct 18, 2023, 6:39 PM

#

One question though..

void prism Oct 18, 2023, 6:41 PM

#

shoot

ionic hollow Oct 18, 2023, 6:41 PM

#

For https://github.com/home-assistant/core/pull/102211 I added a new file and as for the other PR I tried to add the new file from that PR into .coveragerc.

#

This time the pre-commit hassfest check spits out some errors I cannot solve.

#

In this case I would do the change directly on gh to avoid the trouble.

void prism Oct 18, 2023, 6:42 PM

#

ah right

#

but what does hassfest say

ionic hollow Oct 18, 2023, 6:43 PM

#

ModuleNotFoundError: No module named 'numpy'

#

and some stack trace

void prism Oct 18, 2023, 6:43 PM

#

pip3 install numpy==1.26.0

ionic hollow Oct 18, 2023, 6:44 PM

#

did not help

void prism Oct 18, 2023, 6:45 PM

#

can you show the full stacktrace?

ionic hollow Oct 18, 2023, 6:48 PM

#


Validating config_schema... done in 0.78s
Validating dependencies... done in 1.38s
Validating dhcp... done in 0.09s
Validating json... done in 0.00s
Validating manifest... done in 0.02s
Validating mqtt... done in 0.00s
Validating requirements... done in 0.00s
Validating services...Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/xxx/private/home-assistant-core/script/hassfest/__main__.py", line 245, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/xxx/private/home-assistant-core/script/hassfest/__main__.py", line 167, in main
    plugin.validate(integrations, config)
  File "/Users/xxx/private/home-assistant-core/script/hassfest/services.py", line 222, in validate
    validate_services(config, integration)
  File "/Users/xxx/private/home-assistant-core/script/hassfest/services.py", line 133, in validate_services
    services = CORE_INTEGRATION_SERVICES_SCHEMA(data)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
           ^^^^^^^^^^^^^^^^^^^^^^^^

#


  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 387, in validate_mapping
    cval = cvalue(key_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 229, in _run
    return self._exec(self._compiled, value, path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 274, in _exec
    return func(path, v)
           ^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 818, in validate_callable
    return schema(data)
           ^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 387, in validate_mapping
    cval = cvalue(key_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 229, in _run
    return self._exec(self._compiled, value, path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

#


  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 274, in _exec
    return func(path, v)
           ^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 818, in validate_callable
    return schema(data)
           ^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 387, in validate_mapping
    cval = cvalue(key_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 229, in _run
    return self._exec(self._compiled, value, path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 353, in _exec
    v = func(path, v)
        ^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 636, in validate_sequence
    cval = validate(index_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 818, in validate_callable
    return schema(data)
           ^^^^^^^^^^^^

#


  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 387, in validate_mapping
    cval = cvalue(key_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 636, in validate_sequence
    cval = validate(index_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 229, in _run
    return self._exec(self._compiled, value, path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/validators.py", line 353, in _exec
    v = func(path, v)
        ^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/venv/lib/python3.11/site-packages/voluptuous/schema_builder.py", line 818, in validate_callable
    return schema(data)
           ^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/homeassistant/helpers/selector.py", line 156, in _validate_supported_features
    feature_mask |= _validate_supported_feature(supported_feature)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

void prism Oct 18, 2023, 6:49 PM

#

what complains about numpy then

ionic hollow Oct 18, 2023, 6:49 PM

#


  File "/Users/xxx/private/home-assistant-core/homeassistant/helpers/selector.py", line 131, in _validate_supported_feature
    known_entity_features = _entity_features()
                            ^^^^^^^^^^^^^^^^^^
  File "/Users/xxx/private/home-assistant-core/homeassistant/helpers/selector.py", line 91, in _entity_features
    from homeassistant.components.camera import CameraEntityFeature
  File "/Users/xxx/private/home-assistant-core/homeassistant/components/camera/__init__.py", line 29, in <module>
    from homeassistant.components.stream import (
  File "/Users/xxx/private/home-assistant-core/homeassistant/components/stream/__init__.py", line 61, in <module>
    from .core import (
  File "/Users/xxx/private/home-assistant-core/homeassistant/components/stream/core.py", line 14, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'

hassfest-metadata....................................(no files to check)Skipped
hassfest-mypy-config.................................(no files to check)Skipped

void prism Oct 18, 2023, 6:50 PM

#

@ionic knoll this is what coffeecat meant

ionic knoll Oct 18, 2023, 6:52 PM

#

pip install -e .

void prism Oct 18, 2023, 6:52 PM

#

oh right, that's what you said to her too

ionic hollow Oct 18, 2023, 6:53 PM

#

Problem is unfortunately still the same..

void prism Oct 18, 2023, 6:57 PM

#

hmm, what happens when you run the script/setup?

ionic hollow Oct 18, 2023, 6:58 PM

#

runs through without issues

void prism Oct 18, 2023, 7:00 PM

#

very strange

ionic knoll Oct 18, 2023, 7:18 PM

#

if you run hassfest manually?

#

python -m script.hassfest ?

ionic hollow Oct 18, 2023, 7:30 PM

#

Then it's complaining about a lot of missing packages

#


Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/xxx/private/home-assistant-core/script/hassfest/__main__.py", line 10, in <module>
    from . import (
  File "/Users/xxx/private/home-assistant-core/script/hassfest/requirements.py", line 14, in <module>
    from tqdm import tqdm
ModuleNotFoundError: No module named 'tqdm'

#

running pip3 install -r requirements.txt
and pip3 install -r requirements_test.txt again, now the manual command works

void prism Oct 18, 2023, 7:39 PM

#

are you in a venv?

ionic hollow Oct 18, 2023, 7:39 PM

#

pre-commit not

#

is that part of the script/setup? if not, then probably no.

void prism Oct 19, 2023, 10:30 AM

#

@ionic hollow do you agree with the ViCare typing PR? I updated the rest of the types

ionic hollow Oct 19, 2023, 1:05 PM

#

I have some doubts about iterables: list[PyViCareDevice]

#

I think burners, compressors and circuits have no common type

void prism Oct 19, 2023, 1:09 PM

#

let me finish this commit and I'll take a look

#

Right I have a small feeling the typing isn't correct from the beginning

#

At one point we are calling _build_entity with PyViCareDevice as api and at another point we are giving DeviceWithComponent

ionic hollow Oct 19, 2023, 1:21 PM

#

MAybe this should be two different functions.

void prism Oct 19, 2023, 1:21 PM

#

I think my conclusion is right

#

check this out

#

    @property
    def unique_id(self) -> str:
        """Return unique ID for this device."""
        tmp_id = (
            f"{self._device_config.getConfig().serial}-{self.entity_description.key}"
        )
        if hasattr(self._api, "id"):
            return f"{tmp_id}-{self._api.id}"
        return tmp_id

#

DeviceWithComponent has "id", PyViCareDevice doesn't

ionic hollow Oct 19, 2023, 1:29 PM

#

Do you have the chance to test the integration if it works as expected? Otherwise I can try to run it.

void prism Oct 19, 2023, 1:35 PM

#

haha, I don't own any ViCare devices

#

I'm just someone who is looking at certain integrations and be like, oh, we can make this better

void prism Oct 19, 2023, 2:04 PM

#

Mind if I ask some questions about the context?

ionic hollow Oct 19, 2023, 2:22 PM

#

Sure

void prism Oct 19, 2023, 2:25 PM

#

why do you have to put in a heating type when you set up the integration?

ionic hollow Oct 19, 2023, 2:31 PM

#

At least when we support multiple devices, this wuld make no sense.

#

Maybe we could fully rely on the automatic detection: https://github.com/somm15/PyViCare/blob/8ba411483a865e074d1146fd1b8b7a8c4f4be122/PyViCare/PyViCareDeviceConfig.py#L70

void prism Oct 19, 2023, 2:33 PM

#

ionic hollow At least when we support multiple devices, this wuld make no sense.

exactly my point haha

#

Also, not sure if you noticed, PyViCare has a new version

ionic hollow Oct 19, 2023, 2:35 PM

#

Yes

#

That will also clash with the multi device support

void prism Oct 19, 2023, 2:36 PM

#

in a positive way?

ionic hollow Oct 19, 2023, 2:37 PM

#

v2.28.x also provides the gateways to the heating devices.

#

Unfortunately, the current serial, which is used as uid is the serial from that gateway and not the heating device.

void prism Oct 19, 2023, 2:38 PM

#

Right, can you maybe explain a bit more on how the whole system works?

#

Because when I check the code I see some stuff

#

gateways, heating devices, circuits

#

etc

ionic hollow Oct 19, 2023, 2:39 PM

#

I can describe how it works for me, but Viessmann has multiple, also more modern devices.

#

So I have two dump heating devices that have an IR interface.

#

via the interface a gateway box is corrected to my wifi.

#

as I have two heatings for two flats, I have also two gateways.

void prism Oct 19, 2023, 2:40 PM

#

two flats?

ionic hollow Oct 19, 2023, 2:41 PM

#

Yes 😉 two flors

void prism Oct 19, 2023, 2:41 PM

#

ah right

ionic hollow Oct 19, 2023, 2:41 PM

#

so this is kind unusual and I guess most users have only one gateway

#

Or, I think more modern devices have direct wifi access

void prism Oct 19, 2023, 2:43 PM

#

Right right

#

Do they work with this integration already?

ionic hollow Oct 19, 2023, 2:43 PM

#

With my PR, yes

void prism Oct 19, 2023, 2:44 PM

#

I can't remember now, did your PR also bump the library?

ionic hollow Oct 19, 2023, 2:44 PM

#

No

#

So current state gives me my two heating devices

#

The v2.28 gives me four devices, two heatings and two gateways.

void prism Oct 19, 2023, 2:45 PM

#

Aaah right

#

And then the problem is that we can't get the serial from the gateway from the heating anymore?

ionic hollow Oct 19, 2023, 2:47 PM

#

The gateway also seems to support/expose all features that the heating exposes. So the integration tries to create all the sensors again, which fails due to naming with the same serial

#

mindblown

void prism Oct 19, 2023, 2:48 PM

#

Oh so they have the same serial?

ionic hollow Oct 19, 2023, 2:49 PM

#

{
    "data": [
        {
            "gatewaySerial": "7571381723160106",
            "id": "0",
            "boilerSerial": "7452947312545103",
            "boilerSerialEditor": "DeviceCommunication",
            "bmuSerial": "7509081322740107",
            "bmuSerialEditor": "DeviceCommunication",
            "createdAt": "2018-06-08T12:48:28.806Z",
            "editedAt": "2023-07-04T12:25:31.733Z",
            "modelId": "VScotHO1_72",
            "status": "Online",
            "deviceType": "heating",
            "roles": [
                "type:boiler",
                "type:legacy",
                "type:product;VScotHO1"
            ],
            "isBoilerSerialEditable": false
        },
        {
            "gatewaySerial": "7571381723160106",
            "id": "gateway",
            "boilerSerial": null,
            "boilerSerialEditor": null,
            "bmuSerial": null,
            "bmuSerialEditor": null,
            "createdAt": "2021-05-19T06:32:22.925Z",
            "editedAt": "2023-10-09T14:23:14.464Z",
            "modelId": "Heatbox1",
            "status": "Online",
            "deviceType": "vitoconnect",
            "roles": [
                "type:gateway;VitoconnectOpto1",
                "type:legacy"
            ],
            "isBoilerSerialEditable": false
        }
    ]
}

void prism Oct 19, 2023, 2:49 PM

#

wrap them in 3 backticks

ionic hollow Oct 19, 2023, 2:50 PM

#

This is from the API, first device is the heating device, whuch has a "boilerSerial", that should be used instead

void prism Oct 19, 2023, 2:51 PM

#

Instead of what

#

like

#

is there any benefit in including the gateway as another device?

ionic hollow Oct 19, 2023, 2:52 PM

#

I would like to see the status of the devices, which of them is offline. and if possible the RSSI

void prism Oct 19, 2023, 2:52 PM

#

ah so there is a benefit

#

right

#

ah, that's also probably for that PR about connectivity

#

Like if you are up for it, I can help you get this integraton to a nice level

#

But you're the one that can test it haha

ionic hollow Oct 19, 2023, 2:56 PM

#

My heating is an old device, so most of the features are not supported. And the library supports a broad bandwidth of heating and other devices.

void prism Oct 19, 2023, 2:57 PM

#

We can find some more testers, I saw some open issues fly by

#

I have a nice script from bdraco that you can run in the terminal and it will install a PR as custom component

#

so we don't need other devs or technical people to test

#

as long as they know how to execute some command

#

but more like, I want to know if you are up it

ionic hollow Oct 19, 2023, 2:58 PM

#

Thats great

#

Yes, sure.-

void prism Oct 19, 2023, 2:58 PM

#

not that I am now just putting you on a task you dont want

#

So what I am also wondering is, how does the circuits, burners and compressors work?

#

are those the internals of the heating thing?

ionic hollow Oct 19, 2023, 3:00 PM

#

Yes, internals.

void prism Oct 19, 2023, 3:00 PM

#

so they aren't a separate device

ionic hollow Oct 19, 2023, 3:01 PM

#

No. I also have only one burner and one circuit. Not even domestic hot water, only heating.

void prism Oct 19, 2023, 3:02 PM

#

And a circuit is the name for the water pipes in your home?

#

I don't have my own boiler and the one at my parents isn't smart so I don't know the exact term

ionic hollow Oct 19, 2023, 3:03 PM

#

Yes, and I guess bigger devices can supply multiple circuits

void prism Oct 19, 2023, 3:05 PM

#

Right right

#

So now what I am thinking is:

Fix typing: I think we have to split some stuff up, as for example api can be either PyViCareDevice or DeviceWithComponent (or subclasses). I think if we straighten this, we can work a bit stricter and decrease the chance we accidentaly create bugs.
Bump the library to 2.28.x: We can create a migration that will change the unique_id to be part of the right device and change the unique_id of the boiler to the boiler_id.
Auto detect? - This would eliminate the need for the selector in the config flow, enabling us to detect this at startup and connect.
Add multple device support

#

Maybe needs more steps, but what do you think?

ionic hollow Oct 19, 2023, 3:11 PM

#

The config flow is also something that I need to change, the free API has a daily limit, which I reach at about 9 in the evening, therefore I need to adjust the cache lifetime.

void prism Oct 19, 2023, 3:11 PM

#

free API?

#

they have a paid API?

ionic hollow Oct 19, 2023, 3:12 PM

#

yes

void prism Oct 19, 2023, 3:12 PM

#

Why do you need to adjust the cache lifetime in the config flow tho

ionic hollow Oct 19, 2023, 3:12 PM

#

https://developer.viessmann.com/start/pricing.html

void prism Oct 19, 2023, 3:13 PM

#

bruh

#

haha

ionic hollow Oct 19, 2023, 3:13 PM

#

It's on 1440 calls a day 😦

void prism Oct 19, 2023, 3:14 PM

#

I think you do more calls since you have 2 right

ionic hollow Oct 19, 2023, 3:14 PM

#

I think so, but I don't know HA so deeply, when it's updating.

void prism Oct 19, 2023, 3:15 PM

#

I'm guessing ever y 30s

#

wait

#

does the library cache stuff?

ionic hollow Oct 19, 2023, 3:15 PM

#

Yes!

void prism Oct 19, 2023, 3:15 PM

#

I was looking at the code and was like

#

WHAT

#

since it looks like its doing separate calls for both unit and value for example

ionic hollow Oct 19, 2023, 3:20 PM

#

I think it's updating every 60 seconds which leads to 1440 calls.

#

If I set a value I would aleary breach that limit.

void prism Oct 19, 2023, 3:21 PM

#

I think in your case you can disable polling and poll via an automation

#

oh but you dont have an coordinator, so that would become a big automation

ionic hollow Oct 19, 2023, 3:23 PM

#

There is the ability to disable cache

#

https://github.com/somm15/PyViCare/blob/8ba411483a865e074d1146fd1b8b7a8c4f4be122/PyViCare/PyViCare.py#L36-L40

void prism Oct 19, 2023, 3:23 PM

#

oh but you dont want that

#

Like, in that case it would do a call for a lot of stuff

#

It calls a service for the value of something, and for the unit

ionic hollow Oct 19, 2023, 3:26 PM

#

I need to bring my kids to bed, but lets continue on this.

void prism Oct 19, 2023, 3:26 PM

#

yea sure!

ionic hollow Oct 19, 2023, 4:23 PM

#

void prism oh but you dont want that

I wonder if it would be better to let HA handle the data and updating it.

void prism Oct 19, 2023, 4:24 PM

#

I mean we have ways to do that

#

But I am wondering how much calls this lib itself does

ionic hollow Oct 19, 2023, 4:27 PM

#

My history show an average of 1000calls/day

void prism Oct 19, 2023, 4:28 PM

#

Sorry, rephrasing, I am not sure how much different calls the lib does

#

as in self.service.getProperty("heating.dhw.sensors.temperature.hotWaterStorage") vs self.service.getProperty("heating.dhw.sensors.temperature.outlet")

ionic hollow Oct 19, 2023, 4:33 PM

#

no idea

void prism Oct 19, 2023, 4:38 PM

#

I think every one is a single call

#

The thing that does work well in this context is that if your instance doesnt support something, it doesnt create extra polls

ionic hollow Oct 19, 2023, 9:48 PM

#

I might be wrong about the serial, looks like the serial for the gateway is wrong (https://github.com/somm15/PyViCare/issues/335) so no migration necessary.

void prism Oct 20, 2023, 10:18 AM

#

That's interesting

ionic hollow Oct 23, 2023, 1:33 PM

#

Can we finish the typing PR?

#

I think the only needed change is the HeatingDeviceWithComponent

void prism Oct 23, 2023, 1:46 PM

#

I think we need to split some stuff up as there is some typing issues in the objects itself

#

@dataclass
class ViCareSensorEntityDescription(SensorEntityDescription, ViCareRequiredKeysMixin):
    """Describes ViCare sensor entity."""

    unit_getter: Callable[[Device], str | None] | None = None

#

Device can be either a PyViCare or a DeviceWithComponent thing

ionic hollow Oct 23, 2023, 7:27 PM

#

Do you think there is a change to the library needed or can we solve this via the integration?

ionic hollow Oct 23, 2023, 9:06 PM

#

ionic hollow I might be wrong about the serial, looks like the serial for the gateway is wron...

So the serial is correct, but in the integration the wrong one is used 😦 PyViCareDeviceConfig.getConfig.serial is used currently and gives the gateway one. The right one would be PyViCareHeatingDevice.getSerial().

I proposed some changes here: https://github.com/home-assistant/core/compare/dev...CFenner:home-assistant-core:CFenner-patch-12

How could a migration script look like?

void prism Oct 23, 2023, 9:10 PM

#

ionic hollow Do you think there is a change to the library needed or can we solve this via th...

I think the library could use a little change

#

for example, they are missing a py.typed file, some kinf of file that shows the lib is typed

#

and when you do .burners() or whatever, the returnvalue is list[Any]

void prism Oct 23, 2023, 9:14 PM

#

ionic hollow So the serial is correct, but in the integration the wrong one is used 😦 `PyViC...

Hmm, we can just migrate, but in a world where we migrated the entities, is the old serial still used?

ionic hollow Oct 24, 2023, 6:22 AM

#

void prism Hmm, we can just migrate, but in a world where we migrated the entities, is the ...

Could be used in the future for the gateway itself.

void prism Oct 24, 2023, 8:00 AM

#

So to summarize

#

Only main device are added to HA

#In my PR the mypy check fails on parts