#is it acceptable to have the same
hidden crater
@crystal bronze please don't forget about this, whenever you have the time. Thanks!
olive knoll
you cannot have duplicate sentences
HA can't know which one to pick
make sure your fixtures do not have generic names and you can avoid that
hidden crater
that's not the idea. in romanian, the translation for "turn off [the light]" and the translation for "close [the door]" can be the same: "inchide [lumina]" / "inchide [usa]"
following the example for EN, I can't have it like that in Romanian even with a very specific entity name, as "inchide <some generic thing>" supersedes "inchide <that very specific window - fereastra din stanga = "the window on the left">" https://github.com/tetele/intents/blob/main/sentences/en/cover_HassCloseCover.yaml#L6
the specificity of the entity name is not relevant in this context. the same wording for 2 intents (turn off/close) is
crystal bronze
I have a feature in the intent matcher to try out here. You can say an intent should only match entities from a specific domain.
This still needs to be tested, but I think we won't need device class in this case.
@hidden crater Do you have a PR I can test against?
olive knoll
@crystal bronze note that you also need to be able to specify the opposite for the other sentence. HassTurnOn should not target any cover domain entities
crystal bronze
Right. I have requires_context for the HassOpenCover side and excludes_context for the HassTurnOn side 👍
hidden crater
<@535933407939657745> Do you have a PR I can test against?
Not a PR but a commit. I can create a PR if needed https://github.com/tetele/intents/tree/b83292c8521355880a05e0ee4d655ba9e761803e
Uhm... wait, the commit I referenced actually reveals a related, but more specific issue: common wordings between different device_class contexts of the same intent. I'll get back with a relevant link for the mismatched intent.
would it be better if I add some issues with proper description on the intents repo @crystal bronze @olive knoll ? I feel as though it's easier to get sidetracked with a discussion on Discord 🙂
hidden crater