still unavailable | Home Assistant | Page 1

hot wedge Dec 2, 2022, 6:20 PM

#

Weird. Anything in the logs?
With debug of twinkly enabled?

dry sable Dec 2, 2022, 6:21 PM

#

let me fire up debugging

#

nothing that looks errorish

2022-12-02 11:21:56.291 DEBUG (MainThread) [custom_components.twinkly.light] Updating 'Twinkly_6A5D49.collective.lan'
2022-12-02 11:21:56.291 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:21:56.291 DEBUG (MainThread) [ttls.client] GET endpoint led/mode
2022-12-02 11:21:56.320 DEBUG (MainThread) [ttls.client] GET response 200
2022-12-02 11:21:56.320 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:21:56.320 DEBUG (MainThread) [ttls.client] GET endpoint led/out/brightness
2022-12-02 11:21:56.400 DEBUG (MainThread) [ttls.client] GET response 200
2022-12-02 11:21:56.400 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:21:56.400 DEBUG (MainThread) [ttls.client] GET endpoint gestalt
2022-12-02 11:21:56.425 DEBUG (MainThread) [ttls.client] GET response 200
2022-12-02 11:21:56.425 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:21:56.425 DEBUG (MainThread) [ttls.client] GET endpoint movies
2022-12-02 11:22:29.432 DEBUG (MainThread) [custom_components.twinkly.light] Updating 'Twinkly_6A5D49.collective.lan'
2022-12-02 11:22:29.432 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:22:29.432 DEBUG (MainThread) [ttls.client] GET endpoint led/mode
2022-12-02 11:22:29.467 DEBUG (MainThread) [ttls.client] GET response 200
2022-12-02 11:22:29.467 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:22:29.467 DEBUG (MainThread) [ttls.client] GET endpoint led/out/brightness
2022-12-02 11:22:29.495 DEBUG (MainThread) [ttls.client] GET response 200
2022-12-02 11:22:29.495 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:22:29.495 DEBUG (MainThread) [ttls.client] GET endpoint gestalt
2022-12-02 11:22:29.515 DEBUG (MainThread) [ttls.client] GET response 200
2022-12-02 11:22:29.515 DEBUG (MainThread) [ttls.client] Authentication token still valid
2022-12-02 11:22:29.515 DEBUG (MainThread) [ttls.client] GET endpoint movies

hot wedge Dec 2, 2022, 6:28 PM

#

No exceptions or anythng?

dry sable Dec 2, 2022, 6:28 PM

#

nope

#

there's 0 debug logging in the integration

hot wedge Dec 2, 2022, 6:29 PM

#

I added some debug lines in the latest PRs

dry sable Dec 2, 2022, 6:31 PM

#

i see it in the get movies stuff

hot wedge Dec 2, 2022, 6:32 PM

#

Yes. They should show up just after the "Get endpoint movies" probably

dry sable Dec 2, 2022, 6:32 PM

#

nothing happens after that

#

re-ran the script too:

== Setting color ==
## Cant set color ##
404, message='Not Found', url=URL('http://twinkly_6a5d49.collective.lan/xled/v1/led/color')
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fb2e93b7d90>
== Setting color done ==
## Cant get movies ##
Server disconnected
## Cant get current movie ##
Server disconnected
Traceback (most recent call last):
  File "/home/firstof9/twinkly.py", line 65, in <module>
    asyncio.run(main_loop())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/firstof9/twinkly.py", line 45, in main_loop
    if 'movies' in mov and curr:
TypeError: argument of type 'NoneType' is not iterable
Unclosed client session

#

here's the get_mode reply:
{'code': 1000, 'mode': 'movie', 'shop_mode': 0}

#

"led/movie/config":

{'code': 1000,
 'frame_delay': 67,
 'frames_number': 45,
 'leds_number': 435,
 'loop_type': 0,
 'sync': {'master_id': '', 'mode': 'none', 'slave_id': ''}}

hot wedge Dec 2, 2022, 6:59 PM

#

Mhm. Just dont understand why you cant see the debug lines and why it does not work

hot wedge Dec 2, 2022, 7:49 PM

#

DId you replace light.py with the one from the last PR?

dry sable Dec 2, 2022, 7:51 PM

#

yup

hot wedge Dec 2, 2022, 8:11 PM

#

Does it continue with the updates, or did it jst run once?

dry sable Dec 2, 2022, 8:17 PM

#

the async_update function keeps getting called

hot wedge Dec 2, 2022, 8:17 PM

#

Pushed a new file now to the same PR, a bit more error-logging

dry sable Dec 2, 2022, 8:18 PM

#

I'm pin pointing where the issue is but I think it may have something to do with this block:

            for key, value in device_info.items():
                if key not in HIDDEN_DEV_VALUES:
                    self._attributes[key] = value

            if LightEntityFeature.EFFECT in self.supported_features:
                await self.async_update_movies()
                await self.async_update_current_movie()

hot wedge Dec 2, 2022, 8:20 PM

#

The first three lines have not changed. The last three are added in 2022.12

#

At first run, the if should return true, but the two functions below should fail, and unset the EFFECT feature

dry sable Dec 2, 2022, 8:21 PM

#

ya i added some "echo" debugs just to see where it's getting hung up

#

because it seems to never fall out to self._is_available = True

hot wedge Dec 2, 2022, 8:21 PM

#

It could be that the async_update_movies() never returns?

#

That would be the same function as this from the script

Cant get movies

Server disconnected

dry sable Dec 2, 2022, 8:23 PM

#

yup it's failing at that if block

#

            if LightEntityFeature.EFFECT in self.supported_features:
                await self.async_update_movies()
                await self.async_update_current_movie()

hot wedge Dec 2, 2022, 8:24 PM

#

So... I need to add another test to check if that is available

dry sable Dec 2, 2022, 8:27 PM

#

ya like

if movies not in get_movies:
  self.supported_features = None

#

something like that I'd think

#

the older version I could set colors so 🤷‍♂️

hot wedge Dec 2, 2022, 8:29 PM

#

I just need a way to check if the feature is available without turning the lights on or breaking something else

dry sable Dec 2, 2022, 8:30 PM

#

i've not really dug into the API on this stuff, I assume you're reverse engineering it

hot wedge Dec 2, 2022, 8:32 PM

#

Whant happens if you curl http://twinkly_6a5d49.collective.lan/xled/v1/movies

dry sable Dec 2, 2022, 8:33 PM

#

curl: (52) Empty reply from server

#

/xled/v1/led/mode: {'code': 1000, 'mode': 'enabled', 'value': 50}

#

maybe base it on FW version?

#

curl http://twinkly_6a5d49.collective.lan/xled/v1/fw/version
{"version":"2.3.5","code":1000}

hot wedge Dec 2, 2022, 9:24 PM

#

Probably the best

#

That is the latest fw for your?

#

(Pushed a new version now)

#

Seems like 2.7.1 is the first with all of this

dry sable Dec 2, 2022, 9:40 PM

#

hot wedge That is the latest fw for your?

yes

#

just grabbed it and restarting HA now

hot wedge Dec 2, 2022, 9:54 PM

#

New version coming up with version testing instead

#

But if the one you are testing now works, this shoud work as well, as the only difference is that I check for the version instead of another parameter I found

dry sable Dec 2, 2022, 10:10 PM

#

it does become available and controllable

hot wedge Dec 2, 2022, 10:10 PM

#

Excellent

#

Unfortunately, you won't get the effects control with that version

dry sable Dec 2, 2022, 10:11 PM

#

that's fine

#

I'm keeping the tree till it stops working hehe

hot wedge Dec 2, 2022, 10:12 PM

#

Was that with the latest fix, or the previous?

dry sable Dec 2, 2022, 10:13 PM

#

you want me to give the latest a go?

hot wedge Dec 2, 2022, 10:13 PM

#

Thanks a lot for testing btw

dry sable Dec 2, 2022, 10:13 PM

#

sure no problem man

hot wedge Dec 2, 2022, 10:13 PM

#

Pleas, if you don't mind restarting again

dry sable Dec 2, 2022, 10:13 PM

#

downloading now

hot wedge Dec 2, 2022, 10:14 PM

#

So we can close that bug and get it into it to b3 or something

dry sable Dec 2, 2022, 10:14 PM

#

make sure to poke Frenk about it to get added to the beta 🙂

#

new version works too

hot wedge Dec 2, 2022, 10:20 PM

#

Thanks again. Need a break now

hot wedge Dec 3, 2022, 8:35 AM

#

Got a review from balloob, and have implemented all of his comments. Rewrote quite a bit of code. But should still work for you, I hope.

dry sable Dec 3, 2022, 4:42 PM

#

dropping the files in and restarting to test 🙂

hot wedge Dec 3, 2022, 5:03 PM

#

👍

dry sable Dec 3, 2022, 5:14 PM

#

yup still works

#

could go for a firmware field in the device info later on just for good measure 😛

hot wedge Dec 3, 2022, 5:26 PM

#

It's coming.
I have a PR ready for that as well, but it depends on this one to be merged first.

#

I am adding full diagnostics support to the integration

#

Do you mind confirming in the PR that it resolves the issue?
https://github.com/home-assistant/core/pull/83145

https://github.com/home-assistant/core/issues/83076

GitHub

Support older twinkly devices without effects by Olen · Pull Reques...

Proposed change

This should bring back support for older devices that was broken with the new effects functions.
Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an is...

GitHub

Bug: Twinkly unavailable · Issue #83076 · home-assistant/core

The problem Twinkly device unavailable after update to latest beta. What version of Home Assistant Core has the issue? core-2022.12.0b0 What was the last working version of Home Assistant Core? cor...

dry sable Dec 3, 2022, 6:23 PM

#

hot wedge Do you mind confirming in the PR that it resolves the issue? https://github.com/...

just commented

hot wedge Dec 3, 2022, 6:25 PM

#

Thanks. Balloob already approved it, so I am just waiting for the merge and I'll add the diagnostics PR as well

#still unavailable

Cant get movies