BetterSinkholes3

[storm python]

BetterSinkholes is a LabAPI plugin that makes sinkhole environmental hazards (found in LZ - IX Intersections) more realistic and similar to SCP:CB. With the use of this plugin, players who walk into sinkholes fall into the pocket dimension and may never return.

This is a port of BetterSinkholes2 from EXILED to LabAPI.

Original Author: blackruby#2562
EXILED Port: _yamato._

Link: https://github.com/tyabus/BetterSinkholes3

[fair iron]

why patch instead of using PlayersStayingInHazardEventArgs

[severe plinth]

Their response is probably going to be that they don't know because it's a port
Personally, I don't get why people insist on consistently "porting" simple plugins like this
Bro just remake it 😭

Stg I've seen this exact plugin crop up multiple times with multiple ports

Ong this plugin should not need a Harmony dependency
99% sure this can all be done with base LabAPI

Also why are you mixing and matching the notation here

Just use => for all of it or { get; } for all of it, why both

Nested if statements are gross

Don't need curly brackets for this foreach loop, and I have no clue why you're using Hazard.List

I could elaborate and keep going but I don't want to seem too mean

[upper apex]

For version it is better to have { get; }

[severe plinth]

Depends

But yeah it's good to not have to recompute the version with every access

Just depends on how many times you're really accessing it

Typically you only mix for value-types vs reference-types

[severe plinth]

This does 2 expression-bodied and 1 auto-property for 3 string properties

[upper apex]

Yup i agreed

[fair iron]

waiting for CompiledVersion to be the compiled version

[severe plinth]

LabAPI is wild like that

Still have to publicize the assembly btw

[storm python]

I literally forgot that this event exists and I thought it would be a good practice try to make a simple harmony patch

https://github.com/tyabus/BetterSinkholes3/releases/tag/1.0.2

Removed HarmonyLib dependency
Use SinkholeHazard.List instead of Hazard.List
Use OnWaitingForPlayers instead of OnRoundStarted event
Use "=>" instead of "{ get; }" for plugin's Description

[storm python]

this was one of the first plugins I've ever used on my server so I thought why wouldn't I start practicing with it

[storm python]

true

[storm python]

and why would that be mean?

[severe plinth]

I can be rather blunt and some people interpret my critiques as me being a douche so I try to be tentative with my statements when I talk about a person's plugin

I know I can be harsh but generally I don't want to put down anyone's work

[upper apex]

You can also prevent godmod entering / noclip