#I found quite a few strange cases related to lockers

1 messages · Page 1 of 1 (latest)

lethal lake
#

MER ds https://discord.gg/JwAfeSd79u
I described the problem itself in this thread #1383383455332700160 message

As many of you may know, starting with version 2025.6.19.1 of MER, they added the ability to install lockers on the game map. Having quickly run through the MER code, I realized that it uses the basic game functionality of installing lockers on the game map. However, with different test cases, I periodically received an unexpected result. I would like to get some clarification on where exactly the error is? For convenience, I will duplicate all my tests in this thread.

GitHub
Release 2025.6.19.1 · Michal78900/ProjectMER

Implemented Lockers (loot editable only in the map file directly)
Readded FileSystemWatcher (disabled by default)

# 
primitives: {}
lights: {}
doors: {}
workstations: {}
item_spawnpoints: {}
player_spawnpoints: {}
capybaras: {}
texts: {}
scp079_cameras: {}
shooting_targets: {}
schematics: {}
teleports: {}
lockers:
  301decfc:
    locker_type: Misc
    loot:
    - target_item: KeycardJanitor
      remaining_uses: 1
      max_per_chamber: 1
      probability_points: 1
      min_per_chamber: 1
    - target_item: KeycardScientist
      remaining_uses: 2
      max_per_chamber: 1
      probability_points: 2
      min_per_chamber: 1
    - target_item: KeycardZoneManager
      remaining_uses: 2
      max_per_chamber: 1
      probability_points: 2
      min_per_chamber: 1
    - target_item: Painkillers
      remaining_uses: 2
      max_per_chamber: 3
      probability_points: 1
      min_per_chamber: 1
    - target_item: Radio
      remaining_uses: 1
      max_per_chamber: 1
      probability_points: 0
      min_per_chamber: 1
    - target_item: Coin
      remaining_uses: 1
      max_per_chamber: 4
      probability_points: 0
      min_per_chamber: 1
    - target_item: Medkit
      remaining_uses: 1
      max_per_chamber: 1
      probability_points: 1
      min_per_chamber: 1
    - target_item: Flashlight
      remaining_uses: 2
      max_per_chamber: 1
      probability_points: 1
      min_per_chamber: 1
# 
    chambers:
    - acceptable_items: []
      is_open: false
      required_permissions: None
    - acceptable_items: []
      is_open: false
      required_permissions: None
    - acceptable_items:
      - KeycardJanitor
      - KeycardScientist
      - KeycardZoneManager
      - Medkit
      - Painkillers
      is_open: false
      required_permissions: None
    - acceptable_items:
      - KeycardJanitor
      - KeycardScientist
      - KeycardZoneManager
      - Medkit
      - Painkillers
      is_open: false
      required_permissions: None
    - acceptable_items:
      - KeycardJanitor
      - KeycardScientist
      - KeycardZoneManager
      - Medkit
      - Painkillers
      is_open: false
      required_permissions: None
    - acceptable_items:
      - KeycardJanitor
      - KeycardScientist
      - KeycardZoneManager
      - Medkit
      - Painkillers
      is_open: false
      required_permissions: None
    position: (28.595, 290.689, -42.290)
    rotation: (0.000, 0.000, 0.000)
    scale: (1.000, 1.000, 1.000)
    room: Surface_Undefined_Outside
    index: 0
#

Where do flashlights and radios come from if they are not in acceptable_items? During dozens of tests, the only item I did not receive was coins.
p. s. I was still able to get coins once.
p. s. s. In test number 6 I found out where the extra items come from.

#

https://cdn.discordapp.com/attachments/1383383455332700160/1385904519501840395/2025-06-21_114310.png?ex=6857c3aa&is=6856722a&hm=9d52205acdf28ed7ca6f4f67711dd440daef0b5d62d55af3461ceedbd63b0022&
https://cdn.discordapp.com/attachments/1383383455332700160/1385904519795310612/2025-06-21_114245.png?ex=6857c3aa&is=6856722a&hm=32f60f451cc7b76e42c2c6c7bbb00149e544ef697ffca6395d08e01fa828f64a&
https://cdn.discordapp.com/attachments/1383383455332700160/1385904520176861324/2025-06-21_114235.png?ex=6857c3aa&is=6856722a&hm=01d3969e6209a1f8069eeb784c4c02b05ec7cf766431801b823b85ab2f00899e&
https://cdn.discordapp.com/attachments/1383383455332700160/1385904520546222111/2025-06-21_114217.png?ex=6857c3aa&is=6856722a&hm=46ce6ad35315e4d4b94989162a00bd63d5f05a990bda96972082968764004538&

#

Test number 2. I set probability_points: 0 everywhere and the items still continue to appear.
Test number 3. If you do this: loot: [] chambers: [], then as expected the locker is always empty.
Test number 4. If you leave only "loot" filled in, then objects in the closet appear.
Test number 5. If you leave only "chambers" filled in, then no items will appear in the closet.

#

Continuation of test number 6. I got the conclusion that if you specify "acceptable_items: []", then the server or plugin itself determines which items to put there. Which for me is unexpected behavior, i.e. incorrect.
https://cdn.discordapp.com/attachments/1383383455332700160/1385915094348857484/image.png?ex=6857cd83&is=68567c03&hm=8861e79e19150273cc2949c5b2dfa7867cef27884caac13742c9b0b220469218&
https://cdn.discordapp.com/attachments/1383383455332700160/1385915094826876959/image.png?ex=6857cd83&is=68567c03&hm=766325ce927c14b475363155b9716dba8b8112f130e2c8ea9d45a7143feb9f8f&

#

Test number 7. In this situation, no items should appear. However, the janitor cards appear periodically.
https://cdn.discordapp.com/attachments/1383383455332700160/1385938483184664586/image.png?ex=6857e34b&is=685691cb&hm=09849a76c6a3f11a84b26364539018e3e3a62b9c93e26fc4dd6e72339eb7104b&
https://cdn.discordapp.com/attachments/1383383455332700160/1385938483717079050/image.png?ex=6857e34c&is=685691cc&hm=bc6b499d24b055de04fa5c2bb097769e7653a8ba0cdd5a1dda0b2a0409b2e415&
https://cdn.discordapp.com/attachments/1383383455332700160/1385938484077793320/image.png?ex=6857e34c&is=685691cc&hm=48fc25104b1790282c8d97c130bc315b19351b4c662627d19c23eeafde089187&
https://cdn.discordapp.com/attachments/1383383455332700160/1385938484425916538/image.png?ex=6857e34c&is=685691cc&hm=eaa9327be4fe663e9c754ed6a35511706aa4cf0d4744b8e302032684339d6494&

#

From all the above tests I conclude that the functionality of lockers works quite strangely.

#

The plugin developer claims that it uses the game's core code.

image.png
deft drum
#

Like I tried to replicate the base game behavoir using both LabAPI and base game methods to be exact

shut abyss
#

@deft drum whats the problem here exactly? MER or basegame?

deft drum
#

this is how I handle the lockers in any case

        labApiLocker.ClearLockerLoot();
        foreach (SerializableLockerLoot loot in Loot)
        {
            labApiLocker.AddLockerLoot(loot.TargetItem, loot.RemainingUses, loot.ProbabilityPoints, loot.MinPerChamber, loot.MaxPerChamber);
        }

        int i = 0;
        labApiLocker.ClearAllChambers();
        foreach (LapApiLockerChamber chamber in labApiLocker.Chambers)
        {
            if (i > Chambers.Count - 1)
                break;

            chamber.AcceptableItems = Chambers[i].AcceptableItems.ToArray();
            chamber.RequiredPermissions = Chambers[i].RequiredPermissions;
            i++;
        }