DARE (Danny's Awesome Rendering Engine) | Graphics Programming | Page 2

devout mesa Jul 14, 2023, 9:52 PM

#

Right

#

Do you know what srcPipelineStage and dstPipelineStage do (in any barrier)

dawn wave Jul 15, 2023, 5:26 AM

#

Ehhh not entirely,,,

#

I believe srcPipelineStage tells vulkan that src needs to be finished executing first before dst can continue?

devout mesa Jul 15, 2023, 3:28 PM

#

yes

#

To be more formal src is the "first sync scope" and dst is the "second sync scope"

#

#2 cannot continue if #1 hasn't finished

dawn wave Jul 15, 2023, 3:31 PM

#

And I assume every command is "scoped" underneath a certain sync

tropic vigil Jul 15, 2023, 3:31 PM

#

https://themaister.net/blog/2019/08/14/yet-another-blog-explaining-vulkan-synchronization/

Maister's Graphics Adventures

themaister

Yet another blog explaining Vulkan synchronization

dawn wave Jul 15, 2023, 3:31 PM

#

so transfer commands like copy and scoped under transfer

tropic vigil Jul 15, 2023, 3:31 PM

#

10/10 resource

devout mesa Jul 15, 2023, 3:31 PM

#

dawn wave so transfer commands like copy and scoped under transfer

yes

#

go read that if you haven't already yes

#

slipped my mind bleakekw

dawn wave Jul 15, 2023, 3:31 PM

#

i will KEKW

dawn wave Jul 15, 2023, 4:05 PM

#

i am starting to regret making my entire asset system use hashmaps

#

descriptor indexing bleakekw

dawn wave Jul 16, 2023, 12:06 AM

#

so uh

#

how would you bind multiple samplers in a shader?

devout mesa Jul 16, 2023, 12:07 AM

#

do you want samplers only or combined image samplers

dawn wave Jul 16, 2023, 12:07 AM

#

image + samplers

devout mesa Jul 16, 2023, 12:08 AM

#

you make a VkWriteDesc... with a lot of ImageInfos that contain imageViews and samplers

dawn wave Jul 16, 2023, 12:08 AM

#

huston we got a problem then

#

bleakekw

devout mesa Jul 16, 2023, 12:09 AM

#

roger, what is the issue capt

dawn wave Jul 16, 2023, 12:09 AM

#

.bind_sampled_image_array(2, 1, images.as_slice(), sampler.as_ref())

As we can observe

#

phobos only lets you send 1 sampler

devout mesa Jul 16, 2023, 12:10 AM

#

epic

#

Well it's good enough for now

#

Just bind the "default sampler"

dawn wave Jul 16, 2023, 12:12 AM

#

kekw ok

dawn wave Jul 16, 2023, 12:31 AM

#

fellas
should i submit my material information i.e. albedo texture index in the descriptor

#

with my object descriptor storage buffer which is sent to my shader

#

or should i make it seperate from my object struct?

#

/// Describes the object's bda buffers and materials
struct ObjectDescription {
    // 0 - None
    uint64_t vertex_buffer;
    uint64_t index_buffer;
    uint64_t normal_buffer;
    uint64_t tex_buffer;
    uint64_t material;
};

Material refers to another buffer's index which the material information is stored in

#

or I could do:

/// Describes the object's bda buffers and materials
struct ObjectDescription {
    // 0 - None
    uint64_t vertex_buffer;
    uint64_t index_buffer;
    uint64_t normal_buffer;
    uint64_t tex_buffer;
    MaterialDescription material;
};

#

frog_think

devout mesa Jul 16, 2023, 12:33 AM

#

whichever is easier

dawn wave Jul 16, 2023, 12:34 AM

#

im gonna pick the indexing cuz overengineer to save a grand total of 32 extra bytes KEKW

dawn wave Jul 16, 2023, 7:04 PM

#

praying that this works

#

my cpu the moment i open up the project: 🗣️ 🗣️

#

I'm not tripping this is correct yeah?

layout(set = 1, binding = 3) uniform sampler2D texture_samplers[];

devout mesa Jul 16, 2023, 7:06 PM

#

is it the last binding in the set

#

if so, yes

dawn wave Jul 16, 2023, 7:06 PM

#

yeah it is

#

layout(set = 1, binding = 1, scalar) buffer ObjectDescription_ {
    ObjectDescription i[];
} ObjectDescriptionArray;
layout (set = 1, binding = 2) buffer MaterialDescripton_ {
    MaterialDescription m[];
} MaterialDescriptionArray;
layout(set = 1, binding = 3) uniform sampler2D texture_samplers[];

devout mesa Jul 16, 2023, 7:08 PM

#

I'm still waiting for textures

dawn wave Jul 16, 2023, 7:09 PM

#

KEKW its coming slowly

devout mesa Jul 16, 2023, 7:09 PM

#

I can't wait faster

#

but you can make it quiccer

#

get a move on soldier

dawn wave Jul 16, 2023, 7:09 PM

#

okok

dawn wave Jul 16, 2023, 8:03 PM

#

it broke

#

no worky

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 (-1791811812): Validation Error: [ VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 ] Object 0: handle = 0x1f7bc6e4960, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x95331f1c | vkCreateDescriptorSetLayout(): pBindings[2] can't have VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT for VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER since descriptorBindingPartiallyBound is not enabled. The Vulkan spec states: If VkPhysicalDeviceDescriptorIndexingFeatures::descriptorBindingPartiallyBound is not enabled, all elements of pBindingFlags must not include VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013)

#

wtf

#

ah shader crash

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 (-1791811812): Validation Error: [ VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 ] Object 0: handle = 0x1f591e864b0, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x95331f1c | vkCreateDescriptorSetLayout(): pBindings[0] can't have VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT for VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER since descriptorBindingPartiallyBound is not enabled. The Vulkan spec states: If VkPhysicalDeviceDescriptorIndexingFeatures::descriptorBindingPartiallyBound is not enabled, all elements of pBindingFlags must not include VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013)

#

what

#

@tropic vigil Is this a phobos issue?

#

Seems like it is complaining about a descriptor flag not being on?

tropic vigil Jul 16, 2023, 8:09 PM

#

oh

#

looks like we missing a feature flag

dawn wave Jul 16, 2023, 8:09 PM

#

oh kekw

tropic vigil Jul 16, 2023, 8:09 PM

#

ill fix that real quick

dawn wave Jul 16, 2023, 8:09 PM

#

KEKW we need testing

tropic vigil Jul 16, 2023, 8:10 PM

#

yeah ill spend some time on it

dawn wave Jul 16, 2023, 8:10 PM

#

ill see if i can add some more examples for phobos for testing

#

toy renderer like how vuk has iirc

tropic vigil Jul 16, 2023, 8:12 PM

#

pushed on latest

dawn wave Jul 16, 2023, 8:33 PM

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 (-1791811812): Validation Error: [ VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 ] Object 0: handle = 0x1fa9a4f6ca0, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x95331f1c | vkCreateDescriptorSetLayout(): pBindings[1] can't have VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT for VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER since descriptorBindingPartiallyBound is not enabled. The Vulkan spec states: If VkPhysicalDeviceDescriptorIndexingFeatures::descriptorBindingPartiallyBound is not enabled, all elements of pBindingFlags must not include VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT (https://vulkan.lunarg.com/doc/view/1.3.25

#

@tropic vigil I think I found more bugs im not 100% sure however

tropic vigil Jul 16, 2023, 8:34 PM

#

nervous

#

wat

#

i thought i enabled the feature

#

are you on the latest commit

#

is that the only message

dawn wave Jul 16, 2023, 8:35 PM

#

yes i am

phobos = { git = "https://github.com/NotAPenguin0/phobos-rs", rev = "99e0b9a" }

#

there is some more

tropic vigil Jul 16, 2023, 8:35 PM

#

thats not latest

#

i pushed a fix for that error

dawn wave Jul 16, 2023, 8:35 PM

#

oh fuck i used the parent bleakekw

#

nah the same error appears still

#

phobos = { git = "https://github.com/NotAPenguin0/phobos-rs", rev = "f698449" }

#

I think this is me then

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkShaderModuleCreateInfo-pCode-08740 (115483881): Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] Object 0: handle = 0x227fb67f850, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6e224e9 | vkCreateShaderModule(): The SPIR-V Capability (RuntimeDescriptorArray) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pname:codeType is ename:VK_SHADER_CODE_TYPE_SPIRV_EXT, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740)
 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkShaderModuleCreateInfo-pCode-08740 (115483881): Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] Object 0: handle = 0x227fb67f850, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6e224e9 | vkCreateShaderModule(): The SPIR-V Capability (SampledImageArrayNonUniformIndexing) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pname:codeType is ename:VK_SHADER_CODE_TYPE_SPIRV_EXT, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740)

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-vkResetFences-pFences-01123 (1755645774): Validation Error: [ VUID-vkResetFences-pFences-01123 ] Object 0: handle = 0xd5b26f0000000010, type = VK_OBJECT_TYPE_FENCE; | MessageID = 0x68a5074e | VkFence 0xd5b26f0000000010[] is in use. The Vulkan spec states: Each element of pFences must not be currently associated with any queue command that has not yet completed execution on that queue (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-vkResetFences-pFences-01123)

devout mesa Jul 16, 2023, 8:37 PM

#

Nah, most definitely Penguin's fault

tropic vigil Jul 16, 2023, 8:37 PM

#

definitely my fault but probably an easy fix

devout mesa Jul 16, 2023, 8:37 PM

#

Ight this is you though KEKW

tropic vigil Jul 16, 2023, 8:37 PM

#

its just missing feature flags

dawn wave Jul 16, 2023, 8:38 PM

#

hmm ill check on my end then

tropic vigil Jul 16, 2023, 8:38 PM

#

ah runtime descriptor array

dawn wave Jul 16, 2023, 8:38 PM

#

oh KEKW

tropic vigil Jul 16, 2023, 8:38 PM

#

no that last one is caused by the first errors

#

pushed

dawn wave Jul 16, 2023, 8:39 PM

#

praige

#

cope

#

it didn't

#

ERROR phobos::core::debug             > [VALIDATION]: VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 (-1791811812): Validation Error: [ VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013 ] Object 0: handle = 0x17b6ea3b0e0, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x95331f1c | vkCreateDescriptorSetLayout(): pBindings[0] can't have VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT for VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER since descriptorBindingPartiallyBound is not enabled. The Vulkan spec states: If VkPhysicalDeviceDescriptorIndexingFeatures::descriptorBindingPartiallyBound is not enabled, all elements of pBindingFlags must not include VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkDescriptorSetLayoutBindingFlagsCreateInfo-descriptorBindingPartiallyBound-03013)
 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkShaderModuleCreateInfo-pCode-08740 (115483881): Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] Object 0: handle = 0x17b6ea3b0e0, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6e224e9 | vkCreateShaderModule(): The SPIR-V Capability (RuntimeDescriptorArray) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pname:codeType is ename:VK_SHADER_CODE_TYPE_SPIRV_EXT, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740)

#

phobos = { git = "https://github.com/NotAPenguin0/phobos-rs", rev = "3ec955e" }

devout mesa Jul 16, 2023, 8:40 PM

#

Penguin forgor features for bindless 💀

tropic vigil Jul 16, 2023, 8:40 PM

#

wat

#

i enabled partially bound

dawn wave Jul 16, 2023, 8:40 PM

#

tf then

tropic vigil Jul 16, 2023, 8:40 PM

#

guess ill read the spec

#

hold on

dawn wave Jul 16, 2023, 8:40 PM

#

ERROR phobos::core::debug             > [VALIDATION]: VUID-VkShaderModuleCreateInfo-pCode-08740 (115483881): Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] Object 0: handle = 0x1e76e8312e0, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6e224e9 | vkCreateShaderModule(): The SPIR-V Capability (SampledImageArrayNonUniformIndexing) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pname:codeType is ename:VK_SHADER_CODE_TYPE_SPIRV_EXT, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740)
 ERROR phobos::core::debug             > [VALIDATION]: VUID-vkResetFences-pFences-01123 (1755645774): Validation Error: [ VUID-vkResetFences-pFences-01123 ] Object 0: handle = 0xd5b26f0000000010, type = VK_OBJECT_TYPE_FENCE; | MessageID = 0x68a5074e | VkFence 0xd5b26f0000000010[] is in use. The Vulkan spec states: Each element of pFences must not be currently associated with any queue command that has not yet completed execution on that queue (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-vkResetFences-pFences-01123)

#

could be me however and vulkan is doing vulkan things again

tropic vigil Jul 16, 2023, 8:41 PM

#

no

#

its just missing feature flags

dawn wave Jul 16, 2023, 8:42 PM

#

ping me if there is a fix / update

tropic vigil Jul 16, 2023, 8:43 PM

#

ok

#

this time

#

@dawn wave

#

i think i really fixed it

#

i was putting the feature flags in the extension struct instead of in the vk 1.2 features struct

dawn wave Jul 16, 2023, 8:44 PM

#

phobos = { git = "https://github.com/NotAPenguin0/phobos-rs", rev = "87049b7" }

#

it's fixed

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-vkResetFences-pFences-01123 (1755645774): Validation Error: [ VUID-vkResetFences-pFences-01123 ] Object 0: handle = 0xd5b26f0000000010, type = VK_OBJECT_TYPE_FENCE; | MessageID = 0x68a5074e | VkFence 0xd5b26f0000000010[] is in use. The Vulkan spec states: Each element of pFences must not be currently associated with any queue command that has not yet completed execution on that queue (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-vkResetFences-pFences-01123)
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: The logical device has been lost. See <https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#devsandqueues-lost-device>

#

but mine borked KEKW

#

shader crash

#

but phobos fixed i think

tropic vigil Jul 16, 2023, 8:46 PM

#

thats definitely on your end yeah bleakekw

dawn wave Jul 16, 2023, 8:48 PM

#

I LOVE DEBUGGING SHADERS

#

(they do not give me a crash log whatsoever)

#

is there a way to get shaders to like output crashes?

#

Hmm am I doing wrong...

tropic vigil Jul 16, 2023, 8:49 PM

#

probably accessing out of bounds

devout mesa Jul 16, 2023, 8:49 PM

#

Aftermath

#

But ye

#

OOB 99%

dawn wave Jul 16, 2023, 8:50 PM

#

payload.hit_value = texture(texture_samplers[nonuniformEXT(0)], tex_coord).rgb;

bleakekw

#

it's odd as it's reporting that i have at least one image being sent in

#

uhh how do you use nsight aftermath

#

like download?

devout mesa Jul 16, 2023, 8:55 PM

#

I dunno if there is a rust ver

dawn wave Jul 16, 2023, 8:55 PM

#

oh.

devout mesa Jul 16, 2023, 8:55 PM

#

It's C++

dawn wave Jul 16, 2023, 8:55 PM

#

OHH

devout mesa Jul 16, 2023, 8:56 PM

#

c++ once again wins

dawn wave Jul 16, 2023, 8:56 PM

#

that makes sense now

#

Segfaulting 🗣️

tropic vigil Jul 16, 2023, 8:56 PM

#

aftermath works fine with rust

#

its gpu only

dawn wave Jul 16, 2023, 8:56 PM

#

I'm a bit too braindead rn to get it set up KEKW

#

I have a question

#

when submitting images yeah

#

if I only submit one to be bindlessly binded

#

I assume it's index is zero yeah?

devout mesa Jul 16, 2023, 8:59 PM

#

yes

dawn wave Jul 16, 2023, 8:59 PM

#

KEKW then something is going wrong

#

i figured it out

#

i forgot to add tex coordinates

#

stroke of genius if you will

#

ah i solved it

#

yeah tex buffer

#

how you would you uh generate them...?

devout mesa Jul 16, 2023, 9:10 PM

#

you don't

#

uv mapping is done by the artist

dawn wave Jul 16, 2023, 9:10 PM

#

tf why doesn't it exist 💀

#

texcoords work

#

ok

#

IT

#

FUCK8ING

#

WORKS

#

LES

#

LETS

#

FUCKING GOOOOOOOOOOOOOOO

#

#

RAHHHHHHHHHHHHHHHHHHHHHHHHHHH

devout mesa Jul 16, 2023, 9:12 PM

#

now render sponza

dawn wave Jul 16, 2023, 9:12 PM

#

I CAN FEEL IT 🗣️ THE TEXTURES 🦅

#

oh

#

KEKW

#

will try

devout mesa Jul 16, 2023, 9:12 PM

#

no

#

wrong

#

you will succeed.

#

For my entertainment

dawn wave Jul 16, 2023, 9:14 PM

#

material binding works

#

lets blindly scale it to sponza i totally will not regret this decision

#

wait deccer

#

deccer borked

devout mesa Jul 16, 2023, 9:18 PM

#

I failed to understand you meant "deccer cubes" for 2 minutes straight

#

I thought: "he's finally lost it"

dawn wave Jul 16, 2023, 9:18 PM

#

KEKW

#

tf is the gltf default samplers bleakekw

devout mesa Jul 16, 2023, 9:19 PM

#

mate

#

again

#

Just use a single sampler

dawn wave Jul 16, 2023, 9:19 PM

#

ill make one up then

devout mesa Jul 16, 2023, 9:19 PM

#

With linear filtering, linear mip transitions and repeat

#

I assure you that's all you're going to need for 99.9% of models out there

dawn wave Jul 16, 2023, 9:28 PM

#

ohh nooo

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkWriteDescriptorSet-descriptorCount-arraylength (286023833): Validation Error: [ VUID-VkWriteDescriptorSet-descriptorCount-arraylength ] Object 0: handle = 0x22c5b593260, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x110c6099 | vkUpdateDescriptorSets: parameter pDescriptorWrites[2].descriptorCount must be greater than 0. The Vulkan spec states: descriptorCount must be greater than 0 (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-VkWriteDescriptorSet-descriptorCount-arraylength)

#

Fuck this isn't good

#

It means I'll have to always have some dummy texture

#

Is there a way to avoid this?

devout mesa Jul 16, 2023, 9:29 PM

#

Yes

#

Do not write if you have no textures

dawn wave Jul 16, 2023, 9:29 PM

#

But wouldn't that cause the shader to complain then if there is no binding

devout mesa Jul 16, 2023, 9:30 PM

#

No

dawn wave Jul 16, 2023, 9:30 PM

#

wa

devout mesa Jul 16, 2023, 9:30 PM

#

That's what PARTIALLY_BOUND is for

dawn wave Jul 16, 2023, 9:30 PM

#

holy shit

#

thank you

#

literal savior fr

#

bleakekw it's black

#

this bleak brother

#

what it's all black because my tlas broke

#

deccer's cubes once again

devout mesa Jul 16, 2023, 9:36 PM

#

Cubicles are too powerful

dawn wave Jul 16, 2023, 9:37 PM

#

ah is it because they're instanced?

#

yes

#

that is why

#

KEKW

#

#

only one cube

#

:(

#

what

#

it is processing it as only one mesh

devout mesa Jul 16, 2023, 9:48 PM

#

btw I made deccer cubes more powerful

#

would you like to try

dawn wave Jul 16, 2023, 9:48 PM

#

oh no

#

ok

eager chasm Jul 16, 2023, 9:48 PM

#

ah : >

devout mesa Jul 16, 2023, 9:48 PM

#

It's about uh

#

input: 19 mesh primitives (22413312 triangles, 44297721 vertices); 19 draw calls (19 instances, 22413312 triangles)

#

Yeah 22 million triangles

#

no big deal

eager chasm Jul 16, 2023, 9:48 PM

#

you should report this to #926896734284689428 😛 (the failed purple cube)

dawn wave Jul 16, 2023, 9:48 PM

#

bleakekw i havent optimized my asset importing

#

its slow as hell

#

i need to optimize that

#

ok lets think

eager chasm Jul 16, 2023, 9:51 PM

#

your mom is slow as hell

dawn wave Jul 16, 2023, 9:51 PM

#

KEKW

eager chasm Jul 16, 2023, 9:51 PM

#

jk 🙂 but i couldnt resist

dawn wave Jul 16, 2023, 9:52 PM

#

this is some wizardry i'm so unaware about

#

Found 1 meshes on layer 1
Found 1 meshes on layer 2
Found 1 meshes on layer 2
Found 1 meshes on layer 2
Found 1 meshes on layer 2
[gltf]: Scene has 1 meshes

#

gltf is saying it has somehow compressed my 5 meshes into 1

#

this is magical

eager chasm Jul 16, 2023, 9:52 PM

#

: )

devout mesa Jul 16, 2023, 9:53 PM

#

To handle instancing correctly you should do something like this

dawn wave Jul 16, 2023, 9:53 PM

#

oh wait .append

#

oh my god

#

it makes sense now

devout mesa Jul 16, 2023, 9:56 PM

#

HashMap<gltf_primitive, mesh_data> primitives;
for (mesh in gltf.meshes) {
    for primitive in mesh.primitives {
        primitives[mesh] = load(mesh);
    }
}
for (node in gltf.nodes) {
    mesh = node.mesh;
    for (primitive in mesh.primitives) {
        data = primitives[primitive];
        transform = node.transform;
        // put this thing into your scene or something
    }
}```

dawn wave Jul 16, 2023, 9:56 PM

#

i wish i could hash meshes KEKW rn I'm just recursively iterating through the scene

#

collecting all meshes used

#

oh

#

now i understand why you do it like that

#

KEKW

devout mesa Jul 16, 2023, 9:57 PM

#

One node can reference multiple meshes

dawn wave Jul 16, 2023, 9:57 PM

#

yes i realized

devout mesa Jul 16, 2023, 9:57 PM

#

And multiple meshes can reference the same primitives

#

Or different even

dawn wave Jul 16, 2023, 9:57 PM

#

how would you propogate those transformations however?

#

as a node could parent another one

#

and you still need to account for that transformation

devout mesa Jul 16, 2023, 9:58 PM

#

You traverse the node path up to the root

#

and mul transforms

dawn wave Jul 16, 2023, 9:58 PM

#

ohh

#

you can access the parent

#

okok

#

i think that makes sense

devout mesa Jul 16, 2023, 9:59 PM

#

I just use cgltf_node_transform_world which does it for me though bleakekw

dawn wave Jul 16, 2023, 9:59 PM

#

C++ once again wins

#

huh i may need to rewrite it again

#

damn that is annoying

#

as it's gonna be 2000% more efficient to just make a scene tree with handles to the meshes

#

rather than cloning the same mesh

#

nah fuck it

#

im gonna clone it

#

#

this doesn't look right

#

KEKW

eager chasm Jul 16, 2023, 10:13 PM

#

geometry looks right it seems

dawn wave Jul 16, 2023, 10:13 PM

#

yeah textures are wacked

#

it seems to be randomly selecting the textures

eager chasm Jul 16, 2023, 10:15 PM

#

hehe

#

deccer-cubes-randomly-texturized.gltf

dawn wave Jul 16, 2023, 10:17 PM

#

oh

#

wait no way

#

why is it all using the same

#

material

#

KEKW

#

oh my bleakekw

#

i solved it

#

why the fuck was i indexing my material array using my the index of my mesh

#

#

i am still geitng randomized textures

eager chasm Jul 16, 2023, 10:29 PM

#

does it flicker?

dawn wave Jul 16, 2023, 10:29 PM

#

no it literally for some reason

#

is randomly selecting textures

#

this is an issue with my asset loader

#

what if i made this a feature

#

probablistic renderer. there is a 0.00001% chance your render will be correct :D

eager chasm Jul 16, 2023, 10:31 PM

#

😄

dawn wave Jul 16, 2023, 10:59 PM

#

this is actually dialobical

#

if not magical

#

how???

#

it is randomly selecting my textures

eager chasm Jul 16, 2023, 10:59 PM

#

most likely stupitidy

dawn wave Jul 16, 2023, 10:59 PM

#

it is most likely KEKW

eager chasm Jul 16, 2023, 10:59 PM

#

and absolute pebkacism

#

i am victim of the 2 on a frequent basis

dawn wave Jul 16, 2023, 10:59 PM

#

I was able to get it order it so now I can get consistent erorrs 😎

#

i-

#

no way

#

one step closer

#

fixed a casting issue

#

#

one step closer

#

int -> i32

#

vec3 -> [f32; 3]

#

i think that is correct

#

the purple bar work

#

purple bar :)

eager chasm Jul 16, 2023, 11:10 PM

#

go purple bar go 😄

dawn wave Jul 16, 2023, 11:11 PM

#

huh funny seems like my lookup table is f'd

#

this is actually joever

#

that wasn't it

eager chasm Jul 16, 2023, 11:21 PM

#

joever who?

dawn wave Jul 16, 2023, 11:21 PM

#

we aren't coming back from this bug

feral trellis Jul 16, 2023, 11:22 PM

#

eager chasm joever who?

ligma balls

dawn wave Jul 16, 2023, 11:22 PM

#

/// Describes the material properties of the object
struct MaterialDescription {
    // -1 - None
    int albedo_texture;
    vec3 albedo;
};

/// Describes the object's bda buffers and materials
struct ObjectDescription {
    // 0 - None
    uint64_t vertex_buffer;
    uint64_t index_buffer;
    uint64_t normal_buffer;
    uint64_t tex_buffer;
    int material;
};

#

#[repr(C)]
#[derive(Clone, Copy)]
pub struct CMesh {
    pub vertex_buffer: u64,
    pub index_buffer: u64,
    pub normal_buffer: u64,
    pub tex_buffer: u64,
    pub material: i32,
}

#

/// Version of material but for C
#[repr(C)]
#[derive(Copy, Clone)]
pub struct CMaterial {
    pub albedo_texture: i32,
    pub albedo_color: [f32; 3],
}

#

what am i doing wrong

#

is it the albedo_color?

#

is that it

#

is that the root cause?

#

is that why?

devout mesa Jul 16, 2023, 11:24 PM

#

Just a small warning

#

padding

#

Although I am not confident in that

#

Actually, it could never be that

#

no idea bleakekw

dawn wave Jul 16, 2023, 11:26 PM

#

im gonna smash my face into a wall bro

devout mesa Jul 16, 2023, 11:26 PM

#

Do you use scalar layout on everything

dawn wave Jul 16, 2023, 11:26 PM

#

OH MY FUCKING GOD

#

that didn't fix it

#

KEKW

devout mesa Jul 16, 2023, 11:27 PM

#

bruv

dawn wave Jul 16, 2023, 11:27 PM

#

layout(location = 0) rayPayloadInEXT Payload payload;

layout(buffer_reference, scalar) buffer Vertices { vec3 v[]; }; // Vertices
layout(buffer_reference, scalar) buffer Normals { vec3 v[]; }; // Normals
layout(buffer_reference, scalar) buffer TexCoords { vec2 v[]; }; // TexCoords
layout(buffer_reference, scalar) buffer Indices {ivec3 i[]; }; // Triangle indices


layout(set = 1, binding = 1, scalar) buffer ObjectDescription_ {
    ObjectDescription i[];
} ObjectDescriptionArray;
layout (set = 1, binding = 2, scalar) buffer MaterialDthatescripton_ {
    MaterialDescription m[];
} MaterialDescriptionArray;
layout(set = 1, binding = 3) uniform sampler2D texture_samplers[];

#

do samplers need scalar as well?

devout mesa Jul 16, 2023, 11:27 PM

#

no you can't do scalar on that

#

Just try hardcoding 0 in your material data

#

see if it werks

dawn wave Jul 16, 2023, 11:28 PM

#

that works

#

i can do 0-4

#

aka # of textures

devout mesa Jul 16, 2023, 11:28 PM

#

I gotta clarify

#

not in your shaders

#

in your rust code

dawn wave Jul 16, 2023, 11:29 PM

#

ah sure

#

heh

#

#

hard set it at 4

#

this is whati got

devout mesa Jul 16, 2023, 11:30 PM

#

Well

#

there's your problem

#

check GPU side buffers with Nsight

#

Imma go schlepp now

#

good luck soldier

dawn wave Jul 16, 2023, 11:30 PM

#

🫡

#

seems like

#

0 works

#

1-4 borks

#

and it is always the same two meshes

#

the ones i shown in that pictures

#

while i woild love to chekc my buffers i have zero clue how to KEKW as they're buffer views so i can't even attach a name

eager chasm Jul 16, 2023, 11:32 PM

#

renderdoc time

dawn wave Jul 16, 2023, 11:32 PM

#

i wish renderdoc doesn't work with rt extensions

#

oh

#

it works

#

i uh

#

KEKW

#

i forgot to reflect my struct changes

#

KEKW

#

eager chasm Jul 16, 2023, 11:34 PM

#

face

dawn wave Jul 16, 2023, 11:35 PM

#

okay now to figure out issue

#

So

#

vec3 yeah

#

[f32; 3]

#

Why can't I just send that to glsl as a vec3?

#

oh i can

#

what broke then???

#

if i pretend the issue doesn't exist

#

then it doesn't 😎

devout mesa Jul 16, 2023, 11:40 PM

#

do sponza

#

before I enter uncontrolled schlepp

dawn wave Jul 16, 2023, 11:41 PM

#

bro my assset loader

#

is the most unoptimized steaming pile of crap

eager chasm Jul 16, 2023, 11:41 PM

#

no excuses

dawn wave Jul 16, 2023, 11:41 PM

#

KEKW

#

it will take hours

devout mesa Jul 16, 2023, 11:41 PM

#

it's 103 nodes

#

there is no way

dawn wave Jul 16, 2023, 11:41 PM

#

yes way

devout mesa Jul 16, 2023, 11:41 PM

#

???

dawn wave Jul 16, 2023, 11:42 PM

#

you don't understand how unoptimized it is

#

KEKW

devout mesa Jul 16, 2023, 11:42 PM

#

It doesn't matter how unoptimized it is

#

I think it's physically impossible to not be able to load sponza

#

even if you iterated over every single triangle jn sponza 10 times over

dawn wave Jul 16, 2023, 11:43 PM

#

it takes a good 10 seconds for me to load in the helmet

devout mesa Jul 16, 2023, 11:43 PM

#

what

dawn wave Jul 16, 2023, 11:43 PM

#

yea

devout mesa Jul 16, 2023, 11:43 PM

#

sorry can you show me this code

#

I have to see for myself

dawn wave Jul 16, 2023, 11:43 PM

#

KEKW

#

sure

#

its a mess too

#

https://github.com/DannyLeWasTaken/DARE/blob/master/src/asset/gltf_asset_loader.rs

GitHub

DARE/src/asset/gltf_asset_loader.rs at master · DannyLeWasTaken/DARE

Danny's Awesome Rendering Engine. Contribute to DannyLeWasTaken/DARE development by creating an account on GitHub.

#

wait wrong branch @devout mesa

#

fn convert_data_type(

#

https://github.com/DannyLeWasTaken/DARE/blob/0a0a5c31ed984fdd76f4da82d965e13b78b90f56/src/asset/gltf_asset_loader.rs#L1149C1-L1149C22

GitHub

DARE/src/asset/gltf_asset_loader.rs at 0a0a5c31ed984fdd76f4da82d965...

Danny's Awesome Rendering Engine. Contribute to DannyLeWasTaken/DARE development by creating an account on GitHub.

#

here it is

devout mesa Jul 16, 2023, 11:47 PM

#

I am impressed

dawn wave Jul 16, 2023, 11:48 PM

#

yeah me too

#

i wrote this i think during an all nighter

#

im just trying to get textures to work

#

before it refactor the living shit out of this

devout mesa Jul 16, 2023, 11:48 PM

#

Well

#

I'll now take you a bit off road

#

You have textures for deccer cubes loaded yes?

dawn wave Jul 16, 2023, 11:49 PM

#

yes

#

the loading textures ain't the issue it's the attributes

devout mesa Jul 16, 2023, 11:49 PM

#

What happens when you get far away

dawn wave Jul 16, 2023, 11:49 PM

#

aliasing

devout mesa Jul 16, 2023, 11:50 PM

#

something else happens, related to textures

dawn wave Jul 16, 2023, 11:50 PM

#

uhhh idfk mipmap issues?

devout mesa Jul 16, 2023, 11:50 PM

#

yes, you see moiré patterns all over the place right?

dawn wave Jul 16, 2023, 11:50 PM

#

yeah

devout mesa Jul 16, 2023, 11:50 PM

#

How do you fix this

dawn wave Jul 16, 2023, 11:51 PM

#

you don- mipmaps

devout mesa Jul 16, 2023, 11:51 PM

#

You already do mipmaps don't you?

dawn wave Jul 16, 2023, 11:51 PM

#

yeah i just havent enabled them

devout mesa Jul 16, 2023, 11:51 PM

#

try enabling them

#

see if the issue goes away

dawn wave Jul 16, 2023, 11:52 PM

#

i will but it's buggy rn and i need to get textures 101 working

devout mesa Jul 16, 2023, 11:52 PM

#

rip

dawn wave Jul 16, 2023, 11:52 PM

#

well not buggy, just untested

devout mesa Jul 16, 2023, 11:52 PM

#

then we'll do this tomorrow

eager chasm Jul 16, 2023, 11:53 PM

#

all the jibberjabber, where is the screenshot!

dawn wave Jul 16, 2023, 11:53 PM

#

eager chasm Jul 16, 2023, 11:53 PM

#

ah it werks

dawn wave Jul 16, 2023, 11:54 PM

#

it fixed itself

eager chasm Jul 16, 2023, 11:54 PM

#

is that lustri's version?

dawn wave Jul 16, 2023, 11:54 PM

#

hmm i just pulled it straight from the repo

#

dont tell me its wrong bleakekw

eager chasm Jul 16, 2023, 11:55 PM

#

lustri is distributing his in #926896734284689428

devout mesa Jul 16, 2023, 11:55 PM

#

it's not

#

I made a special version though 🙂

eager chasm Jul 16, 2023, 11:55 PM

#

erm you made me forget abuot, that L asked for sponza 😄

#

where is sponza 😄

devout mesa Jul 16, 2023, 11:56 PM

#

the special sponza?

dawn wave Jul 16, 2023, 11:56 PM

#

i found bugs KEKW sponza is soon(tm)

eager chasm Jul 16, 2023, 11:56 PM

#

alright you have 18hrs

dawn wave Jul 16, 2023, 11:56 PM

#

KEKW

#

keep bugging

eager chasm Jul 16, 2023, 11:56 PM

#

!remind me 18 hr to bug danny and sponza

dawn wave Jul 16, 2023, 11:56 PM

#

please dont remind

#

LETS GOOOO

eager chasm Jul 16, 2023, 11:57 PM

#

!remind 18 hr to bug danny and sponza

hollow barnBOT Jul 16, 2023, 11:57 PM

#

Alright deccer, I'll remind you about to bug danny and sponza in 18 hours. ID: 59145700

devout mesa Jul 16, 2023, 11:57 PM

#

https://drive.google.com/file/d/1szaZTtSy3IHWrrx84XNjFFMMWnj4Zkz0/view?usp=sharing

Google Docs

sponza_hp.zip

dawn wave Jul 16, 2023, 11:57 PM

#

noooo

eager chasm Jul 16, 2023, 11:57 PM

#

clock is ticking

#

https://tenor.com/view/hitmans-bodyguard-hitmans-bodyguard-gi-fs-samuel-l-jackson-time-tick-tock-gif-8352665

Tenor

Tick tock muthafucka!

▶ Play video

dawn wave Jul 16, 2023, 11:57 PM

#

end times are upon us

eager chasm Jul 16, 2023, 11:57 PM

#

hehe, gn8

dawn wave Jul 16, 2023, 11:58 PM

#

🫡

devout mesa Jul 16, 2023, 11:58 PM

#

who needed special sponza again?

#

ah danny

eager chasm Jul 16, 2023, 11:58 PM

#

danny after he made sponza work

devout mesa Jul 16, 2023, 11:58 PM

#

yes try also special sponza

#

it's good for your gpu

#

trust

#

KEKW

dawn wave Jul 17, 2023, 12:00 AM

#

#

rip my cpu

#

it will spend the next 10,000 years

#

stuck in eternal computation

#

i figured out why

#

turns out printing each vertex is not a good idea of perforamnce KEKW

#

this is concerngin

#

```thread 'main' panicked at 'Unable to allocate scratch buffer: Vulkan allocation error: `Out of memory````

#

is there an upper limit for scratch memory?

#

if so i'm moving it all into bdas bleakekw

dawn wave Jul 17, 2023, 12:25 AM

#

i know nothing but pain suffering

#

let mut object_description_sratch_buffer = ifc
                    .allocate_scratch_buffer(
                        (self.acceleration_structure.addresses.len()
                            * std::mem::size_of::<asset::CMesh>())
                            as vk::DeviceSize,
                    )
                    .expect("Unable to allocate mesh scratch buffer"); // lmao

#

what about this

#

lacks memory

#

wtfff

#

thread 'main' panicked at 'Unable to allocate mesh scratch buffer: Vulkan allocation error: `Out of memory`

#

I geniunely do not know why

#

is there an upper limit to this amount of memory? For me iirc it was saying I was only using 600 bytes amount of memory

#

@tropic vigil pinging as you probably know

#

panic

#

if i can't solve this

#

i will be beaten brutally by deccer

dawn wave Jul 17, 2023, 12:59 AM

#

fuck it

#

we're making a buffer

dawn wave Jul 17, 2023, 1:23 AM

#

we're so fucking not

#

i actually do not know how to deal with this error. I'm gonna assume for some odd reason scratch memory is really small

#

KEKW

dawn wave Jul 17, 2023, 2:41 AM

#

i gvie up

#

i surrender

#

i cannot figure this scratch error for the love of my life

#

how the hell is 600 bytes causing an out of memory error

dawn wave Jul 17, 2023, 3:24 AM

#

Hmmm is the reason for the out of memory error is because I'm only supposed to create only one scratch?

let mut object_description_sratch_buffer = ifc
                    .allocate_scratch_buffer(
                        (self.acceleration_structure.addresses.len()
                            * std::mem::size_of::<asset::CMesh>())
                            as vk::DeviceSize,
                    )
                    .expect("Unable to allocate mesh scratch buffer"); // lmao
                let mut material_descriptor_scratch_buffer = ifc
                    .allocate_scratch_buffer(
                        (scene_read.materials.len() * std::mem::size_of::<asset::CMaterial>())
                            as vk::DeviceSize,
                    )
                    .expect("Unable to allocate material scratch buffer");

tropic vigil Jul 17, 2023, 6:31 AM

#

Lemme see

tropic vigil Jul 17, 2023, 6:32 AM

#

dawn wave is there an upper limit for scratch memory?

Yes, it’s given on context creation

#

The default is 1 byte (effectively zero) so you probably need to set it

dawn wave Jul 17, 2023, 6:33 AM

#

OHHHH

#

it;s that 1024 * xx * xx thing

#

Oml

#

I think I’ll use bdas instead.

#

Oh wait I can just make ssbos nvm

tropic vigil Jul 17, 2023, 6:34 AM

#

You can create many scratch buffers though, as long as you have memory

#

Scratch mem is good for this, you can still use BDA to bind it

#

But since you update it every frame using scratch mem will handle the double buffering for you

dawn wave Jul 17, 2023, 6:34 AM

#

Hmmm true

#

My only issue is that

#

Wasted space

tropic vigil Jul 17, 2023, 6:35 AM

#

Why wasted

#

It reuses a lot of memory behind the scenes

dawn wave Jul 17, 2023, 6:35 AM

#

Oh I assumed the 1024 * xx * xx is pre-allocated space, no?

tropic vigil Jul 17, 2023, 6:35 AM

#

Well, that is allocated for each scratch allocator

#

But those are created and cached on demand

#

So “best” case you only have two alive

#

Its not much memory for a lot of convenience

#

Dont see it as a waste see it as preallocated memory to speed up short lived allocations

dawn wave Jul 17, 2023, 6:36 AM

#

Hmm yesh ig so I just don’t like that I have to pre-set a fixed amount

tropic vigil Jul 17, 2023, 6:36 AM

#

Hmm maybe dynamically growing scratch allocators is the way to go

dawn wave Jul 17, 2023, 6:37 AM

#

Maybe? How would I do that?

tropic vigil Jul 17, 2023, 6:37 AM

#

Can you open an issue for that

dawn wave Jul 17, 2023, 6:37 AM

#

Alr will do

tropic vigil Jul 17, 2023, 6:37 AM

#

dawn wave Maybe? How would I do that?

Ill wrestle with Phobos internals and add it bleakekw

#

Should be doable though

dawn wave Jul 17, 2023, 6:40 AM

#

Made it 👍

#

Hmm whay should I do in the mean time then

#

Should I try to move them to buffers and attach them as storage buffers?

tropic vigil Jul 17, 2023, 6:41 AM

#

Just set the scratch size to a few mb

dawn wave Jul 17, 2023, 6:41 AM

#

Scuffed fixed KEKW but good enough tbfh

tropic vigil Jul 17, 2023, 6:41 AM

#

No need to attach to the graph if you’re not writing to them on the gpu

dawn wave Jul 17, 2023, 6:42 AM

#

Hmm yeah but how would I indicate to the grsph

#

That I intend on binding them as storage and the shader is meant to read from them:

#

.bind_storage(set, binding, buffer)

tropic vigil Jul 17, 2023, 6:44 AM

#

You don’t need to add it to the graph at all

#

Just allocate and bind

#

Adding things to the graph is just for sync

#

But you’re never writing on the gpu so no sync needed

dawn wave Jul 17, 2023, 6:46 AM

#

Hmm okok

#

So i could literally take the ctx, get the graphics domain, bind the buffer, then submit that for execution snd it show up still?

#

bleakekw I assumed it always unbinded or smth

tropic vigil Jul 17, 2023, 6:49 AM

#

Yep

#

No the graph doesn’t bind anything it just handles sync

#

Hmm i need a bit of a tutorial for Phobos maybe

dawn wave Jul 17, 2023, 6:53 AM

#

Yes-ish

#

More examples tbfh

tropic vigil Jul 17, 2023, 6:54 AM

#

Yeah they are just somewhat tedious to write bleakekw

dawn wave Jul 17, 2023, 6:54 AM

#

I’ll see if I can contribute some

#

Or modify the existing ones to use new features we added

#

So we can get some test coverage

dawn wave Jul 17, 2023, 3:41 PM

#

ok crashes are gone

#

me when i had to simply increase scratch memory bleakekw

#

it is time

#

sponza

#

#

this sponza looks fucked up

#

KEKW

#

#

why the wall

#

wtffff

#

hm what test textures exists

eager chasm Jul 17, 2023, 4:27 PM

#

looks like youare randomly picking textures again

#

i see normal maps and albedo at the same time

dawn wave Jul 17, 2023, 4:27 PM

#

bleakekw

#

i just discovered the gltf crate has utility functions to help me cast types

#

i literally implemented that all myself oml

#

hmm i need to find a smaller scene where this bug repo

feral trellis Jul 17, 2023, 4:50 PM

#

Oh also another mistake I made when loading sponza

#

I used a vec2<u8> for textures coordinates; don't do that (if you do)

#

I forgor that tex-coords can be greater than 1.0

dawn wave Jul 17, 2023, 4:51 PM

#

wait the fuck

#

they can?

feral trellis Jul 17, 2023, 4:51 PM

#

Which caused this for me

#

feral trellis Jul 17, 2023, 4:51 PM

#

dawn wave they can?

Yep

dawn wave Jul 17, 2023, 4:51 PM

#

let me look into my buffer

feral trellis Jul 17, 2023, 4:51 PM

#

Nothing stops a modeler to make UVs out of texture bounds (to cause repetition for example)

dawn wave Jul 17, 2023, 4:52 PM

#

im omw to check my uvs

#

did i forcefully normalize then bleakekw

#

no i only did that to my textures

feral trellis Jul 17, 2023, 4:53 PM

#

Aight

#

As long as you don't clamp uvs when loading in models you're good

dawn wave Jul 17, 2023, 4:55 PM

#

hmmm

#

is the sampler fucked possibly?

#

ah fuck how would I even do a per-image per-sampler binding?

#

is that even possible with how phobos had set it up?

#

bindless images can only take one sampler

#

you know what

#

quest time

#

i need to rework my entire asset system

#

as it's a total mess rn

feral trellis Jul 17, 2023, 5:01 PM

#

Use mine 🤓 KEKW

dawn wave Jul 17, 2023, 5:02 PM

#

ok plan

#

we can either have non-loaded assets then a load method to effectively load them

#

pros:

ease of use
cons:
i pray for my monolithic buffer

#

or we load the entire scene which is gonna be easier for me to code

feral trellis Jul 17, 2023, 5:04 PM

#

What I do in my system is I have an Asset trait that can be implemented for anything, and then a World where I can add in resources, including an AssetLoader

#

Though that more engine related than rendering engine related

dawn wave Jul 17, 2023, 5:05 PM

#

yeah

#

idk i want a way so i can do this

feral trellis Jul 17, 2023, 5:05 PM

#

If you're going to stick with solely a rendering engine I'd say make it load a whole scene at once tbh

dawn wave Jul 17, 2023, 5:06 PM

#

Load buffers -> Load accessors -> Load meshes -> Process meshes -> Generate needed buffers -> Update meshes -> Store buffers on device

#

issue is how do I do this without killing my cpu memory

#

KEKW

#

like auto-generating normals etc.

feral trellis Jul 17, 2023, 5:07 PM

#

'Tis how I do it

#

https://github.com/jedjoud10/cflake-engine/blob/main/crates/rendering/src/gltf.rs

GitHub

cflake-engine/crates/rendering/src/gltf.rs at main · jedjoud10/cfla...

Custom ECS-based game engine built on Rust and WGPU - jedjoud10/cflake-engine

dawn wave Jul 17, 2023, 5:10 PM

#

i need to get into the habit of using traits KEKW

#

hm should i load them manually

#

or rely on the gltf crate

feral trellis Jul 17, 2023, 5:12 PM

#

gltf makes it 10x easier

dawn wave Jul 17, 2023, 5:13 PM

#

lmao why are you loading it manually then KEKW

feral trellis Jul 17, 2023, 5:13 PM

#

I'm using the gltf crate

#

The "manual" part is creating my gfx / rendering / entities objects

dawn wave Jul 17, 2023, 5:13 PM

#

oh i was talking about if i should use gltf's crate built-in deserializer

#

instead of reading the buffers myself

feral trellis Jul 17, 2023, 5:14 PM

#

Oh uhhh for that idk

#

I do that manually and tbh I've had no problems so far

dawn wave Jul 17, 2023, 5:14 PM

#

eh yeah

#

more manual control ig

#

Do you generate normals?

#

ahh okay

#

so idk if this is proper terminology but I'll create a bunch of virtual assets

#

The first deserialization stage will create virtual assets of the scene, the second stage is supposed to recognize if certain materials, textures, or buffers (normals) need to be pre-generated

devout mesa Jul 17, 2023, 5:25 PM

#

I don't understand

#

why you are doing this garbage

#

literally load the things like a normal person

dawn wave Jul 17, 2023, 5:25 PM

#

it's too spaghetti :(

devout mesa Jul 17, 2023, 5:26 PM

#

Yeah, you're supposed to make it less spaghetti

#

not more

feral trellis Jul 17, 2023, 5:27 PM

#

dawn wave Do you generate normals?

Nein

#

I load them in from the glTF

#

I do generate tangents though

dawn wave Jul 17, 2023, 5:28 PM

#

hmm ok

feral trellis Jul 17, 2023, 5:28 PM

#

devout mesa literally load the things like a normal person

just load what you need to load!

#

(trait system does help a lot tbh)

dawn wave Jul 17, 2023, 5:28 PM

#

i should probably make the trait system kekw i haven't been using them at all in my project

devout mesa Jul 17, 2023, 5:30 PM

#

vector<VertexData> vertices;
HashMap<GltfPrimitive, vector<VertexData>> primitives;
for each mesh {
    for each primitive in mesh.primitives {
        // declare pointers to attributes
        vec3* position = null;
        vec3* normal = null;
        for each attribute in primitive.attributes {
            switch (attribute.type) {
                case position: position = attribute.buffer_view....
            }
        }
        // actually put vertices here
        // register primitive in "primitives"
    }
}

for each node {
    for each mesh in node.meshes {
        for each primitive in mesh.primitives {
            if primitive.contains(primitive) {
                // put the vertex data in your scene or something
                scene.insert(object);
            }
        }
    }
}
return scene;```

#

It doesn't get easier than this

dawn wave Jul 17, 2023, 5:30 PM

#

i am overthinking this bleakekw

devout mesa Jul 17, 2023, 5:30 PM

#

yes

#

faaar too much

#

you are about to overflow the amount of overthinking

feral trellis Jul 17, 2023, 5:31 PM

#

I mean tbh I can't blame you my whole engine is overthought KEKW

#

Not a good thing tho

dawn wave Jul 17, 2023, 5:33 PM

#

ah i know why its so hacky

#

been creating an entirely new buffer for each accessor

#

also i don't have some like temporary gltf struct its all free standing functions meaning i have to constantly convert back and forth between my asset & something gltf can understand

devout mesa Jul 17, 2023, 5:36 PM

#

why do you even have to convert back and forth

dawn wave Jul 17, 2023, 5:37 PM

#

cuz i immediately throw my stuff on loading into asset storage

devout mesa Jul 17, 2023, 5:37 PM

#

Look

#

your asset loader has to do ONE THING

#

and ONE THING only

#

convert the data in your GLTF file, to data in vectors you can use later

#

That's all it has to do

#

it doesn't matter what kind of shenanigans you want to do, that's all you will have it do

dawn wave Jul 17, 2023, 5:38 PM

#

okok

devout mesa Jul 17, 2023, 5:38 PM

#

devout mesa ```c++ vector<VertexData> vertices; HashMap<GltfPrimitive, vector<VertexData>> p...

And I am telling you to do it like this

#

It's easy, functional and will work for 99.99999% of models out there

#

https://github.com/LVSTRI/IrisVk/blob/master/src/renderer/core/model.cpp#L81-L163 This takes the vertex and index data

#

https://github.com/LVSTRI/IrisVk/blob/master/src/renderer/core/model.cpp#L299-L318 This iterates over all the nodes and uses the vertex data previously calculated

#

then returns the vectors

#

It's not hard unless you want to complicate your life for no reason whatsoever

#

The things in the middle are meshlet specific and you don't need to look at those

feral trellis Jul 17, 2023, 5:41 PM

#

devout mesa your asset loader has to do ONE THING

Yea this rule is really great for anything programming related

#

Do one thing and do it well

#

If not then it's not its job

dawn wave Jul 17, 2023, 5:41 PM

#

huh yeah but also wouldn't that be duplicating shared data?

feral trellis Jul 17, 2023, 5:42 PM

#

What would?

dawn wave Jul 17, 2023, 5:42 PM

#

the code he sent

#

eh ig it's neglible and in 99.999% of cases it doesn't really matter

devout mesa Jul 17, 2023, 5:42 PM

#

I don't duplicate anything

#

What would I be duplicating?

dawn wave Jul 17, 2023, 5:44 PM

#

since you're iterating over every accessor in each prim, and not the entire gltf file, wouldn't that potentially lead to you having to duplicating the same data?

#

unless I'm not understanding how you're storing all the vertices

devout mesa Jul 17, 2023, 5:45 PM

#

I assume a sane glTF file

dawn wave Jul 17, 2023, 5:45 PM

#

oh kekw

devout mesa Jul 17, 2023, 5:45 PM

#

I don't think any exporter duplicates primitives like that

#

and even if it did, I use my own tools to deduplicate the meshes (gltfpack)

dawn wave Jul 17, 2023, 5:45 PM

#

oh then that makes life a lot easier

#

maybe i'm overthinking this because im constantly testing odd edge cases

devout mesa Jul 17, 2023, 5:53 PM

#

btw I just checked

#

in any of the models I use

#

whether they have been exported from blender, Unreal Engine, transformed from FBX/OBJ to glTF, downloaded from random chinese sites

#

In every single one of them

#

Each primitive is unique

#

Two different primitives never have the same accessors with the same data

dawn wave Jul 17, 2023, 5:55 PM

#

gltf samples really made me go down a rabbit hole then huh

devout mesa Jul 17, 2023, 5:55 PM

#

And even if they were not unique

#

I have this

#

if (meshlet_cache.contains(&primitive)) {
    continue;
}```

#

And also gltfpack deduplicates anything for me

#

accessors, textures, meshes, nodes, etc

dawn wave Jul 17, 2023, 5:55 PM

#

tf im jealous

devout mesa Jul 17, 2023, 5:56 PM

#

gltfpack is free

#

https://meshoptimizer.org/gltf/

dawn wave Jul 17, 2023, 5:56 PM

#

ill see if they have rust wrapping

devout mesa Jul 17, 2023, 5:56 PM

#

No need

#

it's not a tool you use in code

#

Or well, you shouldn't

dawn wave Jul 17, 2023, 5:56 PM

#

OHH CLI

#

i see now

devout mesa Jul 17, 2023, 5:57 PM

#

Granted I do have my own fork of gltfpack which does things how I like them done

#

so perhaps you might wanna fork it and see if there's anything you are unhappy with

dawn wave Jul 17, 2023, 5:57 PM

#

you are overestimating how smart i am KEKW

devout mesa Jul 17, 2023, 5:57 PM

#

For example quantization by default is all or nothing

#

You can't say "I want to quantize positions but not normals"

#

In my fork I get to decide

dawn wave Jul 17, 2023, 6:19 PM

#

Oh yeah

#

how do you guys handle converting over your accessors to certain types and dimensions?

feral trellis Jul 17, 2023, 6:21 PM

#

dawn wave how do you guys handle converting over your accessors to certain types and dimen...

Wdym?

#

I just read the value slice as it was given to me

dawn wave Jul 17, 2023, 6:22 PM

#

Oh so what happens if you get a file that contains accessors with other types?

#

does it kinda just go "lmao"

#

you know maybe lvstri was onto something when he said only consider sane gltf files KEKW

feral trellis Jul 17, 2023, 6:23 PM

#

dawn wave Oh so what happens if you get a file that contains accessors with other types?

I only stick with the "default" types if that's what you mean

#

Aka only (floats, ints, uints, and vecs of those)

#

Common data types basically since those are all I need (and support) anyways

devout mesa Jul 17, 2023, 6:25 PM

#

dawn wave you know maybe lvstri was onto something when he said only consider sane gltf fi...

by gltf spec

#

position will always be vec3

#

normal will always be vec3

#

tangents will always be vec4

#

texcoords will always be vec2

dawn wave Jul 17, 2023, 6:27 PM

#

yeah but the types

devout mesa Jul 17, 2023, 6:28 PM

#

always float

#

unless you use quantization

#

in that case it may or may not be float, but you decide what it will be

dawn wave Jul 17, 2023, 6:28 PM

#

ahh im gonna kms

#

wrote useless code ;kek

#

@feral trellis Sorry for ponging but why not use gltf's document wrapper for json?

feral trellis Jul 17, 2023, 6:39 PM

#

Oh no I do

#

I just decompose it

dawn wave Jul 17, 2023, 6:39 PM

#

oh so it's just semantics?

feral trellis Jul 17, 2023, 6:40 PM

#

// Decompose the JSON document
        let gltf::json::Root {
            accessors,
            buffers,
            buffer_views,
            scene,

            images,
            materials,
            meshes,
            nodes,
            samplers,
            scenes,
            textures,
            ..
        } = json;

feral trellis Jul 17, 2023, 6:40 PM

#

dawn wave oh so it's just semantics?

Yeap

dawn wave Jul 17, 2023, 6:40 PM

#

mkmk

feral trellis Jul 17, 2023, 6:40 PM

#

I get gltf.document and then get root from that

#

https://github.com/jedjoud10/cflake-engine/blob/main/crates/rendering/src/gltf.rs#L134

GitHub

cflake-engine/crates/rendering/src/gltf.rs at main · jedjoud10/cfla...

Custom ECS-based game engine built on Rust and WGPU - jedjoud10/cflake-engine

dawn wave Jul 17, 2023, 6:42 PM

#

ikik i was just confused why you were doing ,into_json

eager chasm Jul 17, 2023, 6:50 PM

#

18hrs have passed

#

where sponza at

dawn wave Jul 17, 2023, 6:50 PM

#

still not here :(

#

well

#

with randomly selected texture (tm)

eager chasm Jul 17, 2023, 6:50 PM

#

yeah 😄

#

could be a feature

dawn wave Jul 17, 2023, 6:50 PM

#

yeah the first ever gambling renderer

eager chasm Jul 17, 2023, 6:51 PM

#

you heard it here first

dawn wave Jul 17, 2023, 6:51 PM

#

this will go big in Vegas baby

#

Is it possible to get a primitive's transform without having to recursively iterate through the node tree?

devout mesa Jul 17, 2023, 7:01 PM

#

no

dawn wave Jul 17, 2023, 7:01 PM

#

oh ok then

devout mesa Jul 17, 2023, 7:01 PM

#

that transform will be 100% wrong

feral trellis Jul 17, 2023, 7:07 PM

#

devout mesa that transform will be 100% wrong

It's literally written in the spec as well

#

It's only the relative transform to the parent

#

So you need to iterate through all nodes to get its global transform

#

https://raw.githubusercontent.com/KhronosGroup/glTF/main/specification/2.0/figures/gltfOverview-2.0.0b.png

devout mesa Jul 17, 2023, 7:09 PM

#

Also don't do it recursively

dawn wave Jul 17, 2023, 7:10 PM

#

i- was doing it that way KEKW

devout mesa Jul 17, 2023, 7:10 PM

#

Bruh

dawn wave Jul 17, 2023, 7:11 PM

#

bruh how are you supposed to do it non-recursively?

devout mesa Jul 17, 2023, 7:11 PM

#

wat

#

ptr = node;
transform = mat4(1.0);
while (ptr->parent) {
    transform = transform * node.matrix;
    ptr = ptr->parent;
}```?

dawn wave Jul 17, 2023, 7:12 PM

#

oh my god

#

yeah that makes sense

#

oh no

#

big oh no

#

seems like gltf crate doesn't provide you with the parent?

#

oh wait you're supposed to implement that yourself?

devout mesa Jul 17, 2023, 7:16 PM

#

?

#

no

#

a node should have a parent ptr

#

Any sane gltf loader will provide you either with a parent ptr, or an index to the parent

dawn wave Jul 17, 2023, 7:16 PM

#

clearly

#

this one isn't

devout mesa Jul 17, 2023, 7:18 PM

#

average rust lib

dawn wave Jul 17, 2023, 7:19 PM

#

I'm gonna assume they didn't add it cuz rust memory safety

devout mesa Jul 17, 2023, 7:20 PM

#

Maybe getting the transform of a node already gives you the fully transformed node?

dawn wave Jul 17, 2023, 7:20 PM

#

if that were the case

#

all my prior screenshots

#

would've been wacked beyond comprehension

devout mesa Jul 17, 2023, 7:21 PM

#

sorry, how are you transforming it right now

dawn wave Jul 17, 2023, 7:21 PM

#

I am literally recursively going through the entire scene tree, multiplying the transforms then applying them

devout mesa Jul 17, 2023, 7:21 PM

#

remember your DSA classes? Any recursive function can be transformed into an iterative function

dawn wave Jul 17, 2023, 7:21 PM

#

haven't taken DSA classes KEKW

#

but yeah it could i think?

devout mesa Jul 17, 2023, 7:22 PM

#

dawn wave I am literally recursively going through the entire scene tree, multiplying the ...

https://tenor.com/view/end-gif-26393040

Tenor

dawn wave Jul 17, 2023, 7:22 PM

#

bleakekw

#

oh my

#

i forgor stack

#

i can literally make a stack of nodes that need to be processed

devout mesa Jul 17, 2023, 7:33 PM

#

I still can't get over the fact you can't get the parent of a node

#

I checked documentation as well

#

hey uh @feral trellis how is this reasonable? on any level?

dawn wave Jul 17, 2023, 7:33 PM

#

eh who cares just do a stack loop

feral trellis Jul 17, 2023, 7:33 PM

#

#

Seems like glTF spec itself doesn't contain the parent node

dawn wave Jul 17, 2023, 7:34 PM

#

yeah but most gltf loaders will include a parent pointer for QoL

feral trellis Jul 17, 2023, 7:34 PM

#

Yelp this one doesn't ig

#

It's not that big of a deal tbh I managed to do without it

dawn wave Jul 17, 2023, 7:34 PM

#

it's 🍴'n time KEKW

#

yeah

feral trellis Jul 17, 2023, 7:34 PM

#

I just start with the root node and go down from there

dawn wave Jul 17, 2023, 7:38 PM

#

im makiung sure im not being dumb

#

wait nvm

#

Aw rust doesn't have variants :(

feral trellis Jul 17, 2023, 7:44 PM

#

Wdym "variants"?

#

enums?

dawn wave Jul 17, 2023, 7:45 PM

#

std::variant<int, string, type>

#

i kinda get it via enums yeah

devout mesa Jul 17, 2023, 7:45 PM

#

bruh you have better variants

#

enums

#

Like 100x better

feral trellis Jul 17, 2023, 7:45 PM

#

Yea

dawn wave Jul 17, 2023, 7:45 PM

#

probably is

feral trellis Jul 17, 2023, 7:45 PM

#

I mean you can also use unsafe unions but you shouldn't use unsafe for that

dawn wave Jul 17, 2023, 7:45 PM

#

oh yeah i can do match and all that stuff

feral trellis Jul 17, 2023, 7:45 PM

#

Enums are the way to go

dawn wave Jul 17, 2023, 7:48 PM

#

im gonna trust lvstri and iterate just over my primitives

#

if he lied then it's joever (i will waste 0.0004 mbs of vram)

feral trellis Jul 17, 2023, 7:49 PM

#

I mean it's kinda like the only way of doing this sanely

dawn wave Jul 17, 2023, 7:50 PM

#

blud thinks im still sane after 2 weeks of non-stop graphics programming

#

you cannot lose what you don't have

feral trellis Jul 17, 2023, 7:50 PM

#

Ok that's true lol

dawn wave Jul 17, 2023, 7:50 PM

#

men we shall go on a mission to save that 0.0004 mb of memory 🫡 each byte counts

devout mesa Jul 17, 2023, 7:55 PM

#

I can load 100 million triangles models into 1.5GB of VRAM

#

you're good

dawn wave Jul 17, 2023, 7:55 PM

#

feral trellis Ok that's true lol

oh now i understand why you did .into_json it preserves the json ordering

#

if I did the document wrapper it's uh questionable

eager chasm Jul 17, 2023, 7:56 PM

#

when you see patterns emerge in the soup that is coleured micro tringles for debug isms

feral trellis Jul 17, 2023, 7:56 PM

#

devout mesa I can load 100 million triangles models into 1.5GB of VRAM

Holy fuck that looks beautiful

devout mesa Jul 17, 2023, 7:56 PM

#

it's not good to stare at tiny triangles for too long bleakekw

eager chasm Jul 17, 2023, 7:56 PM

#

like these 3d images which were popular in the mid 90s

dawn wave Jul 17, 2023, 8:08 PM

#

oh my god

#

this is insufferable

#

why the hell does gltf's document wrapper not iterate in order bleakekw

dawn wave Jul 17, 2023, 8:28 PM

#

LVSTRI, do you handle sparse accessors at all?

#

or you throw that to gltfpack to take care of

devout mesa Jul 17, 2023, 8:29 PM

#

I don't think I have seen any glTF model that uses sparse accessors

#

at all

#

so no I don't handle them KEKW

dawn wave Jul 17, 2023, 8:29 PM

#

🤓 uhm ackshually

#

https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/SimpleSparseAccessor

GitHub

glTF-Sample-Models/2.0/SimpleSparseAccessor at master · KhronosGrou...

glTF Sample Models. Contribute to KhronosGroup/glTF-Sample-Models development by creating an account on GitHub.

devout mesa Jul 17, 2023, 8:29 PM

#

amazing

#

count is now 1

dawn wave Jul 17, 2023, 8:29 PM

#

besides from the examples yeah

#

i really need to stop basing my gltf capabilities on those sample models KEKW

#

its making me overengineer for stuff that i will never come across

feral trellis Jul 17, 2023, 8:44 PM

#

dawn wave why the hell does gltf's document wrapper not iterate in order <:bleakekw:108259...

Oh fuck

#

Well thanks for letting me know now I found a bug in my code lel

#

(yet it somehow worked out this whole time)

dawn wave Jul 17, 2023, 8:45 PM

#

nono if you're doing json

#

you're good

#

that is what you're doing @feral trellis

#

It keeps json ordering

#

also turns out

#

it was a bug on my end bleakekw

feral trellis Jul 17, 2023, 8:47 PM

#

dawn wave nono if you're doing json

O

#

Ok then I guess am gud

dawn wave Jul 17, 2023, 8:47 PM

#

yeah seems like gltf iterators are fine

#

@feral trellis How did you handle getting unique primitives? I can't seem to figure that out rn

feral trellis Jul 17, 2023, 9:09 PM

#

dawn wave <@463353335269818368> How did you handle getting unique primitives? I can't seem...

Wdym by "unique" primitives?

dawn wave Jul 17, 2023, 9:09 PM

#

ah wait nvm we're approaching it from different ways

#

looks like you're iterating over the gltf documents

#

I am getting my prims via iterating through the scene graph

feral trellis Jul 17, 2023, 9:10 PM

#

I mean I do that too

#

I iterate over the nodes, and fetch the surface that I parse from the document's meshes / buffers

#

// For now, we only handle mesh entities and empty entities
            let entity = if let Some(mesh_index) = node.mesh {
                let mesh = &meshes[mesh_index.value()];
                let meshes = &mapped_meshes[mesh_index.value()];

#

meshes is the gltf given value

#

mapped_meshes contains meshes of my own rendering API

dawn wave Jul 17, 2023, 9:11 PM

#

but that however just covers the mesh, no? and not the primitive

#

https://docs.rs/gltf/latest/gltf/struct.Primitive.html

Primitive in gltf - Rust

Geometry to be rendered with the given material.

#

unless I'm high

feral trellis Jul 17, 2023, 9:17 PM

#

That selects the mesh then I iterate for each primitive

#

// Sub-Surfaces that we must render
                let mut subsurfaces = Vec::<SubSurface<PbrMaterial>>::new();

                // Create the sub-surfaces of the entity (mesh)
                for (submesh_index, primitive) in mesh.primitives.iter().enumerate() {
                    let mesh = &meshes[submesh_index];
                    let material = primitive
                        .material
                        .as_ref()
                        .map(|i| mapped_materials[i.value()].clone())
                        .unwrap_or(default.clone());
                    subsurfaces.push(SubSurface {
                        mesh: mesh.clone(),
                        material: material.clone(),
                    });
                }

#

Literally the next line

dawn wave Jul 17, 2023, 9:18 PM

#

wait am I fucking stupid

#

primitive index doesn't refer to the actual primitive index

#

but the mesh?

#

oh my god

#

brain dead activity aka me

devout mesa Jul 17, 2023, 9:21 PM

#

I mean

#

to be fair

#

primitive_index is a bad name if you refer to a mesh

#

KEKW

dawn wave Jul 17, 2023, 9:21 PM

#

noon i understand what they meant

#

primitive_index refers to the index the prim itself is in within the mesh

#

bleakekw

feral trellis Jul 17, 2023, 9:24 PM

#

dawn wave primitive_index refers to the index the prim itself is in within the mesh

Yep

#

Node -> Mesh -> Multiple Prims

dawn wave Jul 17, 2023, 10:01 PM

#

How should I do normal generation

#

without having to deal with duplicate normals/computation

#

mainly worried more about having to recompute the same thing over and over

devout mesa Jul 17, 2023, 10:03 PM

#

You should avoid it

dawn wave Jul 17, 2023, 10:03 PM

#

really? Well the issue is a lot my test gltf file kinda don't have normals

devout mesa Jul 17, 2023, 10:03 PM

#

wat

#

All khronos samples have normals

dawn wave Jul 17, 2023, 10:03 PM

#

yeah but when i open some it will just say no normals??

#

but if you say so

#

i won't generate them

devout mesa Jul 17, 2023, 10:05 PM

#

No you should generate them when they are missing

#

it's just strange

#

Anyways you should put each vertex normal at 0

#

and then iterate over all triangles, cross product their edges and normalize

dawn wave Jul 17, 2023, 10:05 PM

#

oh KEKW just default it all to zero?

#

ah

#

now that makes sense

devout mesa Jul 17, 2023, 10:06 PM

#

You add the result to each vertex, smoothizing the normals

dawn wave Jul 17, 2023, 10:06 PM

#

yeah mhm

#

im just unsure how to do it in a way where i won't be duplicating my computations

#

should I make a hashmap of the vertex accessor index as that is more or less the input for normals?

devout mesa Jul 17, 2023, 10:07 PM

#

for v in vertices {
    v.n = vec3(0, 0, 0);
}

for t in triangles {
    n = normalize(cross(t.b - t.a, t.c - t.a));
    // add the normal to each vertex such that smooth normals are generated
    t.a.n += n;
    t.b.n += n;
    t.c.n += n;
}
for v in vertices {
    v.n = normalize(v.n);
}

devout mesa Jul 17, 2023, 10:08 PM

#

dawn wave im just unsure how to do it in a way where i won't be duplicating my computation...

That does not matter

#

You want to duplicate your computations in fact

#

You will be adding the normal for every vertex you encounter

dawn wave Jul 17, 2023, 10:08 PM

#

ohh i do the process at the end

devout mesa Jul 17, 2023, 10:08 PM

#

More than one triangle could share the same vertices at their edges

#

why even work on accessors?

#

Just load the data

#

and then work on the loaded thing

dawn wave Jul 17, 2023, 10:11 PM

#

eh fine ill change it so i just iterate over every mesh

devout mesa Jul 17, 2023, 10:11 PM

#

devout mesa ```glsl for v in vertices { v.n = vec3(0, 0, 0); } for t in triangles { ...

Dont forger to renormalize btw

dawn wave Jul 17, 2023, 10:11 PM

#

its works for you so i mean

devout mesa Jul 17, 2023, 10:11 PM

#

yes do not worry

#

I do far more complicated computations during loading

#

such a spatial sorting triangles and building RB trees over all them, then greedily aggregating triangles, etc...

#

Although it's meshopt that does this KEKW

dawn wave Jul 17, 2023, 10:12 PM

#

im so fucking jealous

#

rust does have meshopt bindings but they're 3 years old

devout mesa Jul 17, 2023, 10:12 PM

#

You could do it too, I just don't think RT needs meshlets

#

Er well

dawn wave Jul 17, 2023, 10:13 PM

#

heh

devout mesa Jul 17, 2023, 10:13 PM

#

It could use meshlets

dawn wave Jul 17, 2023, 10:13 PM

#

yeah there is a recent paper that goes into using it

devout mesa Jul 17, 2023, 10:13 PM

#

There's this thing I'm starting to work on for RT

#

https://www.intel.com/content/www/us/en/developer/articles/technical/real-time-ray-tracing-of-micro-poly-geometry.html

dawn wave Jul 17, 2023, 10:14 PM

#

yaa that paper

#

looks really interesting

devout mesa Jul 17, 2023, 10:14 PM

#

Unfortunately I do not have an Intel GPU so I can't test this, but the gist is real time LODing and swapping of clusters for RT

#

With streaming, so memory is effectively not a concern anymore

#

And I will try to integrate it into RADV

dawn wave Jul 17, 2023, 10:14 PM

#

RADV?

devout mesa Jul 17, 2023, 10:15 PM

#

(opensource) Vulkan driver for AMD GPUs on linux

dawn wave Jul 17, 2023, 10:15 PM

#

ahh i see

eager chasm Jul 17, 2023, 10:25 PM

#

lustri? are you distracting danny with nanitebrainwormisms?

devout mesa Jul 17, 2023, 10:26 PM

#

wasn't my intention frog_sweat

eager chasm Jul 17, 2023, 10:26 PM

#

thihihi

dawn wave Jul 17, 2023, 10:33 PM

#

devout mesa ```glsl for v in vertices { v.n = vec3(0, 0, 0); } for t in triangles { ...

i alos forgor to say but ew vertex struct

dawn wave Jul 17, 2023, 10:53 PM

#

fuck i realized your solution

#

won't work with mines KEKW

#

unless i do a decently large rework

devout mesa Jul 17, 2023, 10:54 PM

#

how is it even possible

#

you are storing all vertices in a vector right?

dawn wave Jul 17, 2023, 10:54 PM

#

ah wiat yeah

#

nvm it is

#

ill just need to throw everything into one monolithic buffer

#

then suballocate the hell out of it

devout mesa Jul 17, 2023, 10:54 PM

#

????????

#

what the hell are you doing

dawn wave Jul 17, 2023, 10:54 PM

#

magic

devout mesa Jul 17, 2023, 10:54 PM

#

You have your vertex data, in a vector

#

yes or no

#

if yes => good, do what is written above
else => bad, put your vertex data in a vector and see branch yes

dawn wave Jul 17, 2023, 10:55 PM

#

ahh fine

#

ill put it all into one vertex vector

devout mesa Jul 17, 2023, 10:55 PM

#

mate

#

no

#

ok good

#

now we're talkin

#

Just for this mesh primitive

#

one vector of vertex data, you put all your stuff in that once per primitive, you process the data and then put it back into a bigger vector or something

dawn wave Jul 17, 2023, 10:57 PM

#

so
unique meshes -> primitive -> acessors -> yeet the vertex data into the massive vector

#

i should make this a hashmap so it can expand to support other accessors like normals etc

devout mesa Jul 17, 2023, 10:58 PM

#

god

#

fucking damnit

dawn wave Jul 17, 2023, 10:58 PM

#

KEKW

devout mesa Jul 17, 2023, 10:59 PM

#

vector<Vertex> vertices;
load_primitive_into(vertices);
process(vertices);
bigger_vector.insert(vertices);```

#

do you understand

dawn wave Jul 17, 2023, 10:59 PM

#

OH

#DARE (Danny's Awesome Rendering Engine)