wicked notch Jul 21, 2023, 2:05 PM

#

So

#

uh

#

diffuse lighting means random direction right?

#

Should this random direction be within the "hemisphere" of the triangle's normal

#

I don't understand

#

This is cornell box

#

The one we all love

#

this is path traced with the emissive light on top

#

where the hell are these colors coming from

#

With 16 samples per pixel it's somewhat recognizable

#

There are still some bogus colors near the light source though

wicked notch Jul 21, 2023, 2:47 PM

#

I kinda like how low spp counts yield completely bogus colors bleakekw

#

I'll try temporal accumulation

wicked notch Jul 21, 2023, 6:32 PM

#

Aight it werks

#

it's only unbearably slow, but it werks bleakekw

summer gyro Jul 21, 2023, 6:49 PM

#

Nanite2 with raytracing next 😈

wicked notch Jul 21, 2023, 6:50 PM

#

That is unironically the plan

#

KEKW

summer gyro Jul 21, 2023, 6:50 PM

#

LESSGOO

wicked notch Jul 21, 2023, 6:50 PM

#

https://www.intel.com/content/www/us/en/developer/articles/technical/real-time-ray-tracing-of-micro-poly-geometry.html

#

But it's intel only and I don't have an intel GPU

summer gyro Jul 21, 2023, 6:51 PM

#

I donno anyone who has it tbh
(We are not talking about the integrated one right ?)

wicked notch Jul 21, 2023, 6:52 PM

#

Ye

#

I have a laptop with an Intel iGPU but it can't run this

summer gyro Jul 21, 2023, 6:52 PM

#

wicked notch I have a laptop with an Intel iGPU but it can't run this

Why ?

#

Extension holdin ya back ?

wicked notch Jul 21, 2023, 6:53 PM

#

No, it shrimply can't

#

it's too shit bleakekw

#

i.e crashes on startup

#

It's not even old, it's a 12700H

#

I still have the issue of the image "converging" after a while or so

#

Even though it's very clearly still noisy

raven orchid Jul 21, 2023, 8:40 PM

#

What’s the sample count and history depth at?

wicked notch Jul 21, 2023, 8:41 PM

#

4spp

#

history depth is surely less than 100

#

The peter panning is also super weird

frank sail Jul 21, 2023, 8:42 PM

#

what is the ray offset after a bounce?

wicked notch Jul 21, 2023, 8:43 PM

#

const auto normal = glm::normalize(
    n0 * bary.x +
    n1 * bary.y +
    n2 * bary.z);
const auto point =
    glm::vec3(ray.org[0], ray.org[1], ray.org[2]) +
    glm::vec3(ray.dir[0], ray.dir[1], ray.dir[2]) *
    ray.tmax;
ray = bvh_ray(as_vec3(point), as_vec3(random_direction_in_hemisphere(normal)), 0.1f);```

#

all in world space btw

frank sail Jul 21, 2023, 8:44 PM

#

hmm so you aren't offsetting the ray when you bounce?

wicked notch Jul 21, 2023, 8:44 PM

#

How should I offset it?

frank sail Jul 21, 2023, 8:45 PM

#

offset by the normal scaled by a tiny amount

#

that should help prevent self intersection

#

your image should get brighter as a result, but it won't change peter panning

#

which tbh I thought was caused by too much offset

wicked notch Jul 21, 2023, 8:50 PM

#

I think there is something fundamentally wrong here

#

With this

ray = bvh_ray(as_vec3(point + direction * 0.5f), as_vec3(direction), 0.1f);```

#

I no longer have peter panning and the image is darker

#

somehow the exact opposite of what you said jaker

#

bleakekw

#

frank sail Jul 21, 2023, 8:55 PM

#

Lmao

wicked notch Jul 21, 2023, 8:55 PM

#

I am currently very tempted of moving everything to the GPU

frank sail Jul 21, 2023, 8:55 PM

#

.5 is a huge offset though

wicked notch Jul 21, 2023, 8:56 PM

#

just so I don't have to wait 30 seconds for a single frame

#

should I try with .01

#

or .1

frank sail Jul 21, 2023, 8:56 PM

#

and direction is the wrong value to offset by since you will escape the surface more slowly than if you use the surface normal

frank sail Jul 21, 2023, 8:56 PM

#

wicked notch should I try with .01

maybe even .001

#

try different things

wicked notch Jul 21, 2023, 8:56 PM

#

I will

frank sail Jul 21, 2023, 8:56 PM

#

the point is to avoid self intersection caused by floating point error

wicked notch Jul 21, 2023, 8:57 PM

#

unfortunately it takes a solid minute to get 3 frames KEKW

#

#

hmm

wicked notch Jul 21, 2023, 9:00 PM

#

wicked notch

I also notice a super weird "band" in the middle of the box

#

as if pixels clump up there more for some reason

#

Alright this is it

#

we're going fully GPU

#

I am a very impatient man

frank sail Jul 21, 2023, 9:03 PM

#

lmao

#

also I'm not sure why the offset is being weird

#

maybe you gotta negate it for some reason frog_thinkk

wicked notch Jul 21, 2023, 9:04 PM

#

I tried that as well

#

The image was even darker KEKW

frank sail Jul 21, 2023, 9:05 PM

#

cursed lmao

wicked notch Jul 21, 2023, 9:05 PM

#

Anyways, for faster iteration times, I'll be going GPU

#

template <typename Node>
template <bool IsAnyHit, bool IsRobust, typename Stack, typename LeafFn, typename InnerFn>
void Bvh<Node>::intersect(Ray<Scalar, Node::dimension>& ray, Index start, Stack& stack, LeafFn&& leaf_fn, InnerFn&& inner_fn) const {
    auto inv_dir = ray.get_inv_dir();
    auto inv_org = -inv_dir * ray.org;
    auto inv_dir_pad = Ray<Scalar, Node::dimension>::pad_inv_dir(inv_dir);
    auto octant = ray.get_octant();

    auto intersect_node = [&] (const Node& node) {
        return IsRobust
            ? node.intersect_robust(ray, inv_dir, inv_dir_pad, octant)
            : node.intersect_fast(ray, inv_dir, inv_org, octant);
    };

    stack.push(start);
restart:
    while (!stack.is_empty()) {
        auto top = stack.pop();
        while (top.prim_count == 0) {
            auto& left  = nodes[top.first_id];
            auto& right = nodes[top.first_id + 1];

            inner_fn(left, right);

            auto intr_left  = intersect_node(left);
            auto intr_right = intersect_node(right);

            bool hit_left  = intr_left.first <= intr_left.second;
            bool hit_right = intr_right.first <= intr_right.second;

            if (hit_left) {
                auto near = left.index;
                if (hit_right) {
                    auto far = right.index;
                    if (!IsAnyHit && intr_left.first > intr_right.first)
                        std::swap(near, far);
                    stack.push(far);
                }
                top = near;
            } else if (hit_right)
                top = right.index;
            else [[unlikely]]
                goto restart;
        }

        [[maybe_unused]] auto was_hit = leaf_fn(top.first_id, top.first_id + top.prim_count);
        if constexpr (IsAnyHit) {
            if (was_hit) return;
        }
    }
}```

#

This is

#

the beast

#

That I must implement

#

somehow KEKW

frank sail Jul 21, 2023, 9:06 PM

#

goto frog_sweat

wicked notch Jul 21, 2023, 9:07 PM

#

I won't do that

#

I will shrimply return

raven orchid Jul 21, 2023, 9:14 PM

#

For this one, what are the args?

ray = bvh_ray(as_vec3(point + direction * 0.5f), as_vec3(direction), 0.1f);

#

is it new position, direction, idk last one lol

wicked notch Jul 21, 2023, 9:16 PM

#

tmin

raven orchid Jul 21, 2023, 9:18 PM

#

wicked notch ```cpp const auto normal = glm::normalize( n0 * bary.x + n1 * bary.y + ...

this one looks kind of right to me

#

except

#

mult by tmax seems weird

wicked notch Jul 21, 2023, 9:21 PM

#

if the ray intersects a triangle

#

tmax is the distance the ray had to travel to intersect it

raven orchid Jul 21, 2023, 9:21 PM

#

oh ok

wicked notch Jul 21, 2023, 9:21 PM

#

template <typename T>
std::optional<std::pair<T, T>> PrecomputedTri<T>::intersect(Ray<T, 3>& ray, T tolerance) const {
    auto c = p0 - ray.org;
    auto r = cross(ray.dir, c);
    auto inv_det = static_cast<T>(1.) / dot(n, ray.dir);

    auto u = dot(r, e2) * inv_det;
    auto v = dot(r, e1) * inv_det;
    auto w = static_cast<T>(1.) - u - v;

    // These comparisons are designed to return false
    // when one of t, u, or v is a NaN
    if (u >= tolerance && v >= tolerance && w >= tolerance) {
        auto t = dot(n, c) * inv_det;
        if (t >= ray.tmin && t <= ray.tmax) {
            ray.tmax = t;
            return std::make_optional(std::pair<T, T> { u, v });
        }
    }

    return std::nullopt;
}```

raven orchid Jul 21, 2023, 9:21 PM

#

I was thinking you had tmin, tmax as bounds and t was the hit point

wicked notch Jul 21, 2023, 9:21 PM

#

You can see it here

#

yeah, this lib does ray.tmax = t

raven orchid Jul 21, 2023, 9:21 PM

#

ah ok

frank sail Jul 21, 2023, 9:21 PM

#

Tmin of .1 is really high

#

I guess they also use that to prevent self intersection, but it's not as good as the normal offset method

wicked notch Jul 21, 2023, 9:24 PM

#

yeah I'm using both

#

actually using tmin = 0.001 fixed peter panning

#

I don't know why I didn't think of that

#

it actually looks like a proper cornell box now

#

With both offset and small tmin

#

This is with 64spp though

#

Otherwise the image is still dark

frank sail Jul 21, 2023, 9:27 PM

#

you can probably eliminate tmin entirely if you have the normal offset

wicked notch Jul 21, 2023, 9:28 PM

#

The stupid band of clumped pixels is still here though

frank sail Jul 21, 2023, 9:29 PM

#

hmm

#

what rng are you using

wicked notch Jul 21, 2023, 9:29 PM

#

uhh

#

yeah probably a bad idea to use C++'s mersenne twister isn't it? bleakekw

#

For the random directions I'm using a normal distribution btw

frank sail Jul 21, 2023, 9:32 PM

#

it's battle tested at least

wicked notch Jul 21, 2023, 9:32 PM

#

I'll plug in PCG

frank sail Jul 21, 2023, 9:32 PM

#

so that's probably not failing here

wicked notch Jul 21, 2023, 9:33 PM

#

see if it's any different

raven orchid Jul 21, 2023, 9:35 PM

#

wonder why it's only on two of the walls but not the third wall or the box

wicked notch Jul 21, 2023, 9:52 PM

#

PCG actually fixed everything

#

amazing

frank sail Jul 21, 2023, 9:55 PM

#

weird but ok froge

#

maybe mersenne twister has some bias

wicked notch Jul 21, 2023, 10:06 PM

#

perhaps

#

I still need a ridiculous amount of samples per pixel to make the image non dark

frank sail Jul 21, 2023, 10:07 PM

#

I think it's normal to appear dark until you denoise it or take a lot of samples

wicked notch Jul 21, 2023, 10:08 PM

#

This is with 4spp for eg

frank sail Jul 21, 2023, 10:08 PM

#

we register the darkness more than the pixels that are 100x bright as they should be

#

hmm

#

it has surprisingly little noise for being 4spp

#

or is this with your temporal filter

wicked notch Jul 21, 2023, 10:10 PM

#

My "temporal filter" stops working after a while

#

I currently do this:

void main() {
    const vec3 old = texture(color[0], uv).rgb;
    const vec3 new = texture(color[1], uv).rgb;

    const float weight = 1.0 / float(frame + 1);
    o_pixel = vec4(mix(old, new, weight), 1.0);
}```

#

It's still this thing

#

it "converges" after 100 frames or so

frank sail Jul 21, 2023, 10:10 PM

#

what format is your texture

wicked notch Jul 21, 2023, 10:10 PM

#

RGBA8

frank sail Jul 21, 2023, 10:10 PM

#

well that's gonna converge terribly

wicked notch Jul 21, 2023, 10:11 PM

#

Do I have to make the texture itself RGBA32F?

frank sail Jul 21, 2023, 10:11 PM

#

use RGBA32F and then tonemap to RGBA8 for display

wicked notch Jul 21, 2023, 10:11 PM

#

I am doing tonemapping on the CPU KEKW

#

Also

frank sail Jul 21, 2023, 10:11 PM

#

well that's fine as long as you don't accumulate with low precision values

wicked notch Jul 21, 2023, 10:11 PM

#

My tonemap is this color /= color + 1.0f;

#

amazing

frank sail Jul 21, 2023, 10:12 PM

#

it works

#

and is better than aces or whatever dumb """filmic""" "tone"mapper for the purpose of actually seeing what color is produced

#

but yeah my main recommendation is to accumulate RGBA32F values

#

second recommendation is to accumulate before tonemap (so tonemap can still output to RGBA8 buffer)

wicked notch Jul 21, 2023, 10:14 PM

#

I will accumulate before tonemap and srgb

#

and then do another fullscreen tri to display

frank sail Jul 21, 2023, 10:15 PM

#

btw are you doing any sort of gamma compression/encoding/OETF thingy

wicked notch Jul 21, 2023, 10:15 PM

#

just srgb conversion after tonemap

frank sail Jul 21, 2023, 10:15 PM

#

ok good

#

then your thingy will be Perfect and require no further changes after you do the accumulation thing

wicked notch Jul 21, 2023, 10:28 PM

#

shockingly good

#

4 samples per pixel

#

I'll just use RGBA32 attachments for anything (color related) now bleakekw

#

The temporal accumulation still stops after a while

frank sail Jul 21, 2023, 10:32 PM

#

yeah that's normal

#

you could also try switching to exponential accumulation instead of linear after a certain number of frames so the contribution of new frames doesn't approach 0

#

e.g. after 100 frames switch to constant .01 factor instead of using 1/frames (btw I do not know if this will make it look better)

wicked notch Jul 21, 2023, 10:37 PM

#

is there anything more clamplicated

frank sail Jul 21, 2023, 10:38 PM

#

no

wicked notch Jul 21, 2023, 10:38 PM

#

rip

#

how do I make it more pretty then

#

without making samples go up

frank sail Jul 21, 2023, 10:41 PM

#

denoising

#

and taking better samples (ones that are more likely to contribute light)

wicked notch Jul 21, 2023, 10:41 PM

#

both of which are stupidly clamplicated I assume

frank sail Jul 21, 2023, 10:42 PM

#

somewhat

#

I haven't made a decent path tracer so idk the mechanics of sampling algorithms

#

But I can comprehend denoisers since I made one

#

And the best ones today consist of two key parts: temporal reuse and spatial reuse (AKA a blur)

wicked notch Jul 21, 2023, 10:44 PM

#

How does temporal reuse work

frank sail Jul 21, 2023, 10:44 PM

#

It's what you're doing

wicked notch Jul 21, 2023, 10:44 PM

#

amazing

#

So I just gotta blur the shit out of my image then?

frank sail Jul 21, 2023, 10:44 PM

#

Yeah lol

#

Well

wicked notch Jul 21, 2023, 10:44 PM

#

beautiful

frank sail Jul 21, 2023, 10:45 PM

#

Just the noisy parts

wicked notch Jul 21, 2023, 10:45 PM

#

frog_sweat

#

That's the clamplicated part

#

hm

frank sail Jul 21, 2023, 10:46 PM

#

What I mean is that you want to blur irradiance

#

Because some aspects of the scene have no noise, like the surface material

#

And you don't want to blur the albedo, for example

wicked notch Jul 21, 2023, 10:47 PM

#

hm

#

How do I blur just the light rays thonk

frank sail Jul 21, 2023, 10:48 PM

#

Here's what you do

#

You trace normally, but don't apply the cosine or albedo factors of the first bounce until after you denoise

#

So you're looking at the "incoming light" of the surface the eye sees, essentially

#

I can show a pic of how it should look prior to denoising in a sec

wicked notch Jul 21, 2023, 11:10 PM

#

raytracing in summer be like

#

Anyways

#

I have sponza

#

#

The most basic of path tracers can do this KEKW

raven orchid Jul 21, 2023, 11:28 PM

#

Simplest would probably be:

nearest neighbor average of irradiance
add albedo to step 1
temporally accumulate

#

Then steps 1 and 3 are the subject of lots of research papers lol

finite yacht Jul 21, 2023, 11:30 PM

#

wicked notch

amazing, which res and how much fps?

wicked notch Jul 21, 2023, 11:30 PM

#

1280x720

#

fps are 0 KEKW

#

it's one frame every 30 seconds or so

#

The intersection itself isn't bad

finite yacht Jul 21, 2023, 11:31 PM

#

at 1spp?

wicked notch Jul 21, 2023, 11:31 PM

#

It's the looping over all pixels, for all samples, for all bounces

#

64 spp

#

16 bounces

finite yacht Jul 21, 2023, 11:31 PM

#

wicked notch 64 spp

ah ok

wicked notch Jul 21, 2023, 11:34 PM

#

at 1spp I can totally move around

#

incredible honestly lol

#

maybe 2 or 3 fps

finite yacht Jul 21, 2023, 11:35 PM

#

yeah thats actually really good

raven orchid Jul 21, 2023, 11:37 PM

#

What’s the frame rate if you do

#

1spp and max 3 bounce?

wicked notch Jul 21, 2023, 11:37 PM

#

framerate is constant when moving around

#

1spp and 4 bounces

raven orchid Jul 21, 2023, 11:38 PM

#

1 spp 4 bounce = 3 fps?

wicked notch Jul 21, 2023, 11:38 PM

#

yes

#

720p

#

I was wondering though

#

can this be classified as "irradiance"

#

after all it's just how much light a given pixel has

#

could I use this as an "irradiance mask", blur it and then apply albedo and all the other stuff

frank sail Jul 21, 2023, 11:41 PM

#

Possibly

raven orchid Jul 21, 2023, 11:41 PM

#

Yeah you could and it would preserve texture details but your final result would be very binary

frank sail Jul 21, 2023, 11:42 PM

#

It should contain some color from bounce light though

wicked notch Jul 21, 2023, 11:42 PM

#

base color?

frank sail Jul 21, 2023, 11:42 PM

#

E.g. the floor next to the curtains should be colored

#

Not base color

#

Color from bounces (incoming light/irradiance)

wicked notch Jul 21, 2023, 11:43 PM

#

ah the color of the light?

#

or am I stupid

#

No I'm definitely stupid

wicked notch Jul 21, 2023, 11:47 PM

#

frank sail Not base color

sir I'm not sure what this means

#

Do you mean the color of the light?

frank sail Jul 21, 2023, 11:49 PM

#

ok I thought you meant base color as in the material

wicked notch Jul 21, 2023, 11:49 PM

#

yes I meant that

frank sail Jul 21, 2023, 11:49 PM

#

the surface you are looking at should basically not be factored in the color which is being denoised

wicked notch Jul 21, 2023, 11:49 PM

#

the base color factor in a gltf material

frank sail Jul 21, 2023, 11:50 PM

#

well you don't want that

#

lemme show you a pic of fwog in renderdoc

wicked notch Jul 21, 2023, 11:50 PM

#

damn I'm not following at all bleakekw

wicked notch Jul 21, 2023, 11:50 PM

#

frank sail lemme show you a pic of fwog in renderdoc

yes froge

frank sail Jul 21, 2023, 11:52 PM

#

building it

wicked notch Jul 21, 2023, 11:53 PM

#

I am sipping coffee while I await and look at my beautiful sponza

frank sail Jul 21, 2023, 11:53 PM

#

uh 2am coffee?

wicked notch Jul 21, 2023, 11:53 PM

#

honestly path tracing is epic KEKW

wicked notch Jul 21, 2023, 11:53 PM

#

frank sail uh 2am coffee?

ye why not

#

I can't recall the last time I've had 8 hrs of sleep bleakekw

frank sail Jul 21, 2023, 11:54 PM

#

I just remembered that fwog has a button to skip albedo modulation

wicked notch Jul 21, 2023, 11:55 PM

#

ight so what am I looking at

frank sail Jul 21, 2023, 11:55 PM

#

so that's how it looks if I don't multiply the light value by the albedo of the first-bounce surface

#

that's essentially the color that gets denoised

#

actually here's how it looks before any filtering

wicked notch Jul 21, 2023, 11:56 PM

#

ye but I still need to sample the texture and tint the ray color right?

#

Otherwise where do I get the red from

frank sail Jul 21, 2023, 11:56 PM

#

but you only do that after you denoise

wicked notch Jul 21, 2023, 11:56 PM

#

So how do I get the red before denoising?

frank sail Jul 21, 2023, 11:56 PM

#

the red comes from secondary bounces, which are allowed to sample albedo and shiz

wicked notch Jul 21, 2023, 11:57 PM

#

ah

#

so only secondary bounces can shrimple albedo

frank sail Jul 21, 2023, 11:57 PM

#

it's just the primary bounce that contains high-frequency surface info that needs to be preserved

wicked notch Jul 21, 2023, 11:57 PM

#

just to clarify

#

the "primary bounce" is the one from the camera to the surface or from the one after that

frank sail Jul 21, 2023, 11:58 PM

#

the former (the very first surface the ray from the camera hits)

wicked notch Jul 21, 2023, 11:58 PM

#

ok good

frank sail Jul 21, 2023, 11:58 PM

#

btw I have an example of what it looks like if you don't demodulate albedo in your denoiser

#

wicked notch Jul 21, 2023, 11:59 PM

#

let's see

frank sail Jul 21, 2023, 11:59 PM

#

actually I'm not even denoising, so it would look worse than that

#

here is with proper albedo demodulation (plus denoising)

wicked notch Jul 21, 2023, 11:59 PM

#

I see, got it

#

does "demodulation" mean the thing we discussed just earlier

frank sail Jul 22, 2023, 12:00 AM

#

basically your textured become smudged ass if you don't demodulate

#

ye

wicked notch Jul 22, 2023, 12:00 AM

#

i.e the thing where secondary bouces sample albedo and all that

frank sail Jul 22, 2023, 12:01 AM

#

also you're apparently not supposed to apply the cosine term until after denoising

#

the surface2eye cosine term I mean

wicked notch Jul 22, 2023, 12:01 AM

#

I have no idea what the cosine term is bleakekw

#

ah alright

frank sail Jul 22, 2023, 12:01 AM

#

uh the one where you weight the contribution by the cosine of the angle

#

something something projected area

wicked notch Jul 22, 2023, 12:01 AM

#

yes got it

#

amazing so denoising is another truck full of worms

#

beautiful

#

Well that'll come after I force the GPU to trace my bvh

frank sail Jul 22, 2023, 12:03 AM

#

btw here is another explanation of this demodulation thingy (just like 15 seconds)
https://youtu.be/2GYXuM10riw?t=265

YouTube

SIGGRAPH Advances in Real-Time Rendering

Radiance Caching for Real-Time Global Illumination

This talk will present an efficient and high-quality Final Gather for fully dynamic Global Illumination with ray tracing, targeted at next generation consoles and shipping in Unreal Engine 5. Part of the SIGGRAPH 2021 Advances in Real-Time Rendering in Games course ( http://advances.realtimerendering.com/).

Hardware Ray Tracing provides a new ...

▶ Play video

#

well ignore his words and just look at the slides KEKW

raven orchid Jul 22, 2023, 12:03 AM

#

That’s such a cool presentation

#

My take away is that lumen is basically a real time miracle

frank sail Jul 22, 2023, 12:04 AM

#

the point is that geometry normals are incoherent (they have no spatial coherence), but the light is basically a smooth gradient. That means applying the normals (via the cosine term) will make your luminance incoherent and thus harder to denoise

wicked notch Jul 22, 2023, 12:06 AM

#

the only miracle here is that I am still awake

frank sail Jul 22, 2023, 12:06 AM

#

my explanation sucks, but hopefully it gives a geometric intuition

wicked notch Jul 22, 2023, 12:06 AM

#

my monke brain needs to impl GPU trasversal

frank sail Jul 22, 2023, 12:06 AM

#

wicked notch the only miracle here is that I am still awake

by the power of covfefe

wicked notch Jul 22, 2023, 12:32 AM

#

Alright I don't think I can continue bleakekw

#

I can feel parts of my brain shutting off

#

It is time to schlepp

frank sail Jul 22, 2023, 12:32 AM

#

gn

minor root Jul 22, 2023, 9:12 AM

#

lvstri speedrunning graphics algorithms 100% completion

wicked notch Jul 22, 2023, 9:30 AM

#

This speedrun has been months long though bleakekw

#

And nowhere near completion

minor root Jul 22, 2023, 9:34 AM

#

you are fast af though

frank sail Jul 22, 2023, 9:35 AM

#

apparently that's what happens when you ignore sleep and ingest caffeine

twin bough Jul 22, 2023, 11:38 AM

#

Where can I get this superpower

wicked notch Jul 22, 2023, 11:44 AM

#

I use super special coffee beans imbued with various uh, substances

#

||my lawyer requires me to specify that this is a joke||

twin bough Jul 22, 2023, 11:44 AM

#

man seeing ur progress makes me wish im not working on an old ass engine

#

i actually dont drink coffee

#

maybe thats whats missing

wicked notch Jul 22, 2023, 11:47 AM

#

My progress is being hindered by how cool this sponza looks btw

#

I can't stop looking at it from different angles bleakekw

#

I know this has been done countless times but it's epic seeing it myself

twin bough Jul 22, 2023, 11:49 AM

#

noice

#

something about lighting only renders makes me happy

wispy spear Jul 22, 2023, 11:51 AM

#

rendered like that it do be looking more interesting than the usual sponzaism

wicked notch Jul 22, 2023, 3:42 PM

#

I 🅱️ushed the thing btw

#

https://github.com/LVSTRI/Raytracer If anyone is brave enough to try it (it will make your CPU sweat a little)

#

I wonder if this is how cornell box should look with albedo demodulation

#

I'm only tinting the ray color after the first bounce

wispy spear Jul 22, 2023, 3:46 PM

#

what is this thing

#

[build] ModuleNotFoundError: No module named 'jinja2'

#

ah

#

glad2

wicked notch Jul 22, 2023, 3:47 PM

#

the same error as ever KEKW

wispy spear Jul 22, 2023, 3:50 PM

#

arch cant seem to find python-jinja2 ;p

wicked notch Jul 22, 2023, 3:50 PM

#

I think you can just install it through pip

wispy spear Jul 22, 2023, 3:51 PM

#

thats the thing

#

pip wants you to install it via python-packagename using the package manager of the distro

wicked notch Jul 22, 2023, 3:51 PM

#

smh python

wispy spear Jul 22, 2023, 3:51 PM

#

maybe i should setup a build container in the future, all this deps bs is starting to annoy me

#

deccer@rootfs Raytracer]$ pip install jinja2
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try 'pacman -S
    python-xyz', where xyz is the package you are trying to
    install.

    If you wish to install a non-Arch-packaged Python package,
    create a virtual environment using 'python -m venv path/to/venv'.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip.

    If you wish to install a non-Arch packaged Python application,
    it may be easiest to use 'pipx install xyz', which will manage a
    virtual environment for you. Make sure you have python-pipx
    installed via pacman.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

#

: )

#

[deccer@rootfs Raytracer]$ sudo pacman -S python-jinja2
error: target not found: python-jinja2

#

heh

wicked notch Jul 22, 2023, 3:55 PM

#

I guess you could use pipx?

wispy spear Jul 22, 2023, 3:55 PM

#

tf is pipx now

#

ah

wicked notch Jul 22, 2023, 3:55 PM

#

I dunno

wispy spear Jul 22, 2023, 3:55 PM

#

pip3

wicked notch Jul 22, 2023, 3:55 PM

#

it may be easiest to use 'pipx install xyz', which will manage a
virtual environment for you. Make sure you have python-pipx
nstalled via pacman.```

wispy spear Jul 22, 2023, 3:56 PM

#

because python people are idiots

#

python2 != python3

#

and pip != pip3

#

same error

wicked notch Jul 22, 2023, 3:56 PM

#

amazing

wispy spear Jul 22, 2023, 3:57 PM

#

ill replace your glad cmakeism with the one from my cmake template

wicked notch Jul 22, 2023, 3:57 PM

#

ye probably easiest

minor root Jul 22, 2023, 3:59 PM

#

oh that shit

#

yeah python is a mess

wispy spear Jul 22, 2023, 4:01 PM

#

hmm alot of std::ranges isms gcc 13 cant seem to handle either

#

wicked notch Jul 22, 2023, 4:02 PM

#

weird

wispy spear Jul 22, 2023, 4:02 PM

#

clang 15 has no trouble there

#

only doesnt like this one

wicked notch Jul 22, 2023, 4:07 PM

#

I'll just remove the ranges

#

you can pull whenever

wispy spear Jul 22, 2023, 4:13 PM

#

[build] /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/bits/stl_iterator.h:2618:35: error: missing 'typename' prior to dependent type name 'iterator_traits<_It>::iterator_category'
[build]       { using iterator_category = iterator_traits<_It>::iterator_category; };
[build]                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
``` remains

#

no idea what to make of it

wicked notch Jul 22, 2023, 4:13 PM

#

thonk

#

could you post the full error

#

with the myriad of "notes" the compiler spews out

wispy spear Jul 22, 2023, 4:14 PM

#

gcc builds fine now

wicked notch Jul 22, 2023, 4:14 PM

#

amazing

#

C++ compilers

#

™️

wispy spear Jul 22, 2023, 4:14 PM

#

[build] [27/28  96% :: 2.066] Building CXX object CMakeFiles/BVH.dir/main.cpp.o
[build] FAILED: CMakeFiles/BVH.dir/main.cpp.o 
[build] /usr/bin/clang++ -DGLM_FORCE_AVX2 -DGLM_FORCE_DEPTH_ZERO_TO_ONE -DGLM_FORCE_RADIANS -DGLM_FORCE_RIGHT_HANDED -I/home/deccer/Personal/Code/External/Raytracer/deps/cgltf -I/home/deccer/Personal/Code/External/Raytracer/deps/bvh/src/bvh/v2/../.. -I/home/deccer/Personal/Code/External/Raytracer/deps/glm -I/home/deccer/Personal/Code/External/Raytracer/deps/glfw/include -I/home/deccer/Personal/Code/External/Raytracer/build/_deps/glad-build/include -g -std=gnu++2b -loop-vectorize -march=native -mmmx -msse -msse2 -msse3 -mssse3 -msse4 -msse4a -msse4.1 -msse4.2 -mavx -mavx2 -msha -maes -MD -MT CMakeFiles/BVH.dir/main.cpp.o -MF CMakeFiles/BVH.dir/main.cpp.o.d -o CMakeFiles/BVH.dir/main.cpp.o -c /home/deccer/Personal/Code/External/Raytracer/main.cpp
[build] clang-15: warning: -loop-vectorize: 'linker' input unused [-Wunused-command-line-argument]
[build] In file included from /home/deccer/Personal/Code/External/Raytracer/main.cpp:1:
[build] In file included from /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/filesystem:48:
[build] In file included from /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/bits/fs_fwd.h:35:
[build] In file included from /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/system_error:43:
[build] In file included from /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/stdexcept:39:
[build] In file included from /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/string:48:
[build] /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/bits/stl_iterator.h:2618:35: error: missing 'typename' prior to dependent type name 'iterator_traits<_It>::iterator_category'
[build]       { using iterator_category = iterator_traits<_It>::iterator_category; };
[build]                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[build] 1 error generated.

wicked notch Jul 22, 2023, 4:15 PM

#

??

wispy spear Jul 22, 2023, 4:16 PM

#

exactly

#

weird that it takes headers from gcc

#

i thought clang is its o wn shit

wicked notch Jul 22, 2023, 4:17 PM

#

Linux uses libstdc++ as the default stdlib

#

if you want to use clang's you need to explicitly specify that

#

-libc++ or something

wispy spear Jul 22, 2023, 4:17 PM

#

i thought cmake will take care of that when schwitching compilers/kits

#

the gcc variant builds, but doesnt run

wicked notch Jul 22, 2023, 4:18 PM

#

runtime error?

wispy spear Jul 22, 2023, 4:18 PM

#

The program '/home/deccer/Personal/Code/External/Raytracer/build/BVH' has exited with code 377 (0x00000179).

#

oh

wicked notch Jul 22, 2023, 4:19 PM

#

it's probably the target_compile_options or shader/model paths

wispy spear Jul 22, 2023, 4:19 PM

#

i did update my s ystem earlier today, and that completely fucked with my gfx drivers

#

let me reboot

#

yup

#

now it runs

wicked notch Jul 22, 2023, 4:27 PM

#

Does your cpu want to die right now

#

bleakekw

wispy spear Jul 22, 2023, 5:09 PM

#

not really

#

but all cores are active 🙂

wicked notch Jul 22, 2023, 9:09 PM

#

ladies and gents

#

#version 460
#extension GL_ARB_separate_shader_objects : enable
#extension GL_EXT_scalar_block_layout : enable
#extension GL_EXT_buffer_reference : enable

layout (location = 0) in vec2 i_uv;

layout (location = 0) out vec4 o_pixel;

layout (scalar, buffer_reference) restrict readonly buffer b_camera_block {
    mat4 projection;
    mat4 view;
    mat4 pv;
    vec4 position;
} camera;

layout (push_constant) uniform u_pc_block {
    b_camera_block camera_ptr;
};

void main() {
    o_pixel = vec4(i_uv.x, 1.0 - i_uv.y, 0.0, 1.0);
}``` we got a shader

#

we got uv coordinates

#

we got the camera

#

we don't got the BVH though KEKW

wispy spear Jul 22, 2023, 9:21 PM

#

i like the neat naming

wicked notch Jul 22, 2023, 11:12 PM

#

Having renderdoc is so good

wicked notch Jul 22, 2023, 11:59 PM

#

I don't know who or where the person who decided on bitfields is

#

But I hope he will forever regret this decision

frank sail Jul 23, 2023, 12:04 AM

#

lodge a complaint with Dennis Ritchie

wicked notch Jul 23, 2023, 12:43 AM

#

Jaker

#

do you reckon this is how cornell box should look with albedo demodulation?
#1090390868449558618 message

frank sail Jul 23, 2023, 12:49 AM

#

That looks probably roughly correct

wicked notch Jul 23, 2023, 12:50 AM

#

The ray color is always getting tinted by the light's color though

#

Even the primary bounce

#

Should that also be deferred?

frank sail Jul 23, 2023, 1:01 AM

#

that's good

wicked notch Jul 23, 2023, 1:16 PM

#

most GPU inefficient ray-tri intersection KEKW

#

intersection_result_t primitive_intersect(inout ray_t ray, in uint start, in uint end) {
    uint prim_id = -1;
    intersection_result_t result = intersection_result_t(prim_id, vec3(0.0));
    for (uint i = start; i < end; ++i) {
        prim_id = uint(bvh_fetch_primitive_id(i));
        const vec3[3] v012 = vec3[3](
            vec3_from_float(vertices_ptr.data[prim_id * 3 + 0].position),
            vec3_from_float(vertices_ptr.data[prim_id * 3 + 1].position),
            vec3_from_float(vertices_ptr.data[prim_id * 3 + 2].position));
        const vec3 p0 = v012[0];
        const vec3 e10 = p0 - v012[1];
        const vec3 e20 = v012[2] - p0;
        const vec3 normal = cross(e10, e20);

        const vec3 center = p0 - ray.origin;
        const vec3 r = cross(ray.direction, center);
        const float inv_det = 1.0 / dot(normal, ray.direction);

        const float u = dot(r, e20) * inv_det;
        const float v = dot(r, e10) * inv_det;
        const float w = 1.0 - u - v;

        if (u >= FLT_EPS && v >= FLT_EPS && w >= FLT_EPS) {
            const float t = dot(normal, center) * inv_det;
            if (t >= ray.t_min && t <= ray.t_max) {
                ray.t_max = t;
                result.prim_id = prim_id;
                result.barycentric = vec3(w, u, v);
            }
        }
    }
    return result;
}```

#

We do got le tringle though

#

GPU accelerated, raytraced tringle

#

Now let's draw the rest of the fucking owl

wicked notch Jul 23, 2023, 1:48 PM

#

mmm yes

#

cronlel bxo

#

Also known as cornell box

glass sphinx Jul 23, 2023, 2:00 PM

#

ikea cornel box

#

you need to assemble it yourself

#

but half the parts are missing

#

how can this even happen

wispy spear Jul 23, 2023, 2:02 PM

#

KEKW

wicked notch Jul 23, 2023, 2:10 PM

#

glass sphinx how can this even happen

I've no clue KEKW

wispy spear Jul 23, 2023, 2:31 PM

#

glass sphinx how can this even happen

looks more like froyok's volume shadows bleed through channel walls 😄

glass sphinx Jul 23, 2023, 2:32 PM

#

lmao

#

its leaking

wicked notch Jul 23, 2023, 2:58 PM

#

Alright I've found the issue

#

And it's not good

#

at all

#

I fixedn't

#

It's better than before for sure KEKW

#

I'm not sure how or why

#

But it looks like I'm doing anyhit or something, instead of closest hit

#

What the hell is this KEKW

glass sphinx Jul 23, 2023, 3:17 PM

#

wicked notch I fixedn't

how fast does this run

wicked notch Jul 23, 2023, 3:18 PM

#

It's a bit broken so I'm not sure perf is meaningful but it do be running quite slow

#

1.25ms for sponza

#

Fortunately it doesn't scale linearly with triangle count

#

logN ftw

#

2.5ms for intel sponza

#

With the tree, curtains and leaves

#

Weird occupancy graph though, the hell happened in the middle

#

It would be very cool if the API to use the RT cores directly were exposed

#

But I guess they need their internal BVH to work correctly

glass sphinx Jul 23, 2023, 3:27 PM

#

you already implemented a bvh???

#

10xer

wicked notch Jul 23, 2023, 3:27 PM

#

madmann did it for me KEKW

#

I just reimplemented the tracing on the GPU

#

I still don't understand building algorithms unfortunately 😦

glass sphinx Jul 23, 2023, 3:28 PM

#

aah

#

cool tho

#

was it easy to port the tracing and reuse the bvh?

wicked notch Jul 23, 2023, 3:28 PM

#

Yeah, the bvh itself is two vectors

#

very easy to send to the GPU

#

minus the garbage bitfield but we don't talk about that

#

The tracing algo is also very simple

glass sphinx Jul 23, 2023, 3:29 PM

#

nice

wicked notch Jul 23, 2023, 4:43 PM

#

eyyy

#

I got it

#

turns out I was overwriting an good intersection with a bad intersection if none were found KEKW

#

Lovely

#

Beautiful

#

I also optimized it a little

#

The intersection code is utter garbage though bleakekw

#

Poor occupancy, you can feel when there is a very divergent pixel KEKW

wicked notch Jul 23, 2023, 6:31 PM

#

Damn bleakekw

wicked notch Jul 23, 2023, 7:08 PM

#

lots of NaNs damn

wispy spear Jul 23, 2023, 7:28 PM

#

can you not interpolate between neighbors when center is nan? 🙂

#

or run a denoiser over that

wicked notch Jul 23, 2023, 7:37 PM

#

Nah this is a problem that must be fixed

#

hm

#

Not relying on NaNs doesn't solve the issue

#

frog_sweat

#

epic circular pattern

wispy spear Jul 23, 2023, 8:07 PM

#

ive seen that before

#

you were able to fix it then as well

wicked notch Jul 23, 2023, 8:08 PM

#

oh shit

#

I don't remember

#

frick

wispy spear Jul 23, 2023, 8:08 PM

#

feels like it was last wekeend

wicked notch Jul 23, 2023, 8:11 PM

#

I don't remember having these weird circles in my CPU raytracer thonk

#

maybe I am having a stroke

wispy spear Jul 23, 2023, 8:11 PM

#

perhaps not in the cpu raytracer, but i rember seeing these in context of your or jakers recent shizzles

raven orchid Jul 23, 2023, 8:30 PM

#

That’s a really cool pattern though

frank sail Jul 23, 2023, 8:34 PM

#

self intersection moment

wicked notch Jul 23, 2023, 8:37 PM

#

mfw it ain't

#

I offset the ray by a lot and I still get dumb circles

frank sail Jul 23, 2023, 8:39 PM

#

not self intersection moment

wicked notch Jul 23, 2023, 8:42 PM

#

You can see here I get circular patterns when I'm not intersecting a primitive at all #ray-tracing message

#

green = I hit at least 1 primitive
red = I hit no primitive whatsoever in any of the bounces

wicked notch Jul 23, 2023, 9:06 PM

#

turns out ray-node is bork

#

Investigating™️

wicked notch Jul 23, 2023, 10:24 PM

#

Investigation results are in

#

Bounding boxes are extremely small sometimes, when applying a min and max bound to them the circles stop

#

frank sail Jul 23, 2023, 10:25 PM

#

You should start adding debug visualizations in this renderer

wicked notch Jul 23, 2023, 10:26 PM

#

Also, I guess that precision on the GPU is inevitably lower or something, because the same bounding boxes work fine on the CPU

frank sail Jul 23, 2023, 10:26 PM

#

Like what I'm doing in ff (frogfood)

wicked notch Jul 23, 2023, 10:26 PM

#

frank sail You should start adding debug visualizations in this renderer

perhaps

#

I know the issue though, it's precision

#

Either precision, or I don't understand the ray-node intersection test

frank sail Jul 23, 2023, 10:27 PM

#

GPU floats don't intrinsically have less precision, though compilers seem to act as though --ffast-math is enabled

#

The standard guarantees some things about fp precision too

wicked notch Jul 23, 2023, 10:28 PM

#

hm

#

can I disable that somehow

frank sail Jul 23, 2023, 10:28 PM

#

Well check the spec to make sure I'm not bullshitting you first

#

But also, I don't think you can change that

#

See what guarantees you actually get

wicked notch Jul 23, 2023, 10:33 PM

#

NaNs are not required to be generated mfw

#

Any subnormal (denormalized) value input into a shader or potentially generated by any operation in a shader can be flushed to 0. mfw pt2

#

Oh come on
Operations including built-in functions that operate on a NaN are not required to return a NaN as the result.

#

Seriously

wicked notch Jul 23, 2023, 11:36 PM

#

GLSL saddens me

#

// precision issues require me to do this ugliness
const bool hit_left = intr_left.x - 0.000001 <= intr_left.y + 0.000001;
const bool hit_right = intr_right.x - 0.000001 <= intr_right.y + 0.000001;```

wicked notch Jul 23, 2023, 11:54 PM

#

At least sponza looks as nice as ever

frank sail Jul 23, 2023, 11:55 PM

#

heelll yee

delicate rain Jul 24, 2023, 12:12 AM

#

I second bvh vizualization, helped me solve bunch of bugs

wicked notch Jul 24, 2023, 12:13 AM

#

Ye it's probably the next or second next thing I will do

#

I kinda want to see some albedo

delicate rain Jul 24, 2023, 12:15 AM

#

I get it I get it 😄

frank sail Jul 24, 2023, 12:15 AM

#

just one more feature bro, then stuff to help me debug bleakekw

wicked notch Jul 24, 2023, 12:16 AM

#

bleakekw

#

I am not satisfied with my current solution btw

#

the adding of an epsilon adds the chance of traversing a lot more of the BVH than required

#

but I don't know how else I can address GLSL's special needs

#

there is no way to know what the internal spirv compiler will do

frank sail Jul 24, 2023, 12:18 AM

#

maybe you can slap the invariant keyword on some stuff

wicked notch Jul 24, 2023, 12:18 AM

#

I mean

#

everything is random bleakekw

#

I could dump the values of the bounding boxes on the C++ side and on the GLSL side

#

Through renderdoc

#

see if I have any loss of precision

frank sail Jul 24, 2023, 12:20 AM

#

try putting invariant on the output color and see if the epsilon hack is still needed

wicked notch Jul 24, 2023, 12:21 AM

#

I guess I should also remove BDA... (shader debugger doesn't work otherwise)

wicked notch Jul 24, 2023, 12:21 AM

#

frank sail try putting `invariant` on the output color and see if the epsilon hack is still...

I'll try

frank sail Jul 24, 2023, 12:21 AM

#

I've never used the keyword, so good luck

wicked notch Jul 24, 2023, 12:23 AM

#

amazing

#

btw

#

you can represent any floating point number in GLSL as you would in C++ right?

frank sail Jul 24, 2023, 12:24 AM

#

I think so

wicked notch Jul 24, 2023, 12:24 AM

#

for example, if I push const FLT_MIN, will it be the exact same?

frank sail Jul 24, 2023, 12:25 AM

#

the encoding is the same, yeah

#

IEEE-754 my beloved

wicked notch Jul 24, 2023, 12:25 AM

#

I mean the operations

#

a * b + c should be exact

frank sail Jul 24, 2023, 12:25 AM

#

the specs may offer different guarantees about that

#

particularly w.r.t. ULP precision

wicked notch Jul 24, 2023, 12:26 AM

#

I'm about to use fp64

frank sail Jul 24, 2023, 12:26 AM

#

why do you need such exact precision anyways

wicked notch Jul 24, 2023, 12:26 AM

#

uh

#

do you know tringles

#

they can make planes

frank sail Jul 24, 2023, 12:26 AM

#

yeah you need epsilon anywhere 🫄

wicked notch Jul 24, 2023, 12:27 AM

#

now it just so happens that the bounding box of a plane is smol on the y side

#

sometimes it's so smol the GPU freaks out

#

I'll try looking at some other BVH trasversal impls on the interwebs

#

perhaps they do clever things

frank sail Jul 24, 2023, 12:58 AM

#

#

The precise qualifier ensures that operations contributing to a variable’s value are done in their
stated order and with operator consistency.

#

I don't get how this differs from the invariant qualifier, but okay

#

well I guess invariant implies that certain optimizations can be done, they just need to be consistent

#

#

so I guess putting precise on your output will make all computations leading up to it precise as well, epic

#

I think that is a lot closer to the fp rules of C and C++

wicked notch Jul 24, 2023, 8:04 AM

#

amazing

wicked notch Jul 24, 2023, 8:42 AM

#

eyy we got the precision back!

#

IEEE754 my beloved

frank sail Jul 24, 2023, 8:45 AM

#

how did you do it?

wicked notch Jul 24, 2023, 8:45 AM

#

I spammed precise all over the intersection code

#

KEKW

frank sail Jul 24, 2023, 8:46 AM

#

I think it will propagate up if you just apply it to the output color, no?

wicked notch Jul 24, 2023, 8:46 AM

#

probably yeah

frank sail Jul 24, 2023, 8:46 AM

#

smh trying the hard thing before the easy thing 😄

wicked notch Jul 24, 2023, 8:46 AM

#

yep

#

finally

#

thank god Khronos noticed that someone might want a bit more precision bleakekw

frank sail Jul 24, 2023, 8:47 AM

#

perchance

wicked notch Jul 24, 2023, 9:44 AM

#

This path tracer really slows down my pc damn bleakekw

minor root Jul 24, 2023, 9:54 AM

#

i remember compiling the fsr2 c++ lib grinds my entire pc to a halt for a good 10 seconds

frank sail Jul 24, 2023, 9:56 AM

#

ah yeah those shader permutations be thicc

wicked notch Jul 24, 2023, 10:25 AM

#

dFdx and dFdy are undefined behavior in divergent control flow right?

#

Lucky for me, raytracing is anything but divergent, right guys?

#

bleakekw

frank sail Jul 24, 2023, 10:26 AM

#

wicked notch dFdx and dFdy are undefined behavior in divergent control flow right?

yes

#

and here it won't be "slightly" wrong, it will be horrifically wrong

wicked notch Jul 24, 2023, 10:27 AM

#

so horrifically wrong it causes a VK_ERROR_DEVICE_LOST

#

KEKW

frank sail Jul 24, 2023, 10:27 AM

#

I remember debugging a similar issue when I was using texture for SSR

wicked notch Jul 24, 2023, 10:28 AM

#

Anyways I got myself some albedo

#

Let me show this off to danny one sec

#

KEKW

frank sail Jul 24, 2023, 10:28 AM

#

which danny

wicked notch Jul 24, 2023, 10:28 AM

#

the one who's making a raytracer wit VK_KHR_ray_tracing

#

#1127583870167035944

frank sail Jul 24, 2023, 10:29 AM

#

were you guys racing or something

wicked notch Jul 24, 2023, 10:30 AM

#

nah I poking him to make sponza

#

because he procrastinated

#

so I made my own (jk, this is for learning BVHs KEKW )

#

In fact I'll work more on the BVH after this

#

maybe, maybe even make the building on the GPU

#

maybe though

#

I do love myself some

#

ground truth

wispy spear Jul 24, 2023, 10:41 AM

#

ye tiling on the floor looks like cobbled road 😛

summer gyro Jul 24, 2023, 11:25 AM

#

wicked notch Anyways I got myself some albedo

whats the perf ?

#

also is this the super sponza you made or regular sponza ?

wicked notch Jul 24, 2023, 11:29 AM

#

absolutely terrible KEKW

#

pure garbage

#

40ms for sponza

frank sail Jul 24, 2023, 11:32 AM

#

you better get used to it, because that's how the numbers typically look when doing GPU RT

wicked notch Jul 24, 2023, 11:32 AM

#

even with RTX™️?

frank sail Jul 24, 2023, 11:33 AM

#

Yes

wicked notch Jul 24, 2023, 11:34 AM

#

Hm

#

I hope danny makes his thingy work soon so we can compare 🅱️erf

summer gyro Jul 24, 2023, 11:36 AM

#

wicked notch 40ms for sponza

how many bounces tho
also sample count ? 👀

wicked notch Jul 24, 2023, 11:36 AM

#

1spp and 4 bounces bleakekw

summer gyro Jul 24, 2023, 11:36 AM

#

ahh

frank sail Jul 24, 2023, 11:37 AM

#

now do 2 bounces and 0.25 spp frogapprove

summer gyro Jul 24, 2023, 11:37 AM

#

wait 40ms for 1spp and 4 bounces ?
thats too much no ?

frank sail Jul 24, 2023, 11:37 AM

#

that is reasonable imo

wicked notch Jul 24, 2023, 11:37 AM

#

ye that's what I'm saying KEKW

summer gyro Jul 24, 2023, 11:38 AM

#

denoising + upscaling time smh

wicked notch Jul 24, 2023, 11:38 AM

#

1080p btw

#

perhaps that's the reason

#

but this is all trasversal overhead

frank sail Jul 24, 2023, 11:38 AM

#

yeah u need to do 240p

summer gyro Jul 24, 2023, 11:38 AM

#

ahh try at quater res ez perf ++

wicked notch Jul 24, 2023, 11:39 AM

#

I kinda want to move on to RT acceleration

#

But I have work to do here first

frank sail Jul 24, 2023, 11:39 AM

#

lol already sick of the perf

wicked notch Jul 24, 2023, 11:39 AM

#

BVH build on the GPU

frank sail Jul 24, 2023, 11:39 AM

#

you gotta optimize it for the frogfood implementation KEKW

summer gyro Jul 24, 2023, 11:41 AM

#

wicked notch I kinda want to move on to RT acceleration

I wonder how much faster will hardware rt be
cause at the end your kinda doing the same thing

wicked notch Jul 24, 2023, 11:42 AM

#

#

mfw

frank sail Jul 24, 2023, 11:43 AM

#

summer gyro I wonder how much faster will hardware rt be cause at the end your kinda doing t...

except certain bits of the hw are locked when you're not doing hw rt

wicked notch Jul 24, 2023, 11:43 AM

#

primary rays are fine too

#

It's the secondary & later that absolutely destroy 🅱️erf

frank sail Jul 24, 2023, 11:44 AM

#

classic

#

the sad thing is that it's faster to rasterize primary rays too, so rip the only fast part about GPU PT

wicked notch Jul 24, 2023, 11:45 AM

#

btw

#

I'm trying the albedo modulation thing

#

but your RSM thingy has a lot more red and green near the curtains

frank sail Jul 24, 2023, 11:46 AM

#

it won't do anything until you denoise fyi

wicked notch Jul 24, 2023, 11:46 AM

#

There is barely any red here

frank sail Jul 24, 2023, 11:46 AM

#

my scene was a little more optimal for getting the color bleed

#

since I angled the sun to only hit the curtains

summer gyro Jul 24, 2023, 11:48 AM

#

frank sail the sad thing is that it's faster to rasterize primary rays too, so rip the only...

:(

wicked notch Jul 24, 2023, 11:49 AM

#

You can kinda see the ground in the curtain lol

frank sail Jul 24, 2023, 11:49 AM

#

Try a different scene. I don't know exactly how it should look here

#

Make a scene where certain surfaces can only be illuminated by colored bounce light

wicked notch Jul 24, 2023, 3:07 PM

#

Should I upscale after accumulating or before accumulating? thonk

#

Also tonemapping, before or after upscaling?

frank sail Jul 24, 2023, 4:59 PM

#

Tonemap last

proven laurel Jul 24, 2023, 5:00 PM

#

frank sail Tonemap last

why tonemap after upscaling?

frank sail Jul 24, 2023, 5:01 PM

#

Cuz upscaling affects the pixel color in physical ways

wicked notch Jul 24, 2023, 7:06 PM

#

Alright

#

How do you debug a segfault in nvoglv64.dll? nervous

frank sail Jul 24, 2023, 7:06 PM

#

go up the stack and see which line of yours triggers it

wicked notch Jul 24, 2023, 7:07 PM

#

It's random

#

sometimes vkWaitForFences, sometimes vkQueueSubmit2 and sometimes vkCmdDraw

#

Also, the simple act of binding textures does this

#

Here's another ridiculous thing: If I change the render resolution it works fine sometimes bleakekw

wispy spear Jul 24, 2023, 7:11 PM

#

missing fence/barrier perhaps?

delicate rain Jul 24, 2023, 7:11 PM

#

https://tenor.com/view/sad-frown-rain-cat-gif-17035614

Tenor

wicked notch Jul 24, 2023, 7:12 PM

#

wispy spear missing fence/barrier perhaps?

Not sure, but a vkDeviceWaitIdle doesn't fix the issue so I don't think it's sync related

#

I'll try slapping some full barriers everywhere

wispy spear Jul 24, 2023, 7:12 PM

#

and then remove until it kicks you in th butt again

frank sail Jul 24, 2023, 7:12 PM

#

wicked notch sometimes vkWaitForFences, sometimes vkQueueSubmit2 and sometimes vkCmdDraw

btw that's the name of their opengl driver dll bleakekw

wicked notch Jul 24, 2023, 7:12 PM

#

amazing

#

There is not one line of OpenGL in there

#

how is it calling into OpenGL

wispy spear Jul 24, 2023, 7:13 PM

#

nvoglv64.dll

#

vulkan is just abstraction on top of opengl

frank sail Jul 24, 2023, 7:14 PM

#

opengl truly is a low-level api for nvidia

wicked notch Jul 24, 2023, 7:14 PM

#

As usual OpenGL trumps everything

wispy spear Jul 24, 2023, 7:14 PM

#

would be funny

#

vulkan just being highly optimized glCompileListNVs/glDrawListNVs

proven laurel Jul 24, 2023, 7:14 PM

#

frank sail btw that's the name of their opengl driver dll <:bleakekw:1082598350303539240>

ogl and vk is the same dll for nv

frank sail Jul 24, 2023, 7:15 PM

#

o 😳

proven laurel Jul 24, 2023, 7:15 PM

#

wicked notch Not sure, but a `vkDeviceWaitIdle` doesn't fix the issue so I don't think it's s...

does validation scream?

wicked notch Jul 24, 2023, 7:15 PM

#

No errors

#

Even with GPU assisted

#

I don't even have to sample any textures for the crash to happen, just bind a descriptor set and that's it KEKW

proven laurel Jul 24, 2023, 7:16 PM

#

just a sanity check

#

you are not destroying the resource you are waiting on are you?

#

Also you might be TDR'ing

wicked notch Jul 24, 2023, 7:17 PM

#

proven laurel you are not destroying the resource you are waiting on are you?

Nope, I have checks for that, everything is refcounted

#

No TDRs either

twin musk Jul 24, 2023, 7:17 PM

#

frank sail btw that's the name of their opengl driver dll <:bleakekw:1082598350303539240>

they implement vulkan in the same dll as their opengl driver lol

proven laurel Jul 24, 2023, 7:17 PM

#

this sort of nondeterminism smells like TDR though

frank sail Jul 24, 2023, 7:17 PM

#

twin musk they implement vulkan in the same dll as their opengl driver lol

I heard somewhere that they implement vulkan in terms of opengl, but I have no idea if that is a meme

wicked notch Jul 24, 2023, 7:17 PM

#

Let me try reducing the shader to nothing

frank sail Jul 24, 2023, 7:18 PM

#

I could see it being true in the early days of their vulkan support

proven laurel Jul 24, 2023, 7:18 PM

#

I think there is some truth to it

#

afaik that's the same reason why you get issues with windows that have an ogl context

twin musk Jul 24, 2023, 7:18 PM

#

i mean there has to be a reason why passing glsl in as shader module source without the ext used to work right

frank sail Jul 24, 2023, 7:18 PM

#

meanwhile, Vulkan is based off an API that AMD donated to Khronos yaymd

twin musk Jul 24, 2023, 7:19 PM

#

mantle revival in 2024 pls

proven laurel Jul 24, 2023, 7:19 PM

#

3dfx glide revival pls

twin musk Jul 24, 2023, 7:19 PM

#

can't have issues on nvidia cards if your api doesn't support them :)

wicked notch Jul 24, 2023, 7:20 PM

#

Ok so

#

Reducing the shader to nothing except a texture sample works fine

#

changing the resolution (either up or down) works fine (sometimes)

#

Not binding the set works fine

#

Sampling from texture 0 only is bork

#

NOT sampling at all and binding the set is bork (except if the shader is basically empty)

proven laurel Jul 24, 2023, 7:21 PM

#

bork as in crash?

wicked notch Jul 24, 2023, 7:21 PM

#

ye

#

I don't see any TDRs in the event viewer though

proven laurel Jul 24, 2023, 7:22 PM

#

Not sampling being an issue is weird

#

it might be some bad access (gpu based won't catch all of them)

wispy spear Jul 24, 2023, 7:22 PM

#

what happens if you reboot and try again

wicked notch Jul 24, 2023, 7:22 PM

#

I am not accessing the texture array in any way though

proven laurel Jul 24, 2023, 7:23 PM

#

oh wait

#

it's a texture array?

wicked notch Jul 24, 2023, 7:23 PM

#

Yeah, bindless

proven laurel Jul 24, 2023, 7:23 PM

#

array of texture descriptors or texture array

wicked notch Jul 24, 2023, 7:23 PM

#

It's variable count and partially bound

#

array of texture descriptors

proven laurel Jul 24, 2023, 7:24 PM

#

does the descriptor set contain anything

wicked notch Jul 24, 2023, 7:24 PM

#

yeah, the textures

#

I'll try with an empty set?

proven laurel Jul 24, 2023, 7:25 PM

#

Are you dynamically updating the size of the set

wicked notch Jul 24, 2023, 7:25 PM

#

No

proven laurel Jul 24, 2023, 7:25 PM

#

hm

wicked notch Jul 24, 2023, 7:25 PM

#

The set is written to once and never again

#

Btw binding an empty set works fine

proven laurel Jul 24, 2023, 7:27 PM

#

Btw. is VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT set as well?

wicked notch Jul 24, 2023, 7:27 PM

#

yes

proven laurel Jul 24, 2023, 7:28 PM

#

and the variable count binding is the last binding?

#

(not sure if validation checks for that)

wicked notch Jul 24, 2023, 7:28 PM

#

Last and only binding yes

#

I'll try binding only 1 (one) texture

wicked notch Jul 24, 2023, 7:31 PM

#

wicked notch I'll try binding only 1 (one) texture

This has resulted in failure

#

It still crashes

#

what the hell is going on

proven laurel Jul 24, 2023, 7:32 PM

#

can you remove the variable size bit?

wispy spear Jul 24, 2023, 7:33 PM

#

also the reboot will clean up bit perhaps

proven laurel Jul 24, 2023, 7:33 PM

#

if there was a driver crash definitely

wicked notch Jul 24, 2023, 7:33 PM

#

I did reboot

wispy spear Jul 24, 2023, 7:33 PM

#

ah

wicked notch Jul 24, 2023, 7:33 PM

#

probably didn't mention that

#

didn't fix 😦

wispy spear Jul 24, 2023, 7:34 PM

#

too bad 😦

#

was worf a try

#

https://tenor.com/view/i-do-not-understand-worf-star-trek-the-next-generation-i-dont-understand-a-thing-gif-23456164

Tenor

wicked notch Jul 24, 2023, 7:34 PM

#

I am thinking the shader has some kind of issue

#

Because if I shrimply output black, everything works fine

#

I've narrowed it down to BVH intersection

proven laurel Jul 24, 2023, 7:35 PM

#

what is the pipeline?

wicked notch Jul 24, 2023, 7:36 PM

#

if I call bvh_intersect, binding the set will crash

proven laurel Jul 24, 2023, 7:36 PM

#

Is it an rt pipeline?

wicked notch Jul 24, 2023, 7:36 PM

#

No it's a frag shader

#

regular old pipeline

#

I've narrowed it down further

#

It's the ray triangle intersection function

#

calling it will crash

proven laurel Jul 24, 2023, 7:38 PM

#

what exactly is the function doing

#

beyond arithmetic

#

because arithmetic should never cause a crash unless it is a tdr KEKW

wicked notch Jul 24, 2023, 7:38 PM

#

nothing, it's pure ALU

#

And apparently this is the bit that makes it die:

if (u >= -FLT_EPS && v >= -FLT_EPS && w >= -FLT_EPS) {
    const float t = dot(n, c) * inv_det;
    if (t >= ray.t_min && t <= ray.t_max) {
        const vec3 barycentric = vec3(w, u, v);
        const vec3 n0 = vec3_from_float(vertices_ptr.data[prim_id * 3 + 0].normal);
        const vec3 n1 = vec3_from_float(vertices_ptr.data[prim_id * 3 + 1].normal);
        const vec3 n2 = vec3_from_float(vertices_ptr.data[prim_id * 3 + 2].normal);
        const vec2 uv0 = vec2_from_float(vertices_ptr.data[prim_id * 3 + 0].uv);
        const vec2 uv1 = vec2_from_float(vertices_ptr.data[prim_id * 3 + 1].uv);
        const vec2 uv2 = vec2_from_float(vertices_ptr.data[prim_id * 3 + 2].uv);

        ray.t_max = t;
        result.prim_id = prim_id;
        result.barycentric = barycentric;
        result.position = vec3[](p0, p1, p2);
        result.normal = normalize(vec3(n0 * barycentric.x + n1 * barycentric.y + n2 * barycentric.z));
        result.uv = vec2[](uv0, uv1, uv2);
    }
}```

proven laurel Jul 24, 2023, 7:39 PM

#

is the vertex data valid

wicked notch Jul 24, 2023, 7:40 PM

#

yep

proven laurel Jul 24, 2023, 7:43 PM

#

idk how binding the set makes this here crash though

wispy spear Jul 24, 2023, 7:47 PM

#

is it possioble to run this glsl through some glsloptimizer and run the outcome of it?

wicked notch Jul 24, 2023, 8:00 PM

#

I fixed it

#

I'm not sure I like the fix though

wicked notch Jul 24, 2023, 8:01 PM

#

wispy spear is it possioble to run this glsl through some glsloptimizer and run the outcome ...

I wish there was an easy way to look at the spirv

#

https://shader-playground.timjones.io/ this no worky anymore sadly

wispy spear Jul 24, 2023, 8:02 PM

#

does it not have that expression-esque output?

wicked notch Jul 24, 2023, 8:02 PM

#

Oh shit

#

wait it worky

#

absolute pog

wispy spear Jul 24, 2023, 8:02 PM

#

ye it do

frank sail Jul 24, 2023, 8:03 PM

#

wicked notch <https://shader-playground.timjones.io/> this no worky anymore sadly

https://gpuopen.com/rga/

AMD GPUOpen

Radeon™ GPU Analyzer

Radeon GPU Analyzer is an offline compiler and performance analysis tool for DirectX®, Vulkan®, SPIR-V™, OpenGL® and OpenCL™.

#

download it

#

NOW

wicked notch Jul 24, 2023, 8:03 PM

#

Does it worky on NV?

#

I do not possess AMD HW unfortunately

frank sail Jul 24, 2023, 8:04 PM

#

it works without AMD drivers

wicked notch Jul 24, 2023, 8:04 PM

#

common AMD W

#

is there a way to uh

#

see spirv instead of AMD ISA?

#

frank sail Jul 24, 2023, 8:12 PM

#

well uh

#

you can use glslangvalidator if you just want spirv KEKW

wicked notch Jul 24, 2023, 8:12 PM

#

this is a sad world innit

wispy spear Jul 24, 2023, 8:13 PM

#

gib your shader

wicked notch Jul 24, 2023, 8:13 PM

#

📎 trace.vert 📎 trace.frag

frank sail Jul 24, 2023, 8:13 PM

#

the interface for RGA needs an upgrade

#

it only exposes like 25% of what RGA can actually do

#

otherwise you have to use a stinky command line

twin musk Jul 24, 2023, 8:14 PM

#

i wish we had proper debug info for shaders to correlate the isa back to the source/at least spirv

wispy spear Jul 24, 2023, 8:14 PM

#

📎 message.txt

wicked notch Jul 24, 2023, 8:15 PM

#

sir

#

I get it

#

Now how do I know which section of this is intersect_primitive? KEKW

wispy spear Jul 24, 2023, 8:15 PM

#

interesting, for vk1.3 it yields error: 663: Invalid opcode: 400

#

😄

frank sail Jul 24, 2023, 8:15 PM

#

look at the ray tracing extensions for spirv

wicked notch Jul 24, 2023, 8:16 PM

#

wispy spear interesting, for vk1.3 it yields `error: 663: Invalid opcode: 400`

Huh, I am compiling with --target-env vulkan1.3 and it works bleakekw

frank sail Jul 24, 2023, 8:16 PM

#

twin musk i wish we had proper debug info for shaders to correlate the isa back to the sou...

you probably won't be seeing that for a while

frank sail Jul 24, 2023, 8:16 PM

#

wicked notch Huh, I am compiling with --target-env vulkan1.3 and it works <:bleakekw:10825983...

deccer mightn't've done that

wispy spear Jul 24, 2023, 8:17 PM

#

shaderplaygroundve

#

vk1.1 produces spirv 1.3

twin musk Jul 24, 2023, 8:17 PM

#

frank sail you probably won't be seeing that for a while

i can dream right

wispy spear Jul 24, 2023, 8:17 PM

#

eh i better not confuse the horse conch

wicked notch Jul 24, 2023, 8:18 PM

#

I've been contemplatong the frog for a while now

#

Still dunno how the fix works

#

This is the frog I've been contemplating btw

#

For the record, the "fix" is the following

#

Pardon my screenshot

#

But as you can see, I'm loading all the vertex data early in the loop

#

Now if I where to do separate loads for position, normal and uv

#

I will have the same old crash

#

Why? I have no clue

#

Is accessing memory in divergent control flow UB?

#

I would hope it's not?

frank sail Jul 24, 2023, 8:22 PM

#

the only potentially UB part of reading a buffer is with descriptor indexing

wicked notch Jul 24, 2023, 8:22 PM

#

I will assume this is a driver bug and not think about it further

frank sail Jul 24, 2023, 8:22 PM

#

or OOB reads without robust buffer access 😉

wicked notch Jul 24, 2023, 8:22 PM

#

Oh good call

#

Let me enable robustness one sec

#

Nope, even with robustness it crashes

frank sail Jul 24, 2023, 8:24 PM

#

hec

wicked notch Jul 24, 2023, 8:25 PM

#

The next stage would be to have you guys test my thing

#

But eh

#

uncomment #define USE_BUGGY_BEHAVIOR to get crash (maybe)

finite yacht Jul 24, 2023, 8:50 PM

#

huh you are doing VRS as well?

wicked notch Jul 24, 2023, 8:52 PM

#

Yeah but not in this pathtracing project KEKW

#

My bad

#

There we go, this is the version with basically all extensions disabled except the ones I actually need (BDA, desc indexing)

#

📎 bug.zip

finite yacht Jul 24, 2023, 9:15 PM

#

Ok, so here without and with USE_BUGGY_BEHAVIOR. Both seem to work fine but with gets me lower fps

wispy spear Jul 24, 2023, 9:15 PM

#

no linux build smh

wicked notch Jul 24, 2023, 9:19 PM

#

hm

#

That's expected

#

Or at least

frank sail Jul 24, 2023, 9:20 PM

#

I thought lvstri was on Linux

wicked notch Jul 24, 2023, 9:20 PM

#

I wouldn't expect a few milliseconds of delta between loading from memory 3 times and only once

#

But it's better than crashing in the driver bleakekw

wicked notch Jul 24, 2023, 9:20 PM

#

frank sail I thought lvstri was on Linux

Usually, but I'm gamin with frens while figuring this stuff out KEKW

frank sail Jul 24, 2023, 9:21 PM

#

raven orchid Jul 24, 2023, 9:21 PM

#

wicked notch The next stage would be to have you guys test my thing

Will our tiny 1060s explode

wicked notch Jul 24, 2023, 9:22 PM

#

No worries, the froge is but a mere 1 million tris

wispy spear Jul 24, 2023, 9:25 PM

#

for you ill boot into windows my frog

#

i suppse USE_BUGGY_BABABOOEY thingy is an env var?

wicked notch Jul 24, 2023, 9:26 PM

#

it's in trace.frag

wispy spear Jul 24, 2023, 9:26 PM

#

ah

#

oki on my way windows

#

noice, first try just crashes

wicked notch Jul 24, 2023, 9:31 PM

#

amazing

wispy spear Jul 24, 2023, 9:31 PM

#

$ ./PathTracer.exe
[2023-07-24 23:31:15.394] [wsi] [info] initializing window (width: 1920, height: 1080, title: "PT")
[2023-07-24 23:31:15.434] [instance] [info] initialized volk
[2023-07-24 23:31:15.478] [instance] [info] instance initialized
[2023-07-24 23:31:15.479] [instance] [info] validation layers initialized
[2023-07-24 23:31:15.479] [device] [info] found GPU: NVIDIA GeForce GTX 1060 6GB
[2023-07-24 23:31:15.479] [device] [info] acquired GPU: NVIDIA GeForce GTX 1060 6GB
[2023-07-24 23:31:15.480] [device] [info] API version: 1.3.242
[2023-07-24 23:31:15.480] [device] [info] device features enabled
[2023-07-24 23:31:15.480] [instance] [error] [general] terminator_CreateDevice: Failed in ICD C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_675be35f1ba2315e\.\nvoglv64.dll vkCreateDevice call
[2023-07-24 23:31:15.480] [instance] [error] [general] vkCreateDevice:  Failed to create device chain.
[2023-07-24 23:31:15.480] [device] [info] device initialized
Segmentation fault

#

h

#

ah i may or may not have vulkan sdk installed

#

no its installed, i just rembered and checked, did it a week ago

wicked notch Jul 24, 2023, 9:32 PM

#

Hmm perhaps it's a weird bug on my part

#

strange tho

wispy spear Jul 24, 2023, 9:33 PM

#

updating dribers too...

wicked notch Jul 24, 2023, 9:33 PM

#

If it don't work it's fine

#

I got the answer I was looking for

#

i.e: NV bad KEKW

wispy spear Jul 24, 2023, 9:33 PM

#

hehe

#

colors on windows look much better than on windows, and disord is more schnappier too

#

ah im on 536.23, new one is 536.67

#

great

#

wicked notch Jul 24, 2023, 9:38 PM

#

we should all switch to amd

raven orchid Jul 24, 2023, 9:38 PM

#

Woah failed why?

wispy spear Jul 24, 2023, 9:39 PM

#

i cant explain why but i prefer novideo

wispy spear Jul 24, 2023, 9:40 PM

#

raven orchid Woah failed why?

cant say, nothing in eventvwr

raven orchid Jul 24, 2023, 9:40 PM

#

That’s so weird

wispy spear Jul 24, 2023, 9:42 PM

#

634mb of blob

#

ah

#

when i use the installer installer, it shows the error : >

#

too low disk space

#

worked now, but i dont get why it cant init the device

#

is it using anything RTXy?

wicked notch Jul 24, 2023, 9:52 PM

#

nope, only BDA, descriptor indexing and extended integer/fp types (uint64_t, etc.)

wispy spear Jul 24, 2023, 9:54 PM

#

perhaps that wont work on the 1060

wicked notch Jul 24, 2023, 10:33 PM

#

I'll integrate FSR2 tomorrow

#

anyways, path tracing is epic

#

I forgor to put this here this morning KEKW

#

It'll serve as a good collection of all the reference stuff I get

#

Btw I tried to look at DLSS

#

And apparently you need some kind of APPID given directly by NVIDIA or something

finite yacht Jul 26, 2023, 2:30 PM

#

wicked notch anyways, path tracing is epic

did you remove the black lines on the texture?

wicked notch Jul 26, 2023, 2:49 PM

#

black lines?

finite yacht Jul 26, 2023, 2:58 PM

#

in the "path tracing nightmare" scene I have there are these black lines

wicked notch Jul 26, 2023, 3:04 PM

#

Ah, mine doesn't have them for some reason

#

📎 test3_emissive.glb

#

Here it is, complete with the big emissive sphere of doom

wispy spear Jul 26, 2023, 3:34 PM

#

looks like one is with the other without textures

finite yacht Jul 26, 2023, 3:48 PM

#

wicked notch

Weird, I exported this to .gltf + Textures because I cant load .glb, and the resulting image file has the lines.

📎 LUSTRI-GLTF.zip

#

wicked notch Jul 26, 2023, 3:50 PM

#

Huh, I'm not sure

#

I'm not sampling any textures, for the record

#

Actually I lied, I am sampling base color, if there is a base color

wicked notch Jul 26, 2023, 4:26 PM

#

Probably something wrong with the loading

wispy spear Jul 26, 2023, 6:09 PM

#

damn that looks neat

#

now make it real time

#

: >

proven laurel Jul 27, 2023, 9:00 AM

#

wicked notch And apparently you need some kind of APPID given directly by NVIDIA or something

yep. A shame really

#

atleast there is fsr

finite yacht Jul 27, 2023, 1:24 PM

#

wispy spear now make it real time

just give me 1 hour and I can send you a Noisefree Real-Time Video

#

what more do you want

wicked notch Jul 27, 2023, 1:27 PM

#

30ms per frame is real time enough for me 😛

wispy spear Jul 27, 2023, 3:48 PM

#

finite yacht what more do you want

needs to build under linux 😛

cedar seal Jul 29, 2023, 7:08 AM

#

@wicked notch Suggestion: You could ask mods to pin first post here: #1090390868449558618 message

wispy spear Jul 29, 2023, 9:05 AM

#

wicked notch Jul 30, 2023, 7:17 PM

#

path tracing has no right looking this good

wispy spear Jul 30, 2023, 7:21 PM

#

holy moly

#

that do be looking neat

finite yacht Jul 30, 2023, 7:47 PM

#

wanna add AA pls?

wicked notch Jul 30, 2023, 7:47 PM

#

ye I promised I'd add FSR KEKW

finite yacht Jul 30, 2023, 7:49 PM

#

are you planing to make this real time?

#

like with little noise as well not just high fps

wicked notch Jul 30, 2023, 7:49 PM

#

Eh I have no idea how

#

it's already 1spp

#

I'm not really sure how to optimize trasversal

#

I would like to though

#

FSR can already smooth out the noise a bit

finite yacht Jul 30, 2023, 7:51 PM

#

because regarding the AA if you plan on accumulating multiple samples its very easy to add. Just randomly jitter the primary ray inside the pixel

#

like with TAA

summer gyro Jul 30, 2023, 8:00 PM

#

Also do add denoising

#

Looks great

wispy spear Aug 1, 2023, 4:47 PM

#

https://www.youtube.com/watch?v=VlGfFOZRubc 2nd asset potentially has a gazillion of tringles again

YouTube

Gamefromscratch

Unreal Engine August 2023 Free Assets

It's the first Tuesday of the month and Unreal Engine developers know what that means... free stuff! It's another Unreal Engine Marketplace giveaway, this time for August 2023. This month we have 5 "free for the month" assets, with no additions to the permanently free collection. These assets are yours to keep forever, so long as you "buy" th...

▶ Play video

wicked notch Aug 2, 2023, 11:16 PM

#

Lovely

#

Mayhaps I should invest in point shadows

#

I see aliasing too KEKW

#

nothing that a little AA can't fix tho

finite yacht Aug 3, 2023, 12:56 AM

#

finite yacht because regarding the AA if you plan on accumulating multiple samples its very e...

do this!!11!1!

#

in the function that converts pixel to ray dir add random float 0-1 to pixel position. After some frames you got perfect aa

frank sail Aug 3, 2023, 1:00 AM

#

or is it random float in [-.5, .5]

finite yacht Aug 3, 2023, 1:06 AM

#

should be [0.0, 1.0) in compute shader

delicate rain Aug 3, 2023, 1:36 AM

#

Damn I always forget how good RT looks

wicked notch Aug 3, 2023, 6:17 PM

#

btw hardware accel makes things go about 3 times faster

#

Which is less than what I'd expected tbh

wispy spear Aug 6, 2023, 11:43 AM

#

im just leaving this here https://www.youtube.com/watch?v=ZVN50Oxyh5I

YouTube

Cem Yuksel

Stochastic Lightcuts - HPG 2019 Paper Talk

Project page:
http://www.cemyuksel.com/research/stochasticlightcuts/

▶ Play video

wicked notch Aug 6, 2023, 11:44 AM

#

ery nice

#

I'm currently struggling to implement nanite like LODs bleakekw

#

I've been doing nothing but that for the past week or so

wispy spear Aug 6, 2023, 11:45 AM

#

https://tenor.com/view/robxine-rob-blackburn-maxine-trinidad-maxine-pbb-gif-25966429

Tenor

wicked notch Aug 6, 2023, 11:59 AM

#

I mean I get how it works conceptually

#

kindof

#

up until where they go for persistent threads on the GPU bleakekw

#

But the LOD'ing I mostly understood it

frank sail Aug 6, 2023, 11:59 AM

#

What part about persistent threads conchfusez

wicked notch Aug 6, 2023, 11:59 AM

#

I just fail to understand graph partitioning

frank sail Aug 6, 2023, 11:59 AM

#

oh jeez

wicked notch Aug 6, 2023, 12:00 PM

#

frank sail What part about persistent threads conchfusez

first off, it would help knowing how to actually do persistent threads on the GPU

#

regardless of workload

#

because I have no idea what they are or how they work

frank sail Aug 6, 2023, 12:00 PM

#

Isn't it just the thingy where there is a work queue and threads keep grabbing work until there's none left

wicked notch Aug 6, 2023, 12:00 PM

#

It's this part https://youtu.be/eviSykqSUUw?t=1553

wicked notch Aug 6, 2023, 12:01 PM

#

frank sail Isn't it just the thingy where there is a work queue and threads keep grabbing w...

ye

#

that's right

#

except on the GPU bleakekw

#

how the hell do you make a work queue on the GPU

frank sail Aug 6, 2023, 12:01 PM

#

an atomic 🤔

#

hmm

wicked notch Aug 6, 2023, 12:03 PM

#

uhh

#

so the job queue has all the cluster nodes to be processed

#

uh

#

processing involves checking whether the cluster should even be considered when selecting the LOD?

frank sail Aug 6, 2023, 12:06 PM

#

It's possible that they implement a mini job queue for each WG, that way they can sync pushes and pops

#

Instead of having a single global queue

#

Idk lock free programming is hard, so I want to imagine they did something the shrimple way bleakekw

wicked notch Aug 6, 2023, 12:07 PM

#

mfw I have no idea about lock free on the CPU

wispy spear Aug 6, 2023, 12:07 PM

#

NaiveJobQueue.cpp

wicked notch Aug 6, 2023, 12:07 PM

#

how do you expect me to understand lock free on the GPU bleakekw

#

I just use moodycamel's queue

#

is there a moodycamel's queue for the GPU?

frank sail Aug 6, 2023, 12:08 PM

#

Uh atomic comp swap is your friend

wicked notch Aug 6, 2023, 12:08 PM

#

perchance

wispy spear Aug 6, 2023, 12:09 PM

#

https://ye-yuan.com/DSGPURayTracing/ uhm, no i think thats not what you are talking about

wicked notch Aug 6, 2023, 12:09 PM

#

well regardless, I'm not even at step 0

wicked notch Aug 6, 2023, 12:10 PM

#

wispy spear <https://ye-yuan.com/DSGPURayTracing/> uhm, no i think thats not what you are ta...

actually yeah, it is

#

Just not applied to LOD but raytracing

#

the fundamental problem they're solving is one and the same

#

Damn this is interesting

#

I'm still lost bleakekw

#

but interesting nonetheless

wispy spear Aug 6, 2023, 12:21 PM

#

https://tenor.com/view/rabbit-hole-mjc-gif-19460739

Tenor

wicked notch Aug 6, 2023, 12:27 PM

#

literally me fr

frank sail Aug 6, 2023, 12:31 PM

#

Reminds me of a series I read where the main character journeys to the core of the earth (not the one with the movie starring Brendan Fraser)

#

and in it he falls through a hole (or multiple) like that one

wispy spear Aug 6, 2023, 12:32 PM

#

Jules Verne 😉

frank sail Aug 6, 2023, 12:32 PM

#

Nope

#

It was a young adult series I think

#

I read it when I was in middle school (the last time I read fiction recreationally bleakekw ) so I can't remember much

wispy spear Aug 6, 2023, 12:37 PM

#

ah

frank sail Aug 6, 2023, 12:37 PM

#

Ah it was the Tunnels series

wispy spear Aug 6, 2023, 12:37 PM

#

i rember a few drawings of young jaker 🙂

frank sail Aug 6, 2023, 12:37 PM

#

I used chatgpt to help me rember

#

Hehe I used to choose books to read based on how cool I thought the cover image was

#

Literally judging them by their covers KEKW

#

Because of that, I started on the third book of a series because it had the coolest cover

#Iris - A Journey through OpenGL and beyond to learn Graphics

the beast

ground truth

NOW