Fwog and co. | Graphics Programming | Page 15

heavy cipher May 18, 2023, 10:13 AM

#

no

#

the first one gets populated with the source dir of the fetchcontented shit

long robin May 18, 2023, 10:13 AM

#

yeah I just figured the FETCHCONTENT_ was some extra thing they added to throw off the scent

#

ok so it's an issue of visibility

#

because the source dir isn't empty when I print it inside the file that fetches it

final cove May 18, 2023, 10:15 AM

#

oh no way it does populate it

#

it just doesn't show on cmake-gui

#

long robin May 18, 2023, 10:15 AM

#

well the cmake gui thing you were looking at was the wrong variable, same as mine

final cove May 18, 2023, 10:15 AM

#

yeah I mean even with advanced variables on it doesn't show you volk_SOURCE_DIR has value

#

I guess it's uncached or whatever

heavy cipher May 18, 2023, 10:17 AM

#

yes

long robin May 18, 2023, 10:20 AM

#

this feels like a hack, but it fixed my issue
set(FSR2_SOURCE ${fsr2_SOURCE_DIR} PARENT_SCOPE)

#

ok @dapper gorge you can try giving it a shot now. the latest commit in the repo at least sorta works

#

and by that, I mean that this code runs and appears to work

  FfxFsr2ContextDescription contextDesc
  {
    .flags = FFX_FSR2_ENABLE_HIGH_DYNAMIC_RANGE | FFX_FSR2_ENABLE_AUTO_EXPOSURE,
    .maxRenderSize = {windowWidth, windowHeight},
  };
  auto scratchMemory = new char[ffxFsr2GetScratchMemorySizeGL()];
  ffxFsr2GetInterfaceGL(&contextDesc.callbacks, scratchMemory, ffxFsr2GetScratchMemorySizeGL(), glfwGetProcAddress);
  FfxFsr2Context context;
  ffxFsr2ContextCreate(&context, &contextDesc);

dapper gorge May 18, 2023, 10:34 AM

#

I was just saying, I am now opeartional

long robin May 18, 2023, 10:34 AM

#

I gotta hed 2 bed now

dapper gorge May 18, 2023, 10:34 AM

#

I shall clone this

long robin May 18, 2023, 10:34 AM

#

schweet

final cove May 18, 2023, 10:34 AM

#

did you stay up all night

long robin May 18, 2023, 10:34 AM

#

it's only 3:30am

final cove May 18, 2023, 10:34 AM

#

oh that's not... the worst it could possibly be

long robin May 18, 2023, 10:35 AM

#

dapper gorge I shall clone this

anywho, feel free to spam this thread with issues that you find (or make PRs if you're so inclined, hehe)

final cove May 18, 2023, 10:36 AM

#

I guess after you get some sleep you can explain why you need final fantasy x in your project

dapper gorge May 18, 2023, 10:47 AM

#

I'll write here all the problems I find:

You can't compile with LLVM Clang on Windows (really? lol)

long robin May 18, 2023, 10:47 AM

#

I think the issue is the ffx shader tool

#

Only a windows binary is provided (bruh)

dapper gorge May 18, 2023, 10:47 AM

#

Huge bruh

long robin May 18, 2023, 10:48 AM

#

hope you're on Windows lol

dapper gorge May 18, 2023, 10:48 AM

#

So FSR2 is the breaking point with linux?

#

Damn..

long robin May 18, 2023, 10:48 AM

#

maybe we can ship wine with it bleakekw

#

to cope, that is

dapper gorge May 18, 2023, 10:48 AM

#

Isn't AMD the Linux guy?

#

Just do the thing for linux

long robin May 18, 2023, 10:49 AM

#

Idk

#

I mean there are open source drivers

#

Seems like that ecosystem is mostly carried by non-AMD people, but I dunno

valid oriole May 18, 2023, 10:50 AM

#

wat

golden schooner May 18, 2023, 10:51 AM

#

schleep schweet schleppi

valid oriole May 18, 2023, 10:51 AM

#

Im pretty sure I did that half a year QFOT

#

p sure I did that half a year ago

#

oh

#

great

valid oriole May 18, 2023, 10:51 AM

#

dapper gorge I'll write here all the problems I find: - You can't compile with LLVM Clang on ...

meant this

long robin May 18, 2023, 10:51 AM

#

Literally all of my knowledge of AMD stuff on Linux comes from this server

#

It has 0 pertinence to my job

#

Ah

long robin May 18, 2023, 10:52 AM

#

long robin It has 0 pertinence to my job

well except maybe steam deck stuff

#

anyways, I must retire for the night

valid oriole May 18, 2023, 10:52 AM

#

thank you deutsche bahn + everyone else involved with mobile infrastructure along train tracks for the great internet

#

OH FUCK YOU I LOST CONNECTION AGAIN

#

least angry german

dapper gorge May 18, 2023, 10:53 AM

#

I suggest you disable notifications KEKW

dapper gorge May 18, 2023, 10:53 AM

#

valid oriole meant this

It's a custom version of FFX made by Jaker to make it run on OpenGL I guess

#

But I guess the original FFX itself doesn't support clang?

valid oriole May 18, 2023, 10:54 AM

#

oh I thought you mean compiling llvm on windows

#

Bad connection must’ve scrambled some letters

dapper gorge May 18, 2023, 10:54 AM

#

Scrumbulated

heavy cipher May 18, 2023, 10:54 AM

#

valid oriole Im pretty sure I did that half a year QFOT

did pixel execute a QFOT in the middle of the convo froghorror

valid oriole May 18, 2023, 10:55 AM

#

ah fuck it why didn’t it delete it

#

i pressed delete before it was fully sent

golden schooner May 18, 2023, 11:06 AM

#

device lost

#

i wonder if it will appear in /lost+found

valid oriole May 18, 2023, 11:13 AM

#

yes, deep inside radv code, when VK_ERROR_DEVICE_LOST is returned, it does mv /dev/dri/renderD128 /lost+found

long robin May 18, 2023, 5:26 PM

#

wow, no errors while I schlept, must've been a perfect port ()

dapper gorge May 18, 2023, 5:37 PM

#

I actually have no idea if your thing has errors because I have no idea how to use the actual API KEKW

#

So I've been reading documentation and trying different things

long robin May 18, 2023, 5:43 PM

#

hehe

#

I hope you're reading the fsr2 readme. That thing is gold

#

Also there are just two headers you gotta include in your project (the ones in that message), so you can try reading the docs in those

#

Note that the docs in the gl header are still 90% vulkan. I didn't really change them nervous

#

Also, I'll be whipping together an example that you can refer to tonight (not guaranteed to be finished though)

dapper gorge May 18, 2023, 6:48 PM

#

Houston we have a problem

#

Unfortunately GL debug callback is always very shy, it doesn't like to talk much:
GL_INVALID_OPERATION error generated. Texture type and format combination is not valid.

long robin May 18, 2023, 6:49 PM

#

which call is generating it

dapper gorge May 18, 2023, 6:49 PM

#

Callstack

long robin May 18, 2023, 6:49 PM

#

probably one of the glTextureSubImage calls

#

are you compiling for debug

dapper gorge May 18, 2023, 6:50 PM

#

Yes

long robin May 18, 2023, 6:50 PM

#

can you see what line is triggering it

#

well I guess it says right there lol

dapper gorge May 18, 2023, 6:51 PM

#

It's happening on a glGenTextures which doesn't make a lot of sense

long robin May 18, 2023, 6:51 PM

#

hmm

#

maybe I messed up some function pointer

#

nah, should be fine

#

I guess it's the next line (glTextureView) that's triggering it?

dapper gorge May 18, 2023, 6:52 PM

#

The FSR2_PreparedInputColor is succeeding

#

FSR2_ReconstructedPrevNearestDepth is too

#

So are DilatedDepth and LockStatus

#

Only SpdAtomicCounter is failing

long robin May 18, 2023, 6:54 PM

#

can you see what arguments are being passed to glTextureView when it fails

#

maybe I screwed this function up somehow
https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/gl/ffx_fsr2_gl.cpp#L249

#

looks fine to me though

#

maybe I'm passing it a bad (uninitialized) argument

dapper gorge May 18, 2023, 6:56 PM

#

Arguments to glTextureView are fine

long robin May 18, 2023, 6:57 PM

#

then maybe it's failing on glTextureSubImage, which I think is the only other place that has the format arg

dapper gorge May 18, 2023, 7:02 PM

#

Could it be this?

case FFX_SURFACE_FORMAT_R32_UINT:
case FFX_SURFACE_FORMAT_R16_FLOAT:
case FFX_SURFACE_FORMAT_R16_UINT:
case FFX_SURFACE_FORMAT_R16_UNORM:
case FFX_SURFACE_FORMAT_R16_SNORM:
case FFX_SURFACE_FORMAT_R8_UNORM:
case FFX_SURFACE_FORMAT_R8_UINT:
case FFX_SURFACE_FORMAT_R32_FLOAT:
return GL_RED;```

#

Instead of GL_RED perhaps GL_RED_INTEGER?

#

No nevermind

long robin May 18, 2023, 7:05 PM

#

hmm actually I might've screwed that up

#

I think I forgot the _INTEGER for the integer textures

dapper gorge May 18, 2023, 7:17 PM

#

Apparently:

glTextureStorage2D(GL_R32UI);
glTextureSubImage2D(GL_RED, GL_UNSIGNED_INT);``` is "invalid"

#

I have also confirmed that it is happening on SpdAtomicCounter

#

Alright

#

With GL_RED_INTEGER it works

#

But why?

#

It's not in the spec?

#

Can I have the render size equal to the display size if I don't want to upscale?

long robin May 18, 2023, 8:16 PM

#

Yeah

dapper gorge May 18, 2023, 8:20 PM

#

This feels so incredibly wrong KEKW

golden schooner May 18, 2023, 8:21 PM

#

: )

long robin May 18, 2023, 8:21 PM

#

is that your code

#

oh it wants a non null device

dapper gorge May 18, 2023, 8:21 PM

#

Yeah, I have to pass a device somehow

long robin May 18, 2023, 8:21 PM

#

lol I'm gonna remove that assert

dapper gorge May 18, 2023, 8:22 PM

#

There's also commandList in FfxFsr2DispatchDescription

long robin May 18, 2023, 8:24 PM

#

I can make the backend create a "non null" device

#

And command list I guess

dapper gorge May 18, 2023, 8:26 PM

#

GL_INVALID_VALUE error generated. <index> exceeds the maximum number of supported image units.

#

?????????

#

How does this even happen

#

Isn't the limit like 1048576 or something?

long robin May 18, 2023, 8:26 PM

#

no

#

what's the value?

dapper gorge May 18, 2023, 8:26 PM

#

Hehe

#

You would like to know

#

Unfortunately this happens in wglSwapBuffers 😄

long robin May 18, 2023, 8:27 PM

#

bruhment

#

I'm guessing either fsr tried to bind like 30 textures, or there is an uninitialized value somewhere

#

Hmm do the shaders actually compile and link?

#

I know glslang is happy, but I'm afraid it generated something OpenGL doesn't like (unrelated to this issue)

dapper gorge May 18, 2023, 8:29 PM

#

long robin Hmm do the shaders actually compile and link?

Am I supposed to receive an error to stdout if they don't?

long robin May 18, 2023, 8:30 PM

#

I made it so the backend returns an error if it fails

dapper gorge May 18, 2023, 8:30 PM

#

Then they compile just fine

long robin May 18, 2023, 8:30 PM

#

Epic

#

Hmm these issues should be enumerated somewhere so I can fix them

#

Would you mind creating issues on the repo for this stuff, so I don't forget

#

I just need the error code and the line for the gl issues

dapper gorge May 18, 2023, 8:33 PM

#

I found it btw

#

Callstack

#

backendContext->glFunctionTable.glBindImageTexture(
  job->computeJobDescriptor.pipeline.uavResourceBindings[uav].slotIndex,
  ...

#

slotIndex was 11

long robin May 18, 2023, 8:34 PM

#

huh

dapper gorge May 18, 2023, 8:34 PM

#

Which is less than 32

#

Assuming math still works

long robin May 18, 2023, 8:34 PM

#

Tf

dapper gorge May 18, 2023, 8:43 PM

#

Uhm

#

auto x = 0;
glGetIntegerv(GL_MAX_IMAGE_UNITS, &x);``` returns 8...

final cove May 18, 2023, 8:44 PM

#

that sounds plausible

dapper gorge May 18, 2023, 8:44 PM

#

Jaker DEFCON 1

long robin May 18, 2023, 8:47 PM

#

that is quite unfortunate

#

I can probably fix it with bindless textures

#

hmm

#

It might work if I "unbind" the image units first

#

Since I doubt more than 1 or 2 actually need to be written at a time

#

So the issue is probably stale bindings eating up the slots

dapper gorge May 18, 2023, 8:51 PM

#

Should I still open the issue?

long robin May 18, 2023, 8:52 PM

#

Yeah

#

Cuz I'm not confident my solution will work lol

dapper gorge May 18, 2023, 8:53 PM

#

I can't open issues 😦

golden schooner May 18, 2023, 8:54 PM

#

lame excuse

long robin May 18, 2023, 8:54 PM

#

What the heck

golden schooner May 18, 2023, 8:54 PM

#

you have a github account 🙂

dapper gorge May 18, 2023, 8:54 PM

#

No really

#

There is no issues button

long robin May 18, 2023, 8:54 PM

#

Oh tf there is no thingy

#

Yeah lemme fix

golden schooner May 18, 2023, 8:54 PM

#

oh

#

hehe

long robin May 18, 2023, 8:55 PM

#

You can make issues now

#

Btw, this is the file with all the bindings if you're curious
https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/shaders/ffx_fsr2_callbacks_glsl2.h

dapper gorge May 18, 2023, 9:06 PM

#

I did the thing

golden schooner May 18, 2023, 9:08 PM

#

best thing doer

long robin May 18, 2023, 9:09 PM

#

muchas gracias

golden schooner May 18, 2023, 9:11 PM

#

de nada

dapper gorge May 18, 2023, 9:57 PM

#

While Jaker performs The Great Fix™️, I'll be doing some more Vulkan because I still don't feel like learning what rayleigh scattering is KEKW

robust bough May 18, 2023, 11:47 PM

#

@long robin

#

if you want to make a library that's header only

#

you just need to do a target_include_directories(<name> PUBLIC <directory>)

#

idk where your cmake is but

#

target_include_directories(<name> PUBLIC ../fsr2-src/src/ffx-fsr2-api)

#

should turn the include to

#include <ffx_fsr2.h>
#include <gl/ffx_fsr2_gl.h>```

#

actually, making it target_include_directories(<name> PUBLIC ../fsr2-src/src/ffx-fsr2-api ../fsr2-src/src/ffx-fsr2-api/gl)

#

should make the include what you wanted

#

#include <ffx_fsr2.h>
#include <ffx_fsr2_gl.h>```

long robin May 19, 2023, 12:00 AM

#

the API isn't header-only, but I'll note that to make the current includes easier, thx

dapper gorge May 19, 2023, 9:46 AM

#

poke

long robin May 19, 2023, 9:46 AM

#

I pushed a fix for the format thingy

dapper gorge May 19, 2023, 9:46 AM

#

Epic

long robin May 19, 2023, 9:46 AM

#

still integrating with my renderer (I only started like 1 hour ago)

dapper gorge May 19, 2023, 9:47 AM

#

You will be using Fwog for the backend?

long robin May 19, 2023, 9:48 AM

#

huh

#

I'm using one of the fwog samples as a testbed for the opengl fsr2 backend

dapper gorge May 19, 2023, 9:49 AM

#

Ah I see

long robin May 19, 2023, 9:54 AM

#

I wasted some time searching for a bug earlier

#

When I enabled filtered RSM, the jitter would seem to disappear

#

But what actually happened is that I have a 240hz monitor and it's much easier to notice the subpixel jitter at lower framerates

dapper gorge May 19, 2023, 9:56 AM

#

Suffering from success

long robin May 19, 2023, 9:56 AM

#

When I opened RenderDoc, I noticed the jitter was "fine" once more, but only because the framerate went down a lot lol

golden schooner May 19, 2023, 9:58 AM

#

if you need a peasant to test for you on peasant hardware, boop me

long robin May 19, 2023, 9:59 AM

#

It won't run on Linux 😦

#

Unless I ship the spirv binaries

dapper gorge May 19, 2023, 10:00 AM

#

Can't you make it go brrr on penguin OS too?

long robin May 19, 2023, 10:00 AM

#

The ffx shader tool won't run on Linux

golden schooner May 19, 2023, 10:00 AM

#

oh

long robin May 19, 2023, 10:00 AM

#

And the source isn't public afaik

#

Quite a bruhment if you ask me

dapper gorge May 19, 2023, 10:00 AM

#

Come on AMD, you're better than this

golden schooner May 19, 2023, 10:00 AM

#

...creating issue... brb

long robin May 19, 2023, 10:01 AM

#

You can't bleakekw

golden schooner May 19, 2023, 10:01 AM

#

i was jk

#

FSR2 is super laggy on me system, tried it in everspace2

#

(and there seem to be 10 different versions/qualitygrades of it)

long robin May 19, 2023, 10:02 AM

#

There are 5 official quality modes

golden schooner May 19, 2023, 10:02 AM

#

makes sense

#

it was probably those 5 only

#

even when game wasnt loadd and i was just in ui, you could feel the slowdown when trying all of them : >

#

ah and im not trashtalking fsr2

long robin May 19, 2023, 10:03 AM

#

Hehe

#

I wonder if maybe the game was so cheap to render that fsr2 was more expensive than the game lol

#

Or maybe the game wasn't fragment bound in the first place, so fsr was just extra overhead

golden schooner May 19, 2023, 10:04 AM

#

wouldnt surprise me

#

it also feels like they just crammed that in thre because every other game has it too

long robin May 19, 2023, 10:07 AM

#

perhap

#

some studios have marketing agreements to integrate tech like this

#

no clue if this one did

dapper gorge May 19, 2023, 10:08 AM

#

https://github.com/GPUOpen-Effects/FidelityFX-FSR2/pull/60 There is a dude here who somehow reverse engineered the shader compiler

#

How did... what the

golden schooner May 19, 2023, 10:08 AM

#

i use arch btw

long robin May 19, 2023, 10:09 AM

#

dapper gorge <https://github.com/GPUOpen-Effects/FidelityFX-FSR2/pull/60> There is a dude her...

He just added wine

#

And did some other stuff to undo windows hacks

dapper gorge May 19, 2023, 10:10 AM

#

Initally yes, but then he built a python script

long robin May 19, 2023, 10:10 AM

#

Ah

#

I didn't see that

#

Ye the shader tool is not super complicated

#

It automatically generates permutations by invoking glslang and makes some headers with hardcoded data

golden schooner May 19, 2023, 10:12 AM

#

you could "just" spin up a windows vm, to compile/build stuff there and move the output out of there again : >

long robin May 19, 2023, 10:13 AM

#

imo it's pretty silly that Linux support isn't in base fsr2

golden schooner May 19, 2023, 10:13 AM

#

it is

long robin May 19, 2023, 10:13 AM

#

but then again, the Vulkan backend didn't initially ship with it either

golden schooner May 19, 2023, 10:13 AM

#

but perhaps its also a time thing, windows is/was more important

long robin May 19, 2023, 10:14 AM

#

Linux is probably a very small market for this, yeah

golden schooner May 19, 2023, 10:14 AM

#

and then there is wine and the other emulated shit, let them figure it out 🙂

long robin May 19, 2023, 11:04 AM

#

fsr2 be lookin snazzy 😍

dapper gorge May 19, 2023, 11:04 AM

#

Oh my that's genius, you can't have aliasing if there is no image in the first place!

long robin May 19, 2023, 11:07 AM

#

wtf

#

the debugger is jumping over this line

const FfxErrorCode errorCode = fsr2Dispatch(contextPrivate, dispatchParams);

#

the ONE line I'm interested in

golden schooner May 19, 2023, 11:07 AM

#

debug vs release?

long robin May 19, 2023, 11:08 AM

#

it's in defrog mode

dapper gorge May 19, 2023, 11:08 AM

#

wat function is that?

#

I was calling ffxFsr2ContextDispatch

long robin May 19, 2023, 11:08 AM

#

dapper gorge May 19, 2023, 11:08 AM

#

a

#

I see.

long robin May 19, 2023, 11:08 AM

#

I guess ABI issue somehow

#

because the function I'm calling is returning some random garbage

golden schooner May 19, 2023, 11:09 AM

#

the greyed out items remind me of resharper telling me "you can remove them, they are unused"

long robin May 19, 2023, 11:09 AM

#

golden schooner May 19, 2023, 11:09 AM

#

is that an Exception code?

long robin May 19, 2023, 11:10 AM

#

doesn't look like any of these

#

wait a minute

#

ah nvm

dapper gorge May 19, 2023, 11:11 AM

#

Doesn't 0x80000000 overflow in int32?

long robin May 19, 2023, 11:11 AM

#

idk

#

hmm

dapper gorge May 19, 2023, 11:11 AM

#

Yeah it does

brazen glacier May 19, 2023, 11:12 AM

#

yeah i think that's invalid_size?

long robin May 19, 2023, 11:12 AM

#

weird af design choice

golden schooner May 19, 2023, 11:12 AM

#

-2147483636 = -0x7FFFFFF4

#

hmm

long robin May 19, 2023, 11:12 AM

#

lol I'm dumb

golden schooner May 19, 2023, 11:12 AM

#

: >

long robin May 19, 2023, 11:12 AM

#

it's returning on this line

    FFX_RETURN_ON_ERROR(
        contextPrivate->device,
        FFX_ERROR_NULL_DEVICE);

#

it's not skipping anything lol

golden schooner May 19, 2023, 11:12 AM

#

badumm tss

long robin May 19, 2023, 11:13 AM

#

I rebuilt everything cuz I thought I was going insane

brazen glacier May 19, 2023, 11:13 AM

#

rip

long robin May 19, 2023, 11:13 AM

#

making the error codes ints that overflow is frickin weird though

dapper gorge May 19, 2023, 11:13 AM

#

At least it's no longer undefined behaviour (integer overflow) in C++20

#

KEKW

long robin May 19, 2023, 11:13 AM

#

bleakekw

dapper gorge May 19, 2023, 11:14 AM

#

Hey, 'twas really hard for the committee to write "two's complement"

#

That's two whole words

long robin May 19, 2023, 11:15 AM

#

two's words

#

finally

OpenGL Debug message (1281): GL_INVALID_VALUE error generated. <index> exceeds the maximum number of supported image units.

golden schooner May 19, 2023, 11:18 AM

#

hehe

heavy cipher May 19, 2023, 11:18 AM

#

dapper gorge At least it's no longer undefined behaviour (integer overflow) in C++20

it is

dapper gorge May 19, 2023, 11:18 AM

#

Is it?

#

Then I guess that's misinfo

long robin May 19, 2023, 11:20 AM

#

it's not even binding that many images before it fails 😦

binding image slot index: 1
binding image slot index: 2
binding image slot index: 3
binding image slot index: 4
binding image slot index: 5
binding image slot index: 6
binding image slot index: 7
binding image slot index: 11
OpenGL Debug message (1281): GL_INVALID_VALUE error generated. <index> exceeds the maximum number of supported image units.

golden schooner May 19, 2023, 11:20 AM

#

that is weird

dapper gorge May 19, 2023, 11:20 AM

#

MAX is 8 unfortunately

golden schooner May 19, 2023, 11:20 AM

#

for image bindings

long robin May 19, 2023, 11:20 AM

#

so it had nothing to do with stale bindings

heavy cipher May 19, 2023, 11:20 AM

#

dapper gorge Then I guess that's <:misinfo:1073720407452045322>

its now defined to be 2s complement, but overflow is still ub

long robin May 19, 2023, 11:21 AM

#

hmm

golden schooner May 19, 2023, 11:21 AM

#

AMD cards have more apparently, at least according to gpuinfo

long robin May 19, 2023, 11:22 AM

#

huehue

dapper gorge May 19, 2023, 11:22 AM

#

common AMD W

golden schooner May 19, 2023, 11:22 AM

#

zink and llvmpipe also have way more 🙂

long robin May 19, 2023, 11:23 AM

#

my eyes are barely staying open so I shall retire once again

#

I'll dream of ways to fix this with bindless

dapper gorge May 19, 2023, 11:24 AM

#

https://tenor.com/view/spin-frog-xd-gif-25168050

Tenor

golden schooner May 19, 2023, 11:24 AM

#

good night my frog

dapper gorge May 19, 2023, 11:24 AM

#

Have a fine frog specimen before sleep

long robin May 19, 2023, 11:25 AM

#

btw, it is conceivably binding all these images to write to

image name: FSR2_SpdAtomicCounter
image name: FSR2_ExposureMips
image name: FSR2_ExposureMips
image name: FSR2_AutoExposure
image name: FSR2_ReconstructedPrevNearestDepth
image name: FSR2_InternalDilatedVelocity1
image name: FSR2_DilatedDepth
image name: FSR2_LockInputLuma

golden schooner May 19, 2023, 11:25 AM

#

i read Dilated Llama 🦙

long robin May 19, 2023, 11:26 AM

#

it binds like 3 more textures before failing an assert

#

ah, it's failing the assert because I forgor to write a field of the ffxResource struct in ffxGetTextureResourceGL

#

or did I

#

ah, I just provided it with an unknown format

#

quite epic

golden schooner May 19, 2023, 11:28 AM

#

looks like asserts are useless 😄

long robin May 19, 2023, 11:29 AM

#

I'm not even sure if I'm supposed to pass srgb images to fsr2

#

I guess I'm supposed to give it unorm or hdr images

dapper gorge May 19, 2023, 11:30 AM

#

Ah I frogor to tell you that

#

Yeah I fixed it by switching everything back to UNORM and manually doing gamma (after fsr)

long robin May 19, 2023, 11:30 AM

#

alright I'll raise the issue

#

wait

#

I'm not sure if it's an issue KEKW

#

anyways, I schleep

#

I probably won't be able to work on it until sunday evening since I'll be gone this weekend 😢

dapper gorge May 19, 2023, 11:32 AM

#

long robin May 19, 2023, 11:32 AM

#

we shall see anyways

#

maybe I'll find some time to work on it during work tomorrow 😉

golden schooner May 19, 2023, 11:35 AM

#

re wat, it didnt show you directly whats up

golden schooner May 19, 2023, 7:36 PM

#

ah jaker is back

long robin May 19, 2023, 7:37 PM

#

Nuh uh

golden schooner May 19, 2023, 7:37 PM

#

i have a question re Application.cpp

#

https://github.com/JuanDiegoMontoya/Fwog/blob/main/example/common/Application.cpp#L108

#

app->cursorFrameOffset += glm::dvec2{
    currentCursorX - app->previousCursorPos.x,
    app->previousCursorPos.y - currentCursorY
};

#

that looks somewhat weird

long robin May 19, 2023, 7:38 PM

#

what's the q

golden schooner May 19, 2023, 7:38 PM

#

is there a reason why y is calculated the other way around?

long robin May 19, 2023, 7:38 PM

#

yeah

#

Y in window space starts at the top rather than the bottom

golden schooner May 19, 2023, 7:38 PM

#

true

long robin May 19, 2023, 7:39 PM

#

and we want upwards mouse movement to move the camera up

golden schooner May 19, 2023, 7:39 PM

#

anismart

long robin May 19, 2023, 7:39 PM

#

so we gotta floop flop it around

golden schooner May 19, 2023, 7:39 PM

#

indeed

dapper gorge May 19, 2023, 7:52 PM

#

tfw no fsr2 for a weekend

#

https://tenor.com/view/anime-cry-fma-terrible-day-gif-25502341

Tenor

long robin May 19, 2023, 7:55 PM

#

well I thought about the issue a little bit when I was hallucinating in bed

#

I can shrimply make ubo containing handles to all the samplers, textures, and images I need, then index it with the binding slot provided by fsr2

#

the limit of 8 images is really schtewpid though

golden schooner May 19, 2023, 7:56 PM

#

sounds like a plan

long robin May 19, 2023, 7:57 PM

#

I think I only need to change one shader source too

daring surge May 19, 2023, 8:04 PM

#

long robin and we want upwards mouse movement to move the camera up

this is still odd

#

you're reading off of app->previousCursorPos and writing to app->cursorFrameOffset, this should be past the point of fixing y-flip, no?

long robin May 19, 2023, 8:05 PM

#

idk, the code works

#

previousCursorPos is in the same flipped Y space as currentCursorY

#

so uh yeah, mafs

dapper gorge May 19, 2023, 8:07 PM

#

RenderEquation

golden schooner May 19, 2023, 9:24 PM

#

hmm

#

  struct ColorBlendStateOwning
  {
    bool logicOpEnable;
    LogicOp logicOp;
    std::vector<ColorBlendAttachmentState> attachments;
    float blendConstants[4];
  };

  struct ColorBlendState
  {
    bool logicOpEnable = false;
    LogicOp logicOp = LogicOp::COPY;
    std::span<const ColorBlendAttachmentState> attachments = {};
    float blendConstants[4] = { 0, 0, 0, 0 };
  };

#

whats the deal with these 2?

long robin May 19, 2023, 9:26 PM

#

the second one has a std::span in it

golden schooner May 19, 2023, 9:26 PM

#

hehe

#

must be rightier then

long robin May 19, 2023, 9:26 PM

#

but if I want to cache this (I do), I have to make an owning version of the struct, or the reference will likely dangle

golden schooner May 19, 2023, 9:26 PM

#

hmm

#

im not happy with this

long robin May 19, 2023, 9:27 PM

#

the user doesn't see the owning version

#

but yeah I agree it's icky

golden schooner May 19, 2023, 9:29 PM

#

yeah, can we remove the owning one (name wise), and have it cache the state always

long robin May 19, 2023, 9:30 PM

#

hmm

golden schooner May 19, 2023, 9:30 PM

#

after ~~the message to our sponsor~~ your trip

#

there are a few more Owningisms

long robin May 19, 2023, 9:31 PM

#

I suppose that the span version is "unnecessary" (it saves one allocation) since every time you make a pipeline, it'll create the owning version

golden schooner May 19, 2023, 9:31 PM

#

yeah, and you only ever really create pipelines ones

final cove May 19, 2023, 9:32 PM

#

but imagine where you could be if you just saved that allocation

golden schooner May 19, 2023, 9:32 PM

#

: )

#

https://tenor.com/view/that-would-make-me-very-happy-hopeful-happy-good-news-i-want-to-gif-15616170

Tenor

long robin May 19, 2023, 9:33 PM

#

you can raise an issue if you'd like

#

"remove unnecessary owningisms"

golden schooner May 19, 2023, 9:33 PM

#

i was about to say that i do be abouting doing thating

long robin May 19, 2023, 9:34 PM

#

feels weird to force the user to make vectors instead of spans though 😳

heavy cipher May 19, 2023, 9:34 PM

#

glm::span3 when

golden schooner May 19, 2023, 9:35 PM

#

https://github.com/JuanDiegoMontoya/Fwog/issues/82

#

i have no permissions to label apropriately

long robin May 19, 2023, 9:36 PM

#

heavy cipher glm::span3 when

namespace glm {
  using span3 = std::mdspan<float, std::extent<float, 3>>;
}

final cove May 19, 2023, 9:36 PM

#

I wonder if you can still reduce an allocation by providing optional move semantics

#

idk what the call site looks like

golden schooner May 19, 2023, 9:37 PM

#

like a construction site

long robin May 19, 2023, 9:37 PM

#

final cove idk what the call site looks like

just do dis

void func(SomeHugeStruct s)
{
  internalData.push(std::move(s));
}

// if user wants a move
func(std::move(s));

// if user wants a copy
func(s);

#

now you have optional move semantics

final cove May 19, 2023, 9:38 PM

#

but its not perfect

long robin May 19, 2023, 9:39 PM

#

you can use a template to remove the intermediate struct, but perhaps it's not worf it since you're moving anyways

heavy cipher May 19, 2023, 9:39 PM

#

to remove that you need to provide emplace semantics not optional move semantics

long robin May 19, 2023, 9:58 PM

#

@dapper gorge possibly something worth noting
https://github.com/GPUOpen-Effects/FidelityFX-FSR2/issues/108

GitHub

Inverted Viewport (OpenGL-like) · Issue #108 · GPUOpen-Effects/Fide...

I have FSR2 running in a custom vulkan engine but the results don't seem to be as expected. My viewport Y is inverted to match that of OpenGL (via negative viewport dim y) What are the implicat...

#

Not sure if it's a real problem if the motion vectors are correctly provided

dapper gorge May 19, 2023, 9:59 PM

#

hmm

long robin May 19, 2023, 10:00 PM

#

Maybe the jitter y offset would need to be inverted

dapper gorge May 19, 2023, 10:00 PM

#

Perhaps

#

I could also just set a negative offset to all my glViewports

long robin May 19, 2023, 10:00 PM

#

Is that well defined in OpenGL?

dapper gorge May 19, 2023, 10:00 PM

#

I have no idea

heavy cipher May 19, 2023, 10:01 PM

#

no

long robin May 19, 2023, 10:01 PM

#

Uh, you should use glClipControl for that anyways

dapper gorge May 19, 2023, 10:01 PM

#

heavy cipher no

Epic

dapper gorge May 19, 2023, 10:01 PM

#

long robin Uh, you should use glClipControl for that anyways

Yeah true

#

GL_UPPER_LEFT and we are in Australia

long robin May 19, 2023, 10:01 PM

#

Yeah that's the worst case scenario fix

dapper gorge May 19, 2023, 10:02 PM

#

I would test

#

if only you weren't in the middle of nowhere driving

long robin May 19, 2023, 10:02 PM

#

Oh I'm not traveling atm

heavy cipher May 19, 2023, 10:02 PM

#

glPromptUserToRotateMonitor

long robin May 19, 2023, 10:02 PM

#

I'm on the toilet KEKW

dapper gorge May 19, 2023, 10:02 PM

#

Epic

long robin May 19, 2023, 10:02 PM

#

I will be traveling in a few hours

dapper gorge May 19, 2023, 10:02 PM

#

That's plenty to fix FSR2

long robin May 19, 2023, 10:02 PM

#

Mayhapsch enough time to hack bindless in

heavy cipher May 19, 2023, 10:03 PM

#

long robin I'm on the toilet <:KEKW:666849321462792234>

not travelling yet propulsion is engaged 🤔

long robin May 19, 2023, 10:04 PM

#

I'm deploying the swimmers to scout ahead, smhmh

golden schooner May 19, 2023, 10:05 PM

#

without the floating equipment

long robin May 19, 2023, 10:06 PM

#

Minimal equipment- they'll be relying on the currents for transportation

long robin May 19, 2023, 11:05 PM

#

fuuuuuuuuck

#

https://www.reddit.com/r/opengl/comments/yy08bt/glslangvalidator_doesnt_support_bindless_textures/

r/opengl - glslangValidator doesn't support bindless textures?

3 votes and 2 comments so far on Reddit

golden schooner May 19, 2023, 11:06 PM

#

narf

#

reminds me of mojoshaders not being able to support texture2darrays ;C

long robin May 19, 2023, 11:07 PM

#

idk what to do

#

maybe it won't be too hard to fork glslang and make it support bindless textures nervous

dapper gorge May 19, 2023, 11:08 PM

#

frog_sweat

golden schooner May 19, 2023, 11:08 PM

#

or do we know someone who works on it

long robin May 19, 2023, 11:08 PM

#

or maybe I can generate the shader permutations as text

golden schooner May 19, 2023, 11:08 PM

#

mayhaps we can send moscow inkasso

long robin May 19, 2023, 11:08 PM

#

hmm

#

is it possible to make glslang insert compiler defines at the beginning of the shader?

#

because the compiler uses a bunch of flags like -DFOO_ENABLE and such

golden schooner May 19, 2023, 11:09 PM

#

@brazen glacier might know?

brazen glacier May 19, 2023, 11:09 PM

#

i mean you can just pass -DWHATEVER in iirc

long robin May 19, 2023, 11:09 PM

#

trying to make glslang dump text instead of spir-v I guess

brazen glacier May 19, 2023, 11:10 PM

#

lemme read context lol

long robin May 19, 2023, 11:10 PM

#

brazen glacier i mean you can just pass `-DWHATEVER` in iirc

my problem is that I cannot use it to compile glsl that uses opengl bindless textures

#

so at most I can use it to preprocess shaders

#

what I'd like to do is have it emit the shader permutations I need, but in text form for OpenGL to directly consume

brazen glacier May 19, 2023, 11:11 PM

#

can you run it with -E?

long robin May 19, 2023, 11:11 PM

#

but the problem is that fsr2 relies on a bunch of compiler defines

brazen glacier May 19, 2023, 11:14 PM

#

i think you need to manually grab this output though, can't redirect to a file

long robin May 19, 2023, 11:14 PM

#

I think I was being a moron

#

for some reason I wanted the #defines to be literally in the text KEKW

brazen glacier May 19, 2023, 11:15 PM

#

ohhh

#

then why preprocess it at all lol

long robin May 19, 2023, 11:15 PM

#

but yeah just preprocessing works too nice

#

anyways, thanks for engaging with my stupidity

#

now I need to change some schtuff to make this wurk

#

hmm

#

I'm afraid the ffx shader tool will be a roadblock with this 😦

#

it wants to take the spirv binary and do a bunch of shit with it

brazen glacier May 19, 2023, 11:19 PM

#

what does it even do?

long robin May 19, 2023, 11:20 PM

#

it invokes glslang for each shader permutation, then generates headers with info about the permutations

brazen glacier May 19, 2023, 11:20 PM

#

right

#

naturally that needed to be an executable and not a script lol

long robin May 19, 2023, 11:21 PM

#

mayhaps I can take the python clone of it that someone made and modify that

long robin May 19, 2023, 11:21 PM

#

brazen glacier naturally that needed to be an executable and not a script lol

yeah it's dumb

#

all this because I can't bind more than 8 images

golden schooner May 19, 2023, 11:21 PM

#

(on nvidia)

dapper gorge May 19, 2023, 11:22 PM

#

common NVIDIA L

long robin May 19, 2023, 11:22 PM

#

https://github.com/GPUOpen-Effects/FidelityFX-FSR2/pull/60/files#diff-de80f6e4a1170478ed2172c4f6ae53bc5d4bfcb907c595265a71cc644b7f5222

#

I'm gonna push my current stuff to a branch and test it on my AMD compooter

#

bababouille
https://github.com/JuanDiegoMontoya/Fwog/tree/fsr2-test

#

now y'all can try it for yourselves

#

(if you're on windows)

#

(and not NV)

dapper gorge May 19, 2023, 11:30 PM

#

Ah I see, so that's AMD's marketing strategy

#

You just coerce people, interesting

long robin May 19, 2023, 11:33 PM

#

at least it hits the assert without immediately generating gl errors now

brazen glacier May 19, 2023, 11:33 PM

#

hey, not their fault that nv hardware sucks and can only bind 8 images 😏

long robin May 19, 2023, 11:33 PM

#

it's so dumb, you can bind a billion images on nv in vulkan

brazen glacier May 19, 2023, 11:34 PM

#

ah but you see if they limit it to 8 images they can do an optimisation that saves 3 femtoseconds on some cad program

long robin May 19, 2023, 11:35 PM

#

look ma, no errors

brazen glacier May 19, 2023, 11:35 PM

#

i ran it and it spammed errors

long robin May 19, 2023, 11:35 PM

#

are you on nv

brazen glacier May 19, 2023, 11:35 PM

#

no

long robin May 19, 2023, 11:35 PM

#

hmm

#

what errors

brazen glacier May 19, 2023, 11:35 PM

#

long robin May 19, 2023, 11:35 PM

#

spoopy

brazen glacier May 19, 2023, 11:36 PM

#

rx 5700xt, adrenalin 23.4.3, checked out the fsr2-test branch and running gltf viewer

long robin May 19, 2023, 11:36 PM

#

hmm

#

Application.cpp has the debug callback if you wanna throw a breakpoint in there

brazen glacier May 19, 2023, 11:38 PM

#

coming from here (ffx_fsr2_gl.cpp:1194)

long robin May 19, 2023, 11:39 PM

#

probably invalid format somehow

brazen glacier May 19, 2023, 11:40 PM

#

oh lemme do a debug run

#

it's trying to use a resource with unknown surface format

long robin May 19, 2023, 11:41 PM

#

ah

#

I'm dumb^2

#

it's because of the GL_SRGB8_ALPHA8 format I gave it

#

I already fixed it in my local branch, but forgot to tell you

#

"fixed"

#

I just told fsr2 that it's actually GL_RGBA8 and that made it not complain

brazen glacier May 19, 2023, 11:42 PM

#

oh right lol

long robin May 19, 2023, 11:43 PM

#

too bad I can't decipher what's happening in rdc

#

are all these checkered inputs unbound or unused 🤔

#

I can open them in the resource inspector, so I guess they aren't unbound

#

interestingly, each shader only uses a few sampler and image bindings 👀

#

#

decompiled shader

#

three of the passes have a bunch of unbound resources somehow

#

those unbound resources do not correspond with all the checkerboards I see in the texture viewer

oak garden May 19, 2023, 11:58 PM

#

Does it work at least

long robin May 19, 2023, 11:59 PM

#

it correctly generates a black screen

oak garden May 19, 2023, 11:59 PM

#

Nicely upscaled 👌

long robin May 19, 2023, 11:59 PM

#

long robin look ma, no errors

this

#

my new plan of attack for fixing the too-many-binds is to manually set them for each shader

#

hmm is there a function to set the binding of an image in a shader

#

I think it's just glUniform

#

I can do something like

int currBinding = 0;
for (binding : imagesToBind)
{
  auto loc = glGetUniformLocation(program, binding.name);
  glProgramUniformi(program, loc, currBinding);
  glBindImageTexture(currBinding, binding.image, ...);
  currBinding++;
}

#

to make sure images are always bound starting at 0

oak garden May 20, 2023, 12:04 AM

#

That could work yeah

fair thicket May 20, 2023, 12:06 AM

#

rainbow from this evening, seems like you can see the oscillations below purple but i might be imagining it

long robin May 20, 2023, 12:07 AM

#

kinda faint, but I think you can barely see the supernumerary rainbows

#

but maybe that's just the violet part of the main one

#

anywhomst, I gtg in like 10 minutes, so no more fsr2 stuff for me

dapper gorge May 20, 2023, 12:10 AM

#

That's truly one of the rainbows of all time

long robin May 20, 2023, 12:13 AM

#

long robin I can do something like ```cc int currBinding = 0; for (binding : imagesToBind) ...

https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/issues/3

long robin May 22, 2023, 4:25 AM

#

these formats nervous

long robin May 22, 2023, 5:26 AM

#

long robin I can do something like ```cc int currBinding = 0; for (binding : imagesToBind) ...

btw, this strategy seems to work (no more gl errors on Nvidia 🙏) but I still get a black screen because the wrong resources are being bound

long robin May 22, 2023, 7:07 AM

#

I invoked glslang with -g

heavy cipher May 22, 2023, 7:11 AM

#

short for --gobble-ram

long robin May 22, 2023, 7:15 AM

#

how 🇹🇫

long robin May 22, 2023, 8:04 AM

#

no clue how all the bindings are getting mixed up

#

renderdoc is telling me no, but my mind is telling me yes (seriously though, wtf)

#

epic misinfo in the wiki (emphasis mine)

Image bindings can be layered or non-layered, which is determined by layered. If layered is GL_TRUE, then texture must be an Array Texture (of some type), a Cubemap Texture, or a 3D Texture. If a layered image is being bound, then the entire mipmap level specified by level is bound.

#

it seems like renderdoc is just ignoring the glUniform1i calls

long robin May 22, 2023, 8:44 AM

#

it (setting image uniforms via glUniform1i) seems to work when I'm not using spirv bleakekw

#

an absolute baba of a booey, tbqh

#

at this point, I'm tempted to compile the shaders back to glsl at runtime just to see if it changes things

oak garden May 22, 2023, 9:00 AM

#

bleakekw

dapper gorge May 22, 2023, 9:32 AM

#

FSR2 GL is back in the works, pog

dapper gorge May 22, 2023, 8:31 PM

#

poke

long robin May 22, 2023, 8:33 PM

#

dapper gorge May 22, 2023, 8:35 PM

#

cute

#

Where's my FSR2

#

Something that's rightfully mine

#

(jk)

long robin May 22, 2023, 8:35 PM

#

I'm gonna continue to test on AMD machine since I can bind images without having to use glUniform

dapper gorge May 22, 2023, 8:35 PM

#

epic

#

Good luck soldier

#

Let me know if I can be of any help

long robin May 22, 2023, 8:36 PM

#

I shall

golden schooner May 22, 2023, 8:38 PM

#

https://tenor.com/view/thank-you-so-much-gif-24188848

Tenor

heavy cipher May 22, 2023, 8:39 PM

#

da heck is that wcstombs

golden schooner May 22, 2023, 8:40 PM

#

https://tenor.com/view/ponste50-gif-21291437

Tenor

heavy cipher May 22, 2023, 8:40 PM

#

Settra himself wrote this code

long robin May 22, 2023, 8:41 PM

#

heavy cipher da heck is that wcstombs

#

Seriously though, is there a better way to convert wchar strings to c strings nervous

brazen glacier May 22, 2023, 8:44 PM

#

the best way is to not use them :P

long robin May 22, 2023, 8:44 PM

#

I'm afraid I'm forced by fsr2 to use them

brazen glacier May 22, 2023, 8:44 PM

#

i figured, very unfortunate

heavy cipher May 22, 2023, 8:45 PM

#

its your flork jaker

#

kill the wchars

brazen glacier May 22, 2023, 8:45 PM

#

wchar strings don't belong anywhere near render code, when are you going to have a texture with non-ascii chars in its name????

long robin May 22, 2023, 8:45 PM

#

lel

oak garden May 22, 2023, 8:46 PM

#

glsl with wchar uniform name

long robin May 22, 2023, 8:46 PM

#

I don't think they are causing any issues atm

heavy cipher May 22, 2023, 8:46 PM

#

more like lchars

golden schooner May 22, 2023, 8:47 PM

#

https://tenor.com/view/stfc-treasury-bug-gif-27147998

Tenor

long robin May 22, 2023, 8:48 PM

#

Anyways, I know they're disgusting, but I'm not concerned with changing them atm

#

I just want mah got dang bindings to work

heavy cipher May 22, 2023, 8:52 PM

#

btw why are you feeding spirv

#

is that what you do on fwog as well?

#

i'd be spooked that they didn't actually give two shits when implementing that

long robin May 22, 2023, 9:06 PM

#

yes I'm afraid of implementations having spir-v bugs too

#

I'm feeding spir-v because that's what I have to work with

#

I could feed it glsl, but that'd require changing a lot of stuff, which is effort I'd rather not spend right now

long robin May 22, 2023, 9:10 PM

#

heavy cipher is that what you do on fwog as well?

no

#

I'd expect Nvidia's impl of spir-v shaders to be okay. At least it was the last time I tried in my voxel engine

heavy cipher May 22, 2023, 9:11 PM

#

i recall dr. circle having big issues, but this seems a bit to frog_shrimple

golden schooner May 22, 2023, 9:11 PM

#

can you not turn this into an amd hackathon next week, and make the initial authors help you : )

long robin May 22, 2023, 9:15 PM

#

lel

long robin May 22, 2023, 9:23 PM

#

long robin how 🇹🇫

on the bright side, input samplers are 🇫🇴oked the same way on both machines

golden schooner May 22, 2023, 9:27 PM

#

fook

daring surge May 22, 2023, 9:51 PM

#

🇫🇴👌ed

shell inlet May 22, 2023, 9:52 PM

#

long robin May 22, 2023, 9:54 PM

#

I wonder if my translation of this vk backend code is somehow wrong
vk:

    // bind srvs
    for (uint32_t srv = 0; srv < job->computeJobDescriptor.pipeline.srvCount; ++srv)
    {
        addBarrier(backendContext, &job->computeJobDescriptor.srvs[srv], FFX_RESOURCE_STATE_COMPUTE_READ);

        BackendContext_VK::Resource ffxResource = backendContext->resources[job->computeJobDescriptor.srvs[srv].internalIndex];

        writeDatas[descriptorWriteIndex] = {};
        writeDatas[descriptorWriteIndex].sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
        writeDatas[descriptorWriteIndex].dstSet = pipelineLayout->descriptorSets[pipelineLayout->descriptorSetIndex];
        writeDatas[descriptorWriteIndex].descriptorCount = 1;
        writeDatas[descriptorWriteIndex].descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE;
        writeDatas[descriptorWriteIndex].pImageInfo = &imageInfos[imageInfoIndex];
        writeDatas[descriptorWriteIndex].dstBinding = job->computeJobDescriptor.pipeline.srvResourceBindings[srv].slotIndex;
        writeDatas[descriptorWriteIndex].dstArrayElement = 0;

        imageInfos[imageInfoIndex] = {};
        imageInfos[imageInfoIndex].imageLayout = VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL;
        imageInfos[imageInfoIndex].imageView = ffxResource.allMipsImageView;

        imageInfoIndex++;
        descriptorWriteIndex++;
    }

#

gl:

  // bind srvs (sampled textures)
  for (uint32_t srv = 0; srv < job->computeJobDescriptor.pipeline.srvCount; ++srv)
  {
    addBarrier(backendContext, &job->computeJobDescriptor.srvs[srv], FFX_RESOURCE_STATE_COMPUTE_READ);

    BackendContext_GL::Resource ffxResource = backendContext->resources[job->computeJobDescriptor.srvs[srv].internalIndex];

    backendContext->glFunctionTable.glBindTextureUnit(job->computeJobDescriptor.pipeline.srvResourceBindings[srv].slotIndex, ffxResource.textureAllMipsView.id);
    backendContext->glFunctionTable.glBindSampler(job->computeJobDescriptor.pipeline.srvResourceBindings[srv].slotIndex, backendContext->linearSampler.id);
  }

golden schooner May 22, 2023, 9:54 PM

#

hmm are you doing the same mistake i did, mixing image/texture?

shell inlet May 22, 2023, 9:54 PM

#

datas 😔

dapper gorge May 22, 2023, 9:55 PM

#

KEKW

shell inlet May 22, 2023, 9:55 PM

#

also seeing this vulkan code immediately triggered my ptsd because this looks just like my vulkan code

#

except it's bigger

long robin May 22, 2023, 9:55 PM

#

golden schooner hmm are you doing the same mistake i did, mixing image/texture?

vulkan: sampled image
gl: glBindTextureUnit + glBindSampler

#

should be the same

golden schooner May 22, 2023, 9:56 PM

#

it says computeJobDescriptor, was finking you bind to a cs, and glsl might use image not sampler2D

long robin May 22, 2023, 9:56 PM

#

it's kinda dumb

#

but yeah this function is executeGpuJobCompute (write+bind resources and dispatch)

golden schooner May 22, 2023, 9:57 PM

#

perhaps there is no difference in the spriv/underlying assembly between image/samplerisms

#

but there is in glsl, and when you bind a sampler to an image you get black, if that makes any sense

shell inlet May 22, 2023, 9:58 PM

#

I swear even this line BackendContext_VK::Resource ffxResource = backendContext->resources[job->computeJobDescriptor.srvs[srv].internalIndex]; scares me because of [[[]]]

#

is this pure C?

long robin May 22, 2023, 10:03 PM

#

no, it's C++

#

C-like C++ bleakekw

shell inlet May 22, 2023, 10:04 PM

#

so no attempt at any refactoring was made then

long robin May 22, 2023, 10:04 PM

#

I think the only standard lib feature used in the backend is on this line
std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter;

heavy cipher May 22, 2023, 10:04 PM

#

btw did you change anything on the spirv?

long robin May 22, 2023, 10:05 PM

#

shell inlet so no attempt at any refactoring was made then

bro I'm fighting for my life trying to make this code work

heavy cipher May 22, 2023, 10:05 PM

#

seems like the vk code uses separate samplers

#

thats not an opengl thing

long robin May 22, 2023, 10:05 PM

#

yeah I made them combined image samplers

shell inlet May 22, 2023, 10:05 PM

#

long robin bro I'm fighting for my life trying to make this code work

well I am not talking about your code or your effort, otherwise understandable

#

whoever wrote the code must have worn down ctrl, c and v keys

long robin May 22, 2023, 10:06 PM

#

heavy cipher seems like the vk code uses separate samplers

https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/shaders/ffx_fsr2_callbacks_glsl2.h#L156

#

I also noticed that the point sampler isn't actually used anywhere, which is quite convenient for me

#

so I just used the linear sampler for everything

heavy cipher May 22, 2023, 10:08 PM

#

do you ever change the sampler uniform value?

long robin May 22, 2023, 10:09 PM

#

no

#

I figured the resource binding "slot index" would be the correct thing nervous

heavy cipher May 22, 2023, 10:10 PM

#

i'd think it would be

long robin May 22, 2023, 10:10 PM

#

heavy cipher do you ever change the sampler uniform value?

I do change it for images though, because nvidia is stinky and doesn't even allow binding images to indices > 7

#

well the version of the repo on my work pc does not have that yet, since it's not needed

final cove May 22, 2023, 10:13 PM

#

shell inlet

do you know where the full res version of this is

#

I need it

long robin May 22, 2023, 10:14 PM

#

I basically have these files side-by-side and am comparing them atm
https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/gl/ffx_fsr2_gl.cpp
https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/vk/ffx_fsr2_vk.cpp

shell inlet May 22, 2023, 10:15 PM

#

final cove do you know where the full res version of this is

https://media.discordapp.net/stickers/1066530660803686400.webp?size=512

#

ripped from the page

final cove May 22, 2023, 10:16 PM

#

big mcthankies

#

hey you can't just right click and save an image, they're non fungible

long robin May 22, 2023, 10:24 PM

#

somehow textures that I'm not even passing to the fsr context are being bound nervous

#

that is the indirect illumination texture

#

oh and gAlbedo and gNormal are not passed as well

#

I forgot about those, because they kinda looked like inputs to fsr

#

see here

  FfxFsr2DispatchDescription dispatchDesc
  {
    .commandList = (void*)0x1,
    .color = ffxGetTextureResourceGL(&fsr2Context, frame.colorLdrRenderRes->Handle(), renderWidth, renderHeight, GL_RGBA8),
    .depth = ffxGetTextureResourceGL(&fsr2Context, frame.gDepth->Handle(), renderWidth, renderHeight, GL_DEPTH_COMPONENT32F),
    .motionVectors = ffxGetTextureResourceGL(&fsr2Context, frame.gMotion->Handle(), renderWidth, renderHeight, GL_RG32F),
    .exposure = {},
    .reactive = {},
    .transparencyAndComposition = {},
    .output = ffxGetTextureResourceGL(&fsr2Context, frame.colorLdrWindowRes->Handle(), windowWidth, windowHeight, GL_RGBA8),
    .jitterOffset = {jitterX, jitterY},
    .motionVectorScale = {1, 1},
    .renderSize = {renderWidth, renderHeight},
    .enableSharpening = false,
    .sharpness = 0,
    .frameTimeDelta = static_cast<float>(dt * 1000.0),
    .preExposure = 1,
    .reset = false,
    .cameraNear = cameraNear,
    .cameraFar = cameraFar,
    .cameraFovAngleVertical = cameraFovY,
    .viewSpaceToMetersFactor = 1,
  };

shell inlet May 22, 2023, 10:31 PM

#

this oddly makes me think it might be an issue of smth like binding to indices[idx] vs to idx

#

but it can't be that, right

final cove May 22, 2023, 10:33 PM

#

2 channels of GL image binding issues atm

#

ouch

shell inlet May 22, 2023, 10:34 PM

#

moon is at the anti gl phase

dapper gorge May 22, 2023, 10:34 PM

#

frog_sweat

final cove May 22, 2023, 10:34 PM

#

The blood moon is rising...

dapper gorge May 22, 2023, 10:35 PM

#

Ahh, the good old terraria flashbacks

dapper gorge May 22, 2023, 10:36 PM

#

long robin see here ```cc FfxFsr2DispatchDescription dispatchDesc { .commandList = ...

Shouldn't motionVectorScale be the render resolution?

#

But well, I guess that's not important right now KEKW

long robin May 22, 2023, 10:37 PM

#

getTextureResourceGL does this
https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/gl/ffx_fsr2_gl.cpp#L448

long robin May 22, 2023, 10:37 PM

#

dapper gorge Shouldn't `motionVectorScale` be the render resolution?

it depends

#

but atm the texture is completely black, so it does not matter 😄

#

I think 1, 1 scale means the motion vectors are in [-resolution, +resolution] space

#

ah, I think I see one issue

#

stale bindings

golden schooner May 22, 2023, 10:48 PM

#

stalus bingus

long robin May 22, 2023, 10:48 PM

#

idk why, but the frontend isn't trying to bind all the resources that the shader will use

#

so that's why all the random stuff is bound

golden schooner May 22, 2023, 10:51 PM

#

do you not have ZeroThingyBindingThing() in your pipeline?

long robin May 22, 2023, 10:52 PM

#

I forgor to put the fsr dispatch in a scope

dapper gorge May 22, 2023, 10:52 PM

#

ZeroThingyBindy

golden schooner May 22, 2023, 10:52 PM

#

ah

long robin May 22, 2023, 10:53 PM

#

there we go

dapper gorge May 22, 2023, 10:53 PM

#

Now they are all equally fooked?

long robin May 22, 2023, 10:54 PM

#

for some reason, only some images and buffers are being bound

#

but no samplers nor textures

golden schooner May 22, 2023, 10:54 PM

#

yeah so my initial question stands

#

you do glBindSampledTexture

#

on a compute program

#

is it actually samplers/textures or images in the shader?

#

idk, do you know what i mean?

long robin May 22, 2023, 10:56 PM

#

yeah they are

golden schooner May 22, 2023, 10:57 PM

#

ok

long robin May 22, 2023, 10:59 PM

#

the problem must be in job scheduling

#

because the bindings aren't even in there

golden schooner May 22, 2023, 11:00 PM

#

weird

final cove May 22, 2023, 11:00 PM

#

job scheduling from the driver?

oak garden May 22, 2023, 11:01 PM

#

the driver is allowed to do many things but breaking your code is not one of them

final cove May 22, 2023, 11:01 PM

#

maybe its not allowed to, but will it?

dapper gorge May 22, 2023, 11:01 PM

#

oak garden the driver is allowed to do many things but breaking your code is not one of the...

In theory

oak garden May 22, 2023, 11:02 PM

#

opengl issue

dapper gorge May 22, 2023, 11:03 PM

#

https://tenor.com/view/shut-up-shush-shh-ok-bird-gif-17679708

Tenor

#

OpenGL good

#

Jaker will prove it

#

I believe in him

long robin May 22, 2023, 11:03 PM

#

final cove job scheduling from the driver?

fsr2 calls them "jobs"

#

really it's just a list of clears and dispatches that the frontend submits to the backend to execute all at once

#

hmm

#

I question whether the shader really needs everything bound at once

final cove May 22, 2023, 11:07 PM

#

jaker will prove it by revealing you've been running vulkan the whole time

long robin May 22, 2023, 11:12 PM

#

#define POPULATE_SHADER_BLOB(info, index) { info[index].blobData, info[index].blobSize, info[index].numStorageImageResources, info[index].numSampledImageResources, info[index].numUniformBufferResources, info[index].storageImageResourceNames, info[index].storageImageResourceBindings, info[index].sampledImageResourceNames, info[index].sampledImageResourceBindings, info[index].uniformBufferResourceNames, info[index].uniformBufferResourceBindings }

#

return POPULATE_SHADER_BLOB(g_ffx_fsr2_compute_luminance_pyramid_pass_PermutationInfo, tableIndex);

oak garden May 22, 2023, 11:13 PM

#

amd engineers are paid to write this shit?

#

NanaStare

long robin May 22, 2023, 11:13 PM

#

POPULATE_SHADER_BLOB should really be a function lol

#

ah, I see why it isn't

#

the info argument can be several types

oak garden May 22, 2023, 11:15 PM

#

templates?

long robin May 22, 2023, 11:15 PM

#

that means I just need to make this a template

oak garden May 22, 2023, 11:16 PM

#

so are you guys hiring any remote eu devs kekw

long robin May 22, 2023, 11:17 PM

#

make a pr ||that will never get merged||

oak garden May 22, 2023, 11:18 PM

#

😔

golden schooner May 22, 2023, 11:18 PM

#

dont be so grim

#

just text the person at work

final cove May 22, 2023, 11:18 PM

#

abandonware master developers

golden schooner May 22, 2023, 11:18 PM

#

seriously 🙂

long robin May 22, 2023, 11:18 PM

#

we are hiring engineers in EU though

#

I forgor what roles

golden schooner May 22, 2023, 11:19 PM

#

Fullstack Java Developer

oak garden May 22, 2023, 11:19 PM

#

dread_cat

golden schooner May 22, 2023, 11:19 PM

#

im too stupid for serious giraffics business

oak garden May 22, 2023, 11:19 PM

#

id love to do it eventually but i still have a lot to learn imo

#

then again i have 2 more years in uni to tinker around with stuff

final cove May 22, 2023, 11:20 PM

#

I'm realizing that there's no better place to learn other than on the job

oak garden May 22, 2023, 11:20 PM

#

i assume so yeah

golden schooner May 22, 2023, 11:20 PM

#

you could hookup demongod

#

although he sits on the westcoast

long robin May 22, 2023, 11:21 PM

#

there is apparently an open intern/co-op position for my internal org, but when I click on the link to the job it 404s

dapper gorge May 22, 2023, 11:21 PM

#

Are you trying to outsource FSR2 OpenGL?

long robin May 22, 2023, 11:22 PM

#

yeah

#

cheap EU child laborers will do it for me now

oak garden May 22, 2023, 11:22 PM

#

bleakekw

dapper gorge May 22, 2023, 11:22 PM

#

https://tenor.com/view/emoji-in-distress-emoji-sad-emoji-disappearing-emoji-disintegrating-seokvrse-gif-25237004

Tenor

final cove May 22, 2023, 11:23 PM

#

what does a graphics development job even look like, now that I think about it

#

what do you actually do

long robin May 22, 2023, 11:23 PM

#

here's some more epic code for you to gawk at

#define POPULATE_PERMUTATION_KEY(options, key)                                                                \
key.index = 0;                                                                                                \
key.FFX_FSR2_OPTION_REPROJECT_USE_LANCZOS_TYPE = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_REPROJECT_USE_LANCZOS_TYPE);                     \
key.FFX_FSR2_OPTION_HDR_COLOR_INPUT = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_HDR_COLOR_INPUT);                 \
key.FFX_FSR2_OPTION_LOW_RESOLUTION_MOTION_VECTORS = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_LOW_RES_MOTION_VECTORS);   \
key.FFX_FSR2_OPTION_JITTERED_MOTION_VECTORS = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_JITTER_MOTION_VECTORS);   \
key.FFX_FSR2_OPTION_INVERTED_DEPTH = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_DEPTH_INVERTED);                   \
key.FFX_FSR2_OPTION_APPLY_SHARPENING = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_ENABLE_SHARPENING);                 \
key.FFX_HALF = FFX_CONTAINS_FLAG(options, FSR2_SHADER_PERMUTATION_ALLOW_FP16);

final cove May 22, 2023, 11:23 PM

#

I get that senior devs basically ponder the orb all day

long robin May 22, 2023, 11:23 PM

#

final cove what does a graphics development job even look like, now that I think about it

idk

dapper gorge May 22, 2023, 11:23 PM

#

long robin idk

~Jaker, full time graphics developer at AMD

oak garden May 22, 2023, 11:24 PM

#

He spends his time shitposting on discord

dapper gorge May 22, 2023, 11:24 PM

#

KEKW

#

Damn

#

So you were hiring right?

final cove May 22, 2023, 11:24 PM

#

so do I but I do database stuff so I thought my skills weren't transferrable

long robin May 22, 2023, 11:24 PM

#

dapper gorge ~Jaker, full time graphics developer at AMD

I'm a gpu devtech, so I don't make the renderers as much as I help the people who make the renderers

oak garden May 22, 2023, 11:25 PM

#

Interesting

final cove May 22, 2023, 11:25 PM

#

is gpu devtech one of those jobs where they want to see a CE degree and time spent with FPGAs and stuff

brazen glacier May 22, 2023, 11:25 PM

#

good lord how much cpu side code can fsr 2 possibly have
surely at some point it'd be easier to just kick off the few dispatches yourself

dapper gorge May 22, 2023, 11:25 PM

#

long robin I'm a gpu devtech, so I don't make the renderers as much as I help the people wh...

Basically this discord except at AMD?

#

Without the #opengl channel unfortunately

long robin May 22, 2023, 11:27 PM

#

final cove is gpu devtech one of those jobs where they want to see a CE degree and time spe...

no hardware skill required

#

the basic requirements are knowing how a GPU works, how graphics APIs work, and how to optimize graphics

oak garden May 22, 2023, 11:28 PM

#

Sounds reasonable yeah

final cove May 22, 2023, 11:28 PM

#

magic
dark magic
speculation and bikeshedding

#

I've got this down

oak garden May 22, 2023, 11:29 PM

#

Doesn’t sound too bad to do as a job honestly

#

does part of it involve writing tooling and stuff or it it really mostly answering questions or debugging things

long robin May 22, 2023, 11:29 PM

#

the job itself is investigating bugs and perf issues in AAA games, doing frame breakdowns, etc.

oak garden May 22, 2023, 11:29 PM

#

Right

#

Sound cool yeah

long robin May 22, 2023, 11:30 PM

#

there are opportunities to work on tooling

#

and approved R&D projects

final cove May 22, 2023, 11:32 PM

#

is that the abandonware department

#

how do I join that

long robin May 22, 2023, 11:32 PM

#

most R&D projects don't turn into a product

#

and they aren't necessarily software

#

holy shit

final cove May 22, 2023, 11:39 PM

#

is that a good holy shit or a bad holy shit

long robin May 22, 2023, 11:39 PM

#

good

long robin May 22, 2023, 11:39 PM

#

long robin `#define POPULATE_SHADER_BLOB(info, index) { info[index].blobData, info[index]....

this ugly thing was looking for sampled images, not combined samplers

#

but I changed the shader to use combined samplers

#

I think the jitter is backwards or something

#

probably viewport/clip convention issue, but that's easy to solve

#

yeah negating the Y jitter that I pass to fsr fixes that

dapper gorge May 22, 2023, 11:43 PM

#

https://tenor.com/view/black-guy-poggers-poggers-pog-gif-22576295

Tenor

long robin May 22, 2023, 11:43 PM

#

fsr2 still doesn't know about the [-1, 1] depth convention that opengl has, and I don't think there's a way to change it

#

(yet)

dapper gorge May 22, 2023, 11:43 PM

#

glClipControl

long robin May 22, 2023, 11:44 PM

#

yeah, but I don't want to force that upon the user

#

unless I have to

dapper gorge May 22, 2023, 11:44 PM

#

Mate

#

we are probably the only people using FSR2 on OpenGL right now KEKW

#

On the planet possibly

#

But yeah, good idea.

final cove May 22, 2023, 11:45 PM

#

is all the math in the shader factored around a [-1, 1] depth or something?

long robin May 22, 2023, 11:45 PM

#

I'm not sure how this function works, but I think it would be the one that needs to change to accommodate [-1, 1] depth
https://github.com/JuanDiegoMontoya/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/ffx_fsr2.cpp#L663

long robin May 22, 2023, 11:46 PM

#

final cove is all the math in the shader factored around a [-1, 1] depth or something?

something assumes ndc z is [0, 1]

#

it wants all the other projection params

dapper gorge May 22, 2023, 11:47 PM

#

You see, once upon a time someone decided to make OpenGL's NDC depth range [-1;1], we're still working on finding him for adequate punishment.

oak garden May 22, 2023, 11:48 PM

#

He will be forbidden from seeing frogs for the rest of his life

long robin May 22, 2023, 11:49 PM

#

that's a cruel and unusual punishment

final cove May 22, 2023, 11:50 PM

#

oh there are a lot more shaders in fsr than I thought

#

I was hoping to find the formuoli that those 4 constants corresponded to

long robin May 22, 2023, 11:53 PM

#

is there a way to search all open files in vsc

#

ah, the giant magnifying glass on the left

golden schooner May 22, 2023, 11:55 PM

#

ctrl+shift+f

#

like in most editors 🙂

long robin May 22, 2023, 11:55 PM

#

final cove I was hoping to find the formuoli that those 4 constants corresponded to

ffx_fsr2_common.h has all the uses of DeviceToViewSpaceTransformFactors

#

FfxFloat32x3 UnprepareRgb(FfxFloat32x3 fRgb, FfxFloat32 fExposure)
unprepares your rgb

dapper gorge May 22, 2023, 11:58 PM

#

KEKW

final cove May 22, 2023, 11:58 PM

#

FfxFloat32 GetViewSpaceDepth(FfxFloat32 fDeviceDepth)
{
    const FfxFloat32x4 fDeviceToViewDepth = DeviceToViewSpaceTransformFactors();

    // fDeviceToViewDepth details found in ffx_fsr2.cpp
    return (fDeviceToViewDepth[1] / (fDeviceDepth - fDeviceToViewDepth[0]));
}

#

looks like this is all there is to it

dapper gorge May 22, 2023, 11:58 PM

#

Huh, looks like a shrimple * 2.0 - 1.0 will do the tricc

long robin May 23, 2023, 12:00 AM

#

I can just add a compile-time flag for that I guess

#

just like the inverted depth one

oak garden May 23, 2023, 12:01 AM

#

Does that mean OpenGL FSR2 is almost working 👀

dapper gorge May 23, 2023, 12:01 AM

#

FFX_IS_UNHINGED_DEPTH_RANGE

long robin May 23, 2023, 12:01 AM

#

oak garden Does that mean OpenGL FSR2 is almost working 👀

yes

dapper gorge May 23, 2023, 12:03 AM

#

Huge hype

long robin May 23, 2023, 12:03 AM

#

it will be pushed soon™️ alhamdulilah

dapper gorge May 23, 2023, 12:03 AM

#

Staying up to 2am was worth it

long robin May 23, 2023, 12:04 AM

#

u should sleep and then observe the pushed version when you wake up

oak garden May 23, 2023, 12:04 AM

#

It’ll be like Christmas in summer

dapper gorge May 23, 2023, 12:05 AM

#

I shall admire the glory of The Push™️ later then

final cove May 23, 2023, 12:05 AM

#

isn't it still spring

#

I don't know how seasons work

dapper gorge May 23, 2023, 12:05 AM

#

final cove I don't know how seasons work

Earth go spinny spinny, that's how they work

snow sun May 23, 2023, 12:05 AM

#

final cove what does a graphics development job even look like, now that I think about it

you fix up the engine to do things artists want

#

and seniors ask their orb for structural changes

final cove May 23, 2023, 12:07 AM

#

what does that look like though, to me graphics only comes in "simple" and "arcane"

snow sun May 23, 2023, 12:07 AM

#

im a junior i usually optimise or work on new graphics features or more like additions to existing features

#

for example i just finished a thing that lets water make static geo wet

#

sounds super boring but looks really cool when you see the difference

#

rn i work on (to me) arcane stuff

final cove May 23, 2023, 12:09 AM

#

as in you interact with the arcane stuff the senior devs conjured?

snow sun May 23, 2023, 12:10 AM

#

yes

#

when i add something to for example water, i have to read a ton of code to even know where to begin as engine big and stuff

#

but off thats cause im junior

#

but the engines are big so it takes years to get a good overview of everyhting

long robin May 23, 2023, 12:11 AM

#

nah it's because the engine is bad and the whole thing needs a rewrite

snow sun May 23, 2023, 12:11 AM

#

nervous

final cove May 23, 2023, 12:11 AM

#

if I wrote the engine, things would be different

long robin May 23, 2023, 12:11 AM

#

trust me, the seniors love it when juniors demand rewrites

snow sun May 23, 2023, 12:12 AM

#

its honestly very good, i was expecting much worse from what i hear people always say about old engines

#

it also gets semi rewrites all the time in parts

final cove May 23, 2023, 12:13 AM

#

so even the big engines can't avoid perpetual refactoring

snow sun May 23, 2023, 12:13 AM

#

i like how it is ~~the seniors are my gods~~

snow sun May 23, 2023, 12:13 AM

#

final cove so even the big engines can't avoid perpetual refactoring

but they refactor when its smart

#

they have lots of people with smart heads

long robin May 23, 2023, 12:14 AM

#

my carefully architected code
my sensible style choice
my self-documenting code

their spaghetti codebase
their baffling style choices
their unreadable code

snow sun May 23, 2023, 12:14 AM

#

some things get really old tho, its not like its rewritten every year

final cove May 23, 2023, 12:16 AM

#

sounds pretty cool tho, I guess it makes sense they don't literally let you get overwhelmed and drown in the code

#

is your 3rd eye slowly opening from looking at the arcane code though

snow sun May 23, 2023, 12:17 AM

#

oh they do tho

#

you just go throu the jungle and get it after time

#

first months are shit

#

but then its your swamp

long robin May 23, 2023, 12:18 AM

#

: become shrek

snow sun May 23, 2023, 12:18 AM

#

learning to read other peoples code is a real skill

#

i could barely do it

#

now its ok, but muuuuch better then before

long robin May 23, 2023, 12:19 AM

#

fsr2, despite the funny code I showed, is well-enough written that I could comprehend what it was doing in relatively little time

final cove May 23, 2023, 12:20 AM

#

yeah

snow sun May 23, 2023, 12:20 AM

#

i think cpu code is usualy ok cause ides get it

#

but super big shaders can be really poopy to understand

final cove May 23, 2023, 12:21 AM

#

I still need to cross the real threshold which is learning how to get info out of meaty papers

long robin May 23, 2023, 12:21 AM

#

yeah navigating shaders is an atrocity

brazen glacier May 23, 2023, 12:22 AM

#

rider my beloved :)
full go to definition/code completion for hlsl

#

glsl though... lol

snow sun May 23, 2023, 12:22 AM

#

rider?

brazen glacier May 23, 2023, 12:22 AM

#

jetbrains ide, basically a drop in vs replacement

long robin May 23, 2023, 12:22 AM

#

'ardly know 'er

snow sun May 23, 2023, 12:23 AM

#

h

#

mm

long robin May 23, 2023, 12:24 AM

#

btw does anyone know the extension that allows me to vertically stack tabs in VS

#

having one super long line of tabs sucks

snow sun May 23, 2023, 12:54 AM

#

non code can do that natively

#

i use that

long robin May 23, 2023, 12:54 AM

#

oh wut

#

how

snow sun May 23, 2023, 12:54 AM

#

its a setting

#

but its there im sure of it

long robin May 23, 2023, 12:55 AM

#

found it

#

https://i.imgur.com/GOK2Jmb.png

Imgur

#

this is gonna be a gamechanger

#

I've no idea if this is correct, but I'm gonna 🚢 🤡

FfxFloat32 GetViewSpaceDepth(FfxFloat32 fDeviceDepth)
{
    const FfxFloat32x4 fDeviceToViewDepth = DeviceToViewSpaceTransformFactors();

    // fDeviceToViewDepth details found in ffx_fsr2.cpp
#if FFX_FSR2_OPTION_DEPTH_NEGATIVE_ONE_TO_ONE
    return (fDeviceToViewDepth[1] / ((fDeviceDepth * 2.0 - 1.0) - fDeviceToViewDepth[0]));
#else
    return (fDeviceToViewDepth[1] / (fDeviceDepth - fDeviceToViewDepth[0]));
#endif
}

#

two things

I'm not sure if I even need something like this (but I assume yes, if the depth buffer is generated with a [-1 ,1] z projection)
if this is necessary, I wonder if I can just modify DeviceToViewDepth (generated on the CPU) instead of doubling the shader permutations

#

I don't really understand what the function is doing
https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/ffx_fsr2.cpp#L663

#

@shell inlet do you have any thoughts about the device to view space transform thingy that I'm talking about

#

I guess this explains everything I need, as usual
http://www.songho.ca/opengl/gl_projectionmatrix.html

long robin May 23, 2023, 1:45 AM

#

despite fsr2 working on amd, it fails on NV due to the dumb image binding limit and not being able to change image bindings via glUniform (driver bug)

#

I noticed that I'm able to subtract a constant amount from certain bindings (each shader uses a different set of consecutive bindings), so hopefully that can work

#

I'll have to introduce some magic numbers to the shaders though

long robin May 23, 2023, 4:00 AM

#

I tried using the glslang option --auto-map-bindings to just generate bindings starting at 0 for each shader, but for some reason the bindings are not starting at 0 listenyoupieceofshit

#

I think it's the ffx shader tool reading a file and assuming bindings are equal to the numbers in there

#

maybe these can help

--shift-image-binding [stage] num            base binding number for images (uav)
--shift-image-binding [stage] [num set]...   per-descriptor-set shift values
--sib                                        synonym for --shift-image-binding

long robin May 23, 2023, 4:08 AM

#

long robin I think it's the ffx shader tool reading a file and assuming bindings are equal ...

nope, renderdoc says the bindings are "randomly" starting at high indices

#

"show unused items" in renderdoc reveals no more bindings, so I have no clue why the bindings are so high

#

apparently glslang is supposed to alias unused bindings, making this even more baffling

#

lol renderdoc crashes when you have negative resource bindings

#

guess the --shift-image-binding strategy isn't going to work unless I somehow know the base binding

#

or maybe I used it wrong

long robin May 23, 2023, 4:39 AM

#

I have a small test shader to confirm that these all work, so I have no clue why it's failing in the real thing

#

I think I see the issue

#

seems like glslang has one namespace for all resource bindings, and images happen to be bound last, which means they get super high bindings 😢

#

wtf, apparently bindless textures are supported
https://github.com/KhronosGroup/glslang/issues/3205

#

idk why it wasn't working with my thing, maybe I have an old version

long robin May 23, 2023, 5:43 AM

#

ahh the thing that I thought was an nv driver bug is actually a renderdoc bug bleakekw

long robin May 23, 2023, 6:16 AM

#

yeet
https://github.com/baldurk/renderdoc/issues/2942

#

at least nsight works for debugging this, but holy moly is it painful

#

it takes like 10 seconds to open the thing that lets me look at a single texture

#

every. single. time.

#

literal torture using this application to debug

long robin May 23, 2023, 6:53 AM

#

houston, we have an image (ignore the sRGB fail)

#

I noticed (using nsight and apitrace) that everything seemed to be working except the write to the output target

#

seems like writes to an sRGB texture via a unorm image variable are not appreciated by nvidia's driver nervous

#

no validation layers btw bleakekw

#

ADL is terrifying

heavy cipher May 23, 2023, 7:28 AM

#

is memory barrier not a command 🤔

long robin May 23, 2023, 7:29 AM

#

it was, then I determined that it's useful outside of command scopes

#

I might want a memory barrier outside of my abstract rendering or compute scopes for a number of reasons

#

eh, but only rendering or compute can generate the conditions in which you'd need a subsequent memory barrier

#

I have atoned for my sRGB crimes, now enjoy ACES crimes instead

#

aces with correct color space input does not look that different, heh

shell inlet May 23, 2023, 8:16 AM

#

aces with correct color space looks more incorrect than the incorrect one

shell inlet May 23, 2023, 8:17 AM

#

long robin <@397737942476652545> do you have any thoughts about the device to view space tr...

I just woke up and don't understand the question

long robin May 23, 2023, 8:20 AM

#

the question is basically: what is the code in the link doing?

#

but I think I know, hence my follow-up link

shell inlet May 23, 2023, 8:31 AM

#

does something with some matrix, computes some constants, uses bool in subscript operator

#

has to do with projection type

#

no clue what those constants are used for, probably for depth linearization or something

final cove May 23, 2023, 8:48 AM

#

yeah if you follow the functions in the .h you posted yesterday (working from memory at this point) it uses that depth function for reconstructing a position in view space

heavy cipher May 23, 2023, 8:56 AM

#

https://github.com/baldurk/renderdoc/issues/2942 yeeted, deleted and cremated

long robin May 23, 2023, 8:56 AM

#

https://tenor.com/view/sakshi-okay-gif-24764953

Tenor

#

I don't see why it being spir-v would suddenly make that ub

#

but whatever

#

now I wonder if this is the correct way to generate unjittered motion vectors in ndc space

vec2 GetNdcPos(mat4 vp, vec3 worldPos)
{
  vec4 clip = (vp * vec4(worldPos, 1.0));
  return clip.xy / clip.w;
}

void main()
{
  v_motion = GetNdcPos(oldViewProjUnjittered, v_position) - GetNdcPos(viewProjUnjittered, v_position);
}

#

the output is rather blurry under motion with these

#

and renderdoc be saying that a lot of my motion vectors are outside of [-1, 1] nervous

heavy cipher May 23, 2023, 9:07 AM

#

are you accounting for ndc differences?

#

or did you clip control yourself to vk

long robin May 23, 2023, 9:07 AM

#

no, I have not done that yet

#

that's probably contributing to blurriness, but my current motion vectors look wrong anyways

heavy cipher May 23, 2023, 9:09 AM

#

its an easy fix to clip control for now

long robin May 23, 2023, 9:12 AM

#

ez fix indeed

#

I need to change like five places in the indirect lighting code to account for this bleakekw

heavy cipher May 23, 2023, 9:19 AM

#

thats just how opengl looks like

long robin May 23, 2023, 9:44 AM

#

I "took inspiration" from teardown's code finally

#

they pass ndc coords to the fs and do the perspective divide there

#

apparently passing the ndc motion vector to the fs screws it up

#

same as doing the matrix multiply in the fs rgbemoji

#

anyways, my motion vectors are sane now

heavy cipher May 23, 2023, 9:56 AM

#

btw perspective divide in the fs is not always right

long robin May 23, 2023, 9:59 AM

#

when is it wrong?

heavy cipher May 23, 2023, 10:00 AM

#

if you need clipping on the near plane

long robin May 23, 2023, 10:04 AM

#

isn't the pipeline already doing clipping for me here

shell inlet May 23, 2023, 10:06 AM

#

why would there be a fragment shader invocation for a fragment that gets clipped between vertex and fragment shader

#

if you only get interpolated data from vertices in fragment shader

#

and inbetween that the clipping happens

heavy cipher May 23, 2023, 10:10 AM

#

o hwait

#

i am doin a dumb

#

disregard me completely

shell inlet May 23, 2023, 10:10 AM

#

alr

long robin May 23, 2023, 10:11 AM

#

were u thinking of doing perspective divide on gl_Position in the fs

heavy cipher May 23, 2023, 10:11 AM

#

ye

long robin May 23, 2023, 10:11 AM

#

the pipeline takes another soul

shell inlet May 23, 2023, 10:11 AM

#

though I still don't understand how is it that interpolated NDC aren't same as interpolated clip space coords with perspective division

heavy cipher May 23, 2023, 10:12 AM

#

long robin they pass ndc coords to the fs and do the perspective divide there

i guess this threw me bc ndc coords are after persp divide

long robin May 23, 2023, 10:13 AM

#

shell inlet though I still don't understand how is it that interpolated NDC aren't same as i...

idk maybe interpolating the divisor (w) does something funny

heavy cipher May 23, 2023, 10:13 AM

#

in this sense i have no idea what this means then

shell inlet May 23, 2023, 10:13 AM

#

well the clip space is linear so it shouldn't do anything funny

#

but interpolating NDC might

long robin May 23, 2023, 10:14 AM

#

heavy cipher in this sense i have no idea what this means then

they generate ndc coords for current and previous frame unjittered positions, then pass them to the fs, do the persp divide, and then subtract to get the motion vectors

shell inlet May 23, 2023, 10:14 AM

#

but then the interpolation is also perspective-correct

heavy cipher May 23, 2023, 10:14 AM

#

are you sure you don't mean clip space

#

again ndc is after persp divide

long robin May 23, 2023, 10:14 AM

#

oops I mean clip space gets interpolated

#

misinfo moment

heavy cipher May 23, 2023, 10:14 AM

#

misinfo to the bone

long robin May 23, 2023, 10:21 AM

#

anyways, I am once again staring at this function
https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/master/src/ffx-fsr2-api/ffx_fsr2.cpp#L663

#

I think I can upgrade it by adding a third dimension to the matrix_elem_ variables with the corresponding magic numbers

heavy cipher May 23, 2023, 10:28 AM

#

fsr3

#

FFX_FSR2_ENABLE_DEPTH_BAD

long robin May 23, 2023, 10:42 AM

#

long robin anyways, I am once again staring at this function <https://github.com/GPUOpen-Ef...

where the heck did they get this from (apparently it corresponds to row 3, column 3 of the matrix somehow)
const float fQ = fMax / (fMin - fMax);

#

trying to figure out how they derived it from this
https://vincent-p.github.io/posts/vulkan_perspective_matrix/

#

the inverse of the matrix is shown later on, but I still don't see the connection

long robin May 23, 2023, 11:03 AM

#

something still ain't right 😦
https://i.imgur.com/02Ni0D4.png

Imgur

golden schooner May 23, 2023, 11:06 AM

#

batman_hmm

long robin May 23, 2023, 11:30 AM

#

pushed my current stuff to fsr2-test branch of Fwog if anyone wants to observe the bugs

oak garden May 23, 2023, 11:34 AM

#

wait so i have a really dumb question

#

fsr2 works fine on n🅱️idia gpus right?

long robin May 23, 2023, 11:35 AM

#

ye

oak garden May 23, 2023, 11:35 AM

#

i should really integrate that then tbh

long robin May 23, 2023, 11:35 AM

#

most of the pics I showed were taken on my 3070

oak garden May 23, 2023, 11:35 AM

#

much less "magic black box" than dlss lmao

#

bleakekw

#

time to make fsr2-real

long robin May 23, 2023, 11:36 AM

#

the api surface is quite small

oak garden May 23, 2023, 11:36 AM

#

yeah should be easy to make bindings for

long robin May 23, 2023, 11:36 AM

#

idk why that person gave up 😄

oak garden May 23, 2023, 11:36 AM

#

🤷got bored probably

golden schooner May 23, 2023, 11:36 AM

#

rust bit them in the butt 😛

oak garden May 23, 2023, 11:37 AM

#

kek

#

that is a chonker of a readme

dapper gorge May 23, 2023, 11:50 AM

#

Does baldurk just hate OpenGL? 😦

long robin May 23, 2023, 11:51 AM

#

I have no idea if he's correct in that what I'm trying to do is not well-defined

#

I don't see why not. After all, spirv supports regular-ass uniform variables

#

Either way, I'm relying on that behavior for this whole operation to succeed nervous

oak garden May 23, 2023, 11:54 AM

#

NanaStare

valid oriole May 23, 2023, 12:02 PM

#

oak garden <:bleakekw:1082598350303539240>

9 months ago

oak garden May 23, 2023, 12:02 PM

#

exactly dread_cat

oak garden May 23, 2023, 1:44 PM

#

@long robin im trying to build fsr2 and im getting this when running the script Thonk

oak garden May 23, 2023, 2:22 PM

#

hmm looking at whats inside i think i can just yeet that dependency

long robin May 23, 2023, 5:11 PM

#

Hmm

#

I don't even use that script lol

oak garden May 23, 2023, 5:13 PM

#

Yeah I stopped using it too

#

Do you know how fsr compiles/loads it shaders

#

Im a bit conchfused

dapper gorge May 23, 2023, 5:17 PM

#

I think ffxFsr2ContextCreate creates shaders?

oak garden May 23, 2023, 5:18 PM

#

But where does it expect sources to be

#

And does it compile them at build time or at runtime

dapper gorge May 23, 2023, 5:18 PM

#

They are all already compiled using their own shader compiler (I think)

oak garden May 23, 2023, 5:18 PM

#

It looks like it’s shipping dxc as a DLL so I assume at runtime somehow

dapper gorge May 23, 2023, 5:19 PM

#

Shaders are in ffx-fsr2-api/shaders

oak garden May 23, 2023, 5:19 PM

#

Hmm okay

#

So I don’t really have to care

#

That’s cool

#

I won’t be including the headers directly in the rust bindings ofc

#

Do they embed the shaders in the binary?

long robin May 23, 2023, 6:11 PM

#

Shaders are compiled at build time using the ffx shader tool, which invokes glslang, dxc, or fxc

#

Shaders get embedded into header files if that's what you're wondering

#Fwog and co.