Hey, How can i give/remove/check flag of another player? I'm trying to use commands but cant figure it out
https://paste.denizenscript.com/View/129475
I scripted this myself so its not the best code ;3
#(SpaceSlayer) Flag other players
surreal girder
vivid isleBOT
(SpaceSlayer) Flag other players
vivid isleBOT
Hey, How can i give/remove/check flag of another player? I'm trying to use comma...
Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
brazen knot
You have to convert the argument to a PlayerTag in order to flag it
untold rover
!t server.match_player
half masonBOT
!t server.match_player
untold rover
!t server.match_offline_player
half masonBOT
!t server.match_offline_player
untold rover
Depending if you want it to work online or both.
surreal girder
You have to convert the argument to a PlayerTag in order to flag it
wait what
brazen knot
The way you have the script set up, it’s flagging the arg itself, not the player it represents
!c flag
brazen knot
!objecttype PlayerTag
half masonBOT
!objecttype PlayerTag
surreal girder
!objecttype PlayerTag
ye i get flags but idk how to flag the player from the cmd
brazen knot
Same way you’re doing now, but replace the “context.args.get” with a PlayerTag
brazen knot
This one’s my personal favorite
surreal girder
so - flag <server.match_player[<name>]> flag123 expire:1m
untold rover
so `- flag <server.match_player[<name>]> flag123 expire:1m`
Yes. But make sure it actually exists before flagging it. Verify your arguments.
!t objecttag.exists
half masonBOT
!t objecttag.exists
untold rover
While it's unlikely to fail, better to be safe.
half masonBOT
!g don’t trust players
surreal girder
Well yeah,
wait i was using
- narrate "<player.flag_expiration[flag123].from_now.formatted>" to check if they have the flag but it doesnt work
brazen knot
!t PlayerTag.has_flag
half masonBOT
!t PlayerTag.has_flag
untold rover
If you use <player> tag then it's using the linked player, the person running the command.
surreal girder
If you use `<player>` tag then it's using the linked player, the person running ...
im assuming i messed up with this
<<server.match_player[<name>]>.has_flag[<flag123>].from_now.formatted>
brazen knot
Double << is always unnecessary, you can just combine the tag together
untold rover
has_flag returns a boolean, not a timetag.
brazen knot
And the <name> will likely return nothing, as you need something to compare the name too, such as your arguments
!g what do tags look like in real usage
surreal girder
so - narrate "<server.match_player[<context.args.get[2]>]>.flag_expiration[<flag123>].from_now.formatted>"
brazen knot
!g first tags
half masonBOT
!g first tags
brazen knot
Right before the “flag_expiration”, just remove that >
untold rover
You should also define the targeted player prior.
- define target <server.match_player[<context.args.get[2]>]>
So then you can call that definition for other things since you'll need it to check if they have the flag, and then flagging the object.
While not necessary, it reduces redundant code.
untold rover
It's a good idea to use a definition, so then you can use it in place of the lengthy match player.
That won't work because you're just using the plain text of target.
Definitions should be covered in the guide, are you unsure of how to use them?
!g how do you use definitions
untold rover
!g short term memory
half masonBOT
!g short term memory
surreal girder
!g short term memory
ye i just finished reading it
ik im stupid, but i defined target as arg 2 while checking for player
then used target to set flag which should set it on that target no?
surreal girder
untold rover
half masonBOT
!ds https://paste.denizenscript.com/View/129478
untold rover
flag123 is not a valid tag.
Remove the tag lines <>
Line 58 is wrong.
It's not cleanly wrapped.
surreal girder
ye forget that
untold rover
Line 55 still doesn't use definitions.
surreal girder
- flag <[target]> flag123 expire:1m?
<[target]> is to call the definition and flag123 is the flag
untold rover
That should work.
surreal girder
That should work.
its not unless
- narrate "<[target].flag_expiration[<flag123>].from_now.formatted>" is wrong
surreal girder
untold rover
half masonBOT
!logcheck https://paste.denizenscript.com/View/129480
untold rover
You're on a unsupported minecraft version.
Also
Can you
Re-paste your script.
It's changed since.
surreal girder
You're on a unsupported minecraft version.
oof
untold rover
That's not the problem here, but it's something to be aware of.
surreal girder
untold rover
Line 49. Target is undefined.
You did not define target before this instance.
Also line 33, while not necessary you can instead use
!t listtag.first
half masonBOT
!t listtag.first
untold rover
Also, while you don't need to do this it can be considered better practice to just - stop your script if you're doing a simple if/else, depending on the script.
surreal girder
Also, while you don't need to do this it can be considered better practice to ju...
hey, last thing b4 i close the post
i tried <[char1]> char1 [char1] for good measure, but idk what else to do
and i checked ingame with /ex flag 5 is there
untold rover
You're submitting the plaintext of char1, which is fine. That's how you usually check for an element.
untold rover
and i checked ingame with `/ex flag` 5 is there
/ex flag will store a flag, not narrate.
Can you debug the script while also narrating the server flag of char1?
/ex narrate <server.flag[char1]>
(Also be aware tha we have rules against pinging for help, I don't mind in this case but be aware of that please.)
surreal girder
surreal girder
(Also be aware tha we have rules against pinging for help, I don't mind in this ...
oh ok ty, ill turn off the pinging and keep it to reply
untold rover
Okay so.
You're flagging the server with the definition of char1. Which is 5. So you have a server flag of 5 currently.
It'll use whatever is inside the definition, not the name of the definition.
surreal girder
ye thats correct, i want to flag the server with a number (well in the actual code its a longer number)
so i wanted to check if that number already exists, if yes to generate a new one
untold rover
Then you'd need to do - flag server char1:<[char1]> if you want to have a server flag of char1 read as 5
Otherwise if you do - flag server <[char1]> you're just telling the server to flag the server with 5 as true
surreal girder
but wait when i regenerate a new number it says the server already has the flag althought its a new number
untold rover
Did you change the script?
surreal girder
untold rover
!xy
untold rover
What is this all going to be for in the end?
surreal girder
lemme sum up the code, im making a player bank, doing /bank create generates a uique code that only that executor can use
using the code the player can do different tasks like deposit, withdraw etc
untold rover
That doesn't make sense on why they'd need a special code at all.
surreal girder
cuz the player can create accounts with multipel banks
and i need a way to seperate each bank
untold rover
Different storage at different locations I assume.
surreal girder
its mostly virtual
untold rover
Yeah I can see something like /bank ironsafe withdraw or /bank goldtown withdraw that makes some sense, but the unique code doesn't make sense to me in this context.
surreal girder
thats where the unique code comes in, certain players create a bank ingame, which is added to a list
lets say bank owner does /bank create (name) it adds that bank to the list
then the player comes in and makes an account with that bank
banks are not preset, but made live ingame
ive already done that and it works
untold rover
Right, you make a bank of say /bank create diamondvillage then what? I don't see how the unique code is needed here.
surreal girder
but how do i make the player access their diamondvillage account?
untold rover
You mean when they sign up for the bank?
surreal girder
https://paste.denizenscript.com/View/129504 heres the full code
surreal girder
You mean when they sign up for the bank?
ye
untold rover
Okay but where are you adding users to said bank.
surreal girder
wym
untold rover
Am I misunderstanding something here? Aren't banks suppose to let other players deposit and take items, and not the bank owner?
Or is this basically just a virtual stash for every player to create for themself?
surreal girder
ye but the bank owner creates the bank i.e puts it in the system so when other players do /bank list and click on their bank it makes an account for them
i made the code where u can add a bank to the system but cant figure out how to let players create an account
untold rover
I wonder what the advantage of the bank owner has versus just a npc. Huh. That aside..
You don't need to generate a number.
Just use the players uuid as a identifier.
!t playertag.uuid
half masonBOT
!t playertag.uuid
surreal girder
wdym advantage?
untold rover
With the uuid you can use that as an identifier to check whatever is necessary.
- flag server banks.super_custom_bank.accounts.<player.uuid>.cash:0
And whatnot.
Also.
Line 56. I see you stopping the script but then doing the if/else anyways. There's no need to have the else check if you're doing a stop prior during an if check. It'd be different if you had multiple else if checks.
- if !<player.has_flag[my_flag]>:
- stop
- narrate "They have the flag"
It prevents nesting.
surreal girder
so add <player.uuid>.cash:0 to this
- flag server bankssaveddata:->:<list[<server.flag[bankname]>|<server.flag[bankowner]>|<server.flag[legalentity]>]>
- flag server bankssaveddata:->:<list[<server.flag[bankname]>|<server.flag[bankowner]>|<server.flag[legalentity]>].<player.uuid>.cash:0>
untold rover
That makes sense, but why are you using a list and not a map?
surreal girder
no clue honestly
untold rover
Define has examples of how submapping works.
This is also supported via flags.
Did you notice what I did with my flag example earlier?
wanton isle
untold rover
- flag server my_flag.a_custom_key.<player.uuid>:100
This would flag the server with different keys, with the player uuid being the final key with a value of 100.
You would be able to pull up information the same way with narrate.
- narrate <server.flag[my_flag.a_custom_key.<player.uuid> and that should read 100.
- narrate <server.flag[my_flag.a_custom_key]> will show you the maptag with the players uuid being a key and 100 being it's value, and any other entries if they exist
Ah, good catch.
This is practically necessary for a deep information system like what you're doing.
When making your bank I'd suggest constructing the map before flagging the server.
!c definemap
half masonBOT
!c definemap
untold rover
While you can individually flag each and every value, it's not recommended unless necessary. Case by case basis. In this case it seems unnecessary because you're already trying to define four values. Owner. Entity, and some other stuff.
surreal girder
ok so instead of the whole list i make it unique to the executor's uuid (which is the bank owner)
and customkey is the bank name?
untold rover
Wouldn't you want the bank name to be the unique ID for the bank? It'd be a pain go to through all of those uuids as the very first key for the banks, and then read the bank name to the player on a code level.
I mean you can do it sure, I just think it's more work.
surreal girder
wait then im confused
- flag server my_flag.a_custom_key.<player.uuid>:100 if i put this in the script it will flag the server with the bank owner's uuid and i can use their uuid to make accounts?
or custom key is the code to the personal accounts?
untold rover
That will flag the server with the key my_flag with subkeys of a_custom_key.<player_uuid>
Besides the player uuid, the rest is just plaintext. It's an example.
Obviously you can make it much deeper.
So if you wanted to you could end up doing - flag server banks.piglin_town.accounts.<player_uuid>:0
So piglin_town now has a subkey of accounts which has one account, and is using the players uuid of whoever was running the command to make that.
It's all examples, how you want to read the information is up to you. Is the bank only for cash? Is it for items too? You'll have to consider where to slot in the owner information. Something like banks.piglin_town.owner:<player> and such.
surreal girder
ye its money only
untold rover
Also be aware that I'm not sure if the banks name is gonna be more than one word, things get a little dicier if you make the banks name with spaces and also a key. You're generally not suppose to have spaces in keys when making maps.
But you're only getting the second argument and not everything afterwards, so it's fine.
( Alternatively, you could let the bank owner change the 'display name' of the bank, making it read differently to whoever is accessing the bank. Making it look nicer than just something like my_perfect_bank )
untold rover
You're only getting the second argument in your context args when making a bank, it's fine as is. Or should be.
Also.
Something I've noticed.
You're doing a lot of repeating prefixes for narration.
<&color[#3d85c6]>CB of Suncrest <gray>|
You don't have to do this.
!l format script container
half masonBOT
!l format script container
untold rover
!c narrate
half masonBOT
!c narrate
untold rover
Narrate can take format scripts.
So you can shave off some repeated effort.
Although I recommend testing it to be double sure.
surreal girder
ok ill get to that later ty
to compile the steps
Step 1: - flag server banks.piglin_town.accounts.<player_uuid>:0 which creates the bank
it creates a bank under the owner's uuid
untold rover
It creates the bank under the id of plglin_town, and adds the account of whoever the linked player is with a balance of 0
No owner is specified for the bank there.
surreal girder
do i replace piglin_town with the banks name?
random remnantBOT
do i replace `piglin_town` with the banks name?
untold rover
Yes. It was an example.
surreal girder
ok thats how i get the bank in the system
lets say i ditch the uuid thing
- flag server banks.<context.args.get[#]>.accounts to get the banks name
and put it as a subkey to the accounts
that should work right?
true vessel