#(flamexd) Npc's Traits Get Reset Once I Restart the Server.

67 messages · Page 1 of 1 (latest)

sacred plankBOT
#

(flamexd) Npc's Traits Get Reset Once I Restart the Server.

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.

shell python
#

Once the server started back up again I ran the /citizen reload command to see if it did anything and it threw these errors in console.

29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 24bc3369-8d82-2b14-aaa1-7ec9188cdf9d
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 60a359f2-1372-2dab-900c-a9a4e0117358
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 8d4857a1-8950-2db9-9c32-e1a77b9f4b96
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 84820550-7bd8-25cc-a02f-21c8afdf202b
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 3856a7bc-000f-2ca9-ad3f-db4d634deb00
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances ed2b9816-ca83-2ffc-ad7d-5b53ea5aef56
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 4c3ee358-b0b0-2bd9-8b59-e07cfc917870
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 39bbf5a9-089e-25e2-a451-28b48f5f2bb1
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 563101f0-a97e-2544-ae1e-4e2d6e354495
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 12c61d7d-b5a9-27a8-afe9-6830e376c90d
29.12 02:37:10 [Server] ERROR [Citizens] Player registered twice with different NPC instances 8ea65e67-0455-264d-a7a9-8aeec342be11

#

If i knew what that meant I may be able to fix this issue 😅

#

The left is what they look like once I reload the server and the right is what they are supposed to look like. Once again though, every time I restart the server all their commands seem to stop working and they go back to looking like a zombie

image.png
shell python
#

If I had to guess what trait is causing the NPC to reset. I think it would most likely be the
" customentity:
namespacedId: social_media_robot:youtube_robot"

#

just because the npc model gets reset as well

#

In my save's file the two NPC's i'm having issues with is number 22 and 23

ember valley
silk sedgeBOT
ember valley
#

why did you splice part of the logs?

#

o.o

#

!restartlog

silk sedgeBOT
# ember valley !restartlog
Info: restartlog

If you're having trouble posting your log file (!logs) or you posted a log but it's missing information, you might just need a restart!

What To Do: Restart your server, replicate the issue, and then Paste your logs/latest.log file right after.

Why: sometimes logs contain a lot of unrelated output if the server's been running too long which makes them unable to paste properly. Also, every day at exactly midnight minecraft servers do a log rotation, which basically just means the latest.log no longer contains the startup section of log output, which is often the most important section of the log!

shell python
#

one is my saves.yml the other is my console

ember valley
#

restart your server and send the full latest.log file please

shell python
ember valley
silk sedgeBOT
# ember valley !checklog https://paste.denizenscript.com/View/129451
Log Check Results
Server Version

Purpur version 1.21.3-2358-ver/1.21.3@16ce24a (2024-12-04T12:57:44Z)

Plugin Version(s)

Citizens v2.0.36-SNAPSHOT (build 3642) -- (:warning:Outdated build, behind by 17)

Checked For

@ember valley

UUID Version

4 (:white_check_mark: Online)

Java Version

21.0.5 :white_check_mark:

Other Noteworthy Plugin(s)

WorldGuard v7.0.13-beta-1+2f13ae0, MythicMobs v5.8.0-SNAPSHOT-b73e45b0, ProtocolLib v5.4.0-SNAPSHOT-738

Possibly Relevant Plugin(s)

TAB v5.0.3 - This plugin adds Below_Name scoreboards to NPCs.
ViaVersion v5.2.1-SNAPSHOT - Mixed client vs server versions can sometimes cause packet-related issues.
Multiverse-Core v4.3.14 - Multi-world configuration plugins may affect NPCs in unexpected ways.
FastAsyncWorldEdit v2.12.2 - This plugin has been known to break the plugin load order on many servers, due to usage of the 'loadbefore' directive in its 'plugin.yml'.
GSit v1.12.1 - 'Sit on other players' or 'sit on mobs' plugins sometimes allow players to sit on NPCs.

Potentially Bad Line(s)

[03:17:29] [Server thread/ERROR]: [DeluxeAnnounce] Unnable to create cache file! The plugin will not work correctly! :warning: Log contains error messages.

ember valley
#

okay cool

dull vine
#

Is that an itemsadder trait?

#

The registered twice message doesn't mean anything in this case, it was removed in 1.21.4

shell python
#

Yes that is an itemsadder trait. The command ingame is /iaentity citizen 22 model social_media_robot:youtube_robot

#

I assume it adds it to the config file. This worked perfectly fine on the 1.20.4 version. Did the code get changed so that ItemsAdder is no longer supported?

shell python
#

Just tested adding commands to the default NPC without the model and it all seems to work fine after a server reboot. I think this has to be an issue between Citizens and ItemsAdder adding model data

#

Just did some more testing.

The three commands I add to the NPC are as follows:

  • /npc cmd add iaentity citizens 22 anim play discord_bot_hi
  • /npc cmd add npc playsound entity.experience_orb.pickup
  • /npc cmd add discord -p

At this point if I restart the server the NPC keeps all its traits and there are no errors. But when I add a custom model to the citizen utilizing the ItemsAdder plugin (/iaentity citizens 22 model social_media_robot:discord_robot), and restart the server. The NPC gets reset and throws this error again: "ERROR [Citizens] The trait failed to load for NPC ID: 22.".

Safe to say that this issue is between Citizens and ItemsAdder. It seems that Citizens does not like models being saved within the Saves.yml

#

I dont know why this changed between Minecraft versions 1.20.4 and the version I updated to which is 1.21.3

dull vine
#

I would enable citizens debug mode to get the load error but it sounds like it could be an itemsadder issue

dull vine
dull vine
whole pendantBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@shell python

shell python
#

This hasn't been resolved. I am attempting to contact some support over at ItemsAdder but have not heard anything as of yet

One question I have is, how is the error on the Citizens side if it's an ItemsAdder issue? From what I can tell the issue is that Citizens doesn't know what the custom ItemsAdder model means and then proceeds to delete/bypass the error.

Sorry if I sound arrogant, I just don't know what's going on and how I can fix it.

dull vine
shell python
#

Okay we'll do when I get home. Sorry for the delay

shell python
#

Sorry that took a minute. Here is my updated server log with Citizens Debug enabled: https://paste.denizenscript.com/View/129532

Server log with Citizens debug enabled | Paste #129532 | Denizen Pa...

Content of Server Log Paste #129532: Server log with Citizens debug enabled... pasted 2024/12/30 22:43:53 UTC-08:00, Paste length: 107019 characters across 1082 lines, Content: `[06:38:46] [ServerMain/INFO]: [bootstrap] Running Java 21 (OpenJDK 64-Bit Server VM 21.0.5+11-LTS; Eclipse Adoptium Temurin-21.0.5+11) on Linux 5.15.0-89-generic (...

silk sedgeBOT
# shell python !checklog https://paste.denizenscript.com/View/129532
Log Check Results
Server Version

Purpur version 1.21.3-2358-ver/1.21.3@16ce24a (2024-12-04T12:57:44Z)

Plugin Version(s)

Citizens v2.0.36-SNAPSHOT (build 3642) -- (:warning:Outdated build, behind by 17)

Checked For

@shell python

Java Version

21.0.5 :white_check_mark:

Other Noteworthy Plugin(s)

WorldGuard v7.0.13-beta-1+2f13ae0, MythicMobs v5.8.0-SNAPSHOT-b73e45b0, ProtocolLib v5.4.0-SNAPSHOT-738

Possibly Relevant Plugin(s)

TAB v5.0.3 - This plugin adds Below_Name scoreboards to NPCs.
ViaVersion v5.2.1-SNAPSHOT - Mixed client vs server versions can sometimes cause packet-related issues.
Multiverse-Core v4.3.14 - Multi-world configuration plugins may affect NPCs in unexpected ways.
FastAsyncWorldEdit v2.12.2 - This plugin has been known to break the plugin load order on many servers, due to usage of the 'loadbefore' directive in its 'plugin.yml'.
GSit v1.12.1 - 'Sit on other players' or 'sit on mobs' plugins sometimes allow players to sit on NPCs.

Potentially Bad Line(s)

[06:39:40] [Server thread/ERROR]: [Essentials] You are running an unsupported server version! :warning: Log contains error messages.

dull vine
#

ok I have located the problem @shell python - itemsadder is having an error in its save function which is affecting you. I have pushed a change which ignores errors from other plugins but it is only for 1.21.4

#

you will need to either fix NPC ID 22 and 23 manually in the saves.yml or re-create them

#

here is the fixed saves.yml

shell python
#

So does the fixed YML fix the issue or is it only fixed in 1.21.4?

dull vine
#

the issue is that items adder trait is throwing an error when saving

#

in your version of citizens, that error will not be ignored

#

in 1.21.4, the error is ignored

#

the fix in both cases is that itemsadder needs to stop this error from happening

#

but citizens will ignore it in 1.21.4

shell python
#

and I'm assuming Citizens is not backwards compatible right?

dull vine
shell python
#

damn, most plugins dont work on 1.21.4 yet. that sucks

#

Well thanks for your help. Means a lot that you tried to help man ;D

dull vine
#

well, the other fix is for ItemAdder to not throw an error

shell python
#

Yeah

#

the dev for ItemsAdder has yet to respond in his discord which kinda sucks tbh. But you've been great! Thanks again for all your help!

whole pendantBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@shell python

whole pendantBOT
#
Auto-Close Timeout

No response to request to close thread after 2 days. Automatically closing.

whole pendantBOT
#
Thread Reopened

Thread was manually reopened by @shell python.

versed depot
#

was there a reason you reopened this thread? if not,

whole pendantBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@shell python