(drjoenh) stop_sound feature request | Denizen and Citizens | Page 1

vague heart Sep 9, 2024, 7:52 PM

#

Hi, Im suggesting ability to use https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Sound.html inside stop_sound mechanism

Sound (Spigot-API 1.21.1-R0.1-SNAPSHOT API)

declaration: package: org.bukkit, enum: Sound

burnt glenBOT Sep 9, 2024, 7:52 PM

#

vague heart Hi, Im suggesting ability to use https://hub.spigotmc.org/javadocs/spigot/org/bu...

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.

empty shell Sep 10, 2024, 8:59 AM

#

!m stop_sound

gentle summitBOT Sep 10, 2024, 8:59 AM

#

empty shell !m stop_sound

Mechanism: stop_sound

Stops all sounds of the specified type for the player.
Valid types are AMBIENT, BLOCKS, HOSTILE, MASTER, MUSIC, NEUTRAL, PLAYERS, RECORDS, VOICE, and WEATHER
Instead of a type, you can specify a full sound key, which usually has the 'minecraft:' prefix.
If no sound type is specified, all types will be stopped.

Object

PlayerTag

Input

ElementTag

empty shell Sep 10, 2024, 8:59 AM

#

Instead of a type, you can specify a full sound key, which usually has the 'minecraft:' prefix.

#

Cant you do that already?

vague heart Sep 10, 2024, 9:04 AM

#

nah

#

you would need to map Sounds enum to minecrafts keys

#

eg. AMBIENT_BASALT_DELTAS_ADDITIONS -> minecraft:ambient.basalt_deltas.additions

dim crow Sep 10, 2024, 11:09 AM

#

No, the stop sound uses nms and not spigot api to stop the sound, so you would use the minecraft key directly and not the enum

#

Oh wait nvm i just reread your request PE_PandaFacepalm

tardy yarrowBOT Sep 10, 2024, 8:25 PM

#

Changed to Feature

Thread is now a Feature thread. This indicates a request for a new feature to the plugin, that both (A) does not already exist and (B) reasonably can be added. If you are unsure whether this applies, use </helpthread:1028674284870180883> to change back to a normal help thread.

vague heart Sep 10, 2024, 8:25 PM

#

is there even a reason why do we use nms instead of spigots api?

#

ohh i see why

vague heart Sep 10, 2024, 9:01 PM

#

well

#

PR open https://github.com/DenizenScript/Denizen/pull/2645

empty shell Sep 10, 2024, 9:22 PM

#

vague heart is there even a reason why do we use nms instead of spigots api?

what was it

vague heart Sep 10, 2024, 9:22 PM

#

not supported on older versions

empty shell Sep 10, 2024, 9:22 PM

#

I think there was another reason we didnt use spigot

#

and went to nms

vague heart Sep 10, 2024, 9:24 PM

#

although we now use it for SoundCategory so I assume its fine for Sound as well

empty shell Sep 10, 2024, 9:24 PM

#

ah ye #denizen-pre-forum message

#

spigotapi is/used to be broke

vague heart Sep 10, 2024, 9:25 PM

#

my testing ended up just fine, will wait what aya/mcmonkey has to say

violet canopy Sep 30, 2024, 9:09 PM

#

per #denizen-contrib message spigot is gonna replace that anyway

#(drjoenh) stop_sound feature request