(beanbeanju) Cat Type Autocomplete Not Working

[buoyant rampart]

Runnong on the latest version on 1.21 and 1.21.1, the running /npc cat --type () does not auto complete at all, but when typing the correct name the command still works.

[tired swallow]

(beanbeanju) Cat Type Autocomplete Not Working

[tired swallow]

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.

[buoyant rampart]

It seems like it's just missing one line of code, I have tested it in 1.21 but not the other versions

Adding the one line of code fixed the issue in 1.21, should I make a PR?

[distant tapir]

Yes you can @buoyant rampart

[storm moat]

the underlying issue here is one that needs more of a core fix than the OP here realized, I'm pretty sure this is a side effect of interfacification spigot update in 1.21

some enums are no longer enums

Denizen workarounds this with a handler method that supports both old and new variants - https://github.com/DenizenScript/Denizen/blob/dev/plugin/src/main/java/com/denizenscript/denizen/utilities/Utilities.java#L546-L552

[buoyant rampart]

I think I understand, but how come the same code is used for wolf variants? https://github.com/CitizensDev/Citizens2/blob/73a5cfdee67e237c8c4b19bfde1de9429fe65fc8/main/src/main/java/net/citizensnpcs/commands/NPCCommands.java#L3652-L3710

Will that also be an issue in the future?

[storm moat]

probably because wolf is a very very old command, and the wolf variants are brand new, so that's an easy hack to make it work without breaking old minecraft versions

[buoyant rampart]

I see now, thank you for the clarification! Backwards compatibility is a pain but I understand why it's required

Ahh I get why the cat command is in its own class now, rather than in the NPCCommands file

[distant tapir]

Yes I suspect so

[rotund prism]

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

@buoyant rampart