(yriokiri) script review

[tribal galleon]

hi, i made this simple script to get better quality tools the more you craft them. i think i wrote it badly but idk, is there a better way to write this?

the script get triggered when a player finish crafting an item in a mmoitems crafting station

https://paste.denizenscript.com/View/121108

[silent tusk]

(yriokiri) script review

[silent tusk]

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.

[tribal galleon]

i used the syer. before flags for the flag synch system between servers.

[tribal galleon]

a friend suggested i do something like this but idk how to write it in denizen. idk even if it's possible.

[light patrol]

Well that screen shot is not valid syntax at all

!lang data script

[tropic canopy]

Language: Data Script Containers

Data script containers are generic script containers for information that will be referenced by other scripts.

No part of a 'data' script container is ever run as commands.

There are no required keys.

Generally, data is read using the !tag ScriptTag.data_key tag.

data_script_name:

    type: data

    # Your data here
    some_key: some value
    some_list_key:
    - some list value
    some_map_key:
        some_subkey: some value

Group

Script Container System

[light patrol]

You probably want this ^

[light patrol]

But short answer is yes. In general if you find yourself copy-pasting code there is certainly a better way

[tribal galleon]

oh yea i know, it was just a contextual example he made me

not for denizen but in general

[light patrol]

Its a little hard to tell you what to change without actually rewriting it for you, but start with using variables to cut down on the copy paste and try going from there

[tribal galleon]

ok so, first thing i changed is that i generalized the tool id, so i can use this dynamically for every tool i need. now one thing. is there a way to compare if a value is between 2 others instead of using >= 0 and < 50?

an operator i don't know about or something like that?

[light patrol]

No, there is no operator like that, but you can use a data script as mentioned above to store the min/maxs to reduce the number of if checks needed

[tribal galleon]

ye i was trying to do that

Yes!, i did it

https://paste.denizenscript.com/View/121125

[light patrol]

\o/

[tribal galleon]

thx