Allow the user to modify vertical spacing ("margin" to borrow a CSS term) between individual hologram lines
The code exists within HologramTrait but needs to be exposed via command
#(fullwall) Add configurable hologram margin command
mild breach
final juncoBOT
(fullwall) Add configurable hologram margin command
final juncoBOT
Allow the user to modify vertical spacing ("margin" to borrow a CSS term) betwee...
Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>
tiny elkBOT
junior sandal
hey fullwall, i'm interested in trying to work on this one. is there a specific way you would want the command to be formatted or implemented? my current thought process is add it to the hologram command as a sub command, but if you have a better idea on how it should work let me know. currently, the way i would implement this would be somehting like /npc hologram margin [line #] [top/bottom] [margin] or something like that. again, let me know if you have a more specific idea in mind :)
mild breach
hey fullwall, i'm interested in trying to work on this one. is there a specific ...
Yeah, that would be fine! The relevant fields are mt and mb in hologramline
Let me know if you need any help
junior sandal
alright, thanks!
junior sandal
hey fullwall, i have a quick question. how do you want the margin data to be saved, and how do i save/load it. i'm assuming i have to do something with the YAML, but i'm not sure if you want it in a specific way. my current idea is margins.top.<index> and margins.bottom.<index> but i've been messing with that and i've been having trouble getting the margins to load properly. i'm probably doing something wrong, but i just wanted to know your opinion on this
mild breach
hey fullwall, i have a quick question. how do you want the margin data to be sav...
Yeah that’s probably fine, or you could persist the object like lines.0.text and lines.0.margin
I’m not at a computer until after work but you could see the persistence api
junior sandal
Yeah that’s probably fine, or you could persist the object like lines.0.text and...
I’ll try the one you suggested and see how it works. thanks for the idea
junior sandal
yeah that way works a lot better imo. i'll make sure to also add support for the old version of just lines.0: text and then save it as the new lines.0.text version 👍
mild breach
@junior sandal has kindly implemented this