#(Pierrelasse) Non bloat version of citizens?

42 messages · Page 1 of 1 (latest)

open inletBOT
#

(Pierrelasse) Non bloat version of citizens?

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>

fleet ledge
#

Why do you need that?

#

The folders are needed anyway to store the NPC data, and the commands do absolutely nothing unless used - none of that should matter for using it as an API

#

Citizens is an NPC plugin that has an API, not the other way around - again I don't really get why do the commands and folders bother you, they have no effect on anything whatsoever, and regardless a server using your plugin may also want to use Citizens as usual

#

But there is really no reason at all for your plugin to care about the commands/folders, in the absolute worst case scenario, a server would install Citizens just for your plugin, and have an extra folder and few commands they'll just never use/even be aware of

iron parcel
#

@hard bison I understand your request, but "being clean" is not a reason for me to completely rewrite the plugin for a third time

#

@hard bison I understand what you want, but you do not have an explanation as to why you want it

fleet ledge
#

Citizens requires a lot of code to work, it's not something you can just copy/paste

#

But you're talking about potential features other people may want at some point, what's stopping you specifically from just, having Citizens on your server

#

As far as I can see, nothing is stopping you from doing that/there are no actual disadvantages

#

That can be said for pretty much anything - someone may only want player NPC's, but that doesn't mean they need a custom version of Citizens with the code for all other NPC types stripped out

#

They can just have Citizens, and only use what they need

#

I'm not saying it's necessarily bad, but the development effort for fullwall to maintain several different versions of Citizens just isn't worth it at all, compared to just having a couple extra features that you won't use & won't do anything

#

Well, you'd need to have several different GitHub repos, which would be incredibly annoying as you'd need to commit the same changes to each and every one
Or separate everything into a ton of tiny modules, which would be really messy code-wise and probably slow down compile time by a ton
And other then that, code integrates with itself, it's not as simple as just deleting a class - a lot of stuff use each-other

#

And again, the main point is that there's just... no reason to - you still haven't explained any practical advantage to using a Citizens jar with a few less classes

iron parcel
#

it sounds like you just want to copy paste Citizens into your codebase

#

unfortunately, it doesn't work like that

coarse flintBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@hard bison

iron parcel
#

you need to provide some kind of motivation for these changes

#

because it takes time to implement them

#

time that I could spend... on more important features

#

"it would be nice if" is not sufficient, because a solution already exists

fleet ledge
#

Developers already use it, there are a lot of plugins using Citizens' API

iron parcel
#

source?

#

many people are doing many things

fleet ledge
#

Not having commands/a few features in Citizens won't make any difference whatsoever for people using the API

iron parcel
#

I want to spend time on important issues that people have

#

but you haven't explained why you want this so badly

#

I've said this before, but this discord is not an anxiety service

coarse flintBOT
#

@hard bison

Thread Close Blocked

Thread was closed either automatically by timeout or by the Discord manual close button. If closing was intentional, please use </resolved:1028673926114594866> or </invalid:1028673926898909185>.

iron parcel
#

I don't appreciate being insulted, thanks

coarse flintBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@hard bison