(Hepno) PlayerAnimation causes Thread Dumps | Denizen and Citizens | Page 1

high lodge Feb 4, 2023, 8:09 PM

#

Using PlayerAnimations to make a corpse be set to sleeping, whenever this happens, the server thread dumps. Is this method not thread safe?

tired fiberBOT Feb 4, 2023, 8:09 PM

#

(Hepno) PlayerAnimation causes Thread Dumps

tired fiberBOT Feb 4, 2023, 8:09 PM

#

high lodge Using PlayerAnimations to make a corpse be set to sleeping, whenever this happen...

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>

#

frail cloak Feb 4, 2023, 8:10 PM

#

high lodge Using PlayerAnimations to make a corpse be set to sleeping, whenever this happen...

!logs

cinder canyonBOT Feb 4, 2023, 8:10 PM

#

frail cloak !logs

Info: logs

Please post your full latest log file.

Background Info: One of the most helpful tools to identifying the source of a problem is your server logs file! Logs contain all sorts of important information like server and plugin versions, any error messages, and a lot more important information (More Info).

How To: Your log can be found in the logs folder within your server folder. The most recent log is a text file labeled latest.log. To get help using these logs, please open that file in a text editor and copy all of the text, then open https://paste.denizenscript.com/New/Log and paste the text into the box on the page. Then click "Submit" and copy the URL and paste that back into this channel.

Please do not upload the file to Discord or to other pastebin services, use the log pastebin linked above.

high lodge Feb 4, 2023, 8:12 PM

#

📎 2023-02-04-16.log

#

That should work

robust sorrel Feb 4, 2023, 8:13 PM

#

high lodge

!logcheck

cinder canyonBOT Feb 4, 2023, 8:13 PM

#

robust sorrel !logcheck

Repasted

Incorrect upload of log reuploaded to pastebin at https://paste.denizenscript.com/View/105982

#

Log Check Results

Server Version

Purpur version git-Purpur-1171 (MC: 1.16.5)

Plugin Version(s)

Citizens v2.0.30-SNAPSHOT (build 2753) -- (:warning:Outdated build, behind by 148)

Checked For

@robust sorrel

UUID Version

4 (:white_check_mark: Online)

Other Noteworthy Plugin(s)

WorldGuard v7.0.5+3827266, MythicMobs v5.1.4-3aa1b5d2, ProtocolLib v5.0.0-SNAPSHOT-b612

Problematic Plugin(s)

PlugManX v2.3.0 - :warning: Plugin Managers are dangerous and will cause unpredictable issues. Remove it.

Possibly Relevant Plugin(s)

TAB v3.1.5 - This plugin adds Below_Name scoreboards to NPCs.
ModelEngine vR2.5.2 - ModelEngine has Citizens support, but that support is known to be buggy. Issues related to NPCs that use ModelEngine should be reported to ModelEngine support, not Citizens.

robust sorrel Feb 4, 2023, 8:13 PM

#

Your build of Citizens is extremely outdated -

#

!update Citizens

cinder canyonBOT Feb 4, 2023, 8:13 PM

#

robust sorrel !update Citizens

Update Citizens

Latest Citizens dev builds are at https://ci.citizensnpcs.co/job/Citizens2/.
Spigot releases of Citizens are available at https://www.spigotmc.org/resources/citizens.13811/.

robust sorrel Feb 4, 2023, 8:13 PM

#

And also

#

!forks

cinder canyonBOT Feb 4, 2023, 8:14 PM

#

robust sorrel !forks

Info: forks

Our plugins (Citizens, Sentinel, and Denizen) officially support both Spigot and Paper.
Any other forks of the Bukkit project are not supported, but may or may not work in practice.

Lower forks, like CraftBukkit, do not function. You must upgrade to a higher fork (Spigot or Paper).
Hard forks and cross-forks, like Cauldron/Magma/Mohist/Any other Forge-integration fork, or Cardboard/any other Fabric-integration fork, will not work. Some unofficial custom builds of Citizens are made to support these servers, but we cannot provide any support for them here.
Higher forks above Spigot/Paper, such as Purpur, Airplane, etc. are compatible with Citizens only as much as they are compatible with Spigot/Paper. They are generally expected to work in most cases, but we cannot make any guarantees. We will still offer support to users running such forks, but be aware that if you encounter bugs while running such a fork, we may ask you to replicate them on Spigot/Paper to confirm they aren't caused by changes the fork made.

robust sorrel Feb 4, 2023, 8:16 PM

#

But also, looking at the thread dumps, what causes you to think they're caused by Citizens? they seem to mention Essentials

high lodge Feb 4, 2023, 8:29 PM

#

robust sorrel But also, looking at the thread dumps, what causes you to think they're caused b...

I have a plugin using CitizensAPI which spawns a corpse NPC upon player death. I ran /suicide to test it. The NPC appears, tries to lay down, then thread dumps

terse sinew Feb 5, 2023, 3:23 AM

#

And you’re running the code async?

#

No, it’s not thread safe

spice lightBOT Feb 5, 2023, 3:23 AM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@high lodge

frail cloak Feb 5, 2023, 6:26 PM

#

high lodge I have a plugin using CitizensAPI which spawns a corpse NPC upon player death. I...

You're running the command /suicide will kills you, and then what appears to be your own plugin listens to the death dev.hepno.myrutils2.Events.DeathBan.onPlayerDeath(DeathBan.java:110) and then executes an SQL query on main thread. SQL takes time to read, and so that locks up the server thread. That "the thread dumps" you're saying is your server is freezing (because it's waiting on SQL) and the watchdog is giving you a thread dump so you can see why

#

SQL in minecraft is dirty, ideally you'd just not use (instead prefer something like a local config), but if you must use SQL, then trigger it off-thread (and if you need to process results, use bukkit scheduler to merge back to main thread for that)

#

which for the record none of this involves Citizens, merely coincidental

spice lightBOT Feb 5, 2023, 6:28 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@high lodge

high lodge Feb 5, 2023, 6:39 PM

#

Ah got it, thank you!

#

I appreciate the help

spice lightBOT Feb 5, 2023, 6:45 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@high lodge

high lodge Feb 5, 2023, 6:48 PM

#

frail cloak You're running the command `/suicide` will kills you, and then what appears to b...

So run the SQL stuff asynchronously?

frail cloak Feb 5, 2023, 6:54 PM

#

ye

spice lightBOT Feb 8, 2023, 1:04 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@high lodge

#(Hepno) PlayerAnimation causes Thread Dumps