Issues with incorrect type definitions in blockbench-types | Blockbench | Page 1

drifting juniper Aug 21, 2023, 5:31 PM

#

I am trying to see how difficult it would be to port the geckolib animation utils to typescript and am conducting an experimental integration. I'm noticing some errors in the type definitions, for example, PluginOptions.awaitLoading is typed as a string rather than a boolean, and DialogOptions.form does not permit a default property. Does anyone know if Jannis is accepting PRs to the blockbench-types repo, and if not, what the process is for getting these errors corrected? Thanks.

hexed needle Aug 21, 2023, 5:34 PM

#

snavesutit has made prs before so i assume you can just make prs

drifting juniper Aug 21, 2023, 5:38 PM

#

cool thanks. just checking cause at one point jannis was not accepting PRs to blockbench repo, not sure if that's still the case.

worn sinew Aug 21, 2023, 8:46 PM

#

I think snave may be open to contributions to his repo as well.

noble pendant Aug 22, 2023, 6:14 PM

#

You can just PR yes

#Issues with incorrect type definitions in blockbench-types