1.20.5/6 Snapshots | The NeoForged Project | Page 3

slow prism Feb 22, 2024, 5:49 PM

#

i am fixing them

#

DO NOT TOUCH

fallen igloo Feb 22, 2024, 5:51 PM

#

I already fixed 3 classes

#

and pushed them

lean anchor Feb 22, 2024, 5:52 PM

#

Speaking of testframework.. can we have the empty structure stuff early pls

#

It'd save me some serious headache

fallen igloo Feb 22, 2024, 5:53 PM

#

can we first publish it at all

slow prism Feb 22, 2024, 5:55 PM

#

fallen igloo I already fixed 3 classes

f you

#

Stabby

#

there

#

the framework is fixed

foggy steeple Feb 22, 2024, 5:56 PM

#

For now

#

Let me unfix it

lean anchor Feb 22, 2024, 5:58 PM

#

dead

fallen igloo Feb 22, 2024, 5:59 PM

#

48 compile errors in the tests

#

maty I think there are some stabbies coming your way

stiff galleon Feb 22, 2024, 6:15 PM

#

"the stabbies" sound like the awards we'd give out at the end of modjams stevethink

fallen igloo Feb 22, 2024, 6:16 PM

#

yea but only for the worst entries

slow prism Feb 22, 2024, 6:25 PM

#

fallen igloo maty I think there are some stabbies coming your way

why

digital drum Feb 22, 2024, 6:25 PM

#

slow prism why

you have been summoned, there are crashes

elder swallow Feb 22, 2024, 6:28 PM

#

magic sierra Feb 22, 2024, 6:31 PM

#

does it crash when you load a world?

#

or does it work perfectly?

misty crow Feb 22, 2024, 6:33 PM

#

frail hatch Feb 22, 2024, 6:57 PM

#

“Perfectly” is very broad

slow prism Feb 22, 2024, 7:15 PM

#

the tests don't compile

#

abolbsad

stiff galleon Feb 22, 2024, 7:16 PM

#

you need a compiler to do that

fallen igloo Feb 22, 2024, 7:18 PM

#

slow prism the tests don't compile

on it

slow prism Feb 22, 2024, 7:30 PM

#

you're late

#

i think i've done all

fallen igloo Feb 22, 2024, 7:31 PM

#

late? I'm down to 3

slow prism Feb 22, 2024, 7:32 PM

#

not sure why you'd change VanillaGameEvent to return a holder

fallen igloo Feb 22, 2024, 7:33 PM

#

because everything with GameEvent now works with Holder

slow prism Feb 22, 2024, 7:34 PM

#

well no it works with a holder when you pass it around

#

i don't think we should give events holders

fallen igloo Feb 22, 2024, 7:36 PM

#

I think we should because to get a holder back from the object you need the registry again

slow prism Feb 22, 2024, 7:36 PM

#

instead a quality holder change would have been to make the lang provider's addEffect accept a holder

slow prism Feb 22, 2024, 7:36 PM

#

fallen igloo I think we should because to get a holder back from the object you need the regi...

which the event is given

#

and since they're holders it's not like all the static fields in gameevent will keep being a holder<gameevent> for long

fallen igloo Feb 22, 2024, 7:37 PM

#

calling .value is more trivial than getting a holder for a value

slow prism Feb 22, 2024, 7:38 PM

#

¯_(ツ)_/¯

#

it's not like the holder itself is directly useful

#

the only thing a holder is directly useful for is seeing if the entry is in a tag

#

everything else is in optionals so it's arguably easier to go through a registry

fallen igloo Feb 22, 2024, 7:40 PM

#

slow prism it's not like the holder itself is directly useful

it is it has the is methods for checking

slow prism Feb 22, 2024, 7:47 PM

#

composter invalidation is broken

prisma locust Feb 22, 2024, 7:49 PM

#

fallen igloo I think we should because to get a holder back from the object you need the regi...

builtInRegistryHolder() isn't a thing?

fallen igloo Feb 22, 2024, 7:50 PM

#

no removed from GameEvent

slow prism Feb 22, 2024, 7:51 PM

#

gametests saving us from bugs

#

my dream coming true

fallen igloo Feb 22, 2024, 7:52 PM

#

maty fix the last compile error

slow prism Feb 22, 2024, 7:53 PM

#

there's still compile errors?

#

and you made me discard my test fixes Stabby

#

smh

fallen igloo Feb 22, 2024, 7:53 PM

#

yes there is one compile error in the tests

misty crow Feb 22, 2024, 7:55 PM

#

@elder swallow I still can't say for certain why the 45 degree face flickering is fixed, but I can't reproduce it anymore with our fix disabled. My best guess is that the precision issue is fixed by PoseStack not doing those weird normal inversions in some of its methods. Should we nuke it or do we want to keep it as a nice-to-have for mods?

fallen igloo Feb 22, 2024, 7:58 PM

#

maty why did you change the cures stuff?

#

it should fall back if the set is not present

#

not be empty

slow prism Feb 22, 2024, 8:00 PM

#

fallen igloo it should fall back if the set is not present

no

fallen igloo Feb 22, 2024, 8:00 PM

#

it did before

slow prism Feb 22, 2024, 8:00 PM

#

an intentionally empty set would not be present

#

no it didn't

#

there's a test for that

fallen igloo Feb 22, 2024, 8:01 PM

#

empty set != not present

#

the clear happened after it checked if the compound tag has the key

#

so in this case if the optional is non empty

slow prism Feb 22, 2024, 8:02 PM

#

ahem

fallen igloo Feb 22, 2024, 8:02 PM

#

that is writing

slow prism Feb 22, 2024, 8:02 PM

#

yes and when you read that

#

whoops

#

you wanted the effect to not be curable

#

it's saved to the entity

#

and when the entity is restored

#

now it's curable

#

again, there's a test for it

fallen igloo Feb 22, 2024, 8:03 PM

#

ok then the filter is wrong not the ifPresent

slow prism Feb 22, 2024, 8:03 PM

#

the previous behaviour is that deserialized effects shall never be considered "new" effects for the purpose of filling cures

#

and that's how it should be

fallen igloo Feb 22, 2024, 8:04 PM

#

but now it is never curable if loaded from the codec

#

even if you omit it

slow prism Feb 22, 2024, 8:04 PM

#

well yes?..

#

that's precisely what i said

#

if it's loaded from a codec something wrote it

fallen igloo Feb 22, 2024, 8:05 PM

#

list not present should be default not no cures

slow prism Feb 22, 2024, 8:05 PM

#

that "something" is what created the effect and should have decided its cures

fallen igloo Feb 22, 2024, 8:07 PM

#

no

if the list is present and empty -> uncurable
if the list is present and contains cures -> cures
if the list is not present -> default cures

#

but you made it

if the list is present and empty -> uncurable
if the list is present and contains cures -> cures
if the list is not present -> uncurable

slow prism Feb 22, 2024, 8:19 PM

#

it's consistent with the old behaviour

#

which would always overwrite

#

and i don't see a reason not to always overwrite

#

@elder swallow "simple rejects" 😛 https://github.com/neoforged/Kits/commit/0d9c38e06c9ce767104cb1a8e72844226cf146a4#diff-4c3b1b0f88ed34faa7ad07d148e5c75a1d7cd36e32f1d9ff90ad0422d7796cbc

#

you didn't do any of the invalidation rejects

#

you saw it here first ladies and gentlemen

#

technici4n, mr. cap himself forgot to invalidate his caps

#

~~again~~

#

as if aecapfix weren't enough

#

now we need neocapfix

#

hmm, this looks wrong

#

wha

#

that's either wrong or the tests were spawned 13 million blocks away from spawn

#

well the pos seems to be correct

shut wraith Feb 22, 2024, 8:30 PM

#

concern

fallen igloo Feb 22, 2024, 8:31 PM

#

maty have you fixed the compile error

slow prism Feb 22, 2024, 8:31 PM

#

yes

#

hmm

#

#

this is weird

fallen igloo Feb 22, 2024, 8:31 PM

#

then push stabolb

slow prism Feb 22, 2024, 8:32 PM

#

misty crow Feb 22, 2024, 8:32 PM

#

The splitter is dead at the moment

slow prism Feb 22, 2024, 8:32 PM

#

is getBounds broken again

#

did we lose that patch

#

no

#

so the player isn't respawned exactly there

#

time to start up the test client

slow prism Feb 22, 2024, 8:38 PM

#

misty crow The splitter is dead at the moment

yeaaah

#

it's kicking me

misty crow Feb 22, 2024, 8:39 PM

#

You'll have to disable the LoginPacketSplitTest

slow prism Feb 22, 2024, 8:43 PM

#

sigh

#

the barrier blocks are preventing the soawn

wooden tendon Feb 22, 2024, 8:44 PM

#

misty crow The splitter is dead at the moment

Why

#

What did you guys do to my poor splitter?

#

What did he do to you

#

He was innocent in all of this

slow prism Feb 22, 2024, 8:44 PM

#

wooden tendon What did he do to you

crime?

wooden tendon Feb 22, 2024, 8:44 PM

#

Brought to the slaughter

#

On the altar of porting....

#

I can't believe it

misty crow Feb 22, 2024, 8:45 PM

#

wooden tendon Why

The packet codecs aren't global anymore and I haven't yet found a good way to funnel that info into the splitter and keep it updated (it changes with the "phase" changes)

slow prism Feb 22, 2024, 8:48 PM

#

i managed to get trapped in a gametest box

#

java.lang.IllegalStateException: Unregistered holder in ResourceKey[minecraft:root / minecraft:mob_effect]: DeferredHolder{ResourceKey[minecraft:mob_effect / many_mob_effects_test:effect_254]}
    at net.minecraft.Util.getOrThrow(Util.java:874) ~[main/:?] {re:classloading}

#

what that

#

also any changes that you make pls document them in the hackmd at the bottom

#

or any changes you notice in vanilla code

#

oh btw @lean anchor you will definitely need to add skyAccess = true to all of your game tests

#

very sorry for you

#

harold

fallen igloo Feb 22, 2024, 8:52 PM

#

gametests ran... only customRespawnTest fails

slow prism Feb 22, 2024, 8:52 PM

#

fallen igloo Feb 22, 2024, 8:53 PM

#

then push it

slow prism Feb 22, 2024, 8:53 PM

#

schurli you can test the client tests

#

while i go fix that chattype thing

fallen igloo Feb 22, 2024, 8:54 PM

#

I have never done client tests with the framework

slow prism Feb 22, 2024, 8:54 PM

#

time to learn!

#

just start a test client, open the GUI

#

enable the client category and shift

#

the overlay will give you instructions for each test

#

hmm the chat type thing is annoying

#

it's a client event so a custom chattype won't exactly work as it's a dp reg so it needs to be on the server

#

i'll have to pull out the chat type out of ClientChatReceivedEvent

#

oh ffs

#

it's that stupid pattern again with a base event and subclasses

#

but it fires the base event..

#

i can't say i have a lot of options

#

no vanilla chat type would be a good target for the system event

#

i have to pull it out

#

or make it nullable

#

which i guess makes sense since addMessage isn't always called with a chat type "nearby"

fallen igloo Feb 22, 2024, 9:21 PM

#

I can't even get into the world so fix that first maty

slow prism Feb 22, 2024, 9:23 PM

#

why would that be

fallen igloo Feb 22, 2024, 9:26 PM

#

I have no idea too many errors

slow prism Feb 22, 2024, 9:26 PM

#

did you pull latest?

#

i can get in a world just fine

slow prism Feb 22, 2024, 9:28 PM

#

slow prism the overlay will give you instructions for each test

ah right, no overlay

fallen igloo Feb 22, 2024, 9:29 PM

#

I pulled... maybe because the world has experiments enabled?

slow prism Feb 22, 2024, 9:29 PM

#

[23:27:53] [Render thread/FATAL] [ne.ne.ne.co.NeoForgeMod/]: Preparing crash report with UUID d0a96983-7654-4518-a19a-2a0b7755e349
---- Minecraft Crash Report ----
// You should try our sister game, Minceraft!

Time: 2024-02-22 23:27:53
Description: Unexpected error

java.lang.IllegalStateException: Unregistered holder in ResourceKey[minecraft:root / minecraft:mob_effect]: DeferredHolder{ResourceKey[minecraft:mob_effect / many_mob_effects_test:effect_254]}
    at net.minecraft.Util.getOrThrow(Util.java:874) ~[main/:?] {re:classloading}

#

figured out why this crashes

#

#

notice the DeferredHolder part

#

remember that getInner or whatever method during the registries PR that was removed

#

now it would be nice to have

#

hmm

#

maybe a Holder#getDelegate method makes sense thinkies

#

as in one that would return the "delegate"

slow prism Feb 22, 2024, 9:36 PM

#

fallen igloo I have no idea too many errors

well what is one of them

true jacinth Feb 22, 2024, 10:10 PM

#

slow prism

Mojang's uses of Holder continues to astound and bewilder

#

in what fuckin world is this necessary for anything

stiff galleon Feb 22, 2024, 10:14 PM

#

well, in vanilla, if it's not a reference holder, it's a direct holder

#

direct holders usually come from inlined objects in dpregs

elder swallow Feb 22, 2024, 10:41 PM

#

slow prism <@298082405745426433> "simple rejects" 😛 <https://github.com/neoforged/Kits/com...

Oh fuck

#

I think I deleted the entire reject file even though I hadn't addressed all the hunks

#

Good thing we had a test for that...

slow prism Feb 22, 2024, 10:43 PM

#

too late, I'm framing it

lean anchor Feb 22, 2024, 10:46 PM

#

slow prism oh btw <@202247953321033729> you will definitely need to add skyAccess = true to...

Why? None of my tests care about that.

slow prism Feb 22, 2024, 10:47 PM

#

if it's false the test will be surrounded by barrier blocks

#

which sounds like it will mess with compact machine placement

lean anchor Feb 22, 2024, 10:49 PM

#

Nah

#

All my test areas can fit the max vanilla room size

elder swallow Feb 22, 2024, 10:59 PM

#

misty crow <@298082405745426433> I still can't say for certain why the 45 degree face flick...

The bug was previously due to the unstable direction method + matrix * inverse matrix

#

So if they remove the useless "identity" multiplication it should be good

#

I'd keep getNearestStable though

misty crow Feb 22, 2024, 11:00 PM

#

Sounds good 👍

elder swallow Feb 22, 2024, 11:12 PM

#

I'll check tomorrow

fallen igloo Feb 23, 2024, 8:16 AM

#

networking is still broken on latest 24w07a

[09:14:23] [Netty Server IO #1/ERROR] [minecraft/Connection]: Exception caught in connection
io.netty.handler.codec.EncoderException: Pipeline has no outbound protocol configured, can't process packet net.minecraft.network.protocol.common.ClientboundKeepAlivePacket@611a8815
    at net.minecraft.network.UnconfiguredPipelineHandler$Outbound.write(UnconfiguredPipelineHandler.java:79) ~[%23189!/:?] {re:classloading}
    at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.ChannelOutboundHandlerAdapter.write(ChannelOutboundHandlerAdapter.java:113) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at net.minecraft.network.Connection$2.write(Connection.java:488) ~[%23189!/:?] {re:classloading}
    at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:940) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:966) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:934) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:984) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1025) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:306) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at net.minecraft.network.Connection.doSendPacket(Connection.java:327) ~[%23189!/:?] {re:classloading}
    at net.minecraft.network.Connection.lambda$sendPacket$12(Connection.java:322) ~[%23189!/:?] {re:classloading}
    at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174) ~[netty-common-4.1.97.Final.jar%23130!/:4.1.97.Final] {}
    at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167) ~[netty-common-4.1.97.Final.jar%23130!/:4.1.97.Final] {}
    at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) ~[netty-common-4.1.97.Final.jar%23130!/:4.1.97.Final] {}
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569) ~[netty-transport-4.1.97.Final.jar%23127!/:4.1.97.Final] {}
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[netty-common-4.1.97.Final.jar%23130!/:4.1.97.Final] {}
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.97.Final.jar%23130!/:4.1.97.Final] {}
    at java.lang.Thread.run(Thread.java:833) ~[?:?] {}

elder swallow Feb 23, 2024, 8:27 AM

#

what did you connect to?

#

this normally happens when we send a packet right after a protocol switch (e.g. config -> play), before the channel is reconfigured

elder swallow Feb 23, 2024, 8:47 AM

#

hmmm looking more at it, this might be a vanilla bug?

#

if it just happens to send the keepalive packet while the connection is being reconfigured, problems happen

fallen igloo Feb 23, 2024, 9:01 AM

#

elder swallow what did you connect to?

singleplayer

elder swallow Feb 23, 2024, 9:04 AM

#

you were just randomly connecting and this happened?

fallen igloo Feb 23, 2024, 9:05 AM

#

I was entering a singleplayer world with the gametest client

#

(with bundle and 21 preview enabled)

elder swallow Feb 23, 2024, 9:07 AM

#

misty crow <@298082405745426433> I still can't say for certain why the 45 degree face flick...

the normal inversion is still there, however the normal matrix is an identity now, hence its inverse is constantly an identity... I have to check 1.20.1 to understand what happened; the 24w05a contains a bunch of normal-related changes, hard to tell which one is the fix

elder swallow Feb 23, 2024, 9:07 AM

#

fallen igloo I was entering a singleplayer world with the gametest client

do you know if it happens consistently?

fallen igloo Feb 23, 2024, 9:08 AM

#

I'll try again

elder swallow Feb 23, 2024, 9:08 AM

#

the normal is gone from the rendertype core shaders for some reason

fallen igloo Feb 23, 2024, 9:21 AM

#

elder swallow do you know if it happens consistently?

yes it is

elder swallow Feb 23, 2024, 9:22 AM

#

ok @misty crow Mojang's fix is that:

before 24w05a: the bottom-most pose's normal matrix in the PoseStack used for rendering contains the mouse rotation, then later on the rotation is inversed using the inverse normal matrix given to RenderSystem.setInverseViewRotationMatrix
after 24w05a: the mouse rotation does not appear in the normal matrix anymore

#

so it is a clean fix

#

and I will remove ours, but maybe keep getNearestStable

#

@magic sierra the campfire crumbling bug was fixed by mojang

#

XFact, can you explain your use of getNearestStable in FB again? it should only be relevant if you have very small changes in the parameters that you give to it

elder swallow Feb 23, 2024, 9:36 AM

#

fallen igloo yes it is

I can't reproduce. Which run is it? I tried both Neoforge: GameTestsClient and Tests: GameTestClient

fallen igloo Feb 23, 2024, 9:37 AM

#

Tests: GameTestClient

elder swallow Feb 23, 2024, 9:38 AM

#

ok that's what I am running

#

but I'm not getting any crash or disconnect

#

with bundles and 1.21

fallen igloo Feb 23, 2024, 9:40 AM

#

could be a race condition, for me starting mc is awfully slow atm

elder swallow Feb 23, 2024, 9:49 AM

#

OK, I think I see the bug

#

this is problematic I think

#

server receives ServerboundFinishConfigurationPacket on the netty thread and immediately disables its outbound protocol
netty thread calls handleConfigurationFinished, which enqueues itself for processing on the main thread
if unlucky: the main thread sends a ClientboundKeepAlivePacket
then the main executor would normally process handleConfigurationFinished and configure the protocol, but it's too late - the packet is already sent

#

I can't find it on mojira, ideally someone should report it

fallen igloo Feb 23, 2024, 10:13 AM

#

did you already report it?

elder swallow Feb 23, 2024, 10:13 AM

#

no

#

ideally we should reproduce it with a vanilla server but ehhh

fallen igloo Feb 23, 2024, 10:16 AM

#

we should because otherwise it will get closed as invalid

elder swallow Feb 23, 2024, 10:17 AM

#

the issue can be reproduced every single time with the following simple patch (causing the keepalive packet to be sent immediately between the reception and processing of ServerboundFinishConfigurationPacket)

fallen igloo Feb 23, 2024, 10:19 AM

#

can you report the issue (or write it together so I can)

#

or even better we just ping a problem causer

elder swallow Feb 23, 2024, 10:20 AM

#

yeah that would probably be better

fallen igloo Feb 23, 2024, 10:21 AM

#

who Fry, Gegy, someone else?

elder swallow Feb 23, 2024, 10:21 AM

#

I don't know who does the networking stuff

elder swallow Feb 23, 2024, 10:25 AM

#

elder swallow this is problematic I think

@azure sparrow hey (we think) we found an issue with the networking implementation in current snapshots, specifically with how terminal packets unconfigure the channel. See the message I am replying to.

We figured it might be best to report it directly, hope it's ok!

vast parrot Feb 23, 2024, 10:31 AM

#

fallen igloo we should because otherwise it will get closed as invalid

Well, no? It seems like it might cause disconnect in vanilla, unless you are specifically doing something weird with timing

#

The trick is to report it as "it happens in vanilla, here's a test mod to make it more probable", but some reports just start with "step 1. Run this mod"

elder swallow Feb 23, 2024, 10:34 AM

#

hmmm, I didn't know you accepted reports that start with "install fabric and add this mod to the server"

vast parrot Feb 23, 2024, 10:35 AM

#

We don't if it's necessary for the bug to occur. We accept them if mod makes it easier to discover (but it's still happens vanilla)

elder swallow Feb 23, 2024, 10:35 AM

#

ok, that's good to know!

vast parrot Feb 23, 2024, 10:37 AM

#

Basically:

it behaves weird if we change that value in this packet with mod (but it doesn't happen in vanilla) - probably reject
it crashes if we change that value in this packet - likely to be evaluated further, we don't like crashes
it's a race condition, here's a mod to make it more predictable - sure, it's still a race condition in vanilla

#

Also, I'm one to blame for networking

elder swallow Feb 23, 2024, 10:38 AM

#

ok, that's great 🙂

#

should I open a mojira ticket?

vast parrot Feb 23, 2024, 10:40 AM

#

Would be good for tracking

elder swallow Feb 23, 2024, 10:58 AM

#

https://bugs.mojang.com/browse/MC-268727

fallen igloo Feb 23, 2024, 10:59 AM

#

the attached mod got removed

elder swallow Feb 23, 2024, 11:01 AM

#

I added a github link to it

misty crow Feb 23, 2024, 12:05 PM

#

I'm glad that I'm not the one to blame for that one 😄

misty crow Feb 23, 2024, 12:14 PM

#

elder swallow XFact, can you explain your use of `getNearestStable` in FB again? it should onl...

I'm using it to recompute a BakedQuad's direction. To be honest, there most likely isn't any case where the changes would trigger an instability in the vanilla direction computation and in the worst case you'd only encounter an unnoticeable change in lighting after a resource reload or on different materials on an affected shape and not anything actually problematic like the flickering breaking texture

elder swallow Feb 23, 2024, 12:15 PM

#

ok, so safe to remove?

misty crow Feb 23, 2024, 12:15 PM

#

I would say yes

restive raft Feb 23, 2024, 3:12 PM

#

wasn't there an issue filed on our repo regarding the bug that getNearestStable fixed?

#

or am I remembering the Mojira bug

foggy steeple Feb 23, 2024, 3:14 PM

#

Did anyone check the ai movement patch thing that was supposed to stop spinning mobs

restive raft Feb 23, 2024, 3:15 PM

#

..what

#

wait, this sounds vaguely familiar

#

something about an int cast

dry stumpBOT Feb 23, 2024, 3:17 PM

#

ateranimavis

[Reference to](#neoforge-github message) #neoforge-github [➤ ](#neoforge-github message)https://github.com/MinecraftForge/MinecraftForge/pull/6455

slow prism Feb 23, 2024, 10:39 PM

#

I think we can release the test framework too with 1.20.5

fallen igloo Feb 23, 2024, 10:44 PM

#

can we already publish it in 1.20.4 so mods can setup the tests before the update to verify the behaviour

digital drum Feb 24, 2024, 6:39 PM

#

just letting everyone know this is in the works: https://gist.github.com/Spinoscythe/b3310190b15c0576059f2afcc49ca898

Gist

Minecraft 1.20.4 -> 1.20.5 Migration Primer

Minecraft 1.20.4 -> 1.20.5 Migration Primer. GitHub Gist: instantly share code, notes, and snippets.

restive raft Feb 24, 2024, 8:04 PM

#

digital drum just letting everyone know this is in the works: https://gist.github.com/Spinosc...

frail hatch Feb 24, 2024, 8:17 PM

#

what sort of easy/common™️ porting issues occur that potentially could use automated checks to try and find? (For example https://github.com/neoforged/NeoForge/pull/660, wondering if there is any other cases that is worth adding a spotless check for and that can be reasonably detected by just evaluating the contents/diff to see if something got applied wrong)

restive raft Feb 24, 2024, 8:19 PM

#

a fun thought would be comparing indentation between a patched-in line versus its immediately neighboring context, and erroring if the patched-in line has more indentation than both its neighbors

frail hatch Feb 24, 2024, 8:21 PM

#

theoretically could be similar to the trimTrailingWhitespacePatches apply check I made previously. Hmm might look into it. Though I am guessing we wouldn't want it to auto fix that one though as if it is a code block being added it could get hard to determine past the first line

#

though in general that might get annoying to check as in some ways if we are patching in more than one line in a row in a hunk, then we need to keep track of that as one piece for what we are comparing against

#

in some ways?

restive raft Feb 25, 2024, 8:32 AM

#

frail hatch though in general that might get annoying to check as in some ways if we are pat...

hmmmm. fair point

#

also, FYI, am regenning Snowman with fixed indentation (4 spaces)

digital drum Feb 25, 2024, 11:25 AM

#

qq: about CustomPacketPayload.createType(String), will we patch it to be an overload of CustomPacketPayload.createType(ResourceLocation)(which we will create)? this is for the 20.5 migration primer
EDIT: my bad, I was being stupid, they can just do new CustomPacketPayload.Id<>(ResourceLocation)

digital drum Feb 25, 2024, 11:43 AM

#

Is SimpleTier to be removed in 1.20.5?

restive raft Feb 25, 2024, 11:45 AM

#

what makes you say that?

summer furnace Feb 25, 2024, 11:47 AM

#

vanilla hasn't turned tiers into a data-driven feature

#

Tier is still an interface, and Tiers is still an enum, so we still want to give modders a way to define custom tiers without having to implement the interface explicitly every time

digital drum Feb 25, 2024, 11:50 AM

#

wait I'm blind

#

sorry I was mixing up tiers with armor materials

#

I was writing a primer for it

summer furnace Feb 25, 2024, 11:57 AM

#

heh, there's already no "SimpleArmorMaterial" so nothing to remove :P

elder swallow Feb 26, 2024, 3:43 PM

#

I really don't understand the implementation of bundle packets

#

ok now I do... the split happens in the middle of the netty pipeline so that the rest of the pipeline is applied to each packet separately

wooden tendon Feb 26, 2024, 4:55 PM

#

Yep

#

A bundle packet is just a special packet object

#

It is not actually send as the packet

elder swallow Feb 26, 2024, 9:46 PM

#

good news: packets go through the full netty pipeline in singleplayer too now

frail hatch Feb 26, 2024, 9:55 PM

#

So no more accidental leaking from one side to another?

wooden tendon Feb 26, 2024, 9:55 PM

#

nice!

elder swallow Feb 26, 2024, 9:55 PM

#

frail hatch So no more accidental leaking from one side to another?

that, and you get validation that your read/write code makes sense

frail hatch Feb 26, 2024, 9:55 PM

#

Yay

prisma locust Feb 26, 2024, 9:55 PM

#

isn't that a performance downgrade

elder swallow Feb 26, 2024, 9:56 PM

#

not a relevant one though

frail hatch Feb 26, 2024, 9:56 PM

#

Except maybe on ancient machines

prisma locust Feb 26, 2024, 9:56 PM

#

I just wonder why it wasn't always done like this

true jacinth Feb 26, 2024, 9:57 PM

#

Dunno, realistically the decision to make them not use the full pipeline was probably made in 1.3.0

frail hatch Feb 26, 2024, 9:57 PM

#

Or earlier

true jacinth Feb 26, 2024, 9:58 PM

#

Probably not earlier, since 1.3 was the concept of the integrated server

#

before singleplayer probably didn't have packet code at all

frail hatch Feb 26, 2024, 9:59 PM

#

Ah

elder swallow Feb 26, 2024, 10:14 PM

#

the packets only get compressed in multiplayer, not for memory connections

elder swallow Feb 26, 2024, 10:51 PM

#

fixing the generic packet splitter is quite the rabbit hole

misty crow Feb 26, 2024, 11:11 PM

#

Yup, that's why I haven't looked further into it yet 😛

elder swallow Feb 26, 2024, 11:15 PM

#

it's ok, I fixed it 😄

#

https://github.com/neoforged/Kits/commit/f5ff79f8d72f447328004048dcf18cce29eb2a70

#

highlights:

encoding and decoding uses the protocol stream codec from ProtocolInfo
access to the ProtocolInfo for encoding happens by looking in the pipeline for the PacketEncoder
access to the ProtocolInfo for decoding happens via the IPayloadContext which now exposes it
pipeline injections (packet splitter and vanilla filter) are now between the unbundler and the encoder (I think we have a bug in 1.20.4 that packet splitting doesn't work with bundle packets but 🤷, this is fixed in 1.20.5 anyway)
singleplayer connections do not have a compressor, so we must split the packets at 2 MB instead of 8 MB

misty crow Feb 26, 2024, 11:26 PM

#

Looks good 👍

elder swallow Feb 27, 2024, 7:43 AM

#

@slow prism how are the GUI layers going?

slow prism Feb 27, 2024, 9:01 AM

#

they're not

#

do it

elder swallow Feb 27, 2024, 9:11 AM

#

👍

summer furnace Feb 27, 2024, 9:19 AM

#

how are bundle packets sent "unbundled"? do they have a "bundle id" in the packet serialization?

#

just curious

elder swallow Feb 27, 2024, 9:19 AM

#

there is a bundle delimiter packet type

summer furnace Feb 27, 2024, 9:19 AM

#

since the point of the bundles is so the handlers on the receiving end run within the same tick, there must be a way to re-bundle them on the receiving end

#

ahh

elder swallow Feb 27, 2024, 9:19 AM

#

so they send delimiter, packet 1, packet 2, ..., packet N, delimiter

summer furnace Feb 27, 2024, 9:20 AM

#

fancy

elder swallow Feb 27, 2024, 9:20 AM

#

yeah

summer furnace Feb 27, 2024, 9:20 AM

#

I suppose it can rely on packets to be always in order

elder swallow Feb 27, 2024, 9:20 AM

#

yeah

#

you can check PacketBundleUnpacker and PacketBundlePacker for fun

elder swallow Feb 27, 2024, 12:13 PM

#

who fixed the system chat type? is it ok now?

#

~~it looks like uses a chat type that's not in a registry - idk if it's a good or bad idea~~ well I guess we don't have the choice if we want to support vanilla servers and neo clients anyway

#

I'll mark it as resolved then

#

Need to reevaluate finalize spawn because the CompoundTag was removed
@silent @slow prism I assume that this is resolved?

fallen igloo Feb 27, 2024, 12:19 PM

#

elder swallow > Need to reevaluate finalize spawn because the CompoundTag was removed @silent ...

silent only works at the beginning of the message

elder swallow Feb 27, 2024, 12:19 PM

#

I noticed 😛

#

Check where RegistryCodecs#fullCodec went
who wrote this and what is it about?

#

Need to redo slow falling attribute modifier
isn't this handled by the vanilla GRAVITY attribute?

slow prism Feb 27, 2024, 12:23 PM

#

elder swallow > Need to reevaluate finalize spawn because the CompoundTag was removed @silent ...

yes

true jacinth Feb 27, 2024, 5:46 PM

#

elder swallow > Need to redo slow falling attribute modifier isn't this handled by the vanilla...

Presumably it would be, so our patch should be removable

#

I haven't looked at the new vanilla code yet to confirm

#

I do know their step height patches are wrong in one place which will cause the "sneak off a cliff" issue

elder swallow Feb 27, 2024, 5:54 PM

#

true jacinth I haven't looked at the new vanilla code yet to confirm

It does reduce the vertical acceleration

elder swallow Feb 27, 2024, 5:54 PM

#

true jacinth I *do* know their step height patches are wrong in one place which will cause th...

Hmmm where

true jacinth Feb 27, 2024, 6:45 PM

#

elder swallow Hmmm where

Player#maybeBackOffFromEdge - vanilla updated maxUpStep() to refer to the attribute, but this method needs to refer to a flat value of 0.5 otherwise sneaking will cause you to back off cliffs up to your step height

#

Will probably need to file a vanilla bug report once the attribute goes live

frail hatch Feb 27, 2024, 7:46 PM

#

Could also file it marking it as affecting the snapshot?

#

Then we can maybe have them fix it by 1.20.5 release and not have to patch it for them

elder swallow Feb 27, 2024, 9:18 PM

#

Yeah you can file snapshot bugs

#

I filed one the other day

white frigate Feb 28, 2024, 7:55 AM

#

That's what snapshots are for right? Finding bugs

summer furnace Feb 28, 2024, 7:58 AM

#

yes but they are for mojang to find and fix bugs

#

our porting work compounds the vanilla bugs with our own and makes things more complicated

white frigate Feb 28, 2024, 8:01 AM

#

Yeah I misunderstood and thought this was about a bug in vanilla

summer furnace Feb 28, 2024, 8:19 AM

#

oh wait no you read right

magic sierra Feb 28, 2024, 8:27 AM

#

what is "data driven items"?

summer furnace Feb 28, 2024, 8:27 AM

#

context?

magic sierra Feb 28, 2024, 8:28 AM

#

this

white frigate Feb 28, 2024, 8:29 AM

#

Items generated from datapacks im guessing. So you can define a new item type and it appears as a completely new item registered in game, instead of using existing items with custom model data to retexture it with a resource pack

magic sierra Feb 28, 2024, 8:30 AM

#

OHH

clear bane Feb 28, 2024, 8:30 AM

#

mojang is moving to datapacks more and more
makes sense if they switched block registration and item registartion also to datapacks

magic sierra Feb 28, 2024, 8:31 AM

#

Is it good or bad for modloaders?

quiet condor Feb 28, 2024, 8:31 AM

#

I think that's pretty good

white frigate Feb 28, 2024, 8:31 AM

#

people will probably hate it no matter what because it's change :p

quiet condor Feb 28, 2024, 8:31 AM

#

white frigate people will probably hate it no matter what because it's change :p

yeah :(

restive raft Feb 28, 2024, 8:37 AM

#

magic sierra this

tweet link, please

#

also, is this a reply to Gegy's recent tweet

white frigate Feb 28, 2024, 8:38 AM

#

https://twitter.com/IAmRx97/status/1762497453167927542

rx (@IAmRx97) on X

@AcesDust @gegybeans @s my bet is item components available on items that might be groundwork for data driven items in the future (when we do get those, as evidence'd from code changes recently).

restive raft Feb 28, 2024, 8:43 AM

#

i knew it

magic sierra Feb 28, 2024, 8:45 AM

#

Imagine, Mojang adds interface/menu support to datapacks

clear bane Feb 28, 2024, 8:46 AM

#

magic sierra Is it good or bad for modloaders?

why would it be bad?
easy way to add block and items

then again, Mojang doesn't need to care about modloaders being supported with their features
but they do, in some ways

magic sierra Feb 28, 2024, 9:05 AM

#

True

#

But if this version has too many changes, it may break the modloaders.

royal stone Feb 28, 2024, 9:06 AM

#

Dataification makes modifying existing content harder. You can't mixin into a json file (yes there are other tools that do that).

white frigate Feb 28, 2024, 9:07 AM

#

where there is a will tehre is a way

royal stone Feb 28, 2024, 9:08 AM

#

Sure, but will the way be easy to use and compatible with others? Modloaders might have to include a json mixin system if everything turns to datapacks

fallen igloo Feb 28, 2024, 9:15 AM

#

royal stone Dataification makes modifying existing content harder. You can't mixin into a js...

that's why we have things like GLM and BM

elder swallow Feb 28, 2024, 9:15 AM

#

the Registry<Item> is probably going to turn into Registry<ItemType>

#

you'll still be able to mix into the item type 😛

fallen igloo Feb 28, 2024, 9:16 AM

#

turn into is wrong they probably start like with blocks by adding the type registry
Registry<MapCodec<? extends Block>> BLOCK_TYPE

clear bane Feb 28, 2024, 9:16 AM

#

magic sierra But if this version has too many changes, it may break the modloaders.

which is not something new

elder swallow Feb 28, 2024, 9:18 AM

#

in other news, I fixed the overlays

#

in the end this doesn't use LayeredDraw at all

#

I made a new class with a similar interface, so that everyone is forced to give a name to the layer

#

the patch in Gui looks like this - it's very nice and maintainable

#

and the old field is kept, just unused

royal stone Feb 28, 2024, 9:55 AM

#

I did some testing on decompiling java 21 classes (it looks like todays snapshot might be on java 21 due to launcher meta changes) and vineflower does not like the new features. Switches with patterns get decompiled to indy pseudocode and record patterns decompile really wacky with a missing type error. This might cause issues with your patching system if mojang uses these features.

📎 test.java 📎 Test2.java

elder swallow Feb 28, 2024, 9:55 AM

#

harold

wooden tendon Feb 28, 2024, 10:01 AM

#

Shit

#

That would put a wrench into crap

royal stone Feb 28, 2024, 10:02 AM

#

Mojang probably won't use these features a lot at first, so you might get away with manually figuring out how to fix the code for each case, but still not good.

quiet condor Feb 28, 2024, 10:08 AM

#

that would be funny if they suddenly moved to java 21

wooden tendon Feb 28, 2024, 10:10 AM

#

They did for J17

#

It is reasonable to assume that they would

#

I will drop in a message in the vineflower discord

quiet condor Feb 28, 2024, 10:11 AM

#

oh then y'all might be in for a treat porting neo to j21

wooden tendon Feb 28, 2024, 10:12 AM

#

Should be trivial

#

The decompile is the biggest problem

restive raft Feb 28, 2024, 10:24 AM

#

royal stone I did some testing on decompiling java 21 classes (it looks like todays snapsho...

what version of VineFlower did you use?

royal stone Feb 28, 2024, 10:28 AM

#

Latest github release

restive raft Feb 28, 2024, 10:43 AM

#

for the record, what version would that be?

royal stone Feb 28, 2024, 10:44 AM

#

restive raft for the record, what version would that be?

1.9.3

elder swallow Feb 28, 2024, 10:45 AM

#

released 5 months ago

fallen igloo Feb 28, 2024, 10:57 AM

#

might be good to ask problem causer if they know if that feature is used

elder swallow Feb 28, 2024, 11:15 AM

#

I don't think so

#

of course they're going to try to use them lol

#

it's our problem not theirs

mystic cloak Feb 28, 2024, 11:45 AM

#

royal stone I did some testing on decompiling java 21 classes (it looks like todays snapsho...

Mmmh we might need to work on releasing 1.10 then sometime

clear bane Feb 28, 2024, 3:16 PM

#

@restive raft SOUND THE ALARM!!
https://www.minecraft.net/en-us/article/minecraft-snapshot-24w09a

#

we are so fucking fucked

mystic cloak Feb 28, 2024, 3:16 PM

#

and and?

#

I don't see it mentioned?

clear bane Feb 28, 2024, 3:17 PM

#

it is the sheer size of it

magic sierra Feb 28, 2024, 3:17 PM

#

good luck X)

clear bane Feb 28, 2024, 3:18 PM

#

commands
tags
resource packs

#

many formatting changes

magic sierra Feb 28, 2024, 3:18 PM

#

WTF, the changelog is massive

clear bane Feb 28, 2024, 3:18 PM

#

@open kindle you do the alarm

spiral radish Feb 28, 2024, 3:19 PM

#

<@&1067092163520909374>
https://www.minecraft.net/en-us/article/minecraft-snapshot-24w09a
https://mdcfe.dev/mc-changes?ver=24w09a
https://github.com/neoforged/Snowman/commit/4a837180a3c91de75efc079878acd70b5f1b22f1

clear bane Feb 28, 2024, 3:20 PM

#

We understand that this is a significant breaking change for many datapacks and custom maps which will require significant effort to upgrade.

We do however believe that this builds critical foundations for future extensibility. We have taken care to ship these changes all at once, with the hope that this avoids future incremental changes requiring many small updates to packs.

The current NBT 'tag' has existed for quite some time, and we are aware that a lot of clever techniques have been developed with this for commands and data packs.

Although we have made our best effort to identify these cases, some of these techniques rely on undocumented or undefined behavior with certain tag configurations.

We want to ensure that no functionality is lost without a suitable alternative, but due to the undocumented nature of these techniques, we have very likely not caught everything!

We hope to address any regressions over the remaining course of this snapshot cycle.

With such a large change, we deeply value your feedback! You can share your thoughts on these changes over at the feedback site: Let's talk about Item Stack Components!.```

magic sierra Feb 28, 2024, 3:20 PM

#

WAIT

spiral radish Feb 28, 2024, 3:20 PM

#

Snowman The diff you're trying to view is too large. We only load the first 3000 changed files. harold

magic sierra Feb 28, 2024, 3:20 PM

#

#789950127774105602 message HAHAHA

clear bane Feb 28, 2024, 3:21 PM

#

how big is hte snowman, Ater?
since it is private harold

spiral radish Feb 28, 2024, 3:21 PM

#

Showing 3,354 changed files with 18,314 additions and 16,174 deletions.

clear bane Feb 28, 2024, 3:21 PM

#

hehe

#

yeah, was gonna happen one day or another harold

spiral radish Feb 28, 2024, 3:21 PM

#

I think it's mostly the json files

#

All the advancements look like they got updated

clear bane Feb 28, 2024, 3:22 PM

#

idk, I don't have powers to dev, other then websites on this macbook

slow prism Feb 28, 2024, 3:22 PM

#

Previous id (string) and Count (byte) fields have been replaced with id (namespaced string) and count (integer) fields

#

FUCKING FREAKING YES

#

FINALLY

summer furnace Feb 28, 2024, 3:23 PM

#

eep early snapshot today

spiral radish Feb 28, 2024, 3:24 PM

#

spiral radish I think it's mostly the json files

Yeah the jsons count for ~3/4 of the file changes

summer furnace Feb 28, 2024, 3:24 PM

#

game UI has been updated? concern

#

but the UI is like 50% of what makes minecraft feel like minecraft ...

magic sierra Feb 28, 2024, 3:25 PM

#

it's Java 17 or Java 21?

summer furnace Feb 28, 2024, 3:25 PM

#

OH

#

they just tweaked a few things

#

okay

#

no more dirt

slow prism Feb 28, 2024, 3:26 PM

#

magic sierra it's Java 17 or Java 21?

17

magic sierra Feb 28, 2024, 3:26 PM

#

yeap, it's better

summer furnace Feb 28, 2024, 3:26 PM

#

(except in programmer art)

elder swallow Feb 28, 2024, 3:26 PM

#

jesus christ what happened now

slow prism Feb 28, 2024, 3:26 PM

#

hi tech

#

we have item components

#

australian_tater

summer furnace Feb 28, 2024, 3:26 PM

#

they forgot to enable scissor / move the scrollbar heh

elder swallow Feb 28, 2024, 3:27 PM

#

wait

#

#

WHAT

summer furnace Feb 28, 2024, 3:27 PM

#

nice

frail hatch Feb 28, 2024, 3:27 PM

#

summer furnace they forgot to enable scissor / move the scrollbar heh

More likely scrolling text

summer furnace Feb 28, 2024, 3:27 PM

#

I have been complaining about items storing raw NBT for as long as I have known how itemstacks work

slow prism Feb 28, 2024, 3:27 PM

#

yes tech, attachments are now useless

#

australian_tater

frail hatch Feb 28, 2024, 3:27 PM

#

elder swallow

Native attachments?

slow prism Feb 28, 2024, 3:27 PM

#

(for items)

elder swallow Feb 28, 2024, 3:27 PM

#

yikes

open kindle Feb 28, 2024, 3:27 PM

#

I see this as a win

summer furnace Feb 28, 2024, 3:27 PM

#

it is a win

elder swallow Feb 28, 2024, 3:28 PM

#

good thing we already did most of the port to 24w07a

#

(or is it)

summer furnace Feb 28, 2024, 3:28 PM

#

it just means the timing of neo attachments is turning out to be a bit unfortunate

slow prism Feb 28, 2024, 3:28 PM

#

https://github.com/neoforged/Snowman/tree/dev/src/main/java/net/minecraft/core/component

open kindle Feb 28, 2024, 3:28 PM

#

elder swallow (or is it)

I read that in Vsauce's voice kek

slow prism Feb 28, 2024, 3:29 PM

#

it is official, our attachments are useless

#

australian_tater

white frigate Feb 28, 2024, 3:29 PM

#

summer furnace no more dirt

this is gonna break my mod lol.

summer furnace Feb 28, 2024, 3:29 PM

#

actually attachments are probably still needed, since those components are given by the item

slow prism Feb 28, 2024, 3:29 PM

#

they have syncing too with stream codecs

summer furnace Feb 28, 2024, 3:29 PM

#

so we'll need a way to define additional components that are not part of the item's "spec"

foggy steeple Feb 28, 2024, 3:29 PM

#

Minecraft 2.0

summer furnace Feb 28, 2024, 3:30 PM

#

unless I misunderstand

#

I haven't seen the code :P

open kindle Feb 28, 2024, 3:30 PM

#

So its time to rework attachments (again)?

elder swallow Feb 28, 2024, 3:30 PM

#

lmao

#

budget attachments

clear bane Feb 28, 2024, 3:30 PM

#

this is harold

elder swallow Feb 28, 2024, 3:30 PM

#

I could see us moving attachments to that system entirely, but I'd have to check more code

slow prism Feb 28, 2024, 3:30 PM

#

elder swallow budget attachments

budget? it's more robust than ours smh

frail hatch Feb 28, 2024, 3:30 PM

#

Rip custom copiers and comparators?

slow prism Feb 28, 2024, 3:31 PM

#

summer furnace so we'll need a way to define additional components that are not part of the ite...

items can set a default value

#

but stacks can patch

summer furnace Feb 28, 2024, 3:31 PM

#

how much "item-specific" are they?

#

like

#

could we, in theory, use these DataComponentTypes in other objects

elder swallow Feb 28, 2024, 3:31 PM

#

frail hatch Rip custom copiers and comparators?

unless we patch them in, that is

summer furnace Feb 28, 2024, 3:31 PM

#

or are they specific to itemstack?

elder swallow Feb 28, 2024, 3:31 PM

#

summer furnace could we, in theory, use these DataComponentTypes in other objects

seems to be the case

summer furnace Feb 28, 2024, 3:31 PM

#

so one option for the future could be to yeet AttachmentType

#

specifically AttachmentType

#

not the rest

elder swallow Feb 28, 2024, 3:32 PM

#

kekw

foggy steeple Feb 28, 2024, 3:32 PM

#

Yeah itemstack empty is said to be gone in changelog

#

Now empty is represented by null itemstack

summer furnace Feb 28, 2024, 3:32 PM

#

wait what

frail hatch Feb 28, 2024, 3:32 PM

#

AsheUhoh

summer furnace Feb 28, 2024, 3:33 PM

#

we are back to making ItemStack nullable?!?!?!?!

foggy steeple Feb 28, 2024, 3:33 PM

#

Anywhere where you needed empty itemstack is supposed to not have an itemstack entry in the json

#

So just {}

elder swallow Feb 28, 2024, 3:33 PM

#

frail hatch Feb 28, 2024, 3:33 PM

#

But

summer furnace Feb 28, 2024, 3:33 PM

#

but what about in code?

#

just null?

frail hatch Feb 28, 2024, 3:33 PM

#

No code only json

foggy steeple Feb 28, 2024, 3:33 PM

#

I’m just going off what they said in changelog

summer furnace Feb 28, 2024, 3:33 PM

#

okay so empty itemstack still exists, just ... not air

#

it's a stack of nulls

elder swallow Feb 28, 2024, 3:34 PM

#

lol

#

seems oddly familiar

open kindle Feb 28, 2024, 3:34 PM

#

summer furnace Feb 28, 2024, 3:34 PM

#

mojang saw your attachment work

#

and went

elder swallow Feb 28, 2024, 3:34 PM

#

there is a chance 😛

summer furnace Feb 28, 2024, 3:34 PM

#

https://tenor.com/view/stewie-griffin-family-guy-i-want-it-want-i-love-it-gif-17068492

Tenor

foggy steeple Feb 28, 2024, 3:35 PM

#

summer furnace Feb 28, 2024, 3:35 PM

#

my question is, what does an empty inventory slot contain :P

#

in code

elder swallow Feb 28, 2024, 3:35 PM

#

ItemStack.EMPTY

#

that still exists

foggy steeple Feb 28, 2024, 3:35 PM

#

What is it

#

Like what values does empty have

elder swallow Feb 28, 2024, 3:36 PM

#

public static final ItemStack EMPTY = new ItemStack((Void)null);

#

same as 1.19.4+

open kindle Feb 28, 2024, 3:36 PM

#

What happens if a file on disk has item air or count 0

summer furnace Feb 28, 2024, 3:36 PM

#

I thought it was AIR until now?

elder swallow Feb 28, 2024, 3:36 PM

#

DFU?

#

kekw

open kindle Feb 28, 2024, 3:36 PM

#

Ah right

frail hatch Feb 28, 2024, 3:36 PM

#

summer furnace I thought it was AIR until now?

They changed it a bit ago

elder swallow Feb 28, 2024, 3:36 PM

#

summer furnace I thought it was AIR until now?

nah, ItemStack.EMPTY has been null void for some time

open kindle Feb 28, 2024, 3:36 PM

#

The fixer part of DFU

elder swallow Feb 28, 2024, 3:37 PM

#

ok so it's not possible to add components to existing stacks

summer furnace Feb 28, 2024, 3:37 PM

#

yeah datafixerutils

foggy steeple Feb 28, 2024, 3:37 PM

#

The breaker part of DFU

summer furnace Feb 28, 2024, 3:37 PM

#

which I thought was "datafixer utils"

#

but these days it's more like "data, fixer, utils" as 3 separate words

slow prism Feb 28, 2024, 3:37 PM

#

elder swallow ok so it's not possible to add components to existing stacks

hmmm ?

elder swallow Feb 28, 2024, 3:37 PM

#

it's DataFixerUpper

open kindle Feb 28, 2024, 3:37 PM

#

Isnt it datafixerupper?

summer furnace Feb 28, 2024, 3:37 PM

#

err

#

yes

#

brainfart

open kindle Feb 28, 2024, 3:37 PM

#

Yeah

summer furnace Feb 28, 2024, 3:38 PM

#

smh

#

time to rewrite reality so my joke makes sense

elder swallow Feb 28, 2024, 3:38 PM

#

slow prism <a:hmmm:1030417406834774068>?

as in, DataComponentPatch does not support adding components

summer furnace Feb 28, 2024, 3:38 PM

#

https://tenor.com/view/power-gif-26477241

Tenor

elder swallow Feb 28, 2024, 3:38 PM

#

does it support modifying them thinkies

summer furnace Feb 28, 2024, 3:38 PM

#

I guess you can set their contents to replace the defaults from the item

#

but not add components that are not part of the item spec

elder swallow Feb 28, 2024, 3:38 PM

#

why the fuck Reference2ObjectMap<DataComponentType<?>, Optional<?>> map

summer furnace Feb 28, 2024, 3:39 PM

#

thonk

elder swallow Feb 28, 2024, 3:39 PM

#

there is BuiltInRegistries.DATA_COMPONENT_TYPE

summer furnace Feb 28, 2024, 3:40 PM

#

wait does that store the values of the components?

elder swallow Feb 28, 2024, 3:40 PM

#

no no

slow prism Feb 28, 2024, 3:40 PM

#

elder swallow as in, `DataComponentPatch` does not support adding components

the stack uses PatchedDataComponentMap which has a set and remove method

elder swallow Feb 28, 2024, 3:40 PM

#

ahhh

#

I was in DataComponentPatch

#

#

this is really cool

slow prism Feb 28, 2024, 3:41 PM

#

we just need to narrow down the getter in itemstack from DataComponentMap to PatchedDataComponentMap

elder swallow Feb 28, 2024, 3:41 PM

#

there is now automated detection of the default components, avoids the classic "I filled and emptied my tank and now it doesn't stack anymore with newly crafted tanks"

summer furnace Feb 28, 2024, 3:41 PM

#

porting JsonThings will be interesting thinkies

foggy steeple Feb 28, 2024, 3:41 PM

#

Rip mods

summer furnace Feb 28, 2024, 3:41 PM

#

I'll have to figure out how to let people define components and specify which components go on a given item

slow prism Feb 28, 2024, 3:41 PM

#

oh wait no

#

we don't

#

there's direct set and get methods on the stack

#

yeah it's fine

#

elder swallow Feb 28, 2024, 3:42 PM

#

ok cool

#

custom comparator is not needed anymore btw, components need to implement equals

frail hatch Feb 28, 2024, 3:42 PM

#

So just need a copier

elder swallow Feb 28, 2024, 3:43 PM

#

ok this is cursed

#

it's so not thread safe

slow prism Feb 28, 2024, 3:43 PM

#

harold

#

mc is never thread safe

elder swallow Feb 28, 2024, 3:44 PM

#

hmmmmmm

#

#

the components get copied directly

frail hatch Feb 28, 2024, 3:44 PM

#

Oh no

slow prism Feb 28, 2024, 3:44 PM

#

something tells me we'll have entity and BE components by 1.20.5

elder swallow Feb 28, 2024, 3:44 PM

#

I hope that people like immutability ioa

slow prism Feb 28, 2024, 3:44 PM

#

which might make ours somewhat useless

elder swallow Feb 28, 2024, 3:45 PM

#

there's a pretty high chance that we remove ours entirely and patch more vanilla classes to support these new DataComponents

slow prism Feb 28, 2024, 3:45 PM

#

yeah

#

but we should wait until the pres for that

#

since they might do it themselves

elder swallow Feb 28, 2024, 3:45 PM

#

in any case, we need to get the 24w07a port fully finished quite soon

elder swallow Feb 28, 2024, 3:46 PM

#

slow prism but we should wait until the pres for that

I'd maybe give 1-2 weeks for the dust to settle then try to port to the new snapshot?

slow prism Feb 28, 2024, 3:46 PM

#

if we're removing ours, we should not release 1.20.5 with them and remove them later in any case

elder swallow Feb 28, 2024, 3:46 PM

#

yeah definitely agree

frail hatch Feb 28, 2024, 3:47 PM

#

elder swallow I hope that people like immutability <:ioa:877036729918435429>

This makes me sad for a lot of my use cases

slow prism Feb 28, 2024, 3:47 PM

#

fix: custom copier that defaults to an identity function?

elder swallow Feb 28, 2024, 3:47 PM

#

idk

#

it's really sad, they could have made stacks immutable

slow prism Feb 28, 2024, 3:48 PM

#

lol

elder swallow Feb 28, 2024, 3:48 PM

#

they are so close now that there is no direct NBT mutation anymore

frail hatch Feb 28, 2024, 3:48 PM

#

Tbh that might be end goal

frail hatch Feb 28, 2024, 3:49 PM

#

elder swallow custom comparator is not needed anymore btw, components need to implement equals

Does item stack implement equals yet xlurk

elder swallow Feb 28, 2024, 3:51 PM

#

no 😭

twin elk Feb 28, 2024, 3:51 PM

#

I've seen they've moved stuff out of the blockentitytag like container. Is this hardcoded or could we addour stuff to be synced to the BE?

elder swallow Feb 28, 2024, 3:51 PM

#

when are we getting ItemVariants ioa

quiet condor Feb 28, 2024, 3:51 PM

#

what's that?

fallen igloo Feb 28, 2024, 3:52 PM

#

elder swallow in any case, we need to get the 24w07a port fully finished quite soon

it is tho... it compiles and we generated patches so we can just bump to the next snapshot (maty do we have an action for that?)

elder swallow Feb 28, 2024, 3:53 PM

#

I would like to finish all the TODOs from the hackmd first

#

do we want to incorporate changes from 1.20.x too

#

I can poke FBB/RFBB and regsync

#

@rigid walrus @wooden tendon

wooden tendon Feb 28, 2024, 3:56 PM

#

Owf

#

Lucky

spiral radish Feb 28, 2024, 3:57 PM

#

~~next snapshot, "I lied"~~

slow prism Feb 28, 2024, 3:58 PM

#

sad

fallen igloo Feb 28, 2024, 3:59 PM

#

well that is a 80% confirmation that we will get j21 in the update after

#

tech what is the status of our race condition?

shut wraith Feb 28, 2024, 4:01 PM

#

Hey, structured components! Finally!

fallen igloo Feb 28, 2024, 4:01 PM

#

yea it's the mojang variant of itemstack attachments

elder swallow Feb 28, 2024, 4:01 PM

#

fallen igloo tech what is the status of our race condition?

https://bugs.mojang.com/browse/MC-268727

shut wraith Feb 28, 2024, 4:02 PM

#

How some of these components are described makes me think I'm beginning to see how datapackable items would work...

elder swallow Feb 28, 2024, 4:03 PM

#

I will look into switching over to mojang's attachment system entirely for 1.20.5

#

my take: these snapshots take a lot of work for everyone to update to, but the code changes are really nice to see

shut wraith Feb 28, 2024, 4:03 PM

#

That's been my take with their technical changes in general recently

elder swallow Feb 28, 2024, 4:03 PM

#

yeah

shut wraith Feb 28, 2024, 4:04 PM

#

Honestly, I'm liking the new release system. We seem to be getting a lot of much-needed technical changes with this

elder swallow Feb 28, 2024, 4:04 PM

#

we'll probably have to enforce some LTS versions

#

probably 1.X.0/1

shut wraith Feb 28, 2024, 4:05 PM

#

Eh, I don't know that much needs enforced - people are doing it on their own, gravitating to "the last version before experimental datapack features"

#

But regardless, really excited for 1.20.5. Between this component stuff and the new datapack registry syncing stuff... Lots of fun technical changes

elder swallow Feb 28, 2024, 4:06 PM

#

would be funny if all the favorite mods were developed on modern versions, but never combineable because they would all be in different versions kekw

#

"I'd love to use Mekanism, however it's only on 1.20.5 whereas AE2 only supports 1.20.4"

#

kekw

elder swallow Feb 28, 2024, 4:07 PM

#

shut wraith But regardless, really excited for 1.20.5. Between this component stuff and the ...

you're forgetting about stream codecs

foggy steeple Feb 28, 2024, 4:07 PM

#

People are likely going to stay on 1.20.1

#

But not go to 1.20.4. Since packs are mostly sticking to 1.20.1

elder swallow Feb 28, 2024, 4:07 PM

#

I'm anticipating the time when 1.21 comes around

misty crow Feb 28, 2024, 4:10 PM

#

We are up to 6-component composite streamcodecs now 😄

shut wraith Feb 28, 2024, 4:10 PM

#

elder swallow you're forgetting about stream codecs

Oh yeah. Lots of exciting stuff

summer furnace Feb 28, 2024, 4:12 PM

#

from now on mc java version will follow mc version, 1.22 will use java 22, and so on. even if java releases twice a year but mc only once

quiet condor Feb 28, 2024, 4:15 PM

#

did gegy say that?

#

or are you just saying that

summer furnace Feb 28, 2024, 4:16 PM

#

that was a joke

quiet condor Feb 28, 2024, 4:17 PM

#

oh that makes sense

kind sable Feb 28, 2024, 4:21 PM

#

Seee I told y'all that we would get the huge and obvious update in the next snapshot

lean anchor Feb 28, 2024, 4:21 PM

#

The absolute chaos this is gonna cause with datapack mods and stuff like AE.. oooooof

#

Also, long live ItemStack.EMPTY

elder swallow Feb 28, 2024, 4:24 PM

#

lean anchor The absolute chaos this is gonna cause with datapack mods and stuff like AE.. oo...

AE2 is not going to be significantly affected (as in: not more than other mods)

#

long live AEItemKey

kind sable Feb 28, 2024, 4:36 PM

#

But hey my mod is gonna be easier to make ..... When I will have time to make it

misty crow Feb 28, 2024, 4:50 PM

#

Item attribute modifiers are part of the item properties now

median wasp Feb 28, 2024, 5:50 PM

#

Wow this looks so much like attachments

shut wraith Feb 28, 2024, 5:53 PM

#

Yeah they're very similar in some ways

lean anchor Feb 28, 2024, 5:55 PM

#

1.21: Flattening 2 Item Boogaloo

restive raft Feb 28, 2024, 5:56 PM

#

what's more extreme than flattening

lean anchor Feb 28, 2024, 5:56 PM

#

TWO flattenings!

reef parcel Feb 28, 2024, 6:10 PM

#

It looks great so far

#

Very positive change

white frigate Feb 28, 2024, 6:11 PM

#

summer furnace from now on mc java version will follow mc version, 1.22 will use java 22, and s...

Minecraft making a new java version so they can release a new version

fallen igloo Feb 28, 2024, 6:23 PM

#

hmm maximum number of slots in an item is 255

#

sorry not sorry for the flashbang

clear bane Feb 28, 2024, 6:24 PM

#

makes me wonder
bigger stack size when? harold

red beacon Feb 28, 2024, 6:24 PM

#

that is just for the default Minecraft ones though, right? there's no need for a modded item to use the vanilla component?

fallen igloo Feb 28, 2024, 6:24 PM

#

hmmm the post does not mention potions at all... are they still in the unstructured nbt?

clear bane Feb 28, 2024, 6:25 PM

#

I think I did see something about potions

reef parcel Feb 28, 2024, 6:25 PM

#

Yeah, like potion items? There was some stuff abt it

misty crow Feb 28, 2024, 6:25 PM

#

fallen igloo hmmm the post does not mention potions at all... are they still in the unstructu...

Nope, those also have a component

fallen igloo Feb 28, 2024, 6:25 PM

#

clear bane I think I did see something about potions

ah yes I'm blind

clear bane Feb 28, 2024, 6:25 PM

#

potion is said at least 30 times 🙃

fallen igloo Feb 28, 2024, 6:26 PM

#

lean anchor Feb 28, 2024, 6:33 PM

#

But are water bottles still potions?

foggy steeple Feb 28, 2024, 6:37 PM

#

But who is phone?

blazing valve Feb 28, 2024, 6:43 PM

#

elder swallow I hope that people like immutability <:ioa:877036729918435429>

AE2 sure will 😄

twin elk Feb 28, 2024, 7:02 PM

#

Can someone with the decompiled snapshot check how copying components into the BE works? It used to just check the blockentitytag, but since some stuff like Lock where made their own components, I hope it's no longer hardcoded.

digital drum Feb 28, 2024, 7:11 PM

#

twin elk Can someone with the decompiled snapshot check how copying components into the B...

can I post screenshots?

twin elk Feb 28, 2024, 7:12 PM

#

I mean, sure. Is it hardcoded or a property you can enable?

digital drum Feb 28, 2024, 7:13 PM

#

just making sure by components, you mean the DataComponentMap stuff right?

blazing valve Feb 28, 2024, 7:14 PM

#

BlockItem applies this on placement:

    private static void updateBlockEntityComponents(Level level, BlockPos blockpos, ItemStack itemstack) {
        BlockEntity blockentity = level.getBlockEntity(blockpos);
        if (blockentity != null) {
            blockentity.applyComponents(itemstack.getComponents());
        }
    }

digital drum Feb 28, 2024, 7:14 PM

#

public void saveToItem(ItemStack itemStack, HolderLookup.Provider provider) {
  CompoundTag compoundTag = this.saveWithoutMetadata(provider);
  this.removeComponentsFromTag(compoundTag);
  BlockItem.setBlockEntityData(itemStack, this.getType(), compoundTag);
  itemStack.applyComponents(this.collectComponents());
}

blazing valve Feb 28, 2024, 7:15 PM

#

The block_entity_data component is handled separately (seems to just copy itself into the BE NBT)

#

So, BlockEntity#applyComponents & BlockEntity#collectComponents. Very nice

digital drum Feb 28, 2024, 7:16 PM

#

blazing valve Feb 28, 2024, 7:16 PM

#

Would be nice if they named the methods such that they indicate their relationship to items 😄

digital drum Feb 28, 2024, 7:16 PM

#

wait why is removeComponentsFromTag already deprecated?

azure sparrow Feb 28, 2024, 7:17 PM

#

they don't need to specifically be items, you could apply components from another block entity 😛

blazing valve Feb 28, 2024, 7:17 PM

#

Okay, point taken 😄

dry stumpBOT Feb 28, 2024, 7:19 PM

#

digital drum ```java public void saveToItem(ItemStack itemStack, HolderLookup.Provider provid...

Created Gist at the request of @true socket: https://gist.github.com/NeoCamelot/3180c272334cd6b1f3a1d0e7d4bbde9e

true socket Feb 28, 2024, 7:20 PM

#

I may be stupid

#

I did not intend to do that

digital drum Feb 28, 2024, 7:20 PM

#

true socket I may be stupid

its fine

true socket Feb 28, 2024, 7:21 PM

#

digital drum its fine

yeah, I've just been checking here whenever it's snapshot day

#

at this point big changes have arrived often enough that it does become rather important

#

if not just to see Neo's take on things

reef parcel Feb 28, 2024, 7:24 PM

#

@ someone with the ability to, is it possible for me to have the snapshot alarm role, please?

#

i used to use quilt's discord for snapshot updates (darkmode changelog site) but their bot "cozy" has been very moody the past few months and doesn't want to work most of the time

boreal flint Feb 28, 2024, 7:53 PM

#

with item nbt being changed as it was

#

what'd they do with enchantments

#

have they finally fixed the performance sink that is enchantment nbt?

shut wraith Feb 28, 2024, 7:54 PM

#

Yes

#

Everything that vanilla uses is components now from what I can tell

#

Meaning that you don't have to go through nbt to get at it every time you need it

#

Which, as i said... I'm super excited for 1.20.5. So many cool technical changes have been going through recently

boreal flint Feb 28, 2024, 8:02 PM

#

yeah agreed

#

1.18+ has just been a landslide of technical changes

#

it's been nice

#

though I'm sad about java21

#

cmon gegy

#

damn even attributemodifiers is a component now

#

this is gonna get nasty for porting

true socket Feb 28, 2024, 8:04 PM

#

not 1.20.5 doesn't mean not the first 1.21 snapshot

clear bane Feb 28, 2024, 8:04 PM

#

no

true socket Feb 28, 2024, 8:05 PM

#

I mean, with regards to Java version, that was all that gegy said

#

unless I misread it

twin elk Feb 28, 2024, 8:05 PM

#

blazing valve So, BlockEntity#applyComponents & BlockEntity#collectComponents. Very nice

Oh great, we can now do item to block transistions easily

true socket Feb 28, 2024, 8:06 PM

#

so there's a non-zero chance it is first 1.21 snapshot, not that I'm counting on it

clear bane Feb 28, 2024, 8:06 PM

#

1.20.5 is not part of 1.21

#

1.20.5 is part of the 1.20.x versions

true socket Feb 28, 2024, 8:07 PM

#

clear bane 1.20.5 is not part of 1.21

yes, I was talking about when they update to Java 21

clear bane Feb 28, 2024, 8:07 PM

#

that won't be in 1.20.5

true socket Feb 28, 2024, 8:07 PM

#

that is what I said

#

I said just because it's not going to be done in 1.20.5 doesn't mean they don't do it on the first 1.21 snapshot

quiet condor Feb 28, 2024, 8:16 PM

#

that's probably exactly what they will do

#

java 21 in 1.21

rigid walrus Feb 28, 2024, 8:16 PM

#

Now to fix 25 compile errors

median wasp Feb 28, 2024, 8:17 PM

#

I don't think MC will ever be on J21

#

I think they're waiting for Panama in J22

quiet condor Feb 28, 2024, 8:19 PM

#

what's Panama?

stiff galleon Feb 28, 2024, 8:19 PM

#

new api for java to interface with non-java code

fallen igloo Feb 28, 2024, 8:20 PM

#

median wasp I don't think MC will ever be on J21

they already added J21 to the version metadata for later use

stiff galleon Feb 28, 2024, 8:20 PM

#

for minecraft it might be relevant for opengl

boreal flint Feb 28, 2024, 8:21 PM

#

I just want it for the switches mostly lol

boreal flint Feb 28, 2024, 8:21 PM

#

median wasp I don't think MC will ever be on J21

they could do j21 and then do 22 at some point, surely

#

or is the licensing prohibitive

quiet condor Feb 28, 2024, 8:43 PM

#

stiff galleon new api for java to interface with non-java code

oh cool

#

so they can like use javascript?

stiff galleon Feb 28, 2024, 8:44 PM

#

C/C++

dry stumpBOT Feb 28, 2024, 8:44 PM

#

C/C == 1

stiff galleon Feb 28, 2024, 8:44 PM

#

thanks camelot

quiet condor Feb 28, 2024, 8:45 PM

#

stiff galleon C/C++

oh thats cool too

#

thanksCamelot++

dry stumpBOT Feb 28, 2024, 8:46 PM

#

thanksCamelot == 1

quiet condor Feb 28, 2024, 8:46 PM

#

nice

#

thanksCamelot--

dry stumpBOT Feb 28, 2024, 8:46 PM

#

thanksCamelot == 0

quiet condor Feb 28, 2024, 8:49 PM

#

stiff galleon C/C++

wait, could that open some links to Bedrock, since that's on C++?

stiff galleon Feb 28, 2024, 8:50 PM

#

probably not

#

generally it's better to rewrite the code in java

#

but there are a few places where you kinda have to use native code (C and friends), and one of them is rendering

blazing valve Feb 28, 2024, 8:51 PM

#

lwjgl can interface with system OpenGL libraries without having to ship custom built JNI DLLs

#

*could

#

applies to a lot of other system-level interactions

#

you can now make use of any system-level API from java without having to step down to custom JNI code, and without using a massive dependency on JNA

rigid walrus Feb 28, 2024, 8:57 PM

#

https://github.com/neoforged/NeoForm/commit/245793c290aface1cbd798d27700848d36195fa0

GitHub

Update patches and asset index · neoforged/NeoForm@245793c

reef parcel Feb 28, 2024, 9:33 PM

#

oh, you know, components probably help with people who want to make an item have a default enchantment huh?

digital drum Feb 28, 2024, 9:38 PM

#

is there a way that I can port my fork of neo to 24w09a?

summer furnace Feb 28, 2024, 9:39 PM

#

theoretically, sure, realistically... you'd be encountering all the same issues the team is encountering now

digital drum Feb 28, 2024, 9:40 PM

#

summer furnace theoretically, sure, realistically... you'd be encountering all the same issues ...

starting off with:

summer furnace Feb 28, 2024, 9:41 PM

#

that's not "an issue", that's just how it works, the patches never apply out of the box

#

that's usually the big part of the porting process

digital drum Feb 28, 2024, 9:42 PM

#

so what do the maintainers do?

summer furnace Feb 28, 2024, 9:42 PM

#

there's a process, some flags you have to use, I don't know them from memoty (I'm not part of the porting team)

digital drum Feb 28, 2024, 9:43 PM

#

ive seen technici4n viewing the diffs of snapshots, and adding them back

fallen igloo Feb 28, 2024, 9:46 PM

#

the snapshot diffs are just snowman (the snowblower output repo)

#

I'd advise not to do your own porting because there are a few patches that won't apply correctly a lot that get rejected so you have to apply them yourself... if you only need the mc source without neo use snowblower or the base project in neo

rigid walrus Feb 29, 2024, 12:06 AM

#

the StreamCodec for CustomData exists but is marked as deprecated

glossy lichen Feb 29, 2024, 12:10 AM

#

Oh is this codec based

#

My life is over

#

Oh how I miss GsonHelper

rigid walrus Feb 29, 2024, 12:13 AM

#

All item components use codecs with CUSTOM_DATA, ENTITY_DATA, BUCKET_ENTITY_DATA, and BLOCK_ENTITY_DATA using the CustomData codec

#

also the components are registered in net.minecraft.core.component.DataComponents with the individual classes existing in the packagenet.minecraft.world.item.component

foggy steeple Feb 29, 2024, 12:27 AM

#

When doing codec to and from json, what does it use? Gson? Would it be easy to change that to Jackson or so?

glossy lichen Feb 29, 2024, 12:36 AM

#

I assume we have to change everything to a RecordCodecBuilder

true jacinth Feb 29, 2024, 12:50 AM

#

foggy steeple When doing codec to and from json, what does it use? Gson? Would it be easy to c...

Gson, and no, not without making a custom JsonOps that has a different backend and replacing uses globally

shut wraith Feb 29, 2024, 2:13 AM

#

Obviously you can use the codecs with Jackson just fine. But replacing all the vanilla stuff to use Jackson instead of gson - no

errant lion Feb 29, 2024, 5:33 AM

#

median wasp I don't think MC will ever be on J21

Usually the update to the latest Java Version with a LTS, and J21 is that next latest LTS

#

So either 1.21 or 1.22 guaranteed

fallen igloo Feb 29, 2024, 6:36 AM

#

glossy lichen I assume we have to change everything to a RecordCodecBuilder

well codecs are better than writing serializers and deserializers for everything

summer furnace Feb 29, 2024, 6:44 AM

#

true jacinth Gson, and no, not without making a custom JsonOps that has a different backend a...

you could patch JsonOps.INSTANCE in principle, no?

true jacinth Feb 29, 2024, 6:48 AM

#

summer furnace you could patch JsonOps.INSTANCE in principle, no?

No

#

it, and all callers, are strongly typed to gson's JsonElement and related classes

summer furnace Feb 29, 2024, 6:54 AM

#

oh right facepalm

#

that's what I get for talking right after waking up

edgy arrow Feb 29, 2024, 9:42 AM

#

errant lion So either 1.21 or 1.22 guaranteed

Why not 1.20.6? Lol

rigid walrus Feb 29, 2024, 9:43 AM

#

elder swallow > Check where RegistryCodecs#fullCodec went who wrote this and what is it about?

I have already done that RegistryCodecs.fullCodec was only used in WorldDimensions and basically got inlined

clear bane Feb 29, 2024, 9:44 AM

#

edgy arrow Why not 1.20.6? Lol

because there is no time for that
it is pretty well known that 1.21 will be around June this year

#

unless a critical security bug comes around

fallen igloo Feb 29, 2024, 9:44 AM

#

yea the snapshot cycle after 20.5 will be 21 (if they don't need a hotfix)

edgy arrow Feb 29, 2024, 9:45 AM

#

Ah ok

clear bane Feb 29, 2024, 9:45 AM

#

they want 2 major versions a year...
no wait.. they changed that too harold

plucky brook Feb 29, 2024, 10:27 AM

#

glossy lichen Oh is this codec based

StreamCodec != DFU codec

naive hound Feb 29, 2024, 4:18 PM

#

clear bane they want 2 major versions a year... no wait.. they changed that too <:harold:93...

Maybe when they get to the same version as the calendar year they'll stick to one per year to match the pattern. /j

lean anchor Feb 29, 2024, 4:19 PM

#

Can't wait for MC 2025.1

#

https://tenor.com/view/tmnt-cowabunga-it-is-michaelangelo-teenage-mutant-ninja-turtles-gif-15971163

Tenor

naive hound Feb 29, 2024, 4:20 PM

#

If i did it right in my head, the first version to match the calendar year on a 6mo release cycle would be 1.27

#

Summer 24 = 21
Winter 24 = 22
summer 25 = 23
Winter 25 = 24
Summer 26 = 25
Winter 26 = 26
Summer 27 = 27
Winter 27 = wait for January and release 28

lean anchor Feb 29, 2024, 4:26 PM

#

Honestly, I'd be very very happy if Mojang went quarterly

Jan = 25
Mar = 25.1
Jun = 25.2
Sep = 25.3
Dec = 26-rc
Jan = 26

fallen igloo Feb 29, 2024, 4:28 PM

#

that's one too many for quarterly

lean anchor Feb 29, 2024, 4:29 PM

#

Delete December, then

#

Holidays are cancelled

elder swallow Feb 29, 2024, 4:55 PM

#

@true jacinth confirmed the step height bug with a vanilla client and reported it: https://bugs.mojang.com/browse/MC-268917

true jacinth Feb 29, 2024, 5:00 PM

#

thank

elder swallow Feb 29, 2024, 5:03 PM

#

now go vote for the issue else we'll have to fix it in 1.20.5 stabolb

stray bay Feb 29, 2024, 5:12 PM

#

do they fall, or are they teleported to the block below?

elder swallow Feb 29, 2024, 5:12 PM

#

fall

stray bay Feb 29, 2024, 5:12 PM

#

if they fall it's definitely a bug, but if not then arguably they're simply stepping down, just like how sneaking doesn't stop you from walking down stairs or slabs

elder swallow Feb 29, 2024, 5:13 PM

#

it would be super annoying if it also introduced a step down, IMO

#

we'd then have to introduce a counter-attribute harold

stiff galleon Feb 29, 2024, 5:13 PM

#

Another severe issue that occurs when using Thallium is that the player is violently thrown into the ground when stepping off blocks.

restive raft Feb 29, 2024, 5:13 PM

#

isn't stepping down a slab also a fall, but too small to usually register to the player as a fall

stray bay Feb 29, 2024, 5:13 PM

#

[i remember one mod on 1.16 that, i don't remember how it worked, but you could get a step up bonus of up to 3 blocks and you could step down - i don't know what effect sneaking had, but regular walking was definitely a step down and not just falling]

restive raft Feb 29, 2024, 5:15 PM

#

my memory of watching 3rd person perspective of players sneaking tells me that they fall, albeit usually unnoticeable, when stepping down a slab

stray bay Feb 29, 2024, 5:15 PM

#

what happens if you're using one of those super tall staircases that's made of blocks with different voxel shapes

fallen igloo Feb 29, 2024, 5:22 PM

#

tech can we do 09a today or do you need more time?

elder swallow Feb 29, 2024, 5:24 PM

#

I'd prefer waiting for tomorrow 🙂

magic sierra Feb 29, 2024, 5:25 PM

#

restive raft Feb 29, 2024, 5:26 PM

#

hey, that's what I said-ish

elder swallow Feb 29, 2024, 5:29 PM

#

as a player, I think it would be a bad thing

frail hatch Feb 29, 2024, 5:29 PM

#

Can you sneak on the edge of a bottom slab and not fall if it is on a cliff/above void?

prisma locust Feb 29, 2024, 5:29 PM

#

believe so

frail hatch Feb 29, 2024, 5:30 PM

#

If it doesn’t make you fall then I think there is still a bug that it isn’t checking if there is something you would be landing on

#

In regards to step height

elder swallow Feb 29, 2024, 5:30 PM

#

it does check if there is something to land on

restive raft Feb 29, 2024, 5:31 PM

#

i'm not sure I follow

shut wraith Feb 29, 2024, 5:31 PM

#

Yeah if it checks that there's something to land on the sneak-up and step-down heights should be the same

#

That makes sense

fallen igloo Feb 29, 2024, 5:31 PM

#

it technically is not falling off but walking/stepping off

elder swallow Feb 29, 2024, 5:33 PM

#

it is a fall

#

you even take fall damage if the step height is large enough

elder swallow Feb 29, 2024, 5:34 PM

#

shut wraith Yeah if it checks that there's something to land on the sneak-up and step-down h...

I don't think it makes sense - it is really annoying from a gameplay perspective

fallen igloo Feb 29, 2024, 5:34 PM

#

elder swallow you even take fall damage if the step height is large enough

well that is the actual bug then

shut wraith Feb 29, 2024, 5:34 PM

#

Sure. But as a player I'd expect to be able to walk up and down the same stairs while sneaking

elder swallow Feb 29, 2024, 5:34 PM

#

yes it might make sense in code and symmetry and whatever

shut wraith Feb 29, 2024, 5:34 PM

#

The only other solution in my mind would be to make it impossible to go up any steps while sneaking

stray bay Feb 29, 2024, 5:34 PM

#

I mean, if they're going to justify it based on 'stepping down' they need to make it actually step down

shut wraith Feb 29, 2024, 5:34 PM

#

And that seems even more annoying

restive raft Feb 29, 2024, 5:34 PM

#

what if we have a step up and a step down attribute

elder swallow Feb 29, 2024, 5:34 PM

#

remember that you go down even if you are sneaking

#

which makes 0 sense

stray bay Feb 29, 2024, 5:35 PM

#

to the point where you should be able to sprint down stairs of your step-up height without taking fall damage

elder swallow Feb 29, 2024, 5:35 PM

#

the funny thing is that forge had this exact same bug

shut wraith Feb 29, 2024, 5:35 PM

#

elder swallow remember that you go down **even if you are sneaking**

That makes perfect sense if it's treated as a step down instead of a fall. So that's the actual bug here.

If I build a staircase and I can sneak up it, I should be able to sneak down it

stray bay Feb 29, 2024, 5:35 PM

#

yeah but if it's gonna be a step down it needs to be an actual step down

shut wraith Feb 29, 2024, 5:35 PM

#

If I can't sneak down it, the game should prevent me from sneaking up it

elder swallow Feb 29, 2024, 5:35 PM

#

the moment you can sneak down full blocks, it stops making sense

fallen igloo Feb 29, 2024, 5:35 PM

#

elder swallow which makes 0 sense

it does, since you also do it on stairs

stray bay Feb 29, 2024, 5:36 PM

#

which means no fall damage at any speed

shut wraith Feb 29, 2024, 5:36 PM

#

elder swallow the moment you can sneak down full blocks, it stops making sense

If I can step up full blocks, I should be able to sneak down them

elder swallow Feb 29, 2024, 5:36 PM

#

I disagree as a player

#

I don't expect that putting on the mekanism boot thingy will suddenly fuck with my sneaking behavior

prisma locust Feb 29, 2024, 5:36 PM

#

it is debatable

#

question: can we make it a separate attribute thinkies

shut wraith Feb 29, 2024, 5:36 PM

#

elder swallow I disagree as a player

I'd say that what you're saying about not being able to go down any blocks makes some sense... But only if you disallow going up while sneaking.

You don't want one-way paths while sneaking

stray bay Feb 29, 2024, 5:37 PM

#

so is any of this actually new? there wasn't an attribute before but step height was a field on entities before iirc [and in vanilla horses have a higher step height]

elder swallow Feb 29, 2024, 5:37 PM

#

forge fixed it by ignoring its attribute when computing the "step down" distance

shut wraith Feb 29, 2024, 5:37 PM

#

stray bay so is any of this actually new? there wasn't an attribute before but step height...

Entities besides players don't sneak I don't believe

stray bay Feb 29, 2024, 5:38 PM

#

the compromise solution would be to make max step down height a client config [in input settings same as auto jump]

stray bay Feb 29, 2024, 5:38 PM

#

shut wraith Entities besides players don't sneak I don't believe

well yes, but players can ride horses, and regardless of vanilla not supporting it, mods could and did set it on players

#

like my question is, is this new behavior separate from it being implemented as an attribute, or did the old step height variable already have this behavior

reef parcel Feb 29, 2024, 5:40 PM

#

don't think its a great idea to make that client-authoritative, but ¯_(ツ)_/¯

stray bay Feb 29, 2024, 5:41 PM

#

i don't see why not

#

though

#

fall damage isn't really the only concern

#

what if you step down into lava

#

[which, yeah, you can do now with a slab next to lava but it's at least more obvious that you're in a situation where that can happen]

restive raft Feb 29, 2024, 5:42 PM

#

what if we make a separate step down attribute

#

more compromise 🌈

shut wraith Feb 29, 2024, 5:53 PM

#

Eh, if you were to do that I'd make it a "sneak step" attribute, and have it apply going both directions when sneaking. Because fundamentally, being able to sneak up a slope you can't sneak down is confusing.

...but vanilla would have to do that because there's not really many ways neo can do it without breaking some datapacks I'd think, so we'll see what they do

elder swallow Feb 29, 2024, 6:06 PM

#

Actually @fallen igloo if you have free time just go for it tonight!

#

Can I ask you to first squash the current work and rebase on top of the latest 1.20.4 changes before going for the new snapshot?

fallen igloo Feb 29, 2024, 6:07 PM

#

@slow prism do we have a workflow to bump a snapshot branch on Kits to the next snapshot?

elder swallow Feb 29, 2024, 6:07 PM

#

You'll probably have to follow the workflow's steps manually

#

The squashing and stuff can't be automated in any case

#

(the squash would be nice because I'd like to have the latest attachment changes in before I try to replace the system by data components entirely)

fallen igloo Feb 29, 2024, 6:10 PM

#

I don't really like squashing while still in the snapshots, the squash should only happen right before we push to prod

elder swallow Feb 29, 2024, 6:22 PM

#

Why?

#

I need the attachment changes in

#

We don't lose anything by squashing imo

shut wraith Feb 29, 2024, 6:24 PM

#

Can you not merge those in?

#

Oh, you want them under the snapshot work

fallen igloo Feb 29, 2024, 6:25 PM

#

maty said rebase

elder swallow Feb 29, 2024, 6:26 PM

#

That's cursed

shut wraith Feb 29, 2024, 6:26 PM

#

I mean that's sorta what rebase is meant for

#

So I can see the logic there

elder swallow Feb 29, 2024, 6:26 PM

#

I do not want to be fixing conflicts between vanilla changes and our old code

shut wraith Feb 29, 2024, 6:27 PM

#

Good luck with the porting in any case!

fallen igloo Feb 29, 2024, 6:27 PM

#

I think rebase -> fix -> update

#

is what maty meant

elder swallow Feb 29, 2024, 6:30 PM

#

Rebasing the snapshot work is not feasible

#

And it's also too risky IMO

#

Keep in mind that rebasing reapplies the commits one by one. If there is any conflict you have to fix it before you can move on with the other conflicts

slow prism Feb 29, 2024, 6:30 PM

#

uh rebasing is how it was always done lol

#

so yes it is feasible thinkies

elder swallow Feb 29, 2024, 6:30 PM

#

Hence we should first squash, and then rebase the single squashed commit

#

It's quite clearly suboptimal

frail hatch Feb 29, 2024, 6:33 PM

#

elder swallow I don't expect that putting on the mekanism boot thingy will suddenly fuck with ...

That's a bad example. We haven't applied step boost when sneaking for nearly four years https://github.com/mekanism/Mekanism/commit/cd0cbae0bddba2cb8ebc514b4902a2bd67b4a34d

elder swallow Feb 29, 2024, 6:35 PM

#

How does that work with attributes?

#

And honestly I didn't know but it does make sense

frail hatch Feb 29, 2024, 6:37 PM

#

we apply/update the attribute when our step boost application changes

#

that just is where it actually gets what the current value is

elder swallow Feb 29, 2024, 6:37 PM

#

Ah you change it on the player directly?

frail hatch Feb 29, 2024, 6:37 PM

#

yes

elder swallow Feb 29, 2024, 6:39 PM

#

Fair enough heh. I thought it was happening via the item (the equipment stuff)

true jacinth Feb 29, 2024, 6:39 PM

#

stabolb you should still be using the attribute

#

Also did that code even ever work right

#

if someone else modifies the step height that code will explode

stray bay Feb 29, 2024, 6:43 PM

#

yeah, the special sneaking behavior is fine but should be done by adding and removing an attribute modifier, the whole reason we added an attribute was because if more than one mod was installed that had a step height thing they'd all break

true jacinth Feb 29, 2024, 6:43 PM

#

idk if that's still live that commit is from 2020

stray bay Feb 29, 2024, 6:44 PM

#

....is the oddly specific 1.002f value a marker in hopes that other mods that add step height don't set it to the exact same value?

true jacinth Feb 29, 2024, 6:44 PM

#

probably

elder swallow Feb 29, 2024, 7:05 PM

#

It's probably been moved to the attribute by now

frail hatch Feb 29, 2024, 8:35 PM

#

true jacinth <:stabolb:876875085535928350> you should still be using the attribute

I do? And I have? So much so that I was one of the tiny portion of mods that were affected when the attribute was reverted two days after introduction, and had to reimplement it: https://github.com/MinecraftForge/MinecraftForge/pull/8607

true jacinth Feb 29, 2024, 8:35 PM

#

yeah I didn't look at the commit date when I posted that :p

frail hatch Feb 29, 2024, 8:36 PM

#

stray bay ....is the oddly specific 1.002f value a marker in hopes that other mods that a...

I think that was the idea, given something something pre attributes

true jacinth Feb 29, 2024, 8:36 PM

#

Hopefully mojang addresses the step down properly... otherwise idk, I have to fix it in some silly library or something

stiff galleon Feb 29, 2024, 8:37 PM

#

or if they just declare it's intentional then we could just ignore it harold

restive raft Feb 29, 2024, 8:38 PM

#

someone pin a link to the mojira bug report

true jacinth Feb 29, 2024, 8:38 PM

#

"... but given it's a stupid ass decision, I've elected to ignore it"

stiff galleon Feb 29, 2024, 8:40 PM

#

Is this not intended? What else would control the height difference check when sneaking at the edge of a block? If the player is able to step up a certain height I would also expect them to sneak walk off that same height.
I dunno, that makes sense to me

#

https://bugs.mojang.com/browse/MC-268917

^ the mojang bug report for stepup height also affecting sneakoff height

elder swallow Feb 29, 2024, 8:40 PM

#

true jacinth Hopefully mojang addresses the step down properly... otherwise idk, I have to fi...

Or you just remove the attribute when the player is sneaking

true jacinth Feb 29, 2024, 8:42 PM

#

stiff galleon > Is this not intended? What else would control the height difference check when...

even the variable name doesn't imply this behavior - maxUpStep() - for stepping up

restive raft Feb 29, 2024, 8:42 PM

#

stiff galleon <https://bugs.mojang.com/browse/MC-268917> ^ the mojang bug report for stepup h...

deep spoke Feb 29, 2024, 8:42 PM

#

Given that step up and scaling were introduced at similar times, I'd imagine the step down changing when sneaking would not be wanted so that a scaled up entity with scaled up speed, step, fall damage, reach, etc would be effectively the same as a regular scale entity with blocks being smaller

restive raft Feb 29, 2024, 8:42 PM

#

thanks Commoble

true jacinth Feb 29, 2024, 8:43 PM

#

sneak is (always has been) a fixed "you may not step down more than 0.5 blocks [slabs])

deep spoke Feb 29, 2024, 8:43 PM

#

For many mods yes, maybe not necessarily for what vanilla is going for

stiff galleon Feb 29, 2024, 8:43 PM

#

true jacinth sneak is (always has been) a fixed "you may not step down more than 0.5 blocks [...

yeah but you could say the same thing about stepup

deep spoke Feb 29, 2024, 8:44 PM

#

I've seen various mods in the past that disable increased stepping up for their items when sneaking as well

true jacinth Feb 29, 2024, 8:45 PM

#

step up does actually vary between mobs, but sneak is invariant

stiff galleon Feb 29, 2024, 8:45 PM

#

which other mobs can sneak

true jacinth Feb 29, 2024, 8:46 PM

#

It is also not naturally possible to remove the step height modifiers on a property of the player like that

#

(every mod would end up needing a tick handler to check sneaking to remove the property, it would be awful)

stray bay Feb 29, 2024, 8:47 PM

#

does player sneaking not apply when riding a horse?

deep spoke Feb 29, 2024, 8:47 PM

#

Dismounts

true jacinth Feb 29, 2024, 8:47 PM

#

sneaking dismounts the horse, so no

#

but riding the horse increases the step height

jagged yoke Feb 29, 2024, 8:48 PM

#

stiff galleon > Is this not intended? What else would control the height difference check when...

I see the issue now, and could reproduce. It does indeed feel weird. I think the cleanest solution would be adding a crouch_step_height attribute or something.

stiff galleon Feb 29, 2024, 8:48 PM

#

yeah that'd work

true jacinth Feb 29, 2024, 8:48 PM

#

The original issue report to forge requested a "sneak down height" attribute

restive raft Feb 29, 2024, 8:48 PM

#

~~oh hey, the gang's all here~~

true jacinth Feb 29, 2024, 8:48 PM

#

we didn't elect to do that as basically nobody ever wants that behavior, lol

#

gameplay wise it feels exceptionally awful to have the step-down limit adjusted

deep spoke Feb 29, 2024, 8:49 PM

#

Reduced step down works better when combined with reduced player scale + speed + etc

stray bay Feb 29, 2024, 8:52 PM

#

i'm tempted to report a separate bug to mojang about it not doing a proper step down but simply letting you fall

true jacinth Feb 29, 2024, 8:52 PM

#

it's always a fall, you just can't notice it for 0.5

stray bay Feb 29, 2024, 8:52 PM

#

if my step height is two i should be able to sprint down a 2-z-per-y slope without taking fall damage

#

[as is, you actually take damage walking normally down such a slope, since you end up skipping every other step]

elder swallow Feb 29, 2024, 8:54 PM

#

true jacinth gameplay wise it feels *exceptionally awful* to have the step-down limit adjuste...

Yeah...

#

Stepping up 10 blocks is pretty funny though

stray bay Feb 29, 2024, 8:55 PM

#

i am curious how step up behaves if the intervening blocks aren't solid

#

i should download the snapshot

short cove Mar 1, 2024, 2:53 AM

#

https://bugs.mojang.com/projects/MC/issues/MC-268800?filter=allopenissues

#

Did they not do a single test

#

Embed fail

#

foggy steeple Mar 1, 2024, 3:01 AM

#

They release bugs on purpose to make sure players are actually playing the game!

#

No reports = no players

short cove Mar 1, 2024, 3:47 AM

#

I usually don't like the "blah mojang devs lazy" stuff because they're obviously not but

#

Refactors require testing

#

Ur telling me an entire team neglected to check if the item stuff was working

#

Maybe it was working in dev lol

jagged yoke Mar 1, 2024, 3:55 AM

#

There are a million individual things that they could be testing after every merge, it's unavoidable some issues slip through when they don't have an automated test for it

shut wraith Mar 1, 2024, 3:58 AM

#

They've probably since added automated tests for it, if I had to guess. I get they have tons of gametests just for bugs that have happened in the past

short cove Mar 1, 2024, 3:58 AM

#

Isn't this more of a DFU issue

#

Shouldn't DFU has converted the nbt to components

jagged yoke Mar 1, 2024, 3:59 AM

#

No, this is an issue with brand new worlds as well

azure sparrow Mar 1, 2024, 6:37 AM

#

this bug is fun
hint: see AttributeModifier.equals()

rigid walrus Mar 1, 2024, 6:44 AM

#

I was looking at that earlier and noticed the interner along with the hashcode and equals methods only taking into account the id

dense mica Mar 1, 2024, 7:12 AM

#

tbh, it is known that having "the horde" find bugs sometimes is just cheaper, I thought that's why they release the snapshots in the first place^^. Half of Star Citizen runs on the community finding the bugs^^.

stray bay Mar 1, 2024, 7:19 AM

#

default tool attribute modifiers aren't nbt, whatever this is it isn't related to the component thing

rigid walrus Mar 1, 2024, 7:21 AM

#

items have default components

elder swallow Mar 1, 2024, 8:32 AM

#

@true jacinth we don't need this anymore, right?

true jacinth Mar 1, 2024, 8:33 AM

#

Vanilla added gravity yeah?

elder swallow Mar 1, 2024, 8:33 AM

#

this is our 1.20.4 gravity patch - it implements SLOW_FALLING by applying a transient -0.07

#

yeah they did

true jacinth Mar 1, 2024, 8:33 AM

#

Did they not apply a modifier there?

elder swallow Mar 1, 2024, 8:33 AM

#

this means that in NeoForge slow falling only reduces gravity by 0.07 (so from 0.08 to 0.01 by default)

#

whereas in vanilla it reduces gravity to 0.01 regardless of the attribute value

true jacinth Mar 1, 2024, 8:34 AM

#

That... seemingly wouldn't make sense

elder swallow Mar 1, 2024, 8:34 AM

#

if you have a base gravity of 0.20 and slow falling, then:

neoforge 1.20.4: effective gravity is 0.13
vanilla 1.20.5: effective gravity is 0.01

true jacinth Mar 1, 2024, 8:35 AM

#

What if gravity was lower than 0.01

#

would it increase it?

#

That would (imo) be a good case for a bug, because slow fall would increase fall speed

elder swallow Mar 1, 2024, 8:36 AM

#

you might fly up if gravity is lower than 0.08 on neoforge 1.20.4 kekw

#

I need to test this

#

~~nah the min value on neoforge 1.20.4 is 0.08, damn~~

true jacinth Mar 1, 2024, 8:37 AM

#

Huh? You can def have negative gravity

elder swallow Mar 1, 2024, 8:37 AM

#

yeah you're right

#

I was looking at the default value

true jacinth Mar 1, 2024, 8:37 AM

#

bigbrain

elder swallow Mar 1, 2024, 8:37 AM

#

but no, vanilla does a Math.min

true jacinth Mar 1, 2024, 8:38 AM

#

Imo the flat modifier is wrong and should be a multiply by 1/8

#

but vanilla is also wrong for just forcing 0.01

elder swallow Mar 1, 2024, 8:38 AM

#

why is that wrong? I can see both making sense

true jacinth Mar 1, 2024, 8:39 AM

#

oh it doesn't do the increasing thing

#

If that .min call was absent it would be screwed, lol

elder swallow Mar 1, 2024, 8:40 AM

#

yeah

#

but they added it in 1.20.5

true jacinth Mar 1, 2024, 8:40 AM

#

tad annoying that to compute the effective gravity you have to account for slowfall though

elder swallow Mar 1, 2024, 8:40 AM

#

so I think that they tested this

#

lmao I'm going up now

#

this is neoforge 1.20.4, with slow falling

#

it's so stupid

true jacinth Mar 1, 2024, 8:42 AM

#

v smart gravity application

fallen igloo Mar 1, 2024, 8:42 AM

#

well that is a bug

elder swallow Mar 1, 2024, 8:42 AM

#

thankfully that bug will solve itself in 1.20.5

true jacinth Mar 1, 2024, 8:42 AM

#

Make it multiply total 1/8F

#

Probably needs to be fixed in 20.1 too

#1.20.5/6 Snapshots