1.20.2 | The NeoForged Project | Page 8

mental carbon Oct 4, 2023, 9:22 PM

#

Cause those are what the community hangs its expectations on

fallow sundial Oct 4, 2023, 9:22 PM

#

fortunately they've moved past that stage phew abolbsweats

jagged agate Oct 4, 2023, 9:23 PM

#

Split the behaviors to individual registrable functions. One registry for onUse…

fallow sundial Oct 4, 2023, 9:23 PM

#

harold

mental carbon Oct 4, 2023, 9:24 PM

#

If they can find a good way to do the custom things in datapacks

#

That would be a great step forward

fallow sundial Oct 4, 2023, 9:24 PM

#

I mean the concept of block types is mostly a way of configuring properties on a block

#

there's nothing indicating behaviour is included in this

kindred fractal Oct 4, 2023, 9:24 PM

#

Yeah I think each block class will map to a block type, more or less

fallow sundial Oct 4, 2023, 9:24 PM

#

and I doubt it would be

tranquil salmon Oct 4, 2023, 9:24 PM

#

fallow sundial fortunately they've moved past that stage phew <a:abolbsweats:102609326916949205...

Last time I checked bukkit hasn't moved past the enum phase

kindred fractal Oct 4, 2023, 9:25 PM

#

bukkit and move in the same sentence?

fallow sundial Oct 4, 2023, 9:25 PM

#

it's time to move past it then. heh

#

dynamic enum values anyone?

#

the biggest benefit I see in all of this is syncing. if it's done with syncing it solves an issue people have been dealing with for a decade

mossy bobcat Oct 4, 2023, 10:25 PM

#

kindred fractal Yeah I think each block class will map to a block type, more or less

I suspect they'll start with this at least; that's what the current stuff looks like from what I can tell. Basically how configured features work. Even with just that it could be a pretty dang powerful system

#

(the same as configured features currently are)

#

Would also require me to basically rewrite Excavated Variants but you know, it's for a good cause

tranquil salmon Oct 4, 2023, 10:44 PM

#

Here's what the json files currently are for each block when output as json from the codecs

📎 blocks.zip

tranquil salmon Oct 4, 2023, 11:01 PM

#

  "mco.snapshotRealmsPopup.message": "Realms are now available in Snapshots starting with Snapshot 23w41a. Every Realms subscription comes with a free Snapshot Realm that is separate from your normal Java Realm!",
  "mco.snapshotRealmsPopup.title": "Realms now available in Snapshots",
  "mco.snapshotRealmsPopup.urlText": "Learn More",

in en_us.json

frigid bolt Oct 5, 2023, 12:56 AM

#

inb4 next week's snapshot
Dont tempt mojang Tele, you may get that wish 🤣

stray scroll Oct 5, 2023, 3:04 AM

#

got busied, will try to take a look at my work by this weekened

dull bison Oct 5, 2023, 6:15 AM

#

tranquil salmon Here's what the json files currently are for each block when output as json from...

omg this is awesome for stuff like wood types

vague otter Oct 5, 2023, 6:25 AM

#

i KNEW this was coming

#

surprised they didn't at least get properties into the json properly though

inland mesa Oct 5, 2023, 6:30 AM

#

seems super WIP so they probably didn't get around to that yet

dull bison Oct 5, 2023, 6:32 AM

#

I think they will implement but not use it for 1.20.3 and use it in 1.21

inland mesa Oct 5, 2023, 6:33 AM

#

I feel like they may have it in 1.20.3 as a preview feature

dull bison Oct 5, 2023, 7:00 AM

#

I don't think that makes a good preview feature because it is a BIG change

inland mesa Oct 5, 2023, 7:33 AM

#

no like, it would always be used for vanilla, but the preview feature would be adding new ones from datapack

dull bison Oct 5, 2023, 8:09 AM

#

I don't think they will use the json in 1.20.3

mossy bobcat Oct 5, 2023, 8:54 AM

#

I bet they've got a branch where they're switching over to JSON already, and they're slowly bringing components over to test out in production before they make a full switch

mental carbon Oct 5, 2023, 10:39 AM

#

#

Much closer to what it needs to be

#

The META-INF is fucked

#

But much closer

rich void Oct 5, 2023, 11:16 AM

#

why is it still forge?

dull bison Oct 5, 2023, 11:17 AM

#

because the rename comes after the installer works

inland mesa Oct 5, 2023, 11:18 AM

#

step by step

rich void Oct 5, 2023, 11:19 AM

#

oh

#

I thought that would be an easy change

#

but of course that would be harder than it is in mods

mental carbon Oct 5, 2023, 11:56 AM

#

#

Closer......

#

#

Nearly there

#

But first

#

I need to go work out

#

Then I can fix this

#

And that should be the last of it then 😄

muted hemlock Oct 5, 2023, 12:19 PM

#

// iron_ore.json
{
  "type": "minecraft:drop_experience",
  "experience": 0,
  "properties": {}
}

thonkies

rich void Oct 5, 2023, 12:42 PM

#

what's that?

jagged agate Oct 5, 2023, 12:43 PM

#

The start of players and pack makers creating blocks by json

rich void Oct 5, 2023, 12:50 PM

#

cool

#

I think that type should be called "ore" though

#

or raw_ore

jagged agate Oct 5, 2023, 12:51 PM

#

What if you want to use it for non-ores?

muted hemlock Oct 5, 2023, 12:51 PM

#

the block types are 1:1 with existing classes

#

and the existing class that ore blocks use is called DropExperienceBlock :p

rich void Oct 5, 2023, 12:52 PM

#

never knew that

#

so that's just all blocks that drop experience?

dull bison Oct 5, 2023, 2:08 PM

#

that's not something we add btw that is all vanilla

muted hemlock Oct 5, 2023, 2:09 PM

#

the dropexperience block is patched weirdly though

kindred fractal Oct 5, 2023, 2:26 PM

#

isn't there a patch to know how much xp a block drops without having to break it?

frail oriole Oct 5, 2023, 2:34 PM

#

yes

#

and it's super cursed

mossy bobcat Oct 5, 2023, 2:36 PM

#

That patch caused me so much pain in the past

#

...and I can imagine many block related patches and extensions will need rethought depending on where Mojang goes with this

#

That's not even considering items which I have to assume they'd be doing this to too

wise forge Oct 5, 2023, 2:42 PM

#

~~data driven events time~~

mossy bobcat Oct 5, 2023, 2:43 PM

#

I literally built an API to do exactly that for quilt so not as far fetched as it could be, honestly

frail oriole Oct 5, 2023, 2:47 PM

#

data driven event hooks was something i wanted to do for the longest time

mossy bobcat Oct 5, 2023, 2:48 PM

#

I can try to poke such a system in the future if you'd like

frail oriole Oct 5, 2023, 2:48 PM

#

many events could just be method wraps on the base block/item

#

which would get you 99% of the way there

mossy bobcat Oct 5, 2023, 2:49 PM

#

Oh, for block/item specific ones yeah

#

I was thinking in general

frail oriole Oct 5, 2023, 2:49 PM

#

using a coremod or mixin to just say "hey, wrap all these things as events"

#

you'd need a generic event dispatch system to do it

#

not generic event as in GenericEvent but generic as in "general purpose"

#

EventFactoryFactory hype!

mossy bobcat Oct 5, 2023, 2:50 PM

#

At a cursory glance I don't think it would be too hard to make a generic event callback data system - though you'd need some concept of layered event busses or something to support reloading, some system to register callback serializer types (this isn't too hard actually, I have some ideas in mind)... yeah actually I think it's pretty doable

frozen vapor Oct 5, 2023, 2:51 PM

#

EventFactoryProvider mmLol

frail oriole Oct 5, 2023, 2:51 PM

#

EventFactoryProviderFactoryProvider or go home

mossy bobcat Oct 5, 2023, 2:51 PM

#

You'd probably register Pair<Codec<? extends Consumer<SomeEvent>, Class<SomeEvent>> to a registry somewhere to deserialize event listeners

#

So, just a standard old delegate based serialization

#

Except it would register them as listeners by the provided class

#

And then you'd need a layered bus system of some sort to construct a new listener list each reload but keeping anything registered in code

#

Yeah, honestly that could definitely work

muted hemlock Oct 5, 2023, 3:01 PM

#

mossy bobcat ...and I can imagine many block related patches and extensions will need rethoug...

I'm guessing existing block classes will remain (as "block types") and only the block instances will be data driven (having the block properties + constructor args for the blocks)

#

I doubt mojang ends up making a serializer registry for each overridable block method

mossy bobcat Oct 5, 2023, 3:02 PM

#

muted hemlock I'm guessing existing block classes will remain (as "block types") and only the ...

I suspect as much too but there's stuff mojang has as context independent in block types that forge adds patches to make context dependent. I'll wait and see what it all actually looks like at the end of the day though

frail oriole Oct 5, 2023, 3:03 PM

#

mossy bobcat And then you'd need a layered bus system of _some_ sort to construct a new liste...

You'd probably just fix bus

mossy bobcat Oct 5, 2023, 3:03 PM

#

Hmm? How so?

frail oriole Oct 5, 2023, 3:03 PM

#

To allow reloads somehow. Not even sure why this is key right now but

mossy bobcat Oct 5, 2023, 3:03 PM

#

I'd just make a new bus with listeners from the root one, plus any listeners loaded from data

mossy bobcat Oct 5, 2023, 3:04 PM

#

frail oriole To allow reloads somehow. Not even sure why this is key right now but

Oh yeah, it'd be a bus change. Not key right now at all

frail oriole Oct 5, 2023, 3:04 PM

#

Anyway

mossy bobcat Oct 5, 2023, 3:04 PM

#

I was just explaining how I'd approach this #1136320550168436798 message

frail oriole Oct 5, 2023, 3:04 PM

#

New ideas for new things. Which is nice

#

Is kits up to date with progress at present?

#

Was going to take a look this afternoon

#

If I can

arctic sphinx Oct 5, 2023, 3:07 PM

#

I believe Orion has it all locally atm?

mental carbon Oct 5, 2023, 3:08 PM

#

I have it locally currently still

#

I will push later today, where I have the working installer

#

The userdev stuff will not be in there

#

Because it is uterly broken

#

But the infrastructure to create the userdev stuff should be there then

frail oriole Oct 5, 2023, 3:08 PM

#

Thanks

#

Yeah

#

Maybe I'll take a look at userdev

#

Now, isn't userdev different with ngnext?

mental carbon Oct 5, 2023, 3:09 PM

#

I need to create the JSON model for it

#

Cause I derped

frail oriole Oct 5, 2023, 3:09 PM

#

Ok

mental carbon Oct 5, 2023, 3:09 PM

#

frail oriole Now, isn't userdev different with ngnext?

Nope, and if I did it right, NG6 can run the new Userdev still

#

So modders don't need to upgrade

frail oriole Oct 5, 2023, 3:09 PM

#

Ok cool!

mental carbon Oct 5, 2023, 3:10 PM

#

But I am not giving any guarantee on that

frail oriole Oct 5, 2023, 3:10 PM

#

That's ok

mental carbon Oct 5, 2023, 3:10 PM

#

I am trying to make it so

#

But I have not tested it what so ever

frail oriole Oct 5, 2023, 3:10 PM

#

I'll take a look once you push this afternoon

#

I'll validate that the installer looks good and stuff too

#

Now, is kits ready to go patch only?

#

I don't recall seeing the decompiled stuff in kits actually

vague otter Oct 5, 2023, 3:19 PM

#

rich void so that's just all blocks that drop experience?

yup, it was renamed from ore block when it was reused for sculk blocks.

rich void Oct 5, 2023, 3:19 PM

#

vague otter yup, it was renamed from ore block when it was reused for sculk blocks.

ooh, that makes a lot of sense

mental carbon Oct 5, 2023, 7:56 PM

#

#

Forking shirt balls

frail oriole Oct 5, 2023, 7:57 PM

#

ah. generating the wrong hashs

mental carbon Oct 5, 2023, 7:59 PM

#

Not sure

#

I think I generate the right stuff

#

Like the correct hashes

#

For the runtime

#

but jarsplitter behaves differently

#

Okey I think I will need to cook my brain over this tomorrow

#

I think I implemented the jar splitting wrong

#

Which xplains the extra jar

#

But I missed the slim stuff

#

So I need to deal with that first

frail oriole Oct 5, 2023, 8:24 PM

#

hmmm

fallow sundial Oct 5, 2023, 9:08 PM

#

frail oriole data driven event hooks was something i wanted to do for the longest time

you should look at the love tropics behaviour system then, I'm sure you'd love it

keen hearth Oct 5, 2023, 9:46 PM

#

mental carbon

FG did some whack stuff with writing zips to make sure they were stable, like setting the timestamps to epoch, etc. Historically, this has usually been the issue with these hash failures on install.

mossy bobcat Oct 5, 2023, 10:08 PM

#

List of things that can go wrong in zips:

file order
timestamps
file/directory modes
etc.; gradle, I believe, has some built in stuff you can enable on archive tasks to force zips to be fairly reproducible

#

But zip reproducibility is a real goddamn pain

arctic sphinx Oct 5, 2023, 10:11 PM

#

I think there was also an issue with certain jvms having the default compression setting for Zips being a different value iirc

#

Half remember a report to FG

#

https://github.com/MinecraftForge/JarSplitter/pull/2

GitHub

Explicitly set compression ratio on resulting jar files by diesiebe...

Apparently there are some OpenJDK distributions or other circumstances where the default compression level for ZipOutputStream is different. This was reported at PolyMC PolyMC/PolyMC#809, but a use...

mental carbon Oct 6, 2023, 7:29 AM

#

I thought about this for a while. We already check all the hashes of the tools we download. Additionally checking all the hashes of the files that those tools produce with their already checked inputs seems rather overkilll

stray scroll Oct 6, 2023, 7:33 AM

#

IMO it would be overkill for a given file to be checked twice -- once as an output of a tool, again as the input to another kill

#

but usually, known good checksums are a guarantee of consistency; a safeguard in case something causes a tool (designed to give the same output for the same input) to not work correctly on some given system or setup

mental carbon Oct 6, 2023, 7:35 AM

#

The problem is that we already have several different implementations of the same thing

#

Now it is jatsplitter

#

Where ng6/7 have different implementations of the same thing

#

Let alone the zip consistent ordering

#

And it simply does not matter

#

Like we already check every single file the installer downloads for hash and size

#

Including things like neoform the patches the universal jar and all tools

#

The invocations of the tools are hardcoded

#

There is simply no reason to go and do a hash check for that one tool

#

Hell when we switched to fart /vignette lex even disabled the damn hashcheck

#

I am okey with revisiting this later

#

But it requires rewriting a very large part of NG7

#

java.io.IOException: Patch expected com/mojang/blaze3d/pipeline/RenderTarget to have the checksum 2bdcd91c but it was f56381af
    at net.minecraftforge.binarypatcher.Patcher.patch(Patcher.java:197)
    at net.minecraftforge.binarypatcher.Patcher.process(Patcher.java:149)
    at net.minecraftforge.binarypatcher.ConsoleTool.main(ConsoleTool.java:161)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.base/java.lang.reflect.Method.invoke(Method.java:578)
    at net.minecraftforge.installer.actions.PostProcessors.process(PostProcessors.java:226)
    at net.minecraftforge.installer.actions.ClientInstall.run(ClientInstall.java:144)
    at net.minecraftforge.installer.InstallerPanel.run(InstallerPanel.java:423)
    at net.minecraftforge.installer.SimpleInstaller.launchGui(SimpleInstaller.java:189)
    at net.minecraftforge.installer.SimpleInstaller.main(SimpleInstaller.java:161)

#

Now I gotta check what the hell patcher is on about

mossy bobcat Oct 6, 2023, 8:34 AM

#

mental carbon The invocations of the tools are hardcoded

That's exactly why the check is important - if you're getting a different hash, and everything is the same to invoke it, chances are something has gone wrong

#

That, or your tools' output isn't reproducible which is also bad

mental carbon Oct 6, 2023, 8:43 AM

#

Given that the tool output is reproducible

#

Leads me to think that the check is not needed

dull bison Oct 6, 2023, 8:44 AM

#

the check is there to verify that it in fact is reproducible

mental carbon Oct 6, 2023, 8:51 AM

#

dull bison the check is there to verify that it in fact is reproducible

Which is not something that should happen at runtime

#

There should be tests within the tools to guarantee that

#

Not within the consumer of said tool

mental carbon Oct 6, 2023, 8:54 AM

#

mental carbon ```text java.io.IOException: Patch expected com/mojang/blaze3d/pipeline/RenderTa...

Ah figured this error out:

#

Patcher is running in OBF mode

#

Sadface

#

So merged mappings is not correct

#

#

Yep the mappings file did not work properly

#

Okey adding the additional args

#

Lets see 😄

#

#

That is already much better

#

But still erroring on the has

#

Now the damn question becomes

#

Which checksum is wrong

#

Aha

#

There is actually a difference

#

We generate it with the @cinder field annotation present

mossy bobcat Oct 6, 2023, 10:20 AM

#

mental carbon Given that the tool output is reproducible

Is it reproducible? Have you tested that on every possible platform, each with their own possible JVM weirdness, to make sure you get the same results out? A hash is an easy thing because if it doesn't match, there's an issue, because by definition if it doesn't match it isn't reproducible.

mental carbon Oct 6, 2023, 10:52 AM

#

mossy bobcat *Is* it reproducible? Have you tested that on *every possible* platform, each wi...

Yet this requires running several different implementations of the same shit over and over again

#

The patcher will fail downstream is the jar is bogus

#

Like it is doing now

#

So it does not matter if I check the output of the jar splitter for some hashj

mossy bobcat Oct 6, 2023, 10:52 AM

#

I mean, hashing intermediates isn't really important. The important bit is hashing the thing at the very beginning (anything you download) and the very end

mental carbon Oct 6, 2023, 10:52 AM

#

If the contents are bogus

#

The patcher will barf

mossy bobcat Oct 6, 2023, 10:53 AM

#

So as long as the final product is checked on a hash you're fine

mental carbon Oct 6, 2023, 10:53 AM

#

Like it is doing now

mossy bobcat Oct 6, 2023, 10:53 AM

#

But the final products, whatever those may be (so, whatever is actually exposed and used elsewhere), does need to be hashed

#

Like, there's plenty of "non-bogus" (ie, not completely messed up) jars that won't cause a failure until a hash is checked

#

Checking a hash at each step just lets you fine-tune where the issue is when an issue does arise

#

Only checking a final hash is also completely fine - but doing so risks difficulty in figuring out where the failure was

mental carbon Oct 6, 2023, 12:46 PM

#

@frail oriole I pushed my changes

#

I have an issue with the hashes of the binary patches

#

But I think that is caused by using the wrong clean file..... Cause I think I am using the neoform output, and the installer expects just the plain vanilla jar.....

#

Need to double check tomorrow morning

frail oriole Oct 6, 2023, 12:57 PM

#

Yes it does expect the vanilla file

mental carbon Oct 6, 2023, 2:49 PM

#

Yeah then that is my mistake

#

Easily fixable

#

Just need to do it

#

However I have my wedding party tonight

#

So no programming from me untill tomorrow afternoon

frail oriole Oct 6, 2023, 2:50 PM

#

i'm out until next week this afternoon.

#

sadly i don't have any time to look at all. i won't even have a computer heh.

arctic sphinx Oct 6, 2023, 2:50 PM

#

mental carbon However I have my wedding party tonight

Congrats btw

mental carbon Oct 6, 2023, 2:51 PM

#

Thanks

#

But yeah is a trivial fix

frail oriole Oct 6, 2023, 2:51 PM

#

cool

#

is it all still in 1.20.2-ngnext?

#

also, enjoy your wedding party!

#

hmmm

#

i can't get this to build.

#

it won't even clean

#

i have NG and kits colocated. i swapped NG to 7 branch

kindred fractal Oct 6, 2023, 3:13 PM

#

congrats Orion! 😄

dull bison Oct 6, 2023, 3:16 PM

#

congrats Orion ... and Mrs Orion

dull bison Oct 6, 2023, 3:34 PM

#

frail oriole i can't get this to build.

do you also get the configuration cache thing?

true pivot Oct 6, 2023, 3:44 PM

#

congrats!

frail oriole Oct 6, 2023, 3:45 PM

#

dull bison do you also get the configuration cache thing?

Configuration cache entry discarded with 2 problems. i get at the end of the failed build

dull bison Oct 6, 2023, 3:45 PM

#

yep same

frail oriole Oct 6, 2023, 3:46 PM

#

this is just doing clean task

dull bison Oct 6, 2023, 3:47 PM

#

it is because of GradleUtils running git commands in NG

frail oriole Oct 6, 2023, 3:48 PM

#

Caused by: java.lang.NullPointerException: Cannot get property 'sourceSets' on null object
        at build_356kduq6goiv84gjqd0q8syaw$_run_closure7$_closure24$_closure30.doCall(/home/cpw/projects/neoforged/Kits/projects/forge/build.gradle:131)

#

no

#

this source set doesn't seem to quite exist

frozen vapor Oct 6, 2023, 3:49 PM

#

that's a lovely stack trace

frail oriole Oct 6, 2023, 3:50 PM

#

it's enough to try and fix it

dull bison Oct 6, 2023, 3:50 PM

#

hmm for me it says:

#

* What went wrong:
Configuration cache problems found in this build.

2 problems were found storing the configuration cache.
- Build file '..\NeoGradle\build.gradle': external process started 'C:\Program Files\Git\cmd\git.exe --version'
  See https://docs.gradle.org/8.1.1/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Build file '..\NeoGradle\build.gradle': external process started 'C:\Program Files\Git\cmd\git.exe config --system --edit'
  See https://docs.gradle.org/8.1.1/userguide/configuration_cache.html#config_cache:requirements:external_processes

See the complete report at file:///C:/Users/georg/Documents/modding/NeoForged-Porting/build/reports/configuration-cache/9f3o7c6wmcfaob84dqc75b88a/ex99wwh3l2z8ol8fethqfe8a9/configuration-cache-report.html
> Starting an external process 'C:\Program Files\Git\cmd\git.exe --version' during configuration time is unsupported.
> Starting an external process 'C:\Program Files\Git\cmd\git.exe config --system --edit' during configuration time is unsupported.

frozen vapor Oct 6, 2023, 3:50 PM

#

yeah, at least it gives line numbers and stuff 😅

#

if you were going purely on classnames/methods that'd be a nightmare to debug

frail oriole Oct 6, 2023, 3:51 PM

#

yeah. if you do --stacktrace you find that is the root cause of everything else collapsing schurli

#

well, maybe heh

dull bison Oct 6, 2023, 3:53 PM

#

try and do an ide sync in NG first

frail oriole Oct 6, 2023, 3:55 PM

#

ok. so it looks like GU is trying to generate the changelog

#

i have to admit i'm a bit unclear why this would be working for orion

#

commenting out references to the changelog seems to fix it

#

my suspicion is this is a bootstrap problem

dull bison Oct 6, 2023, 4:00 PM

#

I opened NG in its own intellij window and did a sync and then did it in neo again and it works

frail oriole Oct 6, 2023, 4:00 PM

#

ok

#

it's possible that if you decouple NG and neo it works now

#

i still have the paired setup for kits

#

also, no ide. running from cmdline rn

dull bison Oct 6, 2023, 4:10 PM

#

wth :clean:setup and :neoform:setup work but :forge:setup errors

frail oriole Oct 6, 2023, 4:11 PM

#

i just had just setup work from the CLI

#

Cause: java.lang.reflect.InvocationTargetException
Failed to query the value of task ':forge:legacyInstallerJar' property 'installerJson'.
Could not create task ':forge:createLegacyInstallerJson'.
Could not determine the dependencies of null.
Current thread does not hold the state lock for project ':forge'
``` is what i get in IntelliJ right now

#

i'm gonna have to stop this for now

#

hopefully orion can figure it out next week

mental carbon Oct 6, 2023, 4:50 PM

#

Clean the directory

#

Delete the build directory

stray scroll Oct 6, 2023, 5:28 PM

#

hey @mental carbon, what GPG key are you using currently?

#

i'm curious, because I perchance went to do a git log, noticed your key wasn't in my keyring, pulled it from github.com/marchermans.gpg, and now GPG's telling me the key used to sign your most recent commit to Kits is expired

#

and checking my GPG keyring, it seems you have another key which isn't expired, but it seems you're not using it...?

#

yea, it seems all your recent commits to NeoGradle's FG_7.0 branch are also signed with your expired key

#

might wanna look into that

mental carbon Oct 6, 2023, 5:50 PM

#

Arg

#

I indeed have two

#

I will check what I need to do to get it edtended

keen hearth Oct 6, 2023, 10:10 PM

#

Hashes for each step are crucial, it allows for the files to be cached, if your zips are not stable, that is a massive problem.

mental carbon Oct 6, 2023, 10:42 PM

#

They are stable and caching for each step does not need hashes. They are already clearly defined by coordinate

mossy bobcat Oct 6, 2023, 10:48 PM

#

As long as the final file is hashed you'll at least know if there's an issue. You just won't know where if the in-between stuff isn't hashed

keen hearth Oct 6, 2023, 10:58 PM

#

mental carbon They are stable and caching for each step does not need hashes. They are already...

Caching for each step DOES need hashes, otherwise subsequent runs of the installer will do work instead of skipping. You have no way of knowing if the work was completed, or if the work failed.

kindred hatchBOT Oct 7, 2023, 3:38 AM

#

tranquil salmon ```json "mco.snapshotRealmsPopup.message": "Realms are now available in Snapsh...

Created Gist at the request of @fossil ore: https://gist.github.com/NeoCamelot/679dce1a680c91788807b3872ab203da

fossil ore Oct 7, 2023, 3:42 AM

#

kindred hatch Created Gist at the request of <@330138110719557636>: <https://gist.github.com/N...

Oh so that is what that button does lol.

dull bison Oct 8, 2023, 10:48 AM

#

Todo:

finish installer
userdev jar
add neoform (clean) run configurations
rebase
rename packages
bump library versions / change library groups to neoforged variant

mental carbon Oct 8, 2023, 10:51 AM

#

I just realised that the installer was using a way outdated FART version....

#

And that might have been the cause for why I am getting fucking hash mismatches

mental carbon Oct 8, 2023, 10:54 AM

#

dull bison Todo: - finish installer - userdev jar - add neoform (clean) run configurations...

Userdev is missing from this

dull bison Oct 8, 2023, 10:54 AM

#

These libs need to be changed to neo variants:

accesstransformers
eventbus -> bus
forgespi
coremods
unsafe
mergetool
JarJarSelector
JarJarMetadata

#

question for the team: do any of those need a rename too (like eventbus -> bus)?

#

orion is it intentional that the run folder is per subproject inside the projects/<subproject> folder?

mental carbon Oct 8, 2023, 11:34 AM

#

Yes

dull bison Oct 8, 2023, 11:48 AM

#

orion can you update the hackmd with what you already did when the installer is done

mental carbon Oct 8, 2023, 11:52 AM

#

Once I figure out why the damn hash is different

dull bison Oct 8, 2023, 11:53 AM

#

if you need a second pair of eyes I'm available

mental carbon Oct 8, 2023, 11:53 AM

#

Yeah in a couple of minutes

#

I need to clean the kitchen

dull bison Oct 8, 2023, 11:53 AM

#

👍

mental carbon Oct 8, 2023, 12:19 PM

#

Okey cleaning up the kitchen now

#

Afterwards we can take a loook

mental carbon Oct 8, 2023, 2:15 PM

#

@frail oriole or @here does anybody know how the launcher determines the natives_directory we got everything installing and the likes, but running the game crashes with a missing natives error, using the debug flags, we noticed that the launcher is telling the game to use a none existing natives directory. But we can not seem to figure out how that is controlled?

drowsy condor Oct 8, 2023, 2:15 PM

#

ping meh?

pine ember Oct 8, 2023, 2:16 PM

#

In newer versions all the natives are on the classpath, the launcher no longer has any to extract.

drowsy condor Oct 8, 2023, 2:16 PM

#

mental carbon <@104313475756466176> or @here does anybody know how the launcher determines the...

by os?

#

have you tried doing that on multiple os?

mental carbon Oct 8, 2023, 2:17 PM

#

pine ember In newer versions all the natives are on the classpath, the launcher no longer h...

Well that seems to not be the case for 1.20.2 or .1 for that matter......

I can not find any hint of that in the either the installer nor in the version.json of any of those two versions.......

#

I remembered that as well....

#

But the natives just are not found by the game

#

And for some reason are not part of the classpath eventhough I extend the 1.20.2 version launcher json

jagged agate Oct 8, 2023, 2:17 PM

#

drowsy condor have you tried doing that on multiple os?

this channel is for the Neoforge toolchain porting work. Specifically the installer for Neoforge. So this is more for actual technical work and not guesses by folks like us who don't know the inner workings of launchers and installers

drowsy condor Oct 8, 2023, 2:18 PM

#

i mean you ping me so what else would i say ):<

dull bison Oct 8, 2023, 2:18 PM

#

the natives dir it sets is some hash that we don't know where it comes from

jagged agate Oct 8, 2023, 2:18 PM

#

drowsy condor i mean you ping me so what else would i say ):<

he ping @here tag in hopes of roping in other technical folks that are online.

mental carbon Oct 8, 2023, 2:19 PM

#

drowsy condor i mean you ping me so what else would i say ):<

Generally if you have no idea what I am talking about, you really should not be in this thread. It is fine if you want to read it but please if you have no idea then let us figure it out

drowsy condor Oct 8, 2023, 2:19 PM

#

ok

mental carbon Oct 8, 2023, 2:19 PM

#

pine ember In newer versions all the natives are on the classpath, the launcher no longer h...

I guess they are now supposedly passed in via ${classpath}?

pine ember Oct 8, 2023, 2:20 PM

#

mental carbon Well that seems to not be the case for 1.20.2 or .1 for that matter...... I can...

It definitely is the case, you should find the native jars on the class path. It's it possible that it's failing to find them due to whatever neo does (idk anything about that bit so cannot really help)

mental carbon Oct 8, 2023, 2:20 PM

#

I think you might be right modmuss

#

Something is making it so it is either 1) not looking on the CP or 2) the CP is broken

#

I am betting on 2)

#

But I am unsure where to look

#

As far as I can tell the thing is correct

pine ember Oct 8, 2023, 2:21 PM

#

Get a debugger and step through where LWJGL loads them from the CP.

mental carbon Oct 8, 2023, 2:21 PM

#

Yeah I am about to

#

Soooo

#

For some reason the launcher is not putting the GLFW natives on the classpath @pine ember

#

I have all kinds of natives

#

But not the glfw ones

pine ember Oct 8, 2023, 2:27 PM

#

You should have lwjgl-glfw-3.3.2-natives-macos-arm64.jar (or whatever for your OS) 🤔

mental carbon Oct 8, 2023, 2:27 PM

#

But I don't

#

The classpath

📎 message.txt

pine ember Oct 8, 2023, 2:28 PM

#

check the commandline used to start the JVM? idk how you could not have that, unless you are replacing the whole version json.

mental carbon Oct 8, 2023, 2:28 PM

#

Straight from the commandline

pine ember Oct 8, 2023, 2:29 PM

#

Thats odd, no idea whats up.

mental carbon Oct 8, 2023, 2:31 PM

#

Wtd

#

Somebody try that on windows

#

Or mac for that matter

lethal bane Oct 8, 2023, 2:34 PM

#

crashes on windows with Failed to locate library: lwjgl.dll

mental carbon Oct 8, 2023, 2:34 PM

#

Yeah I have that exact same issue

#

But I can not fathom why

#

The classpath is just wrong

mossy bobcat Oct 8, 2023, 2:40 PM

#

How does the newly created neo version JSON compare to a 1.20.2 forge version json that we know works?

mental carbon Oct 8, 2023, 2:40 PM

#

The funny thing it is actually identical at this point

mossy bobcat Oct 8, 2023, 2:40 PM

#

Unless I've misunderstood and it's failing before that

mental carbon Oct 8, 2023, 2:40 PM

#

We thinkk it is related to the update of lwgjl in 20.2

#

And the fact that fmlearlywindow forces it to include 3.3.1

#

So the natives related to it are not properly loaded

#

By the launcher

mossy bobcat Oct 8, 2023, 2:41 PM

#

mental carbon The funny thing it is actually identical at this point

concern welp, there goes that idea. Try comparing to a 20.2 forge one instead of a 20.1 one maybe? That's weird. Natives suck

mossy bobcat Oct 8, 2023, 2:41 PM

#

mental carbon And the fact that fmlearlywindow forces it to include 3.3.1

Ah, that makes some sense

mental carbon Oct 8, 2023, 2:41 PM

#

Yeah

#

but that is completely undocumented behaviour of the launcher

#

That would mean that the launcher does some form of dependency management internally with the given coordinate

mossy bobcat Oct 8, 2023, 2:42 PM

#

Hmm. Do we have any evidence it doesnt do that? After all, the whole thing is pretty undocumented

mental carbon Oct 8, 2023, 2:44 PM

#

Yes and no

#

We have no evidence in either direction

#

Only that we have an additional library for version 3.3.1 for glfw (but not its natives, which are in the parent version json still on 3.3.2)

mossy bobcat Oct 8, 2023, 2:46 PM

#

Should the early window even be requesting 3.3.1 now that vanilla uses 3.3.2?

mossy bobcat Oct 8, 2023, 2:47 PM

#

mental carbon Only that we have an additional library for version 3.3.1 for glfw (but not its ...

Ah, okay. Weird

keen hearth Oct 8, 2023, 6:13 PM

#

It does not do any dependency management from memory. It just collects and resolves all of them.

mental carbon Oct 8, 2023, 6:14 PM

#

Yeah no

#

It actually does

#

If you have say a dependency with the name: org.lwjgl:lwjgl-glfw:1.2.3 then any other dependency with that same group, and module but with different classifiers in the same file are linked to it

#

So if you override org.lwjgl:lwjgl-glfw:1.2.3 with say org.lwjgl:lwjgl-glfw:1.2.4 in another version which inherits from the first, then it will nuke all those classified sub versions (which includes the natives)

plucky pond Oct 8, 2023, 6:33 PM

#

I tried deleting the lwjgl liberated from the json file, but now mc is crashing with a different error. Is it not working or did I break something?

Exception in thread "main" java.io.UncheckedIOException: java.io.IOException: Invalid paths argument, contained no existing paths: [C:\Users\henri\AppData\Roaming\.minecraft\libraries\net\neoforged\forge\1.20.2-20.2.1\forge-1.20.2-20.2.1-universal.jar]

kindred fractal Oct 8, 2023, 6:34 PM

#

there is no 1.20.2 release yet, this channel is only for the actual porting work

plucky pond Oct 8, 2023, 6:36 PM

#

Yes I tried the installer orion send

dull bison Oct 8, 2023, 6:39 PM

#

we are about 5 errors further than you

mental carbon Oct 8, 2023, 7:43 PM

#

Okey, assets are not on the classpath

#

#

Well not crashin.....

kindred fractal Oct 8, 2023, 7:51 PM

#

progress

mental carbon Oct 8, 2023, 7:52 PM

#

#

It is loading some assets, but not alll

kindred fractal Oct 8, 2023, 7:52 PM

#

if you wanna vc

mental carbon Oct 8, 2023, 7:52 PM

#

I am confusued

#

Nah, can't

#

Wife is watching tele

#

#

Primary error

kindred fractal Oct 8, 2023, 7:53 PM

#

isn't that just the version checker?

mental carbon Oct 8, 2023, 7:53 PM

#

No

kindred fractal Oct 8, 2023, 7:54 PM

#

ah yeah

#

apparently it can't read the version from the jar?

mental carbon Oct 8, 2023, 7:55 PM

#

Ja

#

#

It is empty

#

Okey easy fix tomorrow morning 😄

kindred fractal Oct 8, 2023, 7:56 PM

#

hehe good night 😉

mental carbon Oct 8, 2023, 8:33 PM

#

#

#

And world load 😄

#

And I love the mojmaps atruntime

#

Debugging this is amazing

dull bison Oct 8, 2023, 11:59 PM

#

so next up: userdev jar

quiet talon Oct 9, 2023, 12:01 AM

#

eclipse runs still need to be implemented

dull bison Oct 9, 2023, 12:09 AM

#

that can be done after userdev because this is currently blocking the port and eclipse runs is a NG only thing

keen hearth Oct 9, 2023, 4:51 AM

#

mental carbon It actually does

Interesting! These semantics were with the vanilla launcher? Ill have to adjust the FTBApp to do this..

#

Surprised its not an issue tbh, but we have historically not actually updated many dependencies before, especially ones with natives. Likely just manages to work as i collect them outer in i think, don't remember.

wispy zealot Oct 9, 2023, 11:05 AM

#

mental carbon

could the mod list be sorted A-Z by default?

mental carbon Oct 9, 2023, 11:06 AM

#

wispy zealot could the mod list be sorted A-Z by default?

Please use #neoforge-github for that kind of discussions, this thread is scoped to just the porting, not general support or change requests

dull bison Oct 9, 2023, 1:40 PM

#

orion don't forget to just ping me if you need a second pair of eyes

frail oriole Oct 9, 2023, 6:42 PM

#

afternoon orion. looks like you made some solid progress. sorry i was away.

mental carbon Oct 9, 2023, 6:45 PM

#

No problem

#

We figured it out eventually 😄

frail oriole Oct 9, 2023, 6:49 PM

#

are you pushed?

mental carbon Oct 9, 2023, 6:59 PM

#

Yeah currently broken

#

because I am tranferring it to a new device

frail oriole Oct 9, 2023, 6:59 PM

#

Ok

mental carbon Oct 9, 2023, 6:59 PM

#

But I will push a fixed version in a second

mental carbon Oct 9, 2023, 7:04 PM

#

frail oriole are you pushed?

I now pushed, this should create a working installer again

#

But the userdev env is still broken

frail oriole Oct 9, 2023, 7:05 PM

#

Ok. I'll take a look. Gimme a few for commentary

mental carbon Oct 9, 2023, 7:05 PM

#

Take your time

#

A lot is currently hardcoded specifically for 1.20.2

#

I want a working environment for it

#

In which we can work

#

Then I can make a proper DSL which manages the parameterization of the environment better

frail oriole Oct 9, 2023, 7:10 PM

#

of course

#

hmmm

#

still hitting a problem when trying to load into intellij

#

> Task :prepareKotlinBuildScriptModel UP-TO-DATE

FAILURE: Build failed with an exception.

* What went wrong:
java.lang.reflect.InvocationTargetException
Failed to query the value of task ':forge:legacyInstallerJar' property 'installerJson'.
Could not create task ':forge:createLegacyInstallerJson'.
Could not determine the dependencies of null.
Current thread does not hold the state lock for project ':forge'

#

i just nuked all the build and .gradle directories inside kits

mental carbon Oct 9, 2023, 7:15 PM

#

Interesting

#

I just set it up on a clean machine

#

And did not have that error

frail oriole Oct 9, 2023, 7:15 PM

#

hmmm

mental carbon Oct 9, 2023, 7:15 PM

#

I had that once a while ago

#

And it was because some cache was broken

#

In gradle

frail oriole Oct 9, 2023, 7:16 PM

#

hmmm

mental carbon Oct 9, 2023, 7:16 PM

#

Did you also nuke the stuff in the forge subprojects

frail oriole Oct 9, 2023, 7:16 PM

#

yes, everything inside the projects subdirs

mental carbon Oct 9, 2023, 7:16 PM

#

Interesting

#

Can you delete your world ~/.gradle

#

?

frail oriole Oct 9, 2023, 7:17 PM

#

hang on

#

hmmm

#

all the downloads in the world running now

mental carbon Oct 9, 2023, 7:19 PM

#

@fallow sundial When you are around I have a question with respects to GDI, I know GDI generates methods, but IDEA is not seeing them

frail oriole Oct 9, 2023, 7:19 PM

#

kits and NG are still tied at the hip right?

mental carbon Oct 9, 2023, 7:20 PM

#

Currently yes

#

Allthough NG is being published seperatly already

#

But they are tied untill I have both a working userdev

#

And a working installer

frail oriole Oct 9, 2023, 7:20 PM

#

of course

#

no change after nuking .gradle

mental carbon Oct 9, 2023, 7:21 PM

#

Wtf

frail oriole Oct 9, 2023, 7:21 PM

#

1.20.2-ngnext right?

mental carbon Oct 9, 2023, 7:22 PM

#

Yep

frail oriole Oct 9, 2023, 7:22 PM

#

hmmm

mental carbon Oct 9, 2023, 7:22 PM

#

NG7 branch next to it

frail oriole Oct 9, 2023, 7:22 PM

#

yup

mental carbon Oct 9, 2023, 7:22 PM

#

And 1.20.2-ngnext

frail oriole Oct 9, 2023, 7:22 PM

#

i have the FG_7.0 branch of NG

mental carbon Oct 9, 2023, 7:22 PM

#

Yeah

#

I do to

#

On both linux and windows

#

And I don't see that issue

frail oriole Oct 9, 2023, 7:23 PM

#

https://gist.github.com/cpw/69976fb7df1a5888107cc9bf3c061f3b

Gist

gist:69976fb7df1a5888107cc9bf3c061f3b

GitHub Gist: instantly share code, notes, and snippets.

#

stack trace

#

clientExtraConfiguration.getDependencies().getBuildDependencies().getDependencies(null).forEach(task::dependsOn); ???

#

null?

mental carbon Oct 9, 2023, 7:24 PM

#

Yeah that is fine

frail oriole Oct 9, 2023, 7:25 PM

#

it apparently isn't here 😦

mental carbon Oct 9, 2023, 7:26 PM

#

#

Passing null means the root.....

frail oriole Oct 9, 2023, 7:26 PM

#

yeah i see it's nullable

#

is it a race condition?

#

Current thread does not hold the state lock for project ':forge'

mental carbon Oct 9, 2023, 7:27 PM

#

No, it is somehow creating a set of tasks too late

frail oriole Oct 9, 2023, 7:28 PM

#

i have some stuff commented out in my build.gradle files because those tasks were borked the other day (changelog and test client/server)

mental carbon Oct 9, 2023, 7:29 PM

#

Should not matter

frail oriole Oct 9, 2023, 7:31 PM

#

Unable to set prepareKotlinBuildScriptModel sync task. this warning isn't relevant is it?

#

yeah. this is still borked inside intellij for me

#

if i run from command line, no daemon i get a different error

#

Build file '/home/cpw/projects/neoforged/Kits/projects/forge/build.gradle' line: 138

* What went wrong:
A problem occurred evaluating project ':forge'.
> Cannot get property 'sourceSets' on null object

#

        idea {
            primarySourceSet project.sourceSets.test
        }

#

line 138 is the middle line there

#

inside "Test Server"

mental carbon Oct 9, 2023, 7:36 PM

#

Pull

#

I just pushed a change

#

You also have a seriously borked setup

#

Could you reclone?

frail oriole Oct 9, 2023, 7:37 PM

#

happy to. it won't make a difference. i have cleaned everything out.

#

new .gradle etc etc etc

mental carbon Oct 9, 2023, 7:37 PM

#

I have no idea what is up with your seutp

#

Because you seem to be the only one with it

frail oriole Oct 9, 2023, 7:38 PM

#

i think that change fixed it

#

yup.that change fixed it

#

my suspicion is that something was slightly borked and my computer was fast enough to uncover a small race

mental carbon Oct 9, 2023, 7:42 PM

#

Probably

#

Well I removed the violating code

#

Since it is currently not yet needed

frail oriole Oct 9, 2023, 7:43 PM

#

legacyInstallerJar generates an installer right?

#

looks like it

mental carbon Oct 9, 2023, 7:49 PM

#

signInstallerJar

#

Is the ultimate task in that tree

#

Run that

#

It gets you the forge-20.2.1-installer.jar file

frail oriole Oct 9, 2023, 7:49 PM

#

😄

#

looks ok to me

mental carbon Oct 9, 2023, 7:50 PM

#

Nice

#

So it is working for you now

#

Including the installre?

frail oriole Oct 9, 2023, 7:50 PM

#

installed the unsigned jar. which is what we should be doing

#

yes, that was the installer installing into the vanilla launcher

mental carbon Oct 9, 2023, 7:51 PM

#

Nice

#

Yeah the only major difference between the old and new installer files

#

Is that the new one has no hash to validate the one remaining intermediary step that was still being validated

frail oriole Oct 9, 2023, 7:52 PM

#

ok

mental carbon Oct 9, 2023, 7:53 PM

#

I mean, I understand why they are there

#

But given that they were a problem to generate them properly

#

And given that they were only used for that specific subtask....

#

I have removed them for now

frail oriole Oct 9, 2023, 7:55 PM

#

"name": "net.minecraftforge:coremods:5.0.1@jar",

#

interesting - you're adding the file type

mental carbon Oct 9, 2023, 7:55 PM

#

Yep

#

It is standardized code

frail oriole Oct 9, 2023, 7:57 PM

#

you're adding in the parent deps i think

#

"name": "com.google.guava:guava:31.1-jre@jar",

#

for example

#

you're also adding in some transitive deps

#

you don't need full fat antlr4 for example

mental carbon Oct 9, 2023, 7:59 PM

#

Indeed I am

#

Which was already a blessing and a curse at the same time

frail oriole Oct 9, 2023, 7:59 PM

#

?

mental carbon Oct 9, 2023, 8:00 PM

#

It fixed several issues with libraries not properly being loaded

#

But it also triggered an interesting side effect of how to launcher processes those libraries

frail oriole Oct 9, 2023, 8:00 PM

#

there are libraries not properly loading?

mental carbon Oct 9, 2023, 8:01 PM

#

They are now

frail oriole Oct 9, 2023, 8:01 PM

#

i mean, this is how it's worked since 1.13

mental carbon Oct 9, 2023, 8:01 PM

#

Yeah but we changed a lot how those library configs work

frail oriole Oct 9, 2023, 8:01 PM

#

how so?

mental carbon Oct 9, 2023, 8:01 PM

#

Moving stuff around, and they are now explicitly designed to support transitive loading of runtime and none runtime dependencies

frail oriole Oct 9, 2023, 8:02 PM

#

i don't understand

#

something in FML changed? where?

mental carbon Oct 9, 2023, 8:02 PM

#

No

#

In out buildscript for forge

frail oriole Oct 9, 2023, 8:02 PM

#

yes

mental carbon Oct 9, 2023, 8:02 PM

#

The buildscript now properly supports them not being none transitive

frail oriole Oct 9, 2023, 8:03 PM

#

i'm mostly concerned because you're now going to be forcing a lot of people to download existing libraries from our maven rather than mojang's

mental carbon Oct 9, 2023, 8:03 PM

#

No

#

The system first checks if the library can be found on mojangs maven

frail oriole Oct 9, 2023, 8:03 PM

#

      "name": "org.apache.logging.log4j:log4j-core:2.19.0@jar",
      "downloads": {
        "artifact": {
          "sha1": "3b6eeb4de4c49c0fe38a4ee27188ff5fee44d0bb",
          "size": 1864386,
          "url": "https://libraries.minecraft.net/org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar",
          "path": "org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar"
        }
      }
    },

#

?

mental carbon Oct 9, 2023, 8:03 PM

#

And if so generates a url for mojangs maven

frail oriole Oct 9, 2023, 8:03 PM

#

heh

#

    {
      "name": "org.apache.logging.log4j:log4j-api:2.20.0@jar",
      "downloads": {
        "artifact": {
          "sha1": "1fe6082e660daf07c689a89c94dc0f49c26b44bb",
          "size": 313296,
          "url": "https://maven.neoforged.net/releases/org/apache/logging/log4j/log4j-api/2.20.0/log4j-api-2.20.0.jar",
          "path": "org/apache/logging/log4j/log4j-api/2.20.0/log4j-api-2.20.0.jar"
        }
      }
    },

#

why api 20 vs 19 runtime?

mental carbon Oct 9, 2023, 8:04 PM

#

That is still on the chopping block

#

There is probably something in our stack that forces it to be 2.20.0

frail oriole Oct 9, 2023, 8:04 PM

#

was the installer breaking somehow?

#

i don't understand why you're forcing all the parent libs into our version json

#

you say it's borked, but where?

mental carbon Oct 9, 2023, 8:04 PM

#

It is not anymore

#

It was before

#

Can't remember were

frail oriole Oct 9, 2023, 8:05 PM

#

before where?

#

it wasn't borked in 20.1

#

was it?

mental carbon Oct 9, 2023, 8:05 PM

#

No

#

But I mussed have broken something in the port

frail oriole Oct 9, 2023, 8:05 PM

#

k

mental carbon Oct 9, 2023, 8:05 PM

#

That was the fastest way to solve it

frail oriole Oct 9, 2023, 8:05 PM

#

hmmm

#

this needs a revisit

#

if this is the fastest way to get something published so be it

#

but we need to clean this version json up significantly for the longer term

mental carbon Oct 9, 2023, 8:06 PM

#

Yeah for sure

frail oriole Oct 9, 2023, 8:06 PM

#

it shouldn't be duping libraries from the parent config where possible

mental carbon Oct 9, 2023, 8:06 PM

#

To be honest

#

It should

frail oriole Oct 9, 2023, 8:06 PM

#

it shouldn't

mental carbon Oct 9, 2023, 8:06 PM

#

It should do exactly what the dependency that is to be included tells it too

frail oriole Oct 9, 2023, 8:06 PM

#

it shouldn't have transitives in either

mental carbon Oct 9, 2023, 8:07 PM

#

Yes it should

frail oriole Oct 9, 2023, 8:07 PM

#

antlr4 is not needed at runtime

#

only the antlr4-runtime lib

#

for 1 example of several

mental carbon Oct 9, 2023, 8:07 PM

#

Then the lib that includes should be configured as such

frail oriole Oct 9, 2023, 8:08 PM

#

fyi sometimes mojang pushes silent updates to their upstream

#

that's why we should never override

mental carbon Oct 9, 2023, 8:08 PM

#

If it is included that means that the dependency which includes the full antlr is not configured properly

#

And is telling gradle and any of its consumers that it needs the FULL antlr at runtime

frail oriole Oct 9, 2023, 8:09 PM

#

hmmm

#

that's used by access transformers

mental carbon Oct 9, 2023, 8:09 PM

#

Which is why NG7 now includes it at runtime in the version.json

frail oriole Oct 9, 2023, 8:09 PM

#

but it has always just requires the runtime

mental carbon Oct 9, 2023, 8:09 PM

#

Then we need to conigure it as such

frail oriole Oct 9, 2023, 8:10 PM

#

it is? it has been for the past several years

mental carbon Oct 9, 2023, 8:10 PM

#

Because we used the workaround

#

To not have those configurations be transitive

#

And forced every contributor to fully specify all dependencies we need

frail oriole Oct 9, 2023, 8:10 PM

#

implementation('org.antlr:antlr4-runtime:4.9.1')

#

that's all it has

mental carbon Oct 9, 2023, 8:11 PM

#

Yeah and that says: include it in dev and runtime

frail oriole Oct 9, 2023, 8:11 PM

#

there's a separate configuration for antlr

mental carbon Oct 9, 2023, 8:11 PM

#

Hmm

#

Okey

frail oriole Oct 9, 2023, 8:11 PM

#

antlr('org.antlr:antlr4:4.9.1')

mental carbon Oct 9, 2023, 8:11 PM

#

That needs further investigation then

frail oriole Oct 9, 2023, 8:11 PM

#

THAT lib should NOT be required by anything else but AT itself

mental carbon Oct 9, 2023, 8:11 PM

#

Yeah

#

Obviuosly

#

Because it needs to generate the parser etc

frail oriole Oct 9, 2023, 8:11 PM

#

currently it's required by the runtime game

#

because of some sort of weird transitivity you've added

mental carbon Oct 9, 2023, 8:12 PM

#

No it is not weird

#

It is probably somehow wrongly configured in the maven data for that version

#

TLDR: We need to investigate those projects that include those dependencies

#

But including the transitives is the correct thing to do

#

Because it makes use of gradles and mavens native abilities to properly manage the dependency tree

#

And pick the correct version for the dependency

frail oriole Oct 9, 2023, 8:13 PM

#

yes. but it shouldn't be pulling in these deps

mental carbon Oct 9, 2023, 8:13 PM

#

It should not

#

But it is

#

Hence me saying: we need to investigate those projects

#

Which we can do within IDEAs dependency view

#

Or gradles dependency report

#

But it is not a problem for right now

#

Don't get me wrong

#

I understand this is an issue

frail oriole Oct 9, 2023, 8:16 PM

#

yeah, for some reason, it seems that this is a full blown dependency of AT now

mental carbon Oct 9, 2023, 8:16 PM

#

But this is at best an orange issue in the sense that it is something we can investigate later on. But it is not a show stopper for releas

frail oriole Oct 9, 2023, 8:16 PM

#

which is weird AF

#

it's adding about 10 dependencies thru transitivity

#

antlr4 -> antlr something -> ibmicu, etc etc etc

mental carbon Oct 9, 2023, 8:16 PM

#

Yeah

frail oriole Oct 9, 2023, 8:16 PM

#

it's sucking down a fuckton of ancillary gibberish

mental carbon Oct 9, 2023, 8:17 PM

#

I will check lster

#

You can try to figure out what the maven metadata says as to that dependency on the at project

frail oriole Oct 9, 2023, 8:19 PM

#

<dependencies>
<dependency>
<groupId>org.antlr</groupId>
<artifactId>antlr4</artifactId>
<version>4.9.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.antlr</groupId>
<artifactId>antlr4-runtime</artifactId>
<version>4.9.1</version>
<scope>runtime</scope>
</dependency>

#

8.0.4 and 8.0.7 both have it scope compile which is correct

mental carbon Oct 9, 2023, 8:19 PM

#

Interesting it includes the compile scope

#

I will check

mossy bobcat Oct 9, 2023, 8:19 PM

#

frail oriole ``` <dependencies> <dependency> <groupId>org.antlr</groupId> <artifactId>antlr4<...

Hmm, could be it's pulling it from the module?

#

https://maven.neoforged.net/releases/net/minecraftforge/accesstransformers/8.0.7/accesstransformers-8.0.7.module seems to list it as runtime

#

{
  "name": "runtimeElements",
  "attributes": {
    "org.gradle.category": "library",
    "org.gradle.dependency.bundling": "external",
    "org.gradle.jvm.version": 8,
    "org.gradle.libraryelements": "jar",
    "org.gradle.usage": "java-runtime"
  },
  "dependencies": [
    {
      "group": "org.antlr",
      "module": "antlr4-runtime",
      "version": {
        "requires": "4.9.1"
      }
    },
... lots of stuff
    {
      "group": "org.antlr",
      "module": "antlr4",
      "version": {
        "requires": "4.9.1"
      }
    }
  ]
}

frail oriole Oct 9, 2023, 8:20 PM

#

ok. looking at legacy forge, it's scoped correctly - you only get the runtime antlr

mossy bobcat Oct 9, 2023, 8:21 PM

#

Does the system resolve transitive deps from the gradle or maven dependency metadata?

frail oriole Oct 9, 2023, 8:21 PM

#

so this is definitely a change with neogradle

#

good question luke

mossy bobcat Oct 9, 2023, 8:21 PM

#

If it's coming from gradle module info, that's your issue

frail oriole Oct 9, 2023, 8:21 PM

#

legacy almost definitely used the maven data

mossy bobcat Oct 9, 2023, 8:21 PM

#

Because accesstransformer has an incorrect gralde .module file

frail oriole Oct 9, 2023, 8:21 PM

#

but neogradle could well be using the new data

mossy bobcat Oct 9, 2023, 8:21 PM

#

That file declares a runtime dep on the full antlr. Which is wrong

frail oriole Oct 9, 2023, 8:21 PM

#

how do we fix?

mossy bobcat Oct 9, 2023, 8:22 PM

#

Erm, let me poke the build script

#

I'll PR AT with a fix if I can

frail oriole Oct 9, 2023, 8:22 PM

#

k

#

we need to bump the AT lib a bit. there's been 3 versions since the one we're using LOL

mossy bobcat Oct 9, 2023, 8:26 PM

#

Oh wow I need to wait for gradle 7.1 to install...

#

screm gradle caching is dying on me with an unsupported class version error because of how old that gradle is. Lovely...

#

And I don't know where the cache is

#

Anyways, I suspect that the antlr plugin is doing some funky stuff with that antlr configuration, possibly using the old compile configuration? I'm going to see

#

Hey @frail oriole do you mind if I upgrade gradle on AT as well? I don't really want to install java 8 but I'll do it if I have to

dull bison Oct 9, 2023, 8:33 PM

#

Do we already have a fork for AT?

kindred fractal Oct 9, 2023, 8:34 PM

#

https://github.com/neoforged/AccessTransformers

mossy bobcat Oct 9, 2023, 8:36 PM

#

Just installing java 8 for now. Thank goodness for sdkman

frail oriole Oct 9, 2023, 8:36 PM

#

You can upgrade. Bump minor to 1 so 8.1

mental carbon Oct 9, 2023, 8:38 PM

#

I will also force runtime from my end

#

With an attribute

mossy bobcat Oct 9, 2023, 8:45 PM

#

frail oriole You can upgrade. Bump minor to 1 so 8.1

Coolio. Where is the version actually defined?

frail oriole Oct 9, 2023, 8:45 PM

#

Git tag

mossy bobcat Oct 9, 2023, 8:45 PM

#

Ah, so you'd have to do that on merging then

frail oriole Oct 9, 2023, 8:47 PM

#

Yeah

mossy bobcat Oct 9, 2023, 8:48 PM

#

Currently fixing everything that broke on gradle upgrade but this should be a fairly simple fix I think

#

Should I switch stuff to point at the neoforged maven while I'm at it?

dull bison Oct 9, 2023, 8:49 PM

#

Probably and also change the group to net.neoforged

mossy bobcat Oct 9, 2023, 8:50 PM

#

Publishing group not package name for now?

#

(I'll leave the package bit to you all)

mental carbon Oct 9, 2023, 8:51 PM

#

I added some code to NG7

#

To enforce runtime dependencies

#

Lets see if this works

dull bison Oct 9, 2023, 8:52 PM

#

mossy bobcat (I'll leave the package bit to you all)

Group and package should happen at the same time

mossy bobcat Oct 9, 2023, 8:52 PM

#

Oh screm there's so many build script things I'd want to clean up here. Build timestampts to make the jar... gah

mossy bobcat Oct 9, 2023, 8:53 PM

#

dull bison Group and package should happen at the same time

I can make that change too now if you'd like, unless you'd rather that happen later in which case I'll just do the gradle upgrade and dependency fix @frail oriole?

dim sonnet Oct 9, 2023, 8:53 PM

#

you might wanna just base it off of my gradle pr for the upstream at repo

frail oriole Oct 9, 2023, 8:53 PM

#

doing the package has impacts

mossy bobcat Oct 9, 2023, 8:54 PM

#

I'm going to leave package and maven group untouched for now

#

because yeah, that has other impacts

#

So for now, just fixing dependency stuff and maven metadata

mossy bobcat Oct 9, 2023, 8:56 PM

#

dim sonnet you might wanna just base it off of my gradle pr for the upstream at repo

Not sure I can find that PR - it's not hard to do manually though

#

Leaving the implementation timestamp stuff for the time being - @stray scroll probably worth shoving something in gradleutils to get the time of the last commit, to use instead of timestamps of build time, if that's not already a thing

dim sonnet Oct 9, 2023, 9:00 PM

#

ah fun, it's the one repo I didn't do harold

mossy bobcat Oct 9, 2023, 9:01 PM

#

screm what caused this issue... https://github.com/gradle/gradle/blob/049a3c685742eb6151d2017b5e6d41752e7b7f79/platforms/software/antlr/src/main/java/org/gradle/api/plugins/antlr/AntlrPlugin.java#L58-L64

frail oriole Oct 9, 2023, 9:03 PM

#

the gradle antlr support is ancient

mental carbon Oct 9, 2023, 9:03 PM

#

Yeah that will fucking do it

frail oriole Oct 9, 2023, 9:03 PM

#

antlr2.7 is from about 1999 or so?

mossy bobcat Oct 9, 2023, 9:03 PM

#

Also these two dependencies:```
implementation('org.apache.logging.log4j:log4j-api:2.11.+')
implementation('org.apache.logging.log4j:log4j-core:2.11.+')

Can we not use `+` there for something we're publishing?

#

Gradle shouts at you about it, for good reason

frail oriole Oct 9, 2023, 9:03 PM

#

agree. i have been trying to move away from the +

mossy bobcat Oct 9, 2023, 9:03 PM

#

Maven publication 'mavenJava' pom metadata warnings (silence with 'suppressPomMetadataWarningsFor(variant)'):
  - Variant runtimeElements:
      -  contains dependencies that will produce a pom file that cannot be consumed by a Maven client.
          - org.apache.logging.log4j:log4j-api:2.11.+ declared with a Maven incompatible version notation
          - org.apache.logging.log4j:log4j-core:2.11.+ declared with a Maven incompatible version notation

frail oriole Oct 9, 2023, 9:03 PM

#

i was bad

mossy bobcat Oct 9, 2023, 9:03 PM

#

Alright, I'll fix those

mental carbon Oct 9, 2023, 9:03 PM

#

To be fair

frail oriole Oct 9, 2023, 9:03 PM

#

also 2.20 across the board

mental carbon Oct 9, 2023, 9:03 PM

#

It does not matter for us

#

It only matters if you use a native maven cliënt

#

If you use Gradle it works

#

Even if it is in the pom

mental carbon Oct 9, 2023, 9:05 PM

#

mossy bobcat Also these two dependencies:``` implementation('org.apache.logging.log4j:log4j-a...

Just make them maven compatible ranges

#

So [2.11,2.12)

#

Or what ever cpw wants it to be

mossy bobcat Oct 9, 2023, 9:07 PM

#

https://github.com/neoforged/AccessTransformers/pull/1

frail oriole Oct 9, 2023, 9:07 PM

#

just fix to a single version. 2.20.1 or so

mossy bobcat Oct 9, 2023, 9:07 PM

#

mental carbon Just make them maven compatible ranges

For published versoin deps, it should always be pinned to a single version

#

But yeah, PR is open, let me know what I broke

#

This bit is what does the magic:```gradle
configurations {
api {
extendsFrom = extendsFrom.findAll { it != configurations.antlr }
}
compileOnly.extendsFrom antlr
}

#

And yeah there's no way around that because the gradle plugin is absolutely ancient

mental carbon Oct 9, 2023, 9:10 PM

#

It is stupid that we need to do thos

#

But Imho we should indeed be publishing the correct data

#

General question: Do we need antler for this?

mossy bobcat Oct 9, 2023, 9:10 PM

#

Yeah, publishing bad data isn't fun

mental carbon Oct 9, 2023, 9:11 PM

#

mossy bobcat Yeah, publishing bad data isn't fun

Finding this kind of stuff is one of the major reasons I am not making such excuses about "none-transitive" configurations anymore

#

Only where they make sense

mossy bobcat Oct 9, 2023, 9:13 PM

#

mental carbon Finding this kind of stuff is one of the major reasons I am not making such excu...

Hey you know what's worse? The AT fatjar beforehand was, like, way bigger than it needed to be because it had the full antlr fat jar in it

frail oriole Oct 9, 2023, 9:14 PM

#

antlr is used by AT yes

mossy bobcat Oct 9, 2023, 9:14 PM

#

No the fatjar had the whole antlr, not just runtime

#

Because it was listed as a runtime dep

#

Now it only has runtime and the deps of runtime

frail oriole Oct 9, 2023, 9:14 PM

#

yeah i get that

mossy bobcat Oct 9, 2023, 9:15 PM

#

Ah, that was in response to #1136320550168436798 message

frail oriole Oct 9, 2023, 9:16 PM

#

yes

mossy bobcat Oct 9, 2023, 9:16 PM

#

Anyways I'm going to work on other stuff so ping me if you need anything

frail oriole Oct 9, 2023, 9:17 PM

#

thanks

frail oriole Oct 9, 2023, 9:59 PM

#

interesting. we don't have teamcity for AT heh

#

gah. it's borked 😦

#

so we can't build new AT right now

#

hmmm

#

looks like there's something wrong with the teamcity config 😦

#

i'll try and dig into it this evening.

stray scroll Oct 10, 2023, 1:55 AM

#

mossy bobcat Leaving the implementation timestamp stuff for the time being - <@60705847270965...

will try to remember when I've next mustered up the will to fight GradleUtils
if you can, please open up an issue on the repo so it doesn't get forgotten

mental carbon Oct 10, 2023, 11:16 AM

#

@fallow sundial Ping me when you are round

#

I have some questions with respect to GDI generated/adapted classes

fallow sundial Oct 10, 2023, 11:20 AM

#

mental carbon <@561254664750891009> Ping me when you are round

hi

mental carbon Oct 10, 2023, 11:21 AM

#

So I have 1 question: When I use @DSLProperty, that adds new methods to the class file

#

I can see those methods in .class-file in the build.gradle

#

Yet the IDE seems to be completly unaware of those existing

fallow sundial Oct 10, 2023, 11:21 AM

#

when is it unaware

mental carbon Oct 10, 2023, 11:21 AM

#

But only if it is part of the same gradle project

#

Example

#

I am currently coding runTypes for the userdev artifact

fallow sundial Oct 10, 2023, 11:22 AM

#

as in, in the build.gradle using the plugin?

mental carbon Oct 10, 2023, 11:22 AM

#

That has methods to add arguments etc

#

The type RunType is part of dsl-common

#

Yet in the sibling project platform

#

Which has a dependency on dsl-common

#

I don't see those added methods

mossy bobcat Oct 10, 2023, 11:22 AM

#

stray scroll will try to remember when I've next mustered up the will to fight GradleUtils if...

https://github.com/neoforged/GradleUtils/issues/3

fallow sundial Oct 10, 2023, 11:24 AM

#

can you show some screenshots

mental carbon Oct 10, 2023, 11:24 AM

#

#

#

#

The IDE does not see them

#

But when I compile them

#

With gradle

#

Then it works

#

Like a gradle refresh of Kits

#

That compiles NG7

#

And then it just works

#

No problem

#

But the IDE refuses to see the methods

fallow sundial Oct 10, 2023, 11:27 AM

#

mental carbon

yeah the ide will only see the methods when it's using the binary

#

so when it's used in a gradle buildscript context

#

otherwise it uses the source

#

that code compiles fine because javac uses the binary

mental carbon Oct 10, 2023, 11:28 AM

#

Ah okey

#

Yeah

#

So impossible to do

#

While being in the same project

#

That is a massive bummer

fallow sundial Oct 10, 2023, 11:29 AM

#

I mean there's always the option of an intellij plugin

#

as a matter of fact I made a plugin whose sole purpose is ide discovery of transformer added methods

#

albeit cursed due to approach taken

mental carbon Oct 10, 2023, 11:30 AM

#

I saw that

#

But that does not work sadly

#

EnhancedGroovy right?

fallow sundial Oct 10, 2023, 11:35 AM

#

yeah. it's a cursed plugin due to the way it's made to work for everything. but also I could make a separate plugin for just gdi that would work normally and reliably

mental carbon Oct 10, 2023, 11:36 AM

#

It is just a problem during NG7 Development

kindred fractal Oct 10, 2023, 11:38 AM

#

what is GDI?

mental carbon Oct 10, 2023, 11:38 AM

#

Groovy DSL Improver

kindred fractal Oct 10, 2023, 11:38 AM

#

asm-generated methods?

mental carbon Oct 10, 2023, 11:39 AM

#

It allows me to say @DSLProperty on a abstract Property<String> getSomething()

#

And it will generate methods like

#

something(final String something) { getSomething().set(something); }

kindred fractal Oct 10, 2023, 11:39 AM

#

doesn't gradle already do this for properties?

mental carbon Oct 10, 2023, 11:39 AM

#

So that people using NG7 in groovy, kotlin or java have a nice experience

#

No it does not

kindred fractal Oct 10, 2023, 11:42 AM

#

mental carbon Oct 10, 2023, 11:42 AM

#

That is the = way which exists

#

What this adds is a setting method that allows you to do

#

greeting.message 'Hi from Gradle'

#

But also having the same signature for things like list properties

#

Additionally it generates the correct overloads for closures etc

kindred fractal Oct 10, 2023, 11:43 AM

#

hmmm ok

#

seems unnecessary but I don't know shit about gradle so ignore me

mossy bobcat Oct 10, 2023, 11:44 AM

#

The = way has bad IDE support

mental carbon Oct 10, 2023, 11:44 AM

#

It was a compromise

dull bison Oct 10, 2023, 11:44 AM

#

the = thing also only works in build.gradle through magic

mental carbon Oct 10, 2023, 11:44 AM

#

Yeah

mossy bobcat Oct 10, 2023, 11:44 AM

#

It yells at you because it thinks yo're assigning something to a field of the wrong type

#

The only approach that has good IDE support, without this, is using .set

mental carbon Oct 10, 2023, 11:45 AM

#

mossy bobcat The only approach that has good IDE support, without this, is using `.set`

Correct, and GDI generates simple setter calling methods

dull bison Oct 10, 2023, 11:47 AM

#

is GDI a groovy AP or magic

mental carbon Oct 10, 2023, 11:47 AM

#

Groovy AST Transformer

dim sonnet Oct 10, 2023, 11:47 AM

#

It's a Groovy AST transformer (aka compiler plugin)

dull bison Oct 10, 2023, 11:48 AM

#

soo, magic ok

dim sonnet Oct 10, 2023, 11:49 AM

#

Kinda, but you can see the compiled output so it's easy to figure out what it does. For the most part it takes a gradle Property<> field and makes a setter method for it so that the = works in Groovy dsl with ide support

mossy bobcat Oct 10, 2023, 11:49 AM

#

mental carbon Correct, and GDI generates simple setter calling methods

Yeah, that's a good idea. Is the issue that you want to use those magic setters within the environment of the same project they're set in? No way around that lack of IDE support unfortunately

mental carbon Oct 10, 2023, 11:49 AM

#

mossy bobcat Yeah, that's a good idea. Is the issue that you want to use those magic setters ...

Yeah....

mossy bobcat Oct 10, 2023, 11:49 AM

#

Hey, at least it'll look nice for dependencies

#

If you really care you can always use .set instead

dull bison Oct 10, 2023, 11:50 AM

#

dim sonnet Kinda, but you can see the compiled output so it's easy to figure out what it do...

I have seen compiled and decompiled groovy eww

dim sonnet Oct 10, 2023, 11:50 AM

#

@CompileStatic for this kind of basic stuff actually looks alright

#

It looks pretty similar to if you manually wrote the setter method yourself

dull bison Oct 10, 2023, 11:51 AM

#

dim sonnet @CompileStatic for this kind of basic stuff actually looks alright

if it generates some of that array bs in the method body then no

dim sonnet Oct 10, 2023, 11:51 AM

#

Nope, it shouldn't do for this

mossy bobcat Oct 10, 2023, 11:51 AM

#

CompileStatic is "don't do dynamic stuff"

#

So all the weirdness is likely to be gone

#

...well except the occasionaly bit of funkiness to pass stuff into closures or whatnot

#

Because closures can mutate locals

dim sonnet Oct 10, 2023, 11:52 AM

#

Well technically you can still do some dynamic stuff with compilestatic, just limited and without some of the syntax sugar for it

mossy bobcat Oct 10, 2023, 11:52 AM

#

Yeah, you have to manually poke metaclasses generally

#

Or do the unsafe casts yourself

#

harold I did build a tool that results in statically compiled code that doesn't decompile prettily though

mental carbon Oct 10, 2023, 3:13 PM

#

Okey progress: userdev Json is fully generating. I am nearly happy with it and I should be able to produce a working userdev jar later today

fossil ore Oct 10, 2023, 3:14 PM

#

Is there a working prealpha build for neoforge 20.2.1 so that I can start porting over my mods?

#

Doesn't have to be stable or fully functional

regal zenith Oct 10, 2023, 3:15 PM

#

fossil ore Is there a working prealpha build for neoforge 20.2.1 so that I can start portin...

No

fossil ore Oct 10, 2023, 3:18 PM

#

I saw someone mention a test installer for 20.2.1, though it was broken.

kindred fractal Oct 10, 2023, 3:23 PM

#

we'll publish an announcement when the first version is available

dull bison Oct 10, 2023, 6:09 PM

#

fossil ore I saw someone mention a test installer for 20.2.1, though it was broken.

that was just us testing the installer we currently still don't have the ability to setup a dev env for mods

stray scroll Oct 10, 2023, 6:12 PM

#

~~some of us don't even have the ability to setup the dev env for NF~~

dull bison Oct 10, 2023, 6:15 PM

#

skill issue

stray scroll Oct 10, 2023, 6:23 PM

#

i prefer to call it a GradleUtils issue

#

which reminds me, I need to configuration-cache-proof my own versioning plugin

#

thankfully, I built it in a way that's inherently easy to refactor kek

dull bison Oct 10, 2023, 6:28 PM

#

stray scroll i prefer to call it a GradleUtils issue

just comment out the changelog stuff in NG

#

then it works

#

or you can just use the snapshot version from the maven

mental carbon Oct 10, 2023, 7:44 PM

#

Okey: userdev is generating. Now need to implement publishing and adapt the NG7 userdev module to read the new format 😄

mental carbon Oct 10, 2023, 9:43 PM

#

Okey update for today and plan for tomorrow:
today:

Finished userdev profile
Finished userdev jar
Finished new userdev schema
Removed SAS
Reimplemented single SAS use as Patch
Finished implementing new userdev schema consumer

tomorrow:

Create new MDK
Test new MDK and Userdev modules
Create Parchment PR
Create publishing code

#

Remaining fixes for NG7:

Implement Eclipse support
Fix Multiple AT files with the same name
Multimod support in the same project (currently NG7 treats one project it is applied in as one mod, so use multi project setups if you have to)

tranquil salmon Oct 11, 2023, 5:19 AM

#

A new brigadier pr got created last week and merged 2 days ago: https://github.com/Mojang/brigadier/pull/140

stray scroll Oct 11, 2023, 5:22 AM

#

~~/return run, here we go~~

tranquil salmon Oct 11, 2023, 5:23 AM

#

The 2 commands that got added to the previous snapshot series and removed because they were too broken

#

The bug reports haven't been marked as fixed yet though

dull bison Oct 11, 2023, 5:30 AM

#

for that the will need to bump brigadier today and add them back

stray scroll Oct 11, 2023, 5:44 AM

#

or maybe next week thinkies

dull bison Oct 11, 2023, 7:20 AM

#

orion the userdev jar is a bit broken ... the userdev plugin currently expects the inject directory to always be present

mental carbon Oct 11, 2023, 7:21 AM

#

Ah I missed that inject shit

#

Okey I need to check that :d

dull bison Oct 11, 2023, 8:03 AM

#

I fixed it

#

(I think)

#

I'll have to send you the patch since I don't have push access to the FG_7.0 branch

stray scroll Oct 11, 2023, 8:14 AM

#

~~do you want push access /jk~~

stray scroll Oct 11, 2023, 8:54 AM

#

@tranquil salmon oh lawd it comin https://bugs.mojang.com/browse/MC-264699

#

I guess schurli was right kek

tranquil salmon Oct 11, 2023, 8:56 AM

#

7 bug reports marked as fixed within a minute of each other

arctic sphinx Oct 11, 2023, 8:56 AM

#

https://tenor.com/view/its-coming-its-gonna-happen-its-happening-sean-harris-solomon-lane-gif-11866210

Tenor

tranquil salmon Oct 11, 2023, 9:06 AM

#

I wonder what changes they will make to block_types and how they will use the ContextChain

dull bison Oct 11, 2023, 9:28 AM

#

screm setting the group in the allprojects block in Kits crashes the neoform setup

stray scroll Oct 11, 2023, 9:28 AM

#

kekw

dull bison Oct 11, 2023, 9:32 AM

#

dull bison <:screm:980923567833219093> setting the group in the allprojects block in Kits c...

@mental carbon this is very not good could you put that on your list for today (because setting the group should fix the sources location in the userdev json)

mental carbon Oct 11, 2023, 9:33 AM

#

dull bison <:screm:980923567833219093> setting the group in the allprojects block in Kits c...

What?

#

That should not happen

#

Logs please

dull bison Oct 11, 2023, 9:36 AM

#

📎 ide_sync.log

mental carbon Oct 11, 2023, 9:37 AM

#

Wtf

#

Okey

#

Unsure what that is all about

#

Add a evaluationDependsOn(':') to the neoform script and try again

#

Might be a problem with evaluation order and processing of the default java configuration options when the group changes later on

dull bison Oct 11, 2023, 9:39 AM

#

reproducable by adding group 'net.neoforged' on a new line after the version in the root build.gradle

dull bison Oct 11, 2023, 9:39 AM

#

mental carbon Add a evaluationDependsOn(':') to the neoform script and try again

this in fact does nothing

mental carbon Oct 11, 2023, 9:40 AM

#

Hmm

stray scroll Oct 11, 2023, 9:45 AM

#

just to confirm, you have pulled the latest commits for Kits and NG? thinkies

dull bison Oct 11, 2023, 9:46 AM

#

yes

mental carbon Oct 11, 2023, 9:46 AM

#

Can you push schurli?

#

@dull bison

dull bison Oct 11, 2023, 9:50 AM

#

you mean NG or kits?

mental carbon Oct 11, 2023, 9:50 AM

#

Both please

#

Can you push to NG7?

#

Or not

dull bison Oct 11, 2023, 9:51 AM

#

nope

#

but you have the patch

mental carbon Oct 11, 2023, 9:51 AM

#

Give me a second

#

Push

#

You have permissions now

stray scroll Oct 11, 2023, 9:52 AM

#

PUSH PUSH PUSH

dull bison Oct 11, 2023, 9:53 AM

#

ng7 pushed

mental carbon Oct 11, 2023, 9:53 AM

#

I need kits as well

dull bison Oct 11, 2023, 9:55 AM

#

pushed

stray scroll Oct 11, 2023, 10:00 AM

#

hey Orion, have you checked your GPG setup since I last pinged you about that

mental carbon Oct 11, 2023, 10:00 AM

#

stray scroll hey Orion, have you checked your GPG setup since I last pinged you about that

Yeah

#

Had not reuploaded my extended key to github

#

The key it self was fine

#

You can check again

#

The commits should be properly signed now

stray scroll Oct 11, 2023, 10:01 AM

#

yep 👍

#

I get a Cannot get property 'sourceSets' on null object error on the forge subproject evaluation when trying to do a simple ./gradlew

tranquil salmon Oct 11, 2023, 10:05 AM

#

stray scroll I get a `Cannot get property 'sourceSets' on null object` error on the `forge` s...

I get that as well

#

\NeoForge\projects\forge\build.gradle:138

stray scroll Oct 11, 2023, 10:08 AM

#

yep, same line

mental carbon Oct 11, 2023, 10:25 AM

#

Interesting

dull bison Oct 11, 2023, 10:25 AM

#

I get the same from the console

mental carbon Oct 11, 2023, 10:28 AM

#

I now too

#

Intersting

stray scroll Oct 11, 2023, 10:28 AM

#

i

#

interesting

mental carbon Oct 11, 2023, 11:48 AM

#

It is a self reference I think

#

So the error with the group @dull bison is because it is a self reference!

#

net.neoforged:neoforge

#

Is the same coordinate!

dull bison Oct 11, 2023, 11:50 AM

#

then we need to rename the subproject

mental carbon Oct 11, 2023, 11:50 AM

#

Already on it

mental carbon Oct 11, 2023, 12:01 PM

#

stray scroll I get a `Cannot get property 'sourceSets' on null object` error on the `forge` s...

Figured out the problem

stray scroll Oct 11, 2023, 12:13 PM

#

i await the commit thinkies

dull bison Oct 11, 2023, 12:25 PM

#

can you push those fixes before you start the stuff that takes longer

mental carbon Oct 11, 2023, 12:28 PM

#

Yeah if I can fix it

#

I know the cause

#

Just not the fix

#

I thought I knew the fix

#

But that did not work

stray scroll Oct 11, 2023, 12:28 PM

#

~~have you rubberducked it out yet~~

mental carbon Oct 11, 2023, 12:29 PM

#

Already in voice chat

#

Making a cup of tea

#

If anybody wants to join in :d

stray scroll Oct 11, 2023, 1:39 PM

#

someone remind me to poke at that publishing pom and do a bit of... modification thinkies

#

or, to quote the publishing block, "modifactions"

kindred fractal Oct 11, 2023, 2:11 PM

#

was any change made to FML for 20.2?

dull bison Oct 11, 2023, 2:25 PM

#

orion I think we can get away without caving to create a custom component if we remove the default jar from the configuration

stray scroll Oct 11, 2023, 2:50 PM

#

👀 what is this talk of a custom component

dull bison Oct 11, 2023, 2:50 PM

#

nevermind that breaks in a different spot

dull bison Oct 11, 2023, 2:52 PM

#

stray scroll 👀 what is this talk of a custom component

we need to somehow exclude the default jar from publishing

mental carbon Oct 11, 2023, 3:07 PM

#

We can try the global archives block first

#

But that is difficult

mental carbon Oct 11, 2023, 3:08 PM

#

stray scroll or, to quote the publishing block, "modifactions"

What changes do you want?

mossy bobcat Oct 11, 2023, 3:11 PM

#

dull bison we need to somehow exclude the default jar from publishing

Idea: dummy subproject that inherits only the jars you want to publish to its component, and then have that handle publishing

stray scroll Oct 11, 2023, 3:11 PM

#

some minor stuff
changling references of NeoForged to neoforged (matching the actual capitalization of the GH org)
changing the URL (beside the description) to https://neoforged.net
changing the description to something like "A free, open-source, community-oriented modding API for Minecraft" or something similar

arctic sphinx Oct 11, 2023, 3:11 PM

#

<@&1067092163520909374> 23w41a
https://www.minecraft.net/en-us/article/minecraft-snapshot-23w41a
https://mdcfe.dev/mc-changes?ver=23w41a

stray scroll Oct 11, 2023, 3:12 PM

#

@tranquil salmon return run's back

stray scroll Oct 11, 2023, 3:13 PM

#

stray scroll some minor stuff changling references of `NeoForged` to `neoforged` (matching th...

also changing the linked license file to point to the 1.20.x branch

jagged agate Oct 11, 2023, 3:13 PM

#

“Decorated Pots can now store items, and can be smashed by projectiles”

mossy bobcat Oct 11, 2023, 3:13 PM

#

Should someone make a new thread for 20.3 so that discussions of new features don't overlap with the porting effort? Or does it not matter?

jagged agate Oct 11, 2023, 3:13 PM

#

It’s now a storage container?

stray scroll Oct 11, 2023, 3:13 PM

#

by the name of this thread, technically such discussion would fall into here kek

lethal bane Oct 11, 2023, 3:15 PM

#

jagged agate It’s now a storage container?

yes, but a funny one kek

arctic sphinx Oct 11, 2023, 3:16 PM

#

concern they removed Locale.ROOT usage in ChatFormatting

kindred fractal Oct 11, 2023, 3:17 PM

#

jagged agate It’s now a storage container?

transfer API update time again? ...

dull bison Oct 11, 2023, 3:20 PM

#

mossy bobcat Idea: dummy subproject that inherits only the jars you want to publish to its co...

too hacky ... I found a way to remove the default stuff but now I need to somehow add the stuff we need to have it not break

fallow sundial Oct 11, 2023, 3:22 PM

#

they're definitely working towards increasing reach

stray scroll Oct 11, 2023, 3:25 PM

#

shadows will be happy, I'm sure

lethal bane Oct 11, 2023, 3:26 PM

#

fallow sundial they're definitely working towards increasing reach

thinkies TIL you have increased range in creative

arctic sphinx Oct 11, 2023, 3:27 PM

#

I'm sure the PvP community are going to be "happy" as well harold

muted hemlock Oct 11, 2023, 3:27 PM

#

but does Player.getPickRange just have the same bool ? 5 : 4.5 check thinkies

arctic sphinx Oct 11, 2023, 3:27 PM

#

Yes

kindred fjord Oct 11, 2023, 3:28 PM

#

Oh dear why is it static now

jagged agate Oct 11, 2023, 3:28 PM

#

Shadow will not be happy lol

mossy bobcat Oct 11, 2023, 3:28 PM

#

dull bison too hacky ... I found a way to remove the default stuff but now I need to someho...

Where does removing stuff break stuff?

arctic sphinx Oct 11, 2023, 3:28 PM

#

kindred fjord Oh dear why is it static now

It's collating all the places where they do the check into one central place

#

Although the choice of static is a bit weird

jagged agate Oct 11, 2023, 3:28 PM

#

It doesn’t have player context anymore

kindred fjord Oct 11, 2023, 3:28 PM

#

Yeah, I specifically mean the static part

dull bison Oct 11, 2023, 3:29 PM

#

mossy bobcat Where does removing stuff break stuff?

because it expects it to not be empty

mossy bobcat Oct 11, 2023, 3:30 PM

#

dull bison because it expects it to not be empty

Hmm. I'm out of ideas then without looking at the build script

fallow sundial Oct 11, 2023, 3:31 PM

#

well no further block types work abolbsad

mossy bobcat Oct 11, 2023, 3:33 PM

#

Not yet! We're only a few snapshots in

dull bison Oct 11, 2023, 3:34 PM

#

fallow sundial well no further block types work <a:abolbsad:970031332065435739>

not even block properties codec?

stray scroll Oct 11, 2023, 3:35 PM

#

doing a setup of the privat erepo anew, and oh lawd the decompiles are kicking in

dull bison Oct 11, 2023, 3:35 PM

#

stray scroll doing a setup of the privat erepo anew, and oh lawd the decompiles are kicking i...

in parallel

fallow sundial Oct 11, 2023, 3:36 PM

#

dull bison not even block properties codec?

no

#

it's still a unit(of())

dull bison Oct 11, 2023, 3:36 PM

#

mojang has a feedback discord now https://discord.gg/MXxTqXnuD5

stray scroll Oct 11, 2023, 3:37 PM

#

yeah

#

OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x000000079e600000, 656408576, 0) failed; error='The paging file is too small for this operation to complete' (DOS error/errno=1455)

this ain't a good sign

jagged agate Oct 11, 2023, 3:37 PM

#

When the Mojang feedback site is so bad that even Mojang is replacing it with discord lol

feral moat Oct 11, 2023, 3:37 PM

#

stray scroll ``` OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x000000079e600000...

You broke it

stray scroll Oct 11, 2023, 3:40 PM

#

i do hope this is just first-time jitters, and not representative of every setup cycle

dull bison Oct 11, 2023, 3:41 PM

#

@mental carbon we can skip the default variants with ((AdhocComponentWithVariants) components.java).withVariantsFromConfiguration for each of the configurations that are in there (apiElements, runtimeElements, sourcesElements) and then add our own configuration to it with ((AdhocComponentWithVariants) components.java).addVariantsFromConfiguration

stray scroll Oct 11, 2023, 3:41 PM

#

otherwise I might have to short-term discontinue working on NeoForge itself kekw

mental carbon Oct 11, 2023, 3:42 PM

#

stray scroll ``` OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x000000079e600000...

Wtf?

#

you are cursed

dull bison Oct 11, 2023, 3:43 PM

#

stray scroll i do hope this is just first-time jitters, and not representative of every setup...

you can do one setup after the other you don't need to do it on the root project

stray scroll Oct 11, 2023, 3:46 PM

#

I have only 8GB of memory -- technically 7GB because of GPU-reserved space
which is likely half of what most devs here have kek

#

sounds like I'll probably have to make a setup script which sets up each project individually serially

dull bison Oct 11, 2023, 3:48 PM

#

stray scroll I have only 8GB of memory -- technically 7GB because of GPU-reserved space whic...

half? I have 12GB because 20GB are always used by other programs kek

stray scroll Oct 11, 2023, 3:48 PM

#

assuming that 16GB is the likely average

#

which I may be outdated on

#

mmmm, --priority low

mental carbon Oct 11, 2023, 3:52 PM

#

stray scroll sounds like I'll probably have to make a setup script which sets up each project...

Disable the build cache

#

And run :forge:setup

#

You do not need the other projects

stray scroll Oct 11, 2023, 3:52 PM

#

...oh

mental carbon Oct 11, 2023, 3:52 PM

#

They are just for show

#

And display

#

Ng7 does the rest in house

stray scroll Oct 11, 2023, 3:52 PM

#

should those tasks be disabled then?

mental carbon Oct 11, 2023, 3:53 PM

#

No

#

Normal systems should run them so that a reference is available

stray scroll Oct 11, 2023, 3:53 PM

#

"normal systems"...?

mental carbon Oct 11, 2023, 3:53 PM

#

Once with more then 2GB of ram available after everything

rich void Oct 11, 2023, 3:54 PM

#

arctic sphinx <@&1067092163520909374> 23w41a <https://www.minecraft.net/en-us/article/minecraf...

Minecraft is zelda now

stray scroll Oct 11, 2023, 3:55 PM

#

so base and clean are purely for reference?

#1.20.2