when you do a potion that uses NBT, you need to force the NBT, it is ignored by default
for instance:
event.shapeless('3x legendarysurvivaloverhaul:warm_string', [
Item.of('minecraft:potion', '{Potion:"legendarysurvivaloverhaul:heat_resistance"}').weakNBT(),
'3x minecraft:string'
])