How could I make this code more efficient? | latcord | Page 1

coarse flame Sep 22, 2024, 1:01 AM

#

I've made a script to change the ore processing recipes in my pack, but I feel like I've written too much code, as this took a lot of copy and pasting with switching minor details. Script attached in next message.

torn forumBOT Sep 22, 2024, 1:01 AM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

coarse flame Sep 22, 2024, 1:01 AM

#

📎 message.txt

small pewterBOT Sep 22, 2024, 1:01 AM

#

Paste version of message.txt from @coarse flame

plain reef Sep 22, 2024, 1:15 AM

#

for loops

coarse flame Sep 22, 2024, 1:17 AM

#

how to do that 🤔

#

wait lemme read the documentation on this one...

#

Huh, so loops in this are kinda similar to functions in Python? I'm learning that rn and this kinda reminds me of that

plain reef Sep 22, 2024, 1:26 AM

#

A for loop is a programming construct that executes a block of code repeatedly until a condition is met. They are used to iterate over a sequence, such as a list, array, or collection, and perform a certain action a set number of times.

coarse flame Sep 22, 2024, 1:26 AM

#

ty for pointing me in the right direction

coarse flame Sep 22, 2024, 2:00 AM

#

hm, this doesn't seem to be working

ServerEvents.recipes(event => {
    let oreCrushing = (output, crushedInput) => {
        event.recipes.create.crushing([Item.of('create:experience_nugget').withChance(0.75), Item.of(output * 3)], crushedInput)
    }

    oreCrushing('create:crushed_raw_copper', '#forge:ores/copper')
})```

#

it seems like it doesn't like it when I try to make multiple outputs in the helper function

plain reef Sep 22, 2024, 2:12 AM

#

you're trying to multiply a string by tree, not setting the output to tree

#

It should be something like this iirc

Item.of(output, 3)

coarse flame Sep 22, 2024, 2:13 AM

#

OHH okay ty, I'll try that when I get back

#

that makes sense

coarse flame Sep 22, 2024, 2:48 AM

#

figured this out, tysm !

small pewterBOT Sep 22, 2024, 2:48 AM

#

Please close your ticket (with </ticket close:1054771505520717835> or the button atop this thread) once you resolved your issue! This also helps others that would like to help out, as they don't have to look into this thread to check if it has been resolved by now.

Do you have any other questions regarding your issue? Feel free to ask!
Note: You should generally create a new post for unrelated issues.

#How could I make this code more efficient?