Does "harmful()" not work on 1.20+? | latcord | Page 1

gilded vector Nov 17, 2023, 2:32 PM

#

I'm creating a harmful effect for a custom item when rightclicked; the effect is applied when the player right clicks it, but even after i set it to .harmful() it doesn't damage the player.

I'm aware the DamageSource class changed and it's now net.minecraft.world.damagesource.DamageSources;
should i also use net.minecraft.world.damagesource.DamageSource to apply it to the entity so it actually does harm the player/entity? That class seem to hold the entity data while the other just contains the list of sources.

📎 effect_registry.js

neat viperBOT Nov 17, 2023, 2:32 PM

#

Paste version of effect_registry.js from @gilded vector

humble larkBOT Nov 17, 2023, 2:32 PM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

gleaming breach Nov 17, 2023, 2:34 PM

#

Is there anything in the logs?

gilded vector Nov 17, 2023, 2:36 PM

#

nothing related to the effect/item from what i could see

📎 server.log 📎 startup.log

neat viperBOT Nov 17, 2023, 2:36 PM

#

Paste version of server.log, startup.log from @gilded vector

gilded vector Nov 17, 2023, 2:37 PM

#

the class was loaded correctly on startup and the only server "errors" are a couple of recipes I forgot to comment xD

tame birch Nov 17, 2023, 2:40 PM

#

IIRC harmful/beneficial is just a category, isn't?

gleaming breach Nov 17, 2023, 2:41 PM

#

Yeah, i would have thought that aswell

#

So there needs to be an Error in Our damage function

tame birch Nov 17, 2023, 2:42 PM

#

also you don't need to load damage source, you can just new DamageSource
it is available

#

https://github1s.com/KubeJS-Mods/KubeJS/blob/2002/common/src/main/java/dev/latvian/mods/kubejs/BuiltinKubeJSPlugin.java#L397-L398

#

#

yeah harmful does nothing by itself

#

it is used for coloring

gilded vector Nov 17, 2023, 2:52 PM

#

huh, never checked that specifically 😆; I will try using a different type of damage than "attack" and see it if applies

tame birch Nov 17, 2023, 2:56 PM

#

minecraft uses .hurt(

gilded vector Nov 17, 2023, 3:26 PM

#

huh, got a ticking error

#

[12:23:42] [ERROR] ! effect_registry.js#32: Error while ticking mob effect kubejs:mana_overload for entity Aikaya: dev.latvian.mods.rhino.EvaluatorException: Java constructor for "pie.ilikepiefoo.player.CustomDamageSourceJS" with arguments "string,dev.latvian.mods.rhino.Undefined" not found.

gleaming breach Nov 17, 2023, 3:32 PM

#

Something is undefined

#

To be more exact something with a damage sourcw

gilded vector Nov 17, 2023, 3:41 PM

#

well, I'll close the ticket for now and keep testing tonight, time to work now...

#Does "harmful()" not work on 1.20+?