#How to make good code reviews in a Merge Request

5 messages · Page 1 of 1 (latest)

mint lantern
#

How can I do good code reviews, to improve even more I want to review myself. To find bugs or even better things how to implement them. How should I proceed [1.,2.,3. etc.]

mighty viper
#

Reviewing code is just about checking the code satisfies the brief and is free of bugs really.

#

If you have a test suite then some sort of CI process should be able to run the test suite when a pull request is opened.

#

That will catch any logic errors (so long as you actually have test coverage for the feature being developed).

#

And as reviewing PRs requires care and attention, it then makes sense to keep PRs small in terms of changed files/lines of code changed.