PR - 12471 - WorldDifficultyChangeEvent

[austere quest]

.

for make more clean xd
hmmm if you reset everything start with just add the things not related to NMS and commit

if all still fine then go for NMS.. also maybe can just create a CraftDifficulty for the convert to bukkit and avoid add more things to the NMS and just make the event calls in that

[native harbor]

oh completely from scratch
i just reset my local changes to how it is in the pr xD

[austere quest]

xd

reset from main and add repeat.

when touch NMS try the commands for the first call just to make sure not throw anyy..

exists better ways but is what i make when this happen.. the other way is mess with the others tasks and git in minecraft but that just ends in frustration

[native harbor]

i hate patches from the heart for real

i made a new branch and cherry picked my changes into it
without the patches
fixupSourcePatches still throws

[austere quest]

depends how work.. i dont like the spigot patchs because rebase in that is.. well...

[austere quest]

you applypatches first not?

[native harbor]

i like the concept but working with them is just always a pain
every time i think i know what i do something breaks

[native harbor]

uhm... dont tell anyone... i did not

[austere quest]

remember the minecraft files are not in git track and if you just change branch that files still

and can really mess

[native harbor]

yeah i know forgot to run apply

i hate it
i hate it so much
it still throws

[austere quest]

Hmmm same error not?

If dont have issue csn try PR to your PR with that changes but still strange

[native harbor]

that shit gotta be kidding me right 😄
its trying to gaslight me or something
i restarted from scratch and fixup worked...

BUT THERE ARE NO PATCHES

[austere quest]

Not patches?

[native harbor]

literally nothing

the changes are in the code and all but there is no change in patches nor anything commited

[austere quest]

Fixup and rebuild not?

[native harbor]

ohh i have to rebuild afterwards

[austere quest]

Yep

[native harbor]

okay yeah patches are there

i dont think i ever created file patches

[austere quest]

no?

Well if now works you can force push xd

[native harbor]

huge thanks

[austere quest]

Not problem

[native harbor]

about that isnt there a class where all the notchian to bukkit and reverse methods are stored already?

nvm i was thinking about CraftBlock

should that go into craftbukkit tho?

[austere quest]

Yep, but now i think how works the other getDifficulty? Where make the convert?

Im in phone then lazy to search with that

[native harbor]

Where make the convert?
wdym?

[austere quest]

Ok i see CraftWorld the get use the ordinal enum and set use the nms byId

[native harbor]

thats how you mean that right?

[austere quest]

I mean your convertion nms/bukkit its not like in CraftWorld

Then its redundant make that method if can use what exists... Or like say make a CraftDifficulty with the methods for nms->bukkit and reverse

[native harbor]

so i'd rather move that to CraftWorld

[austere quest]

Hmm yeah maybe that is a good place

[empty anchor]

I like that 👍

[native harbor]

i moved it to CraftWorld
that also gave me the idea to fix that ordinal conversion shit in set/getDifficulty

if you want i can add that class again

[empty anchor]

We generally have that "CraftX holds the X <-> nms.X conversion" pattern

would be semi nice to maintain especially because that makes it easy to e.g. auto generate

[native harbor]

alright good to know
i thought thats completely arbitrary depending on context

[empty anchor]

Well it might be in some places

but yea, generally it'd be nice to follow

[native harbor]

what about toBukkit toMinecraft naming
is there some kind of preference at the moment
i saw toNotchian or what it was called and toMinecraft and other stuff

[empty anchor]

toMinecraft and toBukkit for sure yea xD

to Notchian is some old old direction stuff iirc

[native harbor]

also i just saw var usage that i didnt add 😄

[austere quest]

Not related to this thread

Maybe was in the hardfork or upgrade versions... Var its nice for forget sbout what you are saving

[empty anchor]

Some people have managed to sneak it in

[native harbor]

gotta be on that list some day too

[empty anchor]

[austere quest]

A nice cleanup future PR when the cat wake up

[empty anchor]

Cleanup PRs when I got it down to 25 prs again xD

[austere quest]

Explosion PR cof cof

[empty anchor]

Yea I only saw lulu still wanted changes

I am just getting the simple ones while also doing 3 other projects related to paper

[native harbor]

i love cleanups
now that i am one of the cool kids with the Contributor role may i submit those too?

[austere quest]

I make that changes the fire thing unless need just remove the filter

[empty anchor]

I'll look then

[austere quest]

Then Craking PR xd

[empty anchor]

[austere quest]

[native harbor]

is that a yes?

[empty anchor]

I'll look at explosion PR this weekend xD

thats what that was for

[austere quest]

Good question #paper-contrib
I just make cleanups when touch the class in a feature/fix PR

[empty anchor]

for the difficulty PR, I need to make up my mind about API cancelling

oh yea, for the future, #paper-contrib over a thread sounds like a solid idea

that is kind what that thing and the role are for 😉

[native harbor]

alright

[austere quest]

I mean i make this for avoid mess messages in the general dev...

Thread in contrib is valid too (?

[empty anchor]

Hmm, that might honestly be a pretty smart idea

lemme ask

We generally have been looking for a better way to do per-pr discussions

[austere quest]

Like paper-feedback because yeah forum/thread are the same xd

[empty anchor]

Yea, but feedback rn we have reserved for those large large PRs

[austere quest]

Threads or forums then

Thread in contrib for "basic" forum for eta PR

[empty anchor]

Yea, probably nice

[native harbor]

maybe give contrib+ roles perm to create public threads in #1135137683023339521 so we can create threads on prs or issues?

or an extra forum channel true

[empty anchor]

definitely not in the fully automated #1135137683023339521 channel xD

[native harbor]

yeah now that i think about it ...