#codebook

1 messages · Page 1 of 1 (latest)

gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: lambda-method-mappings
gritty sluiceBOT
gritty sluiceBOT
#

Various methods on CompoundTag return a type based on a key input which is a string. Very commonly, that string is a constant which is easy to lookup when choosing a name for the local var. The local var should be named based on that string, completely ignoring the expected type.

gritty sluiceBOT
#
[PaperMC/codebook] New tag created: v1.0.6
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: refactor-suggesters
#
[PaperMC/codebook] branch deleted: context
gritty sluiceBOT
#

There are several useful reports that could be generated from a run of codebook.

  • Missing parameter mappings
  • All locals assigned from methods that don't have a suggester match
  • All locals assigned from fields that don't have a suggester match
  • Any mapped param that is renamed due to a conflict
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: lambda-method-mappings
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: report-system
#

Creates a general injectable system for creating reports that can be generated via the CLI or by using the library directly. Should be helpful for generating separate logs of any important information from any point in codebook without having 1 big log file.

It's possible this should just be done with separate loggers that point to different files, but I like this because it creates a more abstract way on how formatting of various information would look.

gritty sluiceBOT
#
[PaperMC/codebook] New branch created: missing-param-report
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: capitalization-fixes
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: fix/nbt-collections
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] New tag created: v1.0.7
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: improve-min-max-loops
gritty sluiceBOT
#
[PaperMC/codebook] New tag created: v1.0.8
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: report-system
#
[PaperMC/codebook] branch deleted: fix/nbt-collections
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: capitalization-fixes
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: fluent-getters
#
[PaperMC/codebook] branch deleted: better-positions
#
[PaperMC/codebook] branch deleted: improve-min-max-loops
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: feature/skip-primitive-unboxing
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: feature/skip-primitive-unboxing
#
[PaperMC/codebook] branch deleted: missing-param-report
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: feature/check-cast-unwraps
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: optional-param-mappings
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: optional-param-mappings
gritty sluiceBOT
#
[PaperMC/codebook] New tag created: v1.0.10
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#

For more consistent cross-version comparisons it would be useful for codebook to be able to name parameters similarly to how it names the lvt.

If we don't apply any parameter names, we will get a different mess depending on the version ($$x or snowman emoji names).

And when using parchment, we don't have mappings for every snapshot, so there is a large amount of redundant diff each version from the mappings getting more or less in sync/complete.

Having codebook generate parameter n...

gritty sluiceBOT
#
[PaperMC/codebook] New tag created: v1.0.11
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: hypo-config
#
[PaperMC/codebook] branch deleted: hypo-config
#
[PaperMC/codebook] New tag created: v1.0.12
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: asm-bump
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: asm-bump
#
[PaperMC/codebook] New tag created: v1.0.13
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: build-updates
#
[PaperMC/codebook] branch deleted: build-updates
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: bugfix/lowercasing
#

Codebook uses toLowerCase for fully upper-cased type names like UUID.
The call uses the default locale, which might incorrectly map characters
like 'I' to lowercase versions that are not 'i'.
This prevents further patching of the mache sources.

Correctly specify the ROOT locale instead, making the logic independent
from the JVM default locale.

gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: bugfix/lowercasing
#
[PaperMC/codebook] New branch created: bugfix/gh-action
#
[PaperMC/codebook] branch deleted: bugfix/gh-action
#
[PaperMC/codebook] New branch created: bugfix/deploy-updates
#
[PaperMC/codebook] branch deleted: bugfix/deploy-updates
#
[PaperMC/codebook] New tag created: v1.0.14
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: bugfix/lvt-missing-param-fetching
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: bugfix/lvt-missing-param-fetching
#
[PaperMC/codebook] New tag created: v1.0.15
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: renovate/configure
#
[PaperMC/codebook] branch deleted: renovate/asm
#
[PaperMC/codebook] branch deleted: renovate/gradle-actions-5.x
#
[PaperMC/codebook] branch deleted: renovate/actions-setup-java-5.x
#
[PaperMC/codebook] branch deleted: renovate/com.google.code.gson-gson-2.x
#
[PaperMC/codebook] branch deleted: renovate/mockito-monorepo
#
[PaperMC/codebook] branch deleted: renovate/actions-checkout-5.x
#
[PaperMC/codebook] branch deleted: renovate/org.checkerframework-checker-qual-3.x
#
[PaperMC/codebook] New tag created: v1.0.16
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: unpick-v3-4
#

test data:

unpick v3

group long chunk_ticket_type_expiration
	net.minecraft.server.level.TicketType.NO_TIMEOUT

group int chunk_ticket_type_flags
	@flags
	net.minecraft.server.level.TicketType.FLAG_PERSIST
	net.minecraft.server.level.TicketType.FLAG_LOADING
	net.minecraft.server.level.TicketType.FLAG_SIMULATION
	net.minecraft.server.level.TicketType.FLAG_KEEP_DIMENSION_ACTIVE
	net.minecraft.server.level.TicketType.FLAG_CAN_EXPIRE_IF_UNLOADED

target_method net.minecraft.server.level.TicketType register (Ljava/lang/String;JI)Lnet/minecraft/server/level/TicketType;
	param 1 chunk_ticket_type_expiration
	param 2 chunk_ticket_type_flags
target_method net.minecraft.server.level.TicketType <init> (JI)V
	param 0 chunk_ticket_type_expiration
	param 1 chunk_ticket_type_flags
target_method net.minecraft.server.level.TicketType timeout ()J
	return chunk_ticket_type_expiration
target_method net.minecraft.server.level.TicketType flags ()I
	return chunk_ticket_type_flags
Index: versio```...
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: unpick-v3-4
#
[PaperMC/codebook] New tag created: v1.0.17
gritty sluiceBOT
#
[PaperMC/codebook] New tag created: v1.0.18
gritty sluiceBOT
#
[PaperMC/codebook] New branch created: dev/v2
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
gritty sluiceBOT
#
[PaperMC/codebook] branch deleted: renovate/softprops-action-gh-release-2.x