docs | PaperMC | Page 1

- Your plugin's instance,
- The code to run, either with a `Runnable` or `Consumer<BukkitTask>`,
- The delay in ticks before the task should run for the first time,
- If you're scheduling a repeating task - the period in ticks between each execution of the task.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

Why is the page called task scheduler if you immediately refer to it with the BukkitScheduler name. Maybe just name the page "The Bukkit Scheduler" or something along those lines?

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

The `BukkitScheduler` can be used to schedule your code to be run later or repeatedly.

lost sealBOT Jul 16, 2023, 2:34 PM

#

lynxplay

[PaperMC/docs] New review comment on pull request #196: Plugin messaging Docs

Useless empty line.

#

lynxplay

[PaperMC/docs] Pull request review submitted: #196 Plugin messaging Docs

#

lynxplay

[PaperMC/docs] New review comment on pull request #196: Plugin messaging Docs

Do we want to mention somewhere that it is bungeecord:main on the proxy side but BungeeCord on the server side ?

#

lynxplay

[PaperMC/docs] New review comment on pull request #196: Plugin messaging Docs

I feel like, we'd wanna move this like, behind the following example.
Reading this had me think that the following example was for banning players.

lost sealBOT Jul 16, 2023, 3:17 PM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #196 Plugin messaging Docs

#

lynxplay

[PaperMC/docs] Pull request closed: #196 Plugin messaging Docs

#

lynxplay

[docs:main] 1 new commit

16f8ede Plugin messaging Docs (#196) - olijeffers0n

lost sealBOT Jul 16, 2023, 6:54 PM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #143 Add Scheduler

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

I'd prefer something like Scheduling tasks over including Bukkit in the name

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #143 Add Scheduler

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

Think of it as a long sentence, hence the commas and the period at the end,
will add for the first time

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #143 Add Scheduler

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

Will change

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #143 Add Scheduler

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

Will change

#

olijeffers0n

[PaperMC/docs] Pull request opened: #198 Document Missing Configuration Nodes

Closes #188 by adding some missing nodes

lost sealBOT Jul 17, 2023, 9:23 AM

#

MiniDigger

[docs:main] 1 new commit

f09a568 Update Anti XRay Configuration Comment (#189) - olijeffers0n

#

MiniDigger

[PaperMC/docs] Pull request closed: #189 Update Anti XRay Configuration Comment

lost sealBOT Jul 17, 2023, 3:25 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #196 Plugin messaging Docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #196: Plugin messaging Docs

The player count in the last column doesn't seems well formatted

#

olijeffers0n

[PaperMC/docs] New comment on pull request #196: Plugin messaging Docs

This got merged. If you want to suggest something I’ll have to make a new PR - let me know on discord.

lost sealBOT Jul 18, 2023, 2:17 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #143 Add Scheduler

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #143: Add Scheduler

Missing a space between if and (

lost sealBOT Jul 19, 2023, 5:02 PM

#

DomiRusz24

[PaperMC/docs] Issue opened: #199 PaperMC website OpenAPI missing `version` field.

Missing required version field in the PaperMC download OpenAPI specification. (https://api.papermc.io/openapi)

https://swagger.io/specification/#info-object

The specifications requires for the info object to have both the title, and the version.

The PaperMC OpenAPI specification is missing the version field.
Is:

  "info": {
    "title": "PaperMC API"
  },

Should be:

  "info": {
    "title": "PaperMC API"
    "version": "FOO"
  },

(I'm not necessarily...

#

DomiRusz24

[PaperMC/docs] New comment on issue #199: PaperMC website OpenAPI missing `version` field.

This also includes the 3.0.x OAS (https://swagger.io/specification/v3/#info-object)

lost sealBOT Jul 19, 2023, 5:24 PM

#

olijeffers0n

[PaperMC/docs] New comment on issue #199: PaperMC website OpenAPI missing `version` field.

This docs repo holds our docosaurus docs. I believe this would be more appropriate on bibliothek

lost sealBOT Jul 19, 2023, 5:45 PM

#

DomiRusz24

[PaperMC/docs] New comment on issue #199: PaperMC website OpenAPI missing `version` field.

This docs repo holds our docosaurus docs. I believe this would be more appropriate on bibliothek

Man am I blind, haven't realised I can click on more repo's, closing this issue and opening a new one there.

#

DomiRusz24

[PaperMC/docs] Issue closed: #199 PaperMC website OpenAPI missing `version` field.

lost sealBOT Jul 19, 2023, 9:34 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #200 Database docs

Initial Work for database docs. I made these on a plane so some sections may be lacking. Let me know of any additions needed on the PR or discord :)

#

olijeffers0n

[PaperMC/docs] Pull request opened: #201 Plugin configurations

Work on a guide for plugin configurations. I made these on a plane so some sections may be lacking. Let me know of any additions needed on the PR or discord :)

lost sealBOT Jul 20, 2023, 2:00 PM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

MiniDigger

[PaperMC/docs] New review comment on pull request #200: Database docs

this is meh, instead of linking products, we should talk about file based dbs (like sqlite, h2, whatever) vs standalone dbs (postgres, mysql, etc).
that article in particular is worthless seo spam

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

MiniDigger

[PaperMC/docs] New review comment on pull request #200: Database docs

is this still the case on modern systems? I thought it does stuff automatically nowadays

#

MiniDigger

[PaperMC/docs] New review comment on pull request #200: Database docs

w3schools is a really meh resource (and that link isnt even the real one?)
I would suggest this as a quick primer https://www.baeldung.com/java-jdbc and https://docs.oracle.com/javase/tutorial/jdbc/basics/index.html for a fully featured reference

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

MiniDigger

[PaperMC/docs] New review comment on pull request #200: Database docs

we should have a sentence or two about what a connection pool is and why its relevant for standalone dbs like postgres and mysql

#

MiniDigger

[PaperMC/docs] New review comment on pull request #200: Database docs

furthermore we should briefly explain sql vs nosql (excluding nosql from our docs is fine by me :D, but should at least mention that there are DBs that dont use sql.

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

MiniDigger

[PaperMC/docs] New comment on pull request #200: Database docs

I would also love a quick section about sql injection and why its important to use prepared statements

oh, and while at it, we need a big red box about never accessing DB/IO/etc on the main thread

generally, I think our docs should be more like a high level explainer on concepts and lead the user to do a bit research themselves instead of feeling like a full blown tutorial (we arent a good authority on such general java/programming knowledge), but idk what others think

#

MiniDigger

[PaperMC/docs] New comment on pull request #201: Plugin configurations

looking nice, only thing I can think of is handling a custom config file, idk if we want to encourage that tho since people mostly use that for storing data and data should be stored in databases instead.

oh, and maybe saving configs.

lost sealBOT Jul 20, 2023, 5:31 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #201: Plugin configurations

Good points, should now be addressed.

#

powercasgamer

[PaperMC/docs] New comment on pull request #200: Database docs

Should maybe also mention that for gradle you need to use shadow, or the library loader?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #200: Database docs

Yes it is needed, Spigot ships an archaic version of JDBC (3.42.0.0) which does not support the automatic init - (V4+)

#

olijeffers0n

[PaperMC/docs] New comment on pull request #200: Database docs

Should maybe also mention that for gradle you need to use shadow, or the library loader?

Maybe? Seems out of the scope for this teaching people how to shade things into their plugins. I'll take a look at what I did write

#

olijeffers0n

[PaperMC/docs] New comment on pull request #200: Database docs

With response to Mini's comments - A more general overview of what you should be researching could be useful. I'll probably focus more on this angle in future

lost sealBOT Jul 22, 2023, 8:47 PM

#

Owen1212055

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

lost sealBOT Jul 22, 2023, 9:10 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #200: Database docs

@MiniDigger I have addressed your comments I think. I kept the basic guides within dropdowns, and added a more general overview. Would be happy for another review when you get time 😄

lost sealBOT Jul 22, 2023, 9:36 PM

#

lynxplay

[PaperMC/docs] New comment on pull request #84: Add docs for sending plugin messaging

Superseded by 16f8edeb40177d7aa07b755a819819731f92c5fb.
Thank you for the work nonetheless <3

#

lynxplay

[PaperMC/docs] Pull request closed: #84 Add docs for sending plugin messaging

#

lynxplay

[PaperMC/docs] Pull request review submitted: #198 Document Missing Configuration Nodes

#

lynxplay

[PaperMC/docs] Pull request closed: #198 Document Missing Configuration Nodes

#

lynxplay

[docs:main] 1 new commit

a083256 Document Missing Configuration Nodes (#198) - olijeffers0n

#

lynxplay

[PaperMC/docs] Issue closed: #188 player-max-chunk-generate-rate is undocumented

lost sealBOT Jul 22, 2023, 11:00 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #191: New Configuration Page Format

PR is somewhat finalised excluding search. Is this something that we are really interested in? Realistically if you know the config node you can just control-f it

lost sealBOT Jul 23, 2023, 12:25 AM

#

Owen1212055

[docs:main] 1 new commit

e5322b2 Add compression-format unsupported option - Owen1212055

lost sealBOT Jul 23, 2023, 5:08 AM

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

Should be able to use the @site prefix instead of the massive chain of ...

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

I think some visual distinction should be made between yaml setting text that can be expanded and not. Like there is no visual difference between a yaml section key and a value key.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

When this is shown, it changes the height of various things. I think it should be floating so as not not move the description block or other settings down.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

If I click on the circle, the description opens up (as the setting is hightlighted blue) but if I click again when its expanded, it is not collapsed. This doesn't happen if I click directly on the setting text.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

Not sure we need the literal label Description. I feel its apparently enough with the separate outlined box and the collapsible nature of the box.

lost sealBOT Jul 23, 2023, 9:59 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #202 Fix Description of `compression-format unsupported option`

Fixes #e5322b

lost sealBOT Jul 23, 2023, 10:15 AM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #202 Fix Description of `compression-format unsupported option`

#

lynxplay

[PaperMC/docs] Pull request closed: #202 Fix Description of `compression-format unsupported option`

#

lynxplay

[docs:main] 1 new commit

d6493d0 Fix Description of `compression-format unsuppor... - olijeffers0n

lost sealBOT Jul 23, 2023, 11:59 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #191: New Configuration Page Format

Addressed All of Machines Comments.

lost sealBOT Jul 23, 2023, 2:21 PM

#

A248

[PaperMC/docs] Pull request opened: #203 Clarify classloader isolation section on relocation

The classloader isolation currently implemented does not prevent non-paper plugins from accessing paper plugins' classloaders. As a result, relocation remains a good practice to prevent conflicts with non-paper plugins.

This PR is far more limited in scope than #183

#

A248

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

A248

[PaperMC/docs] New review comment on pull request #200: Database docs

The dependency declaration isn't useful because calling classes in org.sqlite packages is unnecessary. No dependency is needed; the whole interface works seamlessly with JDBC.

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #200: Database docs

Good point actually, this is only needed if you intend to relocate a different version of JDBC

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #203 Clarify classloader isolation section on relocation

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #203 Clarify classloader isolation section on relocation

Looks good, just one tweak

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #203: Clarify classloader isolation section on relocation

to your ``paper-plugin.yml``. Note, other Paper plugins will still be unable to access your classloader.

lost sealBOT Jul 23, 2023, 3:29 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #201: Plugin configurations

This deserialize two times the chunk X?

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #201: Plugin configurations

Generally you put bracket when using generic with known type (new HashMap<>())

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #201: Plugin configurations

Reseeing that why the name is chunk-y for a chunk Z?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #201: Plugin configurations

Good Point, fixed

lost sealBOT Jul 24, 2023, 7:26 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #203 Clarify classloader isolation section on relocation

lost sealBOT Jul 24, 2023, 11:30 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #204 Scheduler Docs

Adds scheduler docs. Supercedes #143

lost sealBOT Jul 25, 2023, 6:49 AM

#

Nacioszeczek

[PaperMC/docs] New comment on pull request #143: Add Scheduler

succeeded by #204

#

Nacioszeczek

[PaperMC/docs] Pull request closed: #143 Add Scheduler

lost sealBOT Jul 26, 2023, 11:26 AM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

#

MiniDigger

[PaperMC/docs] New review comment on pull request #201: Plugin configurations

behaviour
do we use english or british on docs?

#

MiniDigger

[PaperMC/docs] New review comment on pull request #201: Plugin configurations

When accessing indented values, you separate the levels with `.`. For example, the key for the "David" string would be `root.another-key`

looks nicer I think

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

lost sealBOT Jul 26, 2023, 11:57 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #205 Add A CONTRIBUTING.md

Adds a contributing file to outline code quality and also a brief guide on how to add a new page.

lost sealBOT Jul 26, 2023, 3:12 PM

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

Perhaps here is a good place to mention vercel deployments of your PR.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

We use [Docusaurus](https://docusaurus.io/) to build and deploy the documentation website. The documentation site is hosted on Vercel, which supports automatic

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #205 Add A CONTRIBUTING.md

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

Saying The documentation after saying where to find the Docusaurus documentation makes it sound like Docusaurus' documentation is written in markdown, when I think you are talking about our documentation. Maybe just make the first occurrence of the word Docusaurus a hyperlink to the docs.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

Using Docusaurus means that there are guides for how to write the documentation. You can find the Docusaurus documentation at

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

Gotta be a website somewhere that covers the main differences for anyone who doesn't know all the quirks. Could be good to link that here

lost sealBOT Jul 27, 2023, 8:06 AM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #205 Add A CONTRIBUTING.md

#

MiniDigger

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

idk if the site is any good, but they list the Our/or, ize/ise, yse/yze ae-oe/e, ence/ense, ogue/og spellings quite nice: https://www.oxfordinternationalenglish.com/differences-in-british-and-american-spelling/

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #205 Add A CONTRIBUTING.md

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

it’s got the word oxford in it so shrug

lost sealBOT Jul 28, 2023, 7:56 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #205 Add A CONTRIBUTING.md

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

I would say, instead of "our docs", "The bulk of Paper's documentation is written with Markdown"

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #205: Add A CONTRIBUTING.md

This Using Docusaurus means that there are guides... bit feels out of place. Perhaps combine that and the next sentence to something like
Docusarus has extensive documentation detailing what is possible with it. and then link over extensive documentation

lost sealBOT Jul 29, 2023, 10:40 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #205: Add A CONTRIBUTING.md

Comments Addressed

lost sealBOT Jul 29, 2023, 4:01 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

I think there needs to be a slightly bigger difference in color between the section names and key names. It feels like they are little too close still. However if the vertical lines are added via the border like I suggested, that might make it enough.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This should have a way to get a link to it as well, not just the keys with values

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

I don't know how it would look, but putting a left border on this div would create those vertical lines between sections which can be helpful in trying to figure out what section something is in. Then you could have the border "light up" when the div is being hovered over as further indication of what section you are in.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

I think a button to "copy" the setting would also be very useful as it is quicker to ctrl+f + ctrl+c to search for a key in your file

lost sealBOT Jul 30, 2023, 12:36 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

Not Quite sure what you mean here... Do you mean like copy autoconfig-send-distance or whatever?

lost sealBOT Jul 30, 2023, 5:34 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

looks like we don't have icons added to docs yet, so not a big issue.

lost sealBOT Jul 30, 2023, 8:22 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

lost sealBOT Jul 31, 2023, 7:10 AM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #205 Add A CONTRIBUTING.md

lost sealBOT Jul 31, 2023, 4:57 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #204 Scheduler Docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #204: Scheduler Docs

This will throw a UnsupportedTemporalTypeException. Generally this method only support seconds and nanos "conversion". But you can uses:
from minutes to ticks: Tick.tick().fromDuration(Duration.ofMinutes(5))
from ticks to minutes: Tick.of(ticks).toMinutes()

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #204: Scheduler Docs

This page contains both 4 spaces and tab for spacing for consistency only one spacing should be used. The whole doc uses 4 spaces except the custom inventory holder page.

lost sealBOT Jul 31, 2023, 5:21 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This looks weird. is it supposed to be a html comment hidden

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The notes looks weird now that it's not anymore a list

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

Same apply for other lists because all is inlined

lost sealBOT Jul 31, 2023, 5:57 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #191: New Configuration Page Format

Ah, yeah looks to be an issue with my conversion script. Addressed

#

olijeffers0n

[PaperMC/docs] New comment on pull request #204: Scheduler Docs

Addressed the comments and fixed the tabs in this file

lost sealBOT Aug 1, 2023, 4:43 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The description of this option has been dropped in the process

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

There's two space here. In the old config it was a newline. Same happens in the replacement-blocks option

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This whole section doesn't mention the engine mode 3

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This list is not correctly formatted

lost sealBOT Aug 2, 2023, 1:29 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #191: New Configuration Page Format

Addressed these comments and removed the trailing space after strings as well

lost sealBOT Aug 2, 2023, 4:54 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This whole part is hidden on the website for some reason. Maybe because the section has a description?

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The default value is missing. The values was outdated even on the old doc, it's now: ["database", "proxies.velocity.secret"]. The other entries has been either removed or hardcoded.

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The default value is missing

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The default value is missing

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This section doesn't exists anymore: https://github.com/PaperMC/Paper/blob/master/patches/server/0005-Paper-config-files.patch#L1474 since the new ansi encoder

lost sealBOT Aug 2, 2023, 8:55 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

Yeah, it seems like this was dropped in favour of chunk-loading-basic and chunk-loading-advanced. I have addressed all of your comments now. Thanks for going through this all with a fine toothpick.

lost sealBOT Aug 2, 2023, 9:36 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #206 Small Grammar Change in Anti Xray Intro

lost sealBOT Aug 3, 2023, 9:58 AM

#

vercel[bot]

[PaperMC/docs] New comment on pull request #201: Plugin configurations

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

lost sealBOT Aug 3, 2023, 10:32 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #201: Plugin configurations

CI is bugged. This PR is ready for final review and does not actually fail deployment locally

#

MiniDigger

[PaperMC/docs] New comment on pull request #201: Plugin configurations

fixed

lost sealBOT Aug 3, 2023, 4:47 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This section miss the strict-advancement-dimension-check option (default to false). You can look here: https://github.com/PaperMC/Paper/blob/master/patches/server/0834-Add-option-for-strict-advancement-dimension-checks.patch
by default bukkit consider some world that are similar to the main world as the main world for custom world unlike vanilla that does strict equality here.
This section also miss the chat-threads section:
![image](https://github.com/PaperMC/docs/assets/41980282/37c53048...

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The default value has changed to 5 players : https://github.com/PaperMC/Paper/blob/master/patches/server/0005-Paper-config-files.patch#L719

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This section miss the allow-grindstone-overstacking option (default to false)

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This section miss the flush-regions-on-save option (default to false)

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

This is a section:

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The default is now: default but maybe the real value could be written somewhere in the description? (could apply for others)

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #191: New Configuration Page Format

The default is now: default

lost sealBOT Aug 5, 2023, 10:00 AM

#

Nacioszeczek

[PaperMC/docs] Issue opened: #207 Missing plugin messaging subchannel

The Plugin Messaging doc is missing the MessageRaw subchannel.
https://www.spigotmc.org/wiki/bukkit-bungee-plugin-messaging-channel/#messageraw

#

olijeffers0n

[PaperMC/docs] New comment on issue #207: Missing plugin messaging subchannel

Will fix later

lost sealBOT Aug 5, 2023, 7:34 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #208 Add missing plugin messaging channel

Adds MessageRaw with component example

lost sealBOT Aug 5, 2023, 8:58 PM

#

Nacioszeczek

[PaperMC/docs] New comment on pull request #208: Add missing plugin messaging channel

Perhaps using a JSON component serializer would be way cleaner than the JSON itself?

lost sealBOT Aug 5, 2023, 9:49 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #209 Document server dot properties

Depends on #191. Slightly changes the behaviour of the YAML formatter to make it work with the server.properties format.

lost sealBOT Aug 5, 2023, 11:39 PM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #205 Add A CONTRIBUTING.md

#

Machine-Maker

[PaperMC/docs] Pull request closed: #206 Small Grammar Change in Anti Xray Intro

#

Machine-Maker

[docs:main] 1 new commit

abacecc Small Grammar Change in Anti Xray Intro (#206) - olijeffers0n

#

Machine-Maker

[PaperMC/docs] Pull request closed: #205 Add A CONTRIBUTING.md

#

Machine-Maker

[docs:main] 1 new commit

410d702 Add A CONTRIBUTING.md (#205) - olijeffers0n

lost sealBOT Aug 6, 2023, 1:07 AM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #191 New Configuration Page Format

#

lynxplay

[PaperMC/docs] Pull request closed: #191 New Configuration Page Format

#

lynxplay

[docs:main] 1 new commit

35f4eff New Configuration Page Format (#191) - olijeffers0n

#

lynxplay

[PaperMC/docs] Pull request review submitted: #203 Clarify classloader isolation section on relocation

#

lynxplay

[PaperMC/docs] Pull request closed: #203 Clarify classloader isolation section on relocation

#

lynxplay

[docs:main] 1 new commit

2534476 Clarify classloader isolation section on reloca... - A248

lost sealBOT Aug 6, 2023, 7:18 AM

#

MiniDigger

[PaperMC/docs] New comment on pull request #208: Add missing plugin messaging channel

yeah, really dont wanna encourage hard coding json strings in any way

lost sealBOT Aug 6, 2023, 11:06 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #209: Document server dot properties

Ready For Review now that we have merged the base formatting PR for this

#

olijeffers0n

[PaperMC/docs] New comment on pull request #208: Add missing plugin messaging channel

Yeah we discussed this last night. Updated it to use adventure

lost sealBOT Aug 6, 2023, 11:54 AM

#

Alvinn8

[PaperMC/docs] Pull request review submitted: #209 Document server dot properties

Was lurking on discord, thought I'd comment.

#

Alvinn8

[PaperMC/docs] New review comment on pull request #209: Document server dot properties

This might cause people to think any Survival mode players can fly.

#

Alvinn8

[PaperMC/docs] New review comment on pull request #209: Document server dot properties

I think the max is 1000 not 100.

lost sealBOT Aug 6, 2023, 2:08 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #209: Document server dot properties

Thank you 😄 - All addressed

lost sealBOT Aug 7, 2023, 11:23 AM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #208 Add missing plugin messaging channel

lost sealBOT Aug 8, 2023, 1:45 AM

#

JACTC

[PaperMC/docs] Pull request opened: #210 Note clarifying port ordering

#

kennytv

[PaperMC/docs] New comment on pull request #210: Note clarifying port ordering

Why?

#

JACTC

[PaperMC/docs] New comment on pull request #210: Note clarifying port ordering

Because if one server doesn't have the port in order, you wouldn't be able to connect to it, and because I haven't seen it mentioned anywhere in the documentation I thought it would help people troubleshoot faster over a simple issue that is port ordering.

But if you prefer to not mention it or mentioning it in another way, its totally fine by me.

#

kashike

[PaperMC/docs] Pull request closed: #210 Note clarifying port ordering

#

kennytv

[PaperMC/docs] New comment on pull request #210: Note clarifying port ordering

The port definition doesn't matter outside of a range of reserved or otherwise maybe already used ports. Your first server could have the port 5543, the next 25599, and another 25566

lost sealBOT Aug 9, 2023, 11:31 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #211 Remove the circular dependency image and add a mermaid diagram instead

lost sealBOT Aug 9, 2023, 5:07 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #193 Add simple docs for userdev

Obviously Still a draft PR, but TBH looks good apart from these comments

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

**Paperweight** is the name of Paper's custom build tooling. The **Userdev** Gradle plugin
provides access to non-API code (known as internals or NMS) during development.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

Extra newline

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

The Paper server jars we provide on the downloads page and through the API are **paperclip** jars.
These use Spigot's mappings, which are essentially some type names, but fully obfuscated fields and methods.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

This guide is written using the Kotlin DSL for Gradle and assumes you have some basic knowledge of Gradle.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

Generally with these admonitions we have blank lines between the content and the triple colons. Applies to the others as well

lost sealBOT Aug 9, 2023, 6:24 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #212 Automate the versioning of doc contents

This grabs the versions of projects from api.papermc.io. There is still some logic required todo with when you are opening an old doc like 1.19 or 1.18. This requests every 5 minutes to keep them up-to-date when the page is still open.

lost sealBOT Aug 10, 2023, 1:08 AM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #209 Document server dot properties

#

the456gamer

[PaperMC/docs] New review comment on pull request #209: Document server dot properties

isnt it in blocks, not chunks?

#

the456gamer

[PaperMC/docs] New review comment on pull request #209: Document server dot properties

could someone get confused that
since enable-status enables the query listener, it overrides enable-query?

#

the456gamer

[PaperMC/docs] New review comment on pull request #209: Document server dot properties

kicked implies they were able to join successfully, rather than prevented like the name suggests

lost sealBOT Aug 10, 2023, 8:23 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #209 Document server dot properties

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #209: Document server dot properties

I suppose it’s possible. I’ll take a look at the rest of your comments later. Thanks for the review

lost sealBOT Aug 10, 2023, 9:08 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

Just need to handle when the user changes between different versions of the docs

#

olijeffers0n

[PaperMC/docs] New comment on pull request #209: Document server dot properties

Addressed, thanks 😄

#

olijeffers0n

[PaperMC/docs] Pull request opened: #213 chore: Un-British recent configuration overhaul

lost sealBOT Aug 11, 2023, 7:20 AM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #213 chore: Un-British recent configuration overhaul

🇺🇸

lost sealBOT Aug 11, 2023, 6:31 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #213 chore: Un-British recent configuration overhaul

#

Machine-Maker

[PaperMC/docs] Pull request closed: #213 chore: Un-British recent configuration overhaul

#

Machine-Maker

[docs:main] 1 new commit

b5ba637 chore: Un-British recent configuration overhaul... - olijeffers0n

lost sealBOT Aug 11, 2023, 7:32 PM

#

NoahvdAa

[PaperMC/docs] New review comment on pull request #208: Add missing plugin messaging channel

Maybe also mention sending to players that aren't on the same backend server as an extra use case.

#

NoahvdAa

[PaperMC/docs] New review comment on pull request #208: Add missing plugin messaging channel

The text above the snippet make it sound like this is only going to one player, when this is being broadcasted to all players on the proxy. This should be clarified to mention that this should be the name of the target player or ALL.

#

NoahvdAa

[PaperMC/docs] Pull request review submitted: #208 Add missing plugin messaging channel

lost sealBOT Aug 11, 2023, 8:17 PM

#

olijeffers0n

[PaperMC/docs] Pull request closed: #204 Scheduler Docs

#

olijeffers0n

[PaperMC/docs] Pull request reopened: #204 Scheduler Docs

#

olijeffers0n

[PaperMC/docs] New comment on pull request #208: Add missing plugin messaging channel

Thanks, Addressed comments

lost sealBOT Aug 11, 2023, 10:17 PM

#

NoahvdAa

[PaperMC/docs] New comment on pull request #208: Add missing plugin messaging channel

Now that I think of it, "This is useful for sending clickable messages to players," sounds weird considering we (and Spigot) have native support for chat components. I feel like this might be a leftover in the bungee docs from a time where this native integration didn't exist yet. Maybe we're better off removing this entire part? I don't really see the purpose for this channel anymore apart from the aforementioned option of using it to send messages to players on a different server.

lost sealBOT Aug 12, 2023, 10:37 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #208: Add missing plugin messaging channel

Good point. I think this is more just bad wording... but yeah the fact that it is a clickable component is not really significant anymore.

#

olijeffers0n

[PaperMC/docs] New comment on pull request #209: Document server dot properties

Addressed Merge conflicts

lost sealBOT Aug 12, 2023, 11:12 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #214 Paper bug fixes page

This is the initial page for transferring the Github Issue to an actual page. Let me know any comments you have as You may want more of an explanation to why these were changed. Any maintainers may also have more insight.

#

the456gamer

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

the456gamer

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Is allowed the right word?
Since server owners can do what they want, including installing plugins to bring the dupe back

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Probably not

lost sealBOT Aug 12, 2023, 12:02 PM

#

NoahvdAa

[PaperMC/docs] Pull request review submitted: #208 Add missing plugin messaging channel

#

NoahvdAa

[PaperMC/docs] Pull request closed: #208 Add missing plugin messaging channel

#

NoahvdAa

[docs:main] 1 new commit

21125d7 Add missing plugin messaging channel (#208) - olijeffers0n

#

NoahvdAa

[PaperMC/docs] Issue closed: #207 Missing plugin messaging subchannel

#

lynxplay

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

lynxplay

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

The main reason iirc why these options are in the unsupported setting is not really the lag or enabling them, it is more that we do not promise these to keep working down the line.

If upstream fixes this accidentally, or even mojang, we are not going out of our way to re-implement these settings.
If enabling them absolutely crashes your server, it is probably still a good idea to let us know lol.

lost sealBOT Aug 12, 2023, 2:00 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Just copied this from Aikars Description. Have added another sentence now

lost sealBOT Aug 12, 2023, 3:15 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

Ok, this is ready for review now. The basic logic behind what version to display to the user is:

If the URL contains the version string, then we load the maximum version for that major. IE the dev guide will display 1.19.4 if we are using the 1.19 versioned docs.
On the other hand, if we are using the latest docs then we can just return the highest Paper version.

SoftwareVersionFetcher

In order to use this, there are some caveats. When it is placed inline within markdo...

lost sealBOT Aug 12, 2023, 4:10 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

I think I would mention somewhere what our criteria for determine what is and isn't intended vanilla behavior. That is an open and confirmed issue on the tracker, usually with a mojang priority assigned to it.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Paper fixes many vanilla bugs that were not intended by Mojang. These bugs are patched to fix behavior or prevent abuse and

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Paper Patches TNT, Carpet, Rail and Gravity Block (Sand, Gravel, etc.) Duplication bugs. These bugs are not intended and

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

These settings are also not guaranteed to be supported into the future and may have their behavior changed or removed at any time.

lost sealBOT Aug 12, 2023, 4:35 PM

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

I think it would probably be very handy to have a component to make linking to specific javadocs easier. Just to avoid the boilerplate of <a href=.... It could take a parameter for the path to whatever, and the inner content would be the text to show instead like the a tag.

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #212 Automate the versioning of doc contents

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

    private currentURLVersion: string | null = null;

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

I think, even if we aren't using them now, we should add all the possible props to CodeBlock like title, and showLineNumbers

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

newline at end for this and all new files.

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #193 Add simple docs for userdev

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

Don't think I'm gonna use Paper plugin here cause that's a separate thing now. I think just adding your works

#

Machine-Maker

[docs] Branch feature/userdev was force-pushed to `3799ad4`

Compare changes

#

Machine-Maker

[docs:feature/userdev] 1 new commit

83edca0 do last suggestion - Machine-Maker

lost sealBOT Aug 12, 2023, 5:29 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #193 Add simple docs for userdev

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

That works too

lost sealBOT Aug 12, 2023, 7:33 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #193 Add simple docs for userdev

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #193: Add simple docs for userdev

I think I would rather this said either // Other Dependencies or just // ...

#

Machine-Maker

[docs:feature/userdev] 1 new commit

b5f5b2c address final comments - Machine-Maker

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #193 Add simple docs for userdev

#

NotMyFault

[PaperMC/docs] Pull request closed: #193 Add simple docs for userdev

#

NotMyFault

[docs:main] 1 new commit

f17102b Add simple docs for userdev (#193) - Machine-Maker

#

NotMyFault

[PaperMC/docs] branch deleted: feature/userdev

#

NotMyFault

[PaperMC/docs] Pull request review submitted: #211 Remove the circular dependency image and add a mermaid diagram instead

#

NotMyFault

[PaperMC/docs] Pull request closed: #211 Remove the circular dependency image and add a mermaid diagram instead

#

NotMyFault

[docs:main] 1 new commit

022fac4 Remove the circular dependency image and add a ... - olijeffers0n

#

NotMyFault

[PaperMC/docs] Pull request review submitted: #209 Document server dot properties

#

NotMyFault

[PaperMC/docs] Pull request closed: #209 Document server dot properties

#

NotMyFault

[docs:main] 1 new commit

c6d2272 Document server dot properties (#209) - olijeffers0n

#

NotMyFault

[PaperMC/docs] Issue closed: #36 Document server.properties

#

NotMyFault

[PaperMC/docs] Pull request review submitted: #201 Plugin configurations

#

NotMyFault

[PaperMC/docs] Pull request closed: #201 Plugin configurations

#

NotMyFault

[docs:main] 1 new commit

20bd56b Plugin configurations (#201) - olijeffers0n

#

NotMyFault

[PaperMC/docs] Issue closed: #105 Plugin configuration

#

NotMyFault

[PaperMC/docs] New comment on pull request #154: Change config table of contents to include all settings

not fond of the notion of making the TOC stupidly large

Same here, thanks for your contribution nonetheless.

#

NotMyFault

[PaperMC/docs] Pull request closed: #154 Change config table of contents to include all settings

lost sealBOT Aug 12, 2023, 9:46 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

There is some buggy behaviour when switching between versions. Other than that there are some syntax changes I will explain when ready for final review

lost sealBOT Aug 12, 2023, 11:53 PM

#

Machine-Maker

[docs:paper/player-reloot-time] 1 new commit

ab0a346 Add docs for player reloot time - Machine-Maker

#

Machine-Maker

[PaperMC/docs] New branch created: paper/player-reloot-time

#

Machine-Maker

[PaperMC/docs] Pull request opened: #215 Add docs for player reloot time

#

Machine-Maker

[docs] Branch paper/player-reloot-time was force-pushed to `c95bba6`

Compare changes

#

olijeffers0n

[PaperMC/docs] New comment on pull request #215: Add docs for player reloot time

What’s the unit?

#

lynxplay

[PaperMC/docs] New comment on pull request #215: Add docs for player reloot time

What’s the unit?

The duration, supports s,m,h,d.

lost sealBOT Aug 13, 2023, 10:38 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #216 Add Config for mushroom spread

For Paper#9592

#

olijeffers0n

[PaperMC/docs] New comment on pull request #215: Add docs for player reloot time

Should it maybe say that? From a quick look at paper it seems like only one unit is permitted rather than 2h3m30s which is how I would use this.

#

lynxplay

[PaperMC/docs] New comment on pull request #215: Add docs for player reloot time

Probably yea :+1:

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #194: Add docs for i18n in paper

                "dev/api/component-api/i18n",

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #194 Add docs for i18n in paper

Looks good, the only thing I would say is that it probably needs an example of using a translatable component

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #194: Add docs for i18n in paper

Extra Newline

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #194: Add docs for i18n in paper

:::info[Javadocs]

Adventure's javadocs for all-things translations can be found [here](https://jd.advntr.dev/api/latest/net/kyori/adventure/translation/package-summary.html).

:::

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #194: Add docs for i18n in paper

Another extra newline

lost sealBOT Aug 13, 2023, 11:25 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #183: Update Paper Plugins docs

Ready for final review

lost sealBOT Aug 13, 2023, 2:56 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Is it? Doesn't sound right to me

lost sealBOT Aug 13, 2023, 4:38 PM

#

Machine-Maker

[PaperMC/docs] branch deleted: temporary-config-page

#

Machine-Maker

[PaperMC/docs] branch deleted: feature/folia

lost sealBOT Aug 13, 2023, 4:58 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #183 Update Paper Plugins docs

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #183: Update Paper Plugins docs

On Line 9, I think that should be an admonition and be worded more generally like
"Developer-specific documentation can be found here". Avoid using you essentially.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #183: Update Paper Plugins docs

It should be noted you still have the ability to include both `paper-plugin.yml` and `plugin.yml` in the same jar.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #183: Update Paper Plugins docs

This will not act as a drop-in replacement for `plugin.yml`, as some things, as outlined in this guide, need to be declared differently.

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #216 Add Config for mushroom spread

Just blocking cause I think the structure of the options is going to change based on https://github.com/PaperMC/Paper/pull/9599#discussion_r1292826471

lost sealBOT Aug 13, 2023, 7:08 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #183: Update Paper Plugins docs

Thanks, Addressed comments

#

olijeffers0n

[PaperMC/docs] Issue closed: #146 Plugin messaging

lost sealBOT Aug 13, 2023, 7:30 PM

#

the456gamer

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

if you are on a sub page of the docs, and click on the version selector in the top right, it takes you back to the root page on the current version.
this feels like it might be confusing, especially as it tries to keep you on the same page when switching versions

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

This isn’t behaviour I have changed, but I am happy to discuss it over on discord as I’m not quite sure what you mean 😄

lost sealBOT Aug 13, 2023, 7:55 PM

#

Machine-Maker

[docs:feature/component/i18n] 1 new commit

6de104f small fixes - Machine-Maker

lost sealBOT Aug 13, 2023, 8:24 PM

#

Machine-Maker

[docs] Branch feature/component/i18n was force-pushed to `3637a46`

Compare changes

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #194 Add docs for i18n in paper

Looks good to me

#

olijeffers0n

[PaperMC/docs] Pull request closed: #194 Add docs for i18n in paper

#

olijeffers0n

[docs:main] 7 new commits

8aefa5a Add docs for i18n in paper - Machine-Maker
ef42c82 add an example for ResourceBundle - Machine-Maker
52180c5 fix typo in registerAll - Machine-Maker
df8dec0 fix 2 things - Machine-Maker
64691b3 small fixes - Machine-Maker

#

Machine-Maker

[PaperMC/docs] branch deleted: feature/component/i18n

lost sealBOT Aug 14, 2023, 10:49 PM

#

Machine-Maker

[docs] Branch paper/player-reloot-time was force-pushed to `73f2ad0`

Compare changes

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #215 Add docs for player reloot time

#

Machine-Maker

[PaperMC/docs] Pull request closed: #215 Add docs for player reloot time

#

Machine-Maker

[docs:main] 1 new commit

4e6cd4a Add docs for player reloot time (#215) - Machine-Maker

#

Machine-Maker

[PaperMC/docs] branch deleted: paper/player-reloot-time

lost sealBOT Aug 15, 2023, 9:19 AM

#

kennytv

[PaperMC/docs] Pull request review submitted: #204 Scheduler Docs

lost sealBOT Aug 15, 2023, 9:37 AM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #204 Scheduler Docs

#

lynxplay

[PaperMC/docs] New review comment on pull request #204: Scheduler Docs

Asynchronous tasks are tasks that are executed on separate threads, therefore will not directly affect

#

lynxplay

[PaperMC/docs] New review comment on pull request #204: Scheduler Docs

Dangerous stuff, keeping an entity reference cross tick is not really something we want.
Would probably be better to use a UUID here.

lost sealBOT Aug 15, 2023, 10:25 AM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #204 Scheduler Docs

#

olijeffers0n

[PaperMC/docs] Pull request closed: #204 Scheduler Docs

#

olijeffers0n

[docs:main] 1 new commit

3f2939f Scheduler Docs (#204) - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Issue closed: #102 How to use the scheduler, what is a "tick"

lost sealBOT Aug 15, 2023, 11:08 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

I have added all the behaviour of a native code block and changed the way that the versions work.

Embedded Versions:

Before, we had:

import SoftwareVersionFetcher from "@site/src/minecraft-versioning/SoftwareVersionFetcher";

The valid versions are 1.13 - { SoftwareVersionFetcher.getMajorPaperVersion() }.

However this only supports synchronous getMajorPaperVersion calls, so I have had to move this to a component:

The valid versions are 1.13 - <SoftwareVe...

lost sealBOT Aug 15, 2023, 12:54 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #217 Remove trailing spaces on non-value nodes

#

olijeffers0n

[PaperMC/docs] Pull request closed: #217 Remove trailing spaces on non-value nodes

#

olijeffers0n

[docs:main] 1 new commit

7cea2b1 Remove trailing spaces on non-value nodes (#217) - olijeffers0n

lost sealBOT Aug 15, 2023, 1:54 PM

#

2sweetheart2

[PaperMC/docs] Pull request opened: #218 Update plugin-messaging.md

Update player.sendPluginMessage from player.sendPluginMessage(plugin, "bungeecord:main", out.toByteArray()) to player.sendPluginMessage(MinecraftChannelIdentifier.from("bungeecord:main"), out.toByteArray())

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #218 Update plugin-messaging.md

#

olijeffers0n

[PaperMC/docs] Pull request closed: #218 Update plugin-messaging.md

#

olijeffers0n

[docs:main] 1 new commit

c35fa3d Update plugin-messaging.md (#218) - 2sweetheart2

#

olijeffers0n

[PaperMC/docs] New comment on pull request #218: Update plugin-messaging.md

Thanks

#

2sweetheart2

[PaperMC/docs] New comment on pull request #218: Update plugin-messaging.md

Thanks

np

lost sealBOT Aug 16, 2023, 7:35 PM

#

Warriorrrr

[PaperMC/docs] Pull request review submitted: #183 Update Paper Plugins docs

#

Warriorrrr

[PaperMC/docs] New review comment on pull request #183: Update Paper Plugins docs

    # Let's say that RegistryPlugin registers some data that your plugin needs to use

#

olijeffers0n

[PaperMC/docs] New comment on pull request #183: Update Paper Plugins docs

Addressed, thanks

#

Warriorrrr

[PaperMC/docs] Pull request review submitted: #183 Update Paper Plugins docs

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #183 Update Paper Plugins docs

lost sealBOT Aug 16, 2023, 9:24 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #183 Update Paper Plugins docs

#

olijeffers0n

[PaperMC/docs] Pull request closed: #183 Update Paper Plugins docs

#

olijeffers0n

[docs:main] 1 new commit

e8ecf63 Update Paper Plugins docs (#183) - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Issue closed: #174 [Feature] Update paper-plugins docs

lost sealBOT Aug 20, 2023, 11:33 AM

#

the456gamer

[PaperMC/docs] Pull request opened: #219 add message format to the global config

basically mentioning that the components are minimessage formatted

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #219 add message format to the global config

The wording on some of these sounds off - “minimessage formatted message” is weird. Maybe more like “The message sent to clients for … - Formatted with minimessage”

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #219 add message format to the global config

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #219: add message format to the global config

Ditto

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #219 add message format to the global config

#

olijeffers0n

[PaperMC/docs] Pull request closed: #219 add message format to the global config

#

olijeffers0n

[docs:main] 1 new commit

9d11766 Add message format (mentioning minimessage) (#219) - the456gamer

#

olijeffers0n

[docs:main] 1 new commit

f5226ee Capitalise MiniMessage in configuration pages - olijeffers0n

lost sealBOT Aug 20, 2023, 8:50 PM

#

astei

[PaperMC/docs] Pull request opened: #220 Update Velocity comparison page for clearer copy and strongly caution against Waterfall

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #220 Update Velocity comparison page for clearer copy and strongly caution against Waterfall

#

Nacioszeczek

[PaperMC/docs] Pull request closed: #220 Update Velocity comparison page for clearer copy and strongly caution against Waterfall

#

Nacioszeczek

[docs:main] 2 new commits

23eab4e Update Velocity comparison page for clearer cop... - astei
ec41e79 Merge pull request #220 from astei/main-1 - Nacioszeczek

lost sealBOT Aug 20, 2023, 9:33 PM

#

the456gamer

[PaperMC/docs] Pull request opened: #221 [DRAFT] add spigot.yml docs

lost sealBOT Aug 20, 2023, 9:59 PM

#

Malfrador

[PaperMC/docs] Pull request opened: #222 Add comparison matrix to Velocity comparison page

A question that gets asked often is "Should I use Velocity, Waterfall or BungeeCord". While the existing page already answer that, its a lot to read and contains plenty of details that most server owners just looking for a simple answer aren't interested in.

This PR adds a small markdown table with a comparison matrix to the top of that doc page. It makes it easy to see at a glance what Velocity does, and what it doesn't do - mainly, supporting plugins made for BungeeCord, another question...

lost sealBOT Aug 20, 2023, 10:14 PM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #222 Add comparison matrix to Velocity comparison page

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #222: Add comparison matrix to Velocity comparison page

It is somewhat possible to run Bungee plugins on Velocity using a plugin, not sure if that's reliable enough to mention that on the docs though

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #222: Add comparison matrix to Velocity comparison page

Could list some of the stuff, e.g. Adventure support

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #222: Add comparison matrix to Velocity comparison page

Should probably mention modern Forge being problematic, on all proxies though

#

olijeffers0n

[PaperMC/docs] New comment on pull request #222: Add comparison matrix to Velocity comparison page

Two rows for velocity and bungee plugins seem redundant but i can’t think of a better way to do this. Also, surely there must be another pro to Bungee over velocity? Seems rather one sided that’s all 😄

lost sealBOT Aug 21, 2023, 12:43 AM

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

on one hand maybe i should remove it so it shouldn't show at all, on the other, its then no longer a complete reference

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

notes for myself later

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

mention file extensions?

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

todo

lost sealBOT Aug 21, 2023, 7:14 AM

#

MiniDigger

[PaperMC/docs] New comment on pull request #222: Add comparison matrix to Velocity comparison page

that table should somehow also show a difference between bungee and waterfall (not that I would know something to add there, lol)

lost sealBOT Aug 21, 2023, 11:46 AM

#

lynxplay

[docs:bugfix/remove-lag-compensate-block-breaking-from-config] 1 new commit

39caef3 Remove lag compensate block breaking configuration - lynxplay

#

lynxplay

[PaperMC/docs] New branch created: bugfix/remove-lag-compensate-block-breaking-from-config

#

lynxplay

[PaperMC/docs] Pull request opened: #223 Remove lag compensate block breaking configuration

lost sealBOT Aug 21, 2023, 12:10 PM

#

lynxplay

[PaperMC/docs] Pull request closed: #223 Remove lag compensate block breaking configuration

#

lynxplay

[docs:main] 1 new commit

d6783f9 Remove lag compensate block breaking configurat... - lynxplay

#

lynxplay

[PaperMC/docs] branch deleted: bugfix/remove-lag-compensate-block-breaking-from-config

lost sealBOT Aug 22, 2023, 9:37 AM

#

kennytv

[docs:hangar-publishing] 1 new commit

47dced0 Sample code for GH actions Hangar publishing - kennytv

#

kennytv

[PaperMC/docs] New branch created: hangar-publishing

#

kennytv

[docs] Branch hangar-publishing was force-pushed to `17f9948`

Compare changes

#

kennytv

[docs] Branch hangar-publishing was force-pushed to `7c35199`

Compare changes

lost sealBOT Aug 22, 2023, 10:13 AM

#

kennytv

[docs] Branch hangar-publishing was force-pushed to `3e17986`

Compare changes

#

kennytv

[docs] Branch hangar-publishing was force-pushed to `ee3e5ca`

Compare changes

#

kennytv

[PaperMC/docs] Pull request opened: #224 Sample code for GH actions Hangar publishing

#

NotMyFault

[PaperMC/docs] Pull request closed: #224 Sample code for GH actions Hangar publishing

#

NotMyFault

[docs:main] 1 new commit

869d473 Sample code for GH actions Hangar publishing (#... - kennytv

#

NotMyFault

[PaperMC/docs] branch deleted: hangar-publishing

lost sealBOT Aug 22, 2023, 10:46 AM

#

kennytv

[docs:main] 1 new commit

d5637e2 Complete unfinished sentence - kennytv

lost sealBOT Aug 22, 2023, 12:52 PM

#

kennytv

[docs:main] 1 new commit

30d16a2 Fix userdev link - kennytv

#

kennytv

[docs:main] 1 new commit

ed0a3fa Fix userdev link again - kennytv

lost sealBOT Aug 22, 2023, 10:09 PM

#

kennytv

[docs:main] 1 new commit

c3ad00a Small wording fixes - kennytv

lost sealBOT Aug 23, 2023, 2:15 AM

#

kennytv

[docs:main] 1 new commit

385459a More fixes to Hangar publishing page - kennytv

lost sealBOT Aug 24, 2023, 10:06 AM

#

KastenKlicker

[PaperMC/docs] Issue opened: #225 Update velocity api version

https://docs.papermc.io/velocity/dev/creating-your-first-plugin, quotes that 3.1.1 is the newest version, but 3.2.0 is the newest version. Please replace 3.1.1 with 3.2.0-SNAPSHOT.

I hope this is the right place to address this issue.

Thx

#

powercasgamer

[PaperMC/docs] New comment on issue #225: Update velocity api version

3.2.0 is not released yet

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

Requires a rebase. Also, i seem to have ignored velocity. I assume we want that as well?

#

KastenKlicker

[PaperMC/docs] New comment on issue #225: Update velocity api version

All JavaDoc URLs at papermc.io are pointing to https://jd.papermc.io/velocity/3.0.0/ (which is Version 3.2.0)
and the "default" Download at https://papermc.io/downloads/velocity is Version 3.2.0.

So even if 3.2.0 isn't a "release version", I would change it.

lost sealBOT Aug 24, 2023, 1:31 PM

#

Nacioszeczek

[docs:main] 1 new commit

ad6d146 fixes #225 - Nacioszeczek

#

Nacioszeczek

[PaperMC/docs] Issue closed: #225 Update velocity api version

lost sealBOT Aug 25, 2023, 1:40 AM

#

Machine-Maker

[docs:contributing/events] 1 new commit

00c7782 Add paper contribution docs for events - Machine-Maker

#

Machine-Maker

[PaperMC/docs] New branch created: contributing/events

#

Machine-Maker

[PaperMC/docs] Pull request opened: #226 Add paper contribution docs for events

#

Machine-Maker

[docs] Branch contributing/events was force-pushed to `eda5730`

Compare changes

lost sealBOT Aug 25, 2023, 8:18 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #226 Add paper contribution docs for events

Few Changes

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #226: Add paper contribution docs for events

this is the bit that shows up in the embed. Maybe make a slightly more user friendly sentence for this, move this down and the note could even go in an amondition

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #226: Add paper contribution docs for events

Why double new lines?

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #226: Add paper contribution docs for events

Maybe requires more than one word. this looks off

lost sealBOT Aug 25, 2023, 11:36 AM

#

A248

[PaperMC/docs] Pull request opened: #227 EventHandlers return void, not null

#

Machine-Maker

[PaperMC/docs] New comment on pull request #227: EventHandlers return void, not null

This is the EventExecutor interface being implemented in the lambda right? I think it also has 2 parameters, the listener and the event.

#

Nacioszeczek

[PaperMC/docs] New comment on pull request #227: EventHandlers return void, not null

This is the EventExecutor interface being implemented in the lambda right? I think it also has 2 parameters, the listener and the event.

The code from the docs does not compile.

#

kennytv

[PaperMC/docs] Pull request review submitted: #185 Add Folia Compatibility info to Paper

#

kennytv

[PaperMC/docs] New review comment on pull request #185: Add Folia Compatibility info to Paper

which will follow it across regions. As an example, let's say I want to set a block to a beehive:

#

kennytv

[PaperMC/docs] New review comment on pull request #185: Add Folia Compatibility info to Paper

as if?

#

kennytv

[PaperMC/docs] New review comment on pull request #185: Add Folia Compatibility info to Paper

In order to support Paper and Folia, you must use the correct scheduler. Folia has different types of schedulers

#

kennytv

[PaperMC/docs] Pull request review submitted: #200 Database docs

#

kennytv

[PaperMC/docs] New review comment on pull request #200: Database docs

To work with SQLite, you will need a driver to connect / initialize the database.

#

kennytv

[PaperMC/docs] New review comment on pull request #200: Database docs

On the other hand, an SQL database is a type of database management system that follows the relational database model.

#

kennytv

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

kennytv

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

If it meets these two criteria, then we will accept changes to fix the bug, as it can take a long time for Mojang to fix

#

kennytv

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

instability on the server. Many of our fixes are configurable, as we understand that some servers may want to keep the

#

kennytv

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

them (Sometimes years). If an issue gets declined by Mojang, we normally do not "fix" it, as it is intended behaviour.

#

kennytv

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

Paper fixes gameplay and mechanic inconsistencies. The most prevalent fixes are to TNT duplication and bedrock breaking.

lost sealBOT Aug 25, 2023, 12:24 PM

#

A248

[PaperMC/docs] New comment on pull request #222: Add comparison matrix to Velocity comparison page

If you haven't any differences between BungeeCord and Waterfall, or you aren't willing to document them, you may want to remove one of the columns entirely.

There are differences. Waterfall guarantees Slf4j and exposes it in the API. On BungeeCord this library happens to be provided, but only due to the recent circumstance of library loading. Moreover, Waterfall has miscellaneous performance improvements to the implementation. I believe there might be a few new events. If we can get https:...

lost sealBOT Aug 25, 2023, 6:25 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

I'm not sure we want to use the word Many here to describe the number of configurable fixes. I would say most aren't configurable. I think Some is better.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #214: Paper bug fixes page

It's possible these are proper nouns as the name of blocks in game so capitalization would be appropriate.

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

lost sealBOT Aug 25, 2023, 6:50 PM

#

Machine-Maker

[docs:contributing/events] 1 new commit

e4b27a3 rework list structure - Machine-Maker

#

olijeffers0n

[PaperMC/docs] New comment on pull request #226: Add paper contribution docs for events

Your .editorconfig has made it in somehow, also need to look at the redirect to check it. Otherwise the content looks generally good

lost sealBOT Aug 25, 2023, 7:11 PM

#

Machine-Maker

[PaperMC/docs] New comment on pull request #226: Add paper contribution docs for events

oh editorconfig should be in, but I guess it can be a different PR.

lost sealBOT Aug 25, 2023, 9:35 PM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #227 EventHandlers return void, not null

lost sealBOT Aug 25, 2023, 11:15 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #226 Add paper contribution docs for events

I’ve looked over the sidebar config and all looks good. Content of the page is good for now and can be added to in the future as needed. Up to you, but i’m happy for this editorconfig to stay here

lost sealBOT Aug 26, 2023, 2:01 AM

#

kennytv

[docs:main] 1 new commit

8cdfd0f Update Hangar publish plugin example - kennytv

lost sealBOT Aug 26, 2023, 7:57 PM

#

lynxplay

[PaperMC/docs] New branch created: feature/sniffer-egg-configuration

#

lynxplay

[docs:feature/sniffer-egg-configuration] 1 new commit

5b9b62f Add sniffer egg configuration - lynxplay

#

lynxplay

[PaperMC/docs] Pull request opened: #228 Add sniffer egg configuration

#

lynxplay

[PaperMC/docs] New review comment on pull request #228: Add sniffer egg configuration

      Boosted hatching occurs when planted on specific blocks.'

#

lynxplay

[PaperMC/docs] Pull request review submitted: #228 Add sniffer egg configuration

#

lynxplay

[docs:feature/sniffer-egg-configuration] 1 new commit

92b871b Update docs/paper/admin/reference/configuration... - lynxplay

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #228 Add sniffer egg configuration

#

olijeffers0n

[PaperMC/docs] New comment on pull request #228: Add sniffer egg configuration

These gonna be durations? If so they need the same comment as the other ones.

#

lynxplay

[docs:feature/sniffer-egg-configuration] 1 new commit

da275f2 Add "in ticks" - lynxplay

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #228 Add sniffer egg configuration

Blocked by the Paper PR, but approved

#

lynxplay

[docs:main] 1 new commit

c4b0d46 Add sniffer egg configuration (#228) - lynxplay

#

lynxplay

[PaperMC/docs] Pull request closed: #228 Add sniffer egg configuration

#

lynxplay

[PaperMC/docs] branch deleted: feature/sniffer-egg-configuration

lost sealBOT Aug 27, 2023, 4:30 PM

#

NotMyFault

[PaperMC/docs] Pull request review submitted: #226 Add paper contribution docs for events

#

NotMyFault

[PaperMC/docs] Pull request closed: #226 Add paper contribution docs for events

#

NotMyFault

[docs:main] 1 new commit

5998426 Add paper contribution docs for events (#226) - Machine-Maker

#

olijeffers0n

[PaperMC/docs] branch deleted: contributing/events

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #227 EventHandlers return void, not null

#

olijeffers0n

[PaperMC/docs] Pull request closed: #227 EventHandlers return void, not null

#

olijeffers0n

[docs:main] 1 new commit

278d709 EventHandlers return void, not null (#227) - A248

#

olijeffers0n

[PaperMC/docs] New comment on pull request #214: Paper bug fixes page

Addressed Comments, some I did not use though as it seemed a bit trigger-happy with the commas and didn't seem correct (with a check online to back me up)

#

olijeffers0n

[PaperMC/docs] New comment on pull request #200: Database docs

Addressed Comments

#

olijeffers0n

[PaperMC/docs] New comment on pull request #185: Add Folia Compatibility info to Paper

Addressed comments and merged main

lost sealBOT Aug 27, 2023, 7:58 PM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

ive decided to keep it, with more of a description with what it does, still saying that you should not touch it

lost sealBOT Aug 27, 2023, 9:14 PM

#

olijeffers0n

[docs:main] 1 new commit

99d29d8 Fix double spaces on lists - olijeffers0n

lost sealBOT Aug 27, 2023, 10:03 PM

#

olijeffers0n

[PaperMC/docs] New comment on commit `d6e2db7`

Extra newline?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

Approved subject to a thorough reading of all descriptions

lost sealBOT Aug 28, 2023, 1:10 AM

#

the456gamer

[PaperMC/docs] Pull request opened: #229 add expected filepaths to config docs

add the filepath to the paper-config files,
merges file info into the "info" block of server.properties to match paper-global and paper-world

side note: i dont know why idea keeps removing the space, i cannot commit without it disappearing

lost sealBOT Aug 28, 2023, 8:05 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #229 add expected filepaths to config docs

#

olijeffers0n

[PaperMC/docs] Pull request closed: #229 add expected filepaths to config docs

#

olijeffers0n

[docs:main] 1 new commit

e49b6e6 add expected filepaths to config docs (#229) - the456gamer

lost sealBOT Aug 28, 2023, 11:11 AM

#

kennytv

[PaperMC/docs] Pull request review submitted: #185 Add Folia Compatibility info to Paper

#

kennytv

[PaperMC/docs] Pull request review submitted: #200 Database docs

lost sealBOT Aug 28, 2023, 12:11 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

It should be finalised now. Ready for review

#

olijeffers0n

[PaperMC/docs] Pull request closed: #185 Add Folia Compatibility info to Paper

#

olijeffers0n

[docs:main] 1 new commit

0ec0b9e Add Folia Compatibility info to Paper (#185) - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

Extra newline

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

        as a probability of 1/<thunder-chance> per chunk, every tick.'

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

        description: 'The range, in blocks, that exp orbs will combine at.'

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

        description: 'The range, in blocks, that items will combine within.'

#

olijeffers0n

[PaperMC/docs] Pull request closed: #200 Database docs

#

olijeffers0n

[docs:main] 1 new commit

21d621b Database docs (#200) - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Issue closed: #106 Working with databases

#

kennytv

[PaperMC/docs] Pull request review submitted: #212 Automate the versioning of doc contents

#

kennytv

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

And this?

#

kennytv

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

Missed this one?

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

Whoops, Yep addressed that

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

lost sealBOT Aug 28, 2023, 2:15 PM

#

Machine-Maker

[PaperMC/docs] Pull request review dismissed: #212 Automate the versioning of doc contents

lost sealBOT Aug 28, 2023, 3:02 PM

#

the456gamer

[PaperMC/docs] Pull request opened: #230 add bukkit.yml docs

this one is shorter than spigot.yml

lost sealBOT Aug 28, 2023, 7:30 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

Looks pretty good, just one thing

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

Use a relative URL please

lost sealBOT Aug 28, 2023, 7:46 PM

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

      Capped by paper to be 20 ticks (1 second).'

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

    description: 'How long of a delay to enforce between connections from an IP address.

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

      The message is formatted with legacy "§" style formatting.'

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

    description: 'Number of ticks between each full auto-save. Set to -1 to disable auto-save.'

lost sealBOT Aug 28, 2023, 8:12 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

    description: 'File to load server permissions from.'

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

      Measured in milliseconds since last attempt.'

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

empty line?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

Needed for markdown formatting

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

    description: 'The kick message for the player when the server shuts down.

#

the456gamer

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

expected so wrapping is skipped imo. can still remove if you want

lost sealBOT Aug 29, 2023, 4:00 AM

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

If -1, uses default.

Personally I don't like how this part sounds

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

      This can be overridden by the [paper-world config](/paper/reference/world-configuration).'

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

same here

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

Maybe this should explain how it works, or link to a page explaining it. And that it's usually not used anymore (to my knowledge?)

#

powercasgamer

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

      This can be overridden by the [paper-world config](/paper/reference/world-configuration).'

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

      description: 'The number of ticks before an arrow despawns.'

#

powercasgamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

      description: 'Whether to allow zombified piglins to spawn inside nether portals.

right now some mobs are "Zombie" whilst others are "zombie"

#

powercasgamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

      description: 'Overrides the simulation distance. Set to -1 or "default" to use the value in server.properties'

lost sealBOT Aug 29, 2023, 7:28 AM

#

olijeffers0n

[docs:main] 1 new commit

4d26fc6 Lose the Paper in the config sidebar ready fo... - olijeffers0n

lost sealBOT Aug 29, 2023, 7:49 AM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #231 Remove doubly nested A tags that trigger browser errors

lost sealBOT Aug 29, 2023, 9:02 AM

#

granny

[PaperMC/docs] Pull request opened: #232 add button that expands/collapses all config descriptions

This PR adds a button that lets you expand or collapse all the config descriptions at once. I've also taken the liberty of fixing some of the linter warnings I was getting, as well as some weird issues that I ran into while attempting to implement this feature.

I've also attached a showDescriptions parameter to the Config component that defaults to false. Setting it to true will expand all the descriptions initially. It might be useful to show all descriptions for smaller configs by ...

lost sealBOT Aug 29, 2023, 10:05 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

lost sealBOT Aug 29, 2023, 11:33 AM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

#

MiniDigger

[PaperMC/docs] New review comment on pull request #232: add button that expands/collapses all config descriptions

codeblock as a classname is a bit generic here, considering its only position relative, maybe configblock?

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

only a nitpick

lost sealBOT Aug 29, 2023, 12:02 PM

#

granny

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

#

granny

[PaperMC/docs] New review comment on pull request #232: add button that expands/collapses all config descriptions

The sole purpose of the "position relative" class is to make it possible for a "position absolute" class to position correctly in whatever element it resides in. I originally renamed it to config-button-parent before changing my mind and naming it relative-container since it could be useful in other places in the future.

#

granny

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

#

granny

[PaperMC/docs] New review comment on pull request #232: add button that expands/collapses all config descriptions

Just realized I could also call it config-container :man_shrugging:

lost sealBOT Aug 29, 2023, 1:45 PM

#

olijeffers0n

[docs:main] 1 new commit

20bd455 Downloads -> Download - olijeffers0n

lost sealBOT Aug 29, 2023, 8:22 PM

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #232: add button that expands/collapses all config descriptions

This class isn’t used?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

#

granny

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

lost sealBOT Aug 29, 2023, 8:57 PM

#

granny

[PaperMC/docs] New review comment on pull request #232: add button that expands/collapses all config descriptions

fixed.. i got too hyperfocused on the naming lol

lost sealBOT Aug 29, 2023, 10:36 PM

#

the456gamer

[PaperMC/docs] Pull request opened: #233 add commands yml documentation

also disable ligatures in config objects. only issue i can think of is if there is a code example in a config description, but that probably should have its own page anyway

lost sealBOT Aug 29, 2023, 10:56 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #233 add commands yml documentation

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

Weird Diff

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

Worded weirdly; More like “Which commands should override…” also is it overriding vanilla or overriding bukkit? If it is the Vanilla command being used i think override is a weird word in the description (i know it’s in the key) just because it’s more of a defaulting action

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

I’m not a fan of this slug / file name. This should indicate more that it is the outdated bukkit commands config rather than anything you need for plugins

lost sealBOT Aug 30, 2023, 3:13 AM

#

kennytv

[PaperMC/docs] Pull request review submitted: #214 Paper bug fixes page

#

kennytv

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

#

kennytv

[PaperMC/docs] Pull request review submitted: #231 Remove doubly nested A tags that trigger browser errors

lost sealBOT Aug 30, 2023, 4:38 AM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #233 add commands yml documentation

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

Bukkit not bukkit

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

Paper not paper

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

I don't think this (List, String) should be uppercased like class names, people reading this won't care that it's a Java class

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #233 add commands yml documentation

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #233: add commands yml documentation

be (easily) be

lost sealBOT Aug 30, 2023, 6:46 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #232 add button that expands/collapses all config descriptions

#

olijeffers0n

[PaperMC/docs] Pull request closed: #232 add button that expands/collapses all config descriptions

#

olijeffers0n

[docs:main] 1 new commit

b097e9b Add button that expands/collapses all config de... - granny

#

olijeffers0n

[PaperMC/docs] Pull request closed: #214 Paper bug fixes page

#

olijeffers0n

[docs:main] 1 new commit

5f4ea25 Paper bug fixes page (#214) - olijeffers0n

#

MiniDigger

[PaperMC/docs] New comment on pull request #231: Remove doubly nested A tags that trigger browser errors

while at it, maybe add a title attribute with the name of the config option to all links for better accessibility and seo
since the links with the anchors come after the actual text, browsers and crawlers dont know what the link refers to.

lost sealBOT Aug 30, 2023, 9:15 AM

#

granny

[PaperMC/docs] Pull request opened: #234 Make config nodes accessible through keyboard shortcuts

This PR replaces the anchor element used for the config nodes with the button element. clean-btn and button--link are applied to render the button the same as an anchor element, and config-node is used for any leftover stylings required to keep visual parity.

https://github.com/PaperMC/docs/assets/43185817/62efe4ca-4f5b-4e59-a836-8655f46ad953

Near the end of the video I notice a weird inconsistency with the config descriptions for the hidden-blocks and replacement-blocks showi...

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #234 Make config nodes accessible through keyboard shortcuts

Does appear to maintain functionality whilst improving accessibility. Personally I have no experience with accessibility but this seems like a step in the right direction

lost sealBOT Aug 30, 2023, 10:21 AM

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #234 Make config nodes accessible through keyboard shortcuts

lgtm

#

olijeffers0n

[PaperMC/docs] Pull request closed: #234 Make config nodes accessible through keyboard shortcuts

#

olijeffers0n

[docs:main] 1 new commit

914f40e use buttons styled as links for config nodes (#... - granny

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #233 add commands yml documentation

lost sealBOT Aug 30, 2023, 11:46 AM

#

olijeffers0n

[docs:main] 1 new commit

880bd7d Don't use N/A for the server properties file - olijeffers0n

lost sealBOT Aug 30, 2023, 1:24 PM

#

olijeffers0n

[docs:main] 1 new commit

bdea195 chore: include css in .editorconfig - olijeffers0n

lost sealBOT Aug 30, 2023, 2:43 PM

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

Missing a uppercase letter to start the sentence but this could be reworded

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

This would be convenient if all other settings reference was clickable to their own page. Applies for others

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

    description: 'How often to shuffle the list of player connections, in ticks, with -1 to disable.

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

You can link directly to the right node: /paper/reference/world-configuration#entities_spawning_alt_item_despawn_rate

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

Can link to that said value

lost sealBOT Aug 30, 2023, 3:15 PM

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

I think a lot of - can be removed there to improve readability. Same below

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

I think only the paper.alwaysPrintWarningState part should be the link

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

This need a reference to /paper/dev/plugin-yml#api-version or at least explain that this doesn't include minor version and start from 1.13.

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #230: add bukkit.yml docs

The link should be on the correct node. Applies for others

#

olijeffers0n

[PaperMC/docs] Pull request opened: #235 Add a title to the YAML elements for SEO

lost sealBOT Aug 30, 2023, 6:44 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #236 Rework navigating configuration pages.

Opening this as a PR to allow discussion, review and so i don’t forget it lol. Same as I showed in discord earlier.

lost sealBOT Aug 30, 2023, 7:56 PM

#

olijeffers0n

[PaperMC/docs] Pull request closed: #235 Add a title to the YAML elements for SEO

#

olijeffers0n

[docs:main] 1 new commit

5144570 Add a title to the YAML elements for SEO (#235) - olijeffers0n

lost sealBOT Aug 30, 2023, 8:41 PM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

i was going off of being a complete reference, from what was generated. Im viewing it from the perspective of someone who has no idea what it might mean, so having somewhere to tell them to leave it alone is beneficial. (probably for paper configs as well)

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

was a pain, but think i got it

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

done

lost sealBOT Aug 31, 2023, 12:32 AM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #236 Rework navigating configuration pages.

#

the456gamer

[PaperMC/docs] New review comment on pull request #236: Rework navigating configuration pages.

Change to <world> because it's every world folder, not specific ones only?

        name: "<world>",

lost sealBOT Aug 31, 2023, 4:41 AM

#

Nacioszeczek

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

Could we also automate stuff like the jar name, e.g. here?

lost sealBOT Aug 31, 2023, 7:17 AM

#

MiniDigger

[PaperMC/docs] New comment on pull request #236: Rework navigating configuration pages.

I think I would remove the border around the files, make them proper links, and remove the color from the folder, since they are not links
I also would want to expand this to include all files paper creates. not every file (like the whitelist or the usercache or whatever) need a whole page, maybe those could have a popup when you click on them with a short text? that popup could be reused for the config files that arent documented yet.

lost sealBOT Aug 31, 2023, 2:05 PM

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

        description: 'The range, in blocks, that exp orbs will combine at.
          This behavior is not present in Vanilla and doesn't impact the usual merge range once spawned.
          Set to 0 to disable.'

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

okay i see, i just feel the default should probably just be <version> or something to avoid to update that each time the version change since it's not important here, feel free to update the other config as well

lost sealBOT Aug 31, 2023, 2:33 PM

#

Warriorrrr

[PaperMC/docs] Pull request opened: #237 Remove reference to a guide that doesn't exist

This bit used to be commented out, but after the big config revamp the comment part was removed

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #237 Remove reference to a guide that doesn't exist

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #237 Remove reference to a guide that doesn't exist

#

olijeffers0n

[PaperMC/docs] Pull request closed: #237 Remove reference to a guide that doesn't exist

#

olijeffers0n

[docs:main] 1 new commit

8e1661f Remove reference to a guide that doesn't exist ... - Warriorrrr

lost sealBOT Aug 31, 2023, 2:59 PM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

slightly altered compared to the suggestion, what do you think?

#

the456gamer

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

for this config ive changed it to an empty string, displaying "N/A" in the actual docs

#

Lulu13022002

[PaperMC/docs] New review comment on pull request #221: add spigot.yml docs

yes it's fine :+1:

#

Lulu13022002

[PaperMC/docs] Pull request review submitted: #221 add spigot.yml docs

lost sealBOT Aug 31, 2023, 5:03 PM

#

Warriorrrr

[PaperMC/docs] Pull request opened: #238 Mention disabling server.props online mode in forwarding guide

Not too sure on the wording, so suggestions welcomed. Disabling online mode in the server.properties is mentioned in the getting started guide at the very bottom, but worth mentioning on this page aswell

do we also want to mention this in the legacy forwarding part?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #238 Mention disabling server.props online mode in forwarding guide

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #238: Mention disabling server.props online mode in forwarding guide

Could link to the file here

lost sealBOT Aug 31, 2023, 6:23 PM

#

powercasgamer

[PaperMC/docs] Pull request opened: #239 fix typo

#

Warriorrrr

[PaperMC/docs] Pull request review submitted: #239 fix typo

lost sealBOT Aug 31, 2023, 7:12 PM

#

olijeffers0n

[PaperMC/docs] Pull request closed: #239 fix typo

#

olijeffers0n

[docs:main] 1 new commit

9d17675 fix typo (#239) - powercasgamer

#

olijeffers0n

[PaperMC/docs] Pull request closed: #231 Remove doubly nested A tags that trigger browser errors

#

olijeffers0n

[docs:main] 1 new commit

a1350da Remove doubly nested A tags that trigger browse... - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New comment on pull request #238: Mention disabling server.props online mode in forwarding guide

Probably best to use the direct link? Its /paper/reference/server-properties#online_mode

lost sealBOT Aug 31, 2023, 8:15 PM

#

Warriorrrr

[PaperMC/docs] New comment on pull request #238: Mention disabling server.props online mode in forwarding guide

That's better yeah, thanks

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #238 Mention disabling server.props online mode in forwarding guide

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #238 Mention disabling server.props online mode in forwarding guide

#

olijeffers0n

[PaperMC/docs] Pull request closed: #238 Mention disabling server.props online mode in forwarding guide

#

olijeffers0n

[docs:main] 1 new commit

eb5789e Mention disabling server.props online mode in f... - Warriorrrr

lost sealBOT Sep 5, 2023, 11:25 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #212: Automate the versioning of doc contents

For all intents and purposes, this PR is now finished so a review would be appreciated 😄 - Kenny's review was a while ago now

lost sealBOT Sep 5, 2023, 11:50 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #233: add commands yml documentation

Still not a huge fan of "commands configuration" as a title, I feel like it makes it sound way more useful than it is... Not sure?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #230 add bukkit.yml docs

#

olijeffers0n

[PaperMC/docs] Pull request closed: #230 add bukkit.yml docs

#

olijeffers0n

[docs:main] 1 new commit

9102099 add bukkit.yml docs (#230) - the456gamer

#

olijeffers0n

[PaperMC/docs] Pull request closed: #221 add spigot.yml docs

#

olijeffers0n

[docs:main] 1 new commit

ca44825 add spigot.yml docs (#221) - the456gamer

lost sealBOT Sep 6, 2023, 5:37 AM

#

olijeffers0n

[docs:main] 1 new commit

396aa5b Use MoveEvent rather than join event - olijeffers0n

lost sealBOT Sep 8, 2023, 2:44 PM

#

MiniDigger

[docs:faq] 1 new commit

d1b9b93 Add faq page and java version check info - MiniDigger

#

MiniDigger

[PaperMC/docs] New branch created: faq

#

MiniDigger

[PaperMC/docs] Pull request opened: #240 Add faq page and java version check info

https://github.com/PaperMC/Paper/pull/9692

#

Warriorrrr

[PaperMC/docs] Pull request review submitted: #240 Add faq page and java version check info

#

Warriorrrr

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

Should probably not be removed

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #240 Add faq page and java version check info

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

Direct link with anchor is probably more useful here?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #240 Add faq page and java version check info

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

Double empty lines

#

MiniDigger

[docs] Branch faq was force-pushed to `048ed9f`

Compare changes

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #240 Add faq page and java version check info

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

- **description**: Allows you to bypass the java version check. See [here](/paper/misc/faq#unsupported-java-detected-what-do-i-do) for more info.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

Unsupported, early-access, or internal versions of Java are often missing features, have known issues or be straight up broken.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

If you still wish to continue, knowing that you are on your own and will receive NO support, you can disable the check, a system property, as explained [here](/paper/reference/system-properties#paperignorejavaversion).

#

MiniDigger

[docs:faq] 1 new commit

666361c Update docs/paper/admin/misc/faq.md - MiniDigger

#

MiniDigger

[docs:faq] 1 new commit

1e05754 Update docs/paper/admin/reference/system-proper... - MiniDigger

#

MiniDigger

[docs] Branch faq was force-pushed to `81d1549`

Compare changes

#

MiniDigger

[docs] Branch faq was force-pushed to `abcaff5`

Compare changes

#

Warriorrrr

[docs:main] 1 new commit

504e10d Add missing ` - Warriorrrr

lost sealBOT Sep 8, 2023, 4:19 PM

#

olijeffers0n

[docs:main] 1 new commit

2191428 Update event-listeners.md - olijeffers0n

lost sealBOT Sep 8, 2023, 4:48 PM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #240 Add faq page and java version check info

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #240: Add faq page and java version check info

Java would look better than java

lost sealBOT Sep 9, 2023, 8:27 PM

#

olijeffers0n

[docs:faq] 1 new commit

a065aee java - - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #240 Add faq page and java version check info

#

olijeffers0n

[PaperMC/docs] Pull request closed: #240 Add faq page and java version check info

#

olijeffers0n

[docs:main] 1 new commit

b920a15 Add faq page and java version check info (#240) - MiniDigger

#

olijeffers0n

[PaperMC/docs] branch deleted: faq

lost sealBOT Sep 10, 2023, 4:26 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

Could link reflection-remapper in the reflection section?

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

    return CRAFTBUKKIT_PACKAGE + "." + clazz;

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

Class.forName(cbClass("entity.CraftBee"));

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

To access Paper internals, you can use the [paperweight-userdev](https://github.com/PaperMC/paperweight-test-plugin)
gradle plugin. This will allow you to decompile the server and access the NMS and CraftBukkit code. You can

lost sealBOT Sep 10, 2023, 5:10 PM

#

Nacioszeczek

[docs:main] 1 new commit

4f8e7df link and correct Paper configs in migration guide - Nacioszeczek

lost sealBOT Sep 10, 2023, 6:32 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

Coolio, addressed comments

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

lost sealBOT Sep 10, 2023, 8:16 PM

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #222: Add comparison matrix to Velocity comparison page

Tabs not spaces

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #222 Add comparison matrix to Velocity comparison page

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #222: Add comparison matrix to Velocity comparison page

 Snap is not maintained by, or affiliated with, the Velocity project._

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #222 Add comparison matrix to Velocity comparison page

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #222 Add comparison matrix to Velocity comparison page

#

Warriorrrr

[PaperMC/docs] Pull request review submitted: #222 Add comparison matrix to Velocity comparison page

#

olijeffers0n

[PaperMC/docs] Pull request closed: #222 Add comparison matrix to Velocity comparison page

#

olijeffers0n

[docs:main] 1 new commit

5173641 Add comparison matrix to Velocity comparison pa... - Malfrador

lost sealBOT Sep 12, 2023, 2:09 PM

#

Leguan16

[PaperMC/docs] Pull request opened: #242 add compression-level description

This adds the necessary description for the new compression-level config option in config/paper-global.yml

See https://github.com/PaperMC/Paper/pull/9711

#

Nacioszeczek

[PaperMC/docs] New comment on pull request #242: add compression-level description

Waiting for the changes to be merged into Paper

lost sealBOT Sep 12, 2023, 4:26 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #242 add compression-level description

Blocking for paper merge. Also, can you doc what the default value is please? In the description that is please ☺️

#

Leguan16

[PaperMC/docs] New comment on pull request #242: add compression-level description

well, i checked if default values in the other places (where IntOr is used) are present and they aren't so I did not include it here as well for consistency.

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

wellllll, this is not exactly true, nowadays with mojang mappings we have much more packages

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

"add the dependencies" is pretty generic, especially considering you mention paperweight below (without saying its adding the dependencies)

#

lynxplay

[PaperMC/docs] New comment on pull request #242: add compression-level description

Not that -1 would be of much use to the docs. The default is up to the deflate impl

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

if you mention this, should at least say something about caching stuff

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

should add a "unless you use the mojang mapped version of paper" here

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

this is only partly true, since paper fully deobfuscates this, I would say something like "in order to provide compability with legacy plugins, paper is reobfuscated at runtime" or something

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

deobfuscated, mojang mapped, names

#

MiniDigger

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

should also add a reference to the data version here

#

MiniDigger

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

MiniDigger

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

generally, I have a really meh feeling about this. its nice that we have a place where we can say that people should depend on the package including the version, but the rest needs a bit more meat to be useful.
it also needs a ton of disclaimers and stuff that API should always be preferred, that using internals can cause damage if you dont know what you are doing, that there is no support, etc
I also dont like using the legacy, misleading, NMS term so often. its important that we explain ...

lost sealBOT Sep 12, 2023, 5:35 PM

#

Leguan16

[PaperMC/docs] New comment on pull request #242: add compression-level description

Not that -1 would be of much use to the docs. The default is up to the deflate impl

does that mean that including the value is unnecessary or not?

#

lynxplay

[PaperMC/docs] New comment on pull request #242: add compression-level description

Can include the -1 being default, just you need to also explain that -1 means the compression will choose a sensible compression level.

lost sealBOT Sep 12, 2023, 9:41 PM

#

Leguan16

[PaperMC/docs] New comment on pull request #242: add compression-level description

Can include the -1 being default, just you need to also explain that -1 means the compression will choose a sensible compression level.

Should I also mention that Paper is using the velocity compressor and that the default is 6?

lost sealBOT Sep 12, 2023, 9:56 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #242: add compression-level description

Personally i would say yes, as it gives people something to use as a reference to their values as well.

lost sealBOT Sep 12, 2023, 10:22 PM

#

Leguan16

[PaperMC/docs] New comment on pull request #242: add compression-level description

I hope this makes sense lol

#

olijeffers0n

[PaperMC/docs] New comment on pull request #242: add compression-level description

Yeah looks ok 👌

lost sealBOT Sep 13, 2023, 12:06 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

I'm not sure here? If someone else could give me a pointer please and thanks

#

olijeffers0n

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

I see what you mean. I have reworked the guide to refer to it as internal code rather than NMS, but still explain the abbreviation at the start. Let me know what you think - there is also a big danger admonition at the top

lost sealBOT Sep 13, 2023, 12:27 PM

#

MiniDigger

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

that reads better, just two things, we should have some headline with the nms term for seo purposes, maybe "what is nms" and explain the term there.
and the alert should have a sentence about prefering api instead.

lost sealBOT Sep 13, 2023, 1:29 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

Yeah, addressed 👍

lost sealBOT Sep 13, 2023, 6:39 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

Using Minecraft internals is not recommended. This is because using the internals directly is not guaranteed to be

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

We recommend using the [Paperweight Userdev](https://github.com/PaperMC/paperweight-test-plugin)

maybe?

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #242 add compression-level description

#

powercasgamer

[PaperMC/docs] New review comment on pull request #242: add compression-level description

    description: 'A higher compression level means less data transmitted at the cost of more CPU time.

lost sealBOT Sep 13, 2023, 7:25 PM

#

Leguan16

[PaperMC/docs] New comment on pull request #242: add compression-level description

changed

lost sealBOT Sep 13, 2023, 7:41 PM

#

powercasgamer

[PaperMC/docs] Pull request opened: #243 fix: mention of Paper plugins in Velocity

@olijeffers0n !

#

powercasgamer

[PaperMC/docs] New review comment on pull request #243: fix: mention of Paper plugins in Velocity

Plugin messaging is a way for Velocity plugins to communicate with clients and servers.

need opinions on this

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #243 fix: mention of Paper plugins in Velocity

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #243 fix: mention of Paper plugins in Velocity

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #243: fix: mention of Paper plugins in Velocity

I think the backend is good here

#

olijeffers0n

[PaperMC/docs] Pull request closed: #243 fix: mention of Paper plugins in Velocity

#

olijeffers0n

[docs:main] 1 new commit

d23a881 this is Velocity, not Paper (#243) - powercasgamer

lost sealBOT Sep 14, 2023, 6:54 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #242 add compression-level description

lost sealBOT Sep 14, 2023, 11:02 AM

#

lynxplay

[PaperMC/docs] Pull request review submitted: #242 add compression-level description

#

olijeffers0n

[PaperMC/docs] Pull request review dismissed: #242 add compression-level description

Blocking for paper merge. Also, can you doc what the default value is please? In the description that is please ☺️

#

lynxplay

[PaperMC/docs] Pull request closed: #242 add compression-level description

#

lynxplay

[docs:main] 1 new commit

8e3d161 add compression-level description (#242) - Leguan16

lost sealBOT Sep 14, 2023, 8:50 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

It shouldn't say We either I think. Using pw userdev is recommended....

lost sealBOT Sep 19, 2023, 9:15 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

Comments addressed :smile:

lost sealBOT Sep 19, 2023, 9:51 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

understand. Paper deobfuscates these identifiers for development, however in order to provide compatibility with legacy

comma here? or after however?

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

Using Minecraft internals is not recommended. This is because using internals directly is not guaranteed to be

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

The internal CraftBukkit code is relocated to `org.bukkit.craftbukkit.<version>`. This means that any attempts to reflect
must include the version. For example, `org.bukkit.craftbukkit.v1_20_R1.CraftServer` is the class for the server in
version 1.20.1. You can access these classes easily with some reflection utilities.

I don't really like this part personally

For example, org.bukkit.craftbukkit.v1_20_R1.CraftServer is the class for the server in
version 1.20.1.

lost sealBOT Sep 20, 2023, 4:46 PM

#

olijeffers0n

[PaperMC/docs] Pull request opened: #244 Add comments to all files

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #244 Add comments to all files

#

lynxplay

[PaperMC/docs] Pull request review submitted: #244 Add comments to all files

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #244 Add comments to all files

#

powercasgamer

[PaperMC/docs] New review comment on pull request #244: Add comments to all files

description: An overview to how Folia's regionizer works.

maybe?

#

powercasgamer

[PaperMC/docs] New review comment on pull request #244: Add comments to all files

description: Paper provides a downloads API that you can use to access builds.

#

powercasgamer

[PaperMC/docs] New review comment on pull request #244: Add comments to all files

description: An explanation of Bukkit's configuration file.

to match the other descriptions

#

powercasgamer

[PaperMC/docs] New review comment on pull request #244: Add comments to all files

description: An explanation of Spigot's configuration file.

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #244 Add comments to all files

#

powercasgamer

[PaperMC/docs] New review comment on pull request #244: Add comments to all files

description: Questions frequently asked by our community, answered by us!

or

description: Frequently asked Folia questions.

to match this or this

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #244 Add comments to all files

#

olijeffers0n

[PaperMC/docs] Pull request closed: #244 Add comments to all files

#

olijeffers0n

[docs:main] 1 new commit

03bf7ea Add comments to all files (#244) - olijeffers0n

lost sealBOT Sep 22, 2023, 6:37 AM

#

Nacioszeczek

[docs:main] 1 new commit

e8ef994 Waterfall EOL; add and move up warnings - Nacioszeczek

lost sealBOT Sep 22, 2023, 7:24 AM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

Nacioszeczek

[PaperMC/docs] New review comment on pull request #241: Add a brief overview to what NMS code is

Mojmapped JAR is not relocated

lost sealBOT Sep 23, 2023, 3:42 PM

#

Nacioszeczek

[PaperMC/docs] Pull request review submitted: #241 Add a brief overview to what NMS code is

#

olijeffers0n

[PaperMC/docs] Pull request closed: #241 Add a brief overview to what NMS code is

#

olijeffers0n

[docs:main] 1 new commit

95ad5a5 Add a brief overview to what NMS code is (#241) - olijeffers0n

lost sealBOT Sep 23, 2023, 6:14 PM

#

Nacioszeczek

[docs:main] 2 new commits

997e614 replace tabs with spaces - Nacioszeczek
3e39d2d don't use snapshots in custom InventoryHolders - Nacioszeczek

#

Nacioszeczek

[PaperMC/docs] New comment on issue #179: Consider editing the Custom InventoryHolder Page within the Paper Documentation

Fixed by 3e39d2d6e49310fa6e15e1288723b045bb58b409

#

Nacioszeczek

[PaperMC/docs] Issue closed: #179 Consider editing the Custom InventoryHolder Page within the Paper Documentation

#

Nacioszeczek

[PaperMC/docs] New comment on issue #125: Bukkit/Spigot configs and Paper's additions to them aren't documented

Partially fixed by #209, #221 and #230.
We should probably still explain commands.yml, help.yml and permissions.yml?
cc @olijeffers0n

lost sealBOT Sep 23, 2023, 7:19 PM

#

Machine-Maker

[docs:main] 1 new commit

cc1f786 add missing extensions to editorconfig - Machine-Maker

lost sealBOT Sep 23, 2023, 10:01 PM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #236 Rework navigating configuration pages.

#

the456gamer

[PaperMC/docs] New review comment on pull request #236: Rework navigating configuration pages.

fixes the blue (i) visible through the description box, tested on firefox

                        <span className={"config-explorer-popup-window-open-tag"} onMouseEnter={handleNodeOpening}>ⓘ</span>

lost sealBOT Sep 24, 2023, 9:50 AM

#

MiniDigger

[PaperMC/docs] New comment on pull request #241: Add a brief overview to what NMS code is

since you added mojmap, maybe that deserves its own paragraph. running a mojmapped server is a good way to simplify the toolchain for people that only write in house plugins, makes debugging easier, allows for hotswapping, etc.

lost sealBOT Sep 24, 2023, 3:09 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #236: Rework navigating configuration pages.

Worked on it a bit however I still can't work out how to align them on the z axis

#

olijeffers0n

[docs:main] 1 new commit

78158e0 Add a comment for mojmap - olijeffers0n

lost sealBOT Sep 24, 2023, 9:42 PM

#

Nacioszeczek

[docs:main] 1 new commit

71253f4 replace Minecraft Wiki links - Nacioszeczek

lost sealBOT Sep 27, 2023, 4:56 PM

#

the456gamer

[PaperMC/docs] Pull request opened: #245 re-write velocity plugin messaging docs

i also moved it from the how-to folder to the API folder, to match the sidebar, but I'm unsure if thats the correct thing to do.

lost sealBOT Sep 27, 2023, 6:04 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

## Case 2: Sending a plugin message to a backend server

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

Additionally, BungeeCord channel compatibility is included, which may remove the need for a companion Velocity plugin in certain cases.

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

    return server.sendPluginMessage(identifier, data);

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

When you need to receive messages from your backend server.

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

    player -->|"1 (Incoming)"| Velocity -->|"2 (Outgoing)"| backend
    backend -->|"3 (Incoming)"| Velocity -->|"4 (Outgoing)"| player

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

this sentence doesn't make a whole lot of sense

#

powercasgamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

this might need a redirect?

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

I separated that so it explicitly says that it returns if it is successful, but I should probably include that in the docs itself

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

Since velocity has a target of java 11, it's not valid for all versions.

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

Nope, that's the path on disk. The slug (at top of file) is unchanged

lost sealBOT Sep 27, 2023, 11:25 PM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

same as above

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

same as above

lost sealBOT Sep 28, 2023, 9:30 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

Additionally, BungeeCord compatibility is included, which may remove the need for a companion Velocity plugin in certain cases.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

Velocity manages connections in both directions, for both the client and backend server. This means Velocity
plugins need to consider 4 main cases:

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

This is for when you need to handle or inspect the contents of a plugin message sent by a player. You must register with the ChannelRegistrar for the event to be fired. An example use case could be logging messages from a mod that reports the enabled features.

Too many newlines - too disjointed (this might not have changed i just didn't like it :))

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

This is for when you need to receive messages from your backend server. It will require registering with the ChannelRegistrar for the event to be fired.

An example use might be handing a request to transfer the player to another server.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

This is for when you need to send a message to a player.

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

i specifically included "channel" as other aspects aren't compatible (i.e plugins)

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

cool beans, just apply the rest of the diff please and thanks 🙏

lost sealBOT Sep 28, 2023, 10:17 PM

#

the456gamer

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

#

the456gamer

[PaperMC/docs] New review comment on pull request #245: re-write velocity plugin messaging docs

is this better?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #245 re-write velocity plugin messaging docs

lost sealBOT Sep 28, 2023, 11:15 PM

#

SrBedrock

[PaperMC/docs] New comment on pull request #245: re-write velocity plugin messaging docs

the next button on this page takes you to the paper's docs, is that on purpose?

lost sealBOT Sep 28, 2023, 11:48 PM

#

the456gamer

[PaperMC/docs] New comment on pull request #245: re-write velocity plugin messaging docs

no, but its also present in production https://docs.papermc.io/velocity/dev/component-api/introduction

lost sealBOT Sep 30, 2023, 8:28 PM

#

olijeffers0n

[PaperMC/docs] Pull request closed: #245 re-write velocity plugin messaging docs

#

olijeffers0n

[docs:main] 1 new commit

0cf7b8c Re-write velocity plugin messaging docs (#245) - the456gamer

lost sealBOT Oct 4, 2023, 5:40 PM

#

Machine-Maker

[docs:fix/tracking-range-y] 1 new commit

12783ad Add tracking range Y & fix monster light level - Machine-Maker

#

Machine-Maker

[PaperMC/docs] New branch created: fix/tracking-range-y

#

Machine-Maker

[PaperMC/docs] Pull request opened: #246 Add tracking range Y & fix monster light level

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #246 Add tracking range Y & fix monster light level

lost sealBOT Oct 4, 2023, 10:13 PM

#

Machine-Maker

[PaperMC/docs] Pull request closed: #246 Add tracking range Y & fix monster light level

#

Machine-Maker

[docs:main] 1 new commit

b040d26 Add tracking range Y & fix monster light level ... - Machine-Maker

#

Machine-Maker

[PaperMC/docs] branch deleted: fix/tracking-range-y

lost sealBOT Oct 6, 2023, 7:17 AM

#

Lo-velo

[PaperMC/docs] Pull request opened: #247 Latest information update

Velocity is not in active development. This is true.
https://github.com/PaperMC/Velocity/issues/1093

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #247 Latest information update

Velocity is still being worked on.

lost sealBOT Oct 6, 2023, 8:15 AM

#

Nacioszeczek

[PaperMC/docs] Pull request closed: #247 Latest information update

#

me4502

[PaperMC/docs] Pull request review submitted: #180 Migration Guides

#

me4502

[PaperMC/docs] New review comment on pull request #180: Migration Guides

I don't believe this line is true? There were numerous items that did not have a block equivalent at that point in time. stick, flint, coal, string, most of the non-cake food items, etc

lost sealBOT Oct 6, 2023, 7:19 PM

#

powercasgamer

[PaperMC/docs] Pull request opened: #248 remove doc link in footer

#

Nacioszeczek

[PaperMC/docs] Pull request closed: #248 remove doc link in footer

#

Nacioszeczek

[docs:main] 1 new commit

25b8891 remove doc link in footer (#248) - powercasgamer

lost sealBOT Oct 6, 2023, 8:37 PM

#

Leguan16

[PaperMC/docs] Pull request opened: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

As communicated in the discord I took the initiative to add a tutorial for creating a project with help of the Minecraft Development IntelliJ plugin.

I did not yet take a look at typos or grammar and just want to gather some feedback for the overall structure.
I also changed the current project-setup markdown file to manual-project-setup.
The new_project_filled.png currently is not in use. This might or might not be added later.
For the list to explain the fields when creating...

lost sealBOT Oct 6, 2023, 9:16 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

powercasgamer

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

redirect might be required here?

#

powercasgamer

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

You should use a domain you own, so something like io.github.<username>.<project> or me.<username> is also commonly used

#

powercasgamer

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

If you want to streamline the process of testing a plugin, you can use the [Run-Paper]https://github.com/jpenilla/run-task) Gradle plugin.

#

Leguan16

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

Leguan16

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

but you most likely don't own me.<name> and not everybody has a GitHub account. I don't think this is to change.

#

Leguan16

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

Leguan16

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

from to? i cannot follow.

lost sealBOT Oct 7, 2023, 3:08 AM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Don’t like this slug

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

new line please

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Bleh, don’t like manual. Just leave it as project setup and then have the mcdev example

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

yes, you cannot just change slugs. You need to set a redirect in the vercel file

lost sealBOT Oct 7, 2023, 4:14 AM

#

Leguan16

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

Leguan16

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

alright

lost sealBOT Oct 7, 2023, 2:20 PM

#

Leguan16

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Alright,
I changed a few things:

I moved project-setup and mcdev-project-setup to a separate subsection project-setup
I changed the list to a table
I reverted the slug

Now, with those changes I don't think we should leave the current project setup tutorial named "Paper Project Setup" since it should be obvious that we try to create a paper project. And it would look better if its just named "Project Setup" and the other one is called "McDev Project Setup". Maybe even just...

#

olijeffers0n

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Yeah so this is ready for content reviews - i’m happy with the addition of a new folder but you need to add a redirect for the slug change :)

#

Leguan16

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Yeah so this is ready for content reviews - i’m happy with the addition of a new folder but you need to add a redirect for the slug change :)

Dang it i forgot it again xd

#

Leguan16

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

I think i changed it?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Just one thing really, redirect lgtm

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

I think clarifying the two “plugin”s is needed

#

Leguan16

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

Leguan16

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Something like this?

description: Step-by-step instructions on how to setup a plugin with the MinecraftDev IntelliJ plugin.

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

maybe change the first plugin to project and keep that Intelljj

#

Leguan16

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Ok I changed it. Will push when I have more feedback.

#

Leguan16

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

lost sealBOT Oct 7, 2023, 8:49 PM

#

olijeffers0n

[PaperMC/docs] Issue opened: #250 Examples on how to use the downloads API

1-2 simple examples of getting builds of a version or something on https://docs.papermc.io/misc/downloads-api.

These would probably be more useful than the Swagger docs

lost sealBOT Oct 8, 2023, 9:20 AM

#

notTamion

[PaperMC/docs] Issue opened: #251 Reference CONTRIBUTING.md in Contributing docs

Since the CONTRIBUTING.md file in the Paper repository is the main source for information on contributing i think referencing or featuring it in the docs would be a good idea.

lost sealBOT Oct 8, 2023, 9:57 AM

#

olijeffers0n

[PaperMC/docs] New comment on issue #251: Reference CONTRIBUTING.md in Contributing docs

The paper contributing file is very different to docs. That included a lot of information about the patch system which isn’t used here. We also care a lot more about grammar and formatting here as well. I’m going to close this but feel free to say if you feel otherwise.

#

olijeffers0n

[PaperMC/docs] Issue closed: #251 Reference CONTRIBUTING.md in Contributing docs

lost sealBOT Oct 8, 2023, 8:51 PM

#

olijeffers0n

[docs:update_1.20.2] 1 new commit

50812f9 Update to 1.20.2 - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New branch created: update_1.20.2

#

olijeffers0n

[PaperMC/docs] Pull request opened: #252 Update to 1.20.2

Whilst the automation PR pends, docs need updating now Paper is out of experimental. I chose not to update the example for the data version as I don't have a mc env around and also when automated, this will be static anyways

lost sealBOT Oct 9, 2023, 6:57 AM

#

MiniDigger

[PaperMC/docs] Pull request closed: #252 Update to 1.20.2

#

MiniDigger

[docs:main] 1 new commit

282f396 Update to 1.20.2 - olijeffers0n

#

MiniDigger

[PaperMC/docs] branch deleted: update_1.20.2

lost sealBOT Oct 9, 2023, 6:30 PM

#

Leguan16

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

I moved the mcdev stuff over to misc and added a section for velocity plugins.
I also reverted the manual project setup back to its previous state.

lost sealBOT Oct 9, 2023, 8:31 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

My apologies, that wasn't quite what I meant by misc. I meant Paper/Dev/Miscellaneous - Sorry

lost sealBOT Oct 9, 2023, 10:53 PM

#

olijeffers0n

[docs:main] 1 new commit

17372e2 Change syntax highlighting on stacktrace - olijeffers0n

lost sealBOT Oct 10, 2023, 5:04 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

powercasgamer

[PaperMC/docs] New review comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

| **Group ID**          | The group ID of your project. This is used for Maven and Gradle. This is usually your domain name in reverse. If you don't know what you should put here, you can use something like `io.github.<yourname>` or if you don't have GitHub you can use `me.<yourname>`. |

lost sealBOT Oct 10, 2023, 2:16 PM

#

olijeffers0n

[PaperMC/docs] New branch created: feat/seperate_topics

#

olijeffers0n

[docs:feat/seperate_topics] 1 new commit

112dbdb Separate the sidebars out - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Pull request opened: #253 Separate the sidebars out

Separates the sidebars for the projects for admin/dev/contrib.

I would also like to make it so that search results only show for the correct project. LMK if you know how

#

lynxplay

[PaperMC/docs] New comment on pull request #253: Separate the sidebars out

The project level separation I definitely agree with, separating the top levels of each project too however might be too much IMO. Tho, not a hard no on that, would need more opinions.

#

olijeffers0n

[PaperMC/docs] New comment on pull request #253: Separate the sidebars out

You mean like hiding the other projects at the top when you select one?

#

lynxplay

[PaperMC/docs] New comment on pull request #253: Separate the sidebars out

No, I mean that https://docs-k2bymnn76-papermc.vercel.app/paper/dev does not show administration or contributing in the sidebar.

lost sealBOT Oct 10, 2023, 5:05 PM

#

Potothingi

[PaperMC/docs] Pull request opened: #254 Latest Java LTS

I recently heard that Paper recommends 21, the latest Java LTS.

#

Leguan16

[PaperMC/docs] New comment on pull request #254: Latest Java LTS

Could you please provide a link where you have heard it?

#

Potothingi

[PaperMC/docs] New comment on pull request #254: Latest Java LTS

If you ask Paper discord about this they will say "use latest java LTS".

#

lynxplay

[PaperMC/docs] New comment on pull request #254: Latest Java LTS

I honestly don't really mind suggesting/having docs to install 21.
Yea only 17 is required but moving the community forward sounds like a generally smart idea.
We'd have to note that down somewhere tho for sure and this 100% needs input from other team members.

lost sealBOT Oct 10, 2023, 5:38 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #253 Separate the sidebars out

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

  primary: ["README"],

looks dum

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

    "label": "Paper Contributing Guide",

match title here https://docs-k2bymnn76-papermc.vercel.app/paper/contributing

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #253 Separate the sidebars out

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

Why is cat here? The development docs don't have it

lost sealBOT Oct 10, 2023, 6:13 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #212 Automate the versioning of doc contents

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

    const [fetched, setFetched] = useState<string>();

My LSP complains about the typing being wrong here, and this seems more correct.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

Does this need to have a return early if href isn't set yet?

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

I don't know how typescript we want to go, but ideally the props would have types.

I don't know if there is a better way than just defining a local interface like

interface SoftwareVersionProps
	versionType: "maj-min" | "maj" | "min",
	project?: "paper" | "whatever",
}

export default function SoftwareVersion({ versionType, project = "paper" }: SoftwareVersionProps) {
}

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #212: Automate the versioning of doc contents

Same comments here as on the SoftwareVersion component.

lost sealBOT Oct 10, 2023, 7:03 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #254 Latest Java LTS

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #253 Separate the sidebars out

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

Cause the docs have horribly enforced standards :P

#

kashike

[PaperMC/docs] Pull request review submitted: #254 Latest Java LTS

lost sealBOT Oct 10, 2023, 7:31 PM

#

SplotyCode

[PaperMC/docs] Pull request opened: #255 Fix location of tracking-range-y

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #255 Fix location of tracking-range-y

#

lynxplay

[PaperMC/docs] Pull request review submitted: #255 Fix location of tracking-range-y

#

olijeffers0n

[PaperMC/docs] Pull request closed: #255 Fix location of tracking-range-y

#

olijeffers0n

[docs:main] 1 new commit

489740b Fix location of tracking-range-y (#255) - SplotyCode

#

olijeffers0n

[PaperMC/docs] Pull request closed: #254 Latest Java LTS

#

olijeffers0n

[docs:main] 1 new commit

ba57a88 Latest Java LTS (#254) - Potothingi

#

olijeffers0n

[docs:feat/seperate_topics] 1 new commit

79d52ca Some formatting changes. - olijeffers0n

lost sealBOT Oct 10, 2023, 8:27 PM

#

olijeffers0n

[PaperMC/docs] New branch created: update_docusaurus_v3

#

olijeffers0n

[docs:update_docusaurus_v3] 1 new commit

7ef1228 Update to docusaurus v3 - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Pull request opened: #256 Update to Docusaurus to v3

lost sealBOT Oct 11, 2023, 9:44 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #253 Separate the sidebars out

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #253 Separate the sidebars out

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

  administration: [
  {

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

  development: [
  {

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

  development: [
  {

#

powercasgamer

[PaperMC/docs] New review comment on pull request #253: Separate the sidebars out

  contributing: [
  {

#

olijeffers0n

[docs:feat/seperate_topics] 3 new commits

489740b Fix location of tracking-range-y (#255) - SplotyCode
ba57a88 Latest Java LTS (#254) - Potothingi
4b8c8fe Merge branch 'main' into feat/seperate_topics - olijeffers0n

lost sealBOT Oct 11, 2023, 10:11 AM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #110: Add mention about configs

Thanks for your interest in contributing! I am going to close this PR as it is a year old now. Should you decide you want to continue - please open a new PR 😄

#

olijeffers0n

[PaperMC/docs] Pull request closed: #110 Add mention about configs

lost sealBOT Oct 11, 2023, 11:39 AM

#

powercasgamer

[PaperMC/docs] Pull request opened: #257 add javadoc stuff

lmk if there's a better way for now

#

olijeffers0n

[PaperMC/docs] New comment on pull request #257: add javadoc stuff

lol, gotta put the code ticks inside the square brackets

lost sealBOT Oct 11, 2023, 4:30 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #257: add javadoc stuff

Why is this a draft?

#

Leguan16

[PaperMC/docs] New comment on pull request #257: add javadoc stuff

because its probably not everything?

lost sealBOT Oct 12, 2023, 6:46 PM

#

Warriorrrr

[PaperMC/docs] Issue opened: #258 Document bukkit.yml's worlds section

The bukkit.yml has an optional worlds section that currently isn't documented, it's used for changing the generator/biome provider for specific worlds to ones from plugins

Example:

worlds:
  world:
    generator: pluginname:generator
    biome-provider: pluginname:biomeprovider

lost sealBOT Oct 15, 2023, 9:09 AM

#

DrakePork

[PaperMC/docs] Pull request opened: #259 Adds missing word 'load' in paper-plugins guide

Noticed that this line

was missing the word load between this plugin should and before or after.

Corrected Version:

#

lynxplay

[PaperMC/docs] Pull request review submitted: #259 Adds missing word 'load' in paper-plugins guide

#

lynxplay

[PaperMC/docs] Pull request closed: #259 Adds missing word 'load' in paper-plugins guide

#

lynxplay

[docs:main] 1 new commit

25256a3 Adds missing word 'load' in paper-plugins guide... - DrakePork

lost sealBOT Oct 18, 2023, 3:05 AM

#

Potothingi

[PaperMC/docs] Issue opened: #260 Outdated information

https://docs.papermc.io/paper/aikars-flags#using-large-pages

-XX:+UseLargePagesInMetaspace

https://bugs.openjdk.org/browse/JDK-8243161
Is anyone still using Java 8 with Paper?

lost sealBOT Oct 19, 2023, 2:11 PM

#

olijeffers0n

[PaperMC/docs] New comment on pull request #256: Update Docusaurus to v3

I have done some looking through the deployment and I believe everything is alright. If anyone can have a look through that would be appreciated :smile:

lost sealBOT Oct 19, 2023, 2:31 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

lost sealBOT Oct 21, 2023, 1:16 AM

#

olijeffers0n

[docs:main] 1 new commit

c75534f Actually import the Tabs so that they are rendered - olijeffers0n

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

olijeffers0n

[docs:update_docusaurus_v3] 3 new commits

25256a3 Adds missing word 'load' in paper-plugins guide... - DrakePork
c75534f Actually import the Tabs so that they are rendered - olijeffers0n
94cf44d Merge branch 'main' into update_docusaurus_v3 - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New comment on pull request #257: add javadoc stuff

These look like a good improvement, can I get this ready for review

#

olijeffers0n

[docs:feat/seperate_topics] 4 new commits

25256a3 Adds missing word 'load' in paper-plugins guide... - DrakePork
c75534f Actually import the Tabs so that they are rendered - olijeffers0n
b39e1b8 Merge branch 'main' into feat/seperate_topics - olijeffers0n
a9a6e40 Address Comments. - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New comment on pull request #253: Separate the sidebars out

So I have updated this. I made it off the back of the comments from community members however I am not sure how much this really improves the UX - let me know what you think

#

olijeffers0n

[PaperMC/docs] New comment on pull request #249: Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

Just needs a merge from main please 🙏

lost sealBOT Oct 22, 2023, 5:19 PM

#

olijeffers0n

[PaperMC/docs] Pull request closed: #249 Added HowTo guide for creating a plugin with the MinecraftDev IJ plugin

#

olijeffers0n

[docs:main] 1 new commit

60430fc Added HowTo guide for creating a plugin with th... - Leguan16

lost sealBOT Oct 26, 2023, 5:21 AM

#

MiniDigger

[PaperMC/docs] Issue opened: #261 Paper inbuild command reference

Todo: add Todo list with commands that need documentating

lost sealBOT Oct 29, 2023, 8:59 AM

#

Nacioszeczek

[docs:main] 1 new commit

a18dce2 list send command in Velocity command list - Nacioszeczek

lost sealBOT Oct 31, 2023, 6:33 PM

#

e-im

[PaperMC/docs] New comment on pull request #256: Update Docusaurus to v3

3.0 is out now. Looking at the changes between this pr and the actual release it should just be a matter of updating the packages.

The primary change is an update from MDX v2 to the newly released MDX 3

This sounds pretty major (i.e. v1 -> v2), but its actually just a few very small changes, hence why it was added at the very end. We don't inferface with MDX directly hence no changes are needed. ...

#

olijeffers0n

[PaperMC/docs] New comment on pull request #256: Update Docusaurus to v3

Yep! Got the notification too. I marked it as draft when the RC came out. I’ll be looking to update in the coming days around Uni work. Someone poke me if i forget 😝

lost sealBOT Oct 31, 2023, 8:43 PM

#

e-im

[PaperMC/docs] New comment on pull request #256: Update Docusaurus to v3

I had missed this initially but the patch for @docusaurus/core can also now be removed because loading typescript config files is now natively supported https://github.com/facebook/docusaurus/pull/9317

lost sealBOT Nov 2, 2023, 11:32 AM

#

Phoenix616

[PaperMC/docs] New comment on pull request #122: Document paperclip.patchonly

Added a mention for that now.

lost sealBOT Nov 2, 2023, 1:26 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #122 Document paperclip.patchonly

lost sealBOT Nov 2, 2023, 2:23 PM

#

olijeffers0n

[docs:fix/remove-village-exploit-docs] 1 new commit

a024f89 Remove Villager Exploit docs - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New branch created: fix/remove-village-exploit-docs

#

olijeffers0n

[PaperMC/docs] Pull request opened: #262 Remove Villager Exploit docs

See https://github.com/PaperMC/Paper/pull/9895

lost sealBOT Nov 2, 2023, 3:17 PM

#

Sytm

[PaperMC/docs] Pull request opened: #263 Change default value for villager infection chance

The default value for this setting has been changed in PaperMC/Paper@6573d9555d80ebe8c70b9c36c4113251055761d3

lost sealBOT Nov 2, 2023, 5:21 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #263 Change default value for villager infection chance

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #262 Remove Villager Exploit docs

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #122 Document paperclip.patchonly

#

olijeffers0n

[PaperMC/docs] Pull request closed: #122 Document paperclip.patchonly

#

olijeffers0n

[docs:main] 1 new commit

6af511d Document paperclip.patchonly (#122) - Phoenix616

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #263 Change default value for villager infection chance

#

olijeffers0n

[PaperMC/docs] Pull request closed: #263 Change default value for villager infection chance

#

olijeffers0n

[docs:main] 1 new commit

ee25d4b Change default value for villager infection cha... - Sytm

lost sealBOT Nov 3, 2023, 3:36 PM

#

olijeffers0n

[docs:update_docusaurus_v3] 6 new commits

60430fc Added HowTo guide for creating a plugin with th... - Leguan16
a18dce2 list send command in Velocity command list - Nacioszeczek
6af511d Document paperclip.patchonly (#122) - Phoenix616
ee25d4b Change default value for villager infection cha... - Sytm
490d9ca Merge branch 'main' into update_docusaurus_v3 - olijeffers0n

lost sealBOT Nov 3, 2023, 4:16 PM

#

olijeffers0n

[docs:update_docusaurus_v3] 3 new commits

0882751 Fix Merge - olijeffers0n
62bef4a Update Docusaurus - olijeffers0n
e34fe1f Fix Introduction Adventure docs - olijeffers0n

#

olijeffers0n

[docs:update_docusaurus_v3] 1 new commit

72e74ab Try MDX - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New comment on pull request #256: Update Docusaurus to v3

Okey, all patches are updated. Ready for reviewal

olijeffers0n

[PaperMC/docs] New comment on pull request #256: Update Docusaurus to v3

Okey, all patches are updated. Ready for reviewal

lost sealBOT Nov 3, 2023, 4:48 PM

#

olijeffers0n

[docs:update_docusaurus_v3] 1 new commit

b55efb8 go from curly to backslash escape - olijeffers0n

lost sealBOT Nov 3, 2023, 5:17 PM

#

olijeffers0n

[docs:update_docusaurus_v3] 2 new commits

be4e7e2 Use CommonMark - olijeffers0n
1645da2 Restore Comments in legacy docs now they are pa... - olijeffers0n

lost sealBOT Nov 4, 2023, 3:28 PM

#

Warriorrrr

[docs:main] 1 new commit

ade4fc5 Update anti-xray hidden block defaults - Warriorrrr

lost sealBOT Nov 4, 2023, 7:20 PM

#

lynxplay

[PaperMC/docs] Pull request closed: #262 Remove Villager Exploit docs

#

lynxplay

[docs:main] 1 new commit

79d3fca Remove Villager Exploit docs (#262) - olijeffers0n

#

lynxplay

[PaperMC/docs] branch deleted: fix/remove-village-exploit-docs

lost sealBOT Nov 5, 2023, 8:36 PM

#

Leguan16

[PaperMC/docs] Pull request opened: #264 Added guide for the AsyncChatEvent

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

This should also mention the use of ChatRenderer.viewerUnaware as something that should be used if the message will not be different depending on who is getting it. This is more performant because the message will only be rendered once per player it's being sent to.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

This guide will explain how to properly use the new `AsyncChatEvent` and its `ChatRenderer`.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

I would maybe also mention somewhere that it is an improved replacement for the deprecated AsyncPlayerChatEvent#setFormat so authors who know of that can make a connection between the two.

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

I think before this happens, it needs to be made clear that the render method is something that plugins implement, they generally do not call it themselves. And they don't supply each of those arguments, its given to them when the render method is called.

lost sealBOT Nov 5, 2023, 10:19 PM

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

I do that in the next section.

lost sealBOT Nov 6, 2023, 7:54 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Of course there are many more things you can do with Components in general.

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

This will throw if the prefix is null, also if we're going to use LuckPerms as an example, might want to link to the api docs for the LP API?

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Why is the prefix in backticks here?

lost sealBOT Nov 6, 2023, 1:37 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

description: An outline on the AsyncChatEvent and how to handle it

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

Maybe some comments on the fact that it is Asynchronous as well? Looks like a good addition though

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

The Chat event has evolved a few times over the years.

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

If you want to learn more about Components, you can read the [Component Documentation](https://docs.advntr.dev/text.html).

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Paper or Adventure?

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

readable XML tags. You can read more about it [here](https://docs.advntr.dev/minimessage.html).

lost sealBOT Nov 6, 2023, 1:59 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

```java title="ChatListener.java"
public class ChatListener implements Listener {

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

The ChatRenderer class is located in io.papermc.paper.chat.ChatRenderer so I would say it's papers way of modifying chat messages.

lost sealBOT Nov 7, 2023, 12:57 PM

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Why exactly should "Chat" be uppercase here?

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Looks nicer i think… doesn’t need to be though

lost sealBOT Nov 7, 2023, 2:11 PM

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

without backticks it produces this:

lost sealBOT Nov 7, 2023, 2:42 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Put the whole command in backticks?

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

I added an additional command above that will add the player to the admin group. Now it should not throw null anymore.

#

Leguan16

[PaperMC/docs] New comment on pull request #264: Added guide for the AsyncChatEvent

I addressed the requested changes.
Feedback about the placement of the docs/wiki link of LuckPerms and MiniMessage would be appreciated.

lost sealBOT Nov 7, 2023, 3:12 PM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

IMO it's still a good idea to add some null checking to it.

lost sealBOT Nov 7, 2023, 4:22 PM

#

kezz

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

kezz

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

don't know why we'd bother mentioning the deprecated method here

#

kezz

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Surely it's worth mentioning that you only need to instantiate this once? Or have ChatListener implement ChatRenderer and just pass this? Idk why we'd recommend instantiating a new object every time for no reason

#

kezz

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

don't really see why this is useful:

plugins already exist that do this including one shipped by LP
nobody would realistically be hardcoding the format like that, it should be using placeholders instead
now we have to maintain docs based on an entirely external plugin

would be better to make it generic, just having a "how to use a configurable format" and then just have the example be MiniMessage with placeholders and a little "add your own here!" bit or something

lost sealBOT Nov 7, 2023, 4:39 PM

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

because it was requested:
https://github.com/PaperMC/docs/pull/264#discussion_r1382642954

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

good point

lost sealBOT Nov 7, 2023, 6:00 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Machine-Maker

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

@kezz I think it's good to mention what it replaces. We frequently get questions about what the replacement for setFormat is on discord, enough that I think its warranted mentioning it somewhere, somehow.

#

Leguan16

[PaperMC/docs] New comment on pull request #264: Added guide for the AsyncChatEvent

I added a note regarding the event being async, added a tip about the usage of ChatRenderer.ViewerUnaware and addressed kezz's comment about the renderer being instantiated every time the event is called.

I did not yet change the last section.

lost sealBOT Nov 8, 2023, 8:28 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

```java title="ChatListener.java"
public class ChatListener implements Listener, ChatRenderer { // Implement the ChatRenderer and Listener interface

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

```java title="ChatListener.java"
public class ChatListener implements Listener, ChatRenderer {

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

null check

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

## Understanding the renderer

lost sealBOT Nov 9, 2023, 12:10 PM

#

masmc05

[PaperMC/docs] Issue opened: #265 Mob goal api guide

It seems that developers see it pretty hard to use the mob goal api, there should be a guide on how to use classes like

The javadocs aren't really great and there are no tutorials

lost sealBOT Nov 9, 2023, 2:03 PM

#

olijeffers0n

[PaperMC/docs] New comment on issue #265: Mob goal api guide

Yep, this is an API that is often overlooked for NMS so I +1 this guide

lost sealBOT Nov 10, 2023, 9:05 AM

#

powercasgamer

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

powercasgamer

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Missing the listener here?

lost sealBOT Nov 10, 2023, 9:45 AM

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Intended since it didn't change and would just distract from the changes in render

lost sealBOT Nov 10, 2023, 4:31 PM

#

olijeffers0n

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

olijeffers0n

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

am i right in saying this is often not a singular player but instead can be a collection of players?

#

Leguan16

[PaperMC/docs] Pull request review submitted: #264 Added guide for the AsyncChatEvent

#

Leguan16

[PaperMC/docs] New review comment on pull request #264: Added guide for the AsyncChatEvent

Well in terms of this method it's a singular audience.

lost sealBOT Nov 12, 2023, 6:42 PM

#

olijeffers0n

[docs:fix/velocity_title_page] 1 new commit

6afef02 Rework velocities title page to use mdx for doc... - olijeffers0n

#

olijeffers0n

[PaperMC/docs] New branch created: fix/velocity_title_page

#

olijeffers0n

[PaperMC/docs] Pull request opened: #266 Rework velocities title page to use mdx for doc cards

lost sealBOT Nov 12, 2023, 7:07 PM

#

Machine-Maker

[PaperMC/docs] Pull request review submitted: #266 Rework velocities title page to use mdx for doc cards

Looks like the velocity landing page also isn't using the cards, maybe it should as well to be consistent? Regardless, this looks good

#docs

SoftwareVersionFetcher

Embedded Versions: