I mean, we do use Cobol
#hangar-dev
untold idol
The ACH uses it so it must be!
sly mason
and they can buy mega hosting plans
They don't use hosting
hosting for any site you really care about is just fucking shooting yourself in the foot
spring also takes advantage of this cool thing, I forget what it's called...
erm, threads?
and scala has fuck all to do with scaling/load, etc
sly mason
now we're talking web scale
i keep meaning to setup a local copy of stuff
I just, erm, also want to get a keyboard pillow
pallid yoke
The docker setup seems to work great for ppl
random badger
Grrrr. The whole content security policy thing in the security configuration is annoying cause it’s not gonna generate a new nonce (for inline scripts) every request if I set it up there.
It’s more of a static thing. Guess I can setup a filter to just manually add the header to every request.
pallid yoke
I am not really an expert on security stuff like that
Am happy that I understand how to execute an csrf and how to protect against it, lol
random badger
what do we think of the create project form?
I think it should be expanded with more "optional" inputs, like the various links. So one doesnt have to then go to the project settings page after to add them (issues, repo, website, etc.)
stiff token
Maybe after you create the project you are redirected to the project settings?
random badger
nah, I think I disagree w/that. should take you to home. I think maybe an additional settings button that if clicked, expands an area with some settings. Mainly probably gonna be used by returning project creators.
pallid yoke
The layout looks ok
Idk if I like giant forms
Like we have those settings already, duplicating stuff like that is kinda meh
Maybe we want to hint the user at being able to change additional stuff in the settings
barren shale
@ivory ingot is a regex possible to delete duplicated tags, like [a]asd[a]dfe[/a][/a]? so open a tag + another a open without the first being closed? 
if a generic finder for any tag isn't possible, saying that it is specifically the a tag is fine as well
just pinged you because I know you're one of the few people that have fiddled with regex a few times 😂
random badger
so you think this is too big @pallid yoke ?
bottom 5 inputs are hidden unless you click the additional settings button
pallid yoke
Mmh
That might be ok
I'll play with it later
Hopefully am actually allowed to be in my flat today 😂
random badger
k, its a tad bigger now. But I still think its not too big...
barren shale
nvm on that regex hackfest, I'll do own parsing/conversion in Java
pallid yoke
Ah ok
So a proper bbcode parser
That has an internal model
And can output markdown?
barren shale
ye
pallid yoke
Looks better MM, I like it
barren shale
and get rid of duplicated tags, could do whatever with any tags with custom handlers
stiff token
Kneny was about to send you simpleish regex for that lol
Unfortunately would require 1 regex for opening tags, and one for closing tags.
Since for opening you need to keep the first instance and for closing you want to keep last instance, most probably.
ivory ingot
@ivory ingot is a regex possible to delete duplicated tags, like
[a]asd[a]dfe[/a][/a]? so open a tag + another a open without the first being closed? :smolEyes:
if a generic finder for any tag isn't possible, saying that it is specifically theatag is fine as well
@barren shale It should be possible with negative look ahead. It get's more complicated when it gets more nested.
ivory ingot
But I would instead recomend building a tree and strip child where child has same tag type as parent.
^(?<tag>\[\w+\])(.+)(?<endtag>\[/\w+\])$
using that to get the outer most tag. Create that tag object with a child that can be a tag itself or plaintext.
sharp crypt
Will resources on hangar be reviewed by a team (hangar team) for safety reasons, or can everyone just upload their plugins as they wish without review?
And will the plugins be hosted on hangar or externally (own download page / github...)
mortal idol
i dont think there will be enough time to review each plugin
but just letting them upload w/o review is meh
narrow verge
For the plugin hosting, you can link to an external jar but there will be a warning
has to be to a jar, not just a page to click download
So it's probably just easier to upload
modest forge
iirc Hangar has the facility for reviews if Paper wishes to use it
?
What do you need Aikar for?
that relates specifically to Hangar?
pallid yoke
We haven't talked about policies yet
Neither internally nor publicly
It's too early for that
leaden lily
Hey Mini, did you end up fixing your example instance of Hangar?
random badger
huh, I didnt realize it was even down. yeah, im getting 404 on main page?
oh, now bad gateway
leaden lily
Been getting 404 for a week or so iirc
pallid yoke
404 means the pod isn't started
Idk what's wrong, will check at work today
Eh tomorrow, lol
barren shale
alright, simple 100 line Java solution already works better than the regex hacks
basically just deduplication and fixes for bad spacing for bold/italics missing (both seen here for example https://i.imgur.com/7hK8FkU.png)
pallid yoke
Ah, not bad
Do we want to link attachments against spigot?
Like, create an image tag, which links to the spigot url
barren shale
oh wow that's incredibly easy heh
REPLACERS.put("attach", ((tag, tagArg, content) -> {
final String imageUrl = "https://www.spigotmc.org/attachments/" + content;
return "![" + imageUrl + "](" + imageUrl + ")";
}));
works™️
random badger
Mini, do u think you’ll have a sec to look over that frontend pr today? I don’t want it to get too big.
pallid yoke
Hopefully I can
Gonna go swimming after work and then get new glasses, but should have time in between
Lemme look at staging first
Flyaway broke
Did somebody touch the file again?
Yeah, you did with multi platform
Lemme nuke db
Back up
pallid yoke
Code in the PR looks nice, didn't expect so many translations, wow
random badger
yeah, once I setup vue i18n, its really easy to do
and wrote a quick script to convert the .properties file into json
random badger
what did you think it was?
random badger
ah, ya no. We probably can automate the creation of the json files so when we get around to adding a bunch more translations, we dont have to add them in multiple places
pallid yoke
Yeah, had the same thought, not sure what format would be leading, smth we can shove into some translation website would be best
I used POEditor before for translations, I think that did support properties
random badger
do we want to have the translations fully up (even if only with English) for initial release?
pallid yoke
Don't think that's a prio tbh
fallow orchid
Hello
barren shale
this is not a social channel
pallid yoke
giving the PR a spin now
I really don't like how the nav bar vanishes if you change page
thats because of how we integrate FA I bet
and I think we want a global loader
lemme play with smth
how do ppl like something like this? https://streamable.com/yhom8y
leaden lily
Ooo, I see that Vue PR MM. Looks good.
random badger
Hmm yeah Mini. I like it. Shouldn’t just the main page be greyed out, not including the header?
I feel like that would make more sense.
Since that’s the content that’s actually changing.
pallid yoke
Meh, as I said, the icons in the header are also loading
random badger
Hmm ya I guess
pallid yoke
I think am gonna give the caching headers and etags and file name hashes a try in a few
Been laying on my couch for too long now, lol
leaden lily
So I saw in the pipeline that it's deploying somewhere... where is it deploying to? Cause the link on the README still leads to a 404.
pallid yoke
imma give that container a kick
pallid yoke
I cant click
ill also put hangar behind CF
and see what happens
great
😄
no CF and my last commit
with CF and my last commit
stuff be hella fast now
leaden lily
Ahh
leaden lily
Lol
pallid yoke
I mean
for some reason ppl already google hangar
if I wouldn't always nuke the DB, we already would be ranked quite good I think 😄
cedar depot
(more than a few of those are me checking in)
pallid yoke
heh
sly mason
literally worse than Z750
random badger
well I was trying to include a few small in changes in a commit I would push to master, and then the rest to a new branch. cause those 3 small ones had nothing to do with the new branch. BUT I had deleted some files and didnt realize they were also included in the commit
sly mason
I stand by my statement
narrow verge
does intellij auto run git add when you delete a file?
@random badger if it's enabled yeah
random badger
is that the same setting that runs git add when you create a file?
random badger
yeah, I thought* I had it off
narrow verge
the git tab tells you what's staged and all that I believe
narrow verge
looks like it just goes to default changelist
random badger
oh they are different settings?
don't think I saw any options before removing from version control
narrow verge
weird
random badger
ok, so you can invite organizations to be collaborators on a project? does that make sense?
there is a section on a org view for accepting invitations to other projects...
and then, that brings up, you can invite organizations to other organizations?
although there aren't any ways for an organization to accept an invite to another org.
narrow verge
I dont think so
random badger
I don't see (in the ore source) where it filters out organizations when it updates membership in an organization
narrow verge
Oh for ore thought you meant github
random badger
no no, talking about hangar
on hangar rn, you can invite organizations to other orgs
and I thought maybe we missed something in the ore source but I don't see it
narrow verge
Yeah yeah probably shouldnt have that
random badger
but ore def has support for inviting an organization as a colab on another project.
narrow verge
seems unintentional, not sure why you'd want that
random badger
its def not unintentional. they even have a UI component for accepting the invites (since you don't have access to that org's "notifications")
on an organization page
random badger
the organization created VanillaTweaks (so its the owner)
but I invited it to another project
gonna see if members of the other org inherit the perms the org has
can't remember if there is logic for that
random badger
yeah, members of the org don't seem to inherit the perms... so ya idk what the point there is?
random badger
there would have to be something different done there. like what happens if you invite an org to the support role?
perhaps if you invite an org as a colab... it has its own project role that cant be changed
and then whatever a users perms in that org are, apply to that project as well?
idk, it still seems odd to me to have orgs as collabs
pallid yoke
Yeah it seems that it's a tad complicated, let's not do it for noe
If ppl complain that's always something we can look at later
random badger
yeah, ok. ill add in some checks on the backend when inviting users
pallid yoke
Sounds good
random badger
and probably checks on the frontend. it does query the user object so we should be able to tell if its an organization or not. Those member lists w/search bars should probably be vue components in the end so we can have easier suggestions
pallid yoke
Yeah
random badger
Mini, what do you know about the deployment key thing with gradle? We don’t have that implemented yet and it’s the last remnant of v1 api left
pallid yoke
I guess it's something that allows you to deploy your plugin from gradle to ore?
I bet sponge has that on their docs
modest forge
SpongeGradle has an Ore deploy task
I don't see any documentation on the SpongeGradle readme but the code for the task is here: https://github.com/SpongePowered/SpongeGradle/tree/0.11/src/main/kotlin/org/spongepowered/gradle/ore
pallid yoke
I mean the sponge docs
random badger
kenny do you want me to try and rebase your branch (add the converter to the create project vue page)?
random badger
erm....
does anyone have an organization on sponge's ore that they can invite me to?
random badger
do you still need csrf protection for json post requests?
pallid yoke
All post I think
random badger
ok, I just wasnt sure. Im guessing you send it as a header then
drifting badger
what's this hangar thing about? 👀
cinder silo
check pins
random badger
who's got a nice and complex spigot project description that can send me the BB code for it?
random badger
I only see hacktoberfest-accepted, are there supposed to be two labels?
sly mason
no
Well, their thing matches any label with "spam" or something in it for holding off on it
proud basalt
yea you can stop with the spam @gleaming sinew
sly mason
There is a channel for discussions here, there is no need to drop an email to everybody for what is basically questions
sly mason
Well, at least it's v2
random badger
I can't see logs of the production instance so idk what's going wrong
random badger
and I mean, the frontend uses the api to display some information
like, does the home page view work?
narrow verge
Yes, but if i click on the example plugin it leads me to localhost:8080/MiniDigger/TestPlugin
doesn't seem intentional
random badger
oh yeah, I need to replace that still lemme do that real quick
narrow verge
doesnt intellij have a rest client
random badger
idk, you'd have to browse around. look through the vue components for where its being used first @gleaming sinew cause the other js will probably get replaced soon anyways
narrow verge
ooooh kay so doing the GET /api/v2/projects with authorization just leads me to the sign in page
random badger
but it doesn't when the frontend queries that to show projects on the home page
narrow verge
Correct, if I copy the details from the network tab in dev tools it works
random badger
well what's the difference between them?
narrow verge
-H "authorization: HangarApi session=47fe4c31-bc9f-4f39-bb7e-683589ea8f5e"
doesn't
If i add ""s around it it works
specifically the session="bruh" vs session=bruh
first works second doesnt
random badger
I was looking in the blob of text at the top of the swagger page
where is that example?
narrow verge
i just scrolled down to the /api/v2/projects thingy
did try it out, typed in the deets
I get a TypeError as well so that may be why as well
now the real question, how does it get the session token 🤔
random badger
hmm yeah idk where that is configured in the project?
narrow verge
is that just a default key?
narrow verge
so how long does that key last? an hour?
random badger
3 hours it looks like?
random badger
that sounds right
wait a few mins for the ci to get this latest commit
should fix the swagger "try it out" thing and the url pointing to localhost
random badger
once mini takes a look at my api pr, itll move back to v1.
I eliminated all but 2 of the places where v1 was still being used in the frontend.
I wonder if there is a way I can add an input where you can input your own apikey to test stuff in swagger
that way when you get one with perms, you can use that
are you still just using your phone @gleaming sinew
narrow verge
😄
random badger
nice
narrow verge
Didn't have a promoted version or it'd show that
random badger
yeah, I have no clue what makes a version become promoted
its some super big complex query thing
leaden lily
Looking good.
random badger
@barren shale lol, I was literally squashing them
barren shale
don't do his work
especially if it's no work at all all of the ones except the 2 still open basically didn't have any meaningful content anyways
random badger
ya ok. I did rebase your pr tho. and it works. when you create a new project and you've saved the converted bbcode, it shows up as the root page
I didn't know if you wanted to do some more things to fill out those checkboxes before it was merged
barren shale
I'll prolly skip messages since you wanted to do more about those after release anyways (?), but still want unit tests
and deduplication for the converter
narrow verge
good morning kneny
random badger
yeah, hold off on the messages
solemn whale
Why would you hate someone like? Isnt it just a waste of energy? 
barren shale
@pallid yoke can you somehow make the loading screen a bit less.. 'present'? it just briefly jumps at you too hard every time with that giant circle and that strong gray-ing 😂
probably just that gray filter, since it makes the screen flicker for short loading
random badger
it shouldn't
cinder silo
even I got one 🤔
random badger
k, the deploy version api endpoint is gonna need some love. since we have dependency linking on project creation, gonna have to add stuff to the post form there to link all those
index.html isn't used afaik... @gleaming sinew so idk why you added that bit there
we could probably delete it, but idk if webpack would complain?
and do we need the babel-lodash-plugin? we are already using lodash-es
which splits up lodash afaik
pallid yoke
I wonder if there is a way I can add an input where you can input your own apikey to test stuff in swagger
@random badger yes, you can configure authentication schemes in swagger
@pallid yoke can you somehow make the loading screen a bit less.. 'present'? it just briefly jumps at you too hard every time with that giant circle and that strong gray-ing 😂
@barren shale mmh, maybe an animation to appear, like fade in?
barren shale
sounds good
pallid yoke
And I mean, we can totally change the style
I literally just copy pasted the loader from work, lmao
And even there I didn't design it myself but our design agency did
It was created for a pretty white website so the filter isn't as bad I guess
random badger
🙂
barren shale
Converter is well an done, and also looks nice on the frontend thanks to Jake
since I'm away for the weekend, I'll just merge now and do unit tests later next week
pallid yoke
👍
cinder silo
@gleaming sinew wtf is ZAPPFIX
random badger
The issue with the other PRs, is either that you didn’t explain the changes well enough, or they were redundant, or they should’ve been in one pr together.
untold idol
yeah please stop burdening open source with your useless changes, I checked out your profile and 90% of your actions this month has been submitting a bunch of 4 line text file spacing changes while begging "not to mark them as spam"
limpid stump
really wants that Hacktoberfest t-shirt methinks
pallid yoke
Just open PRs to your own fucking repo then
sly mason
Drop the attitude
misty mountain
Please just.. discuss the changes you want to make, as was requested of you
sly mason
and once again, "discuss PRs first"
barren shale
we won't merge stuff just so you can get commits / something changes. we will merge things we think actually benefit the project
misty mountain
Helping stuff that is already underway (e.g. converting jquery stuff to vue) is a great way of helping along without discussing a lot first
obviously mention it so you don't waste time as someone may already have done it just not yet pushed, but it's a good entrypoint
well look at what the existing PRs do and PR to the PRs
or check out the issues (idk if there are any? i'm not involved w hangar)
pallid yoke
Maybe that will give me a fucking merge.
@gleaming sinew if that's the kind of language we use now, I can tell you that all what that will get you is a fucking ban
modest forge
?
gusty birch
Aren't they trying to remove jQuery not add more?
modest forge
Hangar is slowly removing jQuery but yes, some JS parts of normal Bootstrap rely on jQuery
Not sure whether the jQuery modals are still there - I recall porting a few modals but not sure if they've been replaced yet
gusty birch
I didn't think bootstrap models needed jquery
random badger
bootstrap 5 doesn't need jquery... so once that is released, we'll move over to there
leaden lily
VBS removes jQuery but I'm not sure if they are finished converting over yet.
Or waiting for BS 5 works too.
limpid stump
@pallid yoke I might be dum but I tried bringing up the docker-compose and got this
pallid yoke
I don't use that part of the docker workflow, I only use the dev db, MM might be able to help
random badger
Tux, you probably need to chmod +x that
sly mason
inb4 MM works on windows
random badger
hmm
sly mason
wasn't there a file perm thing issue before? related?
limpid stump
Also you using Flex or Inline-Block for your dependency Selection?
that's a really dum question, those are possible values for thedisplayproperty in CSS
modest forge
Please don't spam repeat your question, give people a chance to answer @gleaming sinew (and also, you should be able to discern the answer from the source)
gusty birch
@limpid stump might be because the docker user and your user aren't the same
A quick fix I did was to allow everyone read write ex perms on my hangar clone
misty mountain
its r+x on all groups
random badger
hmm, I don't know why I wouldn't have that issue then
limpid stump
The directory is world readable and executable.
gusty birch
Oh I missed that pic hmm I had the same perm issue and that fixed my problem
random badger
you are using the docker/docker-compose.yml right?
limpid stump
yep
gusty birch
Can you try exec bash in the container and checking the perms on mvnw? Unless that pic is off inside the container
sly mason
That's from docker
gusty birch
I thought maybe in copying the files into the container perms where getting messed up
modest forge
You don't need to send us 20 emails about changes that don't make any sense and aren't particularly useful
azure boltBOT
Steviebeenz#3050 was kicked | drop your attitude
limpid stump
side note, I should probably add in something so that HangarAuth will run using a "real" production WSGI container
I'll probably PR some gunicorn magic for that later
gusty birch
Did you get your container working tux?
limpid stump
nope
I'll deal with it later
the Django runserver command is just for development purposes
limpid stump
probably a pretty dumb reason
I can detect the sarcasm
well I'll "look forward" at looking into it, I've had to deal with plenty of gnarly Django apps
misty mountain
?ban @gleaming sinew Drop the attitude, I said.
proud basalt
dyno pls
misty mountain
nighty night dyno
azure boltBOT
Steviebeenz#3050 was banned | Drop the attitude, I said.
untold idol
inb4 he opens 50 prs
misty mountain
he's blocked
modest forge
Python has no threads, so to schedule a task without blocking the Django instance, it uses Redis to communicate with a second worker process
proud basalt
he's banned from the org
modest forge
He's banned
misty mountain
was blocked like 20-30min ago
limpid stump
have yourself plenty of STUPID validation code https://gist.github.com/astei/11e6ff18600d3daf7480bc9e8e2b51c3
From a real production app
@modest forge Actually, that's pretty common, but yeah, it's a mess
Python does have threads BTW, the problem is that the interpreter is not thread-safe, so the problem is "solved" by having a giant mutex
modest forge
Here's the fun part: in production, Sponge disables Redis usage, meaning the entire Redis queueing library just blocks the main Django thread anyway
random badger
runway wen?
limpid stump
Unfortunately, it looks like the GIL will stay with us forever.
modest forge
Yeah, was just easier to explain the interpreter lock as a lack of threading as that's the parallel in other languages
modest forge
So in conclusion, they introduced a worker queue library then disable it in all runtime environments
sly mason
Yea, I'll have you know that he's five and a quarter years old
modest forge
Hey not everyone inflicts pain on themselves with the nuances of Python
limpid stump
PyPy does improve the situation somewhat, simply by virtue of being faster, and if you're really into pain, there's always Jython and IronPython which have no GIL
Some guy even tried to remove the GIL from CPython, but you can't do much more than run basic code and the effort required was so immense that they gave up.
The best hope for GIL-free Python is now software transactional memory, how fun.
Then again, Instagram seems to run their main production app on Python and it kinda works, I guess.
YouTube is also written in Python, but they now transpile to Go.
Oh, wait
Reference counting: “With his complicated buffered-reference-count approach he was able to get his “gilectomized” interpreter to reach performance parity with CPython—except that his interpreter was running on around seven cores to keep up with CPython on one.”
On the other hand I guess it's nice AMD forced everyone to move to higher core counts than four...?
cinder silo
Wow that guy really went on a spam spree
proud basalt
yea
narrow verge
Dude just wanted a shirt
cinder silo
I made a few PRs here and there but I don't expect the tag
random badger
I wonder if hard project deletion even works on ore right now?
cause the way its setup, the db is gonna be mad at you for trying to insert a log record referencing a project id that doesn't exist
barren shale
last I checked it didn’t work :p
random badger
the todo column is shrinking slowly...
random badger
That api pr should be good to merge now. Can just hang on to the deployment key methods.
errant zephyr
Does the documentation for the Ore web API apply to Hangar as well?
cursive kraken
cause the way its setup, the db is gonna be mad at you for trying to insert a log record referencing a project id that doesn't exist
@random badger depends on which branch you are based at
in vue-refactor it works
barren shale
API has been merged and slightly changed in places, but it's mostly similar
pallid yoke
We branched off staging felix, if you can even call it branching of
cursive kraken
Ah k dunno if it's broken there
narrow verge
How often does Git -> Hangar site?
pallid yoke
instantly
narrow verge
Oh cool
pallid yoke
well, I think gitlab polls like every 5 minutes or smth and pipeline takes like 10 and then startup
narrow verge
Is that beer lol
pallid yoke
but yeah, instantly
narrow verge
I don't drink 😡
mellow pebble
lttstore com
pallid yoke
narrow verge
havent dronk anything in at least 9 hours
mellow pebble
jake where are you when we need you smh
pallid yoke
next paper update stream @hollow nova should send out ltt merch instead of pizza 😄
mellow pebble
finally a reason to update paper
pallid yoke
also rocking the hacktober fest shirt right now
mellow pebble
😄
narrow verge
uh oh discord dyin
misty mountain
hacktoberfest gang
narrow verge
dang proxi is cute
pallid yoke
yep
mellow pebble
I just hope I get one this year
pallid yoke
I dont even have it anymore
pallid yoke
I just hope I get one this year
@mellow pebble chances are really low
it will arrive in jan 😉
narrow verge
sad knowing i wont get a shirt this year
cus i highly doubt theres any left by now lol
narrow verge
we aer there
untold idol
oops
narrow verge
sonic notch
oh yeah whoops
narrow verge
(that also means you complied on a later version and are running it on a earlier version, e.g compiled on 11 running on 8)
narrow verge
@random badger didnt your api pr get merged? why is everything at https://hangar.minidigger.me/api still /v2
random badger
Hmmmm
It should be at v1. Unless the deploy failed on the merge.
On mobile atm, so annoying to check. Will look into it
random badger
Hmm @pallid yoke did the gitlab thing run? I don’t see a check mark for that last commit
narrow verge
why's it not gh actions btw 😢
random badger
Idk. Talk to mini
sly mason
Because he uses gitlabs CI to deploy into his own environment
this is a setup which has worked for time, not everything needs to be shoved over to githubs crap
pallid yoke
yeah, I copy the same gitlab ci file over for like 5 years now, lmao
ill check what went wrong
high vapor
pallid yoke
no?
errant zephyr
This may be a dumb question but will Hangar only allow plugins made with the Paper API, or will Spigot API be allowed too?
modest forge
As far as I know, policy hasn't been discussed yet; that said, I'm 99% sure that as long as it runs on Paper it will be allowed, there's no plan for a requirement for it to only run on Paper
At the end of the day it would be a dumb idea to mandate that all plugins on Hangar must be Paper-exclusive, that would just put people off
pallid yoke
spigot plugins indirectly use papers api 😛
but like, eventually spigot plugins will not run on paper anymore so we will see what to do about that then
maybe add big legacy banners 😂
safe harbor
Uninstall em, ez
midnight anchor
but like, eventually spigot plugins will not run on paper anymore so we will see what to do about that then
wdym?
pallid yoke
since spigot is dying, paper will overtake soon (tm)
stiff token
Hard fork for 1.17?
narrow verge
stiff token
I just need an excuse to rewrite all my old plugins :p
narrow verge
motivation:P
pallid yoke
Pressure all ppl into adopting paper then ^^
midnight anchor
what's a "hard fork?"
pallid yoke
currently paper is a fork of spigot, we inherit all changes spigot does, and are dependent on spigot
we for example need to wait on spigot to do updates, cant release for snapshots and prereleases, etc
stiff token
s/independent/dependent :)
pallid yoke
a hard fork would mean we take everything we have, and stop caring about spigot changes
which eventually will lead to spigot plugins not working on paper anymore, because spigot would evolve differently (if it doesnt die)
stiff token
Imagine having Paper snapshots and prereleases - you can have all plugins updated before the full release.
Don't have to wait for weeks, can enjoy the update within hours.
cinder silo
yeah would paper release snapshot builds unlike spigot?
(also why does spigot not release snapshots)
misty mountain
perhaps
pallid yoke
release snapshot builds? most likely no
have source up for later snapshots? that sounds possible
cinder silo
yeah that's what i meant
stiff token
I don't expect builds, because people will run and complain.
stiff token
But having sources for development will be great.
narrow verge
doesnt sounds like hangar discussion going on here
cinder silo
party pooper
misty mountain
i mean, i don't really see an issue with snapshot builds. if we don't do them, someone else will, and people will still complain
mortal idol
no matter what you do, people will complain
random badger
def not saturday dependabot...
sly mason
wow, vulnerabilities 😮
fervent zenith
Is it currently possible for people to make plugins specifically for paper?
safe harbor
Wrong channel but ye
fervent zenith
Which channel should I have asked in? I thought hangar was about paper plugins.
safe harbor
Hangar is an upcoming plugin repository, better use paper-dev/help for paper api related questions
barren shale
god I love the standard bbcode editor, produces quality filtered output like
yep, that literally just becomes By enabling MySQL in the config, you can even connect multiple proxy-servers to a set value in your database, so you won't have to enable/disable maintenance on each proxy by hand! 😂
narrow verge
why does that look like slack
barren shale
the converter itself may "break" in 2 cases; spaces between formatting tags (like [b][i]hello[/i] [/b]...), and sometimes there's no line break where one would look nicer, tho I don't think there actually is a way of concisely determining in code when it needs one and when not, since there's tons of special cases with those in md needing proper interpretation
just took the first from google (+ dark reader) lol https://markdownlivepreview.com/
pallid yoke
@barren shale apperently simple is working on exposing resource description in spigots api
As bbcode
pallid yoke
Well, it's simple that making it
Not spigot itself ^^
It's actually already implemented
See the open PR on the repo
.g spigot xenfororesourcemanagerapi github
No bot here, feels bad man
Basically, a new field called description
barren shale
isn't Spigot API still "official" Spigot just infiltrated by simple?
pallid yoke
Well, it's like 100% written by simple ^^
white sinew
Hey guys, is there anywhere i can see the Hangar site so far? And whats the goal of hangar?
distant pelican
And whats the goal of hangar?
https://github.com/PaperMC/Hangar#hangar---papers-upcoming-plugin-repository
cinder silo
@NotNull private final String string;
// or
private @NotNull final String string;
// or
private final @NotNull string string;
cast your votes now people
random badger
because this has to do with hangar?
stray wharf
3rd
stray wharf
in the same vein as you wouldn't annotate a method nullable or notnull; you annotate its return value null or notnull
random badger
I mean I usually have the annotation 1 line up
stray wharf
i usually 1 line that stuff
a habit from one project where I had to override a copious quantity of inherited methods
1 lining the method signature including the override basically halved the number of lines
cinder silo
i one line fields and one-line-up methods
cinder silo
my style is terrible and inconsistent tho
sly mason
topkek
stray wharf
i don't want to scroll around copious amounts of redundant shit
at least my ide collapses most of the other redundant shit
it just doesn't do it with annotations
pallid yoke
hexed lodge
oh whoops, i thought i was in that sorry
main lava
annotations go first
@cinder silo
the real right answer isjava @NotNull private final String string;
tacit roost
no
lol im late
but ```java
private final @NonNull String string;
its a NonNull String not a NonNull private smh
ivory ingot
it is clearly on a method level. So the return is expected to be not null. Keep it a line before like @main lava recommended.
misty mountain
annotations come on the type; it's not the method itself that is not null, but rather its return type
you also don't do String @NotNull method(); the method isn't what you want to be annotating
if the annotation comes on the method, that also means it becomes @Override String, i.e. you're overriding the type the method is supposed to return. that makes no sense
so those coming on the method itself are before, whereas the specifics to the type come on the type
ivory ingot
@misty mountain whatI meant was that for methods it doesn't matter if you use violet or jmp. I'm more of a fan of multiple lines. So separating Annotations from the field/method/class itself. As they are not required.
misty mountain
I too like multiple lines, and would never do such heresy as to have e.g. @Override on the same line as the method, but type annotations are supposed to be on the type
e.g. consider this:
@NonNull
public Pair<@NonNull String, @Nullable Integer> createPair();```the type annotations on the method suddenly starts to break down
ivory ingot
For that I would have dropped the annotations in between. It's the default thing that a key must be nonNull and a value can be nullable.
For me only the information if I need to check if the Pair is non-/null is the important one.
But on private project I never use a annotation framework for that. 🙂
misty mountain
it's not a key-value though, it's a tuple
I use annotation frameworks everywhere simply because I am stupid and that's fine. It makes IntelliJ be able to help me when I can't hold all the context
I could also have swapped around the annotations, for e.g. Pair<@Nullable String, @NonNull @NonNegative Integer>
narrow verge
And so it begins
sly mason
it's monday bois
main lava
Just wondering. Did hangar implement spoilers yet?
barren shale
it uses markdown for discussion and info pages
main lava
Yes, but thats not a markdown specification.
Github as an example implemented spoilers along with markdown
And spigot has their own way of spoilers
They are really useful would be a cool feature to add
Is it worth a issue on github?
May be backlog
modest forge
I don't think GitHub has proper spoilers, it just allows the <details> HTML tag iirc?
Depends on whether Hangar allows <details>, which I presume it does since the Markdown spec allows most HTML
pallid yoke
Can somebody test on staging and or create an issue?
I can prolly do it in an hour too
main lava
I don't think GitHub has proper spoilers, it just allows the
<details>HTML tag iirc?
@modest forge yeah that what i did mean
Spoilers/Details are a rly cool feature that i would love to see in hangar as i really missed it in ore
pallid yoke
Doesn't sound impossible to add
modest forge
As long as it isn't filtered out it should work
modest forge
mini approve my hangarauth account pls thx
random badger
@modest forge should be verified now 👍
narrow verge
Woah where's my verification :(
modest forge
I mean, after you posted that hangarauth seemed to die
hmm okay it just gets stuck when trying to log in
jaaaaake what did you do
pallid yoke
Jake hacked into the db I guess ^^
modest forge
I think you can change it from django admin?
pallid yoke
@modest forge I don't see an confirmation mail for you
I can see that jake created two
oh waitr theres one thats like 18 days old
random badger
yeah... something went wrong...
I tried to manually set the verified column on your account and then I couldn't even create an account for myself
modest forge
It worked
narrow verge
Man was just joking I didn't even access the site I'm innocent 😂
random badger
oh you know, I think we still have to do the linkout stuff
like replace links in markdown stuff right?
(btw, anyone who created an account on the staging instance that wants their accounts verified, just ping one of us since the mail system isnt really setup yet)
barren shale
what do you mean with replace links in md?
random badger
so they go to the linkout page right?
instead of just a direct link to whatever
the "are you sure you want to go there" page thing
barren shale
oh yeah, if we do that, we should skip the warning page for verified projects
since I find that to be rather annoying whenever I look at something on dbo or ore for example
but doing both should be easy enough, just a few lines in description saving to get the linkout path with the escaped links, and a simple verified check in the linkout controller method to directly redirect
random badger
I know we talked about verified hosts
But yeah, we could have projects that are also “verified”
I wonder if in the markdown parser there’s a way to transform the links there, so you don’t have to find all the hrefs in the output html
somber flicker
so is hanger auth functional? or still in testing?
pallid yoke
It works, yeah
There is just no real mail server plugged in right now, all mails go into some Webinterface where the team can view them
somber flicker
so I dont get the verification mail ? or I should get it?
somber flicker
Well I think I completed sign up so it should be there somewhere
pallid yoke
somber flicker
ty
narrow verge
forbidden
narrow verge
yep, same tab even
misty mountain
might be due to disc? :p
narrow verge
did someone snipe the link lol
pallid yoke
Don't have time to investigate right now
You can't snipe links
They only work if you are logged in
misty mountain
smh mini bork
pallid yoke
When somebody else clicks the link, it asks you to login
ocean pagoda
(tried that, it does)
ocean pagoda
Did I break it by registering at a similar time?
pallid yoke
Lmao
ocean pagoda
lol 😄
pallid yoke
I gave chew the wrong link
ocean pagoda
just stealing my link
narrow verge
mine has like chew twice
pallid yoke
Try this one chew
somber flicker
hey the plugin upload process is really nice
Or I should say the plugin posting workflow
nice and modern
pallid yoke
Props for that to MM, he did rewrite it all
ocean pagoda
Is there a way to add a project description without copying it from spigot?
(I don't want to upload one, just confused by the UI 😄 )
Because there is a big "convert from spigot" button, but no "make your own description"
narrow verge
oop
I guss just put your description on the top and save
bottom*
dang even mini isnt staff lol
somber flicker
ask about bugs here?
narrow verge
sure
mortal idol
the channel desc is Development Discussion for Hangar, our upcoming Plugin Repository
Hangar has a repo with issues
pallid yoke
Yes this channel is good to discuss potential bugs with others
But also create an issue to keep track once it's confirmed
narrow verge
yeah
somber flicker
So If I choose upload Avatar then click choose file ...it appears to freeze my browser 😛
Oh no it just took a long time
narrow verge
yeah that sounds like a browser bug lol
pallid yoke
Depending on what folder you last used (giant download folder...) I could see why the browser slows down
But yeah, that's out of our control
somber flicker
Nah thats fine I worked that out..
Plugin Keywords didnt appear to save
The BBCode HTml links are sort of broken as well https://hangar.minidigger.me/Narimm/Prism-Bukkit/pages/'https://discord.gg/8kgkrba'
narrow verge
Yeah it adds ''s
somber flicker
thats processed from * Support is provided on the [M.O.S.S. discord server]('https://discord.gg/8kgkrba').
narrow verge
can you select a promoted version?
somber flicker
I can try
ocean pagoda
uh, that drama generator is great xD
But for me, promoted versions are not even loading
somber flicker
It appears once you have uploaded a version some of the params are no longer editable
You cant create alternate channels yet iether
Aside from not being able to promote a version my plugin also doesnt display the server version I selected on the main menu it does on the download
narrow verge
also notice how times arent local, they're UTC looks like
pallid yoke
Yeah most times are formated on the server
barren shale
* Support is provided on the [M.O.S.S. discord server]('https://discord.gg/8kgkrba') is not bbcode...?
barren shale
"that's processed from: ..."
narrow verge
e.g.
[URL='https://github.com/JavaAPIs/ChewAPI']ChewAPI[/URL]
turns into
[ChewAPI]('https://github.com/JavaAPIs/ChewAPI')
ocean pagoda
because BBCode is strange
barren shale
I see the problem
somber flicker
thats exactly from the spigot code
barren shale
but narimm, you definitely gotta work on your descriptions lol
barren shale
will fix it in like half an hour, it should auto deploy (?) then you can convert again
narrow verge
Yay
somber flicker
translate probably was not the best word to use
safe harbor
Mini send verification url pl0x
safe harbor
thx <3
pallid yoke
Looks good
barren shale
not sure what you think, but I'd either make that window wider or make it centered https://i.imgur.com/8lPPpyv.png 👀
pallid yoke
That once was centered
sly mason
Just, ew
random badger
@somber flicker couple questions on what you said. You should be able to create alternate channels, either on the plugin upload page or on the version list page for your plugin
and what did you mean by params aren't editable after you upload a version?
and the promoted versions will only happen once the version is approved.
so its not a manual thing; marking a version as promoted
random badger
like if you look now, I approved your version of prism-bukkit, and its now listed as a promoted version
narrow verge
If there's no approved versions and you don't have access to manage the project, it just says "Loading versions" forever
Also, clicking an admin on the staff page leads them to /admin/activities, which I assume is an admin only page
pallid yoke
the staff page was only recently exposed to normals
so that is an issue, open one pls
narrow verge
for both?
barren shale
"don't have access to manage the project" isn't the right condition there, I've had the same when logged out, but not when logged in when viewing narimm's project (with only being a user)
narrow verge
yes, if youre logged out, you dont have access to manage any project :p
barren shale
whether or not you have access to manage the project doesn't matter 👀
narrow verge
is it only if you've signed out?
2fa flow works, says sponge instead of hangar though
barren shale
I dunno, would be nice if you can play around to see
narrow verge
alright, can someone go here (while signed in, and no elevated perms) and see if anything loads? https://hangar.minidigger.me/Chew/SpigotDrama/versions
barren shale
otherwise just open with "in yet to be determined cases" 😂
barren shale
doesn't load when not logged in, and loaded (but nothing listed) when logged in for me
narrow verge
Ahh, so issue is not loading when not logged in, perfect
pallid yoke
theres an issue with auth tokens for anno users
I have been meaning to track that down
cinder silo
dunno if this is on the todo list, but you guys should make a nice modal for the sign in message
rn it's just an alert
pallid yoke
ye
but yeah, keep such obversions coming, we get used to shit like this and forget that it should be changed if its not documented
random badger
Yeah mini, there is some set of conditions that require you to clear your local storage to get a new api session key. Not sure what they are tho.
somber flicker
Machine I was referring to "Keywords" not saving - I set prism as "bukkit grief logger rollback" but it seems when I look at the setting they are not saved.
regarding channel creation - I tried to create a "development" channel - it doesnt yet work.
Also when you click "mark all as read" in notifications - not sure if its possible to reload the top bar to clear the red notice dot - it persists until you reload the page
random badger
ok, taking a look at those things now
hmm, they seemed to save when I set them for you
somber flicker
Please let me know if reporting this stuff here is annoying - I feel like creating issues for each one might be more annoying
random badger
try changing them to something else?
somber flicker
It was when I set them on project creation - let me create another project
random badger
oh set on project creation
I thought you meant in the settings page after creation
somber flicker
no they seem fine from there
barren shale
reporting smaller issues here is good 😛
narrow verge
I always report here and I'll toss it on there if requested
Completely forgot about that repo MM, I'll get someone to transfer it lol
somber flicker
Nope definitly doesnt save keywords from project creation page
I just did DripReported with 4 keywords "metric codahale admin reporter"
random badger
yeah, confirmed that on my local instance
somber flicker
Delete Version does not seem to work - but that may be intentional - however without allowing editing of versions parameters it might result in a high frequency of deletion
ie I wanted to go and add a option dep to a specific version I had already created - but I was unable to do so - so I deleted it to create a new entry,,
random badger
what happens when you try to delete a version?
oh, did you get a message saying you only have 1 public version left?
and yeah, go ahead and make an issue for editing dependencies after creating the version, that's probably a good idea to have
random badger
did vue all of a sudden start supporting camel case for events?
somber flicker
also just clarifying that SSO with google does not work?
The JavaScript origin in the request, https://hangar-auth.minidigger.me, does not match the ones authorized for the OAuth client. Visit https://console.developers.google.com/apis/credentials/oauthclient/${your_client_id}?project=${your_project_number} to update the authorized JavaScript origins.
and yes attempting to delete a version gave me the You only have 1 public version left.
random badger
yeah, that should be fixed now. that message should only show up if you have one public version left and you are trying to delete a public version
but if you are trying to delete a non-public version (aka a New version before its been reviewed) it should be deletable now
somber flicker
Just attempted on test site
random badger
not sure it was deployed yet
somber flicker
Also did you confirm that the "CHANNEL" creation is not working on test
random badger
yes, that should be fixed too. there was a bunch of commits pretty quickly, so none of them have made it to live yet
somber flicker
👍
random badger
not sure why its stuck on pending but, hopefully it does its thing here soon
do you have any qualms with the version upload screen? its probably the most complex form. and idk how user-friendly the dependency selection bit is
ore doesn't have anything like that so I had to design it from scratch
somber flicker
Actually I love the dependency stuff - I guess what would be really cool is if the app could parse poms when they are inside the jar of plugin.yml files - or maybe even a custom dependency list file that can be optionally added to a jar as an embedded resource to basically automate that process
random badger
yeah, that idea had actually crossed my mind. might be interesting to explore that
somber flicker
Maybe limit the automatic linking to only Hangar based Plugins tho -
so you can autolink another plugin on Hangar but not external
random badger
Yeah, I mean linking external would mean downloading the external jar and the searching through it right?
somber flicker
Yeah I can show you some internal code we use to extract plugin.ymls and parse them for information - I havent done dependency parsing before but It shouldnt be hard
but year you definitely need the jar locally.
that being said you could get a jar from a remote source and parse it
ivory ingot
load file -> zipfile -> getEntry('plugin.yml') : File -> read yaml -> get('depends')
That's how I would do it.
@somber flicker
somber flicker
yeah thats basically what we do
narrow verge
External URLs should only allow direct JARs
somber flicker
as it directly linking the jar?
narrow verge
Yes
somber flicker
not linking to a page
narrow verge
That would be ideal
cinder silo
how would you even detect
somber flicker
to use the above idea you would have to do that
narrow verge
HEAD in most cases is GET but only for headers
ivory ingot
Github release page with specific release could be allowed, too for later.
somber flicker
Yeah but that requires automation like we are talking about above
Releases and going to need to somehow tell Hangar what server versions they support/ what dependencies they might have.
narrow verge
I mean if you'd upload an artifact it would grab that
somber flicker
sure
narrow verge
Then head/get it accordingly@
somber flicker
right
but then u need to parse the plugin.yml or require the author to include a resource inside the jar that provides hangar with the required information to create a release version
mind you that would also be helpful for the review team - it could give them some more specific information about a new plugin so they can determine if its approval is appropriate
narrow verge
That already happens doesn't it?
somber flicker
I am not privy to that side of things
soft hornet
Ore would parse the sponge file for relevant info
ivory ingot
What about an optional hangar section in plugin.yml ? Where you can add these things.
hangar.supported-version-range:[1.13, 1.16]
somber flicker
Also BUG report Hangar is not saving the project image file permanently
I have updated Prism jpg 3 tims now and it appears to save but then resets
ysl I think you need more than that - you need to define dependencies and in particular link to the related plugin on hangar
I know they are already in depends: and soft-depends:
but thats just the names
ivory ingot
Is there an extension planned to support loading resource descriptions from GitHub repo.
Like creating a hangar.md there and it ist automatically fetched/ displayed in hangst.?
ivory ingot
I know they are already in
depends:andsoft-depends:
@somber flicker yeah at that point it is guessing.
With a hardfork paper we could also support objects in depends.
{
name: "Worldguard",
URL: "Https://enginehub...."
}
somber flicker
imagine ...you could setup recursive plugin dependency info
ivory ingot
hangar.dependencies:
worldguard: "hangar.papermc.com/worldguard/version?min=7.1&max=7.9
And the server passes the server version as well.
imagine ...you could setup recursive plugin dependency info
@somber flicker imagine we implement it and this is the reason why most people migrate to Hangar.
somber flicker
I suspect if Paper hardforks - that would be the main reason
ivory ingot
60% of the Spigot users failing because of missing dependencies.
Needs no hardfork with the hangar section.
somber flicker
The other consideration Machine re versions ->dependencies is the specific version of the dependency
I didnt see an option for that in the dependency picker - that might be a relevant addition
ivory ingot
Ah ok. Head to bed now. It is 02:49 am
pallid yoke
also just clarifying that SSO with google does not work?
The JavaScript origin in the request, https://hangar-auth.minidigger.me, does not match the ones authorized for the OAuth client. Visit https://console.developers.google.com/apis/credentials/oauthclient/${your_client_id}?project=${your_project_number} to update the authorized JavaScript origins.
@somber flicker yeah sso isn't setup yet, it's actually just using the key ore uses ^^
I like the idea of having a paper/hangar specific section in plugin.yml
You can already put in whatever you want anyways, could just collect hangar metadata with that without affecting any server impl
sly thunder
just noticed this when registering
pallid yoke
thats configurable
sly thunder
alright, just making sure in case you missed it
sly thunder
aight, also i didnt get a verificaiton email i think
pallid yoke
because I got it 😛
sly thunder
sly thunder
inb4 gets password in plain text
pallid yoke
there is no mail server setup
sly thunder
ah
pallid yoke
sly thunder
the channel dropdown changes color with the color thats currently selected
also a way to navigate back to resources would be nice, you're kinda stuck on the plugin page rn. Unless you use the dropdown, which isnt very user friendly imo
nvm you can just click the giant button
random badger
@somber flicker with regards to selecting dependency versions, we decided that’s too far. It’s too complex and would require authors to go back and update that when a new version is released.
Better to just have the author put that info in the plugin description if they feel it’s needed
somber flicker
Fair enough
Although you could use maven versioning for that feature -
ie Maven can declare a range of dependency options via a pom or a minimum dependency but I understand that decision well it had that in maven2
random badger
Well people aren’t uploading their POM right? That’s usually not included in the jar. I just think it’d get to complex for the end user at that point.
ocean pagoda
There hopefully shouldn't be too many plugins that depend on a specific version of something
mossy topaz
If you're building a single-pom.xml project with maven, the pom is actually included in the jar, in META-INF/maven/. Just fyi
Multi-module projects package the pom.xml of that module
ocean pagoda
and even the poms of dependencies are included, atleast for me. Maybe I did something wrong, that seems excessive
mossy topaz
No, that's standard maven-shade behaviour. Resource files are also shaded
somber flicker
The exception to this is anything built with gradle
Gradle can have a POM but by default doesnt
mossy topaz
or, in the very worst case, a project without a proper build system
ocean pagoda
btw, maybe im blind, but it would be nice if you could edit the supported version. Currently it seems to read that from the plugin.yml, so it does not allow versions older than 1.13
pallid yoke
Which would be a nice feature 😂 😂
ocean pagoda
I made the plugin for 1.16, but for some reason 1.8 works as well, so why not
If people really want to miss five years of updates 😄
pallid yoke
this is how you select the versions
it defaults to whatever is defined as api-version
and then allows you to check whatever
sly thunder
@pallid yoke could it be that you cant change the channels of a plugin?
there doesnt seem to be a way to adjust it
ocean pagoda
Ah, didn't see that 😄
pallid yoke
not after upload, I don't think so
pallid yoke
everything is possible
sly thunder
pallid yoke
what would be the usecase?
sly thunder
well, assigning the wrong channels and only realize later its wrong
sly thunder
i mean sure
ocean pagoda
Not possible because you can't upload the same file twice
sly thunder
thats not really user friendly tho