waterfall-github

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue closed: #378 issue with disable\_entity\_metadata\_rewrite

salifm

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[Travertine:master] 1 new commit

3bacafa Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

Xofters

[PaperMC/Waterfall] Issue opened: #398 Error in console Empty packet

[19:51:04 ERROR]: [/188.69.209.5:52564|vegetafan] <-> DownstreamBridge <-> [s2] - encountered exception
io.netty.handler.codec.CorruptedFrameException: Empty Packet!
at net.md_5.bungee.protocol.Varint21FrameDecoder.decode(Varint21FrameDecoder.java:44) ~[server.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:1f16030:286]
at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:502) ~[server.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:1f16030:286]
...

electronicboy

[PaperMC/Waterfall] New comment on issue #398: Error in console Empty packet

Something on your server caused an empty packet to be sent to the proxy, by default bungee considers this an error, whereas the client will generally just ignore it. There is an option in waterfall.yml to allow such broken state, however you should generally look into finding what is causing it and removing it.

electronicboy

[PaperMC/Waterfall] Issue closed: #398 Error in console Empty packet

[buoyant shore]

FrozenBeard

[PaperMC/Waterfall] Issue opened: #399 Error whilst handling query packet from /195\.201\.249\.154:60159

I get this a lot in my logs, and its all the same IP.

[10:58:03] [Netty Worker IO Thread #0/WARN]: Error whilst handling query packet from /195.201.249.154:60159
java.lang.IllegalStateException: No session!
	at net.md_5.bungee.query.QueryHandler.handleMessage(QueryHandler.java:99) ~[Waterfall.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:1f16030:286]
	at net.md_5.bungee.query.QueryHandler.channelRead0(QueryHandler.java:60) ~[Waterfall.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:1f16030:286...

electronicboy

[PaperMC/Waterfall] New comment on issue #399: Error whilst handling query packet from /195\.201\.249\.154:60159

There isn't much we can do about invalid traffic being sent to the proxy, we could probably remove the trace itself like other exceptions in this area, but overall, the proxy is working as intended

FrozenBeard

[PaperMC/Waterfall] Issue opened: #400 Random Kicks: internal Exeption: java\.net\.socketException: connection reset

I have been having issues with people randomly getting kicked from the servers I have under waterfall with:
internal Exeption: java.net.socketException: connection reset
looking up the bungee logs:
I have redacted username and IP:

[13:14:08] [Netty Worker IO Thread #4/INFO]: [/5.66.777.8:51170] <-> InitialHandler is pinging
[13:14:08] [Netty Worker IO Thread #6/INFO]: [/5.66.777.8:51171] <-> InitialHandler has connected
[13:14:09] [Netty Worker IO Thread #6/INFO]: [Usernameredact...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #400: Random Kicks: internal Exeption: java\.net\.socketException: connection reset

java.net.socketException: connection reset - The connection was improperly closed by a remote, are players actually complaining about this? if so, you'll need their client logs to check for any errors, etc; if they're not complaining, they're probably just closing the client improperly

electronicboy

[PaperMC/Waterfall] Issue closed: #400 Random Kicks: internal Exeption: java\.net\.socketException: connection reset

electronicboy

[PaperMC/Waterfall] New comment on issue #392: Waterfall change my config\.yml

Changing actual configuration values is not something bungee does on its own, your configuration is also formatted improperly, incorrect tabbing etc, hence why you're getting that exception

electronicboy

[PaperMC/Waterfall] Issue closed: #392 Waterfall change my config\.yml

[buoyant shore]

FrozenBeard

[PaperMC/Waterfall] New comment on issue #400: Random Kicks: internal Exeption: java\.net\.socketException: connection reset

What usually happens is a large group gets kicked at once, so if there's 40 online 15 might all be disconnected at the same time in bulk, yes they are complaining, not sure why this was closed? it's quite an annoying bug.

electronicboy

[PaperMC/Waterfall] New comment on issue #400: Random Kicks: internal Exeption: java\.net\.socketException: connection reset

Connection reset means that the connection was improperly closed by a remote node, not by waterfall; Sounds like either something is sending info to clients which is causing them to kill or there is an issue with your network in general, overall I can't see a waterfall issue here given the generic nature of the issue, we'd need more info to confirm that an issue exists with waterfall

[buoyant shore]

Charismara

[PaperMC/Waterfall] New comment on issue #392: Waterfall change my config\.yml

@electronicboy The problem is the valid config (this one) change itself to this one which crashes my waterfall proxy. Is there any way to prevent that file from changing?

electronicboy

[PaperMC/Waterfall] New comment on issue #392: Waterfall change my config\.yml

Waterfall itself cannot change the file like that, nor does it make any configuration changes itself, are you using some startup scripts that might be modifying the configs or something?

Charismara

[PaperMC/Waterfall] New comment on issue #392: Waterfall change my config\.yml

java -server -Xmx2048M -jar waterfall.jar nogui
this is my full startup code

[buoyant shore]

willieavendano

[PaperMC/Waterfall] New star added

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #392: Waterfall change my config\.yml

I don't know what's going on with your bungeecord. Both configs you sent are invalid.
In your original config one space at start of the line is missing in lines 4, 20, 32 and 35.
Yaml is space-sensitive.

[buoyant shore]

FrozenBeard

[PaperMC/Waterfall] New comment on issue #400: Random Kicks: internal Exeption: java\.net\.socketException: connection reset

It is waterfall, like I reported. I disabled use_netty_dns_resolver and I haven't seen a mass kick of users since, time will tell.
I will keep this ticket updated with any more inconsistencies with keeping a user connected to the bungee.

[buoyant shore]

colinrgodsey

[PaperMC/Waterfall] New comment on pull request #395: Properly check that the channel is closed

I have noticed this before. Need to fully understand when TCP channels go inActive vs closing... I believe the 'active' state changes immediately, then 'close' doesn't fulfill until the underlying socket itself is closed (which may have to wait on a selector channel).

[buoyant shore]

dunielpls

[PaperMC/Waterfall] New star added

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on pull request #395: Properly check that the channel is closed

// Waterfall comment is missing when you do that change.

[buoyant shore]

MaxIsH0t

[PaperMC/Travertine] Fork created: MaxIsH0t/Travertine

[buoyant shore]

bellmc

[PaperMC/Waterfall] Fork created: bellmc/Waterfall

[buoyant shore]

AutoComplete1

[PaperMC/Waterfall] Issue opened: #401 Waterfall Crash \[java\.lang\.RuntimeException: VarInt too big\]

Hello,
currently our bungeecord is crashed after my research with the help of wrong packets. The crash is so that the proxy is not reachable for about one minute and is then reachable again. Here's the exception:
`io.netty.handler.codec.DecoderException: java.lang.RuntimeException: VarInt too big
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:98) ~[bungee.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:c0c84ca:287]
at io.netty.channel.AbstractChann...

[buoyant shore]

xxDark

[PaperMC/Waterfall] New comment on issue #401: Waterfall Crash \[java\.lang\.RuntimeException: VarInt too big\]

It is not related to the proxy itself, someone is sending invalid packets

[buoyant shore]

AutoComplete1

[PaperMC/Waterfall] New comment on issue #401: Waterfall Crash \[java\.lang\.RuntimeException: VarInt too big\]

@xxDark I am aware of this, but I have a problem with the fact that the proxy is not reachable for about one minute and all players are kicked. If only the error in the console would come, I wouldn't have a problem with it.

[buoyant shore]

Damien111

[PaperMC/Waterfall] New star added

[buoyant shore]

xxDark

[PaperMC/Waterfall] Pull request opened: #402 Allow to disable scoreboards api

[buoyant shore]

iYushu

[PaperMC/Waterfall] New star added

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New review comment on pull request #402: Allow to disable scoreboards api

Missing // Waterfall

MrIvanPlays

[PaperMC/Waterfall] New review comment on pull request #402: Allow to disable scoreboards api

Missing // Waterfall

MrIvanPlays

[PaperMC/Waterfall] New review comment on pull request #402: Allow to disable scoreboards api

Missing // Waterfall

MrIvanPlays

[PaperMC/Waterfall] Pull request review submitted: #402 Allow to disable scoreboards api

You are missing some things

MrIvanPlays

[PaperMC/Waterfall] New comment on pull request #402: Allow to disable scoreboards api

And one more thing: why this is useful?

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on pull request #402: Allow to disable scoreboards api

And one more thing: how this is useful?

This should help with high memory usage introduced by storing scoreboard teams in memory.

Personally I find that disabling Scoreboard API is bit invasive, team objects could be improved by turning name tag visibility/collision rule flags into enums (which requires de-Lomboking the methods and more care on updates).

[buoyant shore]

BingYanchi

[PaperMC/Waterfall] New star added

[buoyant shore]

FrozenBeard

[PaperMC/Waterfall] Issue opened: #403 People randomly kicked \- WARN\]: \[/IPHERE:PORT\] <\-> InitialHandler \- NativeIoException: syscall:read\(\.\.\) failed: Connection reset by peer

This is getting ridiculous now, my last ticket got closed without even looking into this.
This is happening to a LOT of my users.
I have had my server for 6 years and this has just started happening out of the blue, I am the server owner and its happened to me after playing for about 60 mins in a stable internet connection, I know I haven't had this issue before, its Bungee/Waterfall issue.

Searching for the word "WARN" in my latest bungee log brings back 1152 results... This isn't ...

[buoyant shore]

Black-Hole

[PaperMC/Waterfall] New comment on issue #403: People randomly kicked \- WARN\]: \[/IPHERE:PORT\] <\-> InitialHandler \- NativeIoException: syscall:read\(\.\.\) failed: Connection reset by peer

You have to sort this out with your hosting provider.
As with any networking program getting a "Connection reset by peer" is not something you could mitigate at the application layer.

[buoyant shore]

FrozenBeard

[PaperMC/Waterfall] New comment on issue #403: People randomly kicked \- WARN\]: \[/IPHERE:PORT\] <\-> InitialHandler \- NativeIoException: syscall:read\(\.\.\) failed: Connection reset by peer

@Black-Hole it's a Dedi box on kimsufi, how do I diagnose the issue? It's basically no support unless you tell them exactly what's wrong. I have no idea how to diagnose this. Ovh the parent company is massive, but it's not Minecraft specific.

[buoyant shore]

Black-Hole

[PaperMC/Waterfall] New comment on issue #403: People randomly kicked \- WARN\]: \[/IPHERE:PORT\] <\-> InitialHandler \- NativeIoException: syscall:read\(\.\.\) failed: Connection reset by peer

I don't know, but as said before Waterfall gets a message from the TCP stack of the operating system that the connection was closed remotly. And there is nothing to do about that in Waterfall.

[buoyant shore]

AutoComplete1

[PaperMC/Waterfall] Issue closed: #401 Waterfall Crash \[java\.lang\.RuntimeException: VarInt too big\]

[buoyant shore]

DiscowZombie

[PaperMC/Waterfall] New star added

[buoyant shore]

NXGHTMVRX

[PaperMC/Waterfall] New star added

[buoyant shore]

Linux-4

[PaperMC/Waterfall] Fork created: Linux-4/Waterfall

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

835d514 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

7a0f508 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

FrugBatt

[PaperMC/Travertine] Fork created: FrugBatt/Travertine

FrugBatt

[PaperMC/Waterfall] Fork created: FrugBatt/Waterfall

[buoyant shore]

Dinnerwolph

[PaperMC/Waterfall] Fork created: Dinnerwolph/Waterfall

[buoyant shore]

xxDark

[PaperMC/Waterfall] Pull request opened: #404 Explicitly construct array for dispatching events

xxDark

[PaperMC/Waterfall] Pull request closed: #404 Explicitly construct array for dispatching events

xxDark

[PaperMC/Waterfall] Pull request opened: #405 Explicitly construct array for dispatching events

[buoyant shore]

Black-Hole

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

What's the purpose of this commit? Does it lower cpu or memory consumption? If so, do you have some some tests that's shows this?

xxDark

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

What's the purpose of this commit? Does it lower cpu or memory consumption? If so, do you have some some tests that shows this?

Reduces array creation caused by invoking events via reflection, since java.lang.Method.invoke(...) creates new array on each invocation, this commit replaces it with direct MethodAccessor's, and array is created only once.

Will provide tests maybe tomorrow, cuz I'm a bit tired rn

[buoyant shore]

theminecoder

[PaperMC/Waterfall] Fork created: theminecoder/Waterfall

theminecoder

[PaperMC/Waterfall] Pull request opened: #406 Updated Upstream for 1\.14\.4 \(Bungeecord\)

good morning from down under

andrewkm

[PaperMC/Waterfall] New comment on pull request #406: Updated Upstream for 1\.14\.4 \(Bungeecord\)

Yes :)

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #406 Updated Upstream for 1\.14\.4 \(Bungeecord\)

electronicboy

[PaperMC/Waterfall] Pull request closed: #406 Updated Upstream for 1\.14\.4 \(Bungeecord\)

electronicboy

[Waterfall:master] 1 new commit

0766f50 Updated Upstream for 1.14.4 (Bungeecord) - theminecoder

[buoyant shore]

theminecoder

[PaperMC/Travertine] Pull request opened: #110 Updated Upstream for 1\.14\.4 \(Waterfall\)

I'm thinking spaghetti for lunch? Any other ideas?

astei

[PaperMC/Travertine] New comment on pull request #110: Updated Upstream for 1\.14\.4 \(Waterfall\)

Tacos. Always tacos.

[buoyant shore]

zachbr

[Travertine:master] 1 new commit

54a75af Updated Upstream for 1.14.4 (Waterfall) (#110) - theminecoder

zachbr

[PaperMC/Travertine] Pull request closed: #110 Updated Upstream for 1\.14\.4 \(Waterfall\)

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

You are missing a bunch of // Waterfalls, also why you exclude classes from compiling? One more thing: you are making new classes which are specific for waterfall under the net.md_5 package, while you should make it under io.github.waterfallmc.waterfall

[buoyant shore]

successed

[PaperMC/Waterfall] Issue opened: #407 terminal console error 1\.14\.4

[10:30:21 ERROR]: Exception in thread "main" java.lang.NoClassDefFoundError: org/jline/terminal/Terminal$MouseTracking
[10:30:21 ERROR]: at org.jline.reader.impl.LineReaderImpl.doCleanup(LineReaderImpl.java:2345)
[10:30:21 ERROR]: at org.jline.reader.impl.LineReaderImpl.cleanup(LineReaderImpl.java:2332)
[10:30:21 ERROR]: at org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:626)
[10:30:21 ERROR]: at org.jline.reader.impl.LineReaderImpl.readLi...

[buoyant shore]

Minecrell

[PaperMC/Waterfall] New comment on issue #407: terminal console error 1\.14\.4

Related: https://github.com/PaperMC/Paper/issues/894#issuecomment-331787892

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

The purpose of those classes excluded from jar packing is that he apparanrly didnt find a library for these jdk internal classes to add.

xxDark

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

The purpose of those classes excluded from jar packing is that he apparanrly didnt find a library for these jre-internal classes.

Nope, jdk.internal.reflect is sun.reflect since jdk 9, that's why dummy classes was added.

[buoyant shore]

HeathLoganCampbell

[PaperMC/Waterfall] New star added

[buoyant shore]

MAZUU

[PaperMC/Waterfall] New star added

[buoyant shore]

successed

[PaperMC/Waterfall] New comment on issue #407: terminal console error 1\.14\.4

Related: PaperMC/Paper#894 (comment)

My problem is waterfall, and you tag is paper problem mean, i not have paper problem.

electronicboy

[PaperMC/Waterfall] New comment on issue #407: terminal console error 1\.14\.4

The issue is generally the exact same cause, can you reproduce this issue?

[buoyant shore]

MedicOP

[PaperMC/Waterfall] New comment on issue #394: LowMemorySet lag

Any updates on this?

Even if you have a million entries, assuming the overhead is as high as 64 bytes per entry (way more than it actually is), that's only 64MB of RAM.

I don't see why this change is necessary, and sorting the set each time an entry is added is horrible for performance.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #394: LowMemorySet lag

This class has been primed for removal, just; Dreadful mistake of installing Catalina meant that I couldn't make the relevant changes, I'll try and get to this later goes back to huggling mojave

electronicboy

[PaperMC/Waterfall] Issue closed: #394 LowMemorySet lag

electronicboy

[PaperMC/Waterfall] Issue reopened: #394 LowMemorySet lag

[buoyant shore]

Minecrell

[PaperMC/Waterfall] Pull request opened: #408 Update TerminalConsoleAppender to 1\.2\.0

Same changes as in https://github.com/PaperMC/Paper/pull/2299. Update TCA + JLine, replace JNA with Jansi. Also updated Log4j2 while I was at it :)

[buoyant shore]

otreblan

[PaperMC/Waterfall] New star added

[buoyant shore]

willyb321

[PaperMC/Waterfall] New star added

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] Pull request review submitted: #408 Update TerminalConsoleAppender to 1\.2\.0

[buoyant shore]

HeavenPix

[PaperMC/Waterfall] Fork created: HeavenPix/Waterfall

[buoyant shore]

Midnoclose

[PaperMC/Waterfall] New star added

CrystallDEV

[PaperMC/Waterfall] New star added

[buoyant shore]

8MiYile

[PaperMC/Travertine] New star added

[buoyant shore]

HeberonYT

[PaperMC/Travertine] New comment on issue #88: Addition Request : Provide an option to disable entity metadata rewriting \(fixes PaperMC… …\#136\)

@Sharkske did you solve the problem?

[buoyant shore]

HeberonYT

[PaperMC/Travertine] Issue opened: #111 Crash Client 1\.7\.10

Hello!
I am having trouble connecting to my Thermos server.
My current network is:
Server 1 : Travertine #105
Server 2: Paper-1.12.2-b1618
Server 3: Thermos build 58

With modpack 1.7.10 I can enter server 2 without problems, but when entering server 3 (thermos) my client crashes.
Client crash: https://pastebin.com/raw/YG0RzTji

Log Travertine: https://pastebin.com/raw/hShKkpwB
Log Paper: https://pastebin.com/raw/kjeEiQbW
Log Thermos: https://pastebin.com/raw/uXDBUERQ

[buoyant shore]

SpicyDwarf

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[PaperMC/Travertine] New comment on issue #111: Crash Client 1\.7\.10

Does connecting directly with a forced host help? Have you tried disabling
entity metadata rewiring in waterfall.yml? Ultimately, forge and bungee in
general are a bit of a sticky topic in which it's mostly down to mods to
handle bungee properly, shamefully, many don't and won't work with bungee
at all as stuff occurs which they don't expect

On Mon, 22 Jul 2019, 22:45 HeberonYT, [e-mail] wrote:

Hello!
I am having trouble connecting to my Thermos server.
My current ne...

[buoyant shore]

new-sashok724

[PaperMC/Travertine] New star added

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on pull request #373: Speed up packet construction

Bump

[buoyant shore]

Jgbcode

[PaperMC/Travertine] Fork created: Jgbcode/Travertine

[buoyant shore]

Alexre

[PaperMC/Waterfall] Issue opened: #409 LOST\_CONNECTION message being sent after a voluntary disconnection

¿Should the LOST_CONNECTION message be sent by waterfall after a player disconnects by his own from a server? I thought that it would only be sent if the player loses the connection unexpectedly.

Here is the case, I have a lobby-kick plugin, and it's configured to detect the lost_connection message that I have. When a player disconnects from the whole server, that message is sent and the plugin detects it and tries to send the player to the lobby. It causes "the Unexpected packet received ...

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #409: LOST\_CONNECTION message being sent after a voluntary disconnection

could this theoretically be an issue also with bungeecord? in that case opening an issue there too would be a good idea.

where is your plugin operating? where is the message printed which your plugin detects?

[buoyant shore]

suzeanne

[PaperMC/Waterfall] New star added

[buoyant shore]

Seloex

[PaperMC/Waterfall] Fork created: Seloex/Waterfall

[buoyant shore]

HeberonYT

[PaperMC/Travertine] New comment on issue #111: Crash Client 1\.7\.10

@electronicboy
Thanks for your answer.
This is the configuration of my waterfall.yml

use_netty_dns_resolver: true disable_entity_metadata_rewrite: true disable_modern_tab_limiter: true log_initial_handler_connections: true throttling: tab_complete: 1000 game_version: '' allow_empty_packets: false

I have also tried to remove all mods from the server and client and only leave thermos installed, but crashing is still present on the client.
The only thing I need to try is t...

[buoyant shore]

Songxwn

[PaperMC/Waterfall] Issue opened: #410 Forestry 【Minecart with Apiary】 Place Player dropped

kpmyon] <-> DownstreamBridge <-> [shengcun] - encountered exception
java.lang.IllegalArgumentException: Unknown meta type 14: Using mods? refer to disable_entity_metadata_rewrite in waterfall.yml
at net.md_5.bungee.entitymap.EntityMap.rewriteMetaVarInt(EntityMap.java:283) ~[waterfall-289.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:eb6cf93:289]
at net.md_5.bungee.entitymap.EntityMap.rewriteMetaVarInt(EntityMap.java:135) ~[waterfall-289.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT...

electronicboy

[PaperMC/Waterfall] New comment on issue #410: Forestry 【Minecart with Apiary】 Place Player dropped

java.lang.IllegalArgumentException: Unknown meta type 14: Using mods? refer to disable_entity_metadata_rewrite in waterfall.yml disable entity metadata rewriting

electronicboy

[PaperMC/Waterfall] Issue closed: #410 Forestry 【Minecart with Apiary】 Place Player dropped

electronicboy

[PaperMC/Waterfall] New comment on issue #409: LOST\_CONNECTION message being sent after a voluntary disconnection

What message exactly? How are they disconnecting? (there is a huge difference between clicking disconnect and closing the minecraft window); Logs?

Songxwn

[PaperMC/Waterfall] New comment on issue #410: Forestry 【Minecart with Apiary】 Place Player dropped

Sorry to bother, I didn't look carefully.

[buoyant shore]

Alexre

[PaperMC/Waterfall] New comment on issue #409: LOST\_CONNECTION message being sent after a voluntary disconnection

@electronicboy The plugin is set to listen for the message "lost_connection=[Proxy] Lost connection to server."

They are disconnecting clicking disconnect, as I tried it myself.

I don't have a clear log, but I tried to see what happens in the console

`
[23:26:20] [Netty Worker IO Thread #16/INFO]: [/|AlexReq] -> UpstreamBridge has disconnected

[23:26:20] [Netty Worker IO Thread #16/INFO]: [/|AlexReq] <-> DownstreamBridge <-> [murder] has disconnected

[23:26:20] [Netty Worker I...

electronicboy

[PaperMC/Waterfall] New comment on issue #409: LOST\_CONNECTION message being sent after a voluntary disconnection

Can you replicate this without plugins? The logs look normal up until the point that it's trying to move somebody to another server, I believe that there is a case in which waterfall fires an event when bungee doesn't which can cause issues for some plugins

[buoyant shore]

andrewkm

[PaperMC/Waterfall] New comment on issue #393: Error dispatching event PlayerDisconnectEvent

Doesn't happen anymore.

andrewkm

[PaperMC/Waterfall] Issue closed: #393 Error dispatching event PlayerDisconnectEvent

Cyvros

[PaperMC/Waterfall] Issue opened: #411 "game\_version:" not working in 289?

After updating to 289 waterfall seems to ignore what is set in "game_version:" and accepts all connections again.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #411: "game\_version:" not working in 289?

game_version only controls what's sent to the client for the server list ping, it's part of what displays on a protocol version mismatch

electronicboy

[PaperMC/Waterfall] Issue closed: #411 "game\_version:" not working in 289?

[buoyant shore]

Cyvros

[PaperMC/Waterfall] New comment on issue #411: "game\_version:" not working in 289?

beeing only to display a version at mismatch: colsing does not solve it.
It still not shows the entry 1.14.2 when i load the serverlist with 1.8.9 ... so it still does not work and is an issue since last version? It worked before updating.

electronicboy

[PaperMC/Waterfall] New comment on issue #411: "game\_version:" not working in 289?

Configuration? screenshots?
From what I can see your issue is a misunderstanding of what that configuration does

Cyvros

[PaperMC/Waterfall] New comment on issue #411: "game\_version:" not working in 289?

i do not missunderstand …. it worked before …
it should show a red "1.14.2" instead of the players on the 1.8.9 client shouldn't it ?

electronicboy

[PaperMC/Waterfall] New comment on issue #411: "game\_version:" not working in 289?

Bungee itself doesn't know the version of the backend server, for 1.14.3 on the earlier build it would show that info, but as the newest version of waterfall supports 1.8-1.14.4, it's happy as is; Enabling ping-forwarding in config.yml will make it forward the ping to the server which will return the correct version info

[buoyant shore]

danwillm

[PaperMC/Waterfall] Fork created: danwillm/Waterfall

[buoyant shore]

dasphantom04

[PaperMC/Waterfall] New star added

[buoyant shore]

amayakasa

[PaperMC/Waterfall] Fork created: amayakasa/Waterfall

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

9cdf9dd Remove LowMemorySet (Fixes #394) - electronicboy

electronicboy

[PaperMC/Waterfall] Issue closed: #394 LowMemorySet lag

electronicboy

[PaperMC/Waterfall] Issue closed: #407 terminal console error 1\.14\.4

electronicboy

[Travertine:master] 1 new commit

f3f7fa3 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

ckhawks

[PaperMC/Waterfall] New star added

[buoyant shore]

MedicOP

[PaperMC/Travertine] Issue opened: #112 1\.7 team related error

Players are unable to connect using Minecraft 1.7, Travertine shows this error:

I am using Spigot 1.8 with ViaRewind. Is this a Travertine or a ViaRewind problem?

[buoyant shore]

gp-Airee

[PaperMC/Waterfall] Fork created: gp-Airee/Waterfall

[buoyant shore]

metehan-gezer

[PaperMC/Waterfall] Fork created: metehan-gezer/Waterfall

[buoyant shore]

minblock

[PaperMC/Waterfall] New star added

minblock

[PaperMC/Waterfall] Fork created: minblock/Waterfall

[buoyant shore]

kevinlovely

[PaperMC/Waterfall] New star added

[buoyant shore]

cybmp3

[PaperMC/Waterfall] Fork created: cybmp3/Waterfall

[buoyant shore]

TechieBlort

[PaperMC/Waterfall] Issue opened: #412 Waterfall disconnects users from the server

Provided is the error when a user is trying to join 02.08 13:13:53 [Server] WARN [io.netty.util.concurrent.AbstractEventExecutor]: A task raised an exception. Task: net.md_5.bungee.connection.InitialHandler$6$1@4238b77f
02.08 13:13:53 [Server] INFO java.lang.IllegalStateException: Default server not defined
02.08 13:13:53 [Server] INFO at com.google.common.base.Preconditions.checkState(Preconditions.java:444) ~[waterfall-290.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:c3d67e5:290]
02.08 13:1...

TechieBlort

[PaperMC/Waterfall] Issue closed: #412 Waterfall disconnects users from the server

[buoyant shore]

TechieBlort

[PaperMC/Waterfall] New comment on issue #412: Waterfall disconnects users from the server

I closed this thinking I solved it but it still is showing the error sorry about that.

TechieBlort

[PaperMC/Waterfall] Issue reopened: #412 Waterfall disconnects users from the server

electronicboy

[PaperMC/Waterfall] New comment on issue #412: Waterfall disconnects users from the server

Your configuration file is incorrect and likely doesn't define any priorities in the listener (outside of a plugin), I'd suggest joining discord/using the forums for support

electronicboy

[PaperMC/Waterfall] Issue closed: #412 Waterfall disconnects users from the server

yudete

[PaperMC/Waterfall] New star added

[buoyant shore]

rz7d

[PaperMC/Waterfall] New star added

[buoyant shore]

tomo1560

[PaperMC/Waterfall] Issue opened: #413 lost connection when chat only fullwidth space

lost connection when chat only full-width space ("　")
use version：waterfall#290
console log：https://pastebin.com/JZ94cpj1
image：

[buoyant shore]

Black-Hole

[PaperMC/Waterfall] New comment on issue #413: lost connection when chat only fullwidth space

This seems to be designed this way:
https://github.com/PaperMC/Waterfall/blob/master/BungeeCord-Patches/0024-Validate-that-chat-messages-are-non-blank.patch

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #413: lost connection when chat only fullwidth space

This is intentional, not 100% on why it was done, but there is a good chance that it was treated differently in older client versions than it is now

[buoyant shore]

Brokkonaut

[PaperMC/Waterfall] New comment on issue #394: LowMemorySet lag

Doesn't the remaining part of the patch (the String.intern()) create a memory leak, because all names that have ever been added to the Team will never be removed from the memory again?

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #394: LowMemorySet lag

I'm sure the intern list/map is using weak references.

Janmm14

[PaperMC/Waterfall] New comment on issue #413: lost connection when chat only fullwidth space

Should be changed probably to only check is empty in higher client versions.

[buoyant shore]

DieKautz

[PaperMC/Waterfall] New star added

[buoyant shore]

sustained

[PaperMC/Waterfall] New star added

[buoyant shore]

BunSLaPatate

[PaperMC/Waterfall] New star added

[buoyant shore]

danwillm

[PaperMC/Waterfall] Issue opened: #414 Disabling item change animation on server change

Hello,

I was wondering if there was a way to disable the item change animation when switching servers? At the moment when I change servers, the playOutHeldItemChange packet gets sent, which looks like it triggers the animation... is there any way to disable it?

Thank you very much in advance.

[buoyant shore]

coco0325

[PaperMC/Waterfall] Issue opened: #415 Half of Player Were Kicked

Half of player were kicked after the error.

Waterfall-290
PaperSpigot 1.14.4

Error log:
06.08 22:18:30 [Server] WARN No client connected for pending server!
06.08 22:18:30 [Server] INFO 0d0100
06.08 22:18:31 [Server] WARN No client connected for pending server!
06.08 22:18:31 [Server] INFO 0d0100
06.08 22:18:31 [Server] WARN No client connected for pending server!
06.08 22:18:31 [Server] INFO 0d0100

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #415: Half of Player Were Kicked

Not enough information, please paste your logs/latest.log into gist.github.com

mikroskeem

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

Why would you want to disable that exactly?

[buoyant shore]

TerriblePanda

[PaperMC/Waterfall] Issue opened: #416 Skins are not showing in offline mode\.

This is Widely known "bug" in bungeecord. The main reason is the wrong uuid of players. But I still hope you guys fix it soon, Velocity Proxy have fixed it already, so I belive there's a way to fix it.

electronicboy

[PaperMC/Waterfall] New comment on issue #416: Skins are not showing in offline mode\.

We need more information, as this 100% works fine in a properly configured/supported environment

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

The new server is sending the last known cursor position of the hotbar / the default one / the one set by a plugin on join.

[buoyant shore]

TerriblePanda

[PaperMC/Waterfall] New comment on issue #416: Skins are not showing in offline mode\.

I'm using travetine now.
Proxy config:

ip_forward: true
online_mode: false

Spigot: 1.8.8 paperspigot.

Spigot server.properties

online_mode: false

Spigot spigot.yml

bungeecord: true

electronicboy

[PaperMC/Waterfall] New comment on issue #416: Skins are not showing in offline mode\.

online_mode: false You need to have the proxy in online mode for skins, the correct UUID is handled by the proxy and sent to backend servers

electronicboy

[PaperMC/Waterfall] Issue closed: #416 Skins are not showing in offline mode\.

TerriblePanda

[PaperMC/Waterfall] New comment on issue #416: Skins are not showing in offline mode\.

I have said "Skins are not showing in offline mode." in the title and I need you guys to make skin works on offline mode. Velocity proxy have fixed this issue already.

electronicboy

[PaperMC/Waterfall] New comment on issue #416: Skins are not showing in offline mode\.

Sorry, I didn't read the title properly, there are plugins to achieve this, but you set the proxy into offline mode and told it not to contact mojangs API, I'm not really sure why you're expecting a different behavior

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #376: Messages

This would be a nice feature because there isnt really another reason to use Waterfall over Bungecord in my opinion

Waterfall does a bunch of performance improvements. Thats why you should be using it

[buoyant shore]

danwillm

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

@Janmm14 could you help me as to tell me where that is?

Thank you very much.

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

Intercept said packet, cancel sending and move handling to plugin installed on the proxy. Should be easily doable, just don't forget to keep slot state sync with backend servers (e.g via plugin messages - tell server about new slot state on join)

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #416: Skins are not showing in offline mode\.

SkinsRestorer for example

[buoyant shore]

LogalDeveloper

[PaperMC/Waterfall] New star added

[buoyant shore]

omnivion

[PaperMC/Waterfall] New star added

[buoyant shore]

danwillm

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

Where am I able to intercept that packet? I've tried downstreambridge but doesn't seem to be working

[buoyant shore]

danwillm

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

@mikroskeem

Where would I be able to find the code to intercept this packet? I've tried downstreambridge.java but it doesn't seem that I can cancel it there.

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

you have to add a new packet in the protocol module and register it, and then in the proxy module you have to update the interface of downstreambridge for handling, and then you can handle it in downstreambridge

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue closed: #415 Half of Player Were Kicked

electronicboy

[PaperMC/Waterfall] New comment on issue #414: Disabling item change animation on server change

^ Bungee requires that packets are registered in order to be able to "intercept" them, otherwise, they're just passed straight through. Ultimately, the client was never really intended to be used like this, you could test if the disable entity metadata in waterfall.yml provides a nicer transfer experience given that it forces more client state to be in a "we're joining a server" vs "we're switching dimension", or try to control what the client is sent more as above

electronicboy

[PaperMC/Waterfall] Issue closed: #414 Disabling item change animation on server change

electronicboy

[PaperMC/Waterfall] Issue closed: #409 LOST\_CONNECTION message being sent after a voluntary disconnection

electronicboy

[PaperMC/Waterfall] New comment on issue #387: disable\_entity\_metadata\_rewrite not working?

Looks like this one missed my eyes, basically, the setting works, but it seems to be pretty easy to break with some plugins, shamefully there is very little that I can do about this (without implementing 20 dozen ways for it to detect and avoid rewriting...), bungees design just really makes handling more invasive configurations a challenge around other plugins

electronicboy

[PaperMC/Waterfall] Issue closed: #387 disable\_entity\_metadata\_rewrite not working?

NLBlacky

[PaperMC/Waterfall] New comment on issue #387: disable\_entity\_metadata\_rewrite not working?

This work in progress server was connected to a test Waterfall instance on port 25566 while our main instance was on port 25565. It seems like multiple things including the meta rewriting didn't work as intended on servers connected to the second Waterfall instance. Option works fine on the main Waterfall server and I decided to move any test servers to the main Waterfall as well now.

[buoyant shore]

Govindass

[PaperMC/Waterfall] Issue opened: #417 290th update of waterfall broke a plugin

the 290th update of waterfall made ServerListMotdBungee plugin to stop changing motd, I thought I should report this, works perfectly on 289th

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #417: 290th update of waterfall broke a plugin

Please provide more information, like proxy log if you can see any errors.

[buoyant shore]

skybro6789

[PaperMC/Waterfall] Fork created: skybro6789/Waterfall

[buoyant shore]

moyugame

[PaperMC/Waterfall] Fork created: moyugame/Waterfall

[buoyant shore]

hzykj

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue closed: #417 290th update of waterfall broke a plugin

electronicboy

[PaperMC/Waterfall] New comment on issue #417: 290th update of waterfall broke a plugin

Waterfall made no changes that would impact motds, only internal code; if this impacted a plugin, they need to update to accommodate the changes

[buoyant shore]

ksgfk

[PaperMC/Waterfall] Issue opened: #418 If a player has a potion effect,he will be kicked from server

MC:1.12.2
Forge:14.23.5.2838
SpongeForge:1.12.2-2825-7.1.6

As long as the player gets the potion effect, he will be kicked out.

Waterfull show that bad packet ID, are mods in use!? Did not read all bytes from packet class net.md_5.bungee.protocol.packet.EntityEffect 79 Protocol GAME Direction TO_CLIENT

There are many potion effects in mods which I install in my server.Will this have any impact?

electronicboy

[PaperMC/Waterfall] New comment on issue #418: If a player has a potion effect,he will be kicked from server

You have a mod which is modifying the contents of the potions packet, waterfall cares about this in order to fix a race condition with forge, which makes this a fun one to solve; Would really need to know what these mods are doing to the packet in order to determine a proper fix

[buoyant shore]

ksgfk

[PaperMC/Waterfall] New comment on issue #418: If a player has a potion effect,he will be kicked from server

I think I found it.If I install Just Enought IDs,it will happen.After that,I remove that,waterfull work properly.

[buoyant shore]

alex450

[PaperMC/Waterfall] New comment on issue #418: If a player has a potion effect,he will be kicked from server

You have a mod which is modifying the contents of the potions packet, waterfall cares about this in order to fix a race condition with forge, which makes this a fun one to solve; Would really need to know what these mods are doing to the packet in order to determine a proper fix

I have the same problem and same error logs with slashblade and tinkersconstruct
slashblade : when the player is using a sa, he's kicked out
tinkersconstruct：when the player triggers some special effects of ce...

[buoyant shore]

colinrgodsey

[PaperMC/Waterfall] Pull request review submitted: #373 Speed up packet construction

this all LGTM. might end up pulling it into Waterdog if it doesnt end up getting merged here

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #408 Update TerminalConsoleAppender to 1\.2\.0

electronicboy

[PaperMC/Waterfall] Pull request closed: #408 Update TerminalConsoleAppender to 1\.2\.0

electronicboy

[Waterfall:master] 2 new commits

7993599 Update Log4j2 to 2.12.0 - Minecrell
3002132 Update TerminalConsoleAppender to 1.2.0, replac... - Minecrell

electronicboy

[PaperMC/Waterfall] New comment on pull request #408: Update TerminalConsoleAppender to 1\.2\.0

Sorry for the delay, Cheers!

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue opened: #419 ServerKickEvent discrepencies

Waterfall improved the ServerKickEvent to cover more cases, (#39), this is great because it lets plugins capture certain situations easier than vs bungee, however;

Specifically, the LOST_CONNECTION cause is generic and fired should the client disconnect from the client, leading to a specific edge case which plugins do not expect: The client has disconnected from the server

I guess this opens a question of what is the best way to go for this:

1. Move lost connection to its own event, ...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #373 Speed up packet construction

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #373 Speed up packet construction

electronicboy

[PaperMC/Waterfall] New review comment on pull request #373: Speed up packet construction

Removed the try/catch, this woulda incorrectly wrapped exceptions here

electronicboy

[PaperMC/Waterfall] Pull request closed: #373 Speed up packet construction

electronicboy

[Waterfall:master] 1 new commit

fa0711d Speed up packet construction (#373) - mikroskeem

electronicboy

[Waterfall:master] 1 new commit

0085381 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

69237a1 Updated Upstream (Waterfall) - electronicboy

electronicboy

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

java.lang.IllegalAccessError: class net.md_5.bungee.event.InternalReflectionFactory$1 (in unnamed module @0x32a068d1) cannot access class jdk.internal.reflect.ReflectionFactory (in module java.base) because module java.base does not export jdk.internal.reflect to unnamed module @0x32a068d1

electronicboy

[PaperMC/Waterfall] Pull request closed: #405 Explicitly construct array for dispatching events

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] Pull request review submitted: #373 Speed up packet construction

mikroskeem

[PaperMC/Waterfall] New review comment on pull request #373: Speed up packet construction

Whoops, overlooked that detail :eyes: but thanks

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #376: Messages

https://github.com/SpigotMC/BungeeCord/pull/2684

[buoyant shore]

Moderocky

[PaperMC/Waterfall] Fork created: Moderocky/Waterfall

[buoyant shore]

UnioDex

[PaperMC/Waterfall] Issue opened: #420 Random CPU Spikes and Timeout Kicks

Last couple weeks has been really rough for my server because players are randomly getting kicked. First I checked every Spigot instances but there was no issue. BungeeCord is getting unresponsive for ~10 seconds and then half of the players in the server getting kicked.

It happens almost every 5 to 15 minutes. So it's making the gameplay so painful and players stops playing the server.

I tried to profile it with YourKit. Here is a YourKit snapshot:
https://www.dropbox.com/s/sazf3tcuv...

[buoyant shore]

UnioDex

[PaperMC/Waterfall] New comment on issue #420: Random CPU Spikes and Timeout Kicks

One more snapshot:
https://www.dropbox.com/s/tot2etbmdwdoh2t/BungeeCord-2019-08-18(9).snapshot?dl=0

Check 1h48m.

[buoyant shore]

UnioDex

[PaperMC/Waterfall] New comment on issue #420: Random CPU Spikes and Timeout Kicks

Tried these:

• Remove ChangeSkin
• Remove PartyAndFriends
• Update ViaVersion to 2.1.3 in spigot servers.
• Downgrade Waterfall to build 276

None of these worked unfortunately.

[buoyant shore]

UnioDex

[PaperMC/Waterfall] New comment on issue #420: Random CPU Spikes and Timeout Kicks

These might be related: #403

[buoyant shore]

aello

[PaperMC/Waterfall] Fork created: aello/Waterfall

[buoyant shore]

Joshbts

[PaperMC/Waterfall] Issue opened: #421 Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

i get this message upon running Waterfall "main WARN Advanced terminal features are not available in this environment". The cmd window boots up fine and goes through all procedures and still says listening on x.x.x.x:25565, however i cannot connect to it no matter what i try to do

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #376: Messages

https://github.com/SpigotMC/BungeeCord/commit/9e76966e0fc46e4bdc61cfe97f14cd8b98290d8c
@electronicboy you can close this now and merge upstream

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #421: Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

I cannot reproduce this. Its your issue

Joshbts

[PaperMC/Waterfall] New comment on issue #421: Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

i even completely started a new server with a fresh download of waterfall, it has the same issue every time

[buoyant shore]

xxDark

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

java.lang.IllegalAccessError: class net.md_5.bungee.event.InternalReflectionFactory$1 (in unnamed module @0x32a068d1) cannot access class jdk.internal.reflect.ReflectionFactory (in module java.base) because module java.base does not export jdk.internal.reflect to unnamed module @0x32a068d1

You closed PR, and did not allow to fix this?
https://www.youtube.com/watch?v=h3uBr0CCm58

electronicboy

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

If you have a fix, you're more than welcome to open a new PR, we cannot use those internal classes however.

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

420f783 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

3fcb94c Updated Upstream (Waterfall) - electronicboy

electronicboy

[PaperMC/Waterfall] New comment on issue #421: Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

We need more information beyond "doesn't work", what exactly are you seeing when you try to connect?
if you have been tweaking internal OS stuff and broke something, there really ain't much we can do there, but some level of hopeful doubt that that is relevant

Joshbts

[PaperMC/Waterfall] New comment on issue #421: Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

Ill leave some screenshots, so the waterfall server boots up (first screenshot) and gives the message "2019-08-21 18:02:13,625 main WARN Advanced terminal features are not available in this environment". However after that, the server keeps with the startup procedure and says listening on 192.168.0.4:25565, meaning i could usually join the server.
. When i go to join the server ...

electronicboy

[PaperMC/Waterfall] New comment on issue #421: Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

"Connection timed out" is a generic network error and means that there was no response to the connection whatsoever

Configure the proxy to bind on 0.0.0.0 and connect on localhost, double check all IP addresses too, e.g. did your ISP change your IP

electronicboy

[PaperMC/Waterfall] Issue closed: #421 Was running fine, then i wasnt on PC for 2 days and now the server doesnt connect

[buoyant shore]

roombascj

[PaperMC/Waterfall] Fork created: roombascj/Waterfall

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

Is 99.99% also not Java 8 compatible
Java 9 compatibility for this would require a startup flag to import internal jdk modules

[buoyant shore]

MarkL4YG

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

You could try putting everything into the classpath instead of the module path. Reflection should work as expected then. At least thats what we see in Java 11.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

This PR breaks in several ways in java 9+, breaking compilation is a major one, and indicates that this is not compatible with 9+ as a whole; I'm not really interested in trying to hack around this, or require that users potentially have to start the jar differently

electronicboy

[PaperMC/Waterfall] Issue closed: #376 Messages

[buoyant shore]

MarkL4YG

[PaperMC/Waterfall] New comment on pull request #405: Explicitly construct array for dispatching events

Yes, I completely agree with that. I just wanted to say that this option is available for use when automated modules do not allow reflective access for example for older plugins that do not have a module information file.

[buoyant shore]

robot7boy

[PaperMC/Waterfall] Fork created: robot7boy/Waterfall

[buoyant shore]

jefedigital

[PaperMC/Waterfall] New star added

[buoyant shore]

jaqobb

[PaperMC/Waterfall] Fork created: jaqobb/Waterfall

[buoyant shore]

jaqobb

[PaperMC/Waterfall] Fork created: jaqobb/Waterfall

[buoyant shore]

jaqobb

[PaperMC/Waterfall] Pull request opened: #422 Make cmd\-server module messages more configurable

This is but a small change to the existing module (cmd-server) that would make a server list message more configurable. There are a lot of servers (including my own) that still use this module to provide an easy way to change servers. While the module itself is really small and fast, it wasn't offering a full way to change the server list message, until now. With this PR accepted people will be able to fully customize the message (including message after the end of the list and possibility to...

[buoyant shore]

HexedHero

[PaperMC/Waterfall] Pull request review submitted: #422 Make cmd\-server module messages more configurable

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on pull request #422: Make cmd\-server module messages more configurable

This would likely be approved by bungeecord itself.

[buoyant shore]

Harveyplays02

[PaperMC/Waterfall] Issue opened: #423 Tab completion changes \+ additions

Hi, I have a couple of changes and additions that I think would benefit server owners regarding tab-completion with waterfall.

• A similar setting to default Spigot's send-namespaced. This would disable any of the <plugin name>:<command> commands listed in tab completion, and only show the <command> part. This could be helpful if you want to hide the plugins you're using.
• A way to hide every player's name by typing nothing and pressing tab. Currently if you run plugins such as Bun...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #423: Tab completion changes \+ additions

These suggestions aren't applicable to the proxy;

1. Waterfall/bungee do not send namespaced commands, nor do I believe it's the proxies place to interfere with commands sent by the server itself

2. This is client sided, the completion itself is derived from the player info which is displayed in tab, only way for it to not be displayed would be for it to not have been sent to the client/removed from tab

3. This configuration option changes the response of the bukkit API to suggest pl...

electronicboy

[PaperMC/Waterfall] Issue closed: #423 Tab completion changes \+ additions

[buoyant shore]

jaqobb

[PaperMC/Waterfall] New comment on pull request #422: Make cmd\-server module messages more configurable

This would likely get approved by bungeecord itself.

I didn't think about that. I'm gonna close this PR for now and reopen it if BungeeCord doesn't accept a similar PR for some reason.

jaqobb

[PaperMC/Waterfall] Pull request closed: #422 Make cmd\-server module messages more configurable

[buoyant shore]

sathonay

[PaperMC/Travertine] Fork created: sathonay/Travertine

[buoyant shore]

xion87

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

any progress on this?

[buoyant shore]

Legendbender

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

It's fixed for me after new updates

xion87

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

i still see
[17:51:04] [Netty Worker IO Thread #60/ERROR]: [/79.45.96.127:53816|Killator] <-> DownstreamBridge <-> [hub-1] - encountered exception
java.lang.IllegalArgumentException: Team 718eb already exists in this scoreboard
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:191) ~[waterfall.jar:git:Waterfall-Bootstrap:1.14-SNAPSHOT:c3d67e5:290]
at net.md_5.bungee.api.score.Scoreboard.addTeam(Scoreboard.java:73) ~[waterfall.jar:git:Waterfall-Bootstrap:1.14-SNAP...

[buoyant shore]

AfkF24

[PaperMC/Waterfall] New star added

[buoyant shore]

andrewkm

[PaperMC/Waterfall] Issue opened: #424 Waterfall screws up console\.

Please, before I lose my mind.
Tests were done on windows machine.

Bungee is correct:

Type in "testing123":
https://i.imgur.com/EISLX56.png
And begin pinging server:
Correctly moves down: https://i.imgur.com/1uOFBCM.png

Meanwhile on waterfall:

Type in "testing123":
https://i.imgur.com/Atjn3Uv.png
And begin pinging server:
https://i.imgur.com/VdpFKta.png

[buoyant shore]

jaqobb

[PaperMC/Waterfall] Fork created: jaqobb/Waterfall

[buoyant shore]

Hex6000

[PaperMC/Waterfall] New star added

electronicboy

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

We use the same setup as paper, are you having any issues there?

[buoyant shore]

xRealNeon

[PaperMC/Waterfall] New star added

[buoyant shore]

andrewkm

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

What?

andrewkm

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

Paper consoles work correctly.

[buoyant shore]

electricman226

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

Believe this is simply a Windows issue. I've seen it many times when using a Window's console. Why it's different between Bungee and Waterfall, I have no idea.

[buoyant shore]

andrewkm

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

Bungee, Spigot, and Paper all work fine.
It’s the recent Waterfall commit that broke it.

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

log4j 2.12.0 or terminalconsoleappender or jline is broken on Windows 10.

[buoyant shore]

SeocraftNetwork

[PaperMC/Waterfall] Fork created: SeocraftNetwork/Waterfall

[buoyant shore]

Justsnoopy30

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

Can confirm, I'm on windows 10 and this started happening after updating to the latest waterfall build.

[buoyant shore]

wardpoel

[PaperMC/Waterfall] Fork created: wardpoel/Waterfall

TTMDragon

[PaperMC/Waterfall] Fork created: TTMDragon/Waterfall

TTMDragon

[PaperMC/Waterfall] New star added

[buoyant shore]

Justsnoopy30

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

Although my problem is mostly there being no colors and it says this on startup:

2019-09-12 07:40:53,311 main WARN Advanced terminal features are not available in this environment

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] Fork created: MrIvanPlays/Waterfall

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] Pull request opened: #425 Add gplugins command

[buoyant shore]

GamingCrafthd

[PaperMC/Waterfall] New star added

GamingCrafthd

[PaperMC/Waterfall] Fork created: GamingCrafthd/Waterfall

[buoyant shore]

MClausz

[PaperMC/Waterfall] New comment on commit `3002132`

this terminal sucks on Windows

[buoyant shore]

samtaber

[PaperMC/Travertine] Issue opened: #113 BungeeAdminTools compatibility issues

Travertine's build number is less that 878, which BAT requires to run. Is there any way I could modify the build number? I tried modifying the BAT code (since its open source) but its throwing errors since the code doesn't work for some reason.

samtaber

[PaperMC/Travertine] New star added

[buoyant shore]

astei

[PaperMC/Travertine] New comment on issue #113: BungeeAdminTools compatibility issues

The version check is broken because it assumes nobody would ever do something crazy like modify BungeeCord.

For the record, build 878 of BungeeCord is over 5 years old and few people are using such an ancient version of BungeeCord these days.

[buoyant shore]

FirestarterMC

[PaperMC/Waterfall] Fork created: FirestarterMC/Waterfall

[buoyant shore]

sgdc3

[PaperMC/Waterfall] New comment on pull request #425: Add gplugins command

Nice, but i think modules are being deprecated...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on pull request #425: Add gplugins command

I do not believe that it's in the interest of the project to accept PRs from members who have been removed from the community

electronicboy

[PaperMC/Waterfall] Pull request closed: #425 Add gplugins command

[buoyant shore]

dieterblancke

[PaperMC/Waterfall] Fork created: dieterblancke/Waterfall

[buoyant shore]

AdversTM

[PaperMC/Waterfall] New star added

[buoyant shore]

Voyaris

[PaperMC/Waterfall] Fork created: Voyaris/Waterfall

[buoyant shore]

rrye

[PaperMC/Waterfall] New star added

[buoyant shore]

amerioalessio04

[PaperMC/Travertine] Fork created: amerioalessio04/Travertine

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

2b3b0ec Ignore empty packets - electronicboy

[buoyant shore]

p4skal

[PaperMC/Waterfall] Issue opened: #426 Var Int Problem

Our Waterfall recently had problems decoding var ints. It was possible that an attacker could send bytes all matching 0x80 bitmask. The cosequence is that it costs really much cpu time.

Old Code: `public static int readVarIntOLD(final ByteBuf input, final int maxBytes) {
int out = 0;
int bytes = 0;
byte in;
do {
in = input.readByte();
out |= (in & 0x7F) << bytes++ * 7;
if (bytes > maxBytes) {
throw new RuntimeExcep...

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #426: Var Int Problem

1. What are you trying to say exactly?
2. Code blocks are hardly understandable because of formatting issues... besides, New code one is equal to the one in current DefinedPacket class?

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #426: Var Int Problem

old and new code are likely nearly equally translated to bytecode, logic seems identical too
@p4skal

[buoyant shore]

electronicboy

[Waterfall:illegal\-packets] 1 new commit

ebbf094 Start IllegalPacketEvent - electronicboy

electronicboy

[PaperMC/Waterfall] New branch created: illegal\-packets

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #426: Var Int Problem

DefinedPacket.readVarInt(<netty ByteBuf>)

Done

[buoyant shore]

Fl3xstar

[PaperMC/Waterfall] Fork created: Fl3xstar/Waterfall

[buoyant shore]

YukiLeafX

[PaperMC/Waterfall] New star added

[buoyant shore]

DaMatrix

[PaperMC/Waterfall] New star added

[buoyant shore]

EnScrypts

[PaperMC/Waterfall] Fork created: EnScrypts/Waterfall

[buoyant shore]

BrainStone

[PaperMC/Waterfall] New star added

[buoyant shore]

Drc-DEV

[PaperMC/Waterfall] New comment on issue #420: Random CPU Spikes and Timeout Kicks

Was this solved? If so, how did you fix the problem?

If the problem is still present, can you tell us if you have the same problem with BungeeCord or just with Waterfall?

UnioDex

[PaperMC/Waterfall] New comment on issue #420: Random CPU Spikes and Timeout Kicks

Problem solved after I switched CentOS from Ubuntu. Problem was also exist in BungeeCord. Even with Velocity. So I don't think it's related with proxy servers now. Forgot to close the issue. Thanks for reminder.

UnioDex

[PaperMC/Waterfall] Issue closed: #420 Random CPU Spikes and Timeout Kicks

[buoyant shore]

123Kappa

[PaperMC/Waterfall] Issue opened: #427 Mass player kicks\.

Hello, i have a network tha averages 200-260 players sometimes waterfall kicks around half the players off the network. (kicks like 20% from each server). This has started happening since we added more servers to the network and we got more players.

At first I thought it was due to the CPU's load. So i bought a new dedi and i moved my bungeecord there. Issue wasnt fixed, then i thought it was ram, from 4gb i changed it to 2gbs because i thought that it may have been too much. Then i chang...

electronicboy

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

Connection reset by peer - Something external to the proxy closed the connection, this is not something we can do anything with; General advice is to check the client/server logs, something likely caused the connection to close improperly

electronicboy

[PaperMC/Waterfall] Issue closed: #427 Mass player kicks\.

123Kappa

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

Across all servers at the same time?

123Kappa

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

And i said some of them had the error 90% of them just have "disconnected". I want to send you the logs but they include IPs.

electronicboy

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

connection reset by peer specifically means that the remote (or something upstream from us) reset the connection, proxy logs are irrelevant here as they'll just be saying that something on the network closed the connection

123Kappa

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

I can message on your discord, I want you to see the logs, I need assistance from someone who really understands bungee.

I can pay you for your time.

[buoyant shore]

123Kappa

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

Ok i guess not, i have another question though, if it's a ram or cpu issue would i get an error?

[buoyant shore]

123Kappa

[PaperMC/Waterfall] New comment on issue #427: Mass player kicks\.

How do i locate what's causing this issue?

[buoyant shore]

Prasodym

[PaperMC/Waterfall] New comment on issue #340: Weird connection issue with Sponge

I also have the problem with a M.2 SSD, 32GB DDR 4 Ram, I7 8700k CPU and constant 100k line. The normal?

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #340: Weird connection issue with Sponge

OS?
iptables / firewall?
(ddos protection?)

[buoyant shore]

huangsijun17

[PaperMC/Waterfall] Issue opened: #428 Repeatedly dropped or TAB cannot be used

if disable_entity_metadata_rewrite in waterfall.yml set true , then my Tap plugins doesn't work.
if disable_entity_metadata_rewrite in waterfall.yml set fales , then Some of my servers will be unconnected from time to time.
encountered exception java.lang.IllegalArgumentException: Unknown meta type 14: Using mods? refer to disable_entity_metadata_rewrite in waterfall.yml

Both SkyFactory4 with Mohist and EnigTech with Catserver.

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #428: Repeatedly dropped or TAB cannot be used

What do you mean with "Tap" plugins?

huangsijun17

[PaperMC/Waterfall] New comment on issue #428: Repeatedly dropped or TAB cannot be used

What do you mean with "Tap" plugins?
Tab?

That sounds weird to me.

BungeeTabListPlus

tab...

[buoyant shore]

huangsijun17

[PaperMC/Waterfall] New comment on issue #428: Repeatedly dropped or TAB cannot be used

The players should be inside Server EnigTech but now in the upper left corner.

[buoyant shore]

MorkaZ

[PaperMC/Waterfall] New star added

[buoyant shore]

p4skal

[PaperMC/Waterfall] New comment on issue #426: Var Int Problem

Sorry for the late response, i was on vacation.

@Janmm14 Your completly right, even from the logic perspective it's identical.

We had profiled our waterfall fork and found out, that there was much time spent in the readVarInt method. So I looked online for a solution and found this code.I seem to just have copy & pasted it, created an issue without analysing it properly. I just wanted to fix it before vacation.
The "old code" is actually from our fork, so it has nothing to do with th...

p4skal

[PaperMC/Waterfall] Issue closed: #426 Var Int Problem

[buoyant shore]

ANDERSON131A

[PaperMC/Waterfall] New star added

[buoyant shore]

PiiSaba

[PaperMC/Travertine] Issue opened: #114 Error decoding packet unknown with contents

[23:36:18 ERROR]: [/192.168.2.1:50013|YouTube0099] <-> DownstreamBridge <-> [Hub-1] - encountered exception
io.netty.handler.codec.DecoderException: Error decoding packet unknown with contents:

at net.md_5.bungee.protocol.MinecraftDecoder.decode(MinecraftDecoder.java:69) ~[Travertine.jar:git:Travertine-Bootstrap:1.13-SNAPSHOT:56099f3:67]
at net.md_5.bungee.protocol.MinecraftDecoder.decode(MinecraftDecoder.java:13) ~[Travertine.jar:git:Travertine-Bootstrap:1.13-SNAPSHOT:56099f3:67]
at...

PiiSaba

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

How can I fix this error?

electronicboy

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

Update

electronicboy

[PaperMC/Travertine] Issue closed: #114 Error decoding packet unknown with contents

[buoyant shore]

Adam3055

[PaperMC/Travertine] Issue opened: #115 Bungee\.Protocol\.EntityEffect \- Sevtech disconnect

Hi there, we recently setup a Sevtech server and when you go to fly around on the server you will randomly get disconnected and kicked, nothing comes up in the Sevtech console other than user disconnected, but in travertine console it seems to throw an error?

"|Keaton_wizard] <-> DownstreamBridge <-> [Sevtech] - bad packet ID, are mods in use!? Did not read all bytes from p...

[buoyant shore]

PiiSaba

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

I updated but console shows a error then the player got kicked.
Error message: <-> DownstreamBridge <-> [Hub-1] - bad packet ID, are mods in use!? Empty minecraft packet!

I can understand what the message said. But I don't know how to fix it.
Is there a way to fix it or avoid not to get kicked?

[buoyant shore]

mikroskeem

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

See waterfall.yml

electronicboy

[Travertine:master] 1 new commit

9976356 Updated Upstream (Waterfall) - electronicboy

electronicboy

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

Looks like travertine was behind waterfall a build, the configuration option has been removed in favor of making that the standard behavior

[buoyant shore]

TebosBrime

[PaperMC/Waterfall] Fork created: TebosBrime/Waterfall

[buoyant shore]

PiiSaba

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

hmm
My main server is 1.8.8 spigot.
I am making a custom nick plugin so I made a sign gui like hypixel for getting user input for custom nickname.
I found this: https://www.spigotmc.org/threads/sign-gui-for-user-input.104394/page-2#post-1162152
and I used the API.

//
for(WrappedChatComponent chat : packet.getLines()) {
Bukkit.getConsoleSender().sendMessage(StringEscapeUtils.unescapeJavaScript(chat.getJson()));
}
\
About this section, If I send a messages, players got ki...

[buoyant shore]

astei

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

Update Travertine

[buoyant shore]

LogoiLab

[PaperMC/Waterfall] New star added

[buoyant shore]

PiiSaba

[PaperMC/Travertine] New comment on issue #114: Error decoding packet unknown with contents

Thanks for fixing the issue! <3

[buoyant shore]

DopeDealers

[PaperMC/Travertine] Fork created: DopeDealers/Travertine

[buoyant shore]

Web-44

[PaperMC/Waterfall] Fork created: Web-44/Waterfall

[buoyant shore]

Kapakulia

[PaperMC/Waterfall] Fork created: Kapakulia/Waterfall

[buoyant shore]

Drc-DEV

[PaperMC/Waterfall] Issue opened: #429 Jessica Client crashes bungee

Latest jessica client's feature ".figure" crashes bungeecord quite fast (no errors, it just restarts), if there are at least 2 players online.
That feature sends item packets containing shulkerboxes that have books with oversized pages (too long and too many) inside. Seems like a workaround on the now already fixed oversized book exploit.

I think this should be prevented directly on waterfall, because only bungeecord crashes, while the spigot server is fine.

I was able to block this o...

Drc-DEV

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

I'm on windows 10 and I do not experience this problem. I use cygwin and I suppose you should use that too.

[buoyant shore]

ceandream

[PaperMC/Waterfall] Fork created: ceandream/Waterfall

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

Why can't e.g plugin deal with this instead?

[buoyant shore]

Leymooo

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

You can try my plugin https://slava.funtime.su/plugins/FiguresFix/ (ProtocolLib Required). Not sure if it will work for 1.13 and upper, but i hope it will.

Also it looks like that your system runs out of memory and system kill your Bungee/Waterfall process to get some free memory.

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

cygwin is nothing anyone should have to use to run a java program

[buoyant shore]

camdenorrb

[PaperMC/Travertine] Issue opened: #116 Titles don't show up on 1\.8

This code works perfectly fine, it just only shows up on players using 1.12+ clients

Only tested [1.8, 1.12, 1.14.4]

camdenorrb

[PaperMC/Travertine] New comment on issue #116: Titles don't show up on 1\.8

Just realized that travertine only supports 1.7, closing lol...

camdenorrb

[PaperMC/Travertine] Issue closed: #116 Titles don't show up on 1\.8

[buoyant shore]

mikroskeem

[PaperMC/Travertine] New comment on issue #116: Titles don't show up on 1\.8

Wrong, Travertine supports 1.7.x - 1.14.x

[buoyant shore]

electronicboy

[PaperMC/Travertine] New comment on issue #116: Titles don't show up on 1\.8

Would more be https://github.com/PaperMC/Waterfall, would also be interesting to know if this occurs on bungee too

[buoyant shore]

camdenorrb

[PaperMC/Travertine] New comment on issue #116: Titles don't show up on 1\.8

It appears setting fadeIn, stay and fadeOut fixed this. It might also be good to note that it seemed to break randomly.

[buoyant shore]

twieteddy

[PaperMC/Waterfall] New star added

[buoyant shore]

Drc-DEV

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

cygwin is nothing anyone should have to use to run a java program

I thought he was using win10 to remotely connect to a linux server, nevermind

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

cbb038f Bring back jansi workaround for windows - electronicboy

electronicboy

[Travertine:master] 1 new commit

b224807 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

brunoxkk0

[PaperMC/Travertine] Fork created: brunoxkk0/Travertine

[buoyant shore]

JHarris12345

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

This issue is ongoing. Please fix

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

Workaround already presented in here.

JHarris12345

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

I dont understand the scoreboard fix or how I got about fixing it. I dont use default scoreboard

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

you need your plugins to use different scoreboard names

[buoyant shore]

pavelfesenko

[PaperMC/Waterfall] New star added

[buoyant shore]

DominatorRUS

[PaperMC/Waterfall] Fork created: DominatorRUS/Waterfall

[buoyant shore]

JHarris12345

[PaperMC/Waterfall] Issue opened: #430 Issues with scoreboard \(help\)

I get this error quite a bit which has crashed my server. I am not sure what the fix is, I am VERY new to console errors like this https://pastebin.com/BvDCGpdu

JHarris12345

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

How do I do this @Janmm14. Also which plugins?

electronicboy

[PaperMC/Waterfall] New comment on issue #430: Issues with scoreboard \(help\)

Duplicate of #318
Only "fix" is to ensure that servers will have unique team names (Plugins will need to consider bungee setups properly, basically), this is basically a bungeecord issue

electronicboy

[PaperMC/Waterfall] Issue closed: #430 Issues with scoreboard \(help\)

electronicboy

[PaperMC/Waterfall] New comment on issue #318: People are being disconnected

whichever plugin is creating the team that is conflicting on the other server, if you copied worlds over and aren't using plugins, potentially wanna consider delating the scoreboard.dat for the servers involved;

The only current fix is for bukkit plugins to take steps to prevent team name collisions across servers, this is an upstream issue

JHarris12345

[PaperMC/Waterfall] New comment on issue #430: Issues with scoreboard \(help\)

@electronicboy Can you give a bit more of a dummed down version to a newbie please. How do I ensure servers have unique team names? Also how do I make sure plugins consider bungee setups properly?

electronicboy

[PaperMC/Waterfall] New comment on issue #430: Issues with scoreboard \(help\)

You would need to speak to the plugin authors of whatever is using scoreboards on your servers to prevent these collisions, there is no real easy fix here, plugins basically need to take steps to avoid this

JHarris12345

[PaperMC/Waterfall] New comment on issue #430: Issues with scoreboard \(help\)

How do I know what plugins use scoreboards? Also so there is nothing I can do to fix this? I can only rely on devs?

[buoyant shore]

Mystiflow

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

One approach to fixing this is intercepting the Send Scoreboard packet, comparing the scoreboard names and if they match; just mutate the new name by 1 character or so (pretty sure a different name doesn't affect game mechanics) and then cancelling the original packet and sending the new one.

Any teams and objectives should then bind to the new scoreboard in theory.

[buoyant shore]

Jecvay

[PaperMC/Waterfall] Issue opened: #431 compatibility issue of \[emoticons\]\[mclib\]

spongeforge 1.12.2 7.1.7
waterall-295

[issue mod]
https://www.curseforge.com/minecraft/mc-mods/emoticons
https://www.curseforge.com/minecraft/mc-mods/mchorses-mclib

[issue]
in my server, players can see each other's emoticon without waterfall.
but cannot see after install waterfall in front of spongeforge.
without any error log.

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

Please provide your Waterfall configuration (waterfall.yml) and the list of installed plugins (to rule out other issues). Do you also have IP/profile forwarding enabled (ip_forward in config.yml)?

JHarris12345

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

Hmm I use featherboard and TAB. Not sure how to go about fixing

[buoyant shore]

JHarris12345

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

@electronicboy How do I prevent plugins from creating the same team names on my different servers?

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

Once again, you would need to speak to plug-in authors to try to mitigate
this;

On Sun, 3 Nov 2019, 16:31 JHarris12345, [e-mail] wrote:

@electronicboy https://github.com/electronicboy How do I prevent
plugins from creating the same team names on my different servers?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/PaperMC/Waterfall/issues/318?email_source=notifications&email_token=AA...

electronicboy

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

If this is your suggested fix for the proxy, it would require additional
overheads to remap teams, would also create some potential oddball handling
if bungee plugins come into play

The ultimate fix is going to be to figure how to handle the server switch
better, my current thought is to just queue scoreboard packets and flush
them through, it is it's own set of headaches and mess, but the only other
alternative is to leave this solely on server/plug-in devs

On Sun, 3 Nov 2019, 08:05 Mystif...

electronicboy

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

Try disabling entity metadata rewriting in waterfall.yml

On Sun, 3 Nov 2019, 13:30 Mark Vainomaa, [e-mail] wrote:

Please provide your Waterfall configuration (waterfall.yml) and the list
of installed plugins (to rule out other issues). Do you also have
IP/profile forwarding enabled (ip_forward in config.yml)?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/PaperMC/Waterf...

[buoyant shore]

Jecvay

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

Try disabling entity metadata rewriting in waterfall.yml

thanks. i tried but didn't solve.

Please provide your Waterfall configuration (waterfall.yml) and the list of installed plugins

use_netty_dns_resolver: true
disable_modern_tab_limiter: true
log_initial_handler_connections: true
throttling:
  tab_complete: 1000
game_version: ''
disable_entity_metadata_rewrite: true

connection_throttle_limit: 3
online_mode: false
log_commands: false
network_compres...

mikroskeem

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

As this mod seems to be closed source, then try to contact with the mod creator about this issue.

On 3. Nov 2019, at 23:12, Jecvay Liu [e-mail] wrote:

Try disabling entity metadata rewriting in waterfall.yml

thanks. i tried but didn't solve.

Please provide your Waterfall configuration (waterfall.yml) and the list of installed plugins

use_netty_dns_resolver: true
disable_modern_tab_limiter: true
log_initial_handler_connections: true
throttling:
...

[buoyant shore]

Mystiflow

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

@electronicboy would intercepting the inbound Scoreboard Send work? Compare the previous scoreboard name with the latter and if they match; mutate the name by a character or so and send that packet instead? If I'm correct team/scoreboard packets don't require a scoreboard name they just latch on to the clients current scoreboard and if the client thinks it has a new scoreboard now; the team in theory won't pre exist? Would obviously need to confirm it wasn't the same server sending the Send S...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

The client only has a singular scoreboard, teams are shared across all instances; This issue is also not down to the client, this is pretty much 100% a flaw in bungees server connection process; The new target server sends it’s scoreboard data before the proxy has cleaned up the scoreboard on the client, rewriting team names just adds additional complexity, bloat and overheads in the proxy

On 5 Nov 2019, at 11:34, Mystiflow [e-mail] wrote:

@electronicboy <https://git...

[buoyant shore]

Mystiflow

[PaperMC/Waterfall] New comment on issue #318: Proxy does not handle duplicate scoreboard teams across connections

I haven't looked into the client code but what purpose then does the name string serve in the Scoreboard Send packet?

queue scoreboard packets and flush
them through

Do you mean storing each server sent scoreboard packet in a list and then sending the destroy packet for them on server switch?

[buoyant shore]

mchorse

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

I described the process of how the syncing and handshake works over here.

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

So you're simply using plugin message channels?

[buoyant shore]

mchorse

[PaperMC/Waterfall] New comment on issue #431: compatibility issue of \[emoticons\]\[mclib\]

No, I believe the issue here is that my code doesn't get setup properly. I wrote a system that allows for Emoticons to be used when players don't have a mod, so capabilities on the server store whether player have the mod. That code decides whether player has the mod.

It checks whether Emoticons channel gets registered, and if it does, then it can sync the emotes.

[buoyant shore]

langyo

[PaperMC/Waterfall] New star added

[buoyant shore]

LudwigHornslied

[PaperMC/Travertine] Fork created: LudwigHornslied/Travertine

[buoyant shore]

Arvoreen

[PaperMC/Waterfall] Fork created: Arvoreen/Waterfall

[buoyant shore]

KillerJWB86

[PaperMC/Waterfall] New comment on issue #428: Repeatedly dropped or TAB cannot be used

I have the same problem on my server.

[buoyant shore]

onokatio

[PaperMC/Waterfall] New star added

[buoyant shore]

vojtamares

[PaperMC/Waterfall] New star added

[buoyant shore]

Sprite233

[PaperMC/Waterfall] Fork created: Sprite233/Waterfall

[buoyant shore]

SuperLandNetwork

[PaperMC/Waterfall] Fork created: SuperLandNetwork/Waterfall

[buoyant shore]

yooniks

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

CasualProtector will help you, just type it on spigotmc or on google.

[buoyant shore]

lukasl-dev

[PaperMC/Waterfall] Fork created: lukasl-dev/Waterfall

[buoyant shore]

Drc-DEV

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

Another exploit "nullping" adds to the many that can crash bungee, and there's little to no effort on their part to fix these upstream instead of having to deal with them with some obscure plugin or fork.

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

We have no clear overview about those exploits. Personally I don't want to run or download cheat clients on my personal computer (nor do I have decent sandboxing around) to get the grasp what those exploits actually do - I am not fond of running untrusted code near my personal data what I can get from even less trusted webpages.

If someone wants to help then sure, PaperMC IRC and Discord guild are there for a reason. Provide enough information and someone of us will look into it.

[buoyant shore]

kmzs123

[PaperMC/Waterfall] New star added

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

Another exploit "nullping" adds to the many that can crash bungee, and there's little to no effort on their part to fix these upstream instead of having to deal with them with some obscure plugin or fork.

There is little to no effort to do proper bug reports upstream apparantly.

Create an issue on bungeecord repository, provide the cheat client, say the command which crashes your bungee and I'm sure someone (maybe me) would decompile the client then and provide details on ...

electronicboy

[PaperMC/Waterfall] New comment on issue #429: Jessica Client crashes bungee

I've yet to see this in a capacity to crash the proxy outside of just
making it flood exceptions, in part, this is somewhat unfixable given the
nature of a server softwares goal, the fix is Ultimately going to be to try
to optimize how errors are basically handled in the proxy to make them
being thrown less of a performance hit

On Wed, 20 Nov 2019, 17:26 Janmm14, [e-mail] wrote:

Another exploit "nullping" adds to the many that can crash bungee, and
there's little to no...

[buoyant shore]

sdfaken

[PaperMC/Waterfall] Fork created: sdfaken/Waterfall

[buoyant shore]

huangsijun17

[PaperMC/Waterfall] New comment on issue #428: Repeatedly dropped or TAB cannot be used

我的服务器上也有同样的问题，只有在更换服务器后才会发生，开始时在大厅看起来还不错。
https://cdn.discordapp.com/attachments/641968803508518913/644205135756656701/unknown.png

I am the same.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #428: Repeatedly dropped or TAB cannot be used

You must disable entity metadata rewriting (There is no way to work around this without modifying the proxy to be able to work directly with your mods entity metadata somehow), tab plugins breaking is a side-effect that needs to be looked into when I'm not ill

[buoyant shore]

viet

[PaperMC/Waterfall] New star added

sathonay

[PaperMC/Travertine] Fork created: sathonay/Travertine

[buoyant shore]

electronicboy

[Waterfall] Branch illegal\-packets was force-pushed to `0c2b05b`

Compare changes

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

e94c0b9 Cache session exception - electronicboy

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] Pull request opened: #432 Ensure that exit code is not swallowed on failure

Currently fixes build & patches applying subcommands.

[buoyant shore]

Acenox

[PaperMC/Travertine] Fork created: Acenox/Travertine

[buoyant shore]

Stankye

[PaperMC/Travertine] New star added

[buoyant shore]

Matocolotoe

[PaperMC/Travertine] New star added

[buoyant shore]

electronicboy

[Waterfall] Branch illegal\-packets was force-pushed to `b9916a6`

Compare changes

[buoyant shore]

Tym17

[PaperMC/Waterfall] New star added

[buoyant shore]

apachezy

[PaperMC/Waterfall] Fork created: apachezy/Waterfall

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

ea158c3 Further robustness of entity metadata rewrite s... - electronicboy

[buoyant shore]

electronicboy

[Waterfall:feature/ConnectionInitEvent] 2 new commits

47f9491 Cleanup imports from last commit - electronicboy
d78ff20 ConnectionInitEvent - electronicboy

electronicboy

[PaperMC/Waterfall] New branch created: feature/ConnectionInitEvent

[buoyant shore]

electronicboy

[Waterfall:master] 2 new commits

47f9491 Cleanup imports from last commit - electronicboy
b4bdcf3 Add callEvent shortcut to Event - mikroskeem

electronicboy

[Waterfall] Branch feature/ConnectionInitEvent was force-pushed to `26457e4`

Compare changes

[buoyant shore]

Kaama21

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[Travertine:master] 1 new commit

b11282d Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

Aides123

[PaperMC/Waterfall] Issue opened: #433 Error decoding packet

My server throws out all players and the console is full of it
https://pastebin.com/eMuKSdT3

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #433: Error decoding packet

I suggest increasing connection_throttle in config to 20000 and maybe lowering connection_throttle_limit from 3 to 2

[buoyant shore]

Maskia

[PaperMC/Waterfall] New star added

[buoyant shore]

electron93

[PaperMC/Waterfall] New star added

[buoyant shore]

123Kappa

[PaperMC/Waterfall] Issue opened: #434 java\.lang\.IllegalArgumentException: Unknown meta type 18 error in console

Server randomly kicks people, here's the error in waterfall's console: https://pastebin.com/urAppz9W

I heard that enabling "disable_entity_metadata_rewrite" fixes this.
Is it safe to disable that? I run more moded servers.
What does it do exatcly and why it's important.

electronicboy

[PaperMC/Waterfall] New comment on issue #434: java\.lang\.IllegalArgumentException: Unknown meta type 18 error in console

That setting disables the entity metadata rewriting in favor of sending a join packet to the client, basically; It offers a more robust solution for modded environments due to the fact that it doesn't rely on a mechanism that required being able to parse entity metadata, which the proxy needs to be able to understand (but can't)

electronicboy

[PaperMC/Waterfall] Issue closed: #434 java\.lang\.IllegalArgumentException: Unknown meta type 18 error in console

123Kappa

[PaperMC/Waterfall] New comment on issue #434: java\.lang\.IllegalArgumentException: Unknown meta type 18 error in console

Thank you for the quick response!
Do you recommend disabling that? Can it cause issues?

Also how do I find what mod causes this issue?

electronicboy

[PaperMC/Waterfall] New comment on issue #434: java\.lang\.IllegalArgumentException: Unknown meta type 18 error in console

it serves to offer a much cleaner server switch to clients, but; There might be some plugin breakages due to them not expecting the changes involved

You would need to see if there is a way to get forge to dump the entity metadata registry or something, outside of tryna dissect your mods

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

337ca7f Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

47e2f8d Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

EmptyEnd6893

[PaperMC/Waterfall] New star added

[buoyant shore]

johncsuti

[PaperMC/Waterfall] Issue opened: #435 Plugins that use MySQL take a while to load and some fail loading out right

Title says it all i have a link to the full startup log so you can see luck perms complain about it as well as lite bans both of them use MySQL for database storage.

https://pastebin.com/GuLLYwd6

johncsuti

[PaperMC/Waterfall] New comment on issue #435: Plugins that use MySQL take a while to load and some fail loading out right

since they are the only two plugins i use MySQL with it could be just them or it could be others i don't know and according to luck perms they think its an issue with waterfall since its both plugins and i agree with them.

electronicboy

[PaperMC/Waterfall] New comment on issue #435: Plugins that use MySQL take a while to load and some fail loading out right

Nothing to do with waterfall, waterfall only provides the mysql driver

A quick mysql -h<host> shows that the mysql server isn't accepting connections and is just timing them out, this is likely a misconfiguration with your network setup

electronicboy

[PaperMC/Waterfall] Issue closed: #435 Plugins that use MySQL take a while to load and some fail loading out right

[buoyant shore]

andrewkm

[PaperMC/Waterfall] Issue closed: #424 Waterfall screws up console\.

andrewkm

[PaperMC/Waterfall] New comment on issue #424: Waterfall screws up console\.

Fixed.

[buoyant shore]

SubTheSandwich

[PaperMC/Travertine] Issue opened: #117 Players kicked when a 1\.7x and 1\.8x client both connect\.

So, I've had this issue with many other forks of Bungee and with BungeeCord itself. I just want to know why 1.7.10 players are kicked when 1.8 players connect to the server.

Logs:

[21:27:16] [Netty Worker IO Thread #0/INFO]: [/104.174.5.181:53259] InitialHandler is pinging
[21:27:16] [Netty Worker IO Thread #1/INFO]: [/104.174.5.181:53260] InitialHandler has connected
[21:27:17] [Netty Worker IO Thread #1/INFO]: [SubTheSandwichV2|/104.174.5.181:53260] ServerConnector [lobby] has co...

[buoyant shore]

iLemon

[PaperMC/Travertine] New star added

iLemon

[PaperMC/Travertine] New star added

electronicboy

[PaperMC/Travertine] New comment on issue #117: Players kicked when a 1\.7x and 1\.8x client both connect\.

The kick is from the server and is down to it mishandling some part of the login, nothing we can do about this, nor is protocol hackery supported

electronicboy

[PaperMC/Travertine] Issue closed: #117 Players kicked when a 1\.7x and 1\.8x client both connect\.

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] Pull request opened: #436 Add missing ViewDistance packet supplier

[buoyant shore]

electronicboy

[Travertine:unsupported] 1 new commit

ac8e757 Early 1.15 protocol support - electronicboy

electronicboy

[PaperMC/Travertine] New branch created: unsupported

[buoyant shore]

electronicboy

[Travertine] Branch unsupported was force-pushed to `8202aad`

Compare changes

[buoyant shore]

mikroskeem

[PaperMC/Travertine] New comment on commit `ac8e757`

oh no

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #436 Add missing ViewDistance packet supplier

electronicboy

[PaperMC/Waterfall] Pull request closed: #436 Add missing ViewDistance packet supplier

electronicboy

[Waterfall:master] 1 new commit

f708bf1 Add missing ViewDistance packet supplier (#436) - mikroskeem

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

3426625 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Waterfall:master] 1 new commit

6f85738 Rebuild patches - electronicboy

electronicboy

[Travertine:master] 2 new commits

d862626 Update gitignore - electronicboy
6e8f551 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

verboEse

[PaperMC/Waterfall] Fork created: verboEse/Waterfall

[buoyant shore]

digitalbocca

[PaperMC/Waterfall] New star added

[buoyant shore]

SleepingTea98

[PaperMC/Travertine] Fork created: SleepingTea98/Travertine

[buoyant shore]

xxDark

[PaperMC/Waterfall] Fork created: xxDark/Waterfall

[buoyant shore]

SimplyCodin

[PaperMC/Travertine] New star added

[buoyant shore]

2LSpigot

[PaperMC/Travertine] Fork created: 2LSpigot/Travertine

[buoyant shore]

Govindass

[PaperMC/Waterfall] Fork created: Govindass/Waterfall

electronicboy

[Waterfall:master] 1 new commit

82e1da5 ConnectionInitEvent - electronicboy

electronicboy

[PaperMC/Waterfall] branch deleted: feature/ConnectionInitEvent

electronicboy

[PaperMC/Waterfall] branch deleted: readme

[buoyant shore]

meerpaluten

[PaperMC/Waterfall] Issue opened: #437 Cracked Fix by online

If the Server is in onlinemode, and a player joined who is cracked. Then not trigger the ProLoginEvent. Pls patch it. Not Trigger!

electronicboy

[PaperMC/Waterfall] New comment on issue #437: Cracked Fix by online

Wut

On Mon, 16 Dec 2019, 17:16 meerpaluten, [e-mail] wrote:

If the Server is in onlinemode, and a player joined who is cracked. Then
not trigger the ProLoginEvent. Pls patch it. Not Trigger!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/PaperMC/Waterfall/issues/437?email_source=notifications&email_token=AAJMAZH4N2MQRNG6KDOXXKTQY6ZWLA5CNFSM4J3NG5E2YY3PNVWWK3TUL52HS4DFUVEX...

mikroskeem

[PaperMC/Waterfall] New comment on issue #437: Cracked Fix by online

There is no such event as ProLoginEvent, but there is PreLoginEvent.

Either way, PreLoginEvent should fire regardless of the online mode option.

So perhaps you forgot to register the listener?

[buoyant shore]

meerpaluten

[PaperMC/Waterfall] New comment on issue #437: Cracked Fix by online

how can I make sure that my code is not executed with cracked players? But I can't use any other event either. Because then it would be too late for ban

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #437: Cracked Fix by online

how can I make sure that my code is not executed with cracked players? But I can't use any other event either. Because then it would be too late for ban

Use LoginEvent - its called when the server recieved and validated EncryptionResponse

electronicboy

[PaperMC/Waterfall] New comment on issue #437: Cracked Fix by online

Not an issue, The event is a Pre login event, fired before the server attempts to handle authentication against mojang.

electronicboy

[PaperMC/Waterfall] Issue closed: #437 Cracked Fix by online

[buoyant shore]

electronicboy

[Travertine:master] 1 new commit

32c100e 1.15.1 protocol support - electronicboy

[buoyant shore]

andrewgazelka

[PaperMC/Travertine] New star added

[buoyant shore]

nkomarn

[PaperMC/Travertine] New star added

123Kappa

[PaperMC/Travertine] New comment on issue #102: md\_5\.bungee\.protocol\.EntityEffect 79

Did u find the cause of this?

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

90dcf97 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

b65ef1e Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

909beb4 Expose remote address in ConnectionInitEvent - electronicboy

electronicboy

[Travertine:master] 1 new commit

a62c86e Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

487b632 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

fef3195 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

meerpaluten

[PaperMC/Waterfall] Issue opened: #438 Bug

https://hastebin.com/sajexoyoyi.cs

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #438: Bug

Do you know that the player is not using an illegal client modification?

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

6456426 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

269c5fe Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

SrLeojaco

[PaperMC/Waterfall] New comment on issue #433: Error decoding packet

That's an exploit that is being used to crash bungee.

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #433: Error decoding packet

@SrLeojaco I ould not classify this as a bungeecord exploit. It is basically just a DDOS on Layer 7 and Bungeecord just is not that optimized in error handling.

[buoyant shore]

YukiLeafX

[PaperMC/Travertine] New star added

[buoyant shore]

rz7d

[PaperMC/Waterfall] Fork created: rz7d/Waterfall

[buoyant shore]

YouHaveTrouble

[PaperMC/Travertine] Fork created: YouHaveTrouble/Travertine

[buoyant shore]

derklaro

[PaperMC/Waterfall] Fork created: derklaro/Waterfall

[buoyant shore]

0H4rl3qu1n0

[PaperMC/Waterfall] Issue opened: #439 This is not an issue it's a question

Does Paper Work With Waterfall?
As it gives me the error that the server is in online mode though i clearly set online mode to false.

mikroskeem

[PaperMC/Waterfall] New comment on issue #439: This is not an issue it's a question

Please use Paper Discord or IRC (irc.spi.gt#waterfall) for the questions.

[buoyant shore]

Callahhh

[PaperMC/Waterfall] Fork created: Callahhh/Waterfall

[buoyant shore]

Koboo

[PaperMC/Waterfall] Fork created: Koboo/Waterfall

[buoyant shore]

SimplyCodin

[PaperMC/Waterfall] New star added

yappydog

[PaperMC/Waterfall] New star added

[buoyant shore]

LimoK10

[PaperMC/Waterfall] Fork created: LimoK10/Waterfall

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

5adaf9a Speed up some common exceptions - electronicboy

electronicboy

[Travertine:master] 1 new commit

c080a9e Updated Upstream (Waterfall) - electronicboy

electronicboy

[Waterfall:master] 1 new commit

20db3bf Add system property to allow processing bad pac... - electronicboy

electronicboy

[Travertine:master] 1 new commit

93fd439 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

lokka30

[PaperMC/Waterfall] Issue opened: #440 Error authenticating users with minecraft\.net

Hi! I've came across an issue with my Waterfall setup.
My users aren't able to connect, as they get kicked:

Error occurred while contacting login servers, are they down?

(Nope, the login servers aren't down)
We get this error if we disconnect from the Lobby once, then try to join again. I have to restart both Waterfall and the Lobby to fix it.
Waterfall prints this exception in console, below 'error authenticating USER with minecraft.net': [Link to Hastebin](https://hastebin.com/fi...

[buoyant shore]

lokka30

[PaperMC/Waterfall] New comment on issue #440: Error authenticating users with minecraft\.net

I removed all the modules and let Waterfall reinstall them. So far, the issue seems to be fixed. I'll keep it open in case I come across it again.

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #440: Error authenticating users with minecraft\.net

Errors point to DNS error, check your server's DNS configuration.

lokka30

[PaperMC/Waterfall] New comment on issue #440: Error authenticating users with minecraft\.net

Haven't touched my DNS configuration. Used to host bungee instances on the machine without error. Hosted locally on windows.
I apologize for my lack of knowledge on server hosting by the way. :-)

[buoyant shore]

lokka30

[PaperMC/Waterfall] New comment on issue #440: Error authenticating users with minecraft\.net

'sessionserver.mojang.com.Home' isn't a valid site, I don't think .Home is meant to be there.

[buoyant shore]

andris155

[PaperMC/Waterfall] Issue opened: #441 Hackers crash my server \- send too many wrong packets

https://pastebin.com/XhHGux9w (Full log - 20k lines)
10 wrong packets/sec

electronicboy

[PaperMC/Waterfall] Issue closed: #441 Hackers crash my server \- send too many wrong packets

electronicboy

[PaperMC/Waterfall] New comment on issue #441: Hackers crash my server \- send too many wrong packets

Issue has already been reported, please use the search function...
Also, update; Some level of mitigation was added last night.

andris155

[PaperMC/Waterfall] New comment on issue #441: Hackers crash my server \- send too many wrong packets

@electronicboy thanks, this fixed the crash. But this create 100 MB log/minute. Please add option to set a less character warn messages for wrong packets.

electronicboy

[PaperMC/Waterfall] New comment on issue #441: Hackers crash my server \- send too many wrong packets

Reducing the amount of logging ain't going to fix that much, it's basically on your side to mitigate these connection attempts, e.g. configuring fail2ban or using a plugin which will do similar

[buoyant shore]

MrEDok

[PaperMC/Waterfall] Fork created: MrEDok/Waterfall

[buoyant shore]

IndexOutOfMJ

[PaperMC/Waterfall] Fork created: IndexOutOfMJ/Waterfall

[buoyant shore]

Hite29

[PaperMC/Waterfall] Issue opened: #442 Error decoding packet

Hi, can u help me? I have this error.

[20:36:30] [Netty Worker IO Thread #15/ERROR]: [/188.75.186.162:50102] InitialHandler - encountered exception
io.netty.handler.codec.DecoderException: Error decoding packet class Handshake with contents:
+-------------------------------------------------+
| 0 1 2 3 4 5 6 7 8 9 a b c d e f |
+--------+-------------------------------------------------+----------------+
|00000000| 00 ...

electronicboy

[PaperMC/Waterfall] New comment on issue #442: Error decoding packet

Something sent a bad packet

electronicboy

[PaperMC/Waterfall] Issue closed: #442 Error decoding packet

[buoyant shore]

tomcraft

[PaperMC/Waterfall] Issue opened: #443 \[Improvement\] add event when proxy\-protocol packet is received

i see you added ConnectionInitEvent to waterfall, i would suggest an improvement
when you use Waterfall behind HAProxy, this event become quite useless as the ip the event see is the ip of the HAProxy server. So if you want to implement a connection throttler, or a macanism that prevents layer 7 flood (eg: handshake error flood) based on the connection IP, you can't. (not a good idea to ban your load-balancer's IP)

So, in case of proxy-protocol enabled, i think an other event should be ...

[buoyant shore]

IndexOutOfMJ

[PaperMC/Waterfall] Issue opened: #444 Unexpected packet received during server login process\!

Hey,

I have following problem:
If I join my server everything is okay, but if I try to join another server that is in another version (1.15.1)
following exception occurres:

Waterdfall (latest version):

encountered exception: net.md_5.bungee.util.QuietException: Unexpected packet received during server login process!
1b8f017b227472616e736c617465223a

Server I will join (also latest version):
lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java...

electronicboy

[PaperMC/Waterfall] New comment on issue #444: Unexpected packet received during server login process\!

The proxy didn't expect a kick packet to be sent in the login phase, fix your server

electronicboy

[PaperMC/Waterfall] Issue closed: #444 Unexpected packet received during server login process\!

IndexOutOfMJ

[PaperMC/Waterfall] New comment on issue #444: Unexpected packet received during server login process\!

Oh thanks. I did not expected, that it was a plugin error.

[buoyant shore]

perronosaurio

[PaperMC/Travertine] New star added

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

3a793b8 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

82952e0 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

lokka30

[PaperMC/Waterfall] New comment on issue #440: Error authenticating users with minecraft\.net

solved by electronicboy: 'disable the async dns feature in waterfall.yml'.

lokka30

[PaperMC/Waterfall] Issue closed: #440 Error authenticating users with minecraft\.net

[buoyant shore]

Jessebeau2001

[PaperMC/Waterfall] Fork created: Jessebeau2001/Waterfall

[buoyant shore]

PhilippCl

[PaperMC/Waterfall] New star added

[buoyant shore]

meerpaluten

[PaperMC/Waterfall] Issue opened: #445 Crash Report

My Server is crashing from a crasher. Herer is the log from the proxy.
2020-01-11-4.log.gz

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #445: Crash Report

Please use the search feature, this one has been discussed time and time again on github and on discord.

electronicboy

[PaperMC/Waterfall] Issue closed: #445 Crash Report

[buoyant shore]

Kneesnap

[PaperMC/Waterfall] New comment on issue #433: Error decoding packet

Can we make BungeeCord stop using exceptions for error handling then? People are kicking everyone on my server, and there's literally nothing we can do about it.

electronicboy

[PaperMC/Waterfall] New comment on issue #433: Error decoding packet

I've cut down on the workload by pulling out some of the heavy work around the exceptions, right now it's more the general logger + connection attempts, advice overall is to use fail2ban or something

[buoyant shore]

PhanaticD

[PaperMC/Waterfall] New comment on issue #433: Error decoding packet

if you have fail2ban installed, try this

add to: /etc/fail2ban/jail.conf
[bungee] enabled = true port = 25565 filter = bungee logpath = /replace/with/path/to/bungee/logs/latest.log maxretry = 5 findtime = 60 bantime = 600

make file: /etc/fail2ban/filter.d/bungee.conf
`# bungee configuration file
#/etc/fail2ban/filter.d/bungee.conf

[Definition]

Option: failregex

Notes.: regex to match the connection handler messages in the logfile. The

host...

[buoyant shore]

meerpaluten

[PaperMC/Waterfall] Issue closed: #438 Bug

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue closed: #439 This is not an issue it's a question

[buoyant shore]

Fizzelo

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

d598d51 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

a67f941 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

Farweekz

[PaperMC/Waterfall] Fork created: Farweekz/Waterfall

[buoyant shore]

MGW14

[PaperMC/Travertine] Fork created: MGW14/Travertine

[buoyant shore]

sathonay

[PaperMC/Travertine] New star added

[buoyant shore]

VQH-cmd

[PaperMC/Travertine] New star added

[buoyant shore]

Czechball

[PaperMC/Waterfall] New star added

[buoyant shore]

Coloryr

[PaperMC/Waterfall] Issue opened: #446 bad packet ID

When join server,Client will show:

disconnected with: The server you were previously on went down, you have been connected to a fallback server

And I watch Console,it show:

bad packet ID, are mods in use!? Did not read all bytes from packet class net.md_5.bungee.protocol.packet.EntityEffect 79 Protocol GAME Direction TO_CLIENT

What happen it?

huangsijun17

[PaperMC/Waterfall] New star added

huangsijun17

[PaperMC/Travertine] New star added

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #446: bad packet ID

Duplicate of #418

electronicboy

[PaperMC/Waterfall] Issue closed: #446 bad packet ID

KalebDark

[PaperMC/Waterfall] New star added

Coloryr

[PaperMC/Waterfall] New comment on issue #418: If a player has a potion effect,he will be kicked from server

thanks

Coloryr

[PaperMC/Waterfall] New comment on issue #446: bad packet ID

thanks

[buoyant shore]

AixMC

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

56fd936 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

ae5fefb Updated Upstream (Waterfall) - electronicboy

electronicboy

[Travertine:master] 1 new commit

dbe27f3 Add temp 1.15.2 support - electronicboy

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

8af0366 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

7740890 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

Aberdeener

[PaperMC/Waterfall] New comment on commit `8af0366`

thanks for the speedy update :)

[buoyant shore]

thehollowedone

[PaperMC/Waterfall] Issue opened: #447 Error Decoding Packet id 26

` +-------------------------------------------------+
| 0 1 2 3 4 5 6 7 8 9 a b c d e f |
+--------+-------------------------------------------------+----------------+
|00000000| 26 00 00 00 68 01 00 00 00 00 08 d8 c7 c1 1b 2e |&...h...........|
|00000010| 54 34 f4 04 66 6c 61 74 06 00 01 |T4..flat... |
+--------+-------------...

electronicboy

[PaperMC/Waterfall] New comment on issue #447: Error Decoding Packet id 26

That's not the full exception, more than likely your server also sent a bad packet, i.e. replicate without plugins

electronicboy

[PaperMC/Waterfall] Issue closed: #447 Error Decoding Packet id 26

[buoyant shore]

davidmanassa

[PaperMC/Waterfall] New star added

[buoyant shore]

TwentyTicks

[PaperMC/Travertine] Fork created: TwentyTicks/Travertine

[buoyant shore]

GC-spigot

[PaperMC/Waterfall] Issue opened: #448 NPE when setting block's type

just tested it with the latest build from the website ( #70 ) and the error still persists - https://pastebin.com/raw/nFRf3QiX with the Block#setType
Code: http://prntscr.com/qryfac

electronicboy

[PaperMC/Waterfall] New comment on issue #448: NPE when setting block's type

Wrong repo...

electronicboy

[PaperMC/Waterfall] Issue closed: #448 NPE when setting block's type

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

c21eed1 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

6c61092 Updated Upstream (Waterfall) - electronicboy

electronicboy

[Waterfall:master] 1 new commit

f3bcf0b Ditch 1.6 bootstrap - electronicboy

electronicboy

[Travertine:master] 1 new commit

29a0265 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

brandon-welsch

[PaperMC/Waterfall] New star added

[buoyant shore]

Siriuo

[PaperMC/Waterfall] Issue opened: #449 Forge Unexpected packet received error

Whenever trying to setup Waterfall with a forge 1.15.2 server (also tried with 1.14.4 and 1.15.1) I seem to get the below message displaying in the console and within Minecraft.

[Siriuo|/127.0.0.1:63010] ServerConnector [lobby] - encountered exception: net.md_5.bungee.util.QuietException: Unexpected packet received during server login process!
1bc7017b227472616e736c617465223a

No plugins/mods on either side just fresh installations of both.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #449: Forge Unexpected packet received error

Server initiated a kick, likely as bungee doesn't support modern forge support

electronicboy

[PaperMC/Waterfall] Issue closed: #449 Forge Unexpected packet received error

electronicboy

[PaperMC/Waterfall] Issue opened: #450 Modern forge support

Bungee, and by extension, Waterfall; does not support IP forwarding for forge clients, this needs to be investigated, especially as upstream has expressed 0 interest in maintaining forge support

[buoyant shore]

mcdudu233

[PaperMC/Waterfall] Issue opened: #451 Some errors\.Why caused this?

logs:
[14:49:50 ERROR]: [] ServerConnector [lobby] - encountered exception: net.md_5.bungee.util.QuietException: Unexpected packet received during server login process!
0d00

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #451: Some errors\.Why caused this?

Someone sent invalid data to your bungeecord.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue closed: #451 Some errors\.Why caused this?

[buoyant shore]

L4BORG

[PaperMC/Waterfall] Fork created: L4BORG/Waterfall

[buoyant shore]

Paroxial

[PaperMC/Travertine] New star added

[buoyant shore]

Coloryr

[PaperMC/Waterfall] Issue opened: #452 Allways"Timed out"

When join server,player can play some time,but they will kick out server,it show at log:

[23:15:14 INFO]: [Color_yr] disconnected with: Timed out

I try join Server many times,but it allways show this.
It some bugs?

electronicboy

[PaperMC/Waterfall] New comment on issue #452: Allways"Timed out"

Timed out
That means that a packet wasn't received in so long, generally more networking/plugin issues.

electronicboy

[PaperMC/Waterfall] Issue closed: #452 Allways"Timed out"

Coloryr

[PaperMC/Waterfall] New comment on issue #452: Allways"Timed out"

but if i use vanilla client,is also show this.

electronicboy

[PaperMC/Waterfall] New comment on issue #452: Allways"Timed out"

Never said anything about your client. This issue tracker is for reporting issues with waterfall, if you require support, please use the forums/irc/discord, however, we can't do much to debug these types of issues for you

[buoyant shore]

williambacteria

[PaperMC/Waterfall] Issue opened: #453 View Bug with BungeeTableListPlus

I used the latest Waterfall,and the latest BungeeTablistPlus.
The bug is When player change server and player's name will move to top left or bottom right.
This bug only occur on Waterfall, BungeeCord runs well.

electronicboy

[PaperMC/Waterfall] New comment on issue #453: View Bug with BungeeTableListPlus

re-enable metadata rewriting in waterfall.yml.

electronicboy

[PaperMC/Waterfall] Issue closed: #453 View Bug with BungeeTableListPlus

williambacteria

[PaperMC/Waterfall] New comment on issue #453: View Bug with BungeeTableListPlus

I love u

[buoyant shore]

yooniks

[PaperMC/Travertine] Fork created: yooniks/Travertine

[buoyant shore]

alexis-evelyn

[PaperMC/Waterfall] New star added

[buoyant shore]

QuiiBz

[PaperMC/Travertine] Fork created: QuiiBz/Travertine

[buoyant shore]

SuperLandNetwork

[PaperMC/Waterfall] Fork created: SuperLandNetwork/Waterfall

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

cca83df Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

3072d2a Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

Fabbyz

[PaperMC/Travertine] Issue opened: #118 Server\-icon issue

Hi, when i update to 1.15 version the server-icon doesn't work, it's normal?

[buoyant shore]

electronicboy

[PaperMC/Travertine] New comment on issue #118: Server\-icon issue

No, that is not normal, but without information, I can't really say... Generally, check your logs for errors, beyond that, make sure you've got the icon in the correct place (with ping-passthrough, you need it on the server)

electronicboy

[PaperMC/Travertine] Issue closed: #118 Server\-icon issue

[buoyant shore]

Aira-Sakuranomiya

[PaperMC/Waterfall] New star added

[buoyant shore]

LoXR

[PaperMC/Waterfall] Issue opened: #454 GReload not removing servers from config

Something for the issue tracker to be worked on down the track, where you could add servers in the config and /greload no worries. Trying to remove a server would have the server remain in /server.

Using latest Waterfall #318
Tested with and without plugins on Proxy.

[buoyant shore]

samnyan

[PaperMC/Waterfall] New star added

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #454: GReload not removing servers from config

This is intended by upstream (bungeecord) because what to do when people are still connected or currently connecting to the server in question of removal?

[buoyant shore]

Neeonn

[PaperMC/Waterfall] Fork created: Neeonn/Waterfall

[buoyant shore]

meerpaluten

[PaperMC/Waterfall] Issue opened: #455 Spigot Plugin error in proxy

Error: https://paste.timo.cloud/wukosuvusu.bash
In singelplayer the spigot plugin is work. but on the proxy not.

electronicboy

[PaperMC/Waterfall] New comment on issue #455: Spigot Plugin error in proxy

duplicate of #318

electronicboy

[PaperMC/Waterfall] Issue closed: #455 Spigot Plugin error in proxy

[buoyant shore]

CyberFlameGO

[PaperMC/Travertine] New star added

[buoyant shore]

tr7zw

[PaperMC/Travertine] New star added

[buoyant shore]

alexandregv

[PaperMC/Waterfall] New star added

[buoyant shore]

lightda104530

[PaperMC/Waterfall] New star added

[buoyant shore]

triedgriefdev

[PaperMC/Waterfall] New star added

[buoyant shore]

Xernium

[PaperMC/Waterfall] Fork created: Xernium/Waterfall

[buoyant shore]

Xernium

[PaperMC/Travertine] Fork created: Xernium/Travertine

[buoyant shore]

sq179

[PaperMC/Waterfall] New star added

[buoyant shore]

IceMeltt

[PaperMC/Waterfall] New star added

[buoyant shore]

Justsnoopy30

[PaperMC/Waterfall] Fork created: Justsnoopy30/Waterfall

[buoyant shore]

bricerigagneau

[PaperMC/Waterfall] Fork created: bricerigagneau/Waterfall

[buoyant shore]

hypercubemc-github

[PaperMC/Waterfall] Fork created: hypercubemc-github/Waterfall

[buoyant shore]

muumlover

[PaperMC/Waterfall] New star added

[buoyant shore]

FoxieYT

[PaperMC/Waterfall] Fork created: FoxieYT/Waterfall

[buoyant shore]

electronicboy

[Waterfall:pending\-upstream] 1 new commit

17d5b78 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[PaperMC/Waterfall] New branch created: pending\-upstream

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

17d5b78 Updated Upstream (BungeeCord) - electronicboy

[buoyant shore]

Artuto

[PaperMC/Waterfall] Fork created: Artuto/Waterfall

Artuto

[PaperMC/Waterfall] Pull request opened: #456 Removed duplicated javadoc param

This causes the build to fail when using upstream's new profile "dest" with the following command:

mvn -P dist package

[WARNING] Javadoc Warnings
[WARNING] C:\Users\artut\Documents\Projects\Minecraft\Waterfall\Waterfall-Proxy\api\src\main\java\net\md_5\bungee\api\scheduler\TaskScheduler.java:93: warning - Parameter "plugin" is documented more than once.

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #456 Removed duplicated javadoc param

electronicboy

[PaperMC/Waterfall] Pull request closed: #456 Removed duplicated javadoc param

electronicboy

[Waterfall:master] 1 new commit

e9ad343 Removed duplicated javadoc param (#456) - Artuto

[buoyant shore]

Justsnoopy30

[PaperMC/Waterfall] Fork created: Justsnoopy30/Waterfall

[buoyant shore]

applenick

[PaperMC/Waterfall] New star added

[buoyant shore]

ifvictr

[PaperMC/Waterfall] New star added

[buoyant shore]

PhanaticD

[PaperMC/Travertine] Issue opened: #119 player kick, nbt related error

https://pastebin.com/raw/VcsFBry7

electronicboy

[PaperMC/Travertine] New comment on issue #119: player kick, nbt related error

Not really an issue on our side from what I can see, bad NBT tag?

electronicboy

[Travertine:master] 1 new commit

626024b Updated Upstream (Waterfall) - electronicboy

PhanaticD

[PaperMC/Travertine] New comment on issue #119: player kick, nbt related error

that stacktrace in travertine log is only info i can find, i went to the location the player logged in there was nothing there

[buoyant shore]

R4G3-BABY

[PaperMC/Waterfall] Fork created: R4G3-BABY/Waterfall

[buoyant shore]

OvercastCommunity

[PaperMC/Waterfall] Fork created: OvercastCommunity/Waterfall

[buoyant shore]

Luracasmus

[PaperMC/Waterfall] Fork created: Luracasmus/Waterfall

Luracasmus

[PaperMC/Waterfall] New star added

Luracasmus

[PaperMC/Travertine] New star added

[buoyant shore]

lucaazalim

[PaperMC/Waterfall] Issue opened: #457 Increased average player latency

I have updated Waterfall to the lastest commit yesterday, and today my average player latency graph shows constant ping increase and a lot of random spikes.

My plugin calculates the ping average based on ProxiedPlayer::getPing to generate this graph. It is affecting my three Waterfall instances. I have about 600 players playing on each one.

Is there anyone being affected b...

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

From what commit did you update? There haven't been any significant commits related to networking recently either, so perhaps something still on your end?

[buoyant shore]

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

This is the commit we have updated to: https://github.com/PaperMC/Waterfall/commit/e9ad343d5e878e8eba5610c970180cf155e4e14b

I'm going to deploy an instance with the old Waterfall version to make some tests today. I'll send the results here.

mikroskeem

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Let me reword my question... what commit did you use before?

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

This was the ccommit we updated from: https://github.com/PaperMC/Waterfall/commit/6456426ebdf5c4ad3b32a8954607892e70139e63

mikroskeem

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Maybe https://github.com/SpigotMC/BungeeCord/commit/eeb374798b10786bb87175796b55bed0275d56c7 could be the culprit?

[buoyant shore]

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Maybe SpigotMC/BungeeCord@eeb3747 could be the culprit?

Maybe. Probably yes.

Testing results:

• proxy-3 is running https://github.com/PaperMC/Waterfall/commit/6456426ebdf5c4ad3b32a8954607892e70139e63
• proxy-2 and proxy-1 are running https://github.com/PaperMC/Waterfall/commit/e9ad343d5e878e8eba5610c970180cf155e4e14b

![image](https://user-images.githubusercontent....

[buoyant shore]

mikroskeem

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Maybe you could try to revert that change to confirm that it's the issue?

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Previous bungee versions would stop keepalives wrongly if they arrive after the next keepalive was already sent. I think the added spikes could in theory be that it just got accurate now.

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Maybe you could try to revert that change to confirm that it's the issue?

I'm gonna do that. I'll post the results in the next hours.

Previous bungee versions would stop keepalives wrongly if they arrive after the next keepalive was already sent (by default ping 1000+). I think the added spikes could in theory be that it just got accurate now and your server sending keepalives more frequent or sth. along those lines.

Something I noticied is that there are no players reporting...

[buoyant shore]

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

New testing results:

• proxy-1 and proxy-2 are running on the latest commit.
• proxy-3 is running with the latest commit (https://github.com/PaperMC/Waterfall/commit/e9ad343d5e878e8eba5610c970180cf155e4e14b) with https://github.com/SpigotMC/BungeeCord/commit/eeb374798b10786bb87175796b55bed0275d56c7 reverted.

![image](https://user-images.githubusercontent.com/10585881/7497...

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Do you run any plugin on spigot/bungee sending Ping (aka Keepalive) packets? Do you run ViaVersion on Bungee or similar "heavy" stuff?

[buoyant shore]

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

• I don't have anything sending keepalive packets afaik.
• I do run ViaVersion on all my spigot servers.
• I noticied that sometimes the average ping is above 1.4 seconds during the spikes.

I'm gonna try to figure out a way to bring more detailed informations here. Unfortunally the tests are being done on a production environment and I can't restart it as frequently as needed. I'll try.

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Sure, take your time.
As I was the first one creating the bungee issue about it not letting all the keepalives through, I am just really interested why the average decreased that much.

[buoyant shore]

Timeox2k

[PaperMC/Travertine] Fork created: Timeox2k/Travertine

[buoyant shore]

AxdyYT

[PaperMC/Travertine] Fork created: AxdyYT/Travertine

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] Issue opened: #458 Waterfall doesn't call upstream ClientConnectEvent

Can break some bungeecord plugins.

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #443: \[Improvement\] add event when proxy\-protocol packet is received

Wrong. The IP the event see is the player's real IP. The event is called at very early stage, even before the HAProxyMessage is received and decoded.

[buoyant shore]

tomcraft

[PaperMC/Waterfall] New comment on issue #443: \[Improvement\] add event when proxy\-protocol packet is received

When you use HAProxy in front of your Waterfall/BungeeCord, the IP who init
the connection is the IP of the HAProxy server, not the IP of the Minecraft
Client.

Le sam. 22 févr. 2020 à 07:43, MrIvanPlays [e-mail] a
écrit :

Wrong. The IP the event see is the player's real IP. The event is called
at very early stage, even before the HAProxyMessage is received and decoded.

—
You are receiving this because you authored the thread.
Reply to this email directly, view...

[buoyant shore]

tomcraft

[PaperMC/Waterfall] New comment on issue #443: \[Improvement\] add event when proxy\-protocol packet is received

When you use HAProxy in front of your Waterfall/BungeeCord, the IP which init
the connection is the IP of the HAProxy server, not the IP of the Minecraft Client. So, no the ConnectionInitEvent doesn't see the player IP at this early stage of the connection.

Just the same way as Spigot see BungeeCord IP if bungee-protocol is not enabled.

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

e19ea6c Call Bungees ClientConnectEvent (Fixes #458) - electronicboy

electronicboy

[PaperMC/Waterfall] Issue closed: #458 Waterfall doesn't call upstream ClientConnectEvent

electronicboy

[Travertine:master] 1 new commit

3d46c01 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #443: \[Improvement\] add event when proxy\-protocol packet is received

I think it might be better to feed the connection blockage maybe into iptables before HAProxy. That way you're protecting all your bungee's together.
Not sure how HAProxy reacts if the connection is closed immediately: will it maybe try to connect every directly cancelled connection to each other bungee until there's no option left or sth. like that?

[buoyant shore]

tomcraft

[PaperMC/Waterfall] New comment on issue #443: \[Improvement\] add event when proxy\-protocol packet is received

When your HAProxy is not managed by you, you can't play with iptable in front of HAProxy.
Also, playing with iptable for a connection throttler seems quite heavy.
I already made some test and it did not caused any problem to close the connection.

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

56ab742 Fix CCE from last commit - electronicboy

electronicboy

[Travertine:master] 1 new commit

61b2d3b Updated Upstream (Waterfall) - electronicboy

mikroskeem

[PaperMC/Waterfall] New comment on commit `56ab742`

Seems like [https://github.com/PaperMC/Waterfall/commit/e9ad343d5e878e8eba5610c970180cf155e4e14b] got reverted

electronicboy

[PaperMC/Waterfall] New comment on commit `56ab742`

rees internally

electronicboy

[Waterfall:master] 1 new commit

5dcfe9e Removed duplicated javadoc param (#456) - Artuto

electronicboy

[Travertine:master] 1 new commit

c39894d Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

tikaros

[PaperMC/Waterfall] Fork created: tikaros/Waterfall

[buoyant shore]

ranzeplay

[PaperMC/Waterfall] New star added

NoManaSendHelp

[PaperMC/Waterfall] New star added

[buoyant shore]

Nze25

[PaperMC/Travertine] Fork created: Nze25/Travertine

[buoyant shore]

UnRealDinnerbone

[PaperMC/Waterfall] Fork created: UnRealDinnerbone/Waterfall

[buoyant shore]

Jojo1542

[PaperMC/Travertine] Fork created: Jojo1542/Travertine

[buoyant shore]

Xernium

[PaperMC/Travertine] Pull request opened: #120 \[Future\] Tracking 1\.16 changes

This Pull-request is meant to be merge-ready when 1.16 gets released so a usable Bungeecord can be obtained ASAP. The changes in this PR will get lost when Bungeecord gets updated to support 1.16, that is intentional. This is just meant to maybe make @electronicboy s life a little easier ;)

[buoyant shore]

DrexHD

[PaperMC/Waterfall] Fork created: DrexHD/Waterfall

[buoyant shore]

Tanju42

[PaperMC/Waterfall] Issue opened: #459 When pressed \*tab\* and there is a '\\'

I have a String: te_st
When I press tab the preview is: te_st

And when I confirm that I want the string it places it as this: te\_st

Here a Photo:

haeiven

[PaperMC/Waterfall] Issue opened: #460 Logs rate limit

Hello,

Since few years now, bots attacks are rly common on Minecraft.

We've nice antibots to prevent that happening, but there's something who antibots don't handle, it's the logs. Some plugins are having errors when there's too many connections & cancelled connections. And then they're flooding the logs and it start to lag Waterfall.

My idea is to add an option to rate-limit the logs to prevent these lags.

[buoyant shore]

pietreg

[PaperMC/Waterfall] New star added

[buoyant shore]

jbdman

[PaperMC/Waterfall] Issue opened: #461 disable\_entity\_metadata\_rewrite causes other players to become invisible

Similarly to #350

I have an issue using the 4.1.0 Release Version of SkyFactory 4 (Forge 2838), and Waterfall build 323.

When disable_entity_metadata_rewrite is true, players are not able to see each other at all. When disable_entity_metadata_rewrite is false, players are able to see each other, but are periodically kicked due to the Unknown Meta Type.

I am also able to reproduce this issue using Forge 2838, no Mods, and pure Vanilla 1.12.2.

My config files follow:

config.yml:...

[buoyant shore]

JH3Y50N

[PaperMC/Waterfall] New comment on issue #460: Logs rate limit

JH_AntiBot v3 have log filter... handle and remove..

[buoyant shore]

Yboy06

[PaperMC/Waterfall] Issue opened: #462 Timer already cancelled

Hello:
I am getting this error when I load my WaterFall server.

[21:41:22 ERROR]: Exception in thread "main" java.lang.IllegalStateException: Timer already cancelled.
[21:41:22 ERROR]:       at java.util.Timer.sched(Timer.java:397)
[21:41:22 ERROR]:       at java.util.Timer.scheduleAtFixedRate(Timer.java:328)
[21:41:22 ERROR]:       at net.md_5.bungee.BungeeCord.start(BungeeCord.java:290)
[21:41:22 ERROR]:       at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:6...

electronicboy

[PaperMC/Waterfall] New comment on issue #462: Timer already cancelled

The only time that timer is stopped is when the proxy is shutting down, more than likely down to plugins, etc

electronicboy

[PaperMC/Waterfall] Issue closed: #462 Timer already cancelled

[buoyant shore]

paulzzh

[PaperMC/Waterfall] New star added

[buoyant shore]

JesFot

[PaperMC/Waterfall] Fork created: JesFot/Waterfall

[buoyant shore]

Fengchen777

[PaperMC/Waterfall] New star added

[buoyant shore]

Gtzgold

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

54b7faf Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Waterfall:master] 1 new commit

fda6406 Actually rebuilding patches goes a long way - electronicboy

electronicboy

[Travertine:master] 1 new commit

2050e1a Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

coco0325

[PaperMC/Waterfall] Issue opened: #463 Netty Causing Lag

When player count over about 130 Netty eat all cpu usage and causing lag.
YourKit report https://pastebin.com/ufcYhUUf

Waterfall ver #323
Paper 1.15.2

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #463: Netty Causing Lag

report doesn't show anything other than your server opening a ton of new socket connections, which is never gonna be super nice if all your IO workers are working on opening connections...

electronicboy

[PaperMC/Waterfall] Issue closed: #463 Netty Causing Lag

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

This could be a possible problem: https://github.com/SpigotMC/BungeeCord/commit/eeb374798b10786bb87175796b55bed0275d56c7#r37698703

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

@lucaazalim possible problem identified
https://github.com/SpigotMC/BungeeCord/issues/2783

[buoyant shore]

Bennyboy1695

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

This is highly wanted 😄 Anything you need to get the support to happen or is it just a waiting game ?

[buoyant shore]

virustotalop

[PaperMC/Travertine] New star added

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

6f3e7d0 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

25970ec Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

LRNZ09

[PaperMC/Waterfall] New star added

[buoyant shore]

tiarnia

[PaperMC/Waterfall] New comment on issue #449: Forge Unexpected packet received error

well why not it says it does and you can turn in forge in the config but you cant use it?

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #449: Forge Unexpected packet received error

Because nobody has added support for it, and upstream (Bungee) has actually dropped maintenance for forge support
#450 PRs welcome

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

https://github.com/SpigotMC/BungeeCord/pull/2786#issuecomment-598031817

Perhaps the problem comes from that you run ViaVersion in your spigot servers or your server's network is terrible.

[buoyant shore]

PurpleIsEverything

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

I did quite a bit more digging into this and it's actually might be a bit more simple than I think people are realizing.

The error experienced in #449 is a Disconnect packet caused by the server lacking IP Forwarding support. A 1.14+ modded client can connect to a modded server in Vanilla mode just fine it's when you start involving mods you have trouble.

17:06:42 [INFO] Packet ID: 27
17:06:42 [INFO] Text?: {"translate":"disconnect.genericReason","with":["Internal Exception: io.ne...

electronicboy

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

You don't add those attributes via the proxy, attributes aren't transmitted over the connection, from what I recall, it's basically just a K,V store on the connection, but, that's set here: https://github.com/MinecraftForge/MinecraftForge/blob/1933d05e36245ef7461b29853b4854fa769a807f/src/main/java/net/minecraftforge/fml/network/FMLHandshakeHandler.java#L186

PurpleIsEverything

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

In the case of the new FML protocol you won't be worrying about phases or race conditions for the FML Handshake it's all being done over the Vanilla LoginPayloadRequest and Responses they are blocking operations and are forced to happen in order.

Your really only needing to track the vanilla transition between LOGIN and PLAY as these payloads need to ALL complete during LOGIN.

electronicboy

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

I've yet to get around to looking over the new protocol, still on the mend from my health issues, sloowly getting there, needless to say, stuff like this is on the back burner

The issue is really reimplementing the login stuff, that all has to be handled by the proxy given the nature of how this all works, not really expecting any issues, it just boils down to getting the time/motivation/energy/brain-juice to do it

PurpleIsEverything

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

I fully understand hence why I've be trying to do as much as the leg work as possible and will continue to do so to try and reduce some of the workload.

This issue is a very significant blockade to our innovation and keeping our players a safe and happy with new content is of the utmost priority. Without this we can't provide them the experience they expect.

With everyone moving on we just want to be able to keep up, wish you the best hope to see you find the time, motivation and energy...

[buoyant shore]

unchama

[PaperMC/Waterfall] New star added

blackbracken

[PaperMC/Waterfall] New star added

[buoyant shore]

lucaazalim

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

@MrIvanPlays calculations are right (it's a simple average) and our network is fine. I can't test it without ViaVersion. I don't think that testing it with one online player is enough to assume that the problem is with ViaVersion, my network or calculations.

[buoyant shore]

PurpleIsEverything

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

I've done quite a bit more digging today and found a few more things.

Currently it seems that PayloadRequest and Response packets are coming in AFTER the Login Success packet has already been sent here unfortunately that means the client has already gone into a Play state.

The server will attempt 20 times to send fml:loginwrapper...

[buoyant shore]

andris155

[PaperMC/Waterfall] Issue opened: #464 Extra heart and protection icons no remove after switch server

Extra heart and protection icons no remove after switch server
https://www.youtube.com/watch?v=JNunZMOwPOQ

[buoyant shore]

rz7d

[PaperMC/Waterfall] Pull request opened: #465 Do not throw IllegalArgumentException when empty chat has sent

Replaces a Preconditions API call with the simple if/return statement.
This Pull Request fixes Issue #413

Behavior Changes:

Before

Throws IllegalArgumentException if received an empty chat.

After

The empty chat is ignored quietly.

[buoyant shore]

Artuto

[PaperMC/Waterfall] New comment on pull request #465: Do not throw IllegalArgumentException when empty chat has sent

I dont think a call to a method should be ignored silently

[buoyant shore]

rz7d

[PaperMC/Waterfall] New comment on pull request #465: Do not throw IllegalArgumentException when empty chat has sent

I dont think a call to a method should be ignored silently

@Artuto
Yes, I think so too.

I followed the commit history. But the patch is created by Initial Commit.
I need more help or descriptions for this patch.

I'll add the patch that logs empty messages as warnings.

Spigot 1.15.2:
![image](https://user-images.githubuse...

[buoyant shore]

sorenbug

[PaperMC/Waterfall] Issue opened: #466 A way to create new servers through AWS and have Waterfall recognize them

Is there a way I can hook into Waterfall to

1. Query how many players are on a certain server (or a certain subset of servers)?
2. Tell AWS to create the appropriate new server for a specific gamemode and map?
3. Tell Waterfall that that new server exists?

The usecase is as follows:

Say my server has various different gamemodes, such as hg, uhc, bedwars, etc. Some of those gamemodes may have templates for specific maps (hg-jungle, bedwars-city) while some may not (just `uhc...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on pull request #465: Do not throw IllegalArgumentException when empty chat has sent

I was iffy on doing this myself in the past as I wasn't sure of the /why/ of this in the first place
@astei Are you able to give any insights on this?

electronicboy

[PaperMC/Waterfall] New comment on issue #466: A way to create new servers through AWS and have Waterfall recognize them

Is there a better way to dynamically manage servers with Waterfall
Yes, the servers list in waterfall is mutable, allowing you to add/remove servers as your heard desires

1. "yes", bungee provides API for pinging servers, not to mention the players list that the proxy itself maintains (however, proxies list is local to the proxy)
2. I would imagine that there are java APIs available for that

electronicboy

[PaperMC/Waterfall] Issue closed: #466 A way to create new servers through AWS and have Waterfall recognize them

sorenbug

[PaperMC/Waterfall] New comment on issue #466: A way to create new servers through AWS and have Waterfall recognize them

Is there a code example somewhere of changing servers at runtime?

[buoyant shore]

ServersTitan

[PaperMC/Waterfall] Fork created: ServersTitan/Waterfall

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on pull request #465: Do not throw IllegalArgumentException when empty chat has sent

Not a proper solution to the problem.

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #466: A way to create new servers through AWS and have Waterfall recognize them

BungeeCord API allows adding servers by constructing a server info with ProxyServer.getInstance().constructServerInfo(...) and then calling ProxyServer.getInstance().getServers().add(...)

Removal should be possible too, but make sure nobody is on the servers you remove.

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #457: Increased average player latency

Can you just dump https://github.com/SpigotMC/BungeeCord/pull/2786 's jar in your server and then give data? The problem's not obv waterfall, it's coming from bungee so you test it on bungee level.

[buoyant shore]

LinsaFTW

[PaperMC/Waterfall] Issue opened: #467 Remove Empty Packet check \- Finding a real workaround

I dont know the reason Empty Packet was originally added, but if i recall correctly it is Exploit related.

This check does nothing but break some clients as you can spam any other packet that doesnt explicitly do a ch.close() and it will break all the netty threads preventing anyone from joining the server.

I disabled this on FlameCord and didn't found any issues.

mikroskeem

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

You mean this patch?

That's not for "exploit" prevention, it's there because vanilla server is able to handle empty packets fine while BungeeCord kicks player because of it.

mikroskeem

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

Or rather... vanilla client, not server. When server sends out an empty packet for some reason (that seems to happen with some weird plugin combinations) then proxy<->server connection simply gets dropped because of an exception.

[buoyant shore]

PurpleIsEverything

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

Unfortunately after much discussion modern Forge support currently is not possible with the current climate.

There is no packet currently available to reset the client back into a LOGIN state and without that server switching will never be possible.

While initial logins could be done by having Bungee wait for a Login Success or Join Game packet before sending a login success to the client and moving on to Play this will likely cause lots of confusion.

[buoyant shore]

LinsaFTW

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

For some reason this doesnt seem to happen with FlameCord. Weird.

LinsaFTW

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

I will close this because it seems that some people might have issues with empty packets. So people without issues just have to allow empty packets.

LinsaFTW

[PaperMC/Waterfall] Issue closed: #467 Remove Empty Packet check \- Finding a real workaround

[buoyant shore]

Leymooo

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

might have issues with empty packets
I think will be better to use separate VarInt And Packet decoder (extend with override read method) for server <--> proxy with empty packet fix, and for player <--> proxy use original decoders to avoid any potential exploits without readable bytes.

[buoyant shore]

LinsaFTW

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

Reopen to support the idea above this message.

LinsaFTW

[PaperMC/Waterfall] Issue reopened: #467 Remove Empty Packet check \- Finding a real workaround

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

same conclusion I came to on my end before I nodded off last night, but yea, this patch was nothing to do with exploit prevention, but to dull the behavioral difference of bad plugins, people assume that just because it's not kicking a direct connection to the server that something on the server isn't being bad

electronicboy

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

sounds like it would just leave us in the exact same state of affairs, but, with some level of "we support 1.14+", unless I'm missing something with the older system, the client was never forced back into login

[buoyant shore]

xANoyU

[PaperMC/Waterfall] Issue opened: #468 java\.lang\.IllegalArgumentException: Unknown meta type 14

https://paste.ubuntu.com/p/ybyNQhYn6P/
Kick from server to login server

I know to set "disable_entity_metadata_rewrite" as true Can solve this problem

But it makes my tablist sort incorrectly.
image:

Tips after being kicked out

I use the BungeeTablistPlus plugin, But I don't know how to turn to them for help
this is BungeeTabl...

electronicboy

[PaperMC/Waterfall] Issue closed: #468 java\.lang\.IllegalArgumentException: Unknown meta type 14

electronicboy

[PaperMC/Waterfall] New comment on issue #468: java\.lang\.IllegalArgumentException: Unknown meta type 14

tab list order is a known bug, pretty sure that there is already an issue report open for it

[buoyant shore]

PurpleIsEverything

[PaperMC/Waterfall] New comment on issue #450: Modern forge support

No it wasn't since the FML handshake happened in Game mode since it was all Plugin Messages.

[buoyant shore]

Sneakometer

[PaperMC/Waterfall] Issue opened: #469 Shorten / Speedup " Cannot request protocol" exception

As the "corrupted frame" and bad "packet id" excptions where shortened to one line, i wonder if it is possible to do the same thing for the "Cannot request protocol" exception because it can be used to spam the console and lag the server.

Sample Exception:
`[21:04:52 ERROR]: [/192.254.99.49:35795] InitialHandler - encountered exception
java.lang.IllegalArgumentException: Cannot request protocol 49
at net.md_5.bungee.connection.InitialHandler.handle(InitialHandler.java:354) ~[Wa...

[buoyant shore]

LinsaFTW

[PaperMC/Waterfall] New comment on issue #467: Remove Empty Packet check \- Finding a real workaround

same conclusion I came to on my end before I nodded off last night, but yea, this patch was nothing to do with exploit prevention, but to dull the behavioral difference of bad plugins, people assume that just because it's not kicking a direct connection to the server that something on the server isn't being bad

Agree. Its pretty random and you can't really notice.

Alexre

[PaperMC/Waterfall] Issue opened: #470 Greload command not working correctly

I'm using the latest version of waterfall and greload command is not reloading servers ip's, if I want to edit the ip of an existing server, greload won't apply the changes.

Thanks

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #470: Greload command not working correctly

Intended behaviour by bungeecord. /greload only allows adding new servers.

Alexre

[PaperMC/Waterfall] New comment on issue #470: Greload command not working correctly

Ok thanks

Alexre

[PaperMC/Waterfall] Issue closed: #470 Greload command not working correctly

[buoyant shore]

zorbyte

[PaperMC/Waterfall] New star added

[buoyant shore]

RealTriassic

[PaperMC/Waterfall] New star added

RealTriassic

[PaperMC/Travertine] New star added

[buoyant shore]

Proximyst

[PaperMC/Waterfall] Issue opened: #471 Building on OpenJ9 Java 14 results in segmentation fault

Honestly, quite stumped. I've never had this in Java before, so I have no clue where this is supposed to be reported, but compiling Waterfall just dies when using OpenJ9 Java 14 from AdoptOpenJDK (I use https://aur.archlinux.org/packages/jdk14-openj9-bin/).

[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] Waterfall-Super                                                    [pom]...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #471: Building on OpenJ9 Java 14 results in segmentation fault

cannot replicate, but, this falls into line with a bug with the JVM, the jit mechanism induced a segmentation fault, which runs into software bugs/potentially hardware issues

electronicboy

[PaperMC/Waterfall] Issue closed: #471 Building on OpenJ9 Java 14 results in segmentation fault

[buoyant shore]

Jordin

[PaperMC/Travertine] New star added

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #471: Building on OpenJ9 Java 14 results in segmentation fault

I suggest to prefer openjdk aka hotspot over openj9. I heard hotspot is faster and openj9 uses a little less memory.

[buoyant shore]

jbdman

[PaperMC/Waterfall] New comment on issue #461: disable\_entity\_metadata\_rewrite causes other players to become invisible

Will be testing this issue again, when I get home from work in approximately 5 hours.

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #469: Shorten / Speedup "Cannot request protocol" exception

https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java#L347

Basically exception shouldn't be thrown, the client should be dropped without exception.

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #461: disable\_entity\_metadata\_rewrite causes other players to become invisible

Are you running viaversion? Or have a combination with protocolsupport & skinsrestorer?

MrIvanPlays

[PaperMC/Waterfall] New comment on issue #464: Extra heart and protection icons no remove after switch server

Do you have entity metadata rewrite disabled?

OG-Games

[PaperMC/Waterfall] Fork created: OG-Games/Waterfall

OG-Games

[PaperMC/Travertine] Fork created: OG-Games/Travertine

[buoyant shore]

Azn9

[PaperMC/Waterfall] Fork created: Azn9/Waterfall

[buoyant shore]

alexis-evelyn

[PaperMC/Waterfall] Fork created: alexis-evelyn/Waterfall

[buoyant shore]

kamziksvk

[PaperMC/Travertine] Issue opened: #121 antibot stopped working

Hello, our antibot stopped working with the latest release of your Travertine. Here is the pastebin info:

[04:02:40] [main/WARN]: Exception encountered when loading plugin: AntiBotDeluxe
java.lang.IllegalAccessError: tried to access class net.md_5.bungee.api.plugin.PluginClassloader from class de.fusion.antibotdeluxe.bungee.AntiBotDeluxe
	at de.fusion.antibotdeluxe.bungee.AntiBotDeluxe.onEnable(AntiBotDeluxe.java:180) ~[?:?]
	at net.md_5.bungee.api.plugin.PluginManager.enablePlugins(...

mikroskeem

[PaperMC/Travertine] New comment on issue #121: antibot stopped working

https://github.com/SpigotMC/BungeeCord/commit/f41b1fc82131842409fed2df1c702cda36b06bd2

Tell your plugin's author to fix the plugin.

[buoyant shore]

leoncp9

[PaperMC/Waterfall] Issue opened: #472 Add features to alert commands

Hi can you add the options for remove the prefix in the /alert command by waterfall proxy?
\u00a7h
In game i can use &h before all text for remove the prefix, but in the messages.properties file of Waterfall.jar i can't set the code \u00a7h
so is possible set the code &h for remove the prefix in /alert ?
Thank

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #472: Add features to alert commands

In message.properties you should be able to just leave the alert message empty (or use \u00a7f as alert value if it complains about the value being empty).

[buoyant shore]

skyforce77

[PaperMC/Waterfall] Fork created: skyforce77/Waterfall

[buoyant shore]

leoncp9

[PaperMC/Waterfall] New comment on issue #472: Add features to alert commands

yes work, thank little panda, have good day! :D

leoncp9

[PaperMC/Waterfall] Issue closed: #472 Add features to alert commands

[buoyant shore]

skyforce77

[PaperMC/Travertine] Fork created: skyforce77/Travertine

[buoyant shore]

itzcy

[PaperMC/Waterfall] New star added

[buoyant shore]

ForumPlayer

[PaperMC/Waterfall] New star added

andris155

[PaperMC/Waterfall] New comment on issue #464: Extra heart and protection icons no remove after switch server

Yes, disabled.
I don't use viaversion/protocolsupport plugins.

[buoyant shore]

jbdman

[PaperMC/Waterfall] New comment on issue #461: disable\_entity\_metadata\_rewrite causes other players to become invisible

No sir. Forge server on the back end, or vanilla, same issue occurs. No extra bungee plugins.

[buoyant shore]

GeRaged

[PaperMC/Waterfall] Fork created: GeRaged/Waterfall

[buoyant shore]

CirnoTH

[PaperMC/Waterfall] Fork created: CirnoTH/Waterfall

[buoyant shore]

AfkF24

[PaperMC/Waterfall] Issue opened: #473 java\.lang\.IllegalArgumentException: Cannot request protocol 99

I am basically getting my console spammed with this. Server is completely timed out while this is happening.

[20:01:58] [Netty Worker IO Thread #2/ERROR]: [/X.X.X.X:46611]  InitialHandler - encountered exception
java.lang.IllegalArgumentException: Cannot request protocol 99
	at net.md_5.bungee.connection.InitialHandler.handle(InitialHandler.java:354) ~[waterfall-319.jar:git:Waterfall-Bootstrap:1.15-SNAPSHOT:ea7863f:319]
	at net.md_5.bungee.protocol.packet.Handshake.handle(Handshake...

Leymooo

[PaperMC/Waterfall] New comment on issue #473: java\.lang\.IllegalArgumentException: Cannot request protocol 99

https://github.com/SpigotMC/BungeeCord/issues/2793

I think this is a main cause why all this "exploits" work and actually can drop bungeecord

[buoyant shore]

Maxsimuss

[PaperMC/Waterfall] Fork created: Maxsimuss/Waterfall

[buoyant shore]

systemmonkey42

[PaperMC/Waterfall] New star added

[buoyant shore]

Spontini

[PaperMC/Waterfall] Issue opened: #474 \[Enchantment\] Server management without restart

Hello, i don't know why this feature is not exist in the Bungeecord/ Waterfall yet but i think we should've commands to do these things;

• Create/ Remove Servers, ForcedHosts, Change MOTD
• Create/ Remove Groups, Permissions and change group of the user.

TheViperShow

[PaperMC/Waterfall] New comment on issue #474: \[Enchantment\] Server management without restart

Yes it would be nice to see this in-game , the only way to do this currently is using external plugins.

Spontini

[PaperMC/Waterfall] New comment on issue #474: \[Enchantment\] Server management without restart

Yes it would be nice to see this in-game , the only way to do this currently is using external plugins.

Yes and sadly most of the plugins are not that optimized, i believe the real creators can do a lot better job.

electronicboy

[PaperMC/Waterfall] New comment on issue #474: \[Enchantment\] Server management without restart

Create/ Remove Servers, ForcedHosts, Change MOTD

Waterfall exposes API for the former, the others can already be done by a plugin;
Not really sure that there is much interest in designing commands for this, etc

Create/ Remove Groups, Permissions and change group of the user

The mechanism built into bungeecord is trivial and flawed, I do not consider the built in mechanism as being suitable for production servers as-is, use a permissions plugin which is actually designed to be ro...

Spontini

[PaperMC/Waterfall] New comment on issue #474: \[Enchantment\] Server management without restart

Create/ Remove Servers, ForcedHosts, Change MOTD

Waterfall exposes API for the former, the others can already be done by a plugin;
Not really sure that there is much interest in designing commands for this, etc

Create/ Remove Groups, Permissions and change group of the user

The mechanism built into bungeecord is trivial and flawed, I do not consider the built in mechanism as being suitable for production servers as-is, use a permissions plugin which is actually d...

[buoyant shore]

tsao-chi

[PaperMC/Waterfall] New star added

[buoyant shore]

Urek00

[PaperMC/Waterfall] Fork created: Urek00/Waterfall

DebuffPvP

[PaperMC/Travertine] Issue opened: #122 Trvertine Exception Issue

Hi sometimes i get this error on travertine the newest version and sometimes it doesn't happen

https://pastebin.com/bZbayZ1Y

[buoyant shore]

Alexre

[PaperMC/Waterfall] New comment on issue #470: Greload command not working correctly

I have to reopen this, I'm actually testing the latest version of bungeecord, and after changing the server ip and doing greload, I can access to the new one, this does not happen with waterfall.

Alexre

[PaperMC/Waterfall] Issue reopened: #470 Greload command not working correctly

Alexre

[PaperMC/Waterfall] New comment on issue #470: Greload command not working correctly

I have to reopen this, I'm actually testing the latest version of bungeecord, and after changing the server ip and doing greload, I can access to the new one, this does not happen with waterfall.

[buoyant shore]

iDhoom

[PaperMC/Waterfall] Fork created: iDhoom/Waterfall

[buoyant shore]

SrLeojaco

[PaperMC/Waterfall] New comment on issue #470: Greload command not working correctly

Confirm

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

e10d558 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

3592041 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

letlaboy

[PaperMC/Waterfall] Issue opened: #475 Force default server

When the force default server option is marked as true, waterfall only shows the players connected to the lobby, when a player leaves the lobby for another specific server the ping and the value of their connection is not displayed, thus, if there are 100 players on the rankup server and 1 in the lobby on the server motd still in the multiplayer tab of the user's laucher will mark the total of 1 player connected to the server, while there are 101 players in total. when deactivating the fo...

letlaboy

[PaperMC/Waterfall] New comment on issue #475: Force default server

When the force default server option is marked as true, waterfall only shows the players connected to the lobby, when a player leaves the lobby for another specific server the ping and the value of their connection is not displayed, thus, if there are 100 players on the rankup server and 1 in the lobby on the server motd still in the multiplayer tab of the user's laucher will mark the total of 1 player connected to the server, while there are 101 players in total. when deactivating the fo...

[buoyant shore]

owlnull

[PaperMC/Waterfall] New star added

[buoyant shore]

luanmenglei

[PaperMC/Travertine] Issue opened: #123 io\.netty\.channel\.unix\.Errors$NativeIoException

I'm using centos 7
jdk8
And my Travertine worked my perfectly on the win server 2019
But when I change to the Linux.
Every time a player changes the server, it has a chance there will be a io.netty.channel.unix.Errors$NativeIoException

electronicboy

[PaperMC/Travertine] New comment on issue #123: io\.netty\.channel\.unix\.Errors$NativeIoException

io.netty.channel.unix.Errors$NativeIoException occurs when a network I/O issue occurs outside of our control

electronicboy

[PaperMC/Travertine] Issue closed: #123 io\.netty\.channel\.unix\.Errors$NativeIoException

[buoyant shore]

metrotyranno

[PaperMC/Waterfall] Issue opened: #476 \[Enhancement\] Native libs Windows

Hi, Running without native libs on windows causes quite poor performance. Would it be possible to get native compression and cipher libs in windows?

[buoyant shore]

xxDark

[PaperMC/Waterfall] New comment on issue #476: \[Enhancement\] Native libs Windows

Update your JRE to the version at least 11 and ask Waterfall developers to use new Inflater/Deflater methods that accept java.nio.ByteBuffer if they are available.

[buoyant shore]

ohlookitsderpy

[PaperMC/Waterfall] New star added

[buoyant shore]

MinecraftKiwi

[PaperMC/Waterfall] Fork created: MinecraftKiwi/Waterfall

[buoyant shore]

c0wg0d

[PaperMC/Waterfall] Issue opened: #477 How do you change the text that is displayed after using the /send command?

In a recent build there is a ton of text after issuing the /send command. How do we get rid of all this so it just says "Sent to "?

[buoyant shore]

electroplankton

[PaperMC/Waterfall] Fork created: electroplankton/Waterfall

[buoyant shore]

DaAwesomeP

[PaperMC/Waterfall] Issue opened: #478 HTTP proxy not honored for all requests

I am unsure if this is an issue with vanilla or Waterfall or it is easily patched. The server is running behind a firewall that requires all requests go through an HTTP proxy. I added the following Java flags:

-Dhttp.proxyHost=my.proxy.com -Dhttp.proxyPort=3128 -Dhttps.proxyHost=my.proxy.com -Dhttps.proxyPort=3128 -Dhttp.nonProxyHosts="localhost|127.*|[::1]"

Some HTTP requests are honored through the firewall and others are not (many from plugins doing version checks). I assume th...

aikar

[PaperMC/Waterfall] New comment on issue #478: HTTP proxy not honored for all requests

Have you tried with a SOCKS5 Proxy? socksProxyHost? Should be a bit more reliable. Not sure other wise.

DaAwesomeP

[PaperMC/Waterfall] New comment on issue #478: HTTP proxy not honored for all requests

This is an enterprise environment where unfortunately only the HTTP proxy is available. I could adapt the HTTP proxy to a SOCKS proxy locally, but that is not very direct, so I would like to avoid that if possible.

electronicboy

[PaperMC/Waterfall] New comment on issue #478: HTTP proxy not honored for all requests

This is down to netty, bungee, and by extension waterfall, don't appear to
actually handle proxies in the connection to mojangs auth servers

On Thu, 9 Apr 2020, 03:21 Perry Naseck, [e-mail] wrote:

This is an enterprise environment where unfortunately only the HTTP proxy
is available. I could adapt the HTTP proxy to a SOCKS proxy locally, but
that is not very direct, so I would like to avoid that if possible.

—
You are receiving this because you are subscribed t...

[buoyant shore]

DaAwesomeP

[PaperMC/Waterfall] New comment on issue #478: HTTP proxy not honored for all requests

OK, I just tried using socksify (from Dante package) to no avail. It basically routes all traffic of the program run in it through a proxy. Worked for all the programs I could try it with except Java.

[buoyant shore]

DaAwesomeP

[PaperMC/Waterfall] New comment on issue #478: HTTP proxy not honored for all requests

OK, we found a workaround, and its a bit ugly, but it works. We made a custom patch and changed sessionserver.mojang.com to a local server. That server is a reverse proxy that uses the upstream outgoing proxy. It seems to work fine and does not create any security risks.

Proxychains, socksify, and a transparent proxy with iptables all failed for various reasons. Notably that this is a CloudFront CDN address with a shifting IP, and Java would always resolve the IP _before accessing/forwar...

[buoyant shore]

jbdman

[PaperMC/Waterfall] New comment on issue #461: disable\_entity\_metadata\_rewrite causes other players to become invisible

Just tested this issue again today. Latest Waterfall, default settings (except rewrite metadata), with Stoneblock 2 {Forge 14.23.5.2846}. I can confirm the issue is still present.

[buoyant shore]

Time6628

[PaperMC/Waterfall] Issue opened: #479 InitialHandler race condition

I've been getting a similar issue to this old one from BungeeCord since one of the recent updates of Waterfall. Easy way to test it is to switch networks via a vpn or other means while connected to a proxy, that seems to break it until you restart your game.

https://github.com/SpigotMC/BungeeCord/issues/2371

[buoyant shore]

Harleyoc1

[PaperMC/Waterfall] Fork created: Harleyoc1/Waterfall

[buoyant shore]

DarkPlugginer

[PaperMC/Waterfall] Fork created: DarkPlugginer/Waterfall

[buoyant shore]

Matrixchung

[PaperMC/Waterfall] New star added

[buoyant shore]

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Thank you very much for this cause now i can have 1.16 snapshot support with vanillacord hope it works

[buoyant shore]

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Confimation it works with vanillacord and viaversion thanks you very much @Xernium

[buoyant shore]

Struow

[PaperMC/Waterfall] New star added

Struow

[PaperMC/Travertine] New star added

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

I should mention that for now you can find builds of this fork at https://jenkins.krusic22.com/job/Travertine-Xernium/ (kindly provided by @krusic22)

[buoyant shore]

ch515

[PaperMC/Waterfall] New star added

[buoyant shore]

LightMute

[PaperMC/Waterfall] New star added

[buoyant shore]

dobrac

[PaperMC/Waterfall] Issue opened: #480 ServerConnectedEvent is called on disconnect

The ServerConnectedEvent event is called when player is disconnecting from the proxy and it throws and exception to the console with "No client connected for pending server!".

Waterfall version: build 327

It is not happening in the upstream.

[buoyant shore]

tsao-chi

[PaperMC/Travertine] New star added

[buoyant shore]

sevi-kun

[PaperMC/Waterfall] New star added

[buoyant shore]

Issvn

[PaperMC/Waterfall] Fork created: Issvn/Waterfall

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

I should add that I'm only tracking all snapshots so far because of accuracy reasons. The unused or obsolete ones can be flattened out rather easily and I will do so before release

Melacraft

[PaperMC/Waterfall] New comment on issue #48: Exception in thread "main": NullPointerException

I also get the same error:
[21:21:56 ERROR]: Exception in thread "main" java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to java.util.Collection
[21:21:56 ERROR]: at net.md_5.bungee.conf.YamlConfig.getListeners(YamlConfig.java:245)
[21:21:56 ERROR]: at net.md_5.bungee.conf.Configuration.load(Configuration.java:92)
[21:21:56 ERROR]: at io.github.waterfallmc.waterfall.conf.WaterfallConfiguration.load(WaterfallConfiguration.java:49)
[21:21:56 ERROR]: at net.md_5.bungee.B...

mikroskeem

[PaperMC/Waterfall] New comment on issue #48: Exception in thread "main": NullPointerException

This issue is like... almost 5 years old. Please open a new one instead of necrobumping irrelevant old ones.

Melacraft

[PaperMC/Waterfall] New comment on issue #48: Exception in thread "main": NullPointerException

21:36:53 [SEVERE] Exception in thread "main"
21:36:53 [SEVERE] java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to java.util.Collection
21:36:53 [SEVERE] at net.md_5.bungee.conf.YamlConfig.getListeners(YamlConfig.java:234)
21:36:53 [SEVERE] at net.md_5.bungee.conf.Configuration.load(Configuration.java:87)
21:36:53 [SEVERE] at net.md_5.bungee.BungeeCord.start(BungeeCord.java:282)
21:36:53 [SEVERE] at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:113)
...

failex234

[PaperMC/Waterfall] New star added

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #48: Exception in thread "main": NullPointerException

Please open a new one instead of necrobumping irrelevant old ones.

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #48: Exception in thread "main": NullPointerException

Not a waterfall issue, your configuration is invalid

[buoyant shore]

tsao-chi

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

This won't make @electronicboy s life a little easier, but this maybe make @md-5 s life a little easier

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@tsao-chi I doubt it; last time @electronicboy hacked together a working bungeecord well ahead of time md-5 was ready with it on his side

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

That said; I am open to it. I’ll PR my changes th BungeeCord and see what he has to say;

[buoyant shore]

astei

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@Xernium You'll get the cold shoulder, with him saying that "updates are handled internally" and your PR will be closed. I didn't need to open a PR to demonstrate this - there are several examples of this.

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@astei I wasn’t gonna PR to experience that, I know very well what the outcome would be sadly

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

That said who cares in the end- I’ll open my PR and get shut down. I knew that that’s gonna happen from the moment I sent that message. But at least I tried them

[buoyant shore]

SomaSomYT

[PaperMC/Waterfall] Fork created: SomaSomYT/Waterfall

[buoyant shore]

alexandregv

[PaperMC/Travertine] New star added

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Update: Well I got my answer in IRC and I’ll leave it at that. I won’t attempt to contribute to bungeecord directly again. But oh well at least I showed good faith ¯_(ツ)_/¯

[buoyant shore]

krusic22

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

You could move the PR to Travertine, as that got 1.15 support before upstream.

astei

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

...this is literally a Travertine PR.

krusic22

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Thanks for reminding me.

[buoyant shore]

jcrienen

[PaperMC/Waterfall] Fork created: jcrienen/Waterfall

[buoyant shore]

hcbt

[PaperMC/Waterfall] New star added

[buoyant shore]

PhanaticD

[PaperMC/Waterfall] Issue opened: #481 issue with dns resolving

so today mojang session servers been shit, and I assume they updated them a bit ago because the IP changed. However bungee is not updating the resolved IP, as you can see it is different when I use the "host" command, vs what it shows in console for players unable to join

greload does fix it, also probably relevant I do have use netty dns enabled

> host sessionserver.mojang.com sessionserver.mojang.com has address 99.84.223.181

`[17:08:13 ERROR]: Error authenticating A21 with mine...

[buoyant shore]

TNTUP

[PaperMC/Waterfall] New comment on issue #481: issue with dns resolving

Unrelated, thats why my console client/magic launcher throwing me invalid session. Darnit Mojang, they always screw up things :/

[buoyant shore]

aikar

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

I would rather be PR'd to Waterfall. Not all of us use Travertine.

Then Travertine will get it from WF.

[buoyant shore]

Nothingness-Void

[PaperMC/Waterfall] Issue opened: #482 Some functions of MOD will be invalid

AcademyCraft‘s item Data Terminal will not work properly

When I use BungeCord to connect to the mod server
AcademyCraft Unable to detect data terminal
But when I connect directly to the mod server data terminal proper functioning
This problem also appeared in ShinColle

[buoyant shore]

RoottheAdmin

[PaperMC/Waterfall] Fork created: RoottheAdmin/Waterfall

[buoyant shore]

luanmenglei

[PaperMC/Waterfall] Issue opened: #483 Player could not connect to the server

The error is simply io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use

It happens in when I use ProxiedPlayer.connect to send the player to another server,

It usually takes about 10-30 tries before they actually get in.

I'm using
java:
Java(TM) SE Runtime Environment (build 1.8.0_251-b08)
Java HotSpot(TM) 64-Bit Server VM (build 25.251-b08, mixed mode)
os:
CentOS Linux release 7.7.1908 (Core)
Linux localhost.localdomain 3.10.0-1062.el7.x86_6...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #483: Player could not connect to the server

io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use
That is not a waterfall issue, something somewhere tried to use an address that is already in use.

electronicboy

[PaperMC/Waterfall] Issue closed: #483 Player could not connect to the server

[buoyant shore]

luanmenglei

[PaperMC/Waterfall] New comment on issue #483: Player could not connect to the server

So what should I check from

[buoyant shore]

KernelFreeze

[PaperMC/Travertine] New star added

[buoyant shore]

mnjg123

[PaperMC/Waterfall] Issue opened: #484 LoginEvent bypassed

If I repeatedly join my Server I after some time get on the Server eventhough I get cancelled the first time, I get on the server after 2-4 times repeatedly joining. My LoginEvent checks if the Player is banned, and then disallows him.

[buoyant shore]

Managuchi

[PaperMC/Waterfall] Fork created: Managuchi/Waterfall

xxDark

[PaperMC/Waterfall] New comment on issue #484: LoginEvent bypassed

See how AsyncEvent works.

[buoyant shore]

Kr4ken-9

[PaperMC/Waterfall] New star added

[buoyant shore]

RoseStudio

[PaperMC/Waterfall] Fork created: RoseStudio/Waterfall

Timeox2k

[PaperMC/Waterfall] Fork created: Timeox2k/Waterfall

Timeox2k

[PaperMC/Travertine] Fork created: Timeox2k/Travertine

[buoyant shore]

Shazyy

[PaperMC/Waterfall] Issue opened: #485 Java 11 Breaks The Server

Hello,
Recently I was experimenting with Java 11 and I found out that with this version waterfall will turn on, however, no one will be able to join.
It results this error when a user joins:
java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty

Thanks.

electronicboy

[PaperMC/Waterfall] New comment on issue #485: Java 11 Breaks The Server

This is not an issue with waterfall, your certificate store is busted and missing certificates, I'd suggest reinstalling java

electronicboy

[PaperMC/Waterfall] Issue closed: #485 Java 11 Breaks The Server

[buoyant shore]

swaro32

[PaperMC/Travertine] Fork created: swaro32/Travertine

[buoyant shore]

AlexProgrammerDE

[PaperMC/Waterfall] Issue opened: #486 Authentification error

I don't now if this is something to worry about. Maybe is this something on Mojangs side. It was able to log in after the third time.
Here is my log:

[13:14:06 ERROR]: Error authenticating Pistonmaster with minecraft.net
io.netty.resolver.dns.DnsResolveContext$SearchDomainUnknownHostException: Search domain query failed. Original hostname: 'sessionserver.mojang.com' failed to resolve 'sessionserver.mojang.com' after 2 queries
        at io.netty.resolver.dns.DnsResolveContext.finishR...

electronicboy

[PaperMC/Waterfall] New comment on issue #486: Authentification error

Your DNS server timed out

electronicboy

[PaperMC/Waterfall] Issue closed: #486 Authentification error

AlexProgrammerDE

[PaperMC/Waterfall] New comment on issue #486: Authentification error

@electronicboy is there anything i can do to prevent this?

electronicboy

[PaperMC/Waterfall] New comment on issue #482: Some functions of MOD will be invalid

There is an option in waterfall.yml to disable entity metadata rewriting, I would suggest trying that

electronicboy

[PaperMC/Waterfall] New comment on issue #486: Authentification error

You'd need to work out why it timed out, you could disable nettys DNS resolver in waterfall.yml to rely on java/the OSes stack, might offer better caching or something if this occurs often

AlexProgrammerDE

[PaperMC/Waterfall] New comment on issue #486: Authentification error

@electronicboy thanks. I will try this if it occurs multiple times. 👍

Nothingness-Void

[PaperMC/Waterfall] New comment on issue #482: Some functions of MOD will be invalid

THX I will try it

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

3e8cd22 [README] Bump lombok maven plugin, java 11 prep - electronicboy

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

6d51b11 Set aggregate javadoc source to java 8 - electronicboy

[buoyant shore]

RimaitosLab

[PaperMC/Waterfall] Issue opened: #487 Commands don't work when building from sources

I tried to create a Docker image for a waterfall server. I wrote the following Dockerfile which clones the repository and executes waterfall b. Then I copy the waterfall.jar and delete all other files.

The server start fine and also connects to the default server. But I can not execute any commands related to waterfall/bungeecord (e.g. /server, /servers, /glist, /alert). The logs also show nothing interesting, only a plain command now found when executed from the console.

Dockerfile:
`...

electronicboy

[PaperMC/Waterfall] New comment on issue #487: Commands don't work when building from sources

The commands are implemented in the modules, not inside the proxy itself; You'll need to copy them over

electronicboy

[PaperMC/Waterfall] Issue closed: #487 Commands don't work when building from sources

RimaitosLab

[PaperMC/Waterfall] New comment on issue #487: Commands don't work when building from sources

Wow that was a fast Answer, Thank you!

[buoyant shore]

ByteCompiler

[PaperMC/Travertine] Issue opened: #124 Minecraft Message Protocol Text Json Format Byte Code

I want write bukkit multi version from 0, i want analyze int byte to int byte;to create a server 100% autonomous and free of bugs that occur in community edition;

I would like help to establish the tools for the message protocols;what are those "??" in the message data? what tools can i use to read?

is it possible to communicate with the minecraft protocol through json code texts like i saw on some nodejs and wikis servers or do i have to test all int bytes ?

![image](https://user-im...

electronicboy

[PaperMC/Travertine] New comment on issue #124: Minecraft Message Protocol Text Json Format Byte Code

This is an issue tracker, not a call for assistance with unrelated... whatever the heck you're doing...
There is well-established documentation of the protocol on wiki.vg

electronicboy

[PaperMC/Travertine] Issue closed: #124 Minecraft Message Protocol Text Json Format Byte Code

ByteCompiler

[PaperMC/Travertine] Issue opened: #125 Travertine Add 1\.5\.2 1\.4\.7 Version like ProtocolSupport

I would like to edit the travertine myself; but i don't know how to start and the real github code looks incomplete from both the bungeecord, waterfall and travertine;

Could you provide me with the code you work with?

My JD GUi decompiles everything wrong and I have to fix it manually; does it have a decompiler that does not have to work manually to correct the decompilation errors?

To downgrade to 1.5 to test for errors I just need to copy the same structure as 1.7?

Minecraft wor...

electronicboy

[PaperMC/Travertine] New comment on issue #125: Travertine Add 1\.5\.2 1\.4\.7 Version like ProtocolSupport

compile as per the readme, you'll then have the source

electronicboy

[PaperMC/Travertine] Issue closed: #125 Travertine Add 1\.5\.2 1\.4\.7 Version like ProtocolSupport

ByteCompiler

[PaperMC/Travertine] New comment on issue #124: Minecraft Message Protocol Text Json Format Byte Code

when i unzip using zlib i will get a json text protocol format?

electronicboy

[PaperMC/Travertine] New comment on issue #124: Minecraft Message Protocol Text Json Format Byte Code

No. read the protocol docs.

ByteCompiler

[PaperMC/Travertine] Issue opened: #126 mc message protocol

I read wiki docs protocol, I can think of infinite meanings, I don't know which of the meanings is real because I haven't yet lived the reality in which I transformed it into something different than what they are;

ByteCompiler

[PaperMC/Travertine] New comment on issue #126: mc message protocol

Before creating a public repository, learn basic quantum physics;

ByteCompiler

[PaperMC/Travertine] New comment on issue #126: mc message protocol

You don't even know the learning algorithm in your mind, you say things with such conviction that you can't help anyone;

ByteCompiler

[PaperMC/Travertine] New comment on issue #126: mc message protocol

If you want to create one comunnity project you must learn how to converse with people using their language, unlike you will only be a limited light spot;

zachbr

[PaperMC/Travertine] New comment on issue #126: mc message protocol

We can't offer you the help you need.

zachbr

[PaperMC/Travertine] Issue closed: #126 mc message protocol

[buoyant shore]

theminecoder

[PaperMC/Waterfall] Fork created: theminecoder/Waterfall

[buoyant shore]

theminecoder

[PaperMC/Waterfall] Pull request opened: #488 Add exception reporting event

Since bungeecord has gone and made the plugin manager a final class (which is a good thing in some regards) there is no way to wrap around it to handle exception catching for commands and events.

This patch copies over the exception event (and corresponding exception classes) that exists in paper today and implements it in the places around the proxy codebase that should fire the event.

Couple of notes:

• Bungee's EventBus registration doesn't ever store a reference to the plugin that ...

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

We need something that prevents stackoverflow: if an error happens during event handling of any event and if there is a faulty plugin always throwing in ProxyExceptionEvent this creates unneccessary long console output and cpu usage. This could be achieved by having a separate, private callEvent method which requires a ProxyExceptionEvent and which gives the eventbus an empty exception handler.

[buoyant shore]

mnjg123

[PaperMC/Waterfall] New comment on issue #484: LoginEvent bypassed

I am dumb

mnjg123

[PaperMC/Waterfall] Issue closed: #484 LoginEvent bypassed

[buoyant shore]

astei

[PaperMC/Waterfall] Fork created: astei/Waterfall

astei

[PaperMC/Waterfall] Pull request opened: #489 Bump Netty to 4\.1\.49\.Final

This issue includes the fix for netty/netty#10165, also known as "bungeecrasher" or "bungeespammer" amongst other names.

theminecoder

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

We need something that prevents stackoverflow: if an error happens during event handling of any event and if there is a faulty plugin always throwing in ProxyExceptionEvent this creates unneccessary long console output and cpu usage.

This could be achieved by having a separate, private callExceptionEvent method which requires a ProxyExceptionEvent and which gives the eventbus an empty exception handler and which is called instead of callEvent for ProxyExceptionEvents.

There is a...

electronicboy

[PaperMC/Waterfall] Pull request closed: #489 Bump Netty to 4\.1\.49\.Final

electronicboy

[Waterfall:master] 1 new commit

d5adc93 Bump Netty to 4.1.49.Final (#489) - astei

[buoyant shore]

electronicboy

[Travertine:master] 1 new commit

f4b52fa Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

tomcraft

[PaperMC/Waterfall] Fork created: tomcraft/Waterfall

[buoyant shore]

tomcraft

[PaperMC/Waterfall] Pull request opened: #490 Use configured timeout value in UserConnection\#connect

[buoyant shore]

TychoWerner

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Does this need changes when 20w18a comes out or whatever version for that matter or will the previous version still work?

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@TychoWerner Since the snapshots are a highly dynamic element; Yes of course it will change. That’s what this pull request is for. If someone had to do one thing to make all future snapshots work then we wouldn’t be here atm. We can’t exactly predict what Mojang will do to that level. So yes there are gonna be updates and yes stuff is going to break (most likely)

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Side note; I will move this to Waterfall during the coming weekend as per @aikar s suggestion

JRoy

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@aikar Waterfall has never supported pre-release protocols. The pre-release protocols have always been done in Travertine (dbe27f380f23a37386615e317cc1e5a78a65e636, 32c100ed0360addab7421554ee81c86a018e27e1, ac8e757b85208996874605ed305cfdad12d6c3fd). @Xernium for that reason I say keep this here unless aikar or some other member of the paper team replies.

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@JRoy It’d help if you scrolled up in the conversation a bit ;)

[buoyant shore]

TychoWerner

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@TychoWerner Since the snapshots are a highly dynamic element; Yes of course it will change. That’s what this pull request is for. If someone had to do one thing to make all future snapshots work then we wouldn’t be here atm. We can’t exactly predict what Mojang will do to that level. So yes there are gonna be updates and yes stuff is going to break (most likely)

Thanks for your reply. I was looking at your latest commit (https://github.com/PaperMC/Travertine/pull/120/commits/6af17c8eb97...

[buoyant shore]

SuperSandro2000

[PaperMC/Waterfall] New star added

[buoyant shore]

Monsupito

[PaperMC/Travertine] Fork created: Monsupito/Travertine

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #490 Use configured timeout value in UserConnection\#connect

electronicboy

[PaperMC/Waterfall] Pull request closed: #490 Use configured timeout value in UserConnection\#connect

electronicboy

[Waterfall:master] 1 new commit

351a94d Use configured timeout value in UserConnection#... - tomcraft

[buoyant shore]

ReadyFoxy

[PaperMC/Waterfall] New star added

[buoyant shore]

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@Xernium i got an issue with players being disconnected and it says that they where sent too an fallback server while the serverthey were on didn't go down i am using the last buid as of this moment and have viaversion on my proxy along with someother plugins that shoudn't affect this. hope you can help with this. it's only with 1.16

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

am atm looking if this is an 1.16 viaversion issue by moving them too the servers intead of the proxy itself cause had more problems with viaversion though it shoudn't interfere with this

[buoyant shore]

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@TheCompieter I don’t test with ViaVersion especially since it wasn’t updated yet when I pushed this update. It worked on a vanilla snapshot server. I’ll investigate into it.

[buoyant shore]

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

thanks if you need any more specific information say so.

[buoyant shore]

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

also when throwing out an fishing line it doesn't show the line or dobber but does in single player and this is without viaversion and with viaversion.

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@TheCompieter The fishing issue might be due to an entity rewriter being broken. I'll have to look at it. Also I can't reproduce your issue. I tried it with a network that has a 1.15.2 paper server with ViaVersion and a Vanillacord 20w17a server. Is there a specific trigger to the issue?

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Side note; a productive conversation here using comments isn't going to be easy. If you use Discord please @ me on the ViaVersion or on the PaperMC Discord server, that could speed this up a lot

[buoyant shore]

TheCompieter

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

@TheCompieter The fishing issue might be due to an entity rewriter being broken. I'll have to look at it. Also I can't reproduce your issue. I tried it with a network that has a 1.15.2 paper server with ViaVersion and a Vanillacord 20w17a server. Is there a specific trigger to the issue?

No it's random and no error as far as i know i am now just using it without viaversion and if it still happens i will let you know.

Side note; a productive conversation here using co...

[buoyant shore]

Rivest8

[PaperMC/Waterfall] New star added

[buoyant shore]

Roboticluke51

[PaperMC/Waterfall] Issue opened: #491 Waterfall refuses to connect to my spongeforge server

So i have a WaterFall server hosted on 1.15.2 that has a hub and then a flans server. On the flans server i have setup spongeforge and its corresponding settings in order for it to work with waterfall. But for some reason my WaterFall server refuses to connect me to my flans server.

here is what my WaterFall server says:

and here is what my flans server sees:
![unknown](https://user-images.githubusercontent.com/26510945/80270840-674d9280-8689-11ea-...

[buoyant shore]

Xernium

[PaperMC/Waterfall] New comment on issue #491: Waterfall refuses to connect to my spongeforge server

@Roboticluke51 May I chime in here; Bungeecord does something called data rewriting in which data that the server sends to the client or vice-versa is read and verified so the the partner don’t have to suffer if one sends it maliciously modified or invalid data. Your mod setup seems to break or interfere how the vanilla game talks to the server and thus you will get kicked. There are two options to resolve this; Either have the mod authors fix how the mod that causes this behaves; or modify W...

Roboticluke51

[PaperMC/Waterfall] New comment on issue #491: Waterfall refuses to connect to my spongeforge server

@Roboticluke51 May I chime in here; Bungeecord does something called data rewriting in which data that the server sends to the client or vice-versa is read and verified so the the partner don’t have to suffer if one sends it maliciously modified or invalid data. Your mod setup seems to break or interfere how the vanilla game talks to the server and thus you will get kicked. There are two options to resolve this; Either have the mod authors fix how the mod that causes this behaves; or modify...

Roboticluke51

[PaperMC/Waterfall] Issue closed: #491 Waterfall refuses to connect to my spongeforge server

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #491: Waterfall refuses to connect to my spongeforge server

Waterfall already has a patch to disable the mechanism behind this in waterfall.yml

The fact that you're saying it's a 1.12 server but the 1.15 entity remapping logic is in play is sketchy as all heck, some oddball protocol hack in play? o.O

[buoyant shore]

4Cris

[PaperMC/Waterfall] Issue opened: #492 Players have high ping but no errors in the logs

After 3 hours uptime the pings of the players are going crazy with 40-50 players connected

[buoyant shore]

MadBlockNetwork

[PaperMC/Waterfall] Fork created: MadBlockNetwork/Waterfall

[buoyant shore]

iBuyMountainDew

[PaperMC/Waterfall] New star added

[buoyant shore]

hypnosophy

[PaperMC/Waterfall] New star added

[buoyant shore]

hurrgurl

[PaperMC/Waterfall] Issue opened: #493 Waterfall kicks everyone

What's happening there?

EncoderException : java.lang.NullPointerException @ io.netty.handler.codec.MessageToByteEncoder:125
io.netty.handler.codec.EncoderException: java.lang.NullPointerException
	at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.15-SNAPSHOT:e45fb1f:340]
	at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717) ~[BungeeCord.jar:git:Waterfall-Bo...

Janmm14

[PaperMC/Waterfall] New comment on issue #493: Waterfall kicks everyone

Please search your log for a full stack trace. This one is not complete, it is missing "at" lines after "Caused by". Stack trace shortening happens when an exception is thorwn thousands of times to improve performance.

hurrgurl

[PaperMC/Waterfall] New comment on issue #493: Waterfall kicks everyone

io.netty.handler.codec.EncoderException: java.lang.NullPointerException
	at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.15-SNAPSHOT:e45fb1f:340]
	at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717) ~[BungeeCord.jar:git:Waterfall-Bootstrap:1.15-SNAPSHOT:e45fb1f:340]
	at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandle...

electronicboy

[PaperMC/Waterfall] New comment on issue #493: Waterfall kicks everyone

something on your proxy tried to send a mangled set of properties in the player list packet

electronicboy

[PaperMC/Waterfall] Issue closed: #493 Waterfall kicks everyone

[buoyant shore]

MaximeMichaud

[PaperMC/Travertine] New star added

[buoyant shore]

Xernium

[PaperMC/Waterfall] Fork created: Xernium/Waterfall

[buoyant shore]

Xernium

[PaperMC/Waterfall] Pull request opened: #494 \[Future\] 1\.16 Patch/changes

This Pull-request is meant to be merge-ready when 1.16 gets released so a usable Bungeecord can be obtained ASAP. The changes in this PR will get lost when Bungeecord gets updated to support 1.16, that is intentional. This is just meant to maybe make @electronicboy s life a little easier ;).

You can view the original Pull-request here.

I still maintain the Travertine fork just so I can backtrack on the changes, but this imp...

Xernium

[PaperMC/Travertine] New comment on pull request #120: \[Future\] Tracking 1\.16 changes

Branch will be reworked in favour of https://github.com/PaperMC/Waterfall/pull/494

Xernium

[PaperMC/Travertine] Pull request closed: #120 \[Future\] Tracking 1\.16 changes

[buoyant shore]

electronicboy

[Waterfall:master] 1 new commit

a469ee5 Updated Upstream (BungeeCord) - electronicboy

electronicboy

[Travertine:master] 1 new commit

11a06a6 Updated Upstream (Waterfall) - electronicboy

[buoyant shore]

lhridder

[PaperMC/Travertine] New star added

[buoyant shore]

Mr5ecret

[PaperMC/Waterfall] Issue opened: #495 Help\!

i have problem with waterfall can somebody help me!

.... [11:49:04 ERROR]: [/149.202.74.183:49608] InitialHandler - encountered exception: net.md_5.bungee.util.QuietException: Unexpected packet received during login process! 6e6f9828dc248ca11153eb922a60c5ef

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #495: Help\!

someone sent invalid data, usually this can be ignored completely

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Issue closed: #495 Help\!

[buoyant shore]

electronicboy

[PaperMC/Travertine] branch deleted: unsupported

electronicboy

[PaperMC/Waterfall] branch deleted: pending\-upstream

[buoyant shore]

LambArchie

[PaperMC/Waterfall] New star added

[buoyant shore]

IceCruelStuff

[PaperMC/Travertine] Fork created: IceCruelStuff/Travertine

[buoyant shore]

kotsh

[PaperMC/Waterfall] New star added

[buoyant shore]

locness3

[PaperMC/Waterfall] New star added

[buoyant shore]

GiansCode

[PaperMC/Waterfall] Issue opened: #496 Team x already exists in this scoreboard

We're running a multi proxy setup, and, today, out of the blue, the following issue started occurring on our SkyBlock servers, and we're not exactly sure how to deal with it.

Steps we've taken, in order, have been

• Stopping the server(s)
• Deleting the "scoreboard.dat" file from the main world on all server(s)
• Restarting the server(s)
• Manually removing the team(s) causing issues (they come back quick)
• Temporarily removing Scoreboard, and ...

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #496: Team x already exists in this scoreboard

Which plugins do you use on your servers?
Can you modify them easily so no server has identical internal scoreboard names?

GiansCode

[PaperMC/Waterfall] New comment on issue #496: Team x already exists in this scoreboard

We use FeatherBoard as the main scoreboard, but, other plugins like NametagEdit, and LibsDisguises also modify/create boards

I could look into renaming them. But, it's just weird how it came out of nowhere

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #496: Team x already exists in this scoreboard

duplicate of #318

electronicboy

[PaperMC/Waterfall] Issue closed: #496 Team x already exists in this scoreboard

[buoyant shore]

GogumeNetwork

[PaperMC/Waterfall] Fork created: GogumeNetwork/Waterfall

[buoyant shore]

UnioDex

[PaperMC/Waterfall] Fork created: UnioDex/Waterfall

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

I was the one who made the PluginManager final. This was intentional to stop people from modifying it at runtime. Also I don't find a usecase about your pr; exceptions occurring in event handling or command handling should be handled there. A direct example is enforcing an specific argument type for command:

public void execute(CommandSender sender, String[] args) {
   // ...
  try {
      Integer.parseInt(args[0]);
  } catch (NumberFormatException e) {
      sender.sendMessa...

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #488 Add exception reporting event

Looks fine, only real thing is the waterfall comments, they should annotate the set of changes, I'd suggest glancing over the paper contribution guide if you haven't

[buoyant shore]

Louuuwh

[PaperMC/Waterfall] Issue opened: #497 Permissions don't work well

I put the permission "bungeecoord.command.server" as well as the command "bungeecoord.command.glist" via the configuration file.

I did this because a player could not connect via the "server" command even though I had given him permission with LuckPerms.

Unfortunately, it still does not work.
Is it likely that waterfall is involved?

[buoyant shore]

electronicboy

[PaperMC/Waterfall] New comment on issue #497: Permissions don't work well

permission plugins generally override the built-in permissions entirely

electronicboy

[PaperMC/Waterfall] Issue closed: #497 Permissions don't work well

[buoyant shore]

Brokkonaut

[PaperMC/Waterfall] Issue opened: #498 IllegalStateException: Adding 1 elements would exceed capacity of 128

Today I got kicked by my Waterfall and got the following exception in the log:
https://pastebin.com/raw/Dgd1dx5Y
It happended during switching worlds on a server (but not switching servers)

I did have a look in the waterfall logs and during the last days several players got kicked with this exception. Any ideas why that happens and what I can do to prevent this?

[buoyant shore]

Janmm14

[PaperMC/Waterfall] New comment on issue #498: IllegalStateException: Adding 1 elements would exceed capacity of 128

This is the limit on plugin messaging channels which can be registered by players.

Brokkonaut

[PaperMC/Waterfall] New comment on issue #498: IllegalStateException: Adding 1 elements would exceed capacity of 128

Is it possible to list those registered channels to see what might cause it?

[buoyant shore]

Artuto

[PaperMC/Waterfall] New comment on issue #498: IllegalStateException: Adding 1 elements would exceed capacity of 128

ProxyServer#getChannels

https://ci.md-5.net/job/BungeeCord/ws/api/target/apidocs/net/md_5/bungee/api/ProxyServer.html#getChannels--

[buoyant shore]

DreamVoid

[PaperMC/Waterfall] Fork created: DreamVoid/Waterfall

[buoyant shore]

xSoukazex

[PaperMC/Waterfall] Fork created: xSoukazex/Waterfall

[buoyant shore]

theminecoder

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

Think I got everything with comments now. Let me know if I missed anything

theminecoder

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

@MrIvanPlays I understand why you made it final. Honestly I think it's a good thing in the long run. However there is a use case to having exceptions being available like this - which is actually what this pr is about.

I make and use a plugin that grabs all of the exceptions from proxies and backend servers and forwards them to sentry so I can proactively keep an eye on issues without having to tail x amount of logs for all the servers that I run. Has been a lifesaver numerous amounts of t...

[buoyant shore]

MrIvanPlays

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

@MrIvanPlays I understand why you made it final. Honestly I think it's a good thing in the long run. However there is a use case to having exceptions being available like this - which is actually what this pr is about.

I make and use a plugin that grabs all of the exceptions from proxies and backend servers and forwards them to sentry so I can proactively keep an eye on issues without having to tail x amount of logs for all the servers that I run. Has been a lifesaver numerous amount...

[buoyant shore]

lucko

[PaperMC/Waterfall] New comment on pull request #488: Add exception reporting event

however I still think that occurring exceptions should be handled in the source (command, event handling) and not to be suppressed in a event.

Nobody is making the argument that they shouldn't?

Exception handling clearly isn't the use-case of the PR. Read the title: "exception reporting".

The exceptions are not being suppressed, they're just being exposed in an event as well as in a call to the proxy logger.

[buoyant shore]

Namiraja

[PaperMC/Waterfall] New star added

[buoyant shore]

CreepyCre

[PaperMC/Waterfall] Fork created: CreepyCre/Waterfall

[buoyant shore]

bromemc

[PaperMC/Waterfall] Fork created: bromemc/Waterfall

[buoyant shore]

DoNotSpamPls

[PaperMC/Waterfall] Fork created: DoNotSpamPls/Waterfall

[buoyant shore]

Galactica-MC

[PaperMC/Waterfall] Fork created: Galactica-MC/Waterfall

[buoyant shore]

ToonBasic

[PaperMC/Travertine] New star added

[buoyant shore]

liweiqi-CN

[PaperMC/Waterfall] New star added

[buoyant shore]

ablad3

[PaperMC/Waterfall] Issue opened: #499 Unknown z\_stream return code : \-3

Latest Waterfall.
No plugins on the Bungee installed

`[11:21:57] [Netty Worker IO Thread #5/INFO]: [Feurixx] disconnected with: DecoderException : net.md_5.bungee.jni.NativeCodeException: Unknown z_stream return code : -3 @ io.netty.handler.codec.MessageToMessageDecoder:98
[11:24:28] [Netty Worker IO Thread #0/INFO]: [Hungerplay] disconnected with: CorruptedFrameException : length wider than 21-bit @ net.md_5.bungee.protocol.Varint21FrameDecoder:53
[11:56:48] [Netty Worker IO Thread #15...

mikroskeem

[PaperMC/Waterfall] New comment on issue #499: Unknown z\_stream return code : \-3

https://www.zlib.net/manual.html#Constants - #define Z_DATA_ERROR (-3)

Brokenly compressed payload. Something mangling the packets?

[buoyant shore]

Sciroccogti

[PaperMC/Waterfall] New star added

[buoyant shore]

electronicboy

[PaperMC/Waterfall] Pull request review submitted: #488 Add exception reporting event

electronicboy

[PaperMC/Waterfall] Pull request closed: #488 Add exception reporting event

electronicboy

[Waterfall:master] 1 new commit

331ebbf Add exception reporting event (#488) - theminecoder