#waterfall-dev | PaperMC | Page 8

jaunty kindle Mar 19, 2020, 6:34 PM

#

and the reason I ask proxy level is because we are using fabric for its server side performance mods

#

so some Citizens setup is not on the table

#

Commissioning to get this coded is on the table, but at the moment I just want to know how possible this is

#

(Fabric does support being under a proxy btw, there's a recent mod that allows this)

bleak current Mar 19, 2020, 6:42 PM

#

post-coalchella people huh?

#

the pit or w.e it was called after that

jaunty kindle Mar 19, 2020, 6:44 PM

#

its called Second Aether

#

its not that group

bleak current Mar 19, 2020, 6:53 PM

#

anyway basically it's possible as long as person who gets the task is able to think and write code

#

of course there aren't premade solutions available

#

everything has to be done from scratch

#

however since you're sitting on fabric then nothing stops you from writing a decent solution - mappings are pretty decent and their toolchain is even better

jaunty kindle Mar 19, 2020, 6:55 PM

#

The best, in order to reduce development time, would be to have as little server modding needed as possible and have most of the work be done proxy level

#

at least thats what I'd assume

#

Of course if a little is required to make the server's behave, thats fine

#

How difficult would it be/about how much would this go for

bleak current Mar 19, 2020, 6:57 PM

#

moving it on proxy level makes things harder

jaunty kindle Mar 19, 2020, 6:57 PM

#

It does?

bleak current Mar 19, 2020, 6:57 PM

#

not significantly but you'd need to start implementing packets on proxy which aren't there already

#

vs you have full blown server already aware of all the packets

jaunty kindle Mar 19, 2020, 6:58 PM

#

wouldn't a player statue that has packets communicated to it through server side have a lot more latency?

lean gobletBOT Mar 19, 2020, 6:58 PM

#

tbh replicating all packets from all server to all players shouldn't be too hard

jaunty kindle Mar 19, 2020, 6:58 PM

#

not all packets, selectively

bleak current Mar 19, 2020, 6:59 PM

#

all movement related, whatever

jaunty kindle Mar 19, 2020, 6:59 PM

#

for a single player

#

not the entire player base

bleak current Mar 19, 2020, 6:59 PM

#

or everything what's needed to turn a player into puppet

#

you get the point

jaunty kindle Mar 19, 2020, 6:59 PM

#

yeah

lean gobletBOT Mar 19, 2020, 6:59 PM

#

oh, wait, I thought you wanted to display the full audience to everyone

#

so you just want to send the dj?

jaunty kindle Mar 19, 2020, 6:59 PM

#

no, that is not necessary (full audience)

#

yes

lean gobletBOT Mar 19, 2020, 7:00 PM

#

I assume you are aware of what Monstercat did once?

jaunty kindle Mar 19, 2020, 7:00 PM

#

Its better if the full audience is not sent, for performance reasons

#

I am not aware of that

lean gobletBOT Mar 19, 2020, 7:00 PM

#

they did basically just that, but it required a modded client

jaunty kindle Mar 19, 2020, 7:00 PM

#

why would it require a modded client

lean gobletBOT Mar 19, 2020, 7:00 PM

#

.g monstercat minecraft concert

#

(phoenix616) https://www.youtube.com/watch?v=S-carLXQfeA -- Monstercat Charity Minecraft Concert -- Day 1 - YouTube: "Jul 13, 2013 ... Buy games for half the price! Check it out here! https://www.g2a.com/r/boomey30 All credit goes to all the monstercat artists! Buy..."

YouTube

boomer

Monstercat Charity Minecraft Concert -- Day 1

Buy games for half the price! Check it out here! https://www.g2a.com/r/boomey30

All credit goes to all the monstercat artists! Buy their music here! http://www.monstercat.com/music

It's crazy to see what is possible in minecraft! Thank you again, monstercat for such a great ...

▶ Play video

#

for effects, music, direct joining. stuff like that

jaunty kindle Mar 19, 2020, 7:01 PM

#

oh fancy lighting

lean gobletBOT Mar 19, 2020, 7:01 PM

#

of course a lot more is doable with the vanilla client nowadays

jaunty kindle Mar 19, 2020, 7:01 PM

#

music will be handled on a website

lean gobletBOT Mar 19, 2020, 7:01 PM

#

eww

#

xD

jaunty kindle Mar 19, 2020, 7:01 PM

#

and the light show will be guardian beams/ender dragon healing beams/beacons

#

probably particles too, but hopefully not too much because post 1.13 clients can't handle that many of those

lean gobletBOT Mar 19, 2020, 7:02 PM

#

my server did a similar show (for one song) once but it was all pre-programmed: https://www.youtube.com/watch?v=Q85AdF8mNAo

YouTube

Moep.tv

Minebench 4. B-Day: "Let It Go"-Show

Show von Spargelbauer7 zum 4. Geburtstag des deutschsprachigen Minecraft-Servers Minebench.de

Homepage: https://minebench.de
MC-Server: s.minebench.de

Song:
Let It Go 'Frozen OST' Club Mix (Tiësto, Allure - Pair Of Dice - GINJO Mash Up)
https://www.youtube.com/watch?v=Xjmrg...

▶ Play video

#

(phoenix616) Minebench 4. B-Day: "Let It Go"-Show - length 3m 51s - 23 likes, 1 dislike (95.8%) - 546 views - Moep.tv on 2015.06.21

jaunty kindle Mar 19, 2020, 7:02 PM

#

this will all be pre-programmed as well

#

except for the artist's movements though that is

bleak current Mar 19, 2020, 7:03 PM

#

anyway i'd implement it like this:

so-called master server has the dj and a mod sends all the needed info over tcp to daemon which should broadcast all required data to slave servers
slave servers connect to the daemon using mod, spawn the player and proceed processing movement etc

jaunty kindle Mar 19, 2020, 7:03 PM

#

all the sets will be pre-recorded

lean gobletBOT Mar 19, 2020, 7:03 PM

#

I'm actually thinking about automatically creating light shows for songs right now (with the goal of doing it in minecraft for now)

#

it's definitly an interesting concept ;D

bleak current Mar 19, 2020, 7:03 PM

#

latency is practically near to zero

jaunty kindle Mar 19, 2020, 7:03 PM

#

the light shows are all hard coded atm, and aren't specialized to the sets afaik

#

phoenix do you agree a server level system like zzikro is proposing would be the best?

lean gobletBOT Mar 19, 2020, 7:05 PM

#

sounds like it should work

bleak current Mar 19, 2020, 7:05 PM

#

that's one possible solution and perhaps the easiest

#

daemon uses widely known pub-sub pattern, O(n) where n=servers count send operation shouldn't be really bad either

jaunty kindle Mar 19, 2020, 7:06 PM

#

(not being rude just trying to get as many eyes/opinions) phoenix do you think it would be easier than doing it on the proxy as well?

bleak current Mar 19, 2020, 7:06 PM

#

yeah understandable, there are always multiple possible solutions :p

lean gobletBOT Mar 19, 2020, 7:06 PM

#

I personally would just replicate the packets on the proxy but ¯_(ツ)_/¯

#

both versions have their benefits I guess

jaunty kindle Mar 19, 2020, 7:07 PM

#

What would be the benefit of proxy level over the server mod?

bleak current Mar 19, 2020, 7:07 PM

#

my vision is that if it's handled separately then you have greater control over spawning the dj

lean gobletBOT Mar 19, 2020, 7:07 PM

#

(e.g. only replicating on the proxy would limit you to a setup where everywhere is connected to one proxy)

#

and the benefit over a server mod would be that you don't need to mod the server xD

jaunty kindle Mar 19, 2020, 7:07 PM

#

The time table we're working with does not allow for that complex of a system

#

I believe we're only using a single proxy

bleak current Mar 19, 2020, 7:08 PM

#

how much do you have time?

jaunty kindle Mar 19, 2020, 7:08 PM

#

The festival is on March 28th/29th

bleak current Mar 19, 2020, 7:08 PM

#

writing such system takes 1-2 days if you include testing, fixing etc

#

most of the time goes into server mod

#

and least into the broadcasting service

#

which is literally pub-sub thingy

jaunty kindle Mar 19, 2020, 7:09 PM

#

They have a dev for the broadcast

bleak current Mar 19, 2020, 7:09 PM

#

damn if someone paid for me for coming up with that idea...

#

:D

#

fuck

jaunty kindle Mar 19, 2020, 7:10 PM

#

again this would be a fabric mod

bleak current Mar 19, 2020, 7:10 PM

#

so?

jaunty kindle Mar 19, 2020, 7:10 PM

#

So they wouldn't be working with a cushy API like bukkit or sponge

bleak current Mar 19, 2020, 7:11 PM

#

it's rather good than bad

jaunty kindle Mar 19, 2020, 7:11 PM

#

Oh cool

sly crown Mar 19, 2020, 7:15 PM

#

advertising 👀

#

gonna ban yall

bleak current Mar 19, 2020, 7:16 PM

#

no u

jaunty kindle Mar 19, 2020, 7:17 PM

#

I asked

#

1.15

deft trail Mar 19, 2020, 7:19 PM

#

waterfall - 1.8 -> 1.15
travertine - 1.7 -> 1.15

jaunty kindle Mar 19, 2020, 7:19 PM

#

what?

#

Phoenix

#

would you be interested in setting this sort of thing up

#

(just trying to know our options, ziikro didn't say no)

#

is there a way to ping an IRC member?

#

(I assume thats what the bot is)

bleak current Mar 19, 2020, 7:23 PM

#

just say their nick

jaunty kindle Mar 19, 2020, 7:23 PM

#

phoenix616

#

( @bleak current like that yeah? )

bleak current Mar 19, 2020, 7:25 PM

#

yes yes

jaunty kindle Mar 19, 2020, 7:25 PM

#

k lol thanks

lean gobletBOT Mar 19, 2020, 7:30 PM

#

feel free to shoot me a pm on spigot or an email directly (contact data is on my website)

jaunty kindle Mar 19, 2020, 7:32 PM

#

Okay

lean gobletBOT Mar 20, 2020, 10:28 PM

#

check if the origin server is null in the switch event

cyan garnet Mar 20, 2020, 10:39 PM

#

I ended up using ServerConnectEvent and checking reason was plugin or command

lean gobletBOT Mar 20, 2020, 10:41 PM

#

wouldn't neither work there though?

#

oh wait, I guess there is a third one or null?

#

well this is how I did it by checking the player server, apparently I used the connect event too: http://git.io/fj0sP

GitHub

Minebench/ServerClusters

Plugin to group multiple servers into clusters for teleporting and warp purposes (no data syncing, Use SyncInv for that!) - Minebench/ServerClusters

cyan garnet Mar 20, 2020, 10:57 PM

#

Yeah, checking if the server is null there works as well 🙂

dusk crescent Mar 22, 2020, 1:50 AM

#

Hey, anyone know how to add a forced host via code? 🙂

bleak current Mar 22, 2020, 2:05 AM

#

you can replicate that logic yourself easily

#

by listening to server switch event

bleak current Mar 22, 2020, 7:40 PM

#

I added bungeecord to gradle. Everything can be found fine but when i try to use BungeeCord import net.md_5.bungee.BungeeCord; it cannnot be found. why?

bleak current Mar 22, 2020, 8:14 PM

#

did you include only api?

#

or what do you mean

bleak current Mar 22, 2020, 10:23 PM

#

got it.

#

Anyone here experienced in gradle?
Like i am making a big core. and yes it already includes tons of code. But why is it already 13MB and putting all those packages & classess inside the jar?
https://i.insanemc.net/4pLVDR8Wi4.gif (used to code with maven. Gradle is new for me)

#

you ran into same issue with maven very likely as well

#

you usually need to exclude dependencies from being included into the fat jar

#

I've never had this issue before.

#

because usually dependencies declare their own dependency scopes wrong

#

or you've configured stuff wrongly

#

https://paste.helpch.at/inuhedanel.cs

#

this is what i have atm in build.gradle

#

tldr triple check your dependency scopes

#

not enough information

#

run gradle dependency:tree

#

sec

cerulean kettle Mar 22, 2020, 11:47 PM

#

Hey, im trying to find a way to get the source and apply patches properly. Im novice at this but i want to help out applying my patches with .patch files.

#

I have been like 2 years trying to figure this out without success.

#

I can't even get the source building with git bash. I don't know what im doing wrong.

#

I had to make a fork by modifying a decompiled source. So messy.

civic valve Mar 22, 2020, 11:50 PM

#

have you uh

#

read the documentation

#

like the contributors doc

cerulean kettle Mar 22, 2020, 11:51 PM

#

where is that?

#

i've never found docs

#

just "clone and compile with..."

civic valve Mar 22, 2020, 11:51 PM

#

it's literally on the github

cerulean kettle Mar 22, 2020, 11:52 PM

#

im new to github sorry

#

where can i find it?

#

I cant see any docs link in the gh page

civic valve Mar 22, 2020, 11:56 PM

#

do you actually know java?

cerulean kettle Mar 22, 2020, 11:57 PM

#

yeah

#

i've never worked with other people

#

or with repos

#

i just started like

#

some months ago

#

with basic maven stuff

#

and like ~1 year ago with java coding

civic valve Mar 22, 2020, 11:58 PM

#

anyways look at the root directory

#

there is a contributing.md file

cerulean kettle Mar 22, 2020, 11:58 PM

#

i was blinded by intellij, i was never able to completelly know how maven worked until i decided to get to vscode and have a raw look to it

#

Oh man

#

Thanks

#

If i knew this 2 years ago...

#

Im so relieved

#

So md files are basically docs right?

bleak current Mar 23, 2020, 12:02 AM

#

@bleak current So i sort of got it. but not fully yet.

So it's now building without the things that was on the screen before.
But now it only adds manifest somehow. Do you know why?
https://paste.helpch.at/ebovijazax.cs

I am using btw multiple modules

civic valve Mar 23, 2020, 12:03 AM

#

@cerulean kettle md stands for markdown

#

you can google what markdown is

cerulean kettle Mar 23, 2020, 12:05 AM

#

Btw what if i want to modify a patch? Is this possible?

civic valve Mar 23, 2020, 12:07 AM

#

readthedocs

warped loom Mar 23, 2020, 12:10 AM

#

Wait LinsaFTW

#

I know you

#

You're the developer of ExploitFixer

#

Cool plugin and nice fixes

cerulean kettle Mar 23, 2020, 12:12 AM

#

thanks, yeah, im trying to patch this bcord stuff

warped loom Mar 23, 2020, 12:12 AM

#

Yeah I haven't figured out how to use the patches system as well lol I might ask as well

cerulean kettle Mar 23, 2020, 12:12 AM

#

@civic valve But will this replace the existing patch? I dont really know how this commit system works really.

#

im so confused

#

I will better try and experience, i think its the best way to learn gb and thanks.

cerulean kettle Mar 23, 2020, 12:42 AM

#

Btw is it normal that vscode is giving errors?

#

most of stuff is red like wrong syntax missing stuff

#

i have java red hat & maven extensions

#

but like the format of travertine is even wrong... there are final fields without being initialized... why is this like this?

cerulean kettle Mar 23, 2020, 1:08 AM

#

ugh... its so hard to work with this

#

i have to fully recode some parts but theyhave a patch over and i have to start searching for the patches conflicting

#

isnt there a way to get the entire source and compile it directly with the patches included?

#

It seems it is ignoring the folder to take the patches from

#

oh i had to do git add . on the travertine-proxy folder not the main one

#

well its not resolving imports when trying to build with my patches. Weird.

#

maybe ill continue this another day.

cerulean kettle Mar 23, 2020, 1:50 AM

#

yeah its basically not resolving my flamecord dependency

#

used to work before

cerulean kettle Mar 23, 2020, 2:31 AM

#

Just if someone wants to help i would be really grateful. Thanks. I cant even compile vanilla BungeeCord because of random errors in the code even if following the docs. I don't know what to do.

trail plume Mar 23, 2020, 2:33 AM

#

probs because lombok

civic valve Mar 23, 2020, 2:33 AM

#

lombok ❤️

trail plume Mar 23, 2020, 2:33 AM

#

.lombok

lean gobletBOT Mar 23, 2020, 2:33 AM

#

[03:01:27] <gabizou> fuck you and the lombok horse you rode in on

cerulean kettle Mar 23, 2020, 2:33 AM

#

ugh... isnt that for noobs?

trail plume Mar 23, 2020, 2:34 AM

#

no, but it's just bleh

cerulean kettle Mar 23, 2020, 2:34 AM

#

anyways, it doesnt seem to be a lombok issue, but final fields seems to give error "not initialized"

#

or maybe it is a lombok issue...

civic valve Mar 23, 2020, 2:35 AM

#

lombok is really nice when the only people who use your code know exactly how lombok works

cerulean kettle Mar 23, 2020, 2:35 AM

#

Or "constructor not found" there are like 500 checkstyle errors

trail plume Mar 23, 2020, 2:35 AM

#

yes, because constructors are generated

#

you need a lombok plugin for your IDE

cerulean kettle Mar 23, 2020, 2:36 AM

#

it would be nice to add this to the info, i thought it was just for maven

#

thanks

#

It works... you made my day

#

but now its like when compiling it shows errors but on the ide it doesnt

mossy zephyr Mar 23, 2020, 2:47 AM

#

Hey zzzCat

lost latch Mar 24, 2020, 9:25 PM

#

Is there a way to get the forced host that a player joined the proxy using?

lean gobletBOT Mar 24, 2020, 9:27 PM

#

pretty sure there is a method to get the listener address the player connected to

#

I would assume getSocketAddress would contain the address used

lost latch Mar 24, 2020, 9:28 PM

#

Would that give the subdomain used in the forced host? Or at least, be able to differentiate between a forced host and not

#

I thought the actual listener address would just be the IP of the interface used

lean gobletBOT Mar 24, 2020, 9:29 PM

#

try it? or take a look at what the proxy itself uses for that I guess

#

might be PendingConnection#getVirtualHost actually

bleak current Mar 24, 2020, 9:30 PM

#

Is there a way to get the forced host that a player joined the proxy using?

#

yeah that

lost latch Mar 24, 2020, 9:34 PM

#

Nice, thank you

mint hearth Mar 25, 2020, 11:55 AM

#

Hi, I need some help compiling Waterfall, I closed the repo from github, not sure what Clone this repo, but I cannot find Waterfall-Proxy module.

#

Maybe I did something wrong here: Clone this repo, run ./waterfall b from bash, get jar from Waterfall-Proxy/bootstrap/target/ ?

trail plume Mar 25, 2020, 12:11 PM

#

you need to actually clone therepo with git

#

and then run the thing in git-bash or WSL or something

mint hearth Mar 25, 2020, 12:21 PM

#

Thanks, got it, it will be great if this will be added in the readme file, I see others opened tickets asking this on github 👍

trail plume Mar 25, 2020, 12:23 PM

#

I mean, it does?

#

Clone this repo

lost latch Mar 25, 2020, 1:28 PM

#

IS there a method to check if a player is connected to a specific server on the network? I know there is ProxiedPlayer.IsConnected() but that returns true if the player is connected to any server on the network, I need to know if the player is connected to a specific server

dark perch Mar 25, 2020, 1:30 PM

#

ProxiedPlayer have a method to get their server info

#

Use that

lost latch Mar 25, 2020, 1:34 PM

#

Ah right

#

I'm assuming the GetName() method just returns the name of the server specified in waterfall's config.yml?

dark perch Mar 25, 2020, 1:37 PM

#

Iirc, yes

#

Check Javadocs to be sure

dusk crescent Mar 25, 2020, 9:02 PM

#

is p.getPendingConnection().getVirtualHost() returning the subdomain / ip with port the player tries to connect to? understanding that right?

lean gobletBOT Mar 25, 2020, 9:51 PM

#

it should

stark narwhal Mar 25, 2020, 10:35 PM

#

how can you talk as you were a bot, does it remove your message and then the bot post the content ? choque

dark perch Mar 25, 2020, 10:35 PM

#

IRC bridge

stark narwhal Mar 26, 2020, 1:25 AM

#

Hello guys, we are developping a waterfall plugin that modify the server MOTD depending on a ping request, but we already have a plugin that modify the MOTD, is there any way to "call" our plugin after the other one ? We tried to rename the plugin so ours is lower in the list (that's how forge load mods)

dark perch Mar 26, 2020, 1:26 AM

#

Use the depend thing on your plugin yml

stark narwhal Mar 26, 2020, 1:26 AM

#

i don't have a plugin yml

dark perch Mar 26, 2020, 1:26 AM

#

bungee.yml?

stark narwhal Mar 26, 2020, 1:27 AM

#

only waterfall.yml, config.yml, locations.yml

#

and a modules one

trail plume Mar 26, 2020, 1:29 AM

#

set the priority of the event handler to a higher priority

stark narwhal Mar 26, 2020, 1:33 AM

#

It works, thanks

signal pecan Mar 26, 2020, 11:58 PM

#

I tried building Travertine (and Waterfall) but it keeps saying that the pom.xml file does not exist when it is clearly there. Am I doing something wrong when building? I am running 'mvn clean package' after I have cloned it.

trail plume Mar 27, 2020, 12:16 AM

#

run the script, as per the readme

leaden kindle Mar 28, 2020, 2:24 PM

#

Hello ! I have a problem with Bungee, someone can help me ?

upper fiber Mar 28, 2020, 3:57 PM

#

If you tell us the problem @leaden kindle

A waste of conversational bandwidth, be it spoken or digital.
https://www.urbandictionary.com/define.php?term=metaquestion

leaden kindle Mar 28, 2020, 5:31 PM

#

I have a plugin which change user's group on a server and I want to change the group on another server and I try to use plugin message channel but it doesn't work, I don't have errors but on the other server nothing append.

#

My plugin is in the both servers.

#

I tried to use another plugin on the proxy which listen the channel and send to a server the same info and in this server my plugin listen the channel. But the plugin on the proxy doesn't receive any message

lean gobletBOT Mar 28, 2020, 5:53 PM

#

in order to send plugin messages to a server there needs to be a player on the sending and receiving server

upper fiber Mar 28, 2020, 6:19 PM

#

Time for some fun with Databases 🙃 ||It's not as complicated as it seems at first||

warped loom Mar 28, 2020, 6:27 PM

#

it is

lean gobletBOT Mar 28, 2020, 6:29 PM

#

using databases for cross server communication

#

wat

warped loom Mar 28, 2020, 6:31 PM

#

I hope that's not what he's doing

#

databases are meant to store huge quantites of data

leaden kindle Mar 28, 2020, 6:40 PM

#

Oh ok, if has nobody on the server it doesn't work ?

lean gobletBOT Mar 28, 2020, 7:14 PM

#

yeah, the plugin messaging channel between servers is just built ontop of the vanilla plugin messaging channel, it requires a player connection

outer cosmos Mar 28, 2020, 7:47 PM

#

Time for some fun with Databases 🙃 ||It's not as complicated as it seems at first||
@upper fiber Did you look into PlotSquared 4? Hopefully they are releasing their v5 in the next month. Short: PS4 saves its flag in one row atm. 😄

lean gobletBOT Mar 28, 2020, 7:50 PM

#

thonk

upper fiber Mar 28, 2020, 7:54 PM

#

PS4 saves its flag in one row atm
Let's pretend nobody saw that @outer cosmos

errant jetty Mar 29, 2020, 9:29 AM

#

is waterfall better protected then bungee? in terms of exploits and stuff

lean gobletBOT Mar 29, 2020, 12:37 PM

#

there are some small performance improvements but I don't think there are any (known) exploits in bungee?

ember mulch Mar 29, 2020, 7:28 PM

#

is it safe to do Async stuff in PostLoginEvent?

#

with registerIntent and such?

#

😮

lean gobletBOT Mar 29, 2020, 7:30 PM

#

yes

ember mulch Mar 29, 2020, 7:32 PM

#

nice 😮

dense ridge Mar 30, 2020, 3:50 PM

#

What is the Repo from Waterfall

lost latch Mar 30, 2020, 5:57 PM

#

Did waterfall remove the getFrom() method from ServerSwitchEvent that is used to get the server info of the server the player switched from?

#

I can see it in the bungee javadocs and not in the waterfall ones, and it obviously gives an undefined method error when trying to call it in waterfall

#

I'm trying to handle the event using both the server the player is connecting to using ProxiedPlayer.getServer and the server the player is connecting from. How can I do this in waterfall?

bleak current Mar 30, 2020, 6:09 PM

#

waterfall hasn't done upstream merge yet

#

that's why

lost latch Mar 30, 2020, 6:13 PM

#

Oh right, I didn't realise that change was recent in Bungeecord

#

Or was it?

sly crown Mar 30, 2020, 6:13 PM

#

it is yea

lost latch Mar 30, 2020, 6:13 PM

#

Ahh right

#

I'll just switch to bungee for now then

#

Oh wow, didn't see it was only 5 days ago on bungee haha, that's convenient. Glad I didn't start working on this any earlier

upper fiber Mar 30, 2020, 6:41 PM

#

You can't send plugin messages without players online

#

You could use something like Netty or a DB

#

@lyric cipher

#

afaik thats's just not what plugin messages are made and thought for

sly crown Mar 30, 2020, 6:46 PM

#

yea the whole point is that the servers on a network are all independent servers. they're not aware of each other

#

plugin channels just hijack server<->client connections to route a message server<->server, but still needs a client connection to do so

upper fiber Mar 30, 2020, 6:51 PM

#

Plugin messages with no player online?

#

You could use something like Netty or a DB

sly crown Mar 30, 2020, 6:56 PM

#

yea, use a message queue

#

most people use redis for that sort of thing

upper fiber Mar 30, 2020, 7:05 PM

#

It is.
Because plugin messages won't work

shell lagoon Mar 30, 2020, 7:06 PM

#

Could use sockets if you don't want to use a database.

sly crown Mar 30, 2020, 7:07 PM

#

your options are pretty much a raw socket connection where you can send your own sort of messages, or a MQ that's actually designed for this like redis (or any other sort of pub/sub system really)

dense ridge Mar 31, 2020, 9:02 AM

#

What is the Repo from Waterfall?

viral meteor Mar 31, 2020, 2:35 PM

#

guys 🙂

p.getPendingConnection().getListener().getFallbackServer()

is deprecated what is the new thing from that

bleak current Mar 31, 2020, 2:39 PM

#

2nd server in servers list

viral meteor Mar 31, 2020, 3:02 PM

#

@bleak current ? in wich list ? prioritylist ?

bleak current Mar 31, 2020, 3:07 PM

#

lemme see

#

yes

#

https://github.com/SpigotMC/BungeeCord/blob/master/api/src/main/java/net/md_5/bungee/api/config/ListenerInfo.java#L104

GitHub

SpigotMC/BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers. - SpigotMC/BungeeCord

viral meteor Mar 31, 2020, 3:09 PM

#

so its prioritylist.get(1) ?

#

xD

bleak current Mar 31, 2020, 3:16 PM

#

    @Deprecated
    public String getFallbackServer()
    {
        return ( serverPriority.size() > 1 ) ? serverPriority.get( 1 ) : getDefaultServer();
    }

#

idk, is it?

#

perhaps then!

#

if you can't understand the code then you don't have any choice but

#

.try

lean gobletBOT Mar 31, 2020, 3:16 PM

#

https://tryitands.ee/

upper fiber Mar 31, 2020, 4:06 PM

#

Is there a way to distinguish a "real" server join from a server join from one server to another?

sly crown Mar 31, 2020, 4:06 PM

#

from the backend?

#

cuz you're asking in #waterfall-dev

#

of course the proxy knows

upper fiber Mar 31, 2020, 4:07 PM

#

Rather from paper

#

Just thought I'd ask here because it's not just paper, but 🤷‍♂️

sly crown Mar 31, 2020, 4:08 PM

#

i mean the thing is basically that a server switch essentially makes the client leave one server and join another

upper fiber Mar 31, 2020, 4:09 PM

#

So I'd have to do something like
Waterfall makes player switch servers -> notifies receiving server via something like redis -> server knows from redis
?

trail plume Mar 31, 2020, 4:11 PM

#

basically, yes; or do it at the proxy level

sly crown Mar 31, 2020, 4:11 PM

#

from what i understand yea, but i am not too familiar with the process tbh

upper fiber Mar 31, 2020, 4:11 PM

#

Thanks

fervent geyser Mar 31, 2020, 6:42 PM

#

I'm doing this with Redis, realtime info about everything, players and servers

trail plume Apr 1, 2020, 1:58 AM

#

depends on the implementation and all that

#

waterfall doesn't even have a main thread, so... yea...

#

implementation of the library you're using

#

There is likely a handful of people in here that have actually played with rabbit

#

You'd be much faster and get concrete answers if you actually test the behavior yourself, or read the javadocs/google, etc

#

use a profiler or something

#

look at the code

spring bloom Apr 1, 2020, 2:05 AM

#

it blocks main if it blocks main

warped loom Apr 1, 2020, 4:06 PM

#

Are there some additional APIs with Waterfall? I thought the changes were only for the server

📎 unknown.png

sly crown Apr 1, 2020, 4:08 PM

#

there's a few yea

#

tho someone should probably merge upstream cough cough

bleak current Apr 1, 2020, 4:09 PM

#

ping cat

sly crown Apr 2, 2020, 1:48 AM

#

bungee doesn't have a main thread

#

you are fundamentally misunderstanding how bungee works

molten jackal Apr 2, 2020, 11:04 AM

#

I need to be able to check what server someone switched from and to. However, the ServerSwitchEvent doesn't have a getFrom() method like in BungeeCord. Why is this? Is there some alternative I'm missing?

stable vigil Apr 2, 2020, 5:03 PM

#

maybe do it like here described: https://www.spigotmc.org/threads/serverswitchevent-get-source-and-destination.82657/ but i dont know whether it is "stable"

SpigotMC - High Performance Minecraft

Solved - ServerSwitchEvent Get Source and Destination?

Hello Spigot Community,

**EDIT: I solved it myself. Look at post 2.

Recently I am planning on writing a BungeeCord plugin that basically does a...

trail plume Apr 2, 2020, 5:05 PM

#

Swedz, that method was basically only recently added to bungee, it'll be in waterfall once it builds

sly crown Apr 2, 2020, 5:05 PM

#

https://discordapp.com/channels/289587909051416579/555462232209621003/694941457340956693

molten jackal Apr 2, 2020, 5:28 PM

#

Oh my b

#

Didn't realize it was a new feature

#

As of right now, I'm dynamically adding servers like this:

public static ServerInfo addServer(String serverName, String motd, String hostname, int port, boolean restricted) {
    ServerInfo serverInfo = getInstance().getProxy().constructServerInfo(serverName, new InetSocketAddress(hostname, port), motd, restricted);
    return getInstance().getProxy().getConfig().addServer(serverInfo);
}

However I'm looking to get the servers to be retained over reboots. I don't see any save() (or similar) methods in the ProxyConfig class, so I'm not sure what to do.

Also, just now seeing that ProxyConfig is deprecated. What is the correct way to be doing this?

trail plume Apr 2, 2020, 5:38 PM

#

that's how you do it

#

it's basically a "I can modify this at any time" type thing

molten jackal Apr 2, 2020, 5:38 PM

#

Ok thats fine

#

How can I save the config?

grizzled thistle Apr 3, 2020, 3:47 AM

#

Is there timings for waterfall or anything equivalent to it?

molten jackal Apr 3, 2020, 4:17 AM

#

Afaik waterfall/bungee doesn't have a "tps" but you can do network testing using some other software

trail plume Apr 3, 2020, 6:34 AM

#

no, bungee doesn't "tick"

deft trail Apr 3, 2020, 4:14 PM

#

you can run spark on it

shadow schooner Apr 3, 2020, 7:20 PM

#

What methods are available in waterfall that are not available in regular bungee? Anything related to forge?

harsh harbor Apr 3, 2020, 7:59 PM

#

BungeeCord has very bad forge support, and so Waterfall

bleak current Apr 3, 2020, 8:23 PM

#

modern forge is not supported at all yeah

stable vigil Apr 3, 2020, 8:24 PM

#

what you guys think is the problem for that? the designing of bungeecord or the designing of forge?

stone fiber Apr 3, 2020, 8:25 PM

#

yes

#

designed by two separate groups with their own ideas completely independent of each other

#

bungee has sort of gone into "if forge works that's great but we're not gonna put a lot of work into it" mode

#

waterfall is more open to that sort of thing but it's still work that needs to be done afaik

#

thats completely ignoring mods too which can throw a giant wrench in it depending on what they do so, it's a fun time

sly crown Apr 3, 2020, 8:27 PM

#

z sounds like cat now

stone fiber Apr 3, 2020, 8:27 PM

#

maybe Im just cat with a different username

#

it was cat all along

#

cat is everywhere

sly crown Apr 3, 2020, 8:27 PM

#

that explains why cat is so tired all the time

ornate jasper Apr 4, 2020, 3:41 AM

#

Hey, so I'm looking at the docs and I see two events for TabComplete: TabCompleteEvent and TabCompleteResponseEvent, If i wanted to control bungee tab responses i'd work with the former and if i wanted to work with paper server suggestions i'd use the last right

upper plinth Apr 4, 2020, 11:19 PM

#

Is it possible to create a plugin for waterfall to intercept and modify the coordinates sent to the client with a fixed off-set per player (e.g X = X + 50,000 and Z = Z - 13,000)

sly crown Apr 4, 2020, 11:20 PM

#

possible yes...but keep in mind there's a lot of oddities about how coords are sent between server and client

warped loom Apr 4, 2020, 11:20 PM

#

you mean spawn join ?

sly crown Apr 4, 2020, 11:20 PM

#

a lot of packets actually have relative coords

warped loom Apr 4, 2020, 11:20 PM

#

I haven't understood his question

sly crown Apr 4, 2020, 11:21 PM

#

pretty sure they literally just mean all coords in packets

upper plinth Apr 4, 2020, 11:21 PM

#

Yeah

sly crown Apr 4, 2020, 11:21 PM

#

so the player thinks they are in some other part of the world than they really are

upper plinth Apr 4, 2020, 11:22 PM

#

The server knows the player’s real coordinates however is shown a different set of coordinates (passed through some reversible function)

#

Is what I’m trying to achieve

trail plume Apr 4, 2020, 11:47 PM

#

you'd need to offset the entire world to the client

harsh harbor Apr 5, 2020, 8:42 AM

#

yeah, including chunks

lean gobletBOT Apr 5, 2020, 2:11 PM

#

christiandobbie: saw someone try that and they ran into some very odd issues even when changing all packets (or so they claimed)

sly crown Apr 5, 2020, 5:47 PM

#

lmao imagine caring about performance and running on windows

bleak current Apr 5, 2020, 5:52 PM

#

bruh

#

i mean theoretically....

#

.g zig cc

lean gobletBOT Apr 5, 2020, 5:52 PM

#

(DiscordBot) https://ziglang.org/ -- The Zig Programming Language: "Zig is a general-purpose programming language and toolchain for maintaining ... zig build-exe --c-source hello.c --library c --verbose-cc zig cc -MD..."

The Zig Programming Language

Zig is a general-purpose programming language and toolchain for maintaining robust, optimal, and reusable software.

bleak current Apr 5, 2020, 5:52 PM

#

sec

#

https://andrewkelley.me/post/zig-cc-powerful-drop-in-replacement-gcc-clang.html

trail plume Apr 5, 2020, 5:52 PM

#

zig

bleak current Apr 5, 2020, 5:52 PM

#

📎 unknown.png

#

technically could be used to compile dlls

sly crown Apr 5, 2020, 5:54 PM

#

i mean, yes you could

#

but in general even, aside from natives...

bleak current Apr 5, 2020, 5:55 PM

#

windows is still 🤢

bleak current Apr 6, 2020, 8:02 AM

#

does using player.sendMessage("hello"), via paper, trigger any waterfall events?

harsh harbor Apr 6, 2020, 8:10 AM

#

No.

bleak current Apr 6, 2020, 8:20 AM

#

😭

harsh harbor Apr 6, 2020, 8:21 AM

#

Why would you need that?

brazen walrus Apr 6, 2020, 11:56 AM

#

You can use https://github.com/Exceptionflug/protocolize if you want to catch the packet

GitHub

Exceptionflug/protocolize

A lightweight BungeeCord protocol framework supporting items - Exceptionflug/protocolize

harsh harbor Apr 6, 2020, 11:57 AM

#

📎 unknown.png

#

thinking_gun

bleak current Apr 6, 2020, 12:31 PM

#

pepelaugh

#

mother fuck

molten walrus Apr 6, 2020, 4:40 PM

#

It’s kinda pretty

fervent geyser Apr 6, 2020, 7:13 PM

#

w w wwhyyy

bleak current Apr 7, 2020, 6:18 AM

#

@EventHandler
    public void onLogin(LoginEvent event) {
        if (event.getConnection() instanceof ProxiedPlayer) {
            ProxiedPlayer player = (ProxiedPlayer) event.getConnection();

            broadcastAll(String.format(
                    "&e%s joined the game.",
                    player.getName()
            ));
    }

This doesn't trigger, can't I use the LoginEvent? I use other events so the listener is registered.

trail plume Apr 7, 2020, 6:21 AM

#

more than likely waaay too early if you want the connecting player to see it

bleak current Apr 7, 2020, 6:23 AM

#

is there a recommended event for it?

trail plume Apr 7, 2020, 6:26 AM

#

probably server connected event or something like that

bleak current Apr 7, 2020, 6:26 AM

#

PostLoginEvent worked!

wind tapir Apr 8, 2020, 8:28 PM

#

Where in BungeeCord/Waterfall is the server brand when the client pings there server stored?

trail plume Apr 8, 2020, 8:32 PM

#

I don't think it is

wind tapir Apr 8, 2020, 8:34 PM

#

What do you mean...?

#

1.8.x 1.9.x...1.15.x Waterfall

#

That ^^^^^^^^

bleak current Apr 8, 2020, 8:36 PM

#

see how ping response is generated

wind tapir Apr 8, 2020, 8:37 PM

#

I looked through 10 files and couldn't find it

#

📎 unknown.png

#

😐

fervent geyser Apr 8, 2020, 8:38 PM

#

ProxyPingEvent

wind tapir Apr 8, 2020, 8:38 PM

#

Oh...

fervent geyser Apr 8, 2020, 8:38 PM

#

Then modify the response

bleak current Apr 8, 2020, 8:39 PM

#

iirc ping is handled in InitialHandler

wind tapir Apr 8, 2020, 8:39 PM

#

Huh...

#

Barely a thing in there

#

📎 unknown.png

#

Nothing to modify...

fervent geyser Apr 8, 2020, 8:40 PM

#

Well it's Lombok

#

So you have getters and setters generated

dark perch Apr 8, 2020, 8:41 PM

#

With IJ search for references

#

And thats it

wind tapir Apr 8, 2020, 8:42 PM

#

iirc ping is handled in InitialHandler
Yeah, I found

public void handle(LegacyPing ping) throws Exception
    {
        this.legacy = true;
        final boolean v1_5 = ping.isV1_5();

        ServerPing legacy = new ServerPing( new ServerPing.Protocol( bungee.getName() + " " + bungee.getGameVersion(), bungee.getProtocolVersion() ),
                new ServerPing.Players( listener.getMaxPlayers(), bungee.getOnlineCount(), null ),
                new TextComponent( TextComponent.fromLegacyText( listener.getMotd() ) ), (Favicon) null );```

#

in InitialHandler.java

dark perch Apr 8, 2020, 8:43 PM

#

If you want to change that, then listen for the packet and change the ServerPing object

wind tapir Apr 8, 2020, 8:43 PM

#

But, that is legacy ping AND bungee.getName returns the value I want (but the ping still says Waterfall)

fervent geyser Apr 8, 2020, 8:43 PM

#

That should be modifiable through ProxyPingEvent, nah?

dark perch Apr 8, 2020, 8:43 PM

#

Again, look references on IJ

wind tapir Apr 8, 2020, 8:43 PM

#

I'm not on IJ...

dark perch Apr 8, 2020, 8:44 PM

#

Eclipse?

#

NetBeans?

#

NP++?

wind tapir Apr 8, 2020, 8:45 PM

#

No, no, and no.

#

Notepad.exe

bleak current Apr 8, 2020, 8:45 PM

#

InitialHandler does ping response yeah

wind tapir Apr 8, 2020, 8:45 PM

#

(just kidding)

#

Not notepad xD

bleak current Apr 8, 2020, 8:45 PM

#

handle(StatusRequest ...)

wind tapir Apr 8, 2020, 8:45 PM

#

Atom ⚛️

bleak current Apr 8, 2020, 8:45 PM

#

jesus christ

#

when do people learn that you cannot keep using dumb text editors for stuff

wind tapir Apr 8, 2020, 8:46 PM

#

It isn't a dumb text editor...

#

It's a code editor.

bleak current Apr 8, 2020, 8:46 PM

#

use atom for at most writing essays and nothing else

trail plume Apr 8, 2020, 8:46 PM

#

it's a glorified text editor

fervent geyser Apr 8, 2020, 8:46 PM

#

Here, save some nerves -> https://www.jetbrains.com/idea/download/

JetBrains

Download IntelliJ IDEA: The Java IDE for Professional Developers by...

Download the latest version of IntelliJ IDEA for Windows, macOS or Linux.

bleak current Apr 8, 2020, 8:46 PM

#

it's a fucking shit in an electron wrapper

wind tapir Apr 8, 2020, 8:47 PM

#

I have IJ.

#

I just don't open it when making small tweaks (or what should be a small tweak...)

bleak current Apr 8, 2020, 8:47 PM

#

which lost in competition to another shit in electron wrapper called vsc

trail plume Apr 8, 2020, 8:47 PM

#

VSC is awesome

#

I mean, if you're using it for mostly text-editor level stuff, it's awesome

#

actually using it...

#

god

wind tapir Apr 8, 2020, 8:48 PM

#

    public void handle(StatusRequest statusRequest) throws Exception
    {
        Preconditions.checkState( thisState == State.STATUS, "Not expecting STATUS" );

        ServerInfo forced = AbstractReconnectHandler.getForcedHost( this );
        final String motd = ( forced != null ) ? forced.getMotd() : listener.getMotd();
        final int protocol = ( ProtocolConstants.SUPPORTED_VERSION_IDS.contains( handshake.getProtocolVersion() ) ) ? handshake.getProtocolVersion() : bungee.getProtocolVersion();

        Callback<ServerPing> pingBack = new Callback<ServerPing>()```

bleak current Apr 8, 2020, 8:48 PM

#

well yes, definitely better than atom, np++ etc.

trail plume Apr 8, 2020, 8:48 PM

#

I would rather be locked in a room with simple

bleak current Apr 8, 2020, 8:48 PM

#

and has live share

#

otherwise... real ide

#

or emacs :^)

trail plume Apr 8, 2020, 8:48 PM

#

https://wiki.c2.com/?EmacsAsOperatingSystem

bleak current Apr 8, 2020, 8:49 PM

#

PogU

wind tapir Apr 8, 2020, 8:49 PM

#

See code above

trail plume Apr 8, 2020, 8:49 PM

#

Just, make sure you install evil-mode, gotta get a good text editor

wind tapir Apr 8, 2020, 8:49 PM

#

I see supported versions, but everything seems to omit the Waterfall part...

#

Well where is it?

trail plume Apr 8, 2020, 8:50 PM

#

further down

#

it literally just uses getName on the proxy instance

wind tapir Apr 8, 2020, 8:50 PM

#

BRUH

#

I KNOW THAT

bleak current Apr 8, 2020, 8:51 PM

#

watch your attitude

dark perch Apr 8, 2020, 8:51 PM

#

Then do Ctrl + F

wind tapir Apr 8, 2020, 8:51 PM

#

And guess what: getName() returns my proxy name

bleak current Apr 8, 2020, 8:51 PM

#

pull out IDE already

wind tapir Apr 8, 2020, 8:51 PM

#

And yet it still says Waterfall

dark perch Apr 8, 2020, 8:52 PM

#

Then probably you didnt update the jar correctly

#

OR you are doing something wrong

bleak current Apr 8, 2020, 8:52 PM

#

there's literally a method named getPingInfo in IH...

wind tapir Apr 8, 2020, 8:52 PM

#

1.8.x, 1.9.x, 1.10.x, 1.11.x, 1.12.x, 1.13.x, 1.14.x, 1.15.x, 1.16 (Waterfall)

spring bloom Apr 8, 2020, 8:53 PM

#

has mojanged started preleases yet

bleak current Apr 8, 2020, 8:53 PM

#

no

wind tapir Apr 8, 2020, 8:53 PM

#

    @Override
    public String getName()
    {
        return "HyperFall";
    }```

#

BungeeCord.java

#

Ping: 1.8.x, 1.9.x, 1.10.x, 1.11.x, 1.12.x, 1.13.x, 1.14.x, 1.15.x, 1.16 (Waterfall)

#

🤔

dark perch Apr 8, 2020, 8:54 PM

#

Then probably you didnt update the jar correctly

bleak current Apr 8, 2020, 8:54 PM

#

mvn clean and rebuild...

wind tapir Apr 8, 2020, 8:54 PM

#

Um...

#

This is in my fork, and it's had like 40 commits.

bleak current Apr 8, 2020, 8:55 PM

#

mvn clean

#

and rebuild

wind tapir Apr 8, 2020, 8:55 PM

#

All which have been built with HyperFall version

#

Okay.

#

Lemme try

bleak current Apr 8, 2020, 8:55 PM

#

that should've been one of the first things

wind tapir Apr 8, 2020, 8:56 PM

#

Hold on, getting out of patch editing state.

#

Huh.

#

I can't mvn clean.

bleak current Apr 8, 2020, 9:02 PM

#

¯\_(ツ)_/¯

wind tapir Apr 8, 2020, 9:03 PM

#

Nevermind, cleaned the second time.

harsh harbor Apr 8, 2020, 10:48 PM

#

hypefall

#

confused sounds

wind tapir Apr 8, 2020, 10:50 PM

#

Yes lol.

bleak current Apr 9, 2020, 10:15 AM

#

If I use PostLoginEvent and in its function I use getProxy().getPlayers(), does that include the joined player in the event?

smoky spindle Apr 9, 2020, 1:48 PM

#

How do i compile Waterfall to get a sources-file for maven?

glass horizon Apr 9, 2020, 2:29 PM

#

@bleak current yes

high lily Apr 10, 2020, 7:35 AM

#

should be gasrise

bleak current Apr 11, 2020, 5:31 PM

#

Hello, I decompiled the waterfall project and now I would start it but:

ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.
ERROR StatusLogger No Log4j 2 configuration file found. Using default configuration (logging only errors to the console), or user programmatically provided configurations. Set system property 'log4j2.debug' to show Log4j 2 internal initialization logging. See https://logging.apache.org/log4j/2.x/manual/configuration.html for instructions on how to configure Log4j 2
ERROR StatusLogger Unrecognized format specifier [d]

civic valve Apr 11, 2020, 5:40 PM

#

why would you decompile it

bleak current Apr 11, 2020, 5:50 PM

#

because I want to add some functions

harsh harbor Apr 11, 2020, 5:57 PM

#

you can add custom patches.

bleak current Apr 11, 2020, 6:00 PM

#

how?

bleak current Apr 11, 2020, 6:38 PM

#

l m a o

lean gobletBOT Apr 11, 2020, 6:42 PM

#

the readme should contain the information necessary to do that

trail plume Apr 11, 2020, 6:43 PM

#

if you wanna modify waterfall, look at travertine

bleak current Apr 11, 2020, 6:44 PM

#

travertine?

trail plume Apr 11, 2020, 6:45 PM

#

assuming you're not planning to create a PR, travertine basically has the magic to maintain patches over waterfall

civic valve Apr 11, 2020, 6:48 PM

#

@bleak current what are you actually trying to do/change

bleak current Apr 11, 2020, 8:06 PM

#

@bleak current what are you actually trying to do/change
@civic valveI want to add new commands, new modules and a RestAPI

#

why can't you do that with a plugin?

bleak current Apr 11, 2020, 8:37 PM

#

if you wanna modify waterfall, look at travertine
@trail plume travertine also gives me a mistake: https://hastebin.com/gidaleduwo.bash

#

are you decompiling and recompiling once again...?

#

don't do that

#

if you want to build a fork of waterfall, clone travertine, yeet out the patches it has and add your own

#

and change other branding

#

it's easy

trail plume Apr 11, 2020, 8:48 PM

#

wut are you even?

#

if that's actually a real travertine jar and not one you've messed with, onedrive BS? assuming you clipped out your name from there, otherwise, god knows

brazen walrus Apr 12, 2020, 2:14 AM

#

for (ProxiedPlayer player : getProxy().getPlayers()) {
  // some code
}

Stupid question, but is it safe to do this?
The code is called by a scheduler using getScheduler().schedule(...).

warped loom Apr 12, 2020, 12:17 PM

#

I think so

#

also since it's a collection you can use the forEach() method btw

#

getProxy().getPlayers().forEach(player -> ...)

don't know if this has helped you 😁

bleak current Apr 12, 2020, 12:34 PM

#

s t r e a m s

#

pepega

chilly coral Apr 12, 2020, 12:35 PM

#

This one is not from stream api

bleak current Apr 12, 2020, 12:35 PM

#

ah yes right nvm

fervent geyser Apr 12, 2020, 12:36 PM

#

Offtopic question, what is better? forEach() method or classic foreach loop?

#

I heard that forEach is less memory friendly, that it creates new lambda everytime

chilly coral Apr 12, 2020, 12:36 PM

#

forEach from Collection wraps the classic loop

bleak current Apr 12, 2020, 12:37 PM

#

new lambda every time
first time yeah

chilly coral Apr 12, 2020, 12:37 PM

#

forEach from stream api could be memory/cpu angry

fervent geyser Apr 12, 2020, 12:38 PM

#

Just the Collection one, because I'm using that alot

chilly coral Apr 12, 2020, 12:39 PM

#

I don't really know if the lambda thing could hurt performance

stable vigil Apr 12, 2020, 12:40 PM

#

It is definitely slower than a classic for-each-loop but the performance difference is not noticable. It is fine to use it. Personally, I use it very often

fervent geyser Apr 12, 2020, 12:40 PM

#

Thanks ❤️

signal mica Apr 12, 2020, 12:56 PM

#

Is Waterfall Thread safe? I want to add and remove servers from different threads. I would like to avoid the async scheduler since it causes problems with other parts of my code.

warped loom Apr 12, 2020, 1:02 PM

#

Waterfall does not have a main thread from what I've been told

surreal compass Apr 12, 2020, 2:56 PM

#

Is there a waterfall equivalent for ServerCommandEvent on spigot? Or at least any event I can listen to if I want to parse console commands?

lost latch Apr 12, 2020, 4:13 PM

#

So I need my plugin to load after LuckPerms so it can hook into their API, but softdepend doesn't really work from what I've tried, and depends: [LuckPerms] means the plugin won't load if LuckPerms isn't present. Any way I can do this?

warped loom Apr 12, 2020, 4:14 PM

#

i think there is only a load-before in the plugin.yml

#

not a load-after

lost latch Apr 12, 2020, 4:15 PM

#

Yeah, that's what softdepend tries to do on normal plugins iirc

#

Just doesn't work on bungeecord/waterfall, at all.

lean gobletBOT Apr 12, 2020, 6:58 PM

#

it's softdepends, not softdepend

lost latch Apr 12, 2020, 7:33 PM

#

Yeah sorry, that's what I've been trying

#

softdepends: [LuckPerms], plugin still loads before LuckPerms every time

lean gobletBOT Apr 12, 2020, 7:34 PM

#

that's what softdepends means, load after

lost latch Apr 12, 2020, 7:35 PM

#

Ahah, I meant loads before

#

I want my plugin to load after luckperms, by even with putting softdepends: [LuckPerms] it still loads before

lean gobletBOT Apr 12, 2020, 7:42 PM

#

that's odd, it shouldn't do that

#

wait, it might be case-sensitive, try softDepends

lost latch Apr 12, 2020, 8:17 PM

#

Yup! That was it, thank you so much

#

Dk why regular bukkit plugins are softdepend and bungeecord is softDepends

signal mica Apr 12, 2020, 8:59 PM

#

A little "strange" question: Does each plugin run in its own thread? Or in other words: Will I run into problems when I change the classloader in my plugin?
My problem is that I need guava 28 but Waterfall only uses 21. To fix this I want to use some classloader magic

trail plume Apr 12, 2020, 9:00 PM

#

no, they run on the network threads, basically

#

they can have their own threads by the scheduler, etc

#

you probably just wanna relocate guava and shade it in

signal mica Apr 12, 2020, 9:01 PM

#

But how do I do this? I have guava extracted to my plugin but Waterfall will not magically load my dependencies. I could recompile the whole Proxy but I want to avoid that.

trail plume Apr 12, 2020, 9:03 PM

#

use maven/gradle

#

they both have plugins which let you handle this type of stuff

signal mica Apr 12, 2020, 9:04 PM

#

Okay, cool. I will try this then. Many thanks.

naive hound Apr 13, 2020, 7:16 AM

#

Hello, does "depend: [LuckPerms]" guarantee that my plugin will stop before LuckPerms when server will be closing?

#

or what can guarantee it to me?

dark perch Apr 13, 2020, 7:18 AM

#

afaik it only guarantee you load after the plugin

warped loom Apr 13, 2020, 9:32 AM

#

isn't that load-before

#

depend will just make ur plugin not enable if that dependency isn't in the server.

naive hound Apr 13, 2020, 10:51 AM

#

and how can I achieve that my X-plugin will start after Y-plugin and stop before Y-plugin?

wide maple Apr 13, 2020, 10:53 AM

#

loadbefore and loadafter?

naive hound Apr 13, 2020, 11:56 AM

#

thanks, I had "depend: [LuckPerms]" instead of "depends: [LuckPerms]"..

steel jungle Apr 13, 2020, 7:50 PM

#

Can one re-connect a player to the server they're on with the API?

eager hill Apr 13, 2020, 7:53 PM

#

Something like reconnecting while the backend server is down?

steel jungle Apr 13, 2020, 7:56 PM

#

No, just like a relog.

#

I'm trying to add a /login-as <username> command for admins

#

and I thought it would be cool not to have to manually relog

lean gobletBOT Apr 13, 2020, 8:12 PM

#

could just switch to the lobby and back, no idea if reconnecting works

molten jackal Apr 14, 2020, 3:18 PM

#

Is there a way to get the max player limit of a paper/spigot server on the bungee/waterfall side of things?

#

Without having to send a custom plugin message to show that data, preferably.

#

I just found a way to do it with ServerInfo#ping() nvm 😂

bleak current Apr 14, 2020, 7:27 PM

#

will I need to use a plugin to show player names on the server list again?

#

preferably write it myself, but I assume thats how I solve it?

bleak current Apr 14, 2020, 8:09 PM

#

you can use ServerListPlus

full cloak Apr 14, 2020, 10:46 PM

#

Is there any maven repo for waterfall available?

lean gobletBOT Apr 14, 2020, 10:47 PM

#

it's in the normal papermc repo

full cloak Apr 14, 2020, 10:48 PM

#

ah, okay. thx. maybe you could add the maven repo infos also to the github readme for waterfall 🙂

molten jackal Apr 15, 2020, 4:22 PM

#

As of right now, I'm dynamically adding servers like this:
public static ServerInfo addServer(String serverName, String motd, String hostname, int port, boolean restricted) {
    ServerInfo serverInfo = getInstance().getProxy().constructServerInfo(serverName, new InetSocketAddress(hostname, port), motd, restricted);
    return getInstance().getProxy().getConfig().addServer(serverInfo);
}
However I'm looking to get the servers to be retained over reboots. I don't see any save() (or similar) methods in the ProxyConfig class, so I'm not sure what to do.

I never got an answer to this question 😐

bleak current Apr 15, 2020, 4:24 PM

#

you can maintain your own servers storage

molten jackal Apr 15, 2020, 4:26 PM

#

You mean like in my own file and have it load all the servers on boot? That would work, but working via the bungee config would keep everything in one place.

lean gobletBOT Apr 15, 2020, 4:28 PM

#

as far as I can tell you'll have to save it manually

molten jackal Apr 15, 2020, 4:34 PM

#

public static ServerInfo addServer(String serverName, String motd, String hostname, int port, boolean restricted, boolean save) {
    ServerInfo serverInfo = getInstance().getProxy().constructServerInfo(serverName, new InetSocketAddress(hostname, port), motd, restricted);
    ProxyConfig config = getInstance().getProxy().getConfig();
    config.addServer(serverInfo);
    if(save) {
        YamlConfig yaml = (YamlConfig) ProxyServer.getInstance().getConfigurationAdapter();
        try {
            Method method = yaml.getClass().getMethod("save");
            method.setAccessible(true);
            method.invoke(yaml);
        } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException ex) {
            ex.printStackTrace();
        }
    }
    return serverInfo;
}

Untested, hacky, and might work 😂

#

mmm wait

#

ugh nvm lol

#

ill just go the manual route

bleak current Apr 15, 2020, 5:12 PM

#

your other option is to reroute whole configuration to your own configurationadapter

bleak current Apr 16, 2020, 11:46 AM

#

Guys

#

ReadTimeoutException : null

#

i get this kick issue by like 30% of my players

trail plume Apr 16, 2020, 6:29 PM

#

this is the dev channel, not the help channel

#

The exception literally says what happened, there was nothing to read in so long

bleak current Apr 18, 2020, 7:39 PM

#

do you recommend me to use any startup flags on waterfall?

lean gobletBOT Apr 18, 2020, 7:40 PM

#

just makge sure that you use g1gc, also such questions fit more into the help channel ;)

stark bone Apr 18, 2020, 10:31 PM

#

Anyone know why I can't seem to import InitialHandler?

📎 unknown.png

#

I can import everything else fine

bleak current Apr 18, 2020, 10:37 PM

#

because it's not in api

stark bone Apr 18, 2020, 10:38 PM

#

OH of course it isn't

#

I think it just clicked

dark perch Apr 18, 2020, 10:55 PM

#

Because you have the light theme

stark bone Apr 18, 2020, 11:16 PM

#

When does ProxiedPlayer.getUniquieId() get populated?

#

Is it safe to call it during LoginEvent

#

I'm guessing PostLoginEvent tbh

lofty estuary Apr 18, 2020, 11:54 PM

#

for some reason when im pinging a server the callback happens twice
once without a throwable then once with a trowable

#

anyone have an idea?

harsh harbor Apr 19, 2020, 9:19 AM

#

ping callbacks are trash

#

nvm

#

@lofty estuary what throwable do you get

lofty estuary Apr 19, 2020, 10:07 AM

#

Figured it out my own code was causing the throwable

#

Felt real dumb for a bit 😂

#

I'm guessing it's good practice to make sure it's the expected throwable and if not print stack trace

lean gobletBOT Apr 19, 2020, 5:57 PM

#

james090500: UUID should be available in the LoginEvent, only the PreLoginEvent states that it has no additional info about the player

brittle pilot Apr 19, 2020, 10:17 PM

#

Can I include a default config.yml file fro my plugin with bungeecord like i can with spigot?

bleak current Apr 19, 2020, 10:17 PM

#

yes

brittle pilot Apr 19, 2020, 10:19 PM

#

How do I output it to the config dir? Or how do I access the file in the jar to be able to output it?

#

I have a config.yml in my resources dir, and its included in my pom.xml, but I don't see anything like bukkit's saveDefaultConfig

#

Sorry, I'm new to Java. Do I just use something like this https://stackoverflow.com/questions/3861989/preferred-way-of-loading-resources-in-java and save it in getDataFolder?

bleak current Apr 19, 2020, 10:25 PM

#

.g bungeecord plugin configuration api

lean gobletBOT Apr 19, 2020, 10:25 PM

#

(DiscordBot) https://www.spigotmc.org/wiki/using-the-bungee-configuration-system/ -- Using the Bungee Configuration System | SpigotMC - High ...: "Apr 20, 2019 ... The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy."

Using the Bungee Configuration System | SpigotMC - High Performance...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

brittle pilot Apr 19, 2020, 10:26 PM

#

Yes, I'm reading that. Am I missing something?

#

the bottom part huh

bleak current Apr 19, 2020, 10:27 PM

#

yeah

#

it's basically saveDefaultConfig method implementation

brittle pilot Apr 19, 2020, 10:27 PM

#

Yeah I missed this part, ty: getResourceAsStream("config.yml")

upper wharf Apr 20, 2020, 6:06 PM

#

Hi guys, I'm searching something which I don't know if it is realizable (caused I haven't found it online). Do you think it is possible to put a Proxy server (like Socks5) between Waterfall and other servers ?

lean gobletBOT Apr 20, 2020, 6:07 PM

#

probably

upper wharf Apr 20, 2020, 6:07 PM

#

(Instead of Client-> Waterfall -> Server make Client -> Waterfall -> Socks5 -> Server)

#

Ok cool so now I've to found how to figure it out 😢 Thanks

trail plume Apr 20, 2020, 6:10 PM

#

use a tunnel

upper wharf Apr 20, 2020, 6:12 PM

#

Have I to do it plugin side /waterfall jar side or have I to connect through server?

trail plume Apr 20, 2020, 6:13 PM

#

you'd need to setup some form of tunnel or something and connect to it like that

upper wharf Apr 20, 2020, 6:18 PM

#

Okay thanks, I'm going to try that

high lily Apr 21, 2020, 4:42 AM

#

What is the best way to identify a server on the proxy by id or something?

dark perch Apr 21, 2020, 4:44 AM

#

Server name?

high lily Apr 21, 2020, 4:49 AM

#

thank haha

#

does ServerSwitchEvent get fired on the first login switch into the first server?

harsh harbor Apr 21, 2020, 11:36 AM

#

no each time you switch the server

#

read docs

sly crown Apr 21, 2020, 11:35 PM

#

what the hell is that github issue

bleak current Apr 21, 2020, 11:45 PM

#

wtf

#

that person is completely clueless how things work

#

...

#

jesus fuck

#

cat can you just ban that dude from the repos

#

kekw

#

https://github.com/ByteCompiler/protocolsupport2020.03.24 ah yes

#

the kid is unaware that ps is available on github

sly crown Apr 22, 2020, 12:00 AM

#

doesn't include the license

#

he's breaking copyright laws!

#

wait

#

it does

#

lmao

#

does PS bundle the license?

#

and uh...is it really agpl

civic valve Apr 22, 2020, 12:00 AM

#

following copyright in the mc community kekw

sly crown Apr 22, 2020, 12:00 AM

#

https://github.com/ProtocolSupport/ProtocolSupport it's actually agpl pepega

GitHub

ProtocolSupport/ProtocolSupport

Support 1.15, 1.14, 1.13, 1.12, 1.11, 1.10, 1.9, 1.8, 1.7, 1.6, 1.5, 1.4.7 clients on Spigot 1.15.2 - ProtocolSupport/ProtocolSupport

#

is agpl gpl compatible or does it necessitate agpl

civic valve Apr 22, 2020, 12:01 AM

#

i don't think it is

#

holy fuck block that guy

#

They've been banned from github before

#

banned name was marinaluisa2020

#

their whole github profile is begging for support

formal dirge Apr 22, 2020, 12:13 AM

#

kekwhyper

sly crown Apr 22, 2020, 12:17 AM

#

"Before creating a public repository, learn basic quantum physics;"

#

this has to be a troll right

bleak current Apr 22, 2020, 12:29 AM

#

no, a retard

sly crown Apr 22, 2020, 1:00 AM

#

quantum physics?

#

alright ChemE major

bleak current Apr 22, 2020, 1:16 AM

#

barty chem major? lol inb4 works for drug labor, cooking fancy drugs

weary grove Apr 22, 2020, 2:35 AM

#

That guy has to be either incredibly dumb, a troll, or he is a deep cover parody of Deepak Chopra. Honestly I can't decide between these three.

stone fiber Apr 22, 2020, 2:36 AM

#

he's doing the same thing over on the mcmmo repo right now

#

maybe he's just the first in a new line of mkultra test subjects

weary grove Apr 22, 2020, 2:36 AM

#

look at this https://github.com/whitepacket/Stinger-Tor/issues/4

GitHub

give me a demo command to run that program · Issue #4 · whitepacket...

i am trying run online but stinger.py look this error https://repl.it/repls/FrankBurlywoodMalware but here ok https://repl.it/repls/SpotlessAllContent what do i need a .onion site for? i thought th...

#

what do i need a .onion site for? i thought the program was executing ddos attack using proxies provided by tor browser

#

But, alas, the tool does something different

Python-coded Tor DoS tool with slow-GET attack and GET flood that can't be filtered.

#

there is no way to learn if only 1 of the objects is learning; learning is reciprocal; that is why bill gates and elon musk did not put their children in ordinary school, teachers do not want to teach, teachers just want to repeat light data to earn food to survive;

#

This line convinced me he is definitely a crank, and not a garden-variety troll

#

i am coching, psicology, neuro scientist, and full stack developer in all plataform and language, and know all universe languages;

#

claims to be a "full stack developer in all plataform and language"
can't even do basic research on the MC protocol

#

Honestly, I'm convinced they're not a troll or severely misinformed - they're in need of psychiratic help

frigid anvil Apr 22, 2020, 6:00 AM

#

https://github.com/PaperMC/Waterfall/pull/488

GitHub

Add exception reporting event by theminecoder · Pull Request #488 ·...

Since bungeecord has gone and made the plugin manager a final class (which is a good thing in some regards) there is no way to wrap around it to handle exception catching for commands and events.
T...

#

❤️

harsh harbor Apr 22, 2020, 7:29 AM

#

@frigid anvil I don't know if that PR is yours or not

#

but could not it be good if all exceptions parent class was not Exception

#

maybe ProxyException

wide maple Apr 22, 2020, 7:29 AM

#

It’s not his PR

#

notlikecatcowboy

harsh harbor Apr 22, 2020, 7:30 AM

#

is it yours?

wide maple Apr 22, 2020, 7:33 AM

#

No the only PR to paper I have open currently is 1.16 snapshot support for Travertine. I need to move that to Waterfall

trail plume Apr 22, 2020, 7:36 AM

#

No, that's somebody else

#

I mean, their dumcord nick literally shares their github nick

fringe aspen Apr 22, 2020, 9:33 AM

#

all of the exceptions in the pr already have a root ProxyException class if you looked at the pr

harsh harbor Apr 22, 2020, 10:38 AM

#

oh i see

#

my bad

chilly coral Apr 22, 2020, 11:08 AM

#

Hey, i made my own waterfall fork using travertine as a base model and I was wondering when should I use the upstreamCommit script ?

trail plume Apr 22, 2020, 11:11 AM

#

Whenever you're doing a commit that updates upstream

#

That script just creates a commit message, basically

chilly coral Apr 22, 2020, 11:18 AM

#

Humm, ok so for example, if my fork is 6 commits outdated from waterfall, i do merge > patch> rebuild patches > upstream commit ?

trail plume Apr 22, 2020, 11:20 AM

#

yes

#

https://github.com/PaperMC/Waterfall/commit/e10d558b8b8a8156733df8f81775dee704e06072

GitHub

Updated Upstream (BungeeCord) · PaperMC/Waterfall@e10d558

Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

BungeeCord Changes:
f1c32f8...

#

it just creates those commit messages

chilly coral Apr 22, 2020, 11:28 AM

#

Oke thanks zzz ❤️

weary grove Apr 22, 2020, 2:24 PM

#

@trail plume I have created the PR for bumping Netty https://github.com/PaperMC/Waterfall/pull/489

GitHub

Bump Netty to 4.1.49.Final by astei · Pull Request #489 · PaperMC/W...

This issue includes the fix for netty/netty#10165, also known as "bungeecrasher" or "bungeespammer" amongst other names.

stone fiber Apr 22, 2020, 2:35 PM

#

@trail plume any thoughts on that exception event PR?

trail plume Apr 22, 2020, 2:36 PM

#

Not really looked at it yet, but the overall intent is good

grizzled thistle Apr 22, 2020, 2:37 PM

#

📎 unknown.png

#

AHH

#

finally

chilly coral Apr 22, 2020, 3:05 PM

#

can this help with malformed packets attacks ?

bleak current Apr 22, 2020, 3:22 PM

#

yes and no

sinful swift Apr 22, 2020, 3:38 PM

#

Hi, i'm starting developing a Bungee/Waterfall plugin. I found out that i will need some kind of connection between bungeecord and bukkit server. I was looking for it but the only thing I found is Plugin Messaging Channel that (if i'm not wrong) only provides me sending packets to players.

trail plume Apr 22, 2020, 3:39 PM

#

you send it to the player and the proxy intercepts it

sinful swift Apr 22, 2020, 3:39 PM

#

What if there are no players on server?

trail plume Apr 22, 2020, 3:40 PM

#

then that's just not gonna work

#

you'd need to look into an alternative system for that

sinful swift Apr 22, 2020, 3:40 PM

#

Yes i'm asking for alternative system.

trail plume Apr 22, 2020, 3:40 PM

#

e.g. opening your own http server or something, or using something like redis

sinful swift Apr 22, 2020, 3:41 PM

#

redis?

bleak current Apr 22, 2020, 3:41 PM

#

.g redis

lean gobletBOT Apr 22, 2020, 3:41 PM

#

(DiscordBot) https://redis.io/ -- Redis: "Redis is an open source (BSD licensed), in-memory data structure store, used as a database, cache and message broker. It supports data structures..."

bleak current Apr 22, 2020, 3:41 PM

#

or rabbitmq even

#

whatever fits

#

if you need to do rpc mostly then http is fine

#

just pull up a http server

sinful swift Apr 22, 2020, 3:41 PM

#

OK, thank you.

bleak current Apr 22, 2020, 3:41 PM

#

using NanoHTTPD or Netty

#

Netty is harder but you'll get speed (gotta save nanoseconds smh) and don't have to bundle in another library

sinful swift Apr 22, 2020, 3:46 PM

#

Are there any examles of usage of Netty with Bungee?

bleak current Apr 22, 2020, 3:53 PM

#

explain?

#

you want to build http server using it or tap into minecraft pipeline?

sinful swift Apr 22, 2020, 4:03 PM

#

Nevermind I think I will do it myself. Thank you for helping me very much.

bleak current Apr 22, 2020, 4:05 PM

#

there isn't much related to bungee itself with netty

#

you'll simply use netty api, build up your own Bootstrap and handlers

#

and that's it

sinful swift Apr 22, 2020, 4:30 PM

#

Also it is my first Bungee plugin, so i'm not sure if I will realy need it. Can bungeecord/watefrall do something in spigot server? (eg. set block to air, change players gamemode)

#

My question may seem very stupid

fervent geyser Apr 22, 2020, 4:30 PM

#

Not really

trail plume Apr 22, 2020, 4:31 PM

#

no, their state is entirely seperate

fervent geyser Apr 22, 2020, 4:31 PM

#

With some way around, everything is possible tho feelsRareMan

trail plume Apr 22, 2020, 4:31 PM

#

you'd need to send a message to the server to do something to the world, etc

sinful swift Apr 22, 2020, 4:31 PM

#

that meens i will need to use netty

#

Thank you

fervent geyser Apr 22, 2020, 4:31 PM

#

I am using Redis for that tbh

sinful swift Apr 22, 2020, 4:32 PM

#

I need to send single "messages" to spigot servers

#

will redis be good for that?

fervent geyser Apr 22, 2020, 4:32 PM

#

pub/sub? 😄

runic tundra Apr 22, 2020, 4:33 PM

#

ProxiedPlayer player = (ProxiedPlayer) event.getWhoClicked();
                    ServerInfo target = ProxyServer.getInstance().getServerInfo("survival");
                    player.connect(target);

#

Error:

#

[12:32:41 ERROR]: Could not pass event InventoryClickEvent to Hub v1.0-SNAPSHOT
java.lang.NoClassDefFoundError: net/md_5/bungee/api/connection/ProxiedPlayer
at com.castve.hub.Hub.onClick(Hub.java:71) ~[?:?]

#

Line 71:ProxiedPlayer player = (ProxiedPlayer) event.getWhoClicked();

bleak current Apr 22, 2020, 4:33 PM

#

don't mix and match bungee/bukkit api

fervent geyser Apr 22, 2020, 4:33 PM

#

You are using bungee API on the spigot server

runic tundra Apr 22, 2020, 4:34 PM

#

So How do I use the plugin on a spigot server then?

#

How do I connect them via gui

trail plume Apr 22, 2020, 4:34 PM

#

use the plugin messaging channel

runic tundra Apr 22, 2020, 4:34 PM

#

paper*

#

Oh?

trail plume Apr 22, 2020, 4:34 PM

#

.g bungee messaging channel

lean gobletBOT Apr 22, 2020, 4:34 PM

#

(DiscordBot) https://www.spigotmc.org/wiki/bukkit-bungee-plugin-messaging-channel/ -- Bukkit & Bungee Plugin Messaging Channel | SpigotMC - High...: "Dec 21, 2018 ... The anatomy of a Plugin Message Packet is as such: The name of the "channel" (also named "tag" in BungeeCord) the plugin message..."

Bukkit & Bungee Plugin Messaging Channel | SpigotMC - High Performa...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

sinful swift Apr 22, 2020, 4:34 PM

#

:)

fervent geyser Apr 22, 2020, 4:35 PM

#

@sinful swift To be honest, I use Redis for everything, paired with GSON it's just awesome and easy to do

sinful swift Apr 22, 2020, 4:35 PM

#

GSON?

fervent geyser Apr 22, 2020, 4:35 PM

#

Google library for JSON

sinful swift Apr 22, 2020, 4:36 PM

#

Oh

#

I think i will try Netty

#

it sounds cool ;)

fervent geyser Apr 22, 2020, 4:36 PM

#

😇

weary grove Apr 22, 2020, 10:09 PM

#

And just like that, upstream pulls in 4.1.49.Final https://github.com/SpigotMC/BungeeCord/pull/2823

GitHub

Update Netty to 4.1.49.Final by Janmm14 · Pull Request #2823 · Spig...

Fixes #2822

lean gobletBOT Apr 22, 2020, 10:09 PM

#

inb4 everything breaks

bleak current Apr 22, 2020, 10:16 PM

#

"please test your PRs next time" reverts

#

hmm, (random of ["entity meta rewriting", "holding spacebar to leak the memory and get bungee killed by kernel", "...", ...]) broke

civic valve Apr 22, 2020, 10:19 PM

#

It's the same guy lmao

#

📎 5c07522dde2911eef5607636a9d8dbb0.png

bleak current Apr 22, 2020, 10:20 PM

#

i know, hence i said that

#

:p

#

hey, what event should I use to get the total player count whenever a player connects?

random comet Apr 23, 2020, 3:48 AM

#

omegalul

ornate jasper Apr 23, 2020, 4:33 AM

#

Great event

bleak current Apr 23, 2020, 4:43 AM

#

the whole map gets nuked

#

/nuke everyone do it

grizzled thistle Apr 23, 2020, 8:50 AM

#

@bleak current for the entire bungeecord network use getProxy().getOnlineCount()

bleak current Apr 23, 2020, 8:51 AM

#

yeah but I want to update a counter whenever a player connects/disconnects and i don't know what event to use

#

PES_Think

harsh harbor Apr 23, 2020, 8:55 AM

#

it is updated automatically

#

you don't need to manage online count manually

bleak current Apr 23, 2020, 8:55 AM

#

not for showing in minecraft 8029_Pepe_Invalid

trail plume Apr 23, 2020, 8:56 AM

#

PostLogin is the first event after that will be incremented

#

like, right bang after it

bleak current Apr 23, 2020, 8:56 AM

#

and for disconnections?

harsh harbor Apr 23, 2020, 8:56 AM

#

PlayerDisconnectEvent

bleak current Apr 23, 2020, 8:56 AM

#

PES_Hypers

#

perfect thanks

high lily Apr 23, 2020, 9:38 AM

#

do async tasks run on their own thread pool?

trail plume Apr 23, 2020, 9:41 AM

#

yes

high lily Apr 23, 2020, 9:41 AM

#

so runnning sync db querries should be fine in there

#

sync as in on that thread

trail plume Apr 23, 2020, 9:42 AM

#

Yes

high lily Apr 23, 2020, 9:42 AM

#

was ganna use taskchain but that simplifies that

trail plume Apr 23, 2020, 9:42 AM

#

taskchain won't work for waterfall

high lily Apr 23, 2020, 9:43 AM

#

oh ye forgot about that one

#

does paper async tasks also run in a thread pool?

harsh harbor Apr 23, 2020, 9:44 AM

#

Yes

trail plume Apr 23, 2020, 9:44 AM

#

yes

#

At the end of the day, you gotta shove those tasks somewhere

#

it's either use a pool or manage your own threads, which, like...

high lily Apr 23, 2020, 9:44 AM

#

ye I was wondering if they just dedicated like 1 thread

bleak current Apr 23, 2020, 1:33 PM

#

hey

#

i tried using PlayerDisconnectEvent to update my player counter but it's not updated in that event

#

is there any other event where it's updated?

chilly coral Apr 23, 2020, 1:40 PM

#

you can just do -1

#

i think the player is not yet removed from the player list

#

totally other thing, but i just noticed that UserConnection#connect method line 264 does not use the serverConnectTimeout value of the config

#

looks like this: http://p.tomcraft.fr/d3d750.png
should be like this: http://p.tomcraft.fr/50f3.png

#

i'll try to PR but i'm quite noob at patches

bleak current Apr 23, 2020, 1:47 PM

#

you can just do -1
true lmao

weary grove Apr 23, 2020, 8:05 PM

#

Just realized that with my Netty bump patch I didn't include a comment lol

#

doesn't matter, it wound up in Bungee anyway, and the patch was temporary/emergency

chilly coral Apr 24, 2020, 2:57 AM

#

What is the cycle for a PR to be approved ?

bleak current Apr 24, 2020, 3:37 AM

#

when cat has time and energy to merge basically

chilly coral Apr 24, 2020, 8:16 AM

#

Ok 👌

warped loom Apr 24, 2020, 8:43 AM

#

cat has no energy, sad cat

bleak current Apr 24, 2020, 9:19 AM

#

PES_SadCat

bleak current Apr 24, 2020, 9:55 AM

#

1000% cat irl

#

neat emote tbfh

chilly coral Apr 24, 2020, 9:57 AM

#

lol 😂

bleak current Apr 24, 2020, 10:51 AM

#

i assume this question has been asked before, is it possible for a future feature to have an update folder for Waterfall plugins too?

#

i tried to pr that

#

that didn't go too well

#

so no

#

"it's insecure, we shouldn't promote plugins to self update themselves"

#

told by md5, who was surprised that same feature exists in bukkit too

#

yeah thats a shame, i use it a lot on my minecraft instances

#

oh well, ty for testing tho

#

you can reimplement that feature pretty easily though

#

if [ -d plugins/update ]; then
    find plugins/update -name "*.jar" | while read -r f; do
        b="$(basename "${b}")"
        if [ -f plugins/"${b}" ]; then
            mv -v "${f}" plugins/"${b}"
        fi
    done
fi

#

using a shell script

#

untested, might work

#

might not

#

ah yea true, ty m8

thorny holly Apr 24, 2020, 4:39 PM

#

wizman, why //outline not work with polygonal regions

sly crown Apr 24, 2020, 4:40 PM

#

does walls work

#

why tf is this question here

#

lmao

thorny holly Apr 24, 2020, 4:43 PM

#

cause i don't wanna get on your discord lol

#

ah walls works

lean gobletBOT Apr 24, 2020, 5:12 PM

#

at least use #general, lol

thorny holly Apr 24, 2020, 9:34 PM

#

i didn't even realize this was waterfall

proper rampart Apr 26, 2020, 1:09 PM

#

I'm trying to make one addon plugin but can't find a way to disable my plugin if the dependant plugin isn't installed. Bukkit has getServer().getPluginManager().disablePlugin(this); but bungee doesn't. How can I do this?

#

I've tried java public void onEnable() { if (this.getProxy().getPluginManager.getPlugin(depend) == null) return; else { // do stuff } }

chilly coral Apr 26, 2020, 1:16 PM

#

There is a built-in dependency system

#

In the bungee.yml

proper rampart Apr 26, 2020, 1:16 PM

#

It works for bungee too? I didn't even consider that, thought it only worked on spigot.

#

Thanks.

chilly coral Apr 26, 2020, 1:17 PM

#

It works but in my memories, i think it is depend instead of depends

#

May be wrong

proper rampart Apr 26, 2020, 1:18 PM

#

📎 unknown.png

#

from intellij

#

let me check really quick

fervent geyser Apr 26, 2020, 1:18 PM

#

📎 unknown.png

#

It is depend

proper rampart Apr 26, 2020, 1:19 PM

#

okay, thanks

lean gobletBOT Apr 26, 2020, 1:28 PM

#

it is depends on Bungee https://github.com/SpigotMC/BungeeCord/blob/master/api/src/main/java/net/md_5/bungee/api/plugin/PluginDescription.java#L38

GitHub

SpigotMC/BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers. - SpigotMC/BungeeCord

#

depend is for Bukkit ;)

proper rampart Apr 26, 2020, 1:29 PM

#

well

#

thanks

#

yep works as intented

📎 unknown.png

chilly coral Apr 26, 2020, 1:35 PM

#

I knew there was a difference x)

lean gobletBOT Apr 27, 2020, 2:37 PM

#

no

sly crown Apr 27, 2020, 2:37 PM

#

he deleted

lean gobletBOT Apr 27, 2020, 2:37 PM

#

that was 5 hrs ago smh

#

can you please just freaking remove delete permission from normal users?

#

like seriously, that's one of the worst features of discord right after message editing without history

#

ok, well, actually: right after their stupid permissions system which doesn't allow revoken that shit. like wtf

#

I guess the solution would be to crete a bot that removes and reposts all the messages. lmao

round cloud Apr 27, 2020, 3:07 PM

#

Hi, what do you think about this https://github.com/SpigotMC/BungeeCord/pull/2688, do you think you can fix it in waterfall?

stone fiber Apr 27, 2020, 3:07 PM

#

fix what

#

if by fix you mean "revert this thing I dont like"

#

I doubt it, but maybe cat will bite

lean gobletBOT Apr 27, 2020, 3:09 PM

#

imo there is no need for that to begin with, it would be better for people needing more functionality to actually PR that functionality to the API

round cloud Apr 27, 2020, 3:16 PM

#

It's not about what I like, BPM (from developer of ProtocolSupport) works fine since 2015 without change, and now the bungeecord founder just have an idea, that he could merge 1 year old PR what has no other change than make some class private, because it's really bad that some plugin can edit bungeecord plugin manager.. someone could reload the plugin :O that's terrible, if he has 100 players on his server, he need to restart whole bungeecord, because reloading is bad, there could be some plugin that may not works well with reload (you would restart server anyway if the plugin failed to load)

stone fiber Apr 27, 2020, 3:17 PM

#

yeah see Im still on the "no this is stupid lets not revert it" side

#

and your rambling response doesnt really convince me otherwise

#

but Im not the waterfall guy so it may still happen

lean gobletBOT Apr 27, 2020, 3:18 PM

#

"works fine" it fucking hacks internal code

round cloud Apr 27, 2020, 3:19 PM

#

And why do you think this is stupid? Maybe if you had your core server logic in bungeecord plugin with very often updates and a lot of players on your server, you would see it from a other side

stone fiber Apr 27, 2020, 3:19 PM

#

If your core logic is replacing the entire plugin loader, your core logic is broken

weary grove Apr 27, 2020, 3:19 PM

#

Well, "plugin managers" are all terrible, they leak memory and a lot of plugins don't tolerate getting arbitrarily unloaded and reload, same reason why it's not recommended to use /reload

lean gobletBOT Apr 27, 2020, 3:20 PM

#

als why tf are you pushing updates "very often", that sounds like you are not testing at all

#

and if you really want to update stuff often: use your own module loader

weary grove Apr 27, 2020, 3:20 PM

#

I mean, pushing updates often is literally what continuous deployment is

#

It's not a bad thing, if you do it correctly

lean gobletBOT Apr 27, 2020, 3:21 PM

#

well imo you can't do it correctly but ¯_(ツ)_/¯

weary grove Apr 27, 2020, 3:21 PM

#

We use a full CI/CD flow at Mineteria. Trust us, you can do it.

sly crown Apr 27, 2020, 3:21 PM

#

never trust a tux

lean gobletBOT Apr 27, 2020, 3:21 PM

#

so how do you reload plugins without restarts?

round cloud Apr 27, 2020, 3:21 PM

#

Ok, but I'm plugin developer, and I don't want to restart my entire network to load newer version of the plugin, my bungeecord uses just a max of 1GB of ram and I never had ram leak, even on my minigames server I often reload my plugins because of a new features, and I also never had a leaked ram

weary grove Apr 27, 2020, 3:21 PM

#

We usually do one a day but in some cases (emergencies) we will do up to 3

lean gobletBOT Apr 27, 2020, 3:22 PM

#

also why not wait a day/week until the normal, schedules restart?

round cloud Apr 27, 2020, 3:22 PM

#

I dont have restarts at all

weary grove Apr 27, 2020, 3:22 PM

#

We don't reload plugins. We just spin up new servers and let the old ones shutdown.

lean gobletBOT Apr 27, 2020, 3:22 PM

#

uses 1GB

round cloud Apr 27, 2020, 3:22 PM

#

My servers have uptime up to 30 days, and bungeecord up to 1 year

lean gobletBOT Apr 27, 2020, 3:22 PM

#

claims he doesn't leak

#

wat

#

bungee can run fine with 512MB, hell I've used 256 before without plugins and no issues xD

weary grove Apr 27, 2020, 3:23 PM

#

We have the ability to gate things such that only part of the server can get new servers up - this is very useful as we can target emergency bugfixes where they're needed

round cloud Apr 27, 2020, 3:23 PM

#

Depends how many plugins, players, and so on, but 1GB is usage of my whole docker container, bungeecord have maybe about 500MB less, because there is whole linux

weary grove Apr 27, 2020, 3:25 PM

#

Still, unless your plugins are designed to tolerate reloads, it's not advisable. Now perhaps you use largely your own plugins - great, then this works for you. You also have the ability to remove the "dumb feature" from Waterfall yourself!

round cloud Apr 27, 2020, 3:26 PM

#

Yes, but I want to know if my PR would pass, because a lot of people are just negative about this and they don't know why

trail plume Apr 27, 2020, 3:37 PM

#

We've already had a feature request sitting around for something that would negate the specific usecase there

#

it's very rare that we find justification to revert an upstream change, and tbqh, I'd much rather have proper API for the behavior people are tryna aim for

#

not that bungees plugin system is even great for this type of thing

round cloud Apr 27, 2020, 3:40 PM

#

I never had a problem with a plugin reload in bungee or spigot, the one problem I can think of is when I reload a dependency of some plugin or when the plugin has player register and he register players only via join event

trail plume Apr 27, 2020, 3:41 PM

#

never had a problem

#

highlights one area in which plugins often derp this

#

reloading plugins on the proxy is even worse, because it's literally never expected that a plugin would reload, so they're never designed for it

round cloud Apr 27, 2020, 3:41 PM

#

Yes, why would I reload plugin what can't handle a reload, or it's dependency to some other plugin

trail plume Apr 27, 2020, 3:42 PM

#

what is and isn't reloadable is not clear to end users

round cloud Apr 27, 2020, 3:42 PM

#

If it failed, I would restart server anyway

#

But most of the time, I don't need to restart the server

trail plume Apr 27, 2020, 3:42 PM

#

But, as I've said, I'm not fond of the idea of just blindly reverting PRs because somebody isn't happy that their hack no longer works

#

If there is enough demand for it, maybe

fervent geyser Apr 27, 2020, 3:42 PM

#

Would be cool to have something like onReload()

trail plume Apr 27, 2020, 3:42 PM

#

But, I would sooner have proper API for the task

#

already does

#

there is the reload event

round cloud Apr 27, 2020, 3:43 PM

#

It's not like everyone updates a bungee, I haven't updated it since 2020 maybe, just now and now I found it was changed month ago, so I downgraded the bungee

lean gobletBOT Apr 27, 2020, 3:43 PM

#

yeah, plugins that support it listen for the /greload command and do their shit there

round cloud Apr 27, 2020, 3:44 PM

#

It's about the BPM works perfectly last 5 years without any modifications, and now someone mark class like private, because he don't know what to do and he want to make some commits on github

lean gobletBOT Apr 27, 2020, 3:44 PM

#

doesn't work perfrectly

#

claims it works perfectly

#

thonk

trail plume Apr 27, 2020, 3:45 PM

#

md opted to make the change

lean gobletBOT Apr 27, 2020, 3:45 PM

#

if you care that much just revert the change and be done with it? lmao

round cloud Apr 27, 2020, 3:45 PM

#

I never said that, @lilac crystal

trail plume Apr 27, 2020, 3:45 PM

#

Yes, some rando kid shoved it up, but, md agreed with the behavior

round cloud Apr 27, 2020, 3:45 PM

#

BPM = BungeePluginManager, plugin by the ProtocolSupport developer @real cave

lean gobletBOT Apr 27, 2020, 3:46 PM

#

two stupidly hacky plugins, yes

trail plume Apr 27, 2020, 3:46 PM

#

Basically, I've stated my opinion on it

lean gobletBOT Apr 27, 2020, 3:46 PM

#

with known issues xD

round cloud Apr 27, 2020, 3:46 PM

#

So I stay on build from january, and I'll wait for some proper api (there was nothing wrong with current), and I send PR to BPM

trail plume Apr 27, 2020, 3:47 PM

#

there was nothing wrong with current

#

Yes, there was

round cloud Apr 27, 2020, 3:47 PM

#

And what?

lean gobletBOT Apr 27, 2020, 3:47 PM

#

have fun with all the bugs that are in your old version

trail plume Apr 27, 2020, 3:47 PM

#

That class could have been argued to be final the entire time

fervent geyser Apr 27, 2020, 3:47 PM

#

(the old netty version for example)

sly crown Apr 27, 2020, 3:47 PM

#

nullping kekwhyper

trail plume Apr 27, 2020, 3:47 PM

#

This is not the first case where md felt he shoulda made something final but didn't until a few years later

#

Either way, that's my view, I have very little inclination to revert that commit, if somebody wants to create a PR to implement proper API for the functionality there, we can look into it

round cloud Apr 27, 2020, 3:50 PM

#

But the onEnable() and onDisable() method is enough, plugin reload just do onDisable(), loads the plugin again, and call the onEnable() method, or you want to have plugin reloading built in in Waterfall?

trail plume Apr 27, 2020, 3:50 PM

#

or you want to have plugin reloading built in in Waterfall

#

Well..

round cloud Apr 27, 2020, 3:51 PM

#

I can do that, but there would be experts that will say that not every plugin can be reloaded, and my PR would be denied

trail plume Apr 27, 2020, 3:51 PM

#

That would be proper API if the feature was... erm... built into the API...

#

We've already approved the feature for a proper API on our issue tracker

#

There is just been pretty much 0 interest for somebody to actually build/implement such API

round cloud Apr 27, 2020, 3:53 PM

#

Maybe that was the md5 intention manythink

trail plume Apr 27, 2020, 3:53 PM

#

approved for waterfall

#

i have heavy doubts that md would consider such a pr, but 🤷‍♂️

round cloud Apr 27, 2020, 3:54 PM

#

But the functionality would be the same as it is now with BPM plugin, there will be nothing else than call onDisable, reload the plugin can call onEnable

trail plume Apr 27, 2020, 3:55 PM

#

Not really

#

It would be much easier to do in the proxy itself

#

proper events could be added so that plugins can deal with such state changes more gracefully, etc

#

So, yea, the sole intent is the same, to un/re/load plugins

#

The implementation on the other hand would be much more universal and viable for devs to actually pick up on if they want if there is actually proper API for the job

round cloud Apr 27, 2020, 3:58 PM

#

Or, you can do for cycle in the onEnable what would add players to player register (if there is any), that's the only problem why some plugins can't be reloaded, and there is very few of them

#

Because developer should be aware that onEnable should be called not only when server is starting

trail plume Apr 27, 2020, 3:59 PM

#

That's false

#

Bungee doesn't have reloading support built in

#

Nor does bungee even provide the means for them to handle this stuff safely

real cave Apr 27, 2020, 4:00 PM

#

Docs ain't specify when plugin enables either.

round cloud Apr 27, 2020, 4:00 PM

#

Adding onReload method and telling everyone he needs to implement that would break a lot of plugins what works well with current reloading, and no one would add that method

real cave Apr 27, 2020, 4:00 PM

#

So you should be expecting for plugin to be enabled any time.

trail plume Apr 27, 2020, 4:00 PM

#

The lack of reload support is an ecosystem limitation

#

API doesn't garauntee jack bar they'll start at some point, in the real world for plugins, that's on startup before the connection listeners have even been registered

real cave Apr 27, 2020, 4:09 PM

#

There is no problem to update BungeePluginManger to those changes tho.

#

Just need to find some free time.