#waterfall-dev | PaperMC | Page 5

slim viper Jun 5, 2019, 6:31 PM

#

That's what I did. Followed these docs https://www.spigotmc.org/wiki/bukkit-bungee-plugin-messaging-channel/#connect

Bukkit & Bungee Plugin Messaging Channel | SpigotMC - High Perform...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

steel jungle Jun 5, 2019, 6:32 PM

#

What's your end code?

slim viper Jun 5, 2019, 6:33 PM

#

player.sendPluginMessage(MRPG.inst(), "BungeeCord", out.toByteArray());

steel jungle Jun 5, 2019, 6:34 PM

#

That's not all of it. 😛

slim viper Jun 5, 2019, 6:34 PM

#

What do you mean by "end code" ?

steel jungle Jun 5, 2019, 6:34 PM

#

The code after you finished the tutorial.

slim viper Jun 5, 2019, 6:34 PM

#

Ohh like that

#

https://hastebin.com/gexifojumi.java

steel jungle Jun 5, 2019, 6:36 PM

#

https://discordapp.com/channels/289587909051416579/289587909051416579/473255144725807116

slim viper Jun 5, 2019, 6:37 PM

#

Not sure if that is still relevant

#

The channel is being registered explicitly, like so:

getServer().getMessenger().registerOutgoingPluginChannel(this, "BungeeCord");
getServer().getMessenger().registerIncomingPluginChannel(this, "BungeeCord", new IncomingBungeeHandler());

slim viper Jun 5, 2019, 6:59 PM

#

Okay, turns out I should've just used a different stream than what they say in the tutorial

#

¯_(ツ)_/¯

bleak current Jun 5, 2019, 7:59 PM

#

bungeecord:main or w.e that was

#

since 1.13 you have to do that yep

coral lichen Jun 7, 2019, 7:02 AM

#

is there any public maven repo for waterfall?

fringe aspen Jun 7, 2019, 9:29 AM

#

the paper repo has it iirc (i generally use whatever ever the minecraft dev plugin for intellij provides me)

bleak current Jun 7, 2019, 12:29 PM

#

paper's repo has waterfall api artifacts, correct

eager hinge Jun 17, 2019, 10:21 AM

#

https://github.com/PaperMC/Travertine/issues/107

GitHub

"always" & "never" duplicate string · Issue #107 · PaperMC/Trave...

The last months I been taking care of my bungeecord, because I felt the bungeecord really lag. For any reason my bungeecord (Travertine) is using a lot of RAM, and constantly have spikes due GCs. I...

#

Can someone help me with this

trail plume Jun 17, 2019, 10:23 AM

#

It's scoreboard teams

eager hinge Jun 17, 2019, 10:23 AM

#

Oh, really?

#

And?

trail plume Jun 17, 2019, 10:23 AM

#

With waterfall, I'd be somewhat tempted to ensure that you have the string deduplication flag set for the JVM

eager hinge Jun 17, 2019, 10:24 AM

#

How I do that?

#

-XX:+UseG1GC -XX:+UseStringDeduplication -XX:+PrintStringDeduplicationStatistics

#

?

#

Exist a way to check the plugin causing the issue?

#

Should be a spigot plugin, right?

trail plume Jun 17, 2019, 10:27 AM

#

Issue is with how scoreboard teams are handled and stored in memory, they use strings which ends up basically filling up the heap when you have a lot of teams, that could have technically been represented with an enum, but mojang opted to use a string \o/

#

And those flags should help, but string deduplication has it's own performance concerns, and yup, teams will be created by a plugin, either on the proxy or on the server itself

eager hinge Jun 17, 2019, 10:28 AM

#

gotcha

trail plume Jun 17, 2019, 10:28 AM

#

(Well, pretty much generally always down to a plugin when you start having so many teams that it becomes an issue*)

eager hinge Jun 17, 2019, 10:28 AM

#

oh, I see, thanks

ruby dust Jun 17, 2019, 11:03 AM

#

You can try a velocity proxy, it does not store scoreboards and teams in memory.

trail plume Jun 17, 2019, 11:06 AM

#

I wonder if we'd break anything making that an enum

bleak current Jun 17, 2019, 11:13 AM

#

wdym enum

#

ah, the scoreboard flags

#

ugh it's a data class

trail plume Jun 17, 2019, 11:16 AM

#

Yeaaa, probably going to have to delombok that if we wanna play with it

#

I'm thinking we shouldn't ever see a non-expected value in there, but we can deal with that by just having a fallback string I'd figure

#

Not clean and not ideal, but least breaking method I can see :/

bleak current Jun 17, 2019, 11:27 AM

#

i'll try to implement that into my fork

#

but then i need to figure out what plugins do use scoreboard teams

#

and test the shit out from them

#

https://gist.github.com/mikroskeem/2de332b942242b02d9c4e4e872135700

Gist

yeet.patch

GitHub Gist: instantly share code, notes, and snippets.

#

should do the trick

#

btw @trail plume what about my packet construction patch? :D

trail plume Jun 17, 2019, 11:44 AM

#

Oh, sorry, I've not really found the time/motiviation to run through too much recently

bleak current Jun 17, 2019, 11:44 AM

#

i think it should be safe to pull, haven't blown up in my environment yet

#

oh man wat

#

📎 image.png

#

this means that collision rule is initialized only when proto is >= 1.9

#

so in Team class, collision rule might be null as well

#

visible disgust

bleak current Jun 17, 2019, 12:13 PM

#

https://github.com/mikroskeem/MikroCord/blob/master/Waterfall-Proxy-Patches/0040-Save-memory-on-scoreboard-teams.patch

GitHub

mikroskeem/MikroCord

Personal Waterfall fork. Contribute to mikroskeem/MikroCord development by creating an account on GitHub.

#

should be fine i think

harsh harbor Jun 17, 2019, 2:14 PM

#

@bleak current u did not get how tcp fast open works

bleak current Jun 17, 2019, 2:14 PM

#

wdym

harsh harbor Jun 17, 2019, 2:15 PM

#

https://github.com/mikroskeem/MikroCord/blob/master/Waterfall-Proxy-Patches/0029-TCP-fast-open.patch#L115

GitHub

mikroskeem/MikroCord

Personal Waterfall fork. Contribute to mikroskeem/MikroCord development by creating an account on GitHub.

#

you should only do that for SERVER_CHILD

#

not for client connections

bleak current Jun 17, 2019, 2:15 PM

#

ah ok

#

i didn't bother looking into it because there isn't much documentation for it apparently

trail plume Jun 17, 2019, 2:15 PM

#

TCP Fast Open (TFO) is an extension to speed up the opening of successive Transmission Control Protocol (TCP) connections between two endpoints

#

First line from a wiki article, but seems like it all falls in line with what they're saying

eager hinge Jun 17, 2019, 3:08 PM

#

I asked to my developer and he already delete the Team and Scoreboard objetive when player leaves

#

Like
Set<Team> team = ((Player) sender).getScoreboard().getTeams(); for(Team team2 : team) { team2.unregister(); }

#

So, I do not know where is coming from the problem

#

@trail plume exist a way to know where is coming from the problem?

trail plume Jun 17, 2019, 3:13 PM

#

take a look at the dump and see what teams are holding onto those objects

eager hinge Jun 17, 2019, 3:16 PM

#

okey

#

and exist a way to disable team saving for travertine?

#

As I know is useless (?)

trail plume Jun 17, 2019, 3:17 PM

#

The issue is not the fact that it's saving teams as much as bungee keeps them in memory for its own API

#

It's one of those fun annoyances with bungeecord

eager hinge Jun 17, 2019, 3:18 PM

#

yes, pretty much xD

#

Because the GC kill my server

#

Sometimes spikes

#

And the Ping increase

eager hinge Jun 17, 2019, 3:45 PM

#

What another thing uses Teams?

trail plume Jun 17, 2019, 3:48 PM

#

Plugins using scoreboards, anything using scoreboards, etc

eager hinge Jun 17, 2019, 4:20 PM

#

just scoreboards?

#

Nametags? Bossbar?

trail plume Jun 17, 2019, 4:20 PM

#

Teams are a part of scoreboards

eager hinge Jun 17, 2019, 4:20 PM

#

oh, okey

eager hinge Jun 17, 2019, 5:22 PM

#

And is viable disable the Team on Travertine?

#

https://github.com/mikroskeem/MikroCord/blob/master/Waterfall-Proxy-Patches/0040-Save-memory-on-scoreboard-teams.patch

GitHub

mikroskeem/MikroCord

Personal Waterfall fork. Contribute to mikroskeem/MikroCord development by creating an account on GitHub.

bleak current Jun 17, 2019, 5:29 PM

#

experimental

#

so feel free to use at your own risk

eager hinge Jun 17, 2019, 6:49 PM

#

oh

#

I added those flags

#

📎 unknown.png

#

@trail plume that would help?

harsh harbor Jun 17, 2019, 9:00 PM

#

Or you can just remove scoreboard handling on proxy completely

weary grove Jun 18, 2019, 12:37 AM

#

at the risk of breaking plugin compatibility, because this is BungeeCord after all

harsh harbor Jun 18, 2019, 9:04 AM

#

Well, at least make an option that will responsible for processing scoreboard packets or no

trail plume Jun 18, 2019, 9:05 AM

#

Not viable without the disable entity metadata option working 100% afaik

#

(Are scoreboards reset by the client itself when you jump world or not?)

harsh harbor Jun 18, 2019, 9:06 AM

#

lemme check

#

i think yes, but

#

one moment

trail plume Jun 18, 2019, 9:06 AM

#

afaik, without that system being disabled, bungee has to remove them for the client

harsh harbor Jun 18, 2019, 9:07 AM

#

if you send respawn packet - nope

#

but if you send JoinGame - yep

trail plume Jun 18, 2019, 9:07 AM

#

So, yea, for such an option to actually be viable, entity metadata rewriting needs to be disabled

harsh harbor Jun 18, 2019, 10:18 AM

#

@bleak current I was looking on your's fork and, what's the point of this
https://github.com/mikroskeem/MikroCord/blob/master/Waterfall-Proxy-Patches/0031-Restore-stdout-stderr-on-exit.patch

GitHub

mikroskeem/MikroCord

Personal Waterfall fork. Contribute to mikroskeem/MikroCord development by creating an account on GitHub.

bleak current Jun 18, 2019, 10:18 AM

#

fixes cosmetical issue introduced by /grestart

#

that's all

#

as logger cannot be accessed in shutdown hook thread

#

and shows dumb useless warnings

#

well, stdout/err is redirected to logger normally

#

it has bunch of pointless shit very likely, but it's for my own use so /shrug

sick skiff Jun 20, 2019, 7:11 PM

#

https://ci.md-5.net/job/BungeeCord/ws/api/target/apidocs/net/md_5/bungee/api/connection/package-summary.html
or embedded server
does this mean i can create a "void" dummy server with a bungeecord plugin?

#

i have not found any other documentation on such "embedded server"s

trail plume Jun 20, 2019, 7:14 PM

#

There is no embeded server

sick skiff Jun 20, 2019, 7:14 PM

#

i get that, but can i add or create one?

trail plume Jun 20, 2019, 7:15 PM

#

If you went to the length of reimplementing enough of a server, yes

#

Bungee doesn't have support for that build in

sick skiff Jun 20, 2019, 7:16 PM

#

cool! i might investigate some more in that case, it would be useful for wait-queue or login servers

primal granite Jun 21, 2019, 10:34 PM

#

/gamerule announceAdvancements false

#

not working

weary grove Jun 21, 2019, 11:38 PM

#

...Waterfall doesn't control game rules, that's a server setting.

sick skiff Jun 22, 2019, 7:54 AM

#

first time really screwing with java, are there any obvious code mistakes? https://github.com/vik1395/BungeeAuth-Minecraft/pull/27/files

#

(other than the weird whitespace diffs)

primal granite Jun 22, 2019, 8:34 AM

#

so, how to disable announce for archivements ?

#

on server

trail plume Jun 22, 2019, 11:20 AM

#

You use the command on the servers, achivements/whatever are 100% irrelevant to this channel

#

Worth noting that gamerules on the server are pre-world, so you'll need to set the gamerule in every world

dark perch Jun 22, 2019, 11:32 AM

#

There is a option on bukkit.yml to deactivate them isnt it?

gritty oracle Jun 25, 2019, 3:01 AM

#

Is there any way to assign op bungeecord.command.server without adding the permission to a group, just add it to /op?

trail plume Jun 25, 2019, 3:02 AM

#

Bungee doesn't have the concept of op

gritty oracle Jun 25, 2019, 3:02 AM

#

Yeah I'm trying to find a way around that without adding the permission to a group

deft trail Jun 25, 2019, 8:38 AM

#

can someone pretty please with a cherry on top update travertine 😃

bleak current Jun 25, 2019, 10:59 AM

#

https://github.com/PaperMC/Travertine/pull/109

GitHub

Updated Upstream by mikroskeem · Pull Request #109 · PaperMC/Tra...

#

does anyone happen to know an alternative way to git am --show-current-patch | patch -p1 --no-backup-if-mismatch if git am bitches about lacking sha1 btw?

trail plume Jun 25, 2019, 11:53 AM

#

I coulda sworn that I did?

#

Oh, I did, I just completly brain farted and forgot to push \o/

deft trail Jun 25, 2019, 5:04 PM

#

thanks cat! appreciate it!

chilly coral Jun 27, 2019, 10:21 AM

#

Hello, has anybody else experienced the same issue ? https://github.com/PaperMC/Waterfall/issues/378
I'm running the latest Waterfall and it's a real problem :/
(I'm not the author of the issue on GitHub)

GitHub

issue with disable_entity_metadata_rewrite · Issue #378 · PaperM...

Hey, if I set "disable_entity_metadata_rewrite: true" in the waterfall config and players log out in the nether, they can no longer log in as they will get stuck on "load...

trail plume Jun 27, 2019, 10:23 AM

#

Known issue

chilly coral Jun 27, 2019, 10:24 AM

#

Ok, i know I can't ask for an ETA but is it a bug planned to be fixed ?

trail plume Jun 27, 2019, 10:25 AM

#

No real ETA, I need a deeper dive into the issue and time is limited and the tooling available to help figure out what's missing easily is virtually inexistent

chilly coral Jun 27, 2019, 10:31 AM

#

Could it be a problem in packets order ?

trail plume Jun 27, 2019, 10:31 AM

#

Potentially

#

But that's why I need to dig into it

sharp isle Jun 27, 2019, 12:32 PM

#

I may have found a fix

#

https://i.antbig.fr/sUxACe.png

chilly coral Jun 27, 2019, 12:39 PM

#

(it works, i tested)

#

both ways

trail plume Jun 27, 2019, 12:40 PM

#

Yea, I was looking at that code a bit back, but wasn't 100% familiar with what was going on, and didn't have the time to get all the mess I needed up to test it all \o/

#

If it's working and you wanna submit a PR, go for it 😃

chilly coral Jun 27, 2019, 12:41 PM

#

server 1 world -> server 2 world
server 1 world -> server 2 nether
server 1 nether -> server 2 nether
server 1 nether -> server 2 world

#

the fact is that the dimension is already specified by the Login packet, so when the client receive the Respawn packet it just ignore it because he thinks he's in the right dimension

#

so the fix is to send the respawn packet before login when the target dimension is different

#

(i was explaining what caused the bug to happen 😃 )

trail plume Jun 27, 2019, 12:46 PM

#

Yea, had a feeling it was going to be something fun like that, just didn't wanna start throwing packets all around blindly \o/

bleak current Jun 27, 2019, 12:48 PM

#

oh yeah that might be it

chilly coral Jun 27, 2019, 12:51 PM

#

We are not so familiar with patch mecanism 😕

trail plume Jun 27, 2019, 12:51 PM

#

easiest option is to cd into the waterfall-proxy repo and git log and find the patch which adds that change and grab the commit hash

#

then git commit --fixup=##### and git rebase -i --autosquash upstream/upstream

sharp isle Jun 27, 2019, 1:06 PM

#

Is it ok if multiple patch are edited ? https://i.antbig.fr/Y0oGRi.png

trail plume Jun 27, 2019, 1:06 PM

#

Better if that didn't happen, but such is how the patch system works

chilly coral Jun 27, 2019, 1:07 PM

#

i will never understand how it works D:

#

x)

trail plume Jun 27, 2019, 1:08 PM

#

It's git, but... kinda abused

#

e.g. the commands I told you, if you did that on a real repo you'd probably be shot by somebody

sharp isle Jun 27, 2019, 1:13 PM

#

well I 've made my first PR 😃

trail plume Jun 27, 2019, 1:13 PM

#

Your branch is outta sync

#

https://github.com/antbig/Waterfall

GitHub

antbig/Waterfall

BungeeCord fork that aims to improve performance and stability. - antbig/Waterfall

sharp isle Jun 27, 2019, 1:14 PM

#

I may have missed a step

bleak current Jun 27, 2019, 1:14 PM

#

aand you missed // Waterfall comments

#

:p

trail plume Jun 27, 2019, 1:14 PM

#

Already in a waterfall block

bleak current Jun 27, 2019, 1:14 PM

#

oh ok

#

then it's okay

sharp isle Jun 27, 2019, 1:17 PM

#

You can do the fix yourself if you want, I don't understand why my branch is not sync

chilly coral Jun 27, 2019, 1:31 PM

#

while antbig is doing some magic for his PR, I would need help for an issue i have, which i can't figure it out but i can't talk about it in a public channel :/
@trail plume are you ok to PM ?

trail plume Jun 27, 2019, 1:32 PM

#

Depends on the nature of the issue

chilly coral Jun 27, 2019, 1:34 PM

#

it's a paper related issue, so maybe i should go #paper-help ?

trail plume Jun 27, 2019, 1:35 PM

#

My Q is more around why it can't be discussed in a public channel

#

Also, I'll sort the patch out

#

(If that's any easier for you guys?)

sharp isle Jun 27, 2019, 1:35 PM

#

yes 😃

#

I've try both Methodes but none of them are working

chilly coral Jun 27, 2019, 1:36 PM

#

it's a paper 1.12.2 related issue, i have 2 timings to show you. The first is "before update" and the second is with the latest paper 1.12.2. The only difference is the paper version between theses two timings.

#

i just want to send you the timings in PM

trail plume Jun 27, 2019, 1:37 PM

#

Generally better off to just link in #paper-help, more eyes on the issue

wise charm Jun 30, 2019, 7:24 AM

#

https://gyazo.com/cec5bdb3088ce2b1b19b9f2f49fd2c0e

Gyazo

#

wtf

fringe aspen Jun 30, 2019, 1:17 PM

#

#paper-help

sharp badger Jun 30, 2019, 3:07 PM

#

I've noticed that the NMS generateTree with Tall Birch seems to be creating trees with dirt inside them:

📎 unknown.png

trail plume Jun 30, 2019, 3:13 PM

#

Wrong channel...

iron spoke Jul 1, 2019, 7:57 AM

#

Hello, i had trouble using Per-Player View Distance API in 1.14.3, I'm getting this error :

org.apache.commons.lang.NotImplementedException: Per-Player View Distance APIs need further understanding to properly implement
        at org.bukkit.craftbukkit.v1_14_R1.entity.CraftPlayer.setViewDistance(CraftPlayer.java:1994)

Sorry if i'm in the wrong channel.
Also, it works fine on 1.13.X
Does someone knows where it comes from ?

stone fiber Jul 1, 2019, 7:57 AM

#

It comes from paper

#

Read what it’s telling you

#

API isn’t in 1.14.x and requires a deeper understanding of Mojangs rewrite of the chunk system to implement

#

And yes, this is the wrong channel

iron spoke Jul 1, 2019, 8:03 AM

#

Okay, thanks. Are you planning to get this API compatible with 1.14 ?

stone fiber Jul 1, 2019, 8:04 AM

#

It’s planned

#

There are no ETAs

harsh harbor Jul 6, 2019, 1:49 PM

#

@trail plume maybe merge this in?
https://github.com/PaperMC/Waterfall/pull/402
Will fix scoreboards issues for people who disabled entity metadata rewrites

GitHub

Allow to disable scoreboards api by xxDark · Pull Request #402 ·...

trail plume Jul 6, 2019, 1:50 PM

#

Missing waterfall comments, and what scoreboard issues?

harsh harbor Jul 6, 2019, 1:50 PM

#

Missing Waterfall comments?

sly crown Jul 6, 2019, 1:51 PM

#

// waterfall, start/end

harsh harbor Jul 6, 2019, 1:51 PM

#

📎 unknown.png

sly crown Jul 6, 2019, 1:51 PM

#

you add them in a handful of places and just leave them out everywhere else

#

they aren't optional

harsh harbor Jul 6, 2019, 1:51 PM

#

📎 unknown.png

sly crown Jul 6, 2019, 1:52 PM

#

https://i.imgur.com/3MQBs9S.png

Imgur

#

you modified 5 lines

#

but only commend one?

#

a whole lot of lines are just uncommented

#

etc

harsh harbor Jul 6, 2019, 1:52 PM

#

ok

bleak current Jul 7, 2019, 1:52 PM

#

cat when are you going to look into my packet construction patch ;-;

#

#373

trail plume Jul 7, 2019, 4:41 PM

#

It's all on the todo list, kinda burned out on two other projects and getting back into gear is just urgh, I should probably get to finishing my setup for testing servers, just going to use docker-compose and some automagic

lean gobletBOT Jul 10, 2019, 2:04 AM

#

IRC never forgets

barren girder Jul 10, 2019, 2:21 AM

#

sshhhhh

#

i realize now it was 3 days ago

lament chasm Jul 10, 2019, 5:45 PM

#

Any way to send fake proxyplayers to bungee?

I see the UserConnection class but it's final so I can't extend it.

harsh harbor Jul 10, 2019, 5:49 PM

#

wdym

#

'fake proxyplayers'

#

why you even need that

#

@lament chasm

lament chasm Jul 10, 2019, 5:49 PM

#

So they appear on /glist

harsh harbor Jul 10, 2019, 5:50 PM

#

can't you just replace the whole command

lament chasm Jul 10, 2019, 5:50 PM

#

I guess, but if I hooked in-to it, It'd return when plugins use the plugin channel to get the totalOnlinePlayers.

harsh harbor Jul 10, 2019, 5:51 PM

#

i really don't understand why you need this

#

extend DownstreamBridge and override handle(PluginMessage)

#

then replace it for ServerConnection

lament chasm Jul 10, 2019, 6:08 PM

#

@harsh harbor Where would I set the new DownstreamBridge?

Don't do much bungee development so idk where anything is xD

#

Waterfall *** before electronicc roasts me :9

harsh harbor Jul 10, 2019, 6:10 PM

#

((UserConnection)proxiedPlayer).getServer().getCh().getHandle().pipeline()
                .get(HandlerBoss.class).setHandler(new InjectedDownstreamBridge(...));

trail plume Jul 10, 2019, 6:11 PM

#

Is your intent that those "players" actually connect to the proxy?

harsh harbor Jul 10, 2019, 6:14 PM

#

that's not waterfall, wrong channel

#

#paper-dev

dark perch Jul 10, 2019, 6:14 PM

#

Yeh

lament chasm Jul 10, 2019, 7:05 PM

#

@trail plume Just something I'm testing out with the Bungee API implemented with the Spigot API, nothing major aha

Anyway I can override the command?
super("glist", null, "testing", "the", "command", "omg");

The aliases work, how-ever the glist is still overpowered by the bungee one.

trail plume Jul 10, 2019, 7:06 PM

#

aliases won't replace bungee commands

lament chasm Jul 10, 2019, 7:07 PM

#

The "glist" is the actual main command tho? Or am I wrong.

#

http://prntscr.com/od9ubf

yah

Lightshot

Screenshot

Captured with Lightshot

trail plume Jul 10, 2019, 7:07 PM

#

It's probably first come first serve or something

#

You'd need to see if there is a method to force the change or unregister the command

lament chasm Jul 10, 2019, 7:09 PM

#

unregisterCommand found it, now time to locate the glist command location

#

Ugh... found it, any way to disable these jenkin modules? https://prnt.sc/od9w7t

Lightshot

Screenshot

Captured with Lightshot

trail plume Jul 10, 2019, 7:12 PM

#

in the modules config

lament chasm Jul 10, 2019, 7:12 PM

#

Aight, hope it works

violet saffron Jul 14, 2019, 4:19 AM

#

Is there a difference between getting the Waterfall instance to get the players rather than just get the proxy from the main class of the plugin?

trail plume Jul 14, 2019, 4:29 AM

#

no

violet saffron Jul 14, 2019, 4:30 AM

#

Okay thanks (:

violet saffron Jul 14, 2019, 5:27 AM

#

Alright another question, is there a way to only cancel the ServerConnectEvent if it's not being fired due to a player logging into the proxy?

#

So for example, if I load into a hub, it won't do it, but if I leave to another server and then go back to /hub, it'll utilize it.

dark perch Jul 14, 2019, 5:27 AM

#

Waterfall and travertine have Maven repos?

trail plume Jul 14, 2019, 5:27 AM

#

same repo as paper in #404345080917262369

violet saffron Jul 14, 2019, 5:29 AM

#

Aha got it

dark perch Jul 14, 2019, 5:31 AM

#

Travertine shares the api with waterfall?

violet saffron Jul 14, 2019, 5:31 AM

#

Bless up for ServerConnectEvent.Reason (:

trail plume Jul 14, 2019, 5:31 AM

#

Oh, yea

#

Travertine isn't deployed as there is no API changes there

dark perch Jul 14, 2019, 5:31 AM

#

Oh ok, thank you

#

There is anyway of listen to every event?

#

Without manual registration?

trail plume Jul 14, 2019, 5:44 AM

#

nope

dark perch Jul 14, 2019, 10:04 AM

#

How often is ProxyDefineCommandsEvent called?

dark perch Jul 14, 2019, 10:35 AM

#

Does Waterfall allows to intercept packets server -> client?

sharp isle Jul 14, 2019, 11:38 AM

#

No

#

After it depends of the packet you want to intercept

dark perch Jul 14, 2019, 11:41 AM

#

I wanted to intercept the 1.13 Command packet, but isnt possible sadly

chilly coral Jul 14, 2019, 11:46 AM

#

@sharp isle cc

trail plume Jul 14, 2019, 3:42 PM

#

That event is called whenever the server sends it

dark perch Jul 15, 2019, 10:34 AM

#

ProxyDefineCommandsEvent is not fired when i first join the proxy

#

But is fired when i switch server

#

Using Travertine

#

Main server: paper 1.13
Secondary server: paper 1.8 with ViaVersion

#

in fact, none tab event is fired until i switch servers

red tangle Jul 15, 2019, 12:33 PM

#

Is it possible to intercept/monitor sent packets in Waterfall? Haven't checked any docs yet. Just wondering if it's possible

lean gobletBOT Jul 15, 2019, 12:34 PM

#

Waterfall doesn't "understand" most of the packets

trail plume Jul 15, 2019, 12:35 PM

#

So, you can hook into the networking stuff and pull the data that you want, but overall you're kinda in for fun

red tangle Jul 15, 2019, 1:12 PM

#

Ahh okay. That might work

#

Thanks anyways

frank junco Jul 17, 2019, 9:23 PM

#

hello all so i'm trying to figure bungeecord plugin dev and the tutorial says to use 'getProxy().getPluginManger().registerListener(this, new Events()); but 'getProxy' is unknown

sly crown Jul 17, 2019, 9:26 PM

#

post code

frank junco Jul 17, 2019, 9:27 PM

#

public class Main extends Plugin {
@Override
public void onEnable() {
getProxy().getPluginManager().registerListener(this, new Events());
}
}

sly crown Jul 17, 2019, 9:27 PM

#

post full code

frank junco Jul 17, 2019, 9:27 PM

#

err

sly crown Jul 17, 2019, 9:27 PM

#

on a paste service

#

better probably would be a build log or something

frank junco Jul 17, 2019, 9:31 PM

#

https://pastebin.com/NHkNm9dv

Pastebin

package com.bob.Main; import net.md_5.bungee.api.ProxyServer; ...

#

I use eclipse there isn't a build log, it just gives you the errors before even attempting to compile

sly crown Jul 17, 2019, 9:32 PM

#

JavaPlugin

#

javaplugin isn't plugin

frank junco Jul 17, 2019, 9:32 PM

#

ah

#

I noticed this too

sly crown Jul 17, 2019, 9:33 PM

#

you shouldn't have any bukkit refs in proxy code

frank junco Jul 17, 2019, 9:35 PM

#

still gettin the error 😒

#

= S*

#

ah nevermind

#

still had a ref to bukkit's bukkit.plugin

sly crown Jul 17, 2019, 9:36 PM

#

you literally shouldn't even have a bukkit jar available

frank junco Jul 17, 2019, 9:38 PM

#

I see

#

completely new tot his bungee thing, Ialways stopped in the past as it was confusing to set it up... but now I have invested time and done it

#

now trying to convert my plugins to work with multi server setup

#

most of whcih is fine now...but i have certain things like 2 plugins trying to update the player list for all servers... so its not usually accurate....

#

I'm guessing since this no longer uses bukkit, it would mean the Scheduler is gone?

#

runTaskTimerAsync etc ?

sly crown Jul 17, 2019, 9:41 PM

#

bungee

#

is

#

not

#

a

#

minecraft

#

server

#

it's a proxy

spring bloom Jul 17, 2019, 9:41 PM

#

what's a proxy feelsChromosomeMan

sly crown Jul 17, 2019, 9:41 PM

#

throw everything you know about minecraft servers out the window

frank junco Jul 17, 2019, 9:47 PM

#

lol

#

alright

#

I read on the page it said it tried to mimic as much as possible from the bukkit api is why i ask really ^^

#

but anyway you've fixed a major issue i'm sure ill figure the rest out XD

lyric oak Jul 18, 2019, 12:37 PM

#

🤔 think its worth submitting some extra native binaries for compression/encrypt? generated a set for arm64... will probably try to get that arm32 ones soon. im... not entirely sure why im doing this either lol

#

cause i can, i think 🤷

trail plume Jul 18, 2019, 12:38 PM

#

I'm not really fond of the idea of pulling in binaries from others

#

Especially as they'll just sit there until they break or are forgotten about

lyric oak Jul 18, 2019, 12:39 PM

#

fair enough lol. the build script is still pretty much the same, and just have to remove the centos ASM #ifdef if its an arm cpu

trail plume Jul 18, 2019, 12:40 PM

#

If you wanna PR support for the scripts to build it, go ahead

lyric oak Jul 18, 2019, 12:44 PM

#

cool, ill open a PR once i can get back near my raspberry pi to check the arm32 builds

#

the aarch64 ones i built using UserLand on android (can run a user-space version of ubuntu there, no root needed for the device either. kinda fancy)

#

can probably just do cross-builds from linux too

sudden mason Jul 18, 2019, 8:12 PM

#

Is there a from scratch dev env for waterfall?

lyric oak Jul 18, 2019, 8:52 PM

#

should just need maven

#

./waterfall p && mvn install

fringe aspen Jul 18, 2019, 11:01 PM

#

👀 hi jake

sudden mason Jul 18, 2019, 11:12 PM

#

👀

trail plume Jul 20, 2019, 2:08 AM

#

It's late for me and I'm tired, I'll sort out travertine in the morning unless somebody drops in a PR for it

random comet Jul 20, 2019, 2:43 AM

#

dammit was just gonna ask for update

fringe aspen Jul 20, 2019, 3:13 AM

#

yeh im on it

#

its weekend im a bit in and out

deft trail Jul 20, 2019, 3:15 AM

#

rootin' for ya @fringe aspen !

#

ooo its pr'd!

#

cat do you think you could merge before u go to bed?

queen cave Jul 20, 2019, 8:30 AM

#

lol

trail plume Jul 20, 2019, 2:10 PM

#

I think I dropped out like 20/30 minutes after I said that, lol

stone fiber Jul 20, 2019, 2:36 PM

#

I didn't make it much past when I merged that either

bleak current Jul 20, 2019, 4:09 PM

#

📎 image.png

#

.contains("outdated") thonkeyes

#

good to know why lobby server behaves differently, compared to other game servers

harsh harbor Jul 20, 2019, 4:18 PM

#

I guess because first time updateAndGetNextServer is called, empty server join queue is initialized

#

so no default server returned

bleak current Jul 21, 2019, 11:33 PM

#

cat when are you going to look at my pr ;-;

bleak current Jul 22, 2019, 5:21 AM

#

Caused by: java.lang.NullPointerException
    at net.md_5.bungee.protocol.packet.TabCompleteResponse.write(TabCompleteResponse.java:74) ~[server.jar:git:MikroCord-Proxy:1.14-SNAPSHOT:1051ee3:unknown]
    at net.md_5.bungee.protocol.MinecraftEncoder.encode(MinecraftEncoder.java:24) ~[server.jar:git:MikroCord-Proxy:1.14-SNAPSHOT:1051ee3:unknown]
    at net.md_5.bungee.protocol.MinecraftEncoder.encode(MinecraftEncoder.java:9) ~[server.jar:git:MikroCord-Proxy:1.14-SNAPSHOT:1051ee3:unknown]
    at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107) ~[netty-codec-4.1.36.Final.jar:4.1.36.Final]
    ... 49 more
[05:17:29 INFO]: [mikroskeem] disconnected with: EncoderException : java.lang.NullPointerException @ io.netty.handler.codec.MessageToByteEncoder:125

#

interesting

#

(i haven't touched that part at all on my fork)

#

i wonder what goddamn thing managed to set suggestions empty

#

... witch hunt begins

weary grove Jul 22, 2019, 6:36 PM

#

@bleak current Checker Framework is a godsend

#

With it, the proxy wouldn't have compiled

#

I need to put it back on for Velocity... but right now there's tons of compile errors 😦

sly crown Jul 22, 2019, 6:36 PM

#

are suggestions not allowed to be empty?

#

i've had this discussion with people before

#

but no one gave me a conclusive answer

weary grove Jul 22, 2019, 6:36 PM

#

suggestions shouldn't be nullable

sly crown Jul 22, 2019, 6:37 PM

#

well, i said empty, not null :P

weary grove Jul 22, 2019, 6:37 PM

#

an empty list is the Effective Java away to go

#

Yeah, empty suggestions are fine

bleak current Jul 23, 2019, 1:48 AM

#

yeah bungee api/code generally needs a lot of nullability information

#

or better doc

#

idk

civic valve Jul 24, 2019, 3:13 AM

#

How much of pain would it be to add 1.6.4 to Travertine

#

or does such a thing already exist

ornate bloom Jul 24, 2019, 3:13 AM

#

Don't know of one, don't think it'd be particularly hard if you had the experience in general, but Paper team isn't going to maintain that.

#

You'd have to do it on your own and maintain it on your own

#

Since you just need to add proxying support and not that much more, it shouldn't be too difficult from the perspective of someone who has experience with adding protocol support.

trail plume Jul 24, 2019, 8:25 AM

#

You'd basically need to deal with entity metadata, you'll need to deal with the protocol itself too

#

The latter should be the easy one

bleak current Jul 24, 2019, 9:22 AM

#

why 1.6.4?

devout iris Jul 24, 2019, 9:22 AM

#

Because minecraft wasnt horrible back then

bleak current Jul 24, 2019, 10:36 AM

#

are you sure?

#

:pp

civic valve Jul 25, 2019, 3:41 AM

#

@bleak current tekkit along side my 1.14.4 server 😛

bleak current Jul 25, 2019, 10:41 AM

#

fair

deft tangle Jul 27, 2019, 7:43 PM

#

Hello! @trail plume is it possible that the PostLoginEvent is called after the first ServerConnectedEvent one? :/

trail plume Jul 27, 2019, 7:44 PM

#

Potentially

deft tangle Jul 27, 2019, 7:44 PM

#

really?

#

gosh, md5 documentation is just garbage xD

trail plume Jul 27, 2019, 7:47 PM

#

Doesn't look like it should

#

ServCon is thrown from the join game packet

#

And PostLogin should be called just before that

deft tangle Jul 27, 2019, 7:49 PM

#

hmm, so ServerConnectEvent is always called after the PostLoginEvent, right?

trail plume Jul 27, 2019, 7:50 PM

#

That should be the case

deft tangle Jul 27, 2019, 7:52 PM

#

What about the ServerConnectEvent instead?

#

I guess it can be triggered before the post login, am i right?

trail plume Jul 27, 2019, 8:01 PM

#

It'll be fired as soon as the connection is opened

#

(to the server)

#

The process is weird because you've got the proxy and the server all tryna get together and have a party

deft tangle Jul 27, 2019, 8:04 PM

#

so in this case it isn't sure that the Connect event is called after the PostLogin one, is that right?

trail plume Jul 27, 2019, 8:05 PM

#

connect should be called before

deft tangle Jul 27, 2019, 8:05 PM

#

Ok, thank you! 😄

trail plume Jul 27, 2019, 8:05 PM

#

Honestly, go setup a few listeners and test it 😛

deft tangle Jul 27, 2019, 9:16 PM

#

    @EventHandler
    public void onPluginMessage(final PluginMessageEvent event) {
        if (event.isCancelled()) {
            return;
        }

        // Check if the message is for a server (ignore client messages)
        if (!event.getTag().equals("BungeeCord")) {
            return;
        }

        // Check if a player is not trying to send us a fake message
        if (!(event.getSender() instanceof Server)) {
            return;
        }

        // Read the plugin message
        final ByteArrayDataInput in = ByteStreams.newDataInput(event.getData());

        // Accept only broadcasts
        if(!in.readUTF().equals("Forward")) {
            return;
        }
        in.readUTF(); // Skip ONLINE/ALL parameter
        ....
}

@trail plume i get a EOF exception at the 'if(!in.readUTF().equals("Forward")) {' line, how is that possible? :/

bleak current Jul 28, 2019, 10:59 AM

#

hello, there is way to detect "fallback_kick"?

#

tried all events and doesn't work

#

Could not connect to default or fallback server, please try again later: io.netty...

tranquil mortar Jul 28, 2019, 11:16 AM

#

forgive me if i'm breaking any rules, but i'm trying to find a way to port my towny data to the civs plugin. i'm willing to slide some cash for the trouble. i really don't think it's anything too crazy

bleak current Jul 28, 2019, 11:22 AM

#

first of all you're in wrong channel

#

this is #waterfall-dev

bleak current Jul 28, 2019, 11:55 AM

#

or event for "Exception Connecting", there is way to do this?

#

i need to handle all failure connections

trail plume Jul 28, 2019, 11:56 AM

#

I wanna say that there is a callback for that

bleak current Jul 28, 2019, 11:57 AM

#

ok, i will try

deft trail Jul 28, 2019, 9:24 PM

#

is 200% cpu usage normal for ~200 players?

bleak current Jul 28, 2019, 10:50 PM

#

-> #waterfall-help

deft trail Jul 28, 2019, 11:15 PM

#

ok

#

more of a dev question but sure

sly crown Jul 29, 2019, 12:08 AM

#

"This set"

#

lost your train of thought there cat?

trail plume Jul 29, 2019, 12:08 AM

#

I thought that I'd zapped that line from the commit message

hidden radish Jul 29, 2019, 11:16 AM

#

is there an official dependency for the waterfal api?

trail plume Jul 29, 2019, 11:27 AM

#

https://github.com/PaperMC/Waterfall/blob/master/BungeeCord-Patches/0001-POM-Changes.patch#L27

GitHub

PaperMC/Waterfall

BungeeCord fork that aims to improve performance and stability. - PaperMC/Waterfall

hidden radish Jul 29, 2019, 12:05 PM

#

ty

wide maple Jul 30, 2019, 6:28 PM

#

yo I just had a quick question so I thought Id pop in here

#

I need to edit something on Waterfall, how would I do that? Importing the source generated by ./waterfall p yields me nothing but pain and suffering because of countless java logic issues that seem to normall compile fine?

trail plume Jul 30, 2019, 6:30 PM

#

You need the lombok plugin

wide maple Jul 30, 2019, 6:30 PM

#

I tried it both in Eclipse and IntelliJ with that plugin

trail plume Jul 30, 2019, 6:30 PM

#

It's annoying and stupid but we're subject to the hells of upstream 😦

#

it should work fine if you have that plugin installed, make sure that it's actually fully enabled

wide maple Jul 30, 2019, 6:33 PM

#

do I need to do anything else? I am still having the same issues, I tried reinstalling it- I know I have installed it in my eclipse attempt correctly too as I had to patch the binary to allow arbitrary loads (stupid macOS)

📎 Bildschirmfoto_2019-07-30_um_20.32.57.png

trail plume Jul 30, 2019, 6:34 PM

#

got an example of an error it's showing?

wide maple Jul 30, 2019, 6:35 PM

#

sigh this is why it always pays to ask for help. It just stopped happening. Thanks

#

Ill go cry in a corner now

lean gobletBOT Jul 30, 2019, 6:35 PM

#

:D

wide maple Jul 30, 2019, 6:35 PM

#

notlikelori

wide maple Jul 30, 2019, 7:13 PM

#

I got another question, how do I run my changes without having to create a patch from it?

#

or is that not possible?

trail plume Jul 30, 2019, 7:13 PM

#

compile with maven as normal

wide maple Jul 30, 2019, 7:13 PM

#

just mvn package ?

trail plume Jul 30, 2019, 7:14 PM

#

yup

wide maple Jul 30, 2019, 7:15 PM

#

run that on the proxy or on waterfall-super?

trail plume Jul 30, 2019, 7:18 PM

#

in -super is fine

wide maple Jul 30, 2019, 7:20 PM

#

dangit had something that made it loop, well obviously that works now too. thanks again

#

I hate to ask again

#

but

#

If I wanted to register an intermediary between the server connector and player

#

where would I do it best?

#

In the Server connector or in the user connector

trail plume Jul 30, 2019, 7:34 PM

#

take a look at where the server sets up the handlerboss

#

bosshandler, I mean

#

No, right the first time

#

\o/

opaque imp Jul 31, 2019, 5:29 PM

#

Hi, quick question: what is the purpose of the offline uuid?

#

I see a user seems to have a public uuid (assigned by mojang?) and and offline one, that seems to originate in the MC server waterfall connects you to

civic valve Jul 31, 2019, 5:33 PM

#

@opaque imp you need to enable ip forwarding: https://www.spigotmc.org/wiki/bungeecord-ip-forwarding/

opaque imp Jul 31, 2019, 5:33 PM

#

Thanks for that, makes sense!

opaque imp Jul 31, 2019, 6:18 PM

#

@civic valve I set ip_forward: true in config.yml and restarted both the MC server and the proxy, but I'm still seeing the offline mode uuid

#

Do I need to remove the playerdata ?

#

Also not seeing the "external" ip

civic valve Jul 31, 2019, 6:20 PM

#

did you enable offline mode on the spigot/paper side?

opaque imp Jul 31, 2019, 6:20 PM

#

not on paper side, that is likely the reason

#

Enabled bungeecord in paper and that fixed it. Thanks @civic valve !

harsh aspen Aug 1, 2019, 1:10 PM

#

Is possible let BungeeCord send a empty chunk to player?
Just let player won't join any server but remove the Joining server screen

#

Want let player stuck in bungee but can see the chat(remove the loading screen)

idle lance Aug 1, 2019, 1:28 PM

#

https://www.spigotmc.org/threads/how-remove-the-loading-screen-when-login-bungeecord-but-hadnt-logged-in-server.387478/#post-3497469

SpigotMC - High Performance Minecraft

How remove the loading screen when login BungeeCord but hadn't log...

I want stuck players in bungee and send chats before user finished some actions out of game.
But how accept player join but not join any servers and...

harsh aspen Aug 1, 2019, 1:49 PM

#

yes i post it to spigotmc

trail plume Aug 1, 2019, 2:16 PM

#

Possible? Yes, but there is a bit more to it than that

#

There is software which basically acts as a minimal server to keep the client in a limbo state, no idea what they support in terms of actually presenting some form of world however

ornate bloom Aug 1, 2019, 2:18 PM

#

Oh yeh, what was that server called?

trail plume Aug 1, 2019, 2:19 PM

#

https://github.com/TyphoonMC/TyphoonLimbo

GitHub

TyphoonMC/TyphoonLimbo

Lightweight minecraft limbo server. Contribute to TyphoonMC/TyphoonLimbo development by creating an account on GitHub.

ornate bloom Aug 1, 2019, 2:19 PM

#

Nice, thanks

harsh aspen Aug 1, 2019, 3:12 PM

#

Got it, thanks!

devout iris Aug 1, 2019, 6:38 PM

#

Oh 2b2t is also using this

brazen walrus Aug 1, 2019, 8:35 PM

#

Ah that's really nice

#

Is there any easy way to teleport all players from the limbo back to their server once it's back up or do I have to code something?

#

Like a "temporaryFallback" option

lean gobletBOT Aug 1, 2019, 9:35 PM

#

No, as bungee would have no real way to know that it's back up

brazen walrus Aug 1, 2019, 10:15 PM

#

true, there's no permanent connection between the proxy and the server 😧

#

that's fine, it's probably not that hard to do

bleak current Aug 1, 2019, 11:50 PM

#

if i perform a non-async database operation when the join event is fired will it hang the logging in... process for just one player or the entire proxy?

brazen walrus Aug 1, 2019, 11:51 PM

#

https://www.spigotmc.org/wiki/common-development-pitfalls-bungeecord/#blocking-the-i-o-threads

violet saffron Aug 1, 2019, 11:51 PM

#

It will hang the entire proxy

brazen walrus Aug 1, 2019, 11:52 PM

#

performing blocking operations (such as I/O, fetching remote URLs, querying a database, ...) will hurt proxy performance.

Always run blocking tasks asynchronously.

bleak current Aug 1, 2019, 11:52 PM

#

alright

#

thought so, thanks

#

typhoonlimbo is kinda broken

#

until someone finds time to fix it (i still haven't managed to find time for that), then it's better to run an empty server with void world for limbo

#

i made a server with gm3 & clojure script setting speed to 0 to disable movement

#

does typhoonlimbo just spawn the player in a empty end world?

#

pretty much

#

ah i was wondering how they got that sky effect

#

well it doesn't send any chunks though

#

afaik TL has following problems:

players ping timeout suddenly, i even reported that issue
still can't handle plugin messages properly
login process is holy shit how bad - take a look by yourself
^ also that's why you cannot implement Velocity modern forwarding support into it without dumb hackery

bleak current Aug 3, 2019, 4:36 PM

#

Hello, is there any way to get the Forge mod list / detect if the player uses Forge?

trail plume Aug 3, 2019, 4:37 PM

#

once the handshake has completed, there should be a method to get it

bleak current Aug 3, 2019, 4:37 PM

#

In which event?

trail plume Aug 3, 2019, 4:37 PM

#

There is no event for it

#

It occurs as part of the forge handshake process

#

Information is exposed on ProxiedPlayer

bleak current Aug 3, 2019, 4:39 PM

#

I tried this but not works (says every time that I not use Forge):

@EventHandler
    public void onConnect(ServerConnectEvent e) {
        ProxiedPlayer pp = e.getPlayer();

        if (pp == null) {
            return;
        }

        if (pp.isForgeUser()) {
            Map<String, String> mods = pp.getModList();

            System.out.println(pp.getName() + "'s Forge Mods (" + mods.size() + "):");

            for (String key : mods.keySet()) {
                String value = mods.get(key);

                System.out.println("* " + key + ": " + value);
            }
        } else {
            System.out.println(pp.getName() + " is not using Forge.");
        }
    }

trail plume Aug 3, 2019, 4:40 PM

#

Too early

#

There isn't even a connection to a server yet for a chance for the handshake to have occured

#

With also noting that this won't work unless they connect to a forge backend or you have something on the server that's going to simulate that handshake and trick the client into sending its side of the puzzle

bleak current Aug 3, 2019, 6:28 PM

#

use whatever fits for your use-case

#

:p

trail plume Aug 3, 2019, 6:44 PM

#

it wouldn't

#

Waterfall isn't sharing state across servers

#

That's irrelevant to waterfall

#

That would be plugin territory, waterfall doesn't deal with syncronization across instances whatsoever

#

It wouldn't

#

For any gains it would literally require waterfall to actually implement some form of state syncronization across servers

#

We have no intent of providing features like state syncronization

#

People would want a level of customization that can easily already be provided by existing plugins

#

I've said that it's out of scope twice now

#

Because you didn't just ask a simple question, you started pushing something which doesn't make sense even after I said that it's irrelevant to waterfall

#

wut

#

You asked about shoving a framework into waterfall to improve performance

#

I said it would be irrelevant as waterfall doesn't do anything related to what that framework does

fringe aspen Aug 3, 2019, 7:41 PM

#

What it sounds like is you have a problem on your network that is unique to your network, that your trying to get waterfall devs to solve for you.

brazen walrus Aug 4, 2019, 4:48 PM

#

If I call ProxiedPlayer.connect while the specified server is down, the fallback_kick chat message is sent to the player

#

Could not connect to a default or fallback server, please try again later: io.netty...

#

can I disable this message?

#

https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/UserConnection.java#L355

#

doesn't seem so

cyan garnet Aug 5, 2019, 7:52 PM

#

is there some way I can send a message to a server when a player is switching to it, before the player joins?
ex, player goes from ServerA to ServerB and ServerB get's a message "SomePlayer is joining from ServerA"?

trail plume Aug 5, 2019, 7:53 PM

#

Use a proper pub/sub service

cyan garnet Aug 5, 2019, 7:54 PM

#

I'm using JedisPubSub atm but it's taking 80-200 ms for ServerB to get notified about it

#

so it's received after the player joins

harsh vine Aug 6, 2019, 4:53 AM

#

is it just me or are world chunks not being unloaded. is this just a waterfall thing?

#

📎 unknown.png

spring bloom Aug 6, 2019, 4:54 AM

#

this is a 1.14 thing

harsh vine Aug 6, 2019, 4:55 AM

#

do you know of any workaround?

spring bloom Aug 6, 2019, 4:55 AM

#

there is none

harsh vine Aug 6, 2019, 4:55 AM

#

O_O

silent token Aug 6, 2019, 4:55 AM

#

Workaround: don't use 1.14

spring bloom Aug 6, 2019, 4:55 AM

#

you need to consider why they wont unload

#

and the reason is because the system is set up to keep certain chunks loaded as long as they have a ticket for them

#

i.e players and spawn

harsh vine Aug 6, 2019, 4:56 AM

#

I removed all the players from that map... hmmm

spring bloom Aug 6, 2019, 4:56 AM

#

so, if you want to unload chunks

#

remove the players

#

set keep spawn in memory to false

#

that should hit most chunks

#

plugins can also keep chunks around via api if they want to

harsh vine Aug 6, 2019, 4:57 AM

#

i haven't looked at that spawn stuff ill check it out ty

#

huh yeah im kinda at a loss, I did everything you mentioned. still no lock

harsh vine Aug 6, 2019, 5:22 AM

#

Oohhhhhhhhhhhhhhhhhhhhhhhhhhhh updating to the latest paper.jar worked. LETS GO!!!!!!!!!!!!!!!!

autumn storm Aug 6, 2019, 5:32 PM

#

Hey guys. I’m developing a new mod pack that requires a massive amount of chunks be loaded per dimension, hence why waterfall is the only real solution for me. I have not even started testing or even any coding but I was wondering if anyone knew/has any advice on how I could transfer data between between my server networks. I have a sql db but i’m not entirely sure where to start to make it “seem” like the different servers are normal “parallel” dimensions. I would need to somehow simulate transfer of Items(AE2 networks) and energy (maybe simulate some kind of interconnected channel network?).

trail plume Aug 6, 2019, 5:33 PM

#

Not really waterfall-dev stuff, and honestly, going that deep would likely be a killer

bleak current Aug 6, 2019, 7:31 PM

#

cattew, review my pr pls ;-;

final shadow Aug 7, 2019, 2:30 AM

#

🤦

#

@trail plume reopen my issue pls

trail plume Aug 7, 2019, 2:31 AM

#

Basically, no

#

You put the proxy into offline mode, which intentionally tells it not to contact mojangs API

#

We have no interest in changing that behavior and breaking peoples setups, nor do I have interest in maintaining an option for such a feature

final shadow Aug 7, 2019, 2:32 AM

#

offline mode means there's no authentication with proxy

trail plume Aug 7, 2019, 2:33 AM

#

No, offline mode in waterfall.yml means "do not contact mojangs API"

#

I mean, the config.yml for bungee/waterfall

bleak current Aug 7, 2019, 7:05 AM

#

just install SkinsRestorer, how hard is that?

rough folio Aug 7, 2019, 8:16 AM

#

i added a thing in bungeecord to make it so that a proxy can intake ip and uuid forwarding information from another proxy, so as to allow a proxy in a proxy which i need for a thing i'm coding

#

what's the likelyhood of such a pull request being accepted?

ornate bloom Aug 7, 2019, 10:48 AM

#

probably never

#

as it's always a bad idea

bleak current Aug 7, 2019, 11:11 AM

#

why do you need proxy in a proxy O.o

rough folio Aug 7, 2019, 11:55 AM

#

it made so many things much much easier

bleak current Aug 7, 2019, 11:56 AM

#

like?

#

why can't you e.g use dns round robin? why can't you use haproxy?

rough folio Aug 7, 2019, 11:56 AM

#

nono different purpose

#

I think you've seen it elsewhere

#

but basically a thing to spread the load on a server

#

to link multiple servers together and teleport players from one place to another

trail plume Aug 7, 2019, 11:57 AM

#

I've considered allowing such things in the past

#

But it always comes back to the "somebody has to maintain it" type issues

rough folio Aug 7, 2019, 11:59 AM

#

take Skyblock, I coded a thing to conveniently arrange islands on more than one server

#

while still linking chat, messages etc

#

bungee was stopping me in two ways, 1) it was not allowing proxy to proxy at all (would say "can't connect to myself"), 2) it wasn't forwarding ips and authenticated uuids

#

so I fixed both issues

#

well I "duck taped" the first issue and actually implemented incoming ip forwarding for the second

#

not duck, duct

bleak current Aug 7, 2019, 12:03 PM

#

so you're basically doing what you can do fine with non-proxy-in-a-proxy solution

#

and proper plugins

#

whatever floats your boat, but proxy in proxy solution can spawn flame spitting dragons easily

trail plume Aug 7, 2019, 12:04 PM

#

tldr; "You're shooting yourself in the foot and I have no intents of being part of this" 😄

bleak current Aug 7, 2019, 12:04 PM

#

:p

rough folio Aug 7, 2019, 12:04 PM

#

I found it convenient

ornate bloom Aug 7, 2019, 12:04 PM

#

it's always a bad idea

#

said it earlier

#

stick by it

rough folio Aug 7, 2019, 12:04 PM

#

the plugin running on the subproxy knows by default all the players connected to the servers

#

the server component doesn't need to know of any extra servers that it never should connect players directly to

bleak current Aug 7, 2019, 12:05 PM

#

you're using proxy in proxy solution to basically group gamemode servers

#

correct?

rough folio Aug 7, 2019, 12:05 PM

#

well just one for the moment

#

yea the subproxy connects to a spawn server and as many island servers as you need

#

we're releasing on the 11th and I started a few weeks ago, not one situation where I regretted not using the same proxy

#

oh and think of plugin updates, I would have to shut the whole network down

trail plume Aug 7, 2019, 12:07 PM

#

No?

ornate bloom Aug 7, 2019, 12:07 PM

#

lol

rough folio Aug 7, 2019, 12:07 PM

#

tell me about it then

ornate bloom Aug 7, 2019, 12:07 PM

#

Draining is a very basic concept in load balancing.

#

I suggest you learn about load balancing

#

What you're doing is a really cheap imitation of it, probably.

bleak current Aug 7, 2019, 12:08 PM

#

your solution gave me an idea for proper server grouping tbh

#

going to put something together today very likely...

rough folio Aug 7, 2019, 12:10 PM

#

I'm open to criticism, I just don't accept people shutting down the idea from the beginning

trail plume Aug 7, 2019, 12:10 PM

#

The thing is is that you really solve nothing that you couldn't solve in code

#

All you do is introduce another layer of a tool which is pretty much a hack into the line of the connection

ornate bloom Aug 7, 2019, 12:11 PM

#

Yep, wasn't intended to be used this way

bleak current Aug 7, 2019, 12:11 PM

#

short explanation:

i'll extend ServerInfo class to have boolean which tells me whether it's server group info
i can specify what server groups contain what servers (skyblock -> sb_1 sb_2 sb_3)
connection to servers is decided by picking next one from list or using one with least connections

ornate bloom Aug 7, 2019, 12:11 PM

#

You should be doing what you're doing with plugins.

rough folio Aug 7, 2019, 12:11 PM

#

I mean I'm coding a plugin for it haha do you think I'm literally only adding an extra bungee

trail plume Aug 7, 2019, 12:11 PM

#

(And bungee does explictly block those connections for a reason, part of that reason is because of a bad bungee release, but allowing it on our side is just kinda... It's not something I'd be happy to take the hit of dealing with any issues that arise

bleak current Aug 7, 2019, 12:11 PM

#

also cat you're awake can you please do something with my PR please :D

trail plume Aug 7, 2019, 12:11 PM

#

No

ornate bloom Aug 7, 2019, 12:11 PM

#

Pretty much "proxy in a proxy" gets shutdown because it's a non-starter.

bleak current Aug 7, 2019, 12:12 PM

#

:(

trail plume Aug 7, 2019, 12:12 PM

#

Never

ornate bloom Aug 7, 2019, 12:12 PM

#

It's never the right solution

trail plume Aug 7, 2019, 12:12 PM

#

I need to catch up on PRs, just eveerrrything is going to hell \o/

rough folio Aug 7, 2019, 12:12 PM

#

again, you're shutting the idea down without giving a valid point

ornate bloom Aug 7, 2019, 12:12 PM

#

It is not its intended use case and issues arising from it are unsupported

#

Like I said, it's a non-starter

rough folio Aug 7, 2019, 12:13 PM

#

I'm not asking for support lol

ornate bloom Aug 7, 2019, 12:13 PM

#

A plugin will cleanly accomplish these goals using the supported mechanisms

#

Then you do you

#

But be ready for criticism

rough folio Aug 7, 2019, 12:13 PM

#

again, I'm open to criticism

#

not as open to people saying it's bad, full stop

ornate bloom Aug 7, 2019, 12:14 PM

#

It's bad, and so a PR likely won't be accepted, unless cat has other thoughts?

trail plume Aug 7, 2019, 12:14 PM

#

as I said, I was considering at one point, it's just the burden of support that arises from it which I just really don't wanna

ornate bloom Aug 7, 2019, 12:14 PM

#

yeah because it becomes one of the use cases you gotta support

rough folio Aug 7, 2019, 12:14 PM

#

I raised the point of being able to push updates without shutting the main bungee down, still no valid alternative was raised

trail plume Aug 7, 2019, 12:15 PM

#

That's pretty easy

rough folio Aug 7, 2019, 12:15 PM

#

you can always disclaim haha

trail plume Aug 7, 2019, 12:15 PM

#

And I've gone over this simple technique dozens of times on this discord and other places

#

You pull the outdated servers out of circulation

rough folio Aug 7, 2019, 12:19 PM

#

connection is going off and on if I stop replying for a while

#

oh right we do that already with the main proxy plugin, really not sure how that's less of a burden to you

trail plume Aug 7, 2019, 12:23 PM

#

hm?

#

"less of a burden to you" is what I don't understand

rough folio Aug 7, 2019, 12:23 PM

#

having to switch DNSes and reroute connections twice just because one gamemode needs updating seems to add an issue rather than solve it

trail plume Aug 7, 2019, 12:24 PM

#

if you're being sane you automate this stuff

rough folio Aug 7, 2019, 12:24 PM

#

even then, DNS changes take a while for people to acknowledge them and it makes changes less instant

#

I perfectly agree with you for network updates tho

trail plume Aug 7, 2019, 12:25 PM

#

How fast DNS updates depends on how you configure it

rough folio Aug 7, 2019, 12:25 PM

#

and that's what we do already

#

of course, but you need to rely on computers to actually follow your instructions

trail plume Aug 7, 2019, 12:25 PM

#

Sure, you'll always have some level of caching involved with DNS, but low TTLs ain't revolutionary

#

I also don't see how that helps, as you still have your outer edge which needs rebooting to update

rough folio Aug 7, 2019, 12:26 PM

#

there's nothing going on on the main proxy

#

the proxy connects to a server which could be anything

trail plume Aug 7, 2019, 12:27 PM

#

And so, your solution to not being able to roll updates out, is to literally have a single point which you can't do that with?

rough folio Aug 7, 2019, 12:27 PM

#

elaborate

#

not sure what you mean

trail plume Aug 7, 2019, 12:28 PM

#

Sounds like instead of addressing a fundimental issue, you opted to work around it, or you've literally already got the solution there but aren't applying it

rough folio Aug 7, 2019, 12:28 PM

#

for the record updates is only one of the advantages I've found

trail plume Aug 7, 2019, 12:29 PM

#

I mean, proxy in proxy will work

#

It's just one of those things where I can't really see a sane reason why you'd want to do it outside of not wanting to solve other issues

rough folio Aug 7, 2019, 12:30 PM

#

do you not acknowledge a single advantage to this solution? I understand how you wouldn't want to support the feature in the future, but I'm not sure if you're still 100% no on the topic

trail plume Aug 7, 2019, 12:30 PM

#

I can see advantages

#

But, those issues can be solved elsewhere in a manner which the software actually supports

rough folio Aug 7, 2019, 12:31 PM

#

or the other way around 😃

#

point is, and I give it to you, people would start using this setup as a round robin

#

which is obviously wrong

trail plume Aug 7, 2019, 12:32 PM

#

Personally, I think it's stupid and there are obviously better solutions out there than adding another layer of hack

#

In terms of the project, it's not something I have an interest in supporting

rough folio Aug 7, 2019, 12:33 PM

#

and from my perspective it's brought more good than it has taken away, but fair enough I respect your view

#

also any plans on actually adding implementations of Tablist?

#

I see there's some todos but I'm not sure if that's on you or on md5

trail plume Aug 7, 2019, 12:34 PM

#

todos are mostly on mds side

bleak current Aug 7, 2019, 12:35 PM

#

that's upstream (read: md5) side

trail plume Aug 7, 2019, 12:35 PM

#

There is some level of "if I touch stuff, I break bungee"

rough folio Aug 7, 2019, 12:35 PM

#

wdym haha

trail plume Aug 7, 2019, 12:35 PM

#

Forge 1.13+ is on my todo list

#

But honestly, for that, I kinda wanna see if it's viable to rip apart bungees existing implementation

#

Buuuuut I can't do that because then I break other stuff that depends on that

#

(and md has stated he has no intent of supporting forge going forward, so this is the joyous fun moments of maintaining waterfall...)

rough folio Aug 7, 2019, 12:36 PM

#

cuz you're taking about waterfall ye?

#

ah right haha

bleak current Aug 7, 2019, 12:36 PM

#

anyway if you want entirely custom stuff or just to experiment, make your own fork like i did

rough folio Aug 7, 2019, 12:37 PM

#

yea thats what I'll probably do, only burden on me is to keep pulling from upstream every now and then

bleak current Aug 7, 2019, 12:37 PM

#

see how travertine is built

#

or https://github.com/mikroskeem/MikroCord

GitHub

mikroskeem/MikroCord

Personal Waterfall fork. Contribute to mikroskeem/MikroCord development by creating an account on GitHub.

trail plume Aug 7, 2019, 12:37 PM

#

Yea, literally just fork travertine

bleak current Aug 7, 2019, 12:37 PM

#

i copied scripts from travertine, renamed them and that's it

spring bloom Aug 7, 2019, 12:37 PM

#

mikro cord

bleak current Aug 7, 2019, 12:38 PM

#

dab

trail plume Aug 7, 2019, 12:38 PM

#

no issues tab

#

plz

spring bloom Aug 7, 2019, 12:38 PM

#

no issues exist if you don't have reports

bleak current Aug 7, 2019, 12:38 PM

#

tada

ornate bloom Aug 7, 2019, 12:38 PM

#

better than leafcord, which is a burning pile of crap

bleak current Aug 7, 2019, 12:38 PM

#

my fork has bunch of questionable patches as well :D

#

like i said... just to experiment peepoeyes

spring bloom Aug 7, 2019, 12:38 PM

#

mfw bytecord talking trash

ornate bloom Aug 7, 2019, 12:39 PM

#

no, just talking to trash

#

there's a diff 😉

spring bloom Aug 7, 2019, 12:39 PM

#

ok

bleak current Aug 7, 2019, 12:39 PM

#

let's pull leaf's cord

#

rip leaf

rough folio Aug 7, 2019, 12:42 PM

#

I'll look, on the phone now, thanks tho!

wide maple Aug 9, 2019, 6:12 PM

#

Okay this is a bit of a tricky question- is there any sort of endorsed way to add protocol translation adapters to Waterfall? I am doing what ViaVersion is but it just isn’t gonna cut it

#

lori_thinking

trail plume Aug 9, 2019, 6:13 PM

#

No

#

Basically, such behavior will never be endorsed

#

and honestly, doing it on the proxy is probably the worse way

wide maple Aug 9, 2019, 6:14 PM

#

Yes I understand that fully. The issue is that I am facing a ton of different server implementations

#

And working with each on that level is next to impossible

trail plume Aug 9, 2019, 6:15 PM

#

Basically

#

the way viaversion does it is probably the best way

#

No matter what you're going to have to hijack the networking stuff to inject into there

#

be that directly via a plugin or modifying the server itself

wide maple Aug 9, 2019, 6:16 PM

#

^ what I mean by that is that I am working with bedrock servers. I am a moderator and dev for Waterdog and the ton of different implementations for bedrock servers make this extra hard

trail plume Aug 9, 2019, 6:16 PM

#

The way viaversion itself does it is cleaner in some ways, but you do hurt yourself in the long run from it

#

and bedrock is going to be a whole different beast

wide maple Aug 9, 2019, 6:16 PM

#

You ever heard of Waterdog? A waterfall fork that supports bedrock and servers and players

#

lori_ehissoai

trail plume Aug 9, 2019, 6:17 PM

#

Are you actually wanting to do translation between versions or just support passing connections through?

#

and I've seen it

wide maple Aug 9, 2019, 6:17 PM

#

Yes as an addon

#

Because that’s really not the point of Waterdog as a whole

trail plume Aug 9, 2019, 6:17 PM

#

Basically, the way that viaversion does it is more maintainable in the long run

#

But also not the best in terms of compat/performance

wide maple Aug 9, 2019, 6:18 PM

#

Yes I know but for me that way is next to impossible to use because of the oddities raknet brings

trail plume Aug 9, 2019, 6:18 PM

#

like what?

#

if you know the two versions surely you can just rewrite stuff as needed

#

You are going to have to figure out how to handle data changes between the two versions, e.g. items, etc

wide maple Aug 9, 2019, 6:18 PM

#

Yes but translation between java and bedrock and back is a bit more on the taxing side of things

#

Oh yea also, what qualifies someone as No table here?

#

eu_te_moido

trail plume Aug 9, 2019, 6:19 PM

#

That's going to be shit no matter how you do it

wide maple Aug 9, 2019, 6:20 PM

#

Yea but I knew that before I started it, haha

#

Well back to making API for the protocol adapter

#

Thanks for the quick response I really appreciate it

trail plume Aug 9, 2019, 6:21 PM

#

Really shoulda forked travertine insteada waterfall

wide maple Aug 9, 2019, 6:23 PM

#

It has the Travertine patches

#

I added those later on

trail plume Aug 9, 2019, 6:25 PM

#

The difference with forking travertine woulda been that your patches woulda been solely over waterfall vs being a mangle of waterfall and your own set of patches

wide maple Aug 9, 2019, 6:25 PM

#

Yea I have to fix that in the near future

#

lori_sweat

#

Even with all this Waterdog is now surprisingly stable. 104 pocket edition and 51 java edition players at once and still going strong

#

Sadly that makes Waterdog the only real bungee solution for bedrock that doesn’t depend on one server implementation (like synapse)

#

lori_tristeliz

cyan garnet Aug 9, 2019, 8:08 PM

#

How do I run a task in the main thread from the proxy scheduler?

trail plume Aug 9, 2019, 8:10 PM

#

There is no main thread

cyan garnet Aug 9, 2019, 8:10 PM

#

ah

#

ok 😄

fossil gull Aug 13, 2019, 6:24 PM

#

Is there a way to get the current server a player is on it? I tried that with p.getServer().getInfo().getName() but somehow it returns null

chilly coral Aug 13, 2019, 6:49 PM

#

When the player is nowhere, p.getServer() is null

#

A player is nowhere when he's connecting, or when the server he was on just shut off and no server where available.

fossil gull Aug 13, 2019, 6:54 PM

#

I'm using PostLoginEvent and get the player with ProxiedPlayer p = e.getPlayer(); I'm connected to the lobby server so it should be working or not?

chilly coral Aug 13, 2019, 8:54 PM

#

If u are getting a null value, it's that at this moment you are not connected yet to your lobby server

ornate jasper Aug 13, 2019, 10:56 PM

#

yeah postlogin is proxy login, not server login

#

i believe theres serverconnectedevent

#

or something along the lines

idle lance Aug 14, 2019, 12:15 AM

#

@spring bloom You don't need your packet limiter due to waterfall having it?

spring bloom Aug 14, 2019, 12:15 AM

#

does waterfall limit packets

sly crown Aug 14, 2019, 12:15 AM

#

no

spring bloom Aug 14, 2019, 12:16 AM

#

that solves that

idle lance Aug 14, 2019, 12:16 AM

#

#PRThePacketLimiterIntoWaterfall

fossil gull Aug 14, 2019, 5:56 PM

#

@chilly coral Do you know how i can check if the player is connected and then show the current lobby?

bleak current Aug 14, 2019, 6:00 PM

#

electtron

#

are you here?

trail plume Aug 14, 2019, 6:01 PM

#

if you could not ghost ping that would be greeat

chilly coral Aug 14, 2019, 7:11 PM

#

@fossil gull what do you want to do exactly ?

fossil gull Aug 14, 2019, 7:14 PM

#

When a player comes to the server, the current server should be displayed in the tablist. Example: Lobby-1 / Lobby-2

chilly coral Aug 14, 2019, 7:16 PM

#

You are not using the good event

#

PostLogin is triggered after the mojang authentication

#

The good event is ServerConnectedEvent i think

cyan garnet Aug 15, 2019, 5:32 PM

#

Hey, if I send a player to another server that's down, how do I know that it's down? and how do I cancel sending the player?

ornate bloom Aug 15, 2019, 5:39 PM

#

As far as I know, Bungee doesn't know if a server is online, it just tries to forward the connection regardless (might be wrong)

#

So you may need to use a messaging system to determine that.

#

Messaging/caching

cyan garnet Aug 15, 2019, 5:39 PM

#

yeah, thinking about sending a message to bungee to cancel the join event for the player

#

so like after 10 ticks, send the uuid to bungee

#

with redis or something

ornate bloom Aug 15, 2019, 5:40 PM

#

Well, or really just dynamically add/remove servers to Bungee based on whether the server is online, determined by messages

#

Can't join a server if it's not added

trail plume Aug 15, 2019, 5:41 PM

#

Yea, bungee just tries to connect them, which is really the only reliable way to tell if you can connect

#

Real downfall is that it didn't look like it gave you much in the means of trying to control the outcome

ornate bloom Aug 15, 2019, 5:41 PM

#

Yeah, since you can't control the outcome, you have to control the process.

cyan garnet Aug 15, 2019, 5:41 PM

#

yeah, kinda hard when it's all on the paper nodes and not bungee

ornate bloom Aug 15, 2019, 5:42 PM

#

Servers I know that do this usually just use something like Redis along with preventing players from trying to connect to a server if their state is offline according to the Redis cache

#

You can also use Redis of course to send messages indicating that a server has gone offline or come online

cyan garnet Aug 15, 2019, 5:48 PM

#

Gonna try it out, thanks 😃

warped loom Aug 16, 2019, 12:21 PM

#

guys I'm new to Waterfall programming

#

do I have to add Waterfall as external library?

#

or do I have to use BungeeCord

sly crown Aug 16, 2019, 12:59 PM

#

it's a drop in replacement for bungeecord

#

everything in bungeecord is in waterfall

upper fiber Aug 18, 2019, 6:40 PM

#

Is there a way to get the dynmaps from two Waterfall-Servers onto one Page so its possible to switch between them on the sidebar?

wild nova Aug 19, 2019, 2:14 PM

#

FIX the food dupe u dumbfucks

trail plume Aug 19, 2019, 2:15 PM

#

Throwing attitude in the completely wrong channel, 10/10

red tangle Aug 19, 2019, 2:17 PM

#

What ? I though calling developers names in completely unrelated channel guarantees fixing of any issues

night oriole Aug 20, 2019, 12:09 PM

#

@upper fiber https://www.spigotmc.org/resources/dynmap-multiserver.310/

upper fiber Aug 20, 2019, 12:09 PM

#

Already tried that, but cant download it as the external site does not exist anymore

night oriole Aug 20, 2019, 12:11 PM

#

https://github.com/Cube-Space/Dynmap-Multiserver Compile it?

GitHub

Cube-Space/Dynmap-Multiserver

A Webserver which is created to merge DynMaps together - Cube-Space/Dynmap-Multiserver

#

Or https://www.spigotmc.org/threads/dynmap-multiserver.10288/page-6#post-786910

upper fiber Aug 20, 2019, 12:13 PM

#

Oh... didnt see that, thanks

night oriole Aug 20, 2019, 12:13 PM

#

Did you give up very quickly? ;p

upper fiber Aug 20, 2019, 12:14 PM

#

I have to admit that waterfall is kind of low priority right now 😇

night oriole Aug 20, 2019, 12:14 PM

#

Errr... Waterfall?

#

Waterfall is proxy.

#

You run Dynmap on Spigot/Paper/Bukkit.

upper fiber Aug 20, 2019, 12:15 PM

#

I know

night oriole Aug 20, 2019, 12:15 PM

#

Dynmap-MultiServ just merges several Dynmap maps from several Spigot/Paper/Bukkit servers.

#

into one solution for a website.

upper fiber Aug 20, 2019, 12:16 PM

#

But I use waterfall to run/proxy these servers...

night oriole Aug 20, 2019, 12:16 PM

#

Yes?

upper fiber Aug 20, 2019, 12:16 PM

#

Yes

void lion Aug 20, 2019, 10:14 PM

#

Hello !
Any ideas when p.getViewDistance() will be back on paper 1.14 ?

trail plume Aug 20, 2019, 10:16 PM

#

whenever somebody gets to fixing it

#

There is a PR open on the tracker, beyond that, wrong channel

spring bloom Aug 20, 2019, 10:17 PM

#

I've delayed fixing it until per-player mob spawning is approved & merged

#

contains the util I want to use (and will have to use) for it

#

LOL

trail plume Aug 20, 2019, 10:18 PM

#

I totally didn't forget to go do that

void lion Aug 20, 2019, 10:19 PM

#

Okay thanks

#

Good luck x)

cyan garnet Aug 21, 2019, 5:18 PM

#

Any way to send a player from ServerA to ServerB from serverB?
Like have a plugin on ServerB tell bungee to send the player over?

trail plume Aug 21, 2019, 5:19 PM

#

Yes

#

You just need a way to speak to the proxy

#

Whiiiiiich if there are no players online on server B, you'd need to use a proper messaging service

cyan garnet Aug 21, 2019, 5:20 PM

#

ah crap, was worried about that :/

#

will use redis as I already have that setup

bleak current Aug 22, 2019, 7:14 PM

#

@cyan garnet you could also use RMI if you're only interacting with JVMs c:

cyan garnet Aug 22, 2019, 7:15 PM

#

rmi?

#

The servers aren't on the same machine, and already set it up with redis.
I send the uuid and target server on a channel and send the player when bungee gets it 🙂

bleak current Aug 22, 2019, 7:17 PM

#

you can do rmi accross separate machines iirc

#

but yea in that case just use redis and ignore me xd

mint snow Aug 25, 2019, 4:57 PM

#

How can I geht players which are nearby a Player?
Could this work? java List<Entity> nearbyPlayers = ((Player) sender).getNearbyEntities(<distance/2>).stream().filter(e -> e instanceof Player).collect(Collectors.toList());

shell lagoon Aug 25, 2019, 4:58 PM

#

That should work, yes.

mint snow Aug 25, 2019, 4:58 PM

#

and how to get Player objects from the Entity objects?

shell lagoon Aug 25, 2019, 4:58 PM

#

Since you know that the entities are players, you can cast them.

mint snow Aug 25, 2019, 4:58 PM

#

okay.

#

List<Player> nearbyPlayers = ((Player) sender).getNearbyEntities(32,256,32).stream().filter(e -> e instanceof Player).map(e -> (Player) e).collect(Collectors.toList());```
right?

shell lagoon Aug 25, 2019, 5:00 PM

#

Yes, that should work.

mint snow Aug 25, 2019, 5:00 PM

#

Thanks a lot!

tribal jacinth Aug 25, 2019, 5:39 PM

#

i recall a conversation here about the performance difference between getNearbyEntities and manually comparing player distances

#

bottom line was that the former is more performant for smaller ranges

#

but for anything larger you want to look at the players' distances instead

dark perch Sep 2, 2019, 3:23 AM

#

Does Bungee/Waterfall inlcude MySL

#

MySQL?

#

or jdbc?

bleak current Sep 2, 2019, 3:31 AM

#

Probably @dark perch

weary grove Sep 2, 2019, 3:36 AM

#

yes

dark perch Sep 2, 2019, 3:59 AM

#

Ty

bleak current Sep 2, 2019, 6:38 PM

#

or jdbc

#

uhhh

#

jdbc is part of java?

#

but yes, it does include MySQL

#

however bit old library

trail plume Sep 2, 2019, 6:39 PM

#

one day we'll get updated libraries

bleak current Sep 2, 2019, 7:15 PM

#

but muh backwards compat?

weary grove Sep 2, 2019, 9:03 PM

#

heh

#

I made the decision to not include any DB connectors in Velocity

#

Our network uses PostgreSQL 😉

bleak current Sep 3, 2019, 12:44 AM

#

is there a way to stop my plugin from starting in onenable?

bleak current Sep 3, 2019, 7:43 AM

#

setEnabled(false) and then return early

bleak current Sep 3, 2019, 2:11 PM

#

Should Plugin have a setEnabled() method?

bleak current Sep 3, 2019, 2:31 PM

#

Neither Bungee nor Waterfall provides that method though.

#

yeah i cant find it

#

As a temporal solution, you can return early and inform the console that the plugin is not going to work.

#

yeah i was thinking just doing that before registering anything

#

However, I don't think this is a good idea to implement this kind of system to Bungee as this may break a lot of plugins since they don't actually except plugins to be loaded but disabled.

bleak current Sep 3, 2019, 3:21 PM

#

ahh shit

#

yeah it does not exist on bungee, my bad

#

it's only on bukkit

bleak current Sep 4, 2019, 3:57 PM

#

Hello.
I would like to ask you what does "forge_support" do when I set it to "true"?
I can send messages with my Forge mod to the PaperMC server throught a channel?
Version: 1.14.4

sly crown Sep 4, 2019, 3:58 PM

#

that is entirely independent

#

the plugin channel system works regardless of whatever else

#

that's a mojang protocol, not a bukkit/bungee one

trail plume Sep 4, 2019, 4:19 PM

#

1.14 forge isn't supported at all at this point

dusk crescent Sep 7, 2019, 5:01 PM

#

hey, how to get the Protocol version from a server in my bungeecord network?

#

ah got it

#

e.getTarget().ping((arg0, arg1) -> {
if (e.getPlayer().getPendingConnection().getVersion() != arg0.getVersion().getProtocol()) {
e.setCancelled(true);
p.sendMessage(new TextComponent("§cDer Server, den du betreten möchtest, ist auf einer anderen Version."));
}
});

dark perch Sep 8, 2019, 7:20 AM

#

As Bungee supporting ProxiedPlayer#isForge, there is a method to retrieve client mod list'

#

?

bleak current Sep 8, 2019, 8:05 AM

#

yes

#

but you also have to make sure that something handshakes with forge

deft trail Sep 8, 2019, 5:40 PM

#

i think ive tried for months to get something like that working

#

mostly trying spigot behind bungee

#

never could figure it out lol

bleak current Sep 8, 2019, 6:08 PM

#

just peek into wiki.vg

#

though not sure how up to date their docs are with Forge

weary grove Sep 9, 2019, 3:41 AM

#

@bleak current Saw your zlib-ng stuff in MikroCord (since at Mineteria we are looking to squeeze even more performance and reduce the time people have to spend for server switches). So zlib-ng has now landed for Velocity 1.1.0.

bleak current Sep 9, 2019, 5:44 AM

#

🎉

weary grove Sep 9, 2019, 5:55 AM

#

I also made sure it actually did result in a perf boost by profiling it locally. I'm satisfied with the results of my testing.

bleak current Sep 9, 2019, 6:09 AM

#

i don't know proper ways how to profile it

#

how did you, and can i see the results?

#

i just threw it in, still have profiling task in my todo list but never managed to allocate time for that

weary grove Sep 9, 2019, 6:16 AM

#

my methodology was pretty unscientific

#

yourkit (async sampling woo!) + flying around

bleak current Sep 9, 2019, 6:17 AM

#

lmao

#

fair enough

#

though i'll try to port bungee api on top of velocity (as a plugin) this week

#

because why the fuck not

#

inb4 i'll succeed and velocity usage ramps up

#

blurryeyes

meager shadow Sep 11, 2019, 5:32 PM

#

Hey, does anyone know what repo/dependecy to use for plugin development using maven?

sly crown Sep 11, 2019, 5:32 PM

#

#waterfall-help ?

meager shadow Sep 11, 2019, 5:33 PM

#

Lol didn't see that. This channel seemed like the right place for this haha

sly crown Sep 11, 2019, 5:33 PM

#

yea but it was literally just answered there

meager shadow Sep 11, 2019, 9:09 PM

#

Yes, thanks! 😁

ornate jasper Sep 12, 2019, 11:34 PM

#

I'm having issues generating docs for waterfall

#

[[1;31mERROR[m] [1;31mExit code: 1 - /var/lib/jenkins/workspace/WaterLand/WaterLand-Proxy/api/target/generated-sources/delombok/net/md_5/bungee/api/connection/Connection.java:5: error: package net.md_5.bungee.protocol does not exist[m
[[1;31mERROR[m] [1;31mimport net.md_5.bungee.protocol.DefinedPacket;[m
[[1;31mERROR[m] [1;31m                               ^[m
[[1;31mERROR[m] [1;31m/var/lib/jenkins/workspace/WaterLand/WaterLand-Proxy/api/target/generated-sources/delombok/net/md_5/bungee/api/connection/Connection.java:76: error: cannot find symbol[m
[[1;31mERROR[m] [1;31m        void sendPacket(DefinedPacket packet);[m
[[1;31mERROR[m] [1;31m                        ^[m
[[1;31mERROR[m] [1;31m  symbol:   class DefinedPacket[m
[[1;31mERROR[m] [1;31m  location: interface Unsafe[m```

#

getting that

#

many times

#

mvn -B -s /var/lib/jenkins/ws-conf/nexus.xml source:jar javadoc:jar javadoc:aggregate deploy -Dbuild.number=$BUILD_NUMBER -P deployment thats the command i run

marble flint Sep 14, 2019, 9:10 PM

#

I want to create a TextComponent chat message. I tried several things but every time the line breaks are in the mid of a word. I tried ComponentBuilder and TextComponents but I'm unable to find a way that the line breaks are not in the middle of a word. What's the reason for that "let's split words". The ComponentBuilder works fine on spigot

trail plume Sep 14, 2019, 9:16 PM

#

Waterfall uses the same API as bungee which is also used in spigot

#

We don't get to control where the client splits text

marble flint Sep 14, 2019, 9:23 PM

#

okay, leading whitespace in a text component is evil. new ComponentBuilder(..).append(" this will break things").create(); vs new ComponentBuilder(..).append("this will work fine.").create();

brazen anvil Sep 15, 2019, 11:33 AM

#

Helllo,
I have write an custom an custom event system (for have same event on bungee and spigot). For this i have copy waterfall-event and methods for register listeners and call event on PluginManager.
This is perfectly work but on Intellij idea the event is not recognized as an even (so he says the method is not used) :(
I search how i can obtain the result of 2.

Thanks.

Difference :

📎 unknown.png

storm panther Sep 15, 2019, 6:46 PM

#

@brazen anvil you could potentially alt+enter on the method name "onCooldownEnd" and see if there's an option that reads something along the lines of "disable inspection of methods annotated with @EventHandler"

shell lagoon Sep 15, 2019, 6:50 PM

#

If that doesn't show up, go to Settings > Editor > Inspections > Java > Declaration redundancy > Unused declaration > Annotations and then Add Annotation Class.

brazen anvil Sep 15, 2019, 6:53 PM

#

Oki, hanks but what is the reason have different behavior between my event system and bungee or bukkit event system

shell lagoon Sep 15, 2019, 6:55 PM

#

It might be that you only marked that method as an access point, or based on some other pattern that isn't there. IntelliJ also often does its own checks in the back to automatically help you, so IntelliJ may have decided at some point to mark those methods as access points, but not the other one.

brazen anvil Sep 15, 2019, 7:06 PM

#

oki, that is strange

trail plume Sep 16, 2019, 10:08 PM

#

Something sent a bad packet

#

It should disconnect them, there ain't too much we can do given that the app has a singular job which is to handle connections

#

Hm, we could avoid the exception

#

Not in all of the cases, only some specific ones

#

e.g. the one you linked there, we can't really do much about

#

Actually, the one you linked first, we can't do too much about

#

The issue is really down to how packets are sent, if a packet is truncated, we can't really determine that too well

#

(If they have some marvellous fix for that stuff, they should really PR them vs tryna keep them private, but you know, what does software licensing stand for... :L )

bleak current Sep 17, 2019, 8:05 AM

#

theoretically you can check if most packets are truncated or not

#

if you think then all packets must consist of minimum n bytes - gets trickier with packets which contain variable length data, but if you think how vanilla works then you kinda can enforce even stricter limits (e.g plugin message payload is never empty)

real cave Sep 17, 2019, 8:33 AM

#

You can, but people will just start sending garbage above the minimum. The correct solution for this is to temporary ban the ip address that spams this, just like with any Ddos.

bleak current Sep 17, 2019, 8:36 AM

#

mnyeah in the end checking if packet is truncated wastes performance

#

only a little bit, if done correctly

#

so one should simply check how many bad packets said IP sends and then slams with ban

cyan garnet Sep 17, 2019, 11:20 AM

#

How would you guys write a cross server homes plugin?
Store each players home on the bungee and have the bungee instance handle the commands and tab completions etc and have plugins on each server that handles teleportation.
Or have each server keep a record of the homes across all server and make them send the player and the coords over to the target server

grizzled thistle Sep 17, 2019, 2:26 PM

#

I would have a temp cache for each server and whenever they leave, store their homes in a database from the cache and then clear their cache. Then when they join, cache their homes from the database.

#

or you could just store all the data on bungee with whatever, and use plugin channels or sockets to send/update the data which wouldn't require a plugin for every server

thorny holly Sep 18, 2019, 1:05 PM

#

What context should I provide if I'm trying to serialize/deserialize a TextComponent?

#

nvm, discovered ComponentSerializer

stark bone Sep 18, 2019, 8:59 PM

#

In waterfall, should each command have its own class?

bleak current Sep 19, 2019, 9:31 AM

#

in waterfall (and bungee), that's the only way to do commands iirc

warped loom Sep 19, 2019, 8:55 PM

#

if I register a command for Waterfall/bungeeCord will it automatically work on every backend?

#

or only on the proxy server

bleak current Sep 19, 2019, 9:31 PM

#

as proxy processes commands before any other server, then it'll technically work anywhere

#

except that servers won't know about it, unless you set up some kind of a special communication

stark bone Sep 21, 2019, 1:31 AM

#

I'm probably doing this incorrectly. I'd like to get the ServerPing result out of the Callback some how and use it to make a queue system and monitor playercount. Am I going about this the wrong way using ServerInfo.ping() ?

Ideally I'd like Waterfall to monitor player count on a sub-server and when a slot is available send the queued player. However, the only way I see of getting playercount and maxplayers is using ServerInfo.ping()

weary grove Sep 21, 2019, 7:41 PM

#

ServerInfo#ping() is pretty the way you'd want to do it

stark bone Sep 22, 2019, 1:37 AM

#

I'm having some trouble with plugin messaging. BungeeCord doesn't seem to recieve said message. Here is some code:

//SpigotMain.java
getServer().getMessenger().registerOutgoingPluginChannel(this, "myserver:commands");

//Spigot Message sender thingy
ByteArrayDataOutput out = ByteStreams.newDataOutput();
out.writeUTF(((Player) sender).getUniqueId().toString());
out.writeUTF("creative");
((Player) sender).sendPluginMessage(SpigotMain.INSTANCE, "myserver:commands", out.toByteArray());

//BungeeCord listener
    @EventHandler
    public void onPluginMessageReceived(PluginMessageEvent event) {
        System.out.println(event.getTag());
        if (!event.getTag().equalsIgnoreCase("myserver:commands")) {
            return;
        }

However, it seems myserver:commands is never outputted in waterfall when I run the commands, which seems it's not reaching bungee

#

Only thing is outputted is:

[01:38:03 INFO]: BungeeCord
[01:38:03 INFO]: BungeeCord
[01:38:03 INFO]: BungeeCord

and a few minecraft events when I join fir the first time

#

unless I have to do like "bungeecord:myserver"? Let me try that

#

no dice. :/ i'll keep testing

stark bone Sep 22, 2019, 2:09 AM

#

Ahah! Fixed it. I had to do:

getProxy().registerChannel("myserver:commands");

coral lichen Sep 23, 2019, 6:13 PM

#

Which is called first? PlayerHandshakeEvent or PreLoginEvent?

bleak current Sep 23, 2019, 6:14 PM

#

handshake

coral lichen Sep 23, 2019, 6:17 PM

#

is there any event / way for me to cancel a connection before that (for example by injecting into netty?)

bleak current Sep 23, 2019, 6:17 PM

#

why do you need to do that?

#

do you want to reject connection based on ip or something?

coral lichen Sep 23, 2019, 6:21 PM

#

yeah

#

want to do a firewall against minecraft botting

#

if i do it on PreLoginEvent it's already going to be screwing up the bungee

#

if i do it when the connection actually starts i have the benefit of blocking the connection before it becomes a real issue

bleak current Sep 23, 2019, 6:50 PM

#

fair

#

yeah inject something in front of the pipeline

stark bone Sep 24, 2019, 8:45 PM

#

similar to ```java
getProxy().registerChannel("myserver:commands");


is anything like this needed on Paper/spigot to register custom incoming channels opposed to the default ones

bleak current Sep 24, 2019, 8:47 PM

#

getServer().getMessenger().registerIncomingPluginChannel(<your plugin instance>, "myserver:commands", <instance of PluginMessageListener>);

stark bone Sep 24, 2019, 8:48 PM

#

Yep I have that all set, however, it doesn't seem to be recieving anything

bleak current Sep 24, 2019, 8:48 PM

#

well i use that in my plugin

#

works fine for me

stark bone Sep 24, 2019, 8:48 PM

#

and you use a custom channel, like "myserver:commands" not just bungeecord?

#

ideally wanting to do a cross server TP. so, this is the main bit of code atm

#

player.connect(target.getServer().getInfo(), new Callback<Boolean>() {

    @Override
    public void done(Boolean isPlayerConnected, Throwable error) {
        if(!isPlayerConnected) {
            player.sendMessage(new ComponentBuilder(Main.PREFIX).append("Error connecting to server").reset().create());
            return;
        }
        
        //Output teleport command
        ByteArrayDataOutput out = ByteStreams.newDataOutput();
        out.writeUTF("teleport");
        out.writeUTF(player.getUniqueId().toString());
        out.writeUTF(target.getUniqueId().toString());
        player.sendData(Main.PLUGIN_COMMANDS, out.toByteArray());                                
    }                        
});

#

So this teleports me to said server, but the datastream isn't being picked up by Paper which is along the lines of

#

Spigot Main

getServer().getMessenger().registerIncomingPluginChannel(this, Main.PLUGIN_COMMANDS, new CommandMessage());

CommandMessage

public class CommandMessage implements PluginMessageListener {

    @Override
    public void onPluginMessageReceived(String channel, Player player, byte[] message) {
        
        System.out.println(player);
        System.out.println(message);
        
        //Make sure channel is correct
        if (!channel.equalsIgnoreCase(Main.PLUGIN_COMMANDS)) {
            return;
        }
        
        ByteArrayDataInput in = ByteStreams.newDataInput(message);
        String commandToRun = in.readUTF();
        System.out.println(commandToRun);
        
        //Check if command in IF and send to correct handler
        if(commandToRun.equalsIgnoreCase("teleport")) {
            UUID sender = UUID.fromString(in.readUTF());
            UUID target = UUID.fromString(in.readUTF());
            BungeeTeleportCommand.teleport(sender, target);
        }                
    }

}

bleak current Sep 24, 2019, 8:51 PM

#

make sure that you actually register the message listener

stark bone Sep 24, 2019, 8:52 PM

#

with registerIncomingPluginChannel?

bleak current Sep 24, 2019, 8:52 PM

#

yes

stark bone Sep 24, 2019, 8:52 PM

#

Yes that's in main

#

You can have an outgoing and incoming on the same channel name right?

bleak current Sep 24, 2019, 8:52 PM

#

yes

#

also plugin channel name checking is redundant, unless you want to listen to multiple channels using one listener

stark bone Sep 24, 2019, 8:53 PM

#

will adjust that

#

excuse the messy code as I haven't touched plugins in a while

#

especially channels

bleak current Sep 24, 2019, 8:53 PM

#

eh, i've seen worse

#

i've written worse

#

but alright - i'll head to sleep now. good luck

stark bone Sep 24, 2019, 8:54 PM

#

Thanks, I will post here with any updates

#

if anyone else knows, by using a callback in Player.connect, I assume it will wait until the connection is complete before sending said plugin message

bleak current Sep 24, 2019, 8:56 PM

#

before i go

#

iirc that's not always true

stark bone Sep 24, 2019, 8:56 PM

#

so it's possible it sending the output to the old server

bleak current Sep 24, 2019, 8:56 PM

#

connection might not be that far to pass plugin messages to the server

stark bone Sep 24, 2019, 8:57 PM

#

docs state this ```yaml
/**
* Connects / transfers this user to the specified connection, gracefully
* closing the current one. Depending on the implementation, this method
* might return before the user has been connected.
*
* @param target the new server to connect to
* @param callback the method called when the connection is complete, or
* when an exception is encountered. The boolean parameter denotes success
* (true) or failure (false).
*/

#

so it makes sense to

bleak current Sep 24, 2019, 8:57 PM

#

i'd wait for ServerSwitchEvent

#

and then pass the data

#

that of course involves some advanced hackery

#

okay maybe not so much, but for beginners like you very likely

#

anyway, e.g in callback you put an entry to map which will be read on ServerSwitchEvent

#

there might be some pitfalls, due to the nature how bungeecord is built up. make sure that you synchronize such map accesses etc.

stark bone Sep 24, 2019, 9:06 PM

#

thanks for the point in the right direction

#

looking at some source code of other teleporter is a bit strange. They do theplayer.connect then run the plugin message using ProxyServer.getInstance.runAsync

#

how intensive is server messaging? is runAsync really necessary?

dark perch Sep 24, 2019, 9:11 PM

#

afaik is just a packet