#archived-modding-development | Hollow Knight | Page 533

jolly oriole Aug 9, 2021, 3:44 PM

#

and fade in / fade out to other audio works without you having to do something extra

floral blade Aug 9, 2021, 3:46 PM

#

okay, that makes sense. is there ever a need to modify things other than just main though ?

jolly oriole Aug 9, 2021, 3:47 PM

#

things
?
there isn't that much you need to care about, other than maybe for the blurplane

floral blade Aug 9, 2021, 3:47 PM

#

sorry my bad i wrote music instead when i meant main

jolly oriole Aug 9, 2021, 3:47 PM

#

oh

floral blade Aug 9, 2021, 3:47 PM

#

public AudioClip Main;
public AudioClip Action;
public AudioClip Sub;
public AudioClip Tension;
public AudioClip MainAlt;
public AudioClip Extra;

basically what do these others do

jolly oriole Aug 9, 2021, 3:48 PM

#

other channels for dynamic audio, like the extra track that playing in arenas, or the layering in path of pain

#

the chosen audiomixersnapshots affect how all of those are played

floral blade Aug 9, 2021, 3:51 PM

#

so when i select main only and transition to it i basically mute out all other stuff ?

jolly oriole Aug 9, 2021, 3:51 PM

#

yes

floral blade Aug 9, 2021, 3:52 PM

#

so i could have like "crowd cheers" set in my Sub audio clip and transition to an audio mixer that lowers main a bit and increases volume of sub, whenever someone does a PVP kill for example?

jolly oriole Aug 9, 2021, 3:53 PM

#

yea, though the colosseum afaik does it with audiosources

#

that it tells those to play the cheer sound

#

but both are options

floral blade Aug 9, 2021, 3:54 PM

#

okay gotcha now i sortof understand the excel sheet lol

#

so if i want main and sub i go for "normal" audio mixer

jolly oriole Aug 9, 2021, 3:55 PM

#

yes

floral blade Aug 9, 2021, 3:56 PM

#

thanks!

rough pulsar Aug 9, 2021, 4:09 PM

#

Uhm what was i supposed to do again

#

I think i have to select hollow_knight.exe

#

Nvm fsm programs keep crashing

jolly jungle Aug 9, 2021, 4:16 PM

#

avalonia?

rough pulsar Aug 9, 2021, 4:16 PM

#

Yeah

jolly jungle Aug 9, 2021, 4:16 PM

#

damn

rough pulsar Aug 9, 2021, 4:16 PM

#

The normal fsm thing also keeps crashing

#

im gonna debug the normal fsm viewer if there is something wrong that keeps crashing it

rough pulsar Aug 9, 2021, 4:47 PM

#

#

Fsm viewer btw

#

Normal one

#

alright how do i view fsm of other stuff now

jolly jungle Aug 9, 2021, 6:19 PM

#

with fsmviewer shermaU

#

Though you probably meant things you cant view in it

rough pulsar Aug 9, 2021, 6:19 PM

#

Fsmviewer keeps crshing

jolly jungle Aug 9, 2021, 6:20 PM

#

oh sad

jolly jungle Aug 9, 2021, 6:20 PM

#

rough pulsar

this is the reason?

rough pulsar Aug 9, 2021, 6:20 PM

#

Yeah

jolly jungle Aug 9, 2021, 6:20 PM

#

hm

rough pulsar Aug 9, 2021, 6:20 PM

#

Apparently

jolly jungle Aug 9, 2021, 6:20 PM

#

for both?

rough pulsar Aug 9, 2021, 6:20 PM

#

I haven't tested avalonia but it also crashes

jolly jungle Aug 9, 2021, 6:20 PM

#

cuz avalonia doesn't crash for me at all

rough pulsar Aug 9, 2021, 6:20 PM

#

Wait

jolly jungle Aug 9, 2021, 6:20 PM

#

what's that reason even mean

rough pulsar Aug 9, 2021, 6:20 PM

#

How do you view fsms in avalonia

jolly jungle Aug 9, 2021, 6:20 PM

#

like, what does that line cause

jolly jungle Aug 9, 2021, 6:21 PM

#

rough pulsar How do you view fsms in avalonia

like in the first fsmviewer?

rough pulsar Aug 9, 2021, 6:21 PM

#

Like, the only thing that's in avalonia is "open" and it requests me to open a file

jolly oriole Aug 9, 2021, 6:23 PM

#

have you tried the latest fsmvieweravalonia

jolly jungle Aug 9, 2021, 6:24 PM

#

Should be this

https://github.com/nesrak1/FSMViewAvalonia/releases/tag/v3

jolly oriole Aug 9, 2021, 6:28 PM

#

yes

heavy stream Aug 9, 2021, 7:39 PM

#

wrong chat lol

copper nacelle Aug 9, 2021, 7:47 PM

#

because it takes two seconds to change your postbuild to include a folder (note that the msbuild copy task generates missing in-betweens), it promotes practice that shouldn't be used for encapsulation, allows me to sidestep the issue of 1.4 mods more cleanly, and makes distribution of mods generally simpler in that files cannot conflict and folders are entire units which can be removed

#

I don't like loading subfolders because it makes unmanaged dll handling harder as it'll attempt to load those and throw as it did with discord rpc

turbid kayak Aug 9, 2021, 7:47 PM

#

So how does one create a mod?

jolly oriole Aug 9, 2021, 7:48 PM

#

copper nacelle I don't like loading subfolders because it makes unmanaged dll handling harder a...

oh yea, now i can make a managed mod that loads an unmanaged one that is basically the entire mod then pogtamer

copper nacelle Aug 9, 2021, 7:48 PM

#

yeah

jolly oriole Aug 9, 2021, 7:48 PM

#

turbid kayak So how does one create a mod?

https://radiance.host/apidocs/Getting-Started.html

turbid kayak Aug 9, 2021, 7:48 PM

#

jolly oriole <https://radiance.host/apidocs/Getting-Started.html>

Ah, thanks.

copper nacelle Aug 9, 2021, 7:49 PM

#

and if you really can't imagine making a folder in-between for every mod then you can ignore it by just making a dev folder and throwing all the mods in there

jolly oriole Aug 9, 2021, 7:50 PM

#

jolly oriole oh yea, now i can make a managed mod that loads an unmanaged one that is basical...

but i'm not gonna do that, too much can go wrong and checking if a mod does what it's supposed to do will be too difficult

floral blade Aug 9, 2021, 7:57 PM

#

when using a dll to load scripts in unity , should i use the same mod that will contain the asset bundle ?

like compile once => get dll
use dll in unity => create asset bundle
compile mod again with asset bundle in resources => get final mod dll

will unity know to look in my mods namespace , considering that when the game loads there will be 2 dlls that contain the same namespace if i go ahead with shared project and not a core.dll?

steady comet Aug 9, 2021, 8:01 PM

#

copper nacelle because it takes two seconds to change your postbuild to include a folder (note ...

Well, thanks for the explanation at least

jolly oriole Aug 9, 2021, 8:12 PM

#

floral blade when using a dll to load scripts in unity , should i use the same mod that will ...

the only thing unity cares about when assetbundling:
(- name of dll) (i'm not sure on this one, but likely)

namespace/typename of monobehaviour on the object
values of said monobehaviour
which is why i recommend 2 different assemblies for working with custom scenes:
1 exclusively for unity, with only monobehaviours, 'nothing' with HK (as in: no references to assembly-csharp)
1 as the final mod, with everything

floral blade Aug 9, 2021, 8:15 PM

#

if it cares about the name of the dll then i'll need to make my dll name that i load in unity the same as it will be when it is a mod ?

#

or is that no longer a concern when the asset has already been bundled ?

jolly oriole Aug 9, 2021, 8:15 PM

#

floral blade if it cares about the name of the dll then i'll need to make my dll name that i ...

i do that, i don't really know if it's necessary though

floral blade Aug 9, 2021, 8:17 PM

#

i can experiment with a different name,
i do worry that having my shared project setup might break if 2 mods create 2 scenes each wanting a different "version" of the same monobehaviour in the same namespace.

jolly oriole Aug 9, 2021, 8:18 PM

#

i mean, you can look how sfcoreunity.dll is basically the same as sfcore.dll, just with only monobehaviours and no methods

#

and renaming it to sfcore for unity, doing stuff with that and using the resulting bundle with actual sfcore works just fine

floral blade Aug 9, 2021, 8:19 PM

#

so here's what i am doing rn for the sake of experiment

jolly oriole Aug 9, 2021, 8:19 PM

#

also makes my vs solution look funny

copper nacelle Aug 9, 2021, 8:19 PM

#

Probably just checks the assembly name

floral blade Aug 9, 2021, 8:20 PM

#

these are 3 dlls of the same mod with different namespace for the mod itself (each with their own copy of 'DandyCore')

#

unity only shows me 1 here

#

so which dll's DandyCore got loaded ?

#

DandyCore is the namespace here

jolly oriole Aug 9, 2021, 8:21 PM

#

just pick a type of that and watch the errors

jolly oriole Aug 9, 2021, 8:21 PM

#

jolly oriole also makes my vs solution look funny

i could probably reduce the unity-exclusive things with fancy stuff in the csproj, but effort

floral blade Aug 9, 2021, 8:22 PM

#

floral blade unity only shows me 1 here

this works even if i use the compiled mod with references to the modded Assembly-Csharp

#

it cries in the editor but works after asset bundling

jolly oriole Aug 9, 2021, 8:23 PM

#

last time i tried with actual mod assembly, unity just crashed when i updated the mod and reloaded it in the editor

floral blade Aug 9, 2021, 8:23 PM

#

floral blade so which dll's DandyCore got loaded ?

my problem is idk what version of DandyCore this is here & what version it will be when the game loads with 2 mods each with their own version of it

floral blade Aug 9, 2021, 8:24 PM

#

jolly oriole last time i tried with actual mod assembly, unity just crashed when i updated th...

that's fair i have yet to do this lol

jolly oriole Aug 9, 2021, 8:24 PM

#

add a monobehaviour that only logs its full type and see which gets logged with multiple mods ig

#

i actually don't know what would happen

floral blade Aug 9, 2021, 8:25 PM

#

jolly oriole add a monobehaviour that only logs its full type and see which gets logged with ...

how can i log it's full type ?

#

i am willing to experiment

jolly oriole Aug 9, 2021, 8:25 PM

#

private void Awake() {
    Modding.Logger.Log("Type: " + this.GetType().FullName);
}

or something

floral blade Aug 9, 2021, 8:26 PM

#

okay i shall be back with results

worn eagle Aug 9, 2021, 8:29 PM

#

is there some sort of black fader that gets activated in the junk pit? it covers the screen when I teleport to it

copper nacelle Aug 9, 2021, 8:29 PM

#

just junk pit?

#

do you send blanker down

worn eagle Aug 9, 2021, 8:29 PM

#

no

jolly oriole Aug 9, 2021, 8:30 PM

#

oh, it has a giant fade thing that is also used for secret areas?

worn eagle Aug 9, 2021, 8:31 PM

#

idk it just kinda exists

copper nacelle Aug 9, 2021, 8:32 PM

#

            GameCameras.instance.cameraFadeFSM.Fsm.SetState("FadeIn");

            var gm = GameManager.instance;
            yield return new WaitWhile(() => gm.gameState != GameState.PLAYING);

            yield return null;

            PlayMakerFSM.BroadcastEvent("BOX DOWN");
            PlayMakerFSM.BroadcastEvent("BOX DOWN DREAM");

jolly oriole Aug 9, 2021, 8:33 PM

#

it has a blanker on the right side

worn eagle Aug 9, 2021, 8:33 PM

#

could it be because my dreamgate's there?

#

I'll change it and see

#

nope it's a GG_Waterways thing

copper nacelle Aug 9, 2021, 8:37 PM

#

i assume my thing didn't work?

worn eagle Aug 9, 2021, 8:38 PM

#

testing it out now

jolly oriole Aug 9, 2021, 8:38 PM

#

try, maybe additionally, broadcasting UNCOVER as well

#

because that's what the maskers want

worn eagle Aug 9, 2021, 8:41 PM

#

worked, nice

copper nacelle Aug 9, 2021, 8:41 PM

#

gg

jolly oriole Aug 9, 2021, 8:41 PM

#

_waterways

copper nacelle Aug 9, 2021, 8:41 PM

#

true

jolly oriole Aug 9, 2021, 8:42 PM

#

btw, i assume mi2.5 won't really be released with only 2 mods in modlinks?

cedar hemlock Aug 9, 2021, 8:43 PM

#

i can add howwowknyight

#

then you have 3

#

i can ask mulhima and dandy for ck and debug

worn eagle Aug 9, 2021, 8:43 PM

#

InstantTeleport makes it 6

#

should I name it FastTravel

jolly oriole Aug 9, 2021, 8:44 PM

#

if i add my mods we're at like 25 then

cedar hemlock Aug 9, 2021, 8:44 PM

#

ye lol

jolly oriole Aug 9, 2021, 8:45 PM

#

italy, add all your mods too, i need gatling crystal aspid

worn eagle Aug 9, 2021, 8:45 PM

#

idek if it's using crystals anymore

#

last time I recall it shot jellyfish cores

jolly oriole Aug 9, 2021, 8:46 PM

#

i need every variation, chosen randomly

#

or all of those as seperate mods

#

bigger number = better person

copper nacelle Aug 9, 2021, 8:49 PM

#

i can add a bunch

#

just haven't bothered

jolly oriole Aug 9, 2021, 8:50 PM

#

then bother tomorrow

rough pulsar Aug 9, 2021, 8:55 PM

#

watching my pc burn after clicking "open scene list" in fsmviewavalonia was a fun experience

jolly oriole Aug 9, 2021, 8:55 PM

#

https://github.com/hk-modding/api/issues/66#issuecomment-895513430 smh, no single line Copy

rough pulsar Aug 9, 2021, 8:56 PM

#

the normal open thing also doesn't work

copper nacelle Aug 9, 2021, 8:57 PM

#

does it glob

rough pulsar Aug 9, 2021, 8:57 PM

#

wdym

#

oh

jolly oriole Aug 9, 2021, 8:57 PM

#

copper nacelle does it glob

yes

copper nacelle Aug 9, 2021, 8:57 PM

#

oh

#

cheat

rough pulsar Aug 9, 2021, 8:57 PM

#

wdym by glob

copper nacelle Aug 9, 2021, 8:57 PM

#

can you do like {.dll, .pdb}

#

or just /*

jolly oriole Aug 9, 2021, 8:58 PM

#

https://github.com/SFGrenade/SFCore/blob/master/SFCore.csproj#L18-L32 this works, so idk, didn't test it

floral blade Aug 9, 2021, 8:58 PM

#

what i did :

added dll with namespace Futbol & DandyCore in unity => created assetBundle
compiled a new dll with namespace changed to Futbol2 & DandyCore
compiled another dll with namespace changed to Futbol3 & DandyCore
copied only Futbol2.dll & Futbol3.dll into mods folder

-> game complained about not having the monobehaviour.

renamed Futbol3.dll to Futbol.dll => game still complained
compiled a new dll with Namespace Futbol & DandyCore , copied in mods folder
-> it worked, and Modlog contained Type: DandyCore.WhoAmI

if all it needed was DandyCore from the file Futbol.dll then when i renamed Futbol3.dll to Futbol.dll it should have worked, right?

copper nacelle Aug 9, 2021, 8:58 PM

#

that isn't single line

#

scammed

jolly oriole Aug 9, 2021, 8:58 PM

#

<Copy SourceFiles="ReadMe.md;$(TargetPath);$(TargetDir)/$(TargetName).pdb" DestinationFolder="$(ExportDir)/$(TargetName)/zip/" /> is single line with 3 files

copper nacelle Aug 9, 2021, 8:58 PM

#

fair

jolly oriole Aug 9, 2021, 8:59 PM

#

the online one is not even the updated one with mod folders i just noticed

#

<@&283547423706447872>

floral blade Aug 9, 2021, 8:59 PM

#

<@&283547423706447872>

copper nacelle Aug 9, 2021, 8:59 PM

#

?mute 12h 265869087975014411

finite forumBOT Aug 9, 2021, 8:59 PM

#

dynoError Please use a valid limit less than 14 days. ex. 3m, 2h, 1d

gilded lotus Aug 9, 2021, 8:59 PM

#

<@&283547423706447872>

copper nacelle Aug 9, 2021, 8:59 PM

#

wtf

#

?mute 265869087975014411 12h

finite forumBOT Aug 9, 2021, 8:59 PM

#

dynoError I couldn't mute the user. Make sure the Dyno role has Manage Roles permissions.

jolly oriole Aug 9, 2021, 8:59 PM

#

lmao

copper nacelle Aug 9, 2021, 8:59 PM

#

despises me

rough pulsar Aug 9, 2021, 9:00 PM

#

wtf happened

#

discord nitrogen or free csgo knives?

cedar hemlock Aug 9, 2021, 9:00 PM

#

nitrogen

jolly oriole Aug 9, 2021, 9:00 PM

#

copper nacelle ?mute 12h 265869087975014411

you tried to mute that person for around 8.4 billion years

cedar hemlock Aug 9, 2021, 9:01 PM

#

fun

copper nacelle Aug 9, 2021, 9:01 PM

#

wrong parameter order feelsbadman

rough pulsar Aug 9, 2021, 9:01 PM

#

copper nacelle ?mute 12h 265869087975014411

in seconds or planck time? feelspkman

floral blade Aug 9, 2021, 9:01 PM

#

floral blade what i did : - added dll with namespace Futbol & DandyCore in unity => created ...

ICYMI , pls help i do not understand what experiment i just ran and what this means

rough pulsar Aug 9, 2021, 9:02 PM

#

i'm useless in everything other than linking people to stuff

jolly oriole Aug 9, 2021, 9:03 PM

#

seems like it does check for some things to make sure that futbol is futbol, even if another internal namespace is used

copper nacelle Aug 9, 2021, 9:04 PM

#

do you just ref like every unity dll

jolly oriole Aug 9, 2021, 9:04 PM

#

yes, if that's towards me

copper nacelle Aug 9, 2021, 9:04 PM

#

understandable

#

i was wondering how ide support would work

#

with the var

jolly oriole Aug 9, 2021, 9:05 PM

#

was easier to copy+paste into every csproj

copper nacelle Aug 9, 2021, 9:05 PM

#

lmao

rough pulsar Aug 9, 2021, 9:05 PM

#

alright so if i can't do shit in fsmview/fsmviewavalonia, do i just log stuff into console and expect a mess in the bottom left of my screen?

jolly oriole Aug 9, 2021, 9:05 PM

#

idk how vs would handle that tbh, probably would still do the normal relative link if i'd add another one

copper nacelle Aug 9, 2021, 9:07 PM

#

yeah

floral blade Aug 9, 2021, 9:07 PM

#

jolly oriole seems like it does check for some things to make sure that futbol is futbol, eve...

another interesting observation :
at one point in my code i do this

GameObject go = GameObject.Find("dc_"+sceneName);
// if null create blah blah
var customScene = go.GetComponent<CustomScene>();

if i load both Futbol2 & Futbol3 , obviously the one loading second finds the go, but then the component is null for it (even though they're both DandyCore.CustomScene just from different dlls).

jolly oriole Aug 9, 2021, 9:07 PM

#

YEP

rough pulsar Aug 9, 2021, 9:08 PM

#

what is futbol

jolly oriole Aug 9, 2021, 9:08 PM

#

test mod to test how unity works

#

ig

copper nacelle Aug 9, 2021, 9:08 PM

#

a game where you hit a ball with your foot

jolly oriole Aug 9, 2021, 9:09 PM

#

or this

floral blade Aug 9, 2021, 9:09 PM

#

jolly oriole test mod to test how unity works

yes

floral blade Aug 9, 2021, 9:10 PM

#

jolly oriole or this

and yes

floral blade Aug 9, 2021, 9:10 PM

#

copper nacelle a game where you hit a ball with your foot

partial yes it is a nail here

jolly oriole Aug 9, 2021, 9:11 PM

#

oh, for hkmp?

rough pulsar Aug 9, 2021, 9:11 PM

#

when were you able to make custom save art for areas in-game?

jolly oriole Aug 9, 2021, 9:11 PM

#

always

rough pulsar Aug 9, 2021, 9:11 PM

#

so this was a feature in modding api since the dawn of time or a specific core mod?

floral blade Aug 9, 2021, 9:11 PM

#

jolly oriole oh, for hkmp?

yes if i can ever get the ball to sync without a custom build of hkmp

jolly oriole Aug 9, 2021, 9:12 PM

#

rough pulsar so this was a feature in modding api since the dawn of time or a specific core m...

nothing, actually coded per mod lol

#

i did it as a fun thing to do in early 2020, though idk if i was the first

floral blade Aug 9, 2021, 9:12 PM

#

rough pulsar so this was a feature in modding api since the dawn of time or a specific core m...

you could manually do it if u used an unused map zone, but DandyCore allows me to set save art based on scene name

rough pulsar Aug 9, 2021, 9:12 PM

#

lfg

floral blade Aug 9, 2021, 9:13 PM

#

jolly oriole i did it as a fun thing to do in early 2020, though idk if i was the first

this was a big help in researching how to do this tbh

rough pulsar Aug 9, 2021, 9:13 PM

#

i just wish there was something to make the unity scene making not a pain in the ass

#

or maybe there is

jolly oriole Aug 9, 2021, 9:13 PM

#

https://radiance.host/apidocs/NewScene.html hotdogHotdog

rough pulsar Aug 9, 2021, 9:14 PM

#

oh

#

i guess i'll just

floral blade Aug 9, 2021, 9:14 PM

#

or if u want to manually do things read sfcore and watch salehs video

rough pulsar Aug 9, 2021, 9:14 PM

#

have to rely on automatically cropped sprites, hope they are the exact same size as in-game, then preload objects

jolly oriole Aug 9, 2021, 9:14 PM

#

floral blade or if u want to manually do things read sfcore and watch salehs video

basically the same lol

jolly oriole Aug 9, 2021, 9:14 PM

#

rough pulsar have to rely on automatically cropped sprites, hope they are the exact same size...

yes, but make sure you set the pixelPerUnit to 64

rough pulsar Aug 9, 2021, 9:15 PM

#

jolly oriole yes, but make sure you set the pixelPerUnit to 64

💀

floral blade Aug 9, 2021, 9:15 PM

#

jolly oriole basically the same lol

more or less yeah

rough pulsar Aug 9, 2021, 9:15 PM

#

shit

#

i forgot to turn off ping

jolly oriole Aug 9, 2021, 9:15 PM

#

sigh

copper nacelle Aug 9, 2021, 9:15 PM

#

how horrific now 3 children will die

worn eagle Aug 9, 2021, 9:15 PM

#

I'm 3 children

rough pulsar Aug 9, 2021, 9:15 PM

#

i forgor 💀

floral blade Aug 9, 2021, 9:15 PM

#

in doing all this research i also found 56's youtube

jolly oriole Aug 9, 2021, 9:16 PM

#

worn eagle I'm 3 children

then go on a diet

copper nacelle Aug 9, 2021, 9:16 PM

#

my condolences

floral blade Aug 9, 2021, 9:16 PM

#

and found this gem https://www.youtube.com/watch?v=YqQ1XFsApvo

YouTube

fiftysix

maggotPrime

▶ Play video

#

nay Lore

jolly oriole Aug 9, 2021, 9:16 PM

#

https://www.youtube.com/watch?v=auuDqiRi7uQ this is way better

YouTube

fiftysix

myla dissolves to death (asmr)

▶ Play video

floral blade Aug 9, 2021, 9:18 PM

#

how do you even preload acid

rough pulsar Aug 9, 2021, 9:18 PM

#

get gameobject of it

copper nacelle Aug 9, 2021, 9:18 PM

#

yeah

#

I think that's the ke one

floral blade Aug 9, 2021, 9:19 PM

#

oh feelspkman

jolly oriole Aug 9, 2021, 9:19 PM

#

also perfectly shows iframes on enemies

#

i think i still have the video of the first time i actually got custom music working

#

found it

worn eagle Aug 9, 2021, 9:23 PM

#

both 1432 and 1.5 versions

📎 FastTravel.zip

rough pulsar Aug 9, 2021, 9:23 PM

#

vignette looks deep fried to me for some reason even though it may not be

#

in the video

copper nacelle Aug 9, 2021, 9:24 PM

#

it's definitely something

rough pulsar Aug 9, 2021, 9:24 PM

#

and it's loud af

jolly oriole Aug 9, 2021, 9:24 PM

#

rough pulsar in the video

it's deepnest color correction curves in the kingdoms edge scene

rough pulsar Aug 9, 2021, 9:24 PM

#

my ears felt like they were dying

jolly oriole Aug 9, 2021, 9:24 PM

#

rough pulsar my ears felt like they were dying

have you tried turning your volume down?

rough pulsar Aug 9, 2021, 9:25 PM

#

74% 💀

jolly oriole Aug 9, 2021, 9:25 PM

#

meanwhile i'm here at 24

rough pulsar Aug 9, 2021, 9:25 PM

#

i forgot i left it at 74% lol

#

i get it my bad

#

damn i wonder why didn't i use this when making stuff in my mod

floral blade Aug 9, 2021, 9:26 PM

#

jolly oriole found it

pretty cool

#

so , i did a this.GetType().AssemblyQualifiedName instead of this.GetType().FullName

#

and that got me :
Type: DandyCore.WhoAmI, Futbol, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null

#

The assembly-qualified name of a type consists of the type name, including its namespace, followed by a comma, followed by the display name of the assembly. The display name of an assembly is obtained using the Assembly.FullName property.

#

maybe that's how it works ? unity ensures Assembly.FullName also matches ?

rough pulsar Aug 9, 2021, 9:38 PM

#

I'm just gonna create a testing mod that would log stuff in the modlogs

floral blade Aug 9, 2021, 9:52 PM

#

and if i load 2 dlls in unity i can add DandyCore.WhoAmI from both of them on the same GO

#

and print this
[INFO]: Type: DandyCore.WhoAmI, Futbol, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
[INFO]: Type: DandyCore.WhoAmI, Futbol2, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null

#

so i can safely use DandyCore the way i had planned

floral blade Aug 9, 2021, 10:00 PM

#

jolly oriole i mean, you can look how sfcoreunity.dll is basically the same as sfcore.dll, ju...

these probably have the same assembly name? right now my theory is that is how unity decides it has the right dll

dark wigeon Aug 9, 2021, 10:15 PM

#

fsm view avalonia will no longer crash on fsms with missing node connections

thorn osprey Aug 9, 2021, 11:32 PM

#

a

copper nacelle Aug 9, 2021, 11:33 PM

#

what

primal latch Aug 10, 2021, 8:08 AM

#

Just say that the mapi had a breaking change. Time to try and tell rusty how to insert it into the game and the downloads folder grubsad

jolly oriole Aug 10, 2021, 8:12 AM

#

wha

cedar hemlock Aug 10, 2021, 8:32 AM

#

grenade where are the mi2.5 modlinks again?

jolly oriole Aug 10, 2021, 8:34 AM

#

hk-modding/modlinks

#

https://github.com/hk-modding/modlinks/

cedar hemlock Aug 10, 2021, 8:34 AM

#

k

#

thx

#

the link in apilinks.xml doesn't go anywhere

jolly oriole Aug 10, 2021, 8:36 AM

#

the link
which of the 7

#

but yes, that is an outdated api there

cedar hemlock Aug 10, 2021, 8:37 AM

#

<Windows SHA256="9866A9023181C27B599B46E259798580E5EAB76DE343E95E3B1E98D3F820CAE0">
                <![CDATA[https://github.com/HollowKnight-Modding/HollowKnight.Modding/releases/download/v1.5.68.11808-61/ModdingApiWin.zip]]>
            </Windows>

#

would you think it matters which api version i reference?

#

if not i'll just take the latest release

jolly oriole Aug 10, 2021, 8:38 AM

#

take the latest, can also PR it into the modlinks if you want, otherwise i may do that later if i don't forget

cedar hemlock Aug 10, 2021, 8:38 AM

#

k

#

i'll just take this one: https://github.com/hk-modding/api/actions/runs/1109205688

#

do i need the SHA of the zip or the dll?

jolly oriole Aug 10, 2021, 8:50 AM

#

the zip that the installer will download

cedar hemlock Aug 10, 2021, 8:50 AM

#

k

#

what do i do if i have no dependencies?

#

just <Dependencies /> like Vasi does?

jolly oriole Aug 10, 2021, 8:54 AM

#

yea

cedar hemlock Aug 10, 2021, 8:54 AM

#

    <Manifest>
        <Name>HowwowKnyight</Name>
        <Description>Twanswates aww of de text in Howwow Knyight into de much supewiow UwU wanguage, incwuding menyus, usew intewface and in-game diawogues! >w<</Description>
        <Version>3.7.5.0</Version>
        
        <Link SHA256="b8be2445f5ce7d9f7a3a5c2d1ce39e11f3275a041127b984804a8ce78b5f92b4">
            <![CDATA[https://github.com/DDRM-VGV/HowwowKnyight/releases/download/3.7.5/HowwowKnyight.zip]]>
        </Link>
        
        <Dependencies />
    </Manifest>
```should work then right?

jolly oriole Aug 10, 2021, 8:54 AM

#

looks about right

cedar hemlock Aug 10, 2021, 8:54 AM

#

ok i'll make a pr then

jolly oriole Aug 10, 2021, 8:55 AM

#

while you're at it, can you remove 22 - 24 (the files thing from the comment)?

#

as it's not needed since like 6 hours ago

cedar hemlock Aug 10, 2021, 8:56 AM

#

        <Files>
            <File><![CDATA[Test Filename]]></File>
        </Files>
```?

jolly oriole Aug 10, 2021, 8:56 AM

#

yes

cedar hemlock Aug 10, 2021, 8:56 AM

#

k

jolly oriole Aug 10, 2021, 8:56 AM

#

thx

cedar hemlock Aug 10, 2021, 8:56 AM

#

https://github.com/hk-modding/modlinks/pull/8

jolly jungle Aug 10, 2021, 10:19 AM

#

jolly oriole found it

What's that room

#

?

jolly oriole Aug 10, 2021, 10:20 AM

#

deepnest_east_hornet

jolly jungle Aug 10, 2021, 10:20 AM

#

Where'd you enter it from though?

jolly oriole Aug 10, 2021, 10:20 AM

#

deepnest_east_12

jolly jungle Aug 10, 2021, 10:21 AM

#

Hm

#

Did you add the connection?

jolly oriole Aug 10, 2021, 10:21 AM

#

no? it's already there, that's the normal way you get kingsbrand

jolly jungle Aug 10, 2021, 10:21 AM

#

Wait what

#

That didn't look like the entrance to hornet

#

The first room

jolly oriole Aug 10, 2021, 10:22 AM

#

before you get kings brand, it may have less ash lying around

jolly jungle Aug 10, 2021, 10:22 AM

#

Hm

jolly oriole Aug 10, 2021, 10:24 AM

#

jolly jungle Aug 10, 2021, 10:25 AM

#

Ohh

#

Wow I didn't recognise it

nimble lake Aug 10, 2021, 10:40 AM

#

worn eagle both 1432 and 1.5 versions

saved

primal latch Aug 10, 2021, 10:42 AM

#

the release doesn't contain any files

cedar hemlock Aug 10, 2021, 10:42 AM

#

just go to actions

primal latch Aug 10, 2021, 10:42 AM

#

I know

#

Just wanted to report it

jolly jungle Aug 10, 2021, 1:58 PM

#

I'm in here, there are two actions

#

However, even if shouldTurnInLunge is false, it logs the last line in the image

#

even though it should come definitely after the BoolTest

#

Also, the FaceObject seems to never happen, no matter the results of the bool test, while the method below always happens

#

Basically, seems like any action I add simply doesn't function correctly, while methods are fine

#

Any ideas what the problem is?

copper nacelle Aug 10, 2021, 2:13 PM

#

what is should turn in lunge

jolly jungle Aug 10, 2021, 2:21 PM

#

a bool I figure out right before

#

the bool itself works perfectly

copper nacelle Aug 10, 2021, 2:22 PM

#

show

#

is it a constant

#

well

jolly jungle Aug 10, 2021, 2:22 PM

#

copper nacelle is it a constant

Wdym?

copper nacelle Aug 10, 2021, 2:22 PM

#

is it re evaluated every time the action happens

jolly jungle Aug 10, 2021, 2:23 PM

#

jolly jungle Aug 10, 2021, 2:23 PM

#

copper nacelle is it re evaluated every time the action happens

Yep

copper nacelle Aug 10, 2021, 2:23 PM

#

that doesn't count

jolly jungle Aug 10, 2021, 2:24 PM

#

?

#

Why not

copper nacelle Aug 10, 2021, 2:24 PM

#

it's a bool

#

a value type

#

given to an fsm action by putting it on a field

#

it won't update the other one

jolly jungle Aug 10, 2021, 2:24 PM

#

aight

#

Didnt fully understand

copper nacelle Aug 10, 2021, 2:25 PM

#

make it an FsmBool and set the Value

jolly jungle Aug 10, 2021, 2:25 PM

#

but you're saying its stuck using a specific value?

copper nacelle Aug 10, 2021, 2:25 PM

#

yes

#

it's like

jolly jungle Aug 10, 2021, 2:25 PM

#

copper nacelle make it an FsmBool and set the Value

Aight, thanks

copper nacelle Aug 10, 2021, 2:25 PM

#

if I do

#

int x = 3;

jolly jungle Aug 10, 2021, 2:25 PM

#

Oh wait I think I get where you're going

copper nacelle Aug 10, 2021, 2:27 PM

#

IEnumerator F(int x) {
    while (true) {
          Log(x);
          yield return null;
    }
}

StartCoroutine (F(x))

yield return new WaitForSeconds(2);

x = 37;

#

setting x to 37 doesn't make it stop printing 3

#

because primitives/structs are value types

jolly jungle Aug 10, 2021, 2:27 PM

#

Ooh yeah I see now

#

Thanks

#

grublove

copper nacelle Aug 10, 2021, 2:27 PM

#

np

jolly jungle Aug 10, 2021, 2:28 PM

#

But how do I make an FsmBool?

#

It needs to be created through the fsm itself?]

copper nacelle Aug 10, 2021, 2:34 PM

#

https://github.com/fifty-six/HollowKnight.Vasi/blob/master/Vasi/FsmUtil.cs#L193

jolly jungle Aug 10, 2021, 2:34 PM

#

Ooh, thanks

cedar hemlock Aug 10, 2021, 2:34 PM

#

https://github.com/ricardosouzag/ModInstaller/pull/111 new pr

jolly jungle Aug 10, 2021, 3:50 PM

#

copper nacelle <https://github.com/fifty-six/HollowKnight.Vasi/blob/master/Vasi/FsmUtil.cs#L193...

Can I just reference Vasi and use it?

copper nacelle Aug 10, 2021, 3:50 PM

#

yeah

jolly jungle Aug 10, 2021, 3:52 PM

#

Is the one you released 13 hours ago alright?

#

Wait I already have vasi grimmpalm

#

What's vasi even mean?

copper nacelle Aug 10, 2021, 4:01 PM

#

?mute 651843061831434260

#

this is so sad

rough pulsar Aug 10, 2021, 4:01 PM

#

Modding staff

copper nacelle Aug 10, 2021, 4:01 PM

#

yeah

jolly oriole Aug 10, 2021, 4:05 PM

#

copper nacelle Aug 10, 2021, 4:05 PM

#

what are you gonna do to that fence

jolly oriole Aug 10, 2021, 4:06 PM

#

I N S P E C T

floral blade Aug 10, 2021, 4:06 PM

#

oh the map shiney that u stole from divine

copper nacelle Aug 10, 2021, 4:12 PM

#

jolly jungle What's vasi even mean?

jolly oriole Aug 10, 2021, 4:12 PM

#

funny words

floral blade Aug 10, 2021, 4:12 PM

#

visual vasic

copper nacelle Aug 10, 2021, 4:13 PM

#

true

worn eagle Aug 10, 2021, 4:13 PM

#

vasid on what

copper nacelle Aug 10, 2021, 4:13 PM

#

I just didn't want to name another mod ___Core

jolly oriole Aug 10, 2021, 4:13 PM

#

unity_think

floral blade Aug 10, 2021, 4:13 PM

#

jolly oriole <:unity_think:831134927134261278>

where assets if not github?

jolly oriole Aug 10, 2021, 4:14 PM

#

putting binaries in a repo shroompause

copper nacelle Aug 10, 2021, 4:14 PM

#

true

jolly oriole Aug 10, 2021, 4:14 PM

#

but here they are: https://github.com/SFGrenade/AdditionalMaps/tree/master/Resources

floral blade Aug 10, 2021, 4:15 PM

#

sure, we dont source control them there but then whats the better alternative ?

floral blade Aug 10, 2021, 4:15 PM

#

jolly oriole but here they are: <https://github.com/SFGrenade/AdditionalMaps/tree/master/Reso...

yeah i've already seen that and hence ask

copper nacelle Aug 10, 2021, 4:15 PM

#

git lfs it ig

#

I don't like githubs lfs it has like -2 space

jolly oriole Aug 10, 2021, 4:17 PM

#

idrk, the only repo i work with that has binaries in it is because those were there before i started, so i just keep them, even though it takes like an hour to clone the repo. others are 1 man projects, so i can keep the assemblies on my machine

floral blade Aug 10, 2021, 4:19 PM

#

jolly oriole idrk, the only repo i work with that has binaries in it is because those were th...

right but now if i try to clone your repos they dont work 😦 would you / do you include the necessary assets in a a zip with a release tag?

floral blade Aug 10, 2021, 4:19 PM

#

copper nacelle git lfs it ig

this is new

#

(to me)

jolly oriole Aug 10, 2021, 4:19 PM

#

floral blade right but now if i try to clone your repos they dont work 😦 would you / do you ...

i can try

worn eagle Aug 10, 2021, 4:20 PM

#

are you fixing up additionalmaps so I can use fastteleport with it

jolly oriole Aug 10, 2021, 4:21 PM

#

50%,
i'm fixing it up

#

oh yea, i can try fastteleport

#

it was attack to teleport, right?

worn eagle Aug 10, 2021, 4:23 PM

#

no you just use your mouse, the cursor shows up when you open your full map

jolly oriole Aug 10, 2021, 4:23 PM

#

but how do i teleport

worn eagle Aug 10, 2021, 4:24 PM

#

click

jolly oriole Aug 10, 2021, 4:24 PM

#

ok, i think i broke it completely

worn eagle Aug 10, 2021, 4:24 PM

#

using the 1.5 version?

jolly oriole Aug 10, 2021, 4:24 PM

#

yea

#

what dep has it?

worn eagle Aug 10, 2021, 4:26 PM

#

none

jolly oriole Aug 10, 2021, 4:27 PM

#

doesn't work without other mods, probably needs preloading

worn eagle Aug 10, 2021, 4:27 PM

#

lemme install the latest api and see if it runs

jolly oriole Aug 10, 2021, 4:29 PM

#

it might be the save i used that somehow broke the map screen

#

hm, clicking still does nothing

jolly oriole Aug 10, 2021, 5:38 PM

#

🤔

vocal spire Aug 10, 2021, 5:39 PM

#

grubthink

jolly oriole Aug 10, 2021, 5:41 PM

#

it reads possible null reference return value or similar

copper nacelle Aug 10, 2021, 5:44 PM

#

I mean

#

yeah

#

mark the method as returning AudioClip?

jolly oriole Aug 10, 2021, 5:46 PM

#

hm, nah, it's fine

copper nacelle Aug 10, 2021, 5:48 PM

#

pauseshroom

#

there's no point in enabling nullable if you don't use it

jolly oriole Aug 10, 2021, 5:48 PM

#

i changed it, dw

#

salubraS

#

how is the Path.GetDirectoryName a possible null assignment

copper nacelle Aug 10, 2021, 5:58 PM

#

Assembly location is nullable?

rough pulsar Aug 10, 2021, 5:58 PM

#

jolly oriole how is the `Path.GetDirectoryName` a possible null assignment

Shhhhhhh pretend it is

jolly oriole Aug 10, 2021, 5:59 PM

#

when hovered, vs tells me that: "Location" is not NULL here

copper nacelle Aug 10, 2021, 6:00 PM

#

null if path denotes a root directory or is null.

jolly oriole Aug 10, 2021, 6:01 PM

#

bottom thing:

"Location" is not NULL here.

copper nacelle Aug 10, 2021, 6:01 PM

#

yeah but it could be in C:\

jolly oriole Aug 10, 2021, 6:02 PM

#

i'll just glimpse over that ig

copper nacelle Aug 10, 2021, 6:02 PM

#

do !

#

because that's not gonna happen

#

or ?? throw

jolly oriole Aug 10, 2021, 6:03 PM

#

the ?? throw thing did get rid of that

#

_dir = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location) ?? throw new DirectoryNotFoundException("I have no idea how you did this, but good luck figuring it out."), FOLDER);

primal latch Aug 10, 2021, 6:06 PM

#

I love the error message

#

Now go make mi 2.5/3/WHATEVERNUMBERTHE1.5INSTALLERHAS

jolly oriole Aug 10, 2021, 6:06 PM

#

no

copper nacelle Aug 10, 2021, 6:07 PM

#

so much effort

jolly oriole Aug 10, 2021, 6:07 PM

#

do it yourself

#

it's on github after all

copper nacelle Aug 10, 2021, 6:07 PM

#

I worked on it yesterday

#

it has the whole version store to update meme

#

improved di usage

#

moved the thing to an installer class and abstracted everything to interfaces

#

I need to start adding tests

#

you know Microsoft doesn't have a decent filesystem abstraction by default

#

kinda annoying

primal latch Aug 10, 2021, 6:08 PM

#

Imagine testing code

copper nacelle Aug 10, 2021, 6:08 PM

#

yeah I'm imagining it

#

would get rid of so many bugs

primal latch Aug 10, 2021, 6:10 PM

#

Too bad you can’t really add tests to the api

jolly oriole Aug 10, 2021, 6:12 PM

#

god dammit

primal latch Aug 10, 2021, 6:14 PM

#

What are you doing? Going through all suggestions for the mapi?

jolly oriole Aug 10, 2021, 6:16 PM

#

nah, going through resharper for all my mods

#

across ~32 projects it's only like 1052 spelling mistakes

jolly oriole Aug 10, 2021, 9:10 PM

#

thanks resharper

vocal spire Aug 10, 2021, 9:14 PM

#

np

potent summit Aug 10, 2021, 9:28 PM

#

why is incorrect

jolly oriole Aug 10, 2021, 9:32 PM

#

looks like your references are wrong

potent summit Aug 10, 2021, 9:32 PM

#

oh

#

my references

languid goblet Aug 10, 2021, 9:33 PM

#

are you referencing a modded assembly-csharp?

worn eagle Aug 10, 2021, 9:33 PM

#

intialize

potent summit Aug 10, 2021, 9:33 PM

#

oh intialize

languid goblet Aug 10, 2021, 9:34 PM

#

also are you putting using Modding; at the top?

potent summit Aug 10, 2021, 9:34 PM

#

languid goblet also are you putting `using Modding;` at the top?

no

#

where i put

potent summit Aug 10, 2021, 9:35 PM

#

languid goblet are you referencing a modded assembly-csharp?

modded?

languid goblet Aug 10, 2021, 9:36 PM

#

is your game currently modded or vanilla

potent summit Aug 10, 2021, 9:37 PM

#

i put and its like that only the initialize is incorrect

jolly oriole Aug 10, 2021, 9:37 PM

#

initialize with big i

potent summit Aug 10, 2021, 9:37 PM

#

languid goblet is your game currently modded or vanilla

like if have other mods instaled?

languid goblet Aug 10, 2021, 9:38 PM

#

whether or not you have the modding api installed
which you do

potent summit Aug 10, 2021, 9:38 PM

#

jolly oriole initialize with big i

zote

#

thx

#

it function now

potent mantle Aug 10, 2021, 10:38 PM

#

yo

#

how to build a map

#

from zero

#

with no knowledge else than knowing how to install a mod

#

i wanna build a platforming challenge

#

also i can't code

#

<@&328354344313421825> (idk if this role is supposed to be pinged for help, if not i'm really sorry)

copper nacelle Aug 10, 2021, 10:46 PM

#

you are now really sorry

potent mantle Aug 10, 2021, 10:46 PM

#

F

#

sry xd

copper nacelle Aug 10, 2021, 10:46 PM

#

you don't need to know how to mod for a basic platforming challenge though

potent mantle Aug 10, 2021, 10:47 PM

#

i mean

copper nacelle Aug 10, 2021, 10:47 PM

#

There's a mod called DecorationMaster which let's you make your own though it'll be in normal levels

potent mantle Aug 10, 2021, 10:47 PM

#

mmh

copper nacelle Aug 10, 2021, 10:47 PM

#

for a new scene you have to use unity and such

potent mantle Aug 10, 2021, 10:47 PM

#

ah

#

f

#

cant code

#

dont have unity either

copper nacelle Aug 10, 2021, 10:47 PM

#

get unity tm

#

https://radiance.host/apidocs

potent mantle Aug 10, 2021, 10:48 PM

#

copper nacelle get unity tm

tm ?

#

trademark ?

rough pulsar Aug 10, 2021, 10:53 PM

#

i never ever saw a modding staff ping and this is the first time

solemn rivet Aug 10, 2021, 10:59 PM

#

I HAVE BEEN SUMMONED FROM DARKNESS

worn eagle Aug 10, 2021, 11:00 PM

#

gradow when is mi4 coming out

solemn rivet Aug 10, 2021, 11:00 PM

#

notlikequirrel

#

how's installer 2 56

copper nacelle Aug 10, 2021, 11:06 PM

#

pretty good

rough pulsar Aug 10, 2021, 11:08 PM

#

solemn rivet I HAVE BEEN SUMMONED FROM DARKNESS

Make mi6942036042

quick flame Aug 11, 2021, 12:06 AM

#

i need help to get hk mods

copper nacelle Aug 11, 2021, 12:07 AM

#

does this look like #archived-modding-help to you

quick flame Aug 11, 2021, 12:07 AM

#

sorry

copper nacelle Aug 11, 2021, 12:07 AM

#

happens

rough pulsar Aug 11, 2021, 12:23 AM

#

this channel is #archived-modding-help and #modding-discussion for mod developers

potent summit Aug 11, 2021, 1:55 AM

#

How do I do options in the menu to my mod?

#

?

ornate rivet Aug 11, 2021, 2:06 AM

#

the modding api has a menu api

potent summit Aug 11, 2021, 2:07 AM

#

A

charred topaz Aug 11, 2021, 2:49 AM

#

@dark wigeon Hey, I'm running into an issue in regards to AssetTools.Net. Everything up until now has been working smoothly, but when I try to remove an audio asset from the WeaverCore Bundle, AssetTools is throwing an exception saying the provided data seems to be corrupted. All I did was change the AudioClip's AssetBundle name from "weavercore_bundle" to "None". It will only work if I include this audio asset in the bundle.

However, when I switch the compression type in the Pack() method from LZ4 to LZMA, the issue goes away. It only seems to occur when using LZ4 compression. I also tried deleting the audioClip entirely and deleting any cached files left over during the build, but those things didn't change anything.

dark wigeon Aug 11, 2021, 2:50 AM

#

I doubt changing the name has anything to do with it

#

I didn't write the lz4 packing code so I'm not sure

#

if you give me the bundle I'll try checking it out

#

like before and after so I can compare

charred topaz Aug 11, 2021, 2:57 AM

#

dark wigeon if you give me the bundle I'll try checking it out

https://drive.google.com/file/d/1fRNP68EA6UGIF_y3rg9uHrfqQeKxrAq7/view?usp=sharing

dark wigeon Aug 11, 2021, 2:57 AM

#

is this before or after

charred topaz Aug 11, 2021, 2:58 AM

#

This is before packing. The pack function seems to create a bundle with 0KB in size

floral blade Aug 11, 2021, 8:01 AM

#

is it possible to change the location the game looks for unity dlls ?

jolly oriole Aug 11, 2021, 8:03 AM

#

you can move the entire game folder

#

but i don't think that's what you wanted

floral blade Aug 11, 2021, 8:05 AM

#

yeah no lol

#

i was thinking if there was a way to copy the xbox game pass version's exe and tell it to look for assembly-c-sharp & /mods in the saves folder & all other files from the normal install, that would only require the permissions to the game files to be read only and still work to mod. though i neither have windows nor the xbox game pass version so i was mostly asking a theoretical question

#

the modded exe & dll would sit outside the trusted ms crap folder

jolly oriole Aug 11, 2021, 8:10 AM

#

as far as i understand windows and its quirks, an executable looks in its directory, then at enviroment paths to find wanted DLLs, so you'd have to add a hk-assembly-directory to the enviroment variables and remove the assemblies from the games installtion folder, which is difficult because of the permissions

floral blade Aug 11, 2021, 8:11 AM

#

no but we also moved the executable

#

we are only copying things out and modifying the copies, and telling the copies to look at the original folder for other stuff

jolly oriole Aug 11, 2021, 8:12 AM

#

though at that point one isn't that far off of providing pirated copies

floral blade Aug 11, 2021, 8:13 AM

#

tbf mapi already includes a modded assembly-c-sharp.

cedar hemlock Aug 11, 2021, 8:14 AM

#

https://github.com/ricardosouzag/ModInstaller/issues/112 hollowcry

potent summit Aug 11, 2021, 12:17 PM

#

What's the hook of the nail damage

jolly jungle Aug 11, 2021, 12:23 PM

#

Should be here https://hk-modding.github.io/api/api/Modding.ModHooks.html

#

In some fashion

#

I think

potent summit Aug 11, 2021, 12:32 PM

#

Ok

#

Don't have nail damage beesive

light zodiac Aug 11, 2021, 12:41 PM

#

Wdym?

potent summit Aug 11, 2021, 12:54 PM

#

Wdym? What's that

primal latch Aug 11, 2021, 12:54 PM

#

What do you mean

potent summit Aug 11, 2021, 12:55 PM

#

Ok

#

Like the hook of the nail damage i want to change it to my mod

jolly oriole Aug 11, 2021, 1:01 PM

#

resulting of how hk is structured, that is done with the GetPlayerIntHook https://hk-modding.github.io/api/api/Modding.ModHooks.html#Modding_ModHooks_GetPlayerIntHook
you can do pretty much what the example is but instead of "charmSlots" you have "nailDamage"

potent summit Aug 11, 2021, 1:03 PM

#

ok

#

[thx

cedar hemlock Aug 11, 2021, 1:03 PM

#

primal latch What do you mean

wdym? what do you mean?

potent summit Aug 11, 2021, 1:42 PM

#

is it correct have one error

cedar hemlock Aug 11, 2021, 1:50 PM

#

potent summit is it correct have one error

PlayerData.instance.nailDamage = 5;

#

assuming you want to set naildamage to 5

potent summit Aug 11, 2021, 1:50 PM

#

oh thx

cedar hemlock Aug 11, 2021, 1:52 PM

#

what unity version do i need for 1.5?

jolly oriole Aug 11, 2021, 1:53 PM

#

2020.2.2

cedar hemlock Aug 11, 2021, 1:53 PM

#

k

potent summit Aug 11, 2021, 2:01 PM

#

cedar hemlock `PlayerData.instance.nailDamage = 5;`

didnt function in game

#

i put damage 2

cedar hemlock Aug 11, 2021, 2:02 PM

#

in which modhook did you put it

potent summit Aug 11, 2021, 2:03 PM

#

i put there

cedar hemlock Aug 11, 2021, 2:04 PM

#

well you are trying to set info of a save before a save is loaded

potent summit Aug 11, 2021, 2:04 PM

#

oh

#

so where i put

cedar hemlock Aug 11, 2021, 2:07 PM

#

        int target = 5;

        public override void Initialize()
        {
            
            ModHooks.instance.HeroUpdateHook += Update;


        }

        private void Update()
        {
            if (PlayerData.instance.nailDamage != target)
            {
                PlayerData.instance.nailDamage = target;
            }
            else
            {
                ModHooks.instance.HeroUpdateHook -= Update;
            }
        }
```Should work

#

not the most optimized way

#

you can change target to the damage you want

potent summit Aug 11, 2021, 2:08 PM

#

thx

light zodiac Aug 11, 2021, 2:10 PM

#

potent summit didnt function in game

See what debug does

cedar hemlock Aug 11, 2021, 2:10 PM

#

effort

#

why do that when someone else types all the code for you 🥴

cedar hemlock Aug 11, 2021, 2:11 PM

#

light zodiac See what debug does

but hasn't that transferred to 1.5 already?

light zodiac Aug 11, 2021, 2:12 PM

#

https://github.com/TheMulhima/HollowKnight.DebugMod/blob/1242de1420f7cd233ecd34177aa8702d0917d7ec/Source/BindableFunctions.cs#L25-L35

cedar hemlock Aug 11, 2021, 2:12 PM

#

embed

light zodiac Aug 11, 2021, 2:12 PM

#

cedar hemlock but hasn't that transferred to 1.5 already?

So?

cedar hemlock Aug 11, 2021, 2:12 PM

#

well if you want to make a mod for 1.4 1.5 code won't work

cedar hemlock Aug 11, 2021, 2:13 PM

#

potent summit thx

do add PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE"); after PlayerData.instance.nailDamage = target;

light zodiac Aug 11, 2021, 2:14 PM

#

potent summit is it correct have one error

What grenade suggested you do
In init

ModHooks.GetPlayerIntHook += GetInt;```

Then do
```cs
Private int? GetInt(string name, int orig) {
    return name == "nailDamage" ? Target : orig;
}```

cedar hemlock Aug 11, 2021, 2:14 PM

#

fail

rough pulsar Aug 11, 2021, 2:14 PM

#

mul you need to put 3 backticks at the start not two

#

wait

#

if you hook getint to set nail damage to another number (e.g. 7), doesn't the game save naildamage variable as 7?

cedar hemlock Aug 11, 2021, 2:17 PM

#

rough pulsar wait

i was not doing anything

jolly oriole Aug 11, 2021, 2:20 PM

#

rough pulsar if you hook getint to set nail damage to another number (e.g. 7), doesn't the ga...

no, it saves whatever gets set to the internal PlayerData.nailDamage variable

rough pulsar Aug 11, 2021, 2:20 PM

#

oh ok

potent summit Aug 11, 2021, 2:32 PM

#

Have some classes about c sharp

#

In yourube

cedar hemlock Aug 11, 2021, 2:33 PM

#

did you want to announce that or did you want to tell kaan that?

potent summit Aug 11, 2021, 2:37 PM

#

No my English is trash what i want to said is i want to learn more c sharp if this help to modding

cedar hemlock Aug 11, 2021, 2:37 PM

#

If you know how to code in Csharp that helps alot yes

potent summit Aug 11, 2021, 2:38 PM

#

Oh ok

radiant basin Aug 11, 2021, 2:44 PM

#

im kind of regretting failing my csharp class these days lmao

rough pulsar Aug 11, 2021, 2:47 PM

#

There is an official guide on c# by microsoft, it's pretty great

#

It's a text guide but it has everything about c# i think

vocal spire Aug 11, 2021, 2:54 PM

#

cedar hemlock ```cs int target = 5; public override void Initialize() ...

Smh using hero update at least use on hero awake if you aren’t gonna use pd hooks

vocal spire Aug 11, 2021, 2:56 PM

#

radiant basin im kind of regretting failing my csharp class these days lmao

I’m kind of regretting applying for programming classes in my school and not getting them, not regretting learning on my own though zote

rough pulsar Aug 11, 2021, 2:56 PM

#

I learned c# on my own

cedar hemlock Aug 11, 2021, 2:56 PM

#

vocal spire Smh using hero update at least use on hero awake if you aren’t gonna use pd hook...

hollowgun

steady comet Aug 11, 2021, 2:56 PM

#

Is there a reaspn to use MondHooks.HeroUpdateHook rather than On.HeroController.Update?

vocal spire Aug 11, 2021, 2:57 PM

#

Faster to type

#

No difference

steady comet Aug 11, 2021, 2:57 PM

#

palehmm

rough pulsar Aug 11, 2021, 2:57 PM

#

Also it's not MondHooks it's ModHooks

vocal spire Aug 11, 2021, 2:57 PM

#

Other than needing to call orig if you want it to function like normal, but I think that’s a given with on hooks

#

autocorrect stop

rough pulsar Aug 11, 2021, 2:57 PM

#

I disabled autocorrect on my phone shadeshades

vocal spire Aug 11, 2021, 2:58 PM

#

I’m too lazy

potent summit Aug 11, 2021, 3:10 PM

#

why intialize is incorrect

rough pulsar Aug 11, 2021, 3:11 PM

#

potent summit why intialize is incorrect

You didn't put : Mod after the name of your class

potent summit Aug 11, 2021, 3:11 PM

#

oh

rough pulsar Aug 11, 2021, 3:11 PM

#

Oh and also do

#

public MyMod() : base("My Mod")
{
  // stuff
}

Replace "MyMod" with the name of your class and "My Mod" with the actual name of your mod

potent summit Aug 11, 2021, 3:12 PM

#

ok

rough pulsar Aug 11, 2021, 3:14 PM

#

Question, is it fine if i make the initialize method asynchronous?

potent summit Aug 11, 2021, 3:17 PM

#

Now they to have error

rough pulsar Aug 11, 2021, 3:17 PM

#

potent summit Now they to have error

You need to do

public HardMode() : base("Hard Mode") 
{

}

potent summit Aug 11, 2021, 3:19 PM

#

#

like that

#

but already have errors

rough pulsar Aug 11, 2021, 3:19 PM

#

Can you show the upper part of your code, like public class HardMode?

potent summit Aug 11, 2021, 3:20 PM

#

rough pulsar Aug 11, 2021, 3:20 PM

#

Apparently it works?

#

Oh

#

You added two Initialize methods and two constructors (public HardMode () : base("Hard Mode")

#

That's why it's giving errors

potent summit Aug 11, 2021, 3:21 PM

#

oh

#

so i erase

rough pulsar Aug 11, 2021, 3:22 PM

#

Yeah except move the contents of the second Initialize method to the first one

ornate rivet Aug 11, 2021, 4:43 PM

#

#

lets gooooooooooo

jolly oriole Aug 11, 2021, 4:44 PM

#

less gooo

rough pulsar Aug 11, 2021, 4:44 PM

#

is it ok if i use async in initialize

copper nacelle Aug 11, 2021, 4:49 PM

#

depends on if you use anything unity

ornate rivet Aug 11, 2021, 4:50 PM

#

slow

rough pulsar Aug 11, 2021, 4:50 PM

#

my system took ages to reach 3.85% or something in utiny

ornate rivet Aug 11, 2021, 4:51 PM

#

technically this isn't utiny :)

rough pulsar Aug 11, 2021, 4:51 PM

#

utiny ripper

ornate rivet Aug 11, 2021, 4:51 PM

#

AssetRipper

rough pulsar Aug 11, 2021, 4:51 PM

#

Oh ok

vocal spire Aug 11, 2021, 4:51 PM

#

Yoooooo

ornate rivet Aug 11, 2021, 4:52 PM

#

it works with 2020.2.0 so hopefully it works with 2020.2.2 too

#

spring lantern Aug 11, 2021, 4:52 PM

#

hey where can i find mod api download?

vocal spire Aug 11, 2021, 4:52 PM

#

~~Smh if that single extra number stops it -~~

vocal spire Aug 11, 2021, 4:53 PM

#

spring lantern hey where can i find mod api download?

#archived-modding-help it’s usually automatically installed when using a mod installer, if not it’s on the list of mods

spring lantern Aug 11, 2021, 4:53 PM

#

k thanks

cedar hemlock Aug 11, 2021, 4:55 PM

#

does assetbundle work for 1.5? (2020.2.2)

#

cus if no then i'll need to go to 1.4 grubsad

vocal spire Aug 11, 2021, 4:58 PM

#

cedar hemlock does assetbundle work for 1.5? (2020.2.2)

Yes

#

Why wouldn’t it

cedar hemlock Aug 11, 2021, 4:58 PM

#

cus it isn't working for me sadgeyes

#

Assets\AssetBundles-Browser-1.7.0\Tests\Editor\ABModelTests.cs(13,7): error CS0246: The type or namespace name 'Boo' could not be found (are you missing a using directive or an assembly reference?)

#

_ _
Assets\AssetBundles-Browser-1.7.0\Tests\Editor\Util\TestUtil.cs(5,7): error CS0246: The type or namespace name 'Boo' could not be found (are you missing a using directive or an assembly reference?)
_ _

#

Assets\AssetBundles-Browser-1.7.0\Tests\Editor\Util\TestUtil.cs(19,56): error CS0246: The type or namespace name 'RuntimeServices' could not be found (are you missing a using directive or an assembly reference?)

rough pulsar Aug 11, 2021, 5:02 PM

#

time to make a stupid mistake while modding and break everything

cedar hemlock Aug 11, 2021, 5:02 PM

#

k

#

have fun

ornate rivet Aug 11, 2021, 5:16 PM

#

I had to remove the lines that weren't working

#

idk what other people did

copper nacelle Aug 11, 2021, 5:17 PM

#

delete it and put it back tm

floral blade Aug 11, 2021, 5:20 PM

#

so basically yeet the tests directory ?

ornate rivet Aug 11, 2021, 5:28 PM

#

yea

jolly oriole Aug 11, 2021, 5:32 PM

#

assetbundle browser shroompause

ornate rivet Aug 11, 2021, 5:32 PM

#

I swear utiny wasn't this slow

ornate rivet Aug 11, 2021, 5:33 PM

#

jolly oriole assetbundle browser <:shroompause:817511607004561408>

u

ornate rivet Aug 11, 2021, 6:19 PM

#

YOOO

#

it worked

#

#

and shaders work too now apparently??

#

the blurplane didn't work automatically with utiny ripper

ornate rivet Aug 11, 2021, 6:35 PM

#

nvm shaders are just broken in a different way lmao

jolly oriole Aug 11, 2021, 6:39 PM

#

lol

jolly jungle Aug 11, 2021, 6:51 PM

#

cedar hemlock ```cs int target = 5; public override void Initialize() ...

Isn't update a bad idea for a name for this?

jolly oriole Aug 11, 2021, 6:52 PM

#

no, because Mod isn't a derivative of MonoBehaviour

jolly jungle Aug 11, 2021, 6:52 PM

#

Ah, true

jolly jungle Aug 11, 2021, 6:52 PM

#

ornate rivet

Hive Knight arena?

jolly oriole Aug 11, 2021, 6:53 PM

#

yes

jolly jungle Aug 11, 2021, 6:53 PM

#

What're you planning to do with it

rough pulsar Aug 11, 2021, 6:58 PM

#

jolly jungle What're you planning to do with it

vespa battle in pale court apparently intenseface

cedar hemlock Aug 11, 2021, 7:01 PM

#

jolly jungle Isn't update a bad idea for a name for this?

because i don't have monobehavior and heroupdate is basically the same as update, i like to make them the same name so i don't get confused

floral blade Aug 11, 2021, 7:51 PM

#

how do you move where the map zooms in to show the quickmap ?

jolly oriole Aug 11, 2021, 7:52 PM

#

it's part of the quick map fsm or something

#

yep, it's in the quick map fsm

floral blade Aug 11, 2021, 7:53 PM

#

i saw a set position with space = 1
but trying to set the positon using
self.gameObject.transform.localPosition = new Vector3(0, 0, 0);
in PositionCompass did nothing 😦

jolly oriole Aug 11, 2021, 7:54 PM

#

https://github.com/SFGrenade/AdditionalMaps/blob/9e664889e2ead07db137115f49ee7df9a669ff64/MonoBehaviours/GameMapHooks.cs#L144-L146

floral blade Aug 11, 2021, 7:55 PM

#

yes but i am trying to not modify that FSM because it relies on mapZone and i need to show the map based on scene name

jolly oriole Aug 11, 2021, 7:55 PM

#

then have a lot of fun

floral blade Aug 11, 2021, 7:56 PM

#

i am able to show my map

#

it's just in the corner of the screen because the greenpath map is in the center (which i made inactive)

jolly oriole Aug 11, 2021, 7:59 PM

#

yes

#

because setposition is run after positioncompas

floral blade Aug 11, 2021, 7:59 PM

#

#

so a coroutine ?

jolly oriole Aug 11, 2021, 8:00 PM

#

if you want it to work correctly, you can edit the quickmap fsm to include some method of yours in each of the area states (after all other actions ofc)

#

... or you hook On.HutongGames.PlayMaker.Actions.SetPosition.OnEnter and filter out the ones of the quick map fsm, then after it do your code, but that's overboard

floral blade Aug 11, 2021, 8:05 PM

#

the first bit is probably what i will do in the end, for now i am just hooking into QuickMapGreenpath to atleast get the map working once

jolly oriole Aug 11, 2021, 8:08 PM

#

have fun with that, when the position is changed after that method is called

floral blade Aug 11, 2021, 8:08 PM

#

true, coroutine abuse it is

jolly oriole Aug 11, 2021, 8:09 PM

#

that is really shroompause

#

floral blade Aug 11, 2021, 8:12 PM

#

yeah i had seen that i also thought that since the game updates the positon of the compass it will probably be called again after that

#

apparently not

#

but thanks! i have finally got the map on screen, now i can peacefully fix this crap

#

primal latch Aug 11, 2021, 8:20 PM

#

Noice

jolly oriole Aug 11, 2021, 9:21 PM

#

so the ?mute still didn't work ig

copper nacelle Aug 11, 2021, 9:22 PM

#

no he just beat me to it I believe

#

do you want to find out

jolly oriole Aug 11, 2021, 9:22 PM

#

nah

copper nacelle Aug 11, 2021, 9:22 PM

#

this is so sad

#

?mute 56 amogus

finite forumBOT Aug 11, 2021, 9:22 PM

#

dynoError I can't find user 56.

copper nacelle Aug 11, 2021, 9:22 PM

#

blind

jolly oriole Aug 11, 2021, 9:22 PM

#

wait what

copper nacelle Aug 11, 2021, 9:22 PM

#

?mute SFGrenade amogus

finite forumBOT Aug 11, 2021, 9:22 PM

#

dynoSuccess SFGrenade#2066 was muted | amogus

copper nacelle Aug 11, 2021, 9:23 PM

#

true

#

?unmute SFGrenade

finite forumBOT Aug 11, 2021, 9:23 PM

#

dynoSuccess SFGrenade#2066 was unmuted

ornate rivet Aug 11, 2021, 9:23 PM

#

coool

jolly oriole Aug 11, 2021, 9:23 PM

#

mod abuse

copper nacelle Aug 11, 2021, 9:23 PM

#

true

fair rampart Aug 11, 2021, 10:44 PM

#

finite forum

sus

ornate rivet Aug 11, 2021, 10:48 PM

#

your mom is sus

safe hamlet Aug 11, 2021, 11:38 PM

#

?mute @copper nacelle

#

????

#

doesn't work

worn eagle Aug 12, 2021, 12:08 AM

#

can someone test if this works in 1432? when you hover your cursor over a scene on the map, it should show the scene name above the cursor, but I'm not getting any hits

📎 FastTravel.dll

nimble lake Aug 12, 2021, 3:39 AM

#

worn eagle can someone test if this works in 1432? when you hover your cursor over a scene ...

not working for me

#

i can see the cursor but it's not even teleporting when i click

craggy schooner Aug 12, 2021, 7:07 AM

#

0

cedar hemlock Aug 12, 2021, 8:26 AM

#

does someone have a working assetbundle thingie for 1.5?

#

i can't get it to work

jolly oriole Aug 12, 2021, 8:36 AM

#

just don't use it

#

works wonders

cedar hemlock Aug 12, 2021, 8:37 AM

#

what do i do then if i want a custom enemy in-game?

#

ok yeeting the test directory worked

#

i'll just hope that isn't needed

jolly oriole Aug 12, 2021, 8:39 AM

#

assetbundle without assetbundle browser?

cedar hemlock Aug 12, 2021, 8:39 AM

#

no

#

only the "test" folder

jolly oriole Aug 12, 2021, 8:39 AM

#

i meant that towards the

what do i do then if i want a custom enemy in-game?

cedar hemlock Aug 12, 2021, 8:40 AM

#

oh

#

idk how, so if this method works i'll use the browser for now

floral blade Aug 12, 2021, 8:41 AM

#

jolly oriole assetbundle without assetbundle browser?

that knowledge is not shared with me yet

jolly oriole Aug 12, 2021, 8:44 AM

#

https://docs.unity3d.com/Manual/AssetBundles-Workflow.html - Assigning Assets to AssetBundles - 3rd step

primal latch Aug 12, 2021, 9:13 AM

#

Am I the only one who severely doubts this? #modding-discussion message

cedar hemlock Aug 12, 2021, 9:21 AM

#

what was dirtmouth called again

#

just "Town"?

jolly oriole Aug 12, 2021, 10:17 AM

#

yes

jolly jungle Aug 12, 2021, 11:58 AM

#

floral blade

Yoo what is that shroompog

floral blade Aug 12, 2021, 12:00 PM

#

jolly jungle Yoo what is that <:shroompog:585688871552155649>

a custom map in a custom scene mastersmirk

jolly jungle Aug 12, 2021, 12:01 PM

#

Epic 👌

#

Care to elaborate? sherma

cedar hemlock Aug 12, 2021, 12:01 PM

#

dandy has already leaked

#

dandy is elaboratingn't

jolly jungle Aug 12, 2021, 12:04 PM

#

cedar hemlock dandy has already leaked

sharpeD

#

Where?

cedar hemlock Aug 12, 2021, 12:05 PM

#

dandy is elaborating

floral blade Aug 12, 2021, 12:05 PM

#

jolly jungle Epic 👌

basically i was trying to make a futbol mod, on HKMP but needed to make new scene and maps and stuff

cedar hemlock Aug 12, 2021, 12:05 PM

#

[api] ERR: request timed out

#

should've been the response

floral blade Aug 12, 2021, 12:06 PM

#

so thats what this is, the actual futbol part, may not work tho

jolly jungle Aug 12, 2021, 12:06 PM

#

floral blade basically i was trying to make a futbol mod, on HKMP but needed to make new scen...

Woo, that's awesomw

#

How'll the scene be accessed?

cedar hemlock Aug 12, 2021, 12:06 PM

#

may not work sadcowgrub

floral blade Aug 12, 2021, 12:06 PM

#

jolly jungle How'll the scene be accessed?

rn by hugging the left most wall in dirtmouth

cedar hemlock Aug 12, 2021, 12:07 PM

#

maggothug

floral blade Aug 12, 2021, 12:07 PM

#

cedar hemlock may not work <:sadcowgrub:594102870966665216>

yeah i am not yet sure how to sync the ball, because it'll go out of sync pretty quickly i think

jolly oriole Aug 12, 2021, 12:08 PM

#

~~test it before making assumptions~~

jolly jungle Aug 12, 2021, 12:08 PM

#

"only once you see it doesn't work, should you give up"
- Sun Tzu

jolly oriole Aug 12, 2021, 12:08 PM

#

but yea, with the latency it will desync

floral blade Aug 12, 2021, 12:09 PM

#

yep i plan on completing the mod one way or the other mastersmirk i might have to make a player turn into ball for hkmp to sync the ball

#

because hkmp can clearly sync player positions lol

jolly oriole Aug 12, 2021, 12:10 PM

#

but without latency it won't desync

#

... if you use unitys things to handle physics

cedar hemlock Aug 12, 2021, 12:10 PM

#

make the ball a player 🥴

floral blade Aug 12, 2021, 12:10 PM

#

physics does not have randomness ?

jolly oriole Aug 12, 2021, 12:11 PM

#

if you call something with Random, then yes

#

otherwise no

floral blade Aug 12, 2021, 12:11 PM

#

ah

#

it might work both ways then

jolly jungle Aug 12, 2021, 12:14 PM

#

Can you make one of the players host the ball?

floral blade Aug 12, 2021, 12:20 PM

#

far as i can tell, not without messing with re-implementing part of HKMP in my mod / custom HKMP builds

floral blade Aug 12, 2021, 12:21 PM

#

floral blade yep i plan on completing the mod one way or the other <:mastersmirk:722645773086...

this is easiest tbh, take control away from a player , make them a child of ball & set their z behind the ball / make use of invisible skin

vocal spire Aug 12, 2021, 12:36 PM

#

I’ve suggested this a long time ago but I suggest creating some api for hkmp that other mods can use

#

Mods can see if they’re the host, then sync their own stuff, ex the ball in this case

rough pulsar Aug 12, 2021, 12:36 PM

#

is it just football

#

are you porting soccer to hollow knight

#

i thought it was some sort of pvp arena

jolly oriole Aug 12, 2021, 12:43 PM

#

soccer

steady comet Aug 12, 2021, 1:10 PM

#

Is there a guide anywhere for how to do stuff with IL hooks?

rough pulsar Aug 12, 2021, 1:11 PM

#

my accent is ameritish

floral blade Aug 12, 2021, 1:27 PM

#

vocal spire I’ve suggested this a long time ago but I suggest creating some api for hkmp tha...

it is a planned feature but not a super high priority one atm

floral blade Aug 12, 2021, 1:31 PM

#

rough pulsar i thought it was some sort of pvp arena

ye PVP soccer

#

i dont even like soccer , i thought it would be an easy mod to make lol

vocal spire Aug 12, 2021, 1:32 PM

#

steady comet Is there a guide anywhere for how to do stuff with IL hooks?

Iirc hollow point uses them

floral blade Aug 12, 2021, 1:32 PM

#

floral blade i dont even like soccer , i thought it would be an easy mod to make lol

i was referred to this once

floral blade Aug 12, 2021, 1:32 PM

#

steady comet Is there a guide anywhere for how to do stuff with IL hooks?

https://github.com/EverestAPI/Resources/wiki/Your-First-Code-Mod#ilceleste-hooks

#

perhaps it can help you more than it did me

steady comet Aug 12, 2021, 1:37 PM

#

Ooh, thanks

#

I'll take a look

#

Ah yeah that seems helpful enough

#

Definitely better than this one https://radiance.host/apidocs/IL.html 😤

floral blade Aug 12, 2021, 1:46 PM

#

yes that is definitely true

rough pulsar Aug 12, 2021, 1:54 PM

#

the time we get a complete apidocs is longer than silksong

primal latch Aug 12, 2021, 2:50 PM

#

How would I go about adding a lore tablet interaction?

rough pulsar Aug 12, 2021, 3:08 PM

#

what is the difference between canDash and hasDash?

primal latch Aug 12, 2021, 3:08 PM

#

can dash is set to false if you dashed and didn't touch the ground

#

hasDash is wheter you have acquired the cloack

rough pulsar Aug 12, 2021, 3:09 PM

#

thanks

jolly oriole Aug 12, 2021, 3:16 PM

#

primal latch How would I go about adding a lore tablet interaction?

Tot has one

rough pulsar Aug 12, 2021, 3:16 PM

#

sfg

#

if i set this to false, the item prefab should appear right

jolly oriole Aug 12, 2021, 3:17 PM

#

It looks more like that it appears when that is set to true

rough pulsar Aug 12, 2021, 3:18 PM

#

hmm

primal latch Aug 12, 2021, 3:25 PM

#

jolly oriole Tot has one

Thanks. Trying to find it now

#

Can't find it

jolly oriole Aug 12, 2021, 3:30 PM

#

1 sec, booting pc

#

https://github.com/SFGrenade/TestOfTeamwork/blob/master/MonoBehaviours/Patcher/PatchInspectRegion.cs, have some inspect region prefab

floral blade Aug 12, 2021, 3:32 PM

#

jolly oriole <https://github.com/SFGrenade/TestOfTeamwork/blob/master/MonoBehaviours/Patcher/...

very yoinkable code this is , i like

jolly oriole Aug 12, 2021, 3:33 PM

#

it's good that it's 'yoinkable', confirms that it's widely usefull, not much hardcoded (in this case, only where it gets the prefab from)

floral blade Aug 12, 2021, 3:35 PM

#

yep

rough pulsar Aug 12, 2021, 3:37 PM

#

how do i hide soul/health hud if i wanted to

jolly oriole Aug 12, 2021, 3:38 PM

#

debug mod or there also is some fsmevent you can broadcast

#

the gg nkg scene does that

rough pulsar Aug 12, 2021, 3:39 PM

#

what is the fsmevent i can broadcast

jolly oriole Aug 12, 2021, 3:39 PM

#

idk, gimme a sec

copper nacelle Aug 12, 2021, 3:39 PM

#

FsmEvent.Finished

#

:)

jolly oriole Aug 12, 2021, 3:39 PM

#

well, that is one you could broadcast

rough pulsar Aug 12, 2021, 3:39 PM

#

what

#

oh

jolly oriole Aug 12, 2021, 3:40 PM

#

also can't believe 56 is typing while offline

rough pulsar Aug 12, 2021, 3:40 PM

#

wait can you demonstrate in code

primal latch Aug 12, 2021, 3:40 PM

#

We are planning on making Fyremoth open source, but you probably shouldn't look at it.

#

It's absolute chaos

jolly oriole Aug 12, 2021, 3:43 PM

#

rough pulsar wait can you demonstrate in code

#

the eventTarget is btw definetly not complicated at all...

rough pulsar Aug 12, 2021, 3:47 PM

#

thanks

worn eagle Aug 12, 2021, 4:18 PM

#

alright I think I got it working, if someone can try it out on 1432

📎 FastTravel.dll

nimble lake Aug 12, 2021, 4:38 PM

#

worn eagle alright I think I got it working, if someone can try it out on 1432

it's kind of a hit and miss,
when I loaded the game and tried it, it seemed to work, but after the first teleport I wasn't able to open the map by double-clicking Tab
I reloaded the save and then I tried it again, but I wasn't able to teleport. It didn't show the scene name above the cursor either.

primal latch Aug 12, 2021, 4:40 PM

#

grenade, I tried to implement your code by doing this:

public static GameObject familyInteraction;

        public static void Initialize()
        {
            SetupFamilyInteraction();
        }

        public static void SetupFamilyInteraction()
        {
            GameObject inspect = UnityEngine.Object.Instantiate(Fyremoth.preloadedObjects["White_Palace_18"]["Inspect Region"]);
            inspect.name = "familyDialogue";
            var collider = inspect.GetComponentInChildren<BoxCollider2D>();
            collider.offset = new Vector2(0f, -2f);
            collider.size = new Vector2(10f, 1f);

            var fsm = inspect.LocateMyFSM("inspect_region");
            var fsmVar = fsm.FsmVariables;

            fsmVar.GetFsmString("Game Text Convo").Value = "UI_MENU_STYLE_FYREMOTH";
            inspect.SetActive(false);
            GameObject.DontDestroyOnLoad(inspect);
            familyInteraction = inspect;
        }```

#

and then when the scene is loaded:

Fyremoth.Instance.Log(CustomObjects.familyInteraction == null);

                    GameObject interaction = UObject.Instantiate(CustomObjects.familyInteraction);
                    interaction.SetActive(true);
                    interaction.transform.position = new Vector3(50f, 132f, 3.5f);

                    Fyremoth.Instance.Log(interaction == null);```

#

both null checks return false

#

but the interaction doesn't show up and neither does it's hitbox

jolly oriole Aug 12, 2021, 5:34 PM

#

the collider might be underground then, though should be rendered

#

otherwise that should work

cedar hemlock Aug 12, 2021, 6:19 PM

#

whats going wrong

📎 message.txt

#

            if(go1 == null && arg1.name == "Town")
            {
                Log("loading GO");
                go1 = GameObject.Instantiate(assetb.LoadAsset<GameObject>("Capsule"));
                go1.SetActive(true);
                go1.GetComponent<SpriteRenderer>().material = new Material(Shader.Find("Sprites/Default"));
                go1.AddComponent<DamageHero>();
                go1.AddComponent<HealthManager>();
                hm = go1.GetComponent<HealthManager>();
                hm.hp = 100;
                Log("GO loaded");
            }
```for reference

#

oh nvm saleh added his code to the docs

primal latch Aug 12, 2021, 6:30 PM

#

jolly oriole otherwise that should work

Hmmm. Wierd

primal latch Aug 12, 2021, 6:57 PM

#

Something else: when getting the current scene, getting the game object and trying to log it’s coordinates it give a null reference error.

jolly oriole Aug 12, 2021, 6:58 PM

#

at which point of that sequence

primal latch Aug 12, 2021, 6:58 PM

#

At the end

#

After the final null check

#

Just realised I forgot to add (clone) behind it

jolly oriole Aug 12, 2021, 6:59 PM

#

nice

primal latch Aug 12, 2021, 6:59 PM

#

So that is probably unrelated

jolly oriole Aug 12, 2021, 6:59 PM

#

but i meant:
getting scene
log
getting game object
log
get coordinates
log

primal latch Aug 12, 2021, 6:59 PM

#

The get coordinate

#

I think. I have the get statement in the log

rough pulsar Aug 12, 2021, 7:13 PM

#

the

jolly oriole Aug 12, 2021, 7:14 PM

#

the

kindred sedge Aug 12, 2021, 11:47 PM

#

so how hard would it be to go in and replace enemies with specific ones by hand? like to make new encounters

ornate rivet Aug 13, 2021, 12:23 AM

#

not that hard as long as you have modding knowledge

elfin thorn Aug 13, 2021, 8:38 AM

#

Well guys, im trying to make this skin based on Hollow Knight, i would love some tips on how i can complete this and how to change the other sprites, any tips and any help is much appreciated, if anyone from TWP mods would like to give some advices too!

cedar hemlock Aug 13, 2021, 8:39 AM

#

well if you can get a reaction from TWP you're very lucky

elfin thorn Aug 13, 2021, 8:40 AM

#

Anyone that made any skin that can help would be a lot too

cedar hemlock Aug 13, 2021, 8:41 AM

#

but #modding-discussion would probably be the best place to ask

elfin thorn Aug 13, 2021, 8:41 AM

#

Ok, cool!

#

ty

cedar hemlock Aug 13, 2021, 9:14 AM

#

cedar hemlock whats going wrong

am still having this issue, the code that is in the docs does not help

#

the error shows up everytime i try to hit the enemy

jolly oriole Aug 13, 2021, 9:15 AM

#

looks like whatever is supposed to be spawned when getting hit is null

cedar hemlock Aug 13, 2021, 9:16 AM

#

that would be

                InfectedEnemyEffects ogrimHitEffects = Kin.GetComponent<InfectedEnemyEffects>();
                foreach (FieldInfo fi in typeof(InfectedEnemyEffects).GetFields(
                    BindingFlags.Instance | BindingFlags.NonPublic))
                {
                    // Reposition where the hit effect comes from to be slightly higher
                    if (fi.Name == "effectOrigin")
                    {
                        fi.SetValue(iee, new Vector3(0, 0.5f, 0f));
                    }
                    else fi.SetValue(iee, fi.GetValue(ogrimHitEffects));
                }

```this part of saleh's code?

jolly oriole Aug 13, 2021, 9:17 AM

#

maybe

jolly oriole Aug 13, 2021, 2:12 PM

#

<@&283547423706447872>

jolly oriole Aug 13, 2021, 2:54 PM

#

i don't know how i manage to break my entire modded installation every once in a while

primal latch Aug 13, 2021, 2:59 PM

#

same

jolly oriole Aug 13, 2021, 2:59 PM

#

ok, maybe i just broke more than the modded installation

primal latch Aug 13, 2021, 3:03 PM

#

oof

floral blade Aug 13, 2021, 3:08 PM

#

is this registry magic gone wrong?

jolly oriole Aug 13, 2021, 3:15 PM

#

i have no idea

#

apparently a file in my main installation got fucked while i modded a seperate installtion

jolly oriole Aug 13, 2021, 3:51 PM

#

i apparently fixed it somehow

#

idk what was wrong tbh

primal latch Aug 13, 2021, 3:52 PM

#

Could there be any reason why an enemy I'm spawning on scene load would get displaced when entering from one room and not from another

steady comet Aug 13, 2021, 3:54 PM

#

It's unlikely this is the reason, but are either of the scenes you're coming from boss scenes?

primal latch Aug 13, 2021, 3:54 PM

#

no. The scene that displaces it is Ruins2_03B

steady comet Aug 13, 2021, 3:55 PM

#

What is the scene that doesn't displace it?

primal latch Aug 13, 2021, 3:55 PM

#

Ruins1_18

steady comet Aug 13, 2021, 3:55 PM

#

Uhh

#

So which is the scene you're trying to spawn the enemy in? Because IIRC those two are connected

primal latch Aug 13, 2021, 3:56 PM

#

Ruins2_01

steady comet Aug 13, 2021, 3:57 PM

#

Oh I'm dumb, you're coming from the bench and not from the walkway

#

Uhh

#

Well it's not totally impossible that this would be the reason, because Ruins2_03b was split off from Ruins2_03

primal latch Aug 13, 2021, 3:58 PM

#

how would that affect it?

steady comet Aug 13, 2021, 3:58 PM

#

You could try coming to Ruins2_01 from other scenes via dreamgate/benchwarp/doorwarp and seeing if you can spot the pattern

steady comet Aug 13, 2021, 4:00 PM

#

primal latch how would that affect it?

Well, there's been an issue in rando where certain scene changes (made through the ...activeSceneChanged hook) fail to work if the previous scene was a boss scene, so that's why I suggested it

primal latch Aug 13, 2021, 4:00 PM

#

steady comet Well, there's been an issue in rando where certain scene changes (made through t...

ah

primal latch Aug 13, 2021, 4:00 PM

#

steady comet You could try coming to Ruins2_01 from other scenes via dreamgate/benchwarp/door...

using a dreamgate doesn't displace the enemy

steady comet Aug 13, 2021, 4:01 PM

#

dreamgate from Ruins2_03, so it's definitely when you're coming in through the top transition that breaks it?

primal latch Aug 13, 2021, 4:02 PM

#

Just tried that. It's definitely the transition

steady comet Aug 13, 2021, 4:03 PM

#

Huh

#

I can't think of anything then :S

primal latch Aug 13, 2021, 4:04 PM

#

Me neither

floral blade Aug 13, 2021, 5:03 PM

#

what does a game object need to damage player but not send them to hazard respawn ?

rough pulsar Aug 13, 2021, 5:03 PM

#

DamageHero normal...?

floral blade Aug 13, 2021, 5:04 PM

#

so just a collider and damageHero ?

rough pulsar Aug 13, 2021, 5:04 PM

#

yeah?

floral blade Aug 13, 2021, 5:04 PM

#

okay will try that

worn eagle Aug 13, 2021, 5:04 PM

#

layer 11

rough pulsar Aug 13, 2021, 5:05 PM

#

@floral blade

#

11

floral blade Aug 13, 2021, 5:05 PM

#

gotcha, thanks!

rough pulsar Aug 13, 2021, 5:06 PM

#

thanks 🇮🇹

jolly oriole Aug 13, 2021, 5:07 PM

#

22 also works, should be enemy attack afaik

charred topaz Aug 13, 2021, 5:46 PM

#

My mods should be all set for release whenever. I also have a new video setup for the new feature to IKG too.

#

Also, is the modlinks format the same still (A zip with the mod and readme?)

rough pulsar Aug 13, 2021, 5:47 PM

#

Yeah it should be

#

It is

charred topaz Aug 13, 2021, 5:48 PM

#

ok cool

cedar hemlock Aug 13, 2021, 5:50 PM

#

and other files

#

if you want dll's or other files not to be loaded add it into a subfolder of the zip

#

then the api has no trouble with it

rough pulsar Aug 13, 2021, 5:51 PM

#

While i was messing around with mi's source code

#

I realized you can "recommend" other mods within your mod

cedar hemlock Aug 13, 2021, 5:52 PM

#

?

rough pulsar Aug 13, 2021, 5:52 PM

#

Via Optional tag

#

You can choose whether you wanna install it or not with the mod

cedar hemlock Aug 13, 2021, 5:53 PM

#

interesting

rough pulsar Aug 13, 2021, 5:53 PM

#

Only two mods added it

#

Redwing mod as well

jolly oriole Aug 13, 2021, 5:53 PM

#

oh, old modlinks

cedar hemlock Aug 13, 2021, 5:54 PM

#

charred topaz Also, is the modlinks format the same still (A zip with the mod and readme?)

https://github.com/hk-modding/modlinks don't forget to pr to these not the old one

rough pulsar Aug 13, 2021, 5:54 PM

#

Wait what? There is a new modlinks page??

cedar hemlock Aug 13, 2021, 5:54 PM

#

ye

#

for the 1.5 installer

charred topaz Aug 13, 2021, 5:55 PM

#

cedar hemlock <https://github.com/hk-modding/modlinks> don't forget to pr to these not the old...

ok, will do that later. Might also release the mod videos on my yt too, but that's bound to create a demand for the mods

cedar hemlock Aug 13, 2021, 5:55 PM

#

ye better wait for MIwhatever to be released

#

also, grenade you call it MI2.5 but your github says MI3.0 which one is it??

jolly oriole Aug 13, 2021, 5:56 PM

#

56's mi2.5

cedar hemlock Aug 13, 2021, 5:57 PM

#

and MI3.0?

rough pulsar Aug 13, 2021, 5:57 PM

#

MI(2.5+3.0)/2

#

Save settings should accept something like List<int> right?

cedar hemlock Aug 13, 2021, 6:05 PM

#

ye

#

well

#

i tried it

rough pulsar Aug 13, 2021, 6:05 PM

#

did it work?

cedar hemlock Aug 13, 2021, 6:05 PM

#

i can find it in the globalsettings file

#

but when i change it nothing actually changes

#

though that might be a problem with my code

cedar hemlock Aug 13, 2021, 6:26 PM

#

probably a problem with my code*

floral blade Aug 13, 2021, 6:53 PM

#

how do i make to colliders like collide and not just pass through each other if both are enemies ?

#

do i have to detect it in code with a trigger and push?

rough pulsar Aug 13, 2021, 6:54 PM

#

tamershrug

light zodiac Aug 13, 2021, 7:02 PM

#

MAPI suggestion: dont yeet toggled off mods from the top left list but instead, change/append its "version" text to "DISABLED"

rough pulsar Aug 13, 2021, 7:04 PM

#

Is there any way to communicate with a mod without directly using it as a dependency?

steady comet Aug 13, 2021, 7:05 PM

#

rough pulsar Is there any way to communicate with a mod without directly using it as a depend...

Benchwarp lets you do that by doing something like this
https://github.com/homothetyhk/HollowKnight.BenchwarpMod/blob/master/Source/Events.cs#L42

#

If you have control over both mods then you can do something like that

light zodiac Aug 13, 2021, 7:08 PM

#

What's wrong with adding as dependancy

floral blade Aug 13, 2021, 7:17 PM

#

rough pulsar Is there any way to communicate with a mod without directly using it as a depend...

you can add it as an optional dependency

steady comet Aug 13, 2021, 7:19 PM

#

If you're adding to modlinks is the sha256 of the zip or the dll?

jolly oriole Aug 13, 2021, 7:20 PM

#

new modlinks: zip

steady comet Aug 13, 2021, 7:20 PM

#

K

#

Well, I made my PR https://github.com/hk-modding/modlinks/pull/9

#

~~not that anyone will be using it for a million years~~

crude wave Aug 13, 2021, 7:33 PM

#

When are you going to release the new "Mod Installer" compatible with version 1.5 ??

steady comet Aug 13, 2021, 7:37 PM

#

crude wave When are you going to release the new "Mod Installer" compatible with version 1....

Probably not until after all the mod developers have moved their mods over to 1.5, which won't happen for a few weeks or months

elfin thorn Aug 13, 2021, 7:37 PM

#

So well

#

#

#

Im between this two

#

First one looks more like the original

steady comet Aug 13, 2021, 7:38 PM

#

crude wave When are you going to release the new "Mod Installer" compatible with version 1....

But this really isn't a question for here, go ask in #modding-discussion

elfin thorn Aug 13, 2021, 7:38 PM

#

Second one maintains the knight essence

radiant basin Aug 13, 2021, 7:38 PM

#

i like the first one

jolly oriole Aug 13, 2021, 7:40 PM

#

flib, check your PR

elfin thorn Aug 13, 2021, 7:40 PM

#

Making a skin is so much work lol

radiant basin Aug 13, 2021, 7:43 PM

#

yep good luck

steady comet Aug 13, 2021, 7:46 PM

#

jolly oriole flib, check your PR

OK, hopefully it works now, thanks

jolly oriole Aug 13, 2021, 7:47 PM

#

it does

steady comet Aug 13, 2021, 7:49 PM

#

shroompog

cedar hemlock Aug 13, 2021, 7:49 PM

#

ah but if i need to put a value there that it can find it in my mod, where do i define said value?

#

probably in the CSProj, but what do i call it

jolly oriole Aug 13, 2021, 7:50 PM

#

any value, just don't let it be lower than the last release

cedar hemlock Aug 13, 2021, 7:50 PM

#

ah ok

#

makes sense i was being dumb

jolly oriole Aug 13, 2021, 7:50 PM

#

but in the actual mod, it's dependend on wether you use old or new csproj

#

old: in assemblyinfo.cs
new: in the csproj itself

cedar hemlock Aug 13, 2021, 7:50 PM

#

idk probably old

#

the mod itself is pretty old

#

idk if vs updates it

steady comet Aug 13, 2021, 7:51 PM

#

But can't you simply put it in override string GetVersion()?

jolly oriole Aug 13, 2021, 7:52 PM

#

yea

#

but you can have the difference of modlinks version, actuall dll version (dll file version as well if we want to be specific) and version shown in game

cedar hemlock Aug 13, 2021, 7:53 PM

#

[assembly: AssemblyVersion("1.1.0.0")]
[assembly: AssemblyFileVersion("1.1.0.0")]
```which one?

jolly oriole Aug 13, 2021, 7:56 PM

#

both

cedar hemlock Aug 13, 2021, 7:56 PM

#

k

#

what are .pdb files for?

#

i just added them cus other mods have them, but are they needed?

jolly oriole Aug 13, 2021, 8:01 PM

#

to see line numbers on exceptions

steady comet Aug 13, 2021, 8:04 PM

#

So with the pdb included modlinks will get better error messages?

floral blade Aug 13, 2021, 8:05 PM

#

wait 1.5 unity supports pdb files and not just mdb files ?

cedar hemlock Aug 13, 2021, 8:07 PM

#

https://github.com/hk-modding/modlinks/pull/10 woop

#

hopefully version number should actually work now

rough pulsar Aug 13, 2021, 8:19 PM

#

i'm gonna try if putting pdb in mods folder works

#

90% chance that modding api'll just crash