#archived-modding-development | Hollow Knight | Page 514

stone elm Apr 20, 2021, 3:08 PM

#

Well, yes it will. That's what it says it'll do.

#

It just isn't clear, from what you're saying, what you're trying to do.

dark wigeon Apr 20, 2021, 3:08 PM

#

do you mean changing one item in the list after it has been initialized? gotCharms[1] don't new List every time you want to change one item

cedar hemlock Apr 20, 2021, 3:09 PM

#

i just want 1 of the items to change from true to false without touching the first 3rd or 4th one

stone elm Apr 20, 2021, 3:09 PM

#

During initialization or after? That's the part that's confusing here, bub.

dark wigeon Apr 20, 2021, 3:09 PM

#

public List<bool> gotCharms = new List<bool>() { true, true, true, true };
//later
gotCharms[1] = false;

no?

stone elm Apr 20, 2021, 3:10 PM

#

If during, do what I said. If after, do what nes said.

cedar hemlock Apr 20, 2021, 3:10 PM

#

dark wigeon do you mean changing one item in the list after it has been initialized? `gotCha...

bool gotCharms[1] = true gives me 3 errors

dark wigeon Apr 20, 2021, 3:10 PM

#

it seems to me you wanted to do this: (don't do this)

public List<bool> gotCharms = new List<bool>() { true, true, true, true };
public List<bool> gotCharms = new List<bool>() { true, false, true, true };

dark wigeon Apr 20, 2021, 3:10 PM

#

cedar hemlock `bool gotCharms[1] = true` gives me 3 errors

don't put bool you already defined the list

stone elm Apr 20, 2021, 3:10 PM

#

You don't need bool in there. Just a statement like gotCharms[1] = false.

cedar hemlock Apr 20, 2021, 3:11 PM

#

gotCharms doesn't exist (in current context)

#

i did

public List<bool> gotCharms = new List<bool>() { true, true, true, true };
...
//later
gotCharms[1] = false

dark wigeon Apr 20, 2021, 3:13 PM

#

can you post the code that has both of those lines (like including where they are like in methods or classes)

#

I don't know in what places you put these two lines

cedar hemlock Apr 20, 2021, 3:15 PM

#

public class CHESaveSettings : ModSettings
    {
        
        ///public bool charm1new = true;
        // Better charms, insert default values here
        public List<bool> gotCharms = new List<bool>() { true, true, true, true };
        public List<bool> newCharms = new List<bool>() { false, false, false, false };
        public List<bool> equippedCharms = new List<bool>() { false, false, false, false };
        public List<int> charmCosts = new List<int>() { 4, 2, 1, 1 };
    }
...
public override void Initialize()
        {
            ModHooks.Instance.AfterSavegameLoadHook += initSaveSettings;
      }
...
private void initSaveSettings(SaveGameData data)
        {
            // Charms
            Settings.gotCharms = Settings.gotCharms;
            Settings.newCharms = Settings.newCharms;
            Settings.equippedCharms = Settings.equippedCharms;
            Settings.charmCosts = Settings.charmCosts;
            gotCharms[1] = false;
        }

#

i dont understand much of the code already there :(

vocal spire Apr 20, 2021, 3:16 PM

#

settings.gotCharms

#

Also I suggest reading this https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/

C# Programming Guide

Use these resources for detailed information on key C# language features and features accessible to C# through .NET.

cedar hemlock Apr 20, 2021, 3:16 PM

#

thx

#

i'll look at it

stone elm Apr 20, 2021, 3:16 PM

#

You're referring to a variable in the Settings object, so it makes sense you need to reference the object in order to access the variable.

#

Also, the first four lines of initSaveSettings do literally nothing.

cedar hemlock Apr 20, 2021, 3:17 PM

#

so, Settings.gotCharms[1] = false;?

stone elm Apr 20, 2021, 3:17 PM

#

^ yes

cedar hemlock Apr 20, 2021, 3:17 PM

#

it seems to work

vocal spire Apr 20, 2021, 3:17 PM

#

stone elm Also, the first four lines of `initSaveSettings` do literally nothing.

Got that from grenade I think

cedar hemlock Apr 20, 2021, 3:17 PM

#

stone elm Also, the first four lines of `initSaveSettings` do literally nothing.

SFG's code lol

stone elm Apr 20, 2021, 3:18 PM

#

Well okie-dokie then ¯_(ツ)_/¯

jolly oriole Apr 20, 2021, 3:32 PM

#

stone elm Also, the first four lines of `initSaveSettings` do literally nothing.

i copied that from back when it wasn't a single thing, but a property that built on savesetting.getX/setX

cedar hemlock Apr 20, 2021, 3:33 PM

#

hmm i only turned it true here:

private void uumuu()
        {

            if (PlayerData.instance.GetBool(nameof(PlayerData.killedMegaJellyfish)) == true && uuwuugone == false)
            {
                Settings.gotCharms[1] = true;
                uuwuugone = true;
                Log("uumuugone? " + uuwuugone + ".");
            }
        }
``` but for some reason when i start a save its already there

#

though it should only be gotten when uumuu is killed

#

i made sure the code to detect uumuu is dead works

jolly oriole Apr 20, 2021, 3:34 PM

#

in theory yes, but it will break once you save+exit 100%

deep wave Apr 20, 2021, 3:35 PM

#

is uuwuugone a field of the mod

#

because if so then it will not reset between saves

#

can only reset on being loaded for the first time

#

sfg i saw that

jolly oriole Apr 20, 2021, 3:35 PM

#

no

cedar hemlock Apr 20, 2021, 3:36 PM

#

but still i should not have it at the start of a save right?

jolly oriole Apr 20, 2021, 3:36 PM

#

depends on how the flag is initialized

deep wave Apr 20, 2021, 3:37 PM

#

if you have loaded any other save with uumuu killed on that game launch then it will definitely still be true

jolly oriole Apr 20, 2021, 3:37 PM

#

but if you are a normal human being, yes, it should not have it at the start

cedar hemlock Apr 20, 2021, 3:37 PM

#

deep wave if you have loaded any other save with uumuu killed on that game launch then it ...

i haven't

deep wave Apr 20, 2021, 3:37 PM

#

don't store stuff like that in fields in the mod, use SaveSettings

#

https://radiance.host/apidocs/ModdingAPI.html#saving-data

cedar hemlock Apr 20, 2021, 3:38 PM

#

but why do i have it at the start of a new save?

deep wave Apr 20, 2021, 3:38 PM

#

idk, how are you initialising the flag

cedar hemlock Apr 20, 2021, 3:40 PM

#

public class CHESaveSettings : ModSettings
    {
        
        ///public bool charm1new = true;
        // Better charms, insert default values here
        public List<bool> gotCharms = new List<bool>() { true, false, true, true };
        public List<bool> newCharms = new List<bool>() { false, false, false, false };
        public List<bool> equippedCharms = new List<bool>() { false, false, false, false };
        public List<int> charmCosts = new List<int>() { 4, 2, 1, 1 };
    }
...
public override void Initialize()
        {
            Settings.gotCharms[1] = false;
        }

...
private void initSaveSettings(SaveGameData data)
        {
            // Charms
            Settings.gotCharms = Settings.gotCharms;
            Settings.newCharms = Settings.newCharms;
            Settings.equippedCharms = Settings.equippedCharms;
            Settings.charmCosts = Settings.charmCosts;
        }

...
private void uumuu()
        {

            if (PlayerData.instance.GetBool(nameof(PlayerData.killedMegaJellyfish)) == true && uuwuugone == false)
            {
                Settings.gotCharms[1] = true;
                uuwuugone = true;
                Log("uumuugone? " + uuwuugone + ".");
            }
        }
```this is all i have about the gotCharms

jolly oriole Apr 20, 2021, 3:41 PM

#

the only thing missing is the declaration of uuwuugone

#

because the charm stuff probably works

cedar hemlock Apr 20, 2021, 3:42 PM

#

public class CharmHelperExample : Mod<CHESaveSettings, CHEGlobalSettings>
    {
        bool uuwuugone = false;
    }

...
(in initialize)
if (uuwuugone == false)
            {
                ModHooks.Instance.HeroUpdateHook += uumuu;
            }
            if (uuwuugone == true)
            {
                ModHooks.Instance.HeroUpdateHook -= uumuu;
                uuwuugone = true;
            }

...
private void uumuu()
        {

            if (PlayerData.instance.GetBool(nameof(PlayerData.killedMegaJellyfish)) == true && uuwuugone == false)
            {
                Settings.gotCharms[1] = true;
                uuwuugone = true;
                Log("uumuugone? " + uuwuugone + ".");
            }
        }

#

this?

#

the uumuu shit should work

#

yeah it works

deep wave Apr 20, 2021, 3:44 PM

#

why does it look like CharmHelperExample closes immediately after you declare uuwuugone

cedar hemlock Apr 20, 2021, 3:44 PM

#

it may not be very efficient

cedar hemlock Apr 20, 2021, 3:45 PM

#

deep wave why does it look like CharmHelperExample closes immediately after you declare uu...

hmm yeah it doesn't

#

but it may not be smart to send the whole class here

#

if you want i ofc can

jolly oriole Apr 20, 2021, 3:47 PM

#

idk how much work it would be, but you could try reconstructing it

No if in initialize (as uuwuugone will definetly be false)
Hook into modhooks setbool (call InternalBoolSet, and if the target string is "killedMegaJellyfish" [i'm not sure about the name], set Settings.gotCharms[1] = true)

#

should be way better for the computing side

deep wave Apr 20, 2021, 3:49 PM

#

this

#

don't read the bool on every frame, just see when the bool is set and set yours at that point

cedar hemlock Apr 20, 2021, 3:50 PM

#

but will my version break the gotCharm or smth?

deep wave Apr 20, 2021, 3:50 PM

#

not sure but you may also have to hook game load? don't think loading the game triggers setplayerbool

jolly oriole Apr 20, 2021, 3:50 PM

#

holy shit i was pepega with the setbool thing, doesn't return anything

jolly oriole Apr 20, 2021, 3:50 PM

#

deep wave not sure but you may also have to hook game load? don't think loading the game t...

save gets loaded, overrides savesettings

deep wave Apr 20, 2021, 3:51 PM

#

no you just call InternalBoolSet if the target bool isn't "killedMegaJellyfish"

#

just do a

private void SetPlayerBool(string target, bool val) {
  switch (target)
  {
    case "killedMegaJellyFish":
      uuwuugone = value;
      // Do not break here, continue to default:
    default:
      InternalBoolSet(target, val)
  }
}

steady comet Apr 20, 2021, 3:54 PM

#

SetBoolInternal?

deep wave Apr 20, 2021, 3:54 PM

#

yeah that one

#

im not reading docs im just vibing rn

steady comet Apr 20, 2021, 3:54 PM

#

I can't remember if the docs are wrong

deep wave Apr 20, 2021, 3:55 PM

#

whichever one of those is in Modding zote

cedar hemlock Apr 20, 2021, 3:55 PM

#

i just wanna know, what part of my code breaks it (so i know what i did wrong)

jolly oriole Apr 20, 2021, 3:55 PM

#

yes

cedar hemlock Apr 20, 2021, 3:58 PM

#

so, no idea?

deep wave Apr 20, 2021, 3:58 PM

#

i mean i don't know your code

#

you can add more logging and see exactly where it breaks

floral furnace Apr 20, 2021, 5:05 PM

#

if the script just stops working its probably throwing an exception

light zodiac Apr 20, 2021, 5:42 PM

#

cedar hemlock ```cs public class CharmHelperExample : Mod<CHESaveSettings, CHEGlobalSettings> ...

putting if statements in public override void Initialize doesnt work iirc

jolly oriole Apr 20, 2021, 5:58 PM

#

it does work it's just useless

copper nacelle Apr 20, 2021, 6:00 PM

#

uh huh

deep wave Apr 20, 2021, 6:17 PM

#

i mean init is called immediately after the field is initialised with value false zote

copper nacelle Apr 20, 2021, 6:19 PM

#

these is a large difference between the statements "called after field initialization" and "if statements don't work"

deep wave Apr 20, 2021, 6:24 PM

#

i agree

vocal spire Apr 20, 2021, 7:03 PM

#

I wanted to point that out but thought someone else had them fix it

jolly jungle Apr 20, 2021, 8:17 PM

#

What type are fsm variables?

#

Not their values

#

The variables themselves

#

As in, what would be the type of the thing marked here

jolly oriole Apr 20, 2021, 8:19 PM

#

FsmFloat i think

deep wave Apr 20, 2021, 8:20 PM

#

https://hutonggames.fogbugz.com/default.asp?W1103

jolly jungle Apr 20, 2021, 8:21 PM

#

Thanks, both of you

steady comet Apr 20, 2021, 10:43 PM

#

Why are there so many acid detectors in the collector's room? (Ruins2_11)

jolly oriole Apr 21, 2021, 6:04 AM

#

steady comet Why are there so many acid detectors in the collector's room? (Ruins2_11)

every single jar that falls from the ceiling during the fight has one such detector

jolly jungle Apr 21, 2021, 6:17 AM

#

w
why

copper nacelle Apr 21, 2021, 6:17 AM

#

to detect acid

jolly oriole Apr 21, 2021, 6:17 AM

#

i don't even know if they are used, haven't checked that

jolly oriole Apr 21, 2021, 6:18 AM

#

jolly oriole every single jar that falls from the ceiling during the fight has one such detec...

because i was wrong, those are not the jars that fall, but only jar pieces from idk where

steady comet Apr 21, 2021, 6:21 AM

#

Hmm, maybe they just copied and pasted from jars in rooms with acid? It's still kinda funny

jolly jungle Apr 21, 2021, 8:19 AM

#

jolly oriole because i was wrong, those are not the jars that fall, but only jar pieces from ...

this doesn't make it any clearer

jolly oriole Apr 21, 2021, 8:21 AM

#

copper nacelle to detect acid

.

nimble lake Apr 21, 2021, 9:34 AM

#

modders

astral hull Apr 21, 2021, 10:30 AM

#

slightly off topic but how does someone start getting into modding a game from scratch

#

like how did hollow knight mods start out

cedar hemlock Apr 21, 2021, 10:31 AM

#

https://radiance.host/apidocs

astral hull Apr 21, 2021, 10:32 AM

#

ty

cedar hemlock Apr 21, 2021, 11:41 AM

#

astral hull slightly off topic but how does someone start getting into modding a game from s...

not at all off topic btw

#

[ERROR]:[UNITY] - NullReferenceException: Object reference not set to an instance of an object
[ERROR]:[UNITY] - ActionButtonIconBase.GetButtonIcon (HeroActionButton actionButton)
[ERROR]:[UNITY] - ActionButtonIconBase.RefreshButtonIcon ()
[ERROR]:[UNITY] - ActionButtonIconBase.OnEnable ()
[ERROR]:[UNITY] - ActionButtonIcon.OnEnable ()
[ERROR]:[UNITY] - UnityEngine.GameObject:SetActive(Boolean)
[ERROR]:[UNITY] - GameCameras:StartScene()
[ERROR]:[UNITY] - GameCameras:SceneInit()
[ERROR]:[UNITY] - GameManager:BeginScene()
[ERROR]:[UNITY] - <BeginSceneTransitionRoutine>c__AnonStorey13:<>m__3()
[ERROR]:[UNITY] - <BeginRoutine>c__Iterator0:MoveNext()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ERROR]:[UNITY] - 
```what is this

deep wave Apr 21, 2021, 11:46 AM

#

an nre

copper nacelle Apr 21, 2021, 11:46 AM

#

a null reference

#

so true jamie

deep wave Apr 21, 2021, 11:47 AM

#

ikr we're so helpful

jolly oriole Apr 21, 2021, 11:47 AM

#

buttons crashed

cedar hemlock Apr 21, 2021, 11:47 AM

#

it says something about button but i have nothing in my mod that has to do with a button

jolly oriole Apr 21, 2021, 11:48 AM

#

maybe you crashed initialize so hard that other stuff crashed

cedar hemlock Apr 21, 2021, 11:48 AM

#

it happens when i open inv, and i try to go up to the charms that are equiped

jolly oriole Apr 21, 2021, 11:48 AM

#

or the set/getbool stuff

deep wave Apr 21, 2021, 11:48 AM

#

cedar hemlock it says something about button but i have nothing in my mod that has to do with ...

aren't you adding charms, which would have buttons to equip them?

cedar hemlock Apr 21, 2021, 11:49 AM

#

cedar hemlock it happens when i open inv, and i try to go up to the charms that are equiped

on that moment i lose all control of the inventory and con only leave it

cedar hemlock Apr 21, 2021, 11:49 AM

#

deep wave aren't you adding charms, which would have buttons to equip them?

hmm maybe

deep wave Apr 21, 2021, 11:50 AM

#

could be that whatever you're doing on charm update is crashing or something

cedar hemlock Apr 21, 2021, 11:51 AM

#

i can see if it still does it when i remove the charm part

jolly oriole Apr 21, 2021, 11:51 AM

#

cedar hemlock ```cs [ERROR]:[UNITY] - NullReferenceException: Object reference not set to an i...

considering it crashes at GetButtonIcon, are your sprites present?

cedar hemlock Apr 21, 2021, 11:51 AM

#

jolly oriole considering it crashes at `GetButtonIcon`, are your sprites present?

yes?

deep wave Apr 21, 2021, 11:51 AM

#

that sounds confident

cedar hemlock Apr 21, 2021, 11:52 AM

#

lol

#

i forgot a _

#

lets try again

#

ok it works, thx!

vocal spire Apr 21, 2021, 12:10 PM

#

cedar hemlock yes?

very confident

jolly oriole Apr 21, 2021, 12:10 PM

#

update: the typereference does work (only 1 stage up though, so basically useless as well), but the resolved typedefinition is null (because the type doesn't exist without the assembly loaded)

jolly oriole Apr 21, 2021, 12:37 PM

#

this should not have worked (testing changes for the 1.5 mapi)

vocal spire Apr 21, 2021, 2:54 PM

#

Nice

#

“Severely break the entire game”

primal latch Apr 21, 2021, 3:55 PM

#

@jolly oriole @copper nacelle just wondering: how severely will 1.5 break mods?

copper nacelle Apr 21, 2021, 3:55 PM

#

depends on what you mean by break

primal latch Apr 21, 2021, 3:56 PM

#

Will most mods still work or will they all have to be updated?

deep wave Apr 21, 2021, 3:57 PM

#

i assume all mods will need to be recompiled targeting 4.7.2 at the very least?

jolly oriole Apr 21, 2021, 4:00 PM

#

4.0

copper nacelle Apr 21, 2021, 4:05 PM

#

should be doing netstandard

jolly oriole Apr 21, 2021, 4:06 PM

#

oh yea, netstandard 2 was it sadly

copper nacelle Apr 21, 2021, 4:06 PM

#

mfw sadly

jolly oriole Apr 21, 2021, 4:07 PM

#

4.x would've been way better

copper nacelle Apr 21, 2021, 4:08 PM

#

what

#

this is untrue

#

net standard is newer and more standardized

jolly oriole Apr 21, 2021, 4:11 PM

#

but i wouldn't have had to make a custom json.net

#

or does the netstandard one work?

copper nacelle Apr 21, 2021, 4:14 PM

#

the issue is unrelated to net standard itself, just a unity change

jolly oriole Apr 21, 2021, 4:14 PM

#

copper nacelle should be doing netstandard

btw, why is the mapi framework 472 if the game is netstandard?

copper nacelle Apr 21, 2021, 4:14 PM

#

i have an unpushed change already

jolly oriole Apr 21, 2021, 4:15 PM

#

copper nacelle the issue is unrelated to net standard itself, just a unity change

sadge

copper nacelle Apr 21, 2021, 4:15 PM

#

I realized it was the tech after someone had issues building the api

#

because the standard mscorlib wasn't being ref'd by dotnet build for some reason

#

but really we should've been using netstandard anyways

#

and that worked

#

https://docs.microsoft.com/en-us/visualstudio/gamedev/unity/unity-scripting-upgrade rofl

Using .NET 4.x in Unity

Understand how to use .NET 4.x in Unity. Enable the .NET 4.x scripting runtime. Take advantage of .NET compatibility. Review new syntax and language features.

#

their example is newtonsoft

#

wtf we have async now

jolly oriole Apr 21, 2021, 4:29 PM

#

just out of curiosity: why does the api even sort the assemblies by library & mod?

#

it's not like anybody would try to execute code when the library is loaded

copper nacelle Apr 21, 2021, 4:30 PM

#

idk ask serena

#

probably some good reaosn

#

i think you can specify assembly load order in the attribute but i might be remembering wrong

#

Oh yeah

📎 Resources.zip

#

This is what you can load with Resources.Load

#

there's some shaders and materials

#

not much else

#

some language data ig

jolly oriole Apr 21, 2021, 4:32 PM

#

jolly oriole just out of curiosity: why does the api even sort the assemblies by library & mo...

@rain cedar

copper nacelle Apr 21, 2021, 4:33 PM

#

Oh yeah and something of note

#

Resources.FindObjectsOfType finds more than what's in resources

#

for some reason

#

so you can avoid some preloading with it

#

LoadAll fills it up a bunch though

#

despite it only loading garbage from resources

jolly oriole Apr 21, 2021, 4:35 PM

#

copper nacelle Resources.FindObjectsOfType finds more than what's in resources

That's from https://docs.unity3d.com/2017.4/Documentation/ScriptReference/Object.FindObjectsOfType.html

copper nacelle Apr 21, 2021, 4:35 PM

#

*FindObjectsOfTypeAll

jolly oriole Apr 21, 2021, 4:35 PM

#

then yes

#

returns everything that is loaded according to the docs

copper nacelle Apr 21, 2021, 4:36 PM

#

chad

jolly oriole Apr 21, 2021, 4:37 PM

#

that's also the only way to get all monobehaviours in a scene when some are deactivated (though it does also get more than just the ones in the scene)

#

in unity 2017*

jolly oriole Apr 21, 2021, 5:49 PM

#

i think it's possible to resolve assemblies into a loadorder

jolly oriole Apr 21, 2021, 6:14 PM

#

my code for that:

foreach (string modPath in Directory.GetFiles(path, "*.dll"))
{
    using AssemblyDefinition asmDef = AssemblyDefinition.ReadAssembly(modPath);
    Logger.Log($"MainModule: '{asmDef.MainModule}'");
    Logger.Log($"\t\tAssemblyReferences:");
    foreach (var item in asmDef.MainModule.AssemblyReferences)
    {
        Logger.Log($"\t\t\tName: '{item.Name}'");
        Logger.Log($"\t\t\tFullName: '{item.FullName}'");
    }
    Logger.Log("");
}

stone elm Apr 21, 2021, 6:31 PM

#

IDK what you're trying to do, but afaik unless you define your own load context and manually load assemblies into it in a specific order then guaranteeing a load order is difficult

jolly oriole Apr 21, 2021, 6:32 PM

#

the modding api already loads assemblies manually

stone elm Apr 21, 2021, 6:32 PM

#

Correct, but that isn't the same as a full load-order control for all assemblies.

#

Dependencies get auto-loaded, down the tree

jolly oriole Apr 21, 2021, 6:34 PM

#

ok yea, maybe not for loadorder, but type resolving instead, as mono.cecil doesn't resolve basetypes in another assembly.
so, when tot.dll's main class inherits sfcore.dll's generic mod class.

stone elm Apr 21, 2021, 6:35 PM

#

Yeah, you can mess with type resolution a little more easily

copper nacelle Apr 21, 2021, 7:38 PM

#

i changed my mind don't do standard

#

it is a pain and if you use 2.1 it breaks

jolly oriole Apr 21, 2021, 7:39 PM

#

so framework 472?

#

or 4.0?

stone elm Apr 21, 2021, 7:39 PM

#

Most libs that support .netstandard 2.0 will support framework 4.7.2 (like newtonsoft and what-not). Otherwise you might end up with limited APIs due to standard2.0

#

4.7.2 works

copper nacelle Apr 21, 2021, 7:39 PM

#

yeah 472

fickle sparrow Apr 21, 2021, 7:49 PM

#

ax1uWide3

copper nacelle Apr 21, 2021, 8:24 PM

#

@jolly oriole did you ever try this https://github.com/jilleJr/Newtonsoft.Json-for-Unity

GitHub

jilleJr/Newtonsoft.Json-for-Unity

Newtonsoft.Json (Json.NET) 10.0.3, 11.0.2, 12.0.3, & 13.0.1 for Unity IL2CPP builds, available via Unity Package Manager - jilleJr/Newtonsoft.Json-for-Unity

jolly oriole Apr 21, 2021, 8:25 PM

#

of course not

copper nacelle Apr 21, 2021, 8:25 PM

#

it's for il2cpp so it shouldn't depend on enit

jolly oriole Apr 21, 2021, 8:26 PM

#

it's a unity package

copper nacelle Apr 21, 2021, 8:27 PM

#

ok and

jolly oriole Apr 21, 2021, 8:27 PM

#

it's not directly a dll i can download and infect my pc with

copper nacelle Apr 21, 2021, 8:28 PM

#

fair

#

I just install and take the dll out

jolly oriole Apr 21, 2021, 8:28 PM

#

are unitypackages for specific unity versions or can i just plonk it in any version?

#

apparently it just works

copper nacelle Apr 21, 2021, 8:29 PM

#

nice

#

It comes with unity converters too

jolly oriole Apr 21, 2021, 8:30 PM

#

nvm i think i downloaded the wrong thing

#

where should i find the newtonsoft dll then?

#

maybe doesn't work with unity 2017

copper nacelle Apr 21, 2021, 8:34 PM

#

I'll try it in a bit

jolly oriole Apr 21, 2021, 8:36 PM

#

yep, apparently requires unity 2018+? testing with 2020

#

... after it decides to finally start

#

works with 2020

#

works ingame

📎 Newtonsoft.Json.dll

vocal spire Apr 21, 2021, 8:44 PM

#

Nice

copper nacelle Apr 21, 2021, 8:44 PM

#

Sick

vocal spire Apr 21, 2021, 8:44 PM

#

ModdingApi using this now?

jolly oriole Apr 21, 2021, 8:45 PM

#

not yet

torn birch Apr 21, 2021, 11:19 PM

#

How do I run an extension for the Debug Mod?

#

I've been writing some code for my project and ended up working with some of the Debug Mod's API, and I want to run the small part I have so far so that I can make sure it works before I move on

vocal spire Apr 21, 2021, 11:58 PM

#

torn birch How do I run an extension for the Debug Mod?

Wdym, how is it currently coded

#

Is there a class inheriting the mod class(or a abstract class inheriting the mod class)

fallen elk Apr 22, 2021, 4:29 AM

#

How big of an undertaking is it to add in a couple charms to the game?

#

I'm interested in making a couple nail related charms

jolly oriole Apr 22, 2021, 6:06 AM

#

copper nacelle it is a pain and if you use 2.1 it breaks

the mapi is netstandard 2.1 though (so ig i'm not updating to that currently)

copper nacelle Apr 22, 2021, 6:17 AM

#

I reverted it idk if I pushed

fickle sparrow Apr 22, 2021, 6:18 AM

#

yeah master is still on 2.1

copper nacelle Apr 22, 2021, 6:18 AM

#

suicide

fickle sparrow Apr 22, 2021, 6:18 AM

#

ax1uWide4

jolly oriole Apr 22, 2021, 6:19 AM

#

copper nacelle I reverted it idk if I pushed

so i'll take a wild guess and say you didn't push

fickle sparrow Apr 22, 2021, 6:19 AM

#

have you considered using netstandard2.1 and simply not miscompiling split

#

ax1uWide3

copper nacelle Apr 22, 2021, 6:20 AM

#

I pushed

jolly oriole Apr 22, 2021, 6:20 AM

#

just saw 👍

vocal spire Apr 22, 2021, 12:44 PM

#

Not much for the adding charms part thanks to sfgrenade. They made a page in the apidocs about charms and other things. I suggest reading the entirety of the api docs https://radiance.host/apidocs/

#

Well reply didn’t work

vocal spire Apr 22, 2021, 12:45 PM

#

fallen elk How big of an undertaking is it to add in a couple charms to the game?

Look at the messages above

copper nacelle Apr 22, 2021, 1:44 PM

#

thoughts on sha256 for 1.5

ornate rivet Apr 22, 2021, 1:46 PM

#

sounds like a good idea

jolly oriole Apr 22, 2021, 2:40 PM

#

sounds good, gives me even more time to make my shit available on 1.5

vocal spire Apr 22, 2021, 2:45 PM

#

copper nacelle thoughts on sha256 for 1.5

For what part?

jolly oriole Apr 22, 2021, 2:46 PM

#

probably to replace the sha1

vocal spire Apr 22, 2021, 2:47 PM

#

where is sha1 used?

#

Haven’t explored that part of the api much(?)

jolly oriole Apr 22, 2021, 2:50 PM

#

the modinstaller

fallen elk Apr 22, 2021, 3:30 PM

#

vocal spire Look at the messages above

Thanks. Hopefully this won't be too hard

#

Is there any way to detect a parry?

copper nacelle Apr 22, 2021, 3:41 PM

#

HeroController::NailParry

fallen elk Apr 22, 2021, 3:42 PM

#

Awesome thanks

#

What is that btw?

#

Is that a function?

#

i'm just starting out

copper nacelle Apr 22, 2021, 3:44 PM

#

yeah

primal latch Apr 22, 2021, 4:39 PM

#

How would I go about replacing the sprites for the circled items?

Hollow_Knight_Screenshot_2021.04.22_-_18.37.56.53.png

vocal spire Apr 22, 2021, 5:25 PM

#

(Solved)

silent marsh Apr 22, 2021, 6:15 PM

#

Hello,
First of all thanks for all the modding tools, I've been playing with the API for a few days and it's really pleasant to use 🙂
I have a question though: can you add a dependency to something that's not a mod ? If so where would you put the additional dll that your mod needs ? (Sorry if this is a dumb question, I'm used to developing but neither in C# nor on Windows)

deep wave Apr 22, 2021, 6:16 PM

#

you can put misc dlls in the mods folder

#

or use ILmerge to merge them into your mod's dll if you wish

silent marsh Apr 22, 2021, 6:17 PM

#

Really ? I tried and got an error at startup in Hollow Knight. I must have missed something, I'll try again then
Thanks for the ILmerge idea, I didn't know this thing existed

stone elm Apr 22, 2021, 6:17 PM

#

You can put them in the Managed folder and outright avoid the modloader from trying to load them.

#

Don't use ILMerge basically ever unless you're REALLY intent on having a single assembly.

#

I am bias, ILMerge makes me irrationally upset

silent marsh Apr 22, 2021, 6:17 PM

#

I mean, isn't it nicer to have a single DLL to install ? What's the problem with this tool ?

deep wave Apr 22, 2021, 6:17 PM

#

silent marsh Really ? I tried and got an error at startup in Hollow Knight. I must have misse...

the assembly that isn't a mod will "fail to load" because there is no mod, but it still loads

silent marsh Apr 22, 2021, 6:18 PM

#

Oh ok thanks

deep wave Apr 22, 2021, 6:18 PM

#

its just a frustratingly long string at the top of the screen maggotPrime

stone elm Apr 22, 2021, 6:18 PM

#

silent marsh I mean, isn't it nicer to have a single DLL to install ? What's the problem with...

It has benefits and drawbacks. Drawbacks include mangling assembly resolution since you're literally merging the types of another assembly into your own. I suggest against it since including another DLL is not a deal-breaker. (for most, I suppose)

silent marsh Apr 22, 2021, 6:19 PM

#

Makes sense, thanks 🙂

stone elm Apr 22, 2021, 6:20 PM

#

To give an example, something I'm working on references an external DLL. I put this in the Managed folder. That DLL references newtonsoft which is ILMerged into ModdingApi for 1.4. This breaks my mod since I need to reference newtonsoft and NOT the Assembly-CSharp DLL. (I'm now* developing it for 1.5 beta due to this)

silent marsh Apr 22, 2021, 6:21 PM

#

Hmm ok I see

silent marsh Apr 22, 2021, 6:22 PM

#

deep wave its just a frustratingly long string at the top of the screen <:maggotPrime:7384...

If I put the dll in the mods folder I loose all the modding infos at the top left of the screen, that doesn't seem good

stone elm Apr 22, 2021, 6:23 PM

#

What dll does your mod rely on?

silent marsh Apr 22, 2021, 6:24 PM

#

It would rely on the Razer Chroma API (just got a new keyboard and thought it would be fun to light the RGB LEDs according to events in the game), you can find it here for example https://github.com/razerofficial/CSharp_SampleApp

#

Wait I might be dumb

stone elm Apr 22, 2021, 6:27 PM

#

I see, that shouldn't affect the modloader but I'm unsure as to why nothing else appears in the top left. The modding api is clearly running. Do you have any mods for it to show?

silent marsh Apr 22, 2021, 6:27 PM

#

Yes I have a few things usually (Custom Knight, Grass mod, some tests of mine, etc.)

deep wave Apr 22, 2021, 6:28 PM

#

maybe check modlog.txt in case its just modconsole that's crashed?

jolly jungle Apr 22, 2021, 6:28 PM

#

primal latch How would I go about replacing the sprites for the circled items?

Fyremoth palehmm

silent marsh Apr 22, 2021, 6:29 PM

#

deep wave maybe check modlog.txt in case its just modconsole that's crashed?

Good call but it's the same thing in here. But I'm starting to think I didn't get the right DLL (Razer's doc is clearly not as good as radiance.host unfortunately)

stone elm Apr 22, 2021, 6:48 PM

#

Check your unity logs then, there might be an exception in there that doesn't appear in the modlogs

copper nacelle Apr 22, 2021, 6:51 PM

#

there's nothing in modlog?

#

it's usually a type load exception

stone elm Apr 22, 2021, 6:57 PM

#

Considering the razer sdk has native dlls, it could be possible unity shat the bed somehow.

silent marsh Apr 22, 2021, 7:04 PM

#

copper nacelle there's nothing in modlog?

If modlog is the ModLog.txt in my save folder, then it just has

[INFO]:[ModManager] - Initializing
[INFO]:[ModManager] - Initialized
[INFO]:[API] - Loading ModdingApi Global Settings.
[INFO]:[API] - Main menu loading
[INFO]:[API] - Preloaded reflection in 96ms
[INFO]:[API] - Trying to load mods
[INFO]:[API] - Attempting to determine type of mod assemblies (library/mod/addon)
[INFO]:[API] - Saving Global Settings

cedar hemlock Apr 22, 2021, 7:05 PM

#

You ever isntalled DRPC? 👀

silent marsh Apr 22, 2021, 7:05 PM

#

What is this thing ?

cedar hemlock Apr 22, 2021, 7:05 PM

#

Oh just a mod that breaks everything

#

If you never installed it then thats not the problem

silent marsh Apr 22, 2021, 7:06 PM

#

stone elm Check your unity logs then, there might be an exception in there that doesn't ap...

Where are unity logs ? Is it output_log.txt ? I got some errors here but I'm not sure it's the errors I'm looking for

silent marsh Apr 22, 2021, 7:06 PM

#

cedar hemlock Oh just a mod that breaks everything

Good to know

stone elm Apr 22, 2021, 7:06 PM

#

It is output_log

#

You could post it and others can take a look, I suppose.

silent marsh Apr 22, 2021, 7:07 PM

#

Well then I have that, which doesn't look too good

BadImageFormatException: Format of the executable (.exe) or library (.dll) is invalid.
  at Mono.Cecil.PE.ImageReader.ReadOptionalHeaders (System.UInt16& subsystem, System.UInt16& dll_characteristics) [0x00000] in <filename unknown>:0 
  at Mono.Cecil.PE.ImageReader.ReadImage () [0x00000] in <filename unknown>:0 
  at Mono.Cecil.PE.ImageReader.ReadImage (Disposable`1 stream, System.String file_name) [0x00000] in <filename unknown>:0 
  at Mono.Cecil.ModuleDefinition.ReadModule (Disposable`1 stream, System.String fileName, Mono.Cecil.ReaderParameters parameters) [0x00000] in <filename unknown>:0 
  at Mono.Cecil.ModuleDefinition.ReadModule (System.String fileName, Mono.Cecil.ReaderParameters parameters) [0x00000] in <filename unknown>:0 
UnityEngine.MonoBehaviour:StartCoroutine_Auto_Internal(IEnumerator)
UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
OnScreenDebugInfo:Awake()

stone elm Apr 22, 2021, 7:07 PM

#

Yeah, I think, because your modlog is so short, that something in unity is breaking and the modloader dies before it loads any mods

#

There it is

#

That's the native DLL being loaded as an assembly or being loaded on a system of different bitness than it expected

#

.NET has DLLs referred to as assemblies or 'managed code'. These are not the same as native dlls such as those compiled from C/C++/Go/whatever

silent marsh Apr 22, 2021, 7:09 PM

#

Regarding the bitness of the system it should be right if the DLL works with Razer's C# sample app ?

stone elm Apr 22, 2021, 7:09 PM

#

idk, I don't integrate native dlls ¯_(ツ)_/¯

silent marsh Apr 22, 2021, 7:09 PM

#

Wise choice

stone elm Apr 22, 2021, 7:10 PM

#

It could simply be unity trying to load it as an assembly and failing because it might expect native dlls to go into the /plugins folder or something stupid

silent marsh Apr 22, 2021, 7:10 PM

#

Well anyway thanks a lot for your help and your quick answers everyone

primal latch Apr 22, 2021, 7:25 PM

#

jolly jungle Fyremoth <:palehmm:595085708683902986>

I can neither confirm nor deny that

#

But how did you know?

cedar hemlock Apr 22, 2021, 7:28 PM

#

Guess or recent stream

primal latch Apr 22, 2021, 7:28 PM

#

Yeah. I just realised that the name of the cloak was in the shot

cedar hemlock Apr 22, 2021, 7:29 PM

#

The name of ddark

primal latch Apr 22, 2021, 7:29 PM

#

Ah. Yeah.

jolly jungle Apr 22, 2021, 7:35 PM

#

Yep :)

#

And I remembered you were looking for translators for the mod

silent marsh Apr 22, 2021, 7:38 PM

#

(For anyone interested in my Razer DLL problem, everything actually works if I put my DLL in a folder that's accessible in my PATH, but I guess asking the users of a mod to modify their PATH is not really nice)

jolly oriole Apr 22, 2021, 7:43 PM

#

it should be possible to dynamically add that to the path if it isn't already there, but i've never done anything like that

silent marsh Apr 22, 2021, 7:44 PM

#

Yes it should be doable somehow, I'll look into that, thanks

stone elm Apr 22, 2021, 7:45 PM

#

It's possible, but dll resolution in .NET should follow the same principles as assembly resolution iirc. Putting it in the same folder as the EXE should work too

#

You could put it in the mods folder and just let modloader fail to load it, oh well no big deal

silent marsh Apr 22, 2021, 7:45 PM

#

Well yeah but as we saw that crashes Unity

stone elm Apr 22, 2021, 7:45 PM

#

I'd advise against permanently editing a user's PATH unless otherwise specifically noted.

stone elm Apr 22, 2021, 7:46 PM

#

silent marsh Well yeah but as we saw that crashes Unity

In the Managed folder, I thought. My hypothesis was that Unity itself was attempting to load it, not necessarily the modding API

silent marsh Apr 22, 2021, 7:49 PM

#

Sorry if it wasn't clear : putting the DLL in Managed results in [ERROR]:[API] - Error: System.DllNotFoundException: CChromaEditorLibrary in ModLog, and putting it in Managed/Mods results in a crash in output_log (the one I pasted earlier)

stone elm Apr 22, 2021, 7:50 PM

#

That error in the modlog is acceptable, is it somehow blocking your mod from working? If the modding api fails to load a DLL it just moves on

#

And you dont NEED the modding api to load that dll, just your mod specifically to find it

#

I could be misunderstanding what's happening, i suppose

silent marsh Apr 22, 2021, 7:52 PM

#

Well the error is not acceptable because it's triggered when my mod tries to intialize Razer's SDK and it completely crashes

#

I don't get the subsequent logs / keyboard colors that I should get

#

~~It's not triggered by the modding API, it's just triggered by my mod trying to load the DLL~~

#

~~(I think)~~

stone elm Apr 22, 2021, 7:57 PM

#

That may be the deal, sounds possible I suppose. The discord rich presence mod also uses native dlls, for discord's api, I think. I don't remember who made it in order to point you at someone to ask Qs to

#

Someone else here will probably remember though hivetired

cedar hemlock Apr 22, 2021, 7:58 PM

#

Dont download it

silent marsh Apr 22, 2021, 7:58 PM

#

No problem, thanks for all your help. I'll look into temporarily modifying the PATH, that may simply be easier

cedar hemlock Apr 22, 2021, 7:58 PM

#

cedar hemlock You ever isntalled DRPC? 👀

.

silent marsh Apr 22, 2021, 8:03 PM

#

Well, seems like

Environment.SetEnvironmentVariable("PATH", Environment.GetEnvironmentVariable("PATH") + ";hollow_knight_Data\\Managed\\Mods\\MyCoolMod");

simply works

Almost too easy

stone elm Apr 22, 2021, 8:03 PM

#

Yeah, but that's not necessarily temporary

#

And it would be additive unless you check the PATH each time for what you want to be in it

silent marsh Apr 22, 2021, 8:04 PM

#

Well I don't see it in my PATH after closing the game so I'd say that it is temporary

#

silent marsh Apr 22, 2021, 8:05 PM

#

stone elm And it would be additive unless you check the PATH each time for what you want t...

Well yes, it is, but the constructor of my mod is guaranteed to be called exactly once right ?

stone elm Apr 22, 2021, 8:06 PM

#

Is that your user PATH or machine PATH? Did you check both?

stone elm Apr 22, 2021, 8:06 PM

#

silent marsh Well yes, it is, but the constructor of my mod is guaranteed to be called exactl...

Yes, I suppose. Although you should likely put that in Initialize() which I believe is called once

silent marsh Apr 22, 2021, 8:06 PM

#

I put that as early as I could but I guess it makes more sense in Intialize, you're right

silent marsh Apr 22, 2021, 8:08 PM

#

stone elm Is that your user PATH or machine PATH? Did you check both?

I don't see it either in my control panel PATH or in a userland powershell ($env:PATH), is there somewhere else I should check ?

stone elm Apr 22, 2021, 8:08 PM

#

I just checked the SetEnvironmentVariable method docs and it mentions it's for the current process.

#

So you may actually be okay there

silent marsh Apr 22, 2021, 8:09 PM

#

Nice 🙂

#

Thanks 🙂

copper nacelle Apr 22, 2021, 8:09 PM

#

Env variables are always process localized unless you change the defaults

#

Which I assume would be some win32 dllimport shit

silent marsh Apr 22, 2021, 8:10 PM

#

That's what I would have guessed too, but I'm not too familiar with Windows env var (only Linux ones), so thanks for the confirmation

jolly jungle Apr 22, 2021, 8:18 PM

#

Can anyone explain the logistics of this?

jolly oriole Apr 22, 2021, 8:18 PM

#

arrays

jolly jungle Apr 22, 2021, 8:18 PM

#

I may be using the word logistics wrong

#

But yeah

#

If anyone can explain whatever this is meant to do it'll be nice

copper nacelle Apr 22, 2021, 8:19 PM

#

indices correspond

jolly jungle Apr 22, 2021, 8:19 PM

#

Specifically, all the "tracking" stuff

jolly oriole Apr 22, 2021, 8:19 PM

#

event ATTACK has a 40% chance of happenening, but only 2 times max in a row (tracked with 'Attack Count') and can only not happen 3 times max in a row (tracked with 'Ms Attack')

copper nacelle Apr 22, 2021, 8:19 PM

#

eventMax is the max times something can happen in a row iirc?

jolly jungle Apr 22, 2021, 8:20 PM

#

Ah

#

Thanks

#

So it all tracks how many times things happened/ hadn't happened in a row?

jolly oriole Apr 22, 2021, 8:21 PM

#

yes

jolly jungle Apr 22, 2021, 8:22 PM

#

Epic, thanks

jolly oriole Apr 22, 2021, 8:48 PM

#

how can i get the type of a private struct inside a class

copper nacelle Apr 22, 2021, 8:50 PM

#

getnestedtype

jolly oriole Apr 22, 2021, 8:50 PM

#

nvm, i just made my own type for generic stuff

#

maybe works

vocal spire Apr 22, 2021, 8:51 PM

#

https://stackoverflow.com/questions/5323419/can-i-use-privateobject-class-or-reflection-to-access-a-field-in-a-private-class ?

Stack Overflow

Can I use PrivateObject class or Reflection to access a field in a ...

If i have a private class

Class A
{
public static string foo;
}
Can i use reflection to access that static field? Assuming of course i cannot change the code...

The problem i have is that the

copper nacelle Apr 22, 2021, 8:51 PM

#

it's a nested type bro

vocal spire Apr 22, 2021, 8:51 PM

#

Oh

copper nacelle Apr 22, 2021, 8:52 PM

#

you just typeof(Outer).GetNestedType("inner", binding flags that I can't be bothered writing on mobile)

jolly oriole Apr 22, 2021, 8:53 PM

#

is it also possible to get the classtype for casting reasons?

#

casting apparently doesn't work with the selfmade type

#

for specifics: HealthManager.HPScaleGG is a private struct

#

just made custom reflection stuff to directly get the values of normal types inside hpScale

stone elm Apr 22, 2021, 9:03 PM

#

Sorry, what's your Q or did you figure it out?

jolly oriole Apr 22, 2021, 9:04 PM

#

figured it out

#

resulted in a very short line of code

int level2 = (int) typeof(HealthManager).GetNestedType("HPScaleGG", BindingFlags.NonPublic).GetField("level2").GetValue(typeof(HealthManager).GetField("hpScale", BindingFlags.NonPublic | BindingFlags.Instance).GetValue(self));

stone elm Apr 22, 2021, 9:05 PM

#

That's a mouthful

copper nacelle Apr 22, 2021, 9:09 PM

#

yeah you can't cast

#

If you're on 1.5 you can use dynamic for public fields

jolly oriole Apr 22, 2021, 9:09 PM

#

i mean, this works and i only need it twice per enemy spawned

stone elm Apr 22, 2021, 9:10 PM

#

I suggest caching the FieldInfo objects if you're doing this often (in other words: more than once ever)

jolly oriole Apr 22, 2021, 9:10 PM

#

meh

stone elm Apr 22, 2021, 9:11 PM

#

Just to avoid repetitive reflection lookups... Although I think reflection has a cache in .NET I'm not sure

jolly oriole Apr 22, 2021, 9:11 PM

#

the only time it could lag is with bosses that spawn enemies or the colosseum

#

otherwise it's just loading screen

copper nacelle Apr 22, 2021, 9:12 PM

#

No it doesn't have a cache

#

If you don't cache your field lookups you are wrong

#

and you should feel wrong

jolly oriole Apr 22, 2021, 9:14 PM

#

copper nacelle and you should feel wrong

poggy woggy

copper nacelle Apr 22, 2021, 9:16 PM

#

this is a terrible sentence

#

my eyes bleed

steady comet Apr 22, 2021, 9:17 PM

#

Speaking about reflection, is there any difference between

InputHandler input = ReflectionHelper.GetAttr<HeroController, InputHandler>(HeroController.instance, "inputHandler");

and

InputHandler input = GameManager.instance.inputHandler;
``` ?

stone elm Apr 22, 2021, 9:24 PM

#

Where does ReflectionHelper come from?

#

I'll just look at the source to check for you

jolly oriole Apr 22, 2021, 9:25 PM

#

mapi

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/ReflectionHelper.cs

copper nacelle Apr 22, 2021, 9:26 PM

#

The difference is that the former is based around emitting methods at runtime to have fast private field access

steady comet Apr 22, 2021, 9:26 PM

#

Afaik it just gets the private HeroController.instance.inputHandler

copper nacelle Apr 22, 2021, 9:26 PM

#

Utility wise though no

stone elm Apr 22, 2021, 9:26 PM

#

Yeah, found it. I'd say yes, about the same.

steady comet Apr 22, 2021, 9:26 PM

#

Is there any reason to use one over the other? (And just to check, they are the same object?)

jolly oriole Apr 22, 2021, 9:26 PM

#

idk inputHandler's visibility, but if it's public there's no need for the first option

stone elm Apr 22, 2021, 9:27 PM

#

Remove ReflectionHelper just add https://github.com/albahari/uncapsulator 😛

jolly oriole Apr 22, 2021, 9:27 PM

#

in this exact scenario

steady comet Apr 22, 2021, 9:28 PM

#

jolly oriole idk inputHandler's visibility, but if it's public there's no need for the first ...

In this case, the former is getting from HeroController and the second is from GameManager

jolly oriole Apr 22, 2021, 9:29 PM

#

oh, missed that

copper nacelle Apr 22, 2021, 9:30 PM

#

stone elm Remove `ReflectionHelper` just add https://github.com/albahari/uncapsulator 😛

dynamic doesn't exist on net 3.5

#

if it compiles to calling the interface stuff then it might work if you include the intrinsic

stone elm Apr 22, 2021, 9:31 PM

#

Port DLR to .net 3.5, problem solved

#

But, yeah, I don't expect dramatic change. Mostly just being a twerp. Although uncapsulator might work well in 1.5

copper nacelle Apr 22, 2021, 9:33 PM

#

they do the same thing anyways just without the nicer api

#

except that one won't work on 1.5

#

and mine will 😤

#

because reflection emit is not supported there

vocal spire Apr 22, 2021, 10:14 PM

#

jolly oriole poggy woggy

fwoggy woggy

charred topaz Apr 22, 2021, 10:20 PM

#

copper nacelle because reflection emit is not supported there

Would it be possible to add it in to the managed folder, similar to Newtonsoft? I did find this some time ago and has a version for dot net standard 2.0. https://www.nuget.org/packages/System.Reflection.Emit/

System.Reflection.Emit 4.7.0

Provides classes that allow a compiler or tool to emit metadata and optionally generate a PE file on disk. The primary clients of these classes are script engines and compilers.

Commonly Used Types:
System.Reflection.Emit.AssemblyBuilder
System.Reflection.Emit.FieldBuilder
System.Reflection.Emit.TypeBuilder
System.Reflection.Emit.MethodBuilder
...

copper nacelle Apr 22, 2021, 10:21 PM

#

Pretty sure I tried that but it was reffing mscorlib for emit stuff

#

I can give it another shot though

steady comet Apr 23, 2021, 5:33 PM

#

Is the AfterTakeDamageHook sometimes not called?

copper nacelle Apr 23, 2021, 5:34 PM

#

shouldn't

steady comet Apr 23, 2021, 5:39 PM

#

My code:

ModHooks.Instance.AfterTakeDamageHook += DisableDamage;

private static int DisableDamage(int hazardType, int damageAmount)
{
    return 0;
}

Doesn't work on the second dunk

jolly oriole Apr 23, 2021, 5:43 PM

#

that's because iframes lol

steady comet Apr 23, 2021, 5:44 PM

#

palehmm

jolly oriole Apr 23, 2021, 5:44 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/Patches/HeroController.cs#L654 is missing somewhere in https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/Patches/HeroController.cs#L767

steady comet Apr 23, 2021, 5:45 PM

#

OK so it's a bug in the modding API basically?

jolly oriole Apr 23, 2021, 5:45 PM

#

yes

steady comet Apr 23, 2021, 5:45 PM

#

oK, thanks

#

feelspkman

jolly oriole Apr 23, 2021, 5:47 PM

#

alternative, use the OnTakeDamage hook

steady comet Apr 23, 2021, 5:48 PM

#

Uh

#

Is OnTakeDamage for the 1.5 mapi?

jolly oriole Apr 23, 2021, 5:49 PM

#

i have no clue

steady comet Apr 23, 2021, 5:49 PM

#

OK

jolly oriole Apr 23, 2021, 5:49 PM

#

apparently

steady comet Apr 23, 2021, 5:49 PM

#

Well it said the latest commit was Jul 2020, but VS refuses to acknowledge ModHooks.Instance.OnTakeDamage

jolly oriole Apr 23, 2021, 5:50 PM

#

yea, it's not part of the 1432 mapi i think

steady comet Apr 23, 2021, 5:50 PM

#

(maybe because it's internal?)

steady comet Apr 23, 2021, 6:05 PM

#

Spaghetti alert

On.HeroController.TakeDamage += poo;

private static void poo(On.HeroController.orig_TakeDamage orig, HeroController self, GameObject go, CollisionSide damageSide, int damageAmount, int hazardType)
{
    self.cState.invulnerable = false;
    orig(self, go, damageSide, damageAmount, hazardType);
}

That "fixed" the issue...

#

Side question why is hazardType an int rather than using the GlobalEnums.HazardType?

jolly oriole Apr 23, 2021, 6:08 PM

#

teamcherry 🍝

stone elm Apr 23, 2021, 6:15 PM

#

Cherries in spaghetti sounds awful

steady comet Apr 23, 2021, 6:16 PM

#

I see, I suppose I should have expected as much

silent marsh Apr 23, 2021, 6:22 PM

#

Hi, sorry to bother you again, but is there any way to get a hook on crystal dash and/or bench events ? I don't see any in the docs, but maybe they are specifics cases of other hooks ? I thought about SavegameSaveHook for benching but it's probably called a lot more that just when I bench right ?

cedar hemlock Apr 23, 2021, 6:22 PM

#

when you save?

#

theres no thing for just when you bench sadly

#

i've searched for it before

silent marsh Apr 23, 2021, 6:23 PM

#

Ok thanks

copper nacelle Apr 23, 2021, 6:24 PM

#

TakeDamageHook @steady comet

jolly oriole Apr 23, 2021, 6:25 PM

#

is it in 1432?

copper nacelle Apr 23, 2021, 6:25 PM

#

yeah

#

everything is in 1432

#

I only removed hooks

jolly oriole Apr 23, 2021, 6:25 PM

#

just because it's not on the api docs lol

steady comet Apr 23, 2021, 6:30 PM

#

copper nacelle TakeDamageHook <@567770162661687302>

I should use TakeDamageHook rather than TakeDamage? Or just instead of both?

copper nacelle Apr 23, 2021, 6:33 PM

#

what

#

you use it instead of after take damage hook

cedar hemlock Apr 23, 2021, 6:34 PM

#

whats this:

[ERROR]:[API] -   at System.Collections.Generic.Dictionary`2[System.String,UnityEngine.Sprite].get_Item (System.String key) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at TransHK.CharmHelperExample+TextureStrings.Get (System.String key) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at TransHK.CharmHelperExample.Initialize () [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at Modding.Mod.Initialize (System.Collections.Generic.Dictionary`2 preloadedObjects) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at Modding.ModLoader.LoadMod (IMod mod, Boolean updateModText, Boolean changeSettings, System.Collections.Generic.Dictionary`2 preloadedObjects) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at Modding.ModLoader+<LoadMods>d__9.MoveNext () [0x00000] in <filename unknown>:0```

#

smth about a key??

jolly oriole Apr 23, 2021, 6:35 PM

#

looks like a keynotfoundexception

#

when a dictionary doesn't have the key you request

cedar hemlock Apr 23, 2021, 6:37 PM

#

ah i found it

#

thnx for the help

steady comet Apr 23, 2021, 7:13 PM

#

copper nacelle you use it instead of after take damage hook

Well if I try

ModHooks.Instance.TakeDamageHook += DisableDamage;

 private static int DisableDamage(ref int hazardType, int damage)
 {
    return 0;
 }

it doesn't do the hazard respawn thing

#

I think TakeDamageHook is too early

jolly oriole Apr 23, 2021, 7:38 PM

#

yes

copper nacelle Apr 23, 2021, 7:47 PM

#

yeah

#

I can fix it but I'm not backporting it

steady comet Apr 23, 2021, 7:48 PM

#

Fair enough, the spaghetti is good enough for me if I have to use 1432

silent marsh Apr 23, 2021, 8:29 PM

#

cedar hemlock theres no thing for just when you bench sadly

If you're interested I found a way using SetPlayerBoolHook :

ModHooks.Instance.SetPlayerBoolHook += OnSetPlayerBool ;

// ...

private void OnSetPlayerBool(string target, bool val)
{
    if (target == "atBench" && val)
    {
        // ...
    }
}

Although for some reason it's fired multiple times very fast when you bench, so you should implement some cooldown mechanism to have your processing executed only once

fair rampart Apr 24, 2021, 4:36 AM

#

yo

#

how do i get hollowpoint

copper nacelle Apr 24, 2021, 4:37 AM

#

have you tried reading the channel description

fair rampart Apr 24, 2021, 4:37 AM

#

my mistake

ornate rivet Apr 24, 2021, 9:52 AM

#

toxic

primal latch Apr 24, 2021, 11:24 AM

#

DynamicHeapAllocator allocation probe 1 failed - Could not get memory for large allocation 536870912.
DynamicHeapAllocator allocation probe 2 failed - Could not get memory for large allocation 536870912.
DynamicHeapAllocator allocation probe 3 failed - Could not get memory for large allocation 536870912.
DynamicHeapAllocator allocation probe 4 failed - Could not get memory for large allocation 536870912.

#

Anyone encountered this before?

#

It happends when assigning a custom texture loaded from an asset bundle to pure vessel

jolly oriole Apr 24, 2021, 11:32 AM

#

primal latch DynamicHeapAllocator allocation probe 1 failed - Could not get memory for large ...

then your assetbundle is too big

#

who even has a exactly 512 MB assetbundle

primal latch Apr 24, 2021, 11:51 AM

#

jolly oriole then your assetbundle is too big

What is the max size it can be?

#

Oops. I am sorry that I pinged you.

#

I guess your name is correct

jolly oriole Apr 24, 2021, 11:52 AM

#

on 1432 that depends how many and which other mods exist (also preloads, as those also take up memory)

#

test of teamwork has 10 MB of assetbundles (their filesize, don't know how much unity would use for it)

primal latch Apr 24, 2021, 11:54 AM

#

I don’t think it’s the asset bundle. I moved sprites to an assetbundle to stop this from happening on some other bosses

jolly oriole Apr 24, 2021, 11:54 AM

#

hm

primal latch Apr 24, 2021, 11:55 AM

#

And they now work fine

#

It might be that I’m not adding compression

jolly oriole Apr 24, 2021, 11:55 AM

#

shouldn't be an issue

#

1 alternative i could think of is having those sprites in their own assetbundle, so if that loads the rest of the assetbundle isn't loaded (and i hope you don't load all assets from the assetbundle after loading the assetbundle)

primal latch Apr 24, 2021, 11:56 AM

#

jolly oriole 1 alternative i could think of is having those sprites in their own assetbundle,...

I only load sprites when they are needed.

#

I’ll try moving the PV sprite to it’s own asset bundle

#

Could it also be the compression on the asset bundle?

jolly oriole Apr 24, 2021, 11:58 AM

#

compression shouldn't be an issue, but you can try it

primal latch Apr 24, 2021, 11:58 AM

#

Ok

#

I thought I read something about that

jolly oriole Apr 24, 2021, 12:01 PM

#

i use the editor script from https://docs.unity3d.com/ScriptReference/BuildPipeline.BuildAssetBundles.html to build assetbundles

#

though slightly different

different output folder
made it 2 buttons for testing, 1 compressed, 1 uncompressed

primal latch Apr 24, 2021, 12:08 PM

#

I might try it. We are using assetbundles browser

cedar hemlock Apr 24, 2021, 3:35 PM

#

im getting this again:

[ERROR]:[UNITY] - KeyNotFoundException: The given key was not present in the dictionary.
[ERROR]:[UNITY] - System.Collections.Generic.Dictionary`2[System.String,System.String].get_Item (System.String key)
[ERROR]:[UNITY] - TransHK.TransMod+<SetSprite>d__15.MoveNext ()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress)
[ERROR]:[UNITY] - UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
[ERROR]:[UNITY] - TransHK.TransMod:SceneChanged(Scene, Scene)
[ERROR]:[UNITY] - UnityEngine.SceneManagement.SceneManager:UnloadScene(String)
[ERROR]:[UNITY] - <BeginSceneTransitionRoutine>c__AnonStorey13:<>m__2()
[ERROR]:[UNITY] - <BeginRoutine>c__Iterator0:MoveNext()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ERROR]:[UNITY] -

#

my code is:

        Dictionary<string, string> Bossscene = new Dictionary<string, string>() { { "Room_Final_Boss_Core", "Hollow Knight Boss" } };
//...
        public Dictionary<string, Texture> EnemyTextures = new Dictionary<string, Texture>();

//...
USceneManager.activeSceneChanged += SceneChanged;
//...
foreach (string res in asm.GetManifestResourceNames())
            {
                Log("GetManifestRescourceNames");
                using (Stream s = asm.GetManifestResourceStream(res))
                {
                if (s == null) continue;
                byte[] buffer = new byte[s.Length];
                    s.Read(buffer, 0, buffer.Length);
                    _tex = new Texture2D(2, 2);
                    _tex.LoadImage(buffer, true);
                    if (res.Contains("Lifeblood THK.png"))
                    {
                    EnemyTextures.Add("Hollow Knight Boss", _tex);
                    }
                    else if (res.Contains("Big_Buzzboi.png"))
                    {
                    EnemyTextures.Add("", _tex);
                    }
      else if (res.Contains("yet another png name for an enemy"))
                    {
                    EnemyTextures.Add("another enemy name", _tex);
                    }
                }
                Log("aftergetmanifestrescourcenames");
            }
//...
private void SceneChanged(Scene arg0, Scene arg1)
        {
            Log("Scene had changed");
            GameManager.instance.StartCoroutine(SetSprite(arg1));
        }
//...
private IEnumerator SetSprite(Scene arg1)
        {
            Log("Setting sprites");
            var boss = arg1.Find(Bossscene[arg1.name]);
            boss.GetComponent<tk2dSprite>().GetCurrentSpriteDef().material.mainTexture = EnemyTextures[boss.name];
            yield return null;
            Log("Setting sprites End");
        }
```anyone have an idea whats wrong?

#

i have all the png's

deep wave Apr 24, 2021, 3:37 PM

#

directly using EnemyTextures[boss.name] will always try to find the key in the dictionary for every boss

#

so if you do not initialise every single boss then it will error at that point

#

you could use .TryGetValue(string key, out Texture Value) and test for if it returns false

#

or test if the dictionary contains the key before attempting to find it

cedar hemlock Apr 24, 2021, 3:40 PM

#

boss.GetComponent<tk2dSprite>().GetCurrentSpriteDef().material.mainTexture = EnemyTextures[boss.TryGetValue(string key, out string Value)];?

#

cus that gives me 4 errors

deep wave Apr 24, 2021, 3:42 PM

#

no, out string Value sets the variable you put in to the value

#

TryGetValue returns a bool

#

i'd just test for containskey first honestly

#

and trygetvalue is also a method on the dictionary, not on boss

cedar hemlock Apr 24, 2021, 3:47 PM

#

i dont understand it lol
i have no idea where to put .TryGetValue(string key, out Texture Value)

deep wave Apr 24, 2021, 3:48 PM

#

https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.dictionary-2.trygetvalue?view=net-5.0 docs

cedar hemlock Apr 24, 2021, 3:51 PM

#

oo

silent marsh Apr 24, 2021, 5:03 PM

#

Hi, today I don't even have any question / problem ! 🙂
Just wanted to say that I managed to implement the lighting effects for most of the events that I wanted, so I pushed a first working version of my Razer Chroma mod here : https://github.com/Webcretaire/HollowKnight.RainbowKnight
I also made a small preview here : https://youtu.be/FNZI_AMrrO0
If anyone has a Razer keyboard and wants to test it feel free to do so and tell me what you think (the lighting effects can certainly be improved, I'm not a very good designer)
And also obviously thank you for your help for the past few days, Hollow Knight people really are a nice community

fair rampart Apr 24, 2021, 6:58 PM

#

hi , where i can find some info or documentation about hk modding?

jolly oriole Apr 24, 2021, 6:59 PM

#

a lot of it is written at https://radiance.host/apidocs/Getting-Started.html and the official unity documentation

fair rampart Apr 24, 2021, 7:03 PM

#

jolly oriole a lot of it is written at <https://radiance.host/apidocs/Getting-Started.html> a...

oh thanks

ornate rivet Apr 24, 2021, 8:19 PM

#

please for the love of all things good

#

disable these notifications

copper nacelle Apr 24, 2021, 8:26 PM

#

TRUE

#

I despise these

#

I get like 1-4 a day

unborn flicker Apr 24, 2021, 8:26 PM

#

It is incredible that there is no way to turn them off.

jolly oriole Apr 24, 2021, 9:24 PM

#

apparently you can turn those off

#

https://support.google.com/drive/answer/6318501

charred topaz Apr 25, 2021, 2:09 AM

#

Is it not possible to change the functionality of the getters and/or setters of properties using the ON namespace?

copper nacelle Apr 25, 2021, 2:37 AM

#

It is in theory

#

In reality it is a gambling game

#

Small methods are often inlined by the JIT

elder radish Apr 25, 2021, 11:09 AM

#

I've created a custom enemy in a custom scene, setup the AI and everything. It can attack and damage enemy but knight can not hit the enemy for a reason that I dont know. Is there something extra that should do?

#

Is there a static HealthManager that I should add to the scene like SceneManager?

primal latch Apr 25, 2021, 11:12 AM

#

Does it have a colider?

jolly oriole Apr 25, 2021, 11:17 AM

#

It needs a healthmanager (the normal one), be on layer 9, and if it then still doesn't work also a rigidbody

#

The last thing also allows it to be hittable by all players in multiplayer

elder radish Apr 25, 2021, 11:26 AM

#

It does have a collider yeap when the kinght hits it, knight gets damage. enemy is layer 11 and its attack is on 22

#

what is layer 9 for

jolly oriole Apr 25, 2021, 11:26 AM

#

i think layer 9 was enemies, could be wrong though

elder radish Apr 25, 2021, 11:26 AM

#

enemy also has a rigidbody2d

jolly oriole Apr 25, 2021, 11:29 AM

#

oh, layer 11 is enemies, should work then

#

layer 9 was player

elder radish Apr 25, 2021, 11:30 AM

#

HealthManagerOnTakeDamage is not being called

#

I wonder is there something that I should do about On.HealthManager

#

I also have this method and it is being called successfully

jolly oriole Apr 25, 2021, 11:34 AM

#

may i ask what name the enemy gameobject has?

elder radish Apr 25, 2021, 11:34 AM

#

Witch

jolly oriole Apr 25, 2021, 11:35 AM

#

the only way that doesn't work then is your naildamage is 0

elder radish Apr 25, 2021, 11:35 AM

#

Is it possible though

jolly oriole Apr 25, 2021, 11:39 AM

#

it should fully work unless:

your nailDamage is 0
your HealthManager is dead
your HealthManager has iframes from the last attack

elder radish Apr 25, 2021, 11:45 AM

#

what does the last one means?

jolly oriole Apr 25, 2021, 11:46 AM

#

when an enemy gets hit, it has iframes for 0.15/0.2 seconds

elder radish Apr 25, 2021, 11:53 AM

#

it does never gets hit so I assume not the last option

#

what is the diff between the On.HealthManager and the healthmanager instance on the object?

#

Is the first one something different

jolly oriole Apr 25, 2021, 11:56 AM

#

the first one is just for hooks, so you get notified and can execute code when a method of the latter one gets called

steady comet Apr 25, 2021, 11:57 AM

#

Were all the On.??? hooks generated automatically by the monomod?

jolly oriole Apr 25, 2021, 11:58 AM

#

steady comet Were all the On.??? hooks generated automatically by the monomod?

in the 1432 version bundled directly into assembly-csharp, in 1.5 it's the mmhooks dll

steady comet Apr 25, 2021, 11:58 AM

#

I mean, as opposed to someone having to manually create all of them (I'm guessing that's the case with the ModHooks?)

jolly oriole Apr 25, 2021, 12:01 PM

#

steady comet I mean, as opposed to someone having to manually create all of them (I'm guessin...

generated at https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/Assembly-CSharp.csproj#L46

elder radish Apr 25, 2021, 12:01 PM

#

It seems like that hook is not working

#

This hook works on custom scenes too right?

jolly oriole Apr 25, 2021, 12:12 PM

#

then there probably is an exception

steady comet Apr 25, 2021, 12:13 PM

#

jolly oriole generated at <https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/...

That's pretty cool - thanks 🙂

jolly oriole Apr 25, 2021, 12:29 PM

#

elder radish This hook works on custom scenes too right?

tested it (had to first put a healthmanager on my object as i didn't have that), and

var hmPrefab = Resources.FindObjectsOfTypeAll<HealthManager>()[0];
var hm = this.gameObject.AddComponent<HealthManager>();

Dictionary<string, FieldInfo> fis = new Dictionary<string, FieldInfo>();
foreach (var fi in typeof(HealthManager).GetFields(BindingFlags.NonPublic | BindingFlags.Instance))
{
    fis.Add(fi.Name, fi);
    fi.SetValue(hm, fi.GetValue(hmPrefab));
}

fis["boxCollider"].SetValue(hm, null);
fis["recoil"].SetValue(hm, null);
fis["hitEffectReceiver"].SetValue(hm, null);
fis["enemyDeathEffects"].SetValue(hm, null);
fis["animator"].SetValue(hm, null);
fis["sprite"].SetValue(hm, null);
fis["damageHero"].SetValue(hm, null);
fis["audioPlayerPrefab"].SetValue(hm, null);
fis["regularInvincibleAudio"].SetValue(hm, null);
fis["enemyType"].SetValue(hm, 0);
fis["effectOrigin"].SetValue(hm, Vector3.zero);
fis["ignoreKillAll"].SetValue(hm, true);
fis["invincible"].SetValue(hm, false);
fis["invincibleFromDirection"].SetValue(hm, -1);
fis["preventInvincibleEffect"].SetValue(hm, true);
fis["hasAlternateInvincibleSound"].SetValue(hm, false);
fis["alternateInvincibleSound"].SetValue(hm, null);
fis["deathAudioSnapshot"].SetValue(hm, null);
fis["semiPersistent"].SetValue(hm, false);
fis["stunControlFSM"].SetValue(hm, null);

hm.hp = 99999;

made the hook trigger

elder radish Apr 25, 2021, 1:15 PM

#

made it work with your code. The HealthManager I've preloaded might be the problem.Thank you very much, altough your code made me wonder two things

#

How did you select the HealthManager values that you set after foreach loop?

#

Is using Resources.FindObjectOfType an alternative to preloading?

jolly oriole Apr 25, 2021, 1:20 PM

#

null or default values (for ignoreKillAll i just thought they may be fitting, and invincibleFromDirection 0 is invincible from all directions, so -1 was the choice)
no, it only finds loaded things, so contents from not loaded scenes can't be found this way

#

if you make an actual enemy you probably don't need anything after the for loop

elder radish Apr 25, 2021, 1:32 PM

#

again thank you very much for help

light zodiac Apr 25, 2021, 6:52 PM

#

i'm trying to load a scene in HoG. I first tried what benchwarp does and it gave me a black screen. Then i tried using debug mod's save state and this happens.

#

is there any way to stop the player from moving or a better way to load the scene. I did HeroController.instance.RelinquishControl(); to try to stop movement but it didn't seem to work

maiden umbra Apr 25, 2021, 8:17 PM

#

im looking for dialogues stored in dnspy, does someone know where i can find them

copper nacelle Apr 25, 2021, 8:23 PM

#

not in dnspy

maiden umbra Apr 25, 2021, 8:30 PM

#

do you know where?

#

because i see i can get them with the getlanguage hook, but i don't know which key corresponds to what text, if that makes sense

copper nacelle Apr 25, 2021, 8:31 PM

#

you can log the sheet and key w/ the result in there

maiden umbra Apr 25, 2021, 8:31 PM

#

i saw that note on the radiance.host site as well, but how would i do that

#

thanks for your vid btw

copper nacelle Apr 25, 2021, 8:32 PM

#

private string OnLangGet(string key, string sheetTitle) {
    string res = Language.Language.GetInternal(key, sheetTitle);

    Log($"{sheetTitle}-{key}: {res}");

    return res;
}

#

glad the video helped

#

if you want any particular sheet i have them all too, though you can just use AssetStudio pretty easily

maiden umbra Apr 25, 2021, 8:34 PM

#

thank you!

jolly oriole Apr 25, 2021, 8:34 PM

#

copper nacelle ```cs private string OnLangGet(string key, string sheetTitle) { string res =...

you forgot a $

copper nacelle Apr 25, 2021, 8:35 PM

#

that's true

runic wind Apr 25, 2021, 9:47 PM

#

Are there resources for learning how to mod? I have programming experience and a bit of Unity experience, and I'm not looking to do anything too ambitious

uneven radish Apr 25, 2021, 9:50 PM

#

https://radiance.host/apidocs/Getting-Started.html seems to be a good place to start

fluid furnace Apr 26, 2021, 1:20 AM

#

heyo, anybody here know how to make HK mods?

ornate rivet Apr 26, 2021, 1:37 AM

#

hk mods?

#

pretty sure modding hk is impossible

vocal spire Apr 26, 2021, 1:37 AM

#

fluid furnace heyo, anybody here know how to make HK mods?

the message right above yours......

vocal spire Apr 26, 2021, 1:38 AM

#

ornate rivet pretty sure modding hk is impossible

yeah, the apidocs for modding it specifically state that it can't be modded

fluid furnace Apr 26, 2021, 1:40 AM

#

but

#

people have made mods

#

._.

#

isn't that why these channels exist

copper nacelle Apr 26, 2021, 1:40 AM

#

it is a joke

fluid furnace Apr 26, 2021, 1:40 AM

#

oh

#

yeah well you see I lack this thing called a brain

#

um so, I would prefer not to make the mod myself because I'm already trying to learn like 6 other things rn

#

but I can provide assets for the mod if someone can do the actual modding

ornate rivet Apr 26, 2021, 1:43 AM

#

what do you want to make? If it's a tiso mod, it's already being worked on

#

but I guess there's always room for more tiso

#

the real problem is finding an active modder that doesn't already have 6 other projects they are working on

fluid furnace Apr 26, 2021, 1:45 AM

#

true

#

that seems to be the case with most modding communities

fluid furnace Apr 26, 2021, 1:45 AM

#

ornate rivet what do you want to make? If it's a tiso mod, it's already being worked on

that is what I want to do, yes

#

could you point me in the direction of some of those mods

vocal spire Apr 26, 2021, 1:46 AM

#

ornate rivet the real problem is finding an active modder that doesn't already have 6 other p...

~~I feel called out~~

vocal spire Apr 26, 2021, 1:47 AM

#

fluid furnace could you point me in the direction of some of those mods

I know of two possible sources, 1. jngo(not been here for a while) 2. private mod that I will not disclose

#

but everyone has thought of a tiso boss at some point, so there's prob more

fluid furnace Apr 26, 2021, 1:49 AM

#

well then

#

I suppose the question becomes "anyone here working on or know who's working on a Tiso boss mod"

fluid furnace Apr 26, 2021, 2:18 AM

#

now just gotta figure out how to make HK mods

#

learning mod development go brrr

vocal spire Apr 26, 2021, 2:18 AM

#

Do you know c#?

fluid furnace Apr 26, 2021, 2:18 AM

#

no

#

.-.

vocal spire Apr 26, 2021, 2:19 AM

#

You should probably learn it first

fluid furnace Apr 26, 2021, 2:19 AM

#

I would like to learn it, for several reasons

#

one of which is Terraria and also just because it seems like a really versatile language

vocal spire Apr 26, 2021, 2:19 AM

#

Ah yeah, terraria modding is fun

fluid furnace Apr 26, 2021, 2:19 AM

#

I sprite for a bunch of terraria mods but I've never coded any

#

the most programming I've done was a HTML game in Javascript

#

it was for a course

#

byeah I should just do c#

vocal spire Apr 26, 2021, 2:26 AM

#

You should also probably learn a bit of how to work with unity(ex: basic knowledge of how to use monobehaviors and gameobjects)

jolly jungle Apr 26, 2021, 4:17 AM

#

I wanted to make a mod where we actually witness Tiso's death, but that's probably not what you meant

fluid furnace Apr 26, 2021, 1:15 PM

#

no, I was thinking about adding a Tiso boss fight

#

probably accessed by dream nailing his corpse

light zodiac Apr 26, 2021, 1:45 PM

#

i want to load a scene in HoG when i press a button. I'm currently doing: ```cs
if (Input.GetKeyDown(KeyCode.B))
{
GameManager.instance.BeginSceneTransition(new GameManager.SceneLoadInfo
{
IsFirstLevelForPlayer = false,
SceneName = "GG_Hollow_Knight",
HeroLeaveDirection = GlobalEnums.GatePosition.unknown,
EntryGateName = "door_dreamEnter",
PreventCameraFadeOut = false,
WaitForSceneTransitionCameraFade = true,
Visualization = GameManager.SceneLoadVisualizations.GodsAndGlory,
AlwaysUnloadUnusedAssets = false
});

        }```

But when i press the key, i only see a black screen but i can hear the boss and i can take damage

summer siren Apr 26, 2021, 1:49 PM

#

hello can I talk about skin development in this chat

light zodiac Apr 26, 2021, 1:51 PM

#

most skin development talk happens in #modding-discussion

summer siren Apr 26, 2021, 1:53 PM

#

ok

#

thank you

jolly oriole Apr 26, 2021, 1:56 PM

#

light zodiac i want to load a scene in HoG when i press a button. I'm currently doing: ```cs ...

copying what the inspect elements in hog do would also be an option, idk what they exactly do

light zodiac Apr 26, 2021, 1:59 PM

#

how would i copy the inspect elements

jolly oriole Apr 26, 2021, 3:17 PM

#

light zodiac how would i copy the inspect elements

you could preload them, but doing what the statues do is probably better:
~~1. send "DREAM ENTER" event to some object~~
2. set dreamReturnScene pd string
3. send "BOX DOWN DREAM" event to all (broadcastall)
4. send "CONVO CANCEL" event to all (broadcastall)
5. if you want to be fancy, spawn a gg_battle_transitions gameobject
6. send "GG TRANSITION OUT" event to above spawned object
7. call HeroController.instance.ClearMPSendEvents()
8. image

light zodiac Apr 26, 2021, 5:59 PM

#

how do i spawn gg_battle_transitions

#

and for 3 and 4 its just EventRegister.SendEvent("BOX DOWN DREAM");?

jolly oriole Apr 26, 2021, 6:03 PM

#

light zodiac how do i spawn `gg_battle_transitions`

may be a globally accessible gameobject (or preload an Inspect gameobject and pull it out of the fsm)

jolly oriole Apr 26, 2021, 6:06 PM

#

light zodiac and for 3 and 4 its just `EventRegister.SendEvent("BOX DOWN DREAM");`?

PlayMakerFSM.BroadcastEvent("eventname")

jolly oriole Apr 26, 2021, 6:08 PM

#

jolly oriole you could preload them, but doing what the statues do is probably better: ~~1. s...

btw, the 2nd to last part of the image isn't needed

steady comet Apr 26, 2021, 6:11 PM

#

Why does PlayMakerFSM.BroadcastEvent not work?

jolly oriole Apr 26, 2021, 6:12 PM

#

because the method doesn't exist?

#

or i haven't found it

steady comet Apr 26, 2021, 6:12 PM

#

Well it works in Rando tamershrug https://github.com/homothetyhk/HollowKnight.RandomizerMod/blob/master/RandomizerMod3.0/RandomizerMod.cs#L474

jolly oriole Apr 26, 2021, 6:12 PM

#

oh, then i haven't found it

steady comet Apr 26, 2021, 6:13 PM

#

Oh wait, you said ("eventname", false)

#

That overload doesn't seem to exist

jolly oriole Apr 26, 2021, 6:13 PM

#

the false is only to also send it to itself lol

steady comet Apr 26, 2021, 6:13 PM

#

Oh I see lmao

jolly oriole Apr 26, 2021, 6:13 PM

#

i just found that because SendMessageByName used that

steady comet Apr 26, 2021, 6:14 PM

#

In the 1.5 mapi do you have to broadcast an FsmEvent rather than a string fsmEventName?

jolly oriole Apr 26, 2021, 6:14 PM

#

i have no idea

steady comet Apr 26, 2021, 6:14 PM

#

OK, I guess I'll investigate when I get the 1.5 mapi (which I'm far too lazy to get before I'm forced to lmao)

jolly oriole Apr 26, 2021, 6:15 PM

#

i could check rn

#

the static method still exists, so no

steady comet Apr 26, 2021, 6:16 PM

#

Awesome thanks hollowknice

light zodiac Apr 26, 2021, 6:21 PM

#

jolly oriole may be a globally accessible gameobject (or preload an `Inspect` gameobject and ...

like this ?EasierPantheonPractice.PreloadedObjects["Inspect"].FindGameObjectInChildren("gg_battle_transitions");

#

and this is the thing i preloaded ("GG_Workshop","Inspect")

jolly oriole Apr 26, 2021, 6:23 PM

#

light zodiac like this ?`EasierPantheonPractice.PreloadedObjects["Inspect"].FindGameObjectInC...

actually no, it's not part of the structure, but only referenced in the fsm, so something like

EasierPantheonPractice.PreloadedObjects["Inspect"].LocateMyFsm("GG Boss UI").GetAction<CreateObject>("Transition", 0).gameObject

jolly oriole Apr 26, 2021, 6:24 PM

#

light zodiac and this is the thing i preloaded `("GG_Workshop","Inspect")`

("GG_Workshop", "GG_Statue_Hornet/Inspect")

light zodiac Apr 26, 2021, 6:25 PM

#

jolly oriole `("GG_Workshop", "GG_Statue_Hornet/Inspect")`

so if i wanna do for all bosses I'll have to preload each one?

jolly oriole Apr 26, 2021, 6:25 PM

#

no, because the thing you're getting from <#archived-modding-development message> is a prefab, just need to instantiate/spawn it whenever you need (spawnpoint should be the knight i think)

light zodiac Apr 26, 2021, 6:36 PM

#

jolly oriole actually no, it's not part of the structure, but only referenced in the fsm, so ...

how do i send an event to that? the lightblub told me its a HutongGames.PlayMaker.FsmGameObject and that doesnt have a method for send event

jolly oriole Apr 26, 2021, 6:38 PM

#

foreach (var item in go.GetComponentsInChildren<PlayMakerFSM>())
      item.SendEvent("lol");

with go being the thing you have + .Value

light zodiac Apr 26, 2021, 6:50 PM

#

It works!!

#

Thank you so much

jolly oriole Apr 26, 2021, 6:52 PM

#

ez, not a single thing of this was tested 😎

twin gull Apr 26, 2021, 7:30 PM

#

Hey so I was trying to use the mod installer yesterday, and I ran into an issue where hk stopped recognizing my controller, and some guy said "oh yeah, that happens, just use a gamepad->keyboard translator." I would rather not do this for various reasons, so I thought I'd ask about

how exactly the mod api interacts with the game controller api (like, where in the modding api code we interact with controller related things)?
why this is done?

I ask because, not really knowing about how the modding api works, i would think it would be preferable to not interact with the controller in the first place.

FYI, I've been a software engineer for like 10 years (although not a game dev), and I know tons of programming languages, although not really C# particularly. So you can explain stuff in technical terms, not just abstractly

cedar hemlock Apr 26, 2021, 7:31 PM

#

Change some guy to Someone to be more accurate

twin gull Apr 26, 2021, 7:31 PM

#

like, i tried searching for stuff like controller (but mvc, lulz) or input in https://github.com/HollowKnight-Modding/HollowKnight.Modding, but i'm not sure i found the right places to look, and anyway I gather that's not even the correct repo

cedar hemlock Apr 26, 2021, 7:33 PM

#

And <#archived-modding-help message>

twin gull Apr 26, 2021, 7:34 PM

#

I did try a bunch of big picture-related things & plugging in controller either before or after starting hk, although not any external programs like joy2key or whatever it was

#

anyway, this wasn't a request for support

#

I was asking about what was actually going on in the code, since maybe we could just solve this once for everyone

cedar hemlock Apr 26, 2021, 7:35 PM

#

The only time i used joy2key was when i connected my wii controller and all hell broke loose

twin gull Apr 26, 2021, 7:37 PM

#

yeah, see, maybe there's a way to avoid that

#

but i'd need to know for sure whether the repo ref'd above was the correct, canonical, up-to-date repo, and also where to find whatever code affects controller input

#

b/c i probably don't have time to just figure it all out myself from the ground up

cedar hemlock Apr 26, 2021, 7:40 PM

#

If Someone said it was not the roght one then it was not the right one

#

But i dont really know if its the right one

twin gull Apr 26, 2021, 7:41 PM

#

I wasn't 100% sure I understood what he meant here: #archived-modding-help message

cedar hemlock Apr 26, 2021, 7:42 PM

#

It seems to be the right one

twin gull Apr 26, 2021, 7:42 PM

#

But this is for the 1.5 beta

cedar hemlock Apr 26, 2021, 7:42 PM

#

Ah

young walrus Apr 26, 2021, 7:42 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/releases/tag/1.4.3.2-60

GitHub

Release 1.4.3.2-60 · HollowKnight-Modding/HollowKnight.Modding

Bump version

cedar hemlock Apr 26, 2021, 7:42 PM

#

Hollow knight 1.5 is a beta release

young walrus Apr 26, 2021, 7:43 PM

#

1432-60 is the current active version on the installer

twin gull Apr 26, 2021, 7:44 PM

#

cedar hemlock Hollow knight 1.5 is a beta release

does that mean a beta of hk or a beta of the mod api?

cedar hemlock Apr 26, 2021, 7:44 PM

#

Well both

#

That api is still a beta b/c that version of hk is still a beta

twin gull Apr 26, 2021, 7:45 PM

#

so there's a beta of hk, and work on the mod api to support the beta, got it

#

so i could dl & run the hk 1.5 rc if i flipped some flag on steam?

jolly oriole Apr 26, 2021, 7:47 PM

#

yes

#

there's a beta option in the properties

twin gull Apr 26, 2021, 7:47 PM

#

cool, that all makes sense

jolly oriole Apr 26, 2021, 7:47 PM

#

twin gull Apr 26, 2021, 7:48 PM

#

so does anyone know where in the mod api code we interact with the controller or input?

#

is it InputHandler.cs?

cedar hemlock Apr 26, 2021, 7:49 PM

#

I guess?

young walrus Apr 26, 2021, 7:49 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/search?q=input

GitHub

HollowKnight-Modding/HollowKnight.Modding

Hollow Knight Modding API. Contribute to HollowKnight-Modding/HollowKnight.Modding development by creating an account on GitHub.

stone elm Apr 26, 2021, 7:50 PM

#

GitHub's code search is atrocious, otherwise I'd be with you. You use Unity's input modules to handle input, just as if the game would.

cedar hemlock Apr 26, 2021, 7:51 PM

#

y the embed tho

stone elm Apr 26, 2021, 7:51 PM

#

There may be helper code in the modding api, but IDK man, that's where searching will come in handy just don't expect much from github's searchbox

young walrus Apr 26, 2021, 7:52 PM

#

too many clicks to type brackets

twin gull Apr 26, 2021, 7:53 PM

#

yeah, i know how to use github & its codesearch (& that it sucks & you probably have to just clone & search the fs)

young walrus Apr 26, 2021, 7:53 PM

#

there might be a simple solution to the problem, but it's going to be a hidden one. it's probably a byproduct of the API hijacking the game's launch. It's not going to be a cut and dry solution of "inputmethod=xinput"

twin gull Apr 26, 2021, 7:54 PM

#

sure, but does anyone know exactly where we hijack the input, and more importantly why?

jolly oriole Apr 26, 2021, 7:55 PM

#

i think 56 would know

young walrus Apr 26, 2021, 7:55 PM

#

tmk.... nowhere

#

56 would be the one to ask tho

#

that's why I'm saying.... I don't think there's any method in this code that directly takes over input handling. However, the API may have a side effect with the game/steam/etc by virtue of an omission or something that's causing only limited inputs to be accepted

twin gull Apr 26, 2021, 7:57 PM

#

i'm pretty sure you're right

cedar hemlock Apr 26, 2021, 7:57 PM

#

If the what is causing it, why its causing it and how to fix it was known then the bug wouldn't exist

young walrus Apr 26, 2021, 7:58 PM

#

I'm sure it's fixable, but figuring out why the interaction is happening like it is.... will take a ton of debugging

twin gull Apr 26, 2021, 7:58 PM

#

no i don't mean why it's causing it, i mean why do we hijack input in the first place

young walrus Apr 26, 2021, 7:58 PM

#

like I said.... tmk.... we don't

#

at least not on purpose

twin gull Apr 26, 2021, 7:58 PM

#

because that would help me figure out what's going on & what solutions wouldn't break whatever it is we're trying to accomplish in the first place

young walrus Apr 26, 2021, 7:59 PM

#

the assembly file is the main launching file of the game

cedar hemlock Apr 26, 2021, 7:59 PM

#

Its a side effect of something its just not known of what

young walrus Apr 26, 2021, 7:59 PM

#

so by nature of replacing it....

#

^

#

that's why I'm saying, I don't see a method in this code that would be hijacking input handling directly. but some other hand-off might be broken

twin gull Apr 26, 2021, 8:00 PM

#

you mean, nobody is trying to hijack input to e.g. make the menu work or make some class of mods possible, just somebody did something that's doing it & it wasn't intentional?

jolly oriole Apr 26, 2021, 8:01 PM

#

i think it's more like xinput is in the assembly for mac/linux but the modded one doesn't contain that, or something similar, idk

twin gull Apr 26, 2021, 8:01 PM

#

btw, so i didn't mention this earlier, but i checked the player log both with & without the mod api installed:
original:

Game controller set to Generic Controller.

modded:

Game controller set to Unknown Device.

which is why i think Mickely is right

young walrus Apr 26, 2021, 8:02 PM

#

using inputs != input types.

#

the API allows only XInput when it's installed iirc

#

but without the API, steam input handling works fine

#

so some handoff of input method is broken

#

that's what I mean about hijacking input handling

twin gull Apr 26, 2021, 8:03 PM

#

i think sfgrenade may be on to something tho

young walrus Apr 26, 2021, 8:03 PM

#

there is no method in the API that defines input handling. but yes, inputs are used for UIs, etc

#

so the unity/steam/etc input methods are being broken

twin gull Apr 26, 2021, 8:05 PM

#

jolly oriole i think it's more like xinput is in the assembly for mac/linux but the modded on...

do you have any reason to believe that while the modded assembly doesn't have xinput, it would have the libs for other devices like for a switch pro controller or whatever?

jolly oriole Apr 26, 2021, 8:06 PM

#

i have no clue about that, just heard something like that once

twin gull Apr 26, 2021, 8:06 PM

#

the controller i usually use is an 8bitdo sn30 pro, which steam treats as an xbox 360 controller (& would thus use xinput i think)

#

but i also have the sn30 pro+, which can be configured to use xinput, or some other nintendo-specific thing, or some android-related thing (idk, i stopped reading the manual at some point)

#

anyway, the point is that:

if the issue is the modded asm missing xinput
if the modded asm is known to NOT be missing xinput-but-for-nintendo-switch
then it would work if i used the pro+ in switch controller mode

#

i don't actually want to use the pro+ since i like the other controller better, but it would let us identify & solve the problem

#

maybe

#

i mean this isn't just about allowing me to play the game with mod api & some controller, but about reducing the number of people who come here and ask why their controller doesn't work

#

also, my original objective here was to install debug mod so I could learn the speedrun skips, and having to use my less-good controller kind of clashes with that goal

#

(for some reason i want to say that "xinput-but-for-nintendo-switch" is actually called "dinput", but idk, that might have been the android one, or just what 8bitdo calls it, or some other thing)

runic wind Apr 26, 2021, 10:11 PM

#

Is there a way to add a mod option in the pause menu? I’m not seeing anything in the docs

vocal spire Apr 26, 2021, 10:11 PM

#

runic wind Is there a way to add a mod option in the pause menu? I’m not seeing anything in...

You should look at how other mods do it. The ModdingApi itself does not add a way to do this

runic wind Apr 26, 2021, 10:12 PM

#

Alright, thanks

twin gull Apr 26, 2021, 10:40 PM

#

So I just tested it & in fact he pro+ controller in switch-input mode DOES work with the mod api installed. Sort of.

Basically, I may have it configured wrong, but vanilla hollow knight doesn't actually recognize the switch controller in game (i.e. from menu > options > controller), and also it's pretty much unusable in that the d-pad doesn't work, i have to use the left stick to navigate the menus & move the knight, and the only button that works is the a button, and that only works in the menu. But it does work the same with & without the mod api installed. Maybe this is relevant to the theory that the modded asm is missing xinput on some platforms (I'm on linux).

Note that I'm blacklisting the hid_nintendo driver so that steam uses it's built-in hidraw-based pro controller driver. If that's relevant to anything

As I said before, I really don't want to use the pro+ controller, since it's not as good as the other controller, and the only reason I got the mod installer in the first place was to install debug mod to learn the speedrun skips, so if I have to use a suboptimal controller to learn them that kind of defeats the purpose. I'm just noting stuff that may be useful to understand however whatever is happening to people's controllers happens.

twin gull Apr 26, 2021, 11:15 PM

#

looking at debug output with good controller, I see the following:
orig:

Steam stats received.
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

WARNING: Shader Unsupported: 'Sprites/Lit' - Pass '' has no vertex shader

mods:

Steam stats received.
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

[InControl] Joystick 1: "dev:xb360:Xbox 360 Controller"
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

WARNING: Shader Unsupported: 'Sprites/Lit' - Pass '' has no vertex shader

so the mod api adds that InControl bit, whatever it is

#

later we see from both orig & mods:

Game controller set to None.

copper nacelle Apr 26, 2021, 11:18 PM

#

InControl is standard

#

it's what hk uses for input as a whole

#

one of the issues with controllers is xinput

#

varies between platforms

twin gull Apr 26, 2021, 11:19 PM

#

then, the working version does:

Unloading 64 unused Assets to reduce memory usage. Loaded Objects now: 44936.
Total: 126.858000 ms (FindLiveObjects: 2.264000 ms CreateObjectMapping: 1.367000 ms MarkObjects: 122.829000 ms  DeleteObjects: 0.398000 ms)

Game controller set to Generic Controller.
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Controller Support Not Yet Verified
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Unable to match controller of known type (Generic Controller), will attempt default mapping set.

so i guess that match succeeds.

#

but with mods

Unloading 73 unused Assets to reduce memory usage. Loaded Objects now: 45044.
Total: 151.753000 ms (FindLiveObjects: 5.953000 ms CreateObjectMapping: 2.183000 ms MarkObjects: 143.253000 ms  DeleteObjects: 0.363000 ms)

Game controller set to Unknown Device.
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Controller Support Not Yet Verified
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Unable to match controller of known type (Unknown Device), will attempt default mapping set.
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Subscribing to controller detection.
 
(Filename: /home/builduser/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

Fallback handler could not load library /home/dmr/.local/share/Steam/steamapps/common/Hollow Knight/hollow_knight_Data/Mono/x86_64/InControlNative
Fallback handler could not load library /home/dmr/.local/share/Steam/steamapps/common/Hollow Knight/hollow_knight_Data/Mono/x86_64/libInControlNative.so
Fallback handler could not load library /home/dmr/.local/share/Steam/steamapps/common/Hollow Knight/hollow_knight_Data/Mono/x86_64/./InControlNative
...(snip)...
Unsubscribing from controller detection.

vocal spire Apr 26, 2021, 11:20 PM

#

I guess it's a missing library then

twin gull Apr 26, 2021, 11:21 PM

#

@copper nacelle earlier sfgrenade suggested that on some platforms, we patch the asm without adding xinput for some platforms

copper nacelle Apr 26, 2021, 11:22 PM

#

On Linux and mac the universal binary is built against the windows assembly yes

twin gull Apr 26, 2021, 11:22 PM

#

which prompted me to try using my replica switch pro controller in actual-switch mode, which kinda worked

copper nacelle Apr 26, 2021, 11:22 PM

#

Which means native functions aren't tied in

#

Controllers are still fucked on windows anyways though

twin gull Apr 26, 2021, 11:24 PM

#

copper nacelle On Linux and mac the universal binary is built against the windows assembly yes

you mean the universal binary for hk or for the mod installer or what?

copper nacelle Apr 26, 2021, 11:26 PM

#

the api labeled universal is just built against windows because for the most part everything is the same

twin gull Apr 26, 2021, 11:32 PM

#

so presumably, InControl is statically linked to the mac/linux binaries, and running the mod installer is wiping them out somehow?

vocal spire Apr 26, 2021, 11:32 PM

#

not running mod installer, using the ModdingApi

copper nacelle Apr 26, 2021, 11:36 PM

#

InControl has pinvokes

twin gull Apr 26, 2021, 11:36 PM

#

maybe I'm confused: my mental model of what's going on is that running the mod installer patches the hollow knight binaries to add the modding api, so that mod packages can hook into the modding api

copper nacelle Apr 26, 2021, 11:36 PM

#

No

#

That'd be a pain

#

you prebuild the api and just overwrite

vocal spire Apr 26, 2021, 11:36 PM

#

just replacing the assembly with the modded one

copper nacelle Apr 26, 2021, 11:36 PM

#

Can't trust the average user to have .net core let alone msbuild

vocal spire Apr 26, 2021, 11:37 PM

#

can't trust the average user to know what clicking install on a mod does

copper nacelle Apr 26, 2021, 11:37 PM

#

that's true

#

It's just a matter of building against the other vanilla folder

#

Pretty sure I have it already

twin gull Apr 26, 2021, 11:43 PM

#

so i could fix this by building HollowKnight.Modding myself against my own vanilla hk dir, assuming I knew how to apply the result?

vocal spire Apr 26, 2021, 11:43 PM

#

copper nacelle Controllers are still fucked on windows anyways though

maybe, but this

twin gull Apr 26, 2021, 11:44 PM

#

presumably i would want to git co 1.4.3.2-60 first

copper nacelle Apr 26, 2021, 11:44 PM

#

yeah

#

it's fairly simple

#

build in release

#

Provided you're on Mac or Linux

twin gull Apr 26, 2021, 11:47 PM

#

for steps 3-4, is it just msbuild -p:Configuration=Debug or what?

copper nacelle Apr 26, 2021, 11:48 PM

#

don't use debug

#

Release

#

but yeah

#

also add /restore

#

I should replace those

twin gull Apr 26, 2021, 11:54 PM

#

ok; i assumed that was only for step 8 for whatever reason

#

presumably i'm missing some core ms libs:

/usr/lib/mono/msbuild/15.0/bin/Microsoft.CSharp.CurrentVersion.targets(331,5): error MSB4019: The imported project "/usr/lib/mono/msbuild/15.0/bin/Roslyn/Microsoft.CSharp.Core.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.```

copper nacelle Apr 26, 2021, 11:57 PM

#

if you'd like I can just build against the Linux binaries in like 20m

#

Otherwise yeah

twin gull Apr 26, 2021, 11:57 PM

#

that might be better; it turns out i didn't even have the dotnet-sdk installed, and downloading that will take a while, and then who knows whether that's everything

copper nacelle Apr 26, 2021, 11:58 PM

#

Cool

twin gull Apr 26, 2021, 11:58 PM

#

i'm actually installing dotnet-sdk anyway, but i sorta doubt that'll solve everything

runic wind Apr 27, 2021, 1:02 AM

#

anyone know why .NET 3.5 isn't in the target framework list for Visual Studio? I have 3.5 enabled in control panel as well as added as an additional component in the Visual Studio installer

copper nacelle Apr 27, 2021, 1:03 AM

#

did you get the targeting pack

runic wind Apr 27, 2021, 1:05 AM

#

probably not

#

I couldn't find a developer pack- there was only a runtime in the .net downloads page

#

can't find it, do you have a file or link?

copper nacelle Apr 27, 2021, 1:08 AM

#

https://dotnet.microsoft.com/download/dotnet-framework/net35-sp1

#

I believe that includes the targeting pack

#

@twin gull

📎 ModdingAPI.zip

runic wind Apr 27, 2021, 1:09 AM

#

it does? ok then

copper nacelle Apr 27, 2021, 1:09 AM

#

3.5 is a pain

#

there's also .net 3.5 dev tools in the vs installer but you said you already did that

deep wave Apr 27, 2021, 1:12 AM

#

fwiw if you've selected .net core on a new project then versions of .net framework won't show up and you have to either edit the csproj or remake the project in vs

#

(3.5 being a .net framework version)

copper nacelle Apr 27, 2021, 1:40 AM

#

inner peace

ornate rivet Apr 27, 2021, 1:44 AM

#

56 really is shifu

twin gull Apr 27, 2021, 1:52 AM

#

@copper nacelle so that build actually worked. Although it actually didn't work the first time I started hollow knight & appeared to produce the exact same error in Player.log. Just to be sure I deleted Player.log & restarted hk & the controller worked.

I mean, I presume it doesn't actually use Player.log as a cache of config autodiscovery it's tried (it fucking better not anyway)

#

i definitely didn't change anything between the 1st 2 runs other than deleting Player.log

#

unfortunately, if i now try to run the mod installer it overwrites the fixed version i just manually installed with the broken one it auto-downloads; presumably I can still use the mod installer to install debug mod & then re-overwrite the assembly dll

copper nacelle Apr 27, 2021, 1:57 AM

#

yeah that's annoying

#

i could maybe fix that later

#

but yeah you can install and just overwrite again

twin gull Apr 27, 2021, 2:00 AM

#

so i appear to have gotten both debug mod & controller working properly, so that's nice

#

presumably also relevant for macos people who have controller issues

copper nacelle Apr 27, 2021, 2:01 AM

#

yeah

runic wind Apr 27, 2021, 2:02 AM

#

clearly I'm doing something wrong because 3.5 is still missing

#

I'm going through create project -> c# class library -> name and shit, and then I only have the wrong options

#

.net 2.0, .net 2.1, .net core 2.1, .net core 3.1, and .net 5.0

copper nacelle Apr 27, 2021, 2:07 AM

#

that is the wrong type

#

you aren't making a framework lib

#

also idk when this happened for c# because one of my addons was breaking it but it's nice

copper nacelle Apr 27, 2021, 2:08 AM

#

runic wind .net 2.0, .net 2.1, .net core 2.1, .net core 3.1, and .net 5.0

easiest way to fix this is prob just opening the .csproj in an editor and changing netcoreapp3.1 or whatever to net35

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/Assembly-CSharp.csproj#L5 this line

#

but 35 because you're presumably using 1.4.3.2

jolly oriole Apr 27, 2021, 7:01 AM

#

runic wind I'm going through create project -> c# class library -> name and shit, and then ...

there are different class library options for .net core and framework

jolly oriole Apr 27, 2021, 3:19 PM

#

CallMethodProper sux, doesn't want to store fsm variables for me

jolly oriole Apr 27, 2021, 5:46 PM

#

got the inv page working better, idk how the journal doesn't break

vocal spire Apr 27, 2021, 5:57 PM

#

I found out a while ago how it doesn’t break but since I don’t need to again I won’t

jolly oriole Apr 27, 2021, 6:08 PM

#

yo, with your journalHelper, you have it made using instances, but everything else is basically static, why not change it all to static?

runic wind Apr 27, 2021, 8:59 PM

#

Do FSMs get reset? like if I want to change one, do I need to do it only when the game is first loaded or every time a scene is loaded?

copper nacelle Apr 27, 2021, 9:00 PM

#

latter

jolly oriole Apr 27, 2021, 9:23 PM

#

runic wind Do FSMs get reset? like if I want to change one, do I need to do it only when th...

some fsms have a template, so you need to make it first think that it doesn't, then make changes

runic wind Apr 27, 2021, 9:25 PM

#

First off, you will want to include the following HutongGames.PlayMaker, HutongGames.PlayMaker.Actions, and ModCommon.Util.
what does this mean/how do I do it?

jolly oriole Apr 27, 2021, 9:26 PM

#

reference them in your project and then have

using {}

at the top of a .cs file (one using for each namespace)

vocal spire Apr 27, 2021, 9:37 PM

#

jolly oriole yo, with your journalHelper, you have it made using instances, but everything el...

Good idea, will do

#

Making a big update to frog core anyways

runic wind Apr 27, 2021, 10:06 PM

#

how would I get the game object for the Shade? to change its fsm

vocal spire Apr 28, 2021, 2:56 AM

#

runic wind how would I get the game object for the Shade? to change its fsm

probably OnEnemyEnable hook or something like that and check if it's name is a shade name. then modify the fsm

copper nacelle Apr 28, 2021, 2:57 AM

#

SceneManager has a HollowShadeObject

runic wind Apr 28, 2021, 5:32 AM

#

what's causing this error? The other error is "Cannot resolve symbol 'GameObject'". Am I missing a dependency?

#

sorry for being clueless zote

light zodiac Apr 28, 2021, 5:34 AM

#

Right click on it and let it generate a function for you

runic wind Apr 28, 2021, 5:36 AM

#

doesn't help

#

the problem is it doesn't recognize GameObject so it thinks it has the wrong signature

light zodiac Apr 28, 2021, 5:39 AM

#

Did you write GameObject or gameObject

runic wind Apr 28, 2021, 5:39 AM

#

I wrote literally exactly what it wants

#

as well as used the auto generated function

steady comet Apr 28, 2021, 5:45 AM

#

@runic wind you need using UnityEngine; - do you have that?

runic wind Apr 28, 2021, 5:46 AM

#

yeah, but it says it's not being used

steady comet Apr 28, 2021, 5:46 AM

#

Uhh

#

Do you have the right project references?

runic wind Apr 28, 2021, 5:47 AM

#

probably not

steady comet Apr 28, 2021, 5:47 AM

#

As a side note, if you want to mess with FSMs, the way rando does it is to use the On.PlayMakerFSM.OnEnable hook - https://github.com/homothetyhk/HollowKnight.RandomizerMod/blob/master/RandomizerMod3.0/RandomizerMod.cs#L518

runic wind Apr 28, 2021, 5:48 AM

#

I think OnEnemyEnable will work fine

#

what references should I have?

steady comet Apr 28, 2021, 5:48 AM

#

Well there has to be a reference to UnityEngine.dll (I think that's the one?) in the csproj

#

Yeah, UnityEngine.dll

#

I think you can just add references through Visual Studio (if that's the ide you're using?)

runic wind Apr 28, 2021, 5:50 AM

#

using rider because visual studio did not like .NET 3.5

steady comet Apr 28, 2021, 5:51 AM

#

Oh - I assume you can also in rider but I don't know how to

runic wind Apr 28, 2021, 5:51 AM

#

yeah I know how

#

I believe I referenced UnityEngine.dll but I'm trying to find the .csproj to make sure

light zodiac Apr 28, 2021, 5:52 AM

#

screenshot your code

#

nvm I'm blind

runic wind Apr 28, 2021, 5:54 AM

#

yeah UnityEngine.dll is referenced

steady comet Apr 28, 2021, 5:58 AM

#

Does it not recognise the GameObject keyword? What happens if you right click it?

runic wind Apr 28, 2021, 5:58 AM

#

doesn't recognize it

#

top suggestion is to create that type

steady comet Apr 28, 2021, 5:58 AM

#

Huh

#

in VS if I don't have using UnityEngine it just tells me to add it

#

Perhaps someone more experienced than me will have to help :/

light zodiac Apr 28, 2021, 6:00 AM

#

try UnityEngine.GameObject

runic wind Apr 28, 2021, 6:01 AM

#

I still get "Cannot resolve symbol 'GameObject'"

light zodiac Apr 28, 2021, 6:02 AM

#

add refeerence to UnityEngine.CoreModule

runic wind Apr 28, 2021, 6:04 AM

#

that worked!

#

thank you mathulLove

light zodiac Apr 28, 2021, 6:07 AM

#

also, you could try this to make VS work https://windowsreport.com/net-framework-3-5-missing-windows-10/

runic wind Apr 28, 2021, 6:08 AM

#

I'll stick with Rider for now, but thanks

#

I'll take a look if I'm still doing modding stuff when the rider trial runs out

sleek tulip Apr 28, 2021, 12:52 PM

#

So I know nothing about modding or coding in general, but I really want to get into HK modding. I have no idea what I need or how to even start and I was hoping maybe someone could help me.

cedar hemlock Apr 28, 2021, 12:53 PM

#

https://radiance.host/apidocs

vocal spire Apr 28, 2021, 12:53 PM

#

#archived-modding-development you should probably learn the c# language first

The apidocs are really helpful
https://radiance.host/apidocs/

cedar hemlock Apr 28, 2021, 12:53 PM

#

This is modding-dev lol

vocal spire Apr 28, 2021, 12:53 PM

#

Oh

#

lol

#

I’m so used to people asking that in #archived-modding-help

cedar hemlock Apr 28, 2021, 12:54 PM

#

xD

sleek tulip Apr 28, 2021, 12:54 PM

#

Yeah I thought it would be better to ask here

#

One of the questions I have is what you use to make the mods and dlls.

cedar hemlock Apr 28, 2021, 12:59 PM

#

An IDE, such as visual studio in which to code

#

That IDE also makes a dll

#

Also watch the modding tutorial by 56

sleek tulip Apr 28, 2021, 1:00 PM

#

ok thanks

pseudo pond Apr 28, 2021, 1:02 PM

#

c# is pretty easy to pick up, its very similar to java

#

seems pretty intuitive as far as coding languages come

sleek tulip Apr 28, 2021, 1:11 PM

#

If I ever finish some kind of mod where do you post it?

cedar hemlock Apr 28, 2021, 1:12 PM

#

Either pr the modlinks.xml yourself, ask me or someone else to do it or ask for more explanation

sleek tulip Apr 28, 2021, 1:13 PM

#

ok I'll come to that when I get there then

cedar hemlock Apr 28, 2021, 1:13 PM

#

You know what github is?

sleek tulip Apr 28, 2021, 1:13 PM

#

yes

#

I know there are some example mods there that can show you how the code works

cedar hemlock Apr 28, 2021, 1:14 PM

#

https://github.com/ricardosouzag/ModInstaller/blob/master/modlinks.xml

#

Instructions are on top

sleek tulip Apr 28, 2021, 1:14 PM

#

Alright I'll just save the page then

pseudo pond Apr 28, 2021, 2:25 PM

#

would there be any downside to just referencing all of the unity.dll s?

jolly oriole Apr 28, 2021, 2:41 PM

#

The .csproj file is bigger

copper nacelle Apr 28, 2021, 2:42 PM

#

true

light zodiac Apr 28, 2021, 2:45 PM

#

would the .dll be bigger?

jolly oriole Apr 28, 2021, 2:52 PM

#

Maybe, it also contains the references

#

Yea*

#

But that is diminishingly small

deep wave Apr 28, 2021, 2:57 PM

#

iirc resharper has a tool to remove all unused references once you're done

#

but that costs money so niceWeh

jolly oriole Apr 28, 2021, 3:09 PM

#

not if you're a student afaik

pseudo pond Apr 28, 2021, 3:58 PM

#

when implementing ITogglableMod what do i put inside the Unload method

copper nacelle Apr 28, 2021, 3:59 PM

#

Generally you want to unhook what you hooked in Initialize and if you created stuff destroy that

pseudo pond Apr 28, 2021, 3:59 PM

#

got it, thanks

steady comet Apr 28, 2021, 7:53 PM

#

C sharp question, is there a good way to swap two variables? Like

a, b = b, a

in python.

stone elm Apr 28, 2021, 7:57 PM

#

Just tested
(b, a) = (a, b);
and it works

steady comet Apr 28, 2021, 7:57 PM

#

Oh, I didn't realise you need the brackets lmao (I tested without)

#

thanks!

stone elm Apr 28, 2021, 7:58 PM

#

New-ish tuple syntax lets us do fun stuff in C# too

runic wind Apr 29, 2021, 2:58 AM

#

Why is vengefly speed fps dependent?

#

Looking at the fsm, I'm guessing it's something in ChaseObject

#

is acceleration done every frame instead of every physics frame or something?

#

Relatedly, how do I find the code in dnSpy for the methods in fsms?

primal latch Apr 29, 2021, 12:07 PM

#

@runic wind from what I know, playmaker doesn’t use Time.DeltaTime which means that everything scales eitht he amount of frames

jolly oriole Apr 29, 2021, 12:26 PM

#

if i were at home, i could check exactly that

vocal spire Apr 29, 2021, 12:39 PM

#

You can look in playmaker.dll and assembly C sharp.dll in the HutongGames.Playmaker.Actions namespace and some actions are just in the global namespace

steady comet Apr 29, 2021, 1:07 PM

#

(in fact if you're feeling lazy like me you can find the action just by using DNSPY's in-built search feature to search for the name of the action)

pseudo pond Apr 29, 2021, 1:18 PM

#

when changing things in PlayerData can i just use PlayerData.instance.(variable)=(whatever i want)?

steady comet Apr 29, 2021, 1:19 PM

#

You can, but it's considered polite to do it using the SetBool (or SetInt, or whatever it is) method so it goes through the hook for other mods to use

pseudo pond Apr 29, 2021, 1:20 PM

#

what is the correct way to do so?

steady comet Apr 29, 2021, 1:21 PM

#

If it's a bool, then

PlayerData.instance.SetBool(nameof(PlayerData.???), ???)

pseudo pond Apr 29, 2021, 1:21 PM

#

thank you very much!

steady comet Apr 29, 2021, 1:21 PM

#

The nameof(PlayerData.???) is just a compiler thing that means you're less likely to have a typo

pseudo pond Apr 29, 2021, 1:37 PM

#

steady comet The ```nameof(PlayerData.???)``` is just a compiler thing that means you're less...

thank you so much for this, i've been trying to figure this out for like the past 24 hours

#

mostly because im dumb lmao

vocal spire Apr 29, 2021, 2:40 PM

#

steady comet (in fact if you're feeling lazy like me you can find the action just by using DN...

That’s what I do

pseudo pond Apr 29, 2021, 3:33 PM

#

is there a hook for when the player receives a charm notch?

young walrus Apr 29, 2021, 3:35 PM

#

There's a hook for everything

pseudo pond Apr 29, 2021, 3:35 PM

#

is it included in the charmupdate hook?

young walrus Apr 29, 2021, 3:36 PM

#

¯_(ツ)_/¯

#

probably not charmupdate

vocal spire Apr 29, 2021, 3:36 PM

#

pseudo pond is there a hook for when the player receives a charm notch?

You can use SetBool or SetInt hooks

young walrus Apr 29, 2021, 3:36 PM

#

can search through the "On.xxxx" hooks

#

gonna say this just in case, but the list of hooks in the apidocs document is not exhaustive

pseudo pond Apr 29, 2021, 3:41 PM

#

so i could just use the setint hook for PlayerData.charmSlots?

young walrus Apr 29, 2021, 3:42 PM

#

try it

pseudo pond Apr 29, 2021, 3:47 PM

#

uh oh

#

that went poorly

#

game just crashed, think it's because of the way in which i tried to test if it works

vocal spire Apr 29, 2021, 4:23 PM

#

What’s your code

pseudo pond Apr 29, 2021, 4:45 PM

#

/*private void OnSetPlayerIntHook(string intName, int value)
        {
            //Ensures the player can only have a maximum of 3 slots even when aquiring a charm notch
            PlayerData.instance.SetInt(nameof(PlayerData.charmSlots), 3);
        }*/

cedar hemlock Apr 29, 2021, 4:46 PM

#

```
message
```

#

do that

#

not the right ones

pseudo pond Apr 29, 2021, 4:46 PM

#

thank you

copper nacelle Apr 29, 2021, 4:47 PM

#

do not call setint in a setinthook

pseudo pond Apr 29, 2021, 4:47 PM

#

oh

#

makes sense 🤦‍♂️

vocal spire Apr 29, 2021, 4:47 PM

#

Stack overflow lol

#

SetIntInternal?

cedar hemlock Apr 29, 2021, 4:48 PM

#

you can also do cs ater `
```cs
message
```
for colours

pseudo pond Apr 29, 2021, 4:49 PM

#

oh that's cool

#

the more you know

vocal spire Apr 29, 2021, 4:50 PM

#

Color is cool

pseudo pond Apr 29, 2021, 4:50 PM

#

what is the diff between SetIntInternal and SetInt?

vocal spire Apr 29, 2021, 4:51 PM

#

SetInt calls the hooks SetIntInternal doesn’t tmk

pseudo pond Apr 29, 2021, 4:51 PM

#

well that's useful, thank you very much

#

ill see if it works

vocal spire Apr 29, 2021, 4:52 PM

#

So the only place you should really use SetIntInternal is the hook

pseudo pond Apr 29, 2021, 4:52 PM

#

ok

jovial gazelle Apr 29, 2021, 7:16 PM

#

The example mod given on the apidocs is hellmod, is that what I should be using? Seems like it isn't

copper nacelle Apr 29, 2021, 7:17 PM

#

using as what

jolly oriole Apr 29, 2021, 7:18 PM

#

an example probably

jovial gazelle Apr 29, 2021, 7:18 PM

#

An example to learn what the heck i'm supposed to do/so I can work off of it instead of spending a while creating all the files in the right places

copper nacelle Apr 29, 2021, 7:18 PM

#

It's a decent example yeah

jovial gazelle Apr 29, 2021, 7:19 PM

#

Alright

pseudo pond Apr 29, 2021, 7:23 PM

#

jovial gazelle The example mod given on the apidocs is hellmod, is that what I should be using?...

have you watched the video provided?

#

i'd start with that and then go from there using hellmod as an example