#archived-modding-development

1 messages · Page 468 of 1

solemn rivet
#

if you spec a lot into str/dex/luck, you should soon be about 3x as powerful as vanilla knight would be

#

even with the scaling

naive token
#

yeah even with the HP scaling you still were way stronger compared to vanilla

solemn rivet
#

because the scaling for the enemy hp was way slower and capped way sooner than everything else

naive token
#

could just be a separate version of the mod

solemn rivet
#

it is tho

#

it's not official

naive token
#

I mean making both an update with and without scaling

solemn rivet
#

the official one is still borked

#

yeah, we talked about that

heady plank
#

we did indeed

polar sun
#

Well the original mod just with the mask fix is in that zip, my edits to scaling and enemy hp are in a subfolder labeled BonfireEasy

solemn rivet
#

will prolly get around to that, surely not today

#

you can do that if you want to jacob and blitz

#

add a global setting

#

so you can change between easy and hard mode

heady plank
#

Maybe we could use the in-game mod setting menu for it. But i don't know.
In the end, its up to jacob.

naive token
#

enemy HP scaling exponential x2 per level hollowwoke

heady plank
#

but the mod is fixed. According to jacob, the zip file has 2 versions:
Easy - enemies do not scale to your level
Normal- enemies scale to your level

polar sun
#

Easy and normal

#

My version also has different scaling for the damage and extra masks

solemn rivet
heady plank
#

can someone pin jacobs fix?

polar sun
#

"easy" is just the version i made for myself

solemn rivet
#

constant horizontal line is vanilla hp

naive token
#

now we just need the Enemy Randomizer to not be a glitchfest and we have the best mod combination shroompog

solemn rivet
#

X axis is levels

#

the sliders is the amount of levels into each stat

#

the curve describes whether the amount of damage you do is below vanilla or above vanila

#

so with 10 str/dex/luck, all upgrades and all dreamers I should do 120% of vanilla damage

#

so enemies die 20% faster

#

if I do 20 str, 10 dex and 15 luck, I do approx 50% more damage than I would in vanilla

polar sun
#

yeah but that is very situational. My first and only thing i would want to do right off the bat is put EVERYTHING into luck so i can maxamise my geo and get as many upgrades as possible

heady plank
#

thats what i did too

polar sun
#

but that makes enemies REALLY hard to deal with

solemn rivet
#

you don't need more than 15 tbh

polar sun
#

but more then 15 makes geo faster

heady plank
#

more luck = more geos = more levels

#

more levels = more luck

young walrus
#

doesn't level cost go up?

polar sun
#

Yes

naive token
#

I got like 100 Luck last time and the rest of the stats were piss poor lmao

young walrus
#

in which case, you're getting a negative return on investment

#

sure, rate of geo goes up, but the cost also goes up

polar sun
#

Exactly why i need more luck to compensate

young walrus
#

you're fighting a losing battle

polar sun
#

I'm just collecting tons of levels that i will then respec to distribute appropriatly, there's no battle

naive token
#

introducing Enemy Randomizer Nosk which drops 8k Geo

heady plank
#

plus more luck = more crit chance

young walrus
#

hey gradow, get rid of respec-ing

polar sun
#

why?

young walrus
#

make your mod actually punishing

polar sun
#

that makes it less fun

solemn rivet
#

geo increase per luck level is linear

#

5% increase per level

#

and it's also additive, not multiplicative

#

so if an enemy drops 100 geo, 2 luck levels will give you 110 instead of 111

#

level cost increases exponentially

polar sun
#

yeah, eventually you hit a ceiling where it takes so much time to farm for the next level its not worth it anymore

#

thats when you respec

solemn rivet
#

that's not the point

young walrus
#

yeah, so gradow should remove that "loophole"

polar sun
#

eh, i like how it works now

young walrus
#

make people actually spec appropriately

#

lol

solemn rivet
#

I know

#

I'll make the respec cost an arcane egg

#

instead of a rancid one

young walrus
#

that seems more appropriate tbh

#

rancid eggs are everywhere

solemn rivet
#

I know

#

just wanted to make them useful

#

cause they're useless

young walrus
#

tru

polar sun
#

If you wanna just spec appropriately then spec appropriately, wtf do you care about what strangers you've never met doing?

young walrus
#

And I don't care how you get enjoyment out of games

solemn rivet
#

whereas arcane eggs are actually useful by themselves

young walrus
#

I just find it.... interesting

heady plank
#

anyway
respecting does cost racid eggs

#

but with each respec

#

the cost of the rancid eggs goes up

#

so at first, you'll be fine

naive token
#

you can only respec up to 80 times LUL

solemn rivet
#

implying there aren't infinitely many rancid eggs in the game

young walrus
#

^

heady plank
#

-w-

naive token
#

after that the cost is 81

heady plank
#

nevermind then

naive token
#

can't get more Rancid Eggs at once than 80

young walrus
#

you can only hold 88 max

#

or something like that

#

or was it 100

naive token
#

80

young walrus
#

you can get 80 from tuk

#

THEN go get all the map ones

solemn rivet
#

yeah

young walrus
#

that's your max

polar sun
#

80, the vender won't sell you more after 80

naive token
#

101 is the total if you buy 80 from her then get all the others

solemn rivet
#

should be something like 101

#

yeah

#

that's also one of the reasons I stopped caring about this mod

young walrus
#

lol

solemn rivet
#

it's a such a shitfest to optimize

young walrus
#

it was a good starter mod

solemn rivet
#

it was

#

kinda nice proof-of-concept

young walrus
#

yup

solemn rivet
#

it kinda pushed some of the boundaries we had at the time too

#

messing with spells was a first

#

we discovered hitinstances thanks to it too

young walrus
#

you're making me feel old again

solemn rivet
#

tfw you realize we've been playing the same game for 3+ years

#

I mean, you have

#

I stopped playing HK a long time ago

heady plank
#

i just started

solemn rivet
#

ttacco's mod was what brought me back

young walrus
#

I haven't played the game for like 6 months

solemn rivet
#

nice

young walrus
#

ever since end of the rando tournament

#

really

#

gotta practice again though for GDQ submissions

solemn rivet
#

oh

#

you're gonna submit?

young walrus
#

but I'm mostly bored of this game. been playing the shit out of it too long

#

100%

#

AG

solemn rivet
#

nice

#

hope to see you there again

#

I wish I could go to SGDQ this year

heady plank
#

here's a challenge

solemn rivet
#

but I have a conference to attend

heady plank
#

120%

young walrus
#

that's too bad

solemn rivet
#

yeah

young walrus
#

my wife and I are planning to host people at our place

#

since we have 3 spare bedrooms

solemn rivet
#

very cool

polar sun
#

GDQ for me is one of those things that always just happened. I always see new videos for it, It never seems to happen it always just happened and i missed all of it every time

solemn rivet
#

invite 56

young walrus
#

I dont think inviting a minor to my house is a good idea....

solemn rivet
#

it's fine

#

56 is only a minor in physical age anyways

#

Jacob, I watch it live every year

#

not saying that I catch every stream

#

but I'm always checking to see if there's any good games being run

young walrus
#

I go to it live every year

solemn rivet
#

I just happened to catch terraria's stream this year

#

so good

young walrus
#

I think I watched like.... 4 runs this year

solemn rivet
#

bonfire is piss easy

heady plank
#

the difference is one has enemy scaling, the other doesn't

solemn rivet
#

easy bonfire is basically the same

#

with less bugs

young walrus
#

spend all the other time drinking, hanging out with people, playing games, etc etc etc

solemn rivet
#

I mean, that's the whole point right

young walrus
#

when you're there, the stream is like the least important part

solemn rivet
#

yeah

young walrus
#

unless you're running sound of course

#

lol

#

then you care

solemn rivet
#

just a side note

#

I remember back when I first released bonfire

#

people kept complaining that "I was ruining the game" and that "the game was fine as it is"

heady plank
#

and yet here we are

#

helping you fix it

solemn rivet
#

and ever since then, I can't count the amount of people that have tried to play bonfire and complain about the enemy hp scaling

#

it's like

naive token
#

imagine complaining that a fanmade mod ruins the game

#

jeez

solemn rivet
#

it's impossible to please everyone I guess

#

some complain that the mod changes too much, and some complain that it doesn't change enough

heady plank
#

crazy

young walrus
#

you should have made it easier gradow

#

sheesh

#

when the player levels up, the enemies cower in fear, and get weaker

heady plank
#

sounds funny

young walrus
#

if player reaches level 56 or 69, all enemy AI is disabled

heady plank
#

ha

naive token
#

level 57, you're physically invincible

heady plank
#

level 21, enemy ai is stupid, and breaks

#

getting to level 21 is 2 times as expensive, and getting to level 22 is free, as a way to make players not become level 21

nimble lake
#

enemy ai still attack me even though i'm hundreds of levels now

heady plank
#

attacks hollow knight
tink
oh, did you do something? Here, let me show you how its done
leaves, with a blood stain on the wall

nimble lake
#

OMG HOW IS THERE NO MOD OF THAT

#

armor charm or something

#

every attack is useless because it's a tink every time

heady plank
#

that would be an expensive charm.

nimble lake
#

it's ok

#

i'll use the charm notch mod

heady plank
#

ah shit, he figured it out

solemn rivet
#

you can make it ara

#

shouldn't be terribly difficult

nimble lake
#

shouldn't be terribly difficult
said the experienced modder

solemn rivet
#

buddy

#

of all modders here I'm the literal worst

#

0 coding experience

heady plank
#

no no
im the worst here

nimble lake
#

I'm only on 'Section 4: Non-Primitive Types' of the 'C# Tutorial for beginners' by 'Mosh Hamedani' on 'Udemy'

heady plank
#

thats great......i haven't started.........
sad violin

solemn rivet
#

@young walrus where did you learn it again

#

^

nimble lake
#

Also I'm kinda stuck because I'm in a confusing part

heady plank
#

also, wouldn't the tink charm (yes im calling it that) need a custom sprite?

nimble lake
#

Would it even be possible to make hitting the Knight tinking? Is there even a "class" to that or whatever these kids call it today?

#

I'll draw it

heady plank
#

i was thinking you could use the sound effect that plays when hitting spike, and set it up so that when they go tink, it plays that

nimble lake
#

well yea exactly

solemn rivet
#

there are a couple of ways I can see it being done

#

for one, you could look at the baldur shell code

heady plank
#

such a handy charm that is

solemn rivet
#

I'm 99% sure that's for enemies/interactibles sfg

#

like walls, spikes and shields

#

but yeah

#

I'd check baldur shell

#

see what it does and how it does it

#

and adapt that to achieve what you want

nimble lake
#

How can you look into the code of actual charms? fsmview?

solemn rivet
#

yeah

#

most of them are fsm

heady plank
#

well then.

solemn rivet
#

check the knight's fsm

#

I have no idea

#

you can use angle's PrintSceneHierarchyTree to find it

#

wait, what does stalwart do again

nimble lake
#

more iframes i think

solemn rivet
#

ic

heady plank
#

try looking for Propede shell

#

as thats what it was going to be originally called

solemn rivet
#

so yeah, it's baldur we're looking for

#

could be blitz

nimble lake
#

That's for thorns of agony i believe

solemn rivet
#

lemme download the fsmviewer

fair rampart
#

It prob isnt called baldur

nimble lake
#

What does the Knight's fsm called?

fair rampart
#

I think it has multiple fsms

solemn rivet
#

it's 100% not in code

#

found it

#

blocker charm

heady plank
#

ooo

solemn rivet
#

wait no

#

scratch that

nimble lake
#

Isn't blocker dreamshield?

solemn rivet
#

found it

#

Blocker Shield-Control

nimble lake
#

oh nvm then

solemn rivet
heady plank
#

you are right

#

this is spaghetti

solemn rivet
#

this one is pretty simple

heady plank
#

it is, i can understand it, but its still.......a mess

solemn rivet
#

does it even tink at all when using the baldur shell?

#

I never used it, so idk

heady plank
#

i can check

young walrus
#

I still haven't even learned coding properly

#

just stumbling through things

#

until they work

solemn rivet
#

meirl

young walrus
#

honestly, most of my frustration with coding hasn't been the coding itself

#

it's been the fucking game

solemn rivet
#

this is what it does in a nutshell

nimble lake
young walrus
#

trying to reverse engineer everything the game does without any visibility

solemn rivet
#

if you have < 3 blocks you run that and decrease the block counter

#

yeah mick

#

the worst thing is trying to do something in the code

#

but it's not working

young walrus
#

it's why I haven't finished my mod yet

solemn rivet
#

because there's thousands of hidden events and states hiding underneath

young walrus
#

and life gets busy

#

just need to complete one boss exchange

#

then the rest will be easy

heady plank
#

can confirm the shell makes no tink noise

young walrus
#

and I'm 95% of the way there

#

just take the tink noise from spikes

heady plank
#

hey thats what i said

young walrus
#

or enemy baldurs curled up

#

or husk sentry shields

#

and you could just apply that state to the player character when wearing the charm

#

with a random chance for it to activate or something

nimble lake
#

i'm going to set it to 100

young walrus
#

that's almost a hundred

heady plank
#

200

nimble lake
#

yea

#

give it a chance to activate and you got glorified melody

solemn rivet
#

ok

#

do we know if the knight uses the HealthManager or if it has its own healthmanager?

fair rampart
#

probably its own

solemn rivet
#

Oh

#

We can just

#

Copy debug's invulnerability

#

And add the tink

heady plank
#

FUCKING

young walrus
#

but you wouldn't want the knockback

heady plank
#

GENIUS

solemn rivet
#

Yeah

#

But that's a good first step I guess

young walrus
#

and by invuln you mean infinite hp yeah?

heady plank
#

there is no knockback from debugs invincible mode

solemn rivet
#

Yeah

young walrus
#

but there is in infinite hp

#

it just constantly keeps hp at full

#

so, maybe not the best to copy

heady plank
#

hmmmm

young walrus
#

but you can grab what causes dmg to happen anyways

solemn rivet
#

Do it blitz

#

You can do it

young walrus
#

HeroController.TakeHit

#

or something like that

solemn rivet
#

Yup

young walrus
#

it'll be in the HeroController class anyways

#

so you can use that

heady plank
#

this is tricky

nimble lake
#

I mean, you should be getting knocked back when getting hit

#

unless you'll wear that charm that doesn't let you get knocked back

heady plank
#

well
i suppose what you can do
is make something similiar to infinite hp, where enemies hit you, you dont take damage, it uses the noise from spikes, and have knockback when getting hit, but dont play the animation from taking damage, so you could use the information for when you hit a wall, and it pushes you back

#

and simply apply it to hollow knight whenever hes wearing the tink charm

nimble lake
#

btw is it even easy to create new charms entirely?
I've seen some new charms in the 5 knights mod, but that's the only time I saw that

heady plank
#

i think i saw some in light bringer mod

nimble lake
#

just replace some useless charms that no one uses

#

i know i'm joking

solemn rivet
#

Do it anyway

heady plank
#

2 versions of it
replaces
standalone

young walrus
#

replace the compass

#

or gathering swarm

#

the two most useless charms

heady plank
#

b-but i use them
;w;
did i make bad choices?

fair rampart
#

Honestly idek how our custom charms work

#

And they don't work entirely yet

fair rampart
#

this is such a cool game to mod

solemn rivet
#

tell me again how to make a mod with global settings

young walrus
#

you ask nicely

grizzled steppe
#

I hope it's that easy

solemn rivet
#

do it

#

or else

#

cracks knuckle

#

@copper nacelle I'm stealing QOL

copper nacelle
#

ok buddy

#

you just add the property override

solemn rivet
#

yeah

#

so what I'm doing is

#

I create a Settings class

#

with the things I wanna save

#

and I override ModSettings in the main file

#

is that it?

copper nacelle
#

yes

solemn rivet
#

ok

#

last question

#

does Setting need to inherit from ISerializationCallbackReceiver?

copper nacelle
#

no

#

That's just for my custom serializing

solemn rivet
copper nacelle
#

stop being static idiot

solemn rivet
#

it's not

#

unless monobehaviours are static

copper nacelle
#

pepo

#

global settings

#

isn't a static field

#

you are trying to access it staticly

solemn rivet
#

wait

copper nacelle
#

Make an instance variable or something

solemn rivet
#

ffs really

solemn rivet
#

56

#

whytf won't rider let me choose other frameworks aside from 4.7.2

#

even though I have them installed

copper nacelle
#

just edit the csproj

solemn rivet
#

halp

#

it no work

#

I know I'm doing a big dumb

#

but I have no idea how to do this

copper nacelle
#

make your private _globalSettings into an internal property

#

and then just access the field

solemn rivet
copper nacelle
#

any privaten't

#

It doesn't serialize private fields

solemn rivet
heady plank
#

oh dear

#

is it really not working?

#

it works fine for me right out of the box

copper nacelle
#

that's right though

#

why is it cursed

#

The dictionaries are ugly

heady plank
#

hmmm

#

i dont know

solemn rivet
#

ok

copper nacelle
#

gradow why is it cursed

#

i lack the information

solemn rivet
#

dics are cute

solemn rivet
#

I mean

#

I'm not wrong

#

ok, so

#

and yet it's logging all zeroes

#

what do

heady plank
#

should i send you my copy?

solemn rivet
#

of what?

heady plank
#

of the enemy hp mod thing, since i assume thats what you are looking at

solemn rivet
#

I'm reworking the enemyhpbar

#

to make it so you can scale the hpbars

heady plank
#

oooo

solemn rivet
#

I don't get it

#

why can't I access those floats

#

that's why it's returning 0

copper nacelle
#

cease getfloat

#

please

#

i beseech thee

solemn rivet
#

what do then

#

I cannot access it directly

copper nacelle
#

any internal field on the mod

solemn rivet
#

and it's not in the dict so I cannot key/value it

#

any what

copper nacelle
#

any internal field on the mod

#

make the private global settings that's of the actual right type internal instead

solemn rivet
#

I understand some of the words you just said

heady plank
#

well, jacob knows something of the enemy hp mod, as he was able to comment out a section of your mod to make it work with the hp mod

solemn rivet
#

you do realize that hpbars is also mine, right?

copper nacelle
#

i do not think also belongs in this sentence

#

it is yours

solemn rivet
#

I mean

#

in addition to bonfire

copper nacelle
#

ah

#

and the private _globalSettings

#

could just be internal _globalSettings

#

and then you could access it from the instance within the assembly

#

and not have any issues

solemn rivet
#

I still don't understand how this works

#

first, why do I need to override ModSettings

copper nacelle
#

because you are casting to ModSettings for the field

solemn rivet
#

am I though?

#

I have no idea what I'm doing

#

I literally copypasted your QOL

heady plank
#

mind blown

solemn rivet
#

public class InfiniteGrimm : Mod<InfiniteSettings, InfiniteGlobalSettings> why can't I do it like this?

#

like IG does

copper nacelle
#

because that is deprecated

solemn rivet
#

ffs

young walrus
#

lol

solemn rivet
#
        public override ModSettings GlobalSettings
        {
            get => _globalSettings;
            set => _globalSettings = (Settings) value;
        }
        
        internal Settings _globalSettings = new Settings();```
#

eli5

copper nacelle
#

override the property GlobalSettings so it gets serialized by the API

solemn rivet
#

I'm setting _globalSettings to a new instance of Settings

copper nacelle
#

have its get method be the same as getting _globalSettings

#

and have its set be the same as setting _globalsettings, but because it's a ModSettings, cast it to a Settings because we know our settings are of class Settings

solemn rivet
#

that's what I currently have, yea

copper nacelle
#

_globalSettings is just a field

solemn rivet
#

yeah

#

ok

copper nacelle
#

just change the GetFloat shit to _globalSettings.whatever

solemn rivet
#

why can't I use GlobalSettings instead

#

that's what I don't get

copper nacelle
#

because it is ModSettings

#

I mean you can

#

just cast it

solemn rivet
#

(Settings)GlobalSettings?

copper nacelle
#

((Settings) HPBars.instance.GloablSettings).whatever

solemn rivet
#

yeah

#

ok

#

I just don't understand why we need to set the setters and getters manually

#

which means I don't fully understand what's going on here

young walrus
#

Naisu

heady plank
#

wow

solemn rivet
#

just fyi I got hit because I was busy trying to press the screenshot keys

#

anyone care to try it for me?

#

imma grab some food rq

heady plank
#

hahahaha

#

sure

#

i can give it a test run

#

Think of me as the tester

solemn rivet
#

did it work?

heady plank
#

you didnt send it

solemn rivet
#

just

#

get it from the installer

#

as soon as you load up the installer it should auto download it

heady plank
#

ok

#

what exactly am i looking for?

solemn rivet
#

load the game once, then close it

#

go to your saves folder

#

open the enemyhpbars config file

#

edit the float values

#

fg, bg, mg and ol are the hpbar

#

bossfg, bossbg and bossol are the boss hpbar

#

those numbers determine the scaling of the hpbars

#

so setting it to like 2.0 would make it double in size

#

do whatever changes please you, save the changes and close the config file

#

load the game and see if it worked

heady plank
#

yeah

#

it worked

#

i simply made it bigger

solemn rivet
#

nice

#

this is meant to help artists

#

so they can make the hpbar art as big as they want

heady plank
#

and scale it

solemn rivet
#

and then just scale it down to fit within the game

#

instead of manually scaling each file

heady plank
#

any mods you recommend? like, must haves?

solemn rivet
#

qol

#

but since you're on your first playthrough, that's all

heady plank
#

what about the unofficial patch?

solemn rivet
#

sucks

#

never actually use it

heady plank
#

ok then

#

there was 2 other mods i wanted to try, but they seem to be broken
redwing, and according to you, blackmoth

solemn rivet
#

nooo

#

they're not broken

#

they're "broken"

copper nacelle
#

arguable

solemn rivet
#

shush 56

heady plank
#

redwing gives me infinite soul

#

im sure that is broken

copper nacelle
#

intended

solemn rivet
#

that's intended

heady plank
#

oh

#

hmm

#

looks like i'll be adding those back then

solemn rivet
#

don't

#

ffs

#

or do

#

I'm not your mum

heady plank
#

its fine
ill leave them for my 2nd run

#

ill be playing with these mods
Bonfire Fixed
Charm not and overhaul
Custom knight, so i can play as little hornet
Enemy hp bar
Fragile strength for nail arts
Grimchild upgrades
and QoL

#

um

#

@solemn rivet

solemn rivet
#

I don't see anything wrong

heady plank
#

the health bars aren't going away

solemn rivet
#

that's a lie

heady plank
#

pretty sure its dead

young walrus
#

it's pretending

solemn rivet
#

it's just pretending

#

ye

#

don't be fooled

#

or it'll bite ya

heady plank
#

no way its pretending, it exploded

solemn rivet
#

I do that when I'm pretending

#

idk about u

heady plank
#

you're weird

solemn rivet
#

u buddy

heady plank
#

yeah, its like this on a new save

polar sun
#

Are you using a version of Bonfire with the
if (hm.hp <= 5)
{
hm.hp = 1;
}
code? Because that's what does that, that's why thats bad code, it makes no difference to gameplay and it breaks the hp bar mod

#

I just realised i left it in in the original fixed version, i'm going to comment that out and recompile

#

There ya go, Masks fixed AND it's now compatible with the EnemyHPBar mod, which i consider a necessity in any playthrough, even a first one, it's that good imo

heady plank
#

hp bars is good, and looks nice

fair rampart
#

hp bars is absolute pog

naive token
#

wait wait

#

HP Bar mod ALSO fixed now?

solemn rivet
#

long time ago buddy

#

it also supports customization now

naive token
#

insane

#

how many mods have you guys fixed already

young walrus
#

yes

naive token
#

and are they/will they be on the installer

solemn rivet
#

wdym

naive token
#

which mods have you guys fixed and will the mod installer have the fixed versions

young walrus
#

yes

#

the installer gets updated regularly to grab the new versions

solemn rivet
#

just hpbars as far as I'm aware

#

saleh "fixed" pale champion

#

"fixed" because it was an old fix, but he had forgotten to push it

naive token
#

so HP Bars no longer destroys your game and Bonfire actually gives Masks

#

also I imagine if HP Bars no longer has the memory leak it won't make the game play at 1 FPS with the Enemy Randomizer

solemn rivet
#

what

#

the "memory leak" in HP Bars (I put that on quotes because I've never seen it happen) only supposedly happened if you played for long periods of time

naive token
#

the broken HP Bar mod combined with the Enemy Randomizer absolutely annihilated performance

#

even after just starting the game up

solemn rivet
#

that is absolutely weird

#

but then again, enemy rando is weird by definition

heady plank
#

i dont use randomizers, and from what i can tell, hp bar works fine

young walrus
#

enemy rando is.... shaky at best

#

it functions, but definitely not as intended

#

at least it doesn't get stuck loading anymore

naive token
#

I can confirm that the HP Bar mod causes slow downs over time

solemn rivet
#

one person confirming literally means nothing tho

#

because it could just be a local issue

#

and most people I asked never had an issue with the mod

#

granted, we never play for long periods of time at once

#

anyway

#

we have identified what could theoretically cause the issue

#

and have fixed it

#

but have been so far unable to test it

heady plank
#

also, the installer doesn't have the fixed version of bonfire. everytime i launch it, i get a notification to update it. when i do, it takes me back to the broken version

solemn rivet
#

because, as I said, no one that I asked had previously experienced the issue

#

so it's hard to compare

#

yeah, Blitz

#

because it's not the official version

#

I could add it as an alternative version

#

but it'd be a separate mod altogether

naive token
#

I didn't even know about the memory leak until I asked some miscellaneous question about it and someone mod staff told me it was broken

heady plank
#

ok...then why not just implement it? just implement the version with the fixes, and later, add the one that doesn't have the enemy scaling.

solemn rivet
#

yeah, idk how that started circulating vorgozz

naive token
#

because it happens?

solemn rivet
#

never seen it

#

or talked to someone who can show me it happening

#

which fixes Blitz?

heady plank
#

the one where jacob fixed the broken extra masks thing

solemn rivet
#

oh yeah

#

@polar sun can you send me a pr?

naive token
#

I can probably show it since not only I get slow downs over time but the game freezes for a few frames whenever I kill an non-boss enemy

heady plank
#

pr?

solemn rivet
#

pull request

heady plank
#

oh

polar sun
#

I uh, I'm not sure what a pull request is

solemn rivet
#

it's when you push your local version of a cloned repo and ask for it to be pulled into the main branch

#

i.e. when you ask github to merge your changes to the main code

#

and then I, the code owner, must accept it

#

but it'll be credited to you

polar sun
#

Oh, I have no idea how to do any of that

polar sun
#

I also just fixed another mistake i made in the default version

heady plank
#

oh?

polar sun
#

I forgot to make respec costs increase again in the default version

#

@solemn rivet what exactly do u want me to do?

heady plank
#

this jacob

solemn rivet
#

it'll create a copy of the repo for your own github acc

#

push your changes to that copy

polar sun
#

It's complaining about them both having the name "master"

#

i dont see anywhere i can change that name, i just see the name in the branch dropdown

solemn rivet
polar sun
solemn rivet
#

change the base and master

#

put mine as base and yours as master

polar sun
#

I only have a single choice on either one

#

that's to say i don't have a choice

solemn rivet
#

oh

#

I think you're supposed to do that on your own page

#

anyways, I went and did it

polar sun
#

oh you already did it? ok

#

Fixed Extra Masks and compatibility with EnemyHPBar mod

#

I mean, YOU fixed extra masks

#

I'm just the one who physically typed and copied and compiled and tested

#

your the one who actually did everything

heady plank
#

You both fixed it
im just the guy who got someone interested in hollow knight again

polar sun
solemn rivet
#

Who did you get interested in hk again?

heady plank
#

Jacob

solemn rivet
#

Were they uninterested before?

polar sun
#

They were

#

But i was briefly not :p

solemn rivet
#

Bruh moment

gilded lotus
#

organ?

heady plank
#

ooo

#

they look nice

gilded lotus
#

it's good, if you think it fits the theme you are setting, go for it

fair rampart
#

maybe instead of 4 "horns" try having like 20 ?

gilded lotus
#

in my armchair developer opinion if you are going with the 4 there it would be important to keep it close asthetically to the 4 spikes as seen in the seal

fair rampart
#

I mean it's an organ you can setup the pipes almost any way you want, as long as it looks like organ pipes it'll work

#

bro the PK can play the organ? dope

gilded lotus
#

I think it's important to keep an aesthetic particular to an area consistent

fair rampart
#

tbh I don't get organ vibes from the WP, but maybe that's just me

gilded lotus
#

i could see you going for a "root" vibe tho

unborn badger
#

oh shit sf that looks sick

young walrus
#
  1. But having the hole visible on all 4 would be better imo
#

what do you mean

#

oh gotcha

#

in that case, i'd change my vote to 1. to be the most believable, the "horns" should be facing the camera though. the sound going off to the sides (or up) is usually not proper organ design. Plus the pipes should also have a slot in each of them towards the bottom

#

but I digress

polar sun
#

Its hard to decide which is better

ornate rivet
#

Dang Mick is an organ pro

gilded lotus
#

I didnt know Mick was a surgeon

fair rampart
#

proper organ design is having the pipes go straight up
but this is a stylish organ

young walrus
#

Horns on organs face out

#

Pipes go straight up

fair rampart
#

where do you see horns in this picture

young walrus
#

right in the middle

#

in this case, the 4 horns on the stylish organ would still face outwards. sound from those types of instruments always goes out the end, so you want that to travel toward the listener

#

not bounce off walls and go in weird directions

fair rampart
#

it's weird I've never seen horns on an organ

young walrus
#

i grew up with a grandma who played a 3 million dollar organ

fair rampart
#

I guess they correspond to the foot pedals ?

young walrus
#

foot pedals are usually bass

#

so the huge pipes

fair rampart
#

so what are the horns for then

young walrus
#

a different sound

#

usually very high in pitch

#

they sound more like trumpets

fair rampart
#

yes

young walrus
#

you select the sounds you want by pulling out the tabs

#

and some even have pipes hidden behind shutters

#

to make much quieter sounds

fair rampart
#

I played on an organ once 😃 It sounds just like a trumpet for sure

young walrus
#

this is the one she played on

#

the shutters are in the middle there

solemn rivet
#

@copper nacelle

#

halp

heady plank
#

so, i just got a powerA ps3 controller....and hollow knight isn't detecting it

#

anyway to fix this?

unborn badger
#

are you using windows 7

heady plank
#

win 10

solemn rivet
#

don't dualshock controllers require some software

heady plank
#

i checked, nothing needs updating

#

even tested it out on minecraft, and that works fine

unborn badger
#

although steam should pick the controller up automatically

heady plank
#

GOG

unborn badger
#

oh

heady plank
#

doesn't look like its working

#

yeah, its not working

unborn badger
#

do you have steam installed? if so you could add the GoG version as a non-steam game and use steam's built in controller support

heady plank
#

i do

#

let me see

#

that did it

#

just hope my saves arent gone

#

Many thanks, it works, and my saves arent gone

heady plank
#

new problem

#

if i launch hollow knight via steam, my mods dont work

#

so back to square 1

unborn badger
#

what do you mean by "don't work"

#

does the game crash?

heady plank
#

no

#

the mods just dont load in

#

how does hollow knight detect controllers?

solemn rivet
#

check your steam hk files

heady plank
#

my what

rain cedar
#

your steam hk files

heady plank
#

i have the gog version of the game

solemn rivet
#

sounds like you have two installs

heady plank
#

ching said to add it to steam via the add non steam game option

solemn rivet
#

right click the game on steam, properties, local files, browse local files

heady plank
unborn badger
#

my only idea is that adding it to steam might've messed with the installation path somehow

heady plank
#

when i launch it outside of steam, the mods load in, but i cant use my controller

solemn rivet
#

does it show the mods on top left?

heady plank
#

when i launch it via steam, i can use my controller, but the mods dont load up

solemn rivet
#

also, don't point it to the shortcut

#

point it to the actual exe

unborn badger
#

yeah

heady plank
#

figured it out

#

was using the vanilla clean install of hollow knight, instead of the modded one

#

there it goes. now i have both. Many thanks

unborn badger
#

i wish discord had an on screen send button

#

my keyboard is like a foot away from me and hitting enter is effort

heady plank
#

oof

solemn rivet
#

done, bonfire is updated

heady plank
#

yay

lilac field
#

hhhhh

solemn rivet
#

looking good!

heady plank
#

nice

hasty dew
#

i'm bad

solemn rivet
#

if you say so

solemn basin
#

Hornet is growing up so fast.

hasty fractal
#

Nice!

#

I think that the next Custom Knight I’m going to make will be Lost Kin. (sorry for my English)

solemn rivet
#

nothing wrong with your english

heady plank
#

That be an interesting knight

solemn rivet
#

something's wrong with your english

heady plank
#

it happens. i sometimes type too fast, or mistime a space

hasty fractal
#

I’m French, I can make mistakes sometimes.

solemn rivet
#

non-french people are also allowed to make mistakes

#

myself included

flat forum
#

56 specifically alone is not allowed to make mistakes

#

at all

#

under any circumstances

#

56 is required to be perfect by law

copper nacelle
solemn basin
#

Just define perfection as whatever 56 does and it's an easy standard to adhere to.

rain cedar
#

Yeah you right eating too many pills is pretty perfect

gilded lotus
#

vitamins are pills and i wanna be buff like 56

solemn basin
#

Dr. Mario taught me continuously popping pills is the best medical solution to things.

fair rampart
#

the binding of isaac taught me eating one pill of every kind is the smartest move

ornate rivet
#

I'm trying to spawn the trap plants in greenpath but once I kill one that I've spawned, the rest are made inactive the moment they spawn

ornate rivet
#

here's its hierarchy

ornate rivet
#

yall suck

#

I figured it out

#

Kill PersistentBoolItem

urban onyx
#

how do you download hollow point

unborn badger
#

pins

urban onyx
#

cool thx

urban onyx
#

is there any multiplayer mods?

ornate rivet
#

no

urban onyx
#

ok 😦

#

tbh i wanted to mix the hollow point mod and any multiplayer mods

solemn rivet
#

Since there aren't any, by playing hollow point you're already mixing them

urban onyx
#

k

restive valve
#

i'm not an expert but wouldnt a multiplayer mod require rewriting the game

rain cedar
#

Pretty close to it yeah

flat forum
#

^

ornate rivet
#

^

jovial vault
#

most tragic

solemn rivet
#

damn

#

she thicc

fair rampart
#

I'm trying to build the modding API but I'm getting

Error NU1605 Detected package downgrade: MonoMod from 20.2.1.1 to 19.9.1.6. Reference the package directly from the project to select a different version.
The weird part is that NuGet installed 19.9.1.6, so I don't get where the error is coming from ?

young walrus
#

why are you trying to build the API?

copper nacelle
#

the issue is the 19.9.1.6

#

You should have 20.2.1.1 is what it's saying

fair rampart
#

why are you trying to build the API?
easier to tinker around if the API doesn't have the hooks I need

copper nacelle
#

bro

#

any On.

#

or IL. for that matter

fair rampart
#

On ? IL ?

copper nacelle
#

MonoMod runtime detour hooks

#

On.Namespace.Class.Method += Hook for basically a normal hook

#

and IL.Namespace.Class.Method += Hook for an "IL" hook, for modifying the Intermediate Language (IL) of the method

fair rampart
#

thanks

rain cedar
copper nacelle
#

Does that work?

rain cedar
#

yes

#

Visual studio is smart enough

#

I'll change the variable name anyway though

copper nacelle
#

I would've expected it to like die at runtime

rain cedar
#

Why?

copper nacelle
#

like expand get as ((... ?? new Settings) ?? new Settings) ?? new Settings

rain cedar
#

Oh this isn't in the property Settings

copper nacelle
#

Ah

rain cedar
#

Checks for > 3, removes 7

copper nacelle
#

Idk I copy pasted it from 753's stuff

rain cedar
#

Alright I'm gonna change it

#

Maybe some day I'll actually fix that

#

But not today

#

I love floats

copper nacelle
#

merged

#

merge the api prs when

ornate rivet
#

halp

#

On.AudioManager.ApplyMusicCue += AudioManager_ApplyMusicCue;

#

it stops working after the player dies once

#

music and everything continues to work just fine but the hook doesn't do anything

#
private void OnDestroy()
{
  On.AudioManager.ApplyMusicCue -= AudioManager_ApplyMusicCue;
}
#

I know the OnDestroy works because I logged it

rain cedar
#

Do I merge the ones from people I don't know?

#

Ok this blue health one sure

#

The other one is effort to look at

copper nacelle
#

the Linux one is good

#

@ornate rivet what

#

The on death issue is gone

#

Blessed day

ornate rivet
#

what

#

AudioManager_ApplyMusicCue stops running once the player dies

copper nacelle
#

what player

#

where is this ondestroy

ornate rivet
#

Both the OnDestroy and the hook are part of a monobehaviour connected to the gamemanager.
When the player enters scene X, I add the monobehaviour to the gamemanager and when the player leaves (eg dies), I destroy the monobehaviour.

rain cedar
#

So the hook stops working after the behaviour is destroyed?

#

This sounds like the correct thing to happen

copper nacelle
compact sedge
#

technically the correct thing to happen is basically always the thing that happens given any code

rain cedar
copper nacelle
#

ub

ornate rivet
#

no, the monobehaviour is added again once the player enters the scene again

#

did you not read "When the player enters scene X"

solemn rivet
#

But isn't that a new instance of that mono behaviour?

ornate rivet
#

yes

#

a new hook is made

solemn rivet
#

How do you know the hook stops working then

#

Also, just to make sure, are you certain you're calling orig?

ornate rivet
#

yes

#

When I enter the scene and WD theme starts playing, shouldn't it apply the music cue

#

It does the very first time

ornate rivet
#

damnation

rose bay
#

how do i get the AK47 mod?

ornate rivet
#

pins

#

Hollow_Point

flat forum
#

hm?

ornate rivet
#

epic

#

gimme code pls

unborn badger
#

👀

#

is this great knight fight

#

ah

ornate rivet
#

yea sure

#

Wait, Grenade, it's actually going to be a giant Wyrm fight?

#

I thought it was a platforming section, or is it both?

ornate rivet
#

How do you hook a method that's an IEnumerator

copper nacelle
#

what

#

the same as any other method

ornate rivet
#

it doesn't work

glossy solar
#

My dreamer is missing

#

Lurien

copper nacelle
#

what does it doesn't work mean

#

this is not descriptive

glossy solar
#

Bruh I mean Lurien isn’t showing up in my steel soul run

gilded lotus
#

This is modding-development. 56 is talking to Saleh. If you want actual help. Also read Homothetys mod support message in modding help about how to ask for help. “My dreamer is missing” doesn’t mean anything to us lol

ornate rivet
#

lol

copper nacelle
#

will Saleh ever answer what it doesn't work means

ornate rivet
#

just ignore it 56

#

Saleh's kinda dumb ngl

solemn rivet
#

saleh

gilded lotus
#

Isn’t the cap for mods like 20MB anyway or was that removed. For the launcher that is

solemn rivet
#

no, you can have them as big as you want them to

#

the one capping the downloads is google

#

but if you host them elsewhere, it's fine

#

that's how redwing assets does it

gilded lotus
#

Ah

ornate rivet
copper nacelle
#

very nice

#

Ok Grimm on mobile is cursed

shy cloak
#

Okay so I know that once-upon-a-time I used a tool to compare two versions of the Assembly-CSharp.dll file, like WinMerge but for assemblies. Anyone know of anything like this?

copper nacelle
#

JustAssembly

#

is what i use

shy cloak
#

bah. i'm sure it was something else. but thank you! I'll use that for now. 🙂

#

the "GIVE US YOUR EMAIL" is really offputting and I normally don't put up with that

copper nacelle
#

Yeah the signup is annoying

#

I couldn't find anything better though unfortunately

gilded lotus
nimble lake
#

the floor is deep docks?

ornate rivet
#

post it on modinstaller smh

fair rampart
#

how are scene transitions handled ?

solemn rivet
#

Badly

rain cedar
#

Is this like an old windows thing?

rain cedar
#

Pretty sure it's a windows 7 only error so no way I can actually reproduce it

chilly phoenix
#

How would I detect if a player is fighting a boss, would I use OnEnableEnemyHook?

rain cedar
#

Checking current scene, then searching for the boss object is probably the only reliable way to do it

#

Or search for any enemy with > some amount of hp (200?) if you're feeling lazy

#

That looks to be exactly what the hp bar mod does

#

hp >= 200

chilly phoenix
#

Question that may contain spoilers
||I want to edit the hollow knight boss if I were to check SceneChanged what would be the SceneName I would put to detect the arena?||

rain cedar
#

You don't have to spoiler tag things here

#

I think it's Room_Final_Boss_Core

#

Something like that

#

You can check pretty easily with debug mod

chilly phoenix
#

Ok I'll install the debug mod, but how would I check the rooms or boss string names with it?

rain cedar
#

It shows the current scene on the left side

#

For object names I generally use the fsm viewer, anything that matters tends to have an fsm on it

#

Otherwise there's a scene dump zip on the mods drive folder somewhere, but it's a bit outdated

chilly phoenix
#

Alright.

flat forum
#

@rain cedar I have windows 7 zote

compact sedge
#

I’m sorry for your loss

flat forum
#

for my :.|:;?

fair rampart
#

wth

#

I can't believe people still come up with new loss memes

glad pine
#

just as dead as the pale king

#

this discussion

unborn badger
#

local man shaken to core upon seeing chat that’s not being spammed with shitty memes 24/7

solemn rivet
cloud latch
#

I've been getting a lot of help from all the stuff you guys have been providing and documenting

#

But .:|:; is probably the best thing I have learned so far

solemn rivet
#

this man understands the true nature of modding

cloud latch
#

I've been trying to find the value of JUMP_SPEED in the HeroControler, and I spend a bit too much time trying to pin down when or where it gets assigned a value

#

Now while part of me still wants to know the where when and how

#

Im figuring I can just have the game output the value at runtime

#

which is the What I was looking for

gilded lotus
#

idk why it's not just a rounded value

cloud latch
#

Yeah also in the process of just setting up these tools

#

because its obvious i've been doing work that's already been done for me

#

Probably buy a boost for the server at some point as appreciation

#

Yes, but it has the variable JUMP_SPEED, and I was trying to see where that variable got assigned a value

#

It's not in user1.data, those hero variables, they clearly are set for different heroes, since the code indicates that zote and hornet are considered heros for some reason, perhaps planned to be playable (Zote DLC confirmed?!>!)

#

We were not dedicated enough

#

I only got dragged into this game because a friend went full on about it, so I missed out on so much fun

#

I'm guessing they have a generic hero

#

a hollow knight, if you will

#

and wanted to quickly modify aspects it by changing its speed in game stats

#

Well this has been most productive, I shall probably return at some point, to shitpost in an on-topic manner

#

I've been reading most of it for the last couple of days, since I kind of want to to do "fanart" a trace of the game as a separate unity project, new character, levels, enemies and bosses

#

That is why the jump speed is so important to me

#

because it's so important to the feeling of the game

#

goodnight!

rain cedar
#

flower game v2

solemn rivet
#

shhh

cloud latch
#

Oh it's not going to be a full game

#

I'm nowhere near that ambitious

#

It's why I'm using terms like fan art and tracing

#

4 enemies, a boss a character with a different moveset
No progression, no saves, menus, music, or lots of other things that make it a game

cloud latch
#

Ctrl+F: HeroController Public Default Values

cloud latch
#

Searching this chat can be nice to find things that have already been answered