archived-modding-development

[ornate rivet]

is this twitter now

[rain cedar]

I've never seen this tenor thing in my life

It looks like garbage if this is the kinda content on there

[hollow pier]

nitro

[copper nacelle]

I just know it has a discord command

It's pretty shit

[ornate rivet]

https://tenor.com/XJ66.gif

anorexic grimm

[rain cedar]

I can count the frames in that

[ornate rivet]

same

[hollow pier]

sean wtf

[rain cedar]

what

[hollow pier]

twitch lies again

[tranquil glen]

[copper nacelle]

[hollow pier]

[rain cedar]

Is that a fucking nitro lettuce?

[hollow pier]

[rain cedar]

You've stolen from me

[hollow pier]

[rain cedar]

I can't believe this

[hollow pier]

i'll steal your rekkies too dw

[rain cedar]

5 days

[hollow pier]

[copper nacelle]

Why is it so pixelated

[hollow pier]

i don't even know what server i'm on that has it

so ask them

how's this

[rain cedar]

Why does this chest full of chickens kill my game?

Does this mod like calculate the sprite from a 3d model every frame or some shit?

[hollow pier]

i can't believe sean is playing 3d terraria without me

[rain cedar]

We can play 3d terraria together if you want

[hollow pier]

i don't even have it

however

2d terraria

now that's a wild suggestion

[rain cedar]

I have two minecraft accounts don't worry

[copper nacelle]

Incredible

[rain cedar]

I used to have 3 but I gave one of them away

[hollow pier]

truly a generous individual

did you give it to harpreet

[rain cedar]

Nah it's not somebody you know

Because harpreet is the only person you know about

[tranquil glen]

I bet its Kyle

[hollow pier]

what about his dad

[copper nacelle]

but do you remember

[hollow pier]

mr singh

[fair rampart]

5incredible6

[rain cedar]

Kyle is my step brother's name

I don't think I've ever said that though

[hollow pier]

wait wait

[rain cedar]

Good guess

[hollow pier]

amber

[tranquil glen]

yeah and you gave him the account

[hollow pier]

is that even her name

[rain cedar]

no

[tranquil glen]

ez

[rain cedar]

No to krythom yes to pete

[copper nacelle]

was kurosh here when the sheo emote existed

[hollow pier]

was it amber

[rain cedar]

no

[hollow pier]

was it one of the other sisters

[rain cedar]

no

[fair rampart]

There used to be more emotes?

[hollow pier]

well do you have a secret brother

[rain cedar]

no

[hollow pier]

was it timesink

[rain cedar]

no

[hollow pier]

i can't believe this

[rain cedar]

So pete you want to play mc?

[hollow pier]

do i

[hollow pier]

fuck you got me

[copper nacelle]

no

[hollow pier]

tfw 56 has 6000 no

[copper nacelle]

Holy shit

I've found it

[hollow pier]

?

[copper nacelle]

The emote of #archived-modding-help

[copper nacelle]

[hollow pier]

🇫 1⃣ imo

[copper nacelle]

Incredible

[hollow pier]

why is that not in #hk-lore

[mortal trout]

56 nice calamity discord emote

[hollow pier]

yes i too hate freeze ice cube person

[copper nacelle]

I don't think I'm even in their discord

Yeah it's from festive labs

[weak lodge]

incredible.

[hollow pier]

[copper nacelle]

@ timesink

[hollow pier]

when

[copper nacelle]

Sean do you by any chance know why it's fucked on 1.4.3.2 but not on 1.2.2.1 and stuff

[fair rampart]

enemy rando?

it worked fine on 1.3 for me, but 1.4 it stopped

[ripe shore]

So in the example mods there's several uses of LogDebug()

Where does it actually output to?

Furthermore, where is LogDebug actually defined? Visual Studio seems to think it doesn't exist

[leaden hedge]

in the modding api

it outputs to modlog.txt

in your save folder

[ripe shore]

Ah, cool, I see it

So given that the example mod built, all I need to do is drop the .dll into the Mods folder and it should work?

[fair rampart]

does anyone have the google link for what the bonfire mod affects with each stat upgrade?

the link is dead

[fair rampart]

@copper nacelle is this u?
https://cdn.discordapp.com/attachments/467382508397527050/500401974546661387/unknown.png

[cunning lagoon]

unmod him imo

[weak lodge]

multiple instances of unproffesionalism

[ripe shore]

Anyone have any tips?

I hate to be asking all these noob questions but I don't know how to debug past here on my own :/

[young walrus]

just the tip

[ripe shore]

Ah yes perfect

[rain cedar]

Which example mod are you trying to compile?

[ripe shore]

Just #1

I have the other two not set to build

After I move the .dll from the Distribution folder into the Mods folder in the install path

I see the Example Mod loading in the log file

But after that nothing else is logged

[rain cedar]

Ok I see that's the nail damage one

[ripe shore]

That's right yeah

I should be seeing logs every time I attack

[rain cedar]

Anything below an info log is hidden by default

[fair rampart]

You need to enable the log in the api config

[rain cedar]

These two values are good to have for debugging

That still hides LogFine, use 0 for that

In ModdingApi.GlobalSettings.json in your save folder

That example mod won't actually increase nail damage btw

[ripe shore]

Hmm yeah I noticed it didn't seem to

[rain cedar]

After setting the nailDamage field you have to do

PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE");```

The examples are all a bit shoddy, I should update them

[ripe shore]

I see

[rain cedar]

You still get the general structure of a Mod class from them, at least

[ripe shore]

Yeah even that is very helpful

I just wanna make sure I can get one working first lol

[ripe shore]

I have all the references needed to use PlayMakerFSM.BroadcastEvent() but my nail damage doesn't seem to change

LogDebug("You should now be doing " + PlayerData.instance.nailDamage + " damage.");
Correctly outputs 20 damage

But tiktiks survive a hit

Any ideas?

[fair rampart]

tiktik swole

[ripe shore]

Yeah for real

[copper nacelle]

i think the nail slash has a damages enemy component on it

you could just change the value on that

instead of broadcasting the event

You're broadcasting the event after changing the damage, right?

[ripe shore]

Yeah lol

[rain cedar]

Show code

[ripe shore]

Sure

This is where the magic happens

I can just send the file if that's better?

[copper nacelle]

that return is useless

[cunning lagoon]

rude

[rain cedar]

That wouldn't make it not work, though

[copper nacelle]

yeah

idk what's wrong that looks fine

[ripe shore]

Did you write the example mods Sean?

Also

[rain cedar]

I think it was wyza

[ripe shore]

Are these the properties you were referring to 56?

[rain cedar]

What about it?

Nah he meant a damages_enemy component

[copper nacelle]

^

[rain cedar]

DamagesEnemy

Whatever it's called

[copper nacelle]

except it isn't the shitty FSM now

Yeah

[rain cedar]

I think damages_enemy is the FSM yeah

But anyway that won't work, I think I get what the problem is

Or actually that would work

Let me check the DamagesEnemy component

[ripe shore]

I'm not really sure what the best way to go about finding object properties and functions is

Like
PlayerData.instance.nailDamage

[rain cedar]

That's a field

[ripe shore]

A field

It's a property of PlayerData.instance, isn't it?

[rain cedar]

Field - variable
Property - Two methods pretending to be a variable
Function - method

[ripe shore]

Lol

[rain cedar]

So instance is a static property

nailDamage is a field

[ripe shore]

I see

Hm

[rain cedar]

You can see here even though you access it like a field, it runs a function

[ripe shore]

Oh what

That's nuts

[rain cedar]

value in the context of a property setter is an invisible parameter

Passed via =

[ripe shore]

Wow

How come they don't just use a variable?

I can see that it initializes itself

Is that the only difference?

[rain cedar]

In this case it prevents it from ever being null

[ripe shore]

Right

[rain cedar]

There's a lot of reasons to use properties though

Like you could make it only have a public get

So nobody can mess with it

Or do bounds checking on the set

[ripe shore]

Ah

I see

So its effectively a variable with some implicit value checks

Well... usually, anyway

[rain cedar]

Usually, yeah

[ripe shore]

I can imagine it has a lot of uses lol

[rain cedar]

But really you can't know what it does without checking

[ripe shore]

Right

[rain cedar]

Anyway, back on the other thing

It looks like the AfterAttack hook is still before the slash comes out

Bit of a misnomer I guess

So that's probably why it doesn't work

If you want a true after attack hook, you can use On.HeroController.Attack

[ripe shore]

Hm

I tried commenting out everything in OnAfterAttack() earlier so in theory the attack would have just kept going up

[rain cedar]

You'd have something like:

private void AfterAttack(On.HeroController.orig_Attack orig, HeroController self, AttackDirection dir)
{
     orig(self, dir);
     // After attack stuff here
}```

[ripe shore]

But that didn't do anything either

[rain cedar]

Oh, odd

[ripe shore]

yeah

[rain cedar]

The logs from the earlier hook are happening, right?

[ripe shore]

Yeah uh

Something like "attached hook x and hook y" is logged by examplemod1

[rain cedar]

That's a debug log generated by the API when you hook onto stuff

[ripe shore]

Since the log messages within the methods occur, that means the hooks should be fine, right?

Oh what are you referring to

[rain cedar]

Should be, yeah

https://github.com/seanpr96/HollowKnight.Modding/blob/master/Assembly-CSharp/ModHooks.cs#L839

So you should get:
[ExampleMod1] - Adding AfterAttackHook

Is that what you meant by the first thing about attaching?

[ripe shore]

Yeah sorry

Two messages exactly like that appear in the log

[rain cedar]

Alright

[ripe shore]

Uhh

Wait

I definitely just one hit a tiktik

[rain cedar]

So it does work, then?

[ripe shore]

I tried commenting out the reverting code

[rain cedar]

Sometimes at least

[ripe shore]

Yeah it must have just been on my mind

Maybe I forgot to move the built mod

[copper nacelle]

You can add a post build event to move it for you

[ripe shore]

Alternatively, maybe this the power you need

To stop swole tiktik

[rain cedar]

Seems a bit overkill but could be

[ripe shore]

lol

He should have <10 health

[rain cedar]

That's what they want you to think

[ripe shore]

Yeah I was about to start digging into that 56

Post build event? Is the build location hard-coded?

[rain cedar]

I don't think you can change it other than debug/release but maybe

I haven't tried

[leaden hedge]

you can do something like call moveToMod.bat as a post build event

and make moveToMod.bat do something like
mv C:/.../debug/debug.dll C:/.../managed/mods/whatever.dll

[ripe shore]

Yeah wait are .bat files just a series of commands?

[leaden hedge]

or something to that effect

[ripe shore]

That can't be too hard if that's the case

[leaden hedge]

although you'd want to del whatever.dll first

[copper nacelle]

You can just put mv in the postbuild

[ripe shore]

Is postbuild a Visual S feature?

[leaden hedge]

does mv auto overwrite?

[ripe shore]

it might

[copper nacelle]

Yeah

<Target Name="PostBuild" AfterTargets="PostBuildEvent">

<Exec Command="@echo on" />

<Exec Command="echo Copying mod" />

<Exec Command="copy "$(TargetPath)" "D:\Steam\steamapps\common\Hollow Knight\hollow_knight_Data\Managed\Mods\"" />

</Target>

[leaden hedge]

i dunno how you do it on visual s

[ripe shore]

What do you work on?

[leaden hedge]

but on vs17 you just right click on the project > properties

and build events is one of the options on the left

[ripe shore]

vs17 = Visual Studio 17?

[leaden hedge]

yeah

[ripe shore]

@rain cedar you were saying the after attack hook seems to proc before the attack finishes?

I'm trying to implement the function snippet you sent but I'm unsure how function is actually called

Unlike the hooks it doesn't seem tied to any in-game event

[weak lodge]

hmm new modder i spy

lad youve made more of an effort that i have

[leaden hedge]

give them modder

they deserve it more than AA

[weak lodge]

give them modder after ngg2

[fair rampart]

and enemy rando 2

[leaden hedge]

ngg2 after I manage to act like a human being

[weak lodge]

no me

what is a human

[leaden hedge]

and do something that doesn't involve sleeping 4hrs a day and spending the next 20 in bed

[weak lodge]

ok so this is me

[fair rampart]

Basically me, but without the full night of sleep

[weak lodge]

anyway im proud of the lad @ Cake#5928

never thought id see someone with a wholesome pfp in #archived-modding-development

whose not coming to ask about randomizer*

[leaden hedge]

as soon as they find out about fsms they'll stop being wholesome

[weak lodge]

i mean

youre not wrong

[ripe shore]

Aw

Thanks guys

I really feel like a damn fool

[weak lodge]

dont

im the dumb fool

[leaden hedge]

wtf is 753check

[cunning lagoon]

little fool

[ripe shore]

You would think being a junior in CS would make things easier or something

Uh

[rain cedar]

The hook is On.HeroController.Attack

[ripe shore]

Guess not tho

[solemn rivet]

FSMs changed my life

[copper nacelle]

it's a rainbow checkmark i stole from 753

[solemn rivet]

I literally stopped modding because of superdash's stupid fsms

[leaden hedge]

oh

its animated

[ripe shore]

Thanks for all the help ❤ xoxox

[leaden hedge]

I have animations disabled for everything

[ripe shore]

Ill be back later

[copper nacelle]

same tbh

[rain cedar]

If an FSM is too frustrating remake it as not garbage

[weak lodge]

56 when are you never back

[rain cedar]

See: big item popup in randomizer

It was like 500 FSMs

For some reason

[solemn rivet]

I started doing that very thing, sean

but then I had to deal with the hero's stupid spriteanimator

and that broke me

[weak lodge]

cake be warned, hk coded like spagetti with fsm's, im not a modder yet even i can tell you

[solemn rivet]

maybe someday I'll come back to it

but I don't really hate my life that much, so idk

[fair rampart]

the ancient tentacles of the forbidden Finite State Machine will grab hold of reality, and destroy us all

[leaden hedge]

i hate my life too much to do more mods

[weak lodge]

i hate my existence too much to do mods

gradow why are you always in nox app player

[cunning lagoon]

fsms are good

[weak lodge]

lies

die nerd

[solemn rivet]

playing FFBE

[weak lodge]

o ic

[copper nacelle]

dung defender's hitboxes are good

[weak lodge]

hornet's hitboxes are good

[cunning lagoon]

lost lord is easier than lost kin

[copper nacelle]

ngg phase 2 isn't rng

[fair rampart]

they are both easy

[weak lodge]

hollow knight has good fsm's

[copper nacelle]

what's with the apostrophe

[leaden hedge]

phase 1 / 2 / 3 is fine

its phase 4 thats double

[copper nacelle]

fair enough

[rain cedar]

fsmn't's

[leaden hedge]

f's'm'n''''t's'd'o'n''t's'

[weak lodge]

wh'y d'ont w'e all use apos'trophe's

[fair rampart]

is this shakespear

[weak lodge]

hmmmm

[copper nacelle]

'i'w'a'n't't'o'e'n'd'm'y's'e'l'f'

[weak lodge]

th'is'

tbh

[solemn rivet]

shakespearen't

[fair rampart]

Hail, sir knight of m're! doth thee wisheth f'r m're apostrophes?

F'r t is m're apostrophes yond i can grant!

[copper nacelle]

❌

[fair rampart]

nice semicolon

[copper nacelle]

thanks i try

[civic hare]

i'm too angry to be wholesome and too normie to be cool

[copper nacelle]

hmmmmmmm

[civic hare]

at least i'm a communist

[copper nacelle]

hi a communist

[hazy sentinel]

I. Communism is already acknowledged by all European Powers to be itself a Power.
II. It is high time that Communists should openly, in the face of the whole world, publish their views, their aims, their tendencies, and meet this nursery tale of the Spectre of Communism with a Manifesto of the party itself.

[civic hare]

glorious comrade mod is backwards, the void killing the radiance is obviously a metaphor for the workers banding together to seize the means of production

[compact sedge]

this but unironically

[civic hare]

bold of you to assume i'm being ironic

[hazy sentinel]

bold of you to assume the workers will ever succeed

[solemn rivet]

bold of me

[fair rampart]

bold of US

[hazy sentinel]

italics of portugal

[compact sedge]

WE HAVE NOTHING TO LOSE BUT OUR CHAINS

[young walrus]

unironically unironically this unironically

[fair rampart]

Buffalo buffalo Buffalo buffalo buffalo buffalo Buffalo buffalo

[weak lodge]

comrade napoleon

[copper nacelle]

Wtf

https://cdn.discordapp.com/emojis/460549975256989706.png?v=1

why

[fair rampart]

lmao

fr tho just wanna say i appreciate yall i just lurk and have no idea about modding but if it wasn't for you guys i would have shelved the game long ago

[leaden hedge]

wtf

https://cdn.discordapp.com/emojis/339605450653827074.png?v=1

[copper nacelle]

same

[leaden hedge]

clyde cock blocking me

Woah there! The owner of Hollow Knight has requested that Discord block any messages our mostly-accurate robo-hamsters deem to be explicit. Seems like you found one, so your message has not been sent. Please be nice.

[leaden hedge]

thats a female presenting face

banned on tumblr

[weary oyster]

ladies and gentlemen
we got em

[cunning lagoon]

lmao

we have to fight to get this masterpiece on srcom

[weary oyster]

i tried

[cunning lagoon]

how do you do the strong pogo

you do it at 1:51 in your run

and your nohboard doesnt work

[weary oyster]

double tap down

also shoryuken does a weird forward dash slash thing but i didnt find any uses for it

and spamming attack and dash lets you do dashes as fast as you want

[cunning lagoon]

tf is shoryuken

[weary oyster]

the street fighter attack

forward down forward attack

[cunning lagoon]

wtf so much tech

[weary oyster]

ikr

[cunning lagoon]

how did you even figure these combos out

[weary oyster]

mostly just accidentally doing them lol

the dash cancel thing i got from youtube comments on someone elses run

[cunning lagoon]

nice

[spice niche]

iis there a mod that changes the pantheon music to the original boss music?

[azure vessel]

no

[spice niche]

why

[azure vessel]

cause no one made one yet

[spice niche]

someone should make it then

[azure vessel]

i dont think someone will

[spice niche]

[azure vessel]

[solemn rivet]

git commit sudoku

[weary oyster]

why would you want that

the pantheon music is awesome

[ornate rivet]

@cunning lagoon @fast hearth @solemn basin
Hopefully the last version of the mod.
https://github.com/SalehAce1/Daughter-of-Hallownest

Made it so Hornet does not spam air dash

I am going to start working on Pale Champion (aka Pale Lurker mod)

[mortal trout]

pale champion more like pale prince amirite

[spice niche]

pantheon music is awesome

but bossthemes are awesome too

[ornate rivet]

Why does it say program does not contain a static main method as entry point

[analog ermine]

Pale

Pale

[weak lodge]

how's cherry madness going 🤠

[mortal trout]

ye

[hazy sentinel]

how's coal in your eyes going

[weak lodge]

eyes coal your in going how's

[solemn rivet]

literally dies

[floral furnace]

gradowo no pls we still need you

[solemn rivet]

tell that to whoever put burning coal in my eyes

[mortal trout]

draco why

[analog ermine]

Why what?

I am working

Kind of

[coarse grove]

I need help with a mod

[analog ermine]

To figure out this programing langue cause i started in wrong C. They are familliar but still

Work and staff

So

You know what is the worse?

[rain cedar]

@ornate rivet compile as class library

[analog ermine]

When time passes i get even more freaking ideas

[weak lodge]

oh noo!

[compact sedge]

honestly I'm like the opposite I have very little inspirtation rn but enough knowledge to sorta make stuff I wanna make

[weak lodge]

honestly i have alot of ideas but no will to implore them

oh well

[analog ermine]

Traveling between the worlds, on desserest like one, and swampy one, even more weapons, Troupe mode - every enemy is buffed, have new attacks and sprite, Starting chose of vessel with other starting weapons and abilities. Other type of Masks, and more

And more

And freaking my mind is sometimes to big

[floral furnace]

knightmere you can do it, all you need is a bit of determination, willingness to learn, professionally steal source code and bug everyone for fixes when you encounter an error

[weak lodge]

so basically the first half of that sentence i dont have

im willing to steal code no matter what it takes though'

[compact sedge]

seeing someone so willing to steal code fills you with determination

[analog ermine]

Troupe vessel - faster attacks and movement, hovever start with only three masks and staff (that shoots little soul bullets)

[weak lodge]

ok now explain playmaker for me thanks @fair rampart

[compact sedge]

it's uh

pain

[floral furnace]

its death reincarnated into a software

also ngl rewriting the entire code for the 3rd time is actually refreshing

[analog ermine]

[floral furnace]

like you get to abuse ternaries now without shit breaking up

[coarse grove]

which mod do someone suggest me?

[floral furnace]

randomizer hands down

[weak lodge]

play lightbringer

[ivory ruin]

Yeah

[coarse grove]

if my PC will load it and my friend stop playing it because I can't afford it yet(but finish it anyway 112%)

[ornate rivet]

How come this has no transition named SLASH but one of the actions has SLASH

[weak lodge]

playmaker why

please tell me that shit isnt mandatory to use

[cunning lagoon]

i cant even play hk anymore

sorry saleh

[copper nacelle]

Have you checked the global transitions

Also for basically any mod of non-zero complexity you're going to have to deal with fsms

[solemn rivet]

[cunning lagoon]

but fsmss are gpood

if u disagree sorry to tell you but u have the wrong

[weak lodge]

wow nerd takes down chat with facts and logic

[leaden hedge]

if its really complex you can just dodge them

and make ur own shit instead

[cunning lagoon]

yeah just get good

[leaden hedge]

it'll probably run better anyway

[hollow pier]

incredible

[cunning lagoon]

hey someones gotta bop ax

[tranquil glen]

Wait DL why can't you play hk

[cunning lagoon]

my cpu is dying

i can barely play terraria

i did some wp`runs on cp a few days ago and it was beyond unplayable

[hazy sentinel]

just be like 56 and stop playing after day 1

[tranquil glen]

Rip

Who am I going to get to run 5 jump KP

[cunning lagoon]

[hazy sentinel]

5 book library with d6 weary

[cunning lagoon]

wow you found the rare 5 item item room nice

[hollow pier]

kp oob incoming

[cunning lagoon]

no

dont find this

[hazy sentinel]

find this

[cunning lagoon]

you cant even skip a tunnel lol how are you going to skip kp

[hollow pier]

i can skip the tunnel in nldg

[cunning lagoon]

weird way to spell using cheats

[hazy sentinel]

wow gulped left hand cool

[tranquil glen]

I understand you don't want your efforts to be in vain DL

But pete

Pls find KP skip

So many press saves

And time save

Would bring both low press categories to under 10

[hazy sentinel]

but what about low both press category

[tranquil glen]

[cunning lagoon]

yeah i know

i dont really care

[hollow pier]

d wnpatching

[cunning lagoon]

what a gamer

did not even get the quick kill on the final boss

[hollow pier]

isn't rekky 8m

[cunning lagoon]

yeah

8 43

[hollow pier]

wow you suck

[cunning lagoon]

shut up its my first run

[hollow pier]

u

[cunning lagoon]

damn gittle whining about a boss

that's a new one

[hollow pier]

how do you even know that that's gittle

[mortal trout]

looks like you have to do absrad radiant 4 times in a row with no charms and oldnail when you get a new cpu

[cunning lagoon]

because i talked to him the other day

he had the same pfp

[hollow pier]

imagine talking to anyone outside modding

[cunning lagoon]

he also whined non stop about scal

[hollow pier]

scal is unfair pls give less hp

[cunning lagoon]

from what i've seen he basically just complains about every boss he can't beat first try

[rain cedar]

Ah yes scal

Of course

[hollow pier]

Scalpr

[cunning lagoon]

anyway the point is

eroico is lowkey a fun game

who do i yell at to get it added to srcom

[weak lodge]

@cunning lagoon how consistent do you get this

[hollow pier]

imagine not doing the faster rng cdash

[weak lodge]

kuro cdash

[weary oyster]

how is rng dash faster

[cunning lagoon]

rng dash is def half a second or a second faster

[weary oyster]

with perfect execution?

you never need to touch the platform with this setup

[weak lodge]

?

[copper nacelle]

secret santa pog

[hazy sentinel]

wow it's a new keyboard

[cunning lagoon]

i mean if your setup gets you in the good wall position every time then its probably roughly equal

[fair rampart]

woke coke

[cunning lagoon]

but i always go a bit high then slide down a bit to line it up

[weary oyster]

https://youtu.be/mXJMnrJ_p2I @ 26s

there's no way rng dash is faster than this

[cunning lagoon]

yeah thats probably faster

but do yuou get it every time

[weak lodge]

yea thats faster for sure

[weary oyster]

no but thats the part i can improve

[weak lodge]

but

[hazy sentinel]

wtf i haven't picked up rune bag yet

[cunning lagoon]

yeah i mean im not defending the rng dash

[weak lodge]

so it's not consistent?

[weary oyster]

i cant improve rng

[cunning lagoon]

i think its shit and no one should go for it

[hasty kindle]

why is the randomizer mod not working?

[weak lodge]

play lightbringer ez

[hasty kindle]

wich one should i choose in the menu?

[copper nacelle]

Imagine providing a descriptive bug report

or literally any info at all except 'wow not working'

[hollow pier]

i have found these navy blue looking enemies

they seem to only crawl and not actively attack me

[weary oyster]

but what if its just not working :(

[hollow pier]

they have fairly small hitboxes

[ornate rivet]

56, aren't globale transitions shown in the fsm reader in a different color?

[hollow pier]

they seem to be non-hostile

[cunning lagoon]

there's a pretty good monomon hardlock joke here but i cant figure it out

[hollow pier]

there are 4 in king's pass

[hasty kindle]

i launched a randomizer game but every single enemy is not random

[copper nacelle]

Yeah they're black saleh

[cunning lagoon]

you just got good rng

[weary oyster]

pete i actually despise you for giving 56 access to turbo

[hollow pier]

turbo

[ornate rivet]

well I cant see any black ones

[copper nacelle]

Rando is for charms and skills you fool

[hasty kindle]

ok thx to laugh at me

[weary oyster]

nitro whatever

[cunning lagoon]

just give it a month

[copper nacelle]

Enemy rando is for enemies

[hasty kindle]

you're nice

[hollow pier]

ax asleep post cursed ms for a month

[cunning lagoon]

how tf do i get the quick kill on the final boss

i just fall

[hollow pier]

pogo better

isn't it only on one of the attacks

or like two

[cunning lagoon]

yeah

why do you know these things

[hollow pier]

i am an eroico speedrunner

[copper nacelle]

Also if you're using enemy rando and not rando did you hit the load button

[cunning lagoon]

same! 🙂

[hazy sentinel]

thank you mom's knife for ruining synergies

[cunning lagoon]

also wtf is this supposed to mean

[hazy sentinel]

means absrad unfair

[cunning lagoon]

same

[hollow pier]

he's done it

[cunning lagoon]

also got a 10:33

rekky soon

[copper nacelle]

What version is that ptkyr

[cunning lagoon]

why do you care

mind your own business

[hollow pier]

how did i just delete it

all i did was drag it into a folder

and it disappeared

[cunning lagoon]

the game doesn't want you to skip kp

[hollow pier]

ah i just spammed ctrl z

we are safe

[cunning lagoon]

can we take away 56's nitro

[hazy sentinel]

it's called block feature

[cunning lagoon]

ah u right

[hollow pier]

holy shit

it went to 151

is this god

[copper nacelle]

yes

[hollow pier]

gamer

[copper nacelle]

[hazy sentinel]

when will delirious exist

[cunning lagoon]

Pete kyr did you pirate the game? Or why are you not on the godhand version of the game

[hollow pier]

he's done it

[cunning lagoon]

wow he skipped king's pass

what a gamer

[hollow pier]

ah yes

he has fallen into the false knight locked door hardlock

[cunning lagoon]

must be qol

[copper nacelle]

Do you want mini debug?

[cunning lagoon]

sure 😊

[copper nacelle]

hmmmm

ok

[river eagle]

that might be the first time I ever see anyone use that emote wtf

[cunning lagoon]

i've used it multiple times in this server alone

do you not read this channel 24/7?

shit mod

[river eagle]

[weak lodge]

where khan at

ultimate #archived-modding-development lurker

[copper nacelle]

would anyone be interested in a mod which makes the game run better

[cunning lagoon]

no it runs fine for me 🙂

[river eagle]

completely rewrite the entire game without using any fsms

[copper nacelle]

i have a few fsms which i'd like to kill

[cunning lagoon]

wtf murderer

[copper nacelle]

e.g the fucking fsm on the dust particles

just

why

[cunning lagoon]

remove all animations and particles

make the game one static image

[copper nacelle]

i mean particle removal was an idea

[cunning lagoon]

then i might be able to run it at 30fps

[copper nacelle]

there are particle options in unity i think

i could probably set it lower than it is

[buoyant obsidian]

you can just set the max number of particles to zero for all particle systems

bye bye

[copper nacelle]

😩

[river eagle]

Can you make a mod that actually makes the performance worse?

[copper nacelle]

Yeah that's not hard at all

[river eagle]

while making the game look better

[copper nacelle]

that's harder

[leaden hedge]

if only it was 3d

[river eagle]

Hollow Knight Reshade presets

[leaden hedge]

then you could just spam post process

[buoyant obsidian]

VRChat used to have an issue with people making particle weapons that crashed people so I built an anti-crash that just removed all particles with more than 100k particles

[leaden hedge]

that was gods way of telling you stop playing anime simulator

[river eagle]

but could you make a mod that increases all particles by 200%?

[buoyant obsidian]

easily

[cunning lagoon]

quit bragging cunt

[leaden hedge]

could you make a mod that turns all anime avatars in a really fat guy

[buoyant obsidian]

KDT where else will I find so many traps

[leaden hedge]

tiktok

[buoyant obsidian]

shit fam you're right

brb

[leaden hedge]

assuming you wanted actual humans

if you want 2d traps pretty much every site has them as a tag

[weak lodge]

kuro uhh this room gives me trouble to speed through any tips

[copper nacelle]

imagine using #speedrunning

[cunning lagoon]

make the cycle

[fair rampart]

nice pink knight

[cunning lagoon]

just watch any 106 or 112 run and copy it

[weak lodge]

im not a speedrunner memer

[cunning lagoon]

its incredibly lenient

also dont copy my thing because there are a billion things that i dont go for because i lag like crazy

copy ax'r run or something

[weak lodge]

https://youtu.be/mXJMnrJ_p2I

[thorn comet]

#speedrunning ?

[cunning lagoon]

well there's no modding talk going on atm so i don't see anything wrong with having an offtopic conversation here

#hk-discussion works in the same way

but sure

[thorn comet]

#hk-discussion allows offtopic talk if a topic talks turns into offtopic, not starting unrelated convos

[leaden hedge]

I don't let random people talk about completely off topic shit

[mortal trout]

half of the time this channel is speedrunning tbh

[leaden hedge]

most people that talk in here are regular and theres quite a bit of overlap anyway

[weak lodge]

also kuro your screen tears worse than mine

[cunning lagoon]

my screen tears worse than everyone else's

[weak lodge]

i thought my screen was the worse here

1680 x 1050

[fair rampart]

How bad is Kuro's screen tear?

[cunning lagoon]

5 bad

[river eagle]

I feel like screen tearing is the worst around when you have slightly over 60fps

for example at like +300fps it feels like nothing

but at 80fps it's terrible

[cunning lagoon]

just get more fps 🙂

[fair rampart]

mfw when 70 fps

[river eagle]

Also something I've been wondering

since Vsync causes input lag

couldn't you just underclock your gpu to get as close to 60fps as possible without even having to deal with input lag?

[leaden hedge]

you can

you can just set a target fps though

[copper nacelle]

and isn't the issue with vsync that less frames is less input checks

[leaden hedge]

which will just wait until next time

no

[copper nacelle]

isn't look for input queue on update

[leaden hedge]

the lag is caused by vsync buffering extra frames in advance

so you're a frame or 2 behind

sometimes theres big brain stuff like sfv

[copper nacelle]

o

[leaden hedge]

which manages to get like 8 frames of lag from vsync

somehow

[river eagle]

hmm, wonder why there isn't an application yet that automatically tries modifying your gpu clockspeeds to keep a steady 60fps

[leaden hedge]

because the load done on 2 different frames can be extremely different

[river eagle]

Hm, right and also especially on graphics heavy 3d games the fps fluctuates quite a lot so you'd probably end up dipping below 60fps many times which would be worse than screen tearing

[weak lodge]

[ember bloom]

Why are you using gay knight robes

[hazy sentinel]

he has done it

[cunning lagoon]

insane

they have the speedrunner role

[hazy sentinel]

bestiary done 😎

now all i have to do is die ~25 times on basement 1

[ripe shore]

Do you have 100% achievements?

[cunning lagoon]

is this a second save file

[hazy sentinel]

this is a first save file after deleting the actual first save file

[cunning lagoon]

very nice

[hazy sentinel]

😩

[cunning lagoon]

wow you died to them 0 times 😮

impressive

[hazy sentinel]

does the encounter # increase every time he morphs or something

game fix pls

[cunning lagoon]

yeah its broken

just like the boss

[hazy sentinel]

wow encountered larry jr 1326 times hmmm

[buoyant obsidian]

shit my bad thought this was the hollow knight modding channel

[solemn rivet]

aka the fsm-hating channel

btw who was it that was asking about FSMs earlier today?

[fair rampart]

Knightmere I think

[ripe shore]

What the hell is an FSM

[mortal trout]

u

[ripe shore]

ouch

no u

[fair rampart]

Finite State Machine

[ripe shore]

Ah

They sound... nice

[fair rampart]

no

[ripe shore]

lol

[fair rampart]

they are not

[weak lodge]

ok so

[ripe shore]

What are they good for

[weak lodge]

an fsm is basically the middle finger from team cherry in the code

[ripe shore]

l m a o

bring it team cherry

[weak lodge]

elegy HAS 7 FUCKING PARTS

[ripe shore]

? ¿ ? ¿ ? ¿

[fair rampart]

I present to you, the most amazing FSM ever
https://cdn.discordapp.com/attachments/297468195026239489/494544243147276288/The_Hollow_Knight.png

[ripe shore]

Oh

Oh

Oh no

What is this

Animation?

AI?

For enemies?

[fair rampart]

this is for The Hollow Knight boss

Ai

[ripe shore]

Ah

[solemn rivet]

no

this is Satan

incarnate

[cunning lagoon]

fsms are good

[ripe shore]

That picture up there is what they look like in Unity right?

[cunning lagoon]

also arrays start at 1

[solemn rivet]

no, cake, that's a custom viewer

made by nes

[formal flame]

How would you even start changing that?

[solemn rivet]

you don't

you change yourself

it's like the matrix

[formal flame]

It’s like one of those origami puzzles where if you unfold one part you tighten others

[solemn rivet]

you realize that it's not the fsm that bends, it's you who's bending

[formal flame]

And this is modding

[fair rampart]

seriously tho, WHY
https://cdn.discordapp.com/attachments/283680756159741953/522487660108054538/elegy_why.png

[ripe shore]

I can't wait

[solemn rivet]

because

[cunning lagoon]

why not 🙂

[formal flame]

Ah well we still love them

I’m excited for their next games

[fair rampart]

plz no more fsm

[solemn rivet]

^

[fair rampart]

it hurts so much

[ripe shore]

^ What is Sean saying here

It seems like it's not as simple as replacing AfterAttackHook with a different hook

[floral furnace]

whats the error?

[ripe shore]

Oh the red line?

[floral furnace]

afterattack probably has some parameters that isnt added on your OnAfterAttack method

yeah

[ripe shore]

OnAfterAttack is just commented out

The problem seems to be that AfterAttackHook fires after before the enemy actually takes damage

[fair rampart]

https://cdn.discordapp.com/attachments/327461802311155714/522842346388324364/dungwhy.png
Naming 4 FSMs the same thing 😩

[ripe shore]

Pft they're not the same

One of them is clearly 3752b

Comeon

[floral furnace]

well im guessing the hook starts even before the hit is registered

[ripe shore]

Yeah that seems to be the issue

[solemn rivet]

what do you want to hook for?

[fair rampart]

yeah, the 2548 is the passive dung cloud, the 3752 is the spore dung combo

[ripe shore]

The hook is to revert the damage I add in AttackHook

So it only lasts one hit

[solemn rivet]

do it at the start of the next hit

[fair rampart]

but there are 3 variations to the passive cloud shape, and each has it's own FSM

because

[ripe shore]

O shit lol

Tentacles you're a genius lmao

[floral furnace]

expect nothing less from gradowo 😩

[ripe shore]

Also

Whats the point of this XML documentation

[fair rampart]

What server is tentacle global emote from?

[ripe shore]

Hm well there's actually problems with reverting the damage buff on the next attack

Other things rely on nail damage

So for example you could get buffed shadow dash damage so long as your last nail hit was a buffed hit

[rain cedar]

You could also crit then quit out and it would save the increased damage

Try the hit instance hook

[solemn rivet]

AAA: https://discord.gg/AbAAHc

hitinstance happens before hit tho

[cunning lagoon]

nathan is ttacco now 😮

[solemn rivet]

after HeroController.Attack, but before the enemy takes damage iirc

oof

ty dlk

[floral furnace]

56 pls

fuck i mean gradow

[hazy sentinel]

all you modders look the same

[leaden hedge]

mb if they kept their names the same

instead of changing it

[ripe shore]

So none of the hooks related to attacking happen after an enemy takes damage?

Are there any other tools to work with other than hooks?

[floral furnace]

like sean said you can use the hitinstance hook

but you gotta filter it if only wanna apply it to nail attacks only

[rain cedar]

It's unity you can do everything without hooks

Literally everything in the game is available for anything to access

Especially because of reflection

It's not the best way to do it though

[ripe shore]

The best way is... hooks?

[rain cedar]

Events in general are a lot faster than other methods

Since they only run when they need to

[fair rampart]

rub

[rain cedar]

rub a dub dub

[hazy sentinel]

rub a rub a dub dub fellow gamers

[fair rampart]

wet

[ripe shore]

What does it want me to return

[fair rampart]

the parathesis stuff

[ripe shore]

Are you sure? Those are the parameters I pass to the function

Or rather I think it's what the hook passes to my function

[floral furnace]

OnAfterAttack(something something,Hitinstance hit){
}

i forgot the something

[ripe shore]

You betcha

But it doesn't like that it's a void function

[fair rampart]

or wait no return type is like "Void" "Bool" "Int" stuff like that

[floral furnace]

Fsm owner, HitInstance hit

[rain cedar]

You can check the return type by viewing the definition of the hook

[floral furnace]

you return the hit iirc

[rain cedar]

It's a struct so that makes sense

[floral furnace]

its asking for a HitInstance return type

[ripe shore]

Sean the best definition I could find was

#region Assembly Assembly-CSharp, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
// C:\Users\Vasa\Personal Files\Programming\HK Modding\HollowKnight.Modding\Vanilla\Assembly-CSharp.dll
#endregion

using HutongGames.PlayMaker;

namespace Modding
{
    public delegate HitInstance HitInstanceHandler(Fsm owner, HitInstance hit);
}

[rain cedar]

Your changes are boxed otherwise

[compact sedge]

so return a HitInstance

[floral furnace]

public delegate HitInstance HitInstanceHandler

[ripe shore]

o shit

Uh

Returning a default HitInstance seems like it would be bad

What does the hook actually do with the value anyway

[floral furnace]

hit.damageDealt = 420;

return hit;

[ripe shore]

Hmm

[floral furnace]

it gets called whenever a new hitinstance is created, in this case whenever you hit anything, hit contains the info of what that hit is, could be a Spell type that does 20 damage etc etc

[cunning lagoon]

it gets called whenever a new hitinstance is created, in this case whenever you hit anything, hit contains the info of what that hit is, could be a Spell type that does 20 damage etc etc

[floral furnace]

kuro please

[ripe shore]

Thanks Kuro

[floral furnace]

Good job as always kuro knew we wouldnt have done it without you

[cunning lagoon]

No problem dude 😃

[ripe shore]

So whenever I hit an enemy with the nail

Surely a hitinstance is already created

Does the hook replace the old one?

[leaden hedge]

the hook gives you a reference to it

[ripe shore]

Ah

There we go

Oh fucking duh

[fair rampart]

How does the api handle multiple mods trying to set nail dmg?

[ripe shore]

That's the param

[leaden hedge]

it doesn't handle it

the mods have to handle between themselves

which they don't

so which one is last in the queue works

[ripe shore]

lol

[floral furnace]

so just put the load priority to be at the bottom of the list

[ripe shore]

Are the mods queued in some particular known order?

Or is it effectively random

[leaden hedge]

you can set order

some of AAs mods do it

[compact sedge]

hitinstance is when you take damage

[ripe shore]

plsno

[compact sedge]

not when you hit something

[ripe shore]

no god ive come too far

[floral furnace]

wait what

[rain cedar]

That's not right

[fair rampart]

huh

[compact sedge]

or no

wait

no

[floral furnace]

angle pls

[compact sedge]

but it's broken

[floral furnace]

thats another hook

[compact sedge]

cuz the only way to do hitinstances reliably

is with

health manager hook

because that hit instance applies to like

grass and shit

[ripe shore]

Yeah I was going to try to filter the target like someone had suggested

[compact sedge]

unless you just wanna modify damage done

then it's ok

[ripe shore]

Not sure how well that's gonna go

[compact sedge]

but if you care about ONLY triggering it when hitting enemies

[leaden hedge]

can't you just check the target

[compact sedge]

you need On.HealthManager.Hit hook

[floral furnace]

doesnt the hitinstance var allow you to check the game object your hitting at, then check if it has a healthmanager in it ?

[leaden hedge]

to make sure its an enemy

[compact sedge]

I thought I remember something weird about it

unless the bug was fixed

[ripe shore]

That's interesting I figured healthmanager would be about player health

[compact sedge]

target isn't actually the target

it's your object

that's doing the hitting

so like

the nail fsm

[floral furnace]

nope healthmanager is the enemies health

[ripe shore]

whack

[compact sedge]

there was something about target that made it so I couldn't do it at any rate

[floral furnace]

all damage-able stuff has it

[compact sedge]

yeah healthmanager is only for enemies

and it's not implemented natively in modding api because api development stopped before it was added to the game

[ripe shore]

O no

Who made the API again

[compact sedge]

not 100% true me and 56 have made some commits to the modding api since then but it's mostly not been updated

[ripe shore]

I see

[compact sedge]

https://github.com/5FiftySix6/HollowKnight.Modding/graphs/contributors

[ripe shore]

I thought it was 56's project alone

I didn't know other people had helped

Or was it just you two lol

[leaden hedge]

56 didn't do half of it

its mostly sean

[ripe shore]

l m a o

[leaden hedge]

and I guess firzen at the start

[floral furnace]

the other 2/3rd is kuro ofcs

[cunning lagoon]

same

[ripe shore]

Amazing

[rain cedar]

It was me/firzen, then wyza, then it kinda died

A couple people do minor changes every so often

[ripe shore]

Wow 56 isn't even that list

[rain cedar]

Monomod hooks kinda obsolete any further development

[ripe shore]

Despite owning the github repo lol

[solemn rivet]

Wut

[rain cedar]

But I own the repo

[ripe shore]

Hm

[cunning lagoon]

no i own it 🙂

[solemn rivet]

I own u

[fair rampart]

I own your planet

[cunning lagoon]

i can let you own me all you want dad

[rain cedar]

Wait

@compact sedge why did you link a fork?

[leaden hedge]

the fork fits the agenda Kappa

[compact sedge]

cuz it's the version that is on the drive

[rain cedar]

I'm pretty sure I've merged the most recent changes

[ripe shore]

Yeah that's only version I've seen lol

[leaden hedge]

not merging fast enough 😠

[ripe shore]

I didn't see forked from Sean in tiny ass text below it lol

[rain cedar]

The contributors page is inaccurate either way

Wyza has too much, I have too little, I don't think firzen is on there at all

[ripe shore]

Yeah I understand in reality Kuro made the whole thing

What are you gonna do

[rain cedar]

Tell people to play Iconoclasts probably