#archived-modding-development

1 messages · Page 110 of 1

solemn rivet
#

I've just realized sean already posted the relevant lines here

#

well, back to doing nothing

exotic venture
#

f

solemn rivet
#

busy

#

studies

#

is there any benefit to using generic vars instead of the actual vars?

#

specifically when foreach looping

#

also, AA that repo can only accessed by people with a gitlab acc

compact sedge
#

oh sorry

#

I was trying to do a meme

#

and you actually made it so you need an account

solemn rivet
#

yeah

#

I'm evil

#

also

#

your mem level >>> my mem level

compact sedge
#

I'm like on -3 mems right now so I'm sorry

solemn rivet
solemn rivet
#

okay, redid some of the code of the installer

#

tomorrow I'll finish adding support for optional dependencies/suggested mods

copper nacelle
#

nice

solemn rivet
#

code makes more sense now too

#

I have a dictionary for mods and their download links

#

but, for some reason, when I first wrote it, I put the links as keys and the names as values

#

idk

#

I must have been drunk then

pearl sentinel
#

so, question for anyone bored enough to look at this; does this interface make sense to you?

solemn rivet
#

ehhhh not much tbh

pearl sentinel
#

this is the core of something i've been debating on turning into an asset on the unity asset store, though i think i'd open source this part

#

what if i told you that you could use this in place of any unity coroutine

#

basically, put a coroutine in this. you can start, re-start, stop, pause, resume, etc

#

example from one of my tests

#

        [UnityTest]
        public IEnumerator StartAndCountTo100AndPauseAndResumeAt50()
        {
            countPos = 0;
            SmartRoutine testObject = new SmartRoutine(CountToX(100));
            Assert.That(SmartRoutineHelper.Instance.Routines.Count, Is.EqualTo(1), "1 SmartRoutine should be active.");

            while(countPos != 50)
            {
                Assert.That(SmartRoutineHelper.Instance.Routines.Count, Is.EqualTo(1), "1 SmartRoutine should be active.");
                yield return new WaitForEndOfFrame();
            }

            Assert.That(SmartRoutineHelper.Instance.Routines.Count, Is.EqualTo(1), "1 SmartRoutine should be active.");
            testObject.Stop(false);

            Assert.That(testObject.IsPaused, Is.True, "SmartRoutine failed to pause.");
            Assert.That(testObject.IsRunning, Is.True, "SmartRoutine stopped when it should be paused.");
            Assert.That(SmartRoutineHelper.Instance.Routines.Count, Is.EqualTo(0), "No SmartRoutine should be active while paused.");

            yield return testObject;

            Assert.That(countPos, Is.EqualTo(100), "Failed to count to 100.");
            Assert.That(testObject.IsRunning, Is.False, "SmartRoutine failed to stop.");
            Assert.That(SmartRoutineHelper.Instance.Routines.Count, Is.AtMost(0), "SmartRoutine did not complete.");
            yield break;
        }
#

basically think of it as a better coroutine

#

but yeah, if the interface doesn't make sense with that contextual info, i'd appreciate any feedback (there will be comments in the actual thing, i removed them for brevity here, and to get a sense of how the code communicates by itself)

sage flare
#

I'm a little confused as to how the randomizer is supposed to work. I've installed the mod using Crossroads along with the Modding API, and the text "Randomizer" does show up in the bottom right corner of my game. There's no options displayed under the new "Mods" option in the settings. When I start a game, I'm not prompted with anything, and I always get Fury of the Fallen in its correct location. Anybody have something helpful?

copper nacelle
#

did you install modcommon

solemn rivet
#

did u beat the game already?

young walrus
#

have you beaten the game?

sage flare
#

Just did install modcommon. No changes seemingly. And... I just cleared the save that I had beaten the game on.

#

I have another save that's pretty far along that I can beat the game in though.

young walrus
#

all you need to have done on your PC is have beaten the game

#

then in the steel soul vs normal select screen, it's different

#

send a screen shot of your main menu

solemn rivet
#

^

#

you need to be able to select steel soul

young walrus
#

or just.... disappear

copper nacelle
solemn rivet
#

hollowbisappear

sage flare
#

I'm trying to beat the final true boss. I'm still kinda bad. Thanks guys for your help!

#

Interrupted by calls constantly

copper nacelle
#

if you're doing it to unlock rando just beat thk

#

radiance isn't necessary for the steel soul unlock

sage flare
#

Noted

copper nacelle
#

javascript: document.getElementsByName("project[visibility_level]").item(0).selectedIndex = 2; document.getElementsByName("commit")[1].click()

#

bookmarklet to change the visibility to public

#

for gitlab

rain cedar
#

@sage flare If there's text in the bottom right you have the old randomizer for grimm troupe

sage flare
#

How do I get the newer one then? I just used Crossroads to get it earlier today

copper nacelle
#

is it not in crossroads

#

wtf

#

i'll put it in rn

compact sedge
#

is it not in the xml?

copper nacelle
#

doesn't seem to be

rain cedar
#

I've never bothered editing that

#

Was gonna a while ago but there were two of them so I just didn't

copper nacelle
#

@sage flare reopen crossroads and it should be there now

sage flare
#

Got it, thanks!

compact sedge
#

What do I have to do to get my Collider2D to work with my Rigidbody2D?

rain cedar
#

Put the collider on first

#

Should be it

#

Need to set bounds on the collider too of course

#

So it knows where the collision is

compact sedge
rain cedar
#

Implement trigger enter too

#

Both are for hitting colliders

compact sedge
#

can I have a collider that doesn't collide with literally every other physics object but does with like floors and stuff

#

so my balls stop knocking my knight around

rain cedar
#

Yeah, I think there's actually a team cherry component you can use for that

#

Hang on

#

Yeah try adding IgnoreHeroCollision

#

Might work

compact sedge
#

to what my gameobject

#

or my rigidbody2d

rain cedar
#

You can't add components to other components

#

Your object

compact sedge
#

also if I have OnTriggerEnter2D do I need the oncollision one?

rain cedar
#

They serve different purposes

#

Trigger is for hitting non-solid objects, collision is for solid things

#

I think you might have to set iskinematic or something similar to that on your rigidbody for either to work properly

compact sedge
#

That's probably the proper approach

#

isKinematic means I have to write my own physics functions

#

but also it means I CAN write my own collision functions

#

since adding the IgnoreHeroCollision didn't work

#

and also I want it to collide in certain ways

copper nacelle
#

lmao

compact sedge
#

ok I switched to jetbrains rider

#

Loving it already

#

56 was right

copper nacelle
#

nice

rain cedar
#

FSMs have the benefit of being able to be "hooked" at runtime with no dependencies at all

#

Still pretty bad, though

flat forum
#

here

copper nacelle
#

description when

flat forum
#

Early 2018

copper nacelle
#

delet this

flat forum
#

no u

rain cedar
copper nacelle
#

p a i n

dusky lion
#

It's funny because I don't get it because I'm not a true modder and 56 is forcing me to make a mod that renames Millibe to Wilbo.

floral furnace
#

Do it anyway

copper nacelle
#

@dusky lion 🔫

#

ok so open Visual Studio and make a new project

dusky lion
#

Okay done

copper nacelle
#

wait what

#

type has to be class library

dusky lion
#

I pressed the new project button

copper nacelle
#

ok select Class Library (.NET Standard)

dusky lion
#

That was your instructions and I finished instructions

copper nacelle
#

put the name in

#

hit ok

dusky lion
#

Shit um

#

Short intermission

copper nacelle
rain cedar
#

flag is never used again

flat forum
#

here, description
List of changes
Fragile/Unbreakable Strength gives a powerful buff when at max health. Getting hit at max health deals double damage
Fury of the Fallen now makes you stronger based on health lost and not just at 1 health
Longnail Nail is now x1.5 longer. You deal x0.8 damage
Mark of Pride Nail is x1.75 longer. You deal x0.7 damage
Quickslash You attack very fast. You deal x0.5 damage

Combinations:
Fragile Fury - the Fragile/Unbreakable Strength activates at max health and at 2 or less health. You are constantly overcharmed
Long Mark of Pride - nail is x2.25 longer, but deals x0.5-x0.6 damage

trying to combine charms with different effects - Nail Length and Damage, Nail Length and Speed and Nail Length and Speed and Damage punishes you - you deal only 1 damage and your attacks are slower

copper nacelle
#

also just do Punishment = 0

#

in addition to the flag being useless

#

so is the if

dusky lion
#

I am back from my short intermission grimmhiss

copper nacelle
#

nice

dusky lion
#

God dammit um short intermission 2

flat forum
#

@copper nacelle happy?

copper nacelle
flat forum
#

I wrote a description of changes

copper nacelle
#

yes

flat forum
#

yes

dusky lion
#

bakk

flat forum
#

yeah

#

did you see description of the mod?

dusky lion
#

Yes

copper nacelle
#

did you finish making the project

dusky lion
#

Almost had an uncomfortable 10 seconds of visual studio not responding.

#

Where is the option to select Class Library?

copper nacelle
dusky lion
#

Wow yours looks incredibly different to mine

copper nacelle
#

show pic when

flat forum
#

Dark Mode

dusky lion
flat forum
#

install

rain cedar
#

Oh no that's hideous

copper nacelle
#

my eyes

dusky lion
#

Where dark mode option?

floral furnace
#

light theme is ok tbh

flat forum
#

you need to install the extra stuff

copper nacelle
#

Tools -> Options -> Environment

flat forum
#

so you can have a class library

copper nacelle
#

Color theme: Dark

#

yeah reopen the VS installer and select .NET

#

after you make it dark mode

dusky lion
#

It was fine but now that I know there is a dark mode option I'm not going back.

copper nacelle
#

imo that was not fine

floral furnace
#

i mean, i think all of my other ide's are set to light mode

#

its pretty ok i guess

dusky lion
#

Dark mode is engaged as it should be.

copper nacelle
#

the only light mode I like is GitHub's code editor

#

that's ok

#

other than that I prefer dark mode

flat forum
#

hey

#

@copper nacelle

copper nacelle
#

yes

dusky lion
#

REEEEEEEEEEEEEEEEEEEEEEEEEEEEE

floral furnace
#

okay i take that back

#

probably not for discord

copper nacelle
#

delet this

#

oh wait

dusky lion
copper nacelle
#

h a h a

flat forum
#

no

copper nacelle
#

y e s

#

since I'm gonna swap to linux for hk modding

#

i can use discline now

#

terminal discord

#

it doesn't align usernames tho

#

ree

flat forum
#

wait

#

What

#

WHat's that?

dusky lion
#

That looks like hurt

flat forum
#

Y IT NOT LIIGHT MOODE

dusky lion
#

OH

#

2.56 GBS OKAY

flat forum
#

myeah

dusky lion
#

wheresln

floral furnace
#

Btw how hard would disabling attacks and dash should be?

copper nacelle
#

not very

floral furnace
#

Ohhh nice

copper nacelle
#

I think you can just set canDash false w/ the onbool

flat forum
#

and attacks?

#

(is there a CanAttack thing?)

copper nacelle
#

preattack set your nail range to 0

flat forum
#

PreAttack?

#

a preattack hook?

copper nacelle
#

it's called OnAttack

#

OnAttack -> Attack -> AfterAttack

flat forum
#

or is the OnAttack one

#

ok

floral furnace
#

Alrighty then, looks like the GUI is gonna be the harder one to make then

copper nacelle
#

wait

#

it starts the slash after afterattack

#

so i think you could just

#

set attacking false

#

big meme

floral furnace
#

theres a bool for that?

copper nacelle
#

yeah

#

HeroController.instance.cState.attacking = false;

floral furnace
#

cuz otherwise im gonna go dnspy diving

copper nacelle
#

set it in after attack

flat forum
#

Y then set nail range to 0?

copper nacelle
#

never attack again

#

no that was just an idea

floral furnace
#

Nail range 0 is an equivalent i guess

copper nacelle
#

setting attacking false is better

flat forum
#

yeah

#

but

#

Y

floral furnace
#

i mean youre still attacking, but you just cant contact things anymore

dusky lion
#

Installing the .NET shite is going smoothly but slow.

copper nacelle
#

cause it'd work

#

that was a quick guess at something you could do

#

very much not a recommendation

floral furnace
#

yeah it just one of the possible solutions

#

but hey, bool is there so ill just screw with that one instead

flat forum
#

This will be very useful for me as well

dusky lion
#

61% done installing

#

Oh boy it's 3 AM I should be sleeping

#

@copper nacelle I'm going to let it finish downloading overnight and once I wake up I'll do the mod

copper nacelle
#

gn

floral furnace
#

just to remind me, GameObject has an instance that gets created once you get in the game, not in the main menu right?

copper nacelle
#

GameObject GWchadMEGATHINK

#

that's just a unityengine type used a ton

#

GameManager iirc doesn't have an instance till you're in game

#

same w/ HeroController and PlayerData i think

floral furnace
#

then it should be destroyed when you quit back to the menu right?

copper nacelle
#

I'd think so

#

but dunno

#

wait yes

#

it is

#

I remember because I was adding a component to it

#

and then my component kept getting destroyed

#

and i kept getting confused

floral furnace
#

then you had to use do not destroy on load right?

copper nacelle
#

no i just let it die

floral furnace
#

alright

copper nacelle
#

I added a OnDestroy thing to my MonoBehaviour

#

which unhooked my functions

#

and made it so it adds the component onsaveload and stuff

floral furnace
#

ok ok thanks

rain cedar
#

Some stuff doesn't make sense to me, which I added comments for

flat forum
#

Oh

#

Wow

#

Thanks

#

What did you use for reference tho?

#

The latest version is the dll I sent

rain cedar
#

I just put the assembly you posted in dnspy

flat forum
#

I don't think I posted the .cs to Github

#

"These debuffs wpuld stack prettu harshly" - yeah I agree. I thought of trying to fix that later but thanks =D

#

The Reducing Nail Damage was because the FStrength effect is always there

#

I can't remove it

rain cedar
#

Yeah it's a multiplier set manually in the fsm

flat forum
#

So in order to get the value I wanted I lowered the damage so that when it's multiplied by FStrength it gives me the result I wanted

rain cedar
#

Alright

flat forum
#

The scaling on only 1 axis is intentional

#

And the last thing - it's on AfterAttack as the other one started getting crowded and I was afraid not to get lost

rain cedar
#

In visual studio you can do something like

#region stuff
//code
#endregion
#region otherstuff
//more code
#endregion```
flat forum
#

So I decided that I'll go with the tidier option

rain cedar
#

It adds minimizers to the sidebar

flat forum
#

?

#

Really

#

Coooollll

rain cedar
solemn rivet
#

wow, looking at your code, you actually did a lot, Papers!

#

good job!

#

AA: adding optional dependencies now!

solemn rivet
compact sedge
#

Thank you so much

flat forum
#

Thanks a lot Gradow! happygrub omggrub

#

Looking to add a few more things now

solemn rivet
#

tha hard part now is handling case

#

because your files are all in lowercase, but all other mods have proper capitalization

compact sedge
#

sorry :( I could fix my mods

solemn rivet
#

nah

#

I'll figure something out

compact sedge
#

well then add .ToLower() maybe when comparing if the strings are the same?

solemn rivet
#

yeah, I'll do something like that

#

also

#

yikes, is this code messy

#

oh boi

#

I need to clean this up

compact sedge
#

Well I wasn't gonna look but:

Settings.cs
Settings1.cs

solemn rivet
#

wut

#

oh

#

settings1 is the icons

compact sedge
#

beats my naming convention so

#

¯_(ツ)_/¯

solemn rivet
#

if (installedMods.Any(f => f.Equals(dependency + ".dll", StringComparison.InvariantCultureIgnoreCase))) continue;

#

no, that's the VS default naming

#

I can fix that, but I don't really mess with the icons at all

#

so I don't bother

compact sedge
#

ahh ok

solemn rivet
#

I really should rewrite this from scratch

#

this is so ugly

#

I was learning as I went, se there are like a thousand residual bad ideas lingering around

#

I think for now I'll rewrite the list filling method

lofty crescent
#

Does anyone have any tips on how I can start modding this game?

flat forum
#

well

#

with something easy?

#

I just started modding not so long ago

#

Is there anything you wish to mod specifically?

lofty crescent
#

Online coop e.e

flat forum
#

Ooohh

compact sedge
#

uhhh

flat forum
#

interesting

#

but sounds

#

uhhh

solemn rivet
#

uhhhh

#

good

#

luck

lofty crescent
#

ikr

solemn rivet
#

eh

#

know c#?

flat forum
#

How should this work?

compact sedge
#

tbh I don't know how to do online in any language

lofty crescent
#

Im guessing the API wont really apply to this?

flat forum
#

from a coding perspective

solemn rivet
#

online is a nightmare

compact sedge
#

you'll need the API to make a mod that's compatible with other mods but it's not gonna help you with the multiplayer aspect

solemn rivet
#

if anything, I'd start with a local coop

flat forum
#

local

solemn rivet
#

which shouldn't be terribly hard

flat forum
#

yeah

compact sedge
#

only god can save you if you wanna do online coop

solemn rivet
#

time consuming, sure

young walrus
#

lol. good luck with that mod

solemn rivet
#

worth the effort? Prolly not

#

but possible

flat forum
#

(I wanna thank Gradow again for saying I did a lot)

solemn rivet
#

nah, mate

#

you really did

flat forum
lofty crescent
#

So what is this API and how would I go about using it?

flat forum
#

the API

#

is a replacement to the Assembly-CSharp.dll file

#

that allows you to use mods

solemn rivet
#

in short, that

young walrus
#

Pretty sure a multiplayer mod would require a complete rework of how the player functions work and how the game handles triggers and shit with that

#

so have fun

lofty crescent
#

sure would

#

But there can be shortcuts

solemn rivet
#

the API is a version of the game's assembly modified by the modding community to allow for loading external libraries during runtime

#

and that's how most of HK's modding is done

lofty crescent
#

Ok

#

Can I get a look at it?

solemn rivet
#

sure

#

the source should be on github

lofty crescent
#

Uh

#

Link?

#

pls

solemn rivet
#

you can find the binaries in the gdrive in the pins

lofty crescent
#

Thanks

#

oooo

#

I can open it in visual studio?

solemn rivet
#

sure

flat forum
#

yeah

solemn rivet
#

you need to copy the references from the game tho

#

but sure

lofty crescent
#

o k

#

will try

solemn rivet
#

if you simply want to take a look at the code, I'd suggest installing dnspy and opening the compiled binary

#

easier tbh

lofty crescent
#

will try that too

solemn rivet
#

also dnspy = hklove

lofty crescent
#

Is there a link to dnspy somewhere

solemn rivet
#

pins

lofty crescent
#

taa

solemn rivet
#

anything you need in this channel should be in pins imo

compact sedge
#

Is there a way to make a collider not actually collide with anything? Just run a function on intersection?

#

I can't see anything in the docs for it but maybe I'm just blind

flat forum
#

won't making it infinitely small work?

compact sedge
#

no I want it to function as a trigger

#

aka run a script when it collides

#

I'm thinking just removing the Rigidbody2D will work

flat forum
#

I wanna test something quickly

#

which part of the animation does AfterAttack affect?

#

is it the last frame?

solemn rivet
#

AA: running your script on onColliderEnter/onTriggerEnter won't work?

compact sedge
#

no the script runs but it ALSO acts as a collider

#

even if I set the physics to kinematic

#

but if the physics are kinematic

#

I might as well not have them

solemn rivet
#

hm...

sage flare
#

Hi! Just want to say thanks to everyone for the amazing mods and helping me get set up yesterday. This is so much fun.

flat forum
#

glad you're enjoying the mods people have made

#

what mods did you try?

sage flare
#

So far, only the randomizer. It's so different, and I'm excited to try out the others.

flat forum
#

Glad you are

sage flare
#

I'm used to the ALTTP Randomizer, but Hollow Knight is more constrained at the start so it's much more difficult

flat forum
#

I found InfiniteGrimm really enjoyable and BlackMoth interesting, although hard

#

and I'm currently adding stuff to my mod as well

#

so I can release it sooner or later

sage flare
#

Nice! What do you have going in yours?

flat forum
#

well

#

it's a buff to a few nail affecting charms

#

Fury of the Fallen,
Fragile/Unbreakable Strength
Longnail
Mark of Pride
Quickslash

#

wait, I have a decription of changes here somewhere

sage flare
#

Nice - I'm a fan of the nail combat

#

My first play through I think I never even used soul stuff

#

Hardly ever anyways

flat forum
#

List of changes
Fragile/Unbreakable Strength gives a powerful buff when at max health. Getting hit at max health deals double damage
Fury of the Fallen now makes you stronger based on health lost and not just at 1 health
Longnail Nail is now x1.5 longer. You deal x0.8 damage
Mark of Pride Nail is x1.75 longer. You deal x0.7 damage
Quickslash You attack very fast. You deal x0.5 damage

Combinations:
Fragile Fury - the Fragile/Unbreakable Strength activates at max health and at 2 or less health. You are constantly overcharmed
Long Mark of Pride - nail is x2.25 longer, but deals x0.5-x0.6 damage

trying to combine charms with different effects - Nail Length and Damage, Nail Length and Speed and Nail Length and Speed and Damage punishes you - you deal only 1 damage and your attacks are slower

#

here it is

sage flare
#

Interesting...

flat forum
#

I still have a few things to add

sage flare
#

Fragile fury instantly causes overcharmed?

flat forum
#

the biggest one being a charm - Gods' Glory

#

yeah

#

Fragile Fury makes you very OP, but overcharmed

sage flare
#

Sweet!

flat forum
#

I'll ask around and try adding it soon

#

but

exotic venture
#

so long MoP + QS means very fast x2.25 range but at x0.25 dmg?

flat forum
#

after a short break

#

Oh

#

I think?

#

wait

#

no

#

that's a Punishmen

exotic venture
#

this is a buff?

flat forum
#

no nail range and 1 damage

#

had it not been for the Punishment it would have been so tho

exotic venture
flat forum
#

hehehe

#

because

#

I need a better reason to add the final charm

#

also being stupidly OP isn't all that much fun

exotic venture
#

this mod is advocating nail users to kick the bucket and use spells instead

#

wew

flat forum
#

but you can have one of the older, broken versions

#

where you end up with 400 damage the moment you get hit

exotic venture
#

literally the same vein as hell mod

flat forum
#

Nah

sage flare
#

Random idea: what about a charm that makes the nail do zero damage and gives you a ton of soul each hit?

flat forum
#

Um

young walrus
#

so.... dream nail?

flat forum
#

the moment your nail damage becomes 0

exotic venture
#

^

#

YEET

sage flare
#

Dream nail is slower though

exotic venture
#

what mick said

compact sedge
#

just make it 1 dmg then

flat forum
#

you can't hit stuff

young walrus
#

dream wielder tho

#

and then double soul

sage flare
#

Pogo

young walrus
#

super fast swing

sage flare
#

Guess that's fair

exotic venture
#

but yeah the damage nerfs already seem way too overkill

#

longnail is basically MoP for 1 notch less but kicks damage in the nuts

#

MoP curbstomps it into the ground

#

and both of them just murder it

flat forum
#

so, @exotic venture , the idea behind adding the punishment was that each effect was balanced by itself - getting a lot of damage had it's downs. Very big nail meant you don't get hit so easily, so keeping the original nail damage was too OP. So combining them you get away with the balancing on Longnail/MoP

#

that's the reason I added it

#

so you choose to either go super fast, super strong or from a great distance

exotic venture
#

but standalone they make no sense to use so mantiswhy

flat forum
#

what do you mean?

#

standalone they're already very OP

#

Quickslash is like x3-x4 times faster than normal nail

#

that's still double the DPS

exotic venture
#

Longnail Nail is now x1.5 longer. You deal x0.8 damage

#

this just sucks though

flat forum
#

Ok

#

how about I do

#

Longnail - x0.9 damage
MoP - x0.8
both - x0.7

exotic venture
#

also what the heck do you need all that range for anyway

flat forum
#

idea is that it's now harder to get hit

#

(I HAVE NO IDEA WHAT YOU'D NEED SO MUCH RANGE, I'M JUST THE ONE WHO PROVIDES IT)

exotic venture
#

have you even tested what it looks like?

flat forum
#

yeah

#

pretty good

young walrus
#

you don't need to bounce enemies all over the room with heavy blow

#

but hey, you have that option

exotic venture
#

doesn't it just look blatantly ridiculous though

flat forum
#

it looks...

exotic venture
#

also heavy broken is just broken

flat forum
#

interesting

#

ok

#

how about I change the punishment to work this way

exotic venture
#

maybe you don't need to alter them tbh

flat forum
#

equipping 2 Godkiller charms Overcharms you

#

equipping 3 punishes you

#

now you can have Fragile MoP

young walrus
#

salubra punish me

exotic venture
#

mick no

flat forum
#

(I just had to make a stupidly long na-)

#

Mick

young walrus
flat forum
#

Salubra's mere existance is torture

#

go get Salubra's blessing

young walrus
#

but then i'd have to change pants

flat forum
#

punishment

leaden hedge
#

Just make them cost 420 notches

flat forum
#

yeah

#

I played around with that idea

#

but

#

what if the players wants to take their Compass and Gathering Swam and...

#

ummm

#

their

#

uuuhhhhh

#

Kingsoul

#

and Hiveblood

compact sedge
#

you know what'd be cooler. Long nail does normal damage but takes a very long time to attack

flat forum
#

and Joni's blessing

#

AA

compact sedge
#

and it has a very narrow range

flat forum
#

no

compact sedge
#

basically make it a spear

flat forum
#

yes

#

actually

#

but

#

Ok

#

that's doable

#

tommorow

#

but I'll require your help for the Gods' Glory charm

#

Ok

compact sedge
#

look I require help just to get stupid fireball physics

#

it's hard

flat forum
#

next version will rework MoP and Longnail into spears

#

maybe add some charm description

sage flare
#

Or maybe Mark of Pride makes your nail the equivalent of the club the big guards use? Takes ages to hit but has big range and power? I dunno

flat forum
#

I'll see

#

but now

compact sedge
#

make every charm turn the nail into a different kind of weapon

flat forum
#

That's an itneresting idea

#

but please

#

let me sleep

compact sedge
#

Yes sleep. Have good dreams

flat forum
#

I'll have

compact sedge
#

radiant dreams

flat forum
#

R A D I A N T D R E -

#

WHY

#

WHY ARE YOU SO FAST

#

you're the prophet, right

#

ok

#

now seriously

solemn rivet
#

code is so clean now

#

worth the time imo

compact sedge
#

just make one region at the very start to hide all your code. then it will look 100% clean

solemn rivet
#

that's evil

#

it's honestly cleaner now tho

#

easier to navigate too

compact sedge
#

based on the force of gravity, 1 unity unit ~~~~ 10cm. And I know Graig said game code isn't canon but if people are gonna accept the quirrel thing then this seems legit too.

dusky lion
#

Quirrel thing is wrong.

#

Also @copper nacelle I am ready

solemn rivet
#

quirrel thing?

compact sedge
#

oh quirrel must be dead because some game code calls him dead even though it's never mentioned in game

dusky lion
#

His sword is named quirreldeath.png when it is left behind at the Blue Lake.

solemn rivet
#

oh, that thing

#

well

dusky lion
#

I don't think that to be true because it very well could have been a scrapped idea and they just never changed the name of the sprite.

solemn rivet
#

if code is canon, then Herrah was the FK

#

just sayin

dusky lion
#

FK?

solemn rivet
#

false knight

dusky lion
#

Oh

exotic dune
#

Forest of Bones exists bc its in the localisation then

dusky lion
#

Forest of Bones should exist.

compact sedge
#

huh even if I set my game object to a layer that the knight isn't on the collider still collides with the knight. But not the floor?!

#

adding ignoreherocollision fixes the hero part

#

so I guess the hero collision code is independant of layer

#

which is weird because all other collision code isn't

solemn rivet
#

that's weird

#

knight doesn't collide with some objects like geo caches and destructable stuffs

#

unless those are ignoreherocollision too

compact sedge
#

the normal behavior for the collider2d is they collide with all objects on the same layer. when they're attaced to a rigidbody2d they will also collide with all other rigidbody2ds that aren't set as kinematic regardless of layer

#

as far as I know

#

but for some reason the knight collision code seems independant of all this

compact sedge
#

yes this behavior is what I've observed. except they do run collision scripts with kinematic rigidbody2d they just don't push stuff/be pushed and will clip through these objects.

solemn rivet
#

there's only one thing left to fix in the installer

rain cedar
#

*that you know of

compact sedge
#

using / as slash instead of \

solemn rivet
#

there's only one thing left to fix in the installer

#

for some reason, it's asking to install dependencies that are already installed

#

after I fix that, I'll post a release here

compact sedge
#

oh or that

#

rip ur internet btw

solemn rivet
#

my internet has been rip the whole day today

#

AA: I can fix slashes, but is the folder structure similar in other OSs?

compact sedge
#

wdym

#

actually I'll try to fix it

#

don't worry about it

solemn rivet
#

I mean

#

where is the Mods folder located on other OS?

compact sedge
#

same as windows except it's case sensitive

solemn rivet
#

hm..

compact sedge
#

The correct case sensitive path is:
hollow_knight_Data/Managed/Mods

#

much to half the modders' displeasure I pinged like 4 people almost a week ago because they had a zip file with the wrong case sensitive structure.

solemn rivet
#

yeah

#

I should have fixed mine

compact sedge
#

You didn't have any problems with yours

#

I pinged ttacco, kerr, and kdt who each had exactly 1 mod with the wrong structure and all others with the proper one.

solemn rivet
#

oh

#

okay

#

everything should be working now

#

there are still some residual stuff from failed features, but they're not that visible anymore

#

mods should also be in alphabetic order now

#

so that's neat

compact sedge
#

defaultPaths.Add($@"Steam\steamapps\common\Hollow Knight")
please tell me nobody actually installs steam like this to just the root of their C drive.

#

not hating but I'm just confused

solemn rivet
#

no

#

56 has it in the root of his D drive

#

he likes the D

compact sedge
#

ok that's reasonable it just seems weird having it on the C drive where there's a bunch of folders and files

solemn rivet
#

yeah

gray nymph
#

the hollow knight rando tracker doesnt connect for my friend, any ideas why?

solemn rivet
#

ehhh

#

Vmi was complaining about it sometime ago

solemn rivet
#

Updated download link for the modinstaller in pins

compact sedge
#

Hey how do I switch out the sprite on a SpriteRenderer?

When I run some code on the following SpriteRenderer with an existing sprite:

fireballSprite.sprite = Sprite.Create(fireballMagmas[frame], r, Vector2.zero); fireballSprite.enabled = true; fireballSprite.color = Color.white;
my object just disappears

#

the code runs btw but idk what I'm doing wrong

#

it iterates through all the frames too

solemn rivet
#

maybe it's behind the background?

compact sedge
#

the image renders fine as the fireball but when I switch it to the magma sprite it disappears

solemn rivet
#

dunno then

compact sedge
#

idk if there's any glaring problems or if I'm doing this all wrong

solemn rivet
#

if you set it to specific frame instead of looping through the frames, does it work?

compact sedge
#

no

#

ok nvm I found the problem I'm actually stupid

#

my sprite is blank

#

whoops

solemn rivet
#

yeah, was about to say that

#

you never do anything with fireballMagmas

compact sedge
#

no I do it's just

[INFO]:[Redwing] Unable to build fireball magmas. Error System.IndexOutOfRangeException: Array index is out of range.

#

so messed up my gen code

copper nacelle
#

git reset --hard

solemn rivet
#

wut

compact sedge
#

oh I fixed it btw just had the wrong variable in a for loop

solemn rivet
#

nice!

copper nacelle
solemn rivet
#

git --gud

#

oh

#

someone was looking for you earlier today, 56

copper nacelle
#

oh yeah

#

@dusky lion

solemn rivet
#

it would be fitting if his name was finchfinchfinch...finch 56 times

hazy sentinel
#

it would be fitting if 32 character limit

solemn rivet
#

although fitting it wouldn't fit thinkgrub

compact sedge
#

finch^56

warped sinew
#

Is it possible to mod an endless Colosseum?

#

That would be pretty great

#

Random enemies

hazy sentinel
#

graig get 15k on IG hard mode

#

pls

warped sinew
#

What's the record??

#

I played it a bit got to about 7k

compact sedge
#

I think veru has the best score right now

flat forum
#

For InfiniteGrimm?

warped sinew
#

I was actually thinking of streaming some IG yesterday too

flat forum
#

Oohhh

#

I'd loke to see

compact sedge
#

People who have posted it in the discord the score is:

  1. Verulean (9832)
  2. Graig (~7500)
  3. Me (5977)
  4. 56 (~5900)
flat forum
#

For Hard Mode?

compact sedge
#

yes hardmode

warped sinew
#

Oh wow, yeah my highest score is about 7.5 k

compact sedge
#

shoot let me update it then

warped sinew
#

I didn't post a PIC tho

flat forum
#

I'm gonna try hard mode as well

hazy sentinel
#

add a high score tracker imo

compact sedge
#

Your top scores are saved in your save file

warped sinew
#

Nah don't update it, I'll stream a better score :p

compact sedge
#

so you could send your save file and I could tell you your top score

flat forum
#

I'LL TRY THE GPDSLAYERS AGAINST INFINITEGRIMM

compact sedge
#

but it doesn't tell me if you got it in hardmode or normal mode

warped sinew
#

I'm at work right now for the next 5 hours :(

flat forum
#

(Make sure it says if it's hard mode)

warped sinew
#

I'll stream it when I get home

compact sedge
#

uhh keep working because I want me some GnG

warped sinew
#

Yeah of course hard mode lol

flat forum
#

I'd love to see

warped sinew
#

Normal mode I don't think I would get hit

flat forum
#

Hey

compact sedge
#

but if you do you can enjoy a good 60-100 hits without a single stagger

flat forum
#

Gonna remake the Punishment system for GodSlayers

compact sedge
#

alright

#

what do you have in mind?

solemn rivet
#

damn, I have to work on my IG scores

compact sedge
#

I really wanna not be second to last place but I also wanna work on my mod so I'm torn

warped sinew
#

Make Infinite Colosseum

compact sedge
#

smh let me finish the next lightbringer my small fire mod first

warped sinew
#

Heh

flat forum
#

Infinite Colosseum...

warped sinew
#

@pearl sentinel would it be very difficult to mod enemy randomiser into an infinite Colosseum? Can the Colosseum even be edited??

flat forum
#

Interesting idea

pearl sentinel
#

probably not too bad, it's an idea i had once for enemy rando

flat forum
#

It can juat pick a random wave to spawn?

warped sinew
#

Imagine a timer and wave counter too

flat forum
#

Yeah

warped sinew
#

Would be pretty great I think

flat forum
#

Infinite Trial of Fools where the God Tamer randomly shows up

warped sinew
#

@pearl sentinel heh I knew you would have already thought about it

compact sedge
#

Infinite god tamer but every 500 damage you do spawns another random ToF wave on top

flat forum
#

HAHAHA

#

Y E S

hazy sentinel
#

infinite nightmare god tamer god

warped sinew
#

She riding NKGs back

flat forum
#

Infinite Crystal Nightmare Radiant Primal God Tamer

exotic dune
#

God Tamer but every time you kill it, it spawns again with another God Tamer

#

... Lords

compact sedge
#

I wonder if you could fight god tamer and NKG together

#

What about a mod that pairs you against two random bosses

hazy sentinel
#

could probably just damage rush god tamer

flat forum
#

Well

#

A mod that pairs you against 2 random bosses may give you impossible encounters

exotic dune
#

anyone hard + watcher knights

warped sinew
#

Yeah imagine something like dung defender and...... White defender!?

flat forum
#

Imagine Traitor Lord and Grey Prince Zote

#

Imagine Noght King Watcher Knights

hazy sentinel
#

beta radiance + gpz 10

flat forum
#

Cannot implicitly convert type 'int' to 'bool'

regarding this line

if (Punishment = 2)

warped sinew
#

Beta radiance basically just fight two radiance anyway

exotic dune
#

is punishment a bool

compact sedge
#

2 equals signs

flat forum
#

ok

compact sedge
#

punishment is an int

#

but 1 equals sign just sets punishment equal to 2

flat forum
#

Ok

compact sedge
#

and doesn't compare

flat forum
#

yeah

#

should remember that

#

so

#

reworked the Punishment thing

#

now combining 2 won't punish you

#

but combining 3 will

#

per asking from Mystery

compact sedge
#

any 2 is ok?

flat forum
#

yeah

#

and any 3 breaks

compact sedge
#

so what's the interaction between strength and the long nail

#

for example

#

like what's the damage output with both on and what's the range

wintry aurora
#

Oh an active channel

flat forum
#

Range is still 1.5 and damage output at max health is 51

wintry aurora
#

Thank god

flat forum
#

it gets set to lower after you lose your health

#

(it gets set to the usual Longnail damage)

#

without Longnail damage is 63

wintry aurora
#

Imma just watch you guys talk since i know nothing about mods and modding and coding and all that stuff

flat forum
#

well

#

we're talking about what do mod does right now

#

so, no code talk

wintry aurora
#

Yay

#

Is this the godof boyslayer mod?

flat forum
#

yeah

#

reworked the punishment

compact sedge
#

so what's the downside of strength

#

I forgot

wintry aurora
#

What is even the punishment

#

One hit death?

flat forum
#

well

#

almost no nail damage, nail is very slow

#

uh

#

yeah, always Overcharmed

#

should I also empty your soul

compact sedge
#

I mean it's already stupid to try to play the game that way

#

don't need to go to meme levels of stupid

wintry aurora
#

So either use strength and fotf or mop and long nail use all four and you get punished.

flat forum
#

hmmmmmm

#

use any 2 and you're just overcharmed, use any 3 and you're punished

wintry aurora
#

Any combination is allowed even range with damage charms?

copper nacelle
#

imo set soul limited, overcharmed, disable soul gain, and disable healing

#

ez

flat forum
#

AA, well, you're still gaining soul, so a Spell build in that case will work

compact sedge
#

not as much tho because super slow attack speed

#

it's already so shitty nobody would do it

flat forum
#

mmmyeah

#

but

compact sedge
#

except for a meme video

#

like "hey let me take FotF and fragile strength so my damage becomes 1"

flat forum
#

there's always those people that go like "I'll do Path of Pain AND fight NKG with my hands tied to my back and only using my nose"

exotic dune
#

tbh why not just play Blackmoth and only use your nail

#

quicker and easier

flat forum
#

Ok

#

leaving the soul as it is

#

(maybe at least disable healing?)

wintry aurora
#

Can you combine a damage charm with a range charm without getting punished? Or are the only allowed combos strength and fotf or mop and long nail?

flat forum
#

yeah

#

you can combine any 2 of the God Charms and you'll just be overcharmed

wintry aurora
#

Nice, sounds really good.

copper nacelle
#

just overcharm w/ them

#

ez

flat forum
#

overcharmiing isn't a problem

#

it's basically a minor setback

#

time to test it against InfiniteGrimm

#

maybe hard mode

#

also

#

QuickSlash's Damage is pretty low

#

but try equipping it with Soul Eater

#

and you'll end up with a not bad Spell Build

compact sedge
#

4 dmg nkg sounds like more than a minor setback but what do I know

flat forum
#

?

#

Why 4 damage

#

Only case you'll get 4 damage is with Nail1 and Longnail

#

oh, mentioning Longnail

compact sedge
#

no I mean being overcharmed while fighting NKG

flat forum
#

you wanted me to rework those into Lances - thinner, but dealing the same damage

compact sedge
#

you take 4 dmg

flat forum
#

Oh

#

Yeah

#

that

#

isn't Good

compact sedge
#

and you say it's a minor setback

#

but that sounds pretty reasonable

flat forum
#

it's a minor setback most of the time

copper nacelle
flat forum
#

REWORK FRAGILE HEART INTO INFINITEHEALTH

wintry aurora
#

Lmao angle i think got 5k on infinite nkg and finds it easy to do it hitless

#

Don't trust him

#

He's evil

copper nacelle
#

what

compact sedge
copper nacelle
flat forum
#

Ok

wintry aurora
#

Didn't you get 5k on infinite grimm?

flat forum
#

I have hard mode turned on

#

time to test

#

also, how do I change charm name?

compact sedge
#

actually 5977

copper nacelle
#

language get hook

compact sedge
#

but can't do repeating

wintry aurora
#

Anyways i might have to go soon. Since it's late

flat forum
#

Blackmoth does something similar, but changes only descriptions:

                    case "CHARM_DESC_13":
                        ret = @"Freely given by the Mantis Tribe to those they respect.
Greatly increases the range of the bearer's dash, allowing them to strike foes from further away.";
                        break;
copper nacelle
#

have u tried

#

using

#

the

#

language

#

get

#

hook

#

u dungo

compact sedge
#

blackmoth does too

#

use that hook

flat forum
#

no

#

I mean

copper nacelle
#

blackmoth also changes charm names

#

ur bad

flat forum
#

really?

copper nacelle
#

yeah

#

longdash

#

etc

flat forum
#

oh yes

#

I neeed to learn to read

flat forum
#

there's a CornyWokest emoji

#

go get and use that one

flat forum
#

Y E S

flat forum
#

'GodKillers.Description(string, string)': not all code paths return a value
regarding this

string Description(string key, string sheet)

compact sedge
#

return the default key and sheet if you aren't editing it

flat forum
#

I have this right under it

#
string ret = Language.Language.GetInternal(key, sheet);
            if (sheet == "UI")
compact sedge
copper nacelle
#

have u tried showing the whole code

compact sedge
#

see this except I have my key and value backwards

#

but otherwise it's right

#

notice line 46 at the end

flat forum
#

@copper nacelle
here's the whole thing

        string Description(string key, string sheet)
        {
            string ret = Language.Language.GetInternal(key, sheet);
            if (sheet == "UI")
            {
                switch (key)
                {
copper nacelle
#

that's objectively false

compact sedge
#

whole thing

#

doesn't have closing brackets

flat forum
#

I mean

compact sedge
#

found your problem

copper nacelle
#

have u tried looking at the word

#

whole

flat forum
#

I didn't want to put the entire part with the descriptions in here

compact sedge
#

jesus use git or something so you can link the line

flat forum
#
string Description(string key, string sheet)
        {
            string ret = Language.Language.GetInternal(key, sheet);
            if (sheet == "UI")
            {
                switch (key)
                {
                    case "CHARM_DESC_13":
                        ret = @"Freely given by the Mantis Tribe to those they respect.

Turns the nail into a Lance, greatly increasing its range, but decreasing its strength. Allows the bearer to strike foes from further away.";
                        break;

                    case "CHARM_DESC_18":
                        ret = @"Turns the nail into a Lance, increasing its range, but slightly decreasing its strength.";
                        break;

                    case "CHARM_DESC_25":
                        ret = @"Strengthens the bearer, greatly increasing the damage they deal to enemies when at full health,
But once the bearer loses health they will lose the power as well, only gaining it back after focusing.

This charm is fragile, and will break if its bearer is killed.";
                        break;

                    case "CHARM_DESC_25_G":
                        ret = @"Strengthens the bearer, greatly increasing the damage they deal to enemies when at full health,
But once the bearer loses health they will lose the power as well, only gaining it back after focusing.

This charm is ubreakable.";
                        break;

                    case "CHARM_DESC_32":
                        ret = @"Born from imperfect, discarded weapons that have fused together. The weapons still long to be used.
The Bearer will attack much more rapidly, but the attacks will be weaker";
                        break;

                    case "CHARM_NAME_18":
                        ret = @"Lance Nail";
                        break;

                    case "CHARM_NAME_13":
                        ret = @"Lance of Pride";
                        break;
                }
            }
        }
#

too lazy

#

here's the whole block

copper nacelle
#

where's the return ret

compact sedge
#

you don't have return ret;

#

at the very end

flat forum
#

...

#

Ok

#

thanks

copper nacelle
#

deletGrimmChild = false;

compact sedge
#

give me a break didn't know about IEnumerator

#

and coroutines

#

really redwing is the first project of mine to use them at all

flat forum
#

LanceNail is pretty fun

#

Also, the fact you can't combine many charms makes choosing charms trickier

#

I used to always go around with Unbreakable Strength, Quickslash and MoP

#

but now I can't quite

wintry aurora
#

Imo use strength and fotf

copper nacelle
#

imo use str fotf mop quickslash gathering swarm wayward compass

wintry aurora
#

Are other charms that aren't god charms allowed to go with two god charms and not punish you? @flat forum

flat forum
#

not yet

#

Hey, AA

copper nacelle
#

🅱🅱

compact sedge
#

ye

flat forum
#

are you sure Hard Mode doesn't also affect the normal NKG fight?

#

dude seems faster

#

than usual

compact sedge
#

100% sure, ur just bad

#

/s

flat forum
#

Ok

compact sedge
#

if it's normal NKG the mod won't activate at all

flat forum
#

gotta get used to it

compact sedge
#

although if you don't believe me check the log

flat forum
#

I believe you

compact sedge
#

actually wait

#

are you doing normal NKG with debugmod

#

there's technically undefined behavior in my mod that can happen by setting NKG to false while in game. since that's never supposed to happen in any legit game.

flat forum
#

normal NKG with debug mod and InfiniteGrimm

compact sedge
#

but shouldn't be anything major

copper nacelle
#

:ech:

flat forum
#

ok

copper nacelle
#

iirc the fight still gets faster

#

and then he dies

#

if you do that

compact sedge
#

no

#

well

#

if you set killed NKG to false while in the tent you won't need grimmchild but the fight should still be normal

copper nacelle
#

what about outside the tent

compact sedge
#

if you set it outside the tent but in dirtmouth... shouldn't affect anything afaik

#

if you set it while IN the NKG fight dream

#

god help you

copper nacelle
#

unrelated how do you get superglue off a mouse

compact sedge
#

strong acid/base?

#

probably not the best idea

#

might melt the plastic

copper nacelle
#

can't find the nailpolish remover

compact sedge
#

rubbing alcohol

#

maybe

copper nacelle
#

i don't have that

#

finna find my micromesh

compact sedge
#

ur not doing anything with cloth and water

#

if it's fully hardened

#

go to sleep and do it tomorrow

copper nacelle
#

pain

flat forum
#

beat NKG

#

with Strength I'm very OP at full health, but then end up fighting NKG with Nail2

compact sedge
#

does strength get weaker when you lose health?

flat forum
#

yeah

#

very OP at max health

#

at 1 health below your max it's normal nail damage

#

and then gets lower and lower

#

FotF+FStrength negates that effect - makes you very strong at max health and very low health and sets your damage to a bit lower than normal otherwise

#

gonna test it against InfiniteHardGrimm now

#

FotF + Lance of Pride should be a good combo

copper nacelle
#

apparently if you set nkg to killed in the tent

#

it just says you did 0 damage

#

and if you have grimmchild the spawn breaks

compact sedge
#

and since you can't do that without cheating I'm not patching it

copper nacelle
#

is grimm supposed to talk in hard mode

#

cause he doesn't

compact sedge
#

no, he's supposed to appear then disappear

#

is that happening?

copper nacelle
#

yes

#

i was trying to get him to talk

#

but he'd just run away

compact sedge
#

infinite grimm features:
* Rewrites Hollow Knight lore

copper nacelle
#

and now I went out of the tent

compact sedge
#

from readme

copper nacelle
#

came back in w/out grimmchild

#

went into the fight

#

and have grimmchild

#

wait no

#

wtf

#

i put on grimmchild instead of soul eater