#archived-modding-development | Hollow Knight | Page 108

rain cedar Jun 1, 2018, 5:54 AM

#

Good question

#

I can ask my sister

#

She has a degree in linguistics

compact sedge Jun 1, 2018, 5:55 AM

#

woo now we have much higher pitched cicadas plus a beating heart underlying it

flat forum Jun 1, 2018, 5:55 AM

#

((double)((int)(PlayerData.instance.GetInt("nailDamage") * (double)1.25) + ((int)(PlayerData.instance.GetInt("nailDamage") * (1 + 2.0 * ((PlayerData.instance.GetInt("maxHealth") - PlayerData.instance.GetInt("health")) / (double)PlayerData.instance.GetInt("maxHealth")))))) * (double) 0.75));

regarding which part of that is this thing?

Argument 2: cannot convert from 'double' to 'int'

rain cedar Jun 1, 2018, 5:56 AM

#

Clean that shit up my dude

flat forum Jun 1, 2018, 5:56 AM

#

yeah

#

trying to

rain cedar Jun 1, 2018, 5:56 AM

#

It's getting close to unreadable

flat forum Jun 1, 2018, 5:56 AM

#

it gave me this mid-way cleaning

floral furnace Jun 1, 2018, 5:56 AM

#

you have to cast it like
int intVar = (int)(5 * 2.3)

#

theres no need to cast 1.25 into a double

compact sedge Jun 1, 2018, 5:58 AM

#

anyone have adobe audition on their computers?

#

I need a very simple favor

#

I'll ask in meme

#

why not

rain cedar Jun 1, 2018, 6:13 AM

#

Ok an explosion looks like this apparently https://cdn.discordapp.com/attachments/319652494093320194/451991492819550208/Screenshot_2.png

#

So make that

pearl sentinel Jun 1, 2018, 6:14 AM

#

👌

compact sedge Jun 1, 2018, 6:35 AM

#

oh thanks that's literally what I was looking at and uh totally helpful....

#

found a great pink noise generator though

#

well in c++, so I copied it to c# and uh it mostly works

solemn rivet Jun 1, 2018, 4:02 PM

#

@Nicolas239#4540 we don't use hooks anymore. Try ModCommon

#

wut

flat forum Jun 1, 2018, 4:03 PM

#

tag didn't work?

solemn rivet Jun 1, 2018, 4:03 PM

#

wtf

flat forum Jun 1, 2018, 4:03 PM

#

try tagging me

solemn rivet Jun 1, 2018, 4:03 PM

#

@flat forum sup

flat forum Jun 1, 2018, 4:03 PM

#

Ok

#

this works

#

but that one didn't

#

hm

solemn rivet Jun 1, 2018, 4:03 PM

#

well

#

they're not in the channel anymore anyways

hollow pier Jun 1, 2018, 4:03 PM

#

left server duh

compact sedge Jun 1, 2018, 4:05 PM

#

rip

solemn rivet Jun 1, 2018, 4:10 PM

#

why not A Procedural Cicada?

compact sedge Jun 1, 2018, 4:11 PM

#

I actually sorta figured out explosions

#

white noise

speed up

low pass

speed up

low pass

etc.

#

don't touch signal generators. I was really proud of making a sine wave thingy and later a sawtooth one but they make the cicada noises

solemn rivet Jun 1, 2018, 4:14 PM

#

huh

#

you need more Fourier m8

compact sedge Jun 1, 2018, 4:14 PM

#

I actually mentioned that when I started

#

in theory I can do everything with a sine wave thingy

#

but in practice I know calculus BC so I only know that it's possible in theory and not how to actually do it

solemn rivet Jun 1, 2018, 4:16 PM

#

well

#

you need sines and cosines

#

but yeah

#

tbh I'm not much into that area of maths, only did basic undergrad courses on that stuff

#

so, idk

#

I do know that any continuous function can be approximated as much as you'd like by a polynomial

#

the Stone-Weierstrass theorem

flat forum Jun 1, 2018, 4:23 PM

#

Sines and cosines

#

How do those function in circles?

floral furnace Jun 1, 2018, 4:25 PM

#

Uhh im guessing its the waves he needs to pitch the sound and shit

young walrus Jun 1, 2018, 4:26 PM

#

are you trying to code a sound? or would a sound file be needed?

compact sedge Jun 1, 2018, 4:26 PM

#

the brilliant part is sines are cosines so yeah just sines

#

sines are cosines shifted 90 degrees

solemn rivet Jun 1, 2018, 4:27 PM

#

well, yeah, but

compact sedge Jun 1, 2018, 4:27 PM

#

you do need to have some shifting

#

you can't do it with just sines at the origin

solemn rivet Jun 1, 2018, 4:27 PM

#

iirc the Fourier series for a periodic function does differ between sines and cosines

compact sedge Jun 1, 2018, 4:27 PM

#

hmm probably

solemn rivet Jun 1, 2018, 4:27 PM

#

I think it has something to do with the coefficients of the expansion

#

like, all sine functions have a certain coefficient, and all cosines have another (and those coefficients can be functions themselves)

#

wiki delivers

📎 4b46d730f0a556e35ea161b76b5acb02ed3a9544.png

#

wut

#

transparent png

#

ffs

flat forum Jun 1, 2018, 4:29 PM

#

SinA=Cos(90-A)

solemn rivet Jun 1, 2018, 4:29 PM

#

yeah, I know

flat forum Jun 1, 2018, 4:29 PM

#

That's jist for triangles?

solemn rivet Jun 1, 2018, 4:30 PM

#

I'm just saying you can treat all cosines as sines when you're approximating functions via Fourier series

flat forum Jun 1, 2018, 4:30 PM

#

I know there's something about circles

#

Explain pls

solemn rivet Jun 1, 2018, 4:30 PM

#

nah, sin t = cos (90 - t) is always true

#

for all values of t

flat forum Jun 1, 2018, 4:30 PM

#

(In #297468195026239489 if you want ti)

solemn rivet Jun 1, 2018, 4:30 PM

#

why mem, this is Modding related

#

zote

compact sedge Jun 1, 2018, 4:30 PM

#

that's why sines and cosines are basically the same thing but shifted as far as the numbers they produce

#

over a large interval

young walrus Jun 1, 2018, 4:31 PM

#

math is a meme to some people

flat forum Jun 1, 2018, 4:31 PM

#

Because the fact I understanding nothing is meme

solemn rivet Jun 1, 2018, 4:32 PM

#

Papers, the Wiki article is a good place to start

#

https://en.wikipedia.org/wiki/Fourier_series

Fourier series

In mathematics, a Fourier series (English: ) is a way to represent a function as the sum of simple sine waves. More formally, it decomposes any periodic function or periodic signal into the sum of a (possibly infinite) set of simple oscillating functions, namely sines and cos...

compact sedge Jun 1, 2018, 4:32 PM

#

It's weird to me how generating pictures is simple algebra with a tiny bit of trig. Generating sound is calculus and linear algebra by comparison.

floral furnace Jun 1, 2018, 4:32 PM

#

Folding all you have to know is trigonometry and calculus is for dungos hollowface

solemn rivet Jun 1, 2018, 4:33 PM

#

how so AA?

compact sedge Jun 1, 2018, 4:33 PM

#

the required math knowledge to build functions that do many of the effects is much higher

#

because like frequencies aren't real things

#

for example

#

I mean they are

#

but it's not easy to go from a series of floats to frequencies

solemn rivet Jun 1, 2018, 4:33 PM

#

also, Papers, there's this very nice video by 3blue1brown https://www.youtube.com/watch?v=spUNpyF58BY

YouTube

3Blue1Brown

But what is the Fourier Transform? A visual introduction.

An animated introduction to the Fourier Transform, winding graphs around circles. Puzzler at the end by Jane Street: https://janestreet.com/3b1b Funding for ...

▶ Play video

compact sedge Jun 1, 2018, 4:34 PM

#

I mean it is easy but only if the series of float only has 1 frequency in it

flat forum Jun 1, 2018, 4:34 PM

#

Thanks =D

compact sedge Jun 1, 2018, 4:34 PM

#

if it has many

#

and you wanna isolate one

#

then it's hard

solemn rivet Jun 1, 2018, 4:34 PM

#

yeah, I getcha

compact sedge Jun 1, 2018, 4:34 PM

#

I don't conceptually understand the code I'm using for a lowpass filter

#

but I conceptually understand 100% of my image generation code

solemn rivet Jun 1, 2018, 4:35 PM

#

I mean

compact sedge Jun 1, 2018, 4:35 PM

#

I mean I understand it on a basic line by line case

solemn rivet Jun 1, 2018, 4:35 PM

#

I literally study maths for a living and I can't for the life of me understand how to work with sounds

young walrus Jun 1, 2018, 4:36 PM

#

do you HAVE to understand how filters work?

compact sedge Jun 1, 2018, 4:36 PM

#

Well I want to

#

because I don't want to have to copy code if I can help it

#

and also knowing the how means understanding how to modify it to get the effect you want

young walrus Jun 1, 2018, 4:37 PM

#

okay, but why not just run an audio file asset?

#

instead of building the sound in the code?

compact sedge Jun 1, 2018, 4:37 PM

#

because I want each one to sound unique

#

and also

solemn rivet Jun 1, 2018, 4:37 PM

#

oh

compact sedge Jun 1, 2018, 4:37 PM

#

I want to have a really small modfile

solemn rivet Jun 1, 2018, 4:37 PM

#

you literally want procedural sfx

young walrus Jun 1, 2018, 4:37 PM

#

so why not just transform the asset?

compact sedge Jun 1, 2018, 4:38 PM

#

like it's a challenge to me

young walrus Jun 1, 2018, 4:38 PM

#

like how Kerr did with my Boop

solemn rivet Jun 1, 2018, 4:38 PM

#

but yeah, Mick makes a fair point

compact sedge Jun 1, 2018, 4:38 PM

#

my starting asset is white noise and I am transforming it

solemn rivet Jun 1, 2018, 4:38 PM

#

why not modify the asset "randomly" during runtime?

young walrus Jun 1, 2018, 4:38 PM

#

yeah, but you're trying to transform it like.... 8 times

#

why not have an explosion asset, then transform that randomly with 1 transform

#

or 2

#

instead of 8-10

compact sedge Jun 1, 2018, 4:39 PM

#

fair point

#

But I'm hoping the end result is much more modular

solemn rivet Jun 1, 2018, 4:39 PM

#

like, sure, do your white -> 8x lowpass -> explosion

compact sedge Jun 1, 2018, 4:39 PM

#

I wanna reuse this code for a nuke mod because why not, and lasers, and all sorts of things

solemn rivet Jun 1, 2018, 4:39 PM

#

but record the output and use it as a basis for new sounds

#

oh

young walrus Jun 1, 2018, 4:40 PM

#

i mean, i could just make you sounds like that in 5 minutes in ableton

#

then you could use an arppegiation transform to randomly assign pitches

#

especially for like, lasers

compact sedge Jun 1, 2018, 4:42 PM

#

well the other half of the coin is I don't want any assets in my mod file.

#

why not? IDK I've never included assets in any of my code and I don't see why that should end now.

#

I don't make games

#

I do coding stuff for me

young walrus Jun 1, 2018, 4:43 PM

#

couldn't you assemble that into your mod file?

compact sedge Jun 1, 2018, 4:43 PM

#

yes

#

you can just add pictures and sound to your mod file

young walrus Jun 1, 2018, 4:43 PM

#

i mean, if you don't wanna do that, you don't wanna do that

#

i just think you're working too hard, personally

#

lol

compact sedge Jun 1, 2018, 4:43 PM

#

yes I am

#

I'm putting in probably an extra 30 hours that I shouldn't need to

#

but I'm having fun with it

#

and actually learning a lot about procedural generation

young walrus Jun 1, 2018, 4:44 PM

#

shrugs as long as you're okay with that and it works, i guess

flat forum Jun 1, 2018, 4:53 PM

#

By the way, Gradow

#

The vid's really interesting

#

Thanks for sending it =)

solemn rivet Jun 1, 2018, 4:53 PM

#

np

#

I really like this guy's vids

flat forum Jun 1, 2018, 4:54 PM

#

If all of them are like this one It's understandable

compact sedge Jun 1, 2018, 5:10 PM

#

3 blue 1 brown is a great youtuber. He makes stuff I never understood in math make perfect sense.

#

He made a great video on fracals but it's super long

#

https://www.youtube.com/watch?v=gB9n2gHsHN4

YouTube

3Blue1Brown

Fractals are typically not self-similar

What fractal dimension is, and how this is the core concept defining what fractals themselves are. Patreon page: https://www.patreon.com/3blue1brown Special ...

▶ Play video

hollow pier Jun 1, 2018, 5:38 PM

#

fracals

flat forum Jun 1, 2018, 5:40 PM

#

F R A C A L S

copper nacelle Jun 1, 2018, 10:03 PM

#

@compact sedge what's RainbowPos for

compact sedge Jun 1, 2018, 10:03 PM

#

basically it cycles through the color wheel

#

and that's the current position of it in that cycle

copper nacelle Jun 1, 2018, 10:03 PM

#

o

#

ty

burnt laurel Jun 1, 2018, 11:09 PM

#

what's up with lightbringer

#

i downloaded it

#

and there's like

copper nacelle Jun 1, 2018, 11:10 PM

#

1.2.2.1

burnt laurel Jun 1, 2018, 11:10 PM

#

10 different versions

compact sedge Jun 1, 2018, 11:10 PM

#

what's up with lightbringer? (laugh track)

burnt laurel Jun 1, 2018, 11:10 PM

#

what's drm-free

supple sigil Jun 1, 2018, 11:10 PM

#

I remember when the lightbringer trailer first released

copper nacelle Jun 1, 2018, 11:11 PM

#

light ringer

supple sigil Jun 1, 2018, 11:11 PM

#

I was going through hollow knight videos for “just uploaded”

burnt laurel Jun 1, 2018, 11:11 PM

#

so do i get drm free or not

young walrus Jun 1, 2018, 11:11 PM

#

is that the game version you have?

supple sigil Jun 1, 2018, 11:11 PM

#

Then there was this trailer with this cool charm on the front

#

0 views at the time

#

I was like wats this

#

Hk has mods????

burnt laurel Jun 1, 2018, 11:12 PM

#

what does it even mean

young walrus Jun 1, 2018, 11:12 PM

#

DRM free is non-steam

burnt laurel Jun 1, 2018, 11:12 PM

#

oh ok

#

so i'd want normal

young walrus Jun 1, 2018, 11:13 PM

#

do you have a non-steam version of the game

burnt laurel Jun 1, 2018, 11:13 PM

#

i got it on steam

young walrus Jun 1, 2018, 11:13 PM

#

so then no. drm-free wouldn't work for you

burnt laurel Jun 1, 2018, 11:16 PM

#

so do i just download it like i would any other mod

#

just merge hollow_knight_data

young walrus Jun 1, 2018, 11:16 PM

#

Yes. But lifebringer is not api, so it will only work with itself

copper nacelle Jun 1, 2018, 11:17 PM

#

1.2.2.1

young walrus Jun 1, 2018, 11:17 PM

#

No other mods can run at the same time

#

And ya. Doesn't work on lifeblood

burnt laurel Jun 1, 2018, 11:17 PM

#

oh

#

would've been nice to know that

young walrus Jun 1, 2018, 11:17 PM

#

Well the number beside it is the patch

burnt laurel Jun 1, 2018, 11:17 PM

#

oh

young walrus Jun 1, 2018, 11:18 PM

#

Kinda hard to miss

burnt laurel Jun 1, 2018, 11:18 PM

#

i know pretty much nothing about modding

#

i thought it might've been the mod version

young walrus Jun 1, 2018, 11:19 PM

#

Well I mean.... It is that too

burnt laurel Jun 1, 2018, 11:19 PM

#

so is it possible to revert to an older version or should i not bother

#

what version is 1.2.2.1

#

grimm troupe?

rain cedar Jun 1, 2018, 11:20 PM

#

It's one of the grimm troupe patches yes

burnt laurel Jun 1, 2018, 11:20 PM

#

ok

young walrus Jun 1, 2018, 11:21 PM

#

Speedrun.com/hollowknight/guides

copper nacelle Jun 1, 2018, 11:21 PM

#

https://speedrun.com/hollowknight/guides

burnt laurel Jun 1, 2018, 11:24 PM

#

well thats a problem

#

i cant use regedit

rain cedar Jun 1, 2018, 11:24 PM

#

Yeah you can

burnt laurel Jun 1, 2018, 11:24 PM

#

uhh

#

no i cant

rain cedar Jun 1, 2018, 11:24 PM

#

Ok

#

Why?

burnt laurel Jun 1, 2018, 11:25 PM

#

i pressed win + r and entered "regedit"

#

and it's been blocked

#

disabled

rain cedar Jun 1, 2018, 11:25 PM

#

Ask your parents to enable it

copper nacelle Jun 1, 2018, 11:25 PM

#

corny

burnt laurel Jun 1, 2018, 11:25 PM

#

uhh

rain cedar Jun 1, 2018, 11:26 PM

#

Same

burnt laurel Jun 1, 2018, 11:26 PM

#

hmm

#

the thing is

#

they arent the administrators

leaden hedge Jun 1, 2018, 11:26 PM

#

regedit to bypass the block

burnt laurel Jun 1, 2018, 11:26 PM

#

whatever

rain cedar Jun 1, 2018, 11:26 PM

#

Who is the admin?

burnt laurel Jun 1, 2018, 11:26 PM

#

i just wont use the mod

rain cedar Jun 1, 2018, 11:26 PM

#

Are you on a school computer or some shit?

burnt laurel Jun 1, 2018, 11:26 PM

#

no

rain cedar Jun 1, 2018, 11:27 PM

#

Work computer?

burnt laurel Jun 1, 2018, 11:27 PM

#

no

rain cedar Jun 1, 2018, 11:27 PM

#

I could keep guessing

#

But I won't

#

So you should just say

leaden hedge Jun 1, 2018, 11:28 PM

#

why do you even need regedit

burnt laurel Jun 1, 2018, 11:28 PM

#

cause i need it to revert my version

#

supposedly

leaden hedge Jun 1, 2018, 11:28 PM

#

pretty sure you can do that without regedit

rain cedar Jun 1, 2018, 11:28 PM

#

Some people have had problems with downpatching from lifeblood without clearing HK registry values

#

Not me

burnt laurel Jun 1, 2018, 11:29 PM

#

was that with moving data over?

young walrus Jun 1, 2018, 11:33 PM

#

Sometimes you don't wake up at benches

#

Sometimes your opening cutscenes don't even load

#

Sometimes the game crashes

#

Things can just happen

burnt laurel Jun 1, 2018, 11:41 PM

#

well i got 1.2.2.1 but now it's just a black screen

#

no team cherry logo or anything

young walrus Jun 1, 2018, 11:45 PM

#

And welcome to the reason for clearing regedit

burnt laurel Jun 1, 2018, 11:45 PM

#

welp

#

there goes that mod

young walrus Jun 1, 2018, 11:46 PM

#

Why cant you open the run window as admin?

burnt laurel Jun 1, 2018, 11:46 PM

#

i can

#

but i cant access regedit

rain cedar Jun 1, 2018, 11:47 PM

#

Whoever the admin of the computer you're using is can give you access

leaden hedge Jun 1, 2018, 11:48 PM

#

could make a mod that just cleans the registry for hk

compact sedge Jun 1, 2018, 11:48 PM

#

why would that be a mod

#

just make a .reg file people can double click

leaden hedge Jun 1, 2018, 11:48 PM

#

doesn't require admin controls

compact sedge Jun 1, 2018, 11:48 PM

#

with empty HK entries

leaden hedge Jun 1, 2018, 11:49 PM

#

and you could make it edit stuff specifically

#

like permadeath and screens

burnt laurel Jun 1, 2018, 11:49 PM

#

or i could just not use lightbringer

rain cedar Jun 1, 2018, 11:49 PM

#

I don't get why you're so reluctant to just ask for help

#

Unless this is a computer you're not supposed to be gaming on

#

But you already said it's not a work or school computer

burnt laurel Jun 1, 2018, 11:50 PM

#

just dont ask

#

its personal stuff

#

stuff i would prefer not to share with strangers i dont know

leaden hedge Jun 1, 2018, 11:54 PM

#

he pirated his pc

#

confirmed

burnt laurel Jun 1, 2018, 11:56 PM

#

speculate all you want but im not confirming anything

compact sedge Jun 1, 2018, 11:56 PM

#

you wouldn't download a graphics card

#

(but I totally would)

#

(GPUs are so expensive)

young walrus Jun 1, 2018, 11:57 PM

#

Just download more ram

leaden hedge Jun 1, 2018, 11:57 PM

#

just make a vm with 128gb of ram and a SLI 1080ti

copper nacelle Jun 2, 2018, 12:02 AM

#

why do mantis lords have 4 control fsms

compact sedge Jun 2, 2018, 12:02 AM

#

well one is the stagger fsm

copper nacelle Jun 2, 2018, 12:02 AM

#

no

compact sedge Jun 2, 2018, 12:02 AM

#

and the other 3 are for the mantises

copper nacelle Jun 2, 2018, 12:02 AM

#

mantis lords don't stagger 🤔

compact sedge Jun 2, 2018, 12:03 AM

#

that doesn't matter

#

all bosses have stagger fsms afaik

#

its just they have their stagger value set to 9999 hits or something

copper nacelle Jun 2, 2018, 12:04 AM

#

if there is one then it's not in either of the fsm dumps

#

scene dump and just fsm mod

compact sedge Jun 2, 2018, 12:05 AM

#

ree use modcommon dump

copper nacelle Jun 2, 2018, 12:05 AM

#

GWeulixThonk

#

scene dump is from modcommon

#

large think

compact sedge Jun 2, 2018, 12:05 AM

#

oh you don't just mean the giant rar file with all the scenes in it?

copper nacelle Jun 2, 2018, 12:06 AM

#

i do

compact sedge Jun 2, 2018, 12:06 AM

#

ok well it's cool but lacks the useful variables

rain cedar Jun 2, 2018, 12:07 AM

#

It has enough

compact sedge Jun 2, 2018, 12:08 AM

#

it lacks actual numbers though

#

It's decent for state names and nice to have something you can just download but kinda limited in actual uses.

#

and I think kdt agrees with me because he was at one point working on a full game object serializer

#

and aside from just the scene dump, kerr also has a tool to make those dumps with actual numbers

#

in modcommon

flat forum Jun 2, 2018, 3:17 AM

#

is it possible to make Lightbringer an API mod?

floral furnace Jun 2, 2018, 3:22 AM

#

Thats what 56 is doing

flat forum Jun 2, 2018, 3:22 AM

#

really?

#

why didn't anyone tell me?

compact sedge Jun 2, 2018, 3:44 AM

#

it's on haitus for mantis gods

flat forum Jun 2, 2018, 3:49 AM

#

wouldn't mind

#

would also want to try making a God Vessel Mod for Broken Vessel sometime

rain cedar Jun 2, 2018, 3:53 AM

#

Lost kin but with no staggers and faster spawn rate

#

That's really all you need

flat forum Jun 2, 2018, 3:53 AM

#

well

#

I want to try adding something to his down attack

young walrus Jun 2, 2018, 3:55 AM

#

lost kin, but the mobs have 20 hp and spawn every second

flat forum Jun 2, 2018, 3:56 AM

#

3 seconds

rain cedar Jun 2, 2018, 3:56 AM

#

Half second

flat forum Jun 2, 2018, 3:56 AM

#

3 or nothing

compact sedge Jun 2, 2018, 4:15 AM

#

anyone know why a sound pops right at the end and how to get rid of that?

#

wow literally padding it with 0.75 seconds of silence fixes it

#

ok

#

explain that atheists

flat forum Jun 2, 2018, 4:21 AM

#

I

#

I can't

#

it's impossible

exotic dune Jun 2, 2018, 4:21 AM

#

probably some weird-ass implementation quirk

#

b/t cutting off sound within a file vs. at the end

compact sedge Jun 2, 2018, 4:22 AM

#

I had 0.25 seconds of padding

#

but apparently I need 0.75

#

and also to change the audio type to steaming

#

mmm steamed audio

#

from cached in ram

rain cedar Jun 2, 2018, 4:24 AM

#

Is there any way to view what the internal unity calls actually do?

compact sedge Jun 2, 2018, 4:24 AM

#

idk I'm just using boop mod code

#

I guess disassemble the unity dll

rain cedar Jun 2, 2018, 4:25 AM

#

Looking at the Unity dll in dnspy you just get a lot of extern functions

compact sedge Jun 2, 2018, 4:25 AM

#

actually this is dumb but here's what I figured out. I can't use streaming type audio

#

so the only way to get audio to not pop, is to change the audiosource volume

#

but currently I'm doing it through the boop mod so that's probably gonna break stuff

flat forum Jun 2, 2018, 4:26 AM

#

  if( grimm2 == null )

#

what is this?

compact sedge Jun 2, 2018, 4:26 AM

#

if that GameObject is not set to anything

#

or if it's inactive

flat forum Jun 2, 2018, 4:27 AM

#

but is grimm2 NKG?

compact sedge Jun 2, 2018, 4:27 AM

#

that's the second grimm that spawns in in NGG

#

in the second phase

flat forum Jun 2, 2018, 4:27 AM

#

trying to understand how NGG spawns 2 Grimms in the first Grimm fight

compact sedge Jun 2, 2018, 4:27 AM

#

it takes the first one and makes a copy of it

#

storing that copy in grimm2

flat forum Jun 2, 2018, 4:28 AM

#

but that one there is NKG #2, right?

#

or is it just the 2nd Grimm that spawns

young walrus Jun 2, 2018, 4:28 AM

#

so it copies it right away, then nulls it until the final phase?

flat forum Jun 2, 2018, 4:29 AM

#

I'd guess it's null until the final phase where, if it's null it gets unnulled?

young walrus Jun 2, 2018, 4:29 AM

#

....that's literally what i just said

#

lol

flat forum Jun 2, 2018, 4:29 AM

#

Ooops

#

somehow misread the UNTIL as IN

#

I'm appaerently stoopid and dislexic

rain cedar Jun 2, 2018, 4:41 AM

#

If you look here it actually looks more like it sets the grimm2 GameObject one frame after it finds the initial grimm https://github.com/KayDeeTee/HK-NGG/blob/master/src/BossFinder.cs#L58

compact sedge Jun 2, 2018, 4:45 AM

#

grimm2 is active the whole time but

#

https://github.com/KayDeeTee/HK-NGG/blob/master/src/BossFinder.cs#L101

GitHub

KayDeeTee/HK-NGG

HK-NGG - Nightmare God Grimm

#

gfsm is grimm2

#

and it gets set back to normal here
https://github.com/KayDeeTee/HK-NGG/blob/master/src/BossFinder.cs#L205

GitHub

KayDeeTee/HK-NGG

HK-NGG - Nightmare God Grimm

#

when you do yield return null; where does the coroutine resume from?

#

is it at the start

#

oh nvm it starts right where it left off

rain cedar Jun 2, 2018, 4:51 AM

#

That's just telling it to wait a frame

compact sedge Jun 2, 2018, 4:52 AM

#

ok I need to do that in some code. actually I need to do it in more of my code instead of just dumping crap in Update

rain cedar Jun 2, 2018, 4:52 AM

#

Coroutines are cool but letting Unity handle them gives you way too little control

#

Should update them yourself using MoveNext()

compact sedge Jun 2, 2018, 4:53 AM

#

Coroutines run on their own thread?

#

I kinda wanna generate sounds and stuff in the background

#

instead of just pausing the game for about 8 seconds when they click load save

rain cedar Jun 2, 2018, 4:54 AM

#

It's kinda like fake threading

#

It just runs the routine until the next yield at some point

#

Probably at the end of every frame

compact sedge Jun 2, 2018, 4:55 AM

#

is there any good way to do real threading or rather to run something async on a separate thread so that it doesn't slow down everything else

rain cedar Jun 2, 2018, 4:55 AM

#

Not through Unity

compact sedge Jun 2, 2018, 4:56 AM

#

ok

rain cedar Jun 2, 2018, 4:56 AM

#

But C# supports it

#

Obviously

#

It's not even hard

📎 unknown.png

compact sedge Jun 2, 2018, 5:26 AM

#

huh ok

#

so if I'm building my own gameobject, should I use playmaker at all

#

or should I avoid it like the plague

flat forum Jun 2, 2018, 5:27 AM

#

well

compact sedge Jun 2, 2018, 5:27 AM

#

like I have no idea what the right approach for this is

flat forum Jun 2, 2018, 5:27 AM

#

Use it, game's already made out of PlaymakerFSMs

#

another one won't hurt?

compact sedge Jun 2, 2018, 5:28 AM

#

I'm not sure an FSM would be the easiest way to program it though

flat forum Jun 2, 2018, 5:28 AM

#

No, I mean Playmaker won't affect the game as much, considering it's already purely made out of Playmaker

compact sedge Jun 2, 2018, 5:29 AM

#

Basically I'm trying to spawn a sprite that moves according to some simple movement code, and that, on hitting an enemy, damages it.

flat forum Jun 2, 2018, 5:29 AM

#

mmhm

compact sedge Jun 2, 2018, 5:29 AM

#

you tell me how I should do that

flat forum Jun 2, 2018, 5:29 AM

#

well, I don't have much experience in adding objects to the game

compact sedge Jun 2, 2018, 5:29 AM

#

because I have no effing clue

flat forum Jun 2, 2018, 5:30 AM

#

so

#

do what you understand and find easiest

#

and then thinnk about refining it

compact sedge Jun 2, 2018, 5:30 AM

#

Literally I haven't touched game engine code until about 1 month ago

#

so idk what I'm doing

#

not even a little

#

I need a thing I can read to tell me what I'm supposed to do here

#

have anything like that

flat forum Jun 2, 2018, 5:30 AM

#

I hadn't touched code until about I started making the mod

#

only had some basic knowledge

compact sedge Jun 2, 2018, 5:31 AM

#

also nice but I'm doubtful is if anyone has some code I can look at that does something vaguely similar

rain cedar Jun 2, 2018, 5:33 AM

#

Make a GameObject with a DamageEnemies component

#

And a SpriteRenderer

compact sedge Jun 2, 2018, 5:34 AM

#

should I do that for each sprite?

#

and also how do I control it's movement

rain cedar Jun 2, 2018, 5:34 AM

#

Yeah

#

It will need some kind of collider for the DamageEnemies to work

#

Movement idk depends on what you want it to do

compact sedge Jun 2, 2018, 5:36 AM

#

I just need it to follow the game's laws of gravity and newtonian physics but also to pass through walls.

#

I know how to do the second part

#

actually lets start simple

#

I just need it to follow the game's laws of gravity

#

and have an initial velocity

rain cedar Jun 2, 2018, 5:37 AM

#

Put a Rigidbody2D on it and set its gravityScale to something

#

And call AddForce with whatever force you want

compact sedge Jun 2, 2018, 5:40 AM

#

??

📎 unknown.png

#

idk what I'm doing sorry

#

oh typeof

#

right

#

?

rain cedar Jun 2, 2018, 5:40 AM

#

I can't tell what you're doing either from that screenshot

flat forum Jun 2, 2018, 5:40 AM

#

(nor am I, that's why I ask a billion questions)

compact sedge Jun 2, 2018, 5:41 AM

#

cool figured it out:
FireballsGO[i] = new GameObject("redwingFB" + i, typeof(DamageEnemies), typeof(SpriteRenderer), typeof(Rigidbody2D));

flat forum Jun 2, 2018, 5:42 AM

#

(what's the mod called?)

compact sedge Jun 2, 2018, 5:42 AM

#

redwing

#

also if I add these gameobjects as a child of another game object they get that gameobject's position right?

#

I might make an empty position gameobject so they move relative to it

rain cedar Jun 2, 2018, 5:42 AM

#

I think so

charred parrot Jun 2, 2018, 6:28 AM

#

children game objects move with the parent yes

compact sedge Jun 2, 2018, 6:28 AM

#

thanks I got lazy

young walrus Jun 2, 2018, 7:06 AM

#

wow. look at this lazy ass MF

#

just showing up

#

zote

compact sedge Jun 2, 2018, 7:45 AM

#

physics = new Rigidbody2D();
physics.mass = 1.0f;

why does this second thing cause a null ref exception?

physics.mass is a float

rain cedar Jun 2, 2018, 7:45 AM

#

You can't create components like that

#

physics = someGameObject.AddComponent<Rigidbody2D>();

compact sedge Jun 2, 2018, 7:45 AM

#

oh the game object already has the component added

rain cedar Jun 2, 2018, 7:45 AM

#

Then use GetComponent

compact sedge Jun 2, 2018, 7:45 AM

#

should I just uncomment the new line

#

yeah that fixed it

#

thanks

rain cedar Jun 2, 2018, 7:46 AM

#

Neato

flat forum Jun 2, 2018, 7:47 AM

#

Where can I find the info on the Broken Vessel fight?

rain cedar Jun 2, 2018, 7:48 AM

#

What do you mean by info?

#

There's some info for ya http://hollowknight.wikia.com/wiki/Broken_Vessel

flat forum Jun 2, 2018, 7:48 AM

#

well, a while back someone had sent me a .json file with the code for the THK fight

#

it had attack names and other stuff

rain cedar Jun 2, 2018, 7:49 AM

#

Oh you mean a dump of the fsm

flat forum Jun 2, 2018, 7:49 AM

#

I guess?

#

haven't dumped FSMs before

rain cedar Jun 2, 2018, 7:50 AM

#

Well there's a tool for it in ModCommon

compact sedge Jun 2, 2018, 7:51 AM

#

all my code runs but the fireballs don't spawn. I'll just figure it out tomorrow tho

rain cedar Jun 2, 2018, 7:51 AM

#

Here's a dump of the whole scene the boss is in

#

Or not

#

Guess I can't upload from archives

flat forum Jun 2, 2018, 7:52 AM

#

?

rain cedar Jun 2, 2018, 7:52 AM

#

📎 Abyss_19.txt

flat forum Jun 2, 2018, 7:53 AM

#

Wait, this Laptop can't download anything

#

What?

#

How?

#

Why?

#

What the FUCK

rain cedar Jun 2, 2018, 7:55 AM

#

Same

flat forum Jun 2, 2018, 7:55 AM

#

Ok

#

worked

#

apparently

#

Disc C is gone

#

no space on it whatsoever

rain cedar Jun 2, 2018, 7:56 AM

#

That's good

flat forum Jun 2, 2018, 7:56 AM

#

HOW

rain cedar Jun 2, 2018, 7:56 AM

#

Well you see it's probably because you downloaded enough stuff to fill it

flat forum Jun 2, 2018, 7:56 AM

#

I haven't downloaded anything

#

It's probably the stupid Windows

rain cedar Jun 2, 2018, 7:57 AM

#

How big is your hard drive?

flat forum Jun 2, 2018, 7:57 AM

#

📎 unknown.png

#

here

#

Disc C has 5 MB out of 99.9 GB free

rain cedar Jun 2, 2018, 7:57 AM

#

Well there's your problem

flat forum Jun 2, 2018, 7:57 AM

#

it's also full of Blue Folders for some reason

rain cedar Jun 2, 2018, 7:57 AM

#

100 GB is basically nothing

#

D is much larger, switch your OS to that disk

flat forum Jun 2, 2018, 7:58 AM

#

D IS indeed larger

#

Ok

#

maybe some time

#

the .txt file is the whole info from that 1 room Broken Vessel's in

rain cedar Jun 2, 2018, 8:02 AM

#

Yes

flat forum Jun 2, 2018, 8:03 AM

#

there's a separate info thing for every single object in the room, Background, Foreground, enemies...

#

each thing has a layer number

#

what layer is the Knight's one?

#

11?

rain cedar Jun 2, 2018, 8:05 AM

#

Looks like it

flat forum Jun 2, 2018, 8:05 AM

#

infected_knight_room_0004_2?

rain cedar Jun 2, 2018, 8:06 AM

#

Dunno

flat forum Jun 2, 2018, 8:09 AM

#

This appears to be the arena

#

and you can't set Dream Gates in boss arenas

#

so it's a separate thing?

#

By the way, I found the Boss Part

leaden hedge Jun 2, 2018, 1:23 PM

#

also the 2nd grimm doesn't just do nothing

#

I made its control fsm constantly select spikes

flat forum Jun 2, 2018, 1:25 PM

#

so

#

the 2nd Grimm that doesn't appear for most the time is the one spamming spikes?

leaden hedge Jun 2, 2018, 1:26 PM

#

yes

flat forum Jun 2, 2018, 1:32 PM

#

and the first fight?

#

it too spawns 2 Grimms

#

and each functions like a normal separate Grimm

leaden hedge Jun 2, 2018, 1:33 PM

#

probably has a different fsm

#

so it doesn't get overrode

flat forum Jun 2, 2018, 1:34 PM

#

mhm

#

trying to understand if it's possible to do the same for the Watcher Knight

leaden hedge Jun 2, 2018, 1:35 PM

#

it is

flat forum Jun 2, 2018, 1:35 PM

#

so that you fight twice as many

solemn rivet Jun 2, 2018, 2:18 PM

#

make it so that lost kid spawns copies of himself instead of those ghosties

#

they have little health, but explode on death, like the enemies on infected crossroads

#

DEW EET

flat forum Jun 2, 2018, 2:20 PM

#

I'll try

#

maybe

#

just spawn the ghosts

#

but they have a bit more health (so that the defender's crest cheese won't work)

#

and they explode on death

#

YES

#

(Should the mod be called God Vessel?)

solemn rivet Jun 2, 2018, 2:22 PM

#

no

#

it should be called the Lord Vessel

flat forum Jun 2, 2018, 2:22 PM

#

but

#

they tradition of calling hard-mode bosses Gods

floral furnace Jun 2, 2018, 2:22 PM

#

God Kin

flat forum Jun 2, 2018, 2:23 PM

#

Lost God

solemn rivet Jun 2, 2018, 2:24 PM

#

Lord Vessel is more pun-y

flat forum Jun 2, 2018, 2:24 PM

#

Hmmm

#

But first

#

I'll get home

#

and finish the GodKiller Weapons mod

solemn rivet Jun 2, 2018, 2:26 PM

#

tbf

#

my first mod idea, before making blackmoth even

#

like, when lightbringer had just come out

#

was to make elemental spells

#

ice, thunder and fire

flat forum Jun 2, 2018, 2:27 PM

#

Interesting idea

#

how would they function tho

solemn rivet Jun 2, 2018, 2:28 PM

#

like

#

ice would freeze enemies (high burst damage), thunder could chain enemies and scale damage based on the amount of enemies in the chain (low base damage, but high if chaining multiple enemies), fire would burn enemies (med base damage + burn damage)

flat forum Jun 2, 2018, 2:29 PM

#

(I meant how do you activate each one)

solemn rivet Jun 2, 2018, 2:30 PM

#

oh

#

well

copper nacelle Jun 2, 2018, 2:30 PM

#

triple click fireball

solemn rivet Jun 2, 2018, 2:30 PM

#

they could be powerups you pick up in game

#

or they could require some special kind of Soul (kinda Metroid Prime Echoes-esque)

flat forum Jun 2, 2018, 2:33 PM

#

your DD turns into a Lightning, your shriek ice and your... nowmal Soul bullet - fire

copper nacelle Jun 2, 2018, 2:34 PM

#

nowmal

solemn rivet Jun 2, 2018, 2:34 PM

#

maybe

flat forum Jun 2, 2018, 2:34 PM

#

nowmal

#

hewwo

solemn rivet Jun 2, 2018, 2:34 PM

#

or maybe make them all have elemental versions you can cycle through

#

I never got too much into that idea once I realized how hard it would be to implement

flat forum Jun 2, 2018, 2:34 PM

#

press some button to change to next version

#

yeah it'd be hard

#

so, Seanpr sent a thing that shoul be about resizing the nail

#

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);

void Func()
{
    NailSlash thing = (NailSlash)whatever.GetValue(HeroController.Instance);
    thing.scale = something;
}

#

now, the nail scale is a Vector3 thing

#

so just setting a number didn't work

copper nacelle Jun 2, 2018, 2:37 PM

#

thing.scale = new Vector3(stuff)

flat forum Jun 2, 2018, 2:38 PM

#

new Vector3(ScaleX()*[number], ScaleY()*[number], ScaleZ())?

solemn rivet Jun 2, 2018, 2:38 PM

#

you can just do

flat forum Jun 2, 2018, 2:38 PM

#

Sean said I can do *= instead of =

solemn rivet Jun 2, 2018, 2:38 PM

#

Vector3.Scale(thing.scale, vectorToScale)

flat forum Jun 2, 2018, 2:38 PM

#

but that didn't work

solemn rivet Jun 2, 2018, 2:39 PM

#

*= will multiply every coordinate of thing.scale by something

#

but if you do

#

thing.scale = Vector3.Scale(thing.scale, new Vector3(2,0,0));

flat forum Jun 2, 2018, 2:40 PM

#

it will only change length?

solemn rivet Jun 2, 2018, 2:40 PM

#

it'll scale the x coordinate by 2

#

and the other's by zero

#

so the new vector becomes (2*thing.scale.x, 0, 0)

#

it's just an example, tho

flat forum Jun 2, 2018, 2:41 PM

#

0s won't change the thing, right?

#

and not

#

break it and make it a line

solemn rivet Jun 2, 2018, 2:41 PM

#

no, 0 will multiply by 0

#

Vector3.Scale is vector multiplication but done coordinate-wise

flat forum Jun 2, 2018, 2:41 PM

#

so I make those 1s instead of 0s so I keep the original size?

solemn rivet Jun 2, 2018, 2:41 PM

#

yup

pearl sentinel Jun 2, 2018, 2:42 PM

#

Wasup

flat forum Jun 2, 2018, 2:42 PM

#

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);

void Func()
{
    NailSlash thing = (NailSlash)whatever.GetValue(HeroController.Instance);
    thing.scale = Vector3.Scale(thing.scale, new Vector3(2, 1 , 1));
}

#

hey Kerr!

solemn rivet Jun 2, 2018, 2:42 PM

#

but in that case, it's easier to do

copper nacelle Jun 2, 2018, 2:42 PM

#

elderbug

pearl sentinel Jun 2, 2018, 2:43 PM

#

elderbug

flat forum Jun 2, 2018, 2:43 PM

#

I'm trying to understand the code to resize the nail

solemn rivet Jun 2, 2018, 2:43 PM

#

thing.scale = Vector3.Scale(thing.scale, 2 * Vector3.right);

flat forum Jun 2, 2018, 2:43 PM

#

but I want to only change length

solemn rivet Jun 2, 2018, 2:43 PM

#

oops

#

nvm

#

forget that

#

what I said is wrong

flat forum Jun 2, 2018, 2:43 PM

#

Ok

#

and the code I sent there?

solemn rivet Jun 2, 2018, 2:43 PM

#

should work, yeah

flat forum Jun 2, 2018, 2:44 PM

#

is that the way the thing.scale should work?

#

Ok

solemn rivet Jun 2, 2018, 2:44 PM

#

should double your nail x coordinate

#

no, that's how vector3 works

#

and thing.scale is a vector3

flat forum Jun 2, 2018, 2:44 PM

#

yeah yeah

#

I meant will the thing.scale that didn't work before work now

#

also, can I put this entire thing in an if statement

#

which if statement activates whenever there's a CharmUpdate

#

so

OnCharmUpdate
if(EquippedCharm_Mop)
ThatWholeThing

lucid pond Jun 2, 2018, 3:42 PM

#

The EnemyHPBar mod doesn't work properly

📎 unknown.png

flat forum Jun 2, 2018, 3:43 PM

#

Hmm

#

everything seems to be up to date

#

I don't think it required anything else

lucid pond Jun 2, 2018, 3:44 PM

#

the old one is OK

young walrus Jun 2, 2018, 3:44 PM

#

Wat

#

You aren't on the beta branch are you?

lucid pond Jun 2, 2018, 3:46 PM

#

The old EnemyHPBar mod is OK

📎 unknown.png

flat forum Jun 2, 2018, 3:47 PM

#

hmm

young walrus Jun 2, 2018, 3:47 PM

#

Is your mod common up to date?

#

I don't know what current version is of modcommon

lucid pond Jun 2, 2018, 3:48 PM

#

Yes.The QoL mod needs the new modcommon

solemn rivet Jun 2, 2018, 3:56 PM

#

what do you mean "old enemyHpBar"?

lucid pond Jun 2, 2018, 3:57 PM

#

😱 I can't find the health bars even if I lower or raise my resolution a little bit.

📎 unknown.png

#

This one updated on Apr.21. The old one means it.

📎 unknown.png

#

The new one updated on May 22.

📎 unknown.png

solemn rivet Jun 2, 2018, 4:07 PM

#

send modlog and outputlog please

lucid pond Jun 2, 2018, 4:12 PM

#

wait a minute，please

#

the PlayDataDump Mod doesn't have seed message

📎 unknown.png

flat forum Jun 2, 2018, 4:15 PM

#

But

#

You need ModLog

#

Which is a txt file wih your saves

#

Right?

lucid pond Jun 2, 2018, 4:17 PM

#

📎 ModLog.txt

young walrus Jun 2, 2018, 4:17 PM

#

The seed was removed from the overlay

#

Because of how many setting options there are now, it doesn't really tell you much. Because that seed will mean something else if you change one of the custom settings

lucid pond Jun 2, 2018, 4:18 PM

#

That's a pity.

young walrus Jun 2, 2018, 4:19 PM

#

Just add it yourself

#

Use a text element of OBS

#

Write it on there each time

lucid pond Jun 2, 2018, 4:20 PM

#

😂 Inoki said the same words

#

I see.Thanks!

copper nacelle Jun 2, 2018, 4:24 PM

#

wow someone's actually using QoL

#

nice

lucid pond Jun 2, 2018, 4:24 PM

#

mylajoy I'm going to sleep

#

I tried it today.Inoki asked me to test the mod

#

I haven't find any question.

flat forum Jun 2, 2018, 5:17 PM

#

So

#

The FieldInfo thing

#

How can I get to on CharmUpdate?

#

Possibly with an if statement

copper nacelle Jun 2, 2018, 5:20 PM

#

?

#

wdym

flat forum Jun 2, 2018, 5:20 PM

#

Well

#

The whole code thing

#

Has the private static thing

#

So it's an activation the way public void OnAttack is

copper nacelle Jun 2, 2018, 5:22 PM

#

what

flat forum Jun 2, 2018, 5:23 PM

#

Ok

#

Gonna get on my computer in a sec

#

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);

void Func()
{
    NailSlash thing = (NailSlash)whatever.GetValue(HeroController.Instance);
    thing.scale = Vector3.Scale(thing.scale, new Vector3(2, 1 , 1));
}

This is the code I'm talking about

#

adding an IF statement should be like this

#

void Func()
{
    if (CharmEquipped_Something)
    {
      Stuff
    }
}

copper nacelle Jun 2, 2018, 5:26 PM

#

yes

flat forum Jun 2, 2018, 5:27 PM

#

when does the effect take action?

#

is what I don't understand

#

the way OnAttack begins it's effect... On Attacking

#

because I want the effect to take action CharmUpdate

copper nacelle Jun 2, 2018, 5:28 PM

#

Modding.ModHooks.Instance.CharmUpdateHook += yourfunc;

#

then it'll run your function

#

on charmupdate

solemn rivet Jun 2, 2018, 5:29 PM

#

CharmUpdate is called when you sit on a bench

flat forum Jun 2, 2018, 5:30 PM

#

And on changing charms?

solemn rivet Jun 2, 2018, 5:30 PM

#

Not only then, but that's the most common use

#

Yeah, possibly

flat forum Jun 2, 2018, 5:31 PM

#

Ok

#

also, just Vector3 didn't work it needed UnityEngine.Vector3

copper nacelle Jun 2, 2018, 5:33 PM

#

using UnityEngine imo

flat forum Jun 2, 2018, 5:34 PM

#

so, it should look like this?

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);

        void CharmUpdate()
        {
            if (PlayerData.instance.GetBool("equippedCharm_18"))
            {
                NailSlash thing = (NailSlash)whatever.GetValue(HeroController.instance);
                thing.scale = UnityEngine.Vector3.Scale(thing.scale, new UnityEngine.Vector3(2, 1, 1));
            }
        }

#

No overload for 'CharmUpdate' matches delegate 'CharmUpdateHandler'

regarding Modding.ModHooks.Instance.CharmUpdateHook += CharmUpdate;

copper nacelle Jun 2, 2018, 5:37 PM

#

needs args

flat forum Jun 2, 2018, 5:38 PM

#

the private static public void things?

copper nacelle Jun 2, 2018, 5:38 PM

#

CharmUpdate needs args re

#

CharmUpdate(PlayerData data, HeroController controller)

flat forum Jun 2, 2018, 5:39 PM

#

I understand very little ree sadgrub

copper nacelle Jun 2, 2018, 5:40 PM

#

hooks take functions with certain required arguments

#

your function is missing the required arguments

#

change CharmUpdate() -> CharmUpdate(PlayerData data, HeroController controller)

solemn rivet Jun 2, 2018, 5:41 PM

#

Papers it's sorta like this: as you know, methods have arguments. A hook is kinda like a "generic" method. So in the game's code there's a method called CharmUpdate and we make the CharmUpdateHook. Since you're hooking to CharmUpdate, the method you use to do so must have the same arguments

#

And must have the same return type as well

flat forum Jun 2, 2018, 5:42 PM

#

mhm

#

Ok

solemn rivet Jun 2, 2018, 5:43 PM

#

So HeroUpdateHook, for instance, hooks into the HeroController.Update method which has no arguments and has return type void (that is, it doesn't return a value)

flat forum Jun 2, 2018, 5:43 PM

#

I added those to the CharmUpdate thing at the bottom

solemn rivet Jun 2, 2018, 5:43 PM

#

So whenever you use that hook, you must do so with a method with no arguments and no return

flat forum Jun 2, 2018, 5:43 PM

#

and it seemed to fix?

solemn rivet Jun 2, 2018, 5:44 PM

#

Yup

#

Because those are the arguments of the original CharmUpdate

flat forum Jun 2, 2018, 5:44 PM

#

But why did it say those have to be added at the other line?

copper nacelle Jun 2, 2018, 5:45 PM

#

cause they're required?

solemn rivet Jun 2, 2018, 5:45 PM

#

^

flat forum Jun 2, 2018, 5:45 PM

#

Ok

solemn rivet Jun 2, 2018, 5:45 PM

#

here, lemme show it to you

hollow pier Jun 2, 2018, 5:46 PM

#

what is modcommon

copper nacelle Jun 2, 2018, 5:47 PM

#

dependency for a bunch of other mods

solemn rivet Jun 2, 2018, 5:47 PM

#

    public void CharmUpdate()
    {
        if (this.playerData.equippedCharm_26)
        {
            this.nailChargeTime = this.NAIL_CHARGE_TIME_CHARM;
        }
        else
        {
            this.nailChargeTime = this.NAIL_CHARGE_TIME_DEFAULT;
        }
        if (this.playerData.equippedCharm_23 && !this.playerData.brokenCharm_23)
        {
            this.playerData.maxHealth = this.playerData.maxHealthBase + 2;
            this.playerData.MaxHealth();
        }
        else
        {
            this.playerData.maxHealth = this.playerData.maxHealthBase;
            this.playerData.MaxHealth();
        }
        if (this.playerData.equippedCharm_27)
        {
            this.playerData.joniHealthBlue = (int)((float)this.playerData.maxHealth * 1.4f);
            this.playerData.maxHealth = 1;
            this.playerData.MaxHealth();
            this.joniBeam = true;
        }
        else
        {
            this.playerData.joniHealthBlue = 0;
        }
        if (this.playerData.equippedCharm_40 && this.playerData.grimmChildLevel == 5)
        {
            this.carefreeShieldEquipped = true;
        }
        else
        {
            this.carefreeShieldEquipped = false;
        }
        this.playerData.UpdateBlueHealth();
    }```

#

this is the orig charmupdate

copper nacelle Jun 2, 2018, 5:47 PM

#

it has code they all use

hollow pier Jun 2, 2018, 5:47 PM

#

so i need to install api and common for rando

copper nacelle Jun 2, 2018, 5:47 PM

#

yes

hollow pier Jun 2, 2018, 5:47 PM

#

ok

solemn rivet Jun 2, 2018, 5:47 PM

#

it has return type void and has no arguments

#

public void CharmUpdate()

#

as you can see here

#

so whenever you do

ModHooks.Instance.CharmUpdateHook += MyMethod;

#

your method MyMethod must begin just like CharmUpdate, that is

hollow pier Jun 2, 2018, 5:49 PM

#

i just throw the two things into this

📎 unknown.png

solemn rivet Jun 2, 2018, 5:49 PM

#

void MyMethod()

#

yup, ptkyr

#

and merge when asked to

copper nacelle Jun 2, 2018, 5:50 PM

#

^

solemn rivet Jun 2, 2018, 5:50 PM

#

@flat forum read my explanation above

flat forum Jun 2, 2018, 5:50 PM

#

reading it

#

by the way

#

it says it can't convert from double to float

solemn rivet Jun 2, 2018, 5:51 PM

#

show us the line

flat forum Jun 2, 2018, 5:51 PM

#

thing.scale = UnityEngine.Vector3.Scale(thing.scale, new UnityEngine.Vector3(1.5, 1, 1));

#

it's the 1.5 thing probably

solemn rivet Jun 2, 2018, 5:51 PM

#

1.5f

#

that should do it

flat forum Jun 2, 2018, 5:52 PM

#

It worked

#

what does the f stand for?

solemn rivet Jun 2, 2018, 5:52 PM

#

float

#

whenever you're working with floats, just put f beside the value

flat forum Jun 2, 2018, 5:52 PM

#

Ok

#

time to test how it works

#

Ok

#

Forgot to reset it

#

now size scales endlessly

#

this is incredibly fun and stupid

#

I need to fix this

#

probably

solemn rivet Jun 2, 2018, 5:55 PM

#

just do as you did with the nail

flat forum Jun 2, 2018, 5:55 PM

#

so, I need to store the original value

#

Yeah

solemn rivet Jun 2, 2018, 5:55 PM

#

save the original scale when you first run the code

#

the simplest way to do that is to make a counter that counts whenever the code runs

#

and only save if it hasn't run yet

hollow pier Jun 2, 2018, 5:56 PM

#

ok installing mods is hella easy

solemn rivet Jun 2, 2018, 5:56 PM

#

that's ugly, but it works and is easy to understand

#

something like

#

if (counter > 0)
{
    defaultScale = thing.scale;
}

#

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);
        void CharmUpdate()
        {
if (counter == 0)
{
    defaultScale = thing.scale;
}
counter ++;
thing.scale = defaultScale;
            if (PlayerData.instance.GetBool("equippedCharm_18"))
            {
                NailSlash thing = (NailSlash)whatever.GetValue(HeroController.instance);
                thing.scale = UnityEngine.Vector3.Scale(thing.scale, new UnityEngine.Vector3(2, 1, 1));
            }
        }```

#

actually

#

there

#

ofc you need to create the counter and defaultScale fields

flat forum Jun 2, 2018, 6:00 PM

#

defaultScale I already made

#

the counter

solemn rivet Jun 2, 2018, 6:00 PM

#

just public int counter;

flat forum Jun 2, 2018, 6:00 PM

#

I can easily add an INT

#

the thing is how do I make sure I use it when it hasn't been used before?

solemn rivet Jun 2, 2018, 6:01 PM

#

what do you mean?

flat forum Jun 2, 2018, 6:01 PM

#

Oh wait

#

yeah

#

but shouldn't that be if (counter == 0) or something?

solemn rivet Jun 2, 2018, 6:02 PM

#

oops

#

yeah

flat forum Jun 2, 2018, 6:03 PM

#

that threw me off a bit

#

ok, so

solemn rivet Jun 2, 2018, 6:03 PM

#

ints start at 0, so that should work

flat forum Jun 2, 2018, 6:03 PM

#

if it's 0 default scale is set to the scale

#

it gets added to every time you sit on a bench

#

I think thing hasn't been defined at that moment

#

so I need the NailSlash thing = (NailSlash)whatever.GetValue(HeroController.instance); line before that?

#

Ok, changed that

#

it says it can't convert between Vector3 and int and the other way around

solemn rivet Jun 2, 2018, 6:07 PM

#

well, defaultScale should be a Vector3, right?

#

not an int

#

so I don't see the issue

flat forum Jun 2, 2018, 6:07 PM

#

yeah

solemn rivet Jun 2, 2018, 6:07 PM

#

push the code

#

I'll see what I can do

flat forum Jun 2, 2018, 6:07 PM

#

yeah

#

I had set it as an INT

#

stupid mistake on my part

solemn rivet Jun 2, 2018, 6:08 PM

#

oh ok

flat forum Jun 2, 2018, 6:09 PM

#

works

#

every 2nd attack

#

?

#

Why does it work every 2nd attack?

solemn rivet Jun 2, 2018, 6:14 PM

#

Show code

flat forum Jun 2, 2018, 6:14 PM

#

that's the whole thing regarding the size

#

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);

        void CharmUpdate(PlayerData data, HeroController controller)
        {
            NailSlash thing = (NailSlash)whatever.GetValue(HeroController.instance);

            if (counter == 0)
            {
                defaultScale = thing.scale;
            }
            counter++;
            thing.scale = defaultScale;
            if (PlayerData.instance.GetBool("equippedCharm_18"))
            {
                
                thing.scale = UnityEngine.Vector3.Scale(thing.scale, new UnityEngine.Vector3(2, 1, 1));
            }
        }

#

any idea why it'd work only every 2nd attack?

#

Ok

#

tested it again

#

it worked every first attack

#

but the 2nd

#

(which is like a little different)

#

isn't rescaled

flat forum Jun 2, 2018, 6:58 PM

#

By the way

#

The FotF/Strength combo is now almost balanced

solemn rivet Jun 2, 2018, 6:58 PM

#

am back

copper nacelle Jun 2, 2018, 6:59 PM

#

elderbug

flat forum Jun 2, 2018, 6:59 PM

#

with that you get the super strength attack whenever you're at max health (NewFragileStrength) and 2 health and below (FotF)

#

hey Gradow

#

so, after I balance that and fix the nail-resize

compact sedge Jun 2, 2018, 6:59 PM

#

the second attack has a different name, no? it's slash and alt slash.

flat forum Jun 2, 2018, 6:59 PM

#

really?

solemn rivet Jun 2, 2018, 7:00 PM

#

it shouldn't matter since he's dealing with the slashComponent directly

compact sedge Jun 2, 2018, 7:00 PM

#

not that it should affect your code depending on how you hook it

#

yeah shalsComponent should apply to both

copper nacelle Jun 2, 2018, 7:00 PM

#

shals

solemn rivet Jun 2, 2018, 7:00 PM

#

each slash is an instance of slashComponent

#

and slashComponent is the base class

flat forum Jun 2, 2018, 7:00 PM

#

well

solemn rivet Jun 2, 2018, 7:00 PM

#

so altering that should alter all instances of it

flat forum Jun 2, 2018, 7:00 PM

#

the resizing it this about this

#

NailSlash thing = (NailSlash)whatever.GetValue(HeroController.instance);

#

which is NailSlash

#

if there's NailAltSlash

#

it won't be affected I guess

solemn rivet Jun 2, 2018, 7:01 PM

#

nope, it should work

flat forum Jun 2, 2018, 7:01 PM

#

should I replace NailSlash with Slashcomponent?

#

just as a test

solemn rivet Jun 2, 2018, 7:02 PM

#

it won't work

flat forum Jun 2, 2018, 7:02 PM

#

Ok

solemn rivet Jun 2, 2018, 7:02 PM

#

NailSlash is a class in the assembly

copper nacelle Jun 2, 2018, 7:02 PM

#

slashComponent is of type nailslash

solemn rivet Jun 2, 2018, 7:02 PM

#

SlashComponent is-

#

^

flat forum Jun 2, 2018, 7:02 PM

#

Then what's the problem?

Also, here, have it again to not have to scroll up

private static FieldInfo whatever = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance);

        void CharmUpdate(PlayerData data, HeroController controller)
        {
            NailSlash thing = (NailSlash)whatever.GetValue(HeroController.instance);

            if (counter == 0)
            {
                defaultScale = thing.scale;
            }
            counter++;
            thing.scale = defaultScale;
            if (PlayerData.instance.GetBool("equippedCharm_18"))
            {
                
                thing.scale = UnityEngine.Vector3.Scale(thing.scale, new UnityEngine.Vector3(2, 1, 1));
            }
        }

solemn rivet Jun 2, 2018, 7:03 PM

#

dunno

#

only optimization I can think of is just setting a bool instead of counting

flat forum Jun 2, 2018, 7:03 PM

#

AA's assumption seemed like a good reason for it to break

solemn rivet Jun 2, 2018, 7:03 PM

#

yeah

#

but you said it was working before

flat forum Jun 2, 2018, 7:03 PM

#

I meant

solemn rivet Jun 2, 2018, 7:04 PM

#

even though it was scaling to infinity

flat forum Jun 2, 2018, 7:04 PM

#

it was working for only 1 of the slashes

#

and it was scaling to infinity on only 1 of the slashes

#

it always affected only the 1st slash

solemn rivet Jun 2, 2018, 7:04 PM

#

maybe that's it then

#

but that sucks

flat forum Jun 2, 2018, 7:04 PM

#

(I may have not made that part clear enough, sorry)

solemn rivet Jun 2, 2018, 7:05 PM

#

because if that's the case then you're gonna have to deal with slash, altSlash, upSlash, downSlash

flat forum Jun 2, 2018, 7:05 PM

#

Welp

solemn rivet Jun 2, 2018, 7:05 PM

#

all of them are instances of NailSlash

flat forum Jun 2, 2018, 7:05 PM

#

if I have to

#

I will

solemn rivet Jun 2, 2018, 7:05 PM

#

so

#

there's a simpler way

#

which requires more tools

flat forum Jun 2, 2018, 7:05 PM

#

upslashing and downslashing didn't get affected either
And applying a resize on the X scale would just make them wider, no?

solemn rivet Jun 2, 2018, 7:06 PM

#

dunno

compact sedge Jun 2, 2018, 7:06 PM

#

probably but they could also have just been rotated and resizing x on rotated objects could make them taller

#

I think

flat forum Jun 2, 2018, 7:06 PM

#

well, I'll just resize each one separately so I can get Up and Down on the Y scale

solemn rivet Jun 2, 2018, 7:06 PM

#

what I would do is

#

use monomod detour

#

detour this method

📎 unknown.png

#

???

#

profit

flat forum Jun 2, 2018, 7:08 PM

#

alternative

I don't touch things I don't quite understand for the next 8 hours, as I will be sleeping

compact sedge Jun 2, 2018, 7:08 PM

#

ok but that is probably the easiest and best way of doing it

#

Speaking of assumptions and hooks I have to ask: is it a bad assumption that the original function is always called at some point when you use a Modding API hook?

solemn rivet Jun 2, 2018, 7:08 PM

#

not bad at all

compact sedge Jun 2, 2018, 7:08 PM

#

cuz normally all the original functions seem to be called

#

but not for

ModHooks.Instance.DashPressedHook

solemn rivet Jun 2, 2018, 7:08 PM

#

well

compact sedge Jun 2, 2018, 7:09 PM

#

if I add this hook, which has no returns or inputs

#

it stops the original from being called

solemn rivet Jun 2, 2018, 7:09 PM

#

that's the only override, afaik

compact sedge Jun 2, 2018, 7:09 PM

#

is that literally because of your mod

solemn rivet Jun 2, 2018, 7:09 PM

#

so unless you hook the original function to DashPressedHook as well, it's not getting called

#

well, yeah

#

at the time, hooks were just starting to be created

#

the API was a new thing

#

and I asked sean to do it for me

#

and he delivered

compact sedge Jun 2, 2018, 7:10 PM

#

ok makes sense

solemn rivet Jun 2, 2018, 7:10 PM

#

I mean

flat forum Jun 2, 2018, 7:10 PM

#

Ok, I'll see what I can do, but tommorow

#

elderbug

#

nailsmith

solemn rivet Jun 2, 2018, 7:11 PM

#

the way he did it is the best way I can think of doing that tbh

#

elderbug

#

because as it is, it creates an invoke list

compact sedge Jun 2, 2018, 7:11 PM

#

elderbug

solemn rivet Jun 2, 2018, 7:11 PM

#

so if you want to call the orig function as well, you can just add it to the list

compact sedge Jun 2, 2018, 7:11 PM

#

I agree with that behavior but knowing that is very helpful to me

solemn rivet Jun 2, 2018, 7:12 PM

#

my only suggestion would be to add a bool isOverride

#

and if it's false, it would run the original HeroDash before the hook

#

or after

#

whatever

#

hm... That won't work

#

nvm

compact sedge Jun 2, 2018, 7:13 PM

#

My plan for redwing was to implement a very shitty version of blackmoth that only has multidirectional dash and slightly reduced cooldowns if they didn't have yours installed.

#

because my fireball attack requires up dashing

copper nacelle Jun 2, 2018, 7:13 PM

#

imo just require blackmoth

compact sedge Jun 2, 2018, 7:13 PM

#

I'm going to in the XML file

#

so when people download it with modmanager it will

#

unless

#

y'all get recommended mods added

copper nacelle Jun 2, 2018, 7:13 PM

#

and then run blackmoth's dash in ur dash ez

compact sedge Jun 2, 2018, 7:13 PM

#

which needs to happen

#

no. I'm not linking against blackmoth. I'm using reflection

copper nacelle Jun 2, 2018, 7:14 PM

#

run it with reflection large thonk

compact sedge Jun 2, 2018, 7:14 PM

#

but if I use reflection then I won't require that mod

copper nacelle Jun 2, 2018, 7:14 PM

#

GWjustinHyperThink

#

If you have blackmoth

#

then run the method using reflection

#

e z

compact sedge Jun 2, 2018, 7:15 PM

#

if I have blackmoth, the method will be run automatically

#

by the hook

#

and if not then it will add my component which does just 8 directional dash

solemn rivet Jun 2, 2018, 7:16 PM

#

now that I think of it

#

bonfire's levelling system should have been a component to the Hero object

#

...

#

meh

copper nacelle Jun 2, 2018, 7:17 PM

#

wait

#

I should've done that

#

components on the lords

#

ree

compact sedge Jun 2, 2018, 7:18 PM

#

pfft I've never done that

#

maybe I should

#

what advantages does it have

solemn rivet Jun 2, 2018, 7:19 PM

#

well, it made my life SO much easier in enemyhpbars

#

at first I had a huge class with a list of all active enemies and a drawing a bar for each one of them

#

so it was hard to keep track of positioning, when an enemy had died etc.

#

I had to listen to HitInstance and check if the fsm that was hit belonged to one of the enemies on the scene

#

if it did, then I did the hp calculations

#

it was a right mess

compact sedge Jun 2, 2018, 7:21 PM

#

oh I see

solemn rivet Jun 2, 2018, 7:21 PM

#

now... https://github.com/Ayugradow/Enemy-HP-Bars/blob/master/src/ComponentHPBar.cs

GitHub

Ayugradow/Enemy-HP-Bars

Enemy-HP-Bars - Adaptation of KDT's HPBar mod for all enemies

leaden hedge Jun 2, 2018, 7:21 PM

#

you probably could have done it with 3 lines of code tbh via line renderers

#

and 2 of them would have been init

solemn rivet Jun 2, 2018, 7:22 PM

#

wut

compact sedge Jun 2, 2018, 7:22 PM

#

Coding in a nutshell is learning there's always a solution that's 10 times easier than the way you did it

#

so uh speaking of sprites has anyone done any code with SpriteRenderer?

solemn rivet Jun 2, 2018, 7:24 PM

#

I use them in berserk

compact sedge Jun 2, 2018, 7:24 PM

#

ok

leaden hedge Jun 2, 2018, 7:24 PM

#

what about them

#

theres nothing weird about them

compact sedge Jun 2, 2018, 7:25 PM

#

ok my sprites weren't appearing and I was wondering why and after looking at your code I suspect because I forgot sprite.enabled = true

solemn rivet Jun 2, 2018, 7:26 PM

#

could be

#

check if color is not black

compact sedge Jun 2, 2018, 7:26 PM

#

good call since they're still not appearing

leaden hedge Jun 2, 2018, 7:27 PM

#

what are you currently doing

compact sedge Jun 2, 2018, 7:27 PM

#

I'm trying and struggling to spawn custom gameobjects whenever the player dashes

leaden hedge Jun 2, 2018, 7:27 PM

#

i mean what code do you have

compact sedge Jun 2, 2018, 7:29 PM

#

https://github.com/natis1/redwing/blob/master/redwing/RedwingGOs.cs#L44

GitHub

natis1/redwing

redwing - A firey Hollow Knight mod/addon for Blackmoth

#

everything runs because the log at the end works

#

but my intended result is a bunch of fireballs that spawn in

leaden hedge Jun 2, 2018, 7:31 PM

#

whats fireballLength

compact sedge Jun 2, 2018, 7:31 PM

#

it's the width of the actual fireball that I want to appear

#

it's different from the sprite width

#

for now

#

probably gonna set them the same at some point

leaden hedge Jun 2, 2018, 7:32 PM

#

sprite.create rect is the position of the subtexture

#

i.e. if you had 4 16x16 sprites in a 2x2, 16,16,16,16 would give you the bottom right one

compact sedge Jun 2, 2018, 7:32 PM

#

ok

#

ok just set the texture size to 150x150

#

but they are still not appearing

leaden hedge Jun 2, 2018, 7:40 PM

#

try putting another renderer on it

#

like a line renderer

compact sedge Jun 2, 2018, 7:41 PM

#

anything I need to change about the linerenderer to get it to show up

#

like if I add it with: typeof(LineRenderer)

leaden hedge Jun 2, 2018, 7:41 PM

#

yeah

#

you'll need to do useWorldSpace = true

compact sedge Jun 2, 2018, 7:42 PM

#

hell maybe that's what I forgot about my sprite

leaden hedge Jun 2, 2018, 7:42 PM

#

and SetPositions( new Vector3(0,0,1), new Vector3(1,1,1));

#

SetPositions takes an array but w/e

compact sedge Jun 2, 2018, 7:44 PM

#

alright done and done

#

not seeing anything :(

leaden hedge Jun 2, 2018, 7:45 PM

#

have you tried running your code in unity editor

#

so you can actually debug it

compact sedge Jun 2, 2018, 7:46 PM

#

wha what?

#

where do I even start for that? my game object is made entirely in code for one and for two I'm using a playmakerFSM object

#

and three I'm setting its position based on the knight transform

leaden hedge Jun 2, 2018, 7:47 PM

#

none of that stuff matters

#

make a dummy object in editor called "knight"

#

and use that instead of the knight

#

and just make it spawn your fireballs based off that objects position as soon as you press play

compact sedge Jun 2, 2018, 7:48 PM

#

and also copy over 1200 lines of procedural texture generation code too I presume

leaden hedge Jun 2, 2018, 7:48 PM

#

well that shouldnt depend on anything related to hollow knight

compact sedge Jun 2, 2018, 7:49 PM

#

no

#

3d template then?

#

since hk is in 3d?

leaden hedge Jun 2, 2018, 7:50 PM

#

no

#

2d

#

unity has no concept of 2d or 3d

#

all it changes is the default camera from perspective to orthographic

compact sedge Jun 2, 2018, 7:59 PM

#

what do I use instead of Modding.Logger.Log

#

for logging stuff

leaden hedge Jun 2, 2018, 7:59 PM

#

debug.log