#archived-modding-development | Hollow Knight | Page 104

copper nacelle May 28, 2018, 6:22 AM

#

same

compact sedge May 28, 2018, 6:23 AM

#

relatable

flat forum May 28, 2018, 6:23 AM

#

help...

deep sleet May 28, 2018, 6:23 AM

#

quote totally not stolen from an actual game developer

copper nacelle May 28, 2018, 6:24 AM

#

which one

compact sedge May 28, 2018, 6:24 AM

#

try adding logging statements, try try, catch sections

deep sleet May 28, 2018, 6:24 AM

#

One of the devs from clicker heroes/playsaurus

compact sedge May 28, 2018, 6:24 AM

#

if you don't do this and the mod has an exception it will fail silently

flat forum May 28, 2018, 6:25 AM

#

I'll just dump the main thing here and hope someone understands where the problem is

public void OnAttack(AttackDirection dir)
        {
            LogDebug("Attacking");
            if (PlayerData.instance.equippedCharm_6)
            {
                LogDebug("Stronger Attack");

                _tempNailDamage = PlayerData.instance.nailDamage; //Store the current nail damage.

                LogDebug("Set _tempNailDamage to " + _tempNailDamage);

                PlayerData.instance.nailDamage += (PlayerData.instance.maxHealth - PlayerData.instance.health); //Double the nail damage
                

                return;
            }
        }

compact sedge May 28, 2018, 6:25 AM

#

ok question

#

check your log

#

do you see those messages

copper nacelle May 28, 2018, 6:25 AM

#

did you ever send an fsm event

#

or change the damageshero

flat forum May 28, 2018, 6:26 AM

#

(Lemme remember where the log was, be back in eventually)

#

the thing in the save files

#

ModLog.txt?

copper nacelle May 28, 2018, 6:31 AM

#

yes

#

you can just make it appear on screen tho

flat forum May 28, 2018, 6:31 AM

#

messages are not there

#

no "Attacking" or "Stronger Attack" or "Finished Attacking"

#

LogDebug("Finished Attacking");

#

Only info from it is this

[INFO]:[NewFotF] - Initializing
[INFO]:[NewFotF] - Initialized

#

Log("Initialized");

copper nacelle May 28, 2018, 6:34 AM

#

did you hook the methods

#

and did you attack

flat forum May 28, 2018, 6:35 AM

#

these are all the Hooks I have
ModHooks.Instance.AttackHook += OnAttack;
ModHooks.Instance.AfterAttackHook += OnAfterAttack;

#

And to "Did you attack?", I killed a few to see if anything:

[INFO]:Disabling enemy Zombie Runner
[INFO]:Disabled enemy Zombie Runner
[INFO]:Destroying enemy Zombie Runner
[INFO]:Destroyed enemy Zombie Runner

#

(I'll change those from LogDebug to Log)

copper nacelle May 28, 2018, 6:39 AM

#

ok

flat forum May 28, 2018, 6:53 AM

#

Ok

#

it's working better now

#

info appears in the ModLog

#

I'll run 1 last test

#

hm

#

[INFO]:[NewFotF] - Attacking
[INFO]:[NewFotF] - Stronger Attack
[INFO]:[NewFotF] - Set _tempNailDamage to 21
[INFO]:[NewFotF] - Set Nail Damage to to 56
[INFO]:[NewFotF] - Finished Attacking

#

but I still deal 21 damage

#

[INFO]:[NewFotF] - Attacking
[INFO]:[NewFotF] - Stronger Attack
[INFO]:[NewFotF] - Set _tempNailDamage to 21
[INFO]:[NewFotF] - Set Nail Damage to to 56
[INFO]:[NewFotF] - Finished Attacking
[INFO]:[NewFotF] - Set Nail Damage to to 21

#

Log part works fine

#

but I still only deal 21 damage

#

why?

copper nacelle May 28, 2018, 7:13 AM

#

what's your afterattack

flat forum May 28, 2018, 7:14 AM

#

this thing?

        private void OnAfterAttack(AttackDirection dir)
        {
            Log("Finished Attacking");

            PlayerData.instance.nailDamage = _tempNailDamage; 

            _NailDamageTracker = PlayerData.instance.nailDamage;

            Log("Set Nail Damage to to " + _NailDamageTracker);
        }

copper nacelle May 28, 2018, 7:15 AM

#

ree

flat forum May 28, 2018, 7:15 AM

#

yes?

copper nacelle May 28, 2018, 7:16 AM

#

put this after PlayerData.instance.NailDamage = _tempNailDamage

#

and after PlayerData.instance.nailDamage += (PlayerData.instance.maxHealth - ......

#

PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE");

flat forum May 28, 2018, 7:18 AM

#

before the Log

#

?

copper nacelle May 28, 2018, 7:19 AM

#

where the red line is

📎 unknown.png

#

📎 unknown.png

flat forum May 28, 2018, 7:22 AM

#

private void OnAfterAttack(AttackDirection dir)
        {
            Log("Finished Attacking");

            PlayerData.instance.nailDamage = _tempNailDamage; 

            PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE");

            _NailDamageTracker = PlayerData.instance.nailDamage;

            Log("Set Nail Damage to to " + _NailDamageTracker);
        }

copper nacelle May 28, 2018, 7:22 AM

#

also on attack u dungo

flat forum May 28, 2018, 7:22 AM

#

Yeah, I put it

copper nacelle May 28, 2018, 7:22 AM

#

now try it

flat forum May 28, 2018, 7:22 AM

#

but now it's complaining avout this

#

The name 'PlayMakerFSM' does not exist in the current context

copper nacelle May 28, 2018, 7:22 AM

#

click on it

#

hit alt enter

#

and click the thing which has the using

flat forum May 28, 2018, 7:24 AM

#

OK, I have to go out now, I'll try to fix it when I get back

compact sedge May 28, 2018, 7:39 AM

#

I have a question: Why is something like lightbringer platform exclusive? How is that possible for unity engine mods anyway?

leaden hedge May 28, 2018, 7:51 AM

#

Its a mod of the assembly csharp which is platform specific

compact sedge May 28, 2018, 7:51 AM

#

assembly csharp is not platform specific though

#

it's like java bytecode

#

unless it's using external libraries not used by the original game that exist on unity's windows version of mono but not their linux/mac version

leaden hedge May 28, 2018, 7:53 AM

#

It is platform specific though 🤔

#

Try and use your assembly csharp on gog/linux /mac install and it won't work

compact sedge May 28, 2018, 7:55 AM

#

the assembly c# is the same across different OSes tho

#

which is why I can compile the modding api for windows and use it in linux

#

using windows assembly c#

#

and windows build target

rain cedar May 28, 2018, 8:16 AM

#

Didn't used to work like that

compact sedge May 28, 2018, 8:17 AM

#

so the assemblies converged for HK

#

like they used to be different files

#

and now they aren't

rain cedar May 28, 2018, 8:18 AM

#

Guess so

compact sedge May 28, 2018, 8:18 AM

#

maybe HK used to use a third party library or something that was only compatible with windows, so the linux and mac ports used a different 3rd party library, then somewhere around the grimm update maybe they switched their windows only one to the one that works on all oses.

#

that's commonly why assemblies differ

#

keep in mind the mac/linux port was made by some dude (whose a cool dude) but who is unrelated to TC.

#

I think

#

maybe it was done in house I forgot

#

tbh

#

they didn't release it day 1 which indicates they had to rework the code for the platform and it's probable that meant they had different branches which were slightly different code wise

compact sedge May 28, 2018, 8:38 AM

#

Speaking of platform specific bugs. Enemy HP Bar is zipped improperly. the Managed folder should be uppercase in the zip file not lowercase. This makes it impossible to install with a mod installing program on case sensitive file systems like Mac and Linux

@leaden hedge

#

@floral furnace you have the same problem with your tiny mod. your zip file should have a folder named hollow_knight_Data not hollow_knight_data

floral furnace May 28, 2018, 8:46 AM

#

woopsie daisy

#

ill edit that then

compact sedge May 28, 2018, 8:47 AM

#

and because I'm on a roll I'm gonna check every API mod in the drive

#

the correct case sensitive format for the zip is:

hollow_knight_Data/Managed/Mods

#

@pearl sentinel the zip file for Boop mod should have a folder called hollow_knight_Data not hollow_knight_data.

floral furnace May 28, 2018, 8:52 AM

#

📎 API_-_Fragile_Strength_for_Nail_Arts_by_TTacco.zip

#

there with the uppercase crap sorted out

compact sedge May 28, 2018, 8:53 AM

#

ok I can upload it for you

#

Also I just finished checking and ALL other API mods are good. but @leaden hedge and @copper nacelle y'all did leave some stray desktop.ini files in the zip that you might not have wanted.

floral furnace May 28, 2018, 8:54 AM

#

im only tempted to just boost the regular damage of nail arts alone now but meh, that would be like putting bandaid on a leaking pipe

compact sedge May 28, 2018, 8:55 AM

#

ok I uploaded it

warped sinew May 28, 2018, 9:13 AM

#

does ngg work lifeblood?

#

i just tried it and it said it was loaded i but he was normal grimm

#

does modcommon mess with it? maybe ill disable that

#

i disable everyting but ngg and it doesnt seem to work :/

#

guess ill have to down patch. Oh well i get two free notches now and OP flukes, not so bad

exotic venture May 28, 2018, 9:18 AM

#

equip heavy blow to compensate for the gain of 2 notches and don't use flukenest zote

leaden hedge May 28, 2018, 9:21 AM

#

No it doesn't work on lb

exotic venture May 28, 2018, 9:21 AM

#

on the positive side, 100 more health

solemn rivet May 28, 2018, 1:11 PM

#

Why is everyone Benji?

floral furnace May 28, 2018, 1:17 PM

#

Uhhh, boredom

#

Thats literally it, everyone just changed out of boredom

solemn rivet May 28, 2018, 1:22 PM

#

But I wanna be Simo tho

copper nacelle May 28, 2018, 3:17 PM

#

Gradimo

solemn rivet May 28, 2018, 3:34 PM

#

Grad imo

copper nacelle May 28, 2018, 3:57 PM

#

hollowwoke

hazy sentinel May 28, 2018, 3:59 PM

#

Simow

hollow pier May 28, 2018, 4:00 PM

#

the lawn

copper nacelle May 28, 2018, 4:20 PM

#

@compact sedge you can now escape

copper nacelle May 28, 2018, 4:40 PM

#

and it makes you leave and stuff

solemn rivet May 28, 2018, 4:44 PM

#

🇪 🇸 🇨

burnt laurel May 28, 2018, 5:01 PM

#

📎 20180528130115_1.jpg

#

slight problem

#

my dash goes over the platform

copper nacelle May 28, 2018, 5:02 PM

#

did you try

#

pogo

solemn rivet May 28, 2018, 5:02 PM

#

^

burnt laurel May 28, 2018, 5:02 PM

#

aaaaaaa

#

what's the reward for that

copper nacelle May 28, 2018, 5:03 PM

#

mantis lords -> MoP

solemn rivet May 28, 2018, 5:03 PM

#

if you didn't have Claw, sure, that'd be sort of an issue

#

but you do, so

burnt laurel May 28, 2018, 5:03 PM

#

i'm dashing off of the wall

copper nacelle May 28, 2018, 5:03 PM

#

i think even w/out claw you could just updash afterwards

burnt laurel May 28, 2018, 5:03 PM

#

but when i dash

#

my dash goes past the platform

solemn rivet May 28, 2018, 5:04 PM

#

u right, 56, but it's possible for someone to get there without mothwing cloak

#

just pogo, Dunker

#

you can pogo on the spikes

burnt laurel May 28, 2018, 5:04 PM

#

hmm

#

is it worth it?

solemn rivet May 28, 2018, 5:04 PM

#

I mean

copper nacelle May 28, 2018, 5:04 PM

#

yes

solemn rivet May 28, 2018, 5:04 PM

#

it's not that hard

#

you literally only need to pogo once

copper nacelle May 28, 2018, 5:05 PM

#

^

solemn rivet May 28, 2018, 5:05 PM

#

and dash right after

hollow pier May 28, 2018, 5:07 PM

#

did you try clinging the wall and pressing dash

#

literally

burnt laurel May 28, 2018, 5:08 PM

#

yes

hollow pier May 28, 2018, 5:08 PM

#

that's all you need to do

burnt laurel May 28, 2018, 5:08 PM

#

yeah and i did

solemn rivet May 28, 2018, 5:08 PM

#

blackmoth dash is longer

burnt laurel May 28, 2018, 5:08 PM

#

exactly

hollow pier May 28, 2018, 5:08 PM

#

then like dash higher and hold left??

burnt laurel May 28, 2018, 5:08 PM

#

yeah

#

did that

#

it worked

solemn rivet May 28, 2018, 5:08 PM

#

ok

hollow pier May 28, 2018, 5:09 PM

#

you could just not hit the platform and pogo straight to the wall

solemn rivet May 28, 2018, 5:09 PM

#

that's what we said

hollow pier May 28, 2018, 5:09 PM

#

big think

flat forum May 28, 2018, 5:19 PM

#

K I'm home

#

I can start failing to fix the mod again

#

still stuck on this The name 'PlayMakerFSM' does not exist in the current context

copper nacelle May 28, 2018, 5:25 PM

#

using

solemn rivet May 28, 2018, 5:25 PM

#

did you add it as a reference?

#

and using

pearl sentinel May 28, 2018, 5:25 PM

#

@rain cedar when you have time, can you review the changes I made to the gathering swarm mod using harmony. I removed the dependency on hooks dll.

flat forum May 28, 2018, 5:26 PM

#

Did I add what as a reference?

copper nacelle May 28, 2018, 5:26 PM

#

Playmaker.dll

flat forum May 28, 2018, 5:26 PM

#

I added the Assembly-CSharp

#

(Lemme see)

solemn rivet May 28, 2018, 5:26 PM

#

wait - so we're moving from monomod to harmony?

pearl sentinel May 28, 2018, 5:26 PM

#

also, for anyone using mod common, feel free to try out harmony

#

no move, i just added the source into mod common

solemn rivet May 28, 2018, 5:26 PM

#

oh

#

um

#

does it have detours like monomod?

pearl sentinel May 28, 2018, 5:27 PM

#

https://github.com/Kerr1291/Charming/blob/master/Charming/Charming.cs#L196

GitHub

Kerr1291/Charming

Charming - Charm modifications for hollow knight. Depends on ModCommon.

#

you can diff with previous revision to see the differences

#

https://github.com/pardeike/Harmony/wiki/Patching

GitHub

pardeike/Harmony

Harmony - A library for patching, replacing and decorating .NET and Mono methods during runtime

#

details on how to use it

flat forum May 28, 2018, 5:28 PM

#

Ok, I added PlayMaker.dll from the files as a reference

solemn rivet May 28, 2018, 5:28 PM

#

what's this about communication nodes noot

#

lemme see...

flat forum May 28, 2018, 5:29 PM

#

The type 'MonoBehaviour' is defined in an assembly that is not referenced. You must add a reference to assembly 'UnityEngine, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.

#

Whyyy

solemn rivet May 28, 2018, 5:29 PM

#

then add UnityEngine as a reference

pearl sentinel May 28, 2018, 5:29 PM

#

communication nodes?

flat forum May 28, 2018, 5:29 PM

#

How many references does this thing needddd

#

Adding it rn

solemn rivet May 28, 2018, 5:30 PM

#

            Instance = this;
            comms = new CommunicationNode();
            comms.EnableNode( this );```

#

papers: always add PlayMaker, API and Unity, at the very least

flat forum May 28, 2018, 5:30 PM

#

IT's G O N E

#

yAY

burnt laurel May 28, 2018, 5:31 PM

#

tips for beating mantis lords?

flat forum May 28, 2018, 5:31 PM

#

Ok, it's been successfully added

#

what does it do

#

@burnt laurel Mantis Gods?

burnt laurel May 28, 2018, 5:31 PM

#

no

pearl sentinel May 28, 2018, 5:31 PM

#

oh, my communication node is my event manager system

burnt laurel May 28, 2018, 5:31 PM

#

mantis lords

#

i'm using blackmoth

flat forum May 28, 2018, 5:31 PM

#

Well

solemn rivet May 28, 2018, 5:31 PM

#

oh

flat forum May 28, 2018, 5:31 PM

#

Cheese walls

#

Always Cheese Walls

solemn rivet May 28, 2018, 5:31 PM

#

I thought it was something related to harmony

pearl sentinel May 28, 2018, 5:31 PM

#

it's just boiler plate if you want to use it

#

nah

burnt laurel May 28, 2018, 5:31 PM

#

when the other 2 start to attack i can barely even hurt them

solemn rivet May 28, 2018, 5:31 PM

#

because of modHooks = ModCommon.HarmonyInstance.Create( "com.mods.hollowknight.charming" )

pearl sentinel May 28, 2018, 5:32 PM

#

that's the only harmony thing in initialize

flat forum May 28, 2018, 5:32 PM

#

@copper nacelle What should the thing I added do?
PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE");

solemn rivet May 28, 2018, 5:32 PM

#

but, yeah, comms =/= com

copper nacelle May 28, 2018, 5:32 PM

#

update nail damage

burnt laurel May 28, 2018, 5:32 PM

#

there should be a #mod-help channel that's basically #hk-help but for mods, seeing as how often people ask for help with mods

flat forum May 28, 2018, 5:32 PM

#

yeah

burnt laurel May 28, 2018, 5:32 PM

#

and by that i mean mainly me and a couple other people

flat forum May 28, 2018, 5:32 PM

#

maybe

burnt laurel May 28, 2018, 5:32 PM

#

but whatever

flat forum May 28, 2018, 5:32 PM

#

so, another channel split

#

#archived-modding-development and #mod-help

pearl sentinel May 28, 2018, 5:33 PM

#

oh, but thanks gradow, that did point out that i put the creation of the harmony instance after the usage

flat forum May 28, 2018, 5:33 PM

#

Modding is where people help each other create mods

pearl sentinel May 28, 2018, 5:33 PM

#

so whoops

flat forum May 28, 2018, 5:33 PM

#

mod-help is where people help each other use/beat the mod

hollow pier May 28, 2018, 5:33 PM

#

just rename the channel to #check-pins and no more help is required

burnt laurel May 28, 2018, 5:34 PM

#

help with a mod

#

not help getting a mod

solemn rivet May 28, 2018, 5:34 PM

#

^

burnt laurel May 28, 2018, 5:34 PM

#

unless pins are gonna contain tips on beating mantis lords with blackmoth

#

which i doubt

solemn rivet May 28, 2018, 5:34 PM

#

ptkyr lawful evil

flat forum May 28, 2018, 5:34 PM

#

also

hollow pier May 28, 2018, 5:35 PM

#

yo there's like a help channel

flat forum May 28, 2018, 5:35 PM

#

mmmmmyes

burnt laurel May 28, 2018, 5:35 PM

#

i mean

#

that could work

#

but i think of #hk-help as something for base game assistance

solemn rivet May 28, 2018, 5:35 PM

#

there's not much I can say about mantis lords tho

#

beat them basically the same as you would normally

#

dash when they drop down and when they dash at you

hollow pier May 28, 2018, 5:36 PM

#

stand in the corner and pray

solemn rivet May 28, 2018, 5:36 PM

#

dodge boomerangs

#

same as usual

burnt laurel May 28, 2018, 5:36 PM

#

i find it difficult to fight 2 mantis lords at once cause i dash towards one and then the other hits me

#

usually hitting me into spikes

solemn rivet May 28, 2018, 5:37 PM

#

then use spells/1 damage nail

burnt laurel May 28, 2018, 5:37 PM

#

1 damage old nail vs. mantis lords

#

who will win?

#

also how does the nailsmith work?

solemn rivet May 28, 2018, 5:37 PM

#

as you would expect him to

burnt laurel May 28, 2018, 5:38 PM

#

so he upgrades my nail

hollow pier May 28, 2018, 5:38 PM

#

1.01 damage nail

solemn rivet May 28, 2018, 5:38 PM

#

he upgrades your dash

burnt laurel May 28, 2018, 5:38 PM

#

oh

hollow pier May 28, 2018, 5:38 PM

#

wow Blackmoth sounds pretty cool

#

won't play it

burnt laurel May 28, 2018, 5:38 PM

#

its basically the base game

#

but you move forward whenever you attack

flat forum May 28, 2018, 5:40 PM

#

It should have updated... still getting the messages right, but still dealing 21 damage

[INFO]:[NewFotF] - Set _tempNailDamage to 21
[INFO]:[NewFotF] - Set Nail Damage to to 56
[INFO]:[NewFotF] - Finished Attacking
[INFO]:[NewFotF] - Set Nail Damage to to 21

#

I think I put the thing where I had to

#

        public void OnAttack(AttackDirection dir)
        {
            Log("Attacking");
            if (PlayerData.instance.equippedCharm_6)
            {
                Log("Stronger Attack");

                _tempNailDamage = PlayerData.instance.nailDamage; //Store the current nail damage.

                Log("Set _tempNailDamage to " + _tempNailDamage);


                PlayerData.instance.nailDamage += 5 * (PlayerData.instance.maxHealth - PlayerData.instance.health); //Double the nail damage

                PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE");

                _NailDamageTracker = PlayerData.instance.nailDamage;

                Log("Set Nail Damage to to " + _NailDamageTracker);

                return;
            }
        }

solemn rivet May 28, 2018, 5:44 PM

#

show your after attack hook

flat forum May 28, 2018, 5:44 PM

#

private void OnAfterAttack(AttackDirection dir)
        {
            Log("Finished Attacking");

            PlayerData.instance.nailDamage = _tempNailDamage; 

            PlayMakerFSM.BroadcastEvent("UPDATE NAIL DAMAGE");

            _NailDamageTracker = PlayerData.instance.nailDamage;

            Log("Set Nail Damage to to " + _NailDamageTracker);
        }

solemn rivet May 28, 2018, 5:44 PM

#

also, I don't get harmony, Kerr, sorry

#

I'll have to look into it properly later

#

okay, and can you show me when that method gets called?

flat forum May 28, 2018, 5:47 PM

#

?

#

I got distracted and then confused

#

Methods were those public void things, right?

#

(I'm very bad with the names of things TnT)

vernal imp May 28, 2018, 5:52 PM

#

Gradow, will you change anything about Bonfire's UI mess ? :<

solemn rivet May 28, 2018, 5:54 PM

#

uh

vernal imp May 28, 2018, 5:54 PM

#

...S-s-senpai ?

solemn rivet May 28, 2018, 5:54 PM

#

who are you again?

#

thinkgrub

vernal imp May 28, 2018, 5:54 PM

#

nobody :c

flat forum May 28, 2018, 5:55 PM

#

Now you're just "nobody" that I didn't know

solemn rivet May 28, 2018, 5:55 PM

#

oh

vernal imp May 28, 2018, 5:55 PM

#

Well, as they say, nobody is just a friend you haven't met

solemn rivet May 28, 2018, 5:55 PM

#

didn't know nobody had changed their display name

#

btw

#

what do you mean by UI mess?

flat forum May 28, 2018, 5:56 PM

#

(wherever I go the channel starts turning into #meme)

vernal imp May 28, 2018, 5:57 PM

#

^ zote

#

by it being all over the place when sitting at bench and trying to activate charms

solemn rivet May 28, 2018, 5:58 PM

#

well

#

it's fixed already m8

#

fixed it a few days ago

vernal imp May 28, 2018, 5:58 PM

#

oh, i really should download it, shouldn't i?

#

: >

solemn rivet May 28, 2018, 5:58 PM

#

well

#

only if you want to

#

not like I want you to download it or anything~~, b-baka~~

vernal imp May 28, 2018, 5:59 PM

#

oni-chan ..... >_<

solemn rivet May 28, 2018, 6:00 PM

#

oni? Not onii?

#

:triggered:

flat forum May 28, 2018, 6:01 PM

#

Oni is demon

solemn rivet May 28, 2018, 6:01 PM

#

yup

#

that's why

flat forum May 28, 2018, 6:01 PM

#

onii is the one you need

solemn rivet May 28, 2018, 6:01 PM

#

:triggered:

vernal imp May 28, 2018, 6:01 PM

#

wheeew

#

weebs

flat forum May 28, 2018, 6:01 PM

#

Also B L A CK M O T H G U B B E R E L E G Y

solemn rivet May 28, 2018, 6:01 PM

#

blackmoth's elegy

#

shhh

flat forum May 28, 2018, 6:02 PM

#

You know what would be great

#

Blackmoth vs InfiniteGrimm

solemn rivet May 28, 2018, 6:03 PM

#

that sounds like the complete opposite of great

#

but sure

flat forum May 28, 2018, 6:04 PM

#

Also this charm combo is pretty OP

#

📎 unknown.png

#

you get from Point A to point B wth a single click

solemn rivet May 28, 2018, 6:04 PM

#

why dashmaster+quickdash?

#

quickdash is a direct upgrade

compact sedge May 28, 2018, 6:04 PM

#

too bad you can't put on all 6 infinity charms at once yet

#

(not that you need to)

flat forum May 28, 2018, 6:05 PM

#

At the moment I can pass through walls

#

known bug?

copper nacelle May 28, 2018, 6:06 PM

#

have u tried reading the charm descriptions

flat forum May 28, 2018, 6:06 PM

#

Not yet

#

just breakinfg things

#

lemme see

compact sedge May 28, 2018, 6:07 PM

#

imo making it so you can't pass through walls sounds impossible

flat forum May 28, 2018, 6:07 PM

#

OH, Sharp Shadpw now does this

compact sedge May 28, 2018, 6:07 PM

#

btw even without it you can pass through dirtmouth's floor

#

try not to get yourself stuck

#

because the hazard respawn location is above nothingness

flat forum May 28, 2018, 6:08 PM

#

lemme try breaking NKG

#

then InfiniteGrimm

solemn rivet May 28, 2018, 6:08 PM

#

also, try heavy blow

compact sedge May 28, 2018, 6:08 PM

#

ok use the loadout I posted in meme for maximum memes

solemn rivet May 28, 2018, 6:09 PM

#

wut

#

through the ground? Without sharp shadow?

compact sedge May 28, 2018, 6:09 PM

#

w/o ss but with grubberfly

solemn rivet May 28, 2018, 6:10 PM

#

oh

#

weird

#

but I was messing with grubber early on

compact sedge May 28, 2018, 6:10 PM

#

probably because collision detection is hard when you're going that fast

solemn rivet May 28, 2018, 6:10 PM

#

maybe that's some leftover code

#

yeah, it is

#

I'm moving grubber's just like with sharpshadow

#

https://github.com/Ayugradow/Blackmoth/blob/master/BlackmothMod.cs#L110

GitHub

Ayugradow/Blackmoth

Repository for Blackmoth HK mod

compact sedge May 28, 2018, 6:12 PM

#

ok so it's not because hit detection at 3x speed is almost impossible

solemn rivet May 28, 2018, 6:13 PM

#

https://github.com/Ayugradow/Blackmoth/blob/master/BlackmothMod.cs#L397

GitHub

Ayugradow/Blackmoth

Repository for Blackmoth HK mod

flat forum May 28, 2018, 6:13 PM

#

Hmmm

solemn rivet May 28, 2018, 6:13 PM

#

I'm manually moving the transforms

flat forum May 28, 2018, 6:13 PM

#

not dealing any damage for some reason

#

just dash through enemies

solemn rivet May 28, 2018, 6:13 PM

#

actually, that started out as a tentative fix for not being able to dash through some enemies

#

wut

#

oh, yeah

#

you prolly don't have the latest version

#

AA fixed that old vanilla bug, papers

flat forum May 28, 2018, 6:14 PM

#

mhm

#

will check it out in a minute

solemn rivet May 28, 2018, 6:14 PM

#

brb

compact sedge May 28, 2018, 6:15 PM

#

ok

flat forum May 28, 2018, 6:16 PM

#

(wondering if I should just dump the whole mod somewhere to see if you can find what the problem is...)

solemn rivet May 28, 2018, 6:17 PM

#

upload it to github and post the source here

#

and we can add pr

compact sedge May 28, 2018, 6:17 PM

#

^

flat forum May 28, 2018, 6:17 PM

#

Do I need an account to post it in Github?

compact sedge May 28, 2018, 6:17 PM

#

I mean you should be doing this anyway

#

yes

flat forum May 28, 2018, 6:17 PM

#

Ok

solemn rivet May 28, 2018, 6:18 PM

#

best version control for this kind of stuff as far as I'm concerned

compact sedge May 28, 2018, 6:18 PM

#

but if you don't have a github account yet now's a good time as any to make one

flat forum May 28, 2018, 6:18 PM

#

Making one right now

#

Repository...

#

what does that mean? New word for me

#

(English's not my first language sorry)

copper nacelle May 28, 2018, 6:22 PM

#

git repo

#

basically a folder that has version control

#

and some other git stuff

flat forum May 28, 2018, 6:22 PM

#

like this?
https://github.com/Ayugradow/Blackmoth

GitHub

Ayugradow/Blackmoth

Repository for Blackmoth HK mod

copper nacelle May 28, 2018, 6:23 PM

#

yes

flat forum May 28, 2018, 6:23 PM

#

Ok

solemn rivet May 28, 2018, 6:42 PM

#

how's it going papers?

flat forum May 28, 2018, 6:43 PM

#

Not Undertsanding how to put the File in the repo.....

solemn rivet May 28, 2018, 6:43 PM

#

so

flat forum May 28, 2018, 6:44 PM

#

...

solemn rivet May 28, 2018, 6:44 PM

#

the easiest way to get started is to use github desktop

flat forum May 28, 2018, 6:44 PM

#

it only offers me Windows64 bit

#

and my Windows is 32 bit

solemn rivet May 28, 2018, 6:45 PM

#

oh

#

then

#

create a git account

#

then create an online repository

flat forum May 28, 2018, 6:45 PM

#

https://github.com/FoldingPapers

GitHub

FoldingPapers

FoldingPapers has 1 repository available. Follow their code on GitHub.

#

https://github.com/FoldingPapers/NewFotF

GitHub

FoldingPapers/NewFotF

Contribute to NewFotF development by creating an account on GitHub.

#

this is where I got stuck

solemn rivet May 28, 2018, 6:45 PM

#

then click "Upload Files"

#

📎 unknown.png

flat forum May 28, 2018, 6:46 PM

#

📎 unknown.png

#

I can't find any form of "Upload Files"

#

There's a "Create Project" thing tho

solemn rivet May 28, 2018, 6:50 PM

#

you sure there's no desktop for 32 bit?

flat forum May 28, 2018, 6:51 PM

#

📎 unknown.png

exotic venture May 28, 2018, 6:52 PM

#

get 64 bit OS

flat forum May 28, 2018, 6:52 PM

#

Will do

#

soon

#

But

solemn rivet May 28, 2018, 6:52 PM

#

https://central.github.com/deployments/desktop/desktop/latest/win32?format=msi

exotic venture May 28, 2018, 6:52 PM

#

do it now because it's starting to get painful to watch

flat forum May 28, 2018, 6:52 PM

#

Ok

#

I will

#

soon

exotic venture May 28, 2018, 6:52 PM

#

didn't you say that a week ago too

flat forum May 28, 2018, 6:53 PM

#

W A I T I N G F O R S U M M E R B E C A U S E S C H O O L D E C I D E D T O B E S H I T F O R T H E E N D O F T H E Y E A R

solemn rivet May 28, 2018, 6:54 PM

#

wait

#

just download the 64 bit ver

#

should work, I think

#

https://central.github.com/deployments/desktop/desktop/latest/win32

#

I mean, the link is win32

flat forum May 28, 2018, 6:55 PM

#

My neurotic, stressed half won't let me do it without backing up everything

exotic venture May 28, 2018, 6:55 PM

#

do you have anything of importance on your drive

solemn rivet May 28, 2018, 6:55 PM

#

is there any reason to not use a 64 bit OS?

exotic venture May 28, 2018, 6:55 PM

#

other than just savefiles and some photos and shit

flat forum May 28, 2018, 6:55 PM

#

I don't know

#

lots of memes

exotic venture May 28, 2018, 6:55 PM

#

also you are running with 4 gigs of ram while you have like

#

8 i think

flat forum May 28, 2018, 6:55 PM

#

Yeah

#

and I'm stuck with 3.5

solemn rivet May 28, 2018, 6:56 PM

#

Y

exotic venture May 28, 2018, 6:56 PM

#

i'd be more peeved about that than anything else

solemn rivet May 28, 2018, 6:56 PM

#

^

#

~~Mys~~ Benji has spoken

flat forum May 28, 2018, 6:56 PM

#

Yeah

#

also

#

can't enter the THK Boss room like that

#

That's Hell

solemn rivet May 28, 2018, 6:57 PM

#

noot

#

wut

flat forum May 28, 2018, 6:57 PM

#

yeah

#

won't load

solemn rivet May 28, 2018, 6:57 PM

#

u wot m8

flat forum May 28, 2018, 6:57 PM

#

runs out of RAM

#

or so it says

solemn rivet May 28, 2018, 6:57 PM

#

so

#

you haven't fought THK yet?

#

and by extension - Radiance

flat forum May 28, 2018, 6:57 PM

#

(I beat the Game on the barely breathing Office Computer of my Father)

#

I beat everything

solemn rivet May 28, 2018, 6:58 PM

#

oh

#

ok then

flat forum May 28, 2018, 6:59 PM

#

started downloading

#

It Broke mid-way...

solemn rivet May 28, 2018, 6:59 PM

#

win 64x?

flat forum May 28, 2018, 6:59 PM

#

(the supposedly 32 bit .exe you sent)

solemn rivet May 28, 2018, 6:59 PM

#

well, it's in the name

#

that's the actual link on the page, so

#

try again?

golden vine May 28, 2018, 7:07 PM

#

Hi

#

please help

#

How do i make enemy randomizer load

solemn rivet May 28, 2018, 7:07 PM

#

do you have the api installed?

#

what version of the game are you running?

golden vine May 28, 2018, 7:08 PM

#

I have api

#

im in version 1.3.1.5

exotic venture May 28, 2018, 7:08 PM

#

do you have the proper version of the api

golden vine May 28, 2018, 7:08 PM

#

yes

#

other mods work

solemn rivet May 28, 2018, 7:09 PM

#

ok

#

~~install rando2~~

young walrus May 28, 2018, 7:09 PM

#

Did you click the button on the top right?

solemn rivet May 28, 2018, 7:09 PM

#

it's on the gdrive

supple sigil May 28, 2018, 7:09 PM

#

im bot a modder
but
i can make git gud jokes

solemn rivet May 28, 2018, 7:09 PM

#

oh

#

enemy rando

golden vine May 28, 2018, 7:09 PM

#

So it says something about ""
Once installed, click the [Load Enemy Randomzier] button in the top left corner, then wait while the mod loads all of the enemy types in the game.
This process takes on average 2-5 minutes depending on the speed of your computer.

solemn rivet May 28, 2018, 7:09 PM

#

yup

young walrus May 28, 2018, 7:09 PM

#

Top right

golden vine May 28, 2018, 7:09 PM

#

but no button

#

is it a version issue?

#

no nvm

exotic venture May 28, 2018, 7:10 PM

#

thinkgrub

📎 unknown.png

#

maybe reading dependencies might help

golden vine May 28, 2018, 7:10 PM

#

what is modcommon

exotic venture May 28, 2018, 7:11 PM

#

also in the drive

compact sedge May 28, 2018, 7:11 PM

#

pretty sure randomizer even tells you in the mod if you don't have modcommon

young walrus May 28, 2018, 7:11 PM

#

It's like the api

#

But different

golden vine May 28, 2018, 7:11 PM

#

Thanks!

#

I had no idea xD

#

thxxx

#

I finally earned all steam achivements today so i started playing mods

exotic venture May 28, 2018, 7:11 PM

#

neat

golden vine May 28, 2018, 7:16 PM

#

wait 1 more question

#

about abilitie and charm randomizer

#

what is the "all bosses" "all charms" "all skills" about?

copper nacelle May 28, 2018, 7:17 PM

#

you can make it so it requires all bosses to beat the game

#

or all charms

#

or all skills

rain cedar May 28, 2018, 7:18 PM

#

Just do all 3 and go for 107% tbh

golden vine May 28, 2018, 7:18 PM

#

Ok

#

thats what i was going to do

#

thxxxx

flat forum May 28, 2018, 7:36 PM

#

Does This Work? Test Test

📎 ClassLibrary2.sln

compact sedge May 28, 2018, 7:36 PM

#

what are you doing

rain cedar May 28, 2018, 7:36 PM

#

Not much we can do with a sln file

compact sedge May 28, 2018, 7:36 PM

#

dunq

#

github man

flat forum May 28, 2018, 7:37 PM

#

Can't get it to work without Win64

compact sedge May 28, 2018, 7:37 PM

#

what

#

are you talking about

#

first of all why are you on 32 bit

flat forum May 28, 2018, 7:37 PM

#

can't get the GitHub thing without Win64

#

and because PC came like that

rain cedar May 28, 2018, 7:38 PM

#

Is your PC from 2003?

compact sedge May 28, 2018, 7:38 PM

#

it's windows 10

#

it's disgusting

#

idk how you use it

#

32 bit

rain cedar May 28, 2018, 7:38 PM

#

Wtf windows 10 32 bit

compact sedge May 28, 2018, 7:38 PM

#

windows 10

#

https://git-scm.com/download/win

#

there's literally a 32 bit version here

copper nacelle May 28, 2018, 7:38 PM

#

github desktop dungo

#

git works fine everywhere

flat forum May 28, 2018, 7:38 PM

#

I'll just

#

try things

#

again

#

tommorrow

#

because

compact sedge May 28, 2018, 7:39 PM

#

idgaf about github desktop

flat forum May 28, 2018, 7:39 PM

#

sleep

rain cedar May 28, 2018, 7:39 PM

#

Just use git from the command line

compact sedge May 28, 2018, 7:39 PM

#

github desktop is dumb

#

and git is great

#

y'all actually use github desktop?

rain cedar May 28, 2018, 7:39 PM

#

Nah

#

I use git from mingw

flat forum May 28, 2018, 7:40 PM

#

Gradow suggested it

compact sedge May 28, 2018, 7:40 PM

#

if you're on windows this is the correct answer

#

but the website I linked is that

#

git for mingw

copper nacelle May 28, 2018, 7:40 PM

#

i just use git

#

the mingw one

compact sedge May 28, 2018, 7:40 PM

#

https://git-scm.com/download/win this is literally that btw

copper nacelle May 28, 2018, 7:40 PM

#

ik

#

but github desktop is what wasn't 32 bit large dungo

flat forum May 28, 2018, 7:41 PM

#

downloading the 32 bit thing you sent

#

installed

#

I

#

will finish it tommorow

#

because

#

sleep

rain cedar May 28, 2018, 7:56 PM

#

@pearl sentinel I haven't tested it but I think you may have reinstated a bug I used to have in the gathering swarm thing

#

Where picking up a geo that's attacking a node can cause that node to never be targeted again until scene unload/load

#

The Disable function on geo isn't immediate so it still calls FixedUpdate after it

#

Meaning if attracted isn't set to false it gets added back into the tracked chasers

#

Wait nevermind I'm just bad at reading the commit diff

#

Although it does look like you're always disabling the original logic so it might never go after the player

#

Getting an NRE when I try to compile this for testing

[INFO]:[ModCommon] -  :::: CharmingMod.UnRegisterCallbacks() :::: 
[INFO]:[ModCommon] -  :::: CharmingMod.RegisterCallbacks() :::: 
[ERROR]:[API] - Error: System.NullReferenceException: original
  at ModCommon.PatchProcessor.Patch () [0x00000] in <filename unknown>:0 
  at ModCommon.HarmonyInstance.Patch (System.Reflection.MethodBase original, ModCommon.HarmonyMethod prefix, ModCommon.HarmonyMethod postfix, ModCommon.HarmonyMethod transpiler) [0x00000] in <filename unknown>:0 
  at CharmingMod.CharmingMod.PatchGeoControl () [0x00000] in <filename unknown>:0 
  at CharmingMod.CharmingMod.RegisterCallbacks () [0x00000] in <filename unknown>:0 
  at CharmingMod.CharmingMod.Initialize () [0x00000] in <filename unknown>:0 
  at Modding.ModLoader.LoadMod (IMod mod, Boolean updateModText) [0x00000] in <filename unknown>:0 
  at Modding.ModLoader.LoadMods () [0x00000] in <filename unknown>:0 ```

pearl sentinel May 28, 2018, 8:17 PM

#

Hmm, ok I'll look into it when I can

rain cedar May 28, 2018, 8:19 PM

#

It's because you're not matching parameters on FixedUpdate, pretty sure

#

The hooked functions have a bool argument but that's not a thing

pearl sentinel May 28, 2018, 8:22 PM

#

maybe. i was trying this out

#

https://github.com/pardeike/Harmony/wiki/Patching

GitHub

pardeike/Harmony

Harmony - A library for patching, replacing and decorating .NET and Mono methods during runtime

#

Patches can use a parameter named __state to store information in the prefix method that can be accessed again in the postfix method. Think of it as a local variable. It can be any type and you are responsible to initialize its value in the prefix

rain cedar May 28, 2018, 8:26 PM

#

Oh interesting

#

Well in any case that's not the issue anyway

#

Same error without those bools

#

I think I see the real issue

#

The NRE is because reflection isn't finding the Disable method

#

Wrong binding flags, it's a public method

#

Yeah that was it

pearl sentinel May 28, 2018, 8:29 PM

#

whoops

#

thanks for looking it over

rain cedar May 28, 2018, 8:30 PM

#

Also looks like I was right about it never going after the player

rain cedar May 28, 2018, 8:50 PM

#

Ok looks like in the pre method you need to declare __state as a ref var

pearl sentinel May 28, 2018, 8:51 PM

#

ahh, well, that makes sense

rain cedar May 28, 2018, 8:52 PM

#

I'll submit another pr with the fixes I've made

pearl sentinel May 28, 2018, 8:58 PM

#

sweet

#

i should have some more time later this week to clean things up more and post new releases with these updates

rain cedar May 28, 2018, 9:05 PM

#

Alright well it took me a while but I figured out how to do the stuff I needed to do

#

Never really worked with forked repos before

pearl sentinel May 28, 2018, 9:06 PM

#

accepted the pr

rain cedar May 28, 2018, 9:07 PM

#

Cool

pearl sentinel May 28, 2018, 9:09 PM

#

also just added the missing calls to the unregister callbacks that i forgot to put in

rain cedar May 28, 2018, 9:24 PM

#

Gathering swarm is crazy OP with this change

#

The extra geo from the nodes really adds up

#

It's great

solemn rivet May 28, 2018, 9:32 PM

#

maybe have them highlight the nodes instead of collecting them then?

rain cedar May 28, 2018, 9:33 PM

#

Nah I like how it works now

#

Doesn't have to be balanced to be fun

#

See: Your mods

solemn rivet May 28, 2018, 9:33 PM

#

zote

#

shots

rain cedar May 28, 2018, 9:33 PM

#

I called your mods fun

solemn rivet May 28, 2018, 9:33 PM

#

but, yeah, I getcha

#

I know, I'm just kidding

exotic venture May 28, 2018, 9:34 PM

#

heavy broken was so imbalanced at its earlier stages and i have never had so much fun with a mod

solemn rivet May 28, 2018, 9:34 PM

#

^

exotic venture May 28, 2018, 9:34 PM

#

everything broke and it was amazing

rain cedar May 28, 2018, 9:34 PM

#

It's still pretty broken

#

I just hit a crawlid and it went into the wall

exotic venture May 28, 2018, 9:34 PM

#

PFFRTT

rain cedar May 28, 2018, 9:34 PM

#

📎 unknown.png

exotic venture May 28, 2018, 9:35 PM

#

oh damn he actually went into the wall

hollow pier May 28, 2018, 9:35 PM

#

thats a tiktik sean wtf

#

stop clickbaiting

rain cedar May 28, 2018, 9:35 PM

#

Crawly thing

#

Crawlid

#

Never heard of a tiktik

hollow pier May 28, 2018, 9:35 PM

#

uh its a tikky thing

copper nacelle May 28, 2018, 9:35 PM

#

i think tiktik is the white one

#

idk tho

pearl sentinel May 28, 2018, 9:37 PM

#

Yeah heavy blow still needs more work to be finished. I'll see if I can work on it this week

exotic venture May 28, 2018, 9:39 PM

#

intenseeyes i'm up for testing

solemn rivet May 28, 2018, 9:41 PM

#

no need to work on it

#

it's perfect

#

perfect, I say

compact sedge May 28, 2018, 9:41 PM

#

^

#

but unironically, but ironically

pearl sentinel May 28, 2018, 9:42 PM

#

Mostly to add enemies damaging each other

exotic venture May 28, 2018, 9:42 PM

#

it's hollow knight bouncy castle edition

#

also i might make another video and i might or might not have permission to send it to wilbo

#

no pressure ofc

pearl sentinel May 28, 2018, 9:44 PM

#

Oh nice

copper nacelle May 28, 2018, 9:46 PM

#

wow gathering swarm op

compact sedge May 28, 2018, 9:46 PM

#

"hollow knight bouncy castle edition"

HK trampoline physics when. We need a mod that lets you jump at the right time to boost your enemies into spikes

copper nacelle May 28, 2018, 9:46 PM

#

it looks cool af too

compact sedge May 28, 2018, 9:46 PM

#

HK but every surface is a trampoline

solemn rivet May 28, 2018, 9:49 PM

#

well

#

sean was working on a momentum mod

#

to make HK full celeste-like

rain cedar May 28, 2018, 9:49 PM

#

That's pretty much done I just never released it

#

Small mod

bronze temple May 28, 2018, 9:50 PM

#

@rain cedar "Monomod hooks throw an error if you try to remove something from them that isn't in it"

I already fixed that bug many revisions ago 🤔

#

also, I'm just a ping away

#

I'd love to hear about bugs

rain cedar May 28, 2018, 9:50 PM

#

Ah ok I thought that was intentional

solemn rivet May 28, 2018, 9:51 PM

#

so, there's this bug called Elderbug and he's so nice

#

have you given him the flower yet?

#

also, 0x0ade, maybe our version of hooks is using an older version of monomod then?

copper nacelle May 28, 2018, 9:52 PM

#

yeah i should probably update that

bronze temple May 28, 2018, 9:52 PM

#

yup, looks like you're using an old HookGen

#

a few other bugs have been fixed as well

#

f.e. deeply nested types being "invisible"

copper nacelle May 28, 2018, 9:52 PM

#

cool

solemn rivet May 28, 2018, 9:53 PM

#

yeah, I had some issues with that

bronze temple May 28, 2018, 9:53 PM

#

I saw that you're possibly switching to Harmony. I'd like to hear your reasoning so that I can make MonoMod better for other communities (f.e. Rain World, Celeste) 😅

solemn rivet May 28, 2018, 9:54 PM

#

well

#

I don't get harmony, so I'm staying with monomod for the time being

#

:x

rain cedar May 28, 2018, 9:54 PM

#

I think kerr just did that because harmony is at runtime so it's easier to implement

pearl sentinel May 28, 2018, 9:55 PM

#

i just didn't want to add another dependency to my mods

#

since i can include the harmony source in mod common

bronze temple May 28, 2018, 9:56 PM

#

Oh, okay :) It's just that MonoMod.RuntimeDetour would allow you to do what Harmony does regarding detouring methods, minus runtime IL transpiling

#

while maintaining compatibility with mods using HookGen (which uses RuntimeDetour behind the scenes)

#

Nevertheless, I'll probably try to improve compatiblity between RuntimeDetour and Harmony

solemn rivet May 28, 2018, 9:58 PM

#

can't we instead merge our hooks.dll with modcommon?

bronze temple May 28, 2018, 9:58 PM

#

I've seen this being done before

#

you could

pearl sentinel May 28, 2018, 9:58 PM

#

ya'll have access to the mod common repo, feel free to add/edit w/e you want

solemn rivet May 28, 2018, 9:59 PM

#

@copper nacelle what do you think?

copper nacelle May 28, 2018, 9:59 PM

#

sure

bronze temple May 28, 2018, 9:59 PM

#

it's just that ILMerge creates a faulty library, and IIRC your problem with ILRepack was its version selection

copper nacelle May 28, 2018, 9:59 PM

#

ilrepack was working for me as far as versions

bronze temple May 28, 2018, 9:59 PM

#

although you need to keep in mind that the .NET Framework 3.5 builds on top of the 2.0 runtime :)

copper nacelle May 28, 2018, 9:59 PM

#

idk if it's still being weird

bronze temple May 28, 2018, 10:00 PM

#

I see that ILRepack "only" supports the target platforms v1, v1.1, v2 and v4

#

using v2 for 3.5 could work just fine, but I haven't tested that myself yet

copper nacelle May 28, 2018, 10:01 PM

#

@solemn rivet is build for .net 3.5 still being weird for you w/ hooks

#

cause if it is i'll swap it to v2

solemn rivet May 28, 2018, 10:02 PM

#

eh

#

I haven't tested

#

but I don't think so

copper nacelle May 28, 2018, 10:02 PM

#

cool

bronze temple May 28, 2018, 10:04 PM

#

Anyways, if there are any questions / issues / feedback, please don't hesitate to ping me 😄

copper nacelle May 28, 2018, 10:04 PM

#

am i doing something wrong

📎 unknown.png

bronze temple May 28, 2018, 10:04 PM

#

MonoMod isn't on NuGet yet

copper nacelle May 28, 2018, 10:04 PM

#

o

solemn rivet May 28, 2018, 10:04 PM

#

sneaky

bronze temple May 28, 2018, 10:04 PM

#

https://github.com/0x0ade/MonoMod

GitHub

0x0ade/MonoMod

MonoMod - A general purpose .NET assembly modding "basework", powered by cecil.

copper nacelle May 28, 2018, 10:04 PM

#

aa said use nuget for monomod so i thought it was

compact sedge May 28, 2018, 10:05 PM

#

no I said use nuget for the ilrepack

#

or whatever dll merging program you used

copper nacelle May 28, 2018, 10:05 PM

#

fake news

📎 unknown.png

compact sedge May 28, 2018, 10:05 PM

#

well I'm wrong then

#

it's kinda weird to redistribute prebuilt binaries in a github repo tho

copper nacelle May 28, 2018, 10:06 PM

#

¯_(ツ)_/¯

#

could make a subrepo and build it

bronze temple May 28, 2018, 10:06 PM

#

that's why submodules are a thing :)

copper nacelle May 28, 2018, 10:26 PM

#

@pearl sentinel should i push to another branch and make a pr?

solemn rivet May 28, 2018, 10:27 PM

#

this might be a dumb question, but, does it inherit from the Mod namespace? If it doesn't, why not?

copper nacelle May 28, 2018, 10:27 PM

#

does what

solemn rivet May 28, 2018, 10:27 PM

#

eh

#

me no know how to spek word

copper nacelle May 28, 2018, 10:28 PM

#

On or ModCommon?

pearl sentinel May 28, 2018, 10:28 PM

#

make a pr and i'll accept it

solemn rivet May 28, 2018, 10:28 PM

#

modcommon

copper nacelle May 28, 2018, 10:28 PM

#

modcommon inherits from mod yea

solemn rivet May 28, 2018, 10:28 PM

#

oh

#

can you make it have load priority then?

copper nacelle May 28, 2018, 10:28 PM

#

oh yeah

pearl sentinel May 28, 2018, 10:28 PM

#

mod common has a load priority

solemn rivet May 28, 2018, 10:28 PM

#

oh

copper nacelle May 28, 2018, 10:28 PM

#

nice

solemn rivet May 28, 2018, 10:28 PM

#

even better

compact sedge May 28, 2018, 10:28 PM

#

it's -1 right?

solemn rivet May 28, 2018, 10:28 PM

#

thanks Kerr!

pearl sentinel May 28, 2018, 10:28 PM

#

//Load the mod common first!
public override int LoadPriority()
{
return 0;
}

solemn rivet May 28, 2018, 10:28 PM

#

and thanks 56

compact sedge May 28, 2018, 10:29 PM

#

0

#

ok

#

then the default prio is 1 then

solemn rivet May 28, 2018, 10:29 PM

#

that should fix all future load order issues then

#

I mean, not literally all of them

copper nacelle May 28, 2018, 10:31 PM

#

https://github.com/Kerr1291/ModCommon/pull/1

solemn rivet May 28, 2018, 10:31 PM

#

but at least issues caused by loading a mod before its dependencies

compact sedge May 28, 2018, 10:31 PM

#

poor 56, spends 1 month trying to get a PR accepted into the API and only needs 1 minute to get it accepted into modcommon

solemn rivet May 28, 2018, 10:31 PM

#

zote

copper nacelle May 28, 2018, 10:31 PM

#

zote

compact sedge May 28, 2018, 10:31 PM

#

also fuck this means I have to update all my dlls thanks

copper nacelle May 28, 2018, 10:32 PM

#

you're welcome

solemn rivet May 28, 2018, 10:32 PM

#

so

#

are the hooks still On or do I need to change stuffs?

copper nacelle May 28, 2018, 10:32 PM

#

still On

solemn rivet May 28, 2018, 10:32 PM

#

great

copper nacelle May 28, 2018, 10:32 PM

#

if anyone else wants to try it

📎 ModCommon.zip

#

actual file is 8mb

solemn rivet May 28, 2018, 10:33 PM

#

I'll give it a go

compact sedge May 28, 2018, 10:33 PM

#

can you bump the modcommon version so I can implement a check if hooks are in that version of modcommon

copper nacelle May 28, 2018, 10:33 PM

#

sure

pearl sentinel May 28, 2018, 10:34 PM

#

merged your pr

#

also you should have access to mod common repo so i don't think your need to make a pr?

copper nacelle May 28, 2018, 10:34 PM

#

yeah

#

just didn't wanna accidentally do something that's bad practice

#

and then write to master

#

should I bump the ModCommonSettingsVar.ModCommonVersion var

#

@compact sedge 0.0.3

compact sedge May 28, 2018, 10:38 PM

#

ask kerr

#

It'd be helpful for me to have that variable to check if the hooks are in there

pearl sentinel May 28, 2018, 10:38 PM

#

feel free to bump them up

#

i don't think there's ever really harm in moving the version up if you make a change

copper nacelle May 28, 2018, 10:39 PM

#

ok cool

#

bumped to 0.0.3

#

I'll update it on the gdrive rn

compact sedge May 28, 2018, 10:42 PM

#

ok where do I put Assembly-CSharp-firstpass?

#

for the bootstrap

copper nacelle May 28, 2018, 10:42 PM

#

wdym

#

like for building modcommon?

compact sedge May 28, 2018, 10:42 PM

#

yeah

#

do I add the firstpass as a reference

copper nacelle May 28, 2018, 10:42 PM

#

just throw all the dlls in Managed into Vanilla

#

no refs or anything

#

vanilla dlls are better to put in vanilla cause then you don't get hooks for the modapi stuff tho

compact sedge May 28, 2018, 10:43 PM

#

ok one sec let me go find the non-beta dlls

copper nacelle May 28, 2018, 10:43 PM

#

but putting modded dlls works fine

compact sedge May 28, 2018, 10:44 PM

#

wait hold up so I need 1) a vanilla folder with vanilla DLLs
2) modding API assembly c# to build the rest of modcommon?

copper nacelle May 28, 2018, 10:45 PM

#

yes

compact sedge May 28, 2018, 10:45 PM

#

and 1 is just a folder and 2 I can add as a reference

copper nacelle May 28, 2018, 10:45 PM

#

yeah

compact sedge May 28, 2018, 10:45 PM

#

ok makes sense

#

sorry I just need to make sure I'm using non-beta dlls

copper nacelle May 28, 2018, 10:46 PM

#

all good

compact sedge May 28, 2018, 10:48 PM

#

also not your code 56 but modcommon needs to be built in debugging mode apparently

#

because it's using unsafe code

copper nacelle May 28, 2018, 10:48 PM

#

what

#

but it has unsafe on

#

📎 unknown.png

#

oh wait

#

active debug

#

¯_(ツ)_/¯

solemn rivet May 28, 2018, 10:50 PM

#

well, it's working perfectly for me

#

tested it with various mods

#

works fine

copper nacelle May 28, 2018, 10:50 PM

#

neat

compact sedge May 28, 2018, 10:52 PM

#

uhh putting DLLs in the Vanilla folder doesn't work because it doesn't check there

#

it checks the release folder

#

bin/Debug/ or bin/Release

copper nacelle May 28, 2018, 10:52 PM

#

aa

compact sedge May 28, 2018, 10:52 PM

#

pls fix

copper nacelle May 28, 2018, 10:53 PM

#

tbh

#

vanilla folder isn't needed

#

cause it references assembly-csharp and playmaker anyways

compact sedge May 28, 2018, 10:53 PM

#

no it is because it references modded assembly-csharp not vanilla and it needs the firstpass one too

copper nacelle May 28, 2018, 10:53 PM

#

what

#

firstpass shows up in debug anyways

#

and a hooked modded assembly-csharp is the same anyways

#

re

compact sedge May 28, 2018, 10:54 PM

#

only if you add firstpass as a ref

copper nacelle May 28, 2018, 10:55 PM

#

📎 unknown.png

compact sedge May 28, 2018, 10:55 PM

#

now what are your references for Mantis Gods

copper nacelle May 28, 2018, 10:55 PM

#

Assembly-CSharp, UnityEngine, UnityEngine.UI, Playmaker

#

same with this

📎 unknown.png

#

idek what firstpass does

compact sedge May 28, 2018, 10:56 PM

#

well it wasn't showing up when I built it

copper nacelle May 28, 2018, 10:56 PM

#

re

compact sedge May 28, 2018, 10:59 PM

#

but uh anyway if I delete the bin folder and build this is what I get

📎 unknown.png

solemn rivet May 28, 2018, 10:59 PM

#

so

#

can we remove hooks from gdrive and the xml now?

compact sedge May 28, 2018, 10:59 PM

#

📎 unknown.png

copper nacelle May 28, 2018, 10:59 PM

#

oh yea

compact sedge May 28, 2018, 10:59 PM

#

and here's my refs

copper nacelle May 28, 2018, 10:59 PM

#

white theme

#

delet this

compact sedge May 28, 2018, 10:59 PM

#

so it doesn't copy over the firstpass for some reason

#

can someone else git clone and build and see if I'm crazy or something

copper nacelle May 28, 2018, 10:59 PM

#

dunno

📎 unknown.png

solemn rivet May 28, 2018, 11:00 PM

#

I'm editing the xml then

copper nacelle May 28, 2018, 11:00 PM

#

cool

#

removed the folder

solemn rivet May 28, 2018, 11:01 PM

#

has anyone uploaded the dll to gdrive yet?

copper nacelle May 28, 2018, 11:01 PM

#

yea

#

did

solemn rivet May 28, 2018, 11:01 PM

#

ok

compact sedge May 28, 2018, 11:01 PM

#

well anyway I got my mods folder sorted out so all is well for me

copper nacelle May 28, 2018, 11:02 PM

#

neat

#

also double checked by downloading the zip

#

and building it

#

worked ¯_(ツ)_/¯

solemn rivet May 28, 2018, 11:02 PM

#

xml updated

compact sedge May 28, 2018, 11:03 PM

#

fyi you're adding as a ref the modding API assembly-csharp from seanpr's branch/the drive not yours right?

copper nacelle May 28, 2018, 11:03 PM

#

what

compact sedge May 28, 2018, 11:03 PM

#

for building modcommon

copper nacelle May 28, 2018, 11:03 PM

#

I'm just adding the normal Assembly-CSharp.dll as a ref

#

like from Managed

solemn rivet May 28, 2018, 11:03 PM

#

no need to reference the API

compact sedge May 28, 2018, 11:03 PM

#

it builds with the vanilla one

#

huh

solemn rivet May 28, 2018, 11:03 PM

#

we don't need to hook into the hooks

#

hookception

copper nacelle May 28, 2018, 11:04 PM

#

it was already referenced so i just hooked it

#

now you have hooks for your hooks

#

big meme

📎 unknown.png

solemn rivet May 28, 2018, 11:05 PM

#

you actually did that

#

nice

compact sedge May 28, 2018, 11:06 PM

#

ok now I'm confused because without the modding api assembly I can't build modcommon because modcommon uses elements from the modding api

copper nacelle May 28, 2018, 11:06 PM

#

exactly

#

i just run hooks on the modding api assembly

compact sedge May 28, 2018, 11:07 PM

#

but ur saying you are just adding the normal Assembly-CSharp.dll

copper nacelle May 28, 2018, 11:07 PM

#

no i forgot to change it

compact sedge May 28, 2018, 11:07 PM

#

does normal mean the API one

copper nacelle May 28, 2018, 11:07 PM

#

now it does

compact sedge May 28, 2018, 11:07 PM

#

ok

copper nacelle May 28, 2018, 11:07 PM

#

should be able to just clone, change refs to your file locations, and hit build

compact sedge May 28, 2018, 11:07 PM

#

ok

#

ok I figured out the "problem"

#

If you have the firstpass DLL in the same folder as the normal assembly csharp it copies it over but if not it ignores it yet still builds without error

#

even if you don't actually reference it

copper nacelle May 28, 2018, 11:11 PM

#

why do you have it in another folder

#

wtf

compact sedge May 28, 2018, 11:12 PM

#

I have a folder called Mods on my desktop which has all the custom DLLs plus a few vanilla game ones

#

but I didn't have the firstpass in there

#

because I never needed it to build anything before

#

📎 unknown.png

copper nacelle May 28, 2018, 11:12 PM

#

huh

#

why not just reference the api you use tho

compact sedge May 28, 2018, 11:12 PM

#

I just added that one my mouse is over

#

I do the Assembly-CSharp is modified

#

it's the API built over vanilla lifeblood

copper nacelle May 28, 2018, 11:14 PM

#

isn't that literally the same

compact sedge May 28, 2018, 11:14 PM

#

no the vanilla Assembly-CSharp has no modding api

copper nacelle May 28, 2018, 11:14 PM

#

but what

#

w h a t

#

isn't that the same as the api you have in mods tho

compact sedge May 28, 2018, 11:15 PM

#

wdym

copper nacelle May 28, 2018, 11:15 PM

#

why not just add your assembly reference as asdjfklasjdfasdf/Managed/Assembly-CSharp.dll

#

i mean

compact sedge May 28, 2018, 11:16 PM

#

my real hollow knight folder is running lifeblood beta but all the DLLs I use for this are built against lifeblood regular.

#

that way they'll not crash in a weird way

copper nacelle May 28, 2018, 11:16 PM

#

o

solemn rivet May 28, 2018, 11:31 PM

#

so, AA

#

I was fixing the folder structure for my mods as you suggested

#

📎 unknown.png

#

but

📎 unknown.png

compact sedge May 28, 2018, 11:32 PM

#

your folder is wrong

#

idk why

rain cedar May 28, 2018, 11:32 PM

#

📎 unknown.png

compact sedge May 28, 2018, 11:33 PM

#

Windows is case insensitive

#

so it doesn't matter on windows

#

but on not-windows hollow_knight_data and hollow_knight_Data are different paths

solemn rivet May 28, 2018, 11:34 PM

#

ok

#

beta release of the berserk mod

📎 API_BerserkMod_by_Gradow.zip

#

no readmes yet

#

on KBM berserk is bound to Backspace (because why not)

#

on controllers, it's bound to L3+R3

compact sedge May 28, 2018, 11:36 PM

#

well that's what they get for using KBM

#

wait L3?

#

I don't even have that button

copper nacelle May 28, 2018, 11:36 PM

#

that's what happens when you use controller

rain cedar May 28, 2018, 11:36 PM

#

L3 is clicking the left stick

compact sedge May 28, 2018, 11:36 PM

#

oh duhh nvm

solemn rivet May 28, 2018, 11:36 PM

#

I had it bound to End instead of backspace

#

but uhhh

compact sedge May 28, 2018, 11:37 PM

#

so you have to click both sticks

solemn rivet May 28, 2018, 11:37 PM

#

yeah

#

inspired by God of War

#

™

compact sedge May 28, 2018, 11:37 PM

#

thanks steam controller for only having one real stick

#

so I can click a stick and a pad

solemn rivet May 28, 2018, 11:37 PM

#

heh

#

I plan on making it rebindable at some point

compact sedge May 28, 2018, 11:37 PM

#

probably doesn't feel as nice

solemn rivet May 28, 2018, 11:38 PM

#

but I have no idea how to make a UI for that

compact sedge May 28, 2018, 11:38 PM

#

eh this is my revenge for cheating with my controller

solemn rivet May 28, 2018, 11:38 PM

#

I could add it as a setting tho

compact sedge May 28, 2018, 11:38 PM

#

having to click a pad

solemn rivet May 28, 2018, 11:38 PM

#

hm...

#

how would it save that as a setting? I think key codes are ints

copper nacelle May 28, 2018, 11:38 PM

#

globalsetting int

compact sedge May 28, 2018, 11:38 PM

#

^

solemn rivet May 28, 2018, 11:39 PM

#

no, I mean, I know how to save it IF it's an int

rain cedar May 28, 2018, 11:39 PM

#

It's an enum

solemn rivet May 28, 2018, 11:39 PM

#

if it isn't, then I have to figure out

rain cedar May 28, 2018, 11:39 PM

#

Which is an int

compact sedge May 28, 2018, 11:39 PM

#

all data can be reduced to integers

#

or other primative types

exotic dune May 28, 2018, 11:40 PM

#

all data can be reduced to an arbitrary number of bools 😎

burnt laurel May 29, 2018, 12:18 AM

#

oh

#

dashmaster

#

that's neat

#

that'll prove useful in the mantis lord fight

compact sedge May 29, 2018, 12:21 AM

#

uh this is silly but how do you get the modlog using debug mod?

#

it's not appearing in the console

rain cedar May 29, 2018, 12:29 AM

#

That's not related to debug mod

compact sedge May 29, 2018, 12:30 AM

#

ok for some reason I thought debug mod let you view the modlog ingame

rain cedar May 29, 2018, 12:31 AM

#

It is a thing but it's not from debug mod is all

#

Idk how to activate it, never used it

#

Looks like there's a bool in api global settings ShowDebugLogInGame

compact sedge May 29, 2018, 12:33 AM

#

ohhh

#

cool

burnt laurel May 29, 2018, 12:36 AM

#

aaand i'm stuck in the ceiling again

#

same enemy

compact sedge May 29, 2018, 12:42 AM

#

uh I have a problem. I'm trying to switch the texture on a GameObject, but every time I set the GameObject to a new texture it just overlaps with the previous ones

#

Here's my code:

GameObject canvas;
GameObject plane = CanvasUtil.CreateCanvas(RenderMode.ScreenSpaceOverlay, new Vector2(1920, 1080));
plane.SetActive(true);
...


Sprite renderSprite = Sprite.Create(fireBalls[currentImg], new Rect(0, 0, FBTEXTURE_WIDTH, FBTEXTURE_HEIGHT), new Vector2(0, 0));
canvas = CanvasUtil.CreateImagePanel(plane, renderSprite, new CanvasUtil.RectData(new Vector2(FBTEXTURE_WIDTH, FBTEXTURE_HEIGHT), new Vector2(200f, 0f)));

What I expect is the sprite I place to be replaced every time this second bit of code is run but instead it overlaps with the previous sprites.

rain cedar May 29, 2018, 12:47 AM

#

You want to do

canvas.GetComponent<Image>().sprite = renderSprite;

#

On subsequent runs

#

Right now you're just adding a new image panel each time

compact sedge May 29, 2018, 12:48 AM

#

what if I need to change the dimensions of the image panel

rain cedar May 29, 2018, 12:49 AM

#

Then you change sizeDelta on the RectTransform component

solemn rivet May 29, 2018, 12:49 AM

#

so, I'm having a bit of an issue

compact sedge May 29, 2018, 12:50 AM

#

uh there's no Image component of the canvas

solemn rivet May 29, 2018, 12:50 AM

#

what types can the modding api serializer save?

rain cedar May 29, 2018, 12:50 AM

#

You're still calling CreateImagePanel at least once, right?

#

Modding API serializer is the Unity serializer

solemn rivet May 29, 2018, 12:50 AM

#

oh

rain cedar May 29, 2018, 12:50 AM

#

Which is extremely limited

solemn rivet May 29, 2018, 12:50 AM

#

I'm trying to save an Int[]

#

but I don't see the option

compact sedge May 29, 2018, 12:51 AM

#

yeah canvas is a GameObject built with CanvasUtil.CreateImagePanel

rain cedar May 29, 2018, 12:51 AM

#

https://github.com/seanpr96/HollowKnight.Modding/blob/master/Assembly-CSharp/CanvasUtil.cs#L404

#

Then it should have an Image component

solemn rivet May 29, 2018, 12:52 AM

#

so I was trying to save it as a string and parse it to int[]

compact sedge May 29, 2018, 12:52 AM

#

oh UnityEngine.UI.Image

#

ok

#

nvm

rain cedar May 29, 2018, 12:52 AM

#

I do that in randomizer Gradow

#

But not for ints

solemn rivet May 29, 2018, 12:52 AM

#

I'm getting a typeloadexception tho

rain cedar May 29, 2018, 12:52 AM

#

For string?

solemn rivet May 29, 2018, 12:52 AM

#

dunno, doesn't say

#

private Key[] GetKeyArrayFromString(string var)
{
    return var.Split(',').Select(n => Convert.ToInt32(n)).Select(i => (Key)i).ToArray();
}```

#

but I know that this is what's causing it

rain cedar May 29, 2018, 12:53 AM

#

The enum is KeyCode

#

Idk what Key is

solemn rivet May 29, 2018, 12:53 AM

#

key is the type

#

you pass that to AddDefaultBinding

rain cedar May 29, 2018, 12:54 AM

#

I see

solemn rivet May 29, 2018, 12:54 AM

#

_berserkToggle.berserkKb.AddDefaultBinding(GetKeyArrayFromString(GlobalSettings.Keys));

#

and it does accept key[]

#

maybe it's my naming? If I change it from var to something else...

#

it might be mistaking var for a generic type

rain cedar May 29, 2018, 12:55 AM

#

Yeah maybe

#

I would expect it to not compile at all if that was the case, though

solemn rivet May 29, 2018, 12:55 AM

#

it does compile nicely and all

#

changed it to keys, let's see...

#

  at BerserkMod.Berserker.Initialize () [0x00000] in <filename unknown>:0 
  at Modding.ModLoader.LoadMod (IMod mod, Boolean updateModText) [0x00000] in <filename unknown>:0 
  at Modding.ModLoader.LoadMods () [0x00000] in <filename unknown>:0```

#

nope

#

hm...

#

well

#

I hope people don't want to bind it to multiple keys

#

cause I'm gonna remove the key[] parsing for now

compact sedge May 29, 2018, 1:00 AM

#

Thank you so much seanpr it works perfectly :) (video in #297468195026239489)

solemn rivet May 29, 2018, 1:00 AM

#

also, for some reason you can't bind PlayerActions to controller button combos, but you can to key combos

#

so I'm gonna make berserk trigger on a single button/key press

#

because I'm lazy

#

ok, it works perfectly

#

beta tentative release of the berserkmod with rebindable key/button

📎 API_BerserkMod_by_Gradow.zip

#

when I do make a readme, I'll add a list of all key/button codes for rebinding

burnt laurel May 29, 2018, 2:04 AM

#

a while ago i saw a video in here where someone was using blackmoth and just continuously dashed in the corner to defeat hornet

#

how do i do that

#

it was amazing

solemn rivet May 29, 2018, 2:04 AM

#

cheat

burnt laurel May 29, 2018, 2:04 AM

#

rip

solemn rivet May 29, 2018, 2:04 AM

#

he was using turbo

burnt laurel May 29, 2018, 2:04 AM

#

ah

#

what's that?

solemn rivet May 29, 2018, 2:04 AM

#

well

hazy sentinel May 29, 2018, 2:04 AM

#

this

📎 Turbo-Snail-icon.png

young walrus May 29, 2018, 2:04 AM

#

what's a turbo?

solemn rivet May 29, 2018, 2:05 AM

#

^

exotic dune May 29, 2018, 2:05 AM

#

damned snail shaman

young walrus May 29, 2018, 2:06 AM

#

original concept snail shaman when?