#archived-modding-development | Hollow Knight | Page 97

compact sedge May 20, 2018, 5:22 AM

#

for the charms themselves

#

they're scattered all over the place

#

somewhat in fsms somewhat it game logic

flat forum May 20, 2018, 5:22 AM

#

...why?...

compact sedge May 20, 2018, 5:22 AM

#

¯_(ツ)_/¯

flat forum May 20, 2018, 5:29 AM

#

Is your 2nd mod on the Github?

compact sedge May 20, 2018, 5:30 AM

#

yes but no binaries yet

#

you can build it yourself but I wanna test it for the next hour roundabout

#

and then I wanna get it on the drive if it's good enough

#

but yeah I'm very intent on getting my source code on the internet ASAP so people can use it as quickly as possible, but building my own binaries I'm more lazy about because I'd have to write patchnotes

copper nacelle May 20, 2018, 5:32 AM

#

just write

#

various fixes/changes

#

hollowface

compact sedge May 20, 2018, 5:33 AM

#

also I have to update infinite grimm as well (I mean make an updated binary)

#

so people can get the dank integration between the two mods

#

from my second most recent release @copper nacelle

📎 unknown.png

copper nacelle May 20, 2018, 5:33 AM

#

lol

compact sedge May 20, 2018, 5:34 AM

#

and that corner case https://github.com/natis1/infinitegrimm/issues/25

GitHub

White screen after respawning after second time (and beyond) when ...

WTF
White screen is fixed by returning to main menu or redoing the fight.

#

idk what caused it and idk how I fixed it

#

but I'm pretty sure I fixed it

copper nacelle May 20, 2018, 5:34 AM

#

lul

compact sedge May 20, 2018, 5:35 AM

#

but yeah you had to fight grimm with grimmchild, return, refight grimm, do such an amount of damage that the damage message changes, and then die and then it happens

#

it happened about 40% of the time

#

but I fought grimm 10 times that way and it didn't happen after changing some code so I think I fixed it based on that

#

uhhh PlayerData.instance.CalculateNotchesUsed does NOTHING

#

when called in reset

copper nacelle May 20, 2018, 5:43 AM

#

r u using the onint thingy

#

the intget hook

compact sedge May 20, 2018, 5:43 AM

#

I'm doing on activeSceneChanged

#

running PlayerData.instance.CalculateNotchesUsed

copper nacelle May 20, 2018, 5:44 AM

#

boi

#

are you using the onint hook tho

#

to set charm costs

compact sedge May 20, 2018, 5:44 AM

#

what hook

#

I have CharmUpdateHook

#

that's about it

copper nacelle May 20, 2018, 5:45 AM

#

ModHooks.Instance.GetPlayerIntHook

compact sedge May 20, 2018, 5:45 AM

#

no?

copper nacelle May 20, 2018, 5:46 AM

#

aa

#

getplayerint breaks it

#

but uhh

#

if you're just setting it

#

it should work fine

#

got them both past half health

#

wait what's not happening tho

compact sedge May 20, 2018, 5:52 AM

#

it's not setting them as overcharmed even though, with the extra cost, they should be

copper nacelle May 20, 2018, 5:52 AM

#

does the charm show up w/ the cost in the inventory?

compact sedge May 20, 2018, 5:53 AM

#

oh crap I can't test anymore because I fixed my build

copper nacelle May 20, 2018, 5:53 AM

#

what

compact sedge May 20, 2018, 5:53 AM

#

brb let me do 4k damage to IG hardmode

copper nacelle May 20, 2018, 5:53 AM

#

aaa

#

i gotta sleep

#

2am

#

elderbug

compact sedge May 20, 2018, 5:54 AM

#

wtf

#

u up this late

hollow pier May 20, 2018, 5:55 AM

#

wake up at 5pm

flat forum May 20, 2018, 5:57 AM

#

sleep

#

Now

#

back to asking stupid amounts of idiotic questions

#

can I get a few example mods that store things?

#

I wanna try figuring out how it works

compact sedge May 20, 2018, 6:04 AM

#

yeah example mod 2 saves data in the local save file

#

and example mod 3 saves data in a json config file that users can edit

flat forum May 20, 2018, 6:04 AM

#

this one?

#

https://github.com/seanpr96/HollowKnight.Modding/blob/master/ExampleMods/Source/ExampleMod2/ExampleMod2.cs

GitHub

seanpr96/HollowKnight.Modding

Contribute to HollowKnight.Modding development by creating an account on GitHub.

compact sedge May 20, 2018, 6:04 AM

#

alright why isn't this working

📎 unknown.png

#

yeah

flat forum May 20, 2018, 6:06 AM

#

why isn't what working?

compact sedge May 20, 2018, 6:07 AM

#

count the notches

#

2 + 5 + 2 + 3 = 12

#

but I have 11 in the notches section

flat forum May 20, 2018, 6:08 AM

#

hm

#

try unequipping everything

#

and then equipping Deep Focus, Hive Blood and then GrimmChild

compact sedge May 20, 2018, 6:10 AM

#

that's the problem you unequip and reequip it works

#

but not just by default

#

I'm saying screw it and making the player overcharmed on all upgrades

flat forum May 20, 2018, 6:11 AM

#

Wait

#

So

compact sedge May 20, 2018, 6:11 AM

#

so whenever you get an upgrade and the charm cost goes up it assumes you had a full set and overcharms you

flat forum May 20, 2018, 6:11 AM

#

if you beat NKG you don't get overcharmed right after that, but after you unequip and re-equip the charm?

compact sedge May 20, 2018, 6:11 AM

#

yes

#

so you can get max upgrade and it only uses 2 notches

#

so long as you never take it off

flat forum May 20, 2018, 6:12 AM

#

That's probably some notch storage thing or something that you can't really fix

compact sedge May 20, 2018, 6:32 AM

#

you know what's stupid. if you set ITogglableMod it means you can toggle if the mod is on or not while in game

#

like not just in the menu

#

but in game

#

and there's no way I can write something to let my mod be dynamically turned off while in game, but I want it to be turnoffable while in the menu

leaden hedge May 20, 2018, 6:38 AM

#

you can probably (read definitely just not sure how much of a pain in the ass it'll be) find your mods toggle button in the menu and set it to disabled during gameplay

#

pretty sure unity has a built in disabled property for ui components that let you just disable interactions

#

however finding it may be difficult and you may just need to check the text on all the buttons

compact sedge May 20, 2018, 6:53 AM

#

idc, it mostly exists so players have a way to reset the charm cost easilly and also to disable it without uninstalling if they don't like it for whatever reason

#

if players are using it in game they should expect stuff to break, it might not when grimmchild isn't equipped but idk

#

it's probable that if grimmchild is on that the grimmballs will break until they remove and readd it

#

Alright I am really feeling this mod. Although it certainly has some bugs I don't know about so please help me test it if you can!

📎 grimmchildupgrades.dll

#

You don't need infinite grimm for it but it is designed to be used with it. You do need modcommon

#

wtf steam stop crashing on me im triyng to tst a mod

#

I had such a good run too

#

but when steam crashes it brings the game with it

torn fulcrum May 20, 2018, 7:14 AM

#

that reminded me, I was playing randomizer yesterday and got to the part where you normally get the dream nail and then the game froze

rain cedar May 20, 2018, 7:15 AM

#

Not my problem

#

The game just does that there

#

Assuming by "froze" you mean you were stuck falling in the cutscene, not that it actually froze

#

If it actually froze that's not normal

leaden hedge May 20, 2018, 7:16 AM

#

you can't just steal my phrase

#

you'll hear from my lawyers

rain cedar May 20, 2018, 7:16 AM

#

But it isn't my problem

compact sedge May 20, 2018, 7:17 AM

#

I had a storage bug in my mod and I fixed it anyway which I guess makes me better than TC

torn fulcrum May 20, 2018, 7:17 AM

#

ye I know it isn't

#

it might have to do with me getting the dream nail earlier

rain cedar May 20, 2018, 7:19 AM

#

Oh that might actually be my problem then

#

How did the freeze look?

torn fulcrum May 20, 2018, 7:23 AM

#

I read the sign and it said dreamer locations added to map and stuff. Then when the knight turned around it froze when they were facing left

#

right*

rain cedar May 20, 2018, 7:25 AM

#

So it wasn't this one, then? https://www.twitch.tv/videos/138285467

#

That's the one that just happens sometimes without mods

torn fulcrum May 20, 2018, 7:26 AM

#

nah

#

another thing is that the light wall thing didn't appear

rain cedar May 20, 2018, 7:27 AM

#

I know why that happens but I don't know how to fix it

#

The soft lock is probably related

#

For future reference if you have dream nail already enter the room from the right side before interacting

#

The way the game handles boss scenes (Xero) messes with the stuff I do

torn fulcrum May 20, 2018, 7:28 AM

#

alright, I'll try, thank you

compact sedge May 20, 2018, 8:37 AM

#

Alright I spent about 2 hours testing my second mod and I'm feeling pretty good about publishing it as a DLL on github. ~~https://github.com/natis1/grimmchildupgrades/releases/tag/0.1.0~~

If you find any bugs please let me know though.

steep sail May 20, 2018, 8:54 AM

#

@compact sedge what does it do?

compact sedge May 20, 2018, 8:55 AM

#

It makes grimmchild stronger. Here's a full description https://github.com/natis1/grimmchildupgrades/blob/master/README.md

GitHub

natis1/grimmchildupgrades

grimmchildupgrades - A Hollow Knight mod for a better Grimmchild

steep sail May 20, 2018, 8:57 AM

#

hmmm... Lack of precise info. How many notches it will cost?

compact sedge May 20, 2018, 8:59 AM

#

the lack of precise info is intentional for now because its strength, cost, speed, damage, fireball size, etc. are all dependant on its level. Without Infinite grimm its level is set to maximum, and these values are quite high (viewable and configurable in the config file). With it its level is set based on the damage you have done to infinite grimm.

#

But since you asked here's the complete list:

maxAttackSpeedMult = 2.0f;
maxRangeMult = 2.0f;
maxBallMoveSpeed = 1.5f;
maxBallSize = 2.0f;

maxDamage = 35;
notchesCost = 6;

#

max values are the values set at the maximum level

#

at non-maximum levels these values are fractions of this

steep sail May 20, 2018, 9:05 AM

#

Wow...

#

6

#

6 notches

compact sedge May 20, 2018, 9:05 AM

#

it's really strong

steep sail May 20, 2018, 9:06 AM

#

But not for 6 notches

#

4-5

compact sedge May 20, 2018, 9:06 AM

#

at 6 notches it's definitely slightly overpowered

#

try it out

#

in the arena, against zote, wherever

steep sail May 20, 2018, 9:06 AM

#

After NKG)

#

Only after NKG

compact sedge May 20, 2018, 9:06 AM

#

oh right you do need to beat NKG first

#

or it doesn't apply

#

or it shouldn't apply

#

if it does that's a bug

#

oh it probably was applying without beating NKG, but I am fixing that right now

#

https://github.com/natis1/grimmchildupgrades/releases/tag/0.1.1

GitHub

natis1/grimmchildupgrades

grimmchildupgrades - A Hollow Knight mod for a better Grimmchild

flat forum May 20, 2018, 12:23 PM

#

📎 unknown.png

#

Finally

#

took me long enough

#

📎 unknown.png

acoustic ibex May 20, 2018, 12:29 PM

#

I'm still stuck on the mod installation bit

#

so i've got the mod api in place

#

but I dunno what to do now

flat forum May 20, 2018, 12:29 PM

#

mhm

#

So

#

Lemme show you how I've done things

acoustic ibex May 20, 2018, 12:29 PM

#

btw what does the boss rush mod do

#

okay ty

flat forum May 20, 2018, 12:29 PM

#

Oh, Boss Rush?

#

I don't think it's up to date

#

for the latest version of HK

#

but it used to let you fight all the bosses, giving you a small rest after each one

acoustic ibex May 20, 2018, 12:30 PM

#

oh that's a fun mod

#

this is the one i'm trying to install

#

https://github.com/seanpr96/DebugMod

GitHub

seanpr96/DebugMod

DebugMod - Debug Mod for Hollow Knight

flat forum May 20, 2018, 12:31 PM

#

So, the API should be in Steam>Steamapps>common>Hollow Knight>HollowKnight_data>Managed

#

📎 unknown.png

#

look at the thing on top

#

I made a separate Folder for the API

#

you replace the Assembly-CSharp.dll with the API one

#

then make a Folder called "Mods"

#

and install whatever mod you want there

#

after that make sure that the .dll file of the mod is in there

acoustic ibex May 20, 2018, 12:32 PM

#

so i just copy and paste the whole source folder in there?

flat forum May 20, 2018, 12:32 PM

#

Well

#

I'd suggest getting things from here

#

I think the latest version should be the one

#

https://drive.google.com/drive/folders/0B_b9PFqx_PR9Um9MeFZMV21oWGs?usp=sharing

acoustic ibex May 20, 2018, 12:33 PM

#

oh wow

#

thanks

flat forum May 20, 2018, 12:33 PM

#

If not

#

I'll see which one I have and try sending it

acoustic ibex May 20, 2018, 12:33 PM

#

what are some mods that you recommend?

flat forum May 20, 2018, 12:33 PM

#

Oh

#

I'm usually in for a challenging fight

#

so, my favorites are Mantis Gods and InfiniteGrimm

acoustic ibex May 20, 2018, 12:34 PM

#

do they respawn the boss or do you have to go there again?

flat forum May 20, 2018, 12:34 PM

#

Mantis Gods makes the fight against the mantis lords much harder - basically an end game fight

#

(Infinite Grimm respawns Boss, Mantis Gods is still semi-WIP)

#

InfiniteGrimm makes it so that you can endlessly refight NKG once you have defeated him and gotten Grimmchild Lv. 4

#

The fight gets increasingly difficult tho

#

and Grimm never dies

#

after you die it tells you how much Damage you've done

acoustic ibex May 20, 2018, 12:36 PM

#

lol

#

that sounds

#

pretty intense

#

hardcore*

flat forum May 20, 2018, 12:36 PM

#

yeah

#

but it's pretty fun too

#

my record was like

#

lemme check

#

https://steamuserimages-a.akamaihd.net/ugc/921428223737746715/C33518F40AD03F0584C2E5501509E1CE30346662/

#

11227 damage

acoustic ibex May 20, 2018, 12:38 PM

#

lol wow

#

what's the empress muzznik mod

flat forum May 20, 2018, 12:38 PM

#

Oh

acoustic ibex May 20, 2018, 12:38 PM

#

I couldn't even get past grimm

#

like

#

normal grimm

#

so that's pretty impressive

flat forum May 20, 2018, 12:39 PM

#

this one made The Gruzz mother a tough boss - constantly spawning baby Gruzzflies and taking like a gabjillion hits to kill

#

But I have never actually played it myself

#

This one, along with (IIRC) Scale Mod, LightBringer, Glass Soul, Nightmare Mod Grimm aren't for the latest version

acoustic ibex May 20, 2018, 12:41 PM

#

rip

flat forum May 20, 2018, 12:41 PM

#

NGG was for the latest Grimm Troupe version I think

#

and the others are older

acoustic ibex May 20, 2018, 12:42 PM

#

I can understand since it was just updated

flat forum May 20, 2018, 12:42 PM

#

but if you really want to play them

#

you can try downgrading your game back to 1.2.whatever

acoustic ibex May 20, 2018, 12:42 PM

#

haha it's fine

#

i'll just put hollow knight on hold for a bit

#

Until guns and glory comes out

flat forum May 20, 2018, 12:43 PM

#

Well, Debug Mod should be easy todownload

#

you have the API, right?

acoustic ibex May 20, 2018, 12:43 PM

#

yeah

flat forum May 20, 2018, 12:44 PM

#

like, you replaced the Assembly-CSharp

acoustic ibex May 20, 2018, 12:44 PM

#

I did?

flat forum May 20, 2018, 12:44 PM

#

now you just need to make a "Mods" Folder in which to put the Mod

#

📎 DebugMod.dll

#

I think that's the latest version of the Debug Mod

#

📎 Assembly-CSharp.dll

#

this should be the Assembly-CSharp

#

also, @copper nacelle, once you beat them you can't really respawn them or escape....

#

@copper nacelle
https://cdn.discordapp.com/attachments/327461802311155714/447736105488613376/unknown.png
https://cdn.discordapp.com/attachments/327461802311155714/447736592082141184/unknown.png

acoustic ibex May 20, 2018, 12:47 PM

#

oh i see

flat forum May 20, 2018, 12:47 PM

#

These are for the Maker of that Mod

#

The 2 files are for you

#

=P

acoustic ibex May 20, 2018, 12:48 PM

#

Oh yeah it got installed

#

ty

flat forum May 20, 2018, 12:48 PM

#

=D

#

No Problem

acoustic ibex May 20, 2018, 12:48 PM

#

so i see you like hollow knight

flat forum May 20, 2018, 12:49 PM

#

yeah

#

Until G&G comes out I'm mainly playing mods

#

testing if I can help out with something

acoustic ibex May 20, 2018, 12:49 PM

#

maybe you can do like a whole no-hit playthrough or something

#

except fast tracked

flat forum May 20, 2018, 12:50 PM

#

So, Glass Soul

acoustic ibex May 20, 2018, 12:50 PM

#

tbh i'd watch that

flat forum May 20, 2018, 12:50 PM

#

I wouldn't mind trying to

#

but I don't know if I'll have the time to do it

#

because

#

Finals

cursive bone May 20, 2018, 12:56 PM

#

Is the randomizer mod updated for the latest version?

flat forum May 20, 2018, 1:10 PM

#

I don't know, sorry

acoustic ibex May 20, 2018, 1:16 PM

#

rip me

#

I respawned the mantis lords but i saved in the treasure room and now the door wont open

flat forum May 20, 2018, 1:23 PM

#

Well

weak lodge May 20, 2018, 1:23 PM

#

Mantis gods look great

flat forum May 20, 2018, 1:23 PM

#

You have the thing open, right?

#

on the menu at the top Right there should be a cheats thing

#

And in there, there should be a NoClip

#

And in there, there should be a NoClip

#

activate it

#

and walk through the doo

#

r

#

and then turn it off

fair rampart May 20, 2018, 1:51 PM

#

Hey guys! i have one question .
I want to install a mod, but i haven't finished the actual vanilla hollow knight, so what are your advices? should i do it or not or does it affect my saved data? noot

copper nacelle May 20, 2018, 1:52 PM

#

most mods affect save data once you open a save

floral furnace May 20, 2018, 1:52 PM

#

honestly dont imo, you should finish whatever vanilla stuff you have first

copper nacelle May 20, 2018, 1:52 PM

#

so i'd finish the game first tbh

fair rampart May 20, 2018, 2:00 PM

#

k, thanks

flat forum May 20, 2018, 2:05 PM

#

56, did you see?

copper nacelle May 20, 2018, 2:05 PM

#

yeah

flat forum May 20, 2018, 2:05 PM

#

I finally managed to beat the Mantis Gods

copper nacelle May 20, 2018, 2:06 PM

#

hollowknice

#

think i've got an idea on how to fix the transition now

#

haha yes

📎 unknown.png

#

should i change the particle colors

#

or remove them

#

or no

flat forum May 20, 2018, 2:10 PM

#

Put the Black Egg temple ones

#

Also, make them instantly respawn

#

So you can...

copper nacelle May 20, 2018, 2:10 PM

#

wdym

flat forum May 20, 2018, 2:10 PM

#

Always fight them

#

I said that after beating them entering the room again is a lock

#

You can't get out

#

And you can't fight them

#

So, make them "spawn" the moment you enter the room so you can always refight them qhen you travel there

#

And yeah, put the Black Egg Temple particles there

copper nacelle May 20, 2018, 2:12 PM

#

okay

#

should i readd the spikes

#

or no

flat forum May 20, 2018, 2:13 PM

#

Leave them removed?

copper nacelle May 20, 2018, 2:13 PM

#

yea

flat forum May 20, 2018, 2:14 PM

#

You still have a hogh chance to be hit by the boomerang

#

And Boomerangs, as we already said make thing harder

#

Talking about boomerangs

#

Did you remove them from the 2nd fight?

copper nacelle May 20, 2018, 2:14 PM

#

no

#

i think they're fine in the second fight as it is

#

maybe a bit slower

flat forum May 20, 2018, 2:15 PM

#

Why?

copper nacelle May 20, 2018, 2:15 PM

#

still dodgable

flat forum May 20, 2018, 2:15 PM

#

cryla

#

Hmmm

#

Yes but...

#

Uhh
Ummmmm

Ok

copper nacelle May 20, 2018, 2:19 PM

#

well on the bright side transitions work now

#

exactly as i intended too

flat forum May 20, 2018, 2:20 PM

#

?

#

How did they work before?

#

What did you intend and what was off?

copper nacelle May 20, 2018, 2:21 PM

#

uhh

#

now when you go into the room it doesn't take you into a black screen where the pause screen is invisible

#

instead it just drops you into the arena

#

and you fall kinda like the gpz fight

hazy sentinel May 20, 2018, 2:22 PM

#

any 56 polishing mods

copper nacelle May 20, 2018, 2:22 PM

#

yes

hazy sentinel May 20, 2018, 2:22 PM

#

wtf

flat forum May 20, 2018, 2:22 PM

#

Cool

copper nacelle May 20, 2018, 2:23 PM

#

why are particles effort

karmic jungle May 20, 2018, 3:00 PM

#

Does the boss rush mod still work?

copper nacelle May 20, 2018, 3:04 PM

#

it doesn't work on lifeblood but you can downpatch to 1.2.2.1 if you want to use it

karmic jungle May 20, 2018, 3:04 PM

#

Cool, thanks

sterile valley May 20, 2018, 3:10 PM

#

📎 unknown.png

copper nacelle May 20, 2018, 3:10 PM

#

cornywoke

flat forum May 20, 2018, 3:21 PM

#

Are particles gard to mive from 1 room to another

karmic jungle May 20, 2018, 3:28 PM

#

I feel like a huge noob right now, but I can't seem to downpatch. :/

copper nacelle May 20, 2018, 3:28 PM

#

are you using the speedrunning.com guide

solemn rivet May 20, 2018, 3:28 PM

#

^

#

56 is 56x quicker than me

copper nacelle May 20, 2018, 3:29 PM

#

🏃

solemn rivet May 20, 2018, 3:29 PM

#

grimm

flat forum May 20, 2018, 3:31 PM

#

Hey Gradow

#

How did the thing go

#

The one on Friday

solemn rivet May 20, 2018, 4:07 PM

#

Eh which one? Which Friday?

#

elderbug what year is this?

#

Oh you mean seminar/conference thingy?

copper nacelle May 20, 2018, 4:07 PM

#

yes

solemn rivet May 20, 2018, 4:09 PM

#

It went fine. Lots of Ukrainian people, and there was also this, like, guys who is the best of his field attending the conference

#

So I was pretty nervous

#

But it all went smoothly

#

And I even chatted some with that guy

#

He be nice

#

Very cool

#

He's like 70+ I think

#

He and his wife were the cutest couple. We went out for drinks after the first day of talks

#

He drinks like a champ

#

And I drink like a chimp, whatever that means

copper nacelle May 20, 2018, 4:11 PM

#

zote

solemn rivet May 20, 2018, 4:12 PM

#

He even gave me some pointers for future reference

#

All in all, a great experience

#

Except for the fact that I was like 20 minutes late for my flight home

#

But it all worked out

#

And now I'm very much glad that I don't have any other presentations/talks/seminars to attend to until December

#

So I can go back to being the good ol' lazy Gradow

copper nacelle May 20, 2018, 4:15 PM

#

lol

solemn rivet May 20, 2018, 4:16 PM

#

So, 8/8 gr8

#

And thanks for asking and caring btw

#

You guys have all been great

#

grimmwink

copper nacelle May 20, 2018, 4:17 PM

#

happygrub

flat forum May 20, 2018, 4:34 PM

#

I'm happy it went well

#

so

#

back to asking stupid amount of questions in order to make an attempt at making a mod

#

So, I'm supposed to store the size of the Nail, before resizing the stored thing and then applying it to the original

copper nacelle May 20, 2018, 4:40 PM

#

uhh

#

yeah except you don't resize the stored thing

#

you resize the original using the stored thing's value

flat forum May 20, 2018, 4:40 PM

#

Then what do I resize?

copper nacelle May 20, 2018, 4:40 PM

#

so like

#

if you had attack damage as an example

#

you'd store it into a var

#

and then you set nail damage using that variable

#

so like

flat forum May 20, 2018, 4:41 PM

#

I change to damage of the Variable and then?

copper nacelle May 20, 2018, 4:41 PM

#

int x = PlayerData.instance.nailDamage;
PlayerData.instance.nailDamage = x * PlayerData.instance.health;

#

as an example

#

except you would only set x once

#

at the beginning of the game

#

before changing it

flat forum May 20, 2018, 4:43 PM

#

is there some example mod I can look at

#

this?

#

https://github.com/seanpr96/HollowKnight.Modding/blob/master/ExampleMods/Source/ExampleMod1/ExampleMod1.cs

GitHub

seanpr96/HollowKnight.Modding

Contribute to HollowKnight.Modding development by creating an account on GitHub.

copper nacelle May 20, 2018, 4:43 PM

#

yeah that's an example mod

flat forum May 20, 2018, 4:43 PM

#

is it a good example for what I'm trying to do tho

copper nacelle May 20, 2018, 4:45 PM

#

yes

flat forum May 20, 2018, 4:46 PM

#

so, is the private int _tempNailDamage; thing the thing?

copper nacelle May 20, 2018, 4:46 PM

#

yeah that's the var they use to store nail damage

flat forum May 20, 2018, 4:47 PM

#

as a bit later on there's this
_tempNailDamage = PlayerData.instance.nailDamage;

#

which sets it to be the same as the Nail Damage

copper nacelle May 20, 2018, 4:47 PM

#

yeah

#

the way they do is they change nail damage back to that variable right after the attack

#

so it doesn't stack

flat forum May 20, 2018, 4:49 PM

#

So, to store Nail Size I can do the same

#

what is the Nail Size?

#

is it like a...

copper nacelle May 20, 2018, 4:50 PM

#

vector3 iirc

flat forum May 20, 2018, 4:50 PM

#

HeroController.Instance.

#

slashComponent?

solemn rivet May 20, 2018, 4:50 PM

#

You have to get the nail's transform localscale iirc

copper nacelle May 20, 2018, 4:50 PM

#

iirc sean said you don't need to use transform

solemn rivet May 20, 2018, 4:50 PM

#

Oh

#

Dunno then

copper nacelle May 20, 2018, 4:51 PM

#

📎 unknown.png

#

just slashComponent.scale

#

i think

flat forum May 20, 2018, 4:51 PM

#

is there a slashComponent.Scale ot something?

#

Oh

#

Ok

solemn rivet May 20, 2018, 4:51 PM

#

Oh

#

I stand corrected

supple sigil May 20, 2018, 4:52 PM

#

oh so thats where the escape key is

copper nacelle May 20, 2018, 4:53 PM

#

cornywoke

flat forum May 20, 2018, 4:54 PM

#

so

private int modLength;
modLength = HeroController.Instance.slashComponent.Scale
if PlayerData.instance.equippedCharm_18
HeroController.Instance.slashComponent.Scale...

wait...

#

I got confused mid way

copper nacelle May 20, 2018, 4:55 PM

#

slashComponent is private

#

iirc

solemn rivet May 20, 2018, 4:55 PM

#

Yeah

flat forum May 20, 2018, 4:55 PM

#

so....? I can't just get it?

solemn rivet May 20, 2018, 4:55 PM

#

Refer to code I sent you earlier to get that

flat forum May 20, 2018, 4:55 PM

#

Oh

#

the FieldInfo thing?

solemn rivet May 20, 2018, 4:55 PM

#

Like earlier this week

copper nacelle May 20, 2018, 4:55 PM

#

HeroController.Instance.GetType().GetField("slashComponent", BindingFlags.Instance | BindingFlags.NonPublic).GetValue(HeroController.Instance)

#

or whatever

solemn rivet May 20, 2018, 4:55 PM

#

^

flat forum May 20, 2018, 4:57 PM

#

I'm still not completely understanding how this works and what specifically it does

#

lemme google the BindingFlags thing

copper nacelle May 20, 2018, 4:57 PM

#

you're getting the type so you can do a get field on it

#

which gets a fieldinfo

#

specifying bindingflags lets you get private variables

#

and stuff

#

and then you're doing get value (of that field) for the object HeroController.Instance

flat forum May 20, 2018, 4:58 PM

#

the fact that it's private makes things a bit more confusing for me

#

here is the FieldInfo thing I have

#

FieldInfo fi = typeof(MyClass).GetField("myInt", BindingFlags.NonPublic | BindingFlags.Instance); int x = fi.GetValue(InstanceOfMyClass);
if( modLength == null ) modLength = fi.GetValue(HeroController.Instance) nailLength = modLength * multiplier;

and I have this a bit further down

FieldInfo fi = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance); GameObject = fi.GetValue(HeroController.Instance);

#

Why is it private... TnT

copper nacelle May 20, 2018, 5:01 PM

#

because it wants to be

#

instead of GameObject whatever = fi.GetValue(HeroController.Instance);

#

pretty sure it should be

#

NailSlash x = (NailSlash) fi.GetValue(HeroController.Instance);

#

cause myInt should be slashComponent

flat forum May 20, 2018, 5:03 PM

#

So, this

FieldInfo fi = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance); NailSlash x = (NailSlash) fi.GetValue(HeroController.Instance);

#

?

#

(Brb, gotta dinner)

copper nacelle May 20, 2018, 5:05 PM

#

yes

#

then you can do x.scale and stuff

flat forum May 20, 2018, 5:13 PM

#

Where do I do the x.scale and stuff? On a separate thing where I set ModLength or somewhere in there?

#

with the Nailslash x thing

#

FieldInfo fi = typeof(HeroController).GetField("slashComponent", BindingFlags.NonPublic | BindingFlags.Instance); NailSlash x = (NailSlash) fi.GetValue(HeroController.Instance);

modLength = ... ?

#

Oh

#

on a side note thing

#

Nail Damage isn't private, right?

#

Good

#

this one should be easier then\

#

the Meat of this thing should be something like this
private int RageNailDamage

#

then

#

if (PlayerData.instance.equippedCharm_6 )

#

then
PlayerData.instance.nailDamage = PlayerData.instance.nailDamage + 3*(PlayerData.instance.maxHealth - PlayerData.instance.health);
and then
PlayerData.instance.nailDamage = RageNailDamage

#

wait

#

this will stack tho

#

need to set it to be active only during attacks

copper nacelle May 20, 2018, 5:36 PM

#

you could do

flat forum May 20, 2018, 5:36 PM

#

ModHooks.Instance.AttackHook += OnAttack; ?

#

what's this?

copper nacelle May 20, 2018, 5:36 PM

#

PlayerData.instance.nailDamage = (5 + 4 * PlayerData.instance.nailSmithUpgrades) + 3*(PlayerData.instance.maxHealth - PlayerData.instance.health)

#

could do that

#

that's a hook

flat forum May 20, 2018, 5:38 PM

#

So, this?

if (PlayerData.instance.equippedCharm_6 )
{
PlayerData.instance.nailDamage = (5 + 4 * PlayerData.instance.nailSmithUpgrades) + 3*(PlayerData.instance.maxHealth - PlayerData.instance.health)
}

copper nacelle May 20, 2018, 5:38 PM

#

i think that'd work

flat forum May 20, 2018, 5:38 PM

#

That was... easy

#

Now how do I make it a mod

#

Gradow said

#

I use I make a... Class Library thing in Visual Studio

#

Why do I have the feeling that this part will take me much longer than the actual making of the... mod thing itself

copper nacelle May 20, 2018, 5:42 PM

#

¯_(ツ)_/¯

flat forum May 20, 2018, 5:44 PM

#

let me just open a mod or two so I can see what other things I need to steal

#

mods tend to start with a
using BlahBlah
using BlahBlah
using

copper nacelle May 20, 2018, 5:44 PM

#

you can just clone example mod and change the name tbh

flat forum May 20, 2018, 5:45 PM

#

Oh

#

another thing

#

how does the Rage effect of FoTF activate?

copper nacelle May 20, 2018, 5:45 PM

#

wdym

flat forum May 20, 2018, 5:46 PM

#

The red lines at the edge

copper nacelle May 20, 2018, 5:46 PM

#

fsm

flat forum May 20, 2018, 5:46 PM

#

is it a
Health=1
activate stuff = true

copper nacelle May 20, 2018, 5:46 PM

#

idk

#

ask gradow

flat forum May 20, 2018, 5:46 PM

#

@solemn rivet
Help
How do I activate the rage things of FoTF

#

waity

#

is his Berserk mod on GitHub?

copper nacelle May 20, 2018, 5:47 PM

#

yes

#

ayugradow/berserkmod

#

iirc

flat forum May 20, 2018, 5:48 PM

#

Found it

#

now I just have to

#

understand which part is the one I need ~~to take from them~~

copper nacelle May 20, 2018, 5:48 PM

#

cornywoke

flat forum May 20, 2018, 5:48 PM

#

there's furyVignette

#

there's also

if (furyParticle != null)
furyParticle.GetComponent<ParticleSystem>().Play();

#

Well, code got confusing really quickly

#

I guess I can live without the special effects

#

so, nameSpace is the thing in the corner?

copper nacelle May 20, 2018, 5:53 PM

#

?

flat forum May 20, 2018, 5:53 PM

#

namespace BerserkMod

#

is this the thing that appears in the corner?

#

where installed Mods are

copper nacelle May 20, 2018, 5:54 PM

#

that's class name

#

iirc

flat forum May 20, 2018, 5:56 PM

#

Let's see what I can clean up from the thing at the start of the example mod

#

there's always

namespace Mod
{
    public class Something : Mod
....
}

#

I don't need these

private int _hitCounter;

private int _tempNailDamage;

#

but theu are in a thing

#

that the ExampleMod says is about Save Specific things

#

so, maybe I'll do this

private int NailUpgrades

up there

and then, in the if Thing I'll do
NailUpgrades = PlayerData.instance.nailSmithUpgrades

and finally

PlayerData.instance.nailDamage = (5 + 4 * NailUpgrades) + 3*(PlayerData.instance.maxHealth - PlayerData.instance.health)

#

there's some internal static thing

#

What does it do?

#

I don't need the OnAttack and OnAfterAttack things

#

in the mod

#

as of now

#

I delett them

#

Program's complaining that PlayerData.instance doesn't exist anywhere

#

do I just leave it like this?

copper nacelle May 20, 2018, 6:07 PM

#

did you add a reference to assembly-csharp

flat forum May 20, 2018, 6:07 PM

#

Oh

#

Oops

#

still not happy about "maxhealth"

#

📎 unknown.png

copper nacelle May 20, 2018, 6:09 PM

#

white theme

#

boi wtf are you doing

flat forum May 20, 2018, 6:09 PM

#

no idea

copper nacelle May 20, 2018, 6:09 PM

#

that's not in a method

#

when is it getting called

flat forum May 20, 2018, 6:10 PM

#

what do you mean when?

#

what you see on the screen

#

is about a bit more than what I understand

copper nacelle May 20, 2018, 6:10 PM

#

when should your code be called

flat forum May 20, 2018, 6:11 PM

#

uhm

#

is this the
public void OnAttack(AttackDirection dir) thing from the Example mod?

copper nacelle May 20, 2018, 6:12 PM

#

yes

flat forum May 20, 2018, 6:12 PM

#

Oh

#

Ok

#

um

#

I'm an idiot for not looking at this more carefully

copper nacelle May 20, 2018, 6:13 PM

#

📎 unknown.png

flat forum May 20, 2018, 6:13 PM

#

(although, I am an idiot most of the time so it doesn't really maatter)

#

Will doing the same with OnAttack work the same way?

copper nacelle May 20, 2018, 6:14 PM

#

wdym

flat forum May 20, 2018, 6:15 PM

#

public void OnAttack(AttackDirection dir)
{
if (PlayerData.instance.equippedCharm_6 )
BlahBlah
}

leaden hedge May 20, 2018, 6:15 PM

#

do GetPlayerDataBool

#

unless you want your mod to be incompatible with other mods

flat forum May 20, 2018, 6:15 PM

#

I want it to be compatible with other mods

copper nacelle May 20, 2018, 6:16 PM

#

wouldn't it be getplayerint cause you're changing attack damage?

leaden hedge May 20, 2018, 6:16 PM

#

i mean for checking if charms are equipped

copper nacelle May 20, 2018, 6:16 PM

#

o

leaden hedge May 20, 2018, 6:17 PM

#

just generally anything getting data from playerdata should use the GetX functions

flat forum May 20, 2018, 6:18 PM

#

um

leaden hedge May 20, 2018, 6:19 PM

#

also what are you trying to do

flat forum May 20, 2018, 6:19 PM

#

Well

copper nacelle May 20, 2018, 6:19 PM

#

changing nail damage as the player loses and gains health

flat forum May 20, 2018, 6:19 PM

#

make, once FoTF is equipped to boost damage based on lost Health

#

for each lost mask you get 3 extra damage

leaden hedge May 20, 2018, 6:20 PM

#

well for boosting damage you can just do that on takedamage or gainhealth hook

#

same with enabling or disabling effects

flat forum May 20, 2018, 6:21 PM

#

This is... quite a lot for one day

#

Can you go over the Bool thing in a bit more detail?

#

please

#

as of now, the code thing looks like this

public void OnAttack(AttackDirection dir)
        {

            if (PlayerData.instance.equippedCharm_6)
            {
                NailUpgrades = PlayerData.instance.nailSmithUpgrades

            PlayerData.instance.nailDamage = (5 + 4 * NailUpgrades) + 5 * (PlayerData.instance.maxHealth - PlayerData.instance.health)
            }
        }
        private void OnAfterAttack(AttackDirection dir)
        {
            PlayerData.instance.nailDamage = 5 + 4 * NailUpgrades
        }

copper nacelle May 20, 2018, 6:27 PM

#

why are you doing NailUpgrades = PlayerData.instance.nailSmithUpgrades

flat forum May 20, 2018, 6:27 PM

#

Because

#

I found it less confusing

#

(also, there was this private int thing at the top and I didn't want to leave it empty)

leaden hedge May 20, 2018, 6:29 PM

#

should just be something like to change damage

HealthChanged(){
    HeroController.Instance.slashComponent.GetComponent<DamagesEnemy>().damageDealt = (5 + 4 * NailUpgrades) + 5 * (PlayerData.instance.maxHealth - PlayerData.instance.health);
    HeroController.Instance.slashComponent.fury = true;
}

#

also the vignette is controlled by an fsm, you can probably just set it to enabled/disabled as you want

flat forum May 20, 2018, 6:30 PM

#

and the slashComponent.fury does? Is it the red sword?

leaden hedge May 20, 2018, 6:30 PM

#

yes

flat forum May 20, 2018, 6:30 PM

#

Ok

leaden hedge May 20, 2018, 6:30 PM

#

oh its DamagesEnemies

flat forum May 20, 2018, 6:30 PM

#

GetComponent<DamagesEnemies>

leaden hedge May 20, 2018, 6:31 PM

#

yes

#

if you wanted to try and do something else instead of .fury = true

flat forum May 20, 2018, 6:31 PM

#

now I paste that over the PlayerData.instance.nailDamage = (5 + 4 * NailUpgrades) + 5 * (PlayerData.instance.maxHealth - PlayerData.instance.health)?

leaden hedge May 20, 2018, 6:35 PM

#

this could probably colour stuff red as you lose hp

hp= Mathf.Lerp(PlayerData.instance.health / (PlayerData.instance.maxHealth*1.0f), 0, 1);
HeroController.Instance.slashComponent.GetComponent<SpriteRenderer>.color = new Color( 1, hp, hp, 1);

#

also no I already said you don't need to check everytime you attack

#

just when you gain or lose hp

flat forum May 20, 2018, 6:36 PM

#

And the GetPlayerDataBool thing? what do I do with it?

leaden hedge May 20, 2018, 6:36 PM

#

what do you mean

flat forum May 20, 2018, 6:36 PM

#

Where do I put it

leaden hedge May 20, 2018, 6:36 PM

#

you just use that whenever you'd use PlayerData.Instance.xxx

#

where xxx is a bool

flat forum May 20, 2018, 6:36 PM

#

(I sound like a retard)

leaden hedge May 20, 2018, 6:36 PM

#

it just gets a bool from PlayerData

wind mesa May 20, 2018, 6:37 PM

#

euh from the mod list can you explain wat is the unending dreams, charming and charm notch (ok this one i know wat it will do but how much does it add?)

copper nacelle May 20, 2018, 6:37 PM

#

did you read the readmes

wind mesa May 20, 2018, 6:37 PM

#

where

copper nacelle May 20, 2018, 6:38 PM

#

corny

#

in the mods

#

the zips

wind mesa May 20, 2018, 6:38 PM

#

oh no i havent downloaded them

#

just checking wich one i want

flat forum May 20, 2018, 6:39 PM

#

You want Mantis Gods

copper nacelle May 20, 2018, 6:39 PM

#

haha yes

wind mesa May 20, 2018, 6:39 PM

#

nah for now i got randomizer, player tracking and debug

flat forum May 20, 2018, 6:40 PM

#

Ok, so I replace PlayerData.Instance.nailDamage with...

Ok, I'm gonna go to sleep. Hopefully I'll have figured it out by the morning

solid wagon May 20, 2018, 6:49 PM

#

@rain cedar add rancid eggs to the Randomizer table zote

wind mesa May 20, 2018, 6:57 PM

#

rip i cant use the mod installer since well i downloaded hollow on a usb key and keeps giving me error messages....

copper nacelle May 20, 2018, 6:58 PM

#

wow nice giving the error messages

flat forum May 20, 2018, 6:58 PM

#

Wait

#

Why wouldn't the mod be usable the way it is now?

compact sedge May 20, 2018, 6:58 PM

#

steam for windows lets you do that?

flat forum May 20, 2018, 6:58 PM

#

@leaden hedge

copper nacelle May 20, 2018, 6:59 PM

#

yeah

leaden hedge May 20, 2018, 6:59 PM

#

it'd work

#

but if any mod changed any values you change correct

compact sedge May 20, 2018, 6:59 PM

#

weird. seems silly to put a game on a usb stick ¯_(ツ)_/¯

flat forum May 20, 2018, 6:59 PM

#

But you said it won't with other mods?

leaden hedge May 20, 2018, 6:59 PM

#

it'd break

flat forum May 20, 2018, 6:59 PM

#

Hm

#

Well

leaden hedge May 20, 2018, 6:59 PM

#

you don't actually set the variables

#

you simply tell stuff what it is when it asks for it

flat forum May 20, 2018, 7:00 PM

#

What mod would change those very basic ones?

young walrus May 20, 2018, 7:00 PM

#

Unless you're taking it from a friend...

#

#piracy

leaden hedge May 20, 2018, 7:00 PM

#

i have several games on a usb stick

#

mainly stuff I play at other peoples house

#

fighting games mostly

young walrus May 20, 2018, 7:01 PM

#

I have HK on a couple cuz I had to bring it to GDQ

copper nacelle May 20, 2018, 7:01 PM

#

I've got terraria on a usb

#

not much else tho

leaden hedge May 20, 2018, 7:01 PM

#

what do you mean, what mod would change those very basic ones?

#

yours for a start

copper nacelle May 20, 2018, 7:02 PM

#

hell mod

flat forum May 20, 2018, 7:02 PM

#

"but if any mod changed any values you change

it'd break"

#

So

#

Oh

leaden hedge May 20, 2018, 7:02 PM

#

well it would

flat forum May 20, 2018, 7:02 PM

#

Yeah, Hell mod

leaden hedge May 20, 2018, 7:02 PM

#

look at randomizer and boss rush

#

boss rush doesn't use them

#

so it breaks rando

compact sedge May 20, 2018, 7:03 PM

#

you can set your load order of your mod to be later so it overrides the other mod's values. I think

flat forum May 20, 2018, 7:03 PM

#

Hell mod and fandomizer would break it

copper nacelle May 20, 2018, 7:03 PM

#

fandomizer

flat forum May 20, 2018, 7:03 PM

#

Phone keyboard

leaden hedge May 20, 2018, 7:03 PM

#

although randomizer wouldn't affect it even if I did use the correct values

compact sedge May 20, 2018, 7:03 PM

#

fandomizer, when you click on a public discord server you don't know which game it's for

flat forum May 20, 2018, 7:03 PM

#

lol

leaden hedge May 20, 2018, 7:04 PM

#

its no effort to do it correct anyway

#

instead of setting nailDamage, just have a hook on GetPlayerDataBool that returns the correct nail damage

compact sedge May 20, 2018, 7:05 PM

#

^ because setting nail damage means you have to edit your save after uninstalling

#

which reminds me I have to fix that

flat forum May 20, 2018, 7:06 PM

#

I may or may not be too tired to understand

leaden hedge May 20, 2018, 7:06 PM

#

GetPlayerDataInt("string") has a hook

#

if "string" is "nailDamage"

#

you can return x;

#

oops

#

its not a bool its an int

flat forum May 20, 2018, 7:07 PM

#

GetPlayerDataInt("nailDamage")

leaden hedge May 20, 2018, 7:08 PM

#

well thats what the game would be doing

#

theres a hook

#

just find the hook in Modding

#

autocomplete the delegate

flat forum May 20, 2018, 7:08 PM

#

= something?

#

test

#

Ok

leaden hedge May 20, 2018, 7:09 PM

#

just auto make the delegate with vs

#

the hook returns an int which is the new value
and takes a string and int
string is target var
int is its current value

#

Modding.Instance.GetPlayerIntHook += GetInt;

public int GetInt(int value, string varName){
    if( varName == "nailDamage" )
        return value*2;
    return value;
}

#

this doubles your damage

#

regardless of any other mods installed

compact sedge May 20, 2018, 7:13 PM

#

so silly question but does:

PlayerData.Instance.variable give me the variable after it gets modified by any hooks, or is it the real variable?

leaden hedge May 20, 2018, 7:13 PM

#

thats the "real" one

compact sedge May 20, 2018, 7:13 PM

#

how do I get the modified one

leaden hedge May 20, 2018, 7:13 PM

#

you can also do

#

GetIntInternal

#

just do PlayerData.Instance.GetInt("varName");

flat forum May 20, 2018, 7:15 PM

#

So

#

In order for it to work the way it works now
I replace the return value*2
With
return value + 5*(MaxHealth - Health)

leaden hedge May 20, 2018, 7:18 PM

#

yes

#

although imo i'd scale the 5 with value

flat forum May 20, 2018, 7:19 PM

#

And to make it only work when FotF (charm_6) is equipped I replace the thing with that?

#

Wait, it'll scale?

leaden hedge May 20, 2018, 7:19 PM

#

you can just return value if !PlayerData.Instance.GetBool("equippedCharm_6")

#

no it won't scale

#

which kinda sucks

copper nacelle May 20, 2018, 7:20 PM

#

ternary

leaden hedge May 20, 2018, 7:20 PM

#

as you could get 27 damage nail 0 on hell mod

copper nacelle May 20, 2018, 7:20 PM

#

what

leaden hedge May 20, 2018, 7:21 PM

#

if it went after hell mod

flat forum May 20, 2018, 7:21 PM

#

I mean, you are supposed to get 5 damage for each lost health
5, 10, 15, 20
And not
5, 5+10, 5+10+15

copper nacelle May 20, 2018, 7:21 PM

#

o

leaden hedge May 20, 2018, 7:21 PM

#

ok so at 9 max hp

#

you'd get +40 damage

#

which is alot

#

for a start

#

and for something like hell mod which halfs damage, order would matter

flat forum May 20, 2018, 7:22 PM

#

Well

#

I'll be tweaking later

#

Maybe x4 for now

copper nacelle May 20, 2018, 7:22 PM

#

iirc i just changed it to return 2.5

#

i mean

#

2 and then 3 and then 2 and stuff

#

because everyone was doing it old nail anyways

compact sedge May 20, 2018, 7:24 PM

#

oh I was gonna say

#

2.5 damage never did make sense to me

copper nacelle May 20, 2018, 7:25 PM

#

effectively 2.5

compact sedge May 20, 2018, 7:25 PM

#

I mean if you hit one enemy and then another repeatedly one will take 3 dmg every time and the other 2 dmg

#

unless you used random for it

#

actually uhhh does CalculateNotchesUsed bypass GetPlayerIntHook?

copper nacelle May 20, 2018, 7:30 PM

#

yes

compact sedge May 20, 2018, 7:30 PM

#

I did it the "proper" way and now things are wrong

copper nacelle May 20, 2018, 7:30 PM

#

yes

#

tc very nice

compact sedge May 20, 2018, 7:31 PM

#

is there an override for that I don't want to mess with people's saves

copper nacelle May 20, 2018, 7:32 PM

#

📎 unknown.png

compact sedge May 20, 2018, 7:33 PM

#

no thx

copper nacelle May 20, 2018, 7:34 PM

#

cornywoke

compact sedge May 20, 2018, 7:34 PM

#

is there even a way to set notches used manually without reflection?

copper nacelle May 20, 2018, 7:35 PM

#

it's public

#

🤔

leaden hedge May 20, 2018, 7:35 PM

#

yes tc are shitposters

#

tfw they meme us harder than any human could do if they tried

#

just by existing

#

fairly certain Count Charms isn't used for the charm menu anyway

#

unless its CallMethodProper 🤔

compact sedge May 20, 2018, 7:39 PM

#

CalculateNotchesUsed is not, like called ever in game afaik because... ummm... charm storage is like totally a thing iirc.

#

or at least it's not called often enough that you could avoid it in a speedrun

leaden hedge May 20, 2018, 7:40 PM

#

well you can just set notchesFilled

#

in the save and it works

copper nacelle May 20, 2018, 7:40 PM

#

and it's public

#

dungo

compact sedge May 20, 2018, 7:40 PM

#

If I'm setting stuff in the save I'm gonna just set the charm cost.

leaden hedge May 20, 2018, 7:40 PM

#

but charm storage works because overcharm and deequipping are desync'd

compact sedge May 20, 2018, 7:40 PM

#

and tell people to disable my mod to fix their game

copper nacelle May 20, 2018, 7:41 PM

#

wtf

leaden hedge May 20, 2018, 7:41 PM

#

the frame you unequip something overcharm is false, but charm isn't disabled until it reaches its slot in the menu

compact sedge May 20, 2018, 7:41 PM

#

desynced or not desynced the fact that you can do charm storage and it doesn't get fixed automatically means the game isn't running CalculateNotchesUsed()

#

a function that would fix it.

leaden hedge May 20, 2018, 7:41 PM

#

well it wouldnt

compact sedge May 20, 2018, 7:42 PM

#

oh right I forgot it doesn't actually cause overcharm if you are using too many notches

#

nvm

#

thanks tc

leaden hedge May 20, 2018, 7:42 PM

#

its probably getting called by CallMethodProper

#

in the action that unequips / equips charms at the end

#

but overcharm is calculated manually at the beginning

#

for some reason

compact sedge May 20, 2018, 7:44 PM

#

but when you unequip a charm but lie to the game to say that charm is equipped you can unequip it many times and have negative notches used

#

which means they aren't calling that function

#

because if they did you'd be able to unequip it many times but it wouldn't reduce the notches used

#

and with those negative notches used you can put on as many charms as you want

copper nacelle May 20, 2018, 7:45 PM

#

just hook it and find out ez

compact sedge May 20, 2018, 7:46 PM

#

I'd mostly care if I was a speedrunner, I'm just confused at the function's existance if it doesn't seem to be used where it makes sense

copper nacelle May 20, 2018, 7:49 PM

#

meme

📎 unknown.png

leaden hedge May 20, 2018, 7:49 PM

#

GetPlayerDataInt(NULL,PlayerData Var Name,Notch Cost)
IntOperator(Notch Cost,4294967295,2,Notch Cost,FALSE)
PlayerDataIntAdd(NULL,charmSlotsFilled,Notch Cost)

#

420iq

compact sedge May 20, 2018, 7:50 PM

#

Log("You will never see this")

copper nacelle May 20, 2018, 7:50 PM

#

wtf

leaden hedge May 20, 2018, 7:50 PM

#

but like I said

#

overcharm glitch is different

compact sedge May 20, 2018, 7:51 PM

#

no ur right

copper nacelle May 20, 2018, 7:52 PM

#

haha ur a dungo

#

it was called

leaden hedge May 20, 2018, 7:52 PM

#

1 removes overcharm
2 waits for it to return to its slot
3 unequips the charm

📎 unknown.png

copper nacelle May 20, 2018, 7:52 PM

#

📎 unknown.png

leaden hedge May 20, 2018, 7:53 PM

#

why this is like this

#

is 420iq

copper nacelle May 20, 2018, 7:53 PM

#

📎 unknown.png

#

because tc

#

function gets called tho

leaden hedge May 20, 2018, 7:53 PM

#

don't think its used for anything important

#

the charm menu just uses GetPlayerDataInt

copper nacelle May 20, 2018, 7:54 PM

#

huh

#

i think it's called on unequipping

#

cause iirc when i set dreamshield's notch cost w/ getplayerdataint

#

it worked fine when you equipped it

#

but unequipping left a notch used

#

until you reopened the menu

compact sedge May 20, 2018, 8:08 PM

#

https://github.com/natis1/grimmchildupgrades/blob/master/stats.md @steep sail I took your suggestion yesterday and made a chart detailing all the info as precise as I can.

GitHub

natis1/grimmchildupgrades

grimmchildupgrades - A Hollow Knight mod for a better Grimmchild

compact sedge May 21, 2018, 1:48 AM

#

hey anyone here know how to get the number of notches that the person has used

#

like if there's a variable for that anywhere

#

(without just iterating over all the charms)

lucid pond May 21, 2018, 1:49 AM

#

Have the PlayerDataTracker mod been updated for Randomizer Mod 2.0?

young walrus May 21, 2018, 2:00 AM

#

you dont need that mod unless you're using the on screen overlay

solemn rivet May 21, 2018, 2:01 AM

#

AA: Have you tried running CharmUpdate() after checking for Overcharm?

#

also, afaik, the game just iterates over every charm

compact sedge May 21, 2018, 2:02 AM

#

Here's my plan

📎 unknown.png

#

as a hook for ModHooks.Instance.CharmUpdateHook

#

I believe it actually fixes a bug in vanilla HK

#

because it would stop you from infinite unequipping charms for infinite slots

solemn rivet May 21, 2018, 2:06 AM

#

did you see this method

#

    public void RefreshOvercharm()
    {
        if (this.playerData.charmSlotsFilled > this.playerData.charmSlots)
        {
            this.playerData.overcharmed = true;
        }
        else
        {
            this.playerData.overcharmed = false;
        }
    }```

#

in the GameManager class

compact sedge May 21, 2018, 2:08 AM

#

no I'm rewriting functions that don't use GetInt or GetBool to make them use those things

solemn rivet May 21, 2018, 2:08 AM

#

oh, gotcha

compact sedge May 21, 2018, 2:08 AM

#

basically the gist is I don't want my mod ruining save files

#

by setting the cost of a charm

#

and forcing the user to either run it with my mod disabled in the modconfig

#

or to edit the save file manually

solemn rivet May 21, 2018, 2:10 AM

#

got it

compact sedge May 21, 2018, 2:48 AM

#

Can you not do try and catch in the Initialize function?

#

I have this:

📎 unknown.png

#

but the mod fails to load without printing that error

copper nacelle May 21, 2018, 2:49 AM

#

yeah

compact sedge May 21, 2018, 2:49 AM

#

when it's not found

copper nacelle May 21, 2018, 2:49 AM

#

that won't work

#

that's an assembly load error

#

iirc

compact sedge May 21, 2018, 2:49 AM

#

how do you try to find a variable

leaden hedge May 21, 2018, 2:49 AM

#

reflection

copper nacelle May 21, 2018, 2:49 AM

#

reflection

#

ree

compact sedge May 21, 2018, 2:50 AM

#

it's public tho

leaden hedge May 21, 2018, 2:50 AM

#

ok

copper nacelle May 21, 2018, 2:50 AM

#

doesn't matter

#

reflection

leaden hedge May 21, 2018, 2:50 AM

#

but reflection isnt for private stuff

#

reflection is for finding stuff on classes not defined in your dll / assembly

#

just so happens its very good at accessing private members hollowface

compact sedge May 21, 2018, 2:59 AM

#

idk the exact syntax, will this work? ( (int) this.GetType().GetField("infinitegrimm.InfiniteGlobalVars.versionInt").GetValue(null) >= 300)

#

yes it does

#

but god is it gross

solemn rivet May 21, 2018, 3:01 AM

#

that's what I had to do in earlier versions of blackmoth to make it backwards compatible

compact sedge May 21, 2018, 3:02 AM

#

jk that doesn't work

rain cedar May 21, 2018, 3:03 AM

#

You're casting null to int if the other mod isn't loaded

#

Check that it isn't null

compact sedge May 21, 2018, 3:04 AM

#

uh even if it's loaded I get the null reference exception

copper nacelle May 21, 2018, 3:06 AM

#

you can do .GetField("infinitegrimm.InfiniteGlobalVars.versionInt")?

compact sedge May 21, 2018, 3:06 AM

#

do I need the namespace

#

and if so do I need the function as well

leaden hedge May 21, 2018, 3:08 AM

#

why are you doing this.GetType

compact sedge May 21, 2018, 3:08 AM

#

oh instead of just GetType?

copper nacelle May 21, 2018, 3:09 AM

#

type.gettype

#

iirc

compact sedge May 21, 2018, 3:09 AM

#

tbh I have no idea how reflection works

leaden hedge May 21, 2018, 3:09 AM

#

well this.GetType returns the current class

#

Type.GetType("namespace.class").GetField("variable")

copper nacelle May 21, 2018, 3:10 AM

#

don't you need the qualified assembly name

leaden hedge May 21, 2018, 3:12 AM

#

foreach( Assembly asm in AppDomain.GetAssemblies() ){
    foreach( Type t in asm.GetTypes(){
        if(t.Name == "class")
            return t;
    }
}

compact sedge May 21, 2018, 3:12 AM

#

probably b/c that didn't work

copper nacelle May 21, 2018, 3:13 AM

#

Type.GetType("TypeName,DllName") imo

#

Type.GetType("infiniteGrimm.InfiniteGlobalVars,infinitegrimm");

#

i think

#

would work

compact sedge May 21, 2018, 3:17 AM

#

not get field

copper nacelle May 21, 2018, 3:17 AM

#

no you get field of the type

#

wait

#

:ech:

compact sedge May 21, 2018, 3:21 AM

#

that works

#

thanks 56

copper nacelle May 21, 2018, 3:21 AM

#

yw

compact sedge May 21, 2018, 3:21 AM

#

(int)Type.GetType("infinitegrimm.InfiniteGlobalVars, infinitegrimm").GetField("versionInt").GetValue(null)

#

to be precise

lucid pond May 21, 2018, 3:33 AM

#

I need that mod on screen overlay.I stream HK Randomizer Mod everyday on Bilibili.😂

#

I tested Randomizer Mod 2.0 yesterday.Then I plan to start streaming Randomizer Mod 2.0 today.

compact sedge May 21, 2018, 3:47 AM

#

Hey can someone who has access to the google drive update my mod for me. I just released a new version.

📎 API_Infinite_Grimm.zip

copper nacelle May 21, 2018, 3:48 AM

#

updated

compact sedge May 21, 2018, 3:49 AM

#

thanks

flat forum May 21, 2018, 3:51 AM

#

Good Morning

#

is there a mod with the if PlayerData.Instance.GetBool("equippedCharm_6")

#

I'm trying to understand how to fit it in the other Bool thing

#

the one KDT sent, this:

Modding.Instance.GetPlayerIntHook += GetInt;

public int GetInt(int value, string varName){
    if( varName == "nailDamage" )
        return value + 5*(PlayerData.instance.maxHealth - PlayerData.instance.health);
    return value;
}

#

...Bools are a new concept for me

compact sedge May 21, 2018, 3:55 AM

#

if (boolName == "equippedCharm_6" ) {
    return whatever;
}
return bool;

#

Modding.Instance.GetPlayerBoolHook += GetBool;

flat forum May 21, 2018, 3:59 AM

#

is the equipped charm a PlayerData.Instance?

#

if PlayerData.Instance.GetBool("equippedCharm_6")

#

?

compact sedge May 21, 2018, 4:00 AM

#

yes

flat forum May 21, 2018, 4:00 AM

#

Also, the return thing should be?

compact sedge May 21, 2018, 4:00 AM

#

that's if you wanna trick the game

#

into thinking if you have it or not

copper nacelle May 21, 2018, 4:00 AM

#

charms aren't playerdata.instance(s)

compact sedge May 21, 2018, 4:00 AM

#

regardless of if you actually have it

copper nacelle May 21, 2018, 4:00 AM

#

wtf

#

equipped charm is a instance var which is a bool that's on playerdata

compact sedge May 21, 2018, 4:01 AM

#

bigthink

📎 unknown.png

steep sail May 21, 2018, 4:01 AM

#

string+int?

copper nacelle May 21, 2018, 4:01 AM

#

yes notchesUsed is my favorite PlayerData instance

flat forum May 21, 2018, 4:01 AM

#

if PlayerData.Instance.GetBool("equippedCharm_6")

copper nacelle May 21, 2018, 4:01 AM

#

string + int implicitly turns the int into a string

steep sail May 21, 2018, 4:01 AM

#

oh

flat forum May 21, 2018, 4:02 AM

#

what do I put in the return below it?

#

the "return whatever" thing

steep sail May 21, 2018, 4:02 AM

#

didn`t know about this

#

Basically, I`m C++ and Pascal coder

#

Not C#

copper nacelle May 21, 2018, 4:03 AM

#

ik a little bit of c++, some haskell, and a decent amount of c#, python, js, and java

flat forum May 21, 2018, 4:03 AM

#

I know nothing

steep sail May 21, 2018, 4:03 AM

#

UnityScript?

copper nacelle May 21, 2018, 4:03 AM

#

idk that

#

basically js tho iirc

compact sedge May 21, 2018, 4:03 AM

#

eww js

leaden hedge May 21, 2018, 4:03 AM

#

doesn't c++ have implicits 🤔

compact sedge May 21, 2018, 4:03 AM

#

yes

#

c++ 11 and on or 14 and on

#

forgot which one added it

#

I never do implicits

copper nacelle May 21, 2018, 4:04 AM

#

why

#

wtf

compact sedge May 21, 2018, 4:04 AM

#

I think it's bad code

flat forum May 21, 2018, 4:04 AM

#

does return true work?

copper nacelle May 21, 2018, 4:04 AM

#

where

leaden hedge May 21, 2018, 4:04 AM

#

if your function returns a bool

compact sedge May 21, 2018, 4:05 AM

#

oh wait no I do do implicits

#

and they're older they're from like c++idk

copper nacelle May 21, 2018, 4:05 AM

#

then what do you not do

leaden hedge May 21, 2018, 4:05 AM

#

imo explicits just make code more verbose 90% of the time

copper nacelle May 21, 2018, 4:05 AM

#

^

compact sedge May 21, 2018, 4:05 AM

#

verbose code is good code

#

easier to read and debug

leaden hedge May 21, 2018, 4:06 AM

#

not precisely

copper nacelle May 21, 2018, 4:06 AM

#

java.lang.System.out.println("no");

#

or whatever it is

leaden hedge May 21, 2018, 4:07 AM

#

when you've got something like
Int.Parse((float)x/(float)y)*(float)z)

#

sure glad I can just do int i = (x/(float)y)*z

flat forum May 21, 2018, 4:09 AM

#

if (boolName == "equippedCharm_6" ) {
    return true;
}
return bool;

and then I put the other code, the one that changes attack on the second thing
or do I make the return bool to be true or false and the whatever to be the attack thing

leaden hedge May 21, 2018, 4:10 AM

#

if you put other code after that it won't run 🤔

flat forum May 21, 2018, 4:10 AM

#

Mhmm

leaden hedge May 21, 2018, 4:10 AM

#

because return ends the current function

flat forum May 21, 2018, 4:11 AM

#

so, return bool is the true/false thing? Because there needs to be a true/false thing somewhere

leaden hedge May 21, 2018, 4:11 AM

#

what

flat forum May 21, 2018, 4:11 AM

#

how do I get this to work TnT

compact sedge May 21, 2018, 4:11 AM

#

yes return bool is the bool that it reads

#

or in that if statement

#

whatever you return

flat forum May 21, 2018, 4:12 AM

#

so, if the charm is equipped return bool should be true

compact sedge May 21, 2018, 4:12 AM

#

if that's true then it reads it as true

#

that's what will normally happen

leaden hedge May 21, 2018, 4:12 AM

#

also redundancy btw

compact sedge May 21, 2018, 4:12 AM

#

but you are using this code to modify that behavior

#

right?

#

lay it on me what are you trying to do folding

flat forum May 21, 2018, 4:13 AM

#

I'm trying to make it so that whenever FoTF (charm_6) is equipped, attack is boosted based on amount of lost health

#

KDT said that this should be the part about damage based on lost health

Modding.Instance.GetPlayerIntHook += GetInt;

public int GetInt(int value, string varName){
    if( varName == "nailDamage" )
        return value + 5*(PlayerData.instance.maxHealth - PlayerData.instance.health);
    return value;
}

leaden hedge May 21, 2018, 4:14 AM

#

i've already told you to use the ontakedamage/heal hooks

#

to update naildamage

flat forum May 21, 2018, 4:14 AM

#

But this makes it a bit more confusing for me

leaden hedge May 21, 2018, 4:14 AM

#

all this does is make the game think fotf is permanently equipped

if (boolName == "equippedCharm_6" ) {
    return true;
}
return bool;

flat forum May 21, 2018, 4:15 AM

#

so, I'll try and make what I have for now work and then start changing it

#

if (boolName == "equippedCharm_6" ) {
    return TheDamageThing;
}
return true;

?

leaden hedge May 21, 2018, 4:15 AM

#

what

#

no

flat forum May 21, 2018, 4:15 AM

#

Ok

leaden hedge May 21, 2018, 4:15 AM

#

you can't return a number

#

hook into the 2 functions that get called when you change health

#

PlayerData.Instance.GetInt("nailDamage")

#

HeroController.Instance.slashComponent.GetComponent<DamagesEnemies>().damageDealt = nailDamage

compact sedge May 21, 2018, 4:17 AM

#

Ok so here's what you want to do. First check if it's equipped

literally just put:

PlayerData.instance.GetBool("equippedCharm_6");

And if that bool is true, then set the damage. the damage can be set

#

using what KDT said

flat forum May 21, 2018, 4:20 AM

#

will it work the way I'm trying to make it now?

leaden hedge May 21, 2018, 4:22 AM

#

i have no idea what you're trying to do

#

afaik you're making the game always think you don't have fotf equipped

#

thats not even related to the problem

#

so probably not

flat forum May 21, 2018, 4:23 AM

#

trying to fit the Damage thing, that you said should theoretically work into a "if charm_6 is equipped" thing

#

will this work PlayerData.instance.equippedCharm_6?

#

Ok, first, will this do the thing I want and set damage to increase based on amount of lost health (without stacking)?

Modding.Instance.GetPlayerIntHook += GetInt;

public int GetInt(int value, string varName){
    if( varName == "nailDamage" )
        return value + 5*(PlayerData.instance.maxHealth - PlayerData.instance.health);
    return value;
}

rain cedar May 21, 2018, 4:27 AM

#

I think you need to try to understand what the things you're posting do

#

And why they do it

#

Not just ask if it's what you want

flat forum May 21, 2018, 4:27 AM

#

I'm trying to, sorry...

#

that one should find what nail damage is

rain cedar May 21, 2018, 4:28 AM

#

That one adds a scaled value to nail damage

#

Regardless of fury

leaden hedge May 21, 2018, 4:28 AM

#

public Mod(){
    Modding.ModHooks.Instance.TakeDamageHook += UpdateNail;
    Modding.ModHooks.Instance.BeforeAddHealthHook+= UpdateNail;
    Modding.ModHooks.Instance.GetIntHook += nailDamageOverride;
}
public int nailDamageOverride(int value, string varName){
    if(varName == "nailDamage" && PlayerData.Instance.equippedCharm_6){
        return value + 5*(PlayerData.instance.maxHealth - PlayerData.instance.health);;
    }
    return value;
}
public int UpdateNail(int amount){
    int nailDamage = PlayerData.Instance.GetInt("nailDamage");
    HeroController.Instance.slashComponent.GetComponent<DamagesEnemies>().damageDealt = nailDamage;

    return amount;
}

flat forum May 21, 2018, 4:29 AM

#

@rain cedar I understand that, I was trying to make it function only when Fury is equipped

rain cedar May 21, 2018, 4:29 AM

#

Well what KDT posted is that

#

Except it doesn't change damage

#

It's just the framework

leaden hedge May 21, 2018, 4:29 AM

#

should when you get hit

rain cedar May 21, 2018, 4:29 AM

#

Oh wait yeah I see that in nailDamageOverride

leaden hedge May 21, 2018, 4:30 AM

#

only on lb though, I guess you could SetInt and call the fsm event

rain cedar May 21, 2018, 4:30 AM

#

But that's not actually gonna affect damage

leaden hedge May 21, 2018, 4:30 AM

#

    int nailDamage = PlayerData.Instance.GetInt("nailDamage");
    HeroController.Instance.slashComponent.GetComponent<DamagesEnemies>().damageDealt = nailDamage;

#

these 2 should

#

afaik

copper nacelle May 21, 2018, 4:30 AM

#

i was doing it w/out the fsm event in hell mod and it was working

#

idk why

leaden hedge May 21, 2018, 4:31 AM

#

because when the game looked for it when it loads the game

#

you overrode it 🤔

#

BIG THINK

copper nacelle May 21, 2018, 4:31 AM

#

oof

leaden hedge May 21, 2018, 4:32 AM

#

you only need the UpdateNail because he wants it to update as his health changes

rain cedar May 21, 2018, 4:32 AM

#

I would just update damage on swing tbh

#

I don't trust that to work

#

Something else will probably update damage after it runs

leaden hedge May 21, 2018, 4:32 AM

#

just do it everyframe hollowface

rain cedar May 21, 2018, 4:33 AM

#

That wouldn't be that bad if the game was made well

#

But it uses reflection to get values

#

And doesn't cache them