archived-modding-development

[pearl sentinel]

i wrote a generic one today

so most of them could now probably be pulled out

but for "backward compatibility" and in the interest of time, i'm leaving it as-is for now

[rain cedar]

Some of these function names

GetGameObjectFromSpawnObjectFromGlobalPoolInFSM

I get why it's that

Since the FsmStateAction name is most of it

But still looks awful

[pearl sentinel]

yep, that's one motivation behind writing the generic version

GetValueFromAction<Type,Action> is much nicer

[rain cedar]

Yeah

You'd probably still have the bad looking ones internally

Lot better to work with, though

[pearl sentinel]

yeah

there's still lots of parts that can be cleaned up

but i'm hoping we can collaborate or add functionality in one place with this

i also added a couple extras in

https://github.com/Kerr1291/ModCommon/blob/master/ModCommon/ModCommonMiscUtils.cs

EnterSandbox puts you in an empty room that's 2x screens wide and 1x screens tall

GetGatePosition is just a port of the private function that's inside the game

EnterZone transitioning the player to a custom area really easy

[rain cedar]

Isn't GetGatePosition a public function?

Why recreate it?

[pearl sentinel]

it wasn't last i checked

[rain cedar]

Oh I see

TransitionPoint.GetGatePosition is public

But this takes a string

So it's a different use case

[pearl sentinel]

ah, maybe that's why (i forgot why initially)

[rain cedar]

TransitionPoint is a MonoBehaviour anyway so you can't just arbitrarily call it

You need a reference to one

[pearl sentinel]

something that's also included in the common package is my event system

CommunicationNode

if you wanna not use singletons or have nice event broadcasting

[rain cedar]

I didn't know you could do so much with an attribute

[pearl sentinel]

they're pretty neat

[rain cedar]

It doesn't look like you're using it as an attribute, though

In ModCommon.cs

[pearl sentinel]

i don't have any event handlers

[rain cedar]

Oh I'm misreading this

CommunicationNode isn't an attribute, CommunicationCallback is

This makes more sense

[pearl sentinel]

right

[rain cedar]

Yeah and you're just using that to tag things

Alright I get it

[pearl sentinel]

the one place i use it right now in enemy randomizer:

                comms.Publish( new LoadingProgressEvent() { progress = value } );

that's when the loading value updates

then my UI gets the event and sets the % or bar or w/e

what i'd like to do is have it so each enemy that spawns or is replaced has an event

just haven't got around to doing it yet

[rain cedar]

Would be a lot more flexible for sure

[pearl sentinel]

but i'm thinking i'll probably use it as things are re-written to add on hit or death events etc

[rain cedar]

Cool

I'll look through all that more thoroughly later to see if there's anything I can use

Always nice when other people do the hard work for you

[pearl sentinel]

would be neat to put some stuff from debug mod in here or w/e too if you feel interested

[rain cedar]

Yeah? Everything in here should be completely flexible since it's meant to be called arbitrarily by keybind https://github.com/seanpr96/DebugMod/blob/master/Source/BindableFunctions.cs

Unless you had something else in mind

[pearl sentinel]

nope, that's basically what i was thinking

[rain cedar]

It's all really simple stuff

Just great to have all together

Oh I bet the kill all one is broken in beta

Do you know if broadcasting "INSTA KILL" still works?

[pearl sentinel]

it doesn't

[copper nacelle]

iirc someone was saying it doesn't work

in chat

[pearl sentinel]

there's literally no health-type fsms on enemies

[rain cedar]

Yeah, figured

[pearl sentinel]

but getting all active health managers and calling Die() on them should work the same

[rain cedar]

Yeah

Definitely better, just more work for me

The enemy panel is gonna be able to run so much cleaner, though

It's awful code right now

Looking for health fsms everywhere with like 3 different names

[pearl sentinel]

yeah, enemy rando was getting like that too

[copper nacelle]

health_manager, health_manager_enemy, pain1, pain2, pain3, pain17

[rain cedar]

Haha didn't even know about the pain ones

What enemies had that?

[copper nacelle]

no wait

bad joke

[rain cedar]

When game is so bad that jokes get taken as fact with no questions asked

[copper nacelle]

lol

[pearl sentinel]

anyway, sent out some github invites for mod common if any of you wanna do anything with it

[solemn rivet]

I just woke up, and I am recovering from an illness in these past few days

I literally had nightmares about fsms last night

Not even kidding

[exotic venture]

"please TC get rid of FSMs

our resident modders get actual nightmares from them"

[solemn rivet]

Fsm-induced nightmare ffs

It was like all the symptoms I was feeling and all that were all part of a state machine

And it was stuck between two (shitty) states

[exotic venture]

oh god

[pearl sentinel]

[solemn rivet]

Hey, kerr. You wouldn't happen to have a magical helper function for animations which simply plays all animations of the state, like you have with audio clips, would you?

[pearl sentinel]

hmm

i just updated mod common with some cleanup and a few other goodies, but not anything like that. though i don't think you need it?

also, have you tried building mod common yet?

it'll prob be best if you develop the superdash re-write in there since you can add any helpers you need to write directly to the common

anyway, you can do this

            tk2dAnimator.Play();

typically the animations are all referencing the same animator, so you could do this

            foreach(var a in tk2dAnimator.Library.clips)
                tk2dAnimator.Play(a)

@solemn rivet

[solemn rivet]

thanks! I'll take a look

[pearl sentinel]

@exotic venture tell me what you think of heavy broken v2

[exotic venture]

isn't this v3

[pearl sentinel]

er

maybe

idk

there

[exotic venture]

nice

[pearl sentinel]

it's still basically a rough hack, but i made it a bit more stable

you should actually see them fly away now

[exotic venture]

nice!

but uh

i run a 144hz display so i actually already could

[pearl sentinel]

😛

plus they'll ricochet better, sometimes

[exotic venture]

but, like, we'll see

[pearl sentinel]

and in theory they should hurt enemies they hit

[exotic venture]

ok so

heavy blow is now an instakiller

and i have had issues where the framerate severely dropped

....and save and quit is borked

ok i can't complete ToF

i guess it's memory leaks or the game just can't keep up

[rain cedar]

Memory leaks shouldn't really be a thing because c# has automatic garbage collection

Unless something is holding reference to a ton of useless data

[pearl sentinel]

Oh crap. Yeah heavy blow leaks

Whoopz

[copper nacelle]

[pearl sentinel]

Always be careful with unity materials kids

[exotic venture]

wow i guessed right

[fair rampart]

is there a way to have one save be randomizer and another not be?

[exotic venture]

randomizer doesn't affect saves

[young walrus]

yes, run the randomizer on a save slot, then turn it off for another one

two separate saves, boom

[exotic venture]

or, yknow, that

[fair rampart]

Ok thx

First time using a mod, don’t want to screw it all up

[young walrus]

use Easy mode, tbh

[fair rampart]

...

nah

[young walrus]

unless you know speedrun tech

[fair rampart]

k

[copper nacelle]

no don't

isn't it like 99% just shade skip

and like a few fireball skips

[rain cedar]

Yeah basically

If you get wings early you're in for a bad time

[young walrus]

and just super unintended ways of doing stuff

like deep focus with no super dash

basically just all of crystal peak

[copper nacelle]

wings early was the most fun imo

[young walrus]

^

[fair rampart]

does it need the modding apl?

[young walrus]

yes

[copper nacelle]

yes

[fair rampart]

i dont know what any of this means

[copper nacelle]

just download an installer

from pins

and check the box

[young walrus]

crossroads installer

[young walrus]

it does all the work for you

yeah that's what i said

crystal peak

[hazy sentinel]

sneek peak

real shit people who say sneak peak are hella gay human beings

[young walrus]

[rain cedar]

But it's sneak peek

[hazy sentinel]

sniek pijk

[fair rampart]

it didnt work

the modding api showed up in top right but the randomizer didnt

[rain cedar]

Gonna need more info than that

[young walrus]

top right? O.o

[fair rampart]

top left

sorry

[exotic venture]

have you done every step as indicated by that pinned step by step guide

[young walrus]

it doesn't show up there

[fair rampart]

yeah i have

[young walrus]

go start a new save

[fair rampart]

i did

[exotic venture]

aka, have you placed the mod in the mods folder

[young walrus]

^^

that too

[fair rampart]

...

[young walrus]

the mod should show up as loaded on the top left

[fair rampart]

someone needs to neck me

[exotic venture]

you didn't

nice job

[fair rampart]

im fokin dumb

[exotic venture]

real nice

[fair rampart]

dost thou mean plugins?

theres a plugins folder but no mod

[rain cedar]

Can you show what you've downloaded for randomizer?

[fair rampart]

nvm its in managed

xdddd

[exotic venture]

have you checked the managed folder

yes

[young walrus]

the randomizer folder is in the right spot. it has some button assets in it

right sean? i think....

there's an assets folder somewhere

[rain cedar]

Yeah I think that's right

[young walrus]

i think that's the right spot

[fair rampart]

where do i put it

it still dosnt work

[young walrus]

show your mods folder. in the Hollow Knight data folder -> managed -> mods

[rain cedar]

Nice

[young walrus]

yeah. this is wrong

[rain cedar]

You just copy the stuff from the zip in

It's already set up right

Don't mess with it

[fair rampart]

..?

[young walrus]

or just use the crossroads installer

or watch the video in pins

shows you step by step where to put it

[fair rampart]

i use the hollow knight data folder?

didnt i just replace that for the modding api tho

[young walrus]

it's a folder structure

that puts the files where they need to be

they're empty folders except for the final destination

[fair rampart]

so what do i do with the Randomizer folder

[rain cedar]

It was right the first time

[young walrus]

copy all zip contents

paste all contents in the exe location

boom done

hollow_knight_data will merge with the actual folder and place files in the proper location

and the randomizer folder will stay there for asset use

super simple

[fair rampart]

it worked

im overthinking it

[young walrus]

yes

you are

lol

[fair rampart]

NeW vErSiOn Is AvAiLaBlE

right when i got it

[young walrus]

don't listen to that

it's broken

[fair rampart]

ok good

[rain cedar]

Blame github

And also me

[young walrus]

but mostly github

[rain cedar]

And also Unity

Mostly Unity actually

[fair rampart]

Thanks yall

[young walrus]

and your healers

and tanks

[fair rampart]

Also does hp bar work with this one?

[young walrus]

yes

[fair rampart]

Cool

Thanks again

[buoyant wasp]

Mostly unity

Actually I am pretty sure I fixed the version check by disabling it

Maybe I didnt push that...

[rain cedar]

Nah it's fixed I just implemented version checking poorly because I'm lazy

For debug and randomizer it just assumes any version returned that isn't the current one means it's out of date

[buoyant wasp]

ah

ok, cool. I cheated to fix it. "every version is current"

cause unity...grumble....

[rain cedar]

There's probably some external library we can use that supports TLS 1.2

To get actual version checking back in

Actually nevermind on that, quick google search shows that's not possible until .net 4.5

[sturdy jetty]

Are there any mods that only work on 1.3.0.8? Basically I want to know if I should update to 1.3.0.8 or not?

[tranquil glen]

no

don't

[young walrus]

all the mods you'd ever want are on 1.2.2.1

some beta work has been done, but nothing full force yet until it actually releases

[buoyant wasp]

I haven't really kept up, is there a branch in github for the API for 1.3.x yet? IE is the fixes that Kerr was doing being tracked somewhere?

[pearl sentinel]

I forked the api this morning with my changes. There's a bug in it tho with the current patch. Save and quit freezes the game

[buoyant wasp]

cool

i mean that you forked it, not that it has a bug

lol

[pearl sentinel]

[wide crown]

kerr does it do itwithout debug mod too?

cause it's not just save and quit then, it's death too

[pearl sentinel]

Haven't had the time to try yet

But that's possible

[sturdy jetty]

Does Boss Rush Mod stack with Debug mod?

What if I installed Boss Rush mod and want to play Debug mod with my normal save files?

[young walrus]

you can't play normal saves with boss rush installed

[buoyant wasp]

bossrush disables saves

[sturdy jetty]

So I need to download 1.3.0.8 to resume my save file?

[vagrant leaf]

no you just need to uninstall bossrush

[young walrus]

What is with you and the beta. Lol

[young walrus]

Boss rush can be toggled on and off from the in game menus iirc

[sturdy jetty]

Can someone show me how to toggle boss rush on and off?

This is for 1.2.2.1. Microsoft Windows.

[copper nacelle]

just move it into a folder inside the mods folder

[sturdy jetty]

So I must manually toggle it by dragging and dropping the .dll boss rush file?

[copper nacelle]

it should show up in the mods menu but your mod menu is empty

so that's the easiest way to do it

gradow's modinstaller has pretty good mod management for when you want to keep stuff installed but toggle it

[sturdy jetty]

Gradow's modinstaller = Crossroads. exe?

[young walrus]

Just drag the Dll in your folders

Make another folder in the mods folder

Name it "move mods here to turn off"

Then drop whatever mods you don't want to run, into that folder

[copper nacelle]

imo

[young walrus]

And move them back out when you want them on

Simple

[sturdy jetty]

I see. Why is Mantis Gods listed twice?

[copper nacelle]

uhh

cause one version's the compiler output i dragged in myself

and one's the version installed using the installer

[sturdy jetty]

I see. So is the mod manager the crossroads .exe file or a different file?

If it is a different file, can you link it here?

[copper nacelle]

different files

it's right after crossroads in pins

[sturdy jetty]

I see. So which directory should I drag ModInstaller.exe to?

I tried running it from my desktop and it gave me an error.

Just to clarify, all mods should be played on 1.2.2.1 except the Heavy Blow buff mod which should be played on 1.3.0.6 Lifeblood Beta, correct?

[copper nacelle]

should work anywhere

and yeah

what error did you get?

[sturdy jetty]

It was some error handling exception or something.

Anyways, I manually installed the debug mod via drag and drop without Cross Roads or Gradow's mod installer.

I get this.

So how do I respawn defeated bosses?

[wide crown]

press Esc, select bosses on top right, select boss

[sturdy jetty]

Okay, thanks.

I tried using the debug to equip all charms at once, but it does not work.

Can you tell me what could be wrong?

[rain cedar]

It doesn't have that feature

[vagrant leaf]

activate windows

[rain cedar]

Oh I didn't even see that behind the thing

[sturdy jetty]

I see. So if I want to refight Lost Kin, I just go back to where he was and press respawn all bosses and he should be there?

[rain cedar]

That's not even a button

So no you don't click that

[sturdy jetty]

So to refight Lost Kin, I just click respawn bosses in the debug menu?

Can I reopen the door to the Path of Pain via debug mode?

[rain cedar]

Just noclip into the door

[sturdy jetty]

I see.

So I turned off the debug screen because it clogged up my view for the boss fight.

How do I turn the screen back on?

[rain cedar]

F1

[sturdy jetty]

I see.

Is it possible to equip all charms at once in Debug mode?

[solemn rivet]

Can we keep ?? as our pet? Pretty please

[sturdy jetty]

@rain cedar Actually, I got Lost Kin refight to work.

[rain cedar]

Good for you

[hazy sentinel]

@sturdy jetty permablocked

anyway let's do some working out here

start off with a problem

hmm

idk the region E bounded by uhh

let's just uhh

have a hemisphere

symmetric about positive z axis centered at the origin

ez gods

radius just like

3

cool cool

density function should be

[sturdy jetty]

Can someone recommend me any other Hollow Knight mods besides Boss Rush, debug?

[hazy sentinel]

proportional to x²y

so that's

[hexed swan]

veru chill

[hazy sentinel]

r cubed

cos squared sin

don't forget the jacobian fellas

r to the fifth cos squared phi sin squared phi

ooh that's kinda nice

that's like uhh

1/4 sin squared of 2 phi

times r to the fifth of course

now bounds of integration are

r 0 to 3, theta 0 to 2 pi, phi 0 to pi/2

cool cool let's do r first

just 3^4/2 i think

or wait

fuck

3^5/2

yeah then that's 3^5/8 times sin squared of 2 phi

integrated with respect to theta first i guess

make that shit 3^5/4 pi times sin squared of 2 phi

w.r.t. phi kinda sucks

sin squared of 2 phi is 1 minus cosine of 4 phi all over 2

[tranquil glen]

what are you solving here?

[hazy sentinel]

3^5/8 pi (1-cos4φ)

sooooo

hmm phi bounds were 0 and pi/2

pi/2-0-cos2pi+cos0

just pi/2 then huh

wow interesting

so 3^5π²/16

i think

[tranquil glen]

i wrote a 3 hour math thing today and that used up any brain power i might have had to comprehend what you just did

[hazy sentinel]

tbh discord not the best for notation

didn't even do the problem correctly i think

[tranquil glen]

i don't even know what the problem was

unity is coded in c++ but its games use c# right?

so making a mod i'd use c#

?

[copper nacelle]

yea

mods are in c#

[tranquil glen]

time to learn c# i guess

how different is it to c++?

[trim grove]

c++ + ++ == c#

but also they have a lot of moderate to large differences

last i checked anyway

[rain cedar]

C# is more similar to java than c++

[tranquil glen]

oof

[buoyant obsidian]

C# basically is Java

[tranquil glen]

gross

not a huge java fan

[rain cedar]

C# is cooler because it runs well

[copper nacelle]

c# is cooler because it isn't java

[leaden hedge]

c#is cooler because microsoft

[fair rampart]

From someone who has done C/C++/Java, the C#/Microsoft environment seems like an absolute mess

[glossy pelican]

Hey, some good new mods?

[rain cedar]

No they all suck

[glossy pelican]

I would love to see some story mod

That would be cool.. or not

I mean, there is no enemies mods

Just some gameplay mods

[rain cedar]

Making new content is way harder than changing what's there

[sturdy jetty]

Besides Hornet and NKG, what cool bosses should I refight in debug?

[pearl sentinel]

tfw the game updated while i was debugging something and confused the shit out of me when all my references magically broke

[sturdy jetty]

You mean the 1.3.0.8 today?

[sturdy jetty]

Instead of programming a boss to have 9999 health, can you program him to have let's say 3000 health for example?

This is for debug mod.

Also, how do you even program a boss to get 9999 HP?

Also, how do you set up several Dream Gate portals?

[rain cedar]

For the 9999 you click the infinity symbol by the enemy in the enemy panel

For dream gates everything is in the dream gate submenu in the top right

[sturdy jetty]

I clicked respawn all bosses or I must have clicked something, but now I only have 104% completion.

I checked my inventory and I seem to have everything.

[rain cedar]

Yeah it's crazy how respawning a boss would lower your %

[sturdy jetty]

Can someone tell me what are the most commonly missed thing affecting completion rate after installing the debug mod to replay bosses?

So can I increase it back to 106% by defeating The Radiance / The Hollow Knight or something?

[rain cedar]

Defeat whatever bosses you respawned

[exotic venture]

rad and hk dont count towards %

[sturdy jetty]

I figure that respawning bosses makes the game think I still have not yet fought some bosses, correct?

[rain cedar]

That would be the idea, yeah

[sturdy jetty]

I see.

So I respawned Lost Kin, Hornet, Mantis Lords. I was at 103%, then I beat Mantis Lords, so now it is 104%.

So I guess the last 2 must be Hornet and Lost Kin?

[rain cedar]

Just hornet

Lost kin is no %

Hornet is only 1, though

[pearl sentinel]

@exotic venture https://clips.twitch.tv/GleamingSourDragonfruitKappaClaus

https://clips.twitch.tv/SquareCaringYakCmonBruh

[sturdy jetty]

What does Read Data, Save Data, Delete item, do within the context of setting up Dream Gates?

Wouldn't be easier to label them as set up a Dream Gate, Delete Dream Gate?

[rain cedar]

That's not even the right amount of buttons

There's already add/delete, that's pretty clear

Read/save read or save your dream gates from/to a file

[sturdy jetty]

What is the difference between the top picture and the bottom picture?

[rain cedar]

The top one shows a bug and the bottom one looks fine

Misaligned text in the help menu

But anyway I'm done playing 20 questions for tonight

Maybe someone else will feel like dealing with you

[fair rampart]

@pearl sentinel
I grabbed your V1 of the Heavy Blow mod, what's the difference between that and V3 or whatever?

[rain cedar]

From what I've seen V3 works a lot nicer

Doesn't smack around non-enemies and does damage to enemies when they hit things

Rather than just bouncing around forever

[sturdy jetty]

Can someone send me the Version 3 of the Heavy Blow Buff Mod? Thanks.

I got the Dream Gate to work.

[inland relic]

My bonfire mod is not working

what should ı do

[young walrus]

What'd you do?

[inland relic]

ı did nothing

ı moved file to data but it doesn't work

[tranquil glen]

did you get the modding api?

[inland relic]

no

should ı

[young walrus]

Yes

[inland relic]

how can i find it

[young walrus]

📌

[inland relic]

okay thx

Oh no

my save is gone

modding api 😦

ı changed it with my old save but it crashes

okay it works

How can ı use modding api withoust losing my save:?

[young walrus]

You just use it

[inland relic]

ı used but my save is gone

[young walrus]

Modding API doesn't affect saves

[inland relic]

interesting

[young walrus]

What else do you have installed

[inland relic]

charm notchs mod

what is public beta?

[young walrus]

You're on the beta?

[inland relic]

I don't know

it says public beta

[young walrus]

Title screen. Bottom left

What patch number does it say

[inland relic]

1.2.2.1

[solemn rivet]

Then you need to grab the api from the gdrive in pins

Did you do that?

[inland relic]

ı did but my save gone

[solemn rivet]

What do you mean by that?

[inland relic]

I installed the modding api then my save deleted

[solemn rivet]

Install the api, open the game and show us a screenshot of the save selection screen

[inland relic]

okay

Thank you my save is back 😃

there is no problem

[solemn rivet]

Then it's all good

[inland relic]

Yep thx

[solemn rivet]

Just a heads up

Bonfire is op as fuck

A nice proof of concept for some things, but still op

[inland relic]

I'm not going to use it

when ı install my game is going back

I am sitting on a bench with 60geo at dirtmouth

But ı was at kingdom's edge

[sturdy jetty]

bonfire mod = ?

[young walrus]

you're the bonfire mod?

[fair rampart]

Hey folks, so I've just come back to being interested in HK after a while, in preparation for G&G

I see a lot of mods in that pinned post up there, but I only recognize a few of them by name

is there some place where there are some blurbs about what they all actually do :V?

[shell dew]

Every zip file has a README.txt included i believe

[fair rampart]

Ah, thanks

that's a place I can start

[shell dew]

Got chu

[pearl sentinel]

hehe, this function that looks for transition gates in a scene searches for them in 3 different ways. i like the 3rd debug output line tho. TC has a good sense of humor

1st:

Debug.Log("SUCCESS - Found as root object");

2nd:

Debug.Log("SUCCESS - Found in _Transition Gates folder");

3rd:

Debug.Log("SUCCESS - Found as a child of a random scene object, can't win em all");

well, i should've guessed

my scene transition problems with doors are because of this

PFSM Name: Door Control

[fair rampart]

Oh boyo

I guess we can add another Mod Loader/installer to the list if we want

[copper nacelle]

what

[fair rampart]

I've got a mod installer/loader I've built that's generic to all Unity games.
Works with a buttload of them currently, installs Patches and normal mods that can just be loaded and run code just interacting with the game

I haven't found a game it DOESN'T work with..

[copper nacelle]

works with hk then?

[fair rampart]

I'd imagine

Nobody's made Hollow Knight mods with it yet so

¯_(ツ)_/¯

I'll go test really fast, I think I still have HK downloaded

Let's check

[copper nacelle]

w/ it?

[exotic venture]

heavy blow is beautiful

[fair rampart]

Yep.

It works with Hollow Knight.

I honestly just feel bad adding to the list/making something new that people are going to have to update mods for if they wanna use it :L

Oh well, I'll post it

I'm really busy working on it and modding RainWorld so I won't be making any mods for now but

[exotic venture]

well currently we already roll with an api for it

[fair rampart]

It'll exist

Yeah

[exotic venture]

if it works don't fix it i suppose

[fair rampart]

Which one are you talking about?

Crossroads or?

[exotic venture]

ohhh you mean actual installers

[fair rampart]

Both

[exotic venture]

yeah we already got two

[fair rampart]

:V

Partiality is a Mod Installer and Mod Loader

Bundled into one

Either way

CrossRoads is kinda

[exotic venture]

for a mod loader we just got the modding api

as for installer

a la manuel is best

[fair rampart]

illegal unless the devs give explicit legal permission to distribute the game's assets/code good, but can be improved

Idk about the rest

[exotic venture]

well i mean everything here is kinda closed off

[young walrus]

crossroads is meant for the people that are super struggling since it auto downloads the mods they need and installs them

[fair rampart]

Yeah I saw that

It's a pretty neato feature.

Anyway... Either way.

https://github.com/PartialityModding/PartialityLauncher/releases

[exotic venture]

what a readme

[fair rampart]

Partiality is a catch-all Unity Modder, it installs patches so you don't need to redistribute a game's code/asset files, just your patches. It uses MonoMod to do that.

Well for one

It's still hugely WIP anddddd

I need to do all the detailing ;-;

Also the actual source code is outdated

It's all 0.2 stuff

[exotic venture]

wew

[fair rampart]

Because I did a HUGE update with 0.3, switched to Eto.Forms for cross-platform UI and shtuff

Haven't updated the source yet

[exotic venture]

i've heard about monomod being used for some stuff here but i think they switched back to own making i guess?

not entirely sure

[fair rampart]

Yeah

anyway

[pearl sentinel]

we have a modding api created with monomod

mods link against that

[fair rampart]

Oh neato

[pearl sentinel]

then only the api changes on updates

[fair rampart]

Well if you have any patches made in MonoMod, They'll work with Partiality, you just drop them into the "Mods" folder.

[pearl sentinel]

yeah, 99% of our mods these days don't use monomod for anything

[fair rampart]

You should fix that :V

Well

Your patches should use MonoMod

The loaded mods don't need to

[pearl sentinel]

that's what the api does

[fair rampart]

Ye

[pearl sentinel]

already

[fair rampart]

Well good

[exotic venture]

back to the "don't fix what ain't broken" mentality

[fair rampart]

You guys can convert to partiality if you want or not, I don't really mind, I just saw that some of the modding was redistributing the game's assets and I wanted to offer a proven, already-built alternative.

So that if the devs DO get mad at you guys (or their lawyers do or whatever) you guys have something as a backup

[exotic venture]

devs are in this discord

[pearl sentinel]

i see what you're saying, @buoyant wasp or @rain cedar might have a better response for you

[young walrus]

well since the devs know about the modding and are fine with it....

[exotic venture]

uhhh if they objected

they'd just call them out here

but considering some devs even use the mods made here i mean

why would they

[fair rampart]

Well now that there's an easy-to-use form of modding that doesn't require distributing the game's files, they may want you guys to switch to that.

[copper nacelle]

you can just use an xdelta tho

[fair rampart]

They may not have known that it was easy or possible

Anyway, the point is. I'm not here to overturn the modding community or tell you guys that everything you have is bad and you should switch

[copper nacelle]

Modding API can already be installed w/out distributing files

as well

[fair rampart]

I'm just here to give you an alternative

[copper nacelle]

you just compile it from github w/ vanilla files

and swap out the output

it's only distributed here for ease of use

w/ dev's perms iirc

[fair rampart]

Good

Then it's fine

[exotic venture]

"don't fix what ain't broken", too

[buoyant wasp]

I looked at it before, but the big thing was that we couldn't rewrite game code with it at the time. and there was some other thing it didn't do (though I can't remember what)

wrapping methods is fine, but sometimes we are editing the methods in the middle because we can't do it before/after the original method

(big ones were altering the save functionality and altering the dash mechanics, but there were others)

[fair rampart]

You can do that, it's just more complicated than putting your code before/after

Either way

I'm around if you guys have questions, but you can stick to how you have it, it doesn't look like the devs are upset about how you guys do it.

I also wanted to put Partiality here kinda because I need more Unity games to test Partiality with and find bugs and stuff

[buoyant wasp]

I'm not opposed to the concept personally, but i also tend to agree with @exotic venture . If it ain't broke 😃 . If someone wants to go through the effort, that's fine, but that would mean having to port all mods to the new way too or fracturing the setup. I can just say that, myself, won't be putting effort into changing how it's done now. if this was something we would have had 8 months ago... 😃

[fair rampart]

Yeah

It only just started existing a few months ago because I didn't have the knowledge/drive to create it

[solemn rivet]

8 months

god, I feel old

[buoyant wasp]

but i'm glad there is more work being done in this arena. Unity is pretty popular these days for better or worse, so more modding power is always good

[fair rampart]

Yep

I'm trying to prep Partiality for when Risk Of Rain 2 comes out

Because I want to mod that game the SECOND it comes out

Looks like you guys have got it going good though so 👍

Good luck, and I'm here if you need me

[pearl sentinel]

@exotic venture much more balanced heavy blow (and shouldn't lag)

still pretty op tho

no more hitting gates and elevators either

[exotic venture]

heavy blow is now balanced

a man can dream

[pearl sentinel]

Idk I think it's getting close

[exotic venture]

i have time after being mentally drained from work so let's test this

[pearl sentinel]

[solemn rivet]

are the number of bounces limited?

or do they bounce til ded

[pearl sentinel]

they bounce until the applied velocity is less than a threshold i set

since FSMs basically take over the velocity, i can't use the real velocity

[solemn rivet]

I see

[sturdy jetty]

Pin it. Mod common = ?

[young walrus]

boy, ? is a lot of mods

you must be a bot

[wide crown]

thanks Kerr

testing too the new api

though debug mode says "new version available"

even though i dl the one from the folder

[solemn rivet]

ignore that

[wide crown]

ok 😃 ok crash on quit to menu

hazards are good too

so far so good 😃

[solemn rivet]

no crash on quit to menu, or crash on quit to menu?

would be nice to get at least ground charge working today

[bronze temple]

@fair rampart what were you trying to achieve here

[fair rampart]

¯_(ツ)_/¯

More options.

If it ain't broke don't fix it, but if it breaks later there's more options

[bronze temple]

you mean, fragmenting a modding community?

The current API isn't broken and MonoMod is already being used behind the scenes

[fair rampart]

Yeah that's what I said

[bronze temple]

if you're willing to move the existing API to Partiality and preserve backwards compatibility, that's fine

[fair rampart]

"If it ain't broke, don't fix it"

It's not bad to have a second option in case something changes

Better safe than sorry

But a few modders (one at least) already said they wouldn't be switching to Partiality, which is fine

I didn't expect them to, they seem to have things under control

But knowing it exists doesn't hurt anyone either

[bronze temple]

by the way, I thought Partiality wasn't ready for proper mods yet?

Why are you already proposing it in existing modding communities?

[fair rampart]

Well I can't bugtest it if nobody uses it so...

It is ready for proper mods

[bronze temple]

I've already explained my opinion on it in the MonoMod server

find new games, use them as "testing data"

that's how MonoMod became more stable over time

[fair rampart]

Yeh

[bronze temple]

I'd prefer if we'd move this discussion back into the MonoMod server

sorry for cluttering your chat 😅

[pearl sentinel]

[wide crown]

it wasn't a crash it just locked till you pressed esc

not enabling you to go to menu

a soft-softlock

[solemn rivet]

Yeah... That's been an issue with the last patches

They changed scene behaviors

[young walrus]

hilarious mod idea: change all sounds when the hero hits an enemy with the nail to this BOOP sound:

https://www.youtube.com/watch?v=ucRfdCtjbbA

or a similar boop sound

[oak laurel]

I couldn't clip chat fast enough

😦

[rain cedar]

What?

[young walrus]

https://www.youtube.com/watch?v=AGP1aXb8ds4

hahahahaha

i can just imagine it

[rain cedar]

You seem pretty amused by this idea

[young walrus]

it'd be hilarious

instead of that squish sound

you'd have this

[oak laurel]

Can we replace all noises with Mickely's Elderbug impression instead?

https://clips.twitch.tv/ImpartialSnappyTurnipCeilingCat

[rain cedar]

That's also a possibility yeah

[wide crown]

lool

[river pendant]

hi so

i had debug mod installed before moving to the lifeblood beta

and basically

my nail damage was turned up stupidly high because i was messing around

and now even though i've gone back a version and reinstalled everything, the modloader keeps telling me that debug won't load

[copper nacelle]

ModLog

imo

it's in the saves folder

and the save folder location is in 📌

[river pendant]

yes but, where do i go from there

[young walrus]

The beta can really mess with your game

Post the log hete

Here

[river pendant]

can do

i'm using what i can only assume is the most recent version of the mod since it's the only one on the google drive link my friend gave me

[copper nacelle]

delete your mod settings

also in save folder

[rain cedar]

Yeah, empty settings somehow

[copper nacelle]

they end in .json

[river pendant]

global settings i assume?

[rain cedar]

Nah, I think it's actually a problem with your save file

Or no this would be global settings

[river pendant]

i'd very much like to not have to replay the game through again if possible

[copper nacelle]

api error so I'd assume global

[rain cedar]

Idk how, I added a failsafe for empty settings

[copper nacelle]

failsafe failsafe when

[river pendant]

just just uh

delete this boys, right

[copper nacelle]

could delete all of them

if you want

[river pendant]

aight nice

[rain cedar]

Oh right there's global mod settings

[young walrus]

Side note, has anyone recreated the bench bug I had a few weeks ago?

[tranquil glen]

yes

[river pendant]

alright lemme try this out

[tranquil glen]

it happened to me mick

[young walrus]

Lol

I wonder if it happens anymore with the new beta patches

[tranquil glen]

i just cleared the entire registry

[young walrus]

Ya. I had to too

What a dumb bug

[tranquil glen]

yeah

[river pendant]

sweet

alright now to just save and hope it doesnt fuck up when i go back to the beta

[rain cedar]

Alright I see the problem here

I added the failsafe here https://github.com/seanpr96/HollowKnight.Modding/blob/master/Assembly-CSharp/ModHooks.cs#L2110 but not here https://github.com/seanpr96/HollowKnight.Modding/blob/master/Assembly-CSharp/Mod.cs#L175

[river pendant]

aight beta is installing

thanks lads

i can't wait to hear from my friend about how i joined and left

and how i need to get good or something like that

anyways

👋

[copper nacelle]

[sturdy jetty]

What is the difference between Mod Common and Modding API for 1.3.0.9 Beta?

Also can someone pin it?

[copper nacelle]

ModCommon just has some nice stuff

really nice stuff

[solemn rivet]

No, it won't be pinned because it's not final or stable

[rain cedar]

It's not even something that any end user needs to care about

[sturdy jetty]

So if we want to play the mod, do we need Mod Commons or not?

[rain cedar]

Just fuck off man

Please

I literally just answered that

I don't understand how someone like you can even operate in life

[sturdy jetty]

I see. If we want to use Mod Common, which directory should we install it in?

I never installed Mod Commons before.

[rain cedar]

It's not something that the end user needs to care about

Like I said

Fuck it I'm blocking you because I'm not otherwise capable of just ignoring your constant inane questions

[young walrus]

Yeah but Sean.... Where do install? Kek

[rain cedar]

Same

[solemn rivet]

please tell me it's a bot

[sturdy jetty]

But 56 said Mod Commons has some really nice stuff in it, hence my question.

[rain cedar]

He says things that are related to current discussions so I don't think he's a bot

Just really dumb

[solemn rivet]

like sean said, not something end users should even care about, ??

[sturdy jetty]

I see.

[solemn rivet]

maybe it's like cleverbot, but not

[pearl sentinel]

have you ever seen this before?

https://clips.twitch.tv/TacitProductiveNarwhalTF2John

[rain cedar]

Maybe that's a new thing in the beta

[pearl sentinel]

i don't think they're playing the beta? not sure tho

oh they are

nvm

[copper nacelle]

leaked new enemy rando game mode

[pearl sentinel]

hah

[copper nacelle]

saw this and nearly died

[rain cedar]

You didn't even say it was a mod, though

You just said it has nice stuff

[copper nacelle]

yeah

[solemn rivet]

Tell him there's nice stuff if you jump off a cliff

[hidden gull]

Anyone know if the traitor lord got a health buff from the lifeblood update?

[pearl sentinel]

only way to know that would be to diff the FSMs, and i don't think anyone checked them prior to the update

[hidden gull]

Okay, thanks

[pearl sentinel]

@solemn rivet here's a pretty thorough dump of the superdash object using a new object printer that uses reflection. thought it might be helpful to you

specifically the object's fsm i guess

[sturdy jetty]

For the Debug Mod, I cannot respawn Crystal Guardian 1 or 2.
I click respawn.
I warp somewhere else then I warp back.
CS 1 and 2 are still not there.
Mantis Lords, Hornet, Lost Kin all appear for me.
This is for Microsoft Windows 1.2.2.1.

[exotic venture]

what does your output log say when you click the respawn boss button

is there a boss even detected

also, i am pretty sure cg1 and 2 are mini bosses and not actual bosses

kinda like a brooding mawlek

[rain cedar]

How much you guys wanna bet this was ??

[buoyant obsidian]

it was * * * *

[pearl sentinel]

Unrelated: Sean, idk if you saw my comment this morning, but the door transitions have an fsm on them, so that's why they're janky/missing data

It's pretty simple, so I'm just gonna rewrite it. Idk if the rewrite will even need to end up being a state machine.

But just in case you were curious

[rain cedar]

Yeah I figured

Really odd it would be like that, though

[sturdy jetty]

@exotic venture

Hold on. Let me post my Mod Log.

[exotic venture]

still holding on @sturdy jetty

[sturdy jetty]

@exotic venture This is what I have.

[sterile valley]

Who made the Debug mod?

[exotic venture]

you aren't warping out but giving yourself 100 essence

[sterile valley]

Or rather. Who made the Crossroads thing?

[exotic venture]

have you tried walking out of the room

[sterile valley]

Whoever did, please update the Debug mod in it. It shouldn't be too hard, I assume you get it off somewhere on the internet.

All that needs to be done is to grab the updated version of the link.

Whoever you are, thank you for the great job you've done with Crossroads.

[sturdy jetty]

Yes.

[sterile valley]

You've made a lot of people's lifes easier. 🖤

[sturdy jetty]

As well as warping in and out.

[exotic venture]

and it didn't respawn the boss?

must be due to cg1 and 2 having preexisting entities maybe?

like the dood sitting on a bench

[sturdy jetty]

Correct. Boss did not respawn.

No one is sitting on the bench.

[exotic venture]

odd

no clue how that works

[sturdy jetty]

I see. We;ll, thanks for investigating at least.

[exotic venture]

i vaguely recall something that stopped cg1 and 2 from spawning but i don't remember what it was

[sturdy jetty]

I see. If it matters, I set up a few extra Dream Gates.

So maybe it could be that.

[exotic venture]

a few?

[sturdy jetty]

Like 10 or so.

Via the debug mod.

[exotic venture]

mais por que

[sturdy jetty]

So I can teleport to each boss and play a Boss Rush my own style.

KDT's Boss Rush does not fit my style.

[copper nacelle]

[warped sinew]

You might enjoy the forbidden mod

[hollow pier]

wow big meme

[sturdy jetty]

I will try it.

[wide crown]

wait how do you give yourself essense with debugmod

[sturdy jetty]

Pressing "Add item" in the top right hand corner.

It gives 100 Essence each click.

I have over 30k Essence.

[wide crown]

can geo be given too?

[sturdy jetty]

Increasing Geo requires another click. I never tried adding more Geo though because I already have 360K Geo from

playing Trial of the Fool everyday.

[wide crown]

wait

which button?

https://i.imgur.com/A24rPaW.png

[sturdy jetty]

For Geo?

[wide crown]

geo and ess.

i see no button for them there

[sturdy jetty]

For Geo, I do not know. I never needed more Geo, so I never tried investigating which button gives me more Geo.

For Essence, click "Add Item" under "Dream Gate."

[wide crown]

oh.

https://i.imgur.com/jSksX42.png

no

[sturdy jetty]

Hmm.

[wide crown]

when i do add item it does that

[sturdy jetty]

Try pressing "Read Data."

[wide crown]

file dreamgate.dat not found

write: writing dgdata to the file

OH it's Items

and clicking on geo and essence

give them gotit

[sturdy jetty]

Nice.

[solemn rivet]

so, lenovo is a piece of shite

my laptop is just over a year old and the (internal, I might add) battery goes poof!

there's an inch high bump on my keyboard

ffs

[pearl sentinel]

.<

wow, that sucks

time to hit up /r/buildapc

[solemn rivet]

I had to disassemble it last night and remove the bastard

yay, no more overheating

but, yeah, at the time I bought this I was finishing my master's so I figured a portable pc would be best for me

but I can't even run HK over 90fps on this

what point is there to life below 120fps?

[pearl sentinel]

hehe

buttery smooth fps is nice

[solemn rivet]

so, yeah, sorry for the offtopic, I just needed to vent

also, back on track, I'll take a look at that new dumper of yours kerr

might make things way easier for me

[pearl sentinel]

it could still use some tweaking to cut down on redundant info

[solemn rivet]

I think that, in short time, we'll be able to write a script to convert fsms to your gamestatemachines

because... It's pretty procedural tbh

find var/action, do default procedure, rinse and repeat

[pearl sentinel]

sorta, the boilerplate stuff at least

[solemn rivet]

yeah

[pearl sentinel]

that's a good idea tho

it could just grab the template class i've got and then add to that and rename stuff

[solemn rivet]

I think it could work for simple/short fsms

like door_control, sprite_glow...

[fickle mesa]

i have a question. i downloaded the debug mod, and cant get it to work. It worked before, but i closed the thing with the commands and keys and such, and cant get it to come back. basically cant use mod at all because of this. help please

not really a question technically

[solemn rivet]

f1

[fickle mesa]

thank you

[pearl sentinel]

for some like door control, that might end up not being an fsm. going to look at it this morning

[solemn rivet]

hmm I think there is a door_control fsm tho

lemme take a look at the cached fsms I have...

yup, there is

[young walrus]

Should almost leave a permanent UI note in a corner or something to remind people what the hide hotkey is

[weary oyster]

hp bar mod doesnt seem to work for NKG

@leaden hedge fix plis

[solemn rivet]

are you on beta?

[weary oyster]

beta what?

im playing on 1.2.2.1

[solemn rivet]

hm...

then it should work

[weary oyster]

it works on other bosses

[solemn rivet]

iirc it's hard coded to work with NKG

[weary oyster]

just not nkg

[solemn rivet]

kek

[weary oyster]

like the health bar is there but it just doesnt go down at all

stays at full

[solemn rivet]

I just checked the code

indeed it doesn't work

huh

            case "Lost Kin":
                HPBar.maxHP = 1200;
                goto IL_427;
            case "Nightmare Grimm Boss":
            case "False Knight Dream":
                HPBar.maxHP = 360;
                goto IL_427;```

[weary oyster]

can you fix it?

[solemn rivet]

I think so

do you happen to know NKG's health?

[weary oyster]

1500

[solemn rivet]

always? Independent of upgrades?

[weary oyster]

i think it is?

like 90% sure

i think only regular grimm scales on nail

[solemn rivet]

try this

also, sorry for doing this without permission, KDT

if you want to, I can delete this post

@weary oyster ^

[pearl sentinel]

how dare you fix something

[solemn rivet]

I mean, it's his code, so...

also

dnspy is stupid

turned this

into this

why would you use uint num3 = __1__<PrivateImplementationDetails>.ComputeStringHash(gameObjectName); instead of switch case-ing the gameObjectName?

I'll just clone and compile it

ffs

[weary oyster]

nice gradow, that works

[solemn rivet]

oh

[weary oyster]

thanks a lot

[solemn rivet]

I won't then

np

[weary oyster]

huh? lol

[solemn rivet]

nah

it's just the compiler being stupid, but if it works, then it's fine

[pearl sentinel]

a better question is why use a switch at all there :3

[solemn rivet]

[leaden hedge]

Its 1800, and thats how a switch actually works

[solemn rivet]

I know, but that's not the point

the point is, it first decompiled it as a switch

then, after I changed it, it decompiled it as that

no consistency

[pearl sentinel]

Compiler optimizations

[leaden hedge]

There's no need for a switch anymore anyway

Its not an optimization AFAIK

That's just how a switch works

It's a hard coded hashtable

[pearl sentinel]

oh, i wasn't referring to that

i thought the switch was a result of w/e the code was originally

        Dictionary<string,int> hpValues = new Dictionary<string, int>()
        {
            {"Head",40 }
            ,{"Hornet Boss 1",225}
        };

like that

becoming the switch

[leaden hedge]

I removed all that

Which hpbar code are you looking at

[solemn rivet]

certainly not the one in github

maybe I have an older version