#archived-modding-development | Hollow Knight | Page 59

copper nacelle Feb 20, 2018, 1:58 AM

#

except don't because fsms are bad

solemn rivet Feb 20, 2018, 2:00 AM

#

I can do some wonky workaround like that

#

have it directly subtract from enemies' HP

#

but, meh

#

so, on an unrelated note

#

I found out what "I" was doing to change files on the drive that aren't mine

#

for some reason, when I right click->"get shared link" on any file, it auto-changes that file's share status to "anyone at UC Santa Cruz with the link can view"... Which is weird, cause I have no connection to UCSC, don't use VPN/proxy and, just to be safe, I live in Brazil

#

so, yeah

#

I sent google a message

#

still waiting for a reply tho

copper nacelle Feb 20, 2018, 2:11 AM

#

lmao

solemn rivet Feb 20, 2018, 2:12 AM

#

it doesn't depend on the browser btw

#

and also, it doesn't happen if instead of right-click, I use the little "chain" button on the page to get the share link

copper nacelle Feb 20, 2018, 2:12 AM

#

wtf

pearl sentinel Feb 20, 2018, 3:57 AM

#

i leave for like literally 3 hours and miss all the excitement

copper nacelle Feb 20, 2018, 3:58 AM

#

lmao

pearl sentinel Feb 20, 2018, 4:00 AM

#

i should make an "im feeling lucky" button that just downloads random mods

copper nacelle Feb 20, 2018, 4:01 AM

#

lmao

#

that'd be neat

pearl sentinel Feb 20, 2018, 4:08 AM

#

then we can tell people to just click the button until they're happy

copper nacelle Feb 20, 2018, 4:09 AM

#

nice

pearl sentinel Feb 20, 2018, 4:13 AM

#

i wanna make a mod that tracks where you go (like visually) with waypoints that you can load and follow on subsequent playthroughs

copper nacelle Feb 20, 2018, 4:13 AM

#

that'd be neat

pearl sentinel Feb 20, 2018, 4:13 AM

#

yeah, pretty easy too

#

maybe if i have time tomorrow morning

#

i could do things today... but i'm so close to void elves....

copper nacelle Feb 20, 2018, 4:29 AM

#

void elves

#

what

pearl sentinel Feb 20, 2018, 4:29 AM

#

(WoW)

#

new race thing

copper nacelle Feb 20, 2018, 4:30 AM

#

o

solemn rivet Feb 20, 2018, 3:02 PM

#

(potential?) final release! Now it can download and manage modding API and API mods!

📎 ModInstaller.exe

agile gulch Feb 20, 2018, 3:02 PM

#

cool and good

rain cedar Feb 20, 2018, 3:27 PM

#

can someone make a pizza please (it will make me very happy mylajoy )

📎 pizza_adven_zestypepperoni.png

pearl sentinel Feb 20, 2018, 3:28 PM

#

usedFunk

solar heart Feb 20, 2018, 3:29 PM

#

pizza will make me very happy too

pearl sentinel Feb 20, 2018, 3:29 PM

#

usedSip

solemn rivet Feb 20, 2018, 3:31 PM

#

smallestviolin

solar heart Feb 20, 2018, 3:36 PM

#

what

#

why did my post got deleted?

scarlet sierra Feb 20, 2018, 3:39 PM

#

Tbh a team of modders need to collaborate and make a playable quirrel mod

rain cedar Feb 20, 2018, 3:40 PM

#

Tbh a team of fast food workers need to collaborate and make me a taco

#

Fucking two of them right one after the other

solemn rivet Feb 20, 2018, 3:40 PM

#

kek that's like above average

solar heart Feb 20, 2018, 3:42 PM

#

@rain cedar it looks like you are a "HUNGRY KNIGHT"

rain cedar Feb 20, 2018, 3:42 PM

#

Wow and an @ for no reason

#

We're on a roll here

#

Alright you've gone from being annoying to outright spam

#

I'm gonna delete those pictures, don't post more

solar heart Feb 20, 2018, 3:51 PM

#

sowwy :((

pearl sentinel Feb 20, 2018, 3:55 PM

#

just tried an idea i had, time only moves while you're pressing a key

#

kinda fun

rain cedar Feb 20, 2018, 3:55 PM

#

SUPER

#

HOLLOW

pearl sentinel Feb 20, 2018, 4:01 PM

#

ok, this is a more than kinda fun

exotic venture Feb 20, 2018, 4:03 PM

#

SUPER HOLLOW KNIGHT 64 WHEN

pearl sentinel Feb 20, 2018, 4:04 PM

#

threading the needle with timescale and enemy rando: https://puu.sh/zrUh8/b0afaf560c.jpg

exotic venture Feb 20, 2018, 4:04 PM

#

intenseeyes

#

Tell me more.

rain cedar Feb 20, 2018, 4:04 PM

#

Wow you have a working enemy rando already and you're hiding it

exotic venture Feb 20, 2018, 4:05 PM

#

I need to know more about this

pearl sentinel Feb 20, 2018, 4:05 PM

#

it softlocks in a few places that i'm ironing out (the enemy rando)

#

i'm hoping to release it soon

young walrus Feb 20, 2018, 4:05 PM

#

we still need to finalize the bingo goals. lol

exotic venture Feb 20, 2018, 4:06 PM

#

bingo goals, what

rain cedar Feb 20, 2018, 4:07 PM

#

"Finalize"

#

There needs to be like double what there is now

#

https://docs.google.com/spreadsheets/d/1w4_ZAxrVHWEOLoyCdwBLgyjEBN4NaThxwY7t6ip4774/edit?usp=sharing

young walrus Feb 20, 2018, 4:08 PM

#

there's like 150+ goals there

rain cedar Feb 20, 2018, 4:08 PM

#

There's only 18 green ones

#

Good luck getting short cards

young walrus Feb 20, 2018, 4:09 PM

#

so we'll just make 1 medium list

rain cedar Feb 20, 2018, 4:09 PM

#

Ok

young walrus Feb 20, 2018, 4:10 PM

#

so like... exclude all the red goals, and then use orange/yellow primarily in the list. and combine some green ones for the list

#

boom

rain cedar Feb 20, 2018, 4:11 PM

#

Yeah, could be fun

#

Some of the uncolored ones in the middle should be green too

#

Like tram pass and crossroads grubs

#

Very easy

young walrus Feb 20, 2018, 4:20 PM

#

even if we just have a rough version together for v1.0, that'll allow us to do some races/runs with it for balancing

exotic venture Feb 20, 2018, 4:22 PM

#

lantern is also very easy

rain cedar Feb 20, 2018, 4:22 PM

#

Eh

young walrus Feb 20, 2018, 4:22 PM

#

easy-ish goals are fine

rain cedar Feb 20, 2018, 4:22 PM

#

It's easy but time consuming

young walrus Feb 20, 2018, 4:22 PM

#

we have 25 of these

exotic venture Feb 20, 2018, 4:23 PM

#

arcane egg is also pretty easy

rain cedar Feb 20, 2018, 4:23 PM

#

Arcane egg requires abyss

young walrus Feb 20, 2018, 4:23 PM

#

^

rain cedar Feb 20, 2018, 4:23 PM

#

Or a lot of essence

young walrus Feb 20, 2018, 4:26 PM

#

And something like buying lantern, requires you to spend a bunch of money, which could also be used for other goals

#

so if you have let's say 4 geo related goals on the board, you have to make choices on what to do

#

and what you think the opponent is going to do

pearl sentinel Feb 20, 2018, 5:14 PM

#

one other mod concept i was wondering about, visual path tracker: https://puu.sh/zrWBg/d7c4575dce.jpg

#

(very roughly thrown together)

#

was thinking something like this could be useful for speed running

#

saving off route data and using it for practicing, or just for tracking where you've been

#

thoughts? useful? useless?

solemn rivet Feb 20, 2018, 5:23 PM

#

@exotic venture my take on fixing that annoying vanilla bug

📎 Blackmoth.dll

#

see if this works

#

I mean, I tried it and at least it works... Dunno if it still breaks tho

scarlet sierra Feb 20, 2018, 7:29 PM

#

fighting bosses with a tracker would be hell due to it cluttering the screen

fresh furnace Feb 20, 2018, 7:30 PM

#

you could make it like 10% opacity

pearl sentinel Feb 20, 2018, 8:41 PM

#

Well, ideally it would be on a toggle, and mostly setup so you could follow the path of a previously recorded run

#

Also, sharing recorded runs could be a thing

young walrus Feb 20, 2018, 8:43 PM

#

would there be a way to use that tracking to "save" a room timer

#

so we can easily compare optimal strats for rooms?

pearl sentinel Feb 20, 2018, 8:44 PM

#

Yep

young walrus Feb 20, 2018, 8:44 PM

#

because I could see that being SUPER useful

pearl sentinel Feb 20, 2018, 8:45 PM

#

Everything I've mentioned could probably be done in a day, including adding metadata to points

#

Like, if you got hit, or swung, what time at the point, etc

young walrus Feb 20, 2018, 8:45 PM

#

exactly

#

that would be huge

#

really really helpful for run optimizations

#

and for explaining/learning new tricks

pearl sentinel Feb 20, 2018, 8:46 PM

#

Cool. Then I'll put it in my to do list

young walrus Feb 20, 2018, 8:46 PM

#

like... the timing for fireball skips

#

or explosion pogo

#

if you had all this tracking stuff, it's MUCH easier

#

cuz you could import a tracking overlay from someone else

pearl sentinel Feb 20, 2018, 8:46 PM

#

Yeah, would be neat to see the data an advanced player like you generates

young walrus Feb 20, 2018, 8:47 PM

#

would that be possible? to overlay imported data onto your own game?

#

so it's static in a room?

pearl sentinel Feb 20, 2018, 8:47 PM

#

Yep

young walrus Feb 20, 2018, 8:47 PM

#

that would be amazing

pearl sentinel Feb 20, 2018, 8:47 PM

#

That's the main feature I was hoping for

young walrus Feb 20, 2018, 8:47 PM

#

Huge huge huge tool for new runners

buoyant wasp Feb 20, 2018, 8:47 PM

#

"advanced player" hollowlenny

young walrus Feb 20, 2018, 8:47 PM

#

^

pearl sentinel Feb 20, 2018, 8:48 PM

#

You could also have it "inspect" and show stats for the nearest points, and do things like estimate how fast you were going by averaging your position

young walrus Feb 20, 2018, 8:48 PM

#

and how far off from optimal you were

pearl sentinel Feb 20, 2018, 8:49 PM

#

Yeah, it would be easier to figure that stuff out for sure

young walrus Feb 20, 2018, 8:49 PM

#

so then we can get an idea of how large some frame windows are

pearl sentinel Feb 20, 2018, 8:51 PM

#

Sigh, I need to stop having ideas for a bit so I can finish enemy rando sadgrub

exotic venture Feb 20, 2018, 8:51 PM

#

i wanna play enemy randomizer for sure

#

seems like a good balance

young walrus Feb 20, 2018, 8:53 PM

#

hmm.... if i can track data on 1.2.2.1 and get a good overlay/window for clipping to shade soul....

pearl sentinel Feb 20, 2018, 8:54 PM

#

Mickely, what all data would you like to have overlaid on a scene?

buoyant wasp Feb 20, 2018, 8:54 PM

#

all the things

young walrus Feb 20, 2018, 8:54 PM

#

movement, input presses, everything

#

but like....

#

able to hide some stuff if you want

#

and able to save certain "instances"

#

so.... say i'm trying this clip over and over

#

I want to save successful input sequences

#

and ignore ones that don't work

pearl sentinel Feb 20, 2018, 8:55 PM

#

Gotcha

young walrus Feb 20, 2018, 8:55 PM

#

so almost like a "recording" function

pearl sentinel Feb 20, 2018, 8:57 PM

#

Yeah, if I have some time tonight I'll see what I can throw together as a prototype. I originally wanted this so I could have a way to follow my previous run and try to optimize it, but you have a lot more ideas for it

young walrus Feb 20, 2018, 8:58 PM

#

it could be used for both

buoyant wasp Feb 20, 2018, 8:58 PM

#

bosses will look like hilarious spaghetti

young walrus Feb 20, 2018, 8:58 PM

#

lol

#

some kind of time tracking there would be nice

pearl sentinel Feb 20, 2018, 8:58 PM

#

Yeah, I have some ideas there

young walrus Feb 20, 2018, 8:58 PM

#

so it deletes the path before and after like 3 seconds

pearl sentinel Feb 20, 2018, 8:58 PM

#

Yeah, something like that

buoyant wasp Feb 20, 2018, 8:59 PM

#

it'd be interesting though, to see if patterns emerge that we weren't previously aware of

young walrus Feb 20, 2018, 8:59 PM

#

maybe

#

it would be a huge visual tool

#

if only it were allowed during actual runs

ancient nebula Feb 20, 2018, 9:14 PM

#

in blackmoth mod, the shadow attack is supposed to be same dmg as nail?

#

at the start

young walrus Feb 20, 2018, 9:15 PM

#

the shadow attack is your main method of attacking

#

that's what the mod does

ancient nebula Feb 20, 2018, 9:15 PM

#

im asking about damage

#

cause it seems both nail and shadow to 1 dmg each

#

did restart game

#

11 shadow attacks to kill one of starting bugs

young walrus Feb 20, 2018, 9:16 PM

#

that sounds like a bug to me

ancient nebula Feb 20, 2018, 9:16 PM

#

downloaded that one through kerrs mod manager

young walrus Feb 20, 2018, 9:17 PM

#

which version though? the API one? or the non-API one?

#

i think there was a non-api at least and it was ported

ancient nebula Feb 20, 2018, 9:18 PM

#

blackmoth 1.2.0

#

its marked as api mod in kerrs mod organider thing

young walrus Feb 20, 2018, 9:19 PM

#

yeah, looks like he deleted the older one from the drive

#

@solemn rivet

ancient nebula Feb 20, 2018, 9:20 PM

#

im gonna try the manual file insertion see what ill get

#

i think its working?

#

yup, attack damage now works fine
it may be a problem with whatever file kerrs launcher is grabbing and wiring into the game
or coincidence that it worked this time ヽ（´ー｀）┌

pearl sentinel Feb 20, 2018, 9:48 PM

#

Yeah, I need to update the modlinks. I'll do that tonight. If possible I'd like to move that file with the master list of mods to the drive or elsewhere so any mod author may update it

stiff belfry Feb 20, 2018, 9:51 PM

#

is there a mod that makes Salubra's blessing.. not there? like you still get the soul ect but its not so loud and annoying?

buoyant wasp Feb 20, 2018, 9:51 PM

#

probably best to put it in the general drive probably

#

@Oh nope.

#

you either enjoy the love that salubra gives you, or don't get it 😃

ancient nebula Feb 20, 2018, 9:53 PM

#

~~a mod that replaces salubra with quirrel~~

#

~~a mod that replaces everyone with quirrel~~

pearl sentinel Feb 20, 2018, 9:53 PM

#

As soon as modlinks.xml goes up somewhere I'll change the loader to download it on startup

stiff belfry Feb 20, 2018, 9:53 PM

#

welp

pearl sentinel Feb 20, 2018, 9:53 PM

#

(Once I'm home)

young walrus Feb 20, 2018, 9:54 PM

#

to delete the blessing, just delete your game

#

simple

ancient nebula Feb 20, 2018, 9:54 PM

#

xD

thorn comet Feb 20, 2018, 9:57 PM

#

salubra

buoyant wasp Feb 20, 2018, 10:05 PM

#

ah, but what we really need is for both salubra and zote to both give their blessing to you, everywhere

hazy sentinel Feb 20, 2018, 10:05 PM

#

infinite soul

#

sounds good

trim grove Feb 20, 2018, 10:05 PM

#

rip lightbringer?

buoyant wasp Feb 20, 2018, 10:09 PM

#

infinite soul in exchange for having to listen to zote chatter and salubra bless you everywhere all the time

solemn rivet Feb 20, 2018, 10:09 PM

#

kerr, I manually made my own modlinks for the modloader

#

it doesn't include 753's mods

ember shard Feb 20, 2018, 10:09 PM

#

plus you need to read a precept every time you enter a new room

young walrus Feb 20, 2018, 10:10 PM

#

^^

#

THIS

#

lol

solemn rivet Feb 20, 2018, 10:10 PM

#

@ancient nebula could you please tag me if blackmoth stops working? Specifically, if dash stops doing damage

#

latest version I uploaded was supposed to fix that (which is a vanilla bug, so not my fault)

ancient nebula Feb 20, 2018, 10:12 PM

#

alright, rn everythings working fine

solemn rivet Feb 20, 2018, 10:12 PM

#

thanks! happygrub

#

also, thanks KDT for that GetEventSenderHook. That shit's a lifesaver

rustic stag Feb 20, 2018, 10:39 PM

#

Say I find what I'm looking for in FSM Viewer, where do I go from there?

#

📎 unknown.png

buoyant wasp Feb 20, 2018, 10:41 PM

#

you'll have to start the virgin waffle sacrifices

#

but really you'll need to get the gameobject that it's associated with, then get it's FSMs and then set the fields that you want to modify.

#

i know there is an example of that in the nightmare god grimm and bonfire mods

rustic stag Feb 20, 2018, 10:43 PM

#

Okay, well the file I'm viewing is called 'Untagged,Health,Hive Health Regen,5Kl8jA.json'. I assume that 'Health' is the gameobject?

buoyant wasp Feb 20, 2018, 10:44 PM

#

honestly, not sure what arcane methods are used to get the right thing by name. i usually ask @leaden hedge to point me in the right direction when I hate myself and look at FSMs

#

I doubt Health is it

#

because that's too vague

rustic stag Feb 20, 2018, 10:45 PM

#

I saw somewhere somebody explained the what the order of each thing means, but I can't rememver where it's listed.

young walrus Feb 20, 2018, 10:49 PM

#

sounds like hiveblood

rustic stag Feb 20, 2018, 10:50 PM

#

You would be correct

#

Or are you telling me that hiveblood is the name of the gameobject?

young walrus Feb 20, 2018, 10:51 PM

#

oh i have no idea what it's actually called in the game code

#

probably not hiveblood

rustic stag Feb 20, 2018, 10:51 PM

#

Okay haha

#

Was hoping it'd be simple

young walrus Feb 20, 2018, 10:51 PM

#

doubt it

#

the way other things are named

#

example: nail arts

leaden hedge Feb 20, 2018, 11:09 PM

#

its tag, gameobject, fsmname, checksum

#

@rustic stag

rustic stag Feb 20, 2018, 11:10 PM

#

Thank you very much!

solemn rivet Feb 20, 2018, 11:11 PM

#

like wyza said, there's some easy FSM manipulation done in bonfire and blackmoth, and probably some more obscure arts in boss rush

leaden hedge Feb 20, 2018, 11:11 PM

#

you can probably just search for that gameobject whenever a room loads

#

although it wouldn't surprise me if each mask is its own object and you'd have to edit the fsm on each one of them 🤔

#

that sounds like the quality of code the game would have

solemn rivet Feb 20, 2018, 11:14 PM

#

if the gameobject.name really is Health, that sounds actually plausible

leaden hedge Feb 20, 2018, 11:15 PM

#

why isnt this game coded more like celeste FeelsBadMan

#

that games been out a month and we've already got custom levels and mechanics

hollow pier Feb 20, 2018, 11:15 PM

#

celeste > hk

solemn rivet Feb 20, 2018, 11:16 PM

#

heretics, heretics everywhere

rustic stag Feb 20, 2018, 11:17 PM

#

Okay, so let's say I figure out the name and whatnot. How do I actually edit it? dnSpy?

solemn rivet Feb 20, 2018, 11:17 PM

#

well, you can edit in dnspy

#

or you can use API

leaden hedge Feb 20, 2018, 11:17 PM

#

check ngg source code

#

https://github.com/KayDeeTee/HK-NGG/tree/master/src

GitHub

KayDeeTee/HK-NGG

HK-NGG - Nightmare God Grimm

#

pretty much all this does is edit an fsm

solemn rivet Feb 20, 2018, 11:19 PM

#

playMakerFSM = FSMUtility.LocateFSM(go, "health_manager");
FSMUtility.SetInt(playMakerFSM, "HP", (int)((double)FSMUtility.GetInt(playMakerFSM, "HP") * (1.25 + (double)(num / 3)) * (2.5 / (1.0 + Math.Exp(-0.05 * (double)Settings.CurrentLv)))));```

#

this is one instance of FSM edition in bonfire

#

https://github.com/Ayugradow/BonfireMod/blob/master/BonfireMod.cs

GitHub

Ayugradow/BonfireMod

Repository for BonfireMod HK mod

leaden hedge Feb 20, 2018, 11:20 PM

#

now if you want to add more actions to it or states

#

thats a little more complicated

rustic stag Feb 20, 2018, 11:25 PM

#

Welp, I have no idea what any of that mess is.

solemn rivet Feb 20, 2018, 11:30 PM

#

go is an object

#

playMakerFSM = FSMUtility.LocateFSM(go, "health_manager"); this looks for the "health_manager" FSM in the gameobject go

rustic stag Feb 20, 2018, 11:33 PM

#

I meant more so that I don't know how to set up my modding 'environment'. I assume this can all be done in visual studio, but I have no idea how to get it to build a dll or set the dependencies for example.

solemn rivet Feb 20, 2018, 11:34 PM

#

oh

rustic stag Feb 20, 2018, 11:34 PM

#

But that is also helpful infromation, so thank you.

leaden hedge Feb 20, 2018, 11:53 PM

#

you could do it in dnspy but it'd be awkward

#

modding api has a few example mods

#

that you can just load into visual studio

ancient nebula Feb 20, 2018, 11:56 PM

#

in blackmoth, does upgrading nail increase shadow attack?

hollow pier Feb 20, 2018, 11:56 PM

#

no it actually nullifies it completely

ancient nebula Feb 20, 2018, 11:57 PM

#

thank

rapid berry Feb 21, 2018, 12:33 AM

#

hey ive got a glitch i think

#

idk if this is the right place for it

#

but um

#

everytime i try and use mods like i start up and the game

#

and i cant click on any of the menu options

#

like start game or anything

pearl sentinel Feb 21, 2018, 12:35 AM

#

which version of the game?

#

steam/gog?

#

and which mod were you trying

rapid berry Feb 21, 2018, 12:37 AM

#

the GOG version

#

1.2.2.1

pearl sentinel Feb 21, 2018, 12:37 AM

#

which mod?

rapid berry Feb 21, 2018, 12:38 AM

#

and the mods were the debug mod and the modding api

pearl sentinel Feb 21, 2018, 12:38 AM

#

manual installation?

rapid berry Feb 21, 2018, 12:38 AM

#

im using the crossroads installer

pearl sentinel Feb 21, 2018, 12:38 AM

#

oh, that might be a gog bug i have then

#

i hadn't had anyone with gog test it yet

young walrus Feb 21, 2018, 12:38 AM

#

API doesn't work with GOG last i knew

rapid berry Feb 21, 2018, 12:38 AM

#

ah ok

young walrus Feb 21, 2018, 12:38 AM

#

Sean looks like he'll tell us

rain cedar Feb 21, 2018, 12:39 AM

#

The api isn't currently compatible with GOG, but I could compile one for it if you post the full contents of your managed folder here as a zip

#

Fucking mobile, took 3 edits to get that right

pearl sentinel Feb 21, 2018, 12:39 AM

#

i'll add a note to the installer download about that

rapid berry Feb 21, 2018, 12:40 AM

#

strangley enough i did actually get it working once

pearl sentinel Feb 21, 2018, 12:43 AM

#

@buoyant wasp would it be possible to get this file put on the drive somewhere where modders could edit it?

📎 modlinks.xml

#

also, good news on the horrible graphics for the loader. game artist friend at work is gonna make me some UI art. says he has an idea to theme the mod menu after the charm notch screen so i'm excited to see what he comes up with

stiff belfry Feb 21, 2018, 12:47 AM

#

yay

rapid berry Feb 21, 2018, 12:47 AM

#

📎 Managed.rar

#

this folder yeah?

rain cedar Feb 21, 2018, 12:48 AM

#

Yeah

#

That's before attempting to mod it already, right?

pearl sentinel Feb 21, 2018, 12:49 AM

#

if you used the loader, the backup files are in the Backup folder in the hollow knight directory

rapid berry Feb 21, 2018, 12:49 AM

#

yep

pearl sentinel Feb 21, 2018, 12:50 AM

#

(if you need em for some reason)

rain cedar Feb 21, 2018, 12:52 AM

#

📎 Assembly-CSharp.dll

#

Does this work? @rapid berry

rapid berry Feb 21, 2018, 12:52 AM

#

should i replace the current one with that version?

rain cedar Feb 21, 2018, 12:53 AM

#

Yeah

rapid berry Feb 21, 2018, 12:54 AM

#

hmm

#

no same issue

#

this is a really odd problem

#

it was working like

#

perfectly a few days ago

rain cedar Feb 21, 2018, 12:56 AM

#

Is there a modlog.txt file in your save folder?

rapid berry Feb 21, 2018, 12:56 AM

#

lemme check

#

yeah

rain cedar Feb 21, 2018, 12:57 AM

#

Post it here

rapid berry Feb 21, 2018, 12:57 AM

#

aight

#

📎 ModLog.txt

rain cedar Feb 21, 2018, 1:00 AM

#

Alright ModHooks is failing to initialize

#

But it's also not throwing an error

#

Odd problem

rapid berry Feb 21, 2018, 1:01 AM

#

hmm

rain cedar Feb 21, 2018, 1:01 AM

#

I'll just put a try/catch around the entire constructor so we get an error

#

📎 Assembly-CSharp.dll

#

Run this to where it breaks, then post the new log

#

Sorry, don't have the GOG version or I'd be doing testing like this myself

rapid berry Feb 21, 2018, 1:04 AM

#

aight will do

rain cedar Feb 21, 2018, 1:05 AM

#

It might "work" because the exception isn't unhandled anymore but it'll be extremely buggy

rapid berry Feb 21, 2018, 1:06 AM

#

well youre right about it working

#

and the mod section of the menu showed up aswell

rain cedar Feb 21, 2018, 1:08 AM

#

Yeah, but the ModHooks class isn't fully initialized, which is a big issue

rapid berry Feb 21, 2018, 1:09 AM

#

📎 ModLog.txt

#

new modlog thing

buoyant wasp Feb 21, 2018, 1:09 AM

#

oh, weird

#

why would it do that...

#

go into your saves folder

#

if there is a file that is called Modhooks.GlobalSettings.json or some such, delete it

#

or ModdingApi.GlobalSettings.json i can't remember it's name offhand

rapid berry Feb 21, 2018, 1:10 AM

#

theres a moddingapi one, a debugmod one and a bak of the moddingapi one

#

ill delete them now

rain cedar Feb 21, 2018, 1:11 AM

#

Debug one should be fine to keep

buoyant wasp Feb 21, 2018, 1:11 AM

#

yeah, somehow that got created, but with nothing in it

rapid berry Feb 21, 2018, 1:11 AM

#

aight deleted

rain cedar Feb 21, 2018, 1:11 AM

#

Guess we should add exception handling in LoadGlobalSettings for this case

#

I'll do that now

copper nacelle Feb 21, 2018, 1:11 AM

#

someone else earlier also got a Modhooks.GlobalSettings.json that was empty

#

and it also broke it

#

it was a while ago

rain cedar Feb 21, 2018, 1:16 AM

#

@rapid berry This should be a working version, even with a broken settings file

📎 Assembly-CSharp.dll

pearl sentinel Feb 21, 2018, 1:18 AM

#

Just added support for alternate GOG mod links to the downloader, i'll upload the new version as soon as you're done with that and have a drive link for it

rain cedar Feb 21, 2018, 1:18 AM

#

Alright, just pushing to github first

rapid berry Feb 21, 2018, 1:18 AM

#

yeah game seems to be working

pearl sentinel Feb 21, 2018, 1:18 AM

#

usedNice

rapid berry Feb 21, 2018, 1:19 AM

#

so is that the modding api installed?

#

like is that all setup now

rain cedar Feb 21, 2018, 1:19 AM

#

Yeah you should be good

buoyant wasp Feb 21, 2018, 1:19 AM

#

assuming you have versions in the upper left hand corner, yes

rapid berry Feb 21, 2018, 1:19 AM

#

big thanks

#

very helpful and much appreciated

rain cedar Feb 21, 2018, 1:20 AM

#

Oh, the linux api isn't on the drive yet either

#

@copper nacelle or @buoyant wasp Could you build/upload that? I'm not running linux

copper nacelle Feb 21, 2018, 1:23 AM

#

📎 Assembly-CSharp.dll

rain cedar Feb 21, 2018, 1:24 AM

#

Could you upload the xml too in case anyone wants to do modding work on linux?

buoyant wasp Feb 21, 2018, 1:24 AM

#

should be the same

solemn rivet Feb 21, 2018, 1:24 AM

#

@ancient nebula what oof said was wrong - dash damage does scale with nail upgrades

rain cedar Feb 21, 2018, 1:25 AM

#

Alright, I'll just steal the xml I have for the gog one then

ancient nebula Feb 21, 2018, 1:26 AM

#

-runs to nailmaster-

#

👌 thank

solemn rivet Feb 21, 2018, 1:26 AM

#

wait, I thought that ever since CP02 drm-free version and steam .dll were the same

#

np!

buoyant wasp Feb 21, 2018, 1:26 AM

#

they are close, but not quite

ancient nebula Feb 21, 2018, 1:26 AM

#

thats one hell of a sexy hand reaction

buoyant wasp Feb 21, 2018, 1:26 AM

#

at least, so it seems

solemn rivet Feb 21, 2018, 1:27 AM

#

iirc there was a new class that was supposed to handle versions

rain cedar Feb 21, 2018, 1:27 AM

#

They're always gonna be slightly different if only just because of Steam achievements

solemn rivet Feb 21, 2018, 1:27 AM

#

just a sec

rain cedar Feb 21, 2018, 1:27 AM

#

Unless that code is in gog, but unused

solemn rivet Feb 21, 2018, 1:28 AM

#

I'll just check it in dnspy real quick

#

I thought this was supposed to handle both versions

📎 AchievementHandler.cs

#

private void Start()
    {
        this.gm = GameManager.instance;
        if (this.gm.gameConfig.steamEnabled)
        {
            this.steamEnabled = true;
            this.steamIntegrator = this.gm.steamIntegrator;
        }
        if (this.gm.gameConfig.galaxyEnabled)
        {
            this.gogEnabled = true;
            this.gogIntegrator = this.gm.gogIntegrator;
        }
    }```

rain cedar Feb 21, 2018, 1:30 AM

#

the config might be hard coded and not determined at startup

#

So the actual code is the same, they just have to change one thing

solemn rivet Feb 21, 2018, 1:31 AM

#

gotcha

rain cedar Feb 21, 2018, 1:32 AM

#

Lol yeah this is their GameConfig "script"

📎 unknown.png

#

They're totally just setting these all in editor

#

Actually they've got error checking on this, achievements wouldn't be the problem

📎 unknown.png

#

Oh shit hahaha

#

📎 unknown.png

#

Unity strikes again, they're trying to use null coalescence

#

No wonder this breaks

copper nacelle Feb 21, 2018, 1:37 AM

#

lmao

buoyant wasp Feb 21, 2018, 1:38 AM

#

lul

pearl sentinel Feb 21, 2018, 1:39 AM

#

pfft

#

amazing

rain cedar Feb 21, 2018, 1:40 AM

#

One of the key features I look for in game engines is breaking basic features of the coding language

#

Nobody does it better than Unity

buoyant wasp Feb 21, 2018, 1:42 AM

#

i still can't believe they broke null coelescence so messed up

rain cedar Feb 21, 2018, 1:43 AM

#

It's understandable

#

I mean they wanted to store values in null variables

#

Makes perfect sense to me

trim grove Feb 21, 2018, 1:44 AM

#

thinkgrub

buoyant wasp Feb 21, 2018, 1:45 AM

#

you know, as opposed to....treating nulls or pointers to nulls the way you should have

trim grove Feb 21, 2018, 1:46 AM

#

dont check for nulls ever and hope for the best?

rain cedar Feb 21, 2018, 1:46 AM

#

Really this is Microsoft's fault for not letting every operator be overridden

#

The thing is almost every way to check for null works

#

Because they've overridden the operators

#

Just stuff like ?? and null == object won't work

copper nacelle Feb 21, 2018, 1:48 AM

#

didn't they override ==?

rain cedar Feb 21, 2018, 1:49 AM

#

They did, but with how c# works putting null first will not use the overridden one

#

I think

#

object == null should work fine

copper nacelle Feb 21, 2018, 1:49 AM

#

wtf

trim grove Feb 21, 2018, 1:49 AM

#

why would you check if null == something... that seems... backwards

buoyant wasp Feb 21, 2018, 1:49 AM

#

but it makes it so this ?? that won't work

rain cedar Feb 21, 2018, 1:49 AM

#

It is backwards from conventions, but it should be fine

#

Only it isn't

#

I guess I can make a small script to test how overriding works in this scenario

trim grove Feb 21, 2018, 1:50 AM

#

override the override thinkgrub

copper nacelle Feb 21, 2018, 1:51 AM

#

override the override so that it flips them when null is first

rain cedar Feb 21, 2018, 1:58 AM

#

Alright I was wrong about how c# works

#

I am pretty sure that with two non-null objects it will choose the overload from the one that's put first

#

But I guess that doesn't apply to null

copper nacelle Feb 21, 2018, 1:58 AM

#

~~overload null~~

#

📎 DeepinScreenshot_select-area_20180220205914.png

rain cedar Feb 21, 2018, 1:59 AM

#

As a side note this is awful and I felt dirty writing it https://pastebin.com/kRGjGeKt

copper nacelle Feb 21, 2018, 1:59 AM

#

lmao

#

side-note

#

on that answer

#

one comment was

#

I knew there had to be an easy answer!

rain cedar Feb 21, 2018, 2:00 AM

#

But what if I also want to override the Equals function?

copper nacelle Feb 21, 2018, 2:00 AM

#

then you feel depressed

hollow pier Feb 21, 2018, 2:01 AM

#

notequals

copper nacelle Feb 21, 2018, 2:01 AM

#

why is there no = react

#

life ruined

rain cedar Feb 21, 2018, 2:01 AM

#

That's the closest I can find

hollow pier Feb 21, 2018, 2:01 AM

#

close enough

copper nacelle Feb 21, 2018, 2:02 AM

#

nice

rain cedar Feb 21, 2018, 2:02 AM

#

♒

#

Maybe better idk

solemn rivet Feb 21, 2018, 2:02 AM

#

vertical equals

hollow pier Feb 21, 2018, 2:02 AM

#

⏸ but not

rain cedar Feb 21, 2018, 2:03 AM

#

⏸ ⤵

#

Perfect

hollow pier Feb 21, 2018, 2:03 AM

#

⏸ ⤴

#

no

rain cedar Feb 21, 2018, 2:03 AM

#

But it's symmetrical

#

That's the same thing

hazy sentinel Feb 21, 2018, 2:03 AM

#

not in unicode's eyes

#

also "symettrical"

hollow pier Feb 21, 2018, 2:03 AM

#

⏸ ⤴ 🔁 ⤵ 🔄 ⤴

#

bada bing

rain cedar Feb 21, 2018, 2:03 AM

#

Fuck you I spelled it right

hazy sentinel Feb 21, 2018, 2:04 AM

#

📎 ok.png

hollow pier Feb 21, 2018, 2:04 AM

#

you did indeed spell "it" correctly

solemn rivet Feb 21, 2018, 3:23 AM

#

fixed soul not recharging when hitting an enemy. Should also permanently fix broken damage for dash

📎 Blackmoth.dll

copper nacelle Feb 21, 2018, 3:25 AM

#

nice

solemn rivet Feb 21, 2018, 3:27 AM

#

I literally did 'subtract this much from enemy hp'

#

Inb4 underflow

copper nacelle Feb 21, 2018, 3:28 AM

#

nice

#

lmao

solemn rivet Feb 21, 2018, 3:28 AM

#

Shouldn't break tho

#

Damage cap is vanilla nail damage cap

#

21

#

Actually, 42 with sharp shadow... 63 with fstrength

copper nacelle Feb 21, 2018, 3:29 AM

#

w/ fury?

solemn rivet Feb 21, 2018, 3:29 AM

#

Fury is 1.5x?

copper nacelle Feb 21, 2018, 3:30 AM

#

thought it was 1.75x

solemn rivet Feb 21, 2018, 3:30 AM

#

I always forget

#

So...

#

Still less than 126

#

No underflow

#

Phew

copper nacelle Feb 21, 2018, 3:31 AM

#

lmao

solemn rivet Feb 21, 2018, 2:23 PM

#

also, can someone test if I haven't broken anything with the latest version of the mod installer?

#

📎 ModInstaller.exe

leaden hedge Feb 21, 2018, 3:07 PM

#

fury is 1.75

ember shard Feb 21, 2018, 3:10 PM

#

I can't hit the Collector in Boss Rush anymore. Fought him twice, and both times, he just stopped taking damage at some point

leaden hedge Feb 21, 2018, 3:10 PM

#

did you have summons

ember shard Feb 21, 2018, 3:11 PM

#

the dreamshield and baby grimm

solemn rivet Feb 21, 2018, 3:18 PM

#

it's a known vanilla bug

leaden hedge Feb 21, 2018, 3:24 PM

#

its apparently fixed in cp3 patch

#

so im not gonna fix it on my end

solemn rivet Feb 21, 2018, 3:24 PM

#

do you know the cause?

leaden hedge Feb 21, 2018, 3:27 PM

#

dunno what the cause is

#

but the fix shouldnt be too hard

#

just replace the transition to the 15 hit death state with the actually for real dead state

solemn rivet Feb 21, 2018, 3:29 PM

#

makes sense

ember shard Feb 21, 2018, 3:30 PM

#

oh, I didn't know that was in vanilla, thanks for the info

solemn rivet Feb 21, 2018, 3:30 PM

#

just avoid doing indirect damage to it

pearl sentinel Feb 21, 2018, 3:45 PM

#

Yeah I ran into it when trying out the weaver charm on him. Pretty annoying

solemn rivet Feb 21, 2018, 4:18 PM

#

kerr, how's the enemy rando?

#

grimm

young walrus Feb 21, 2018, 4:18 PM

#

kerr, how's the tracking mod?

solemn rivet Feb 21, 2018, 4:19 PM

#

kerr, how's life?

pearl sentinel Feb 21, 2018, 4:23 PM

#

Lol. Wife was sick this morning, but they're coming along. Fixed up some bugs in rando and got started on the tracking. Got caught up trying to find a way to record all the controller inputs since there's no way to get the list of bound controller buttons, but hollow knight uses a 3rd party controller plug in that I need to investigate atill, so there's still hope.

#

For the tracker, I got a lot of other data in so far, like 10 different kinds of timestamps and frame recordings and the position.

solemn rivet Feb 21, 2018, 4:28 PM

#

nice

#

can I help in some/any way?

pearl sentinel Feb 21, 2018, 4:28 PM

#

For enemy rando I had a few enemies missing from the loading step, like menderbug, so I figured that out and now he'll be randomly showing up I think

#

I'll try to get the tracker on a repo soon and then sure

young walrus Feb 21, 2018, 4:30 PM

#

oh man. every enemy is menderbug

pearl sentinel Feb 21, 2018, 4:31 PM

#

Once some options are added you could do that. Could also make every enemy nosk.

young walrus Feb 21, 2018, 4:31 PM

#

lol

pearl sentinel Feb 21, 2018, 4:32 PM

#

Actually, gradow, dp you have things setup to look at fsms already?

#

Do*

#

So, when you engage the crystal guardian, something triggers the player's camera to move away to a fixed point I'm wondering if it would be possible to tell the family to leave that state or whatever

#

If I can't figure that out he'll have to be disabled for randoming

#

Fsm, not family. Thx phone

young walrus Feb 21, 2018, 4:36 PM

#

i don't know what needed correcting

#

i tell my family to leave the state every time I see CG too

pearl sentinel Feb 21, 2018, 4:37 PM

#

That should be a zote precept.

#

Omg. You know how some randomizers replace certain text, I should look into replacing all text with random zote precepts

#

Or maybe just shop text

leaden hedge Feb 21, 2018, 4:44 PM

#

pretty sure thats just a thing on the camera class

#

it has a focus target

#

I guess you could go find it in CG fsms

pearl sentinel Feb 21, 2018, 5:04 PM

#

If that's all then fixing it would be easy

buoyant wasp Feb 21, 2018, 6:00 PM

#

@pearl sentinel - that XML is up on the drive now. Any of the mod owners should be able to edit it as needed.

pearl sentinel Feb 21, 2018, 6:38 PM

#

Cool, may I edit it as well?

#

Thanks a bunch :)

pearl sentinel Feb 21, 2018, 6:58 PM

#

@buoyant wasp

buoyant wasp Feb 21, 2018, 6:58 PM

#

get @dapper folio to add you

#

if he hasn't already

dapper folio Feb 21, 2018, 7:00 PM

#

Anyone with editing priveleges may add more people iirc

#

simply pm myself or an online modder with privileges and let us know what email you want added

buoyant wasp Feb 21, 2018, 7:17 PM

#

@pearl sentinel ^

pearl sentinel Feb 21, 2018, 7:18 PM

#

Just did that

#

Got access now. Thanks guys!

#

usedNice

dapper folio Feb 21, 2018, 7:20 PM

#

salubra

pearl sentinel Feb 21, 2018, 7:23 PM

#

Oh, just talked to game artist friend, he was wondering if anyone had physically extracted any hollow knight sprites, in particular the UI elements. Even just the packed sprite sheets would be fine he says, so he could use them on the mod loafer UI

#

Er, loader

buoyant wasp Feb 21, 2018, 7:24 PM

#

yeah, multiple times

#

searching from:KDT has:file will probably get you what you want

#

lots of spritesheets have been posted

#

depending on what you need, i have a bunch of the charms, items, abilities, etc extracted separately already too

pearl sentinel Feb 21, 2018, 7:29 PM

#

Awesome, I'll browse around. Thanks!

solemn rivet Feb 21, 2018, 7:33 PM

#

you can also extract them yourself using UABE

leaden hedge Feb 21, 2018, 8:02 PM

#

pretty sure I've dumped ui before

#

you could probably check from kdt to wyza has file

rustic stag Feb 21, 2018, 8:55 PM

#

I'm trying to change how much geo enemies drop. So far this is what I have, but it's not working. Can anybody point out what's wrong/missing?

#

📎 unknown.png

buoyant wasp Feb 21, 2018, 9:04 PM

#

look at the bonfire mod, it changes those values

solemn rivet Feb 21, 2018, 9:25 PM

#

I was the one who game him that code

#

for some reason, the SceneChangedHook is not getting called

#

se that Log("Updated geo"); there? It's not appearing at all in the log

buoyant wasp Feb 21, 2018, 9:26 PM

#

is the hook getting added?

solemn rivet Feb 21, 2018, 9:26 PM

#

dunno, didn't look at the log

#

is it @rustic stag ?

buoyant wasp Feb 21, 2018, 9:27 PM

#

yeah, if the log is set to debug level, it'll show all places where every mod is adding the hook

#

which is the default, so it should show up there

rustic stag Feb 21, 2018, 9:27 PM

#

Oh son of a bitch. So I checked the log after quitting to menu. It wasn't there. It doesn't add it to the file until the game is closed.

#

It's there now...

solemn rivet Feb 21, 2018, 9:28 PM

#

you using notepad?

rustic stag Feb 21, 2018, 9:28 PM

#

Yes.

solemn rivet Feb 21, 2018, 9:28 PM

#

that explains it

buoyant wasp Feb 21, 2018, 9:28 PM

#

yeah, notepad doesn't update in real time

solemn rivet Feb 21, 2018, 9:28 PM

#

so it should be working then

buoyant wasp Feb 21, 2018, 9:28 PM

#

the log file does though

#

you can also just turn on the on screen console

#

which sends all the logs to the screen too

rustic stag Feb 21, 2018, 9:28 PM

#

What is the key for that?

#

tilde?

solemn rivet Feb 21, 2018, 9:29 PM

#

do it like this: set it to print the dropped geo before and after the command

buoyant wasp Feb 21, 2018, 9:29 PM

#

you have to enable it in the global settings file for the api

#

in your saves folder

#

I don't have the exact name in front of me

solemn rivet Feb 21, 2018, 9:30 PM

#

if (playMakerFSM != null)
                {
                    Log($@"Geo before edit:{playMakerFSM.FsmVariables.GetFsmInt("Geo Small").Value}");
                    playMakerFSM.FsmVariables.GetFsmInt("Geo Small").Value *= 2;
                    Log($@"Geo after edit:{playMakerFSM.FsmVariables.GetFsmInt("Geo Small").Value}");
                    playMakerFSM.FsmVariables.GetFsmInt("Geo Small Extra").Value *= 2;
                    playMakerFSM.FsmVariables.GetFsmInt("Geo Medium").Value *= 2;
                    playMakerFSM.FsmVariables.GetFsmInt("Geo Med Extra").Value *= 2;
                    playMakerFSM.FsmVariables.GetFsmInt("Geo Large").Value *= 2;
                    playMakerFSM.FsmVariables.GetFsmInt("Geo Large Extra").Value *= 2;
                }```

#

see if these values are the same

#

and use notepad++

#

it updates in real-time

rustic stag Feb 21, 2018, 9:32 PM

#

Would Sublime Text work as well?

#

It updates real-time

solemn rivet Feb 21, 2018, 9:32 PM

#

dunno, never used it

#

sure

#

anything that updates rt

buoyant wasp Feb 21, 2018, 9:33 PM

#

yeah you can use that or NP++ or VS Code or w/e. the onscreen console works pretty well though 😃 (once you enable it in the settings file you can toggle it on/off with F10)

solemn rivet Feb 21, 2018, 9:33 PM

#

wyza: counldn't find that option in the api settings

buoyant wasp Feb 21, 2018, 9:33 PM

#

hmm

solemn rivet Feb 21, 2018, 9:33 PM

#

    "StringValues": {
        "keys": [],
        "values": []
    },
    "IntValues": {
        "keys": [
            "LoggingLevel"
        ],
        "values": [
            2
        ]
    },
    "BoolValues": {
        "keys": [],
        "values": []
    },
    "FloatValues": {
        "keys": [],
        "values": []
    },
    "ModEnabledSettings": {
        "keys": [
            "Blackmoth"
        ],
        "values": [
            1
        ]
    }
}```

buoyant wasp Feb 21, 2018, 9:34 PM

#

weird

#

you can add

#

ShowDebugLogInGame to bool values

#

so

#

"BoolValues": {
        "keys": ["ShowDebugLogInGame"],
        "values": ["true"]
    },

#

should work i think

#

if it doesn't i can look when i get home

rustic stag Feb 21, 2018, 9:35 PM

#

Mod log works!
[INFO]:[HK_TestMod] - Geo before edit:3
[INFO]:[HK_TestMod] - Geo after edit:6
[INFO]:[HK_TestMod] - Geo before edit:3
[INFO]:[HK_TestMod] - Geo after edit:6
[INFO]:[HK_TestMod] - Geo before edit:2
[INFO]:[HK_TestMod] - Geo after edit:4
[INFO]:[HK_TestMod] - Geo before edit:2
[INFO]:[HK_TestMod] - Geo after edit:4

solemn rivet Feb 21, 2018, 9:35 PM

#

so it is working

#

nothing to do

buoyant wasp Feb 21, 2018, 9:39 PM

#

hmm

solemn rivet Feb 21, 2018, 9:39 PM

#

wait

#

nvm

buoyant wasp Feb 21, 2018, 9:39 PM

#

wonder if it's true/false without the quotes

solemn rivet Feb 21, 2018, 9:39 PM

#

I had it set to true instead of "true"

#

still breaks tho

buoyant wasp Feb 21, 2018, 9:40 PM

#

eh, it's probably serializing it to something else

#

maybe 0 or 1 or something

solemn rivet Feb 21, 2018, 9:40 PM

#

will try some variations

#

brb

#

gr8 it works

#

quotes on both, just as you said

#

eh, but f10 does nothing

buoyant wasp Feb 21, 2018, 9:46 PM

#

debug mod installed? i think it can map to the same key and overwrite it.

solemn rivet Feb 21, 2018, 9:47 PM

#

nope, only blackmoth

buoyant wasp Feb 21, 2018, 9:47 PM

#

public void Update()
        {
            if (Input.GetKeyDown(KeyCode.F10))
            {
                StartCoroutine(_enabled
                    ? CanvasUtil.FadeOutCanvasGroup(OverlayCanvas.GetComponent<CanvasGroup>())
                    : CanvasUtil.FadeInCanvasGroup(OverlayCanvas.GetComponent<CanvasGroup>()));
                _enabled = !_enabled;
            }
        }

#

weird

solemn rivet Feb 21, 2018, 9:47 PM

#

also, which version of the API is this supposed to work on?

#

I'm using -34, the one on the drive

buoyant wasp Feb 21, 2018, 9:47 PM

#

pretty sure -34 has it

solemn rivet Feb 21, 2018, 9:47 PM

#

but I know there are more recent versions in here

#

I'll open it in dnspy just in case

buoyant wasp Feb 21, 2018, 9:48 PM

#

yeah, it's 34

#

i know it works :/ cause @copper nacelle used it

#

at least, i'm pretty sure he's the one who asked for it in the first place

solemn rivet Feb 21, 2018, 9:51 PM

#

yeah, it's there alright

#

just checked

#

weird...

#

wait, when I opened the game it changed the value to 0

#

manually changed it to 1 and it works

#

that's... Strange, cause I had set it to "true" before running

buoyant wasp Feb 21, 2018, 9:53 PM

#

well, it could be that any value other than 1 is false and "true" isn't parsed into true

#

it's unity's garbage serializer

#

which is why we have this hack of a method to store stuff

solemn rivet Feb 21, 2018, 9:53 PM

#

noot

#

isn't there anyway to bypass unity's serializer?

buoyant wasp Feb 21, 2018, 9:54 PM

#

only if you want to ship your own

#

cause it's .net 3.5 which doesn't have a json serializer built in

#

so you'd have to include one. plus we had to deal with it regardless because the save files use the built in one

#

so if i have to deal with stupid storage for that, might as well just be consistent in the pain

solemn rivet Feb 21, 2018, 9:56 PM

#

no thank you

buoyant wasp Feb 21, 2018, 9:57 PM

#

but yeah. Unity is like "Hey we have this super fast serializer/deserizer. It's 10x faster than the competition." It's fast, it's true, but then it goes on to say "but it basically doesn't support any complex data structures or even simple ones like dictionaries".

#

given the size of the data that is being serialized, taking 3ms vs 10-30ms to save is not worth it

#

but oh well, that's unity for you

leaden hedge Feb 21, 2018, 10:49 PM

#

you think I have .05 seconds to wait for my game to save 😡

#

at most I have 0.005 seconds 😡

trim grove Feb 21, 2018, 10:49 PM

#

look at mr spare time over here

exotic venture Feb 21, 2018, 10:59 PM

#

probably one of those guys with like a super quantum ssd that reads and writes at 1000000 tb/s and boots up at femtosecond speeds

copper nacelle Feb 21, 2018, 11:21 PM

#

wait what did I do/ask for or whatever

#

the on screen mod log thing?

buoyant wasp Feb 22, 2018, 12:22 AM

#

i think so

pearl sentinel Feb 22, 2018, 12:42 AM

#

Updated mod loader (pin also updated):

Now supports downloading with separate links for GOG specific mods.
modlinks.xml mod database source has been moved to the #archived-modding-development drive so updates to the mod download paths (for new versions or new mods) will not require a new release of Crossroads.
The default steam directory will now be automatically searched for your Hollow Knight install (in addition to alternate steam library folders that were already searched) to make the setup process easier.

https://github.com/Kerr1291/Crossroads/releases/download/v00.31/Crossroads_v.31.zip

solemn rivet Feb 22, 2018, 1:14 AM

#

nice!

#

my installer is pretty much where I want it to be

copper nacelle Feb 22, 2018, 1:15 AM

#

you added the url stuff?

solemn rivet Feb 22, 2018, 1:16 AM

#

yup

#

it downloads and installs API mods and the API itself

copper nacelle Feb 22, 2018, 1:16 AM

#

nice

solemn rivet Feb 22, 2018, 1:16 AM

#

if you want to give it a spin

📎 ModInstaller.exe

copper nacelle Feb 22, 2018, 1:17 AM

#

📎 unknown.png

solemn rivet Feb 22, 2018, 1:17 AM

#

kek

#

use right checkboxes to install

#

and left ones to enable/disable

copper nacelle Feb 22, 2018, 1:17 AM

#

fuck

📎 unknown.png

#

also this one idk

📎 unknown.png

solemn rivet Feb 22, 2018, 1:18 AM

#

ffs

#

worked fine for me

#

with debug as well

#

📎 unknown.png

copper nacelle Feb 22, 2018, 1:19 AM

#

A H H H

📎 unknown.png

solemn rivet Feb 22, 2018, 1:19 AM

#

WTF ARE YOU DOING

copper nacelle Feb 22, 2018, 1:19 AM

#

happened when two at once

📎 unknown.png

solemn rivet Feb 22, 2018, 1:19 AM

#

I don't even

#

sigh

buoyant obsidian Feb 22, 2018, 1:19 AM

#

your first issue is

copper nacelle Feb 22, 2018, 1:19 AM

#

actual mods at the end

📎 unknown.png

buoyant obsidian Feb 22, 2018, 1:20 AM

#

that's Terraria not hollow knight

solemn rivet Feb 22, 2018, 1:20 AM

#

I have NO idea how that happened

#

I mean

vagrant leaf Feb 22, 2018, 1:20 AM

#

please fix

solemn rivet Feb 22, 2018, 1:20 AM

#

literally

#

NO IDEA

copper nacelle Feb 22, 2018, 1:20 AM

#

lmfao

solemn rivet Feb 22, 2018, 1:20 AM

#

holy fuck

#

that's amazing

copper nacelle Feb 22, 2018, 1:20 AM

#

?

solemn rivet Feb 22, 2018, 1:20 AM

#

you always break it so fast

#

I have no idea how

copper nacelle Feb 22, 2018, 1:21 AM

#

¯_(ツ)_/¯

#

master of bugs

solemn rivet Feb 22, 2018, 1:21 AM

#

bnugs is right

#

I assume those weird files are not inside your Mods folder, right?

copper nacelle Feb 22, 2018, 1:22 AM

#

wtf

#

they are now

#

they weren't before

#

📎 unknown.png

vagrant leaf Feb 22, 2018, 1:23 AM

#

📎 unknown.png

solemn rivet Feb 22, 2018, 1:23 AM

#

do you have any idea what those are?

#

I'll try setting my install path the same as yours, see what happens

copper nacelle Feb 22, 2018, 1:24 AM

#

no clue

solemn rivet Feb 22, 2018, 1:26 AM

#

it literally checks only the Mods and Disabled folder to fill that list

#

I just googled it. Those .dlls belong under system32

#

Gradow is a hacker confirmed

copper nacelle Feb 22, 2018, 1:27 AM

#

lmao

solemn rivet Feb 22, 2018, 1:27 AM

#

please delete your system32 folders

#

HOW

copper nacelle Feb 22, 2018, 1:28 AM

#

¯_(ツ)_/¯

solemn rivet Feb 22, 2018, 1:28 AM

#

I'll make a version that shows a message box for each dll added

#

with the dll path

copper nacelle Feb 22, 2018, 1:28 AM

#

lmao

#

should I delete the weird dlls

solemn rivet Feb 22, 2018, 1:30 AM

#

private void PopulateCheckBox(CheckedListBox modlist, CheckedListBox installList, string Folder, string FileType)
        {
            DirectoryInfo dinfo = new DirectoryInfo(path: Folder);
            FileInfo[] Files = dinfo.GetFiles(searchPattern: FileType);
            foreach (FileInfo file in Files)
            {
                if (!installedMods.Contains(item: file.Name))
                {
                    modlist.Items.Add(item: Path.GetFileNameWithoutExtension(file.Name));
                    installedMods.Add(item: file.Name);
                    installList.Items.Add("Installed");
                }
                else
                    File.Delete(path: Folder + $@"/{file.Name}");
            }
        }```

#

has your pc exploded yet?

copper nacelle Feb 22, 2018, 1:30 AM

#

not yet

solemn rivet Feb 22, 2018, 1:30 AM

#

then, maybe

copper nacelle Feb 22, 2018, 1:30 AM

#

I renamed the folder to uhhh

#

just in case

solemn rivet Feb 22, 2018, 1:30 AM

#

kek

copper nacelle Feb 22, 2018, 1:30 AM

#

wait does the installer check for a mods dir

solemn rivet Feb 22, 2018, 1:30 AM

#

it does

copper nacelle Feb 22, 2018, 1:30 AM

#

📎 unknown.png

#

buggo

solemn rivet Feb 22, 2018, 1:31 AM

#

and it doesn't create one- ohhhh

#

shit

#

it's probably finding every dll under c or d

#

@copper nacelle see if this fixes it

📎 ModInstaller.exe

copper nacelle Feb 22, 2018, 1:38 AM

#

no mods folder error

#

but

#

📎 unknown.png

#

and if I try it again

#

📎 unknown.png

#

and then if I try a diff mod afterwards

#

📎 unknown.png

#

@solemn rivet which leads to the great error

📎 unknown.png

solemn rivet Feb 22, 2018, 1:39 AM

#

I see...

#

it's trying to install stuff, but for some reason, it's unable

#

mine works fine btw

#

📎 unknown.png

copper nacelle Feb 22, 2018, 1:40 AM

#

¯_(ツ)_/¯

solemn rivet Feb 22, 2018, 1:40 AM

#

📎 unknown.png

#

just installed HPBar

#

at which point does that happen, 56?

#

after the install confirmation screen?

#

this one

📎 unknown.png

#

eh, revealed my language

#

reee

copper nacelle Feb 22, 2018, 1:43 AM

#

uh

#

after clicking yes

solemn rivet Feb 22, 2018, 1:45 AM

#

ok

#

can you delete those useless dlls and run this?

📎 ModInstaller.exe

#

this should give you progressive message boxes

#

so we can figure out where it breaks

copper nacelle Feb 22, 2018, 1:47 AM

#

alright

#

downloading

#

installing

#

error

solemn rivet Feb 22, 2018, 1:48 AM

#

got it

copper nacelle Feb 22, 2018, 1:48 AM

#

📎 unknown.png

solemn rivet Feb 22, 2018, 1:48 AM

#

so it breaks during installation

#

can you delete that temp folder and try again, please?

copper nacelle Feb 22, 2018, 1:49 AM

#

also new error

#

📎 unknown.png

solemn rivet Feb 22, 2018, 1:49 AM

#

that's the first error

#

when does this happen?

copper nacelle Feb 22, 2018, 1:49 AM

#

was just checking not installed on a bunch of mods

#

most gave already exists

#

happens after "installing"

solemn rivet Feb 22, 2018, 1:50 AM

#

did you delete the temp folder?

copper nacelle Feb 22, 2018, 1:50 AM

#

after deleting stuff everything gives the being used

#

thingy

#

wait

#

wtf

#

@solemn rivet ¯_(ツ)_/¯

📎 unknown.png

solemn rivet Feb 22, 2018, 1:52 AM

#

sigh

copper nacelle Feb 22, 2018, 1:52 AM

#

reopened the window and

#

babam

solemn rivet Feb 22, 2018, 1:52 AM

#

I'm... sorry for all that

#

it's breaking something and I have no idea what

#

because even after mirroring your configs, it doesn't happen to me

copper nacelle Feb 22, 2018, 1:53 AM

#

slightly different error when trying to install now

📎 unknown.png

#

also it's fine

#

@solemn rivet wait it works

#

it gives all those dlls and "fails"

#

but after reopening the window

#

the mod is installed

solemn rivet Feb 22, 2018, 1:55 AM

#

it is

#

it's breaking on cleanup

#

also, love that error

#

you literally have no clue what is wrong

#

so useful

copper nacelle Feb 22, 2018, 1:55 AM

#

lol

#

successful installation tho

📎 unknown.png

#

and the directorys in temp are also gone

#

so after installing it says the being used thing

#

I reload the window

#

and the mod is installed

#

wait wtf

#

it also has this in temp now

📎 unknown.png

solemn rivet Feb 22, 2018, 1:58 AM

#

yeah

#

for some reason it's note deleting both temp and the zips

#

this is more verbose

📎 ModInstaller.exe

rain cedar Feb 22, 2018, 2:02 AM

#

Inb4 errors

copper nacelle Feb 22, 2018, 2:03 AM

#

deleting when installer is open still breaks

📎 unknown.png

#

no dlls found or something

#

copying D:\temps....\hellmod.dll

#

and rando which was already there

#

and then the good ol cannot access because it is being used

#

and I reloaded window

#

and mods are installed

#

no weird files

#

¯_(ツ)_/¯

solemn rivet Feb 22, 2018, 2:05 AM

#

so it's breaking right before deleting the folder

#

I assume there's leftover stuff inside temp?

#

did it copy any txts or something?

copper nacelle Feb 22, 2018, 2:06 AM

#

README.txt for debug i think

#

debug always fails with readme already in temp

#

readme for rando apparently

#

is in Mods

solemn rivet Feb 22, 2018, 2:07 AM

#

eh

#

not in Hollow Knight?

copper nacelle Feb 22, 2018, 2:07 AM

#

there's a readme folder there

#

with a shit load of readmes

#

and by shit load I mean 3 folders

#

with each having 1

solemn rivet Feb 22, 2018, 2:07 AM

#

no, that's kerr's

#

mine's like this:

#

📎 unknown.png

#

worse, but meh

copper nacelle Feb 22, 2018, 2:08 AM

#

none of those

#

rip

solemn rivet Feb 22, 2018, 2:08 AM

#

hm...

#

so that's where it's breaking - when copying random files laying around

#

and that stops the delete from going off

copper nacelle Feb 22, 2018, 2:08 AM

#

I can't get the error with the 500 dlls ree

#

did you fix it?

solemn rivet Feb 22, 2018, 2:09 AM

#

well, I did nothing to fix it tbh

#

can you delete settings and try again?

copper nacelle Feb 22, 2018, 2:10 AM

#

the one in Local?

solemn rivet Feb 22, 2018, 2:10 AM

#

ye

#

just to be safe

#

maybe it's something with the paths...

copper nacelle Feb 22, 2018, 2:11 AM

#

it's trying to copy a bunch of old ones

#

like I tried to install idk bossrush?

#

and it also copied blackmoth

#

and charm notch

#

rip system32 error tho

solemn rivet Feb 22, 2018, 2:12 AM

#

also

#

I think for some reason yours might be case-sensitive on paths

#

because it said it could not find Mods, when you literally just showed me the folder

copper nacelle Feb 22, 2018, 2:13 AM

#

weird

#

it's ntfs too

#

and it doesn't care about case in explorer too

solemn rivet Feb 22, 2018, 2:15 AM

#

📎 2018-02-21_23-14-21.gif

#

how it's supposed to be

rain cedar Feb 22, 2018, 2:16 AM

#

Why are you taking the time to drag literally every popup window towards the center?

copper nacelle Feb 22, 2018, 2:16 AM

#

D:\temp\README.txt already exists

#

for some of them

#

before anything else

#

after hitting yes

solemn rivet Feb 22, 2018, 2:16 AM

#

because I was not sure it was centered right

copper nacelle Feb 22, 2018, 2:16 AM

#

for others:
Extracting
the directory is not empty wtf new error

solemn rivet Feb 22, 2018, 2:17 AM

#

does the temp folder exist now?

#

if so, is it empty?

copper nacelle Feb 22, 2018, 2:17 AM

#

temp never stopped existing

#

nvidia has a folder in it

#

temp has hollow_knight_Data and NVIDIA Corporation in it

solemn rivet Feb 22, 2018, 2:17 AM

#

...

#

brb

copper nacelle Feb 22, 2018, 2:17 AM

#

NVIDIA Corporation has a few bin files, no dlls

#

elderbug

solemn rivet Feb 22, 2018, 2:24 AM

#

it's my fault for assuming the folder didn't exist

copper nacelle Feb 22, 2018, 2:25 AM

#

n

#

i

#

c

#

e

#

it worked

solemn rivet Feb 22, 2018, 2:26 AM

#

sorry for the time lost

#

I'm stupid and inexperienced

copper nacelle Feb 22, 2018, 2:26 AM

#

it's all good

📎 unknown.png

solemn rivet Feb 22, 2018, 2:26 AM

#

sadgrub

copper nacelle Feb 22, 2018, 2:26 AM

#

lol

solemn rivet Feb 22, 2018, 2:26 AM

#

now, to remove the useless messageboxes

#

xD

copper nacelle Feb 22, 2018, 2:26 AM

#

lol

#

inb4 message boxes were preventing the 50 dll error

solemn rivet Feb 22, 2018, 2:27 AM

#

kek

#

nah, I think I fixed it earlier

#

don't remember how tho

#

oh well

copper nacelle Feb 22, 2018, 2:27 AM

#

lmao

solemn rivet Feb 22, 2018, 2:27 AM

#

deleted the older one to prevent spam - this one has fewer boxes

📎 ModInstaller.exe

#

oh, yeah

#

the only thing I did was create the mod folder if it didn't exist

copper nacelle Feb 22, 2018, 2:29 AM

#

works 👍

#

wait wtf

#

but my mods folder existed

#

thinkgrub

solemn rivet Feb 22, 2018, 2:29 AM

#

don't... Just... Don't...

#

cryla

copper nacelle Feb 22, 2018, 2:30 AM

#

lmao

#

wait a second

#

forgot to try the good ol

#

delete the mods folder while the installer is open

solemn rivet Feb 22, 2018, 2:30 AM

#

why would you do that

#

xDDD

#

it only creates it on load

#

don't, please don't

#

my poor heart can't take it

#

ded

#

primalaspid

copper nacelle Feb 22, 2018, 2:30 AM

#

lmao

#

doesn't even let you install mods w/out the folder

#

it knows

solemn rivet Feb 22, 2018, 2:31 AM

#

phew

#

I mean, I can make it create the folder at install if it doesn't exist

#

but why

copper nacelle Feb 22, 2018, 2:32 AM

#

lol

solemn rivet Feb 22, 2018, 2:33 AM

#

it technically shouldn't happen

#

unless you purposefully delete it after loading the installer

copper nacelle Feb 22, 2018, 2:33 AM

#

me_irl

rain cedar Feb 22, 2018, 2:33 AM

#

Never assume the end user won't do stupid shit

solemn rivet Feb 22, 2018, 2:34 AM

#

done

copper nacelle Feb 22, 2018, 2:35 AM

#

inb4 deletes hollow_knight_Data during installation

solemn rivet Feb 22, 2018, 2:35 AM

#

it checks and creates on demand the folder on EACH install request

#

inb4 uninstalls game during installation

hazy sentinel Feb 22, 2018, 2:35 AM

#

uninstalls installer during installation

solemn rivet Feb 22, 2018, 2:36 AM

#

thankfully there's no installation for the installer

#

hollowface

#

and... Pushed

#

thanks for the patience 56!

#

i o u

copper nacelle Feb 22, 2018, 2:38 AM

#

yw

#

the real question now is

#

can I break kerr's installer

solemn rivet Feb 22, 2018, 2:42 AM

#

dunno

#

but his is way more resilient than mine

#

he actually knows what he's doing

copper nacelle Feb 22, 2018, 2:42 AM

#

lmfao

solemn rivet Feb 22, 2018, 2:43 AM

#

I'm serious, I had never used winforms before doing this installer

#

and had never used c# (or done any kind of programming) before blackmoth and bonfire

#

so if I had to bet which one works better...

#

I'd say his

young walrus Feb 22, 2018, 7:05 PM

#

https://www.w3schools.com/code/tryit.asp?filename=FOPTF3F0QMDG

#

okay, what'd i do wrong. lol

buoyant wasp Feb 22, 2018, 7:18 PM

#

lol

#

wth

young walrus Feb 22, 2018, 7:19 PM

#

i dunno man

buoyant wasp Feb 22, 2018, 7:19 PM

#

so you're trying to take the list of goals, and output 26 goals randomly selected from the list?

young walrus Feb 22, 2018, 7:19 PM

#

25

#

just to start

#

then there's requirements with certain goals

buoyant wasp Feb 22, 2018, 7:19 PM

#

and the same goal shouldn't be selected twice right?

young walrus Feb 22, 2018, 7:19 PM

#

that can't both be picked

#

that too

#

i have no clue what i'm doing, dude

#

....obviously

buoyant wasp Feb 22, 2018, 7:20 PM

#

yeah, i know, you're not a programmer by trade, or hobby. 😉

young walrus Feb 22, 2018, 7:20 PM

#

my experience with this language has been a grand total of.... 30 minutes

#

aka.... just now

#

there's also a bunch of them in there that shouldn't be included together, like Dung Defender and Defender's Crest

#

for obvious reasons

buoyant wasp Feb 22, 2018, 7:22 PM

#

yeah, well, i'm gonna fiddle with the first requirement to get you started 😉

young walrus Feb 22, 2018, 7:23 PM

#

lol.

buoyant wasp Feb 22, 2018, 7:29 PM

#

here

#

https://jsfiddle.net/gvtm3ywf/2/

#

can't guarantee there aren't any logic errors in there, but it runs

young walrus Feb 22, 2018, 7:36 PM

#

For not knowing what I'm doing, at least I got kinda close

#

noot

buoyant wasp Feb 22, 2018, 7:42 PM

#

indeed

young walrus Feb 22, 2018, 7:58 PM

#

📎 unknown.png

#

it's outputting it with the brackets and '

#

which we don't want

buoyant wasp Feb 22, 2018, 8:03 PM

#

change

#

    output[i]= {"name": goals.splice(goalIndex,1)[0] };

#

I updated the fiddle i posted above with that

#

i'm just serializing the object, so the quotes have to be there with that kind of output

#

there are other options, just not with the design you were heading in

young walrus Feb 22, 2018, 8:05 PM

#

📎 unknown.png

buoyant wasp Feb 22, 2018, 8:06 PM

#

it probably had the quotes because it was assuming that name was always going to be a string and not an single element array 😃

young walrus Feb 22, 2018, 8:06 PM

#

so now.... the best way to add logic to this so that if a certain goal shows up, others can't?

#

i could add a shit ton of IF statements i guess, but that sounds awful

pearl sentinel Feb 22, 2018, 8:09 PM

#

maybe make like mappings, like, Goal = <list of exclusive goals>
then when you go to add a new goal, for each goal you already have, see if its list contains the new one?

leaden hedge Feb 22, 2018, 8:10 PM

#

you could probably have a hash table

buoyant wasp Feb 22, 2018, 8:10 PM

#

^

#

your data structure right now is very simple, you'll probably need to do a couple of things. First expand that simple array to an array of objects that contain a Keyword for the goal, the name of the goal, and a array of other goals' keywords that are disallowed

#

like

#

var goals = {
    "DungDefender" : {
        "name": "Defeat Dung Defender",
        "excludes": [ "IgnoreDungDefender" ]
    },
    "IgnoreDungDefender" : {
        "name": "Ignore Dung Defender",
        "excludes" : [ "DefeatDungDefender", "GetIsmas" ]
    }
}

young walrus Feb 22, 2018, 8:15 PM

#

Welp, hope nobody wants to see a bingo board for 2 years. lol

buoyant wasp Feb 22, 2018, 8:15 PM

#

when you add a goal in your loop, you add the excludes to an array. then on every loop check to see if the random one you got is in that array, if it is, ask for another random one until you get one that isn't in the array

#

or add it to a hash, that's probably better

#

faster so you don't loop

leaden hedge Feb 22, 2018, 8:15 PM

#

hash tables will be faster

#

you'd remove it from the array when you check it too so it can't come up twice hollowface

buoyant wasp Feb 22, 2018, 8:16 PM

#

ah, yeah splice it out either way

#

though for something this small, i doubt it's gonna take long even if you didn't do either of those better ways. 125 items is gonna take milliseconds to loop through a thousand times

#

but yes, the hash table and removing from the array regardless is faster

leaden hedge Feb 22, 2018, 8:17 PM

#

doesn't matter anyway

buoyant wasp Feb 22, 2018, 8:17 PM

#

and is better

leaden hedge Feb 22, 2018, 8:17 PM

#

because arrays are hash tables in javascript

buoyant wasp Feb 22, 2018, 8:18 PM

#

i know it is that way on the surface, is that how the engine renders them though?

leaden hedge Feb 22, 2018, 8:18 PM

#

afaik yes

buoyant wasp Feb 22, 2018, 8:21 PM

#

weird, wouldn't have thought that. But i suppose it's like alot of things with modern languages. I do XYZ and it works. It's only until it doesn't work that you go and dig into how the engine actually compiles it that you realize why "XYZ" was such a bad way to do it.

young walrus Feb 22, 2018, 8:25 PM

#

oh i think i get it

#

so... if i give dung defender and defender's crest the same tuple/bucket value, then if one of those values was already pulled, it'll reiterate and pull from another bucket

pearl sentinel Feb 22, 2018, 8:27 PM

#

duh, i should apply my work experience here

#

i mean, there's a few ways to do this

#

if you don't want to have something that iterates until it finds a valid solution

#

at work, we're not allowed to "throw away" rng calls

#

i actually implemented something like this for my last game

leaden hedge Feb 22, 2018, 8:29 PM

#

shouldn't be to complicated to do something like

    var goals = [ 
        "DungDefender": {"Name":"Defeat Dung Defender", "excludes":{"GetIsmas", "GetDefendersCrest"},
        "GetIsmas": {"Name":"Get Ismas Tear", "excludes":{"DungDefender", "GetDefendersCrest"},
        "GetDefendersCrest": {"Name":"Get Defenders Crest", "excludes":{"DungDefender", "GetIsmas"}
    ]

    randomkey = randomKey(goal)

    foreach key in goals[randomkey].exludes{
        delete goals[key]
    }

    delete goals[randomkey]

pearl sentinel Feb 22, 2018, 8:29 PM

#

basically, the master list was arranged as a weighted table

leaden hedge Feb 22, 2018, 8:29 PM

#

would probably work fine

#

I don't remember the function to remove a key in javascript

pearl sentinel Feb 22, 2018, 8:30 PM

#

and we just set the weights of invalid values to 0

#

before each run