Brief Library Review | Rust Programming Language Community | Page 1

crude sluice Mar 17, 2023, 6:49 PM

#

Brief Library Review

river spruce Mar 17, 2023, 7:36 PM

#

I think you did a good job and I only have some minor things to point out:
I'd drop the set_ prefixes from the builder methods, they feel redundant to me.
Consider not leaking implementation details like reqwest. You can't change it for something else without breaking downstream.
The use of endpoint in the module description is confusing. They contain data types, not endpoints.
You could have struct Client and struct AuthorizedClient(Client). That way you could encode on the type level which methods may or may not be called without API key

#

Make it roli::Error, repeating names isn't popular in rust land

#

No need for Client::new if you implement default already

#

Builders usually prevent incomplete or conflicting configurations. If there is no such state and sane defaults exist, you might not need it at all.

river spruce Mar 17, 2023, 9:45 PM

#

clippy actively disagrees with me https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default

Clippy Lints

A collection of lints to catch common mistakes and improve your Rust code.

#

your docs were easy to understand, I think that's the important part. the rest is just bikeshedding

#Brief Library Review