JLabel icons not updating properly | Together Java | Page 1

native briarBOT Jun 21, 2024, 1:35 PM

#

<@&987246399047479336> please have a look, thanks.

#

Here is an AI assisted attempt to answer your question 🤖. Maybe it helps! In any case, a human is on the way 👍. To continue talking to the AI, you can use </chatgpt:1108714622413963314>.

#

TJ-Bot

I'm making a blackjack game and using labels to output respective card imagges. For whatever reason, the labels are not actually being updated. The program has access to all of the images so I think its an issue with my methods.

s to the correct card images, as I can see them being loaded into the program, but they are not displaying on the JLabels.

One common issue that could be causing this problem is that you are not invoking the repaint() method after updating the JLabel with a new icon. In Swing, you need to explicitly call repaint() to tell the UI to redraw itself with the updated information.

Make sure that you are calling repaint() or revalidate() (which also triggers a repaint) on the parent container of the JLabel after setting a new icon. This will ensure that the changes are reflected on the screen.

Another thing to check is if you are updating the JLabel on the Event Dispatch Thread (EDT). All Swing GUI updates should be done on the EDT to avoid threading issues. You can use SwingUtilities.invokeLater() or SwingUtilities.invokeAndWait() to update your JLabel on the EDT.

If these solutions do not work, you may want to double-check your code logic and make sure that you are actually setting a new icon on the JLabel correctly. You can also try debugging your code or printing out debug statements to see where exactly things might be going wrong.

Overall, make sure to properly update and refresh your JLabels when changing their icons in order for them to display correctly in your blackjack game.

paper delta Jun 21, 2024, 1:37 PM

#

Are you repainting the label?

#

But are you repainting after setting the icon?

native briarBOT Jun 21, 2024, 1:41 PM

#

Detected code, here are some useful tools:

Formatted code

// method updates player hand images
private void updatePlayerHandImages(List<Card> playerHand) {
  // displays the first card
  Card firstCard = playerHand.get(0);
  String firstCardFileName = getCardImageFileName(firstCard.getRank(), firstCard.getSuit());
  gamePlayerCardOne.setIcon(new ImageIcon(firstCardFileName));
  gamePlayerCardOne.repaint();
  // displays the second card
  Card secondCard = playerHand.get(1);
  String secondCardFileName = getCardImageFileName(secondCard.getRank(), secondCard.getSuit());
  gamePlayerCardTwo.setIcon(new ImageIcon(secondCardFileName));
  gamePlayerCardTwo.repaint();
  // if there are more than two cards in the hand, the images are updated alternating between gamePlayerCradOne and gamePlayerCardTwo (player can still see their hand value for reference)
  for (int i = 2; i < playerHand.size(); i++) {
    Card card = playerHand.get(i);
    String cardFileName = getCardImageFileName(card.getRank(), card.getSuit());
    // determines which label to update with the image
    if (i % 2 == 0) {
      gamePlayerCardOne.setIcon(new ImageIcon(cardFileName));
      gamePlayerCardOne.repaint();
    }
    else {
      gamePlayerCardTwo.setIcon(new ImageIcon(cardFileName));
      gamePlayerCardTwo.repaint();
    }
  }
}

#

Detected code, here are some useful tools:

Formatted code

// method updates dealer hand images
private void updateDealerHandImages(List<Card> dealerHand, boolean revealFirstCard) {
  // updates second card image
  if (dealerHand.size() > 1) {
    Card secondCard = dealerHand.get(1);
    String secondCardFileName = getCardImageFileName(secondCard.getRank(), secondCard.getSuit());
    gameDealerCardTwo.setIcon(new ImageIcon(secondCardFileName));
    gameDealerCardTwo.repaint();
  }
  else {
    gameDealerCardTwo.setIcon(new ImageIcon("cardBack.png"));
    gameDealerCardTwo.repaint();
  }
  // updates first card image based on if its the dealer's turn or not
  if (revealFirstCard && dealerHand.size() > 0) {
    Card firstCard = dealerHand.get(0);
    String firstCardFileName = getCardImageFileName(firstCard.getRank(), firstCard.getSuit());
    gameDealerCardOne.setIcon(new ImageIcon(firstCardFileName));
    gameDealerCardOne.repaint();
  }
  else {
    gameDealerCardOne.setIcon(new ImageIcon("cardBack.png"));
    gameDealerCardOne.repaint();
  }
}

paper delta Jun 21, 2024, 1:42 PM

#

Ah, not called from the Swing thread.

#

SwingUtilities.invokeLater(new Runnable() {
  @Override
  public void run() {
     label.setIcon(icon);
  }
});

native briarBOT Jun 22, 2024, 2:55 AM

#

@limpid glen

Your question has been closed due to inactivity.

If it was not resolved yet, feel free to just post a message below
to reopen it, or create a new thread.

Note that usually the reason for nobody calling back is that your
question may have been not well asked and hence no one felt confident
enough answering.

When you reopen the thread, try to use your time to improve the quality
of the question by elaborating, providing details, context, all relevant code
snippets, any errors you are getting, concrete examples and perhaps also some
screenshots. Share your attempt, explain the expected results and compare
them to the current results.

Also try to make the information easily accessible by sharing code
or assignment descriptions directly on Discord, not behind a link or
PDF-file; provide some guidance for long code snippets and ensure
the code is well formatted and has syntax highlighting. Kindly read through
https://stackoverflow.com/help/how-to-ask for more.

With enough info, someone knows the answer for sure 👍

#JLabel icons not updating properly