We're making a wrapper over the Discord API using Java!! | Together Java | Page 4

light loom May 7, 2024, 4:57 PM

#

annotation based processing
you don't need to start a gateway session to use their web API
We're gonna have hot reloading
We might have a drag and drop editor

plain ledge May 7, 2024, 4:58 PM

#

light loom * annotation based processing * you don't need to start a gateway session to us...

Error handling

steep spruce May 7, 2024, 4:58 PM

#

yes, I'm middle eastern silly
I know falafel and tasted it

light loom May 7, 2024, 4:58 PM

#

Yeah error handling

tawdry pewter May 7, 2024, 4:58 PM

#

u from lebanon?

steep spruce May 7, 2024, 4:58 PM

#

I just prefer shawarma or koshari

light loom May 7, 2024, 4:58 PM

#

Oh guess what we're also gonna have tests, JDA has 0 pepekek

steep spruce May 7, 2024, 4:58 PM

#

tawdry pewter u from lebanon?

Egypt

plain ledge May 7, 2024, 4:58 PM

#

steep spruce yes, I'm middle eastern silly I know falafel and tasted it

Same I just wasn’t sure if u were talking bout food

light loom May 7, 2024, 4:58 PM

#

Plz halloumi and falafel in a wrap

steep spruce May 7, 2024, 4:58 PM

#

light loom Plz halloumi and falafel in a wrap

koshari >>>>>

#

koshari fills you up and is awesome

tawdry pewter May 7, 2024, 4:59 PM

#

steep spruce Egypt

nice! I love shawirma

light loom May 7, 2024, 4:59 PM

#

1 sec, let me act smart and open Uber eats on some random Arab place and act like I know what I'm talking about 😭

#

I'm kidding, I know the menu by heart pepe_sad

tawdry pewter May 7, 2024, 5:00 PM

#

War π API . it's like a poem

light loom May 7, 2024, 5:00 PM

#

Warpi

steep spruce May 7, 2024, 5:01 PM

#

omg yes

#

I love warpi

#

I love to warpi mi shawarmi

placid wharfBOT May 7, 2024, 5:01 PM

#

TJ-Bot

What does warpi mean

In the context of a Java Q&A discord server, "warpi" is not a recognized term or concept in the Java programming language. It is possible that it could be a typo or a misspelling of a different term or word related to Java programming.

If you are looking for assistance with a specific Java programming topic or issue, it would be helpful to provide more context or clarification on what you are referring to as "warpi." This will allow other members of the server to better understand your question and provide relevant assistance.

In general, when asking for help or clarification on a technical topic in a discord server, it is important to be clear and specific in your communication. Providing details such as code snippets, error messages, and any relevant background information can help others assist you more effectively.

Overall, if you are unsure about the meaning of "warpi" in the context of Java programming, it may be helpful to double-check your spelling or try providing more information to clarify your question.

steep spruce May 7, 2024, 5:01 PM

#

yk what I'm saying

light loom May 7, 2024, 5:01 PM

#

Perfect

#

It's unused

#

Let's give it a meaning

steep spruce May 7, 2024, 5:01 PM

#

light loom It's unused

ok we use warpi

steep spruce May 7, 2024, 5:02 PM

#

light loom Let's give it a meaning

warpi mi shawarmi

#

it's easi

light loom May 7, 2024, 5:02 PM

#

warpi Uranus

#

peepo_mhh

steep spruce May 7, 2024, 5:02 PM

#

sorry

#

pepe_sad

light loom May 7, 2024, 5:02 PM

#

It's okay to fight me , I'm kinda trolling on a serious topic

#

Warpi

steep spruce May 7, 2024, 5:03 PM

#

I'd do the same

light loom May 7, 2024, 5:03 PM

#

light loom Warpi

#

Just pinning so we don't forget

#

steep spruce May 7, 2024, 5:05 PM

#

oh cool I've never been pinned in a big server

light loom May 7, 2024, 5:05 PM

#

I pinned some of the suggestions

light loom May 7, 2024, 5:06 PM

#

steep spruce oh cool I've never been pinned in a big server

peepo_heart

#

Let's poll

#

light loom May 7, 2024, 5:11 PM

#

light loom

#

cast your votes

oak flare May 7, 2024, 5:13 PM

#

tbh I don’t like any of these pepekek

plain ledge May 7, 2024, 5:13 PM

#

What are you making?

light loom May 7, 2024, 5:13 PM

#

oak flare tbh I don’t like any of these <:pepekek:646439889797251082>

i swear i just want a name at this point so we can move away from "java-discord-api"

light loom May 7, 2024, 5:13 PM

#

plain ledge What are you making?

a discord framework peepo_heart

oak flare May 7, 2024, 5:14 PM

#

light loom i swear i just want a name at this point so we can move away from "java-discord-...

Yeah but naming is very important

#

But also hard

plain ledge May 7, 2024, 5:14 PM

#

How about jiscord

oak flare May 7, 2024, 5:14 PM

#

That sound sus

light loom May 7, 2024, 5:16 PM

#

oak flare That sound sus

i was about to call it a good idea

#

until i read this

brave ridge May 7, 2024, 5:16 PM

#

I wouldn't go for names that cast shade on other projects like BetterJDA.

light loom May 7, 2024, 5:17 PM

#

but u voted openjda

#

ah well java discord api

#

maybe

#

they cause shame on themselves for going with the name JDA to begin with

sharp ferry May 7, 2024, 5:17 PM

#

light loom but u voted openjda

Yea "open" isn't a good idea in general

light loom May 7, 2024, 5:18 PM

#

it can be in some scenarios

#

but i'm gonna leave the naming to the community

sharp ferry May 7, 2024, 5:18 PM

#

Let's call it Angklung

oak flare May 7, 2024, 5:18 PM

#

wut

sharp ferry May 7, 2024, 5:18 PM

#

Angcord

#

so my idea is the following :

light loom May 7, 2024, 5:19 PM

#

i can imagine a viking saying "AngC0RD!!"

brave ridge May 7, 2024, 5:19 PM

#

DrocsidA?

light loom May 7, 2024, 5:19 PM

#

peeps should consider SEO pepe_sad

sharp ferry May 7, 2024, 5:19 PM

#

-cord makes me think about music cords
I googled favorite music instrument of java island, and I got Angklung

light loom May 7, 2024, 5:20 PM

#

Cord&Coffee

#

sound cools - looks ugly 😐

sharp ferry May 7, 2024, 5:20 PM

#

Gamecord

#

from Gamelan, a music nstrument from java

#

wait

#

no

light loom May 7, 2024, 5:21 PM

#

https://discord-gamecord.js.org/

Discord Gamecord

discord-gamecord is a powerful npm package with a collection of minigames for your discord bot. With simple setup and lots of customizations you can bring your discord bot to another level.

sharp ferry May 7, 2024, 5:21 PM

#

it looks too much like game

#

yea

#

wait

#

Jazzcord

#

🙂

#

Anyway, pick your poison https://en.wikipedia.org/wiki/Music_of_Indonesia

Music of Indonesia

As it is a country with many different tribes and ethnic groups, the music of Indonesia (Indonesian: Musik Indonesia) itself is also very diverse, coming in hundreds of different forms and styles. Every region has its own culture and art, and as a result traditional music from area to area also uniquely differs from one another. For example, eac...

brave ridge May 7, 2024, 5:28 PM

#

Also make sure it's SEO friendly. Disbot/uranium/... don't tick that box.

steep spruce May 7, 2024, 5:29 PM

#

brave ridge Also make sure it's SEO friendly. Disbot/uranium/... don't tick that box.

I made uranium name as a joke lol

#

I didn't expect him to add it to a list of things to choose from

light loom May 7, 2024, 5:29 PM

#

i thought u were srs

#

the explosive framework

steep spruce May 7, 2024, 5:29 PM

#

💀

light loom May 7, 2024, 5:30 PM

#

not too long, after our testing and docs are done...

#

the promotional campaign animesmile

#

"THIS VIDEO IS SPONSORED BY <insert name>"

#

i kid :3 - i'm gonna message discord directly

steep spruce May 7, 2024, 5:32 PM

#

ey so if I contribute that CMD lib and discord sponsors us will you get me a new PC bc I can't earn income ykykyk

light loom May 7, 2024, 5:33 PM

#

what am i, jeff bezos?

steep spruce May 7, 2024, 5:33 PM

#

idk maybe send a selfie

light loom May 7, 2024, 5:33 PM

#

i mean if discord really did sponsor us

#

i'd split

#

if they don't - im at least gonna try get us lifetime nitro

steep spruce May 7, 2024, 5:33 PM

#

lol

light loom May 7, 2024, 5:34 PM

#

but anyways, i do wanna say great job to everyone so far - we've made such good progress - i never expected us to do as much as we did in the time we've spent so far

steep spruce May 7, 2024, 5:34 PM

#

honestly I could make 2 kinds of CMD libs built in

one without annotations where you are required to extend a class and you have to register it manually but executes faster

and one that is exactly the opposite of that I just said

light loom May 7, 2024, 5:35 PM

#

we need that

#

the annotations lib is a users only way into using any type of annotation processing

#

so we need the traditional way inside :core available

steep spruce May 7, 2024, 5:36 PM

#

I could literally make registerCommand and it checks if it's an instanceof something, if it's instanceof the command class and has an annotation it throws

#

or it just loops over methods

light loom May 7, 2024, 5:36 PM

#

for example'; https://github.com/javadiscord/java-discord-api/blob/add-wrappers-over-discord-request/core/src/main/java/com/javadiscord/jdi/core/EventListener.java

GitHub

java-discord-api/core/src/main/java/com/javadiscord/jdi/core/EventL...

A wrapper over the discord API to create bots using Java - javadiscord/java-discord-api

#

this is our manual when not using annotations

orchid portal May 7, 2024, 5:40 PM

#

light loom * annotation based processing * you don't need to start a gateway session to us...

We might have a drag and drop editor
u know how expensive that'll be develop

oak flare May 7, 2024, 5:42 PM

#

Would be doable for me

#

Though not sure what you mean by drag and drop editor

light loom May 7, 2024, 5:46 PM

#

orchid portal > We might have a drag and drop editor u know how expensive that'll be develop

It's doable

#

The only complexity is the frontend which can do in html

oak flare May 7, 2024, 5:47 PM

#

JavaFX >

steep spruce May 7, 2024, 5:48 PM

#

light loom for example'; https://github.com/javadiscord/java-discord-api/blob/add-wrappers-...

also, instead of staying limited to a certain number of events why don't this FW just give devs ability to create their own events? pepe_sad

light loom May 7, 2024, 5:49 PM

#

#

Imagine something like my crap drawing

#

On the left it is all the "actions" and "events"

#

You can drag an event listener onto the drawing board

#

Then under it drag a "action" to listen for

#

Add a simple "if-statement"

steep spruce May 7, 2024, 5:50 PM

#

.

light loom May 7, 2024, 5:50 PM

#

And call one of the API requests

#

Then when you press generate, it should create a .java file

steep spruce May 7, 2024, 5:51 PM

#

steep spruce also, instead of staying limited to a certain number of events why don't this FW...

@light loom? pepe_sad

orchid portal May 7, 2024, 5:51 PM

#

light loom

if we do ever actually make this, make it not spit out the code and commercialize

#

for hosting

light loom May 7, 2024, 5:51 PM

#

You think we should charge money?

orchid portal May 7, 2024, 5:51 PM

#

ofc

light loom May 7, 2024, 5:51 PM

#

steep spruce <@821143476455342120>? <:pepe_sad:979524296462467102>

I didn't understand

steep spruce May 7, 2024, 5:51 PM

#

ofc

light loom May 7, 2024, 5:51 PM

#

orchid portal ofc

Bet

#

Bet bet

orchid portal May 7, 2024, 5:52 PM

#

light loom You think we should charge money?

it'll not only be demotivating but also depressing for me to work on smth like that for free

steep spruce May 7, 2024, 5:52 PM

#

light loom I didn't understand

no like, devs can create their own events, like there's a message event, channel create, etc etc

just let devs make their own alongside the default events

light loom May 7, 2024, 5:52 PM

#

steep spruce no like, devs can create their own events, like there's a message event, channel...

Idk what that looks like

light loom May 7, 2024, 5:53 PM

#

orchid portal it'll not only be demotivating but also depressing for me to work on smth like ...

Sure, I don't mind us monetizing convince tooling

steep spruce May 7, 2024, 5:53 PM

#

light loom Idk what that looks like

I made a menus lib that actually has something like this

it's basically platform independany

#

https://github.com/FlameyosSnowy/Woody/blob/main/core%2Fsrc%2Fmain%2Fjava%2Fme%2Fflame%2Fmenus%2Fmenu%2Factions%2FActions.java

GitHub

Woody/core/src/main/java/me/flame/menus/menu/actions/Actions.java a...

High-performance no-BS, menus library. Contribute to FlameyosSnowy/Woody development by creating an account on GitHub.

#

this is not the final code btw

#

I have almost a complete rework of this

#

but with like a few lines of code you get the point

light loom May 7, 2024, 5:54 PM

#

I'll look later

#

If we make commercial tooling and it actually sells wow.

steep spruce May 7, 2024, 5:55 PM

#

light loom I'll look later

just remember
this code is bad only because it isn't the final product xd

steep spruce May 7, 2024, 5:55 PM

#

light loom If we make commercial tooling and it actually sells wow.

don't forget to get me a car

#

convertible specifically

#

good for back

light loom May 7, 2024, 5:55 PM

#

I don't need the money for myself, so it's for you peeps

steep spruce May 7, 2024, 5:56 PM

#

light loom I don't need the money for myself, so it's for you peeps

wew thanks but I'm mostly grateful for what I have

orchid portal May 7, 2024, 6:00 PM

#

steep spruce wew thanks but I'm mostly grateful for what I have

does that mean all the money is for me?

steep spruce May 7, 2024, 6:03 PM

#

orchid portal does that mean all the money is for me?

nah I'm gonna upgrade my PC and give the rest to charity

#

I'm thinking a Ryzen 5 3400G and GTX 1080

#

16gb ram ykyk

#

if I can get GTX 1660 I will use 2 monitors

orchid portal May 7, 2024, 6:05 PM

#

steep spruce nah I'm gonna upgrade my PC and give the rest to charity

lets move to #chit-chat

plain ledge May 7, 2024, 6:46 PM

#

orchid portal does that mean all the money is for me?

Woah my friend

steep spruce May 7, 2024, 7:56 PM

#

plain ledge Woah my friend

he so felsish

#

ik

light loom May 8, 2024, 4:57 PM

#

@orchid portal can we merge??

worthy flower May 8, 2024, 4:59 PM

#

hey guys

#

i'd like to know is there any architecture drawings for the new framework ?

#

documentations or meetings ?

#

i dunno about the progress, but ig these are essential before coding

light loom May 8, 2024, 5:00 PM

#

No we have a task to document this, all my architecture are on scrap paper

#

The architecture is good though but it's not important to understand the code, the modules are small on their own

worthy flower May 8, 2024, 5:02 PM

#

it'd be nice to understand the what and why; the packages and components; as models

#

to make good design

#

otherwise, we may get into serious design troubles (like others ;.)

light loom May 8, 2024, 5:03 PM

#

We won't run to any troubles because we're #experts peepo_heart

worthy flower May 8, 2024, 5:03 PM

#

i know that it could be time consumming, and NOT ez

light loom May 8, 2024, 5:03 PM

#

But if you have specific questions, I can answer it, documentation is a future task for us

worthy flower May 8, 2024, 5:03 PM

#

it's not that

#

but ok iget it

#

(same as my team lead usually says)

#

:p

light loom May 8, 2024, 5:04 PM

#

The code is pretty self documenting imo, if you have a look at it, stuff does make sense

#

And screw your lead peepo_heart peepo_knife

worthy flower May 8, 2024, 5:04 PM

#

leslie

#

i understand

#

i hope im wrong

light loom May 8, 2024, 5:08 PM

#

It's okay, you're a babyy peepo_heart

#

A lot of our choices are in this thread though

#

You'll find some interesting stuff by reading the chat

#

But there's over 3000 messages peepoW

worthy flower May 8, 2024, 5:08 PM

#

light loom But there's over 3000 messages <:peepoW:942442078334484492>

that's the point

#

i cannot read all of it

light loom May 8, 2024, 5:09 PM

#

Our docs are gonna be longer pepe_sad

worthy flower May 8, 2024, 5:09 PM

#

wdym

light loom May 8, 2024, 5:09 PM

#

There's so much to write

worthy flower May 8, 2024, 5:10 PM

#

ah

#

we gotta be smart in that

#

ig drawings can help

#

anyway, im gonna take a look soon

orchid portal May 8, 2024, 5:15 PM

#

light loom <@494830783765151754> can we merge??

Did u fix everything?

worthy flower May 8, 2024, 5:18 PM

#

i'd like to know who is surajkumar ?

oak flare May 8, 2024, 5:20 PM

#

wazei

worthy flower May 8, 2024, 5:21 PM

#

alright ty

plain ledge May 8, 2024, 5:29 PM

#

light loom Our docs are gonna be longer <:pepe_sad:979524296462467102>

Hopefully the non java docs are not that long

restive void May 8, 2024, 6:03 PM

#

light loom But there's over 3000 messages <:peepoW:942442078334484492>

Dont u think it would be better to make a dedicated discord server for this project?

#

Way too easy for important info to get lost in a single thread like this imo

orchid portal May 8, 2024, 6:06 PM

#

worthy flower i'd like to know who is surajkumar ?

the man

#

the myth

#

the legend

light loom May 9, 2024, 7:02 PM

#

i merged screw it 😐

oak flare May 9, 2024, 7:10 PM

#

last words

#

before disaster

light loom May 9, 2024, 7:11 PM

#

it's not

#

it's now testing season!!!

#

if everyone can test the life out of this with me peepo_heart

oak flare May 9, 2024, 7:18 PM

#

I cant

plain ledge May 9, 2024, 7:35 PM

#

Smh

light loom May 9, 2024, 7:36 PM

#

plain ledge Smh

I'm sorry pepe_sad

worthy flower May 10, 2024, 8:31 PM

#

hey guys

#

i was checking the project and tickets on GH

#

it seems there are tons

#

i wonder how those were made and analyzed ?

#

i need to talk a bit before i get started

#

(knowing that currenly im cloning the repo)

light loom May 11, 2024, 8:37 AM

#

Went over the docs and made the tickets like that, with some being just general programming wisdom

#

And some are just a collated from what everyone else has recognised as either something we need to do, or tech debt that's been racking up

worthy flower May 11, 2024, 10:18 AM

#

light loom Went over the docs and made the tickets like that, with some being just general ...

went over the docs
What docs?

oak flare May 11, 2024, 10:30 AM

#

worthy flower > went over the docs What docs?

discord api docs

light loom May 12, 2024, 8:54 AM

#

time to write some tests

#

this will take me forever

light loom May 12, 2024, 10:37 AM

#

peeps can somebody review https://github.com/javadiscord/java-discord-api/pull/95?

GitHub

Unit tests for UserRequest by surajkumar · Pull Request #95 · javad...

Describe the PR

Fixed some issues found during unit testing
Add a helper to test against the live discord API
Added tests for UserRequest

Context:
We use the real discord API because even with al...

#

best to review by commits

#

oh nice the tests are failing now

worthy flower May 12, 2024, 10:42 AM

#

Hey waz

light loom May 12, 2024, 10:42 AM

#

hi

worthy flower May 12, 2024, 10:42 AM

#

Oh you're doing some work nice

light loom May 12, 2024, 10:43 AM

#

ah tests are failing because missing env var on gh

#

but they're also failing for me locally when i do gradle build but work when running standalone 😦

worthy flower May 12, 2024, 10:56 AM

#

peepo_think

orchid portal May 12, 2024, 10:59 AM

#

light loom but they're also failing for me locally when i do `gradle build` but work when r...

"devops is not a role"

light loom May 12, 2024, 10:59 AM

#

it's a skill

light loom May 12, 2024, 1:01 PM

#

Received HTTP status code 400 {"username": ["You are changing your username or Discord Tag too fast. Try again later."]}

#

rip my tests 😦

#

worthy flower May 12, 2024, 1:32 PM

#

Wtf

light loom May 12, 2024, 1:44 PM

#

its okay, i've tested and it works so ill keep it disabled

orchid portal May 12, 2024, 1:48 PM

#

light loom `Received HTTP status code 400 {"username": ["You are changing your username or ...

is it not on the imposter api?

light loom May 12, 2024, 1:51 PM

#

using the real api - imposter wouldn't tell me if there are any errors besides the basic validation of our decoders

#

useful for testing that our models are in the right shape - that's a different part of the testing though

restive void May 16, 2024, 1:27 AM

#

What needs to be worked on currently for the wrapper?

plain ledge May 16, 2024, 1:36 AM

#

restive void What needs to be worked on currently for the wrapper?

I think integration & Unit tests

#

documenting code

restive void May 16, 2024, 1:37 AM

#

Oh nah

#

U guys got that one 👍👍

light loom May 16, 2024, 5:56 AM

#

restive void Oh nah

Hahaha

#

Testing pepe_sad

oak flare May 16, 2024, 12:04 PM

#

what would you recommend me to start with?

light loom May 16, 2024, 12:05 PM

#

testssss]

#

test anything

oak flare May 16, 2024, 12:05 PM

#

well no

light loom May 16, 2024, 12:05 PM

#

we're done functionally

oak flare May 16, 2024, 12:05 PM

#

I am not familiar with the project at all

light loom May 16, 2024, 12:05 PM

#

ah it's simple to write tests actually

#

we're testing the method calls work in discord as expected

oak flare May 16, 2024, 12:05 PM

#

yeah but I have zero context

light loom May 16, 2024, 12:05 PM

#

i can show u

#

i am going to be showing chris too, maybe I can do something in the vc

#

to show how it all works

#

and write some tests in front of u

#

so u get an idea

oak flare May 16, 2024, 12:06 PM

#

I want to get an idea of the project

light loom May 16, 2024, 12:06 PM

#

want me to walk you through the entire project?

#

https://github.com/orgs/javadiscord/projects/1/views/2?pane=issue&itemId=58196175

GitHub

Java Discord • javadiscord

Java Discord

#

there's this ticket you can trry working on

#

or maybe anything else in the no status if you're interested

oak flare May 16, 2024, 12:09 PM

#

hm, what kind of logging are we using, and I kinda have no idea how to implement this "flow id"

light loom May 16, 2024, 12:10 PM

#

1 sec

#

#1223284116263276637 message

#

read down from here

#

look into "mapped diagnostic context" (MDC) on google for log4j and run some experiments

oak flare May 16, 2024, 12:11 PM

#

ah nice there is some baeldung article about that

#

do you already have a pattern in mind?

light loom May 16, 2024, 12:16 PM

#

i guess just add [id] to the front maybe?

oak flare May 16, 2024, 12:16 PM

#

yeah, at what point should context happen?

light loom May 16, 2024, 12:17 PM

#

good question

oak flare May 16, 2024, 12:17 PM

#

on some request?

#

or do we have an action system or whatever?

light loom May 16, 2024, 12:17 PM

#

look inside :core

#

https://github.com/javadiscord/java-discord-api/blob/main/core/src/main/java/com/javadiscord/jdi/core/Guild.java

#

this class essentially is our "Action Sender"

#

and you can see some methods like

#

channel() invite() user()

#

those link to the actual sending methods which are located in :api

#

e.g. user() takes you to https://github.com/javadiscord/java-discord-api/blob/main/api/src/main/java/com/javadiscord/jdi/core/api/UserRequest.java

#

from here you can do stuff like getUser() or leaveGuild()

#

eventually, everything ends up inside https://github.com/javadiscord/java-discord-api/blob/main/api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestDispatcher.java

#

which sends the request and gets the response

#

it's a bit tricky because it's async so maybe you have to link the flowId to the DiscordRequest

oak flare May 16, 2024, 12:21 PM

#

cancer lmao

light loom May 16, 2024, 12:22 PM

#

it's a little tricky but really helpful, it was the feature zabu requested 😄

#

the main point of it all is to know which log messages are related to a specific thing

oak flare May 16, 2024, 12:22 PM

#

well yeah

#

seems quite hard though imo

#

if the user starts with a call to Guild#..., then the context should start

#

but idk

light loom May 16, 2024, 12:24 PM

#

the context can start much earlier

#

as far as receiving an event from the websocket

#

most typical usecase is a response to an event e.g. channel created, message received etc

#

as that's what triggers the handlers the users are using

#

however, the scenario where we start from Guild is something like running a scheduled action (so not responding to an event but manually invoking)

oak flare May 16, 2024, 12:27 PM

#

im not familiar with the websocket, but like giving each websocket event its own flow id?

light loom May 16, 2024, 12:27 PM

#

mhm

#

would you like a walk through the codebase squid?

oak flare May 16, 2024, 12:30 PM

#

yeah would be nice

light loom May 16, 2024, 12:30 PM

#

jump in vc

light loom May 16, 2024, 1:02 PM

#

com.javadiscord.jdi.internal.gateway.handlers.events.EventCodecHandler = entry point for gateway events

#

:gateway module

#

com.javadiscord.jdi.core.Discord = entry point for sending requests

#

:core module

oak flare May 16, 2024, 1:08 PM

#

so gateway events are from discord -> bot
and sending requests are from bot -> discord
right?

light loom May 16, 2024, 1:08 PM

#

yess

oak flare May 16, 2024, 1:21 PM

#

what happens if I start the context in the gateway EventCodecHandler and it calls a listener created by a user of the library?
because I need to specify the pattern in log4j2.xml, can users of the library also benefit from this and just update their pattern to use the context, even though it is in a different unrelated package?

light loom May 16, 2024, 1:23 PM

#

oak flare what happens if I start the context in the gateway `EventCodecHandler` and it ca...

that's fine - it shows the user where in the code something started from

#

so if an error occurs - they can know "okay so its this handler that error started from"

oak flare May 16, 2024, 1:24 PM

#

I am talking if they log in their code as well

light loom May 16, 2024, 1:24 PM

#

i don't think it updates their own log messages?

oak flare May 16, 2024, 1:24 PM

#

but if its still in the same context?

#

whatever I will just try it out 😛

light loom May 16, 2024, 1:24 PM

#

yeah experiment, I have no idea on this stuff myself, never done it before

#

even mapped diagnostic context, I had to google this never heard of it before

#

might not even be the right solution, maybe something custom will have to be done, I am not sure 😦

oak flare May 16, 2024, 1:25 PM

#

We will see

light loom May 16, 2024, 1:26 PM

#

🙂 🙂

oak flare May 16, 2024, 1:32 PM

#

there is no resources folder in core? and no log4j2.xml in core? is that intended?

light loom May 16, 2024, 1:45 PM

#

no, probably just didn't notice

#

but we do get logs

#

so not sure xd

oak flare May 16, 2024, 1:47 PM

#

huh

#

tf

light loom May 16, 2024, 1:47 PM

#

it might be getting inherited from another module

oak flare May 16, 2024, 1:47 PM

#

I am going to add one anyways

#

anything I need to look out for?

#

well I just see that only gateway got a resources folder

light loom May 16, 2024, 1:51 PM

#

if you delete it, what happens, do all logs stop?

oak flare May 16, 2024, 1:52 PM

#

well let me setup a bot token

#

so I can test

light loom May 16, 2024, 1:52 PM

#

oki

oak flare May 16, 2024, 1:58 PM

#

ERROR com.javadiscord.jdi.internal.gateway.WebSocketHandler - [4014] Disallowed intent(s).
uh what do I do here?

light loom May 16, 2024, 1:59 PM

#

Ah you didn't setup the bot properly

oak flare May 16, 2024, 1:59 PM

#

probably lmao

#

just selected everything

#

lmao

light loom May 16, 2024, 2:00 PM

#

Give me like 15 mins I'm just away from my PC - I'll show you how to do it.

oak flare May 16, 2024, 2:00 PM

#

ah ok

#

all good

light loom May 16, 2024, 2:25 PM

#

okay im here

oak flare May 16, 2024, 2:26 PM

#

what did I do wrong?

light loom May 16, 2024, 2:26 PM

#

#

tick these in the "Bot" page

#

oak flare May 16, 2024, 2:27 PM

#

ah thanks

#

they changed the ui again peepo_sad_2

light loom May 16, 2024, 2:27 PM

#

#

under "Installation"

#

oh

#

this is the new bit

oak flare May 16, 2024, 2:29 PM

#

light loom

thid doesnt work

#

if you select bot you also need to select permissions

#

can I just select everything again?

light loom May 16, 2024, 2:30 PM

#

yeah try that

#

it's new so i'm not sure about this page

oak flare May 16, 2024, 2:31 PM

#

still same error

#

and I think there is some bug in the websocket stuff

#

the first error gives 2sec delay as stated, but everything after spams instantly

light loom May 16, 2024, 2:40 PM

#

can you send me ur token?

#

this was an issue a long time ago but I had fixed it since

oak flare May 16, 2024, 2:46 PM

#

uh yeah

#

can you even send them through discord though?

light loom May 16, 2024, 2:46 PM

#

yes

orchid portal May 16, 2024, 2:52 PM

#

oak flare can you even send them through discord though?

if u try hard enough

oak flare May 16, 2024, 3:35 PM

#

light loom if you delete it, what happens, do all logs stop?

yeah they stop

#

it seems like one is enough actually

#

it applies to other modules as well

#

what can cause that

#

and where should the log4j2.xml be located then?

#

bruh

#

so it seems like if the module is imported its going to use that config if not specified

#

im just going to modify gateways existing log4j2 and check this later

#

also I need ideas for generating the ids

#

what would fit here?

#

first test works pretty nice

#

just need to find a way to make that optional

#

or well maybe not

#

going to look deeper later or tomorrow

light loom May 16, 2024, 4:44 PM

#

Could just use an Integer and increment it for the time being?

floral halo May 16, 2024, 6:17 PM

#

Hi, this project looks interesting, I want to poke around the code. I cloned the repo but gradle doesn't seem to be pulling in any dependencies out of the box. I'm not experienced with gradle but have worked with Maven extensively. Which JDK does this project use, and how do I get Gradle to recognize the dependencies? Using Intellij 2024.1

#

It says 'no local installed toolchains match and toolchain download repositories have not been configured'
I'm assuming that means Gradle is either not installed or not properly configured. Looks like Gradle is installed though since I have it in my User folder

oak flare May 16, 2024, 6:22 PM

#

hm I just cloned it today as well, everything worked fine

#

might be worth creating a #1051826284008853505

#

I might be able to help with gradle, you dont need to install it, project provides wrapper

floral halo May 16, 2024, 6:22 PM

#

which Java SDK are you using?

oak flare May 16, 2024, 6:23 PM

#

check build.gradle ig

#

let me check

#

java 21

#

otherwise try to press this button in intellij

floral halo May 16, 2024, 6:24 PM

#

i just added java 21 and that fixed it

#

pepekek

#

thanks bro

oak flare May 16, 2024, 6:35 PM

#

light loom Could just use an Integer and increment it for the time being?

ok yeah, but where should I store that integer? it should ideally share it across the modules

#

the implementation seems quite easy, just some questions that needs to be answered first

#

let me create a list of questions in the pr

light loom May 16, 2024, 6:43 PM

#

hm, well it could be anyway, in a class called FlowId with a static getter?

oak flare May 16, 2024, 6:43 PM

#

in which module though?

light loom May 16, 2024, 6:55 PM

#

i guess make a new one called :logging or :util since it'll need to be accessible by everything?

oak flare May 16, 2024, 6:56 PM

#

since it'll need to be accessible by everything?
that depends

#

if we want all logging to have flow ids

#

or just stuff that relates to user stuff

#

like outgoing/incoming stuff

#

but then we simply change build.gradle for that specific module

light loom May 16, 2024, 7:20 PM

#

oak flare if we want all logging to have flow ids

yeah probably everything

#

how configurable is it?

#

i'd love a demo of what's possible and we can then all agree on what's best

oak flare May 16, 2024, 7:21 PM

#

well technically everything, as far as I understand we just need to group logging by defining a start and end of a group

#

for some stuff it is easy to group

#

for example gateway events

light loom May 16, 2024, 7:23 PM

#

mhm

oak flare May 16, 2024, 7:23 PM

#

but for others there needs to be some analysis on how to group, for example group all initializing logging? etc

light loom May 16, 2024, 7:24 PM

#

ah i see, cool will discuss with you later

#

i'm currently...

#

you know...

oak flare May 16, 2024, 7:24 PM

#

yeah all good

light loom May 16, 2024, 7:24 PM

#

secret

oak flare May 16, 2024, 7:24 PM

#

I can wait

light loom May 16, 2024, 7:24 PM

#

😄

sharp ferry May 16, 2024, 7:24 PM

#

no

light loom May 16, 2024, 7:25 PM

#

i'm eating

oak flare May 16, 2024, 7:25 PM

#

ofc

#

what are you saying in this situation in english? "Enjoy your meal"?

light loom May 16, 2024, 7:33 PM

#

Actually I ordered food

oak flare May 16, 2024, 7:33 PM

#

lazy ass

light loom May 16, 2024, 7:37 PM

#

i got indian

#

it's not lazy, it's difficult

oak flare May 16, 2024, 7:37 PM

#

peepo_heart

light loom May 16, 2024, 9:34 PM

#

squid, this now a good time or want to discuss it tomorrow?

oak flare May 16, 2024, 9:37 PM

#

i dont mind either way

light loom May 16, 2024, 9:37 PM

#

have you got something you could show me?

oak flare May 16, 2024, 9:37 PM

#

well there is not much to show

#

the idea is simple

light loom May 16, 2024, 9:38 PM

#

ah you haven't actually implemented it right?

oak flare May 16, 2024, 9:38 PM

#

give me one sec

light loom May 16, 2024, 9:38 PM

#

or you have?

oak flare May 16, 2024, 9:38 PM

#

light loom ah you haven't actually implemented it right?

I did, but just for one case, no need for the others its really simple

#

you remember EventCodecHandler#handle

light loom May 16, 2024, 9:39 PM

#

yeah

oak flare May 16, 2024, 9:39 PM

#

basically did this:

#

int counter = 0;

@Override
@SuppressWarnings({"unchecked"})
public void handle(GatewayEvent gatewayEvent, ConnectionMediator connectionMediator) {
    ThreadContext.put("flow.id", String.valueOf(counter++));
    
    // actual logic        

    ThreadContext.clearAll();
}

and the actual logic uses logging

#

using this pattern in the log4j2.xml automatically going to put the id into its place:

<PatternLayout pattern="%X{flow.id} - %d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n" />

light loom May 16, 2024, 9:40 PM

#

ooooooh

oak flare May 16, 2024, 9:40 PM

#

thats it

#

there is not more too it

light loom May 16, 2024, 9:40 PM

#

were u able to see that flowId through an entire journey?

oak flare May 16, 2024, 9:40 PM

#

and the actual complete implementation depends on the questions asked

oak flare May 16, 2024, 9:41 PM

#

light loom were u able to see that flowId through an entire journey?

well in this case everything that is happening in the actual logic

#

even in custom listener

#

because you call them in this logic

#

and the user of the library can change their log4j2.xml while still being able to optionally take use of the flow.id value

light loom May 16, 2024, 9:42 PM

#

great find, let me run some tests, i'm curious how it looks with the multi-threaded parts

oak flare May 16, 2024, 9:42 PM

#

well yeah

#

let me show you smth

light loom May 16, 2024, 9:42 PM

#

want to watch? I can share my screen

oak flare May 16, 2024, 9:42 PM

#

yeah in a sec

#

the first got no id because thats not in the current implementation so its fine
but you can also see that some numbers get "skipped", that happens if the EventCodecHandler#handle get called but no logging happens,
is this a problem? it kinda looks unclean, but the idea still works, having unique ids for unique flows

light loom May 16, 2024, 9:45 PM

#

maybe we can set it from main?

orchid portal May 16, 2024, 9:45 PM

#

light loom want to watch? I can share my screen

i want to watch u

light loom May 16, 2024, 9:46 PM

#

sure

oak flare May 16, 2024, 9:46 PM

#

light loom maybe we can set it from main?

what do you mean?

light loom May 16, 2024, 9:46 PM

#

i'll show you

floral halo May 16, 2024, 9:58 PM

#

you guys in a room somewhere? or already done?

orchid portal May 16, 2024, 10:00 PM

#

floral halo you guys in a room somewhere? or already done?

i can come in ur room if u wnt

plain ledge May 16, 2024, 10:36 PM

#

@light loom are we switching off of the vertx ws

light loom May 16, 2024, 10:37 PM

#

plain ledge <@821143476455342120> are we switching off of the vertx ws

i need to think hard about this

floral halo May 16, 2024, 11:22 PM

#

Heyy noob question, I was messing around iwith the example bot, got it connected to discord and added to my server, but whenever I send a message in the channel, the bot throws NPE in the GatewayEventListener because there is no guild object in the cache... is there something I need to configure for this to be populated?

light loom May 16, 2024, 11:50 PM

#

@floral halo thanks for checking, so there will be bugs, the project is still in development

#

I've already spotted the issue while I was writing tests and it'll eventually get fixed

#

Any bugs, issues etc you find, would be great if you could let us know but just so you're aware, there will be plenty of bugs pepe_sad

floral halo May 17, 2024, 12:14 AM

#

light loom Any bugs, issues etc you find, would be great if you could let us know but just ...

Cool, thanks for verifying, good to know peepo_heart

#

is there a preferred method for reporting bugs, like if I find one, should I add a new issue to the Git repo, or should I just report them in one of the Discord channels?

light loom May 17, 2024, 12:46 AM

#

Issue on GH is easier to track but you can also post them here peepo_heart

steep spruce May 17, 2024, 2:04 PM

#

@light loom I'm done with exams

oak flare May 17, 2024, 2:05 PM

#

you german?

steep spruce May 17, 2024, 2:31 PM

#

oak flare you german?

egyptian

#

but i finished early and not in june bc I'm 7th grade (preparatory 1st)

oak flare May 17, 2024, 2:31 PM

#

well nvm pepekek

oak flare May 17, 2024, 9:47 PM

#

@light loom how are you testing btw? You just change test bot and try out stuff?
Also how can I see what you tested already and what still needs testing?

light loom May 17, 2024, 9:49 PM

#

i have a PR

#

sec

oak flare May 17, 2024, 9:49 PM

#

mb

light loom May 17, 2024, 9:49 PM

#

https://github.com/javadiscord/java-discord-api/pull/95

GitHub

Unit tests for UserRequest by surajkumar · Pull Request #95 · javad...

Describe the PR

Fixed some issues found during unit testing
Add a helper to test against the live discord API
Added tests for UserRequest

Context:
We use the real discord API because even with al...

#

so for some of the testing I am testing it by running it locally

#

then once I know it works I add @Disabled

#

because some of the actions break everything

#

e.g. if i did a "guild leave"

#

well gg im no longer in a server 😄

#

I think once this PR is fixed and merged

#

that gives you all the boilerplate for everyone else to write tests because they can reference this

#

the PR also has fixes for issues I found during testing

#

for example for us to decode enums properly we need a @JsonCreator

oak flare May 17, 2024, 9:51 PM

#

what are these countdownlatches? just used to await the asynchronous code?

light loom May 17, 2024, 9:51 PM

#

yeah it basically blocks the thread until it gets woken up or times out

oak flare May 17, 2024, 9:51 PM

#

is there no better way?

light loom May 17, 2024, 9:52 PM

#

nope - discord could be slow or rate limit could be slowing us down or anything

#

the tests are quick though

oak flare May 17, 2024, 9:52 PM

#

is there no blocking method in AsyncResponse?

light loom May 17, 2024, 9:52 PM

#

nope

oak flare May 17, 2024, 9:52 PM

#

any reason for that?

light loom May 17, 2024, 9:53 PM

#

I don't know how to make it blocking without blocking the entire application

#

if your handler is blocked, then you're blocking events

#

and if events are blocked

#

it'll bubble up all the way to the important areas like the gateway connection

#

so we'd need to do some heavy multi threading

#

which makes no sense to do anyway

oak flare May 17, 2024, 9:54 PM

#

but then we kinda have a worse api than other discord libraries

light loom May 17, 2024, 9:55 PM

#

why? because we can't block?

#

but what if an error occurs?

oak flare May 17, 2024, 9:56 PM

#

because the user of the library is forced to use async

light loom May 17, 2024, 9:56 PM

#

consider this:

oak flare May 17, 2024, 9:56 PM

#

idc about the implementation right now

#

just talking from the user perspective

light loom May 17, 2024, 9:57 PM

#

let me think about it - maybe I can do it

oak flare May 17, 2024, 9:57 PM

#

same with chaining

#

I like the way jda does it

#

though its not perfect

light loom May 17, 2024, 9:59 PM

#

you can chain but not different requests

#

e.g.

#

getChannel()
 .sendMessage()
 .getUser()````

#

that would be dumb

#

but you can chain the AsyncResponse

#

but i often don't like it because the code ends up heavily indented

oak flare May 17, 2024, 10:01 PM

#

yeah exactly what I mean, you end up with ten lambdas and heavy indentation

light loom May 17, 2024, 10:06 PM

#

    public T block() throws Exception {
        CompletableFuture<T> future = new CompletableFuture<>();
        this.successConsumer = future::complete;

        this.exceptionConsumer = result -> {
            throw new RuntimeException(result);
        };

        return future.get();
    }

#

i think this might work

oak flare May 17, 2024, 10:07 PM

#

weird approach lmao

light loom May 17, 2024, 10:08 PM

#

it's fine imo

oak flare May 17, 2024, 10:10 PM

#

not sure if this even works lmao

light loom May 17, 2024, 10:10 PM

#

im testing wait

#

okay

#

i think it works

oak flare May 17, 2024, 10:10 PM

#

is this fully single threaded?

light loom May 17, 2024, 10:11 PM

#

networking isn't

#

everything else is

#

we're piggy backing each of the network threads

oak flare May 17, 2024, 10:11 PM

#

ok so is discord.start a blocking call or not? I am trying to understand lol

light loom May 17, 2024, 10:11 PM

#

yeah its a blocking call

#

but the multi threading is provided by the network code

oak flare May 17, 2024, 10:12 PM

#

and there is a loop waiting for async stuff right?

light loom May 17, 2024, 10:12 PM

#

nope no loop

#

unless you mean sending requests to discord api async? then yes

oak flare May 17, 2024, 10:16 PM

#

yea

light loom May 17, 2024, 10:16 PM

#

Yeah there's a loop in the request dispatcher class

#

But that loop is just to handle rate limiting

oak flare May 17, 2024, 10:19 PM

#

well yeah, but its not

just to handle rate limiting
this loop causes start to be blocking right?

#

so outgoing are single threaded
and incoming is handled by network stuff

light loom May 17, 2024, 10:20 PM

#

Nope

#

That's running on a different thread

#

These are the threads:

#

main
gateway
api calls

#

Vert.x under the hood handles all the threading, so we're getting free async it's just we don't have to write async code

oak flare May 17, 2024, 10:22 PM

#

a well my question way earlier was stupid

#

I asked if the start method is a blocking call

#

though I meant if its like blocking forever because of some loop

#

caused misunderstanding mb

light loom May 17, 2024, 10:23 PM

#

Ah

#

Yeah it's not blocking the main thread:)

oak flare May 17, 2024, 10:24 PM

#

but for example if I have a listener and it gets triggered its going to run on the gateway thread right?

light loom May 17, 2024, 10:25 PM

#

Yeah

#

Which is based on vert.x internal thread pool

oak flare May 17, 2024, 10:26 PM

#

so if a listener would have a heavy task it would only block some internal thread from thread pool?

light loom May 17, 2024, 10:27 PM

#

Yeah

#

But on heavy traffic events such as message create

#

If you're blocking in your listener

#

You're potentially spawning loads of threads now

#

(at least that's how I think it works?)

oak flare May 17, 2024, 10:28 PM

#

yeah I am trying to understand what happens here as well

light loom May 17, 2024, 10:28 PM

#

But this is regular java concepts

oak flare May 17, 2024, 10:28 PM

#

yeah ofc

light loom May 17, 2024, 10:29 PM

#

I'm not sure exactly what vert.x does I think it's uncapped using the cachedThreadPool but I can't remember

#

It can handle a few thousand non-blocking requests per second anyway

#

I just remembered I need to create an issue

#

I set a reminder 🙂

#

The issue is: we have cached objects

#

But we're not using them!!

oak flare May 17, 2024, 10:31 PM

#

what are we even caching?

light loom May 17, 2024, 10:31 PM

#

Models, so stuff like channel objects, users, etc

#

It's internally tracked and updated

oak flare May 17, 2024, 10:32 PM

#

what happens if they change? the cached object would be outdated no?

light loom May 17, 2024, 10:32 PM

#

If they change, the gateway sends an update event

#

But

oak flare May 17, 2024, 10:32 PM

#

ah ok

light loom May 17, 2024, 10:32 PM

#

Some things we don't get events for maybe but I'll make it configurable

#

Maybe I can make a method in Guild

#

and a "is cached" boolean

#

So users can check before they actually make a request

#

The cache system is cool and simple

#

There's 3 types

#

A full cache i.e. cache everything

#

Partial cache which only caches models you tell it to

#

And no caching

#

By default it's set to full

#

But configure as you please from Discord class

#

That's the only module with unit tests and complete coverage pepekek

oak flare May 17, 2024, 10:36 PM

#

light loom Maybe I can make a method in Guild

wouldnt that need to be in the request classes?
like for example ChannelRequest#fetchChannel:

check if caching for that is activated
check if cached object for that id exists
return AsyncResponse with cached object or make request

thats how I understand what you are talking about right now

light loom May 17, 2024, 10:37 PM

#

I don't wanna do that in secrecy from the user because discord sends partial objects sometimes so we don't have all the fields in some of the cached objects

#

They might only send 3 fields when an object might have 8

#

Our caching updates that though (you might remember the reflection I was doing way back)

#

I want the user to specifically choose or configure caching behaviour

e.g. maybe they can set a property "always check cache first"

#

So then your scenario kicks in

#

Otherwise if they wanna check cache, go into it and check

oak flare May 17, 2024, 10:39 PM

#

light loom I don't wanna do that in secrecy from the user because discord sends partial obj...

ah you mean like two endpoints returning object with same id, but one endpoint might give more information than the other?

light loom May 17, 2024, 10:41 PM

#

Yes

oak flare May 17, 2024, 10:41 PM

#

cancer

#

going to make caching harder and unpredicable for the user

#

a solution would be to have cache per endpoint in such a scenario

#

but thats also cancer

#

btw in the request dispatcher, why does it create a new httpclient for every request a user sends?

light loom May 17, 2024, 10:49 PM

#

oak flare going to make caching harder and unpredicable for the user

Actually we've solved the problem already peepo_heart

#

Any object, no matter where it's from, if we've cached it - we update any null fields with the values and update the existing ones with the new data 😍

light loom May 17, 2024, 10:50 PM

#

oak flare btw in the request dispatcher, why does it create a new httpclient for every req...

Oversight, if it doesn't need to be recreated, we can move it outside peepo_heart

oak flare May 17, 2024, 10:51 PM

#

well I generally think of something redundant in the case of httpclient

light loom May 17, 2024, 10:51 PM

#

Just make sure that we can still run multiple requests by having a single http client

oak flare May 17, 2024, 10:51 PM

#

but I might not be familiar with the api for it

light loom May 17, 2024, 10:51 PM

#

The overhead is small anyway if any

oak flare May 17, 2024, 10:53 PM

#

not sure, quick look shows that it initialises a new cached thread pool every time

#

but it is definitely designed to be re-used for multiple calls

light loom May 17, 2024, 10:56 PM

#

Ah perfect, we can just move it outside of the method call then, good catch

oak flare May 17, 2024, 11:02 PM

#

btw for the implementation of a blocking get method in AsyncResponse couldnt we simply use some lock that waits and gets notified in the setResult method?
then we additionally store a field for the result and then return it in the blocking call?

light loom May 17, 2024, 11:08 PM

#

What didn't you like about the completable future?

#

It's actually a pretty nice implementation imo

#

It's pretty safe too

oak flare May 17, 2024, 11:10 PM

#

what if user wants to have a successConsumer and still using a blocking call?

#

you override it

#

same with error

#

also doesnt this introduce some new thread stuff?

#

and you dont even need to use wait/notify directly, you can easily use some higher level stuff from java.util.concurrent

#

I could try this

light loom May 17, 2024, 11:18 PM

#

We can do a check

#

if(successConsumer != null) throw

#

Or we can handle multiple consumers

oak flare May 17, 2024, 11:19 PM

#

nah thats bad approach, you can actually just chain them

#

and then still use completable future

#

but it seems like abusing it for this case maybe?

light loom May 17, 2024, 11:19 PM

#

Yeah can do, it's not making the code ugly or anything so I don't mind

oak flare May 17, 2024, 11:20 PM

#

well why are we even introducing asyncresponse in the first place? instead of using some existing stuff?

light loom May 17, 2024, 11:21 PM

#

Primarily, flexibility and future maintainability, once we use something existing, we're stuck with the provided pattern and implementation

oak flare May 17, 2024, 11:22 PM

#

I would disagree

light loom May 17, 2024, 11:22 PM

#

Here we can just change, extend and do anything

oak flare May 17, 2024, 11:22 PM

#

we can do with existing as well?

light loom May 17, 2024, 11:23 PM

#

Sure, but the logic is so small and simple, the only difference at the moment is the class name and method names, in concept it's the same style as a Future

oak flare May 17, 2024, 11:23 PM

#

hm idk

#

but like CompletableFuture already comes with all the features, like chaining etc

#

and it is easier for user of the libary

#

they dont need to look up another way of the same shit

light loom May 17, 2024, 11:26 PM

#

Maybe but it's really a small nitpick and I like knowing that I have complete control over our AsyncResponse

oak flare May 17, 2024, 11:27 PM

#

well you got complete control over completable future as well

light loom May 17, 2024, 11:27 PM

#

We don't

oak flare May 17, 2024, 11:27 PM

#

you do

#

you can simply extend it

light loom May 17, 2024, 11:27 PM

#

Yeah that is an option

oak flare May 17, 2024, 11:27 PM

#

and then still return completable future

light loom May 17, 2024, 11:27 PM

#

I'm okay to explore extending

#

Because that retains our control

oak flare May 17, 2024, 11:28 PM

#

or if you need to introduce smth new you return your new class

#

the javadocs even shares an example for extending it

#

there is not a single final method

#

anyways good night

#

so maybe think about it peepo_heart

floral halo May 18, 2024, 12:18 AM

#

light loom Oversight, if it doesn't need to be recreated, we can move it outside <:peepo_he...

speaking of which, there is an object mapper in DiscordResponseParser that is being instantiated with every method call, it can be updated to use the object mapper that already exists at the field level

light loom May 18, 2024, 12:22 AM

#

floral halo speaking of which, there is an object mapper in DiscordResponseParser that is be...

Good catch if that's the case, it should be class level

oak flare May 18, 2024, 5:13 AM

#

guild.channel().createReaction(message.channelId(), message.id(), ":joy:");

randomly found issue with this:

07:13:07.170 [pool-2-thread-1] ERROR com.javadiscord.jdi.internal.api.DiscordRequestDispatcher - Failed to send request to https://discord.com/api/channels/1237095281846255699/messages/1241257237192904716/reactions/:joy:/@me
java.lang.NullPointerException: null
    at java.base/java.util.Objects.requireNonNull(Objects.java:233) ~[?:?]
    at java.net.http/jdk.internal.net.http.HttpRequestBuilderImpl.PUT(HttpRequestBuilderImpl.java:192) ~[java.net.http:?]
    at com.javadiscord.jdi.internal.api.DiscordRequestDispatcher.sendRequest(DiscordRequestDispatcher.java:98) ~[api-1.0.0.jar:?]
    at com.javadiscord.jdi.internal.api.DiscordRequestDispatcher.run(DiscordRequestDispatcher.java:58) ~[api-1.0.0.jar:?]
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
    at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

#

the lines in the DiscordRequestDispatcher might not match with main

#

as I modified it

#

// DiscordRequestDispatcher.java:98
requestBuilder.PUT(discordRequestBuilder.getBody());

#

ah well

#

seems like the body is null by default

#

and the CreateReactionRequest is not setting it:

    @Override
    public DiscordRequestBuilder create() {
        return new DiscordRequestBuilder()
                .put()
                .path(
                        "/channels/%s/messages/%s/reactions/%s/@me"
                                .formatted(channelId, messageId, emoji));
    }

#

body should be body = HttpRequest.BodyPublishers.noBody() by default instead of null ig?

light loom May 18, 2024, 8:29 AM

#

Good catch, yeah it should be if that's what works

#

Can you raise a PR and a test for it too?

#

Or create the test in my branch?

#

If you don't want to that's fine, I can do it

oak flare May 18, 2024, 12:30 PM

#

yeah I can do that

#

maybe later though

#

but if I do I just going to add it in your branch, makes more sense

#

btw why do we use this kind of switch in the DiscordRequestDispatcher:

switch (discordRequestBuilder.getMethod()) {
    case HttpMethod.GET:
        requestBuilder.GET();
        break;
    case HttpMethod.POST:
        requestBuilder.POST(discordRequestBuilder.getBody());
        break;
    case HttpMethod.DELETE:
        requestBuilder.DELETE();
        break;
    case HttpMethod.PUT:
        requestBuilder.PUT(discordRequestBuilder.getBody());
        break;
    case HttpMethod.PATCH:
        requestBuilder.method(HttpMethod.PATCH.name(), discordRequestBuilder.getBody());
        break;
    default:
        throw new IllegalArgumentException(
                "Unsupported HTTP method: " + discordRequestBuilder.getMethod());
}

#

why not enhanced switch with ->?

#

also what do we do with the example bot module? I think it should only contain print statements by default.
For example currently it does this:

public class ExampleNoAnnotate implements EventListener {

    @Override
    public void onMessageCreate(Message message, Guild guild) {
        System.out.println("Received a message in ExampleNoAnnotate");
        guild.channel()
                .createInvite(1232064259085828228L, 1000, 10, true)
                .onSuccess(res -> System.out.println("Result: " + res))
                .onError(System.err::println);

        guild.auditLogs()
                .getAuditLogs(new GetAuditLogsBuilder())
                .onSuccess(res -> System.out.println("Result: " + res))
                .onError(System.err::println);
    }
}

and this doesnt even work if you dont have permissions set for this

#

also it is annoying that I always need to manually rollback all the example files to not create unwanted changes

#

any way to fix that?

light loom May 18, 2024, 12:54 PM

#

oak flare also it is annoying that I always need to manually rollback all the example file...

I usually do it through intellij and just keep the files I don't want committed unticked

light loom May 18, 2024, 12:55 PM

#

oak flare why not enhanced switch with `->`?

These are very small things that don't make any difference to maintainability and functionality but if you wanna change it feel free

oak flare May 18, 2024, 12:56 PM

#

light loom These are very small things that don't make any difference to maintainability a...

well readability is important as well, all the break statements are useless

light loom May 18, 2024, 12:56 PM

#

It's also readable :p

#

But I don't mind the change if you find it less readable

oak flare May 18, 2024, 12:57 PM

#

cat_thumbs_up

oak flare May 18, 2024, 12:57 PM

#

oak flare also what do we do with the example bot module? I think it should only contain p...

what about this?

light loom May 18, 2024, 12:58 PM

#

I didn't understand the question, can you explain again? Sorry

oak flare May 18, 2024, 12:59 PM

#

basically the default code throwing exception for me

light loom May 18, 2024, 12:59 PM

#

oooh

oak flare May 18, 2024, 12:59 PM

#

because of some bot permissions iirc

light loom May 18, 2024, 12:59 PM

#

Uncaught exception?

#

Or is it the onError

oak flare May 18, 2024, 12:59 PM

#

uh cant tell right now

#

let me test real quick

light loom May 18, 2024, 1:00 PM

#

If it's onError then that's all cool - the example itself is pretty crap, we should make a proper example lol

oak flare May 18, 2024, 1:00 PM

#

java.lang.Exception: Received HTTP status code 403 {"message": "Missing Permissions", "code": 50013}
com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type `java.util.ArrayList<com.javadiscord.jdi.core.models.audit_log.AuditLogEntry>` from Object value (token `JsonToken.START_OBJECT`)
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1, column: 1]

light loom May 18, 2024, 1:01 PM

#

Damnit

#

We'll get there

#

Slowly does it 😄

oak flare May 18, 2024, 1:02 PM

#

yeah all good

#

just wanted to mention it

oak flare May 18, 2024, 1:05 PM

#

light loom I usually do it through intellij and just keep the files I don't want committed ...

ok yeah thats easier I just noticed, but what happens if I change branch again? does it keep the uncommited changes?

#

bruh seems like git couldnt properly install pre commit hook

#

well there is none peepo_think

#

did I miss smth?

light loom May 18, 2024, 1:29 PM

#

oak flare did I miss smth?

No you're right there isn't any

#

It's just a GHA

light loom May 18, 2024, 1:29 PM

#

oak flare ok yeah thats easier I just noticed, but what happens if I change branch again? ...

You can't do this, you have to commit or stash your changes before switching branches

placid wharfBOT May 18, 2024, 1:30 PM

#

@light loom

wazei

create issue for using cached objects!!

oak flare May 18, 2024, 1:44 PM

#

light loom You can't do this, you have to commit or stash your changes before switching bra...

Ok good to know, especially putting bot token again and again can be annoying

oak flare May 18, 2024, 3:35 PM

#

Got pinged?

floral halo May 18, 2024, 3:36 PM

#

Couple of issues with GatewayEventListener line 44:

long guildId = (long) guildIdField.get(event);

Sometimes guildIdField.get(event) returns String instead of Long, so it throws ClassCastException

When it does return Long, it returns Long object instead of long primitive, so it throws ClassCastException: cannot cast java.lang.Long to long

#

So I think there needs to be some branching logic that checks for instanceof String, and the existing cast should be (Long) instead of (long)

#

just some screenshots for verification

#

the String issue looks like something to do with message pin (and I discovered it when pinning a message with the bot)

light loom May 18, 2024, 3:52 PM

#

It's coming back as a String!?

#

Amazing find @floral halo !

floral halo May 18, 2024, 3:53 PM

#

yeah, is it something to do with the codecs perhaps? I'm still learning the system

light loom May 18, 2024, 3:54 PM

#

It's discord sending it as a String, they make things so hard pepe_sad

#

But it's not a hard issue :p just annoying that it's an issue to begin with

floral halo May 18, 2024, 3:54 PM

#

haha yeah

light loom May 18, 2024, 3:57 PM

#

#

Guys we have a new guy

#

He randomly joined my server

#

And said "hey I wanna contribute"

floral halo May 18, 2024, 3:59 PM

#

haha nice!

light loom May 18, 2024, 3:59 PM

#

I didn't expect this at all

oak flare May 18, 2024, 4:03 PM

#

Pretty nice

light loom May 18, 2024, 4:12 PM

#

They're gonna be working on logging

floral halo May 18, 2024, 4:20 PM

#

light loom It's discord sending it as a String, they make things so hard <:pepe_sad:9795242...

I think they had javascript in mind haha

oak flare May 18, 2024, 4:25 PM

#

light loom They're gonna be working on logging

ok nice

#

ping me if I can continue with flow ids

light loom May 18, 2024, 7:10 PM

#

he...

#

did it in the wrong repo...

oak flare May 18, 2024, 7:10 PM

#

wdym

light loom May 18, 2024, 7:10 PM

#

comments on: java-discord-api

#

does work in lj-discord-bot

oak flare May 18, 2024, 7:11 PM

#

there are 2 repos?

#

lel

light loom May 18, 2024, 7:11 PM

#

https://github.com/javadiscord/lj-discord-bot

#

this repo has 0 issues

#

its just a bot using JDA

oak flare May 18, 2024, 7:11 PM

#

lmao

floral halo May 18, 2024, 7:40 PM

#

I think there is an issue in private DiscordResponseParser::parseResponse

It tries to deserialize the response directly into a List, but looks like the repsonse is actually a Map of Lists, so the response needs to be deserialized as a Map, then the appropriate list needs to be fetched by key, e.g. "audit_log_entries"

Otherwise, it throws MismatchedInputException

#

I can create issues on the GitHub repo, but I prefer to get confirmation before doing so, that way I don't create duplicate tickets or misreport something that isn't actually a bug

oak flare May 18, 2024, 8:03 PM

#

oak flare ``` java.lang.Exception: Received HTTP status code 403 {"message": "Missing Perm...

you talking about this for example?

light loom May 18, 2024, 8:03 PM

#

@floral halo mind writing all these out on GH please? It's just I haven't got time to go through the stuff you've raised atm

floral halo May 18, 2024, 9:18 PM

#

light loom <@1125865169902374913> mind writing all these out on GH please? It's just I have...

sure no problem!

floral halo May 18, 2024, 9:21 PM

#

oak flare you talking about this for example?

yup that's it. the ObjectMapper is trying to deserialize the response json directly into a List, but the list is inside a Map

floral halo May 18, 2024, 10:00 PM

#

added a few issues to the backlog

oak flare May 18, 2024, 10:00 PM

#

thanks peepo_heart

floral halo May 18, 2024, 10:06 PM

#

oak flare ``` java.lang.Exception: Received HTTP status code 403 {"message": "Missing Perm...

Actually, in this case, the mapper is trying to deserialize the error message into a list, when there is no list at all. I ran into this as well. When there is no error message, however, it still doesn't deserialize properly because the list is inside a map

floral halo May 19, 2024, 1:29 PM

#

Hey can someone authorize me to push branches to the repo? https://github.com/NightTripperID

GitHub

NightTripperID - Overview

NightTripperID has 9 repositories available. Follow their code on GitHub.

light loom May 19, 2024, 1:29 PM

#

wym?

floral halo May 19, 2024, 1:30 PM

#

or do I have to fork the repo?

light loom May 19, 2024, 1:30 PM

#

yeah

#

fork and create PR 🙂

floral halo May 19, 2024, 1:30 PM

#

okies mb pepekek

light loom May 19, 2024, 1:31 PM

#

npp

#

i just saw the issues - they look well written btw ty peepo_heart

floral halo May 19, 2024, 1:31 PM

#

thanks!

#

I couldn't put labels on them so you'll have to do that part

light loom May 19, 2024, 1:54 PM

#

that's np 🙂

light loom May 19, 2024, 4:06 PM

#

light loom

so WARPI lol?

#

what does WARPI stand for again? lol

oak flare May 19, 2024, 4:07 PM

#

nah bro

#

idk

#

@floral halo thanks for creating the #107 issue, forgot to peepo_heart

light loom May 19, 2024, 4:10 PM

#

who's mennafabio on GH?

#

https://github.com/javadiscord/java-discord-api/pull/100

oak flare May 19, 2024, 4:10 PM

#

idk might not even be on this server 🤷‍♂️

light loom May 19, 2024, 4:10 PM

#

lmfao

#

i think it is

#

somebody here

oak flare May 19, 2024, 4:11 PM

#

ask him

light loom May 19, 2024, 4:13 PM

#

I'm gonna work on some of these bug tickets

oak flare May 19, 2024, 4:14 PM

#

I might as well

floral halo May 19, 2024, 4:22 PM

#

oak flare <@1125865169902374913> thanks for creating the #107 issue, forgot to <:peepo_hea...

no problem!

light loom May 19, 2024, 4:34 PM

#

28 open issues - amazing gigachad

floral halo May 19, 2024, 4:35 PM

#

light loom 28 open issues - amazing <:gigachad:930095729400250378>

can you assign me to 104?

light loom May 19, 2024, 4:35 PM

#

for sure! done peepo_heart

floral halo May 19, 2024, 4:37 PM

#

106 and 103 are pretty much the same issue, I think that one will require some consideration on how to solve

light loom May 19, 2024, 4:41 PM

#

106 is strange

#

we should only be decoding on a 200 error

#

unless they send a 200 with error lol

floral halo May 19, 2024, 4:45 PM

#

it came for me when audit logs are requested

#

                .getAuditLogs(new GetAuditLogsBuilder())
                .onSuccess(res -> System.out.println("Result: " + res))
                .onError(System.err::println);```

#

but you get audit logs, users, webhooks, everything basically

light loom May 19, 2024, 4:56 PM

#

yeah that's how it should work

floral halo May 19, 2024, 5:03 PM

#

so there probably needs to be some sort of mapping for elementType to response key, (e.g. AuditLogEntry.class maps to "audit_log_entries"), so it knows which list to parse, and also a way to know how to parse error responses, and afaik it's not sending 200 with error, the error response I got was a 403

light loom May 19, 2024, 5:12 PM

#

hmm

#

I would assume the onError would have kicked

#

Maybe there's a small bug there

floral halo May 19, 2024, 7:06 PM

#

hmm needs further investigation I suppose spongehmm

light loom May 19, 2024, 7:08 PM

#

    private <T> void success(
            Class<T> type, DiscordResponse response, AsyncResponse<T> asyncResponse) {
        if (response.status() >= 200 && response.status() < 300) {
            try {
                T result = OBJECT_MAPPER.readValue(response.body(), type);
                asyncResponse.setResult(result);
            } catch (JsonProcessingException e) {
                asyncResponse.setException(e);
            }
        } else {
            asyncResponse.setException(
                    new Exception(
                            "Received HTTP status code "
                                    + response.status()
                                    + " "
                                    + response.body()));
        }
    }

#

    public <T> AsyncResponse<T> callAndParse(Class<T> clazz, DiscordRequest request) {
        AsyncResponse<T> asyncResponse = new AsyncResponse<>();
        DiscordResponseFuture future = dispatcher.queue(request);
        future.onSuccess(res -> success(clazz, res, asyncResponse));
        future.onError(asyncResponse::setException);
        return asyncResponse;
    }

#

it looks like it should just work lol

#

debugging timeeee

#

will do it once ala jshell gets deployed

oak flare May 19, 2024, 7:10 PM

#

I can do some debugging

#

link issue

floral halo May 19, 2024, 7:11 PM

#

    private final DiscordResponseParser responseParser;
    private final long guildId;

    public AuditLogsRequest(DiscordResponseParser responseParser, long guildId) {
        this.responseParser = responseParser;
        this.guildId = guildId;
    }

    public AsyncResponse<List<AuditLogEntry>> getAuditLogs(GetAuditLogsBuilder builder) {
        return responseParser.callAndParseList(
                AuditLogEntry.class, builder.guildId(guildId).build());
    }
}```

#

it's because getAuditLogs directly calls responseParser.callAndParseList

#

https://github.com/javadiscord/java-discord-api/issues/103

GitHub

`DiscordResponseParser::parseResponse` MisMatchedInputException wit...

Description of the Issue DiscordResponseParser::parseResponse throws MismatchedInputException when trying to deserialize audit logs from response json valid_response.json return objectMapper.readVa...

light loom May 19, 2024, 7:15 PM

#

okay the logic is obvious now

floral halo May 19, 2024, 7:15 PM

#

yeah mb the issue ticket is a bit misleading

light loom May 19, 2024, 7:15 PM

#

callAndParseList just needs to check the status

#

which it doesn't do before trying to parse to a List

#

at least that's one way

floral halo May 19, 2024, 7:16 PM

#

well, yes, for the error status, that is true

#

but on success, it appears the list needs to be extracted from a map

light loom May 19, 2024, 7:17 PM

#

so a new method on top

molten tusk May 19, 2024, 7:18 PM

#

welcome @floral halo

floral halo May 19, 2024, 7:18 PM

#

molten tusk welcome <@1125865169902374913>

thank you!

floral halo May 19, 2024, 7:22 PM

#

light loom ```java private <T> void success( Class<T> type, DiscordResponse...

one more detail, private <T> void success is called if the future is successful in callAndParse, but it is not called if the future is successful in callAndParseList, just to avoid confusion

light loom May 19, 2024, 7:23 PM

#

do you want to work on it? 🙂

floral halo May 19, 2024, 7:23 PM

#

sure I can give it a shot

light loom May 19, 2024, 7:23 PM

#

i can help as much as you need

light loom May 19, 2024, 7:56 PM

#

@oak flare

#

#

u were right!!

oak flare May 19, 2024, 7:57 PM

#

lel

light loom May 19, 2024, 7:57 PM

#

Can you review his PR?

oak flare May 19, 2024, 7:57 PM

#

link

light loom May 19, 2024, 7:57 PM

#

https://github.com/javadiscord/java-discord-api/pull/100

GitHub

feat: adding stop() method by mennafabio · Pull Request #100 · java...

Describe the PR
This feature resolves #98 by adding a stop method to interrupt and close all thread pools and connections sockets within 30 seconds timeframe.
Checklist

This PR contains environme...

#

I'm suprised we're getting randoms contributing, it's awesome

oak flare May 19, 2024, 7:58 PM

#

yeah very nice

light loom May 19, 2024, 7:58 PM

#

(randoms from the internet, not this server)

oak flare May 19, 2024, 8:02 PM

#

is a websocketmanager and all its stuff instance heavy?

#

like does it make sense to move the initialization in the constructor and then using the start method?

#

not sure how all of them work though

light loom May 19, 2024, 8:03 PM

#

in which constructor?

oak flare May 19, 2024, 8:03 PM

#

Discord.java and start method

light loom May 19, 2024, 8:04 PM

#

no i don't think so - i want to keep it as simple to call

oak flare May 19, 2024, 8:04 PM

#

?

#

like my question is if they actually do anything before this line:

webSocketManagerProxy.start(connectionMediator);

floral halo May 19, 2024, 8:08 PM

#

so it looks like just the audit log entries are coming as a map, all the other DiscordRequests that utilize callAndParseList appear to be coming as lists, so it's unique to that endpoint. I tried it in Postman and it's also coming as a Map there as well. Was this this what was expected to come from this endpoint?

#

So I think, yeah, another method, callAndParseMapToList or something would be the best solution, and you can pass a key as a parameter

light loom May 19, 2024, 8:11 PM

#

oak flare like my question is if they actually do anything before this line: ```java webSo...

ill check soon

light loom May 19, 2024, 8:12 PM

#

floral halo so it looks like just the audit log entries are coming as a map, all the other D...

we just made guesses, the phase rn is testing and correcting - this issue might not be unique to this endpoint

floral halo May 19, 2024, 8:13 PM

#

light loom we just made guesses, the phase rn is testing and correcting - this issue might ...

cool, no worries, I think I can draft a solution that can be applied to any other endpoints we find that might fit this bill

oak flare May 19, 2024, 8:18 PM

#

uh I cant review using intellij?

orchid portal May 19, 2024, 8:19 PM

#

@oak flare wazel denied this earlier

oak flare May 19, 2024, 8:19 PM

#

and?

#

he approved it

#

now

#

lol

orchid portal May 19, 2024, 8:19 PM

#

oak flare he approved it

he did?

oak flare May 19, 2024, 8:20 PM

#

ah nvm

#

it was the other pr

#

mb

#

any reason why he denied it?

light loom May 19, 2024, 9:13 PM

#

uh

#

lol

floral halo May 19, 2024, 9:28 PM

#

light loom i can help as much as you need

can you add me to 103 and 106?
pr to fix those:
https://github.com/javadiscord/java-discord-api/pull/113

GitHub

Fixes bugs in `DiscordResponseParser` by NightTripperID · Pull Requ...

Describe the PR

Adds response parsing for map bodies
Updates AuditLogEntryRequest to parse from map instead of list
Fixes error handling for bad requests
relates to issues 103 and 106

winter jungle May 20, 2024, 1:37 PM

#

light loom https://github.com/javadiscord/java-discord-api/pull/100

Hey guys, im new here. Im the "mennafabio" guy from github. Found your Discord Server, happy to be here. I dont have much to do with Discord Bots and that topic but looking forward to learn more about that :)!

oak flare May 20, 2024, 1:41 PM

#

Hi, thanks for your contribution

#

note that this server isnt technically related to the project itself

winter jungle May 20, 2024, 1:42 PM

#

Sure, im glad i finally found an interesting "Java" Topic based Discord Server.

light loom May 20, 2024, 1:43 PM

#

welcome! I'm surpised you found us on TJ!

winter jungle May 20, 2024, 1:43 PM

#

also im looking at your comments rn, so about the little stop method in the setter or method. Isnt there then redundant or duplicated code? since we already then have the "stop" method.

winter jungle May 20, 2024, 1:44 PM

#

light loom welcome! I'm surpised you found us on TJ!

Actually i found this project via the "good first issues" website, since i've never contributed to any project, i wanted to try this out and there i saw some first grabs for this project

light loom May 20, 2024, 1:44 PM

#

winter jungle Actually i found this project via the "good first issues" website, since i've ne...

what good first issue website? 👀

oak flare May 20, 2024, 1:44 PM

#

lol

winter jungle May 20, 2024, 1:45 PM

#

this one https://goodfirstissues.com/

Good First Issues

Good First Issues empowers first-time contributors of open-source software. This website is primarily targeted at developers who want to contribute to open source software but do not know where or how to start. By providing developers with filters, the website empowers them to browse and select issues/repositories based on programming languages ...

#

just googled and this website came up, and if you filter "java" your project is also there.

light loom May 20, 2024, 1:45 PM

#

wow that's insane

winter jungle May 20, 2024, 1:45 PM

#

think there is a scanner whichs scans github labels and index it in there

light loom May 20, 2024, 1:45 PM

#

pretty cool though

oak flare May 20, 2024, 1:45 PM

#

lol thats nice

light loom May 20, 2024, 1:46 PM

#

i'm surprised to see organic contributors - really nice

oak flare May 20, 2024, 1:46 PM

#

winter jungle also im looking at your comments rn, so about the little stop method in the sett...

I was talking about replacing the setter

#

public class DiscordRequestDispatcher implements Runnable {
    // ...
    private boolean running = false;

    // ...
    
    @Override
    public void run() {
        running = true;
        while (running) {
            // ...
        }
    }

    public void stop() {
        running = false;
    }

}

I thought about smth like this instead

#

and then maybe introduce logic if we want to let already queued requests to run

#

same idea what executors shutdown vs shutdownNow does maybe

light loom May 20, 2024, 1:53 PM

#

oak flare and then maybe introduce logic if we want to let already queued requests to run

yeah possible 2 variants, a graceful shutdown were the dispatcher rejects additional requests but still finishes the current queue

#

and then a forced shutdown that completely stops the dispatcher

winter jungle May 20, 2024, 2:09 PM

#

But then the while condition of "running" becomes useless i think, since it checks if it is true but thats always the case since we are setting running = true always first in the run() method

#

or maybe i understand the Runnable interface wrong, could also be the case 😄

oak flare May 20, 2024, 2:10 PM

#

well its supposed to be a while true loop until someone uses the stop method to stop the loop

light loom May 20, 2024, 2:13 PM

#

winter jungle But then the while condition of "running" becomes useless i think, since it chec...

run() gets invoked by the start() however, if you set it in the constructor the value will be running = true but the thread might not have started, so it's not actually running

#

if we had a getter e.g. isRunning that would return true even if the thread had not started

light loom May 20, 2024, 2:14 PM

#

oak flare well its supposed to be a while true loop until someone uses the stop method to ...

something to think about, should running be Atomic?

oak flare May 20, 2024, 2:14 PM

#

yeah I was questioning smth like that as well peepo_think

light loom May 20, 2024, 2:15 PM

#

I think maybe but my brain isn't working right now lol

#

since stop() will be called by another thread, it should be ig

winter jungle May 20, 2024, 2:28 PM

#

Mhh good point, that would make the boolean thread-safe. I've implemented the stop() also now in DiscordRequestDispatcher with a TODO for the implementation. Think it makes sense to open a new Isse for that since it has nothign to do with the actual Discord stop method.

#

I also need to think on how to handle the queue in that stop method peepo_think

oak flare May 20, 2024, 2:35 PM

#

light loom since `stop()` will be called by another thread, it should be ig

wouldnt volatile be enough here?

#

well no ig

#

both threads write to the variable

#

well im not sure

#

not that into thread safety

light loom May 20, 2024, 2:53 PM

#

WTF

#

IT DELETED THE OP

oak flare May 20, 2024, 2:53 PM

#

?

light loom May 20, 2024, 2:54 PM

#

I was just updating the main post with the list of contributors and then dyno bot said "don't mass mention members"

#

and deleted the entire post

#

lol?

#

@lavish nest

oak flare May 20, 2024, 2:55 PM

#

hell nah

#

thanks dyno

light loom May 20, 2024, 2:55 PM

#

this is so stupid 😐

oak flare May 20, 2024, 2:55 PM

#

well I got the message in logs

#

if you want

light loom May 20, 2024, 2:55 PM

#

can you keep it safe so I can figure out how to bring it back

oak flare May 20, 2024, 2:56 PM

#

just stupid that it deleted the original message, looks weird in #1150852739467849829

light loom May 20, 2024, 3:05 PM

#

i am actually so annoyed lol

oak flare May 20, 2024, 3:08 PM

#

same

#

that just stupid

light loom May 20, 2024, 3:09 PM

#

https://github.com/javadiscord/java-discord-api

GitHub

GitHub - javadiscord/java-discord-api: A wrapper over the discord A...

A wrapper over the discord API to create bots using Java - javadiscord/java-discord-api

light loom May 20, 2024, 3:09 PM

#

light loom https://github.com/javadiscord/java-discord-api

oak flare May 20, 2024, 3:10 PM

#

sad pin lmao

light loom May 20, 2024, 3:14 PM

#

well - i was using it to keep track of all the members that have contributed - we have 8 people that have raised PRs and they have been merged, with 4 people with work in progress, it was a way for me to keep track of you all and to show that you're efforts were not going unnoticed - still - we can take the L with the original post and continue as normal peepo_heart

molten tusk May 20, 2024, 3:17 PM

#

Stupid dyno reeee

floral halo May 20, 2024, 7:11 PM

#

It's not dyno's fault, he was just programmed that way pepe_sad

plain ledge May 20, 2024, 7:34 PM

#

floral halo It's not dyno's fault, he was just programmed that way <:pepe_sad:9795242964624...

wut wut

orchid portal May 21, 2024, 12:40 AM

#

@light loom https://docs.oracle.com/en/java/javase/21/docs/api/java.compiler/javax/annotation/processing/AbstractProcessor.html

AbstractProcessor (Java SE 21 & JDK 21)

declaration: module: java.compiler, package: javax.annotation.processing, class: AbstractProcessor

orchid portal May 22, 2024, 6:41 AM

#

i tried fixing the spotless

#

will make a pr

#

pls merge and we'll improve it over time

worthy flower May 22, 2024, 8:56 AM

#

hey guys

#

i think about getting started soon, anybody helps me to find something to do ?

molten tusk May 22, 2024, 9:09 AM

#

pick any issues

#

or find bugs

worthy flower May 22, 2024, 9:22 AM

#

molten tusk or find bugs

I may pick something that is already in progress with someone else

orchid portal May 22, 2024, 9:23 AM

#

worthy flower I may pick something that is already in progress with someone else

see the job board

worthy flower May 22, 2024, 9:24 AM

#

where ?

orchid portal May 22, 2024, 9:26 AM

#

worthy flower where ?

https://github.com/orgs/javadiscord/projects/1/views/2

GitHub

Java Discord • javadiscord

Java Discord

worthy flower May 22, 2024, 9:33 AM

#

orchid portal https://github.com/orgs/javadiscord/projects/1/views/2

alright i see it

#

what i do next ?

orchid portal May 22, 2024, 9:44 AM

#

worthy flower what i do next ?

pick one from redy

worthy flower May 22, 2024, 9:44 AM

#

how do i pick it ?

orchid portal May 22, 2024, 9:45 AM

#

worthy flower how do i pick it ?

comment on the issue

worthy flower May 22, 2024, 9:45 AM

#

orchid portal comment on the issue

ah !

orchid portal May 22, 2024, 9:45 AM

#

i'll assign u

worthy flower May 22, 2024, 9:45 AM

#

alr thanks

molten tusk May 22, 2024, 2:43 PM

#

you can do #81

lavish nest May 22, 2024, 3:48 PM

#

orchid portal <@821143476455342120> https://docs.oracle.com/en/java/javase/21/docs/api/java.co...

wazei decided to take some time off, and focus on himself peepo_heart

#

so in terms of his responsibilities and commitments, everything he has been contributing to on this server is on pause, including this project

oak flare May 22, 2024, 3:50 PM

#

cant we continue? or would you say we should stop and wait for him?

lavish nest May 22, 2024, 3:50 PM

#

he is currently not on the server, so please try to respect that and not DM him ^^

molten tusk May 22, 2024, 3:51 PM

#

he has opened pull request today

lavish nest May 22, 2024, 3:51 PM

#

he deserves break peepo_heart

lavish nest May 22, 2024, 3:51 PM

#

oak flare cant we continue? or would you say we should stop and wait for him?

yeah, of course ^^

molten tusk May 22, 2024, 3:54 PM

#

we can give wazei a surprise for when he is back peepo_heart

worthy flower May 22, 2024, 6:57 PM

#

molten tusk you can do #81

it's in review ?

floral halo May 22, 2024, 7:28 PM

#

@oak flare when you get the chance, can you move 103, 104, and 106 to done? The code for those has been merged

oak flare May 22, 2024, 7:28 PM

#

yea

#

well seems like the issue arent linked to the prs

#

because the issues are still open

#

instead of relates to issue ... use github keywords like

resolves #103

floral halo May 22, 2024, 7:30 PM

#

hmm, I tried linking the prs to the issues but I couldn't figure it out, not sure if it is a permissions thing

#

oh is it a keyword thing?

oak flare May 22, 2024, 7:31 PM

#

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

#

#

well editing afterwards wont close them automatically anymore

#

but I am going to close them manually cat_thumbs_up

floral halo May 22, 2024, 7:34 PM

#

thanks

oak flare May 22, 2024, 7:34 PM

#

which pr relates to #108?

floral halo May 22, 2024, 7:34 PM

#

let me check

oak flare May 22, 2024, 7:35 PM

#

uh I mean 104

#

but it is fixed by 108

floral halo May 22, 2024, 7:35 PM

#

yes, issue 104 is pr 108

oak flare May 22, 2024, 7:36 PM

#

all should be closed now

molten tusk May 22, 2024, 8:39 PM

#

worthy flower it's in review ?

I don't know

orchid portal May 22, 2024, 10:15 PM

#

lavish nest wazei decided to take some time off, and focus on himself <:peepo_heart:88548092...

yea i talked ho him

lavish nest May 22, 2024, 10:16 PM

#

I know, just wanted to let everyone else know ^^

orchid portal May 22, 2024, 10:16 PM

#

but he also said this project doesnt have to be on pause

#

he'll do his part from github

lavish nest May 22, 2024, 10:17 PM

#

yup ^^

#

but also do not want people to ping him too much, or expect feedback from him

#

he will probably be low availability, and that's fine, he deserves a break peepo_heart

#

doesn't mean project won't continue to function

#

I have maintainer role now as well, and will be here if needed for my access

oak flare May 22, 2024, 10:21 PM

#

actually we all got maintainer lol

lavish nest May 22, 2024, 10:24 PM

#

yeah, I know

#

for people currently working on it

#

things change with time tho, people come and go, it's and open-source project

#

they have other things they need to take care of

#We're making a wrapper over the Discord API using Java!!