#dev-contrib | Python | Page 106

fallen patrol Apr 20, 2021, 8:52 PM

#

what do you think, after seeing the above screenshot

patent pivot Apr 20, 2021, 8:53 PM

#

I meant figured out in the sense of working together

fallen patrol Apr 20, 2021, 8:53 PM

#

ah

#

yes

#

btw this can be the same role, right?

#

patent pivot Apr 20, 2021, 8:54 PM

#

uhhhh

#

yeah

fallen patrol Apr 20, 2021, 8:55 PM

#

cool

stable mountainBOT Apr 20, 2021, 8:55 PM

#

Hey @fallen patrol! I noticed you posted a seemingly valid Discord API token in your message and have removed your message. This means that your token has been compromised. Please change your token immediately at: https://discordapp.com/developers/applications/me

Feel free to re-post it with the token removed. If you believe this was a mistake, please let us know!

fallen patrol Apr 20, 2021, 8:55 PM

#

uh

#

yep am doing well

patent pivot Apr 20, 2021, 8:56 PM

#

lol

#

how did that happen

fallen patrol Apr 20, 2021, 8:56 PM

#

oh nothing

#

just didn't click the ide

#

and then typed it and pasted it and entered it

#

sadly

#

blink

#

since staff can edit this being its a wiki page

#

dependancies

patent pivot Apr 20, 2021, 8:58 PM

#

we're in a wiki freeze right now, no edits

fallen patrol Apr 20, 2021, 8:58 PM

#

dependencies

#

smh

#

~~typos tho~~

patent pivot Apr 20, 2021, 8:59 PM

#

there are pros & cons to it. cons are that if the system fails for whatever reason then we've just published someones token wider, the real killer would be discord adding a token invalidate endpoint

patent pivot Apr 20, 2021, 8:59 PM

#

fallen patrol ~~typos tho~~

we'll hopefully transition to dewiki soon so that non-staff can contribute typo fixes

fallen patrol Apr 20, 2021, 9:00 PM

#

also

#

how do you install dependancies with pipenv

#

through a pipfile

patent pivot Apr 20, 2021, 9:00 PM

#

pipenv sync

fallen patrol Apr 20, 2021, 9:00 PM

#

that errored

#

oh

brazen charm Apr 20, 2021, 9:00 PM

#

Mind the --dev

fallen patrol Apr 20, 2021, 9:01 PM

#

oop

#

did i need those?

brazen charm Apr 20, 2021, 9:02 PM

#

That'll install things like precommit and flake8 so you can lint locally

fallen patrol Apr 20, 2021, 9:03 PM

#

bro what config file

#

#

why are

sleek steppe Apr 20, 2021, 9:03 PM

#

yes

patent pivot Apr 20, 2021, 9:03 PM

#

ah nice

sleek steppe Apr 20, 2021, 9:04 PM

#

No, nothing's in dev-log

fallen patrol Apr 20, 2021, 9:07 PM

#

i am totally stealing this!```py
[scripts]
start = "python -m bot"
lint = "pre-commit run --all-files"
precommit = "pre-commit install"

#

taught me something i don't know!

sleek steppe Apr 20, 2021, 9:07 PM

#

What PR? The eval one?

#

Redundancy

#

Wellll no

#

str(command) is the same as command.qualified_name, not command.name

#

!d discord.ext.commands.Command.qualified_name

stable mountainBOT Apr 20, 2021, 9:09 PM

#

discord.ext.commands.Command.qualified\_name


qualified_name```
Retrieves the fully qualified command name.

This is the full parent name with the command name as well. For example, in `?one two three` the qualified name would be `one two three`.

clever wraith Apr 20, 2021, 9:10 PM

#

man i guess discord mobile doesnt really like ascii art

#

.catify

sleek steppe Apr 20, 2021, 9:11 PM

#

def qualified_name(self):
    parent = self.full_parent_name
    if parent:
         return parent + ' ' + self.name
    else:
        return self.name

clever wraith Apr 20, 2021, 9:21 PM

#

@fallen patrol i'm working on a converter rn for the colors

#

yeah

#

well no, i meant converting strings to a discord.Color object

#

yeah, but i;m gonna add some niceties to it

sleek steppe Apr 20, 2021, 9:31 PM

#

@clever wraith your branches should track upstream/main so you don't have commits from other branches

clever wraith Apr 20, 2021, 9:31 PM

#

it seems it broke should i close the pr?

sleek steppe Apr 20, 2021, 9:34 PM

#

Probably, because of merge conflicts

patent pivot Apr 20, 2021, 9:34 PM

#

color converter will only work for some stuff

sleek steppe Apr 20, 2021, 9:35 PM

#

Yeah. subclassing ColourConverter should be fine

gritty wind Apr 20, 2021, 9:37 PM

#

Hey, any idea why the member mock doesn't have an async assert?

#

Or well, it's missing them for some functions

clever wraith Apr 20, 2021, 9:37 PM

#

aight fixed it is there now

sleek steppe Apr 20, 2021, 9:38 PM

#

Hmm. It seems like 50% of the time I start bot it exits with code 69 because the bot and the site are starting at the same time

gritty wind Apr 20, 2021, 9:39 PM

#

Reasoning

Added because of approved Issue
@clever wraith just a heads up, this field is meant for you to describe why you used the solution you did instead of others, not why you made the PR.

#

I've proposed reworking of that template to better explain that

#

The updated one is:

clever wraith Apr 20, 2021, 9:40 PM

#

gritty wind > ## Reasoning > > Added because of approved Issue <@456226577798135808> just a...

ohh

sleek steppe Apr 20, 2021, 9:46 PM

#

Is this good for the embed?

clever wraith Apr 20, 2021, 9:46 PM

#

@clever wraith 699 nice

sleek steppe Apr 20, 2021, 9:48 PM

#

Still think this should be in fun.py 🤔

dusky shoreBOT Apr 20, 2021, 9:51 PM

#

GitHub

PROpen Cowsay

fallen patrol Apr 20, 2021, 9:51 PM

#

sleek steppe Is this good for the embed?

Did you make every embed colored?

#

Lol

sleek steppe Apr 20, 2021, 9:52 PM

#

Hmm?

#

@clever wraith

clever wraith Apr 20, 2021, 10:02 PM

#

oop thatll be fixed momentarily

gritty wind Apr 20, 2021, 10:09 PM

#

gritty wind Hey, any idea why the member mock doesn't have an async assert?

cc @tawdry vapor I'm specifically looking at member.move_to and ctx.invoke

fallen patrol Apr 20, 2021, 10:15 PM

#

clever wraith well no, i meant converting strings to a discord.Color object

ok yes i can write cog

clever wraith Apr 20, 2021, 10:15 PM

#

ok

fallen patrol Apr 20, 2021, 10:16 PM

#

the biggest thing will actually be writing the converter lol

clever wraith Apr 20, 2021, 10:16 PM

#

did you make the fork

fallen patrol Apr 20, 2021, 10:16 PM

#

always has been

#

https://github.com/onerandomusername/sir-lancebot

#

wtaf

#

i just got a dial tone from youtube

#

@clever wraith so what i actually don't know is how to be able to convert the args and all to the rgb

clever wraith Apr 20, 2021, 10:22 PM

#

ok

#

yeah i'll work on smth

sleek steppe Apr 20, 2021, 10:22 PM

#

fallen patrol https://github.com/onerandomusername/sir-lancebot

I think he'd need to know what branch it is

clever wraith Apr 20, 2021, 10:22 PM

#

make a branch

fallen patrol Apr 20, 2021, 10:22 PM

#

haven't made it yet 😅

clever wraith Apr 20, 2021, 10:22 PM

#

WELL MAKE IT

fallen patrol Apr 20, 2021, 10:22 PM

#

its locallllll

clever wraith Apr 20, 2021, 10:24 PM

#

@fallen patrol what's that branch :angery:

fallen patrol Apr 20, 2021, 10:25 PM

#

pre-commit sorry

#

gtg make it happy

#

@vocal prairie @clever wraith what are you guys interested in doing?

clever wraith Apr 20, 2021, 10:29 PM

#

converter

#

and some PIL stuff

fallen patrol Apr 20, 2021, 10:32 PM

#

would the converter be in the same file?

#

doesn't seem like it would need to go in utils but yknow

#

it would be nicest

fallen patrol Apr 20, 2021, 10:34 PM

#

clever wraith <@!717983911824588862> what's that branch :angery:

create-color-command

clever wraith Apr 20, 2021, 10:34 PM

#

ok

#

can I have piss access

fallen patrol Apr 20, 2021, 10:34 PM

#

not sure of the structure of the project but since someone else is writing it it would result in least blame conflicts to resolve if its in a util file

fallen patrol Apr 20, 2021, 10:35 PM

#

clever wraith can I have piss access

wat

clever wraith Apr 20, 2021, 10:35 PM

#

*push access

fallen patrol Apr 20, 2021, 10:35 PM

#

no .

#

oh

clever wraith Apr 20, 2021, 10:35 PM

#

bad spelling :blobpain:

#

@fallen patrol so did you give access

fallen patrol Apr 20, 2021, 10:40 PM

#

tawdry vapor Apr 20, 2021, 10:41 PM

#

gritty wind cc <@!137073073168973824> I'm specifically looking at `member.move_to` and `ctx....

I don't know. The mixin should be responsible for making sure mocks of async functions use AsyncMock.

#

I didn't write that mixin

vocal prairie Apr 20, 2021, 10:56 PM

#

fallen patrol <@!788119126450765844> <@456226577798135808> what are you guys interested in doi...

In what?

fallen patrol Apr 20, 2021, 10:56 PM

#

sir-lancebit#677

#

sir-lancebot#677

dusky shoreBOT Apr 20, 2021, 10:56 PM

#

GitHub

IssueOpen Create a colo[u]r command

clever wraith Apr 20, 2021, 10:59 PM

#

ok

fallen patrol Apr 20, 2021, 11:01 PM

#

clever wraith ok

blink

#

you commented and expressed interest

sleek steppe Apr 20, 2021, 11:08 PM

#

Is there an issue on lancebot's repo about the .ext list command?

vocal prairie Apr 21, 2021, 12:04 AM

#

On the website, could this be changed to 100 helpers?

#

#

Um…

#

sleek steppe Apr 21, 2021, 12:04 AM

#

We have 100 helpers? Wow

thorny obsidian Apr 21, 2021, 12:04 AM

#

I think there's still a wiki freeze in place, but that does remind me to changelog!

vocal prairie Apr 21, 2021, 12:05 AM

#

wiki freeze?

#

That's on the home page btw.

thorny obsidian Apr 21, 2021, 12:08 AM

#

While things are being migrated over we're not editing things on the website. I forget which components are wiki and which aren't though

vocal prairie Apr 21, 2021, 12:09 AM

#

The main page isn't wiki, right?.

#

The image is from he index.html file.

thorny obsidian Apr 21, 2021, 12:12 AM

#

oh that's probably a PR change then

vocal prairie Apr 21, 2021, 12:15 AM

#

Can I pr it now, or should I open an issue?

clever wraith Apr 21, 2021, 12:15 AM

#

@sleek steppe regarding your review, what would you suggest? the module doesnt include any error handling

sleek steppe Apr 21, 2021, 12:16 AM

#

When you send an invalid character...does it raise an error?

clever wraith Apr 21, 2021, 12:17 AM

#

just an exception, does except Exception work?

thorny obsidian Apr 21, 2021, 12:19 AM

#

vocal prairie Can I pr it now, or should I open an issue?

It's small enough that you can just PR

vocal prairie Apr 21, 2021, 12:19 AM

#

👍

fallen patrol Apr 21, 2021, 12:19 AM

#

thorny obsidian While things are being migrated over we're not editing things on the website. I ...

all /pages are wiki

sleek steppe Apr 21, 2021, 12:24 AM

#

clever wraith just an exception, does `except Exception` work?

I guess so. You shouldn't except BaseException really, as only exceptions that are exiting exceptions (i.e SystemExit, KeyboardInterupt, GeneratorExit, CancelledError)

clever wraith Apr 21, 2021, 12:24 AM

#

alright

fallen patrol Apr 21, 2021, 12:26 AM

#

clever wraith Apr 21, 2021, 12:29 AM

#

looks good so far!!

sleek steppe Apr 21, 2021, 12:36 AM

#

Umm

#

What do those three groups of letters/numbers mean 🤔

fallen patrol Apr 21, 2021, 12:46 AM

#

that's the format of rgb

#

#

actually the hex is technically wrong for what everything else expects it as

clever wraith Apr 21, 2021, 12:47 AM

#

lmao

fallen patrol Apr 21, 2021, 12:50 AM

#

#

done

#

the basis of the command is done

#

next is a whole converter that will be about as large as the rest of it

#

and creating a script to parse the two scripts online

vocal prairie Apr 21, 2021, 12:51 AM

#

CYMK is a formula I dmed to you

fallen patrol Apr 21, 2021, 12:51 AM

#

yes

#

check dms again

#

i also gave you write access to my branch

vocal prairie Apr 21, 2021, 12:54 AM

#

Can I be assigned to site#366?

dusky shoreBOT Apr 21, 2021, 12:54 AM

#

GitHub

IssueOpen Dewikification: Search function

thorny obsidian Apr 21, 2021, 12:55 AM

#

vocal prairie Can I be assigned to site#366?

done~

vocal prairie Apr 21, 2021, 12:55 AM

#

Thanks!

sleek steppe Apr 21, 2021, 12:56 AM

#

fallen patrol

does rgb(a, b, c) work

fallen patrol Apr 21, 2021, 12:56 AM

#

wdym

sleek steppe Apr 21, 2021, 12:57 AM

#

.colour rgb(123, 221, 111)

sleek steppe Apr 21, 2021, 1:05 AM

#

fallen patrol that's the format of rgb

I thought rbg was numbers though 🤔

wicked nova Apr 21, 2021, 1:05 AM

#

I'm looking for ways to contribute to the bot, but I have 0 ideas.

#

What should I do?

fallen patrol Apr 21, 2021, 1:05 AM

#

sleek steppe I thought rbg was numbers though 🤔

oh

wicked nova Apr 21, 2021, 1:05 AM

#

RGB is numbers

fallen patrol Apr 21, 2021, 1:05 AM

#

haven't added converters yet 😂

#

that was actually hex in that invoke

vocal prairie Apr 21, 2021, 1:06 AM

#

wicked nova I'm looking for ways to contribute to the bot, but I have 0 ideas.

You can check out the issues on the repositories.

wicked nova Apr 21, 2021, 1:06 AM

#

👍

vocal prairie Apr 21, 2021, 1:06 AM

#

https://git.pydis.com/sir-lancebot and https://git.pydis.com/bot

sleek steppe Apr 21, 2021, 1:06 AM

#

Those are big embeds

sleek steppe Apr 21, 2021, 1:07 AM

#

fallen patrol haven't added converters yet 😂

You could take a look at the 1.7.1 colour converter 👀 https://github.com/Rapptz/discord.py/blob/master/discord/ext/commands/converter.py#L506-L586

fallen patrol Apr 21, 2021, 1:22 AM

#

sleek steppe You could take a look at the 1.7.1 colour converter 👀 <https://github.com/Rappt...

lol

#

i don't think i'm defining the args correctly

#

async def color(self, ctx: commands.Context, *user_color: ColorConverter)

#

should absorb the rest of it

#

unless

#

i could actually convert the type after the header

sleek steppe Apr 21, 2021, 1:23 AM

#

fallen patrol `async def color(self, ctx: commands.Context, *user_color: ColorConverter)`

No I was thinkingasync def color(self, ctx: commands.Context, *, user_color: ColorConverter)

fallen patrol Apr 21, 2021, 1:24 AM

#

is it not the same

fallen patrol Apr 21, 2021, 1:25 AM

#

sleek steppe No I was thinking`async def color(self, ctx: commands.Context, *, user_color: Co...

sleek steppe Apr 21, 2021, 1:25 AM

#

fallen patrol is it not the same

@bot.command()
def foo(ctx, *args):
    await ctx.send(args)
# <prefix>foo 1 2 3
# Sends: ('1', '2', '3')

@bot.command()
def foo(ctx, *, args):
    await ctx.send(args)

# <prefix>foo 1 2 3
# Sends: '1 2 3'

sleek steppe Apr 21, 2021, 1:26 AM

#

fallen patrol

Yeah it doesn't work with 1.5.1, only 1.7.1 (which I said in the message)

#

I was talking about your own ColourConverter

#

I just meant you should ~~copy~~ get some inspiration from that

fallen patrol Apr 21, 2021, 1:31 AM

#

sleek steppe I just meant you should ~~copy~~ get some inspiration from that

hm what? i didn't copy it LOL

sleek steppe Apr 21, 2021, 1:32 AM

#

I didn't say that

fallen patrol Apr 21, 2021, 1:46 AM

#

sleek steppe I didn't say that

100% didn't

#

anyways it now has a converter and i didn't write any of it

#

#

it defintely didn't come from 1.7

sleek steppe Apr 21, 2021, 1:47 AM

#

now you need one for CMYK, HSL and HSV

fallen patrol Apr 21, 2021, 1:47 AM

#

eh

#

users can't input in hsl or hsv i think

sleek steppe Apr 21, 2021, 1:48 AM

#

really?

#

.colour #6563C7
.colour cmyk(49, 50, 0, 22)
.colour hsl(241, 47, 58)
.colour rgb 101 99 199

vocal prairie Apr 21, 2021, 1:51 AM

#

sleek steppe now you need one for CMYK, HSL and HSV

CMYK is built already

#

Some code joe had

fallen patrol Apr 21, 2021, 1:51 AM

#

sir-lancebot#677

dusky shoreBOT Apr 21, 2021, 1:51 AM

#

GitHub

IssueOpen Create a colo[u]r command

fallen patrol Apr 21, 2021, 1:52 AM

#

heck

#

skips converters for now

#

time to work on the naming portion ablobsweats

vocal prairie Apr 21, 2021, 1:52 AM

#

Didn't joe have a list of websites that you could pull from?

#

Might not have been joe.

#

But someone did.

#

Yeah

#

You linked two in the issue

#

Just pull from those.

fallen patrol Apr 21, 2021, 1:53 AM

#

well

#

actually

#

need to merge the list and then figure out to parse it

vocal prairie Apr 21, 2021, 1:53 AM

#

Stick it in a txt

#

Or a yaml

#

Or a md

#

Or just a colors.py file

fallen patrol Apr 21, 2021, 1:57 AM

#

sleek steppe > ``` > .colour #6563C7 > .colour cmyk(49, 50, 0, 22) > .colour hsl(241, 47, 58)...

and hsv is in colorsys

placid ermine Apr 21, 2021, 2:51 AM

#

bump

thorny obsidian Apr 21, 2021, 3:11 AM

#

Alright. I'm up for a bit cause health stuff. Who wants a review for lancebot stuff?

short snow Apr 21, 2021, 3:14 AM

#

I can give it a try, not completely sure on how to implement the repetitive reminders tho

clever wraith Apr 21, 2021, 3:17 AM

#

thorny obsidian Alright. I'm up for a bit cause health stuff. Who wants a review for lancebot st...

i mean, id take a review on sir-lancebot#699 . Sorry that health stuff has you up!

dusky shoreBOT Apr 21, 2021, 3:17 AM

#

GitHub

PROpen Cowsay

short snow Apr 21, 2021, 3:19 AM

#

sleek steppe I was talking about your own ColourConverter

Using colorsys would make it really simple, it has everything you need for this feature

short snow Apr 21, 2021, 3:59 AM

#

we can merge sir-lancebot#697

dusky shoreBOT Apr 21, 2021, 3:59 AM

#

GitHub

PROpen Fixed the .catify command producing UnboundLocal and Forbidden Errors

short snow Apr 21, 2021, 3:59 AM

#

2 approvals are there

thorny obsidian Apr 21, 2021, 4:17 AM

#

amazing how little info the github actions gives me -_-

#

@patent pivoteeeeeeeeeeeeeeeeeeee, I don't know why the github actions hates me ;_; I pushed a green button and I don't know what I did wrong (re: merging the .catify fix)

short snow Apr 21, 2021, 4:28 AM

#

try re running them, github actions faced some internal issues

fallen patrol Apr 21, 2021, 5:09 AM

#

^

#

seems like everything is facing internal issues rn

#

i wonder what is down

short snow Apr 21, 2021, 5:36 AM

#

#

tried my best lol

#

the duck could be a pond

#

https://fastapi.tiangolo.com/tutorial/body-fields/ and we could do this for keeping some keys optional in the requests

Body - Fields - FastAPI

FastAPI framework, high performance, easy to learn, fast to code, ready for production

short snow Apr 21, 2021, 5:37 AM

#

short snow

both would be using the same colorscheme

#

or different, dunno which would be better

fervent sage Apr 21, 2021, 5:41 AM

#

imo if it can be customised it should be able to be customised independently of everything else

short snow Apr 21, 2021, 5:45 AM

#

sorry, i didn't get you

short snow Apr 21, 2021, 5:47 AM

#

short snow https://fastapi.tiangolo.com/tutorial/body-fields/ and we could do this for keep...

don't need this, it is more simpler than i thought, here it is: https://fastapi.tiangolo.com/tutorial/body/#create-your-data-model

Request Body - FastAPI

FastAPI framework, high performance, easy to learn, fast to code, ready for production

fervent sage Apr 21, 2021, 5:48 AM

#

if something, like the duck, can be customised in whatever way, like changing its colours, then you should be able to individually control each aspect of that, rather than it being dependent on something else i.e. the manduck

short snow Apr 21, 2021, 5:48 AM

#

hmm

fervent sage Apr 21, 2021, 5:48 AM

#

also wdym by 'keys'

short snow Apr 21, 2021, 5:48 AM

#

say if this is the request:

{
    "name": "Foo",
    "description": "An optional description",
    "price": 45.2,
    "tax": 3.5
}

#

then name, price are the keys

#

that's what i call them

fervent sage Apr 21, 2021, 5:49 AM

#

ah, technically they're all just fields in the request body

short snow Apr 21, 2021, 5:49 AM

#

like we discussed here.

fervent sage Apr 21, 2021, 5:49 AM

#

and we already do that, that's what the models are in the models.py file

#

the issue i was facing when i originally looked at it was that we wanted the values to default to random values, rather than static defaults

short snow Apr 21, 2021, 5:51 AM

#

yeah, that's what i was seeing rn, we would need to add some logic the color gens, so it can take the colors given my the user and generate the rest depending on that

fervent sage Apr 21, 2021, 5:52 AM

#

now youre starting to see why i gave up on doing it initially kek

short snow Apr 21, 2021, 5:52 AM

#

lol :doge_kek:

fervent sage Apr 21, 2021, 5:52 AM

#

i dont think it should be that hard, it just takes more sitting down and thinking than i can reasonably achieve in a session lol

short snow Apr 21, 2021, 5:53 AM

#

yeah, once we understand the way, it would be easy, just need to figure out a good efficient way to do it

fervent sage Apr 21, 2021, 5:56 AM

#

i think™️ we could do it like this: (i'll miss out a bunch of fields because laziness, but you should get the general idea)

def fill_defaults(duck: dict): # this dict is dict(the_duck_request_body)
  data = {
    "accessories": {
      "hat": choice(hats),
      "outfit": choice(outfits)
    }
  }

  data.update(duck)
  return data

#

we'd probably have a helper function to generate the random defaults, and then update that with the request body

short snow Apr 21, 2021, 5:58 AM

#

just get the random values and over write them with the ones the user gave?

fervent sage Apr 21, 2021, 5:58 AM

#

yep

short snow Apr 21, 2021, 5:59 AM

#

but wouldn't it be as smooth as the ones generated, as the ones got generaed randomly are based of a color scheme and are of similar type

fervent sage Apr 21, 2021, 5:59 AM

#

the issue there is i'm not sure update will work how I want it to, for example let's say we have

{
  "something": {
    "a": 1,
    "b": 2
  }
}
```and we call .update() on that with
```py
{
  "something": {
    "b": 3
  }
}
```I'm fairly sure `something.a` just disappears from it

short snow Apr 21, 2021, 6:00 AM

#

yeah we can leave that aside, lets think on the way to do it, implementation can be figured out later

fervent sage Apr 21, 2021, 6:00 AM

#

i'm gonna go have breakfast and think about this kek

short snow Apr 21, 2021, 6:01 AM

#

short snow but wouldn't it be as smooth as the ones generated, as the ones got generaed ran...

good, this is the only problem there is with the current idea

fervent sage Apr 21, 2021, 6:04 AM

#

I dont think there's really a perfect solution for this, if it's totally customized by the user they get what they asked for, if it's completely randomly generated then they get it with a colour scheme, if it's half and half then how are we supposed to know what they even want. I guess we could generate it precisely the same as the full random ones, that way at least the random parts follow the same colour scheme

short snow Apr 21, 2021, 6:05 AM

#

yeah

#

so just overwriting them should work?

fervent sage Apr 21, 2021, 6:06 AM

#

fervent sage the issue there is i'm not sure update will work how I want it to, for example l...

I think that's the way to go, but I don't think my way of calling .update will work because (see replied message)

short snow Apr 21, 2021, 6:06 AM

#

yeah, i will look into the implementation

#

i will have to wait for the pr to get merged before i can open a pull request lemon_angrysad

short snow Apr 21, 2021, 6:43 AM

#

@fervent sage ok, so this should work, #bot-commands message

fervent sage Apr 21, 2021, 6:43 AM

#

epic!

#

now we just need to get that PR merged blob_pain

short snow Apr 21, 2021, 6:43 AM

#

yeah

#

i think it is over complicated a bit, lemme see if i can simplify the merge function

short snow Apr 21, 2021, 7:10 AM

#

and should we just support random pets

#

not customizable thro input json

short snow Apr 21, 2021, 7:12 AM

#

short snow

options:

a - just generate two random duck and man duck and join them with a rope

b - generate two of them using the same colourscheme and join them with a rope

fervent sage Apr 21, 2021, 7:13 AM

#

hmmm, probably b

patent pivot Apr 21, 2021, 7:17 AM

#

thorny obsidian <@!165023948638126080>eeeeeeeeeeeeeeeeeeee, I don't know why the github actions ...

Try rerun

short snow Apr 21, 2021, 7:18 AM

#

fervent sage hmmm, probably b

ok, so we have four features pending, should i open a small issue for each of them?

#

1 - your - Random() model thing
2 - mine - allow to pass input for man ducks
3 - mine - allow passing only some inputs and rest would be taken thro the default (random generator)
4 - mine - pet ducks

fervent sage Apr 21, 2021, 7:21 AM

#

short snow ok, so we have four features pending, should i open a small issue for each of th...

that'd be awesome, yep

green oriole Apr 21, 2021, 7:52 AM

#

GET /helper_count on the API when

short snow Apr 21, 2021, 8:45 AM

#

fervent sage that'd be awesome, yep

ok cool, lemme open them

#

i think you can open describe Random model issue better than me lemon_sweat

fervent sage Apr 21, 2021, 9:02 AM

#

yup

short snow Apr 21, 2021, 9:07 AM

#

how can i create a message object mock and get its link (writing tests for bot#1446 )

dusky shoreBOT Apr 21, 2021, 9:07 AM

#

GitHub

PROpen Enhancing information within the incidents channel.

short snow Apr 21, 2021, 9:17 AM

#

and @green oriole what all do want in tests?

like when i put a message link, then do you want to check for the webhook message content too or just the number of embeds sent?

what i came up with is:

put a message with 3 links, test if there are one message with three embeds sent
edit a message to have 4 links, test if there are four embeds
edit a message to have 0 links, test if the message gets deleted
delete a message, check if the message gets deleted
on adding action/rejected emoji, does the message get deleted or not

green oriole Apr 21, 2021, 9:57 AM

#

Sounds about right

#

You probably only need 2 links every time but that should be fine

short snow Apr 21, 2021, 10:10 AM

#

green oriole You probably only need 2 links every time but that should be fine

yeah right, I will start it once i can get #dev-contrib message this done

patent pivot Apr 21, 2021, 10:20 AM

#

@cold island bear in mind user mentions in embeds are pretty broken across all platforms, one of the reasons for the feature is to get a user ID since jump links on mobile don't work and I don't think the user embeds either

cold island Apr 21, 2021, 10:21 AM

#

maybe in addition?

patent pivot Apr 21, 2021, 10:22 AM

#

yeah in addition would be alright

short snow Apr 21, 2021, 10:25 AM

#

the author is already mentioned

#

i will mention the channel id

#

lemme see about golddd

cold island Apr 21, 2021, 10:26 AM

#

short snow the author is already mentioned

I see a @ sign and the username, it doesn't seem like a mention

#

going by the ss you sent

short snow Apr 21, 2021, 10:27 AM

#

#

hmm

cold island Apr 21, 2021, 10:27 AM

#

ok

short snow Apr 21, 2021, 10:27 AM

#

i will update the screenshots on the pr

#

better @cold island ?

cold island Apr 21, 2021, 10:31 AM

#

the channel should still be there

short snow Apr 21, 2021, 10:31 AM

#

is that realy gold pithink , looks like some yellow LOL

#

channel id?

cold island Apr 21, 2021, 10:31 AM

#

yeah

short snow Apr 21, 2021, 10:31 AM

#

i thought it is not needed since we can just right click on it

cold island Apr 21, 2021, 10:31 AM

#

no

short snow Apr 21, 2021, 10:31 AM

#

k

cold island Apr 21, 2021, 10:31 AM

#

sorry, eating

#

the channel name

#

since mentions don't always render

short snow Apr 21, 2021, 10:32 AM

#

ok, i think channel mentions always render

cold island Apr 21, 2021, 10:32 AM

#

discord is good at fucking it up

short snow Apr 21, 2021, 10:33 AM

#

lol, just id or even the name

cold island Apr 21, 2021, 10:33 AM

#

name + mention imo

short snow Apr 21, 2021, 10:34 AM

#

that would look repetitve, we can get the name thro the id anyways, if we put that

#

like we do for format user

cold island Apr 21, 2021, 10:34 AM

#

Difference is

#

if the mention doesn't work but you see the name you can just scroll to the channel

#

whereas there's not much to do with the channel ID

#

The user mention is useful to pull up the profile, but mods can get the relevant info from the user ID

short snow Apr 21, 2021, 10:36 AM

#

ok cool, got it

#

perfect

cold island Apr 21, 2021, 10:38 AM

#

ok_handbutflipped

short snow Apr 21, 2021, 10:48 AM

#

pushed, just need to figure out tests now

short snow Apr 21, 2021, 11:27 AM

#

@patent pivot which library do we use to generate those nice graphs, the npm lib

patent pivot Apr 21, 2021, 11:27 AM

#

uhhhhh

short snow Apr 21, 2021, 11:27 AM

#

i remember you said it in the ot channels, but i can't remember it

patent pivot Apr 21, 2021, 11:27 AM

#

https://www.npmjs.com/package/react-chartjs-2

npm

react-chartjs-2

React components for Chart.js

short snow Apr 21, 2021, 11:28 AM

#

yes, thanks!

sleek steppe Apr 21, 2021, 12:28 PM

#

@clever wraith could you push 😄

clever wraith Apr 21, 2021, 12:29 PM

#

no

#

AttributeError: 'NoneType' object has no attribute 'version_sort'```

#

i keep getting this

#

just started getting it now

#

@sleek steppe

sleek steppe Apr 21, 2021, 12:30 PM

#

In your command?

clever wraith Apr 21, 2021, 12:30 PM

#

no

#

  File "C:\Users\VIncas\AppData\Roaming\Python\Python38\site-packages\pipenv\core.py", line 2512, in do_run
    ensure_project(
  File "C:\Users\VIncas\AppData\Roaming\Python\Python38\site-packages\pipenv\core.py", line 576, in ensure_project
    ensure_virtualenv(
  File "C:\Users\VIncas\AppData\Roaming\Python\Python38\site-packages\pipenv\core.py", line 498, in ensure_virtualenv
    python = ensure_python(three=three, python=python)
  File "C:\Users\VIncas\AppData\Roaming\Python\Python38\site-packages\pipenv\core.py", line 388, in ensure_python
    path_to_python = find_a_system_python(python)
  File "C:\Users\VIncas\AppData\Roaming\Python\Python38\site-packages\pipenv\core.py", line 350, in find_a_system_python
    return next(iter(finder.find_all_python_versions()), None)
  File "C:\Users\VIncas\AppData\Roaming\Python\Python38\site-packages\pipenv\vendor\pythonfinder\pythonfinder.py", line 328, in find_all_python_versions
    path_list = sorted(versions, key=version_sort, reverse=True)
AttributeError: 'NoneType' object has no attribute 'version_sort'```

#

i might be running it wrong

#

omg

#

im stupid

#

im running form the wrong dir

#

i think u were wrong with that Image.Image @sleek steppe

#

im getting errors now from my command

sleek steppe Apr 21, 2021, 12:32 PM

#

Attribute errors?

#

I have no idea what error you'd be getting; I haven't seen your current code

clever wraith Apr 21, 2021, 12:34 PM

#

nvm

#

i made another mistake

#

i can push now

thorny obsidian Apr 21, 2021, 12:36 PM

#

The command is super cool by the way! I was playing with it last night locally

clever wraith Apr 21, 2021, 12:36 PM

#

mine?

#

@sleek steppe pushed

clever wraith Apr 21, 2021, 12:37 PM

#

thorny obsidian The command is super cool by the way! I was playing with it last night locally

coolest is the 193600 squares if u are talking about mine

#

cuz it can create some cool imgs

#

ill show mine and my friend's

#

#

i think thats pretty cool

thorny obsidian Apr 21, 2021, 12:38 PM

#

Yeah! It's super cool

clever wraith Apr 21, 2021, 12:38 PM

#

thanks

fervent sage Apr 21, 2021, 12:38 PM

#

i prefer lower number of squares myself, otherwise it looks kinda random

#

but yeah its an awesome feature

clever wraith Apr 21, 2021, 12:39 PM

#

thanks

#

@thorny obsidian are u gonna review it?

thorny obsidian Apr 21, 2021, 12:39 PM

#

I'm hoping to today once I answer some work emails~

clever wraith Apr 21, 2021, 12:39 PM

#

ok thanks

sleek steppe Apr 21, 2021, 12:39 PM

#

vocal prairie Apr 21, 2021, 12:40 PM

#

No, the emoji didn't show.

sleek steppe Apr 21, 2021, 12:40 PM

#

pain

clever wraith Apr 21, 2021, 12:40 PM

#

u approved it?

sleek steppe Apr 21, 2021, 12:40 PM

#

different PR

clever wraith Apr 21, 2021, 12:40 PM

#

or is that someone else's

#

oh..

vocal prairie Apr 21, 2021, 12:41 PM

#

sleek steppe pain

@patent pivot Uh, is this normal? The emoji just disappeared.

patent pivot Apr 21, 2021, 12:41 PM

#

yeah I think it's just a bug that we can't work around

sleek steppe Apr 21, 2021, 12:41 PM

#

I mean it's been happening

patent pivot Apr 21, 2021, 12:41 PM

#

The emoji is certainly there in the payload, it just seems that Discord strips it out

fervent sage Apr 21, 2021, 12:42 PM

#

weird

short snow Apr 21, 2021, 12:46 PM

#

wait don't merge splitify, i got a change

sleek steppe Apr 21, 2021, 12:46 PM

#

Can't merge anyways, needs a core dev approval

clever wraith Apr 21, 2021, 12:46 PM

#

no one is gonna

clever wraith Apr 21, 2021, 12:46 PM

#

sleek steppe Can't merge anyways, needs a core dev approval

yeah

#

but since ur a contributor urs counts as 1 of the staff right?

#

so if kutie approves it today then it should be merged i think

sleek steppe Apr 21, 2021, 12:47 PM

#

~~Kutie isn't a core-dev~~

fervent sage Apr 21, 2021, 12:47 PM

#

kutie isnt a core dev i dont think

clever wraith Apr 21, 2021, 12:48 PM

#

oh rip

fervent sage Apr 21, 2021, 12:48 PM

#

fervent sage kutie isnt a core dev i dont think

this is a bad sentence

clever wraith Apr 21, 2021, 12:48 PM

#

@short snow what do you mean use it instead of I and we?

sleek steppe Apr 21, 2021, 12:48 PM

#

fervent sage kutie isnt a core dev i dont think

No apostrophes ANGRY

short snow Apr 21, 2021, 12:49 PM

#

clever wraith <@!736234578745884682> what do you mean use it instead of I and we?

yes

thorny obsidian Apr 21, 2021, 12:49 PM

#

nope, not a core dev

fervent sage Apr 21, 2021, 12:49 PM

#

"I use Image.(something) to do {something}" would be "It uses Image.(something)...", for example

thorny obsidian Apr 21, 2021, 12:49 PM

#

I do not know our stack or d.py well enough at all to even be remotely considered for core dev

clever wraith Apr 21, 2021, 12:49 PM

#

so if i say: I make a for loop, you want me to instead say it make a for loop?

#

i dont get it

fervent sage Apr 21, 2021, 12:49 PM

#

i can teach you d.py kek

clever wraith Apr 21, 2021, 12:49 PM

#

@short snow

short snow Apr 21, 2021, 12:49 PM

#

we should have a place where all the stack is there, if it is not public then make it public

#

it helps

sleek steppe Apr 21, 2021, 12:50 PM

#

thorny obsidian I do not know our stack or d.py well enough at all to even be remotely considere...

https://vcokltfre.dev

discord.py Bot Tutorial

fervent sage Apr 21, 2021, 12:50 PM

#

since you're not personally carrying out what you're saying the code does, it should be using the wording "it does" "it changes" rather than "i do" "i change"

short snow Apr 21, 2021, 12:50 PM

#

clever wraith so if i say: I make a for loop, you want me to instead say it make a for loop?

it loops through .... can be used rather

thorny obsidian Apr 21, 2021, 12:50 PM

#

haha, I've actually been through that a few times >_>

sleek steppe Apr 21, 2021, 12:50 PM

#

lol

thorny obsidian Apr 21, 2021, 12:50 PM

#

or rather, I've read through it and plan on incorporating some stuff in a smaller bot I'm making for a different server

sleek steppe Apr 21, 2021, 1:05 PM

#

fervent sage since you're not personally carrying out what you're saying the code does, it sh...

@clever wraith needs more clarification this

placid ermine Apr 21, 2021, 2:25 PM

#

latex unload

green oriole Apr 21, 2021, 2:26 PM

#

.ext unload latex

dusky shoreBOT Apr 21, 2021, 2:26 PM

#

:ok_hand: Extension successfully unloaded: bot.exts.evergreen.latex.

green oriole Apr 21, 2021, 2:27 PM

#

Hey @clever wraith, are you linting your PR locally before committing?

clever wraith Apr 21, 2021, 2:27 PM

#

Yeah

green oriole Apr 21, 2021, 2:27 PM

#

You have quite a bunch of fix commits right here

placid ermine Apr 21, 2021, 2:28 PM

#

couldn't you have waited 5 seconds lemon_pensive

#

my .latex $69 \cdot 6 - 9 + 6 + 9 = 420$ didn't get rendered 😔

green oriole Apr 21, 2021, 2:30 PM

#

lol

#

.ext load latex

dusky shoreBOT Apr 21, 2021, 2:31 PM

#

:ok_hand: Extension successfully loaded: bot.exts.evergreen.latex.

green oriole Apr 21, 2021, 2:31 PM

#

.latex $69 \cdot 6 - 9 + 6 + 9 = 420$

dusky shoreBOT Apr 21, 2021, 2:31 PM

#

$latex.png$

green oriole Apr 21, 2021, 2:31 PM

#

.ext unload latex

dusky shoreBOT Apr 21, 2021, 2:31 PM

#

:ok_hand: Extension successfully unloaded: bot.exts.evergreen.latex.

sleek steppe Apr 21, 2021, 2:31 PM

#

perfect

green oriole Apr 21, 2021, 2:31 PM

#

@placid ermine there you go

placid ermine Apr 21, 2021, 2:31 PM

#

it is done

#

thank

#

bump on this btw

green oriole Apr 21, 2021, 2:33 PM

#

lemon_pensive

#

Who else was involved in the latex discussion?

placid ermine Apr 21, 2021, 2:34 PM

#

30% of it was me talking to myself

#

but uh
scaleios, mark, kutiekatj, and joe have participated in the convos

green oriole Apr 21, 2021, 2:34 PM

#

Oh boy

sleek steppe Apr 21, 2021, 2:36 PM

#

Regarding https://github.com/python-discord/bot/pull/1546#issuecomment-824094690, do you think Due or Done at makes more sense?

green oriole Apr 21, 2021, 2:38 PM

#

I've asked in the core dev chat about latex rendering as it is scrolling slower than this channel, will get back to you once I have an answer

#

"Due" sounds better imo

short snow Apr 21, 2021, 2:39 PM

#

@clever wraith have you tested your pr before committing a push?

#

You have a lot of changes which are kind of breaking

green oriole Apr 21, 2021, 2:39 PM

#

"Done at" sounds awkward

clever wraith Apr 21, 2021, 2:39 PM

#

short snow <@456226577798135808> have you tested your pr before committing a push?

I've forgotten a few times smh

short snow Apr 21, 2021, 2:40 PM

#

Test your pr and go through each requested change and see if the they work and are resolved

tough imp Apr 21, 2021, 2:42 PM

#

"Done at" sounds awkward but given the dot it may be the best we have, not sure

short snow Apr 21, 2021, 2:42 PM

#

Yeah, due sounds better

#

And more appropriate

#

To the context

tough imp Apr 21, 2021, 2:43 PM

#

I wanted to see how awkward it could get if I change my phone's locale to another lang but it said it'd have to restart and I'm not ready for that kind of commitment

green oriole Apr 21, 2021, 2:43 PM

#

Haha

vale ibex Apr 21, 2021, 2:43 PM

#

!stream @vale ibex 3d

stable mountainBOT Apr 21, 2021, 2:43 PM

#

@vale ibex

✅ @vale ibex can now stream.

vale ibex Apr 21, 2021, 2:43 PM

#

It also worth mentioning that it's possible to be a date too

green oriole Apr 21, 2021, 2:43 PM

#

It isn't even a dot on Android

#

It is a vertical bar

short snow Apr 21, 2021, 2:43 PM

#

Yeah, we should do this for such commands

tough imp Apr 21, 2021, 2:43 PM

#

iOS has a pipe too

green oriole Apr 21, 2021, 2:43 PM

#

!rstream 126811506632294400 REVOKED

stable mountainBOT Apr 21, 2021, 2:43 PM

#

✅ Revoked the permission to stream from @vale ibex.

vale ibex Apr 21, 2021, 2:44 PM

#

So the wording needs to work when its both Today at XX:XX and XX/XX/XXXX

tough imp Apr 21, 2021, 2:44 PM

#

Chris using this opportunity to grant themselves extra perms 😔

vale ibex Apr 21, 2021, 2:44 PM

#

green oriole !rstream 126811506632294400 REVOKED

Sadge

short snow Apr 21, 2021, 2:44 PM

#

Lol

vale ibex Apr 21, 2021, 2:44 PM

#

Due sounds good to me

green oriole Apr 21, 2021, 2:45 PM

#

Y'all better not let the coffee be too powerful

sleek steppe Apr 21, 2021, 2:45 PM

#

vale ibex `Due` sounds good to me

Pushed.

fervent sage Apr 21, 2021, 2:46 PM

#

dusky shore

wait really

vale ibex Apr 21, 2021, 2:46 PM

#

sleek steppe Pushed.

incident_actioned

short snow Apr 21, 2021, 2:47 PM

#

any core Dev if you have time off, could you review the quackstack PR, it is holding off the other features.

fervent sage Apr 21, 2021, 2:47 PM

#

^^^

short snow Apr 21, 2021, 2:47 PM

#

Me and Alec giving too many reminders lol

#

No patience

vale ibex Apr 21, 2021, 2:48 PM

#

I'll have a look at setting an environment to test it tonight if I get a chance

#

I'm not familiar enough with the code to tell from just the PR changes

patent pivot Apr 21, 2021, 2:48 PM

#

fervent sage ^^^

fwiw quackstack is reviewable by any staff member

short snow Apr 21, 2021, 2:49 PM

#

Hmm, one staff and one core Dev right?

patent pivot Apr 21, 2021, 2:49 PM

#

nope

short snow Apr 21, 2021, 2:49 PM

#

Or just two staffs

patent pivot Apr 21, 2021, 2:49 PM

#

1 staff member

short snow Apr 21, 2021, 2:49 PM

#

Thanks Chris lemon_hyperpleased

#

We got it then

#

Oh no

#

Vco had a commit

patent pivot Apr 21, 2021, 2:49 PM

#

short snow Apr 21, 2021, 2:49 PM

#

On it lemon_grimace

patent pivot Apr 21, 2021, 2:50 PM

#

yeah

short snow Apr 21, 2021, 2:50 PM

#

SMH 🤦‍♂️ Alec

fervent sage Apr 21, 2021, 2:51 PM

#

.randomcase sorry

dusky shoreBOT Apr 21, 2021, 2:51 PM

#

SOrRY

short snow Apr 21, 2021, 2:51 PM

#

Lol, not at all

sleek steppe Apr 21, 2021, 2:51 PM

#

Merged before the checks passed 😬

vale ibex Apr 21, 2021, 2:51 PM

#

!remind 2h Look at this swanky new time feature

stable mountainBOT Apr 21, 2021, 2:51 PM

#

Sure.

Your reminder will arrive in 2 hours!

short snow Apr 21, 2021, 2:52 PM

#

vale ibex Apr 21, 2021, 2:52 PM

#

That's enforced by Discord

short snow Apr 21, 2021, 2:52 PM

#

Isn’t it a dot?

sleek steppe Apr 21, 2021, 2:52 PM

#

Mobile I think

vale ibex Apr 21, 2021, 2:52 PM

#

the separator is a pipe on mobile and a dot on desktop

short snow Apr 21, 2021, 2:53 PM

#

Oh

sleek steppe Apr 21, 2021, 2:53 PM

#

fervent sage Apr 21, 2021, 2:53 PM

#

vale ibex the separator is a pipe on mobile and a dot on desktop

my life is 7x worse now that i know this

tough imp Apr 21, 2021, 2:54 PM

#

1981 nice

#

we're gonna reach the tayloer swift album soon

sleek steppe Apr 21, 2021, 2:55 PM

#

@vale ibex the weird image being outside of the embed bug for the .spookyavatar only happens when I mention lancebot 🤔 but when I make lancebot the one who's invoking the command then it doesn't do that Thonk maybe there isn't a point of trying to fix it

short snow Apr 21, 2021, 2:55 PM

#

Hmm, but why does that happen

#

Is the question here

wide elm Apr 21, 2021, 3:09 PM

#

tough imp we're gonna reach the tayloer swift album soon

lmao

cold moon Apr 21, 2021, 4:00 PM

#

One thing I notified in QuackStack: This currently installs also dev-dependencies in Dockerfile, but there we need only production dependencies.

#

Yes, easiest way is using Docker

green oriole Apr 21, 2021, 4:02 PM

#

Yes

#

Dev dependencies should never be installed in a docker image lemon_pensive

balmy sparrow Apr 21, 2021, 4:03 PM

#

poetry install --no-dev, someone can just commit to main?

green oriole Apr 21, 2021, 4:03 PM

#

Yep yep

tough imp Apr 21, 2021, 4:03 PM

#

If you're using docker you don't need to do the site setup

#

compose will spin up a site container for you

#

just do the bot

green oriole Apr 21, 2021, 4:04 PM

#

balmy sparrow `poetry install --no-dev`, someone can just commit to main?

I usually use pipenv install --system --deploy, what does --no-dev do?

balmy sparrow Apr 21, 2021, 4:04 PM

#

that's the poetry command to not install dev deps

green oriole Apr 21, 2021, 4:04 PM

#

lmao, I am so blind

cold moon Apr 21, 2021, 4:04 PM

#

poetry installs dev deps default

#

Duck using new colors generation: https://quackstack.pythondiscord.com/static/993c510e9d10c027c75139f029562847449127f1.png

green oriole Apr 21, 2021, 4:05 PM

#

Yeah, yeah, I didn't see that it wasn't pipenv for some reason

#

Wait, do we really have quackstack as a critical project haha

#

Guess we do, huh

cold moon Apr 21, 2021, 4:06 PM

#

~~Top priority 🤣~~

green oriole Apr 21, 2021, 4:06 PM

#

No main commit for me

tough imp Apr 21, 2021, 4:06 PM

#

The bot project has a docker-compose.yml which defines which services need to run; it contains the site service as well, so just by following the bot instructions if you use docker and compose, it will run site for you

cold moon Apr 21, 2021, 4:07 PM

#

Yeah, this new branch protection policy don't let main-pushes anymore.

green oriole Apr 21, 2021, 4:07 PM

#

Well, only to critical projects

cold island Apr 21, 2021, 4:07 PM

#

It can launch a site container for you. If you want to work only on the bot side of things then that's all you need

green oriole Apr 21, 2021, 4:08 PM

#

I guess permissions on this projects are a bit funky since I don't have access to most of the settings

tough imp Apr 21, 2021, 4:08 PM

#

btw I think this still isn't addressed

green oriole Apr 21, 2021, 4:08 PM

#

Yes, it should

#

Are we not mentioning it in the guide?

tough imp Apr 21, 2021, 4:08 PM

#

the guide just recommends running fakeredis

green oriole Apr 21, 2021, 4:09 PM

#

Alright, that should probably be changed after the wiki freeze

vale ibex Apr 21, 2021, 4:09 PM

#

We're in a wiki freeze atm, while we're working on the dewikification

#

Ah yea, what Akarys said

green oriole Apr 21, 2021, 4:09 PM

#

!remind 2w Suggest to use the Redis container on the Python docs

stable mountainBOT Apr 21, 2021, 4:09 PM

#

I'll allow it.

Your reminder will arrive in 14 days!

green oriole Apr 21, 2021, 4:10 PM

#

https://github.com/python-discord/quackstack/pull/34

GitHub

Dockerfile: don't install dev dependencies by Akarys42 · Pull Reque...

Development 👏 dependencies 👏 should 👏 never 👏 be 👏 installed 👏 in 👏 a 👏 container
For real though, this takes time and build space and I doubt anyone is linting their code from inside a container. ...

tough imp Apr 21, 2021, 4:11 PM

#

linting from within

balmy sparrow Apr 21, 2021, 4:12 PM

#

green oriole https://github.com/python-discord/quackstack/pull/34

will my approval be enough lmao

green oriole Apr 21, 2021, 4:13 PM

#

One way to find out lemon_smug

balmy sparrow Apr 21, 2021, 4:14 PM

#

devops has to approve as well

green oriole Apr 21, 2021, 4:14 PM

#

@patent pivoteeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee

#

Do you have a second?

tough imp Apr 21, 2021, 4:15 PM

#

there has to be some endpoint

#

d.py even implements this https://discordpy.readthedocs.io/en/stable/api.html#discord.Guild.create_custom_emoji

patent pivot Apr 21, 2021, 4:15 PM

#

hi

#

i have a second

tough imp Apr 21, 2021, 4:16 PM

#

ah

#

yea

patent pivot Apr 21, 2021, 4:16 PM

#

approving

green oriole Apr 21, 2021, 4:16 PM

#

Thanko

patent pivot Apr 21, 2021, 4:16 PM

#

merged

tough imp Apr 21, 2021, 4:16 PM

#

joe the merger

patent pivot Apr 21, 2021, 4:17 PM

#

legend amongst men

balmy sparrow Apr 21, 2021, 4:18 PM

#

do we need to be making the virtualenv as well pithink

sleek steppe Apr 21, 2021, 4:22 PM

#

Quackstack uses poetry? pogchamp

patent pivot Apr 21, 2021, 4:23 PM

#

heck yea

magic arch Apr 21, 2021, 4:23 PM

#

nicee

#

~~(on another note, i think joe is staring into my soul)~~

patent pivot Apr 21, 2021, 4:26 PM

#

🥸

balmy sparrow Apr 21, 2021, 4:33 PM

#

balmy sparrow do we need to be making the virtualenv as well <:pithink:652247559909277706>

poetry config virtualenvs.create false

fallen patrol Apr 21, 2021, 4:37 PM

#

patent pivot heck yea

You missed an opportunity here :(

#

duck yea

magic arch Apr 21, 2021, 4:39 PM

#

ducky_dave

stable mountainBOT Apr 21, 2021, 4:51 PM

#

@vale ibex

It has arrived!

Here's your reminder: Look at this swanky new time feature.
[Jump back to when you created the reminder](#dev-contrib message)

fervent sage Apr 21, 2021, 4:53 PM

#

sleek steppe Quackstack uses poetry? <:pogchamp:785638233693224967>

i made the initial stuff so ofc kek

sleek steppe Apr 21, 2021, 4:54 PM

#

ah yes

fallen patrol Apr 21, 2021, 5:05 PM

#

vale ibex the separator is a pipe on mobile and a dot on desktop

I hate mobile

clever wraith Apr 21, 2021, 5:48 PM

#

i made the change with pronouns @sleek steppe its way worse now but oh well

remote abyss Apr 21, 2021, 6:09 PM

#

Not sure if this is the right place to ask, but I noticed an issue with the response from the python bot when typing !d if.
We were trying to show a user how to use the if/else syntax for python, but it returned irrelevant django syntax instead. I also noticed that if isn't on the tags list, so I wonder where it's even coming from... 🤔

thorny obsidian Apr 21, 2021, 6:10 PM

#

!if

stable mountainBOT Apr 21, 2021, 6:10 PM

#

if __name__ == '__main__'

This is a statement that is only true if the module (your source code) it appears in is being run directly, as opposed to being imported into another module. When you run your module, the __name__ special variable is automatically set to the string '__main__'. Conversely, when you import that same module into a different one, and run that, __name__ is instead set to the filename of your module minus the .py extension.

Example

# foo.py

print('spam')

if __name__ == '__main__':
    print('eggs')

If you run the above module foo.py directly, both 'spam'and 'eggs' will be printed. Now consider this next example:

# bar.py

import foo

If you run this module named bar.py, it will execute the code in foo.py. First it will print 'spam', and then the if statement will fail, because __name__ will now be the string 'foo'.

Why would I do this?

• Your module is a library, but also has a special case where it can be run directly
• Your module is a library and you want to safeguard it against people running it directly (like what pip does)
• Your module is the main program, but has unit tests and the testing framework works by importing your module, and you want to avoid having your main code run during the test

sleek steppe Apr 21, 2021, 6:10 PM

#

Oh you mean !d if

#

!d if

stable mountainBOT Apr 21, 2021, 6:10 PM

#

if

if

The {% if %} tag evaluates a variable, and if that variable is “true” (i.e. exists, is not empty, and is not a false boolean value) the contents of the block are output:

{% if athlete_list %}
    Number of athletes: {{ athlete_list|length }}
{% elif athlete_in_locker_room_list %}
    Athletes should be out of the locker room soon!
{% else %}
    No athletes.
{% endif %}
```...

remote abyss Apr 21, 2021, 6:10 PM

#

Yeah sorry I think it was !d if

sleek steppe Apr 21, 2021, 6:10 PM

#

That was before Numelor's PR

remote abyss Apr 21, 2021, 6:10 PM

#

How recent was that

whole forge Apr 21, 2021, 6:11 PM

#

sad

remote abyss Apr 21, 2021, 6:11 PM

#

Rip

whole forge Apr 21, 2021, 6:11 PM

#

was hoping to get this https://docs.python.org/3/reference/compound_stmts.html#the-if-statement

remote abyss Apr 21, 2021, 6:12 PM

#

!d if makes sense, but why on earth would it be returning django 😅

sleek steppe Apr 21, 2021, 6:12 PM

#

Uhhh I guess there were some issues with the command

#

bot#1014

dusky shoreBOT Apr 21, 2021, 6:13 PM

#

GitHub

PRMerged Doc improvements

sleek steppe Apr 21, 2021, 6:13 PM

#

It was merged 9 days ago

#

Also wasn't !docs get a thing

whole forge Apr 21, 2021, 6:15 PM

#

remote abyss `!d if` makes sense, but why on earth would it be returning django 😅

the docs command scans documentation for matching statements, its returning django because django has a documentation piece called "if" for their templating language

remote abyss Apr 21, 2021, 6:15 PM

#

So it's not just scanning python docs?

sleek steppe Apr 21, 2021, 6:15 PM

#

!d

stable mountainBOT Apr 21, 2021, 6:15 PM

#

All inventories (`22` total)

• gitpython
• kivy
• matplotlib
• more_itertools
• networkx
• numpy
• pandas

whole forge Apr 21, 2021, 6:15 PM

#

i belive the approprite way to go about this is to exclude every reserved name, statement and builtin function in python from being pulled from any other source than the python docs

brazen charm Apr 21, 2021, 6:15 PM

#

!d label.if works

remote abyss Apr 21, 2021, 6:15 PM

#

Oh I see

stable mountainBOT Apr 21, 2021, 6:15 PM

#

label.if

8.1. The if statement

The if statement is used for conditional execution:


if_stmt ::=  "if" assignment_expression ":" suite
             ("elif" assignment_expression ":" suite)*
             ["else" ":" suite]
``` It selects exactly one of the suites by evaluating the expressions one by one until one is found to be true (see section [Boolean operations](https://docs.python.org/3/reference/expressions.html#booleans) for the definition of true and false); then that suite is executed (and no other part of the [`if`](https://docs.python.org/3/reference/compound_stmts.html#if) statement is executed or evaluated). If all expressions are false, the suite of the [`else`](https://docs.python.org/3/reference/compound_stmts.html#else) clause, if present, is executed.

sleek steppe Apr 21, 2021, 6:16 PM

#

!d if

#

oh yeah it is django

remote abyss Apr 21, 2021, 6:16 PM

#

Alright I'll use label.if for now, thx.

#

Errr

#

Even that snippet looks ridiculously confusing

whole forge Apr 21, 2021, 6:17 PM

#

yeah its the grammar for if statements

stable mountainBOT Apr 21, 2021, 6:17 PM

#

label.if

8.1. The if statement

The if statement is used for conditional execution:


if_stmt ::=  "if" assignment_expression ":" suite
             ("elif" assignment_expression ":" suite)*
             ["else" ":" suite]
``` It selects exactly one of the suites by evaluating the expressions one by one until one is found to be true (see section [Boolean operations](https://docs.python.org/3/reference/expressions.html#booleans) for the definition of true and false); then that suite is executed (and no other part of the [`if`](https://docs.python.org/3/reference/compound_stmts.html#if) statement is executed or evaluated). If all expressions are false, the suite of the [`else`](https://docs.python.org/3/reference/compound_stmts.html#else) clause, if present, is executed.

remote abyss Apr 21, 2021, 6:18 PM

#

There's no way that would be helpful to someone asking for help 😂

thorny obsidian Apr 21, 2021, 6:18 PM

#

Do you have something in mind for explaining if/else? We could turn it into a dedicated tag

whole forge Apr 21, 2021, 6:19 PM

#

the issue if people using !d if would still persist, i think there should be a way to handle docs for things like if too

#

people are going to use !d if because that seems to make sense

remote abyss Apr 21, 2021, 6:20 PM

#

I explained it like this in a pinch

if condition:
    # do stuff
elif condition2: 
    # elif is optional
else:
    # default condition.

#

But it could definitely be explained better

#

Or shown better

whole forge Apr 21, 2021, 6:20 PM

#

remote abyss I explained it like this in a pinch ```py if condition: # do stuff elif cond...

not quite accurate, elif: will raise a syntax error, it needs a condition

remote abyss Apr 21, 2021, 6:20 PM

#

Oh right

#

Fixed

#

Still, that's just a barebones example

sleek steppe Apr 21, 2021, 6:21 PM

#

Hmm It would be cool for tags to parse the markdown to fine the bolded title and made it the embed title

brazen charm Apr 21, 2021, 6:22 PM

#

!d tut-if is the closest you can get to anything like that, but is still a more technical tutorial which I don't think is as suited to complete beginners. The tutorial pages also don't expose the symbols nicely so you pretty much have to look for the ids yourself

stable mountainBOT Apr 21, 2021, 6:22 PM

#

tut-if

4.1. if Statements

Perhaps the most well-known statement type is the if statement. For example...

thorny obsidian Apr 21, 2021, 6:23 PM

#

I think in this case an !if-else tag or something would be nice

whole forge Apr 21, 2021, 6:23 PM

#

yes but that does not fix the issue of people mistakenly using "!d if"

brazen charm Apr 21, 2021, 6:24 PM

#

imo the statement is something that should mostly be explained personally if someone needs to understand it

thorny obsidian Apr 21, 2021, 6:24 PM

#

I think the tag could be nice to provide an example boilerplate you can then use to explain personally

thorny obsidian Apr 21, 2021, 6:25 PM

#

whole forge yes but that does not fix the issue of people mistakenly using "!d if"

to be perfectly honest, I don't think a lot of peope use the !d if to pull built in stuff. Even if we fix it, the fix doesn't really... help in this case.

remote abyss Apr 21, 2021, 6:25 PM

#

Yeah it would be good to have something uniform and agreed upon, I'm sure everyone's examples would be slightly different

#

I'm surprised the docs command doesn't require specifying a library before the keyword

whole forge Apr 21, 2021, 6:26 PM

#

in many cases it does

remote abyss Apr 21, 2021, 6:26 PM

#

Like !d <python/py> <keyword>

fervent sage Apr 21, 2021, 6:27 PM

#

aiohttp

whole forge Apr 21, 2021, 6:27 PM

#

!d aiohttp.ClientSession

stable mountainBOT Apr 21, 2021, 6:27 PM

#

aiohttp.ClientSession

class aiohttp.ClientSession(*, connector=None, loop=None, cookies=None, headers=None, skip_auto_headers=None, auth=None, json_serialize=json.dumps, version=aiohttp.HttpVersion11, ...)```
The class for creating client sessions and making requests.

whole forge Apr 21, 2021, 6:27 PM

#

there we go

green oriole Apr 21, 2021, 6:27 PM

#

I was about to say that it is a stdlib haha

stable mountainBOT Apr 21, 2021, 6:28 PM

#

help


help([object])```
Invoke the built-in help system. (This function is intended for interactive use.) If no argument is given, the interactive help system starts on the interpreter console. If the argument is a string, then the string is looked up as the name of a module, function, class, method, keyword, or documentation topic, and a help page is printed on the console. If the argument is any other kind of object, a help page on the object is generated.

Note that if a slash(/) appears in the parameter list of a function, when invoking [`help()`](https://docs.python.org/3/library/functions.html#help "help"), it means that the parameters prior to the slash are positional-only. For more info, see [the FAQ entry on positional-only parameters](https://docs.python.org/3/faq/programming.html#faq-positional-only-arguments).

This function is added to the built-in namespace by the [`site`](https://docs.python.org/3/library/site.html#module-site "site: Module responsible for site-specific configuration.") module.

sleek steppe Apr 21, 2021, 6:29 PM

#

remote abyss I'm surprised the docs command doesn't require specifying a library before the k...

python isn't a library though

remote abyss Apr 21, 2021, 6:29 PM

#

Well then !d <django> if

#

You get my point

whole forge Apr 21, 2021, 6:30 PM

#

hu

remote abyss Apr 21, 2021, 6:30 PM

#

Wtf lol

whole forge Apr 21, 2021, 6:30 PM

#

wot

#

so to recap, !d if works, but !d django.if doesn't?

#

thats very eugh behaviour

brazen charm Apr 21, 2021, 6:31 PM

#

It depends on the symbol, if isn't a method or anything like that for django so it's just if directly in the docs, but if it had a conflict that wouldn't be a label or something else we move, then it'd be prefixed with django. The role of the django template tags could be added to the list of groups that's currently moved out of the way in case of a conflict (which includes the label group), but that'd also need additional handling as I believe currently it'll just depend on which one came first if they're both moveable

#

There won't be multiple symbols pointing to the same docs (except for rare cases where they're provided multiple times by the inventories)

whole forge Apr 21, 2021, 6:33 PM

#

i would definitely make sure that no library can have anything thats in python as a !d label

#

!d else

stable mountainBOT Apr 21, 2021, 6:33 PM

#

else

8.1. The if statement

The if statement is used for conditional execution:


if_stmt ::=  "if" assignment_expression ":" suite
             ("elif" assignment_expression ":" suite)*
             ["else" ":" suite]
``` It selects exactly one of the suites by evaluating the expressions one by one until one is found to be true (see section [Boolean operations](https://docs.python.org/3/reference/expressions.html#booleans) for the definition of true and false); then that suite is executed (and no other part of the [`if`](https://docs.python.org/3/reference/compound_stmts.html#if) statement is executed or evaluated). If all expressions are false, the suite of the [`else`](https://docs.python.org/3/reference/compound_stmts.html#else) clause, if present, is executed.

whole forge Apr 21, 2021, 6:33 PM

#

yo

#

wack

#

!d for

stable mountainBOT Apr 21, 2021, 6:33 PM

#

for

for

Loops over each item in an array, making the item available in a context variable. For example, to display a list of athletes provided in athlete_list:

<ul>
{% for athlete in athlete_list %}
    <li>{{ athlete.name }}</li>
{% endfor %}
</ul>
```  You can loop over a list in reverse by using `{% for obj in list reversed %}`...

remote abyss Apr 21, 2021, 6:33 PM

#

Yikes lol

whole forge Apr 21, 2021, 6:33 PM

#

another tempalte one that shouldnt be here

#

!d def

stable mountainBOT Apr 21, 2021, 6:34 PM

#

def

8.6. Function definitions

A function definition defines a user-defined function object (see section The standard type hierarchy):

brazen charm Apr 21, 2021, 6:37 PM

#

Well, it'd be impossible to take care of all cases but as I said the django template things have their own group so handling can be added for that. Best to open an issue for it if you'd like to see it handled

fallen patrol Apr 21, 2021, 7:58 PM

#

Relevant poetry and vsc news:

#

https://devblogs.microsoft.com/python/python-in-visual-studio-code-april-2021-release/

Python

Luciana Abud

Python in Visual Studio Code – April 2021 Release | Python

We are pleased to announce that the April 2021 release of the Python Extension for Visual Studio Code is now available. You can download the Python extension from the Marketplace, or install it directly from the extension gallery in Visual Studio Code.

patent pivot Apr 21, 2021, 8:00 PM

#

nice

short snow Apr 21, 2021, 11:10 PM

#

Weee lezzz go, quackstack PR got merged 🎉

sleek steppe Apr 21, 2021, 11:11 PM

#

I see 🎉

#

- [ ] Read all the comments in this tempelate.
- [ ] Ensure there is an issue open, or link relevant discord discussions.
- [ ] Read the [contributing guidelines](https://pythondiscord.com/pages/contributing/contributing-guidelines/).

@gritty wind Should these sentences end with ??

gritty wind Apr 21, 2021, 11:19 PM

#

Sure

fallen patrol Apr 21, 2021, 11:36 PM

#

Wat

#

@short snow obj to you too

#

And @gritty wind as well

#

gritty wind Apr 21, 2021, 11:37 PM

#

What's happening?

fallen patrol Apr 21, 2021, 11:37 PM

#

That's definitely scale

#

Scale is now toxic

#

~~mentioned wrong person lol~~

gritty wind Apr 21, 2021, 11:37 PM

#

Do you... need glasses? haha

#

I'm confused

fallen patrol Apr 21, 2021, 11:38 PM

#

It says obj

#

So whatever they sent my phone doesn't support right?

gritty wind Apr 21, 2021, 11:39 PM

#

I see that on windows as well

#

just invisible on iOS

vocal prairie Apr 21, 2021, 11:40 PM

#

I can't see it on Windows. Just says obj

sleek steppe Apr 21, 2021, 11:42 PM

#

fallen patrol It says obj

yeah I meant i saw the three obj and then 🎉

fallen patrol Apr 21, 2021, 11:42 PM

#

O

#

Lol

short snow Apr 21, 2021, 11:44 PM

#

Am on iOS right now, must be the problem

#

!raw #dev-contrib message

stable mountainBOT Apr 21, 2021, 11:48 PM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

short snow Apr 21, 2021, 11:51 PM

#

fallen patrol Apr 21, 2021, 11:51 PM

#

Dafuq?

vocal prairie Apr 21, 2021, 11:52 PM

#

#

Wot?

short snow Apr 21, 2021, 11:52 PM

#

Lol, I need some sleep, night

vocal prairie Apr 21, 2021, 11:52 PM

#

Night!

short snow Apr 21, 2021, 11:52 PM

#

Summer starts, schedule fucks up

deft patrol Apr 22, 2021, 5:16 AM

#

True

short snow Apr 22, 2021, 5:50 AM

#

Ok, welp am stuck here, and dunno why

#

this is my code: https://paste.pythondiscord.com/awahimojuc.py

#

i am kinda rewriting the manduck generator to support from options

#

but, the pants and dress color are always coming the same

#

dunno why that is happening

#

i can push the code to my fork, if you want to see the rest of it

#

sir @fervent sage i need your help

fervent sage Apr 22, 2021, 5:53 AM

#

h

#

i fear manduck generation

fallen patrol Apr 22, 2021, 5:55 AM

#

Did reddit just

#

Die

#

#

#reddit, not the website itself*

short snow Apr 22, 2021, 5:59 AM

#

fervent sage i fear manduck generation

lol, i will try debugging more, if anyone can help let me know

#

nvm, thats the wrong screenshot

#

it was fixed long ago

#

correct ss

#

ok the colors are correct

#

but the generator generates them too close

vocal wolf Apr 22, 2021, 6:38 AM

#

If y'all know stuff about unit tests, please review these two very old PRs.

https://github.com/python-discord/bot/pull/954
https://github.com/python-discord/bot/pull/836

fervent sage Apr 22, 2021, 9:43 AM

#

!remind 6h look over quackstack#35

stable mountainBOT Apr 22, 2021, 9:43 AM

#

Can do!

Your reminder will arrive in 6 hours!

dusky shoreBOT Apr 22, 2021, 9:43 AM

#

GitHub

PROpen Allow to pass options while generating Man Ducks

plush falcon Apr 22, 2021, 9:44 AM

#

Hi may I know how do I pull the python bot in my own server?

I had forked it and also tried the webhooks function, but it doesn't work.

short snow Apr 22, 2021, 9:58 AM

#

well if anyone how to create message object mocks and get there link in unit tests let me know.

Need them to write tests for one of the pr on bots ( 1446)

tough imp Apr 22, 2021, 10:02 AM

#

have you looked at the existing tests? I'm sure they create mock messages

#

e.g. https://github.com/python-discord/bot/blob/ce819ade482e82ecbc474bce5fb8ac9dd8b37b40/tests/bot/exts/moderation/test_incidents.py#L130

#

is the link an attribute you want to set?

#

that line sets two attributes: content and attachments

#

you can set any other attribute the same way

short snow Apr 22, 2021, 10:07 AM

#

tough imp is the link an attribute you want to set?

like, this is a message object, then i want to get its message link like this: #dev-contrib message

I want to create like akarys send for the enhance incidents pr you reviewd recently

#

i went thro the tests already, didn't see anywhere how to get the message links, rest i can do ig

tough imp Apr 22, 2021, 10:07 AM

#

what will you use the link for?

#

is the link normally an attribute on the message object?

short snow Apr 22, 2021, 10:10 AM

#

i think so, lemme see

tough imp Apr 22, 2021, 10:11 AM

#

I've written the existing tests so you can ask me about them if you have any questions

short snow Apr 22, 2021, 10:11 AM

#

the existing tests are ok and i can understand them perfectly, this is what i want to do with the tests: #dev-contrib message

tough imp Apr 22, 2021, 10:16 AM

#

I think I'd have to read your implementation to help you write tests for it

#

the way unit tests are written is that you isolate a piece of code that you want to test (e.g. a function, or the regex), and you mock the inputs (and/or state if not pure) to simulate each scenario that you want to test, and then make assertions about the outputs (or state, if side effects)

#

so for example to test the regex, I think you only really need to provide a mock message link

#

and observe whether the regex identifies the link as it should

#

you don't need an actual message object to do that

#

for another example, to test extract_message_links, you would pass a MockMessage(content="my content here") which includes some message links in the content

#

and then observe whether the function returns the desired amount of embeds

#

if you wanted to test the embed content as well, you would have to mock e.g. make_message_link_embed as well

#

that would allow you to test the function in isolation, without depending on what make_message_link_embed returns (because you would mock its return value)

#

however a valid approach would be also to just let make_message_link_embed run

#

I'm not really able to tell you which one would be better in this case, I'd have to spend more time reading the implementation

#

ultimately, something needs to be mocked at some point, because you cannot get a real Context object anyway

short snow Apr 22, 2021, 10:23 AM

#

so i would need to make message link embed and extract message link functions separately?

#

and not in the flow of the on_message ?

tough imp Apr 22, 2021, 10:24 AM

#

well, consider what on_message is responsible for

#

its responsibilities are to check whether the message is an incident, and if so, pass it to add_signals, extract_message_links, and the return value of that, conditionally, to send_webhooks

#

it's not responsible for sending the webhooks directly

#

of course it is possible to write a test that will ascertain whether the webhook is sent correctly on a simulated event propagating through the listener

#

but that is more difficult to orchestrate

#

and I think that's closer to integration testing

#

if you're just testing on_message as a unit, you only need to test that it does what it's responsible for

#

i.e. correctly delegating to other functions

#

the current testing suite is written using this approach

#

though I'm not able to tell you whether it's the best approach, and how useful it ultimately ends up being lol

#

again, please review this class here: https://github.com/python-discord/bot/blob/ce819ade482e82ecbc474bce5fb8ac9dd8b37b40/tests/bot/exts/moderation/test_incidents.py#L746

#

it doesnt assert whether the signals are added

#

it only asserts whether the add_signals function is called as it should

#

add_signals is responsible for adding the signals, not on_message, so that behaviour is tested elsewhere

#

the function docstrings explain the behaviour that is being asserted, so in this case, it is specifically that:

Messages qualifying as incidents are passed to add_signals.
Messages not qualifying as incidents are ignored.

short snow Apr 22, 2021, 10:33 AM

#

I think, it is much clear to me now, I will try writing tests for them

#

if i get stuck, i will let you know 😄

#

thanks!

tough imp Apr 22, 2021, 10:34 AM

#

yea no worries

short snow Apr 22, 2021, 11:58 AM

#

So to sum I need to add these tests:

Mock a message containing two links, see if two links are returned on extract_message_links.
Mock two make_message_link_embed embeds and pass it to the webhook and test whether 2 of them are sent into the channel.
Delete the incident, test if the delete function is called or not.
On editing the incident, is the extract message links function called

vocal prairie Apr 22, 2021, 12:23 PM

#

plush falcon Hi may I know how do I pull the python bot in my own server? I had forked it an...

You can follow this guide to setting it up. https://pydis.com/pages/contributing/bot/

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

Can I pass off the implementation of an !about command? It was discussed here: #dev-contrib message. I've been rather busy lately, so I haven't had the time to do it, and I'd rather not leave it sitting there.

green oriole Apr 22, 2021, 12:59 PM

#

!about

#

Hmm

#

I think we have something like that

#

!info

#

Maybe we yeeted it

#

.about

#

Yeah, why not

short snow Apr 22, 2021, 1:00 PM

#

!bot info

stable mountainBOT Apr 22, 2021, 1:00 PM

#

Python Bot

A utility bot designed just for the Python server! Try !help for more info.

Total Users

181230

green oriole Apr 22, 2021, 1:00 PM

#

It isn’t high priority, it can wait

#

Aha

sleek steppe Apr 22, 2021, 1:04 PM

#

stable mountain

Why is that a hidden command 🤔

green oriole Apr 22, 2021, 1:09 PM

#

¯_(ツ)_/¯

clever wraith Apr 22, 2021, 1:21 PM

#

people in general are calling me dumb for saying python is slow lmao

#

im so glad this channel exists

sleek steppe Apr 22, 2021, 1:21 PM

#

~~But it isn't~~

clever wraith Apr 22, 2021, 1:22 PM

#

it really is

#

go for example is wayyy faster

#

and i know from experience

thorny obsidian Apr 22, 2021, 1:23 PM

#

I think it's a bit unfair to compare a statically typed with dynamically typed language.

clever wraith Apr 22, 2021, 1:23 PM

#

i had literally 2 programs coded to do the same

#

well still

sleek steppe Apr 22, 2021, 1:23 PM

#

I haven't had any issues with speed with python

clever wraith Apr 22, 2021, 1:24 PM

#

im not saying it causes issues

thorny obsidian Apr 22, 2021, 1:24 PM

#

@njit and all my problems are solved 😎

clever wraith Apr 22, 2021, 1:24 PM

#

im just saying its slow

#

if u were to spam requests, python would be way slower

brazen charm Apr 22, 2021, 1:24 PM

#

Not exactly the channel to go to because you didn't like general

clever wraith Apr 22, 2021, 1:25 PM

#

i just appreciated it and then it developed into this

rancid zenith Apr 22, 2021, 1:25 PM

#

I'm seeing this everywhere so I'll just throw in my blanket statement. Python is slow. However, there's plenty reasons for it not mattering, such as it being dynamically typed or the speed difference not being noticeable.

Does that satisfy your statement?

rancid zenith Apr 22, 2021, 1:25 PM

#

brazen charm Not exactly the channel to go to because you didn't like general

whoops

green oriole Apr 22, 2021, 1:25 PM

#

Speed isn’t everything

clever wraith Apr 22, 2021, 1:25 PM

#

yes

#

but i never said python is worse than other languages

#

i was particularly talking about the speed

green oriole Apr 22, 2021, 1:26 PM

#

Programming is a facet of engineering, it is about tradeoffs

rancid zenith Apr 22, 2021, 1:26 PM

#

clever wraith i was particularly talking about the speed

I don't think anyone would disagree, but when you make a statement like that its usually going to be taken as "and thus, worse than other languages" to some

green oriole Apr 22, 2021, 1:26 PM

#

It is off-topic for this channel anyway

clever wraith Apr 22, 2021, 1:26 PM

#

it depends on what ur making

balmy sparrow Apr 22, 2021, 1:26 PM

#

clever wraith if u were to spam requests, python would be way slower

don't the new async frameworks give golang like speeds? uvloop is pretty fast (although not a web framework)

vocal prairie Apr 22, 2021, 1:26 PM

#

For the search feature on the website, would you rather it use a search API or a manual search? I'm personally leaning towards manual, just to try it out.

#

^ That's a pydis dev question, not about python's speed.

clever wraith Apr 22, 2021, 1:27 PM

#

rancid zenith I don't think anyone would disagree, but when you make a statement like that its...

worse in terms of speed, yes

#

but thats all

rancid zenith Apr 22, 2021, 1:27 PM

#

clever wraith worse in terms of speed, yes

#python-discussion ?

clever wraith Apr 22, 2021, 1:27 PM

#

no, too many idiots there

#

i cant handle

rancid zenith Apr 22, 2021, 1:27 PM

#

Well I don't want to clog this chat so... have a good one

clever wraith Apr 22, 2021, 1:27 PM

#

yeah i said everything i had to

green oriole Apr 22, 2021, 1:27 PM

#

It isn’t a reason to not stick to channel topics

vocal prairie Apr 22, 2021, 1:28 PM

#

vocal prairie For the search feature on the website, would you rather it use a search API or a...

For context, this is in regards to site#366

dusky shoreBOT Apr 22, 2021, 1:28 PM

#

GitHub

IssueOpen Dewikification: Search function

clever wraith Apr 22, 2021, 1:28 PM

#

if someone has approved my pr and i do a new commit, does the approval stay?

green oriole Apr 22, 2021, 1:29 PM

#

Yes

clever wraith Apr 22, 2021, 1:29 PM

#

cuz im pretty sure it does and i dont think it should be that way

thorny obsidian Apr 22, 2021, 1:29 PM

#

I'd be down for trying to roll our own, although I'm not sure how core devs feel.

clever wraith Apr 22, 2021, 1:29 PM

#

what if ppl approved it and i sneaked in something malicious

green oriole Apr 22, 2021, 1:29 PM

#

Our own search? 👀 do we really need to?

sleek steppe Apr 22, 2021, 1:29 PM

#

clever wraith cuz im pretty sure it does and i dont think it should be that way

You can re-request a review

green oriole Apr 22, 2021, 1:29 PM

#

clever wraith what if ppl approved it and i sneaked in something malicious

Well we look at it before merging

vocal prairie Apr 22, 2021, 1:29 PM

#

green oriole Our own search? 👀 do we *really* need to?

Idrc, I'm fine with either

clever wraith Apr 22, 2021, 1:29 PM

#

yeah ik but thats not what im talking about

clever wraith Apr 22, 2021, 1:29 PM

#

green oriole Well we look at it before merging

ok

#

good

green oriole Apr 22, 2021, 1:30 PM

#

it is rare that a pr stays with 2 approvals without being merged anyway

clever wraith Apr 22, 2021, 1:30 PM

#

i had 4 approvals

#

now 3 i think cuz i requested a re review

green oriole Apr 22, 2021, 1:30 PM

#

Well, core dev approvals

clever wraith Apr 22, 2021, 1:30 PM

#

ok

#

i asked like 3 maybe staff members to look at it but no one has yet

short snow Apr 22, 2021, 1:31 PM

#

vocal prairie For the search feature on the website, would you rather it use a search API or a...

manual search, the api is completely been moved out for dewifikation

vocal prairie Apr 22, 2021, 1:31 PM

#

short snow manual search, the api is completely been moved out for dewifikation

Not our own API

#

I'm talking about something like Algolia.

short snow Apr 22, 2021, 1:33 PM

#

i don't think we want to depend on external service for that

green oriole Apr 22, 2021, 1:34 PM

#

could we, like, just use a search library?

#

We just have to search a few local files

vocal prairie Apr 22, 2021, 1:34 PM

#

That wouldn't be hard.

#

Just searching markdown and html.

short snow Apr 22, 2021, 1:35 PM

#

we have difflib

vocal prairie Apr 22, 2021, 1:35 PM

#

That's what I meant by manual.

green oriole Apr 22, 2021, 1:35 PM

#

Hmm sounds like that wouldn’t be great performance wise

short snow Apr 22, 2021, 1:35 PM

#

short snow So to sum I need to add these tests: 1. Mock a message containing two links, see...

@tough imp

vocal prairie Apr 22, 2021, 1:36 PM

#

green oriole Hmm sounds like that wouldn’t be great performance wise

It would probably be fine, it's that it might be harder to make the search live.

#

What I mean by live is where results pop up as you're typing.

#

Which isn't necessary.

#

But I'm sure there would be ways to make it more efficient if that's something that's needed.

sleek steppe Apr 22, 2021, 1:38 PM

#

Would it be cool if a tag started with **bold** text, then we'd use that for the embed title?

short snow Apr 22, 2021, 1:38 PM

#

are you searching thro the full content or just the headers?

vocal prairie Apr 22, 2021, 1:39 PM

#

No idea.

#

It's whatever the staff wish to search.

short snow Apr 22, 2021, 1:40 PM

#

one minute, i think my dewification, there is a short description field added

#

ok yes they are added, maybe we can just search thro them,

#

searching thro the entire content wouldn’t be great performance wise

vocal prairie Apr 22, 2021, 1:42 PM

#

So we can just search headers?

#

Headers and the description?

short snow Apr 22, 2021, 1:43 PM

#

in my opinion, worth asking lemon as the issue opener

brazen charm Apr 22, 2021, 1:44 PM

#

sleek steppe Would it be cool if a tag started with \*\*bold\*\* text, then we'd use that for...

Could have some kind of a header for arbitrary embed attrs so we don't have to rely on some special parsing which may not be obvious

#

or just json but I don't really think that's worth it and loses the md preview

sleek steppe Apr 22, 2021, 1:47 PM

#

I mean it wouldn't be too hard to do

line = file.readline()
if match := re.fullmatch(r"\*\*(.+)\*\*", line):
    embed.title = match.group(1)

brazen charm Apr 22, 2021, 1:47 PM

#

Yes, but it is something you need to know about and may not want

fervent sage Apr 22, 2021, 2:13 PM

#

it's a markdown file why not just use markdown?

# Title

body

#

that makes far more intuitive sense i think than using a file format with built in header syntax and using a different way of defining titles

green oriole Apr 22, 2021, 2:19 PM

#

You can also have table representing the metadata

#

It is a common solution

tough imp Apr 22, 2021, 2:26 PM

#

the event definitions use markdown with YAML frontmatter, the bot already has a dependency to parse them

brazen charm Apr 22, 2021, 2:26 PM

#

fervent sage it's a markdown file why not just use markdown? ```md # Title body ```

Was thinking things like urls could also come in handy. With something like ?url=... or ?title=... as a header being simple to parse in the code, or html style comments which don't seem to be rendered by github

tough imp Apr 22, 2021, 2:26 PM

#

and GitHub does render the frontmatter correctly

#

e.g. https://github.com/python-discord/branding/blob/main/events/new_year/meta.md

#

(look at the raw repr)

stable mountainBOT Apr 22, 2021, 3:43 PM

#

@fervent sage

It has arrived!

Here's your reminder: look over quackstack#35.
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Apr 22, 2021, 5:30 PM

#

chop chop

#

I hope it is done 👀

dusky shoreBOT Apr 22, 2021, 6:06 PM

#

GitHub

PROpen Allow to pass options while generating Man Ducks

fervent sage Apr 22, 2021, 6:06 PM

#

@short snow am getting 500s while making manduck requests

brazen charm Apr 22, 2021, 7:17 PM

#

bot#1298 and bot#1299 can be closed (or their scope changed) with the board being archived

dusky shoreBOT Apr 22, 2021, 7:17 PM

#

GitHub

IssueOpen Creating a Bounty Board Leader Board
Add Bounty Leader Board Statistics to the !user command

sleek steppe Apr 22, 2021, 7:38 PM

#

🤔 webhooks are weird

patent pivot Apr 22, 2021, 7:40 PM

#

lol

#

in attempting to add shipit to devlog i have accidentally CENSORED shipit NO MORE SHIPIT

clever wraith Apr 22, 2021, 7:42 PM

#

😢

#

Bad joe

#

~~Please don't ban me lol~~

sleek steppe Apr 22, 2021, 7:44 PM

#

I'll add :shipit: to every approval until it works

clever wraith Apr 22, 2021, 7:44 PM

#

shipit

vale ibex Apr 22, 2021, 7:50 PM

#

sleek steppe <@!126811506632294400> the weird image being outside of the embed bug for the `....

I tracked down the issue

#

It's when the user's name isn't file safe

sleek steppe Apr 22, 2021, 7:51 PM

#

Ah that makes sense

vale ibex Apr 22, 2021, 7:51 PM

#

just writing a quick func to escape invalid filename chars now

vale ibex Apr 22, 2021, 8:01 PM

#

sleek steppe Ah that makes sense

#

#

Works now

sleek steppe Apr 22, 2021, 8:01 PM

#

Ah nice

vale ibex Apr 22, 2021, 8:02 PM

#

pushed

fallen patrol Apr 22, 2021, 8:03 PM

#

vale ibex just writing a quick func to escape invalid filename chars now

just make the name simple lol?

vale ibex Apr 22, 2021, 8:04 PM

#

Hah yea that's an option

#

Was fun to write the escaper though 😛

fallen patrol Apr 22, 2021, 8:06 PM

#

i just wrote something similar lol

#

shaldn't talk about it until its merged tho

short snow Apr 22, 2021, 10:56 PM

#

fervent sage <@!736234578745884682> am getting 500s while making manduck requests

Hmmm, I will have a look

sleek steppe Apr 22, 2021, 11:56 PM

#

Could someone review bot#1531?

dusky shoreBOT Apr 22, 2021, 11:56 PM

#

GitHub

PROpen Redirect output to bot-commands channel for the !eval command

short snow Apr 23, 2021, 12:09 AM

#

sleek steppe Could someone review bot#1531?

I think you are missing a return on line 144

sleek steppe Apr 23, 2021, 12:10 AM

#

Yeah, good catch

short snow Apr 23, 2021, 12:16 AM

#

@gritty wind care to explain this a bit more?

Certain edge cases may occur if a module changes names while unloaded, and in such cases, it may be best to ignore it in code, and send a warning in a dev channel.

#

Like, how can a cog change its name on unload, and even if it does what warning do you send to Dev channel

#

Is it like, you don’t load all cogs found in cache and those which are present in cache but not in the cogs are sent as warning?

gritty wind Apr 23, 2021, 12:19 AM

#

Say you have a module titled "chritsmas"

#

Someone notices that typo after it has already been merged, and decides to rename it

#

now the module will be called "christmas"

#

if chritsmas had been unloaded for some reason

#

You presumably still want it to be unloaded when it becomes christmas

#

But that seems difficult to figure out dynamically

#

so just let people figure it out with something like:
"Couldn't find unloaded module: chritsmas"

#

Ah, I think I see your confision

#

it doesn't change name on unload, it changes name on restart after being unloaded

short snow Apr 23, 2021, 12:22 AM

#

Ok, so basically what I said afterwards, send a warning for all cogs which are present in cache but couldn’t be found

gritty wind Apr 23, 2021, 12:23 AM

#

Yeah

short snow Apr 23, 2021, 12:23 AM

#

I can go ahead and do it then

#

Lemme comment

gritty wind Apr 23, 2021, 12:23 AM

#

it's not approved

#

I want discussion from people who rejected it previously

short snow Apr 23, 2021, 12:25 AM

#

Whoops, didn’t see the label 🏷

sleek steppe Apr 23, 2021, 1:23 AM

#

woops accidentally made a comment instead of an approval

fallen patrol Apr 23, 2021, 3:09 AM

#

hey! why use poetry for stuff that will be published on pypi?

gritty wind Apr 23, 2021, 3:10 AM

#

Like over pipenv?

#

It has native support for it

#

More reminiscent of something like yarn or npm than pipenv

fallen patrol Apr 23, 2021, 3:11 AM

#

gritty wind It has native support for it

wdym

gritty wind Apr 23, 2021, 3:11 AM

#

You can package your module and push it to pypi with one command

#

well, two

#

but they are simple commands, not manual steps

fallen patrol Apr 23, 2021, 3:11 AM

#

ohhhhh

#

snazzzzzzzzzzy

gritty wind Apr 23, 2021, 3:11 AM

#

It's on the homepage of poetry

#

a big selling point

fallen patrol Apr 23, 2021, 3:11 AM

#

!pypi poetry

stable mountainBOT Apr 23, 2021, 3:11 AM

#

poetry v1.1.6

Python dependency management and packaging made easy.

short snow Apr 23, 2021, 3:11 AM

#

@fervent sage changes pushed, you can test it thro this:

curl -X 'GET' \
  'http://127.0.0.1:8000/manduck' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "variation": 1,
  "colors": {
    "body": {
      "r": 252,
      "g": 79,
      "b": 242
    },
    "wing": {
      "r": 252,
      "g": 98,
      "b": 243
    },
    "eye": {
      "r": 50,
      "g": 1,
      "b": 47
    },
    "beak": {
      "r": 252,
      "g": 77,
      "b": 137
    },
    "eye_wing": {
      "r": 254,
      "g": 205,
      "b": 252
    }
  },
  "dress_colors": {
    "shirt": {
      "r": 173,
      "g": 250,
      "b": 41
    },
    "pants": {
      "r": 175,
      "g": 250,
      "b": 46
    }
  },
  "accessories": {
    "hat": "santa",
    "outfit": "ninja",
    "equipment": "radio"
  }
}'

#

sorry for taking space

fallen patrol Apr 23, 2021, 3:12 AM

#

so is the reason to switch to poetry for @dusky shore why?

gritty wind Apr 23, 2021, 3:12 AM

#

Speed, and apparently works better on Mac

fallen patrol Apr 23, 2021, 3:12 AM

#

cause that's a bot and doesn't seem like it'll be going on pypi any time soon

gritty wind Apr 23, 2021, 3:12 AM

#

It is a tooooon faster than pipenv

#

and seems to be more maintained

vocal prairie Apr 23, 2021, 3:12 AM

#

Poetry is way faster

fallen patrol Apr 23, 2021, 3:13 AM

#

yeah lol i normally launch a shell for pipenv since its so slow

#

unrelated

#

vsc isn't running my bash_profile script on the integrated terminal, how to fix that?

#

its

#

.…

#

add -l to terminal.integrated.shellArgs.linux

#

thanks stack overflow

balmy sparrow Apr 23, 2021, 3:29 AM

#

gritty wind well, two

One, if you do poetry publish --build 😛

fallen patrol Apr 23, 2021, 3:45 AM

#

balmy sparrow One, if you do `poetry publish --build` 😛

inb4 tests don't run

#

poetry should run tests before pushing to pypi if it does not already lol

balmy sparrow Apr 23, 2021, 3:52 AM

#

I appreciate how simple they've made it already and run tests myself

clever wraith Apr 23, 2021, 5:47 AM

#

Hey! currently I can't talk (sadly) I would love to but I cant, does someone need some help coding, then dm me.

#

):

#

Hmm hello so high staff help me please aww );;;

short snow Apr 23, 2021, 5:54 AM

#

!voice

stable mountainBOT Apr 23, 2021, 5:54 AM

#

Voice verification

Can’t talk in voice chat? Check out #voice-verification to get access. The criteria for verifying are specified there.

short snow Apr 23, 2021, 5:54 AM

#

@clever wraith

short snow Apr 23, 2021, 7:27 AM

#

sir-lancebot#615 can have good first issue label

dusky shoreBOT Apr 23, 2021, 7:27 AM

#

GitHub

IssueOpen Codeblock rendering inconsistency on Android client.

short snow Apr 23, 2021, 7:28 AM

#

i think you missed this comment @gritty wind , https://github.com/python-discord/sir-lancebot/issues/685#issuecomment-824425749

GitHub

Rework The PR Template · Issue #685 · python-discord/sir-lancebot

Description The PR template has a lot going for it. I like the fields it has, and the descriptions written there for each one are quite adequate, yet, we still end up with a lot of PRs that either ...

gritty wind Apr 23, 2021, 7:28 AM

#

I saw it, but haven't had a chance to action it

#

Don't know if I agree with it

#

Oh, that's a different comment

short snow Apr 23, 2021, 8:00 AM

#

#dev-log message here, am thinking of making a command which can edit the cache (remove, list).

list - listing all cache enteries along with the status of they are loaded or not.

remove - removing a entry

short snow Apr 23, 2021, 8:00 AM

#

short snow So to sum I need to add these tests: 1. Mock a message containing two links, see...

@tough imp , in case you missed this

tough imp Apr 23, 2021, 8:03 AM

#

I don't think such a command would be necessary, the cache probably shouldn't be user-facing, it's just state for the extensions module

#

You can already list extensions and see their status

#

The cache should be a reflection of that

gritty wind Apr 23, 2021, 8:04 AM

#

Theoretically, you can, but the command is broken 👀

#

list, everything else works

tough imp Apr 23, 2021, 8:04 AM

#

short snow <@!144912469071101952> , in case you missed this

I'm not able to answer this, sorry ~ I'd have to read your implementation to try to help you figure out which tests to write

#

try to think about which parts of it would be worth testing

#

starting with the regex sounds good