#dev-contrib | Python | Page 86

gritty wind Feb 23, 2021, 10:31 AM

#

noice

#

are there any characters you can't put in an embed?

vocal wolf Feb 23, 2021, 10:31 AM

#

I escaped the markdown

#

ehhhhhh

#

there may be some

#

I don't know of any, though

#

Filtering specific characters before requesting from a website

#

so there's no possibilities of injections or something

#

also just a good practice tbh

#

sanitization

short snow Feb 23, 2021, 10:37 AM

#

vocal wolf Filtering specific characters before requesting from a website

this should be done in most of such commands then

#

oo, you are streaming, lemme join

vocal wolf Feb 23, 2021, 10:38 AM

#

yep, it should be done with all commands.

#

https://github.com/python-discord/bot/blob/pypi-url-formatter-patch/bot/exts/info/pypi.py#L39-L42

#

current state

short snow Feb 23, 2021, 10:40 AM

#

ok, (Review my pr, of wiki command, and update ttt on sir lance if u get time, and they need update in the labels too)

gritty wind Feb 23, 2021, 10:45 AM

#

That embed looks pretty cool, well done Vester

vocal wolf Feb 23, 2021, 10:46 AM

#

@obsidian patio great work. bot#1429 has been merged.

dusky shoreBOT Feb 23, 2021, 10:46 AM

#

GitHub

PRMerged [bot] #1429 DM on open help channel

obsidian patio Feb 23, 2021, 10:52 AM

#

Awesome!

short snow Feb 23, 2021, 10:53 AM

#

lemon_hyperpleased

#

that was a pretty fast merge

obsidian patio Feb 23, 2021, 10:55 AM

#

Short PR, quick revisions. Nice when things are moving

brazen charm Feb 23, 2021, 10:59 AM

#

Still looking for some reviews on bot#1014 if anyone has maybe an hour or two free

dusky shoreBOT Feb 23, 2021, 10:59 AM

#

GitHub

PROpen [bot] #1014 Doc improvements

vocal wolf Feb 23, 2021, 11:05 AM

#

I'll add it to the bounty board

#

Done.

short snow Feb 23, 2021, 11:15 AM

#

is bounty board visible for contributors?

obsidian patio Feb 23, 2021, 11:15 AM

#

Yep

short snow Feb 23, 2021, 11:18 AM

#

@vale ibex Mentioned changes in c4 pr :D

vale ibex Feb 23, 2021, 11:20 AM

#

!remind 23949s connect 4 PR

stable mountainBOT Feb 23, 2021, 11:20 AM

#

Sure thing!

Your reminder will arrive in 6 hours, 39 minutes and 9 seconds!

vale ibex Feb 23, 2021, 11:21 AM

#

Dang, 2 seconds off 6pm 😂

#

I updated the bot test server yml on notion with @obsidian patio's change, not sure if its worth a dev announce or not

#

obsidian patio Feb 23, 2021, 11:26 AM

#

Cool, thanks!

vale ibex Feb 23, 2021, 11:27 AM

#

I really like the language used in the DM too, nice job 😄

obsidian patio Feb 23, 2021, 11:33 AM

#

Thanks 😄

vocal wolf Feb 23, 2021, 11:44 AM

#

Question

#

How does one use the Redis cache to store message object or message id?

#

preferably message object, if that's even possible

vale ibex Feb 23, 2021, 11:49 AM

#

would it be cache.set(key, value)

vocal wolf Feb 23, 2021, 11:49 AM

#

Using self.bot.redis_session?

vale ibex Feb 23, 2021, 11:49 AM

#

Where cache is async_rediscache.RedisCache(namespace=foo)

vocal wolf Feb 23, 2021, 11:49 AM

#

ah

brazen charm Feb 23, 2021, 11:49 AM

#

Don't think you can really serialize a message in any other way

vale ibex Feb 23, 2021, 11:49 AM

#

https://github.com/python-discord/async-rediscache#using-a-rediscache-instance

GitHub

python-discord/async-rediscache

An easy-to-use asynchronous redis-backed caching utility - python-discord/async-rediscache

short snow Feb 23, 2021, 11:50 AM

#

https://github.com/python-discord/sir-lancebot/blob/master/bot/exts/christmas/advent_of_code/_caches.py

https://github.com/python-discord/sir-lancebot/blob/3ad829d98f1de30f08d26fe592b8a89701301983/bot/exts/christmas/advent_of_code/_helpers.py#L336

Have a look at this two.

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

vocal wolf Feb 23, 2021, 11:50 AM

#

tyvm

#

I think I know the direction I should go in now

short snow Feb 23, 2021, 12:01 PM

#

have we used redis cache in bot?

#

if yes where

brazen charm Feb 23, 2021, 12:01 PM

#

help channels and dm log come to mind

green oriole Feb 23, 2021, 12:03 PM

#

We use it quite a lot

gritty wind Feb 23, 2021, 12:03 PM

#

voice gate, silence, branding

green oriole Feb 23, 2021, 12:03 PM

#

On top of my head, we use it for people who got the ping in #voice-verification, branding state, silenced channels, defcon state (soon)

gritty wind Feb 23, 2021, 12:03 PM

#

What are you using it for again?

vocal wolf Feb 23, 2021, 12:05 PM

#

gritty wind What are you using it for again?

https://github.com/python-discord/bot/pull/1414#issuecomment-777409931

short snow Feb 23, 2021, 12:05 PM

#

xith was asking for in the stream on twitch, we were doing it for the ^

gritty wind Feb 23, 2021, 12:05 PM

#

Riiight

#

Do you need to store anything other than the IDs?

vocal wolf Feb 23, 2021, 12:06 PM

#

am trying to store the object

#

but other than that

#

no

#

message object, that is

gritty wind Feb 23, 2021, 12:06 PM

#

Well, I'm presuming you want it to edit it, yeah?

short snow Feb 23, 2021, 12:07 PM

#

yeah

gritty wind Feb 23, 2021, 12:07 PM

#

I think you can store just what you need to recreate it and get discord to edit it

#

Without storing the whole thing

short snow Feb 23, 2021, 12:07 PM

#

(kwzrd suggested use of redis)

gritty wind Feb 23, 2021, 12:07 PM

#

Let me look at the init

#

I saw the issue, just wasn't sure what data you needed

vocal wolf Feb 23, 2021, 12:08 PM

#

I'm not completely sure if we need redis though

#

Since it's only one ID

gritty wind Feb 23, 2021, 12:08 PM

#

Are you planning on ditching persistence, or?

vocal wolf Feb 23, 2021, 12:09 PM

#

I'm thinking about it

#

I mean it would be neat to have it

#

But is it necessary for this?

short snow Feb 23, 2021, 12:09 PM

#

i had the same thinking, of not using redis, but when xith told that a big contributor told about it, there must be some reason

vocal wolf Feb 23, 2021, 12:09 PM

#

Would it take more work to use the redis cache, or just search for the message?

vocal wolf Feb 23, 2021, 12:10 PM

#

short snow i had the same thinking, of not using redis, but when xith told that a big contr...

That person being kwzrd

short snow Feb 23, 2021, 12:11 PM

#

redis cache would probably be neater i think

vocal wolf Feb 23, 2021, 12:11 PM

#

I mean it's like one extra API call, which we don't exactly want

#

My verdict: yes on the Redis cache

gritty wind Feb 23, 2021, 12:11 PM

#

It's 1 API call on startup to avoid having to use d.py hacks

short snow Feb 23, 2021, 12:12 PM

#

hmmm, what was the issue last time?

#

when we merged the pr

vocal wolf Feb 23, 2021, 12:12 PM

#

Editing an uneditable message

gritty wind Feb 23, 2021, 12:13 PM

#

I'm looking at the message edit src code, and all you'd need to inject is channel ID and msg ID

short snow Feb 23, 2021, 12:13 PM

#

webhook messages are uneditable?

gritty wind Feb 23, 2021, 12:13 PM

#

They aren't from the bot

#

Can't edit a message from a different user

short snow Feb 23, 2021, 12:14 PM

#

ok, so what are u doing rn then? Making the bot send a message and then edit it on claiming channels?

vocal wolf Feb 23, 2021, 12:14 PM

#

if message exists, edit message. otherwise, send message, set dynamic message to that message, save in cache.

short snow Feb 23, 2021, 12:15 PM

#

ah right

vocal wolf Feb 23, 2021, 12:15 PM

#

skipped some parts, but that's a tldr

short snow Feb 23, 2021, 12:15 PM

#

yeah understood

gritty wind Feb 23, 2021, 12:29 PM

#

Made a POC for editing a message from a channel id + msg id

#

but it became a bit esoteric

#

import discord; from types import SimpleNamespace; msg_props = SimpleNamespace(_state=SimpleNamespace(http=self.bot.http), channel=SimpleNamespace(id=776836333208600591), id=813748314746912819, _update=lambda x: x); await discord.Message.edit(self=msg_props, content="test")

vocal wolf Feb 23, 2021, 12:30 PM

#

oh god

gritty wind Feb 23, 2021, 12:30 PM

#

It doesn't look too bad when you expand it

#

but I'm too lazy to expand it

#

What have you done

#

https://paste.pythondiscord.com/viwuzuhiqu.properties

#

Expanded version

#

I will slap you if this makes it into a PR though lol

vocal wolf Feb 23, 2021, 12:32 PM

#

!e print('\n'.join('import discord; from types import SimpleNamespace; msg_props = SimpleNamespace(_state=SimpleNamespace(http=self.bot.http), channel=SimpleNamespace(id=776836333208600591), id=813748314746912819, _update=lambda x: x); await discord.Message.edit(self=msg_props, content="test")'.split('; ')))

#

ffs

stable mountainBOT Feb 23, 2021, 12:32 PM

#

@vocal wolf :white_check_mark: Your eval job has completed with return code 0.

001 | import discord
002 | from types import SimpleNamespace
003 | msg_props = SimpleNamespace(_state=SimpleNamespace(http=self.bot.http), channel=SimpleNamespace(id=776836333208600591), id=813748314746912819, _update=lambda x: x)
004 | await discord.Message.edit(self=msg_props, content="test")

vocal wolf Feb 23, 2021, 12:32 PM

#

lol

vocal wolf Feb 23, 2021, 12:33 PM

#

gritty wind I will slap you if this makes it into a PR though lol

eheheheheh

#

now I want to

gritty wind Feb 23, 2021, 12:33 PM

#

I mean we do something similar with docs

#

but that's because a better solution doesn't exist there

vocal wolf Feb 23, 2021, 12:41 PM

#

@gritty wind unfortunately objects cannot be put into the cache

#

but maybe I could serialize them

#

would that be overdoing it?

gritty wind Feb 23, 2021, 12:42 PM

#

Yesh, hence the hack with IDs above

#

But yeah that's overkill

#

just save the IDs, and fetch them

#

The channel should be available, the message should be fetched

whole forge Feb 23, 2021, 1:45 PM

#

thing that came up between me and @gritty wind trying to get @vocal wolf bot dev setup working in docker compose:
what are the opinions on putting restart: always on the bot service? This would allow to bot to restart by itself if it crashes because the site hasn't loaded yet.

personally, i would also like to add a config for the log-storage as to prevent logs file from growing to horrendous sizes when leaving the bot running for a while.

gritty wind Feb 23, 2021, 1:47 PM

#

👍 from me, but I'd also like this only as a temporary solution, as there are other docker errors that indicate a problematic config.

I think the bigger fix here, and it's something we talked about at various points but never implemented is to have the bot wait for site on startup. I'd also like better startup errors, but we have an unapproved issue pending for that

cold moon Feb 23, 2021, 1:48 PM

#

We should do something like site do for waiting PostgreSQL

brazen charm Feb 23, 2021, 1:51 PM

#

Should we be able to bypass that? I often start the bot without the site running for features that do not require it

gritty wind Feb 23, 2021, 1:52 PM

#

Doesn't the bot error out on start if site isn't running?

whole forge Feb 23, 2021, 1:53 PM

#

i made a draft PR for it: https://github.com/python-discord/bot/pull/1430

GitHub

Add logging and restart config to docker compose by laundmo · Pull ...

This adds logging and restart configs to the docker compose.
Both are added using yaml anchors, which makes them easily change-able across all services.
related discussion on discord

#

(tell me if the tags are wrong)

gritty wind Feb 23, 2021, 1:55 PM

#

So it's probably not CI because we don't use compose in CI but it doesn't matter

brazen charm Feb 23, 2021, 1:55 PM

#

It didn't last time I ran it like that but it has been a while, something may have changed that makes a request before the bot starts fully

gritty wind Feb 23, 2021, 1:55 PM

#

I think we also have enhancemnet

gritty wind Feb 23, 2021, 1:56 PM

#

brazen charm It didn't last time I ran it like that but it has been a while, something may ha...

defcon

brazen charm Feb 23, 2021, 1:56 PM

#

That was wrapped in a broad except last time I checked so it shouldn't stop startup

#

Looks like it doesn't work now because of await self.cache_filter_list_data() in the bot login, which can be deleted to work without the site running

whole forge Feb 23, 2021, 1:59 PM

#

right, but its still a issue for people that want the site running/need site features, and just do docker-compose up -d

gritty wind Feb 23, 2021, 1:59 PM

#

Hmm it shouldn't be except for very specific issues, because the site will be ready when they go to use it

#

But startup features that fetch from bot won't work

#

So a waiting solution would still work better imo

brazen charm Feb 23, 2021, 2:02 PM

#

Waiting sounds good for me, just also would like something to bypass that, although I'm not sure if there even is a good way of doing that (maybe handling a single keyboard interrupt)

austere jetty Feb 23, 2021, 2:09 PM

#

#bot-commands

gritty wind Feb 23, 2021, 2:10 PM

#

Hi

#

Is something wrong?

short snow Feb 23, 2021, 2:18 PM

#

gritty wind Is something wrong?

I think they want to run code from links, but currently the snebox doesn't support it

#

like we paste a pastebin link, it gets the code from there and then runs it

gritty wind Feb 23, 2021, 2:19 PM

#

Ah lol, I sent that message before they started typing

#

It probably won't be a snekbox thing, but a bot thing

#

But hmm

short snow Feb 23, 2021, 2:19 PM

#

yeah yeah

#

a bot thing

gritty wind Feb 23, 2021, 2:19 PM

#

I'm not sure if we want to fetch code from unknown sources

patent pivot Feb 23, 2021, 2:19 PM

#

oh that reminds me about something else

#

!remind 1h readiness checks

stable mountainBOT Feb 23, 2021, 2:19 PM

#

Alright.

Your reminder will arrive in 1 hour!

short snow Feb 23, 2021, 2:19 PM

#

like:

!e
link=<link>

#

only python discord pastebin links

#

and also support to run .py files, like your message contains a attachement

patent pivot Feb 23, 2021, 2:20 PM

#

Didn't we decide against that

#

also we ban py attachments

gritty wind Feb 23, 2021, 2:20 PM

#

short snow and also support to run `.py` files, like your message contains a attachement

that's a hard no

#

we don't allow attachments on the server yeah

patent pivot Feb 23, 2021, 2:20 PM

#

yeah I'm fairly sure we decided against running from the pastebin

#

it isn't the intent of snekbox or the eval feature

#

there is an issue somewhere, but I'm on mobile

#

either organisation or meta

#

or maybe bot

gritty wind Feb 23, 2021, 2:21 PM

#

That's all the places an issue can be haha

#

Is it closed?

patent pivot Feb 23, 2021, 2:22 PM

#

think so

#

now on laptop 1 sec

#

https://github.com/python-discord/bot/issues/1133

GitHub

Evaluate code from website Pastebin. · Issue #1133 · python-discord...

Feature Suggestion The idea was suggested, but never implemented. We could implement it like this.

#

open I guess

#

but yeah I'd rather not

short snow Feb 23, 2021, 2:24 PM

#

bot#1133

dusky shoreBOT Feb 23, 2021, 2:24 PM

#

GitHub

IssueOpen [bot] #1133 Evaluate code from website Pastebin.

short snow Feb 23, 2021, 2:24 PM

#

open

stable mountainBOT Feb 23, 2021, 3:19 PM

#

@patent pivot

It has arrived!

Here's your reminder: readiness checks.
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Feb 23, 2021, 3:31 PM

#

I was about to ask someone to investigate that :D

patent pivot Feb 23, 2021, 3:56 PM

#

!remind 1h actually readiness checks

stable mountainBOT Feb 23, 2021, 3:56 PM

#

You got it!

Your reminder will arrive in 1 hour!

stable mountainBOT Feb 23, 2021, 4:56 PM

#

@patent pivot

It has arrived!

Here's your reminder: actually readiness checks.
[Jump back to when you created the reminder](#dev-contrib message)

obsidian patio Feb 23, 2021, 5:00 PM

#

Hey @patent pivot @green oriole @subtle kraken @vocal wolf @gritty wind! It's just about time for the meeting. Wanna join dev-vc?

subtle kraken Feb 23, 2021, 5:00 PM

#

hello

short snow Feb 23, 2021, 5:00 PM

#

(hello)

celest charm Feb 23, 2021, 5:02 PM

#

@patent pivot what's the text chat for dev-voice?

#

lemon_pensive

short snow Feb 23, 2021, 5:02 PM

#

Everyone left hmmm....

#

ah shifted to staff

balmy sparrow Feb 23, 2021, 5:34 PM

#

Heyo, the fuzzy matching for the commands suggestion seems to pick up any additional text that come with it as well

#

Saw something happen where a super large text block was also added to it, leading to a large embed reply from the bot

#

!pste test 1 2 3 4 5

#

Should I be making an issue for this? (the suggestion embed gets deleted but you can test it with ^ )

sleek steppe Feb 23, 2021, 5:43 PM

#

Afaik, paste is a tag, not a command.

#

!t paste

stable mountainBOT Feb 23, 2021, 5:44 PM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pydis.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

sleek steppe Feb 23, 2021, 5:45 PM

#

wait nvm there are still suggestions for tags

stable mountainBOT Feb 23, 2021, 5:59 PM

#

@vale ibex

It has arrived!

Here's your reminder: connect 4 PR.
[Jump back to when you created the reminder](#dev-contrib message)

grim tide Feb 23, 2021, 8:23 PM

#

how is the command typo fixer coded?

rapid swallow Feb 23, 2021, 8:28 PM

#

grim tide how is the command typo fixer coded?

it's similar to the tag system

grim tide Feb 23, 2021, 8:28 PM

#

ah, so the typos are manually coded in?

rapid swallow Feb 23, 2021, 8:28 PM

#

https://github.com/python-discord/bot/blob/604c9b6ff1ac169235adbf89a596bcca5f28f7cc/bot/exts/backend/error_handler.py#L65-L70

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

rapid swallow Feb 23, 2021, 8:29 PM

#

grim tide ah, so the typos are manually coded in?

no

clever wraith Feb 23, 2021, 8:29 PM

#

why do you guys make a cog for every command?

rapid swallow Feb 23, 2021, 8:29 PM

#

https://github.com/python-discord/bot/blob/604c9b6ff1ac169235adbf89a596bcca5f28f7cc/bot/exts/backend/error_handler.py#L180
you can see the source code for getting similar command here

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

rapid swallow Feb 23, 2021, 8:29 PM

#

clever wraith why do you guys make a cog for every command?

we don't
cogs are made for related commands

grim tide Feb 23, 2021, 8:30 PM

#

thanks

clever wraith Feb 23, 2021, 8:30 PM

#

rapid swallow we don't cogs are made for related commands

no, for sir-lancebot

brazen charm Feb 23, 2021, 8:30 PM

#

Why is that under the tag function anyway

fallen patrol Feb 23, 2021, 8:40 PM

#

so

#

what was the bug for the help channels clonking out today?

obsidian patio Feb 23, 2021, 8:42 PM

#

Basically, we merged a feature where the first message from the user in the help channel was sent to them in DMs (check out #changelog)

#

the issue is when they just sent an image. That means there was no message, so the bot tried to send an empty message, which throws an exception

fallen patrol Feb 23, 2021, 8:43 PM

#

yeah, and bumped the count up to 3, but i'm guessing that was a config change

fallen patrol Feb 23, 2021, 8:43 PM

#

obsidian patio the issue is when they just sent an image. That means there was no message, so t...

ohhhh

obsidian patio Feb 23, 2021, 8:43 PM

#

Since there's an exception before the new channel is moved up, we'll be left with one less available help channel

fallen patrol Feb 23, 2021, 8:43 PM

#

so now I assume it will attach the image in DMs

obsidian patio Feb 23, 2021, 8:44 PM

#

Scaleos fixed it. Not sure how it handles that edge case now

fallen patrol Feb 23, 2021, 8:44 PM

#

~~would I get in trouble for testing?~~

obsidian patio Feb 23, 2021, 8:45 PM

#

No

#

Seems like it just logs the exception and ignores it atm

#

Not optimal, but it works

#

https://github.com/python-discord/bot/commit/d71ac9f6e240ffd2d4195d9dbbf5740a0c2413a1

clever wraith Feb 23, 2021, 8:46 PM

#

can confirm, works

fallen patrol Feb 24, 2021, 2:27 AM

#

obsidian patio Seems like it just logs the exception and ignores it atm

testing

#

oh hey it didn't crash

obsidian patio Feb 24, 2021, 2:28 AM

#

Yep, scal fixed it

fallen patrol Feb 24, 2021, 2:28 AM

#

#help-pineapple message

#

Well, I tested to see if it would crash if it deleted the message via the spam filter

#

so I attached a message.txt and filled it with useless text

obsidian patio Feb 24, 2021, 2:31 AM

#

Yeah

#

Right now we just filter out the exceptions

clever wraith Feb 24, 2021, 3:14 AM

#

erm

#

i wanna contribute to

#

uh

#

sir lancebot

#

but erm

#

yeah

#

how do i do that

thorny obsidian Feb 24, 2021, 3:16 AM

#

We have resources for that! First off, here's the repo for for Sir Lancebot:
https://github.com/python-discord/sir-lancebot

Take a look through and see if there are existing issues that you want to work on. If you have a specific thing you want to implement, that's fine too. We just want you to make an issue about it first so we can assign you to it.

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

#

We do have some contributing guidelines, you can take a read through them before you work on your contribution/feature: https://github.com/python-discord/sir-lancebot/blob/master/CONTRIBUTING.md

short snow Feb 24, 2021, 3:17 AM

#

And the contributing guide on the sir-lancebot repo and site

thorny obsidian Feb 24, 2021, 3:18 AM

#

Finally, here's a helpful wiki for how to get Sir Lancebot up and running locally so you can test your feature and all that good stuff: https://pythondiscord.com/pages/contributing/sir-lancebot/

Python Discord | Contributing to Sir Lancebot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

Feel free to ask here if you want to bounce ideas off of us or have issues getting Sir Lancebot running

short snow Feb 24, 2021, 3:18 AM

#

You need to have a good understanding of discord.py for contributing to sir-lancebot.

balmy sparrow Feb 24, 2021, 3:31 AM

#

balmy sparrow Saw something happen where a super large text block was also added to it, leadin...

Bump

clever wraith Feb 24, 2021, 3:32 AM

#

thorny obsidian We have resources for that! First off, here's the repo for for Sir Lancebot: htt...

do u guys use cogs? because i dont

thorny obsidian Feb 24, 2021, 3:32 AM

#

balmy sparrow Should I be making an issue for this? (the suggestion embed gets deleted but you...

yes, please do make an issue

clever wraith Feb 24, 2021, 3:32 AM

#

i am sfupid so i do not know how to make cogs

thorny obsidian Feb 24, 2021, 3:32 AM

#

clever wraith do u guys use cogs? because i dont

yes we do, this could be a great opportunity to learn about cogs and use them

clever wraith Feb 24, 2021, 3:32 AM

#

oh ok

#

cogs are great because all my commands are in separate files

#

i know how to do the usual @client.command thing

#

why do you guys make cogs for pretty much for every command?

#

pretty confusing lemon_thinking

thorny obsidian Feb 24, 2021, 3:35 AM

#

Because we can then unload/reload them and it keeps it fairly structured. If you want to work on a specific command, you only need to alter a few smaller files and not massive ones

clever wraith Feb 24, 2021, 3:36 AM

#

yeah

#

if you have 20 commands all packed in main.py

#

then...

sleek steppe Feb 24, 2021, 3:37 AM

#

I don't think it's confusing

clever wraith Feb 24, 2021, 3:39 AM

#

if anyone has a good tutorial on cogs please tell me

#

so i can contribute

vocal wolf Feb 24, 2021, 3:50 AM

#

@thorny obsidian thursday sounds good. What timezone are you in?

thorny obsidian Feb 24, 2021, 3:50 AM

#

vocal wolf <@!212644551926611969> thursday sounds good. What timezone are you in?

EST but with your sleep schedule does that matter? =P I'm functioning at 8am and my cutoff is 10pm

fallen patrol Feb 24, 2021, 3:51 AM

#

@vocal wolf #community-meta message

vocal wolf Feb 24, 2021, 3:51 AM

#

thorny obsidian EST but with your sleep schedule does that matter? =P I'm functioning at 8am and...

Given it's a Thursday and I have Calculus I won't be available until like 1130 PST, 230pm your time

fallen patrol Feb 24, 2021, 3:51 AM

#

#community-meta message

thorny obsidian Feb 24, 2021, 3:51 AM

#

vocal wolf Given it's a Thursday and I have Calculus I won't be available until like 1130 P...

oh that's perf

fallen patrol Feb 24, 2021, 3:51 AM

#

Those two

vocal wolf Feb 24, 2021, 3:51 AM

#

fallen patrol https://canary.discord.com/channels/267624335836053506/429409067623251969/812496...

mmmmmm I don't know, people can insert offensive names

fallen patrol Feb 24, 2021, 3:52 AM

#

itd be for internal use only ¯\_(ツ)_/¯

#

besides, you don't think they can submit offensive questions already?

vocal wolf Feb 24, 2021, 3:52 AM

#

I've already seen pretty wack posts

fallen patrol Feb 24, 2021, 3:52 AM

#

This was the reason i gave for it

#

This way someone could get updated with their question got added

vocal wolf Feb 24, 2021, 3:52 AM

#

I mean I guess it's so we can contact the user if we have questions

fallen patrol Feb 24, 2021, 3:53 AM

#

And i never fixed the typo, *when

vocal wolf Feb 24, 2021, 3:53 AM

#

Have you made an issue in the sir-lancebot repo?

#

It would be much easier to keep track of progress there

fallen patrol Feb 24, 2021, 3:53 AM

#

No, i haven't coughs

vocal wolf Feb 24, 2021, 3:54 AM

#

@thorny obsidian we shall be productive.

fallen patrol Feb 24, 2021, 3:54 AM

#

I wasn't sure if i make a meta issue and a sirlancboe issue

vocal wolf Feb 24, 2021, 3:54 AM

#

sir lancebot issue will do

fallen patrol Feb 24, 2021, 3:54 AM

#

~~perhaps she'll tell me what she uses for git eventually~~

fallen patrol Feb 24, 2021, 3:54 AM

#

vocal wolf sir lancebot issue will do

Ok

#

Unfortunately i can't make it right now and probably not uh, until thursday

#

I have a thingy tomorrow so that's out. 😓

vocal wolf Feb 24, 2021, 3:55 AM

#

ah

#

I wish you luck

#

I hope everything goes well!

fallen patrol Feb 24, 2021, 3:56 AM

#

Yee, it should go well, not that big

vocal wolf Feb 24, 2021, 3:56 AM

#

oh god damn

fallen patrol Feb 24, 2021, 3:56 AM

#

Can continue in another fairly ignored channel lol

#

~~i wouldn't say this in ot~~

vocal wolf Feb 24, 2021, 3:56 AM

#

You have teh powah!

fallen patrol Feb 24, 2021, 3:57 AM

#

Anyways

#

There's a lot of stuff in #community-meta soley about the topic command not having a lot of topics on it and ppl saying no one looks at the stuff

vocal wolf Feb 24, 2021, 3:58 AM

#

!remind @thorny obsidian 39h Meet for thing

stable mountainBOT Feb 24, 2021, 3:58 AM

#

Affirmative!

Your reminder will arrive in 1 day and 15 hours and will mention 1 other(s)!

fallen patrol Feb 24, 2021, 3:59 AM

#

Wut you can do that

vocal wolf Feb 24, 2021, 3:59 AM

#

ye

#

tbh I think #community-meta is for suggesting the idea, and then you go to the repo and make an issue after getting approval from others in that channel

#

that channel's like for staging I guess

green oriole Feb 24, 2021, 8:39 AM

#

vocal wolf !remind <@!212644551926611969> 39h Meet for thing

What is it all about? pithink

vocal wolf Feb 24, 2021, 8:40 AM

#

green oriole What is it all about? <:pithink:652247559909277706>

cleaning up the topics in the .topic command

#

adding more, editing, deleting, etc.

green oriole Feb 24, 2021, 8:42 AM

#

A'ight

vale ibex Feb 24, 2021, 11:00 AM

#

@short snow Sorry I just realised that my comment on your connect 4 PR lost the context of the other comment I was replying too, so might not have made sense. I've updated the comment, hopefully it makes more sense now 😄

short snow Feb 24, 2021, 11:32 AM

#

vale ibex <@!736234578745884682> Sorry I just realised that my comment on your connect 4 P...

Cool thanks will have a look it

#

ah an guild check, that's what was missing

#

😬

#

uhh, i will do that rn

#

should i hardcode the channel, or use constants?

gritty wind Feb 24, 2021, 11:35 AM

#

If you're just trying to prevent it from running in DM, I think there's a check for that

#

Or are you trying to do something else

short snow Feb 24, 2021, 11:36 AM

#

gritty wind If you're just trying to prevent it from running in DM, I think there's a check ...

yes that's what i am doing

gritty wind Feb 24, 2021, 11:37 AM

#

Right, so what needs hardcoding?

short snow Feb 24, 2021, 11:37 AM

#

lemme see if there is a check for that

vale ibex Feb 24, 2021, 11:38 AM

#

I think the commands.guild_only() check would be enough

short snow Feb 24, 2021, 11:38 AM

#

gritty wind Right, so what needs hardcoding?

the community commands channel id

vale ibex Feb 24, 2021, 11:38 AM

#

https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.guild_only

gritty wind Feb 24, 2021, 11:38 AM

#

short snow the community commands channel id

That's already done for you

short snow Feb 24, 2021, 11:38 AM

#

vale ibex I think the `commands.guild_only()` check would be enough

i don't think that it takes a message argument

vale ibex Feb 24, 2021, 11:38 AM

#

short snow the community commands channel id

That's in constants.py afaik

gritty wind Feb 24, 2021, 11:38 AM

#

You just need to stop it from running in guild

short snow Feb 24, 2021, 11:38 AM

#

ah ok

#

got it

gritty wind Feb 24, 2021, 11:39 AM

#

All commands in sir-lance run through the whitelist_check, which passes on guild, and checks for very specific channels otherwise

short snow Feb 24, 2021, 11:41 AM

#

It doesn't provide the sir lancebot chanel here

vale ibex Feb 24, 2021, 11:42 AM

#

you can pass a channel kwarg to the whitelist check, which will output the channels

#

although the check doesn't seem to be running

gritty wind Feb 24, 2021, 11:43 AM

#

The whitelist check wouldn't help here because it only affects on-server things

vale ibex Feb 24, 2021, 11:44 AM

#

yea, true.

#

One option is to use the commands.guild_only() decorator and then catch NoPrivateMessage in an command error handler

#

but something more generic may be useful for the bot

gritty wind Feb 24, 2021, 11:45 AM

#

We already handle it globally

#

https://github.com/python-discord/sir-lancebot/blob/master/bot/exts/evergreen/error_handler.py#L85

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

short snow Feb 24, 2021, 11:45 AM

#

(Example the ttt command pic i showed)

vale ibex Feb 24, 2021, 11:46 AM

#

Ahh right, so just the decorator is needed then

short snow Feb 24, 2021, 11:47 AM

#

can i edit the embed sent out by that error handler pointing towards #sir-lancebot-playground

vale ibex Feb 24, 2021, 11:47 AM

#

That's good to know for future and probably invalidates the point of sir-lancebot#581

dusky shoreBOT Feb 24, 2021, 11:47 AM

#

GitHub

IssueOpen [sir-lancebot] #581 Block commands from working in DMs

vale ibex Feb 24, 2021, 11:47 AM

#

short snow can i edit the embed sent out by that error handler pointing towards <#607247579...

That could be useful

short snow Feb 24, 2021, 11:47 AM

#

@gritty wind whats your say?

#

should i jsut do it with c4 pr

#

since it is just a line change

gritty wind Feb 24, 2021, 11:48 AM

#

Sure

short snow Feb 24, 2021, 11:48 AM

#

okie dokie

short snow Feb 24, 2021, 12:06 PM

#

@vale ibex done 🎉

#

vale ibex Feb 24, 2021, 12:08 PM

#

Looks good, how come you added a new import for guild_only, instead of using commands.guild_only, since you already have commands imported?

short snow Feb 24, 2021, 12:08 PM

#

uhh, i just hovered over the error and pycharm did that lol

vale ibex Feb 24, 2021, 12:08 PM

#

Ahhh 😂

short snow Feb 24, 2021, 12:09 PM

#

should i change it?

vale ibex Feb 24, 2021, 12:09 PM

#

another reason why notepad is the one true editor

vale ibex Feb 24, 2021, 12:09 PM

#

short snow should i change it?

I'm going to approve your current changes anyway, up to you if you want to change it

short snow Feb 24, 2021, 12:09 PM

#

if u approve, it is a merge

#

lol

#

press the secret button 🙃

vale ibex Feb 24, 2021, 12:10 PM

#

😦

#

Not my decision lol

gritty wind Feb 24, 2021, 12:10 PM

#

I can merge it in a bit

short snow Feb 24, 2021, 12:10 PM

#

ok lemon_hyperpleased

short snow Feb 24, 2021, 12:11 PM

#

vale ibex Not my decision lol

soon™️

vale ibex Feb 24, 2021, 12:12 PM

#

~~It's only a matter of time until the owls take over brother~~

short snow Feb 24, 2021, 12:25 PM

#

We should change the annotation for bot from commands.Bot to bot.Bot to fix the http_session annotation errors

green oriole Feb 24, 2021, 12:43 PM

#

@gritty wind do you mean commands that need to be invoked in the server, or commands that will require DMs?

gritty wind Feb 24, 2021, 12:44 PM

#

The original issue was about commands being invoked from DM

#

The code chris posted will only affect that, not the bot using DMs

green oriole Feb 24, 2021, 12:47 PM

#

Right, there shouldn't be any commands that need to be invoked in DMs then

gritty wind Feb 24, 2021, 12:47 PM

#

sweet beans

cold moon Feb 24, 2021, 12:48 PM

#

I think minesweeper uses DM commands?

short snow Feb 24, 2021, 12:48 PM

#

only input

gritty wind Feb 24, 2021, 12:48 PM

#

Ideally we should move all that to the server

#

But for now I think none of those require you enter commands into DMs

short snow Feb 24, 2021, 12:49 PM

#

uhh, that could be a bit spamming, and would loose the board, since even others use the channel

#

loose board meaning go up in message history

gritty wind Feb 24, 2021, 12:50 PM

#

Battleship and minesweeper are the only games affected by this?

#

We can have the bot delete the messages

#

And the sir-lancebot channel does not move as fast as bot-commands

short snow Feb 24, 2021, 12:51 PM

#

uhh, just allow inputs in DMs, and not "invoking" the command

gritty wind Feb 24, 2021, 12:51 PM

#

But input is also susceptible to breaking

#

And it's already difficult enough to investigate some bugs

#

If we can reduce the complexity, that would be awesome

short snow Feb 24, 2021, 12:51 PM

#

hmmm, so we can do it like the sal command

#

true

#

sorry for breaking the discussion, but:
there are two annotations issues in the sir-lancebot dunno about bot.

We should change the annotation for bot from commands.Bot to bot.Bot to fix the http_session annotation errors

in a lot of places in the sir-lancebot code this happens:

def func() -> None:
  return await ctx.send()

but it should be

def func() -> None:
  await ctx.send()
  return

cold moon Feb 24, 2021, 12:54 PM

#

Maybe we can make global DM disable, but decorator that bypass this.

gritty wind Feb 24, 2021, 12:54 PM

#

That would be easy, but why?

cold moon Feb 24, 2021, 12:56 PM

#

Like minesweeper should stay in DMs

gritty wind Feb 24, 2021, 12:56 PM

#

That would be unrelated to this

#

The change to make commands invokable only from the server won't affect message handlers getting messages in DMs

#

So there is no need for an override

cold moon Feb 24, 2021, 12:57 PM

#

I don't understand now. Do you want disable commands in DMs?

short snow Feb 24, 2021, 12:57 PM

#

this like i said in my comment on the github

gritty wind Feb 24, 2021, 12:57 PM

#

Yes, that's what I want

#

Invoke commands only from the server

short snow Feb 24, 2021, 12:58 PM

#

you can get messages from DMs, but not start a command or "invoke" it in the DMs

gritty wind Feb 24, 2021, 12:58 PM

#

Which is what we do with @stable mountain

cold moon Feb 24, 2021, 12:58 PM

#

But .ms reveal|flag commands is meant to be executed in DMs

gritty wind Feb 24, 2021, 12:58 PM

#

Which is the difficult part in this

#

I want it moved to the server

#

But the concern is that it would flood the chat

#

So I'm thinking we delete the message after the action is done

short snow Feb 24, 2021, 12:59 PM

#

it would also go up in the message history

#

the board

gritty wind Feb 24, 2021, 12:59 PM

#

The sir-lancebot channel does not scroll that fast

short snow Feb 24, 2021, 1:01 PM

#

it could, you never know

short snow Feb 24, 2021, 2:03 PM

#

@gritty wind Done! Also why did the lint and status embed run twice?

gritty wind Feb 24, 2021, 2:05 PM

#

Hmm I’ll check it out in a bit

patent pivot Feb 24, 2021, 2:10 PM

#

huh

#

would that be me

#

no

gritty wind Feb 24, 2021, 2:11 PM

#

Nah

#

It’s two runs

gritty wind Feb 24, 2021, 2:27 PM

#

I don't know

#

I think it's just github fucking up

#

the merge went fine

short snow Feb 24, 2021, 2:29 PM

#

#sir-lancebot-playground message 🎉 🎉

thorny obsidian Feb 24, 2021, 3:07 PM

#

!source

stable mountainBOT Feb 24, 2021, 3:07 PM

#

Bot's GitHub Repository

Repository

Go to GitHub

dry folio Feb 24, 2021, 3:07 PM

#

thorny obsidian !source

i'm here now 🙂

#

i see a bunch of files with weird names lol

thorny obsidian Feb 24, 2021, 3:08 PM

#

so all of your bot code in the repo is in the bot folder you see. The way we use our bot is with extensions and cogs, so for most things you go to the exts folder

dry folio Feb 24, 2021, 3:09 PM

#

thorny obsidian so all of your bot code in the repo is in the `bot` folder you see. The way we u...

ah i see

#

yeah i see a folder named "moderation"!

thorny obsidian Feb 24, 2021, 3:10 PM

#

utils is for useful functions used in multiple parts of the code, resources is for things like json files and the like. rules is to help with some filtering things.

#

Moderation is typically our moderation system. For things like invites and the like, we put that under filters

dry folio Feb 24, 2021, 3:10 PM

#

thorny obsidian Moderation is typically our moderation system. For things like invites and the l...

ohhhh so filters filter out all inappropriate content

thorny obsidian Feb 24, 2021, 3:10 PM

#

filters is for things our bot will check for and usually just straight up remove

green oriole Feb 24, 2021, 3:11 PM

#

or notify the mods

dry folio Feb 24, 2021, 3:11 PM

#

green oriole or notify the mods

yes, i saw that it's written by you Akarys42 lol

thorny obsidian Feb 24, 2021, 3:12 PM

#

mhm, we have filters for tokens, webhooks, spam (which uses our rules which is the other folder I mentioned earlier), and then just other filtering. So you can see that we filter for invites, blacklisted domains, too much zalgo, etc

green oriole Feb 24, 2021, 3:12 PM

#

I have probably made the last modification of this file, but not everything is written by me 😄

dry folio Feb 24, 2021, 3:13 PM

#

green oriole I have probably made the last modification of this file, but not everything is w...

ah ok lol

dry folio Feb 24, 2021, 3:13 PM

#

thorny obsidian mhm, we have filters for tokens, webhooks, spam (which uses our rules which is t...

sickkkk

#

im looking into it right now. tysm @thorny obsidian!

thorny obsidian Feb 24, 2021, 3:14 PM

#

no problem~ if you anymore questions feel free to ask here

dry folio Feb 24, 2021, 3:14 PM

#

thorny obsidian no problem~ if you anymore questions feel free to ask here

alright! :))

green oriole Feb 24, 2021, 3:16 PM

#

If you are curious about how a specific command is implemented @dry folio, you can use the !source command like this

#

!source rule

stable mountainBOT Feb 24, 2021, 3:16 PM

#

Command: site rules

Provides a link to all rules or, if specified, displays specific rule(s).

Source Code

Go to GitHub

dry folio Feb 24, 2021, 3:17 PM

#

!source pypi

stable mountainBOT Feb 24, 2021, 3:17 PM

#

Command: pypi

Provide information about a specific package from PyPI.

Source Code

Go to GitHub

dry folio Feb 24, 2021, 3:17 PM

#

green oriole If you are curious about how a specific command is implemented <@!76922160788891...

ooh, thx for the shortcut!

#

im still trying to understand the anti-spam function lol, this is my first time seeing real good code made by other devs and it's rly cool

short snow Feb 24, 2021, 5:33 PM

#

is there a way to put emojis, and webhooks into the server templates?

green oriole Feb 24, 2021, 5:33 PM

#

There is not afaik

short snow Feb 24, 2021, 5:33 PM

#

adding them seems a tedious task

green oriole Feb 24, 2021, 5:34 PM

#

I know, I know..

#

It should be more streamlined soon-ish

short snow Feb 24, 2021, 5:36 PM

#

Cool, maybe we can have a different solution for time being make a config file containing emoji name and its raw github link and adding it through code

#

similary for webhooks

gritty wind Feb 24, 2021, 5:38 PM

#

Webhooks should come included

#

at least mine did

#

emoji is only one that's mandatory

#

I don't think it warrants much effort while we wait on smart config

short snow Feb 24, 2021, 5:44 PM

#

gritty wind Webhooks should come included

Nope didn’t come

#

eternal owl Feb 24, 2021, 6:17 PM

#

do we have a fixed style on how imports should be?
example:
from discord.ext import commands => commands.command, commands.Cog

or
from discord.ext.commands import stuff

cold moon Feb 24, 2021, 6:47 PM

#

Depends how many things you have to import

eternal owl Feb 24, 2021, 6:55 PM

#

thoughts on https://github.com/python-discord/sir-lancebot/pull/596#issuecomment-785295754

GitHub

Add .pyfacts command by MrKomodoDragon · Pull Request #596 · python...

Relevant Issues
Closes #587
Description
I added a text fie with some facts and made the command send an embed with the fact.
Reasoning
The text file would be simplest to edit and change.
Screenshot...

cold moon Feb 24, 2021, 6:56 PM

#

py-gen have so high activity that nobody see this actually.

eternal owl Feb 24, 2021, 6:56 PM

#

wut is py-gen

cold moon Feb 24, 2021, 6:57 PM

#

#python-discussion

clever wraith Feb 24, 2021, 7:03 PM

#

eternal owl thoughts on https://github.com/python-discord/sir-lancebot/pull/596#issuecomment...

imo, i don't like the idea of sending a random fact to python general

#

i like the idea of appending a fact to the file though

eternal owl Feb 24, 2021, 7:05 PM

#

gotcha 👍

clever wraith Feb 24, 2021, 7:05 PM

#

how do I append a line to the file again?

eternal owl Feb 24, 2021, 7:07 PM

#

you can open the text file in append mod

#

mode*

#

with open("...", "a") as f:

clever wraith Feb 24, 2021, 7:27 PM

#

riiight

vale ibex Feb 24, 2021, 7:53 PM

#

Would it be worth using aiofiles here, if we're doing file io in a command

cold moon Feb 24, 2021, 8:10 PM

#

@eternal owl @clever wraith This is not possible anymore, because file persisting was removed with migration to Kubernetes.

green oriole Feb 24, 2021, 8:11 PM

#

we have redis though!

cold moon Feb 24, 2021, 8:12 PM

#

Yes, but using files isn't option anymore

patent pivot Feb 24, 2021, 8:12 PM

#

we try avoid it for persistence

vale ibex Feb 24, 2021, 8:12 PM

#

Is redis persistent?

patent pivot Feb 24, 2021, 8:12 PM

#

just abouts

#

but would much rather use it as a cache

vale ibex Feb 24, 2021, 8:12 PM

#

Yea, that's safer

green oriole Feb 24, 2021, 8:13 PM

#

I mean, we do consider it as more or less persistent now

vale ibex Feb 24, 2021, 8:13 PM

#

What do we use to persist otn?

green oriole Feb 24, 2021, 8:13 PM

#

It is Lance anyway

patent pivot Feb 24, 2021, 8:13 PM

#

vale ibex What do we use to persist otn?

database

green oriole Feb 24, 2021, 8:13 PM

#

vale ibex What do we use to persist otn?

the database

patent pivot Feb 24, 2021, 8:13 PM

#

postgres

green oriole Feb 24, 2021, 8:13 PM

#

meh, joe is faster

vale ibex Feb 24, 2021, 8:13 PM

#

Ahh yea the Web is a thing

#

Having a discussion and manually updating is probably good enough for now

cold moon Feb 24, 2021, 8:14 PM

#

~~This is so sad that we can't have DB in lancebot~~

patent pivot Feb 24, 2021, 8:15 PM

#

I think not having a DB is a primary goal of the project

#

lancebot is our project to inspire open source contribution

#

I think that having a simple setup process with no other moving components is the goal

#

and that's why we make redis optional and stuff

green oriole Feb 24, 2021, 8:16 PM

#

Honestly, will we ever loose the redis cache

patent pivot Feb 24, 2021, 8:16 PM

#

¯_(ツ)_/¯

green oriole Feb 24, 2021, 8:16 PM

#

At worse we have the backup

patent pivot Feb 24, 2021, 8:17 PM

#

yeah

cold moon Feb 24, 2021, 8:17 PM

#

But you can't have tables in Redis

patent pivot Feb 24, 2021, 8:17 PM

#

sure

#

but that's just a limitation we deal with

#

because that's a better downside than having contributors having to set up a whole database or docker

cold moon Feb 24, 2021, 8:19 PM

#

If we could get Redis hash tables then this would partially give something like table

green oriole Feb 24, 2021, 8:19 PM

#

cold moon But you can't have tables in Redis

It isn't bad honestly, you can work around that

patent pivot Feb 24, 2021, 8:19 PM

#

seasonalbot being KV at core is very simple for new contributors

#

and async-rediscache makes it super easy to add pseudo-persistence

green oriole Feb 24, 2021, 8:20 PM

#

Don't we already have hash maps with async-rediscache?

cold moon Feb 24, 2021, 8:21 PM

#

But each namespace is hash table

patent pivot Feb 24, 2021, 8:21 PM

#

internally yeah async-rediscache uses hashsets

#

yeah

clever wraith Feb 24, 2021, 8:21 PM

#

cold moon <@!263560579770220554> <@456226577798135808> This is not possible anymore, becau...

oh :/

short snow Feb 24, 2021, 11:13 PM

#

can i have the trash can emote?

patent pivot Feb 24, 2021, 11:13 PM

#

trashcan

short snow Feb 24, 2021, 11:16 PM

#

Ty

#

Failmail and defcon ones too please

patent pivot Feb 24, 2021, 11:22 PM

#

failmail defcondisabled defconedit defconenabled

#

heading off now but if you need any others just drop me a DM

brazen charm Feb 24, 2021, 11:23 PM

#

Can just replace them with ordinary emojis if it's for your test server, not like they come up much

short snow Feb 24, 2021, 11:25 PM

#

Currently i do that, but sometimes it is needed for the look, how does it look? And maybe u need that emoji while writing some code, so i just thought of adding them all

#

No need of adding style.icons right?

#

And to use eval we would need to host it right?

#

And how do we see if a issue is approved to work on or not in bot

brazen charm Feb 24, 2021, 11:50 PM

#

Yes, you need to host snekbox to use the public eval. I believe it is included in the bot's compose

patent pivot Feb 24, 2021, 11:51 PM

#

Which issue are you interested in?

short snow Feb 24, 2021, 11:54 PM

#

patent pivot Which issue are you interested in?

Am just going thro the code of bot rn, will let u know soon

brazen charm Feb 24, 2021, 11:54 PM

#

Issues that don't have the planned tag should be ready afaik, but it'll always be clear after you ask to be assigned

short snow Feb 24, 2021, 11:55 PM

#

Alright

#

What is BOT_API_KEY? And https://github.com/python-discord/bot/blob/d71ac9f6e240ffd2d4195d9dbbf5740a0c2413a1/docker-compose.yml#L43 needs to be replaced right? So why doesn’t it be taken from .env?

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

brazen charm Feb 25, 2021, 12:01 AM

#

BOT_API_KEY is what the bot uses to authenticate with the site's api

short snow Feb 25, 2021, 12:02 AM

#

And how do we get that?

brazen charm Feb 25, 2021, 12:04 AM

#

The development key is the badbot one

fallen patrol Feb 25, 2021, 12:50 AM

#

brazen charm The development key is the badbot one

So there's a development site for people to use when making development environments for @Python?

#

Or you gotta host the site as well.

brazen charm Feb 25, 2021, 12:53 AM

#

You host everything yourself

fallen patrol Feb 25, 2021, 12:56 AM

#

Ah okay

short snow Feb 25, 2021, 1:50 AM

#

which voice gate channel?

#

#voice-verification?

short snow Feb 25, 2021, 2:35 AM

#

I did docker-compose up -d but the bot isn't online

#

all the images are build

#

#

Logs have no errrors

#

lemme see if the site is up

#

site is up

#

hmm, everything except the bot is up

#

the token is correct

#

what else can be the problem? lemon_thinking

obsidian patio Feb 25, 2021, 2:57 AM

#

Try starting the bot container now that everything else is up, if it's not already running. I personally have an issue where bot starts before site is running, so bot can't quite start

short snow Feb 25, 2021, 3:03 AM

#

obsidian patio Try starting the bot container now that everything else is up, if it's not alrea...

docker-compose up --no-deps bot ?

obsidian patio Feb 25, 2021, 3:03 AM

#

I've done it using the ui

short snow Feb 25, 2021, 3:04 AM

#

ubuntu has no docker ui 😦

obsidian patio Feb 25, 2021, 3:05 AM

#

Hmm, I don't know how it'd be done with the CL. Just try to run the container if it's not already running, assuming that the other containers are running already

short snow Feb 25, 2021, 3:06 AM

#

alright

#

on docker-compose up --no-deps bot

obsidian patio Feb 25, 2021, 3:10 AM

#

Not sure what's happening

#

Hopefully someone else knows

brazen charm Feb 25, 2021, 3:12 AM

#

I believe you'll need to change the hosts in your config

#

"redis.default.svc.cluster.local" into "redis" etc.

short snow Feb 25, 2021, 3:27 AM

#

brazen charm "redis.default.svc.cluster.local" into "redis" etc.

lemme try that

#

done done odne 🎉

#

ty

short snow Feb 25, 2021, 3:53 AM

#

here this works and sends a webhook

#

butt

#

here it doesn;t

#

same id being used

#

am just messing around to check whether the setup is correct

#

--

and i get this:

According to the API, your request is malformed.
after every !clean

short snow Feb 25, 2021, 4:07 AM

#

short snow -- and i get this: > According to the API, your request is malformed. after eve...

fixd , had to put my server id in config.yml

short snow Feb 25, 2021, 4:09 AM

#

short snow here this works and sends a webhook

even this got fixed 😄

#

the onl problem, i found with !ping command

#

running the bot like this: docker-compose up -d bot

gritty wind Feb 25, 2021, 4:24 AM

#

Yeah there’s an issue to fix ping on local deploys

#

It’s very broken

sullen phoenix Feb 25, 2021, 4:32 AM

#

yeah, the ping command won’t work locally

short snow Feb 25, 2021, 4:37 AM

#

whats the issue, i can try to fix it

gritty wind Feb 25, 2021, 4:37 AM

#

It isn't approved

#

The fix is ready

#

but

#

I actually don't remember why it isn't approved

#

bot#1407

dusky shoreBOT Feb 25, 2021, 4:38 AM

#

GitHub

IssueOpen [bot] #1407 Ping Command Bugs

gritty wind Feb 25, 2021, 4:38 AM

#

Or maybe not? Akarys quietly removed the planning tag

patent pivot Feb 25, 2021, 4:53 AM

#

https://github.com/python-discord/site/pull/443 feel free to review, ~~soothe me from my devops headache ~~

GitHub

Apply LimitOffsetPagination in GET Infraction with default Page Siz...

Add Default Pagination class LimitOffsetPagination with Page Size 100 in GET Infraction

trim cradle Feb 25, 2021, 5:08 AM

#

@gritty wind I did this in my current deployment but it's not working again 🤷🏻‍♂️

gritty wind Feb 25, 2021, 5:09 AM

#

o no

trim cradle Feb 25, 2021, 5:09 AM

#

did something change about the website?

gritty wind Feb 25, 2021, 5:09 AM

#

what's the error

#

shouldn't have

short snow Feb 25, 2021, 5:10 AM

#

even the site api would change to api.web:8000 if that's what u mean

trim cradle Feb 25, 2021, 5:10 AM

#

gritty wind what's the error

I copied everything for good measure but the problem is presumably at the end https://paste.pythondiscord.com/uyuzaqusay.properties

short snow Feb 25, 2021, 5:10 AM

#

@eternal owl Done 🎉 , mentioned the required changes in improve wikipedia pr

gritty wind Feb 25, 2021, 5:11 AM

#

I c

#

try docker-compose up -d web

#

then docker-compose up -d in a few seconds

#

also what's in your redis setings

short snow Feb 25, 2021, 5:12 AM

#

trying to set up bot?

trim cradle Feb 25, 2021, 5:13 AM

#

gritty wind also what's in your redis setings

lines 6 to 10 are exactly

    redis:
        host:  "localhost"
        port:  6379
        password: null
        use_fakeredis: true

gritty wind Feb 25, 2021, 5:14 AM

#

well it shouldn't matter then

#

should just be the other thing

trim cradle Feb 25, 2021, 5:25 AM

#

@gritty wind I don't understand why it be like it is

#

namely why I need the -d

gritty wind Feb 25, 2021, 5:28 AM

#

The d is just so it doesn't lock you in the console

#

You can omit it if you want

#

more importantly you need to start the site before the bot

#

Because @patent pivot didn't add readiness checks >.>

short snow Feb 25, 2021, 5:55 AM

#

this is what i did:

docker-compose up -d # Will get the site, redis and eval running
docker-compose up -d bot # Will re run the bot, since bot starts before site is running, so bot can't quite start in the first command

And

I believe you'll need to change the hosts in your config
"redis.default.svc.cluster.local" into "redis" etc.

gritty wind Feb 25, 2021, 5:58 AM

#

He's already using fake redis, so that won't affect it

#

it's just the startup readiness here

short snow Feb 25, 2021, 6:00 AM

#

ah ok

patent pivot Feb 25, 2021, 7:04 AM

#

gritty wind Because <@!165023948638126080> didn't add readiness checks >.>

how do you do it lol

short snow Feb 25, 2021, 7:05 AM

#

hmm, i tried it once again but the bot doesn't come online

#

run docker-compose up -d and docker-compose up --no-deps bot --> Cannot connect to api.web:8000

#

run docker-compose up -d and docker-compose up -d bot -->

bot_redis_1 is up-to-date
bot_postgres_1 is up-to-date
bot_snekbox_1 is up-to-date
bot_web_1 is up-to-date
Starting bot_bot_1 ... done
``` But doesn't come online

#

hmm, seems like i need to do this:

#

- docker-compose up -d bot
- docker-compose up --no-deps bot

#

and i don't get a startup message in #dev-log

#

(my dev log)

gritty wind Feb 25, 2021, 7:09 AM

#

gritty wind try `docker-compose up -d web`

try this

short snow Feb 25, 2021, 7:10 AM

#

alright

#

without any commands before that?

#

jason@devlab:~/PycharmProjects/bot$ docker-compose up -d web
bot_postgres_1 is up-to-date
bot_web_1 is up-to-date

#

lemme stop them and do it again

#

Ok, nothing seems to work now, even the earlier thing

#

aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.web:8000 ssl:default [None]
``` on doing `docker-compose up --no-deps bot`

hardy gorge Feb 25, 2021, 7:46 AM

#

what's the schema set to?

short snow Feb 25, 2021, 7:48 AM

#

hardy gorge what's the schema set to?

    # PyDis site vars
    site:        &DOMAIN       "web:8000"
    site_api:    &API          "api.web:8000"
    site_api_schema:           "http://"
    site_paste:  &PASTE  !JOIN ["paste.", *DOMAIN]
    site_schema: &SCHEMA       "https://"
    site_staff:  &STAFF  !JOIN ["staff.", *DOMAIN]

#

should i shift it to http

#

for site_schema

hardy gorge Feb 25, 2021, 7:49 AM

#

yes

#

That's causing the SSL errors

#

There's no certificate or TLS route exposed locally

#

although

#

I wonder why it's using site_schema at all

#

However, it does mention SSL (the error)

#

So it's worth a shot

short snow Feb 25, 2021, 7:50 AM

#

aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.web:8000 ssl:default [Connect call failed ('172.22.0.5', 8000)]

#

same

vocal wolf Feb 25, 2021, 7:50 AM

#

@cosmic moat great job so far, do you think you think you can finish this off?

https://github.com/python-discord/sir-lancebot/pull/586

hardy gorge Feb 25, 2021, 7:50 AM

#

@short snow Alright, change the site_schema back in that case

#

It supposed to be for the outside world website, I think

short snow Feb 25, 2021, 7:52 AM

#

hardy gorge <@!736234578745884682> Alright, change the site_schema back in that case

uhh, it worked now

#

i changed it back to https

#

and ran docker-compose up --no-deps bot

#

and tada

hardy gorge Feb 25, 2021, 7:53 AM

#

Alright, that's a bit odd.

short snow Feb 25, 2021, 7:53 AM

#

yeah, i don't understand whats going on

#

i changed nothing else

hardy gorge Feb 25, 2021, 7:53 AM

#

The local schema for the API you're connecting to internally should be http, since there's no TLS/SSL locally

short snow Feb 25, 2021, 7:54 AM

#

should i show the web part of my config, rn? the one which is working rn?

#

fails on eval

hardy gorge Feb 25, 2021, 8:01 AM

#

that's a weird configuration

#

It looks like it's looking for a kubernetes cluster address

#

Are you running snekbox locally?

obsidian patio Feb 25, 2021, 8:08 AM

#

I believe mine did that as well, before I changed something in the config file

hardy gorge Feb 25, 2021, 8:09 AM

#

I don't think you get snekbox by default with our docker-compose, but I haven't actually checked it in a while

#

Which just means the eval command doesn't work, as you can't use the remote one

timid sentinel Feb 25, 2021, 8:13 AM

#

You need to change the snekbox API URL in the config. I think http://snekbox:8060 works if you're using docker

green oriole Feb 25, 2021, 8:15 AM

#

It is http://snekbox:8060/eval

timid sentinel Feb 25, 2021, 8:15 AM

#

Ah yes

green oriole Feb 25, 2021, 8:15 AM

#

You do get it by default in the compose setup

short snow Feb 25, 2021, 9:03 AM

#

hardy gorge Are you running snekbox locally?

yeah doing docker-compose up -d, gets the snekboxbuild from github

short snow Feb 25, 2021, 9:03 AM

#

green oriole It is `http://snekbox:8060/eval`

lemme see

#

ty everything works now

#

i will go through the code and then start contributing to bot too

vocal wolf Feb 25, 2021, 9:25 AM

#

https://github.com/python-discord/bot/pull/1028 needs reviewing

subtle kraken Feb 25, 2021, 10:13 AM

#

Hi am reviewing your PR (bot#1392)
how are we skipping fuzzysearch with changing it to True?
At best we skip command suggestion which uses difflib and not fuzzy
Can you explain it to me?

dusky shoreBOT Feb 25, 2021, 10:13 AM

#

GitHub

PROpen [bot] #1392 Don't fuzzy search for tags when tag is on cooldown

short snow Feb 25, 2021, 10:15 AM

#

i can take over the left behind prs if u want to

#

on sir lance and bot.

#

you ppl seem to be on 🔥

green oriole Feb 25, 2021, 10:16 AM

#

@vocal wolf ^

short snow Feb 25, 2021, 10:16 AM

#

ak, xith and senjan

vocal wolf Feb 25, 2021, 10:16 AM

#

lol

#

thanks

short snow Feb 25, 2021, 10:16 AM

#

u missed part 1 of the ping

subtle kraken Feb 25, 2021, 10:18 AM

#

yeah am reviewing stuff because more than 20prs and it gets terrifying

#

am trying to close as many new PRs as possible so we can focus on old ones, which am also looking into reviewing

short snow Feb 25, 2021, 10:24 AM

#

short snow i can take over the left behind prs if u want to

@vocal wolf lemon_thinking

vocal wolf Feb 25, 2021, 10:25 AM

#

short snow i can take over the left behind prs if u want to

list them and I'll see

short snow Feb 25, 2021, 10:29 AM

#

vocal wolf list them and I'll see

#

(sir-lance)

vocal wolf Feb 25, 2021, 10:30 AM

#

I'll go over all the PRs in sir-lance and label them accordingly

#

you can start on those

short snow Feb 25, 2021, 10:31 AM

#

vocal wolf you can start on those

alright thanks.

vocal wolf Feb 25, 2021, 10:34 AM

#

short snow alright thanks.

but don't do like, all of them

#

in fact, let me take an even closer look

short snow Feb 25, 2021, 10:35 AM

#

alright let me know which can be taken

#

and sir-lancebot#600 needs another approve, iceman gave first one

dusky shoreBOT Feb 25, 2021, 10:35 AM

#

GitHub

PROpen [sir-lancebot] #600 Improve Wikipedia Command

green oriole Feb 25, 2021, 10:36 AM

#

@subtle kraken I heard you want to increase your streak pithink

subtle kraken Feb 25, 2021, 10:36 AM

#

who told you that

#

and what do you want

green oriole Feb 25, 2021, 10:38 AM

#

dusky shore

This PR needs reviewing

subtle kraken Feb 25, 2021, 10:42 AM

#

Do I look like I review sir-lancebot smh

subtle kraken Feb 25, 2021, 10:43 AM

#

green oriole This PR needs reviewing

I'll put it in my asyncio.Queue

green oriole Feb 25, 2021, 10:43 AM

#

haha

vale ibex Feb 25, 2021, 11:08 AM

#

subtle kraken Hi am reviewing your PR (bot#1392) how are we skipping fuzzysearch with changing...

https://github.com/python-discord/bot/blob/ced0af2b2936b1fab4f5601bd7b1c00bbbd9130a/bot/exts/backend/error_handler.py#L169

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

#

This invoke see's if the given command is a tag by trying to invoke it

#

Currently if the tag is on cooldown, that function returns False, which makes this check think it doesn't exist

#

There were two options that I saw implement a 3 state system of exists, exists but on cd and not exists. or return true even if its on cd

#

since the return of that specific function I changed isn't used anywhere else, changing it to True there means anything that calls invoke gets told it exists, but the tag still doesn't run as its on cd

subtle kraken Feb 25, 2021, 11:14 AM

#

@vale ibex yeah but I don't see that point to fuzzy search at any point in either case of return

#

so its just more of a misnaming of PR?

#

it looks good otherwise

vale ibex Feb 25, 2021, 11:15 AM

#

So if the invoke returns false, the error handler thinks it isn't a tag, so carries on and tries to fuzzy search

#

But since the invoke returns true, the error handler sees that its a tag and doesn't do anything

#

but within the invoke it still doesn't run the tag, since its on cd

#

Currently if a tag is on cd, and a user tries to run the tag as a command, this error handler will be hit, try to invoke the tag, the invoke will return False (since its on cd) so the error handler will think its not a tag and try to fuzzy search

#

By making the invoke return True even if its on cd, this error handler sees that its a tag so doesn't do the fuzzy search

#

or am I missing the point of your question? 😛

subtle kraken Feb 25, 2021, 11:19 AM

#

am not quite seeing that being False go into any sort of fuzzy search

#

if it's False it will just go and invoke send_command_suggestion

vale ibex Feb 25, 2021, 11:19 AM

#

yea, which is the fuzzy search for a command

#

or at least that's what I've heard it be called

subtle kraken Feb 25, 2021, 11:20 AM

#

difflib uses fuzzy search?

#

but yeah okay

#

sounds good either way

vale ibex Feb 25, 2021, 11:20 AM

#

Alright, might be my misunderstanding of it then, I've just heard it be called fuzzy search 😛

subtle kraken Feb 25, 2021, 11:20 AM

#

maybe it was fuzzy search before

#

if similar_command_data := difflib.get_close_matches(command_name, raw_commands, 1): is what searches for commands at the moment

#

well either way I can approve it, looks good

vale ibex Feb 25, 2021, 11:21 AM

#

👍

balmy sparrow Feb 25, 2021, 11:22 AM

#

sorry to butt in, is this somehow related to bot#1400 ?

dusky shoreBOT Feb 25, 2021, 11:22 AM

#

GitHub

PRMerged [bot] #1400 Make defaultdict tag

balmy sparrow Feb 25, 2021, 11:22 AM

#

No wait

#

I meant 1432, it's an issue with the "did you mean..." Embed catching any extra words

#

https://github.com/python-discord/bot/issues/1432

GitHub

Faulty tag suggestions · Issue #1432 · python-discord/bot

On making a typo with a tag, any additional text that was sent along with it is also sent in the "Did you mean..." embed. The fuzzy matching also seems a bit odd here, with pste b...

subtle kraken Feb 25, 2021, 11:24 AM

#

not quite

balmy sparrow Feb 25, 2021, 11:24 AM

#

I saw some cases where it could lead to quite large embeds

subtle kraken Feb 25, 2021, 11:24 AM

#

that PR I talk of simply means suggestion won't be sent on cooldown

balmy sparrow Feb 25, 2021, 11:24 AM

#

Ah right NVM then, thought the fuzzy matching would be related

#

how are tags to issues assigned?

#

Am I supposed to set them as I make an issue, or will some staff member do it?

gritty wind Feb 25, 2021, 11:25 AM

#

Submit a proposal on the tag discussions, get it approved, then you'll be assigned to an issue

balmy sparrow Feb 25, 2021, 11:25 AM

#

I think I'm not using the right lingo here

#

I'm talking of those little color bubbles with stuff like "status: planning"

subtle kraken Feb 25, 2021, 11:26 AM

#

core devs assign those

#

those are called labels

balmy sparrow Feb 25, 2021, 11:26 AM

#

Ah right 👍

wind socket Feb 25, 2021, 12:44 PM

#

might want to look into this

#

only saw this behaviour in #discord-bots , remember seeing the old embed in help channels

green oriole Feb 25, 2021, 12:46 PM

#

There is a fix incoming for that :)

cosmic moat Feb 25, 2021, 1:21 PM

#

vocal wolf <@!523662958916665361> great job so far, do you think you think you can finish t...

sure, i'll have time tomorrow afternoon

subtle kraken Feb 25, 2021, 4:18 PM

#

balmy sparrow https://github.com/python-discord/bot/issues/1432

commented on your issue btw

mossy wolf Feb 25, 2021, 4:19 PM

#

@vocal wolf on my PR for the empty-json tag. Sorry I was under the impression I already merged the requested changes from the review. I guess I forgot those. They are merged now. Will wait for a review
bot#1393

dusky shoreBOT Feb 25, 2021, 4:19 PM

#

GitHub

PROpen [bot] #1393 Made a tag to help people fix an empty file JSON error.

clever wraith Feb 25, 2021, 4:52 PM

#

wind socket might want to look into this

fuzzy wuzzy is weird sometimes

stable mountainBOT Feb 25, 2021, 6:58 PM

#

@vocal wolf @thorny obsidian

It has arrived!

Here's your reminder: Meet for thing.
[Jump back to when you created the reminder](#dev-contrib message)

vocal wolf Feb 25, 2021, 6:59 PM

#

mmmmmmmmmm

thorny obsidian Feb 25, 2021, 6:59 PM

#

postpone?

vocal wolf Feb 25, 2021, 6:59 PM

#

ye

#

I'm busy being sad lol

thorny obsidian Feb 25, 2021, 6:59 PM

#

no problem~ ping me when you are less sad, also do something else to distract yourself!!!

green oriole Feb 25, 2021, 7:24 PM

#

like sleeping

fallen patrol Feb 25, 2021, 8:23 PM

#

vocal wolf I'm busy being sad lol

vocal wolf Feb 26, 2021, 12:03 AM

#

@thorny obsidian I have recovered. Shall we meet sometime today?

thorny obsidian Feb 26, 2021, 12:03 AM

#

yeah! I have a meeting in 90 minutes, but can chat anytime before then

vocal wolf Feb 26, 2021, 12:03 AM

#

Noice

#

Lol it's hard to think on 3 hours of sleep

#

Unnecessary sadness

thorny obsidian Feb 26, 2021, 12:04 AM

#

You feeling any better?

vocal wolf Feb 26, 2021, 12:04 AM

#

Oh yeah

#

I just slept for like 6 hours, that's some good shit right there

thorny obsidian Feb 26, 2021, 12:05 AM

#

whoo! Don't make me bully you into letting me mail you cookies hyperlemon

vocal wolf Feb 26, 2021, 12:05 AM

#

Lol

#

Am on phone, will move to desktop.

thorny obsidian Feb 26, 2021, 12:21 AM

#

@patent pivot do you wanna chat about the .topic command?

patent pivot Feb 26, 2021, 12:21 AM

#

💤

vocal wolf Feb 26, 2021, 12:21 AM

#

@patent pivot

#

Have a good sleep

patent pivot Feb 26, 2021, 12:21 AM

#

vocal wolf Feb 26, 2021, 12:21 AM

#

my internet isn't being healthy

thorny obsidian Feb 26, 2021, 12:30 AM

#

.topic

dusky shoreBOT Feb 26, 2021, 12:30 AM

#

**What is the title of the last book you read?**

Suggest more topics here!

eternal owl Feb 26, 2021, 1:30 AM

#

What are you guys talking about

vocal wolf Feb 26, 2021, 1:30 AM

#

eternal owl What are you guys talking about

updating topics

eternal owl Feb 26, 2021, 1:30 AM

#

Ohk

vocal wolf Feb 26, 2021, 1:58 AM

#

@thorny obsidian topics have been pushed.

fallen patrol Feb 26, 2021, 1:58 AM

#

vocal wolf updating topics

nice, I see a majority of my suggestions in that commit lol

vocal wolf Feb 26, 2021, 1:58 AM

#

https://github.com/python-discord/sir-lancebot/pull/603

#

PR created, needs review.

vocal wolf Feb 26, 2021, 1:58 AM

#

fallen patrol nice, I see a majority of my suggestions in that commit lol

:)

vocal wolf Feb 26, 2021, 2:10 AM

#

vocal wolf <https://github.com/python-discord/sir-lancebot/pull/603>

pls review :)

thorny obsidian Feb 26, 2021, 2:36 AM

#

@vocal wolf Thanks for doing all the work and just letting me chat about random things~~

vocal wolf Feb 26, 2021, 2:36 AM

#

lol np

#

was fun

#

@mossy wolf https://github.com/python-discord/bot/pull/1393 merged.

clever wraith Feb 26, 2021, 5:32 AM

#

ok

mossy wolf Feb 26, 2021, 9:10 AM

#

vocal wolf <@!234649992357347328> <https://github.com/python-discord/bot/pull/1393> merged.

Thanks. It was fun contributing to the bot. How long does it take on average for an update to be pushed?

vocal wolf Feb 26, 2021, 9:10 AM

#

It really depends

#

Some PRs are absolutely massive and take months to get merged

#

others are small and can take as little as 5 minutes

#

So given the size of the tag in this case, I'd say usually a day or two, maybe up to 5 days?

#

Not too sure though

mossy wolf Feb 26, 2021, 9:12 AM

#

Fair enough. I’ll wait and see when we get the #changelog message

vocal wolf Feb 26, 2021, 9:12 AM

#

oh yeah I can post that

brazen charm Feb 26, 2021, 9:12 AM

#

The bot redeploys almost immediately after a pr is merged if everything went correctly if you were asking about that

vocal wolf Feb 26, 2021, 9:14 AM

#

!empty-json

stable mountainBOT Feb 26, 2021, 9:14 AM

#

When using JSON, you might run into the following error:

JSONDecodeError: Expecting value: line 1 column 1 (char 0)

This error could have appeared because you just created the JSON file and there is nothing in it at the moment.

Whilst having empty data is no problem, the file itself may never be completely empty.

You most likely wanted to structure your JSON as a dictionary. To do this, edit your empty JSON file so that it instead contains {}.

Different data types are also supported. If you wish to read more on these, please refer to this article.

mossy wolf Feb 26, 2021, 9:16 AM

#

brazen charm The bot redeploys almost immediately after a pr is merged if everything went cor...

Right. Yeah I was wondering about that. Fair enough

short snow Feb 26, 2021, 9:20 AM

#

we need one for connect 4 too ig

short snow Feb 26, 2021, 10:35 AM

#

@gritty wind https://github.com/python-discord/sir-lancebot/issues/602#issuecomment-785991958 I got a question on the issue you opened about WTF Python

GitHub

Add Subsection Command for WTFPython · Issue #602 · python-discord/...

While discussing python-discord/meta#63, a suggestion that came up was to add a command to get a direct link to subsections of the python gotchas list. This can be used to quickly direct people tow...

gritty wind Feb 26, 2021, 10:35 AM

#

hello

#

sure, I don't see why not

short snow Feb 26, 2021, 10:36 AM

#

alright, so if the message it long, i will just paginate it, cool thanks for the quick response

gritty wind Feb 26, 2021, 10:37 AM

#

just paginate everything

#

if it fits in one page, the paginator should already handle that

short snow Feb 26, 2021, 10:38 AM

#

yeah, the paginator would manage that

short snow Feb 26, 2021, 12:42 PM

#

so api is separate from site now?

gritty wind Feb 26, 2021, 12:42 PM

#

that is under active development

cold island Feb 26, 2021, 12:49 PM

#

@gritty wind does my answer in the PR make sense? not sure if that's what you meant

gritty wind Feb 26, 2021, 12:49 PM

#

So what I'm thinking is

#

If it isn't an actual error

#

It shouldn't be printed and treated as such

#

It'll make it to sentry, and it will error out on local dev

#

Especially with fakeredis which does not maintain state across restarts

cold island Feb 26, 2021, 12:52 PM

#

the exception print is actually a request from Akarys https://github.com/python-discord/bot/pull/1262#discussion_r577765331

#

Keep in mind also that the try-except is suppressing any errors, so it's not gonna make it to sentry

gritty wind Feb 26, 2021, 12:54 PM

#

I don't necessarily agree with that sentiment that errors in it should be relayed to sentry. Imo, exceptions should only be raised when you have an unpredictable, or uncatchable error.

short snow Feb 26, 2021, 12:54 PM

#

which framework is being used for the api?

gritty wind Feb 26, 2021, 12:55 PM

#

That info will be available once the repo is made public

gritty wind Feb 26, 2021, 12:55 PM

#

cold island Keep in mind also that the try-except is suppressing any errors, so it's not gon...

Ah okay

#

In that case, I don't see what we're talking about

#

It's just the difference between a try-except and if-else

cold island Feb 26, 2021, 12:56 PM

#

Well, it's an unpredictable behavior that we need to address at that moment

#

So it pings mods because they need to see if the settings should be changed, and devops so they know there's an issue

gritty wind Feb 26, 2021, 12:57 PM

#

Yeah that's what I'm hoping it would do

#

I just don't see the value in a sentry error

#

But if that's not in the question

#

Then I'm good with it

cold island Feb 26, 2021, 12:57 PM

#

There won't be a sentry error

#

It will just print out the traceback

gritty wind Feb 26, 2021, 12:57 PM

#

Hmm that I'm unsure of

#

Primarily because it will be confusing on local development

#

And I don't see what a KeyError traceback will provide over a customized message

#

or no message at all, and a discord warn

cold island Feb 26, 2021, 12:58 PM

#

by printing I mean to Discord

gritty wind Feb 26, 2021, 12:58 PM

#

Ah lol

cold island Feb 26, 2021, 12:58 PM

#

to the channel

gritty wind Feb 26, 2021, 12:59 PM

#

In that case, don't mind me

short snow Feb 26, 2021, 1:06 PM

#

Ahh, am not sure if stackoverflow thing is needed, since if a cheatsheet query is not available to them, the send back the result of a stackoverflow search

#

https://github.com/chubin/cheat.sh

#

If there is no cheat sheet for a programming language query (and it is almost always the case), it is generated on the fly, based on available cheat sheets and answers on StackOverflow. Of course, there is no guarantee that the returned cheat sheet will be a 100% hit, but it is almost always exactly what you are looking for.

short snow Feb 26, 2021, 2:01 PM

#

Bot errors out on

!e

from random import random
while True: print(chr(round(9585 + random())), end='')

#

in #bot-commands

gritty wind Feb 26, 2021, 2:01 PM

#

I think it's currently having a bit of a problem with infinite loops

#

@patent pivot ^

patent pivot Feb 26, 2021, 2:02 PM

#

yeah we're working on a fix internally

#

!e ```py
from random import random
while True: print(chr(round(9585 + random())), end='')

stable mountainBOT Feb 26, 2021, 2:02 PM

#

Sorry, an unexpected error occurred. Please let us know!

ClientResponseError: 500, message='Internal Server Error', url=URL('http://snekbox.default.svc.cluster.local/eval')

patent pivot Feb 26, 2021, 2:02 PM

#

yeah that's the one

#

will hopefully have something together by the end of the weekend, if not earlier

short snow Feb 26, 2021, 2:06 PM

#

Hmm, I dunno but another bot with snekbox woks with this using lxc containers, it keeps it simple and doesn't coomplicate it our current implementation is. Run on a linux server

#

uses nodejs now, but can be done with python too

#

and using lxc containers, it implements half security for us

gritty wind Feb 26, 2021, 2:08 PM

#

I don't think this will help in this case

#

But more details once we actually fully debug it and fix it

short snow Feb 26, 2021, 2:09 PM

#

yeah, but it is about simplifying the current one, maybe if i get time, i can share a detailed implementation of it.

gritty wind Feb 26, 2021, 2:10 PM

#

I guess if this is a general thing, you'd want to talk to @tawdry vapor about it too

short snow Feb 26, 2021, 2:12 PM

#

(I am not sure about how it is implemented currently, just basic information ik, so I could be wrong)

fallen patrol Feb 26, 2021, 2:20 PM

#

patent pivot !e ```py from random import random while True: print(chr(round(9585 + random()))...

wouldn't it run out of memory or run out of time by that point?

patent pivot Feb 26, 2021, 2:20 PM

#

so

#

yeah

#

it runs out of memory

#

okay so

#

hm let me try describe how this all works

fallen patrol Feb 26, 2021, 2:21 PM

#

but shouldn't there be a limit on the memory usable by the process?

patent pivot Feb 26, 2021, 2:21 PM

#

no yeah that is the limit that is being hit

#

this isn't an escape that is causing us to run out of memory or anything

#

when you start an eval on snekbox, the server actually creates two cgroups (which are there to limit resource usage)

#

we create one, nsjail then creates one inside that

#

once we are done, we delete the one we created

#

the issue is you can only delete a cgroup if there is nothing inside it

#

when nsjail exits normally it cleans up the cgroup it created, it does not do that if it exited due to a memory error or other cgroup limit hit

#

so basically we are trying to delete a cgroup which is "busy" because it has a child cgroup that had a process that got killed

#

there is no security compromise, it's just that nsjail isn't clearing something up which we need it to clear up in order to run our clear up tasks

fallen patrol Feb 26, 2021, 2:23 PM

#

ah

patent pivot Feb 26, 2021, 2:23 PM

#

by the time the error above has hit the actual python execution has long finished and we are in the stages of cleaning up and sending the data back to @stable mountain

fallen patrol Feb 26, 2021, 2:23 PM

#

ok

short snow Feb 26, 2021, 2:23 PM

#

ah thanks, i Think using lxc would be much simpler than this, i will talk to Mark about this.

patent pivot Feb 26, 2021, 2:23 PM

#

lxc will not work for us in terms of devops

#

we don't want to set up a whole new container runtime, it works well enough in docker with the security policies in place

short snow Feb 26, 2021, 2:25 PM

#

hmmm, alright i will think about it, but still think if lxc is worth it, i will talk to mark about it

#

how do u ppl delete codejam teams?

#

and this should be caught, no two team names and one person should be in one team only

gritty wind Feb 26, 2021, 2:35 PM

#

We don't really use this frequently enough for it to be a big deal

patent pivot Feb 26, 2021, 2:35 PM

#

yeah

gritty wind Feb 26, 2021, 2:35 PM

#

but open an issue for it

short snow Feb 26, 2021, 2:38 PM

#

for both of them?

hardy gorge Feb 26, 2021, 2:43 PM

#

I don't know if it's worth adding the functionality

#

I'm not quite sure what the exact setup will be for the next code jam

#

The current command has served us fine so far, but I'm not sure we'll be using it again in the future

hardy gorge Feb 26, 2021, 2:45 PM

#

short snow ah thanks, i Think using lxc would be much simpler than this, i will talk to Mar...

I'm intrigued, why do you think a different container type would be better for us?

ember cloud Feb 26, 2021, 2:47 PM

#

I don't know if this is the right channel to ask this but what would cause a Something went wrong. error when pasting in paste.pydis.com?

#

I keep getting that

hardy gorge Feb 26, 2021, 2:50 PM

#

That's odd. I'm not getting anything like that. When do you see that error?

ember cloud Feb 26, 2021, 2:55 PM

#

when I try to paste my code

#

it works when I write a small string like abcd

#

but not for my code

patent pivot Feb 26, 2021, 2:55 PM

#

hmmmmmm

#

one sec

#

can you DM me your code

ember cloud Feb 26, 2021, 2:55 PM

#

Yes

#

#

here's how my screen looks like

thorny obsidian Feb 26, 2021, 2:58 PM

#

I'm not sure we'll be using the code jam set-up code exactly as it is currently. There are a lot of lessons learned for how we'll run it and there are definitely aspects we're going to change.

patent pivot Feb 26, 2021, 2:59 PM

#

alright hastebin resolved, firewall got greedy

thorny obsidian Feb 26, 2021, 2:59 PM

#

I haven't looked at the exact code and functionality yet, but plan to in April

short snow Feb 26, 2021, 3:05 PM

#

how were teams removed till date?

patent pivot Feb 26, 2021, 3:06 PM

#

internal eval

short snow Feb 26, 2021, 3:07 PM

#

ah

late wolf Feb 26, 2021, 3:17 PM

#

#bot-commands message
got a problem

gritty wind Feb 26, 2021, 3:18 PM

#

Same issue as

gritty wind Feb 26, 2021, 3:18 PM

#

patent pivot hm let me try describe how this all works

start reading from here if you are interested for an explanation, otherwise we are working on it

patent pivot Feb 26, 2021, 3:22 PM

#

I'll open a PR on snekbox when I get home

#

I wonder why this problem has only just manifested

#

Might be upstream

hardy gorge Feb 26, 2021, 3:28 PM

#

When did you make the cgroups change?

#

Wasn't that yesterday or something when it got merged?

green oriole Feb 26, 2021, 3:31 PM

#

Yesterday we merged a PR making a unique cgroup for each process, but it seems to break in prod

hardy gorge Feb 26, 2021, 3:36 PM

#

That's what I meant, yeah

#

So, I don't think it's a problem that only just manifested because of upstream

#

But rather it manifested because we merged that PR

#

And it only does this in certain specific circumstances

patent pivot Feb 26, 2021, 3:40 PM

#

Oh was that only yesterday

#

so

#

I wonder what the thing is

#

is it having large stdouts?

#

!e import time; ' ' * 100_000_000; time.sleep(0.1)

stable mountainBOT Feb 26, 2021, 3:41 PM

#

@patent pivot :warning: Your eval job timed out or ran out of memory.

[No output]

patent pivot Feb 26, 2021, 3:42 PM

#

riiiight

#

yeah that's probably something I didn't test, I tested memory & PID limits, forgot that huge stdout wreaks havoc at times as well

#

this is my patch that fixes it for stdout as well

green oriole Feb 26, 2021, 3:43 PM

#

I wonder why it did work two days ago, but not now anymore

patent pivot Feb 26, 2021, 3:43 PM

#

I don't think it did work two days ago

#

did we test huge stdout on the dynamic cgroups PR?

green oriole Feb 26, 2021, 3:43 PM

#

Well, we did have some users running infinite loops, it never broke

#

I can see if I can reproduce locally

patent pivot Feb 26, 2021, 3:44 PM

#

infinite loops or infinite loops with prints?

#

!e ```py
a = [1]
while True:
a.extend(a)

stable mountainBOT Feb 26, 2021, 3:44 PM

#

@patent pivot :warning: Your eval job timed out or ran out of memory.

[No output]

patent pivot Feb 26, 2021, 3:44 PM

#

!e ```py
a = [1]
while True:
a.extend(a)
print(a)

stable mountainBOT Feb 26, 2021, 3:44 PM

#

Sorry, an unexpected error occurred. Please let us know!

ClientResponseError: 500, message='Internal Server Error', url=URL('http://snekbox.default.svc.cluster.local/eval')

patent pivot Feb 26, 2021, 3:44 PM

#

that's where the error manifests

green oriole Feb 26, 2021, 3:44 PM

#

Alright, let's see

#

I do get a 500 on your branch

#

OSError: [Errno 16] Device or resource busy: '/sys/fs/cgroup/memory/snekbox-dae49828-a99f-4696-926d-7a963487250d'

patent pivot Feb 26, 2021, 3:50 PM

#

yeah

green oriole Feb 26, 2021, 3:53 PM

#

Building the image takes a long time man

#

Okay, it did work before the merge @patent pivot

patent pivot Feb 26, 2021, 3:56 PM

#

yeah

#

expected

gritty wind Feb 26, 2021, 3:57 PM

#

@cold island can we suppress the ping in dev versions?

#

or rather, with fake_redis

green oriole Feb 26, 2021, 4:00 PM

#

You can do that if debug is enabled, but I'm not sure if it is worth the trouble

cold island Feb 26, 2021, 4:07 PM

#

gritty wind <@!512354988157173763> can we suppress the ping in dev versions?

How do I check that?

green oriole Feb 26, 2021, 4:11 PM

#

smh straight up ignoring my message

gritty wind Feb 26, 2021, 4:11 PM

#

constants.fake redis

green oriole Feb 26, 2021, 4:23 PM

#

Hello folks, it would be much appreciated if someone could review bot#1436

cold island Feb 26, 2021, 4:23 PM

#

Yeah I can add that

dusky shoreBOT Feb 26, 2021, 4:23 PM

#

GitHub

PROpen [bot] #1436 Helpful Startup Errors

short snow Feb 26, 2021, 4:27 PM

#

green oriole Hello folks, it would be much appreciated if someone could review bot#1436

Alright lemme have a look

cold island Feb 26, 2021, 4:31 PM

#

green oriole smh straight up ignoring my message

You mean me?

green oriole Feb 26, 2021, 4:31 PM

#

yep

#

I guess it works with the constant

patent pivot Feb 26, 2021, 4:35 PM

#

do we use bulma calendar anywhere

short snow Feb 26, 2021, 4:35 PM

#

Hmm, never seen anywhere

#

Ok now my deleted msgs are useful, why did ak merge pr with only one approval

patent pivot Feb 26, 2021, 4:46 PM

#

which PR

#

1436?

green oriole Feb 26, 2021, 4:46 PM

#

short snow Ok now my deleted msgs are useful, why did ak merge pr with only one approval

Because you approved it, and I do trust your judgement, the PR is quite simple either way

short snow Feb 26, 2021, 4:48 PM

#

Ah ok. Thankyou lemon_hyperpleased

green oriole Feb 26, 2021, 4:49 PM

#

thank you for your review, appreciate that!

patent pivot Feb 26, 2021, 7:38 PM

#

cc @late wolf @short snow that bug should be fixed in https://github.com/python-discord/snekbox/pull/94, please feel free to test your snippets again

clever wraith Feb 26, 2021, 10:38 PM

#

how is my PR?

short snow Feb 27, 2021, 1:43 AM

#

patent pivot cc <@!707472976454483988> <@!736234578745884682> that bug should be fixed in htt...

Alright cool, i will test it

#

#

Not my idea, had being purposed by someone on gurkbot so thought it would be good here too, a way to get random challenges from codewars.

#

On sir lance

#

Their image

#

Ooh boy, i forgot the issue for pet bot, i will open it

gritty wind Feb 27, 2021, 4:16 AM

#

Hey there

#

we don't allow recruitment on this server

karmic cave Feb 27, 2021, 4:17 AM

#

Oh, apologies.

gritty wind Feb 27, 2021, 4:17 AM

#

Please review rule 6

karmic cave Feb 27, 2021, 4:17 AM

#

Okay.

fallen patrol Feb 27, 2021, 5:07 AM

#

so.…

#

why the abstraction layer?

#

what advantage does it bring to have a layer between the database?

tawdry vapor Feb 27, 2021, 5:08 AM

#

What are you asking about?

fallen patrol Feb 27, 2021, 5:09 AM

#

#dev-log

#

in short, https://github.com/python-discord/api#python-discord-api

GitHub

python-discord/api

A FastAPI-based service that allows our services to communicatie with our database. - python-discord/api

#

The Python Discord API is an internal API that serves as an abstraction layer between our Discord bot and our PostgreSQL database.The API is not publicly accessible, but only reachable from within our Kubernetes-cluster.

tawdry vapor Feb 27, 2021, 5:10 AM

#

I don't have the answer to that

#

I'm not involved in the project

gritty wind Feb 27, 2021, 5:11 AM

#

Well, there are certain advantages to using an API over SQL statements in general

fallen patrol Feb 27, 2021, 5:11 AM

#

as of now, I know the bot requires the site to act as a proxy to the database, so my question is more, what advantage does a proxy over a database do

#

ohhhhhhhh

#

thanks for the answer

#

it could be bundled with the bot, but that wouldn't be too great if you have a big-ass bot