green mesa Oct 14, 2020, 2:56 PM

#

ok but i am asking for pr template only

#

like have u run pipenv and all that stuff where we put x

green oriole Oct 14, 2020, 2:57 PM

#

I'm sure you can write a PR body yourself

glass pecan Oct 14, 2020, 2:57 PM

#

you can reference other prs that have been merged if needed too

green mesa Oct 14, 2020, 2:57 PM

#

doing that only

brazen charm Oct 14, 2020, 2:57 PM

#

A lot of seasonalbot features follow the same outline, that's not really the case for the bot. The ticking stuff you do on seasonalbot should be handled with a properly installed precommit

green oriole Oct 14, 2020, 2:57 PM

#

We assume that you did everything written at the bottom of the seasonalbot PR template

glass pecan Oct 14, 2020, 2:57 PM

#

maybe reference anything by ves

#

for a nice pr description

green mesa Oct 14, 2020, 2:58 PM

#

ok

#

my first pr at bot repo 🙂

#

.pr 1237

dusky shoreBOT Oct 14, 2020, 3:00 PM

#

[404] #1237 Issue/pull request not located! Please enter a valid number!

green mesa Oct 14, 2020, 3:00 PM

#

woops

#

.pr 1237 bot

dusky shoreBOT Oct 14, 2020, 3:00 PM

#

GitHub

PROpen [bot] #1237 Package cmd

eternal owl Oct 14, 2020, 3:01 PM

#

I think the file should be inside bot/exts/info/ instead of bot/exts/utils/

#

the package cmd file

green mesa Oct 14, 2020, 3:01 PM

#

but utility label is mentioned on it

#

thats y i added file there

#

i can move it if u wnt

eternal owl Oct 14, 2020, 3:02 PM

#

ohk

green oriole Oct 14, 2020, 3:04 PM

#

utils sounds good

hardy gorge Oct 14, 2020, 3:05 PM

#

@cold island sure. I've had some work, but the cog has changed a lot in the meantime, so it's trashware now

cold island Oct 14, 2020, 3:05 PM

#

I could also try add an option to display modmail logs, though I'll see how it goes with what's already outlined

#

@hardy gorge if it's saved to a specific branch I could take a peek for reference

green mesa Oct 14, 2020, 3:45 PM

#

@green oriole if u r free can i get my bug_ec merged i have two approval 🙂

#

i have one question if someone approved my pr and again he/she gave review his/her approval get dismissed?

eternal owl Oct 14, 2020, 3:49 PM

#

My review does not count I guess, we need another review from staff

brazen charm Oct 14, 2020, 3:49 PM

#

They do count

green mesa Oct 14, 2020, 3:50 PM

#

noice

#

then i have approval

crude gyro Oct 14, 2020, 3:51 PM

#

@crude gyro I got idea about articles app: Currently this is loading all data over and over again from filesystem and last modified + contributors from GitHub every time when somebody visit article. But what about in ready function in AppConfig fetching all guides, categories and GitHub data at once and store them to cache, because in order to modify article, this have to redeploy, what means this cache everything again.
@cold moon

Yes, implementing complete caching is part of the dewikification plan. I guess maybe I haven't made an issue for it yet, but the idea is that once we get rid of the API and the staff/deletedmessages, we can cache all the pages and only need to return cache. there are tools to do this for the entire site very easily.

for the github repository data, we actually already cache this for 10 minutes between every request.

cold moon Oct 14, 2020, 3:52 PM

#

But what engine we will use? Redis? Memcached?

#

Or just local cache?

crude gyro Oct 14, 2020, 3:52 PM

#

we haven't discussed the implementation details yet.

#

maybe even higher level than that.

#

instead of implementing caching as code, we may be able to just use a middleware for it.

#

but let's get back to it later. one step at a time.

cold moon Oct 14, 2020, 3:54 PM

#

Implementing this is really really simple and when I currently implement caching as local memory cache, then later we just have to replace config, because interface stays same.

#

https://docs.djangoproject.com/en/3.1/topics/cache/#basic-usage

Django’s cache framework | Django documentation | Django

#

This interface apply to each cache engine and replacing cache engine means replacing engine in configuration

green mesa Oct 14, 2020, 4:45 PM

#

If anyone is free can u have a look at my pr

#

.pr 485

dusky shoreBOT Oct 14, 2020, 4:45 PM

#

GitHub

PROpen [seasonalbot] #485 Pride Leader(pl)

patent pivot Oct 14, 2020, 4:47 PM

#

We could just put varnish in front of the site

#

that would be fastest

crude gyro Oct 14, 2020, 8:13 PM

#

yeah, that's more along the lines of what I'm thinking

clever wraith Oct 14, 2020, 10:20 PM

#

everybody gangsta until the owners start to talk

patent pivot Oct 14, 2020, 10:21 PM

#

lol

clever wraith Oct 14, 2020, 10:21 PM

#

oh shit and they respond

#

thank you for this server tho

#

its great

patent pivot Oct 14, 2020, 10:23 PM

#

CatSmug

cold island Oct 14, 2020, 11:15 PM

#

For anyone looking for a relatively simple review
https://github.com/python-discord/bot/pull/1212

sharp timber Oct 14, 2020, 11:25 PM

#

#sir-lancebot-playground message
Anyone interested in figuring out why it did this

cold island Oct 14, 2020, 11:27 PM

#

I get this error while booting up the bot. Is anyone familiar with it?

📎 unknown.png

lime mural Oct 14, 2020, 11:28 PM

#

I can fix that Bats

#

can I? :D

cold island Oct 14, 2020, 11:29 PM

#

@sharp timber what are you referring to specifically? it seems like the message started with the correct answer

lime mural Oct 14, 2020, 11:29 PM

#

no, the multiple mentions of the same person

brazen charm Oct 14, 2020, 11:30 PM

#

Is your local site up to date Zig?

cold island Oct 14, 2020, 11:31 PM

#

@lime mural feel free to open an issue in the repo and ask to be assigned there

lime mural Oct 14, 2020, 11:31 PM

#

okay thanks :)

brazen charm Oct 14, 2020, 11:32 PM

#

Looks like the cog just adds the authors of messages with correct answers to a list, so if someone answers multiple times they'll get multiple mentions

lime mural Oct 14, 2020, 11:32 PM

#

yep

cold island Oct 14, 2020, 11:34 PM

#

Numerlor this might sound dumb but I'm still trying to wrap my head around what the bot image can and can't do without the site. Figured some things would just be voided instead of raising exceptions. I'll look into setting it up now 😄

tawdry vapor Oct 14, 2020, 11:35 PM

#

It needs it for infractions, the syncer (which doesn't really count since that is only done to support other features that use the site), storing defcon settings, off topic channel names, deleted messages, and some other stuff I am forgetting

#

Reminders

brazen charm Oct 14, 2020, 11:36 PM

#

Well, you can ignore the error, but you'll get exceptions from anything that tries to connect to the site if it's not up and errors like the above if it's missing needed features/changes. In this case it won't sync the members

cold island Oct 14, 2020, 11:36 PM

#

Yeah, I understand what the site is for, I just thought that the errors would be when I try to run the commands instead of when it's trying to start

#

thanks

sullen phoenix Oct 14, 2020, 11:37 PM

#

the syncer runs on bot start, so that’s why

#

it also gathers infractions

tawdry vapor Oct 14, 2020, 11:37 PM

#

There are several startup tasks, like reapplying mute infractions, syncing the watch channel cache

brazen charm Oct 14, 2020, 11:37 PM

#

A lot of them run as a part of the cog inits so those will error out if something's not right

cold island Oct 14, 2020, 11:38 PM

#

I see

tawdry vapor Oct 14, 2020, 11:38 PM

#

Never mind the mute infractions, those are just done when someone joins the guild

sullen phoenix Oct 14, 2020, 11:39 PM

#

it should gather infractions to reschedule their pardons

tawdry vapor Oct 14, 2020, 11:39 PM

#

Oh what it does is reschedule them

#

Yes

cold island Oct 14, 2020, 11:45 PM

#

ok so I guess this is the part that somewhat confused me: https://pythondiscord.com/pages/contributing/bot/#site-and-bot

#

Because that's the command I used

#

Should I be cloning the site as well? placing it in the same directory?

sullen phoenix Oct 14, 2020, 11:47 PM

#

no, it’ll pull the image from docker hub

cold island Oct 14, 2020, 11:47 PM

#

Then theoretically it should have done so

sullen phoenix Oct 14, 2020, 11:47 PM

#

what do you have as the site url and schema in the config?

cold island Oct 14, 2020, 11:48 PM

#

let's see

sullen phoenix Oct 14, 2020, 11:48 PM

#

i thought you had this working before

#

hmm

cold island Oct 14, 2020, 11:49 PM

#

site:        &DOMAIN       "web:8000"
site_api:    &API    !JOIN ["api.", *DOMAIN]
site_paste:  &PASTE  !JOIN ["paste.", "pythondiscord.com"]
site_staff:  &STAFF  !JOIN ["staff.", *DOMAIN]
site_schema: &SCHEMA       "http://"

#

It worked without the site I just kind of ignored it because I didn't need it

sullen phoenix Oct 14, 2020, 11:50 PM

#

like Numerlor said before, is your local site up to date?

#

try a docker pull pythondiscord/site

cold island Oct 14, 2020, 11:52 PM

#

I rebuilt it so I figured it was enough

sullen phoenix Oct 14, 2020, 11:52 PM

#

a rebuild should also suffice

#

yeah

#

okay, maybe not

#

lol

#

docker-compose pull
docker-compose up --build

cold island Oct 15, 2020, 12:03 AM

#

got a bunch of warnings but otherwise seems ok

#

ok cool it works

#

thanks to all who replied 😄

rapid igloo Oct 15, 2020, 12:07 AM

#

i found this in the roles page:

This includes writing pull requests for open issues, and also for reviewing open pull requests (we really need reviewers!)
does that mean everyone is welcome to leave code reviews?

sullen phoenix Oct 15, 2020, 12:08 AM

#

absolutely

rapid igloo Oct 15, 2020, 12:08 AM

#

wow ok

#

i'm scared xd

brazen charm Oct 15, 2020, 12:09 AM

#

You should be familiar with the environment of the project you're reviewing for before doing it though

rapid igloo Oct 15, 2020, 12:36 AM

#

could anyone have a look at this if you're free

#

.pr 501

dusky shoreBOT Oct 15, 2020, 12:36 AM

#

GitHub

PROpen [seasonalbot] #501 remove duplicate winners for .riddle

sharp timber Oct 15, 2020, 12:43 AM

#

Something doesn't seem right here

#

Here, we have snekbox's upload limit being set to 1k chars
https://github.com/python-discord/bot/commit/6dccbd38016b113983b195f15272a5f432df6dcb

#

This doesn't make much sense though, because this will only do an upload if theres a lot of newlines, but under 1000 characters, which doesn't apply to many files. In addition, there's a path here:

        if lines > 10:
            truncated = True
            if len(output) >= 1000:
                output = f"{output[:1000]}\n... (truncated - too long, too many lines)"
            else:
                output = f"{output}\n... (truncated - too many lines)"
        elif len(output) >= 1000:
            truncated = True
            output = f"{output[:1000]}\n... (truncated - too long)"

        if truncated:
            paste_link = await self.upload_output(original_output)

that seems to expect to upload code to the paste service if we cross over 1000 characters. But if we do, no upload happens.

#

For a use case example:

import dis

def f():
    try:
        1/0
    except Exception as e:
        pass
    return e

dis.dis(f)

#

returns ~1200 characters. Well short enough to reasonably upload to pythons paste, and still doable in a message, but the bottom gets cut off at the moment and it's not uploaded

cold island Oct 15, 2020, 12:56 AM

#

@sharp timber this is a very old commit

sharp timber Oct 15, 2020, 12:56 AM

#

yeah, and it hasn't changed since. Which confuses me.

#

because I don't recall the behavior

cold island Oct 15, 2020, 12:59 AM

#

@sharp timber this seems to be the root https://github.com/python-discord/bot/blob/4255fdef8b7a75c59f45928abf9da250e24ddc00/bot/exts/utils/snekbox.py#L72

#

it's limited to 1000 characters

#

it might be outdated with the current pasting service, but it's something that joe can probably answer better

sullen phoenix Oct 15, 2020, 1:12 AM

#

that’s there just because

#

the actual limit is like 50k

brazen charm Oct 15, 2020, 1:13 AM

#

I'd say open an issue, afaik the limit is intended but the logic around it doesn't make all that much sense

cold island Oct 15, 2020, 1:13 AM

#

it could be to prevent the service from being bombarded with large files, but it doesn't have to be 1000

#

We could limit it to say 2000, and if the output is still too great, then truncate it in the paste as well instead of not uploading it at all

brazen charm Oct 15, 2020, 1:28 AM

#

I don't think it really matters but not truncating huge outputs for the paste service does exclude the amount of spammy while True print type things from it

tawdry vapor Oct 15, 2020, 1:29 AM

#

During a staff meeting it was decided to leave it at 1000 even though I suggested something higher. I think all of the people involved overlooked the fact that it truncates at 1000.

brazen charm Oct 15, 2020, 1:29 AM

#

There's also the nice opportunity to use the new line counting helper from the codeblock pr instead of count there

tawdry vapor Oct 15, 2020, 1:29 AM

#

It was in voice so I don't remember what exactly was said over a year ago

#

I think the intent was to not overload the paste service but even 50,000 characters is only 0.05 megabytes

cold island Oct 15, 2020, 1:30 AM

#

I think it's worth opening an issue about it a year later.. worst case it'll be closed again

tawdry vapor Oct 15, 2020, 1:31 AM

#

At the time the limit was something like 100k character limit and 100 MB for content, which is why there's that comment about the 400 - you could spend a while uploading 100MB only for the server to send back a 400 minutes later cause there are too many characters

rapid igloo Oct 15, 2020, 3:14 AM

#

https://github.com/python-discord/bot/blob/master/bot/exts/help_channels.py#L858 where's bot.http.pin_message documentation? I cant find where it is defined either

sullen phoenix Oct 15, 2020, 3:14 AM

#

it's not documented

rapid igloo Oct 15, 2020, 3:15 AM

#

Wut

sullen phoenix Oct 15, 2020, 3:16 AM

#

everything under http is not documented

#

we probably used it to save an API call

#

oh, i remember, it was in a PR ~~that had some controversy~~

#

let me find it

rapid igloo Oct 15, 2020, 3:17 AM

#

ok

sullen phoenix Oct 15, 2020, 3:19 AM

#

https://github.com/python-discord/bot/pull/1023#discussion_r450767120

GitHub

Help System: Implement question message pinning by ks129 · Pull Req...

Added first (claiming) message pinning and unpinning on dormant for better access when help session is long and new peoples join to helping. Resolves #1020

#

yeah, it was to save an API call along with getting rid of some chunky code

rapid igloo Oct 15, 2020, 3:23 AM

#

Ah ok, ty

#

https://github.com/python-discord/bot/pull/1023#pullrequestreview-457166782 how about this, the reason i was looking at that code is because i was figuring out if theres a way to delete the 'Python pinned a message to this channel' message. Is it neccessary to remove it tho?

#

Now that people know the bot pins the first message

sullen phoenix Oct 15, 2020, 3:29 AM

#

i wouldn't mind now, but it's a good idea to open an issue to get the thoughts of other people as well

rapid igloo Oct 15, 2020, 3:41 AM

#

done ✨

#

im surprised there weren't any issue templates

green mesa Oct 15, 2020, 3:49 AM

#

Yesterday same thing happened 😅 with me

green oriole Oct 15, 2020, 5:59 AM

#

You should see that as an exercise to make your write proper documents lemon_pleased

#

I have to say, doing that helped me quite a lot

rapid igloo Oct 15, 2020, 6:09 AM

#

Oh well, discord doesnt help because now everytime i wanna type 'you' i type 'u' lol

lime mural Oct 15, 2020, 6:23 AM

#

🎃 + 🍋

#

spooky lemoji for Halloween

obsidian patio Oct 15, 2020, 7:19 AM

#

@lime mural feel free to propose it in #dev-branding and possibly open an issue on the branding repo

rapid igloo Oct 15, 2020, 7:40 AM

#

what is the purpose of codeowners in pydis repos? are the requested people of a pr supposed to be the reviewers, or are they there just to show they are the code owners?

green mesa Oct 15, 2020, 7:40 AM

#

.pr 485

dusky shoreBOT Oct 15, 2020, 7:40 AM

#

GitHub

PROpen [seasonalbot] #485 Pride Leader(pl)

green mesa Oct 15, 2020, 7:40 AM

#

Woops

#

Wrong

green oriole Oct 15, 2020, 7:41 AM

#

In pydis repos, we use them to make sure that at least 1 core devs approved the PR

green mesa Oct 15, 2020, 7:41 AM

#

.pr 479

dusky shoreBOT Oct 15, 2020, 7:41 AM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

green mesa Oct 15, 2020, 7:41 AM

#

1 approve from chibli and 1 approve from iceman is done

subtle kraken Oct 15, 2020, 7:42 AM

#

I think that explains it fairly well https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners#about-code-owners
It also lists the usage of it, which we do use in fact
@rapid igloo

About code owners - GitHub Docs

You can use a CODEOWNERS file to define individuals or teams that are responsible for code in a repository.

green oriole Oct 15, 2020, 7:48 AM

#

I wonder which algorithm are we using for auto-assignment

green mesa Oct 15, 2020, 7:50 AM

#

For code review?

green oriole Oct 15, 2020, 7:51 AM

#

Yeah

subtle kraken Oct 15, 2020, 8:00 AM

#

Suggestions are based on git blame somehow afaik @green oriole

#

And github just uses those suggestions

green oriole Oct 15, 2020, 8:00 AM

#

Huh interesting

subtle kraken Oct 15, 2020, 8:01 AM

#

You can request a review from either a suggested or specific person. Suggested reviewers are based on git blame data. If you request a review, other people with read access to the repository can still review your pull request.

green oriole Oct 15, 2020, 8:02 AM

#

That’s actually pretty smart

subtle kraken Oct 15, 2020, 8:02 AM

#

I just found out github has docs
Thats where I got the text above from

green oriole Oct 15, 2020, 8:03 AM

#

Well, I was looking at https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-organizations-and-teams/managing-code-review-assignment-for-your-team#configuring-code-review-assignment

Managing code review assignment for your team - GitHub Docs

Code review assignments clearly indicate which members of a team are expected to submit a review for a pull request.

subtle kraken Oct 15, 2020, 8:06 AM

#

Hmm

#

Sounds like simple algo

📎 SmartSelect_20201015-101003_Samsung_Internet.jpg

obsidian patio Oct 15, 2020, 8:10 AM

#

Ah, cool

green mesa Oct 15, 2020, 8:11 AM

#

Load balance is quite nice

rapid igloo Oct 15, 2020, 9:04 AM

#

https://github.com/python-discord/bot/issues/1238 any thoughts on this anyone?

GitHub

Help Channels: Delete pin message notification · Issue #1238 · pyth...

When the bot pins a message, a 'notification' like Python pinned a message to this channel. See all the pins.. In reference to this (review comment), this message was kept to &#...

green mesa Oct 15, 2020, 9:26 AM

#

How it will silently pin?

#

And how bot will know what to pin if it doesn't pin the first message?

rapid igloo Oct 15, 2020, 9:36 AM

#

wdym? i'm talking about removing the pin notification (Python pinned a message in this channel), what it pins stays the same

#

like this one #help-croissant message

eternal owl Oct 15, 2020, 10:00 AM

#

@green mesa you missed this suggestion made by chibli

📎 unknown.png

green mesa Oct 15, 2020, 10:01 AM

#

Ahh

green mesa Oct 15, 2020, 10:18 AM

#

Just an idea when user will write the first message in channel we can ask what's your question and tell the user this will be pinned so others can check your question and after that user can put the question and then bot can pin

#

What u guys think

#

This way bot will pin the correct question

green oriole Oct 15, 2020, 10:19 AM

#

Well, after using the channels at least one you see that it'll pin the first message

#

Having an "Hello" or something pinned is fine by me, you can still use it to jump to the beginning of the chat

green mesa Oct 15, 2020, 10:20 AM

#

Ok

#

But don't u think we should try to make things more clear to our pydis community so, new people will also know what's happening

glass pecan Oct 15, 2020, 10:22 AM

#

wat

#

it's pretty clear man

#

you're suggesting adding complexity for a thing that isn't really an issue at the moment

green mesa Oct 15, 2020, 10:22 AM

#

👍

tough imp Oct 15, 2020, 10:23 AM

#

yea I see the pin as more of a jumplink to where the session started

#

it doesn't necessarily be the question itself

#

often the question is spread across multiple messages anyway due to pictures or codeblocks

green mesa Oct 15, 2020, 10:24 AM

#

Ok

lunar elm Oct 15, 2020, 12:33 PM

#

hi

#

i downloaded the source code for the python bot and dont know how to run it

tough imp Oct 15, 2020, 12:35 PM

#

we do have contributor guides here: https://pythondiscord.com/pages/contributing/

#

have you seen them?

lunar elm Oct 15, 2020, 12:35 PM

#

i ve never seen them

#

im gonna see them now

tough imp Oct 15, 2020, 12:35 PM

#

they should give you a good idea, but feel free to ask for help in this channel if something isnt clear

lunar elm Oct 15, 2020, 12:35 PM

#

ok

#

thanks

#

im gonna now look in the guide

#

i still dont understand that much

tough imp Oct 15, 2020, 12:46 PM

#

seasonalbot is a lot easier to setup

#

are you stuck on any particular step?

lunar elm Oct 15, 2020, 12:50 PM

#

im stuck on the config

harsh veldt Oct 15, 2020, 1:04 PM

#

i downloaded the source code for the python bot and dont know how to run it
@lunar elm git clone is better than downloading the source code, so it would be a git repo, so you can commit and contribute(if you want)

#

see the guide, I think it's really good one

green mesa Oct 15, 2020, 1:07 PM

#

.pr 479

dusky shoreBOT Oct 15, 2020, 1:07 PM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

green mesa Oct 15, 2020, 1:08 PM

#

If anyone is free can he/she have a look? at this

lunar elm Oct 15, 2020, 1:31 PM

#

but what is seasonal bot?

obsidian patio Oct 15, 2020, 1:47 PM

#

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to bot that changes with the seasons

lunar elm Oct 15, 2020, 1:47 PM

#

cool

obsidian patio Oct 15, 2020, 1:56 PM

#

@lunar elm Adding to that, we recently moved to a SeasonalBot that isn't as seasonal. Almost all commands are available the year around nowadays. It's mostly a project where we can get started with contributing to open source and a really fun bot to have on the server. We have a lot of games and fun commands on it. Type .help in #sir-lancebot-playground if you want a full list of its features 😄

green oriole Oct 15, 2020, 5:34 PM

#

We need to update dat description

lime mural Oct 15, 2020, 5:45 PM

#

is there a way to get link to official docs using !docs command

glass pecan Oct 15, 2020, 5:46 PM

#

for what

#

!docs contains like 14 different sources

lime mural Oct 15, 2020, 5:47 PM

#

python

glass pecan Oct 15, 2020, 5:47 PM

#

hmm probably not

#

!docs

stable mountainBOT Oct 15, 2020, 5:47 PM

#

All inventories (`19` total)

• pytest
• python
• requests
• scipy
• urllib3

lime mural Oct 15, 2020, 5:47 PM

#

like I did !docs math.factorial
if I could get link to official docs for that method

glass pecan Oct 15, 2020, 5:47 PM

#

yeah only via the inventory links

#

oh that's what you mean

brazen charm Oct 15, 2020, 5:48 PM

#

The link is in the title of the embed, if you're on mobile it doesn't show up but it's there

lime mural Oct 15, 2020, 5:48 PM

#

oh

#

that worked ty

errant cobalt Oct 15, 2020, 10:36 PM

#

Hey, guys. I am currently at my entry stage with my python and looking for a simple project to contribute, any ideas or projects?.

brazen charm Oct 15, 2020, 10:41 PM

#

This channel is specifically for the projects of this community; from here seasonalbot is geared towards beginners https://github.com/python-discord/seasonalbot

green mesa Oct 16, 2020, 3:27 AM

#

.pr 479

dusky shoreBOT Oct 16, 2020, 3:27 AM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

green mesa Oct 16, 2020, 3:27 AM

#

Anyone

rapid igloo Oct 16, 2020, 4:03 AM

#

hey guys, need some feedback here, which option is better:

#

📎 A9JF1GAOqehbgAAAABJRU5ErkJggg.png

#

📎 O4GBGOgEkRQAAAABJRU5ErkJggg.png

#

or this last one?

📎 wH4OZ8ULh3r1wAAAABJRU5ErkJggg.png

rapid igloo Oct 16, 2020, 8:06 AM

#

cool stuff, updated it (:

#

thanks for voting

lime mural Oct 16, 2020, 9:35 AM

#

is that the embed

rapid igloo Oct 16, 2020, 9:35 AM

#

its one of the fields of the embed im working on

#

if you want the whole embed ill send a pic

lime mural Oct 16, 2020, 9:37 AM

#

I like the last one better

rapid igloo Oct 16, 2020, 9:37 AM

#

but the last one is a bit messy with the (1) numbers imo

#

and most ppl chose the 2nd so i used the 2nd

lime mural Oct 16, 2020, 9:39 AM

#

yeah ig then use that one 👌

rapid igloo Oct 16, 2020, 9:40 AM

#

heres how the whole embed looks like, some stats may not be accurate and im still working onit

📎 xjW5j2C4FT8AAAAASUVORK5CYII.png

#

borrowing joes lol

lime mural Oct 16, 2020, 9:41 AM

#

ah yea the emotes make it better

#

check on mobile tho

rapid igloo Oct 16, 2020, 9:42 AM

#

oh yeah thanks for reminding me

#

ios seems fine, but dont have a android device to test on 😐

lime mural Oct 16, 2020, 9:43 AM

#

hmm I can test it

#

if u want

rapid igloo Oct 16, 2020, 9:43 AM

#

sure that'll be great its the :tada: and :clock1: im using

lime mural Oct 16, 2020, 9:44 AM

#

Nah, I mean the layout might break on mobile, I'm sure emojis will be fine

rapid igloo Oct 16, 2020, 9:45 AM

#

oh ok, because on web theres 🪙 but on ios there isnt so i just wanna make sure

#

also yeah embeds are a bit messed up sometimes on mobile

lime mural Oct 16, 2020, 9:46 AM

#

you can use the unicode instead of codes ig

#

🎉

#

🕒

rapid igloo Oct 16, 2020, 9:50 AM

#

oh thanks

#

but if a device doesnt have a particular emoji i dont think unicode will make it work

#

though

lime mural Oct 16, 2020, 9:51 AM

#

I mean you can check that here

rapid igloo Oct 16, 2020, 9:51 AM

#

but anyways im pretty sure they all have tada and clock

#

yeah i tried the coin unicode and on my ipad it shows as question mark

lime mural Oct 16, 2020, 9:52 AM

#

https://emojipedia.org/party-popper/

🎉 Party Popper Emoji

Emoji Meaning A party popper, as explodes in a shower of confetti and streamers at a celebration. Generally depicted as a gold party hat, striped on some platforms, at a 45° angle, with…

#

https://emojipedia.org/three-oclock/

🕒 Clock Face Three O’Clock Emoji

Emoji Meaning Three O’Clock was approved as part of Unicode 6.0 in 2010 …

rapid igloo Oct 16, 2020, 9:54 AM

#

thx it seems android and ios should all support it

#

like compared to this https://emojipedia.org/coin/, coin has so little support

harsh veldt Oct 16, 2020, 11:21 AM

#

what are those emojis

        defcon_disabled: ":defcondisabled:"
        defcon_enabled:  ":defconenabled:"
        defcon_updated:  ":defconsettingsupdated:"

#

hmm why doesn't discord keep ids

obsidian patio Oct 16, 2020, 11:22 AM

#

They’re for defcon. It’s basically the current anti-raid system we have

#

They’re the emojis to symbolise the different states

harsh veldt Oct 16, 2020, 11:22 AM

#

but there's no emoji named defcondisabled

#

:defcondisabled:

#

I'm asking this for server conf, if I don't have emoji how am I going to add it to server

obsidian patio Oct 16, 2020, 11:28 AM

#

Use some placeholder emojis. The functionality is what is generally tested

sullen phoenix Oct 16, 2020, 11:33 AM

#

we have separate emoji servers

harsh veldt Oct 16, 2020, 11:35 AM

#

is its emoji files stored in repo like branding?

brazen charm Oct 16, 2020, 11:40 AM

#

There's only a few emojis that you'll need to set for it to function

obsidian patio Oct 16, 2020, 11:43 AM

#

To answer your question, I don’t think the icons are actually stored there

harsh veldt Oct 16, 2020, 12:26 PM

#

i've set them up

#

btw, the template that lemon sent is a bit outdated

#

where's verification channel?

crude gyro Oct 16, 2020, 12:44 PM

#

not sure I sent a template..

harsh veldt Oct 16, 2020, 12:47 PM

#

https://discordapp.com/channels/267624335836053506/635950537262759947/694868859865530418

harsh veldt Oct 16, 2020, 1:17 PM

#

we will keep our own test server updated, and generate new templates from that whenever we need to.
@crude gyro

#

uh sorry for ping

#

didn't mean that

crude gyro Oct 16, 2020, 2:25 PM

#

looks like I said that on April 1st?

#

so... uhh.. April Fool's!! lemon_sweat

obsidian patio Oct 16, 2020, 2:26 PM

#

@crude gyro That’s actually listed as one of the April fools jokes on https://database.pydis.com

short snow Oct 16, 2020, 2:41 PM

#

@obsidian patio that link redirects to "https://www.youtube.com/watch?v=dQw4w9WgXcQ", is it supposed to do that?

obsidian patio Oct 16, 2020, 2:51 PM

#

Yeah. It’s called a rickroll

cold moon Oct 16, 2020, 6:03 PM

#

I have heard that deployment backend will get rework, but is there any plans for deployment changes?

harsh veldt Oct 16, 2020, 6:05 PM

#

Hi, I have some problems with docker. I have installed it and it runs containers perfectly on wsl 2 linux containers. however, in your https://pythondiscord.com/pages/contributing/hosts-file/ guide you have mentioned that you need to run command docker-machine ip default, adn I have issues about it. first what is docker-machine second, it gives error docker-machine is not recognazible so I probably need to add something to Path but im not sure. I tried to search in docs of docker but there is no info about not recognized command docker-machine in https://docs.docker.com/machine/concepts/.

#

ah wait I haven't checked possible errors page, lemme check that real quick

tawdry vapor Oct 16, 2020, 6:07 PM

#

I am not familiar with using Docker outside of linux, but their docs do state

#

The installers for Docker Desktop for Mac and Docker Desktop for Windows include Docker Machine, along with Docker Compose.

#

So, presumably you should have it somewhere, and it isn't on your PATH as you suspected

harsh veldt Oct 16, 2020, 6:08 PM

#

yeah but which folder I have to add to PATH

tawdry vapor Oct 16, 2020, 6:08 PM

#

You need to run that on your host, not inside the container, to be clear

harsh veldt Oct 16, 2020, 6:09 PM

#

oh

#

I see

#

okay, um lemme try that

brazen charm Oct 16, 2020, 6:13 PM

#

The IP you need is already in the hosts file for docker, you just need to copy it over to the pydis domains

harsh veldt Oct 16, 2020, 6:16 PM

#

what do I need to write in redirect_uri in the reddit app?

#

The IP you need is already in the hosts file for docker, you just need to copy it over to the pydis domains
okay, I am not configuring it yet, I'll see what i'll do when I configure that

brazen charm Oct 16, 2020, 6:17 PM

#

@tawdry vapor Where did you find that? both the install pages on https://docs.docker.com/docker-for-... for mac and windows state

The Docker Desktop installation includes Docker Engine, Docker CLI client, Docker Compose, Notary, Kubernetes, and Credential Helper.

tawdry vapor Oct 16, 2020, 6:18 PM

#

https://docs.docker.com/machine/overview/#what-is-docker-machine

Docker Documentation

Docker Machine overview

Introduction and Overview of Machine

harsh veldt Oct 16, 2020, 6:19 PM

#

what do I need to write in redirect_uri in the reddit app?
or do I really need to configure reddit app?

brazen charm Oct 16, 2020, 6:19 PM

#

You don't need to set the redirect_uri to anything meaningful. You only need it for the reddit commands and posts like in #reddit

harsh veldt Oct 16, 2020, 6:20 PM

#

okay thanks

brazen charm Oct 16, 2020, 6:21 PM

#

Not sure if that's just incorrect or they meant is as docker machine that's part of the docker desktop app because it doesn't seem to come with it as far as I can see

harsh veldt Oct 16, 2020, 6:22 PM

#

do I need to activate the virtualenv for docker-compose up -d?

tawdry vapor Oct 16, 2020, 6:31 PM

#

No

#

The container uses its own virtual environment within the contaner

harsh veldt Oct 16, 2020, 6:32 PM

#

yeah, docker-compose is not even in Pipfile

harsh veldt Oct 17, 2020, 8:12 AM

#

hey, me again, there's no "Run without Docker" section here https://pythondiscord.com/pages/contributing/bot/#run-the-project

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

is it just pipenv run?

#

just a note that, you may include this to "Running with Docker section":

If your computer has only 4GB RAM and 5 years old, do not try to run 5 containers at the same time, the computer might crash

green oriole Oct 17, 2020, 8:59 AM

#

@harsh veldt would you mind commenting on meta#60 about that, please ? lemon_pleased

#

.issue 60 meta

dusky shoreBOT Oct 17, 2020, 8:59 AM

#

GitHub

IssueOpen [meta] #60 Update the contributing guides

harsh veldt Oct 17, 2020, 9:12 AM

#

uh, I'm having some issues with postgres. When I open psql shell, it asks password for user postgres, which I set when I installed it. But if I do psql from normal command prompt it asks for the user MyName. Which there's no such user, ran \du from psql shell, and the result is

                                   List of roles
 Role name |                  Attributes                         | Member of
-----------+------------------------------------------------------------+---
 postgres  | Superuser, Create role, Create DB, Replication, Bypass RLS | {}

#

so there's only user postgres but it asks for user MyName

#

📎 unknown.png

#

I tried to change password for user, using

ALTER USER Murad PASSWORD 'newpassword';

but how can I change password of user if there's no user 😄

cold island Oct 17, 2020, 10:16 AM

#

I want to add a helper function which will serve several cogs. Where should I write it?

green oriole Oct 17, 2020, 10:19 AM

#

In the utils most probably

cold island Oct 17, 2020, 10:21 AM

#

That's where I'm looking atm, but can't find an appropriate file

green oriole Oct 17, 2020, 10:23 AM

#

What's your function for?

cold island Oct 17, 2020, 10:24 AM

#

I want to add a function which will define what mod channels are. Because currently the checks for that are scattered and repeated, and it leads to bugs.
So I want to be able to import a function which will tell me if the provided channel is considered a mod channel

green oriole Oct 17, 2020, 10:24 AM

#

Sounds like it should be here https://github.com/python-discord/bot/blob/master/bot/utils/channel.py

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

cold island Oct 17, 2020, 10:25 AM

#

Hmm that's weird, I don't see that file in my clone

#

I'll check what's going on on my end, thanks 😄

lime mural Oct 17, 2020, 10:26 AM

#

make sure you're on same branch

cold island Oct 17, 2020, 10:27 AM

#

It's my own branch, but I created it a few days ago

#

Oh, I just have a bad case of blind

lime mural Oct 17, 2020, 10:29 AM

#

haha

harsh veldt Oct 17, 2020, 12:51 PM

#

unhandled exception in bot:

for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed

What does this means?

brazen charm Oct 17, 2020, 12:52 PM

#

What's the full traceback?

harsh veldt Oct 17, 2020, 12:59 PM

#

just file names

#

@brazen charm https://paste.pythondiscord.com/nedetatija.sql

brazen charm Oct 17, 2020, 1:02 PM

#

How are you running the bot, outside of docker?

harsh veldt Oct 17, 2020, 1:02 PM

#

yes

#

both bot and site

#

site is running

green oriole Oct 17, 2020, 1:02 PM

#

You need fakeredis then

#

It is one of the first parameters in the config file

brazen charm Oct 17, 2020, 1:03 PM

#

Or point it at the right ip/host if it's running somewhere

green oriole Oct 17, 2020, 1:03 PM

#

use_fakeredis or something similar, you need to set it to true

harsh veldt Oct 17, 2020, 1:03 PM

#

okay

#

what about REDIS_PASSWORD?

brazen charm Oct 17, 2020, 1:04 PM

#

Doesn't matter for local dev

harsh veldt Oct 17, 2020, 1:04 PM

#

k

#

probably better to include it to contributing guide that you need to set use_fakeredis to true when you're running both locally

brazen charm Oct 17, 2020, 1:06 PM

#

It doesn't have to be true if you're running redis through either wsl, docker or something else which would allow it. But I don't think the guides mention redis at all which would be helpful

green oriole Oct 17, 2020, 1:07 PM

#

Can you mention it in meta#60? 🙃

#

.issue 60 meta

dusky shoreBOT Oct 17, 2020, 1:07 PM

#

GitHub

IssueOpen [meta] #60 Update the contributing guides

lime mural Oct 17, 2020, 1:11 PM

#

I will try contributing once the guide is improved xD

harsh veldt Oct 17, 2020, 1:23 PM

#

@lime mural the guide is good enough. if you're contributing only bot just run the site and stuff with docker, I cannot run because my computer is not strong enough to run 5 containers at the same time, it's lagging. but i do not think there will be some issues with running docker

lime mural Oct 17, 2020, 1:24 PM

#

mine isn't either

#

don't think I can run 5 containers

brazen charm Oct 17, 2020, 1:25 PM

#

Why 5 containers? I count 5 for completely everything, half of which is not needed

harsh veldt Oct 17, 2020, 1:29 PM

#

Why 5 containers? I count 5 for completely everything, half of which is not needed
@brazen charm why not?

brazen charm Oct 17, 2020, 1:30 PM

#

redis is optional, and you'll only need snekbox when working on it

#

personally I run the bot normally, and the site, postgres and redis in docker

#

So that'd be 2 running containers, although I'm not sure how much each individual container contributes to how much docker takes up

lime mural Oct 17, 2020, 1:38 PM

#

oh 2 containers might be fine then

#

that makes more sense, thanks

cold island Oct 17, 2020, 1:42 PM

#

I seem to be failing one of the tests. Is there an easy way to see what the input to that test is?

green oriole Oct 17, 2020, 1:43 PM

#

Note that on windows a container will take more processing power than a native app because of the hypervisor, but not on Linux since it ks running as a native process, they are just a few restrictions on it

#

@cold island you can take a look at the source, or if it is a subtest there should be the test data in the output

cold island Oct 17, 2020, 1:46 PM

#

The output message is pretty generic, and from what I see I'm already handling what it concerns, which is why I wanted to know the exact input

green oriole Oct 17, 2020, 1:47 PM

#

Well, source code then

cold island Oct 17, 2020, 1:47 PM

#

That would be great if I was good with unittests lol. I'll see if I can figure it out

green oriole Oct 17, 2020, 1:49 PM

#

Haha, well, it should be pretty straightforward as for the I-call-the-production-code part

#

If you need anything, feel free to give me a little ping though lemon_pleased

glass pecan Oct 17, 2020, 1:50 PM

#

no little pings left, only big pings

cold island Oct 17, 2020, 1:50 PM

#

are those role pings?

glass pecan Oct 17, 2020, 1:50 PM

#

no, they're big pings.

#

@AKARYS

green oriole Oct 17, 2020, 1:51 PM

#

Wut

#

How

cold island Oct 17, 2020, 1:52 PM

#

lol

glass pecan Oct 17, 2020, 1:52 PM

#

not as cool once i delete it

#

but still

cold island Oct 17, 2020, 1:54 PM

#

@green oriole I think I'll take you up on that offer

green oriole Oct 17, 2020, 1:54 PM

#

Alright

#

Which test is failing?

cold island Oct 17, 2020, 1:54 PM

#

In tests\bot\exts\info\test_information.py

#

test_create_user_embed_expanded_information_in_moderation_channels

#

Fails on infraction_counts.assert_called_once_with(user)

#

AssertionError: Expected 'expanded_user_infraction_counts' to be called once. Called 0 times.

green oriole Oct 17, 2020, 1:56 PM

#

It seems like cog.user_nomination_counts is never called when making an embed in a mod channel

lime mural Oct 17, 2020, 1:57 PM

#

Note that on windows à container will take more processing power than a native app because of the hupervisor, but not on Linux since it ks running as a native process, they are just a few restrictions on it
@green oriole even on WSL?

green oriole Oct 17, 2020, 1:57 PM

#

Is that intended?

#

@lime mural nope, WSL goes through the hypervisor

lime mural Oct 17, 2020, 1:57 PM

#

ah rip then

#

what about Docker on Windows itself?

cold island Oct 17, 2020, 1:58 PM

#

user_nomination_counts? don't you mean infraction counts?

brazen charm Oct 17, 2020, 1:59 PM

#

wsl 1 doesn't use hyperv, but is slower in most aspects than 2

green oriole Oct 17, 2020, 2:00 PM

#

No, this exact function, look https://github.com/python-discord/bot/blob/ff7c34aee21493efbc78a9b6521dd9c0f48d4a72/tests/bot/exts/info/test_information.py#L325

cold island Oct 17, 2020, 2:00 PM

#

No it's not intended, and it shows the expanded counts when I invoke it in the test server

green oriole Oct 17, 2020, 2:01 PM

#

Can you add a dirty print to make sure that the command is properly detecting the mod channel?

cold island Oct 17, 2020, 2:01 PM

#

No, this exact function, look https://github.com/python-discord/bot/blob/ff7c34aee21493efbc78a9b6521dd9c0f48d4a72/tests/bot/exts/info/test_information.py#L325
That's not the function being checked here though. That function is checked one line below

green oriole Oct 17, 2020, 2:03 PM

#

Oh no, the decorator ordering got me, it seems like

cold island Oct 17, 2020, 2:03 PM

#

And the assertion error says expanded_user_infraction_counts. Or am I missing something?

green oriole Oct 17, 2020, 2:03 PM

#

Yes, you're right

#

So is this function supposed to be called?

cold island Oct 17, 2020, 2:04 PM

#

Yes, it is

#

And since it shows me the expanded count in the test server it seems to work fine

#

I'll add a print there

green oriole Oct 17, 2020, 2:07 PM

#

Oh, I think I know why

#

The test is patching constants.MODERATION_CHANNELS to be [50], but I think we aren't using this constant anymore, are we?

cold island Oct 17, 2020, 2:09 PM

#

Hmmm there is a line which uses it ctx = helpers.MockContext(channel=helpers.MockTextChannel(id=50))

#

or do you mean something else

green oriole Oct 17, 2020, 2:10 PM

#

It is a decorator on the class containing the test

#

https://github.com/python-discord/bot/blob/ff7c34aee21493efbc78a9b6521dd9c0f48d4a72/tests/bot/exts/info/test_information.py#L266

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

harsh veldt Oct 17, 2020, 2:11 PM

#

why does API gives me 401 (unauthorized) status code?

green oriole Oct 17, 2020, 2:11 PM

#

Did you changed the API key on the bot?

cold island Oct 17, 2020, 2:11 PM

#

Ok, and what do you mean by not using it anymore?

harsh veldt Oct 17, 2020, 2:12 PM

#

Did you changed the API key on the bot?
@green oriole no I didn't set

#

it's badbot blah i think

green mesa Oct 17, 2020, 2:12 PM

#

Yeh

#

I also have

green oriole Oct 17, 2020, 2:12 PM

#

Ok, and what do you mean by not using it anymore?
@cold island can you check if the code is still using this constant to check if you are in a mod channel?

cold island Oct 17, 2020, 2:13 PM

#

I am still using that constant, but I changed it so that it would include other criteria as well

green oriole Oct 17, 2020, 2:13 PM

#

Hmm

cold island Oct 17, 2020, 2:13 PM

#

But it's not using less channels, so whatever is in there should still work

brazen charm Oct 17, 2020, 2:13 PM

#

Did you configure the site values?

harsh veldt Oct 17, 2020, 2:14 PM

#

@green oriole if i don't set that in .env does that means it's not setted or it's default badbot?

#

Did you configure the site values?
@brazen charm

site:        &DOMAIN       "pythondiscord.local:8000"
    site_api:    &API    !JOIN ["api.", *DOMAIN]
    site_paste:  &PASTE  !JOIN ["paste.", *DOMAIN]
    site_staff:  &STAFF  !JOIN ["staff.", *DOMAIN]
    site_schema: &SCHEMA       "http://"

green oriole Oct 17, 2020, 2:15 PM

#

I am not sure, I think you have to set it

harsh veldt Oct 17, 2020, 2:15 PM

#

okay lemme set it and reload

green oriole Oct 17, 2020, 2:15 PM

#

@cold island I'd suggest you to step through a debugger then, I don't know what could be failing

brazen charm Oct 17, 2020, 2:15 PM

#

Yes, it needs to be set

green oriole Oct 17, 2020, 2:15 PM

#

Maybe your new conditions isn't correctly detecting the mod channel?

brazen charm Oct 17, 2020, 2:16 PM

#

How does your code look?

cold island Oct 17, 2020, 2:16 PM

#

That's the only plausible explanation, even though it clearly does 🤷‍♂️

green mesa Oct 17, 2020, 2:16 PM

#

First time setup of pybot is pain but after that it goes smooth

harsh veldt Oct 17, 2020, 2:39 PM

#

I just saw the comment of mbaruh in the issue. So there's pr from kosayada about improving !superstarify command(#1204). Should I wait for merging of pr then work on the issue #1224?

#

.pr 1204 bot

dusky shoreBOT Oct 17, 2020, 2:40 PM

#

GitHub

PROpen [bot] #1204 Modify !superstar to use apply_infraction.

green oriole Oct 17, 2020, 2:42 PM

#

It seems like you want to wait first, yeah

cold island Oct 17, 2020, 2:51 PM

#

@green oriole siiiiiiiiiigh I found it

#

smh

#

The test didn't work well because I imported the mod channels constant using a relative import

#

Which I did because another constant was already being imported that way

green oriole Oct 17, 2020, 2:53 PM

#

Ah damn

cold island Oct 17, 2020, 2:53 PM

#

Which might mean that the other constant isn't being tested

#

Does it mean that I have to change it now because the PR tests will fail?

green oriole Oct 17, 2020, 2:55 PM

#

Either that or fixing the test ~~but I have no idea how~~

green oriole Oct 17, 2020, 3:10 PM

#

@cold island oh no, the line continuation lemon_pensive

#

Why not putting parenthesis around the two conditions?

cold island Oct 17, 2020, 3:24 PM

#

uuuuh, I could change that

#

Maybe we should add that to the linter 😛

green oriole Oct 17, 2020, 3:29 PM

#

Hmm, they are valid cases for line continuations, I think

brazen charm Oct 17, 2020, 3:30 PM

#

None that I'm aware of when we go to 3.9

cold island Oct 17, 2020, 3:30 PM

#

I wouldn't need to break the line if I could just import the constant itself >:|

#

fixed

#

and now linting failed 🤦

obsidian patio Oct 17, 2020, 3:40 PM

#

@cold island https://soundcloud.com/lemonsaurusrex/lint-before-you-push 👀

cold island Oct 17, 2020, 3:40 PM

#

I always lint before I push 😠

#

It just was supposed to be simple 😔

obsidian patio Oct 17, 2020, 3:41 PM

#

Hahah yeah

cold island Oct 17, 2020, 3:42 PM

#

Can I run the precommit without committing?

sullen phoenix Oct 17, 2020, 3:43 PM

#

just pipenv run lint

cold island Oct 17, 2020, 3:44 PM

#

lmao it was a trailing whitespace

obsidian patio Oct 17, 2020, 3:44 PM

#

Hahah that happens

fickle trail Oct 17, 2020, 3:45 PM

#

my duo is on so im chill

cold island Oct 17, 2020, 3:47 PM

#

so... because there is a difference in line endings between windows and linux, it now wants to stage changes on every single file on the repo

#

Can I just revert the last commit I made? lol

green oriole Oct 17, 2020, 3:48 PM

#

You can append to it and force push, yeah

brazen charm Oct 17, 2020, 3:48 PM

#

Should be able to just ignore that, but at this point I'd revert and replace the commit that added the \ and replace it with properly formatted parentheses

cold island Oct 17, 2020, 3:58 PM

#

Nope, I reverted but linting still modifies all the files

sullen phoenix Oct 17, 2020, 4:00 PM

#

you have to stage the changes

brazen charm Oct 17, 2020, 4:00 PM

#

Don't lint then I guess, or configure the line endings for git

sullen phoenix Oct 17, 2020, 4:00 PM

#

unless i'm missing something

#

oh, right

green oriole Oct 17, 2020, 4:01 PM

#

I think this is happening because one of the hook creates a windows ending, and so the mixed line ending hook wants to change everything to windows endings, or something like that

cold island Oct 17, 2020, 4:16 PM

#

I force pushed but I don't think I did it right lol

#

Either way, it seems like pipenv run lint has different behavior than the precommit

#

Because the precommit actually handled it right

green oriole Oct 17, 2020, 4:17 PM

#

It looks okay

cold island Oct 17, 2020, 4:19 PM

#

Ok yeah the commit history looks right

green oriole Oct 17, 2020, 4:19 PM

#

And the CI succeeded \o/

cold island Oct 17, 2020, 4:20 PM

#

woo

#

Thank you for holding my hand throughout the process

green oriole Oct 17, 2020, 4:20 PM

#

Anytime lemon_pleased

tawdry vapor Oct 17, 2020, 8:46 PM

#

Would greatly appreciate reviews on this https://github.com/python-discord/bot/pull/1245

GitHub

Store the bot instance as a global variable by MarkKoz · Pull Reque...

Is very convenient when writing utility functions that rely on the bot's state, but aren't in cogs and therefore lack the typical way to access the instance. No more passing around ...

#

I think it's pretty simple

#

I'd like to kind of fast-track it so I can get to work on something else that was beginning to involve a lot of passing around of the bot instance.

tough imp Oct 17, 2020, 8:59 PM

#

loooking

brazen charm Oct 17, 2020, 9:00 PM

#

Would patching it into builtins be too magical?

#

Right, it would be, didn't consider every checker that'd complain about it being undefined

tough imp Oct 17, 2020, 11:04 PM

#

I dont know how likely it is, but if an import chain is triggered before the bot is instantiated, it could also cause some other module to assign or try to use the placeholder None

#

that'd be a nasty thing to debug

brazen charm Oct 17, 2020, 11:11 PM

#

maybe a singleton class would give it a clearer value

thorny obsidian Oct 17, 2020, 11:14 PM

#

Did I do something weird in #help-falafel ? Got an odd output from using !e

brazen charm Oct 17, 2020, 11:16 PM

#

can't handle text yet, so you go a syntax error with ``` which the bot refused to output

thorny obsidian Oct 17, 2020, 11:17 PM

#

But I feel like I've used:
```py before and it's been fine

obsidian patio Oct 17, 2020, 11:17 PM

#

In other words, you can’t add any commends around the code block

#

print(5)

Some extra text

#

This won’t be allowed

brazen charm Oct 17, 2020, 11:18 PM

#

It's using the whole message as code

thorny obsidian Oct 17, 2020, 11:18 PM

#

Huh. I figured it would only use what's in the code block.

obsidian patio Oct 17, 2020, 11:18 PM

#

There’s a PR about allowing that, though

#

And even having multiple code blocks like this:

# Some code

Some text ```py

Extra code ```

Final comments

cold island Oct 17, 2020, 11:39 PM

#

You're welcome to review it so it can be merged lemon_pleased

thorny obsidian Oct 17, 2020, 11:40 PM

#

I don't think my coding ability and standards are good enough to provide a review, otherwise I would

rapid igloo Oct 17, 2020, 11:41 PM

#

@cold island which pr is it, just wanna have a look

cold island Oct 17, 2020, 11:43 PM

#

https://github.com/python-discord/bot/pull/1212

rapid igloo Oct 17, 2020, 11:44 PM

#

thanks

#

doesn't it already have 2 approvals?

cold island Oct 17, 2020, 11:45 PM

#

It takes 2 staff approvals

rapid igloo Oct 17, 2020, 11:45 PM

#

ohh ok

cold island Oct 17, 2020, 11:46 PM

#

But others are encouraged to review PRs and give their opinions

brazen charm Oct 17, 2020, 11:48 PM

#

only one core dev approval is needed afaik

cold island Oct 17, 2020, 11:48 PM

#

It takes two staff approvals, at least one of which needs to be a core dev

brazen charm Oct 17, 2020, 11:50 PM

#

https://discordapp.com/channels/267624335836053506/635950537262759947/721000141271728178

patent pivot Oct 17, 2020, 11:51 PM

#

yep, it's 1 core dev approval + 1 approval from anyone else (contrib/staff)

#

It does depend on the PR really

cold island Oct 17, 2020, 11:52 PM

#

Yeah but are we talking about an automatic merge? Because a core dev can just merge if they want

brazen charm Oct 17, 2020, 11:52 PM

#

Nothing's merged automatically, just don't have to do a force merge if it's two from the org

patent pivot Oct 17, 2020, 11:52 PM

#

ah right, yeah, for GitHub UI to glow green it needs 2 core devs, but yeah, as Numerlor says, can merge at any point

cold island Oct 17, 2020, 11:53 PM

#

Right, that's what I mean

obsidian patio Oct 18, 2020, 12:07 AM

#

@cold island I’ll have a look at it if I find the time

#

!remind 3d Ready to review Zig’s PR?

stable mountainBOT Oct 18, 2020, 12:07 AM

#

You got it!

Your reminder will arrive in 3 days!

obsidian patio Oct 18, 2020, 12:08 AM

#

And in the future, I’d recommend working on a feature branch, so you always have a clean master branch

cold island Oct 18, 2020, 12:21 AM

#

ik, that's why I do usually, just kind of forgot with this one

rapid igloo Oct 18, 2020, 5:20 AM

#

@obsidian patio @green oriole I think my PR 475 is almost ready for review now, it would be good if you could have a look (when you're free) and help me test it? One big problem i have now is the amount of api fetching needed which slows down the response time, but i have tried to optimise it where i can. tysm

green oriole Oct 18, 2020, 6:33 AM

#

Alright, I'll try to

#

If we have some serious rate limit issues, we can always use a blank token to increase the limit

rapid igloo Oct 18, 2020, 6:37 AM

#

For me when i was running it locally i had to generate a token from github, but i dont know if a token is used in production

green oriole Oct 18, 2020, 6:39 AM

#

Actually, it seems like we have a GITHUB_TOKEN env var

rapid igloo Oct 18, 2020, 6:39 AM

#

Yup i used that and it worked for me

green oriole Oct 18, 2020, 7:15 AM

#

It should be set in prod 👍

cold moon Oct 18, 2020, 7:17 AM

#

@patent pivot All changes in Voice Gate PR made.

patent pivot Oct 18, 2020, 7:23 AM

#

awesome stuff, will take a look later today

cold moon Oct 18, 2020, 11:11 AM

#

I think Python Discord repositories should have .editorconfig, because then most biggest editors will automatically get like end of line and indent type + amount.

glass pecan Oct 18, 2020, 11:20 AM

#

i don't hate the idea

patent pivot Oct 18, 2020, 11:40 AM

#

reviews left @cold moon

#

primarily formatting + copy

cold moon Oct 18, 2020, 11:42 AM

#

I think I have to find way to get Grammarly to PyCharm lemon_sweat

obsidian patio Oct 18, 2020, 11:43 AM

#

Fwiw PyCharm already checks for spelling errors

patent pivot Oct 18, 2020, 11:43 AM

#

yeah, but it's fairly simple

#

spelling and grammar checkers are more complex

obsidian patio Oct 18, 2020, 11:43 AM

#

Yeah

#

It’s more of a “is this in the dictionary” type of thing

rapid igloo Oct 18, 2020, 11:47 AM

#

How about https://github.com/codespell-project/codespell

green oriole Oct 18, 2020, 11:47 AM

#

There's also the JB plug-in, Grazie

brazen charm Oct 18, 2020, 11:49 AM

#

The config is fairly standard so I'm not sure if .editorconfig is worth it, but settings EOL though gitattributes would be nice if possible as there have been some problems with them and lint on win

rapid igloo Oct 18, 2020, 11:50 AM

#

Doesn't pre commit fix/check the line endings?

green oriole Oct 18, 2020, 11:51 AM

#

Yeah, but the fix part seems pretty broken, as it tries to change the line ending for every files in the repo haha

cold island Oct 18, 2020, 12:00 PM

#

The precommit fix part seems ok, but pipenv run lint gave me hell yesterday lol

brazen charm Oct 18, 2020, 12:05 PM

#

I had issues with the EOL fixer with pre commit on almost every commit (then a second commit after the files were changed passed), making things like merges a PITA; Mark suggested setting autocrlf to input and eol to lf in the config which seems to have fixed it, but I'm not sure what the gitattributes equivalent it or how it affects the files on other OSs

cold moon Oct 18, 2020, 12:27 PM

#

@patent pivot Voice Gate changes made. I made that now this only remove underscore for infraction only for visual side to not break anything.

patent pivot Oct 18, 2020, 12:28 PM

#

yep — that's what I was hoping for, sweet. will give it another test shortly

patent pivot Oct 18, 2020, 1:31 PM

#

I think this review is final @cold moon

cold moon Oct 18, 2020, 1:38 PM

#

@patent pivot All suggestions applied

cold moon Oct 18, 2020, 2:13 PM

#

One approval left for Voice Gate... Nice...

cold moon Oct 18, 2020, 2:29 PM

#

@patent pivot Currently everybody can see voice channels, even without voice verified role.

patent pivot Oct 18, 2020, 2:29 PM

#

intentional.

#

it's rolled out

#

we're just gating the speak permission, not the connecting.

cold moon Oct 18, 2020, 2:29 PM

#

Oh, so you can listen but not talk without role?

patent pivot Oct 18, 2020, 2:30 PM

#

yep

short snow Oct 18, 2020, 3:15 PM

#

some problem

#

#sir-lancebot-playground message

#

here it shld be .roll and not !roll

obsidian patio Oct 18, 2020, 3:16 PM

#

You’re right. I’ll fix that now

brazen charm Oct 18, 2020, 3:18 PM

#

Probably worth going over the code and making sure everything uses the prefix var

obsidian patio Oct 18, 2020, 3:18 PM

#

You mean something like {CONSTANTS.bot_prefix} instead?

brazen charm Oct 18, 2020, 3:20 PM

#

either from there or from the bot instance

obsidian patio Oct 18, 2020, 3:20 PM

#

Alright

obsidian patio Oct 18, 2020, 3:59 PM

#

@short snow should be fixed now

short snow Oct 18, 2020, 4:01 PM

#

ok perfect :)!

thorny obsidian Oct 18, 2020, 4:03 PM

#

So I have my DMs off for this server and I just tried voiceverify. It told me to check my DMs and I didn't get any sort of fallback response as per PR #1246

glass pecan Oct 18, 2020, 4:03 PM

#

orly?

thorny obsidian Oct 18, 2020, 4:03 PM

#

mhm, I only got the "check your DMs messsage"

glass pecan Oct 18, 2020, 4:03 PM

#

i did test it myself and got the reply i expected

#

so lemme check logs

#

it still says "check your DMs" regardless though lol

#

📎 unknown.png

thorny obsidian Oct 18, 2020, 4:04 PM

#

I didn't see that second embed

glass pecan Oct 18, 2020, 4:06 PM

#

@thorny obsidian can you try again?

#

yep definitely shown

#

📎 unknown.png

thorny obsidian Oct 18, 2020, 4:07 PM

#

I got removed from the channel before I saw it

glass pecan Oct 18, 2020, 4:07 PM

#

ahh that'll be why then

#

thanks, that's not something i could test... kinda can't hide channels from me

thorny obsidian Oct 18, 2020, 4:08 PM

#

Ha, yeah. That makes sense

obsidian patio Oct 18, 2020, 4:17 PM

#

thanks, that's not something i could test... kinda can't hide channels from me
@glass pecan you could view it as a person with the developers role

#

The new “view as role” feature

glass pecan Oct 18, 2020, 4:19 PM

#

yeah, probs

#

@thorny obsidian when you lost perms, did you still see the channels last few messages?

thorny obsidian Oct 18, 2020, 4:33 PM

#

Nope, it kicked me back out to welcome

glass pecan Oct 18, 2020, 4:34 PM

#

hrm

#

whoops, time to force push

#

never tried to do a multiline git commit message via cli before, so that was fun and surprisingly simple

obsidian patio Oct 18, 2020, 4:59 PM

#

Really?

#

Most people do git commit and then use the editor, but there's also git commit -m "XXX" -m "YYY" -m "ZZZ"

#

All of the new message things will be new lines

cold moon Oct 18, 2020, 5:00 PM

#

And I use Sublime Merge/JetBrains IDE lol

glass pecan Oct 18, 2020, 5:02 PM

#

git commit and then use the editor
yes this is what i did

#

i had to check though

#

as i've only ever used -m before, or a gui lol

#

vscode/pycharm commits

patent pivot Oct 18, 2020, 11:54 PM

#

13 line diff review from any contrib? https://github.com/python-discord/bot/pull/1247

GitHub

Ensure verified users can see verified message. by scragly · Pull R...

When verified users get their role, they cannot see the voice-verification channel anymore, so I've added a 3 second delay for granting the role in order to ensure there's some time...

obsidian patio Oct 19, 2020, 12:00 AM

#

Done

patent pivot Oct 19, 2020, 12:01 AM

#

gnarly

#

merged

rapid igloo Oct 19, 2020, 12:01 AM

#

just saying, this part seems repeated

try:
                 await ctx.author.send(embed=embed)
                 await ctx.send(f"{ctx.author}, please check your DMs.")
             except discord.Forbidden:
                 await ctx.channel.send(ctx.author.mention, embed=embed)

patent pivot Oct 19, 2020, 12:01 AM

#

intentional

rapid igloo Oct 19, 2020, 12:01 AM

#

ok

patent pivot Oct 19, 2020, 12:01 AM

#

oh, do you mean because it is repeated for failure and success?

obsidian patio Oct 19, 2020, 12:01 AM

#

Let’s hope we didn’t the break the bot and now have to suffer

rapid igloo Oct 19, 2020, 12:01 AM

#

yeah @patent pivot

patent pivot Oct 19, 2020, 12:02 AM

#

riiiight, yeah, I misread, whoops

rapid igloo Oct 19, 2020, 12:02 AM

#

haha

patent pivot Oct 19, 2020, 12:02 AM

#

yeah, there would be less duplicated ways to go about that — but it's not hugely critical

brazen charm Oct 19, 2020, 12:03 AM

#

Any thoughts on https://github.com/python-discord/bot/issues/998 ?

patent pivot Oct 19, 2020, 12:05 AM

#

hmmmm

#

what would the proposed implementation be there

#

saving the files and reuploading?

brazen charm Oct 19, 2020, 12:06 AM

#

The bot would send them the text contents of the message (if any are present)

patent pivot Oct 19, 2020, 12:06 AM

#

right, but for the "or an attachment" part

brazen charm Oct 19, 2020, 12:07 AM

#

You can upload an attachment with a message, if the attachment doesn't pass through the filter the whole thing gets deleted

patent pivot Oct 19, 2020, 12:08 AM

#

ahh right, so you're not suggesting reupload the attachment, right

obsidian patio Oct 19, 2020, 12:08 AM

#

@brazen charm I added my view on it now

brazen charm Oct 19, 2020, 12:08 AM

#

We could keep the message around for a minute or two in case of disabled dms

patent pivot Oct 19, 2020, 12:09 AM

#

hm

#

Eventually Discord will have ephemeral messages

brazen charm Oct 19, 2020, 12:10 AM

#

Is that eventually close?

patent pivot Oct 19, 2020, 12:10 AM

#

They are suggesting end of the year

#

hmm, I think keeping things around defeats the point of the filter

#

we recently had the filter catch actual malware

brazen charm Oct 19, 2020, 12:11 AM

#

Oh, in memory, not in the channel

patent pivot Oct 19, 2020, 12:11 AM

#

ahhhh

brazen charm Oct 19, 2020, 12:11 AM

#

so delete, keep in a cache and then some user command could be used to retrieve it for a short period

patent pivot Oct 19, 2020, 12:12 AM

#

riiiiight

cold island Oct 19, 2020, 6:41 AM

#

Any chance this can be merged? since it has two reviews, one of which a core dev review.
I'd rather wait for it to be merged before I work on the next thing which might cause conflicts

https://github.com/python-discord/bot/pull/1243

crude gyro Oct 19, 2020, 6:54 AM

#

@cold island approved. merge if you want.

rapid igloo Oct 19, 2020, 6:56 AM

#

any thoughts on this anyone? I currently have 2 yes and 2 no so im not sure: https://github.com/python-discord/bot/issues/1238

cold island Oct 19, 2020, 7:11 AM

#

approved. merge if you want.
@crude gyro thank you, but I don't think I have perms to merge

#

any thoughts on this anyone? I currently have 2 yes and 2 no so im not sure: https://github.com/python-discord/bot/issues/1238
I didn't say no, I said "convince me" 😄

obsidian patio Oct 19, 2020, 7:23 AM

#

@cold island I added another comment. It’s probably not worth removing

rapid igloo Oct 19, 2020, 7:24 AM

#

not sure if mark has anything to say, because i think he's the first to mention its presence

tawdry vapor Oct 19, 2020, 7:43 AM

#

I'm indifferent

timid sentinel Oct 19, 2020, 7:45 AM

#

I would be happy if it was removed, but then again I don't use the pinned message feature

#

And I know it is there if I wanted to use it

crude gyro Oct 19, 2020, 10:30 AM

#

I don't see any need to remove it.

rapid igloo Oct 20, 2020, 1:20 PM

#

gosh its october 20th already; not much time left. im worried that this pr wont be merged before hacktoberfest ends, because then its gonna be a waste of time ig, rules could be different next year 🥺 reviews anyone? https://github.com/python-discord/seasonalbot/pull/475 atm it really hurts seeing people receiving not entirely accurate hackstats. i know it could extend until first half of november or so, but still

obsidian patio Oct 20, 2020, 1:41 PM

#

Should the functionality be correct now, so it’s actually filtering according to the rules?

wispy quail Oct 20, 2020, 7:27 PM

#

Not sure how of a good suggestion this is, but: add a limit for !remind so people don't fill the db with unnecessary stuff (e.g. 50+ years) to avoid this

#bot-commands message

obsidian patio Oct 20, 2020, 7:28 PM

#

It doesn’t really add that much extra data. I think it’s fine from that aspect. It also doesn’t really get used that much (with strange times)

green oriole Oct 20, 2020, 7:51 PM

#

Yes, you have a limit

obsidian patio Oct 20, 2020, 7:53 PM

#

!remind @green oriole 9999999999y Well, it’s only the datetime failing and not an actually reasonable limit

stable mountainBOT Oct 20, 2020, 7:53 PM

#

Sorry, an unexpected error occurred. Please let us know!

ConversionError: (<class 'bot.converters.Duration'>, OverflowError('signed integer is greater than maximum'))

obsidian patio Oct 20, 2020, 7:53 PM

#

Isn’t that something like 4080 years as the limit?

subtle kraken Oct 20, 2020, 7:54 PM

#

Datetime has 9999y limit

#

9999y 12m 31d
So long its not passing into 10000

#

Max would be 9999-12-31 - current date

#

7980y few months few says

obsidian patio Oct 20, 2020, 7:56 PM

#

But didn’t you mute me for 7980 years because that was the limit?

subtle kraken Oct 20, 2020, 7:57 PM

#

It was close to it

#

It wasnt the limit

obsidian patio Oct 20, 2020, 7:57 PM

#

Ah, okay

subtle kraken Oct 20, 2020, 7:59 PM

#

Gimme a sec

#

7980 would be the limit had it been 2019-12-31 @obsidian patio

#

!remind 251799076610s test

stable mountainBOT Oct 20, 2020, 8:01 PM

#

You got it!

Your reminder will arrive in 7979 years, 2 months, 11 days, 3 hours, 56 minutes and 50 seconds!

obsidian patio Oct 20, 2020, 8:03 PM

#

Aah okay

rapid igloo Oct 20, 2020, 11:36 PM

#

Should the functionality be correct now, so it’s actually filtering according to the rules?
@obsidian patio yeah i believe the logic is according to the hacktoberfest rules now. but the only thing is that their source code also check for "spammy" repo/prs which i'm not quite sure about, but i don't think it's too much of a problem compared to the hacktoberfest topic, pr acceptance, etc

stable mountainBOT Oct 21, 2020, 12:07 AM

#

@obsidian patio

It has arrived!

Here's your reminder: Ready to review Zig’s PR?.
[Jump back to when you created the reminder](#dev-contrib message)

green mesa Oct 21, 2020, 1:42 AM

#

Plz anyone check my pr bug emoji now it's seven day no one checked it

#

!pr 479

#

.pr 479

dusky shoreBOT Oct 21, 2020, 1:43 AM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

short snow Oct 21, 2020, 5:56 AM

#

#reddit message the "I_m Joseph" post is messed up due to bold

cold moon Oct 21, 2020, 6:33 AM

#

.issue 475

dusky shoreBOT Oct 21, 2020, 6:33 AM

#

GitHub

PROpen [seasonalbot] #475 update hacktoberstats logic for updated rules

cold moon Oct 21, 2020, 6:33 AM

#

There is one point about what I'm unsure:

When a PR is labelled invalid/spam but it is merged/approved, it will still be counted

rapid igloo Oct 21, 2020, 6:53 AM

#

@cold moon thats the hacktoberfest rules i guess, i asked in the hacktoberfest server and they said that if a pr was labelled invalid/spam but merged/approved, it will also be counted (which is what i said)

#

in the pr matt also said that invalid/spam labelled prs shouldn't be ignored so that proves my point

short snow Oct 21, 2020, 6:59 AM

#

that links takes us to a blackhole (atleast for me)

rapid igloo Oct 21, 2020, 7:03 AM

#

sure here it is ignore the link then

📎 image0.png

rapid igloo Oct 21, 2020, 8:05 AM

#

lemon_hyperpleased it's merged

#

nvm now

green mesa Oct 21, 2020, 9:21 AM

#

Mine is still waiting 😔

surreal venture Oct 21, 2020, 10:19 AM

#

!pr 123

#

.pr 1234

dusky shoreBOT Oct 21, 2020, 10:19 AM

#

[404] #1234 Issue/pull request not located! Please enter a valid number!

surreal venture Oct 21, 2020, 10:19 AM

#

.pr 123

dusky shoreBOT Oct 21, 2020, 10:19 AM

#

GitHub

PRMerged [seasonalbot] #123 Add command .partnerzodiac

surreal venture Oct 21, 2020, 10:19 AM

#

.pr1

#

.pr 1

dusky shoreBOT Oct 21, 2020, 10:19 AM

#

GitHub

IssueClosed [seasonalbot] #1 Set up some simple Discord bot boilerplate.

rapid igloo Oct 21, 2020, 10:47 AM

#

@surreal venture this channel isn't for playing with commands, you can do it in #sir-lancebot-playground

surreal venture Oct 21, 2020, 11:05 AM

#

oh sorry my bad

green mesa Oct 21, 2020, 12:38 PM

#

Can someone look at my pr also😔

#

.pr 479

dusky shoreBOT Oct 21, 2020, 12:39 PM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

green mesa Oct 21, 2020, 12:39 PM

#

It has 2 approval one from iceman and one from chibli

#

And 7 days already passed

obsidian patio Oct 21, 2020, 12:40 PM

#

Iceman isn’t staff, so we’ll need another staff approval before the count is 2

green mesa Oct 21, 2020, 12:40 PM

#

Chibli?

#

Is mod

#

And core dev

obsidian patio Oct 21, 2020, 12:40 PM

#

Yes. We need 2

green mesa Oct 21, 2020, 12:41 PM

#

I thought we need only 1

obsidian patio Oct 21, 2020, 12:41 PM

#

Either way, it doesn’t look like you’ve addressed the feedback given

green mesa Oct 21, 2020, 12:41 PM

#

Yes I addressed all buddy

#

Which one I left can u point it plz

tough imp Oct 21, 2020, 12:42 PM

#

the PR still has changes requested from 2 people

obsidian patio Oct 21, 2020, 12:42 PM

#

You need two explicit approvals from two staff members, where one of them is a core developer

green mesa Oct 21, 2020, 12:42 PM

#

Actually chibli approved it and after that he requested for feedback

#

That's y his approval got removed

#

But I addressed what he asked for

#

@nocturne hare can u pls look at the changes I made in https://github.com/python-discord/seasonalbot/pull/479 I have addressed all changes u requested for

green mesa Oct 21, 2020, 1:47 PM

#

📎 Screenshot_2020-10-21-19-17-32-163.jpeg

#

Finally UwU

#

Ty Chibli

short snow Oct 21, 2020, 1:54 PM

#

#sir-lancebot-playground message a think this is a bug for the candy command, another bug

cold moon Oct 21, 2020, 3:56 PM

#

@eternal owl Why you closed user events management site PR?

eternal owl Oct 21, 2020, 3:57 PM

#

I made a few changes to the API which were already commited, I will open new PR with cleaner commits

#

nvm, mb, not sure what I was thinking, lol, re-opened it

cold moon Oct 21, 2020, 4:16 PM

#

~~Rebase is always option~~

obsidian patio Oct 21, 2020, 4:20 PM

#

That would remove PR comments from what I’m aware, but that doesn’t mean it shouldn’t be done

cold moon Oct 21, 2020, 4:20 PM

#

This PR don't have any reviews/comments

eternal owl Oct 21, 2020, 4:20 PM

#

its a draft PR

#

I'm writing some final tests now and will push changes

obsidian patio Oct 21, 2020, 4:22 PM

#

Okay. Then I don’t have anything against rebasing

green oriole Oct 21, 2020, 4:23 PM

#

If it is a draft PR, it is pretty fine, but don't forget that you can always force push the branch if no one commented on it yet, and start over without making a new PR

eternal owl Oct 21, 2020, 4:24 PM

#

I have made changes to the model and I wanted to include it in a commit which I made in the beginning, hence I thought of making a new PR with new commits

#

if model changes, then tests, serializer, viewset also change, so more commits

cold moon Oct 21, 2020, 4:25 PM

#

Yeah, after any comments is added, it's not good here to rebase it, but I have contributed to some repos where force-push is required, as commit history have really specific guidelines.

#

😭 Reactions are disabled in #dev-announcements

short snow Oct 21, 2020, 4:32 PM

#

@rapid igloo congrats for contributor role!

eternal owl Oct 21, 2020, 4:47 PM

#

gratz!

cold moon Oct 21, 2020, 5:19 PM

#

Is there any way that Contributors can get reacting permission in #dev-announcements ?

brazen charm Oct 21, 2020, 5:20 PM

#

Don't you already have them?

eternal owl Oct 21, 2020, 5:20 PM

#

we do

green mesa Oct 21, 2020, 5:21 PM

#

Still waiting for my pr to get merged 😔

obsidian patio Oct 21, 2020, 5:22 PM

#

Have you addressed the requested changes?

cold moon Oct 21, 2020, 5:23 PM

#

Oh, they added it! lemon_s_autumn

green mesa Oct 21, 2020, 5:33 PM

#

@obsidian patio I still aren't able to locate

#

📎 Screenshot_2020-10-21-19-17-32-163.jpeg

#

I have got these

eternal owl Oct 21, 2020, 5:34 PM

#

!pr 479

#

.pr 479

dusky shoreBOT Oct 21, 2020, 5:34 PM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

obsidian patio Oct 21, 2020, 5:38 PM

#

Looks like you have one staff approval. You’ll need a second one as well

green mesa Oct 21, 2020, 5:39 PM

#

Whatttt one is required only right😔

eternal owl Oct 21, 2020, 5:39 PM

#

this and

📎 unknown.png

#

📎 unknown.png

#

it would be better if the if statements were consistent

#

both of them accomplish the same but with diff conditions set

#

line 34 and 44

green mesa Oct 21, 2020, 5:40 PM

#

First one is for when dict have only 1 item

#

And second one is for if dict has more than 1 item

#

That's y I have two conditions

eternal owl Oct 21, 2020, 5:41 PM

#

make the if statement condition same in the 2 chunks

#

just for consistancy

#

2 chunks

#

📎 unknown.png

#

line 34 and 43

green mesa Oct 21, 2020, 5:45 PM

#

@eternal owl one is checking if condition is =1 and one is checking more than 1

#

If I use same condition code will mess up

eternal owl Oct 21, 2020, 5:46 PM

#

I meant, mimic the if statement conditions in line 34 and 43

green mesa Oct 21, 2020, 5:47 PM

#

Is it making much difference😅

eternal owl Oct 21, 2020, 5:47 PM

#

nop

green mesa Oct 21, 2020, 5:48 PM

#

2nd chunk is checking same thing as first just in oppo manner

rapid igloo Oct 22, 2020, 1:01 AM

#

uh, viewing on ipad discord embedded safari is like this

📎 image0.png 📎 image1.png

#

is it a youtube problem or...

sullen phoenix Oct 22, 2020, 1:02 AM

#

it really depends on your browser

#

joe and i see them differently as well

#

i don't think there's much we can do

patent pivot Oct 22, 2020, 1:02 AM

#

hgrnh that padding is not good

sullen phoenix Oct 22, 2020, 1:03 AM

#

yeah lol

rapid igloo Oct 22, 2020, 1:03 AM

#

same result on chrome, just saying

sullen phoenix Oct 22, 2020, 1:08 AM

#

https://cdn.discordapp.com/attachments/365960823622991872/768619491033743400/Screenshot_2020-10-22_at_00.39.21.png

#

https://cdn.discordapp.com/attachments/365960823622991872/768638321982832640/unknown.png

#

that's joe vs i

patent pivot Oct 22, 2020, 1:09 AM

#

wow leaked

sullen phoenix Oct 22, 2020, 1:12 AM

#

SORRY JOE SORRY JOE

rapid igloo Oct 22, 2020, 1:17 AM

#

wait what apr 8

cold island Oct 22, 2020, 1:18 AM

#

why not?

sullen phoenix Oct 22, 2020, 1:24 AM

#

didn’t change the date on that pic yet

cold island Oct 22, 2020, 1:43 AM

#

o

trim cradle Oct 22, 2020, 4:08 AM

#

I'm doing a code exploration to wrap my head around what adding a timer to !watch would entail, but the idea is that you'd do !watch <user_id> <duration> <reason> and the user will automatically be removed from the watchlist after that duration

#

is there anywhere in particular I should be looking, other than bigbrother.py?

brazen charm Oct 22, 2020, 4:17 AM

#

Not familiar with the code for it, but that would probably be most fitting for the scheduler from scheduling utils and some persistence from redis; I believe silence is merged now so you could take a look there

trim cradle Oct 22, 2020, 4:24 AM

#

@brazen charm thanks!

green mesa Oct 22, 2020, 4:44 AM

#

.pr 479

dusky shoreBOT Oct 22, 2020, 4:44 AM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

green mesa Oct 22, 2020, 4:44 AM

#

Anyone plz

rapid igloo Oct 22, 2020, 5:14 AM

#

why is there a reddit command on both python and seasonal bot?
they seem to almost do the same thing

eternal owl Oct 22, 2020, 5:52 AM

#

they are slightly different

#

the seasonalbot one needs a few fixes

#

https://github.com/python-discord/seasonalbot/issues/348

GitHub

Problems with Reddit command. · Issue #348 · python-discord/seasona...

Recently, the Reddit command PR (#346) was merged with a number of problems being overlooked. This issue is to outline the required fixes and any additional enhancements to the feature. Current Pro...

obsidian patio Oct 22, 2020, 6:09 AM

#

Is there any reason we don’t simply merge them?

#

I know Akarys has brought up this topic before as well

cold moon Oct 22, 2020, 6:17 AM

#

I think this should stay as Python feature as Python post them to #reddit

obsidian patio Oct 22, 2020, 6:31 AM

#

Maybe, though I don’t think it quite fits @stable mountain. Does anyone else have a thought on this?

crude gyro Oct 22, 2020, 7:52 AM

#

It's not a core feature. I think it belongs in SeasonalBot. I hate that it exists in both and we should absolutely merge it all into one place.

cold moon Oct 22, 2020, 7:59 AM

#

I think maybe should milestone page loaded dynamically from YAML? Then adding new entries will need only change YAML file, not editing whole HTML?

#

And currently there is this nice bouncing effect only when you are moving down first time. I think this should be changed that this like leave with this bouncing effect when this is going out from screen and then next time going back again with same effect.

crude gyro Oct 22, 2020, 8:18 AM

#

I don't think I need either of those things.

cold moon Oct 22, 2020, 8:20 AM

#

These should be nice improvements, I think. Not something really-really important.

sour sierra Oct 22, 2020, 1:12 PM

#

Is there anything else I need to change about this- https://github.com/python-discord/seasonalbot/pull/496 ?

GitHub

Fix candy mini-game to group leader-board scores correctly by quant...

Relevant Issues

Closes #495, #477 and #284
Description

The older code was storing candy spawn information in the json, which I think is unnecessary. I have replaced it all with two sets- candy_m...

obsidian patio Oct 22, 2020, 1:22 PM

#

I’ll probably have time to review it again tomorrow

green mesa Oct 22, 2020, 6:03 PM

#

@subtle kraken sorry if I sounds annoying can u plz check https://github.com/python-discord/seasonalbot/pull/479 if u have time

subtle kraken Oct 22, 2020, 6:06 PM

#

Sure though I might only just have time around tomorrow morning (in 12h or so)
Though will try to check it within 3h @green mesa

green mesa Oct 23, 2020, 1:04 AM

#

Ty

sharp timber Oct 23, 2020, 5:06 AM

#

The token remover filter doesn't function on @stable mountain 's dms. While this makes sense from one perspective ( Bot dms aren't the server, so most moderation filters don't make much sense there ) I think for tokens it's a different matter?

cold moon Oct 23, 2020, 5:09 AM

#

Is DMs relayed to somewhere?

sharp timber Oct 23, 2020, 5:32 AM

#

DM's to the bot are, yes

#

https://github.com/python-discord/bot/blob/master/bot/exts/moderation/dm_relay.py

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

cold moon Oct 23, 2020, 5:39 AM

#

hmm, then tokens + webhooks should be catched.

sharp timber Oct 23, 2020, 5:43 AM

#

In DM's you can't delete a message someone else sent, so this may be more difficult than it looks

short snow Oct 23, 2020, 5:53 AM

#

#sir-lancebot-playground message and this #sir-lancebot-playground message, i guess this is another bug or some problem with the .candy command

rapid igloo Oct 23, 2020, 6:04 AM

#

There's a pr fixing the candy command

#

.pr 496

dusky shoreBOT Oct 23, 2020, 6:05 AM

#

GitHub

PROpen [seasonalbot] #496 Fix candy mini-game to group leader-board scores correctly

rapid igloo Oct 23, 2020, 6:05 AM

#

I think it revamps the whole logic so it should fix those bugs

obsidian patio Oct 23, 2020, 7:07 AM

#

It changes a lot of the logic. I’ll probably review it a second time later today

rapid igloo Oct 23, 2020, 7:25 AM

#

minor fix - 15 lines total, https://github.com/python-discord/seasonalbot/pull/510 could anyone have a look?

#

(if i counted correctly)

rapid igloo Oct 23, 2020, 9:10 AM

#

fixed this issue with .hackstats #760857070781071431 message (thank you @near belfry ), this probably has higher priority than the one above. also it only has 5 line changes https://github.com/python-discord/seasonalbot/pull/511

brazen charm Oct 23, 2020, 12:10 PM

#

Is there any reason we're running aiohttp integration for sentry? https://github.com/python-discord/bot/commit/5c0819890259e446273707ec2dbb4b8312c9e19f removed it since it was intended for servers, but was later readded in https://github.com/python-discord/bot/commit/93be87cea7cde7333042e2bb9529867723f567a7

tawdry vapor Oct 23, 2020, 2:12 PM

#

Because lemon misunderstood its purpose

#

The integration is only useful when running an aiohttp server

patent pivot Oct 23, 2020, 9:32 PM

#

yeah, it doesn't harm having it but it is redundant

green mesa Oct 24, 2020, 12:06 PM

#

@subtle kraken 😅 my pr

vocal wolf Oct 24, 2020, 12:31 PM

#

@green mesa can you post it here?

green mesa Oct 24, 2020, 12:31 PM

#

Sure

#

.pr 479

dusky shoreBOT Oct 24, 2020, 12:31 PM

#

GitHub

PROpen [seasonalbot] #479 [Bug] emoji command

subtle kraken Oct 24, 2020, 12:33 PM

#

will check the PR in <2h for sure

#

gotta run an errand and will get to the pr

green mesa Oct 24, 2020, 12:33 PM

#

🙂

rapid igloo Oct 24, 2020, 1:27 PM

#

hello, 5 line diff review anyone? its a fix for the hackstats command (for some users) https://github.com/python-discord/seasonalbot/pull/511

glass pecan Oct 24, 2020, 1:28 PM

#

did you say low-effort pr? are you asking to be invalidated

#

jks

#

i'll have a look

rapid igloo Oct 24, 2020, 1:28 PM

#

uh i don't get it, but thx

glass pecan Oct 24, 2020, 1:28 PM

#

eh, it's hacktoberfest

rapid igloo Oct 24, 2020, 1:29 PM

#

nah i'm not worried for a tshirt

#

i already ordered it

glass pecan Oct 24, 2020, 1:29 PM

#

the joke is lots of low effort prs going around, so i was just poking fun

#

it's fiiine

#

Looks alright, just some missing capitalisation in your description, no capitalisation in your commit message and the commit message could be more descriptive. Not worth correcting on seasonalbot, but worth making note of for future PRs.

rapid igloo Oct 24, 2020, 1:36 PM

#

shit

glass pecan Oct 24, 2020, 1:36 PM

#

?

rapid igloo Oct 24, 2020, 1:37 PM

#

everything is shirt.

#

shit

glass pecan Oct 24, 2020, 1:38 PM

#

The code appears fine and the feedback is only minor feedback for future improvements. If it was shit, it wouldn't have been approved lol

obsidian patio Oct 24, 2020, 1:40 PM

#

I’ll have a look at it as well. Is it fine if I potentially approve the code of it without testing the feature? @glass pecan

glass pecan Oct 24, 2020, 1:43 PM

#

@obsidian patio sorry, disappeared for a sec there. yeah that's fine, I've run the code

green oriole Oct 24, 2020, 1:47 PM

#

Oh oh

#

Sorry vest

glass pecan Oct 24, 2020, 1:48 PM

#

lol

obsidian patio Oct 24, 2020, 1:48 PM

#

Ehhh

#

Seems like I left a review on a merged PR

glass pecan Oct 24, 2020, 1:49 PM

#

yeah

#

but your comment is valid. it matched on mine, but I also haven't had a non-accepted pr yet

#

soooooo

obsidian patio Oct 24, 2020, 1:50 PM

#

So we merged a non-working PR?

glass pecan Oct 24, 2020, 1:50 PM

#

we gotta confirm the issue first

obsidian patio Oct 24, 2020, 1:50 PM

#

Right

glass pecan Oct 24, 2020, 1:50 PM

#

if so, then we just gotta make a fix, no biggy

#

it wasn't accurate before the merge either lol

obsidian patio Oct 24, 2020, 1:51 PM

#

Yeah, I guess

green oriole Oct 24, 2020, 1:53 PM

#

Oh no

#

Haha

glass pecan Oct 24, 2020, 1:54 PM

#

there is so much code in this module

#

there we go, so it wasn't a problem

#

thanks IPv4

late wolf Oct 24, 2020, 2:11 PM

#

don't know if the right channel, if it aint the tell me so but The silence or the shh commands uses overwrites right?

glass pecan Oct 24, 2020, 2:13 PM

#

yep

#

https://github.com/python-discord/bot/blob/master/bot/exts/moderation/silence.py#L153-L165

subtle kraken Oct 24, 2020, 2:14 PM

#

@green mesa you already checked that it all works well?

#

well its merged now

green mesa Oct 24, 2020, 2:25 PM

#

It got approved 3-4 days before but no one merged but u did finally ty

cold moon Oct 24, 2020, 3:55 PM

#

📎 Screenshot_2020-10-24_at_18.54.59.png

#

Is this right design?

📎 Screenshot_2020-10-24_at_18.54.19.png

glass pecan Oct 24, 2020, 3:55 PM

#

force refresh your cache

#

🙂

cold moon Oct 24, 2020, 3:58 PM

#

Yeah, this worked

glass pecan Oct 24, 2020, 3:59 PM

#

It was tempting to just say yes and let you get worried though lol

patent pivot Oct 24, 2020, 4:01 PM

#

hahaha

past falcon Oct 24, 2020, 4:14 PM

#

The stat tracking on !e looks a lil weird to me:

if ctx.channel.category_id == Categories.help_in_use:
    self.bot.stats.incr("snekbox_usages.channels.help")
elif ctx.channel.id == Channels.bot_commands:
    self.bot.stats.incr("snekbox_usages.channels.bot_commands")
else:
    self.bot.stats.incr("snekbox_usages.channels.topical")``` This doesn't seem to cover all whitelisted channels/categories (esoteric, help_available, voice), so they would just get bundled as topical. And the topical help channels don't even seem to be whitelisted 🤔 
(https://github.com/python-discord/bot/blob/master/bot/exts/utils/snekbox.py)

green oriole Oct 24, 2020, 4:15 PM

#

Topical help channels aren't whitelisted, but staff members can use eval in those

#

Also #esoteric-python is a topical channel

past falcon Oct 24, 2020, 4:16 PM

#

Ah, true. So esoteric is treated correctly there then, but what about help_available / voice?

And separate question - why are topical help channels not whitelisted?

green oriole Oct 24, 2020, 4:18 PM

#

I guess you can call voice topical, but maybe it could have another category for the stats

#

I don't see how you'd run an eval in help available though

past falcon Oct 24, 2020, 4:18 PM

#

I agree, but the available category is whitelisted 😄

green oriole Oct 24, 2020, 4:18 PM

#

That's really weird

#

I guess you could start your question with an example

#

As for the second question iirc it was because they still considered the topical help channel shared, and people could disturb the conversation with evals

cold island Oct 24, 2020, 7:03 PM

#

I'd like to consult the hivemind
I want the top-most function responsible for the !user command to know whether the user has infractions, assuming the command was invoked inside a mod channel.
Now, I could start searching inside the embed the function receives from its helper functions, for the exact format resulting from a user having infractions in a mod channel, but it sounds silly to search for information I already gained inside the helper functions, and it would also be volatile to any formatting changes.

That said, the idea of propagating a boolean value throughout the helper functions doesn't appeal to me too much either.

Thoughts?

#

I cooouuld change what each helper function does

#

yeah, that sounds alright

green mesa Oct 25, 2020, 6:43 AM

#

Scarygif command of seasonalbot is not working

#

📎 Screenshot_2020-10-25-12-14-58-605.jpeg

sour sierra Oct 25, 2020, 7:18 AM

#

It works on my local instance. Maybe giphy API key is missing/not set?

cold moon Oct 25, 2020, 7:19 AM

#

Problem can be on API key. There was mess with YouTube API key too some time ago

green mesa Oct 25, 2020, 7:34 AM

#

Hmmm

cold moon Oct 25, 2020, 7:41 AM

#

Tested locally: Problem is on missing API key. Having key = no error, removing it shows exactly same error.

#

Have to be solved by DevOps team

glass pecan Oct 25, 2020, 8:13 AM

#

.scarygif

dusky shoreBOT Oct 25, 2020, 8:13 AM

#

A spooooky gif!

green oriole Oct 25, 2020, 8:14 AM

#

Ah yes

#

Very spooky

obsidian patio Oct 25, 2020, 8:52 AM

#

That taco cat is terrifying. It frightens me

cold moon Oct 25, 2020, 8:55 AM

#

I think for https://github.com/python-discord/site/issues/385 it's better to add another template engine to site: Jinja2. Jinja have one big thing that Django own lang don't have: setting variables inside templates. This is really important thing for event pages, as this will make much much easier defining sidebars inside templates (these should be built with dictionaries, what building Jinja supports). This don't mean that everything have to use Jinja, as Django supports multiple engines too.

GitHub

Dewikification: Create an app for showing event info. · Issue #385 ...

Remember to target the dewikification branch with this pull request For displaying event information (like for our code jams), we will want a slightly different approach. These will basically just ...

green oriole Oct 25, 2020, 9:10 AM

#

So you want to use jinja2 instead of jinja I'm guessing 1?

cold moon Oct 25, 2020, 9:14 AM

#

Yes, I said Jinja2 first, then I didn't included 2 anymore

green oriole Oct 25, 2020, 9:15 AM

#

I don't understand, which templating engine are we using right now?

cold moon Oct 25, 2020, 9:18 AM

#

Django Template Engine

green oriole Oct 25, 2020, 9:25 AM

#

Huh I thought we were using jinja2

#

I'm not opposed to adding it, but you should leave a comment on the PR issue to ask what others think about that

cold moon Oct 25, 2020, 10:53 AM

#

Also can someone assgin me to this issue?

green oriole Oct 25, 2020, 10:57 AM

#

Sure thing

hardy gorge Oct 25, 2020, 10:58 AM

#

@cold moon Could you explain to me why we'd need Jinja2 for that?

#

My view is that we can use DTL's include system for things like shared side bars

#

You have a main content area for the content area and all the pages that share the same sidebar include the same sidebar template

#

That would be the DTL solution for what we're trying to do

#

(It's the same as how all our pages include the same template for the top navbar area, just for a common side bar)

#

Including two different template systems into our app does not sound like the most straightforward solution, tbh

cold moon Oct 25, 2020, 11:01 AM

#

Okay, but then so there should be static sidebar from template, and then block that allow inserting page-specific sidebar blocks?

hardy gorge Oct 25, 2020, 11:02 AM

#

I think we don't have a common sidebar design that we can just insert a small bit of data

#

We want different kinds of sidebars for different pages, which means we'd need to have some kind of template for those anyway

#

If we want a common side bar, say for all events, we could insert context data for the template and render it that way

#

using template iteration

cold moon Oct 25, 2020, 11:04 AM

#

Actually yes, there isn't common elements for every page sidebar.

hardy gorge Oct 25, 2020, 11:05 AM

#

What do you mean?

#

Anyway, I much prefer to use one templating system instead of two in our relatively small web application

cold moon Oct 25, 2020, 11:05 AM

#

I thought that this upcoming event is in every sidebar, but it isn't.

hardy gorge Oct 25, 2020, 11:06 AM

#

That wouldn't be a problem with DTL, right?

cold moon Oct 25, 2020, 11:07 AM

#

Yes. My original idea was building sidebars with dictionary and for this DTL doesn't work

hardy gorge Oct 25, 2020, 11:07 AM

#

You can create template for an upcoming events box, make sure it has the context data to render the template, and include it

cold moon Oct 25, 2020, 11:07 AM

#

So own template for upcoming events, own template for relevant links etc?

#

And also, where should event pages be? In root templates folder or app templates folder?

cold moon Oct 25, 2020, 11:54 AM

#

Also, will event guides, rules etc. pages handled by content app or by events app?

patent pivot Oct 25, 2020, 12:03 PM

#

content I would assume

cold moon Oct 25, 2020, 12:33 PM

#

But same time some of these pages is connected with specific event, like per-event rules?

cold island Oct 25, 2020, 12:35 PM

#

Sounds like the distribution is basically something that is generally relevant over a prolonged amount of time, and something that is relevant only to a specific event

cold moon Oct 25, 2020, 12:35 PM

#

And they have sidebars too

green oriole Oct 25, 2020, 12:41 PM

#

Can't we just have subfolders? lemon_thinking

cold moon Oct 25, 2020, 1:10 PM

#

Yes, I plan using subfolders for events app

green oriole Oct 25, 2020, 1:34 PM

#

I don't see the issue then

eternal owl Oct 25, 2020, 4:06 PM

#

any reason we are not sending the error response msg to the user?

📎 unknown.png

#

if we make our site 400 responses consistent, we can parse them and send it
example:
all 400 responses can be of this format:

{
field: [error message],
field2: [...]
}

and then parse this on the bot site and send it in the channel

green oriole Oct 25, 2020, 4:38 PM

#

What is that?

#

the site API wrapper?

eternal owl Oct 25, 2020, 4:51 PM

#

the bot error handler for site API responses

#

https://github.com/python-discord/bot/blob/master/bot/exts/backend/error_handler.py#L237

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

cold moon Oct 25, 2020, 6:30 PM

#

Huh, events dewikification was really simple.

patent pivot Oct 25, 2020, 7:51 PM

#

there is some actual code at https://github.com/python-discord/forms-backend now 😃

GitHub

python-discord/forms-backend

Backend for Python Discord forms. Contribute to python-discord/forms-backend development by creating an account on GitHub.

tawdry vapor Oct 26, 2020, 5:28 AM

#

I need reviews on this https://github.com/python-discord/bot/pull/1245

GitHub

Store the bot instance as a global variable by MarkKoz · Pull Reque...

Is very convenient when writing utility functions that rely on the bot's state, but aren't in cogs and therefore lack the typical way to access the instance. No more passing around ...

#

I'm concerned it's turning into bikeshedding

#

I have another PR to refactor help channels which is based on this

glass pecan Oct 26, 2020, 6:10 AM

#

@tawdry vapor Sorry, I didn't see this ticket. In a branch I'm working on, I actually kinda already made an importable reference to bot from anywhere, but it's different from the proposal that you were laying out in your PR.

#

Since this is something you were touching already, I'll stop what I'm doing and discuss first.

#

For reference, the solution I was going to go with was a class attribute on Bot: literally Bot.instance

#

which would be redefined on __init__

#

I 100% agree though on the convenience of some form of importable reference to the instance, as it's stupidly annoying having to pass a single reference of bot around that will never change into a whole bunch of utility tools.

tawdry vapor Oct 26, 2020, 6:37 AM

#

That's not bad I suppose

#

Would avoid import changes but I've already done the work

sour sierra Oct 26, 2020, 8:42 AM

#

I assume this should be ready for merging now- https://github.com/python-discord/seasonalbot/pull/496

GitHub

Fix candy mini-game to group leader-board scores correctly by quant...

Relevant Issues

Closes #495, #477 and #284
Description

The older code was storing candy spawn information in the json, which I think is unnecessary. I have replaced it all with two sets- candy_m...

late wolf Oct 26, 2020, 12:07 PM

#

What is snoflake?

green oriole Oct 26, 2020, 12:12 PM

#

It is the way discord (and originally Twitter) IDs are made

dusky shoreBOT Oct 26, 2020, 5:37 PM

#

GitHub

IssueOpen [seasonalbot] #412 Update help command

cold moon Oct 26, 2020, 5:48 PM

#

🎉 And events app is ready! Time to open PR.

green oriole Oct 26, 2020, 5:51 PM

#

Noiiice

cold moon Oct 26, 2020, 5:53 PM

#

I hope this get merged sooner than content app, as this don't have so much logic in views, basically loading templates.

green oriole Oct 26, 2020, 5:54 PM

#

You should mention it on the PR then

cold moon Oct 26, 2020, 5:58 PM

#

And I think events app issue is not worth advanced level. This was really easy to do.

green oriole Oct 26, 2020, 6:03 PM

#

The difficulty levels are just indicators, that's not an issue