I think it doesn't work if the number of elements in the split are the same
#dev-contrib
hardy gorge
tough imp
it also allows subcommands to bypass checks on the group
i.e. if the group is mods-only and you decorate it with invoke_without_command=True, subcommands will entirely bypass the group callback
it's documented but annoying
well, I found it annoying
hardy gorge
Hmm, right
It does work, though. There was some other error I was experiencing
from typing import Union
from discord.ext.commands import Cog, group
class Emoji(Cog):
def __init__(self, bot):
self.bot = bot
@group(invoke_without_command=True)
async def emoji(self, ctx, emoji: str) -> None:
await ctx.send(f"Received {emoji}!")
@emoji.command(name="count")
async def count(self, ctx) -> None:
await ctx.send(f"count!")
bot.add_cog(Emoji(bot))
That has the desired API (.emoji <emoji> for emoji info and .emoji count for the count)
green oriole
ctx.invoke bypass checks, right?
tough imp
so if you annotate emoji as discord.Emoji, it won't try to convert it unless a non-subcommand was given
green mesa
I like ves idea
green oriole
Yeah, it doesn’t
hardy gorge
I haven't looked into the command parser, but I imagine it tries to match the longest fully qualified command first
and then having leftovers as potential arguments
green oriole
invoke_without_command: Indicates if the group callback should begin parsing and invocation only if no subcommand was found.
Sounds like it does
neon garnet
I'm all for a unified emoji cog
green mesa
@neon garnet 
waiting for your example embed is it ready
neon garnet
I'm busy with irl responsibilities, might not be able to work on it for a day or two
Please be patient, I'll get back to you as soon as I can
green mesa
ok
neon phoenix
i am really bad making things aesthetic, what can i do to make this better?
obsidian patio
I think only the emoji name as title would be nice (capitalized)
stable mountainBOT
Desktop
Web
Mobile
neon phoenix
emoji_information.add_field(
name="General information",
value=textwrap.dedent(f"""
Emoji name: {emoji.name}
Emoji ID: {emoji.id}
Created at: {emoji.created_at}
Animated: {'Yes' if emoji.animated else "No"}
"""),
inline=False
)
The created date should preferably be a human readable format
neon phoenix
pydis-bot has datetime to user readable but seasonalbot not
green oriole
Well, you can just copy paste it
neon phoenix
well, yeah
I will make it a staticmethod
green oriole
You could put it in the utils tbh
obsidian patio
Maybe “Created: X years Y months... ago” would be better for the date
green oriole
Also, no need to repeat “Emoji” for every field
obsidian patio
The general info header is probably overkill as well
obsidian patio
Also, how are we doing with the emoji cdn link?
obsidian patio
Alright
@green oriole considering that it’s in an embed and that admins+ manage emojis, I don’t think there’s really a need for code blocks
green oriole
It is just for the look of it
obsidian patio
In the title?
green oriole
Yeah
obsidian patio
I’m not sure that would look good. Unless we include something other than the emoji name
Like this:
green oriole
Well, there’s already another text
obsidian patio
Emoji info: lemon_xd
I was thinking about if we should remove the other text
Like just having the emoji name in the title
neon phoenix
(ignore the ID, i fixed that)
obsidian patio
!role Developers
stable mountainBOT
neon phoenix
i can't make the footer a clickable link though
green oriole
You can click the image on mobile, can’t you?
neon phoenix
nope
green oriole
Sad
neon phoenix
the only thing i could do is to make the title a clickable link
like emote
oh wait
actually...
obsidian patio
I think something like “Emoji info: emoji_name” may be a better title
green oriole
Maybe you should add a Source: [link](cdn_url) field
obsidian patio
The idea of only including emoji name may be a bit odd, and I want capitalization
hardy gorge
Is that CDN link clickable?
green oriole
That’s good
neon phoenix
no, sadly
hardy gorge
Why not?
hardy gorge
It's an embed right, you can use markdown
green oriole
Although can you change the cdn link like I said?
hardy gorge
or is it the footer?
neon phoenix
footer
hardy gorge
Is the thumbnail clickable?
green oriole
Not on mobile, apparently
neon phoenix
i got the solution
green oriole
And I don’t think making mobile user copy the link by hand is a good idea
Maybe you should add a Source: [link](cdn_url) field
neon phoenix
yeah i am doing that
cold moon
@neon phoenix I think these keys in this embed (created, name, animated) should be bold.
neon phoenix
i got the solution
green mesa
Atie I think your issue will cover emojicount also
neon phoenix
@cold moon yeah sure
green mesa
So I think we don't need to recreate same thing again
neon phoenix
green oriole
No, they shouldn’t be bold, that’s not our embed style
don’t make it an actual link though
Use markdown
Like that [link](https://.../)
green mesa
Add command which can search for groups also
green mesa
I like this one ,it looks clean
green oriole
CDN: Link to match the style
short snow
looks nice! just use dark theme instead
neon phoenix
nah thanks
green oriole
-_-
green mesa
👀
neon phoenix
green oriole
Now remove the line break please
neon phoenix
The CDN link was supposed to be the footer, but the footer didn't accept markdown, so that's why i made a newline there to recreate the footer :|
green mesa
In footer we can't add link I think
neon phoenix
@green mesa #dev-contrib message
green oriole
Well, I understand, but it doesn’t work in the footer, so you gotta make it an actual field
green mesa
One more thing people don't remember name like oh think and all
neon phoenix
green mesa
it will be great if u group them through category as functor said in pr
neon phoenix
it is a group
@commands.group(invoke_without_command=True)
async def emoji(self, ctx: commands.Context, emoji: Emoji) -> None:
"""Returns relevant information about a Discord Emoji."""
short snow
you make a server thumbnail down or the person who asked thumbnail down
green mesa
Here logo is category
So people can just search from category
And they can get list of emoji
And they can choose from it
Same like wiki command
And bot will show the embed
just an idea if u like
isn't that your pr lol
green mesa
Actual mine and your pr is almost same
green oriole
I like this embed
green mesa
Mine is subcommand to your issue
green oriole
I’m curious about what @obsidian patio think
neon phoenix
imagine someday an emote gets deleted, but someone used the .emoji command prior its deletion
the thumbnail won't work anymore
sooo
why not convert quickly the asset into a stringio?
green mesa
well it will happen once in a blue moon😅
green oriole
Because you have to re-upload it and such
green mesa
So I don't think we need to worry
green oriole
Don’t think that’s necessary
green mesa
Tomorrow I will start working on source command pr 🙂
green mesa
Now it's look awsome
neon phoenix
okay, annd
how would i invoke a command?
so both .emoji and .emoji info will work
same thing as !d and !d get
green oriole
Yeah, that’s the goal atie
green mesa
😁 py bot helps
green mesa
Gg
neon phoenix
i needed to add another file though (human readable timedelta)
green mesa
Use union also
obsidian patio
I’m curious about what @obsidian patio think
@green oriole what part?
green mesa
So it will accept emoji+str
neon phoenix
Use union also
@green mesa for what?
there is no need
Emoji will try to convert the parameter to emoji
green oriole
@obsidian patio the embed format
neon phoenix
green oriole
Does it work if you directly use the emoji?
neon phoenix
yes
obsidian patio
I think the fields should be in this order
- Name
- Created
- ID
- Link
neon phoenix
well, the linter is broken 🦀
i pipenv install --dev i swear
i get Passed even if i inserted 10 lines on the code
short snow
@neon phoenix what happens when you put default emoji?
green mesa
It will not show date I think
obsidian patio
And I think the last link should be something like this:
Image source
That would be one single link
green mesa
And source also
short snow
can you see what happens ?
green mesa
I think it will be passed as str not emoji
neon phoenix
@short snow error
short snow
😛
green mesa
So u can handle that and say default emoji or something
neon phoenix
well, but why i should do that
obsidian patio
@neon phoenix does that sound good to you?
neon phoenix
if i detect if it's a string, what should i do? if i raise badargument there is no need because discord.py will already do that
@obsidian patio sorry, what? i wasn't looking at the chat
obsidian patio
Check my last two messages
green mesa
I think there is now way to detect it's an default emoji unless u write regex for that
obsidian patio
I think having a single link for it would be better. Partially because “image source” or similar is clearer and partially because a single link seems to make more sense
@green oriole what’s your thoughts on this?
green mesa
emoji source?
green oriole
I agree
neon phoenix
wish there was a way to detect the most abundant color on the emote so you can set a better embed color
for example, ohtnk is mostly yellow
but there is no way to detect that
green oriole
Well, we have Pillow, you can take the median color
neon phoenix
but >>>blocking and >>>>slow
brazen charm
Can't image images so small taking a considerable amount of time, and there's always threading
neon phoenix
okay, so, how would i install packages without breaking something?
green mesa
pipenv install pillow
obsidian patio
Pillow is already included in SeasonalBot iirc
green oriole
Which package? Pillow is already included
green mesa
Oo yeah for 8bitify
neon phoenix
ah PIL
obsidian patio
.snake snakify hello
dusky shoreBOT
Vestergurkan#0585
neon phoenix
dunno man but in stackoverflow the snippets to get the medium color are quite large
brazen charm
If it's too much trouble bro implement, the embed color really isn't important imo
obsidian patio
I think having a standard color would be totally reasonable
green mesa
Use green then
green oriole
What’s the usual default color for seasonal
green mesa
Yeah our seasonal bot
green mesa
For valentine I am going with pink
obsidian patio
I think we may want to clean up the embed color use @green oriole
And have a convention
green mesa
WoW
green oriole
We need conventions in general for seasonal tbh
obsidian patio
I’m thinking more per event. Errors are red, standard is green etc
neon phoenix
so green or blurple???
green oriole
Blurple
green mesa
I like the colour of pydis core dev role
green oriole
That seems to be what is used right now
obsidian patio
Yep
neon phoenix
so, grind hard to get it @green mesa
obsidian patio
Hahah
green mesa
Yes I am trying to contribute regularly to seasonal repo😁
green oriole
I have way too many green rn
obsidian patio
Core developer requires being a staff members, so being only contrib and core dev isn’t possible
green oriole
Yeah, sure
cold moon
My dream is getting mod role in this server... And core dev too
obsidian patio
You should preferably commit atomic changes while you work on it
obsidian patio
If you’re unsure about the term atomic, check out the latest ping by ves
cold moon
This is little bit hard to make atomic commits for me, because I don't want to commit things that not work perfectly (or at least I think everything works well)
green mesa
Oopsy wrong ping again vester
obsidian patio
Read through the pin from ves. It’ll make things more clear
green mesa
Same here ks
hardy gorge
Making atomic commits is difficult. Writing good commit messages is difficult as well.
obsidian patio
And things don’t have to work in every iteration. It’s about committing every atomic change
green oriole
I wonder if you could consider https://github.com/python-discord/bot/commit/aeaa3dd75a96fb8e8f66556e17d7759be1d59631 as atomic
I don’t think spitting it more would have been a better idea though
hardy gorge
I'm not familiar with code spaces, but it looks like you need everything in there to set up that feature
So, splitting it up would not really be a good idea
But say that you're working on our roles command and you want to do two things:
- Allow helpers to use it
- Introduce fuzzy matching
Those two things sound like two different features, two different sets of changes that go together
If you have to implement the fuzzy matching from scratch, you may even split that one up further
- implement fuzzy matching
- Add fuzzy matching to role command
(assuming that fuzzy matching is not an incredibly difficult and multifaceted feature in and of itself)
green mesa
I really wnt to have one tag realted to atomic commits
hardy gorge
I think it's something that is better captured by articles and it's subjective
hardy gorge
A good start is by writing good commit messages
neon phoenix
i readed the "how to write good commit messages" article from the CONTRIBUTING.md file
hardy gorge
If your summary line suddenly needs to include multiple features all in one summary line, you're probably doing too much in that commit
Basically, can you summarise what you've done in one clear, 50 character sentence
With a more detailed body below that
green mesa
Ok
neon phoenix
how do you write bodies within the cli git?
i only know how to make messages, but not long descriptions
hardy gorge
just do git commit and it will open up your configured editor
neon phoenix
ah okay
hardy gorge
So, without the -m flag
obsidian patio
I’ll review the PR later today @neon phoenix
neon phoenix
okay
hardy gorge
It probably defaults to your default CLI text editor, but you can specify other editors
neon phoenix
nano is my default editor
hardy gorge
I used to use Sublime for mine, but I'm just lazily using nano now because I didn't bother changing the config after my latest fresh install of ubuntu
green mesa
mine is vsc
hardy gorge
It doesn't have to be a CLI editor
neon phoenix
but still, cli is better (specially nano) because you write your message, and then ctrl x y
instead of a window opening up for a long time
hardy gorge
I don't like Nano that much because it's more difficult to spot the current line length
thorny obsidian
(I also super recommend gitkraken for looking at and managing commits, although I do write my commits from VSCode directly)
hardy gorge
I've got wrapping and warnings set up in PyCharm to make sure to keep my summary line within 50 chars and my body within 72 chars
green mesa
Site gives json response?
green oriole
I know this is a thing, but I’m not sure if it can be used here https://github.com/wimglenn/advent-of-code-data
green mesa
One more question can we work on 3-4 issue at once?
green oriole
At the same time? Not really..
obsidian patio
I’d strongly recommend not doing that. If you can’t manage completing one, why open 3 more?
“Can’t manage” as in “haven’t completed yet”
green mesa
Ohk I will try to get my 2 pr merge tomorrow
As emoji info can show info about emoji I think I should make emoji count it's subcommand
green mesa
Ok so for emoji count I will wait for atie pr to get merged first
Then I will start working on that
obsidian patio
Are you assigned to the emoji count issue?
green mesa
Yeh
obsidian patio
Adding it as its own command as a start wouldn’t be too bad, but I think it’s fine if we wait with it until Atie’s pr is merged
neon phoenix
@green mesa the checks didn't even pass at all
fix your errors
bot/exts/valentines/valentine_zodiac.py:109:38: E999 SyntaxError: invalid syntax
green oriole
Hah
green mesa
@neon phoenix I know check the last commit
That I have accepted suggestion today
I have to fix that issue and do some cleaning of code
That's it
cold moon
~~Why this is so hard to find issue to solve ~~
green oriole
What would you say about doing some reviewing instead @cold moon?
It seems to be the current bottleneck in our development cycle, and I think you'd be perfectly capable of doing a proper review
cold moon
Okay, I'll do it after I finish something I found: Cowboy lemoji (there is special issue about it)
thorny obsidian
@cold moon i think Xith was working on that. You can check it out in #dev-branding
obsidian patio
@green oriole I don't like how it looks in a code block
Quotes are probably better
obsidian patio
Yeah. I commented that already
What do you think about this compared to setting the attributes one by one? ```py
emoji_information = Embed(
title=f'Information about "{emoji.name}"',
description=textwrap.dedent(f"""
Name: {emoji.name}
Created: {time_since(emoji.created_at)}
ID: {emoji.id}
Emoji source image
"""),
color=Color.blurple()
)
I think setting them one by one is what caused the vertical embed issue on mobile, but I'm not sure
brazen charm
I need to bring over the sphinx license https://github.com/sphinx-doc/sphinx/blob/3.x/LICENSE but unsure how to handle it because it refers to the authors file. Also copying the authors file doesn't make much sense, but the license will be referring to something that doesn't exist in the scope of the project. Should it be copied over verbatim? Asked around on the sphinx IRC a few days ago but didn't get an answer
obsidian patio
Hmm... strange
green oriole
We redistribute sphinx in one of our project?
brazen charm
I'll need it for 1067
green oriole
.issue 1067 bot
dusky shoreBOT
patent pivot
lol
legal
license legal is not my cup of tea really, so I don't know loads about it
green oriole
I feel like you're the most legal related person in the whole team lol
patent pivot
I think it was @tawdry vapor who last looked at licenses for something similar? with the ipython stuff
eternal owl
hey @cold moon, thanks for the review on my site PR, can you also look at https://github.com/python-discord/bot/pull/1165
since its directly related to it
Im still kinda looking for suggestions on this
cold moon
I can look into it tomorrow
eternal owl
okay 👍
a little confused with the reddit cog in @stable mountain
here we set the default amount to 25, and this function is being called only once from another function which also takes in an amount but the default there is 5
get_top_posts is the only function that calls the fetch_posts function
why do we have default values for amount in both the functions and of different values?
why don't we just have the default set in the get_top_posts function
eternal owl
\o/
cold moon
So jams will be not managed from site in future?
eternal owl
please tell me you have plans to change the landing page UI
patent pivot
this app is primarily for insights, which will be our version of jetbrains developer survey, digitalocean currents, etc.
eternal owl
of the forms website
patent pivot
lol, I mean
cold moon
I'd really like to build jams system
patent pivot
colours are straight from Discord, open to altering them though
cold moon
I think there should PyDis logo in header?
patent pivot
that was @celest charm, who very much liked the two curves lol
eternal owl
maybe the purple can be darker
patent pivot
better rounding?
eternal owl
lesser border-radius
patent pivot
that Sign in with Discord button will go btw
right, that is less, I was asking if it was better
or even less
eternal owl
ye this perfect
patent pivot
thorny obsidian
(I liked the better rounding? one more)
eternal owl
or even less
@patent pivot this
patent pivot
hmmm
patent pivot
better rounding? was 10px, then next was 5px and then 7.5px
eternal owl
5px
thorny obsidian
I think 5px is too small, 7.5x+ looks fine to me
eternal owl
better than the current one
patent pivot
also yes, a pydis logo would be nice, however I have no idea what font we use and whether we can put it on a webpage
the answer is probably
maybe
one sec
eternal owl
i really like the white and blurple on our main website, maybe we can try the same?
thorny obsidian
For the video we used Uni Sans, which should be fine to use
patent pivot
i really like the white and blurple on our main website, maybe we can try the same?
hm, we can, however my original goal was to try mimic discord colors a bit
uni sans does look fine to use, no CDN by the looks of things though
let me find a TTF
eternal owl
go we goin for a darkish theme?
cold moon
Now bit out out of topic from current discussion but do we have any plans about jams implemention in site?
eternal owl
like forms, u mean?
patent pivot
Now bit out out of topic from current discussion but do we have any plans about jams implemention in site?
@cold moon not really, I think it is an admin task in need of claiming
like forms, u mean?
@eternal owl forms will probably not be used for code jams
eternal owl
kay
patent pivot
it might, depending on how exportable the data is and such
eternal owl
guess I will have to learn react to contribute to forms :/
cold moon
I have some ideas for jams in site, should I make issue somewhere with prototype HTMLs?
patent pivot
guess I will have to learn react to contribute to forms :/
@eternal owl depends on what you want to contribute, styling is fairly straightforward providing you find the component
I have some ideas for jams in site, should I make issue somewhere with prototype HTMLs?
@cold moon let me get back to you on this one
by get back i mean like 3 minutes
eternal owl
i started learning vue a few days back, and thats my first framework, lol
I can help with styling, lemme see if I can come up with a design
patent pivot
sure thing
Okay, we have an internal issue for code jams and it is blocked right now while we figure out what we want codejams to be like. Wait until we've finished this jam and we'll pick that idea upp.
cold moon
Okay
eternal owl
is this a go?
https://github.com/python-discord/bot/issues/1172
eternal owl
whats the font-family for python discord forms
patent pivot
uni sans in that screenshot
one second
I'm just going to open a PR and then I can get a staging deploy for you
okay, give netlify a second and it'll fire up a staging copy
lol so many PR checks
sad no one saw my awesome console work
thorny obsidian
mmmmmm Python Discord Forms is not centered vertically properly
patent pivot
in the console or the actual site
thorny obsidian
the thing you just posted
patent pivot
okay phew
file bug report with google lol
I have no idea why it is doing that
I could actually just spit out a banner image
thorny obsidian
It looks like it's taking the entire text (including the y dipping down) and centering that, vs centering based on characters that don't drop down below the baseline
eternal owl
this is how discord does the curves on their website
just 2 colors
they go from white -> dark in the starting and then dark->blurple in the end, looks good, we can do similar
patent pivot
we had that originally
and staff said they preferred the two colours
so you want dark to blurple instead of blurple to darkk?
blurple background will not be pleasant
eternal owl
how about centering?
we can also add some cool hover effects
scale() being one of my favorite
patent pivot
ignore the colour, but this is one wave
eternal owl
that is much better
thorny obsidian
Could you do two waves but keep it two colors?
eternal owl
ye that could work
patent pivot
remove the opacity?
eternal owl
ye, just 2 solid colors
patent pivot
patent pivot
eternal owl
i meant, centering the forms
and reducing the width
like I showed in the video example above
patent pivot
hmmm
we could? i think the left alignment is nicer considering this list could grow considerably
i'll try it, one sec
eternal owl
#available-forms {
height: 100vh;
padding-top: 20px;
color: white;
display: flex;
flex-direction: column;
align-items: center;
justify-content: space-around;
}
#available-forms h2 {
font-size: 40px;
font-weight: normal;
}
.form-indicator {
background-color: white;
color: black;
padding: 30px;
border-radius: 5px;
margin: 20px 0;
transition: 0.3s;
}
.form-indicator:hover{
transform: scale(1.1, 1.1);
}```if u need it ☝️
#available-forms is the whole forms section and .form-indicator are the forms
eternal owl
kay
thorny obsidian
I like the side padding, but I don't think the header needs to be centered
eternal owl
can we have forms on a new line?
patent pivot
we can, but it won't scale very well responsively
hmm
maybe it will
one sec
no, the waves won't really work with that
eternal owl
k
patent pivot
thorny obsidian
mmm that looks nice
eternal owl
u say available forms and there is a closed form, lol
patent pivot
hmmm yeah
that probably wouldn't be there in prod, that is for the staff side of things
eternal owl
the green and white don't really go together, maybe a bit darker shade of green
patent pivot
but it does mean that the big green box may not be appropriate for the user facing thing
green is #43b581, I'll try darken it now
brazen charm
Is the green a general color for available ?
eternal owl
if you're using vscode, it can open a color palette which is really handy
patent pivot
lol, not from this it can't
Is the green a general color for available ?
@brazen charm yeah, I did have green and red but holy schmuck that was bright and colourful and hard to understand
maybe this
eternal owl
try this #2E8B57
patent pivot
hmmm
doesn't fit with the otherwise light colour palette imo, needs to be a touch softer
#349E62
brazen charm
Would a lighter greyish color be fitting? Light for active and muted for inactive
patent pivot
greyple is already registered in the colours file
bear in mind
users won't ever see the muted one
so I'll probably just use the darker colour and no tags
like this
the greens will only ever be displayed to staff member
so I think it's probably fine for now
pushing my changes
deploying
eternal owl
how simple is this
ignore the white color
the nav bar is actully blurple, idk why my ss changes it
patent pivot
deploy preview updated for my latest changes https://deploy-preview-9--pydis-forms.netlify.app/
I think that is a cool style but a little dull, this is a pretty small app and there is some freedom to explore things other than boxes
eternal owl
maybe a curve between the blurple and the dark background
patent pivot
merging that PR now
thanks for the feedback y'all
live now https://pydis-forms.netlify.app/
eternal owl
cool
patent pivot
I did add those hover animations as well in case you didn't notice :)
brazen charm
For the license, can the project have a non working revision without a license in the commits?
patent pivot
I added some transition effects to the forms app for going between pages https://pydis-forms.netlify.app/
AB of 50% for which effect you get, either the fade effect or the fade + scale effect, check your console to see which one you are on (a red branch with animation/scale-transition-effect means you are on the AB). Remove the nf_ab cookie and reload to try flip to the other AB.
also AB is cool and I'm kinda just fanboying over my deployment tool that I can actually do this
green mesa
V 1.5.0 of d.py has been released
It has voice and allowed mention update
Should we update our pipfile and lock file?
neon garnet
Sounds like we'll need to anyways
sullen phoenix
yes, we were planning to update already
green mesa
Ok
green mesa
For seasonal bot help command we can add ℹ️which will show the info about reactions and 🔢 which will ask for page number
But this idea will collide with r.danny
Can we have this or we need something new 😅
hardy gorge
Should we update our pipfile and lock file?
@green mesa
It's typically not that simple. We'll need to update the version, but also make sure the bots still work properly with the new versions. This specific release includes things we'll have to change (including the main thing, the intents) before we can update.
green mesa
Ok
green mesa
!source get
stable mountainBOT
Sorry, an unexpected error occurred. Please let us know!
AttributeError: 'NoneType' object has no attribute 'callback'
green mesa
bug found
stable mountainBOT
green mesa
@nocturne hare thinking of doing this way, any suggestion or idea about this, so others can know what all zodiac sign are compatible with which one
user can choose number from list and bot will show the info about this or if user dont give 4th parameter then, bot will choose random zodiac sign from list for compatiblity
stable mountainBOT
sullen phoenix
exception won't work either
nocturne hare
What exactly does .zodiac virgo or .zodiac date september 15 give atm @green mesa ?
green mesa
nocturne hare
Aside from the Full form first letters looking kinda sketch with the underline (or the last one not having an underline) that's more or less the full scope of the issue you're working on.
I'd worry about polishing that before extending the scope of your pr.
Ultimately it's already feature creeped the issue by quite a bit, since the issue only wanted to be able to fetch zodiac from dates, or dates from zodiac.
(I'm not saying it's bad, what you've done. Just that you should finish it before starting something new)
green mesa
Ok
nocturne hare
Just out of curiousity. What does it look like without the in_line=false on the fields.
green mesa
I think it might make embed look messy
nocturne hare
May i see?
green mesa
Actually I just closed my laptop 😅
nocturne hare
Mkai, I'm just thinking that the embed is some what big
green mesa
Hmm ok tomorrow I will try this
nocturne hare
Maybe if you one line the fullform, but keep the bold/underline of the first characters?
green mesa
I can try this
neon garnet
@green mesa I should be able to roll out an example in a few hours, stay tuned 😄
sharp timber
green mesa
sullen phoenix
i think you've missed the point, Anubhav
green mesa
Oopsy
sullen phoenix
we already know <> works, we're testing out []
neon phoenix
when sending a POST request at snekbox, i get this error: ERROR | Couldn't launch the child process
the error code is 255 as well
why is this happening?
green oriole
Interesting, NsJail is probably failing
neon phoenix
i did sudo dockerd at the beginning
then, i ran sudo docker run --ipc=none --privileged -p 8060:8060 pythondiscord/snekbox
like the readme said
then, i ran ```py
x = requests.post("http://127.0.0.1:8060/eval", json={"input": "print('hello')"})
x.json()
{'stdout': '', 'returncode': 255}
Sorry, I was reading the source code, can you try lowering the logging level to debug and send us the log?
neon phoenix
how would i do that?
i am running the image directly
if that's a problem
huh
now it works
did this happen because i ran it for the first time?
https://paste.pythondiscord.com/azokihamog.makefile when i ran it for the first time
https://paste.pythondiscord.com/xepunacize.cs when i ran it now
green oriole
My best guess is that the cgroups weren't ready
green oriole
Snekbox?
Weird
slim-buster can't be that big
Nah, there's no way, the codespace universal is 2Gb, and it is like Ubuntu plus 20 fully featured languages
green mesa
Is snekbox coded by pydis people from scratch?
brazen charm
What would from scratch be here? snekbox's source isn't very big because there are good tools available to rely on, which were made by bigger groups
patent pivot
Is snekbox coded by pydis people from scratch?
@green mesa we use external tools, but yeah, we made snekbox
eternal owl
I am interested in working on this
https://github.com/python-discord/bot/issues/1172
and the related site issue too if its good to go.
subtle kraken
I can assign you @eternal owl
Though am pretty sure site has to be done & merged before bot
eternal owl
Wait, I made a comment suggesting a few changes, I haven't heard back from the author
subtle kraken
Joe liked your suggestion so thats fine by me
eternal owl
Kay even I thought the same, but just confirming
sullen phoenix
i like the idea as well
subtle kraken
You can always ask @cold island before you actually start working
subtle kraken
May you comment on the issue on site?
Cant assign non contribs
Or so github doesnt display you
eternal owl
Okay
eternal owl
You too, I'm heading to bed, gn
cold island
👍
vocal wolf
.issue 1187 bot
dusky shoreBOT
vocal wolf
@tawdry vapor now that 1.5.0 has been released, I think this issue should be reopened. Thoughts?
sullen phoenix
k is already working on it
vocal wolf
ah
sullen phoenix
vocal wolf
I'm too slow
tawdry vapor
Yes it has to be changed for 1.5 since it's a minor version change. The current specified only permits patch version changes
eternal owl
1 more day for hacktoberfest 👀
neon phoenix
👀 epic
eternal owl
will the current open PRs count for hacktoberfest ?
green mesa
Noice
green oriole
will the current open PRs count for hacktoberfest ?
@eternal owl as long as they are merged during October I think they count for the Hactoberfest t-shirt
eternal owl
kay
exotic ember
only pull requests created during October count
PRs opened before Oct 1 do not count even if they're marked as ready for review or merged during the month
eternal owl
can anyone do a quick review of this, I implemented the changes suggested by @brazen charm, its a very small PR
exotic ember
!remind 1h 
stable mountainBOT
eternal owl
ty kosa :p
stable mountainBOT
@exotic ember
It has arrived!
neon phoenix
eternal owl
@exotic ember you mentioned that the error handling should take place within the get_top_posts method, then how can I identify if the error was due to connection problems or couldn't find any SFW posts? or did you mean same error message for both?
exotic ember
Using the same error messsage should be fine, the wording could be changed to Sorry! We were unable to get any SFW... to maybe? reflect that
eternal owl
alright
ruby pulsar
so I created an issue, do I need to wait for the owner to approve it before making a pull req?
issue in question https://github.com/python-discord/seasonalbot/issues/464#issue-712052602
subtle kraken
well, not owner so to say, once anyone of the core devs/staff members accepts the issue you can work on it
ruby pulsar
okay, thanks
subtle kraken
I can look into it bit later
ruby pulsar
that would be great, thanks!
patent schooner
Hello there! I've been looking for improving my (pretty basic) Python skills and I just stumbled upon your @stable mountain bot project.
I'm going through your contributing guide and I've got a question. Do you mind if I ask it here? Thank you in advance 🙂
(moreover, English is not my first language, thus do correct me if I mess up!)
tough imp
this is a good place to ask
neon phoenix
for English not being your first language you write it quite well
patent schooner
Great, thank you! I'm having trouble with this part here: https://pythondiscord.com/pages/contributing/bot/#server-setup. Do I need to match perfectly the IDs of all the channels, roles etc in order to just run the bot?
Fact is I wanted to get my feet wet by working on the following issue..
.issue 1120 bot
dusky shoreBOT
patent schooner
@neon phoenix Thank you, much appreciated! 🙂
neon phoenix
and yeah, you need to match perfectly the ids of channels and roles
otherwise your bot will throw exceptions like not found and etc
patent schooner
@neon phoenix ok, I know it sounds dumb but I just wanted to be sure 🙂
timid sentinel
I think you could get away with missing out a few if you only needed it to work for a specific thing
patent schooner
@timid sentinel uhm I see. I just was looking to get the #reddit channel going
As to see if my changes were indeed working
subtle kraken
If you don't mind whole lot of errors which might make debugging harder, you could get away with just configurating reddit part
patent schooner
@subtle kraken Oh ok. As a matter of fact, I've already got a whole lot of errors (that's why I decided to ask for help). But, among those I got, there is this one that worries me the most
asyncio | ERROR | Task exception was never retrieved
[..]
ConnectionRefusedError: [Errno 111] Connect call failed ('172.19.0.5', 8000)
and.. [..] aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.web:8000 ssl:default [Connect call failed ('172.19.0.5', 8000)]
I'm using docker btw
subtle kraken
looks bit like as misconfiguration
can't say much as seasonal is quite bit inconsistent and I mainly look around /bot
green oriole
I actually got the same error this weekend, but I have to admit I didn't looked into it
patent schooner
Oh ok, I thought that the @stable mountain bot was delegated to updating the posts feed of the #reddit channel
Anyway, I'll keep digging into it. Thank you guys!
obsidian oxide
Can anyone please help me approve changes (I need one more approval) it’s my first ever contribution to open source
obsidian patio
Maybe I can have a look at it tomorrow, if it isn’t done already by then
obsidian oxide
Thank you!
obsidian patio
!remind 18h Review PR above /\
stable mountainBOT
ruby pulsar
Hey
So I opened an issue and got approval to work on it
and I'm done now
so like I can just open a pull request now?
I also noticed that someone made a commit to the repo while I had forked and cloned locally
obsidian patio
Wanna share a screenshot here first, so I can have a look at how it looks?
ruby pulsar
here's the link to the issue @obsidian patio https://github.com/python-discord/seasonalbot/issues/464
Ohh
do you want a ss of the code?
obsidian patio
I was the one who approved it. I mean how the embed currently looks
ruby pulsar
Oh okay
sec
@obsidian patio here it is
removed the full name and location, as discussed
obsidian patio
What’s up with the syntax highlighting of the description?
ruby pulsar
oh
its css lol
I'll get rid of it, idr why I put it there I intended to remove it
thought it added some contrast
okay, thats done
obsidian patio
I don’t think requested by is really nevessary
ruby pulsar
mhm so you want me to get rid of the entire author part?
obsidian patio
Yes. I think that would be the most consistent with current commands
ruby pulsar
ah right
I also noticed that someone made a commit to the repo while I had forked and cloned locally
This shouldn't affect anything right? I'm sorry this is my first pull req on github
brazen charm
You don't need to do anything unless the commits affected the parts of code that you modified
ruby pulsar
ah perfect, I didn't modify any existing code, just added stuff
So I'm good to go now?
obsidian patio
Wanna show another screenshot?
ruby pulsar
@obsidian patio
obsidian patio
I’d much rather see “PRs opened last month” or “total PRs”, than starred repos
ruby pulsar
I looked and there isn't a direct way to get the PRs of a user. I opened the issue in the first place since I had this idea of making a quick little command to get me started on github. My idea was that the command gives me a brief overview of a github user, and starred repos doesn't sound as bad to me, and would definitely be something that a user's overview should have, although I do agree that PRs might be a better option but quite frankly that may be well beyond my scope right now, sorry about that @obsidian patio
obsidian patio
Alright. Sounds fair to me
You may get reviews on your PR about it, but I think it should be fine
patent pivot
merged the transition changes on https://pydis-forms.netlify.app/ and also merged a PR to make the rendered forms dynamic https://github.com/python-discord/forms-frontend/blob/main/src/api/forms.ts
obsidian patio
Feel free to open a PR. The process will take a bit of time, since we really want to ensure great quality on all code in the codebase, and you’ll probably get an unexpected amount detail checking. Just telling you so it doesn’t come as a surprise 😄
!remind 18h Review PR /\
stable mountainBOT
obsidian patio
@ruby pulsar I’ll try to review it tomorrow, if I find the time
ruby pulsar
Feel free to open a PR. The process will take a bit of time, since we really want to ensure great quality on all code in the codebase, and you’ll probably get an unexpected amount detail checking. Just telling you so it doesn’t come as a surprise 😄
@obsidian patio Ohhh oh yea sure absolutely, thanks for the heads up
👍
obsidian patio
No problem. Good luck with your first PR
ruby pulsar
Hmmm
I'm getting this error
Error: the command flake8 could not be found within PATH or Pipfile's [scripts].
I'm on MacOS
obsidian patio
Have you followed the contributing guide?
ruby pulsar
pip3 show -f flake8 shows that its installed in /Library/Python/3.8/lib/python/site-packages
yes I did
code works with flake8 linting
obsidian patio
Including installing dependencies?
ruby pulsar
Not exactly sure what you mean by that, but I used the vs code command pallette and chose flake8 as the linter and fixed the formatting
I also did pre-commit install
Found a fix
obsidian patio
Nice!
ruby pulsar
I'll check back in tomorrow, its 3am for me now. Thanks a lot Vester!
obsidian patio
Sure thing. Glad to see you getting your first PR out there
patent pivot
https://github.com/python-discord/seasonalbot/pull/466 this is ready for a contrib review all done
patent pivot
cheers @brazen charm
sullen phoenix
hacktoberfest stats!!!
ruby pulsar
So all checks passed when I ran pre-commit against all files, but the checks by the bot failed anyways https://github.com/python-discord/seasonalbot/pull/465
glass pecan
are you sure you have all dev packages installed. the ones that got caught in the CI linting seem to be the extra packages, not plain flake8
you should have installed the pipenv packages with pipenv sync --dev
glass pecan
no
glass pecan
you never need to lock unless you change deps
glass pecan
if you get a prompt about needing to lock, it's likely you used pipenv install or pipenv upgrade instead of pipenv sync
if you don't get such a prompt, then don't worry
ruby pulsar
Oh no I didn't get a prompt to lock it
glass pecan
ok
ruby pulsar
How do I push a fix now? I tried to pushing the code to my fork but of course it said that everything's up to date. so like how do I commit to a pull request? Sorry this is my first PR
Do I need to make a change in my file so I can push?
green mesa
what command r u using for push?
And yes whenever u make successful commits then only u can push
sullen phoenix
these were the linting errors from your build @ruby pulsar https://dev.azure.com/python-discord/Python Discord/_build/results?buildId=8217&view=logs&j=5264e576-3c6f-51f6-f055-fab409685f20&t=70134e25-3a69-59fb-2ae4-55c2ab507b01
green mesa
f1re linting error are addressed by pre commit right
sullen phoenix
yes
green mesa
Then how he is able to push before passing check of pre commit?
glass pecan
are you sure you have all dev packages installed. the ones that got caught in the CI linting seem to be the extra packages, not plain flake8
this is why
how do I commit to a pull request?
@ruby pulsar you push updates to the branch your PR is attached to.
ruby pulsar
@glass pecan yes I just pushed, but the checks failed again
even after running pipenv sync --dev
glass pecan
what happens when you do pipenv run lint
ruby pulsar
hmmm, the last flake8 check failed on this one, weird because pre commit was working against all files
but the in built vs code flake8 linter doesn't point this stuff out
glass pecan
precommit only checks based on current diff pretty sure
might be why
anyhow, stick to using lint
check output and address each issue
then once it's clear, try again
ruby pulsar
on it
glass pecan
you can also cross-reference based on the link f1re sent above
since that link shows the output of CI results too
green mesa
@nocturne hare this is how its looking when i written full form in one line
and with inline true like this
i think i like more inline true one more
but inline true we have one problem we cannot see inline true on android
it shows like inline false only
i am thinking of skipping date and zodiac converter idea because my issue wnts me to make zodiac and date different command of partnerzodiac
.issue 414
neon garnet
@green mesa
neon garnet
I'm thinking setting the image on the top right to a random twemoji
neon garnet
no, it's the current time
green mesa
ohk
neon garnet
@green mesa, alternatively, there's this as well
green mesa
this looks epic
neon garnet
The image comes from the branding repository
Anyways, ping me if you have any other questions
Just noticed that invoking .cogs for @dusky shore doesn't bring up the fancy embed compared to !cogs for @stable mountain
@sullen phoenix Heya, mind if I make a quick PR?
sullen phoenix
we should probably get that fixed, yeah
that happens to all commands on seasonalbot
except for .issue and maybe a few others
sullen phoenix
okay, maybe not then? i just saw you test some things, pure
neon garnet
I assume this acts differently in @stable mountain right?
@group(name="extensions", aliases=("ext", "exts", "c", "cogs"), invoke_without_command=True)
async def extensions_group(self, ctx: Context) -> None:
"""Load, unload, reload, and list loaded extensions."""
await ctx.send_help(ctx.command)
yeah
glass pecan
i won't stop anyone from doing it, but i wouldn't really say it's a super necessary thing. just if you go there, please give it a truly nice user-facing upgrade lol
not to say you would, but I'm not sure we want to encourage things like single commands getting wrapped in discord.Embeds during hacktoberfest lol
bit of a low hanging fruit lol
neon garnet
Fair enough lol, how exactly does @stable mountain override the default behaviour though?
neon garnet
ah
glass pecan
seasonalbot hasn't migrated to the discord.py integrated HelpFormatter yet
that's totally something someone can work on if they want
it's a bit of a pain though because my help model (that seasonalbots was adapted from) wasn't exactly equal to HelpFormatter in api
neon garnet
I might have a go at it if I'm not busy for school, will have to study the inner workings a bit more though
glass pecan
sure thing
green mesa
i have one quick fix to statuscat command, it will work after this, actually api provide the image of all status code but http module doesnt provide for 425 and such so if we add list of valid status code which are not mentioned in http module we can fix the error
@neon garnet can i use get emoji link from pydis server
like atie does
but my emoji will be random
green mesa
okie
neon garnet
@glass pecan Should I start by looking into https://github.com/python-discord/bot/blob/403bb4940817002c75099a47eddfe48c5b279a76/bot/exts/info/help.py#L41?
green oriole
What is it all about?
neon garnet
I'm thinking of porting it over to @dusky shore for a nicer ctx.send_help
green oriole
Right, well, you can start there, sure
neon garnet
Should I expect any behavioural differences between the LinePaginator classes for the two bots?
green oriole
It shouldn’t be any different, but a fix/change from one of the bot could have not been ported to the other
neon garnet
I'll go and write an issue later so we could track it there as well
nocturne hare
@green mesa Use , as a seperator instead of |
__A__ssertive, __R__efreshing, ...
green oriole
Can you add a space after the , ?
green mesa
sure
nocturne hare
I like the look of that
(with a space)
What does it look like with a longer zodiac
Like the longest one
nocturne hare
It's not bad, and i'd imagine that would be huuuge with the previous version
green mesa
yeh i also like this
nocturne hare
Maybe rearrange them a bit? in the order of motto, strengths, weaknesses then the full form?
nocturne hare
What do you think about that?
green oriole
It would be nice if we could have some capitalization too
green mesa
for strengths and weaknesses?
green oriole
Yeah
green mesa
ok
nocturne hare
the G and P should be at least
Then you can push the version you like best, was just curious to the different formats
nocturne hare
Am at work, can look at it if i find the time
green mesa
ok
green mesa
i think i need to make like this
https://media.discordapp.net/attachments/635950537262759947/761100312508629012/unknown.png
bcz user may wnt to give multiple names at once
neon garnet
@green mesa You can add a special case for it I guess, if the user requests just one then the thumbnail can probably be used
green mesa
ok
late wolf
what does Mock Members mean
i saw a class called mock member and also classes called mock scragly and mock hemlock
subtle kraken
Unit testing related stuff
It probably also says what it is for
As well as you can judge by the files location
late wolf
sorry but i couldn't, that's why I was askking. But thx for the asnwer
neon garnet
Quick suggestion, maybe you could do a fuzzy search and send a suggestion to the user who invoked the command?
nocturne hare
Maybe it could include the date range on each zodiac, since you already have all that whitespace available?
green oriole
Also, how did you ordered them?
nocturne hare
that too would be a neat feature
green mesa
date
nocturne hare
Yeah, deffo include date then. Else it looks unordered
Unless it should sort by Name and be written as 1. Aries from - to?
green oriole
But you didn't start by the one from the beginning of the year, did you?
green mesa
ok let me order them by alphabetically
nocturne hare
While you're at it, can you change the log.info("Making zodiac embed.") on line 63 to trace?
green mesa
names are fetched from json directly
ok
one more thing i show the same error embed in partnerzodiac and zodiac
for zodiac date will look legit but for partnerzodiac?
nocturne hare
Something like py error_comp = "\n".join( f"`{i}` {name}: {zodiac['start_at']} - {zodiac['end_at']}" for i, (name, zodiac) in enumerate(sorted(self.zodiac_fact.items()), start=1) ) would sort and show date.
You could have a parameter for the function that toggles date or not, but i dont see a harm in knowing the date when doing partnerzodiac?
green mesa