#dev-contrib | Python | Page 63

obsidian patio Sep 22, 2020, 2:27 PM

#

Thanks @green mesa 😄

eternal owl Sep 22, 2020, 2:27 PM

#

oh yea, grats @obsidian patio

green mesa Sep 22, 2020, 2:27 PM

#

congo for core dev akrays

green oriole Sep 22, 2020, 2:27 PM

#

The callback isn’t valid anymore

#

You can just open a new webpage, and it should work again

#

Thanks, guys!

obsidian patio Sep 22, 2020, 2:28 PM

#

Alright. I tried to reload the page a couple of times before and it didn’t do anything @green oriole

#

Btw, that blue role actually looks good on you

green mesa Sep 22, 2020, 2:28 PM

#

yeh

green oriole Sep 22, 2020, 2:28 PM

#

thanks!

obsidian patio Sep 22, 2020, 2:29 PM

#

Got it working by opening a new tab, but is there anything that could be done about this issue?

green oriole Sep 22, 2020, 2:31 PM

#

Maybe we could redirect onto the main page, assuming it is supported by the library, I’ll take a look at it lemon_pleased

obsidian patio Sep 22, 2020, 2:31 PM

#

Alright, thanks

cold moon Sep 22, 2020, 3:51 PM

#

@green oriole Woah, you are now Core Dev... Congratulations! 🎉 ||I want to be too core dev and staff||

green oriole Sep 22, 2020, 3:51 PM

#

Thanks!

green mesa Sep 22, 2020, 3:59 PM

#

ks|| I wnt to be contributor and core dev no need of staff role||

eternal owl Sep 22, 2020, 4:06 PM

#

@green oriole Woah, you are now Core Dev... Congratulations! 🎉 ||I want to be too core dev and staff||
@cold moon me2 haha

#

@green mesa i commented a few more changes on ur PR

green mesa Sep 22, 2020, 4:10 PM

#

Ty buddy

#

I will try to make appropriate changes tomorrow

eternal owl Sep 22, 2020, 4:13 PM

#

no hurry 👍

vocal wolf Sep 22, 2020, 4:26 PM

#

@green oriole I see. Thank you for this info!

obsidian patio Sep 22, 2020, 5:02 PM

#

@sullen phoenix Could you elaborate on this comment?
https://github.com/python-discord/seasonalbot/pull/449#discussion_r492434403

#

I don't quite understand what you mean

polar path Sep 22, 2020, 5:11 PM

#

hey can anyone help me with setting up the modmail

#

i asked in it's orginal server but no resonse

#

and what is meant by py dis core developers?

short snow Sep 22, 2020, 5:12 PM

#

the people who contributed alllot to pydis projects

#

and now handle core parts of it

patent pivot Sep 22, 2020, 5:12 PM

#

hey can anyone help me with setting up the modmail
@polar path not really, we just run the docker image, we don't maintain the application

polar path Sep 22, 2020, 5:13 PM

#

ohh, ok

#

thx though

sullen phoenix Sep 22, 2020, 5:15 PM

#

@sullen phoenix Could you elaborate on this comment?
https://github.com/python-discord/seasonalbot/pull/449#discussion_r492434403
@obsidian patio i can elaborate in a little over an hour, after class

obsidian patio Sep 22, 2020, 5:16 PM

#

Alright. I may not be able to fix it toady, then (time zones, you know), but we'll see

sullen phoenix Sep 22, 2020, 5:22 PM

#

that's all good

#

okay actually, i have a few minutes now

obsidian patio Sep 22, 2020, 5:23 PM

#

Aah, perfect

sullen phoenix Sep 22, 2020, 5:23 PM

#

basically, all you need to do is move the extensions util file contents to the __init__.py

#

and replace the walk_extensions func

#

it should be relatively simple

obsidian patio Sep 22, 2020, 5:24 PM

#

So the walk_extensions should be removed completely? (old one)

sullen phoenix Sep 22, 2020, 5:24 PM

#

yeah, the new one should work with the extension loading

obsidian patio Sep 22, 2020, 5:24 PM

#

And the ext utils file should be deleted?

sullen phoenix Sep 22, 2020, 5:25 PM

#

yeah exactly

obsidian patio Sep 22, 2020, 5:25 PM

#

Alright. I'll have a look at it now

sullen phoenix Sep 22, 2020, 5:25 PM

#

awesome, thanks

obsidian patio Sep 22, 2020, 5:34 PM

#

Seems like we have a from bot import exts statement that's causing some trouble

#

That will import the file itself

mellow hare Sep 22, 2020, 5:36 PM

#

Someone doing a fix for it?

obsidian patio Sep 22, 2020, 5:40 PM

#

@mellow hare For what?

mellow hare Sep 22, 2020, 5:41 PM

#

The import issue you just mentioned

obsidian patio Sep 22, 2020, 5:41 PM

#

Aah

#

It's not a commit yet

mellow hare Sep 22, 2020, 5:42 PM

#

Ah, I missed that, sorry

obsidian patio Sep 22, 2020, 5:42 PM

#

F1re asked me to the contents of a file in a pr review

mellow hare Sep 22, 2020, 5:42 PM

#

Ah I see it now

#

Bleh, so many different usernames

obsidian patio Sep 22, 2020, 5:43 PM

#

Yep. Not sure about the reasoning behind it

mellow hare Sep 22, 2020, 5:44 PM

#

I have a hard time keeping tabs on whose Github name goes with which Discord person

#

I need to make a like... print out or something

patent pivot Sep 22, 2020, 5:44 PM

#

we could probably handle it through site

obsidian patio Sep 22, 2020, 5:44 PM

#

Aah, yeah. Mine is linked in my discord fyi

mellow hare Sep 22, 2020, 5:44 PM

#

Yeah I just don't want to have to keep going elsewhere to figure it out

patent pivot Sep 22, 2020, 5:44 PM

#

yeah

obsidian patio Sep 22, 2020, 5:45 PM

#

Yeah, reasonable

mellow hare Sep 22, 2020, 5:45 PM

#

Would be easier to just have a piece of paper in front of me where I can go "Oh, that's f1re"

obsidian patio Sep 22, 2020, 5:45 PM

#

Hahah yeah. You could always make a terminal command

green mesa Sep 22, 2020, 5:45 PM

#

.pr 453

dusky shoreBOT Sep 22, 2020, 5:45 PM

#

GitHub

PROpen [seasonalbot] #453 handled exception of ContentTypeError at search_wikipedia

mellow hare Sep 22, 2020, 5:45 PM

#

True

#

Or a bot command

green mesa Sep 22, 2020, 5:46 PM

#

Hemlock this pr is waiting for your review

obsidian patio Sep 22, 2020, 5:46 PM

#

ghuser gustavwilliam -> @obsidian patio

green mesa Sep 22, 2020, 5:46 PM

#

I have changed 1 thing only

mellow hare Sep 22, 2020, 5:46 PM

#

I'll check it out

green mesa Sep 22, 2020, 5:46 PM

#

Ok tnx

#

we could probably handle it through site
Yeh we can have option same as discord for GitHub

eternal owl Sep 22, 2020, 5:48 PM

#

maybe we should use our github names as nick?

mellow hare Sep 22, 2020, 5:49 PM

#

Eh, I don't want to force everyone to change just because I'm grumpy

green mesa Sep 22, 2020, 5:49 PM

#

That will be good but some has 2 id

eternal owl Sep 22, 2020, 5:49 PM

#

in my case, the names are different but the profile pic is the same

green mesa Sep 22, 2020, 5:49 PM

#

That will cause issue

mellow hare Sep 22, 2020, 5:49 PM

#

Yeah, and that helps me out a lot, Ice

green mesa Sep 22, 2020, 5:49 PM

#

And all dont agree to change his/her name

#

Same with me

mellow hare Sep 22, 2020, 5:50 PM

#

I think it's mainly that a lot of people just have the default

green mesa Sep 22, 2020, 5:50 PM

#

Mine profile pic is also same

eternal owl Sep 22, 2020, 5:50 PM

#

what are the odds of this, lol, same number of additions

📎 unknown.png

green mesa Sep 22, 2020, 5:51 PM

#

Due to bad weather ss is not loading my net eh😐

mellow hare Sep 22, 2020, 5:51 PM

#

Spooky

obsidian patio Sep 22, 2020, 5:52 PM

#

@sullen phoenix this is giving me an issue. Since the __init__ file is part of the ext module, it'll be run when importing ext. Moving the code would result in the __init__ file trying to import itself in an endless loop, I believe. Is there anything in particular that you're trying to solve by moving it, or would it be fine to let it be in the original file? That didn't give me any issues

green mesa Sep 22, 2020, 5:53 PM

#

Ty for approving hemlock😁

eternal owl Sep 22, 2020, 5:53 PM

#

thank you @mellow hare for taking up the review for my PR 😁

mellow hare Sep 22, 2020, 5:53 PM

#

No problem, might take me a little bit to go through it

eternal owl Sep 22, 2020, 5:54 PM

#

np, lemme know if u need any help understanding

obsidian patio Sep 22, 2020, 5:54 PM

#

I really felt like continuing the "thank you hem... 😁" chain

cold moon Sep 22, 2020, 5:54 PM

#

Next part of Dewikification PR opened

eternal owl Sep 22, 2020, 5:54 PM

#

btw, do u need the test file i use?

#

or test code

mellow hare Sep 22, 2020, 5:54 PM

#

Not at the moment

eternal owl Sep 22, 2020, 5:54 PM

#

okay

green mesa Sep 22, 2020, 5:54 PM

#

Now I am waiting for my pr to get merged😁

mellow hare Sep 22, 2020, 5:55 PM

#

I'll spin it up on my local machine and go from there. Does it rely on any changes to site?

sullen phoenix Sep 22, 2020, 5:55 PM

#

oh i see, i didn't realize it imported the module, interesting

mellow hare Sep 22, 2020, 5:55 PM

#

@green mesa Yep, just waiting on it to finish doing its checks

green mesa Sep 22, 2020, 5:55 PM

#

Ok

eternal owl Sep 22, 2020, 5:55 PM

#

I'll spin it up on my local machine and go from there. Does it rely on any changes to site?
@mellow hare what do you mean?

mellow hare Sep 22, 2020, 5:56 PM

#

Like were there any API changes that were made on the site to make this work

green oriole Sep 22, 2020, 5:56 PM

#

@cold moon that'd be nice if you could include more infos in your PR description, it is a pretty important change, and you don't say what are the changes and how the new setup work

obsidian patio Sep 22, 2020, 5:56 PM

#

Yeah hahah. We could probably solve it some other way, while getting the logic into the __init__, but I think leaving it in the original sounds best

green oriole Sep 22, 2020, 5:56 PM

#

@mellow hare for seasonal? No, you don't need the site

obsidian patio Sep 22, 2020, 5:56 PM

#

At least if it isn't causing any issues

mellow hare Sep 22, 2020, 5:56 PM

#

No no no

#

Oh my god I'm an idiot

#

This is a Site pr

#

I thought it was a bot one

#

Doy

green oriole Sep 22, 2020, 5:56 PM

#

Oh haha

sullen phoenix Sep 22, 2020, 5:57 PM

#

~~wait no, it shouldn't be a circular import~~

#

~~because it shouldn't try to import itself~~

#

hm wait

#

nvm

#

confusing myself lol

eternal owl Sep 22, 2020, 5:57 PM

#

There is a new endpoint, its bot/users/bulk_patch to patch users in bulk
and my PR removes the drf-bulk package and implements bulk-create too (independent of the drf-bulk package)

mellow hare Sep 22, 2020, 5:57 PM

#

@eternal owl Ignore me, I'm speaking the crazy talk

#

Yeah I see that now

#

I was confused as to which repo this was on

obsidian patio Sep 22, 2020, 5:58 PM

#

Importing a module should run its __init__.py file, from what I'm aware

mellow hare Sep 22, 2020, 5:58 PM

#

@obsidian patio Not necessarily

eternal owl Sep 22, 2020, 5:58 PM

#

https://paste.pythondiscord.com/fayeqoxufa.py
take this test code, if u need it later

mellow hare Sep 22, 2020, 5:58 PM

#

Oh well yes it'll do that

sullen phoenix Sep 22, 2020, 5:58 PM

#

no, it runs it once in the beginning

obsidian patio Sep 22, 2020, 5:58 PM

#

Hmm, alright

green oriole Sep 22, 2020, 5:58 PM

#

Well, yeah, modules are cached

mellow hare Sep 22, 2020, 5:58 PM

#

But in it's __all__ it's just loading the two functions within the __init__ file

#

So there's no worries there

#

Or am I misunderstanding?

obsidian patio Sep 22, 2020, 5:59 PM

#

Why wouldn't we just keep it in the separate file?

sullen phoenix Sep 22, 2020, 5:59 PM

#

that's probably fine too

obsidian patio Sep 22, 2020, 5:59 PM

#

That's what we do on the Python bot

green mesa Sep 22, 2020, 5:59 PM

#

Ty Akarys

green oriole Sep 22, 2020, 6:00 PM

#

Hem apparently didn't want to merge it

mellow hare Sep 22, 2020, 6:00 PM

#

We really should overhaul Seasonal to conform more to @stable mountain's style

#

Dude...

#

I'm easily distracted

#

Blame the ADHD

sullen phoenix Sep 22, 2020, 6:00 PM

#

@dusky shore has a lot of technical debt

green oriole Sep 22, 2020, 6:00 PM

#

That's fiiiiine

mellow hare Sep 22, 2020, 6:00 PM

#

technical debt
Huh, first time I've heard that phrase

green oriole Sep 22, 2020, 6:01 PM

#

Personally I don't like putting actual code in __init__ files, it feels pretty unorganized

#

Each file should have its own purpose

mellow hare Sep 22, 2020, 6:01 PM

#

I'm not opposed to making it a utility

obsidian patio Sep 22, 2020, 6:01 PM

#

Let's keep it in utils

sullen phoenix Sep 22, 2020, 6:01 PM

#

fine with me

#

should get rid of the stuff in __init__.py then

green oriole Sep 22, 2020, 6:02 PM

#

Although, I have to admit, no idea what we are talking about lemon_sweat

cold moon Sep 22, 2020, 6:02 PM

#

@green oriole Is this now better? I'm not very good writer in english.

sullen phoenix Sep 22, 2020, 6:02 PM

#

and move the other function over to utils

mellow hare Sep 22, 2020, 6:02 PM

#

@green oriole https://github.com/python-discord/seasonalbot/blob/master/bot/exts/__init__.py

sullen phoenix Sep 22, 2020, 6:02 PM

#

but anyways, my brain is all jumbled up now lol, back to class

green oriole Sep 22, 2020, 6:02 PM

#

Right

mellow hare Sep 22, 2020, 6:02 PM

#

Study hard, study well

green oriole Sep 22, 2020, 6:02 PM

#

That's really ugly imo

#

Haha

mellow hare Sep 22, 2020, 6:03 PM

#

I'm curious how we handle it in @stable mountain

green oriole Sep 22, 2020, 6:03 PM

#

Utils everywhere

mellow hare Sep 22, 2020, 6:03 PM

#

Oh right, and we have a separate cog loader anyway

green oriole Sep 22, 2020, 6:03 PM

#

Is this now better? I'm not very good writer in english.
@cold moon yeah much better, don't worry, as long as you do your best to speak English, you're fine

obsidian patio Sep 22, 2020, 6:04 PM

#

I think the code currently in __init__.py should be fine

mellow hare Sep 22, 2020, 6:04 PM

#

Most of our staff are non-native English speakers

#

So don't sweat it

obsidian patio Sep 22, 2020, 6:04 PM

#

And we can merge the pr instead

eternal owl Sep 22, 2020, 6:04 PM

#

@cold moon are u planning on working on this
https://github.com/python-discord/site/issues/385

GitHub

Dewikification: Create an app for showing event info. · Issue #385 ...

Remember to target the dewikification branch with this pull request For displaying event information (like for our code jams), we will want a slightly different approach. These will basically just ...

obsidian patio Sep 22, 2020, 6:05 PM

#

@mellow hare True. We are surprisingly many Swedes and Norwegians

green oriole Sep 22, 2020, 6:05 PM

#

We only have two functions, so for now I'm guessing that it is fine, although if we add more, we should definitely move to an utils file I think

#

Told you, we are being invaded by the north of Europe haha

obsidian patio Sep 22, 2020, 6:05 PM

#

I agree

#

Hhaha didn't quite understand the extent of it

green mesa Sep 22, 2020, 6:06 PM

#

📎 Screenshot_2020-09-22-23-36-35-652.jpeg

#

Don't know what happen to bot

mellow hare Sep 22, 2020, 6:07 PM

#

.wiki bacon

dusky shoreBOT Sep 22, 2020, 6:07 PM

#

Wikipedia results for `bacon`

1 Bacon
2 Francis Bacon
3 Back bacon
4 Kevin Bacon
5 Six Degrees of Kevin Bacon
6 Sosie Bacon
7 Francis Bacon (artist)
8 Roger Bacon
9 Vegetarian bacon
10 Bacon sandwich

green mesa Sep 22, 2020, 6:07 PM

#

When I tested the code locally by tagging channel it worked

dusky shoreBOT Sep 22, 2020, 6:07 PM

#

Enter number to choose

mellow hare Sep 22, 2020, 6:07 PM

#

.wiki @mellow hare

dusky shoreBOT Sep 22, 2020, 6:07 PM

#

Sorry, we could not find a wikipedia article using that search term

mellow hare Sep 22, 2020, 6:07 PM

#

Seems fine to me

green mesa Sep 22, 2020, 6:07 PM

#

.wiki #dev-contrib

#

Ohk

obsidian patio Sep 22, 2020, 6:08 PM

#

It's probably searching for this: @mellow hare. How often would there be results for that?

green oriole Sep 22, 2020, 6:08 PM

#

Isn't that a perm issue?

green mesa Sep 22, 2020, 6:08 PM

#

Can u search .wiki #dev-contrib

green oriole Sep 22, 2020, 6:08 PM

#

No, definitely not the right one haha

green mesa Sep 22, 2020, 6:08 PM

#

It's not reading error

green oriole Sep 22, 2020, 6:08 PM

#

.wiki #dev-contrib

dusky shoreBOT Sep 22, 2020, 6:08 PM

#

Sorry, we could not find a wikipedia article using that search term

green mesa Sep 22, 2020, 6:08 PM

#

Wow

green oriole Sep 22, 2020, 6:09 PM

#

Yeah, that's a perm issue

green mesa Sep 22, 2020, 6:09 PM

#

It worked for u

mellow hare Sep 22, 2020, 6:09 PM

#

Staff have special permission

green mesa Sep 22, 2020, 6:09 PM

#

Lol and i thought I made u merged broken or😅

#

Pr*

dusky shoreBOT Sep 22, 2020, 6:09 PM

#

Sorry, we could not find a wikipedia article using that search term

green oriole Sep 22, 2020, 6:10 PM

#

Yeah, everything's fine, nothing in sentry

cold moon Sep 22, 2020, 6:10 PM

#

@eternal owl No, currently I try to migrate resources (guides, books etc.). But these wait for both of my current PRs

eternal owl Sep 22, 2020, 6:10 PM

#

okay

obsidian patio Sep 22, 2020, 6:10 PM

#

.issue 449

dusky shoreBOT Sep 22, 2020, 6:10 PM

#

GitHub

PROpen [seasonalbot] #449 Add extension management commands

obsidian patio Sep 22, 2020, 6:11 PM

#

This should be fully ready to merge whenever ready

vocal wolf Sep 22, 2020, 6:11 PM

#

watch this shit

#

!ping

cold moon Sep 22, 2020, 6:11 PM

#

Nice ping command

stable mountainBOT Sep 22, 2020, 6:11 PM

#

Pong!

Command processing time

0.000 ms

Python Discord website latency

12.276 ms

Discord API latency

101.374 ms

green mesa Sep 22, 2020, 6:11 PM

#

Noice

cold moon Sep 22, 2020, 6:11 PM

#

0.000

vocal wolf Sep 22, 2020, 6:11 PM

#

very fast lol

green mesa Sep 22, 2020, 6:11 PM

#

📎 Screenshot_2020-09-22-23-41-39-664.jpeg

obsidian patio Sep 22, 2020, 6:11 PM

#

Nice @vocal wolf

green mesa Sep 22, 2020, 6:11 PM

#

Y this lol

#

Discord mobile😂😂

green oriole Sep 22, 2020, 6:12 PM

#

Ah yes, thanks discord

vocal wolf Sep 22, 2020, 6:12 PM

#

Thanks, it took much longer than it should have

obsidian patio Sep 22, 2020, 6:12 PM

#

Things generally do

#

Especially in programming

vocal wolf Sep 22, 2020, 6:13 PM

#

aioping didn't want to work

green mesa Sep 22, 2020, 6:14 PM

#

pithink

vocal wolf Sep 22, 2020, 6:14 PM

#

alright next issue

obsidian patio Sep 22, 2020, 6:14 PM

#

This issue tracker will be empty soon with that attitude hahah

green mesa Sep 22, 2020, 6:15 PM

#

Yeh tomorrow I will try to complete 2 pr

#

Source is same

green oriole Sep 22, 2020, 6:15 PM

#

~~and reviewing will pile up~~

obsidian patio Sep 22, 2020, 6:15 PM

#

True

green mesa Sep 22, 2020, 6:15 PM

#

And 1 partnerzodiac needs some updation

mellow hare Sep 22, 2020, 6:23 PM

#

I need to kick some rears to get more reviews going

#

I know people don't like to do them but they're vital

green oriole Sep 22, 2020, 6:29 PM

#

Once codespaces is setup, I'll try to do more reviews as I won't have to be in on my computer to launch the bot lemon_pleased

mellow hare Sep 22, 2020, 6:32 PM

#

Fair point

#

Hadn't thought about that

#

I mean honestly even if I manage to get people just looking for syntax, logic or efficiency stuff I'll be happy

eternal owl Sep 22, 2020, 6:38 PM

#

https://github.com/python-discord/bot/pull/1157
this PR is ready for review

GitHub

Restrict nsfw subreddit(s) or similar by RohanJnr · Pull Request #1...

closes #1153
Changes made to Reddit Cog:

Check if the subreddit is NSFW or similar by using the over_18 boolean value got with the API response.

if True, then send an error message.

if False,...

#

very small one

#

I just now updated my branch

#

and im geting redis error

#

socket.gaierror: [Errno -3] Temporary failure in name resolution

#

seems to be working with docker tho

#

i went back to my last commit when the bot was working
I get the same error even now but the bot doesn't stop the execution there, and continues

#

but when i update the branch with the latest changes, and run, it stops at that error and exits

#

https://paste.pythondiscord.com/exofanixun.coffeescript
this is the complete error

mellow hare Sep 22, 2020, 7:48 PM

#

@eternal owl Have you made sure to set the use_fakeredis flag to true in the config.yml?

#

Or are you running redis locally

obsidian patio Sep 22, 2020, 9:38 PM

#

@sullen phoenix whenever you’re free, I’d love to see the extensions command merged into master

sullen phoenix Sep 22, 2020, 9:52 PM

#

yeah, sure

#

did you remove the old walk_extensions function?

obsidian patio Sep 22, 2020, 10:06 PM

#

Nope. Isn’t that one supposed to be there any longer?

#

@sullen phoenix if this is the last thing needed before we merge, I could get up and do that as the last thing before going to bed

brazen charm Sep 22, 2020, 10:08 PM

#

There's really no rush for anything that's not critical

obsidian patio Sep 22, 2020, 10:09 PM

#

Yeah. Would still be nice to get it merged. Just feels good to have it done, instead of waiting another day or two

sullen phoenix Sep 22, 2020, 10:09 PM

#

no no, you should go to bed instead. like Numerlor said, no rush

#

well, you'd need 2 approvals anyway

obsidian patio Sep 22, 2020, 10:10 PM

#

Hahah yeah, fair enough

green mesa Sep 23, 2020, 1:22 AM

#

.pr 456

dusky shoreBOT Sep 23, 2020, 1:22 AM

#

GitHub

PROpen [seasonalbot] #456 updated d.py to 1.4.1 and added voice as extra

green mesa Sep 23, 2020, 1:23 AM

#

I have updated d.py to 1.4.1 and added voice as extra

#

It's just a lib update pr😅

green mesa Sep 23, 2020, 3:52 AM

#

@eternal owl in subcommand for date of partnerzodiac i am only taking date and month from user so it's hard to map with zodiac sign ,I can't touch the zodiac_explantion json file it will not help in this scenario I think

#

Any recommendations how should I tackle

#

😅

#

📎 Screenshot_2020-09-23-09-27-55-162.jpeg

#

I am taking this 2 input only

#

📎 Screenshot_2020-09-23-09-30-09-992.jpeg

#

And have json like this

eternal owl Sep 23, 2020, 4:39 AM

#

as I said, have a dict to store all the information about the zodiac signs

#

in the json file, also include and starting date and ending date for each zodiac sign

#

then when u load the json, convert that to a datetime object

green oriole Sep 23, 2020, 6:58 AM

#

Hey @obsidian patio, after investigation your issue a little, it seems like a monkey patch is causing this, the issue for replacing it is here https://github.com/python-discord/site/issues/341 lemon_pleased

GitHub

Replace Allauth anti-email monkey-patch with proper settings. · Iss...

The allauth extension we use for the discord login and connection to a github account for any of our site accounts. We have a monkeypatch to avoid saving in our database any email details that we m...

green mesa Sep 23, 2020, 8:19 AM

#

.pr 456

dusky shoreBOT Sep 23, 2020, 8:19 AM

#

GitHub

PROpen [seasonalbot] #456 updated d.py to 1.4.1 and added voice as extra

green mesa Sep 23, 2020, 8:19 AM

#

what i need to change in docker file?

#

i dont have much experience with docker 😅

obsidian patio Sep 23, 2020, 8:37 AM

#

Aah, alright. Thanks for showing me Akarys. I don’t quite understand how it happens, but I’m glad you found the issue. Maybe move the issue from low to normal?

green oriole Sep 23, 2020, 9:41 AM

#

Was about to do that, but I ran out of time lemon_sweat

obsidian patio Sep 23, 2020, 9:49 AM

#

Hahah, no worries

nocturne hare Sep 23, 2020, 10:04 AM

#

You shouldn't need to change anything in docker for the installation at least

#

but you probably need to add ffmpeg to the environment with docker

green oriole Sep 23, 2020, 10:10 AM

#

About?

#

Right

green mesa Sep 23, 2020, 10:15 AM

#

ffmpeg violates Youtube TOS right 😅

green oriole Sep 23, 2020, 10:15 AM

#

No

nocturne hare Sep 23, 2020, 10:15 AM

#

No

green oriole Sep 23, 2020, 10:15 AM

#

yt-dl does

green mesa Sep 23, 2020, 10:15 AM

#

ooo

nocturne hare Sep 23, 2020, 10:15 AM

#

ffmpeg is an audio driver

#

youtube-dl is what downloads content from youtube, and uses ffmpeg to stream it to discord.

green mesa Sep 23, 2020, 10:16 AM

#

oo

green oriole Sep 23, 2020, 10:16 AM

#

You'll need to remove git from the the image, so you just have to change this line to ffmpeg https://github.com/python-discord/seasonalbot/blob/master/Dockerfile#L12

GitHub

python-discord/seasonalbot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to bot that changes with the seasons. - python-discord/seasonalbot

#

yt-dl also relies on ffmpeg internally I think

green mesa Sep 23, 2020, 10:17 AM

#

thats it

#

i have to remove git only

#

and add ffmpeg in pipfile?

green oriole Sep 23, 2020, 10:18 AM

#

No, in the apt command

#

Simply replace git by ffmpeg

green mesa Sep 23, 2020, 10:18 AM

#

ok

green oriole Sep 23, 2020, 10:18 AM

#

I don't think it is available on pypi

green mesa Sep 23, 2020, 10:19 AM

#

RUN apt-get -y update \
    && apt-get install -y \
        ffmpeg \
    && rm -rf /var/lib/apt/lists/*

this way

green oriole Sep 23, 2020, 10:20 AM

#

Looks like it

green mesa Sep 23, 2020, 10:21 AM

#

ok

late wolf Sep 23, 2020, 10:23 AM

#

IDK if this is the right channel but i am trying to add the python bot to mi server as well, but if i need help setting it up should I ask here.

#

pls ping me

green mesa Sep 23, 2020, 10:25 AM

#

@late wolf https://pythondiscord.com/pages/contributing/bot/#contribution

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

just follow steps and u r set

late wolf Sep 23, 2020, 10:25 AM

#

oh ok thx

late wolf Sep 23, 2020, 10:45 AM

#

well when following that I already get an error from the code

Unable to import 'discord.ext'
Unable to import 'coloredlogs'

#

@late wolf < https://pythondiscord.com/pages/contributing/bot/#contribution>
@green mesa That's For Contirbutors

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

green mesa Sep 23, 2020, 10:51 AM

#

yeh and for contributing we first run the bot on our test server

#

just dont contribute

glass pecan Sep 23, 2020, 10:52 AM

#

If you mean to invite the bot like a public bot to your server, it's not possible.

#

It's only possible to selfhost it

#

And even then, it's created quite strictly to our requirements and community structure, so it may not suit what you want.

brazen charm Sep 23, 2020, 10:53 AM

#

If you need something from the bot it'd be abetter idea to extract that part of it instead of trying to set it up whole

late wolf Sep 23, 2020, 10:53 AM

#

ohh could u help me do that

#

that's exactly what i was looking for

glass pecan Sep 23, 2020, 10:54 AM

#

We are unable to support third party usage really on a formal level, but if you have troubles with things you could probably ask questions when needed.

#

If it's generally about discord.py, #discord-bots will be able to help. If it's specific to something about our bot, it's likely the above contributor guide has info on it.

late wolf Sep 23, 2020, 10:55 AM

#

wdym by 3rd party usage

glass pecan Sep 23, 2020, 10:57 AM

#

outside of our own community

late wolf Sep 23, 2020, 10:58 AM

#

i see, very well i will try to see what i can do with the existing ode

#

code

glass pecan Sep 23, 2020, 11:05 AM

#

hope it goes well!

late wolf Sep 23, 2020, 11:07 AM

#

thx

#

@glass pecan i can ask questions about the bot here right?

queen dawn Sep 23, 2020, 12:03 PM

#

            interval: 5
            max: 3_000```

What the hell does 3_000 mean?
Found this in `config-default.yml`

glass pecan Sep 23, 2020, 12:04 PM

#

@late wolf sure can, but i can't promise solutions

#

@queen dawn it means 3000

#

the _ is a thousands seperator format

#

it's supported in both yml and newer versions of python

queen dawn Sep 23, 2020, 12:05 PM

#

oh really

glass pecan Sep 23, 2020, 12:05 PM

#

!eval print(3_000)

dry turret Sep 23, 2020, 12:05 PM

#

Python lets you place them anywhere within a numbers.

stable mountainBOT Sep 23, 2020, 12:05 PM

#

@glass pecan :white_check_mark: Your eval job has completed with return code 0.

queen dawn Sep 23, 2020, 12:05 PM

#

didn't know thjat

#

ty !

glass pecan Sep 23, 2020, 12:06 PM

#

np

queen dawn Sep 23, 2020, 12:06 PM

#

so if I understood correctly

#

!e print(3_000_000)

stable mountainBOT Sep 23, 2020, 12:06 PM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

queen dawn Sep 23, 2020, 12:06 PM

#

oh sec

glass pecan Sep 23, 2020, 12:06 PM

#

that would work, yep

#

in python, like grote mentioned, it'll just ignore any underscores you use no matter where

queen dawn Sep 23, 2020, 12:12 PM

#

If running the webserver in Docker, set it to "web:8000".
If the site container is running separately (i.e. started from a clone of the site repository), then COMPOSE_PROJECT_NAME has to be set to use this domain. If you choose not to set it, the domain in the following step can be used instead.
If running the webserver locally and the hosts file has been configured, set it to "pythondiscord.local:8000".
Otherwise, use whatever domain corresponds to the server where the site is being hosted.```
Can someone help me understand this?

#

I do not know to specifics what is a docker

#

and I don't know what to use

green oriole Sep 23, 2020, 12:12 PM

#

Well, how are you running the bot, using docker or pipenv?

queen dawn Sep 23, 2020, 12:12 PM

#

pipenv I believe

#

On my PC

green oriole Sep 23, 2020, 12:13 PM

#

Okay

#

Are you on windows or linux/macos?

queen dawn Sep 23, 2020, 12:13 PM

#

Windows

late wolf Sep 23, 2020, 12:14 PM

#

what deos filtering lists do

green oriole Sep 23, 2020, 12:14 PM

#

Have you added the entry in C:\Windows\System32\Drivers\etc\hosts?

#

what deos filtering lists do
@late wolf where?

late wolf Sep 23, 2020, 12:14 PM

#

in github

queen dawn Sep 23, 2020, 12:14 PM

#

What entry?

green oriole Sep 23, 2020, 12:15 PM

#

127.0.0.1   pythondiscord.local
127.0.0.1   api.pythondiscord.local
127.0.0.1   staff.pythondiscord.local
127.0.0.1   admin.pythondiscord.local```this

queen dawn Sep 23, 2020, 12:15 PM

#

How do I add this?

green oriole Sep 23, 2020, 12:15 PM

#

@late wolf I mean, in which file?

#

@queen dawn open notepad as admin, open the file, and add those lines at the bottom

late wolf Sep 23, 2020, 12:16 PM

#

bot folder fileters folder

queen dawn Sep 23, 2020, 12:16 PM

#

notepad++ workls too?

green oriole Sep 23, 2020, 12:16 PM

#

Yeah, sure

late wolf Sep 23, 2020, 12:16 PM

#

inside the bot folders and inside the filters folders

queen dawn Sep 23, 2020, 12:17 PM

#

https://prnt.sc/umfw6t Here I should add all of these?

Lightshot

Screenshot

Captured with Lightshot

green oriole Sep 23, 2020, 12:18 PM

#

At the bottom of the file

queen dawn Sep 23, 2020, 12:20 PM

#

https://prnt.sc/umfxr4 Like that?

Lightshot

Screenshot

Captured with Lightshot

green oriole Sep 23, 2020, 12:20 PM

#

@late wolf well, as written in the docstring, it is used to manage the whitelists and blacklists of the bot, such as the watchlist trigger or the invite list

#

@queen dawn no, no # before those lines

queen dawn Sep 23, 2020, 12:20 PM

#

Oh

#

only on the ones you told me to add right?

#

and what about the spaces? I should remove them too?

#

(talking about the spaces between hashtag and the ip address

late wolf Sep 23, 2020, 12:21 PM

#

idk what whitelists and black lists are @green oriole

green oriole Sep 23, 2020, 12:21 PM

#

@queen dawn you can but it isn’t mandatory

queen dawn Sep 23, 2020, 12:22 PM

#

Okay I added these

green oriole Sep 23, 2020, 12:22 PM

#

@late wolf a whitelist is a list of autorized stuff, a blacklist is a list of forbidden stuff

queen dawn Sep 23, 2020, 12:22 PM

#

so if I understand corretly now I need to use pythondiscord.local:"8000

#

ofc without the typing mistakes

late wolf Sep 23, 2020, 12:22 PM

#

i see, so incase of python bot what are some white lists and black lists could u give me an example

green oriole Sep 23, 2020, 12:22 PM

#

exactly!

queen dawn Sep 23, 2020, 12:23 PM

#

Great! Thank you so much Akarys! I would have never even got close to do this

green oriole Sep 23, 2020, 12:23 PM

#

@late wolf well, as I said, there’s the watchlist triggers (list of forbidden words/regexes which ping mods when used), and the server list (the servers you are allowed to post invites to)

#

@queen dawn any time! lemon_pleased

late wolf Sep 23, 2020, 12:24 PM

#

thx

queen dawn Sep 23, 2020, 12:26 PM

#

I got to creating the .env file, just a quick question, when they mean the project root they mean the folder that contains the config-default.yml the config.yml, the readme.md and such right?

green oriole Sep 23, 2020, 12:27 PM

#

That’s the one, yeah

queen dawn Sep 23, 2020, 12:28 PM

#

Great

#

it doesn't matter if I use touch .env or type nul > \path\to\project\.env if I launch Git Bash in the project root

#

right?

green oriole Sep 23, 2020, 12:29 PM

#

Yeah, that’s totally fine

#

Do what work best for you lemon_pleased

queen dawn Sep 23, 2020, 12:30 PM

#

Ilove that emoji !

green oriole Sep 23, 2020, 12:31 PM

#

Haha, we have quite a few of those lemon_pika

queen dawn Sep 23, 2020, 12:33 PM

#

https://prnt.sc/umg7hv

Lightshot

Screenshot

Captured with Lightshot

#

did I do the syntax correct?

#

and what do I need in the BOT_API_KEY

green oriole Sep 23, 2020, 12:35 PM

#

badbot13m0n8f570f942013fc818f234916ca531

#

That’s the default key

queen dawn Sep 23, 2020, 12:35 PM

#

wait what

#

that's what I need to put?

green oriole Sep 23, 2020, 12:35 PM

#

Yeah

queen dawn Sep 23, 2020, 12:35 PM

#

I'm dying

#

lemon_grimace

#

do I need to run the .env file? I've always changed env variables through cmd...

green oriole Sep 23, 2020, 12:37 PM

#

The .env file is just here to add more env vars, you don’t have to explicitly run it

#

pipenv will load it for you

queen dawn Sep 23, 2020, 12:37 PM

#

Great!

#

because i'm not using docker I need to use this "PostgreSQL"?

#

What is "The site" and why do I need it?>

green oriole Sep 23, 2020, 12:51 PM

#

Yeah, you need postgres and our website to run on your machine

#

The bot communicates with the site in order to store data

#

https://pythondiscord.com/pages/contributing/site/

Python Discord | Contributing to Site

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

queen dawn Sep 23, 2020, 12:54 PM

#

so just follow this tutorial too?

green oriole Sep 23, 2020, 12:54 PM

#

Yup

hardy gorge Sep 23, 2020, 1:00 PM

#

I'd recommend using Docker, if you can. It even works well on Windows 10 Home now, assuming that you're on a fairly up to date version

green oriole Sep 23, 2020, 1:01 PM

#

You have to be on a preview though, don’t you?

hardy gorge Sep 23, 2020, 1:02 PM

#

No

#

Not any more

#

You just need to meet the requirements: For x64 systems: Version 1903 or higher, with Build 18362 or higher.

#

For WSL2

#

And then you can install Docker with a WSL2 back-end

#

It's easy and works out of the box

late wolf Sep 23, 2020, 1:08 PM

#

hey it says this in the tutorial what does this mean??

config-default.yml

eternal owl Sep 23, 2020, 1:09 PM

#

there should be a file with that name when u clone the repo

#

u need to create a new file called config.yml and paste its contents in it

late wolf Sep 23, 2020, 1:10 PM

#

do u have any idea which folder that might be in?

eternal owl Sep 23, 2020, 1:10 PM

#

at the project root

#

where the pipfile, pipefile.lock exist

late wolf Sep 23, 2020, 1:11 PM

#

??

📎 unknown.png

eternal owl Sep 23, 2020, 1:11 PM

#

look closely, there is a file called config-default

#

9th from the top

late wolf Sep 23, 2020, 1:12 PM

#

yes there is what about it

#

oh thats the on

#

right?

eternal owl Sep 23, 2020, 1:13 PM

#

now create a new file called config.yml

#

do u have git bash or wsl?

late wolf Sep 23, 2020, 1:13 PM

#

idk what that is

eternal owl Sep 23, 2020, 1:13 PM

#

nvm

#

create a config.yml file and copy the contents of config-default.yml into it

late wolf Sep 23, 2020, 1:14 PM

#

ok thx

#

there isnt a guild ID there thgouh

#

or it's just that i couldnt find it

eternal owl Sep 23, 2020, 1:20 PM

#

line 136

late wolf Sep 23, 2020, 1:20 PM

#

oh i found it thx bro

#

what is meant by categories?

#

and what is the change log channel?

eternal owl Sep 23, 2020, 1:24 PM

#

📎 unknown.png

#

here Development is the category

#

and channel below it come under that category

late wolf Sep 23, 2020, 1:25 PM

#

ohh i see thx but when we add a topic then why is it yellow but otheres are red?

eternal owl Sep 23, 2020, 1:25 PM

#

the server has many categories- Bot Commands, Events, Help, etc

#

ohh i see thx but when we add a topic then why is it yellow but otheres are red?
@late wolf ?

#

also, check the pins, there is a server template u can use

queen dawn Sep 23, 2020, 1:32 PM

#

I'd recommend using Docker, if you can. It even works well on Windows 10 Home now, assuming that you're on a fairly up to date version
@hardy gorge Why?

mellow hare Sep 23, 2020, 1:35 PM

#

It makes life a lot easier. Normally you'd have to set up the individual services like the database and the server hosting. Docker handles all of that for you

#

Okay not server hosting

#

But in general it's as simple as docker-compose up and you're up and running

green mesa Sep 23, 2020, 2:09 PM

#

@eternal owl

@staticmethod
def zodiac_date() -> List[dict]:
    zodiac_date = {"Aries": (datetime(year, 3, 21), datetime(year, 4, 19)),
                   "Taurus": (datetime(year, 4, 20), datetime(year, 5, 20)),
                   "Gemini": (datetime(year, 5, 21), datetime(year, 6, 20)),
                   "Cancer": (datetime(year, 6, 21), datetime(year, 7, 22)),
                   "Leo": (datetime(year, 7, 23), datetime(year, 8, 22)),
                   "Virgo": (datetime(year, 8, 23), datetime(year, 9, 22)),
                   "Libra": (datetime(year, 9, 23), datetime(year, 10, 22)),
                   "Scorpio": (datetime(year, 10, 23), datetime(year, 11, 21)),
                   "Sagittarius": (datetime(year, 11, 22), datetime(year, 12, 21)),
                   "Capricorn": (datetime(year, 12, 22), datetime(year, 1, 19)),
                   "Aquarius": (datetime(year, 1, 20), datetime(year, 2, 18)),
                   "Pisces": (datetime(year, 2, 19), datetime(year, 3, 20))
                   }
      return zodiac_date

#

i have converted this into static method

#

is it right

#

bcz in json its getting messy

#

😅

eternal owl Sep 23, 2020, 2:13 PM

#

u don't need a method for this

#

have that variable outside the class

#

i meant to have the loading of json date for zodiac info inside

#

like the description, etc

green mesa Sep 23, 2020, 2:14 PM

#

hmmm

eternal owl Sep 23, 2020, 2:15 PM

#

have u included the starting and ending date for each zodiac in the json?

#

as induvidual keys

green mesa Sep 23, 2020, 2:16 PM

#

nope

#

adding those

#

in main script i use

eternal owl Sep 23, 2020, 2:16 PM

#

add the dates in the json

#

then in the Cog, write a script to extract all the data including those dates

#

lemme show u

green mesa Sep 23, 2020, 2:17 PM

#

i use json to extract other info

#

will i create 4 key

eternal owl Sep 23, 2020, 2:17 PM

#

add the dates in zodiac_explanation.json

green mesa Sep 23, 2020, 2:18 PM

#

in json we can keep tuples right

eternal owl Sep 23, 2020, 2:18 PM

#

"Aries":{
  "start": "iso date format for aries starting date",
  "end": "iso date format for aries ending date",
  ...
},```

green mesa Sep 23, 2020, 2:19 PM

#

and 2 for month

eternal owl Sep 23, 2020, 2:19 PM

#

or u can use a list to keep them under 1 key

#

no

green mesa Sep 23, 2020, 2:19 PM

#

(datetime(year, 3, 21), datetime(year, 4, 19))?

#

this way

eternal owl Sep 23, 2020, 2:19 PM

#

start will be for example: 2020-01-1

#

u cant store datetime in json

green mesa Sep 23, 2020, 2:20 PM

#

actually i have defined year like this -> year = datetime.now().year

#

so we dont need to change again and again every year

eternal owl Sep 23, 2020, 2:21 PM

#

year dosent matter

#

just hard code it

#

i dont think zodiac signs change with year

green mesa Sep 23, 2020, 2:21 PM

#

for leap year?

#

feb

eternal owl Sep 23, 2020, 2:22 PM

#

still comes under Aquarius

#

29th feb is between 15th and 14th march

green mesa Sep 23, 2020, 2:23 PM

#

ok then i will put leap year as year

eternal owl Sep 23, 2020, 2:23 PM

#

2020 is leap year :p

green mesa Sep 23, 2020, 2:23 PM

#

so others can check for 29 also

#

noice

#

then i will hardcode it

#

json accept tuples?

eternal owl Sep 23, 2020, 2:25 PM

#

no

#

use list

green mesa Sep 23, 2020, 2:25 PM

#

looks like json dont like 😂

eternal owl Sep 23, 2020, 2:25 PM

#

[]

green mesa Sep 23, 2020, 2:25 PM

#

ok list done

eternal owl Sep 23, 2020, 2:29 PM

#

okay so

#

once u have added the dates in the json

#

it will be loaded here in ur script

#

with open(Path("bot/resources/valentines/zodiac_explanation.json"), "r", encoding="utf8") as file:
    """Load zodiac zodiac explanation from static JSON resource."""
    zodiac_fact = load(file)```

#

so zodiac_fact will hold all that data

#

as we saved the dates in JSON as string, we want to convert them into datetime objects, so loop over zodiac_facts and convert the string representation to datetime objects

#

u can do that by using fromisoformat() method

#

https://docs.python.org/3/library/datetime.html#datetime.datetime.fromisoformat

green mesa Sep 23, 2020, 2:35 PM

#

ty

#

i have made this static method

    @staticmethod
    def load_exp_json() -> dict:
        p = Path("bot/resources/valentines/zodiac_explanation.json")
        with p.open(encoding="utf8") as json_data:
            zodiac_fact = load(json_data)
            return zodiac_fact

eternal owl Sep 23, 2020, 2:35 PM

#

perform the creation of datetime objects in that itself

#

can u show me the way u stored the dates in ur json

green mesa Sep 23, 2020, 2:36 PM

#

yeh sure

#

{
    "Aries":{
            "start_at": "2020-03-21",
            "end_at": "2020-04-19",
            "About":"Amazing people born between **March 21** to **April 19**. Aries loves to be number one, so it’s no surprise that these audacious rams are the first sign of the zodiac. Bold and ambitious, Aries dives headfirst into even the most challenging situations.",
            "Motto":"***“When you know yourself, you're empowered. When you accept yourself, you're invincible.”***",
            "Strengths":"courageous, determined, confident, enthusiastic, optimistic, honest, passionate.",
            "Weaknesses":"impatient, moody, short-tempered, impulsive, aggressive.",
            "full_form":"**A** for assertive\n**R** for refreshing\n **I** for independent\n**E** for energetic\n**S** for sexy",
            "url":"https://www.horoscope.com/images-US/signs/profile-aries.png"
        },

eternal owl Sep 23, 2020, 2:37 PM

#

okay

#

so

for fact in zodiac_fact:
  fact["start_at"] = datetime.fromisoformat(fact["start_at"])
  fact["end_at"] = datetime.fromisoformat(fact["end_at"])```

#

nd dont forget to import datetime
from datetime import datetime

green mesa Sep 23, 2020, 2:38 PM

#

its already imported

#

like this

eternal owl Sep 23, 2020, 2:39 PM

#

okay

green mesa Sep 23, 2020, 2:40 PM

#

in static method i have add this right

eternal owl Sep 23, 2020, 2:42 PM

#

i have made this static method

    @staticmethod
    def load_exp_json() -> dict:
        p = Path("bot/resources/valentines/zodiac_explanation.json")
        with p.open(encoding="utf8") as json_data:
            zodiac_fact = load(json_data)
            return zodiac_fact

@green mesa in this

green mesa Sep 23, 2020, 2:42 PM

#

yeh saying for this only

eternal owl Sep 23, 2020, 2:42 PM

#

also

green mesa Sep 23, 2020, 2:42 PM

#

return

eternal owl Sep 23, 2020, 2:42 PM

#

we dont need 2 methods to load json, u can merge the 2 methods

green mesa Sep 23, 2020, 2:43 PM

#

ok

neon garnet Sep 23, 2020, 2:50 PM

#

Setting up the test server sure is tedious

eternal owl Sep 23, 2020, 2:50 PM

#

yep

#

the server template in the pins does simplify it

obsidian patio Sep 23, 2020, 2:52 PM

#

Yeah. It really is

green oriole Sep 23, 2020, 2:52 PM

#

Soon™

obsidian patio Sep 23, 2020, 2:53 PM

#

Are you working on a setup script?

eternal owl Sep 23, 2020, 2:54 PM

#

i tried to make a setup script once, but the &ENV and other things stopped me

mellow hare Sep 23, 2020, 2:54 PM

#

@eternal owl I haven't forgotten your PR, I just got caught up in work. I'll have it done by the end of the day. I need to see who else I can rope into checking it over

eternal owl Sep 23, 2020, 2:54 PM

#

no hurry, and thanks @mellow hare 😄

green oriole Sep 23, 2020, 2:58 PM

#

Are you working on a setup script?
@obsidian patio something like that

#

Still at the design stage though

cold moon Sep 23, 2020, 3:01 PM

#

Is there issue about dewikification of Contributing pages, FAQ page, Rules, Code of Conduct, Privacy?

neon garnet Sep 23, 2020, 3:01 PM

#

iirc there were talks about a bot that allows for bootstrapping that process

queen dawn Sep 23, 2020, 3:03 PM

#

Okay after some break I got back to working on the code, and I don't know if to use the site with a docker or not... what's the quickest and easiest way

green oriole Sep 23, 2020, 3:03 PM

#

Pff, no fun pure

queen dawn Sep 23, 2020, 3:05 PM

#

Wait if I did the bot without a docker does it mean I have to do the site also in a docker?

green oriole Sep 23, 2020, 3:08 PM

#

The easiest way is to setup the bot with docker

#

You won't even need a local copy of the site

obsidian patio Sep 23, 2020, 3:09 PM

#

That’s awesome Akarys. The current setup is... monstrous

#

Btw, is there anything shorter I can call you? Like “Ak” or something

queen dawn Sep 23, 2020, 3:15 PM

#

@green oriole Wait so you think I should do the bot again but using a docker?

#

and then what should I do the site in?

green oriole Sep 23, 2020, 3:16 PM

#

Btw, is there anything shorter I can call you? Like “Ak” or something
@obsidian patio I'm fine with "ak", yeah

#

@queen dawn forgot to ask you something, are you on windows home or pro

queen dawn Sep 23, 2020, 3:17 PM

#

I believe pro

#

let me check

#

does it matter???

#

Windows 10 enterprise lemon_thinking

green oriole Sep 23, 2020, 3:18 PM

#

Yeah it does

#

Well, docker will be faster then

#

You don't really have to change a lot of things on your already setup bot

#

The only thing is that the site url is now web:8000

queen dawn Sep 23, 2020, 3:19 PM

#

I haven't set up the site yet

#

Only the bot I set up using your help previously

green oriole Sep 23, 2020, 3:21 PM

#

You won't need to, that's the magic of docker

queen dawn Sep 23, 2020, 3:22 PM

#

OOOO

#

So just follow the guide of the bot again and just change the things that are related to the docker?]

green oriole Sep 23, 2020, 3:24 PM

#

Well, the only thing you need to change is the url

queen dawn Sep 23, 2020, 3:25 PM

#

Great!

#

So just install Docker Hub?

obsidian patio Sep 23, 2020, 3:26 PM

#

Alright, nice

green oriole Sep 23, 2020, 3:26 PM

#

The docker engine, yeah

green mesa Sep 23, 2020, 3:29 PM

#

for fact in zodiac_fact:
fact["start_at"] = datetime.fromisoformat(fact["start_at"])
fact["end_at"] = datetime.fromisoformat(fact["end_at"])
@eternal owl its raising error

eternal owl Sep 23, 2020, 3:34 PM

#

What error

green mesa Sep 23, 2020, 3:34 PM

#

    fact["start_at"] = datetime.fromisoformat(fact["start_at"])
TypeError: tuple indices must be integers or slices, not str

#

i dont know y its taking as tuple

tough imp Sep 23, 2020, 3:35 PM

#

can you link me the PR?

eternal owl Sep 23, 2020, 3:37 PM

#

oh

#

my bad, i thought i was a list of dicts

green mesa Sep 23, 2020, 3:38 PM

#

.pr 456

dusky shoreBOT Sep 23, 2020, 3:38 PM

#

GitHub

PROpen [seasonalbot] #456 updated d.py to 1.4.1 and added voice as extra

green mesa Sep 23, 2020, 3:38 PM

#

oops

eternal owl Sep 23, 2020, 3:38 PM

#

for val in zodiac_fact.values():
  val["start_at"] = datetime.fromisoformat(val["start_at"])
  val["end_at"] = datetime.fromisoformat(val["end_at"])```

green mesa Sep 23, 2020, 3:38 PM

#

.pr 455

dusky shoreBOT Sep 23, 2020, 3:38 PM

#

GitHub

PROpen [seasonalbot] #455 Partnerzodiac

green mesa Sep 23, 2020, 3:39 PM

#

this one kwzrd

eternal owl Sep 23, 2020, 3:39 PM

#

try that code

tough imp Sep 23, 2020, 3:39 PM

#

cheers

eternal owl Sep 23, 2020, 3:39 PM

#

i should check the format again

#

yep, i got it right this time

#

what happened before is that it was looping for the keys and expects an index instead of a string

cold moon Sep 23, 2020, 4:00 PM

#

https://github.com/python-discord/bot/issues/553 should be updated to follow new cogs schema.

GitHub

Writing unit tests for the bot · Issue #553 · python-discord/bot

The unit test branch coverage of our bot is currently 20% (30% including the test files). We would like to increase the test coverage of our bot to make one of our community's most essentia...

obsidian patio Sep 23, 2020, 4:13 PM

#

@sullen phoenix It's fixed now. I really hope this is ready to merge this time around

queen dawn Sep 23, 2020, 4:16 PM

#

Okay I don't know if it's connected but after restarting fo rtthe download of the Docker I was asked to download a linux something and now I can't launch discord on my PC and I get an error form the docker installer (auto opens on startup)

green oriole Sep 23, 2020, 4:16 PM

#

Unh

#

That's really weird

#

What is the error about?

queen dawn Sep 23, 2020, 4:17 PM

#

I can send the crash report from the docker installer

neon garnet Sep 23, 2020, 4:17 PM

#

I assume you're on Windows?

queen dawn Sep 23, 2020, 4:17 PM

#

and form discord I can take a screen shot

#

Yep WIndows

#

Discord:

A fatal Javascript error occured Error: Cannot find module 'discord_desktop_core' Require Stack: and then a lot of paths that go to appdata\local

neon garnet Sep 23, 2020, 4:18 PM

#

What error does Docker say exactly?

stable mountainBOT Sep 23, 2020, 4:18 PM

#

Hey @queen dawn!

Uh-oh! It looks like your message got zapped by our spam filter. We currently don't allow .txt attachments, so here are some tips to help you travel safely:

• If you attempted to send a message longer than 2000 characters, try shortening your message to fit within the character limit or use a pasting service (see below)

• If you tried to show someone your code, you can use codeblocks
(run !code-blocks in #bot-commands for more information) or use a pasting service like:

https://paste.pythondiscord.com

queen dawn Sep 23, 2020, 4:18 PM

#

Let me get a pastebin

#

https://paste.pythondiscord.com/kemezifigi.css

neon garnet Sep 23, 2020, 4:20 PM

#

Do you have WSL2 enabled/installed?

green oriole Sep 23, 2020, 4:21 PM

#

You don't need WSL2 on pro edition

#

At least you're not supposed to

neon garnet Sep 23, 2020, 4:21 PM

#

Right, just checking an edge case as well

green oriole Sep 23, 2020, 4:21 PM

#

Maybe hyperv isn't enabled though

queen dawn Sep 23, 2020, 4:21 PM

#

I think I have WSL2?

#

Pretty sure it asked to download that lemon_thinking

thorny obsidian Sep 23, 2020, 4:22 PM

#

I know I had to disable a setting in my bios to allow docker to use hyperv

queen dawn Sep 23, 2020, 4:23 PM

#

What setting?

green oriole Sep 23, 2020, 4:23 PM

#

Maybe you could try this https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/enable-hyper-v

Enable Hyper-V on Windows 10

Install Hyper-V on Windows 10

thorny obsidian Sep 23, 2020, 4:23 PM

#

it was something about virtualization under advanced settings

#

let me see if I can find the SO for it

queen dawn Sep 23, 2020, 4:24 PM

#

Oh I know that

#

Let me try a sec

#

I think it worked lemon_glass

#

Oh

#

Nope

#

But discord is fixed if it's sopme how related

#

https://pastebin.com/xQ358cQp

Pastebin

System.InvalidOperationException:Failed to set version to docker-de...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

green mesa Sep 23, 2020, 4:37 PM

#

📎 Screenshot_2020-09-23-22-07-30-282.jpeg

#

Don't know y I got this

#

For windows pro and windows home u have to enable visualisation differently

#

in windows pro when u boot pc just press 2-3 time F2 and in setting enable visualisation

#

And then boot the pc

#

Yesterday I enabled visualisation of my windows pro for docker

#

With this method

queen dawn Sep 23, 2020, 4:44 PM

#

I did

#

I enabled the Virtulaziation in the BIOS

green mesa Sep 23, 2020, 4:46 PM

#

Ok then where r u stuck in installing docker?

queen dawn Sep 23, 2020, 4:46 PM

#

wym

#

I started the installer

#

then restarted when askled

#

then it wanted me to seperatly install linux something something

#

then I installed

#

restarted

#

and now when ever I start the PC I get the error message linked above

green mesa Sep 23, 2020, 4:51 PM

#

I don't have experience with docker, sorry 😔

eternal owl Sep 23, 2020, 4:53 PM

#

u need 03 instead of 3 @green mesa

green mesa Sep 23, 2020, 4:53 PM

#

I tried with that also

#

📎 Screenshot_2020-09-23-22-24-02-704.jpeg

eternal owl Sep 23, 2020, 4:54 PM

#

its not taking that 0

green mesa Sep 23, 2020, 4:54 PM

#

Don't know why it's happening

#

📎 Screenshot_2020-09-23-22-07-14-710.jpeg

eternal owl Sep 23, 2020, 4:54 PM

#

also, take it as a string instead of an int

green mesa Sep 23, 2020, 4:54 PM

#

Thinking of doing this way

eternal owl Sep 23, 2020, 4:55 PM

#

u can actully use date directly

#

from datetime import date

green mesa Sep 23, 2020, 4:55 PM

#

Ok

neon garnet Sep 23, 2020, 4:58 PM

#

First time set up sure does take a while

#

F i n a l l y

📎 unknown.png

obsidian patio Sep 23, 2020, 5:09 PM

#

stop being so pure

short snow Sep 23, 2020, 5:09 PM

#

lol

#

:failmail: ?

green oriole Sep 23, 2020, 5:10 PM

#

Pure's bot doesn't have access to the emoji apparently

subtle kraken Sep 23, 2020, 5:10 PM

#

emote used to say that bot failed to send the DM with infraction

short snow Sep 23, 2020, 5:10 PM

#

but the emoji uses id right?

#

and there is no need for that

#

someone had told me this earlier

green mesa Sep 23, 2020, 5:11 PM

#

I like that reason 😅

subtle kraken Sep 23, 2020, 5:11 PM

#

the bot must be in same server as the emoji to be able to use it

#

pretty sure majority if not all mod emojis are used in <:name:ID> format so they can be used cacheless

short snow Sep 23, 2020, 5:14 PM

#

ok

queen dawn Sep 23, 2020, 5:56 PM

#

Can someone help me?

#

https://pastebin.com/xQ358cQp I'm trying to install Docker

Pastebin

System.InvalidOperationException:Failed to set version to docker-de...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

#

and jsut nothing f***ing works

thorny obsidian Sep 23, 2020, 5:58 PM

#

What windows version are you on?

queen dawn Sep 23, 2020, 6:00 PM

#

10 enterprise

thorny obsidian Sep 23, 2020, 6:03 PM

#

To confirm, virtualization in the BIOS is turned on and HyperV is also enabled?

queen dawn Sep 23, 2020, 6:04 PM

#

HyperV and SVM

thorny obsidian Sep 23, 2020, 6:05 PM

#

Do you have a fresh download of the docker desktop to install?

queen dawn Sep 23, 2020, 6:05 PM

#

Yep

#

Want me to try to reinstall it?

thorny obsidian Sep 23, 2020, 6:05 PM

#

Yeah let's go for it

queen dawn Sep 23, 2020, 6:05 PM

#

Okay

#

Let me just recheck in the BIOPS

#

Im now checking the bios

#

And I don't see hyperV

#

Only see SVM Mode

thorny obsidian Sep 23, 2020, 6:09 PM

#

HyperV won't be in the BIOS settings, it's a windows feature

queen dawn Sep 23, 2020, 6:09 PM

#

Oh

#

How do I enable that?

#

Wakt

#

Let me Google

queen dawn Sep 23, 2020, 6:37 PM

#

Okay after a couple of times trying to install hyper V it always gets stuck in the same place

#

what can I do?

thorny obsidian Sep 23, 2020, 6:38 PM

#

What is it getting stuck on?

queen dawn Sep 23, 2020, 6:38 PM

#

on the download

#

at about 20%?

#

I used power shell

#

not trying on cmd

#

but I don't see it getting any better...

thorny obsidian Sep 23, 2020, 6:40 PM

#

do you mean enabling hyperV? It shouldn't be a download

queen dawn Sep 23, 2020, 6:40 PM

#

Download?

#

I found on docs.microsoft.com that I should do it throught powershell or cmd

#

https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/enable-hyper-v

Enable Hyper-V on Windows 10

Install Hyper-V on Windows 10

thorny obsidian Sep 23, 2020, 6:41 PM

#

well, you can try enabling it through the settings and see if that works

mellow hare Sep 23, 2020, 6:45 PM

#

Don't you have to do something special....

#

Hold on

queen dawn Sep 23, 2020, 6:47 PM

#

?

#

Let me try

mellow hare Sep 23, 2020, 6:47 PM

#

Yeah I think you have to do it via the Windows Features thing

queen dawn Sep 23, 2020, 6:47 PM

#

Could it be because the docker installer is running

mellow hare Sep 23, 2020, 6:47 PM

#

Possibly

queen dawn Sep 23, 2020, 6:48 PM

#

okay I pressed quit should I try now?

mellow hare Sep 23, 2020, 6:48 PM

#

Go to your Programs and Features Window (where you would go to uninstall stuff)

#

Then on the left hand side you'll select Turn Windows Features on or off

#

And then you'll click the check next to Hyper-V. It'll start downloading stuff and probably ask you to restart your machine

queen dawn Sep 23, 2020, 6:50 PM

#

I think it finally worked
!

#

It's asking to restart

#

Should I restart?

mellow hare Sep 23, 2020, 6:50 PM

#

Yeppers

#

I had to go through the same process when I tried to get Docker up and running

queen dawn Sep 23, 2020, 7:04 PM

#

Still doesn't work lemon_enraged

#

https://pastebin.com/a398VpKV

Pastebin

System.InvalidOperationException:Failed to set version to docker-de...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

#

I'll try top reinstall

#

but even since I downloaded the docker I've had a problem with my PC

#

sometimes it just doesn't boot to windows

#

Anyone? I'm really tried of this.. been on this for a few hours with no progress

queen dawn Sep 23, 2020, 7:34 PM

#

I've been told it's not a good idea to use a docker on Windows

#

so I should go back to not use a docker?

thorny obsidian Sep 23, 2020, 7:38 PM

#

I haven't had any issue with docker on Windows. Honestly I would start from scratch and delete and of the docker files you have so far and double check your settings for both HyperV and WSL 2 and go through the install instructions again.

queen dawn Sep 23, 2020, 7:39 PM

#

Okay

#

Thank you

thorny obsidian Sep 23, 2020, 7:39 PM

#

That error messages suggest something funky with the WSL 2 engine, so maybe disabling wsl2 and just using hyperV might be the way to go?

sullen phoenix Sep 23, 2020, 8:13 PM

#

approved! @obsidian patio

obsidian patio Sep 23, 2020, 8:14 PM

#

Aah awesome! Thanks 😄

sullen phoenix Sep 23, 2020, 8:15 PM

#

no problem

obsidian patio Sep 23, 2020, 8:24 PM

#

Could someone else review it as well?

dusky shoreBOT Sep 23, 2020, 8:36 PM

#

GitHub

PROpen [seasonalbot] #449 Add extension management commands

queen dawn Sep 23, 2020, 8:50 PM

#

That error messages suggest something funky with the WSL 2 engine, so maybe disabling wsl2 and just using hyperV might be the way to go?
@thorny obsidian how do I do that

#

now found some windows files were corruped

#

Trying again

green mesa Sep 24, 2020, 3:32 AM

#

.issue 432

dusky shoreBOT Sep 24, 2020, 3:32 AM

#

GitHub

IssueOpen [seasonalbot] #432 Update discord.py version to 1.4.1

green mesa Sep 24, 2020, 3:33 AM

#

I have changed git to ffmpeg in docker file

#

Now it's ready for review

neon garnet Sep 24, 2020, 3:40 AM

#

Is installing ffmpeg necessary here for the Dockerfile? I don't really see it on the blame for said file.

#

Either way, I'll launch it after I grab lunch.

green mesa Sep 24, 2020, 3:40 AM

#

For spooky sound command we need

#

Ok pure

eternal owl Sep 24, 2020, 3:46 AM

#

https://github.com/python-discord/site/pull/378
One more review to go!

GitHub

Add pagination and bulk update support for User(discord user) seria...

closes #375
Implementation
Pagination

Using built in PageNumberPagination with the default page size being 10,000 user objects(dicts) per page.
2 query parameteres to control page number and page ...

neon garnet Sep 24, 2020, 4:34 AM

#

Building containers does sure take a while

#

@green mesa I've successfully built your PR using Docker but discord.py seems to error out with the following traceback:

seasonalbot    | 09/24/20 04:41:12 - bot.exts.evergreen.error_handler ERROR: Unhandled command error: 'NoneType' object has no attribute 'connect'
seasonalbot    | Traceback (most recent call last):
seasonalbot    |   File "/usr/local/lib/python3.8/site-packages/discord/ext/commands/core.py", line 85, in wrapped
seasonalbot    |     ret = await coro(*args, **kwargs)
seasonalbot    |   File "/bot/bot/exts/halloween/spookysound.py", line 37, in spookysound
seasonalbot    |     voice = await self.channel.connect()
seasonalbot    | AttributeError: 'NoneType' object has no attribute 'connect'

#

Might have something to do with my test server

hardy gorge Sep 24, 2020, 4:49 AM

#

It probably "gets" a channel somewhere based on an ID. If a channel with that ID is not found on your guild, that get channel function will return None

#

Good example of the dangers of None

neon garnet Sep 24, 2020, 4:50 AM

#

It obtains a channel ID from constants.py which I assume is tightly coupled with this server

hardy gorge Sep 24, 2020, 4:52 AM

#

Most likely, yeah. There are some IDs in there that get their value from an environment variable so you can configure it to a test server. I'm not intimately familiar with Seasonal Bot's constant system, though; not sure if the design is to just create a lot of environment variables for all these channel constants.

green mesa Sep 24, 2020, 5:05 AM

#

@neon garnet have u mentioned voice channel id in constants.py?

neon garnet Sep 24, 2020, 5:08 AM

#

Yes, currently building w/o installing ffmpeg now

obsidian patio Sep 24, 2020, 5:09 AM

#

If anyone has time to review this as well, it would be awesome

dusky shoreBOT Sep 24, 2020, 5:09 AM

#

GitHub

PROpen [seasonalbot] #449 Add extension management commands

green mesa Sep 24, 2020, 5:55 AM

#

When good first issue tag gets added to any issue?

neon garnet Sep 24, 2020, 5:56 AM

#

Not quite sure what you mean

green mesa Sep 24, 2020, 5:57 AM

#

📎 Screenshot_2020-09-24-11-26-59-993.jpeg

#

This good first issue tag

#

I mean label sorry

neon garnet Sep 24, 2020, 6:00 AM

#

Typically that's added for issues that can easily be resolved by first-time contributors or beginners

green mesa Sep 24, 2020, 6:07 AM

#

Ohk

#

We use postgres for both bot?

obsidian patio Sep 24, 2020, 6:20 AM

#

At least for @stable mountain

exotic ember Sep 24, 2020, 6:20 AM

#

@dusky shore does not use a database

subtle kraken Sep 24, 2020, 6:21 AM

#

To be fair Python doesn't use Postgres so to say
It interacts with it through the site

neon phoenix Sep 24, 2020, 6:22 AM

#

That's why commands like kick, ban, etc are really quick

#

Because instead of manipulating the db directly, it sends a request to the server, which manipulates the db

green mesa Sep 24, 2020, 6:25 AM

#

Hmm then @neon garnet how r u planning to make emoji count command without db😅

#

R u planning to write to file or something

neon garnet Sep 24, 2020, 6:26 AM

#

You can easily obtain the emojis that a guild has

#

!doc discord.Guild.emojis

green mesa Sep 24, 2020, 6:27 AM

#

I wnt to get number of uses of particular emoji 😅

stable mountainBOT Sep 24, 2020, 6:27 AM

#

`discord.Guild.emojis`

emojis```
All emojis that the guild owns.

Type Tuple[[`Emoji`](#discord.Emoji "discord.Emoji"), …]

neon garnet Sep 24, 2020, 6:27 AM

#

@green mesa Well, that's not really possible

green mesa Sep 24, 2020, 6:27 AM

#

This only gives the list of emoji that guild has

neon garnet Sep 24, 2020, 6:27 AM

#

and that's out of scope for my feature

green mesa Sep 24, 2020, 6:28 AM

#

Ok

#

Let me read the issue again then😅

#

I think I have missed something

#

Or misunderstood

neon garnet Sep 24, 2020, 8:23 AM

#

.issue 1170 bot

dusky shoreBOT Sep 24, 2020, 8:23 AM

#

GitHub

IssueOpen [bot] #1170 Infraction subcommand for amending infraction reasons

neon garnet Sep 24, 2020, 8:23 AM

#

Currently waiting for approvals/suggestions on this feature although I have a rudimentary implementation set up

green oriole Sep 24, 2020, 8:25 AM

#

It looks pretty good, although I can’t judge if this feature is needed

#

The implementation and the UI seems to be pretty straightforward

#

I think you can just go for it, we don’t really approve issues on @stable mountain

hardy gorge Sep 24, 2020, 8:35 AM

#

I guess what they are after is suggestions from the moderation team

#

Staff should be able to self-assign issues anyway

cold island Sep 24, 2020, 8:37 AM

#

commented

green oriole Sep 24, 2020, 8:51 AM

#

Might as well ask #mods then lemon_pleased

glass pecan Sep 24, 2020, 8:51 AM

#

sure i'll send a ping, why not

#

annoyed a few tens of people

#

if there's nothing after a while, i think we can trust it's a sane implementation

cold island Sep 24, 2020, 9:27 AM

#

annoyed a few tens of people
we're used to it

green mesa Sep 24, 2020, 9:37 AM

#

😅

green oriole Sep 24, 2020, 9:41 AM

#

Don’t forget to assign yourself on the issue @neon garnet lemon_pleased

neon garnet Sep 24, 2020, 9:42 AM

#

Thanks for the heads up

green oriole Sep 24, 2020, 9:42 AM

#

np

obsidian patio Sep 24, 2020, 9:48 AM

#

What role do you need to assign yourself issues?

glass pecan Sep 24, 2020, 9:48 AM

#

you need to be part of the github staff group

#

if you're not in there, ask an owner for privs

obsidian patio Sep 24, 2020, 9:49 AM

#

Aah, alright. I should be able to, then. How is it with adding labels?

cold island Sep 24, 2020, 9:50 AM

#

You mean who can edit labels? Should be the same

glass pecan Sep 24, 2020, 9:50 AM

#

same deal yep

obsidian patio Sep 24, 2020, 9:51 AM

#

So I can add WIP, importance level and such labels?

cold island Sep 24, 2020, 9:51 AM

#

Yeah

#

Are you asking if you technically can, or if you're allowed to?

glass pecan Sep 24, 2020, 9:52 AM

#

you're allowed to, just understand a core dev may change it lol

#

i doubt you'll have issues though, they're pretty self explanatory

obsidian patio Sep 24, 2020, 9:55 AM

#

Perfect, thanks

green oriole Sep 24, 2020, 9:56 AM

#

I am a bit clueless about how to make codespaces throwaway, since you need a config file for the bots

#

The only thing I can think of is using dotfiles to store configs, and maybe encrypt them

obsidian patio Sep 24, 2020, 9:56 AM

#

Wait, could (should) I approve on SeasonalBot as well?

#

The label

glass pecan Sep 24, 2020, 9:57 AM

#

yes you're allowed to approve if you're reasonably sure it's a useful feature

#

if its a bit iffy, it's better to not make the jump and just ask in here

obsidian patio Sep 24, 2020, 10:22 AM

#

Alright. Thanks @glass pecan 😄

green mesa Sep 24, 2020, 12:45 PM

#

@eternal owl now my pr is ready for review

#

.pr 455

dusky shoreBOT Sep 24, 2020, 12:45 PM

#

GitHub

PROpen [seasonalbot] #455 Partnerzodiac

green mesa Sep 24, 2020, 12:47 PM

#

📎 m.PNG

#

📎 d.PNG

#

now u can type month as str or int UwU

gusty sonnet Sep 24, 2020, 12:51 PM

#

You can do
__C__onfident
__A__nalytical
...

#

It will be easier to read imo

green mesa Sep 24, 2020, 12:52 PM

#

ok

#

changing rn

gusty sonnet Sep 24, 2020, 12:53 PM

#

Also consider linting your json as well, the spaces in there are inconsistent

#

📎 unknown.png

green mesa Sep 24, 2020, 12:53 PM

#

ok

#

ok

balmy sparrow Sep 24, 2020, 12:55 PM

#

That's why commands like kick, ban, etc are really quick
I don’t really contribute here, but was curious how this is faster?
#dev-contrib message

eternal owl Sep 24, 2020, 12:55 PM

#

I will review the pr in about an hour @green mesa

green mesa Sep 24, 2020, 12:55 PM

#

ok

#

@gusty sonnet i just linted and i didnt get any error from json

#

i used pipenv run lint command

gusty sonnet Sep 24, 2020, 1:06 PM

#

Hmm, you probably aren't using ESlint right? 😄

#

Well, try to format it then

#

like adding space between :{ / keep spacing consistent at 2 or 4, etc

green mesa Sep 24, 2020, 1:48 PM

#

done

#

Soon I will be ready to work on my 4th issue😁

green mesa Sep 24, 2020, 2:10 PM

#

📎 Screenshot_2020-09-24-19-40-34-055.jpeg

#

On Android last letter is not getting underlined 😔

#

It's again discord bug

#

Any recommendations what should I do

tough imp Sep 24, 2020, 2:14 PM

#

what does your markdown look like?

#

sadly Discord markdown is not very consistent across platforms

cold moon Sep 24, 2020, 2:17 PM

#

Discord should really make this look exactly same in every platform.

obsidian patio Sep 24, 2020, 2:23 PM

#

Especially mobile

cold moon Sep 24, 2020, 2:27 PM

#

Should I open issue in site repo about (Dewikification) creating app for serving contributing guides?

green oriole Sep 24, 2020, 2:38 PM

#

I think you should focus on your already open PRs first

eternal owl Sep 24, 2020, 3:04 PM

#

lot of typos @green mesa , lol

green mesa Sep 24, 2020, 3:05 PM

#

@eternal owl where😅

eternal owl Sep 24, 2020, 3:06 PM

#

📎 unknown.png

#

📎 unknown.png

green mesa Sep 24, 2020, 3:06 PM

#

Lol

#

😅

#

Tnx

#

Btw is command working

#

Or I need to change something😅

#

I am fixing my typo rn😁

green oriole Sep 24, 2020, 3:07 PM

#

There’s a PC extension for spellchecking, it is pretty great, I use it personally

green mesa Sep 24, 2020, 3:07 PM

#

For vsc?

green oriole Sep 24, 2020, 3:07 PM

#

Ah, I don’t know

green mesa Sep 24, 2020, 3:07 PM

#

Ok let me check

#

I don't know y my pc got hanged 😔

eternal owl Sep 24, 2020, 3:11 PM

#

when someone enters an invalid zodiac name, can we display the list fo zodiac signs instead of the error message? what do you guys say?

green mesa Sep 24, 2020, 3:12 PM

#

I like the idea

eternal owl Sep 24, 2020, 3:13 PM

#

cuz people like me might not know the spelling of some zodiac signs, lol

green mesa Sep 24, 2020, 3:13 PM

#

Yeh

eternal owl Sep 24, 2020, 3:13 PM

#

lemme make a comment on the PR about this

green mesa Sep 24, 2020, 3:13 PM

#

We can give them 3 chances to type out right zodiac name

eternal owl Sep 24, 2020, 3:14 PM

#

no

#

just sending a list of zodiac names will be good enough

#

then they can re-invoke the command

green mesa Sep 24, 2020, 3:16 PM

#

Hmm ok

eternal owl Sep 24, 2020, 3:41 PM

#

sorry for being slow, its going to take a lil longer @green mesa

green mesa Sep 24, 2020, 3:42 PM

#

Np I will edit by code tomorrow 😁

eternal owl Sep 24, 2020, 3:42 PM

#

👍

green mesa Sep 24, 2020, 3:42 PM

#

U can take your time

eternal owl Sep 24, 2020, 3:43 PM

#

so u hardcoded the dates for capricorn

📎 unknown.png

#

now u did this cuz the regular checks werent working?

#

the reason it fails, is
the end value is 2020-01-19

#

instead it should be 2021

#

capricorn goes from 2020-12-22 to 2021-12-19

#

but in ur code, it goes from 2020-12-22 to 2020-12-19

cold moon Sep 24, 2020, 3:53 PM

#

Why I'm getting:

docker.errors.APIError: 500 Server Error: Internal Server Error ("b'Mounts denied: \r\nThe paths /opt/pythondiscord/seasonalbot/data and /opt/pythondiscord/seasonalbot/log\r\nare not shared from OS X and are not known to Docker.\r\nYou can configure shared paths from Docker -> Preferences... -> File Sharing.\r\nSee https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.\r\n.'")

when running SeasonalBot with Docker

green mesa Sep 24, 2020, 3:56 PM

#

@eternal owl if I make any change it start sending Capricorn only

#

That's y I hard-coded for Capricorn only

#

Others are dynamic

#

It fetches value from json and make datetime obj

#

And then bot compares

green oriole Sep 24, 2020, 3:57 PM

#

@cold moon your docker isn't properly configured to accept volumes

#

Maybe not running as root? (or whatever is the macos equivalent)

eternal owl Sep 24, 2020, 3:59 PM

#

i found the fix @green mesa , i will include it in the review

green mesa Sep 24, 2020, 4:00 PM

#

Ty

cold moon Sep 24, 2020, 4:05 PM

#

@exotic ember https://github.com/python-discord/seasonalbot/pull/397#pullrequestreview-491989479 This is not possible to add newline to game for compact mode. Discord don't allow that.

GitHub

Tic-tac-toe command by ks129 · Pull Request #397 · python-discord/s...

Relevant Issues

Closes #300
Description

I added tictactoe command like described in issue, + added tictactoe history|log to show a list of current session games and tictactoe history|log show &a...

timid sentinel Sep 24, 2020, 4:08 PM

#

I think a blank/empty character and then a newline works

brazen charm Sep 24, 2020, 4:09 PM

#

Discord won't strip out zero width spaces

cold moon Sep 24, 2020, 4:12 PM

#

@brazen charm Thanks, this worked

cold moon Sep 24, 2020, 4:56 PM

#

But this give another thing: Emojis will be too small in Cozy mode.

#

So should this have really small icons, but format well in compact or don't format that well in compact mode and have good sized emojis

#

📎 Screenshot_2020-09-24_at_19.57.50.png

green mesa Sep 24, 2020, 4:58 PM

#

Looks nice

cold moon Sep 24, 2020, 4:59 PM

#

📎 Screenshot_2020-09-24_at_19.58.46.png

#

This is how this was

short snow Sep 24, 2020, 5:02 PM

#

tic tac toe?

green mesa Sep 24, 2020, 5:03 PM

#

Yeh

sharp timber Sep 24, 2020, 5:30 PM

#

Should I re-request review once I've committed something that implements requested changes, or should I allow the auto-request from pushing a new commit do that?

green oriole Sep 24, 2020, 5:34 PM

#

Hey @obsidian patio I'll be doing some changes on the permissions tomorrow, mind if I change the !role permissions in the same go?

obsidian patio Sep 24, 2020, 5:35 PM

#

Aah, sounds great. I'll assign you

subtle kraken Sep 24, 2020, 5:36 PM

#

I'd say you don't need to re-request but I wouldn't be opposed to it so we don't forget about the PR @sharp timber

green oriole Sep 24, 2020, 5:36 PM

#

@sharp timber you can ask for review again, yeah, although I'm not sure what you mean by auto-request Damn, sorry for the second ping

obsidian patio Sep 24, 2020, 5:36 PM

#

Now someone just has to press the magic button with the extensions command

sharp timber Sep 24, 2020, 5:36 PM

#

"Changes requested" has one person, and "2 pending reviews" has two other people added by the github bot (?)

subtle kraken Sep 24, 2020, 5:37 PM

#

I think mark will get to it regardless

#

as for lemon and Hem, it doesn't have to be them to review it

green oriole Sep 24, 2020, 5:37 PM

#

Right, you'll have to re-request to review the person who requested changes again, anyway

sharp timber Sep 24, 2020, 5:38 PM

#

Gotcha

#

I thought it was like that but wasn't sure

#

Should be all ready to go now then

brazen charm Sep 24, 2020, 5:38 PM

#

The repos are set to request 2 reviews from the core devs when opened, after that it only notifies the subscribed people

green oriole Sep 24, 2020, 5:39 PM

#

magic button pressed vest

obsidian patio Sep 24, 2020, 5:39 PM

#

@dusky shore development will be much smoother now, I'd say

brazen charm Sep 24, 2020, 5:39 PM

#

So the manual request will pop up even when not subscribed, but most of the time I'd say people who reviewed will take a look later when addressed

green oriole Sep 24, 2020, 5:40 PM

#

Yes, seasonal is waaayyy faster

subtle kraken Sep 24, 2020, 5:41 PM

#

Im looking at your PR currently, Bast

green mesa Sep 24, 2020, 5:51 PM

#

@subtle kraken can u also have a look at my pr for partnerzodiac sub command 🙂

#

.pr 455

dusky shoreBOT Sep 24, 2020, 5:52 PM

#

GitHub

PROpen [seasonalbot] #455 Partnerzodiac

subtle kraken Sep 24, 2020, 6:05 PM

#

bit later

#

fwiw am mainly available sat-sun for reviews

eternal owl Sep 24, 2020, 6:14 PM

#

@green mesa review submitted, quite a lot of requested changes.

#

for the JSON, I said we could use iso-date format strings instead of a list to store month and date numbers, to save u the time to replace all that, I have already done it (sent the json file in DM)

sharp timber Sep 24, 2020, 9:26 PM

#

So, by clicking "Resolve Conversation" I've been getting these: https://discordapp.com/channels/267624335836053506/622895325144940554/758796395699896320

mellow hare Sep 24, 2020, 10:42 PM

#

Allllllllllrighty folks, time for me to have a call to action. Anyone feel like doing me a solid and doing a code review? https://github.com/python-discord/site/pull/378

GitHub

Add pagination and bulk update support for User(discord user) seria...

closes #375
Implementation
Pagination

Using built in PageNumberPagination with the default page size being 10,000 user objects(dicts) per page.
2 query parameteres to control page number and page ...

green oriole Sep 25, 2020, 6:26 AM

#

So, by clicking "Resolve Conversation" I've been getting these: https://discordapp.com/channels/267624335836053506/622895325144940554/758796395699896320
@sharp timber nah, that's because you commented on one of the review comment, github is just a bit silly

eternal owl Sep 25, 2020, 10:06 AM

#

@mellow hare can you can review https://github.com/python-discord/bot/pull/1165
this PR too please because this one is directly linked to site PR which you reviewed recently

GitHub

Smart syncing of Users by RohanJnr · Pull Request #1165 · python-di...

Closes #1119
Implementation

Refactor Code to support paginated response.
Bulk Update Users whose properties have changed.
Update Users via PATCH method by only sending user ID and modified user...

neon garnet Sep 25, 2020, 11:51 AM

#

Off-topic names are chosen randomly right?

green oriole Sep 25, 2020, 11:51 AM

#

Well, yes

neon garnet Sep 25, 2020, 11:52 AM

#

Currently reading through https://github.com/python-discord/site/blob/5e8b55146a13b99453595337f33c06d96767b0d5/pydis_site/apps/api/viewsets/bot/off_topic_channel_name.py#L15, what exactly does "used" mean in this context?

green oriole Sep 25, 2020, 11:53 AM

#

If they have been already used once in this rotation

#

So yeah, it is random, but not fully random, we make sure they all appear at least once

neon garnet Sep 25, 2020, 11:53 AM

#

Right right

green mesa Sep 25, 2020, 1:24 PM

#

@eternal owl y u wnt to take date in isoformat only?

neon garnet Sep 25, 2020, 1:25 PM

#

It's much more pragmatic than just an array of numbers

green mesa Sep 25, 2020, 1:27 PM

#

pithink

#

discord.ext.commands.errors.ExtensionFailed: Extension 'bot.exts.valentines.valentine_zodiac' raised an error: TypeError: descriptor 'isoformat' for 'datetime.datetime' objects doesn't apply to a 'str' object

#

i think again i need to make list

hardy gorge Sep 25, 2020, 1:33 PM

#

Uh, what did you do?

green mesa Sep 25, 2020, 1:33 PM

#

            for zodiac_name, zodiac_data in zodiac_fact.items():
                zodiac_start = zodiac_data["start_at"].split("-")
                zodiac_fact["start_at"] = datetime.isoformat(zodiac_start[0],zodiac_start[1],zodiac_start[2])```

#

{
  "Aries": {
    "start_at": "2020-03-21",```

#

i think i need to use %Y-%m-%d to split

tough imp Sep 25, 2020, 1:37 PM

#

isoformat is used to serialize a datetime object into a string, I think you want to do the opposite?

#

fromisoformat takes the whole string and parses it, you don't need to split it yourself

#

>>> from datetime import datetime
>>> 
>>> datetime.fromisoformat("2020-03-21")
datetime.datetime(2020, 3, 21, 0, 0)

#

here's the docs: https://docs.python.org/3/library/datetime.html#datetime.datetime.fromisoformat

eternal owl Sep 25, 2020, 1:44 PM

#

i did mention how to do it in the review

📎 unknown.png

#

https://github.com/python-discord/seasonalbot/pull/455#discussion_r494487171

mellow hare Sep 25, 2020, 1:45 PM

#

Ice I'll look at the one you linked me today

eternal owl Sep 25, 2020, 1:45 PM

#

thanks 😄

mellow hare Sep 25, 2020, 1:45 PM

#

I need to start kicking butts to get other people to review

green mesa Sep 25, 2020, 1:45 PM

#

same thing i tried

#

and getting this error

eternal owl Sep 25, 2020, 1:45 PM

#

i still need to change the testcase i guess, cuz I changed the implementation

mellow hare Sep 25, 2020, 1:45 PM

#

Like even if a handful of staff or regs can do one a week or hell even 1 every 2 weeks I'd be happy

green mesa Sep 25, 2020, 1:45 PM

#

discord.ext.commands.errors.ExtensionFailed: Extension 'bot.exts.valentines.valentine_zodiac' raised an error: TypeError: descriptor 'isoformat' for 'datetime.datetime' objects doesn't apply to a 'str' object

eternal owl Sep 25, 2020, 1:46 PM

#

show code

green mesa Sep 25, 2020, 1:46 PM

#

                print(zodiac_data)
                zodiac_data['start_at'] = datetime.isoformat(zodiac_data['start_at'])```

eternal owl Sep 25, 2020, 1:46 PM

#

I really appreciate your hardwork :p @mellow hare

#

its fromisoformat

#

instead of isoformat

green mesa Sep 25, 2020, 1:47 PM

#

lol

eternal owl Sep 25, 2020, 1:47 PM

#

xD

#

use date instead of datetime also

#

as we don't really care about time

#

from datetime import date
date.fromisoformat()

green mesa Sep 25, 2020, 1:47 PM

#

tnx buddy let me try

eternal owl Sep 25, 2020, 1:48 PM

#

👍

#

ur best friend is the python repl

#

i do a bunch of testing there

#

a quick note @mellow hare , the bot PR uses the changes in the site PR

#

so you will have to run the site which has those

mellow hare Sep 25, 2020, 1:49 PM

#

Yeah I wasn't going to merge it until I knew the site PR was live

eternal owl Sep 25, 2020, 1:49 PM

#

oki