#dev-contrib | Python | Page 44

molten bough Feb 9, 2020, 4:27 PM

#

haha

eternal owl Feb 9, 2020, 4:27 PM

#

oh

#

feature issues are also called tickets?

glass pecan Feb 9, 2020, 4:27 PM

#

tbh i don't know the origin of why i called them that

molten bough Feb 9, 2020, 4:27 PM

#

issues == tickets

eternal owl Feb 9, 2020, 4:27 PM

#

okay

glass pecan Feb 9, 2020, 4:28 PM

#

but i think of them like support or job tickets

#

which they are sorta

eternal owl Feb 9, 2020, 4:28 PM

#

okay

glass pecan Feb 9, 2020, 4:28 PM

#

ok, you'll want to space out the "the problems we know are with an extra line above it

#

it needs to be clearly structured, so we can see that the statement is beginning the list you have under it

#

another option is to use a header

eternal owl Feb 9, 2020, 4:29 PM

#

okay

glass pecan Feb 9, 2020, 4:29 PM

#

# Current Problems as an example

#

and then the list within it

eternal owl Feb 9, 2020, 4:30 PM

#

got it

glass pecan Feb 9, 2020, 4:30 PM

#

good judgement on reducing the header level

eternal owl Feb 9, 2020, 4:30 PM

#

I will use 2 # , 1 is too big

molten bough Feb 9, 2020, 4:31 PM

#

there is a semantic reasoning to the different headers too

glass pecan Feb 9, 2020, 4:31 PM

#

do you know how to show an image in markdown?

eternal owl Feb 9, 2020, 4:31 PM

#

nop....

#

i only know that markdown is for code

glass pecan Feb 9, 2020, 4:32 PM

#

here's a useful reference

#

https://guides.github.com/features/mastering-markdown/

eternal owl Feb 9, 2020, 4:32 PM

#

thx!

glass pecan Feb 9, 2020, 4:32 PM

#

so instead of the inline link, you'd use

![image](https://cdn.discordapp.com/attachments/542272993192050698/676055841220067338/Screenshot_20200209-131812.jpg)

molten bough Feb 9, 2020, 4:32 PM

#

Markdown is truly one of the most useful things going

#

it's a shame the guy that came up with it is so grabby

eternal owl Feb 9, 2020, 4:33 PM

#

updated

glass pecan Feb 9, 2020, 4:34 PM

#

ok so your first issue is:

The command does a double embed edit which means it gets rate limited pretty quickly.

#

I don't know what you mean by this

eternal owl Feb 9, 2020, 4:34 PM

#

dont ask me what it means

molten bough Feb 9, 2020, 4:34 PM

#

the embed is edited twice

#

a double embed edit

eternal owl Feb 9, 2020, 4:35 PM

#

if you spam the right paginate fast, then you dont get anything

glass pecan Feb 9, 2020, 4:35 PM

#

in what context. when it starts, when it's navigated, when it's just sitting around being itself

molten bough Feb 9, 2020, 4:35 PM

#

it does it if you don't spam as well

eternal owl Feb 9, 2020, 4:35 PM

#

when u navigate

molten bough Feb 9, 2020, 4:35 PM

#

When you click a navigation reaction, it blanks the embed, and then fills it again

glass pecan Feb 9, 2020, 4:35 PM

#

ok

eternal owl Feb 9, 2020, 4:35 PM

#

sometimes it dosent fill

#

it stands like that forever

glass pecan Feb 9, 2020, 4:35 PM

#

blanking is a pretty horrible method, but i reckon i know why it's done

#

but for now, lets adjust the wording to appropriately explain the issue

#

something like

#

When navigating using reactions, the embed is edited twice in succession, first making the embed blank and then with the new content. This sometimes results in slow updating and the embed staying blank.

eternal owl Feb 9, 2020, 4:37 PM

#

okay

glass pecan Feb 9, 2020, 4:37 PM

#

hopefully you can agree that is easier for others to understand and to easily reproduce the issue themselves when testing

eternal owl Feb 9, 2020, 4:38 PM

#

yep!

glass pecan Feb 9, 2020, 4:38 PM

#

then you have a line

#

(We need to figure out a way to solve this)

#

that's the entire point of an issue ticket

#

it can be removed

eternal owl Feb 9, 2020, 4:38 PM

#

okay

glass pecan Feb 9, 2020, 4:38 PM

#

next is about the user agent

#

you're describing the solution, not the problem

eternal owl Feb 9, 2020, 4:39 PM

#

okay lemme get that

glass pecan Feb 9, 2020, 4:39 PM

#

ok

eternal owl Feb 9, 2020, 4:39 PM

#

Should i mention the problem and the solution in the same place?

glass pecan Feb 9, 2020, 4:39 PM

#

you can in this case

eternal owl Feb 9, 2020, 4:39 PM

#

okay

glass pecan Feb 9, 2020, 4:40 PM

#

keep in mind, it's more of a "this should be replaced with something similar to the Python bot's User Agent, such as python3:python-discord/seasonalbot:1.0.0 (by /u/PythonDiscord)"

#

rather than a "change it to x"

#

sometimes the recommended fixes in issues aren't always the most suitable, as fixes are done in the PR stage

eternal owl Feb 9, 2020, 4:41 PM

#

okay

#

I said app/client

woeful thorn Feb 9, 2020, 4:41 PM

#

It's also more than just changing the user agent, you need to add an authentication flow for the API

#

Which also requires us to generate the credentials and add them to Seasonalbot's environment

glass pecan Feb 9, 2020, 4:41 PM

#

that's the next point, yep. it's missing from the issue currently

eternal owl Feb 9, 2020, 4:42 PM

#

i dont understand authentication flow

#

what credentials

glass pecan Feb 9, 2020, 4:42 PM

#

ok

#

for example the bot has an api token for authenticating with discord

#

without it, it can't interact with the api

eternal owl Feb 9, 2020, 4:43 PM

#

but reddit does not need one

glass pecan Feb 9, 2020, 4:43 PM

#

reddit requires one as per their developer terms

#

without that token, we lose benefits

eternal owl Feb 9, 2020, 4:43 PM

#

Oo i never knew that

glass pecan Feb 9, 2020, 4:43 PM

#

the rate limit is greatly decreased for example

eternal owl Feb 9, 2020, 4:44 PM

#

so I should set it to an env var

glass pecan Feb 9, 2020, 4:44 PM

#

you'll want to reference the implementation in the Python bot repo when you go to fix it

#

but in the issue ticket you'll just want to outline that it is missing and needs to be added

#

Currently the API does not use an authenticated request. We should make sure to use an app token from Reddit the same as the Python Bot does also. This bot will need one created by an admin specific to Seasonalbot.

eternal owl Feb 9, 2020, 4:46 PM

#

oki

glass pecan Feb 9, 2020, 4:48 PM

#

you'll also want to add in the error from Suhail's comment

eternal owl Feb 9, 2020, 4:50 PM

#

updated

glass pecan Feb 9, 2020, 4:53 PM

#

"In the code" isn't unnecessary to add, as a note. Any code changes is in the code, and tbh it's more important that it's actually about an output string that users see.

eternal owl Feb 9, 2020, 4:54 PM

#

okay

glass pecan Feb 9, 2020, 4:57 PM

#

good stuff

#

that's a much clearer issue ticket. we just merged a PR for issue ticket templates also that was worked on a while ago. so in future, there'll be more details requested, but hopefully it gives a better outline on what we need to see.

eternal owl Feb 9, 2020, 4:58 PM

#

cool

#

thanks for the guidance!

glass pecan Feb 9, 2020, 4:58 PM

#

no probs

eternal owl Feb 10, 2020, 2:07 AM

#

https://github.com/python-discord/seasonalbot/issues/348
is this ready to be approved?

GitHub

Problems with Reddit command. · Issue #348 · python-discord/seasonalbo...

Recently, the Reddit command PR (#346) was merged with a number of problems being overlooked. This issue is to outline the required fixes and any additional enhancements to the feature. Current Pro...

hardy gorge Feb 10, 2020, 5:13 AM

#

I think I've read some people had some additional considerations before we go ahead with it, so I'm not sure.

eternal owl Feb 10, 2020, 5:19 AM

#

okay

jade tiger Feb 10, 2020, 10:24 AM

#

What's the best/suggested way to pull changes from upstream? I'm about 600 commits behind, lol. It's part of an open PR and last time I tried to do something like that it didn't end well

green oriole Feb 10, 2020, 10:25 AM

#

You could create a new remote upstream and use git pull upstream/master inside your master branch

#

Once you have fetched it

#

But you should have write access to the repos, right?

jade tiger Feb 10, 2020, 10:33 AM

#

pull to master --> git pull origin/master to update branch? --> git push changes to branch?

#

yeah this was before I had write access, and I'm less likely to break something if I'm working on a fork 😂

green oriole Feb 10, 2020, 10:33 AM

#

pull upstream/master, not origin/master

#

You can’t break anything, you don’t have access to master, and the history is rewritable

jade tiger Feb 10, 2020, 10:40 AM

#

do I need to rebase to remove this nuisance thing?

📎 unknown.png

green oriole Feb 10, 2020, 10:40 AM

#

No, you shouldn’t use rebasing when you don’t need to

#

merging master gaves a merge commit anyway, it is just hidden by github when it is from the same remote

jade tiger Feb 10, 2020, 10:42 AM

#

ok so should be all good to go now, yeah?

green oriole Feb 10, 2020, 10:43 AM

#

Yes I think

jade tiger Feb 10, 2020, 10:43 AM

#

👍 cheers

green oriole Feb 10, 2020, 11:27 AM

#

Sir @mellow hare and @sullen phoenix, you were pretty interested in the re-eval functionality iirc, the PR is ready, if you have some time to review it 😄 https://github.com/python-discord/bot/pull/710

GitHub

Eval cog improvements by Akarys42 · Pull Request #710 · python-discor...

Now that snekbox support some external libraries (see python-discord/snekbox#51), I think this is a good time to work on some improvements :

Feature : Re-evaluate snippet with emoji reaction (clo...

eternal owl Feb 10, 2020, 1:21 PM

#

this is the together java server and they have a very good way of indicating whether a channel is free or not and that is the bot adding free emoji to the channel name

📎 unknown.png

molten bough Feb 10, 2020, 1:22 PM

#

I think they have a plan at this point

eternal owl Feb 10, 2020, 1:22 PM

#

Just wanted to show it xD

crude gyro Feb 10, 2020, 1:38 PM

#

I hate it, just for the record.

eternal owl Feb 10, 2020, 1:39 PM

#

okay

green oriole Feb 10, 2020, 1:46 PM

#

It is pretty ugly yeah

#

But I mean, c’mon they are Java devs, they don’t like beautiful things

crude gyro Feb 10, 2020, 1:46 PM

#

that 🆓 emoji is god awful

#

if they had made a custom one, maybe it would've looked okay

woeful thorn Feb 10, 2020, 1:47 PM

#

Ugliness isn’t really the problem, it’s that it’s equally as nondeterministic as the free command we already have

crude gyro Feb 10, 2020, 1:47 PM

#

yes, but arguably a little more immediate

green oriole Feb 10, 2020, 1:47 PM

#

The lack of space between the channel name and the emoji is bad too

crude gyro Feb 10, 2020, 1:47 PM

#

more convenient

#

but ultimately misleading and not the right solution

#

I think the bit of friction we have where users have to use the !free command, and the additional wording in the !free command that makes it clear that these might not in fact be free are kind of essential

#

!free

stable mountainBOT Feb 10, 2020, 1:49 PM

#

**Looking for a free help channel?**

#help-chestnut 1h 24m 44s inactive
#help-falafel 34m 56s inactive
#help-croissant 19m 52s inactive

crude gyro Feb 10, 2020, 1:49 PM

#

there are no promises made here that we can't deliver on

#

but a 🆓 emoji makes a promise that it cannot keep.

hardy gorge Feb 10, 2020, 1:50 PM

#

Honestly, I think the system we have in mind is far better and it isn't even that complicated

crude gyro Feb 10, 2020, 1:50 PM

#

agreed.

green oriole Feb 10, 2020, 1:50 PM

#

A clock emoji maybe, just to tell there wasn’t any message in a certain amount of time, not that the channel is indeed free?

#

Yep!

hardy gorge Feb 10, 2020, 1:50 PM

#

No, let's not make too many changes to the help channel system

#

I want a clean pilot test of the new system without any more shenanigans going on in the mean time

crude gyro Feb 10, 2020, 1:51 PM

#

yep.

hardy gorge Feb 10, 2020, 1:51 PM

#

The help channels are the core of our community

green oriole Feb 10, 2020, 1:52 PM

#

It wasn’t really a suggestion, it was just a reaction type of thing, your idea is far better

clever wraith Feb 10, 2020, 2:23 PM

#

maybe channel description can call free ?

gusty sonnet Feb 10, 2020, 3:11 PM

#

Hmm @green oriole why increasing from 10 lines to 11? What if it has 12 lines and you truncate the final line anyway?

#

Would having a dynamic limit better in this case?

green oriole Feb 10, 2020, 3:37 PM

#

No no, we have a limit of 11 lines, if the output is greater, we truncate it and upload to paste.pydis.com, but with the current setup, if the output is exactly 11 lines long, the last line get truncated but it doesn't properly detect it and the original output isn't uploaded to the paste service @gusty sonnet

#

There is more details in the corresponding issue

#

And I didn't expected people to delete the bot response before re-evaluating, gonna fix that :P

#

If you don't delete it yourself and let the bot do it, you can see the feature working

gusty sonnet Feb 10, 2020, 3:48 PM

#

Hmm, so we have a hard cap of 11 lines? What if the output is exactly 12? Can we argue that in that rare case, it should still be shown?

green oriole Feb 10, 2020, 4:38 PM

#

@gusty sonnet the striping in done a big higher in the code, as it is now everything is balanced, we strip up to 11 eleven lines and show them correctly, the issue was that two values wasn't set correctly

#

You left two comment on lines I didn't modified, it isn't really fair :D

gusty sonnet Feb 10, 2020, 4:42 PM

#

Well, since you are doing stuff with it, might as well do some refactoring 😄

#

To be honest it is working fine so you can also disregard it until it becomes a problem. Having working feature comes first!

green oriole Feb 10, 2020, 4:47 PM

#

I can do it, that's fine :D

#

So did you get the 11 lines thingy?

gusty sonnet Feb 10, 2020, 4:48 PM

#

Ye the 11 lines is fine, I resolved the conversation about it, we can always go with it and raise another issue if it becomes a problem later

#

I will go over the tests tomorrow

green oriole Feb 10, 2020, 4:51 PM

#

Nice!

cold moon Feb 10, 2020, 6:14 PM

#

https://github.com/python-discord/bot/issues/697 Is this issue solved or? And when not, quick question: how to fetch site latency?

GitHub

!ping command · Issue #697 · python-discord/bot

Abstract For now, we don't have any way to know when the bot is laggy if it is the bot, the site or discord API that is laggy. This command can be used to report the latency of all of them....

mellow hare Feb 10, 2020, 6:16 PM

#

It'll be two pronged. Part of it will have to be done on the bot, the other on the site

#

The API will have to be listening for that request

hardy gorge Feb 10, 2020, 6:16 PM

#

Have we decided on whether or not we want that feature?

mellow hare Feb 10, 2020, 6:16 PM

#

No idea

green oriole Feb 10, 2020, 6:28 PM

#

An admin said yes before I wrote it

woeful thorn Feb 10, 2020, 6:31 PM

#

Worth making an issue for discussion isn't the same thing as worth implementing the feature

green oriole Feb 10, 2020, 6:32 PM

#

Yep

cold moon Feb 10, 2020, 7:33 PM

#

Hardest thing to contribute to any Python Discord project is setting up env. Just my computer crash

mellow hare Feb 10, 2020, 7:33 PM

#

Well that's bizarre

molten bough Feb 10, 2020, 7:35 PM

#

At what step did that happen to you?

brazen charm Feb 10, 2020, 7:43 PM

#

PySide2 docs repeat themselves in the symbol permalinks, I assume because of the nature of it being packages under the main one with a different docs structure. (PySide2.QtTest.PySide2.QtTest.QTest.qExpectFail as an example)
Would this be worth handling when getting the symbol from users here to fetch it? Or should it just stay general for all the module docs that may come

cold moon Feb 10, 2020, 7:46 PM

#

I tried setup Docker, but after this computer crashed

tawdry vapor Feb 10, 2020, 8:01 PM

#

Have you tried setting it up without Docker?

tawdry vapor Feb 11, 2020, 1:35 AM

#

@woeful thorn How do I install flake-annotations from git now that setup.py is gone?

#

Do I have to go through poetry?

#

I tried simply ```sh
pip install -e git+git@github.com:python-discord/flake8-annotations.git@TYP-to-ANN#egg=flake8-annotations

#

But it errors cause setup.py does not exist

woeful thorn Feb 11, 2020, 1:39 AM

#

If you want an editable install you have to use poetry

#

Since pip won’t do an editable install with the TOML

tawdry vapor Feb 11, 2020, 1:39 AM

#

Bah.

woeful thorn Feb 11, 2020, 1:39 AM

#

Poetry makes a temporary setup.py to do it

tawdry vapor Feb 11, 2020, 1:40 AM

#

Poetry it is

woeful thorn Feb 11, 2020, 1:40 AM

#

It’s annoying

tawdry vapor Feb 11, 2020, 1:40 AM

#

Can poetry install from git?

#

I'll find out soon enough. Pip has been really slow to install things today

patent pivot Feb 11, 2020, 1:41 AM

#

it can

#

for all supported types see https://python-poetry.org/docs/cli/#add

Commands | Documentation | Poetry - Python dependency management and p...

Official documentation of Poetry

woeful thorn Feb 11, 2020, 1:44 AM

#

That’s for adding dependencies, not installing from source

#

I think you have to clone it

tawdry vapor Feb 11, 2020, 1:46 AM

#

Yeah that sounds like the better option

woeful thorn Feb 11, 2020, 1:47 AM

#

I guess they don’t expose the setup.py fakery

#

Though you’d have to clone it anyway to do that

#

That might be a fun helper to write

tawdry vapor Feb 11, 2020, 1:49 AM

#

Sorry I don't really know how to do this

woeful thorn Feb 11, 2020, 1:49 AM

#

?

tawdry vapor Feb 11, 2020, 1:50 AM

#

Not sure how to use poetry. Do I need to create my own project and then add flake8-annotations as as a dependency?

woeful thorn Feb 11, 2020, 1:50 AM

#

No

tawdry vapor Feb 11, 2020, 1:50 AM

#

I just want to make a venv and then install flake8-annotations to it.

woeful thorn Feb 11, 2020, 1:51 AM

#

It’s the same flow as Pipenv

#

poetry install in the source directory, if you have the env activated it will install to it

tawdry vapor Feb 11, 2020, 1:52 AM

#

I thought that would just install its dependencies rather than the project itself

#

That's how it seems to be worded in the help menu anyway. After all, I do not consider a project to be a dependency of itself.

#

Not normally, anyway

#

But I will try that, thanks

woeful thorn Feb 11, 2020, 1:55 AM

#

If there’s a way to word it more clearly I’d be happy to adjust it

tawdry vapor Feb 11, 2020, 1:58 AM

#

"you can install the projects and its dependencies to create a development environment using: ..."

#

Also noticed the note below still mentions a Pipfile

woeful thorn Feb 11, 2020, 1:59 AM

#

oops

tawdry vapor Feb 11, 2020, 2:00 AM

#

Meant to have projects be singular there

woeful thorn Feb 11, 2020, 2:12 AM

#

Is this clearer?

### Development Environment
This project uses [Poetry](https://python-poetry.org/) to manage dependencies. With your fork cloned to your local machine, you can install the project and its dependencies to create a development environment using:

Note: An editable installation of `flake8-annotations` in the developer environment is required in order for the plugin to be registered for Flake8. By default, Poetry includes an editable install of the project itself when `poetry install` is invoked.

tawdry vapor Feb 11, 2020, 2:20 AM

#

Yes, thanks

#

Meanwhile my install has been chugging along for the past 30 minutes

#

Only 25 packages to go...

clever wraith Feb 11, 2020, 9:53 AM

#

https://github.com/python-discord/seasonalbot/issues/341

GitHub

Allow Users to React to a Bookmark to Recieve a Copy · Issue #341 ·...

Spun off of conversations in #338 (comment) and #340 (review): @kwzrd: I've also seen a suggestion that the bot could listen for further clicks on its 📨 reaction, and dispatch the bookmark ...

#

can we complete the 'planning' on this one ? i purpose a timeout system thatr emove all reaction and then put the 📨 in the end . so that on_reaction does not cluster

hardy gorge Feb 11, 2020, 10:16 AM

#

Can you add your proposal to the issue?

clever wraith Feb 11, 2020, 10:23 AM

#

done

hardy gorge Feb 11, 2020, 5:29 PM

#

Interesting.

📎 2020-02-11_18-29.png

green oriole Feb 11, 2020, 6:47 PM

#

Race condition?

cold moon Feb 12, 2020, 5:22 AM

#

Is this still available https://github.com/python-discord/seasonalbot/issues/278 ?

GitHub

[Feature Request] Horror Game Recommendations · Issue #278 · python...

It's that spooky time of the year, and there's no better time to turn off the lights and cower in fear in front of a screen! To also keep up with the gaming spirit, what game should...

eternal owl Feb 12, 2020, 5:58 AM

#

I think it can merged with the recommend game command

eternal owl Feb 12, 2020, 7:24 AM

#

https://github.com/python-discord/site/issues/178
is someone still working on this?

GitHub

Django: Public Facing Tags View · Issue #178 · python-discord/site

It would be handy to display a list of our current tags, and their descriptions, for folks to reference without having to invoke the command in-server. Edit: tangentially related to #102

cold moon Feb 12, 2020, 7:40 AM

#

But is these both available to-do? And where should this fetch games data? From IGDB?

eternal owl Feb 12, 2020, 7:42 AM

#

currently the recommend game command uses static files(json), but I think it will be better if we use an API for more games

#

IGDB looks good, we could use steamAPI as well

green oriole Feb 12, 2020, 7:44 AM

#

IGDB looks like a good idea

cold moon Feb 12, 2020, 7:44 AM

#

Just 50k requests limit

eternal owl Feb 12, 2020, 7:45 AM

#

thats plenty

cold moon Feb 12, 2020, 7:45 AM

#

Ye

eternal owl Feb 12, 2020, 7:46 AM

#

is it 50k per month/year/forever?

green oriole Feb 12, 2020, 7:46 AM

#

Even if it is per forever, that's enough

eternal owl Feb 12, 2020, 7:47 AM

#

yea

cold moon Feb 12, 2020, 7:48 AM

#

This say just 50k requests

📎 image0.png

cold moon Feb 12, 2020, 8:41 AM

#

@hardy gorge sorry about ping, but should SeasonalBot use IGDB for games? Just I want start solving https://github.com/python-discord/seasonalbot/issues/278 this is currently dead issue

GitHub

[Feature Request] Horror Game Recommendations · Issue #278 · python...

It's that spooky time of the year, and there's no better time to turn off the lights and cower in fear in front of a screen! To also keep up with the gaming spirit, what game should...

green oriole Feb 12, 2020, 8:42 AM

#

Are you HeroicHitesh?

eternal owl Feb 12, 2020, 8:43 AM

#

@cold moon dude you can make game recommendations on any theme, not only horror, let's make it universal

green oriole Feb 12, 2020, 8:43 AM

#

Because I mean, if it isn’t you, you should ask them first if they are still working on it

eternal owl Feb 12, 2020, 8:43 AM

#

I created a similar issue for movies a few days back

cold moon Feb 12, 2020, 8:44 AM

#

I'm not, but pull request is closed due copyrights, and there is no response after Oct 2019

green oriole Feb 12, 2020, 8:47 AM

#

Hmm yeah, they deleted their branch, it should be fine

eternal owl Feb 12, 2020, 9:11 AM

#

are you currently working on any issue @green oriole ?

green oriole Feb 12, 2020, 9:15 AM

#

I need to apply reviews on my latest PR

#

Why? ^^

eternal owl Feb 12, 2020, 9:16 AM

#

nothing much, Im having some issues running the website

#

I did docker-compose up

#

but when I go to localhost:8000, it says disallowed host(I did setup my hosts file)

#

and am I allowed to edit the allowed hosts list?

green oriole Feb 12, 2020, 9:17 AM

#

You need to go to http://pythondiscord.local:8000

eternal owl Feb 12, 2020, 9:18 AM

#

fak

#

thank you very much

crude gyro Feb 12, 2020, 9:19 AM

#

maybe it would be nice if we set up localhost.pythondiscord.com

#

I have a design for making that work

green oriole Feb 12, 2020, 9:20 AM

#

You can also use the ALLOWED_HOST env var to override it if you need to, I did it on my dev server so I can access it outside of the server itself

#

Not sure if it is a good idea

#

What the api endpoint would be?

#

api.localhost.pythondiscord.com?

crude gyro Feb 12, 2020, 9:21 AM

#

something like that.

hardy gorge Feb 12, 2020, 9:21 AM

#

Is this to avoid adding entries to a hosts file?

#

Like, the remote redirects to localhost or something

crude gyro Feb 12, 2020, 9:22 AM

#

you'd avoid everything. you'd just run the containers and go to localhost.pydis.com and it would work

#

no port, https supported

#

no hosts file

green oriole Feb 12, 2020, 9:22 AM

#

Supporting https and not using a specific port isn’t that hard

#

I mean, we could just use http://localhost:8000, it is the same as localhost.pydis,com

#

Doesn’t change much

hardy gorge Feb 12, 2020, 9:24 AM

#

I guess the point is that with a setup like lemon's, configuration gets way easier

#

People don't have to worry about setting up a hosts file and/or ports

eternal owl Feb 12, 2020, 9:24 AM

#

hey guys can we have .vscode in gitignore for the site repo

crude gyro Feb 12, 2020, 9:24 AM

#

yes that would probably be fine @eternal owl

#

it's a popular editor and I don't see any reason we shouldn't have it in the gitignore

hardy gorge Feb 12, 2020, 9:25 AM

#

I'm all for cutting down on the number of configuration steps

eternal owl Feb 12, 2020, 9:25 AM

#

okay

green oriole Feb 12, 2020, 9:25 AM

#

http://localhost:8000/ doesn’t need any additional configuration

#

No host file

crude gyro Feb 12, 2020, 9:25 AM

#

yeah and it's http and you have to specify a port

hardy gorge Feb 12, 2020, 9:26 AM

#

How does it work with our Django set-up that relies on subdomains?

green oriole Feb 12, 2020, 9:26 AM

#

It uses django-host iirc

hardy gorge Feb 12, 2020, 9:27 AM

#

It does, yes, but that's not what I'm asking

#

Our site's routes depend on the subdomains

green oriole Feb 12, 2020, 9:27 AM

#

We could use a nginx or apache config, or whatever you use

crude gyro Feb 12, 2020, 9:28 AM

#

it is a little bit of work to do properly though @hardy gorge.

basically you set up the DNS zone file to forward the domains to 127.0.0.1, as you might expect.

then, if we don't already have one used locally (I forget), you'd need an nginx container in the docker-compose, which would host the site. If you want hot-reloads (which we do), you might need some sort of plugin to allow that because nginx might disable it by default. Then you'd have a self-signed certificate on the repo itself which the nginx would use for SSL, this would allow https requests to work.

we might also need a mechanism to keep the self-signed certificate from expiring.

hardy gorge Feb 12, 2020, 9:28 AM

#

We do not use nginx or apache locally at the moment, though

#

that was for Akarys, by the way

crude gyro Feb 12, 2020, 9:28 AM

#

oh I know, just laying out the design

#

we use this at dignio and it works well

green oriole Feb 12, 2020, 9:29 AM

#

I mean, on the pydis server

#

You could create a custom config that soft redirect to localhost:8000

#

Please don’t add nginx in the container

#

It would make a windows setup even harder

crude gyro Feb 12, 2020, 9:30 AM

#

not sure why it would affect windows setup at all

#

because you can't get docker working?

green oriole Feb 12, 2020, 9:30 AM

#

Home edition can’t yeah

crude gyro Feb 12, 2020, 9:31 AM

#

right okay

#

that's a fair point, I guess

#

we could explore this idea of just having the site itself redirect requests to localhost:8000 when they come in on localhost domains. I wonder how feasible that would be

#

could maybe even set up our nginx config for those localhost domains to automatically redirect https to http

#

that way we'd sort of (but not really) support https

green oriole Feb 12, 2020, 9:32 AM

#

My point was to add a new nginx config on the pydis server, it should be feasible

crude gyro Feb 12, 2020, 9:32 AM

#

okay, to do what

green oriole Feb 12, 2020, 9:32 AM

#

I can try some thing with my dev server if you want

#

To redirect to localhost:8000

#

With same subdomain and request URL

#

But with http I guess

crude gyro Feb 12, 2020, 9:33 AM

#

hm, yeah, that might work too.

#

and would be by far the easiest

#

does localhost:8000 work right now? or would we need to change ALLOWED_HOSTS ?

green oriole Feb 12, 2020, 9:34 AM

#

We would need to add it yeah

crude gyro Feb 12, 2020, 9:34 AM

#

okay, I like this idea. good suggestion, @green oriole

#

I'll open an issue on the salt repo.

hardy gorge Feb 12, 2020, 9:35 AM

#

Okay, but localhost doesn't work with subdomains without modifying hosts

crude gyro Feb 12, 2020, 9:35 AM

#

that's true. okay. how do we work around that

hardy gorge Feb 12, 2020, 9:35 AM

#

would such a redirection keep the original subdomain headers intact?

#

i.e., if both api.local.pydis and local.pydis redirect to localhost, would django-hosts still work?

crude gyro Feb 12, 2020, 9:36 AM

#

no, it wouldn't.

#

it needs to be able to parse out a subdomain

#

so that's a valid point

#

might be a showstopper for this suggestion

#

but

#

okay I have one idea

#

we could make api.pydis.com available through pydis.com/api

hardy gorge Feb 12, 2020, 9:38 AM

#

We could rewrite our entire routing for this to work, but that's not something we should change without serious consideration. It should be easy to either just ditch the subdomains or have them redirect to the main domain with a subpath (api.pydis -> pydis/api)

crude gyro Feb 12, 2020, 9:38 AM

#

right, we had the same idea there

#

I think we could do both?

#

like, we don't need to change it, we could just have api.pydis.com and pydis.com/api route to the same place

#

I actually.. hmm

hardy gorge Feb 12, 2020, 9:39 AM

#

It would mean we wouldn't have to worry about cross-subdomain login cookies

crude gyro Feb 12, 2020, 9:39 AM

#

if we ditched subdomains altogether, you mean?

hardy gorge Feb 12, 2020, 9:39 AM

#

or have them as simple redirects

crude gyro Feb 12, 2020, 9:39 AM

#

we wouldn't need wildcard SSL certs either..

#

well, we would for redirects

hardy gorge Feb 12, 2020, 9:39 AM

#

We may want to keep paste.pydis

green oriole Feb 12, 2020, 9:40 AM

#

api.localhost:8000 works fine

#

I set pydis.dev.<mydomain> as a valid host on my dev server, and api.pydis.dev.<mydomain> is the api endpoint

crude gyro Feb 12, 2020, 9:41 AM

#

I'm not convinced that's true. it is of course true that Django doesn't care, but I'm not sure an attempt to add a subdomain to localhost would survive if you process it through nginx

green oriole Feb 12, 2020, 9:42 AM

#

Okay, one second

eternal owl Feb 12, 2020, 9:42 AM

#

https://github.com/python-discord/site/issues/178
is this issue still valid

GitHub

Django: Public Facing Tags View · Issue #178 · python-discord/site

It would be handy to display a list of our current tags, and their descriptions, for folks to reference without having to invoke the command in-server. Edit: tangentially related to #102

crude gyro Feb 12, 2020, 9:42 AM

#

sure

eternal owl Feb 12, 2020, 9:43 AM

#

someone is already assigned but that was in october

crude gyro Feb 12, 2020, 9:43 AM

#

I unassigned them

#

want me to assign you?

eternal owl Feb 12, 2020, 9:43 AM

#

sure, let me comment, I want to try it

#

thank you

crude gyro Feb 12, 2020, 9:44 AM

#

cool, would be nice to see. This issue is lacking some design, so please start by discussing how this should be designed before attempting it

#

we always start with design.

green oriole Feb 12, 2020, 9:44 AM

#

The screenshot contains some sensitive informations, mind if I DM you lemon?

eternal owl Feb 12, 2020, 9:44 AM

#

Yea my very first question is where should it be

crude gyro Feb 12, 2020, 9:44 AM

#

I've never killed someone for DMing me, @green oriole

eternal owl Feb 12, 2020, 9:44 AM

#

I mean should it come under the more section?

green oriole Feb 12, 2020, 9:44 AM

#

Haha okay

crude gyro Feb 12, 2020, 9:44 AM

#

definitely not under More.

#

that's full enough as it is

eternal owl Feb 12, 2020, 9:45 AM

#

Do we have a page dedicated to our bots? like all the features of them(I might be blind)

crude gyro Feb 12, 2020, 9:45 AM

#

I don't think we do, but such a page might not be a bad idea.

eternal owl Feb 12, 2020, 9:45 AM

#

cool

crude gyro Feb 12, 2020, 9:45 AM

#

I imagine we might want a general server information page as the parent of that bot page, too

#

but anyway, just make the tags page independent for now

#

and we can worry about where to link to it from later on

eternal owl Feb 12, 2020, 9:46 AM

#

okay

#

where to make tag page?

crude gyro Feb 12, 2020, 9:46 AM

#

something like pythondiscord.com/pages/tags I guess?

eternal owl Feb 12, 2020, 9:46 AM

#

okay cool

#

should i add .vscode to gitignore while I work on this?

#

nvm I will use sublime text for this

molten bough Feb 12, 2020, 9:55 AM

#

A compliant network stack should always return 127.0.0.1 for <whatever>.localhost

#

I don't see why nginx would be unhappy with that

hardy gorge Feb 12, 2020, 9:56 AM

#

@eternal owl I've added the ignore to the site's master

#

So, if you update/rebase your local branch, you don't have to use a different editor than the one you're used to

eternal owl Feb 12, 2020, 9:56 AM

#

okay

#

path('pages/', include('wiki.urls')),
i cant find any wiki folder

#

how does it work

hardy gorge Feb 12, 2020, 9:59 AM

#

The wiki articles are stored in the database, so your local installation will not have any content in the wiki

eternal owl Feb 12, 2020, 10:00 AM

#

okay

hardy gorge Feb 12, 2020, 10:01 AM

#

url paths in Django do not represent actual directories; it defines how urls are parsed and routed to views.

eternal owl Feb 12, 2020, 10:01 AM

#

I need a bit of education of the project structure, its so diff from django-admin startproject xyz

molten bough Feb 12, 2020, 10:01 AM

#

It's not that different

hardy gorge Feb 12, 2020, 10:01 AM

#

In this case, we include all the urls of the wiki after /pages/ on the url

molten bough Feb 12, 2020, 10:02 AM

#

They basically ended up consolidating some stuff

eternal owl Feb 12, 2020, 10:02 AM

#

so if I want to write a view for the pages/tags, where should I

hardy gorge Feb 12, 2020, 10:02 AM

#

We use a central directory for templates and static files

molten bough Feb 12, 2020, 10:02 AM

#

The same place you usually would - in the app

eternal owl Feb 12, 2020, 10:02 AM

#

home app?

molten bough Feb 12, 2020, 10:02 AM

#

Depends on the view you're writing

#

What're you up to?

eternal owl Feb 12, 2020, 10:03 AM

#

https://github.com/python-discord/site/issues/178

GitHub

Django: Public Facing Tags View · Issue #178 · python-discord/site

It would be handy to display a list of our current tags, and their descriptions, for folks to reference without having to invoke the command in-server. Edit: tangentially related to #102

molten bough Feb 12, 2020, 10:03 AM

#

That probably belongs in home, I guess, yeah

cold moon Feb 12, 2020, 10:05 AM

#

is https://github.com/python-discord/seasonalbot/issues/345 free, so I can start solving this?

GitHub

Movie command · Issue #345 · python-discord/seasonalbot

Most of us fancy watching movies, be it horror, romantic, action, comedy, etc. We already have 2 commands that get us a romantic and horror movie, but what about other genres? Implementation detail...

eternal owl Feb 12, 2020, 10:06 AM

#

it should be approved

cold moon Feb 12, 2020, 10:06 AM

#

Oh, approved missing?

molten bough Feb 12, 2020, 10:07 AM

#

Well, I guess you need to start at the bottom and work up

#

It looks like https://github.com/python-discord/seasonalbot/pull/306 was declared stale

GitHub

Generic Movie Embed Generator by sgh304 · Pull Request #306 · pytho...

Generic Movie Embed Generator
Adds a generic method for generating random movie embeds.
Pull Request Details
This abstracts out the logic from the Valentine's Day movie generation command i...

#

Why don't you leave a comment on the PR and ask to take it over?

cold moon Feb 12, 2020, 10:09 AM

#

ok

eternal owl Feb 12, 2020, 10:09 AM

#

hey @molten bough, you got some time now?

molten bough Feb 12, 2020, 10:09 AM

#

What do you need, Ice?

eternal owl Feb 12, 2020, 10:09 AM

#

some more info on how the site works 😅

molten bough Feb 12, 2020, 10:09 AM

#

Well, I can try, haha

eternal owl Feb 12, 2020, 10:09 AM

#

okay

molten bough Feb 12, 2020, 10:09 AM

#

I have updates installing but I can start IDEA after that

eternal owl Feb 12, 2020, 10:09 AM

#

so from where are the wiki templates rendered

#

i mean there has to be a view right

molten bough Feb 12, 2020, 10:10 AM

#

They're rendered by django-wiki

crude gyro Feb 12, 2020, 10:10 AM

#

there is no view.

molten bough Feb 12, 2020, 10:10 AM

#

yup

crude gyro Feb 12, 2020, 10:10 AM

#

we change them on the site itself

molten bough Feb 12, 2020, 10:10 AM

#

well there is a view, but it's not one of ours

eternal owl Feb 12, 2020, 10:10 AM

#

so its django built in?

molten bough Feb 12, 2020, 10:10 AM

#

No, it's a third party app

eternal owl Feb 12, 2020, 10:10 AM

#

okay

molten bough Feb 12, 2020, 10:11 AM

#

If you want to add wiki pages, you'll have to use the django admin

eternal owl Feb 12, 2020, 10:12 AM

#

so now i need to make a new url end point

#

ooh

molten bough Feb 12, 2020, 10:12 AM

#

What's the plan, in your mind?

#

Are you planning to have it under pages/?

eternal owl Feb 12, 2020, 10:13 AM

#

yea

#

pages/tags/

molten bough Feb 12, 2020, 10:14 AM

#

Yeah, so you could add that before the current pages/ url route in the home app

crude gyro Feb 12, 2020, 10:14 AM

#

yeah, the tags page does need a normal view

clever wraith Feb 12, 2020, 10:14 AM

#

ok how will it get updated ?
using a connection between bot and website
we alredy have an API in @stable mountain afaik

molten bough Feb 12, 2020, 10:14 AM

#

that's already done

#

this is a public view page

#

You almost certainly don't want to render a wiki view, Ice

#

I suggest creating a new template for this

#

You can always model it on the wiki one I wrote

hardy gorge Feb 12, 2020, 10:15 AM

#

@clever wraith Tags are stored in the database

eternal owl Feb 12, 2020, 10:15 AM

#

where is the wiki one

clever wraith Feb 12, 2020, 10:16 AM

#

no he purposed it contain commands and description of each bot .

molten bough Feb 12, 2020, 10:16 AM

#

templates/wiki/article.html

clever wraith Feb 12, 2020, 10:16 AM

#

how can we make a connection between bot and web

molten bough Feb 12, 2020, 10:16 AM

#

you might need to unravel things a little, there's a lot of template inheritance going on

#

@clever wraith this is just a tags page

clever wraith Feb 12, 2020, 10:17 AM

#

tags as
WIP
priority level . kind kf things ?

#

of*

hardy gorge Feb 12, 2020, 10:18 AM

#

No, the tags we have for our bot

#

!tags

#

Things like

#

!ask

stable mountainBOT Feb 12, 2020, 10:18 AM

#

ask

Asking good questions will yield a much higher chance of a quick response:

• Don't ask to ask your question, just go ahead and tell us your problem.
• Don't ask if anyone is knowledgeable in some area, filtering serves no purpose.
• Try to solve the problem on your own first, we're not going to write code for you.
• Show us the code you've tried and any errors or unexpected results it's giving.
• Be patient while we're helping you.

You can find a much more detailed explanation on our website.

clever wraith Feb 12, 2020, 10:18 AM

#

ahhh got it

#

why i can control it if it was called by @hardy gorge

eternal owl Feb 12, 2020, 10:19 AM

#

so step 1 is to write the url endpoint @molten bough ?

molten bough Feb 12, 2020, 10:19 AM

#

Well, I usually start with the template

#

but it's really up to you

#

Create the view, add the URL route, and then get hacking

clever wraith Feb 12, 2020, 10:19 AM

#

did i just found a bug ?

eternal owl Feb 12, 2020, 10:20 AM

#

where to create the view

hardy gorge Feb 12, 2020, 10:20 AM

#

Since tags are just stored in the database, a ListView and DetailView class with appropriate templates should basically provide the backbone.

molten bough Feb 12, 2020, 10:20 AM

#

Not a bug

#

Under the home app

hardy gorge Feb 12, 2020, 10:20 AM

#

Then you can route the url to those view classes and it would work fine

eternal owl Feb 12, 2020, 10:20 AM

#

okay I will make a new view in the apps/home/views/home.py?

molten bough Feb 12, 2020, 10:20 AM

#

No

#

Make a file

#

Or rather, make a tags package with two files

clever wraith Feb 12, 2020, 10:20 AM

#

there must be a reactor == ctx.author check ?

molten bough Feb 12, 2020, 10:20 AM

#

Since you need two views

#

@clever wraith It was intentional back when I worked on that part of the bot

hardy gorge Feb 12, 2020, 10:21 AM

#

@clever wraith Why? It's quite handy to allow others to browse paginations as well.

#

We use that all the time with infractions

eternal owl Feb 12, 2020, 10:21 AM

#

what is package

clever wraith Feb 12, 2020, 10:21 AM

#

but one person can be eivl and press the delete function

molten bough Feb 12, 2020, 10:21 AM

#

pydis_site.apps.home.views.tags - that's a package

#

so what?

hardy gorge Feb 12, 2020, 10:22 AM

#

if people get obnoxious, they'll get an infraction

clever wraith Feb 12, 2020, 10:22 AM

#

function here means button*

eternal owl Feb 12, 2020, 10:22 AM

#

I made the folder and now I should create a file called views.py and start writing my view

hardy gorge Feb 12, 2020, 10:22 AM

#

Anyway, the view classes are probably just going to be four lines or so

molten bough Feb 12, 2020, 10:22 AM

#

No, again, make two files, one for each view

hardy gorge Feb 12, 2020, 10:22 AM

#

They could also live in one file, as far as I'm concerned

clever wraith Feb 12, 2020, 10:23 AM

#

in class you say

eternal owl Feb 12, 2020, 10:23 AM

#

why do I need 2files for 2 views

molten bough Feb 12, 2020, 10:23 AM

#

That wouldn't be too bad either, yeah

eternal owl Feb 12, 2020, 10:23 AM

#

I need a ListView and detailView

molten bough Feb 12, 2020, 10:23 AM

#

I guess I'm used to the conventions other languages impose, the one file one class deal

eternal owl Feb 12, 2020, 10:23 AM

#

okay

#

what will be the naming convention

molten bough Feb 12, 2020, 10:23 AM

#

If they're short then one file is probably fine

#

You could look at the other views for that

eternal owl Feb 12, 2020, 10:24 AM

#

okay

#

it will be list.py and detail.py i guess

molten bough Feb 12, 2020, 10:24 AM

#

That sounds fine

eternal owl Feb 12, 2020, 10:24 AM

#

okay cool

cold moon Feb 12, 2020, 10:25 AM

#

I hope PR #306 author check this PR. I just can't mention him

eternal owl Feb 12, 2020, 10:27 AM

#

something is wrong with my lappy, it hung for 10s and then discord and mozilla just closed, lol

molten bough Feb 12, 2020, 10:27 AM

#

Out of RAM?

eternal owl Feb 12, 2020, 10:27 AM

#

8gigs

#

should be enough pithink

#

how can i check my db

molten bough Feb 12, 2020, 10:32 AM

#

Check in what sense?

eternal owl Feb 12, 2020, 10:33 AM

#

I want to see the tags in the db

molten bough Feb 12, 2020, 10:33 AM

#

You can use the django admin

hardy gorge Feb 12, 2020, 10:33 AM

#

@cold moon It was their first contribution to PyDis and it seems they were only active on GH during Hacktober. It's so stale I wouldn't mind someone else taking over.

eternal owl Feb 12, 2020, 10:34 AM

#

okay

cold moon Feb 12, 2020, 10:34 AM

#

ok, thanks

eternal owl Feb 12, 2020, 10:34 AM

#

btw can i see the db from psql?

hardy gorge Feb 12, 2020, 10:34 AM

#

yes

#

but, there probably aren't any tags in your database if you haven't added any yourself

eternal owl Feb 12, 2020, 10:35 AM

#

whats the db name

molten bough Feb 12, 2020, 10:35 AM

#

pysite, I think

eternal owl Feb 12, 2020, 10:35 AM

#

docker will create db right?

molten bough Feb 12, 2020, 10:35 AM

#

Yup

eternal owl Feb 12, 2020, 10:35 AM

#

📎 Screenshot_from_2020-02-12_16-05-13.png

molten bough Feb 12, 2020, 10:35 AM

#

Is that a local postgres server?

eternal owl Feb 12, 2020, 10:36 AM

#

yea i think so

molten bough Feb 12, 2020, 10:36 AM

#

It runs its own in Docker

eternal owl Feb 12, 2020, 10:36 AM

#

oh

molten bough Feb 12, 2020, 10:36 AM

#

It's exposed on port 7777

#

local only

eternal owl Feb 12, 2020, 10:36 AM

#

okay

molten bough Feb 12, 2020, 10:36 AM

#

and yep, it's pysite

#

user and pass are also pysite

eternal owl Feb 12, 2020, 10:37 AM

#

okay

hardy gorge Feb 12, 2020, 10:38 AM

#

You can also docker exec into psql within the container

#

something like

molten bough Feb 12, 2020, 10:38 AM

#

Oh yeah

hardy gorge Feb 12, 2020, 10:38 AM

#

$ docker exec -it site_postgres_1 psql -U pysite

eternal owl Feb 12, 2020, 10:38 AM

#

okay

hardy gorge Feb 12, 2020, 10:38 AM

#

depending on the name of the container, obviously

molten bough Feb 12, 2020, 10:38 AM

#

it should be docker-compose exec postgres psql -U pysite

#

or something like that

eternal owl Feb 12, 2020, 10:39 AM

#

im in \o/

#

had to use sudo tho

hardy gorge Feb 12, 2020, 10:39 AM

#

docker exec should work

#

oh

#

you're not in the docker group?

eternal owl Feb 12, 2020, 10:39 AM

#

not yet

cold moon Feb 12, 2020, 10:44 AM

#

But should I use current OMDB, or add new env var for TMDB?

eternal owl Feb 12, 2020, 10:45 AM

#

TMDB it is

#

there was an issue which said to change to tmdb from omdb

molten bough Feb 12, 2020, 10:46 AM

#

maybe check that

#

yup https://github.com/python-discord/seasonalbot/issues/136

GitHub

Change omdb api usage to use tmdb. · Issue #136 · python-discord/se...

The snakes extension was moved to this bot now, but it uses the omdb api. We should adjust whatever uses omdb to use tmdb, which is already used in a halloween feature.

eternal owl Feb 12, 2020, 11:02 AM

#

What can possibly go wrong

📎 Screenshot_from_2020-02-12_16-32-42.png

molten bough Feb 12, 2020, 11:04 AM

#

Did you wait for it to finish starting?

eternal owl Feb 12, 2020, 11:04 AM

#

it says Watching for file changes with StatReloader in terminal

molten bough Feb 12, 2020, 11:05 AM

#

Sounds right

#

Are you using the right port?

#

Did you add that domain to your hosts file?

eternal owl Feb 12, 2020, 11:06 AM

#

it was working fine before

molten bough Feb 12, 2020, 11:07 AM

#

local machine, port 8000

#

check your hosts entry

hardy gorge Feb 12, 2020, 11:07 AM

#

What did you change between a working state and a non-working state?

#

Alternatively, restart your devserver and see if it starts normally

eternal owl Feb 12, 2020, 11:07 AM

#

i changed the urls.py file, created new files, edited those

#

okay

#

I had a typo in an import statement

#

i fixed it and now it works

molten bough Feb 12, 2020, 11:14 AM

#

ah, yeah, that'd do it

eternal owl Feb 12, 2020, 12:09 PM

#

I got the views working now, time to make the web page pretty

molten bough Feb 12, 2020, 12:11 PM

#

\o/

eternal owl Feb 12, 2020, 12:12 PM

#

\o/

#

btw If im using docker, I dont have to setup env vars right?

molten bough Feb 12, 2020, 12:16 PM

#

You shouldn't need to, yeah

eternal owl Feb 12, 2020, 12:17 PM

#

but I get error that secret key is missing

#

wait

#

how to run docker and python manage.py shell together

molten bough Feb 12, 2020, 12:18 PM

#

using docker-compose exec service_name command

eternal owl Feb 12, 2020, 12:19 PM

#

what can be service name

molten bough Feb 12, 2020, 12:19 PM

#

Whatever is in the compose file

#

Looks like web

eternal owl Feb 12, 2020, 12:19 PM

#

okay

#

thanks

#

!tags

#

is there a way I can get all the tags from pydis database?

#

I not sure what do give in the embed section other than description

molten bough Feb 12, 2020, 12:28 PM

#

It's an embed object, the same as Discord would use normally, I think

eternal owl Feb 12, 2020, 12:28 PM

#

oohk

#

Tag embed must contain one of the fields {'video', 'image', 'title', 'fields', 'description'}.
how will the fields dict look

hardy gorge Feb 12, 2020, 12:32 PM

#

You can also add tags using your bot, but this is an example of an actual tag:

#

{"description": "**Off-topic channels**\n\nThere are three off-topic channels:\n\u2022 [#ot0-psvm’s-eternal-disapproval](/guild/267624335836053506/channel/291284109232308226/) \n\u2022 [#ot1-perplexing-regexing](/guild/267624335836053506/channel/463035241142026251/) \n\u2022 [#ot2-never-nester’s-nightmare](/guild/267624335836053506/channel/463035268514185226/) \n\nTheir names change randomly every 24 hours, but you can always find them under the `OFF-TOPIC/GENERAL` category in the channel list."}

eternal owl Feb 12, 2020, 12:33 PM

#

okay

#

do some tags have fields also?

#

or should I only display description

molten bough Feb 12, 2020, 12:35 PM

#

I think all tags right now only have description

#

from what I've seen anyway

#

it's just there in case they want to add tags with other fields

#

but for the sake of future-proofing you should handle all of them

eternal owl Feb 12, 2020, 12:38 PM

#

okay, but I will need an example with all those values

#

example with {'video', 'image', 'title', 'fields', 'description'}

molten bough Feb 12, 2020, 12:39 PM

#

Check the Discord API docs

#

That's what I recommend

eternal owl Feb 12, 2020, 12:46 PM

#

okay

hardy gorge Feb 12, 2020, 12:46 PM

#

These are just the normal fields from the json/dict respresetnation of a Discord embed

#

The current tag command only adds a description field, but that may change in the future

eternal owl Feb 12, 2020, 12:46 PM

#

for some reason my <h1> , <ul> and <li> are not showing up

molten bough Feb 12, 2020, 12:46 PM

#

Need to be in a content div

eternal owl Feb 12, 2020, 12:47 PM

#

oh

#

okay @hardy gorge

eternal owl Feb 12, 2020, 1:02 PM

#

found this
https://discordapp.com/developers/docs/resources/channel#embed-object-embed-structure

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

rocky bloom Feb 12, 2020, 1:17 PM

#

aren’t fields just nested dictionaries ?

eternal owl Feb 12, 2020, 1:19 PM

#

it says array of embed field objects so it probably a list of dicts

rocky bloom Feb 12, 2020, 1:20 PM

#

that makes sense

eternal owl Feb 12, 2020, 1:21 PM

#

first trial(the text there is bound to change)

📎 Screenshot_from_2020-02-12_18-50-37.png

#

how is it

woeful thorn Feb 12, 2020, 1:23 PM

#

Seems like a reasonable start, should be alphabetized though

eternal owl Feb 12, 2020, 1:24 PM

#

okay

cold moon Feb 12, 2020, 1:27 PM

#

How about adding amount of movies to .movie <genre> (I'll use subcommands)? Default should 5, max 20 and min 1

#

Seasonalbot

eternal owl Feb 12, 2020, 1:30 PM

#

or maybe get 5 always and paginate them?

#

I think you can do it without subcommands

cold moon Feb 12, 2020, 1:31 PM

#

I can do, but managing and code style I think is better with subcommands

green oriole Feb 12, 2020, 1:31 PM

#

You just use a database query to get all the tags right?

#

Because you directly call .sort_by on it to sort them

cold moon Feb 12, 2020, 1:32 PM

#

Just there is much genres

#

~~and I mean this will paginate 1-20 movies~~

eternal owl Feb 12, 2020, 2:01 PM

#

where can i find that perfect spacing

📎 unknown.png

#

trail 1 for detail page, dont have much idea , that starting line will change once I figure out the proper spacing.
that hr is barely visible haha

📎 Screenshot_from_2020-02-12_19-43-09.png

#

I think I should make that hr darker

hardy gorge Feb 12, 2020, 2:15 PM

#

The spacing on the top are breadcrumps using a nav tag with the breadcrumb css class

#

It contains an ul of the breadcrumb items

#

Example from a random wiki page:

<nav class="breadcrumb is-pulled-left" aria-label="breadcrumbs">
        <ul>
          <li>
              <a href="//pythondiscord.com/pages/">Index</a>
          </li>
          <li class="is-active">
            <a href="//pythondiscord.com/pages/">Code Jams</a>
          </li>
        </ul>
      </nav>

#

@eternal owl Just a few things upfront, the "official" command to display tags is !tags <name>; in general, using !<name> will also work, but only if we don't have a command with the same name/alias.

#

The reason is that the individual tags are not commands, but whenever someone issues a non-existing command, we check if we have a tag by that name; if so, we return that instead.

#

So, !<tagname> may not always work (although we should probably prevent such shadowing)

mellow hare Feb 12, 2020, 2:24 PM

#

Do we currently have any instances of conflicts?

hardy gorge Feb 12, 2020, 2:25 PM

#

I don't think so

mellow hare Feb 12, 2020, 2:25 PM

#

Yeah I can't think of any

eternal owl Feb 12, 2020, 2:40 PM

#

okay, thanks @hardy gorge

#

I need some feedback on those pages guys

#

The 2 pics are above

cold moon Feb 12, 2020, 3:03 PM

#

Current progress

📎 Screenshot_2020-02-12_at_17.03.25.png

eternal owl Feb 12, 2020, 3:50 PM

#

confirming complete embed json:

{
    "title": "This is a title.",
    "description": "This is a descriptin.",
    "image":{
        "url": "https://somepic.jpg",
        "proxy_url": "some_url",
        "height": 100,
        "width": 100
    },
    "fields":[
        {
            "name": "Some name",
            "value": "xyz",
        },
        {...},
        {...}
    ]
}```
( I dint add video as its almost similar to image)

#

@hardy gorge

hardy gorge Feb 12, 2020, 3:51 PM

#

I'm not sure, I'm not home. (I'm at the hairdresser actually)

eternal owl Feb 12, 2020, 3:51 PM

#

oh okay

hardy gorge Feb 12, 2020, 3:51 PM

#

Looks right

eternal owl Feb 12, 2020, 3:51 PM

#

okay cool

hardy gorge Feb 12, 2020, 3:52 PM

#

Aren't there more options, like author and the like?

eternal owl Feb 12, 2020, 3:52 PM

#

yep there are plenty

#

https://discordapp.com/developers/docs/resources/channel#embed-object-embed-structure

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

hardy gorge Feb 12, 2020, 3:52 PM

#

In principle, the database can store everything

#

We currently don't use everything, though.

#

Maybe an author field would make sense in the future for keeping track of who wrote what

eternal owl Feb 12, 2020, 3:53 PM

#

okay cool

hardy gorge Feb 12, 2020, 3:53 PM

#

Haven't thought it through yet.

#

Anyway, that's just to indicate that future updates may add features.

#

Not every field has to be rendered on our website; it should just not break it if we decide to store another field.

eternal owl Feb 12, 2020, 3:54 PM

#

all_keys = {
        'title', 'type', 'description', 'url', 'timestamp',
        'color', 'footer', 'image', 'thumbnail', 'video',
        'provider', 'author', 'fields'
    }
one_required_of = {'description', 'fields', 'image', 'title', 'video'}```
i just found this in `api/models/bot/tag.py`

#

I think I will impliment for all_keys

#

shouldn't be hard

#

lemme know if there are any format changes(like which should be list and which should be dict n stuff)

rocky bloom Feb 12, 2020, 3:58 PM

#

i might look into unit tests and help out with them

#

for bot

eternal owl Feb 12, 2020, 3:58 PM

#

cool

rocky bloom Feb 12, 2020, 4:01 PM

#

after like half a year of never talking/participating here i feel like i need to do something 😂

hardy gorge Feb 12, 2020, 4:01 PM

#

There are going to be some small changes to our helpers once we upgrade to 3.8

#

Soonish

rocky bloom Feb 12, 2020, 4:01 PM

#

soon™️

hardy gorge Feb 12, 2020, 4:02 PM

#

That's one of the area's in which 3.8 is a significant update: mocks for async stuff

rocky bloom Feb 12, 2020, 4:02 PM

#

so shall i leave it until 3.8 or start it anyway

#

will much change besides the mock classes themselves?

eternal owl Feb 12, 2020, 4:02 PM

#

my format passed the validator

hardy gorge Feb 12, 2020, 4:03 PM

#

@rocky bloom No, the changes will be minimal

rocky bloom Feb 12, 2020, 4:04 PM

#

ah so i'll start learning and doing some

eternal owl Feb 12, 2020, 4:05 PM

#

I need to learn testing as well pithink

#

I found a bug

#

in django admin interface, when I am trying to update/edit a tags object, it insted keeps the old one and makes a new one with the updated/edited details

#

So its kinda impossible to edit an object without creating a new one and then deleting the old one.

hardy gorge Feb 12, 2020, 4:17 PM

#

It doesn't do that for me

#

It doesn't do that on our actual website as well

#

So, I can't replicate what you found

#

📎 2020-02-12_17-19.png

eternal owl Feb 12, 2020, 4:19 PM

#

Let me share vid

#

https://streamable.com/u39kp

Streamable

2020-02-12 21-49-13 - Streamable

▶ Play video

#

pithink

#

damn this emoji is soo good pithink

hardy gorge Feb 12, 2020, 4:21 PM

#

Okay, I only edited the actual tag, not the title

eternal owl Feb 12, 2020, 4:22 PM

#

yea the title edit is bugged

clever wraith Feb 12, 2020, 4:23 PM

#

Since i no see activity , I am pulling a PR with my purposal in mind

woeful thorn Feb 12, 2020, 4:23 PM

#

What does that mean?

clever wraith Feb 12, 2020, 4:24 PM

#

wait a sec , let me link the issue it is reffered with

#

https://github.com/python-discord/seasonalbot/issues/341

GitHub

Allow Users to React to a Bookmark to Recieve a Copy · Issue #341 ·...

Spun off of conversations in #338 (comment) and #340 (review): @kwzrd: I've also seen a suggestion that the bot could listen for further clicks on its 📨 reaction, and dispatch the bookmark ...

woeful thorn Feb 12, 2020, 4:24 PM

#

So rather than being patient, you're just going to go ahead and do what you want?

#

You're free to do that, but keep in mind that it might end up being a waste of time if what you intend to do doesn't align with what ends up being planned

clever wraith Feb 12, 2020, 4:25 PM

#

its ok

hardy gorge Feb 12, 2020, 4:25 PM

#

@eternal owl It's not really a bug in that the behavior is easily explained: The title is apparently the primary key of that model.

clever wraith Feb 12, 2020, 4:26 PM

#

I did it with creating bookmark command itself, and it got passed cuz it was a good idea. going same with this one

hardy gorge Feb 12, 2020, 4:26 PM

#

So, if you "change" it, you literally saving something with a different pk

eternal owl Feb 12, 2020, 4:26 PM

#

ooh

#

gotcha

woeful thorn Feb 12, 2020, 4:27 PM

#

I think you have a very different interpretation of history, the last PR you just tossed in without discussion underwent a pretty significant rewrite before it was merged

eternal owl Feb 12, 2020, 4:28 PM

#

Is there any bulma class to add top padding?

hardy gorge Feb 12, 2020, 4:30 PM

#

Top padding for what part?

eternal owl Feb 12, 2020, 4:30 PM

#

📎 Screenshot_from_2020-02-12_22-00-43.png

clever wraith Feb 12, 2020, 4:30 PM

#

don't mock me atleast ;-;

hardy gorge Feb 12, 2020, 4:30 PM

#

Bulma assumes you're placing your content in the appropriate container classes; that should sort out the spacing for you

eternal owl Feb 12, 2020, 4:30 PM

#

here, need some space at the top

#

I am currently using content and container class

hardy gorge Feb 12, 2020, 4:31 PM

#

I think you could look at the wiki pages to see how it's done there

eternal owl Feb 12, 2020, 4:31 PM

#

okay

hardy gorge Feb 12, 2020, 4:31 PM

#

They have a similar lay-out but with the desired spacing

eternal owl Feb 12, 2020, 4:31 PM

#

btw the tags /thing is not working

hardy gorge Feb 12, 2020, 4:31 PM

#

Did you use breadcrumbs in the appropriate nav container?

eternal owl Feb 12, 2020, 4:31 PM

#

there is no space after / and the link is not clickable

#

I used ur code

#

<div class="container">
        <nav class="breadcrumb is-pulled-left" aria-label="breadcrumbs">
            <ul>
                <li>
                    <a href="{% url 'list_tags' %}">Tags</a>
                </li>
                <li class="is-active">{{ object.title }}</li>
            </ul>
        </nav>
    </div>```

woeful thorn Feb 12, 2020, 4:32 PM

#

@clever wraith I'm not mocking you. My point is that it saves everybody time and effort if you start from a solid foundation instead of charging ahead before the task is appropriately laid out

hardy gorge Feb 12, 2020, 4:33 PM

#

I don't see a url in there, @eternal owl

#

just a title

eternal owl Feb 12, 2020, 4:33 PM

#

% url 'list_tags' %

#

the line above that

clever wraith Feb 12, 2020, 4:33 PM

#

can we then point our attention to that issue , cuz i wanna complete it, cuz people asked for it today , and maybe i will not be available day after tomorrow

hardy gorge Feb 12, 2020, 4:33 PM

#

hmm, does that actually resolve properly? Shouldn;t it be something like home:list_tags?

#

How does the url render?

eternal owl Feb 12, 2020, 4:34 PM

#

we can specify without app name also

#

<a href="{% url 'detail_tags' title=obj.title %}">{{ obj.title }}</a>
this works in the tags listing page

#

i just use detail_tags insted of home:detail_tags

hardy gorge Feb 12, 2020, 4:35 PM

#

What's in your urls.py for home?

clever wraith Feb 12, 2020, 4:35 PM

#

@stable mountain not working

stable mountainBOT Feb 12, 2020, 4:35 PM

#

Can I send you a private message?

No. We do not provide one-on-one tutoring - you can hire someone locally if you really need that. We also prefer that questions are answered in a public channel as it means that everyone else present is able to learn from them. If you're working with code that you are unable to disclose for any reason, you should try to make your question more general and write a separate, small piece of code to illustrate your problem.

clever wraith Feb 12, 2020, 4:36 PM

#

ok it slowed down

eternal owl Feb 12, 2020, 4:36 PM

#

path('pages/tags', TagsListView.as_view(), name="list_tags"),
path('pages/tags/<str:title>', TagsDetailView.as_view(), name="detail_tags"),```
these are the new urls I added

hardy gorge Feb 12, 2020, 4:36 PM

#

@clever wraith in what way?

clever wraith Feb 12, 2020, 4:36 PM

#

It didn't responded for over 5 seconds

clever wraith Feb 12, 2020, 5:00 PM

#

what is the d.py version of @dusky shore ?

woeful thorn Feb 12, 2020, 5:01 PM

#

1.2.5

#

https://github.com/python-discord/seasonalbot/blob/master/Pipfile.lock#L130

clever wraith Feb 12, 2020, 5:02 PM

#

any idea why its still 1.2.5 ?

woeful thorn Feb 12, 2020, 5:02 PM

#

Because that's what it was when we locked the dependencies, and 1.3.1 hasn't been tested yet

clever wraith Feb 12, 2020, 5:03 PM

#

so i can't use some of the thing from docs '='

woeful thorn Feb 12, 2020, 5:03 PM

#

Like what?

clever wraith Feb 12, 2020, 5:03 PM

#

like clear()

#

📎 unknown.png

woeful thorn Feb 12, 2020, 5:05 PM

#

Reaction.remove() still exists

clever wraith Feb 12, 2020, 5:05 PM

#

have to loop in that

woeful thorn Feb 12, 2020, 5:06 PM

#

Ok

glass pecan Feb 12, 2020, 5:07 PM

#

https://discordpy.readthedocs.io/en/v1.2.5/api.html#discord.Message.clear_reactions

#

assuming you're not in need of leaving a reaction behind

cold moon Feb 12, 2020, 5:09 PM

#

Is this good?

📎 Screenshot_2020-02-12_at_19.09.13.png

woeful thorn Feb 12, 2020, 5:09 PM

#

Probably not, I don't think the user needs the "I've sent this" feedback for all eternity

glass pecan Feb 12, 2020, 5:10 PM

#

double newline probably isn't necessary @cold moon

#

also is this paginated

cold moon Feb 12, 2020, 5:10 PM

#

Ye, this is paginated

glass pecan Feb 12, 2020, 5:10 PM

#

did you see if the markdown bug is still present

cold moon Feb 12, 2020, 5:10 PM

#

What?

glass pecan Feb 12, 2020, 5:10 PM

#

markdown in embeds used to not clear on embed edits

#

i have not heard that being fixed yet

#

so it would result in weird double text or leftovers

cold moon Feb 12, 2020, 5:11 PM

#

For me everything works correctly

glass pecan Feb 12, 2020, 5:11 PM

#

at least until you visited another channel and came back

#

righto then, that's a good sign. it's pretty obvious when it happens, so should be fine

eternal owl Feb 12, 2020, 5:20 PM

#

how is this

📎 Screenshot_from_2020-02-12_22-50-14.png

glass pecan Feb 12, 2020, 5:21 PM

#

whats this

eternal owl Feb 12, 2020, 5:22 PM

#

tags detail page

#

https://github.com/python-discord/site/issues/178

glass pecan Feb 12, 2020, 5:25 PM

#

is it just me or does this look like a wiki page though

cold moon Feb 12, 2020, 5:26 PM

#

This looks nice

eternal owl Feb 12, 2020, 5:27 PM

#

this is the tags list view page @glass pecan

📎 Screenshot_from_2020-02-12_22-56-46.png

#

thanks @cold moon

molten bough Feb 12, 2020, 5:28 PM

#

The link in the breadcrumb probably shouldn't say Bulma

#

haha

eternal owl Feb 12, 2020, 5:28 PM

#

oh yea

#

hows the UI, g

#

{
    "url":"https://github.com/RohanJnr",
    "image":{
        "url":"https://assets.pokemon.com/assets//cms2-en-uk/img/misc/_tiles/pokemon-day/2020/pokemon-day-2020-169-en.jpg"
    },
    "author":{
        "name":"Iceman"
    },
    "fields":[
        {
            "name":"Field One",
            "value":"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus ac rhoncus velit."
        },
        {
            "name":"Field Two",
            "value":"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus ac rhoncus velit."
        }
    ],
    "footer":{
        "text":"footer text",
        "icon_url":"https://cdn.discordapp.com/emojis/638729835442602003.png?v=1"
    },
    "description":"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus ac rhoncus velit. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Fusce nisi dui, faucibus sit amet egestas eu, imperdiet vel lectus. Aliquam vulputate volutpat porta. Interdum et malesuada fames ac ante ipsum primis in faucibus."
}```
i am using this for Testing

#

I have not added all the fields tho

#

like video, time, etc

glass pecan Feb 12, 2020, 5:30 PM

#

@eternal owl command and author details at the top i'd probably use bulma tags.
The tag content itself can either be as you've got it, or you could choose to adjust it to be embed-esque so it's familiar to the discord view.

eternal owl Feb 12, 2020, 5:30 PM

#

what is embed-esque

glass pecan Feb 12, 2020, 5:31 PM

#

similar to the style of the discord embeds

eternal owl Feb 12, 2020, 5:32 PM

#

where can I find it

#

is it a bulma thing?

glass pecan Feb 12, 2020, 5:32 PM

#

no

#

if it's too complex a thought, don't worry about it, was just a thoughty

eternal owl Feb 12, 2020, 5:34 PM

#

So its like a discord embed stype

#

its not hard i guess

#

lemme try

molten bough Feb 12, 2020, 5:34 PM

#

I wrote some CSS that kind of does that with the messages framework

eternal owl Feb 12, 2020, 5:36 PM

#

where can i find discord embed background color

#

where can I find that css g

molten bough Feb 12, 2020, 5:36 PM

#

Probably in the static folder

#

I don't think I have it cloned here

clever wraith Feb 12, 2020, 5:37 PM

#

constants.py

molten bough Feb 12, 2020, 5:38 PM

#

We're not talking about the bot.

clever wraith Feb 12, 2020, 5:38 PM

#

ohhh

#

i was working on the bot so first thing popped was that only

molten bough Feb 12, 2020, 5:41 PM

#

Yep, it's in static/css/base/notification.css

#

Do not attempt to make a messages div

#

that won't do what you want

#

but this should give you an idea of how I gave it that signature left border

eternal owl Feb 12, 2020, 5:41 PM

#

I tried my own, not the best , lol

📎 Screenshot_from_2020-02-12_23-11-31.png

#

I need figure out better colours

molten bough Feb 12, 2020, 5:42 PM

#

well you'd still need to make it.. look like an embed

#

also, the site doesn't have a dark theme

#

use the light theme embeds

#

I wrote CSS for that too

eternal owl Feb 12, 2020, 5:42 PM

#

wait

#

arent embeds dark?

molten bough Feb 12, 2020, 5:42 PM

#

Not in the light theme

eternal owl Feb 12, 2020, 5:43 PM

#

ohh there exists a light theme, right

molten bough Feb 12, 2020, 5:43 PM

#

oh, iceland

#

haha

eternal owl Feb 12, 2020, 5:43 PM

#

lol

glass pecan Feb 12, 2020, 5:43 PM

#

yes pls use lighttheme embed style lol

eternal owl Feb 12, 2020, 5:43 PM

#

will do

#

But Im done for today, I will do the rest tmw

glass pecan Feb 12, 2020, 5:43 PM

#

maybe down the line we'll add a theme switcher to the site, but it's super low priority. for now better to be consistent

#

and sure thing

eternal owl Feb 12, 2020, 5:44 PM

#

I will look into ur css, g

#

but tmw

molten bough Feb 12, 2020, 5:44 PM

#

the CSS I wrote for that currently requires is-dark bot set on the notifications if you want dark theme

#

might be best to change that

eternal owl Feb 12, 2020, 5:44 PM

#

night

molten bough Feb 12, 2020, 5:44 PM

#

so you can just set it on the body or something, dark-theme or whatever

#

Later, rohan

glass pecan Feb 12, 2020, 5:44 PM

#

@clever wraith can you please fix your PR. Your description doesn't describe anything, it's just basic commentary and your reasoning is useless

#

If you want to keep contributing, I hope to see a little effort in what you bring to the table please

#

Communication is a very important aspect of contributing, and it doesn't feel like you're really caring much about it

clever wraith Feb 12, 2020, 5:46 PM

#

wait i think i need to put some pressure on my mind

#

ok i want help in reasoning

molten bough Feb 12, 2020, 5:47 PM

#

What PR is this?

clever wraith Feb 12, 2020, 5:47 PM

#

https://github.com/python-discord/seasonalbot/pull/349

GitHub

Bookmark reaction bookmark by AG4lyf · Pull Request #349 · python-d...

Relevant Issues
Closes #341 and #338
Description
Can't belive the 338 just needed
if target_message is None:
target_message = ctx.message

otherwise i tried to include i...

molten bough Feb 12, 2020, 5:47 PM

#

lol, "people requested this"

#

didn't you request this?

glass pecan Feb 12, 2020, 5:47 PM

#

I also edited out the top section that's meant to be part of the template defaults.

clever wraith Feb 12, 2020, 5:47 PM

#

ahh man i am so bad at this job

molten bough Feb 12, 2020, 5:48 PM

#

The reasoning is the "why"

#

so like, why is this feature useful?

#

what does it bring to the table?

#

the description doesn't describe what the PR is, either

clever wraith Feb 12, 2020, 5:49 PM

#

## Description
Can't belive the 338 just needed

    if target_message is None:
        target_message = ctx.message

otherwise i tried to include it previously with a bug related update
but it needed some planning and improvement so we doing it now 
it basically create a temp list of the people who alredy got the bookmark , 
when someone react with pin emoji it check if user in that list if not it sends the 
bookmark to prevent spamming. and after 5 minutes it removes all the reaction.


## Reasoning
People requested this
Also it provide less keyboard typing to do same thing which can be done like this

#

what about this one ?

#

@glass pecan you know thats the only thing i suck at.
I think its better now

glass pecan Feb 12, 2020, 5:52 PM

#

what's the only thing you suck at?

#

communication?

clever wraith Feb 12, 2020, 5:52 PM

#

yeah

#

ok you are typing for so long

glass pecan Feb 12, 2020, 5:54 PM

#

Communication covers things like these issue and pr tickets, your commit messages, planning features, being a constructive part of discussions rather than just demanding things, listening to feedback from others and actually considering them when moving forward especially when it's from people who have been working on these projects for a fair amount of time.

#

If you think it's "the only thing you suck at" and it's fine to overlook, you're greatly mistaken

#

It's an absolutely massive part of contributing, impacts almost every single stage of things and truly results in extreme frustration when you're not willing to improve

#

And honestly, I've really not seen much of an effort from you to improve in these aspects yet, so take these words to heart because if you don't start making more of an effort, I'm not really going to let it keep going as it is

clever wraith Feb 12, 2020, 5:57 PM

#

ok got it

#

is it ok now ?

#

or more ?

cold moon Feb 12, 2020, 5:57 PM

#

Should scarymovie and romancemovie stay as different commands or should they 1 movie call to new movies command?

glass pecan Feb 12, 2020, 5:57 PM

#

@clever wraith ill read it soon, i'm writing my own tickets atm

#

@cold moon it's a good consideration to merge it, so your question is good

#

would you feel it makes more sense to put each type under a parent command of movies instead

#

like movies scary and movies romance for example

cold moon Feb 12, 2020, 6:00 PM

#

This is what I'm making, just these (scary and romancemovie) would ctx.invoke, so basically like alias of like .movies horror

glass pecan Feb 12, 2020, 6:01 PM

#

the purpose of the alias is backward in that case though

#

the alias is mostly for direct invoking things that would be hidden in subcommands instead

#

such as some of our site commands

#

!help site

stable mountainBOT Feb 12, 2020, 6:01 PM

#

Command Help

!site
Can also use: s

Commands for getting info about our website.

Subcommands:
faq
Info about the site's FAQ page.
help
Info about the site's Getting Help page.
home
Info about the website itself.
resources
Info about the site's Resources page.
rules [rules...]
Provides a link to all rules or, if specified, displays specific rule(s).
tools
Info about the site's Tools page.

glass pecan Feb 12, 2020, 6:01 PM

#

you'll see !site rules often used as !rules instead

#

in your case, both your commands are already top levels

cold moon Feb 12, 2020, 6:02 PM

#

yeah, then should I remove these cogs after my work is done?

glass pecan Feb 12, 2020, 6:02 PM

#

in what sense?

#

sorry, just don't know if you're deciding on one way or the other atm regarding command structure

cold moon Feb 12, 2020, 6:04 PM

#

I mean these RomanceMovieFinder and ScaryMovie. When .movies command is added these commands is available there too. Just they are available always.

mellow hare Feb 12, 2020, 6:05 PM

#

Are they not all under the same movie cog?

woeful thorn Feb 12, 2020, 6:05 PM

#

No

mellow hare Feb 12, 2020, 6:05 PM

#

That's my mistake then

glass pecan Feb 12, 2020, 6:05 PM

#

feels like they kinda should be though eh

#

is the code similar

woeful thorn Feb 12, 2020, 6:05 PM

#

Yes, that's the point of this PR

glass pecan Feb 12, 2020, 6:06 PM

#

then if you're combining them into one @cold moon, you'll defs want to change their commands

#

that way they both share the parent command group of movie

#

feels the most sensible option to me

mellow hare Feb 12, 2020, 6:07 PM

#

Agreed

#

Also means you don't have to worry about unloading certain cogs

#

You just have the one that's always loaded ready to roll

molten bough Feb 12, 2020, 6:23 PM

#

I'm able to edit other people's issues/PRs on GH, is that intentional or just a limitation of their permissions system?

glass pecan Feb 12, 2020, 6:24 PM

#

it's a limitation of GH perms

molten bough Feb 12, 2020, 6:24 PM

#

Fair 'nuff

glass pecan Feb 12, 2020, 6:24 PM

#

contribs can edit issues

#

same deal with labels

molten bough Feb 12, 2020, 6:24 PM

#

I believe the "Closes" line in this PR is formatted incorrectly

#

in AG's PR, I mean

glass pecan Feb 12, 2020, 6:24 PM

#

GH has a terrible granularity

molten bough Feb 12, 2020, 6:25 PM

#

it only links one of the issues, not both

glass pecan Feb 12, 2020, 6:25 PM

#

and yeah it is gdude lol

green oriole Feb 12, 2020, 6:25 PM

#

Edits is useful to tick boxes on checklists though

molten bough Feb 12, 2020, 6:25 PM

#

True, Ak

glass pecan Feb 12, 2020, 6:25 PM

#

but don't edit it, i'd suggest commenting on it if you can gdude

molten bough Feb 12, 2020, 6:25 PM

#

Okay

glass pecan Feb 12, 2020, 6:25 PM

#

that way people can make sure they learn through repetition

#

if we do it for them, they might not remember for next time

molten bough Feb 12, 2020, 6:26 PM

#

Good point

#

I need to read up on that feature tbh, let's see..

#

yep, it is how I thought it was only, no shorthand

glass pecan Feb 12, 2020, 6:26 PM

#

i seen something new earlier today

molten bough Feb 12, 2020, 6:26 PM

#

Oh?

glass pecan Feb 12, 2020, 6:26 PM

#

hang on, still writing my big book

molten bough Feb 12, 2020, 6:27 PM

#

Haha, okay

#

Material dark Github userstyle is great, by the way

green oriole Feb 12, 2020, 6:28 PM

#

I did used it, but I removed it because something was off

molten bough Feb 12, 2020, 6:28 PM

#

A lot of styles don't theme the top bar thing

green oriole Feb 12, 2020, 6:28 PM

#

I can't remember what though

molten bough Feb 12, 2020, 6:28 PM

#

this one does though

glass pecan Feb 12, 2020, 6:28 PM

#

📎 unknown.png

green oriole Feb 12, 2020, 6:29 PM

#

Oh yeah, there is little things like this everywhere

molten bough Feb 12, 2020, 6:29 PM

#

Oh, that's neat

#

I don't see that

#

although I'm not requested reviewer haha

green oriole Feb 12, 2020, 6:29 PM

#

There is the same for PR merges too

molten bough Feb 12, 2020, 6:29 PM

#

this is how material dark looks btw

📎 unknown.png

glass pecan Feb 12, 2020, 6:30 PM

#

looks nice

molten bough Feb 12, 2020, 6:30 PM

#

I wish I could theme windows this way, but it's too risky

glass pecan Feb 12, 2020, 6:31 PM

#

at the risk of going too far off topic, i'll mention briefly that the idea of theming windows gives me throwbacks to the old Windows transformation packs you could get that fully changed core files and half of the time broke explorer lol

molten bough Feb 12, 2020, 6:32 PM

#

oh my god yes, I remember that

glass pecan Feb 12, 2020, 6:32 PM

#

i think i changed XP to Vista UI once just because why not

molten bough Feb 12, 2020, 6:32 PM

#

I did the same thing too haha

#

I think stardock had a product that did it as well

glass pecan Feb 12, 2020, 6:32 PM

#

knowing them, it was probably less breaky lol

molten bough Feb 12, 2020, 6:32 PM

#

oh, windowblinds is still.. maintained

#

impressed

glass pecan Feb 12, 2020, 6:35 PM

#

the github cli also looks quite nice

#

i might try it out sometime

green oriole Feb 12, 2020, 6:36 PM

#

Hub?

molten bough Feb 12, 2020, 6:36 PM

#

I've heard a few good things about it, but I just use PyCharm's stuff

#

or the site

glass pecan Feb 12, 2020, 6:37 PM

#

i still use git cli a lot

#

diffs and commits are super nice in pycharm though so i do use that

hardy gorge Feb 12, 2020, 6:38 PM

#

The CLI is still my go-to, but I'm starting to use PyCharm more for git.

cold moon Feb 12, 2020, 6:38 PM

#

DONE! I'll make PR soon for SeasonalBot .movies command

glass pecan Feb 12, 2020, 6:38 PM

#

i wish the PR view in pycharm wasn't so hidden though

#

excellent ks, thanks

#

don't forget to lint

#

(you should have precommit installed already tho)

molten bough Feb 12, 2020, 6:39 PM

#

it has a PR view?

#

well, case in point I guess, haha

glass pecan Feb 12, 2020, 6:40 PM

#

📎 unknown.png

molten bough Feb 12, 2020, 6:40 PM

#

Dang, nice

glass pecan Feb 12, 2020, 6:40 PM

#

i use it because i can just

#

Right Click -> "Create New Local Branch"

#

even if it's on a fork

clever wraith Feb 12, 2020, 6:41 PM

#

@molten bough it works fine at my point the closes thing , but still you are better in this so i edited it

glass pecan Feb 12, 2020, 6:42 PM

#

no it doesn't close both in the original format you had it as

#

only the first one

hardy gorge Feb 12, 2020, 6:42 PM

#

@glass pecan oh, man, I love you. That's a great feature and I had no idea it existed.

glass pecan Feb 12, 2020, 6:43 PM

#

does your partner know about this

#

am i becoming a home wrecker

rocky bloom Feb 12, 2020, 6:57 PM

#

the fact that noone knew about this kinda reinforces the fact it's so hidden 😂

glass pecan Feb 12, 2020, 6:57 PM

#

it definitely is

#

i can maybe show how bad its hidden

#

📎 unknown.png

rocky bloom Feb 12, 2020, 7:02 PM

#

yikes

green oriole Feb 12, 2020, 7:07 PM

#

Ya see @molten bough what I was saying about features hidden in submenus ^^

wispy quail Feb 12, 2020, 8:13 PM

#

Hello! I do not mean to come off as impatient, but I'm the author of the #741 PR request- it's a refactor of the information.py cog. I can get this issue with the PR too, but I just want to make sure that it is okay for it to be in the PR 😁
https://github.com/python-discord/bot/issues/744

I know I left a comment on the issue and should wait for a response, but I'm changing everything based on the requested changes on the PR- so I just wanna make sure that I can get this issue with it before the PR is accepted (if all the changes are okay) 😁

GitHub

Add thousand separators to Members count in !server · Issue #744 · ...

Right now, some numbers in the embed result of !server do not have thousand separators, here is a screenshot of it: Like this part, it does add separators: But this part it does not: The command ca...

glass pecan Feb 12, 2020, 8:15 PM

#

i must have missed this

#

thank you for bringing it to attention

#

dammit ela

#

beat me to it

#

lol

woeful thorn Feb 12, 2020, 8:16 PM

#

🙂

#

You got distracted by discord, I got distracted by github

glass pecan Feb 12, 2020, 8:16 PM

#

i was reading okay

crude gyro Feb 12, 2020, 8:17 PM

#

@wispy quail yeah, you're good.

glass pecan Feb 12, 2020, 8:17 PM

#

in general, or just for now

crude gyro Feb 12, 2020, 8:17 PM

#

both

wispy quail Feb 12, 2020, 8:19 PM

#

Awesome, thank you very much for the quick response 😁 I'll go ahead and do it up! 😄

long garnet Feb 12, 2020, 8:43 PM

#

if the name randomizer for the staff lounge were to work as the one for the OT channels, would it be better if it changed a bit more often?

#

like 3 times a day at least

woeful thorn Feb 12, 2020, 8:44 PM

#

Once a day is fine

crude gyro Feb 12, 2020, 8:45 PM

#

@clever wraith you closed the valentines PR?

long garnet Feb 12, 2020, 8:45 PM

#

mmm that's less to worry about anyway

#

and test

clever wraith Feb 12, 2020, 8:47 PM

#

yes, apologies

crude gyro Feb 12, 2020, 8:48 PM

#

but. why?

clever wraith Feb 12, 2020, 8:49 PM

#

I'd rather not go into it if that's ok

crude gyro Feb 12, 2020, 8:49 PM

#

eh. sure.

clever wraith Feb 12, 2020, 8:50 PM

#

nothing to do with you or this community

molten bough Feb 12, 2020, 8:51 PM

#

Feel free to poke me if you need to talk about anything, hax

rocky bloom Feb 12, 2020, 9:33 PM

#

ok unit testing looks way too difficult for a noob like me 😂 especially knowing me i'd forget something here and there

#

i think i'm just gonna stick to seasonalbot for now

crude gyro Feb 12, 2020, 9:35 PM

#

unit tests are optional in bot

rocky bloom Feb 12, 2020, 9:37 PM

#

yeah i know

#

but i wanted to help with the unit tests

#

so i looked into it but it looked too difficult 😂

crude gyro Feb 12, 2020, 9:46 PM

#

it's easier than it looks

#

Corey has a nice unittest series.

#

you need to know a few basic concepts, like what's a mock? what's coverage? what are some good tools that will help do this? why is it sometimes a good idea to write more than one test for the same piece of code?

#

then you're more or less good to go.

clever wraith Feb 13, 2020, 4:49 AM

#

with @dusky shore its help section is the default one and doesn't uses paginator .
If someone work on it , should it be similar to @stable mountain help menu ?

eternal owl Feb 13, 2020, 4:51 AM

#

claim it here
https://github.com/python-discord/seasonalbot/issues/295

GitHub

Add Pagination to .help · Issue #295 · python-discord/seasonalbot

With all of the contributions made to Seasonalbot over the last year, the .help command is starting to get really unwieldy: A pagination utility is provided by Seasonalbot, and you can see an examp...

clever wraith Feb 13, 2020, 4:51 AM

#

I know there is a Issue with that

eternal owl Feb 13, 2020, 4:52 AM

#

it open so you can work on it

clever wraith Feb 13, 2020, 4:52 AM

#

actually my own bot have a help .
wonder if that looks good to be in @dusky shore

eternal owl Feb 13, 2020, 4:52 AM

#

you have to use the paginator built for seasonalbot

clever wraith Feb 13, 2020, 4:52 AM

#

its pretty same

#

no one saw nothing

#

@eternal owl what kind of weird paginator it is

eternal owl Feb 13, 2020, 5:53 AM

#

It's not weird

#

Even I thought It was but it fairly simple

#

Look at the reddit command for example

clever wraith Feb 13, 2020, 5:57 AM

#

it uses ImagePaginator , i will use LinePaginator

green oriole Feb 13, 2020, 9:56 AM

#

Oh yes more lemoji!

rocky bloom Feb 13, 2020, 10:16 AM

#

YES LEMOJI

eternal owl Feb 13, 2020, 11:00 AM

#

?

green oriole Feb 13, 2020, 11:06 AM

#

See the latest #dev-log message :D

eternal owl Feb 13, 2020, 11:06 AM

#

ooh

#

pithink

eternal owl Feb 13, 2020, 12:13 PM

#

I wonder why its applying the blue color to the entier embed

📎 Screenshot_from_2020-02-13_17-42-58.png

#

code
https://pastebin.com/SkzDVZf9

Pastebin

[HTML 5] detail tags - Pastebin.com

#

using my own css

📎 Screenshot_from_2020-02-13_17-46-26.png

hardy gorge Feb 13, 2020, 12:18 PM

#

You're using is-info

eternal owl Feb 13, 2020, 12:19 PM

#

yea

hardy gorge Feb 13, 2020, 12:19 PM

#

Which is a bulma modifier of that color

eternal owl Feb 13, 2020, 12:19 PM

#

.messages .notification.is-info {
    background-color: #fdfdfd;
    border-left-color: #1c8ad3;  /* Bulma default colour */
    color: #4a4a4a;  /* Bulma default colour */
}```

#

I am using the one in the notification.css

rocky bloom Feb 13, 2020, 12:19 PM

#

~~love the pokemon logo~~

eternal owl Feb 13, 2020, 12:19 PM

#

btw why isnt there space btw .notification and .is-info

#

I stole it from pokemon.com haha @rocky bloom

rocky bloom Feb 13, 2020, 12:20 PM

#

because they're part of the same element