#dev-contrib | Python | Page 41

gusty sonnet Dec 20, 2019, 7:18 AM

#

Hmm @tawdry vapor

📎 unknown.png

#

I can commit it, does it not show up for you?

tawdry vapor Dec 20, 2019, 7:18 AM

#

It does

#

but when I clicked it, said I am not allowed (I was trying to batch them together for what it's worth)

gusty sonnet Dec 20, 2019, 7:19 AM

#

Hmm, let me try I guess

#

Oh

#

It says batching must be done from file tab

tawdry vapor Dec 20, 2019, 7:19 AM

#

Yeah I was doing that

gusty sonnet Dec 20, 2019, 7:19 AM

#

Hmm

#

Let me try then

tawdry vapor Dec 20, 2019, 7:20 AM

#

Just make the commit message nicer than the default :^)

gusty sonnet Dec 20, 2019, 7:20 AM

#

What do you want to put as commit message?

tawdry vapor Dec 20, 2019, 7:20 AM

#

The fix KeyError blahblahblah I wrote

gusty sonnet Dec 20, 2019, 7:22 AM

#

📎 unknown.png

#

Very interesting haha

#

Did you get the same message?

tawdry vapor Dec 20, 2019, 7:25 AM

#

Yes

#

I pushed some commits yesterday so either my permissions were revoked or GitHub has an issue (I have not tried pushing via command line git now because I have nothing else to push)

long garnet Dec 22, 2019, 5:42 AM

#

@tawdry vapor I failed logging 101

#

could you give me a brief explanation to know when to use which? it's not totally obvious to me :c

tawdry vapor Dec 22, 2019, 5:46 AM

#

Sure there is a good SO answer on this https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels

long garnet Dec 22, 2019, 5:48 AM

#

thanks

tawdry vapor Dec 22, 2019, 5:48 AM

#

the debug vs info one can be a bit ambiguous but just think about in what situations it'd be helpful for you to see the message

long garnet Dec 22, 2019, 5:52 AM

#

by the way, I think there's another bug in some of the moderator modules (which is present in the upstream)

#

iirc the functions that send a DM to the user don't check if the user argument is an actual discord.User/Member

#

so if it's a discord.Object it fails to send the message

#

kinda minor bug because the bot can't send messages if they don't share the server I think (might be wrong of this), but regardless, the exception breaks the function and the "<x> applied to whatever" doesn't show up

#

I should prolly check it, I might be wrong

tawdry vapor Dec 22, 2019, 5:56 AM

#

Yeah I already commented about that in the review

#

It's not really how you describe it though

#

You are right it doesn't check the type. However, the parameters are correctly annotated - they don't specify that a discord.Object is allowed

#

But there's no place where something other than a user or member is given as far as I can see

#

Regarding the can't share server thing, I don't know, but the function should catch those exceptions so it's fine.

long garnet Dec 22, 2019, 6:00 AM

#

ah, I meant it in a way that the banned user wouldn't know even if it didn't fail

#

async def send_private_embed(user: UserTypes, embed: discord.Embed) -> bool:
# ...
    await user.send(embed=embed)```

#

(no .send method in discord.Object)

tawdry vapor Dec 22, 2019, 6:02 AM

#

Yeah I understand

#

But it will never fail in practice

#

Yes, there are no actual safeguards against it

#

But nothing is currently broken as far as I can tell regarding that

#

IMO it should just raise the exception because a discord.Object should never be given to that function anyway, and that is made clear by the function annotations

long garnet Dec 22, 2019, 6:04 AM

#

I'll leave it then

tawdry vapor Dec 22, 2019, 6:05 AM

#

You could catch the attributeerror and use log.exception

#

Sorry, it doesn't actually need to raise it. I said that cause I was interested in the traceback, and that can just be logged without raising it

#

If you want you can add it. I think it's OK either way

long garnet Dec 22, 2019, 7:05 AM

#

nvm I just now understand what you said

long garnet Dec 22, 2019, 5:42 PM

#

@tawdry vapor what do you mean by

This fetch_user needs to be addressed somehow (e.g. skip DM if user is a proxy) because otherwise it will raise an error
in relation with this? https://github.com/python-discord/bot/blob/3b6c7d88695fa6703ab94786b3ec8aade32f9c3e/bot/cogs/moderation/scheduler.py#L110

#

I am unclear in which case it would raise an error, since that's making it a proper user... you mean I should catch possible exceptions if that fetch fails?

tawdry vapor Dec 22, 2019, 5:44 PM

#

Yeah that is what I meant, sorry

#

Just catch the exception is OK

#

When I wrote that I was thinking it would fail again but maybe the fetch will work even though it failed in the converter.

long garnet Dec 22, 2019, 5:47 PM

#

depends

#

if the fetching in FetchedUser fails but returns a discord.Object, that discord.Object might be incorrect

#

really low chances for that to happen though

#

but if it fails completely apply_infraction won't be even called

tawdry vapor Dec 22, 2019, 7:43 PM

#

@long garnet If you didn't know, you could have batched my review suggestions and committed them via GitHub

#

It looks like you manually did the changes

long garnet Dec 22, 2019, 7:43 PM

#

yeah, but I wasn't sure how to change them

#

you missed many fs for f-strings

tawdry vapor Dec 22, 2019, 7:43 PM

#

Oh sorry

#

Well you could have just not committed the ones I messed up 😄

long garnet Dec 22, 2019, 7:44 PM

#

I also do this a bit on purpose because I want to avoid using the GitHub tools as much as possible

#

same with working with forks and not a branch

#

it helps me keep learning

#

@tawdry vapor

            try:
                if not isinstance(user, (discord.Member, discord.User)):
                    user = await self.bot.fetch_user(user.id)
            except discord.HTTPException as e:
                log.error(f"Failed to fetch user `{user.id}`: status {e.status}")
            else:
                # Accordingly display whether the user was successfully notified via DM.
                if await utils.notify_infraction(user, infr_type, expiry, reason, icon):
                    dm_result = "📨 "
                    dm_log_text = "\nDM: Sent"
                else:
                    dm_result = f"{constants.Emojis.failmail} "
                    dm_log_text = "\nDM: **Failed**"```about to do the last commit, does this look good?

#

not sure what's failing there

📎 unknown.png

tawdry vapor Dec 22, 2019, 7:47 PM

#

cant have a space after it

long garnet Dec 22, 2019, 7:47 PM

#

right

#

I thought it might be wise to avoid fetching if not necessary

#

idk

tawdry vapor Dec 22, 2019, 7:48 PM

#

Yes that looks OK

#

Did you test it?

long garnet Dec 22, 2019, 7:48 PM

#

No, I'm about to

tawdry vapor Dec 22, 2019, 7:48 PM

#

👌

long garnet Dec 22, 2019, 7:48 PM

#

I did test the watching channel ones

#

those are commited already

#

I nominated absent-lemon in my server, amazing

tawdry vapor Dec 22, 2019, 7:50 PM

#

Yeah it is a bit odd to nominate someone that isn't in the server 🤔

long garnet Dec 22, 2019, 7:50 PM

#

well, it's a side effect

tawdry vapor Dec 22, 2019, 7:50 PM

#

Right

#

It's fine

long garnet Dec 22, 2019, 7:51 PM

#

if it gets to the proxy then it's because the bot doesn't know if it's in the server or not

#

and if they use proxy in the watching modules then I assume they wanted to watch/nominate people in that case too

#

(though yeah, why nominate? I'd rather have it fail)

tawdry vapor Dec 22, 2019, 7:51 PM

#

All the members in the guild should already be in the cache unless something is really wrong with Discord at that time

long garnet Dec 22, 2019, 7:52 PM

#

(watching for supervision makes some sense)

#

ah, that try-except is wrong because those vars in else: are used afterwards anyway lol

tawdry vapor Dec 22, 2019, 7:55 PM

#

you can just move them outside

#

like right under if not infraction["hidden"]:

long garnet Dec 22, 2019, 7:58 PM

#

        if not infraction["hidden"]:
            dm_result = f"{constants.Emojis.failmail} "
            dm_log_text = "\nDM: **Failed**"

            # Sometimes user is a discord.Object; make it a proper user.
            try:
                if not isinstance(user, (discord.Member, discord.User)):
                    user = await self.bot.fetch_user(user.id)
            except discord.HTTPException as e:
                log.error(f"Failed to fetch user `{user.id}`: status {e.status}")
            else:
                # Accordingly display whether the user was successfully notified via DM.
                if await utils.notify_infraction(user, infr_type, expiry, reason, icon):
                    dm_result = ":incoming_envelope: "
                    dm_log_text = "\nDM: Sent"```like with a default value?

tawdry vapor Dec 22, 2019, 7:59 PM

#

Yeah

#

That's basically what it was doing anyway, I think

#

I just used an else originally to make it more readable

patent pivot Dec 22, 2019, 9:51 PM

#

hm, this is a bit confusing imo

📎 unknown.png

#

the two links go to the intros for non-programmers and programmers but there is no description of that at all

green oriole Dec 22, 2019, 9:52 PM

#

They don't point to the sane link?

crude gyro Dec 22, 2019, 9:53 PM

#

there is a description on hover, I think

#

but yeah it sucks.

green oriole Dec 22, 2019, 9:54 PM

#

I think this page in itself is misleading anyway

patent pivot Dec 22, 2019, 10:03 PM

#

no hover text that i can see

📎 unknown.png

sharp timber Dec 25, 2019, 10:56 AM

#

Not sure if this is known already or not, but if there are exactly 11 lines of output the bot will output 10. At 12 lines it will begin to upload the output to a paste

green oriole Dec 25, 2019, 10:59 AM

#

Yes, looks like a bug

#

I'm searching through the issues but I don't think it has been already reported

#

Doesn't look like there is one, do you mind opening an issue please?

sharp timber Dec 25, 2019, 11:03 AM

#

I'll do so

hardy gorge Dec 25, 2019, 11:36 AM

#

!e
print(*range(11), sep="\n")

stable mountainBOT Dec 25, 2019, 11:36 AM

#

@hardy gorge :white_check_mark: Your eval job has completed with return code 0.

hardy gorge Dec 25, 2019, 11:36 AM

#

Interesting.

green oriole Dec 25, 2019, 11:43 AM

#

I'll try to batch some eval related issue later today

#

Now that it support external libraries, I think it is a good time to upgrade it

green oriole Dec 25, 2019, 4:33 PM

#

Can't create a draft PR without any commit?

#

That sucks

#

Guys.. I have a small issue..

#

I have an AttributeError: SIGKILL on elif returncode == 128 + Signals.SIGKILL:, but when I use jump to definition, it is clearly defined

📎 unknown.png

#

Line 104 in \bot\cogs\snekbox.py (https://github.com/python-discord/bot/blob/master/bot/cogs/snekbox.py#L104) if you wanna check out

crude gyro Dec 25, 2019, 4:52 PM

#

complete traceback?

green oriole Dec 25, 2019, 4:52 PM

#

Yes sir!

#

https://paste.pythondiscord.com/rofebuwono.py

crude gyro Dec 25, 2019, 4:55 PM

#

what operating system are you on?

green oriole Dec 25, 2019, 4:56 PM

#

Windows

#

On a docker-less setup if that can help

crude gyro Dec 25, 2019, 4:56 PM

#

looks like this constant might not exist on windows

#

the signals module does not guarantee the presence of all the signals on every OS

#

it's platform dependant

green oriole Dec 25, 2019, 4:57 PM

#

There is no SIGKILL on windows?

crude gyro Dec 25, 2019, 4:57 PM

#

that's what I'm finding

#

in windows, the equivalent would be SIGTERM

green oriole Dec 25, 2019, 4:57 PM

#

Hmm, seems kind of logic

molten bough Dec 25, 2019, 4:57 PM

#

windows does have SIGKILL, sort of

#

there isn't actually a signal for it

#

it just fucking murders the process

crude gyro Dec 25, 2019, 4:57 PM

#

that's not the point, the point is that there's no SIGKILL constant in the Signals IntEnum if you're on windows

green oriole Dec 25, 2019, 4:58 PM

#

Windows, the process murderer

crude gyro Dec 25, 2019, 4:58 PM

#

and so, you get the above traceback.

#

which kinda sucks.

tawdry vapor Dec 25, 2019, 4:58 PM

#

NsJail cannot even run on Windows in the first place

green oriole Dec 25, 2019, 4:58 PM

#

It does run

#

If I remove this line

#

So I guess a simple getattr would be enough

tawdry vapor Dec 25, 2019, 4:59 PM

#

NsJail is linux only. It relies on groups among other linux only features. It fundamentally cannot work on Windows

crude gyro Dec 25, 2019, 4:59 PM

#

yeah I'm not sure why you're trying to spin this up on windows.

tawdry vapor Dec 25, 2019, 4:59 PM

#

Maybe snekbox will start but should you try to use it, it wont work

#

Oops, meant to write cgroups not groups

green oriole Dec 25, 2019, 5:00 PM

#

📎 unknown.png

#

It does run

crude gyro Dec 25, 2019, 5:00 PM

#

anyway if we were going to fix this, I'd simply add an elif extra before the failing one that looks for a SIGTERM

green oriole Dec 25, 2019, 5:00 PM

#

I just want to work with the bot-side interface

tawdry vapor Dec 25, 2019, 5:00 PM

#

Oh this is on the bot?

green oriole Dec 25, 2019, 5:00 PM

#

Yep

tawdry vapor Dec 25, 2019, 5:00 PM

#

OK, sorry then

crude gyro Dec 25, 2019, 5:00 PM

#

snekbox cog

#

not snekbox repo

green oriole Dec 25, 2019, 5:01 PM

#

I want to work on a few snekbox enhancements, I can fix it

#

Yeah, I should have specified it, my bad

tawdry vapor Dec 25, 2019, 5:02 PM

#

You did I just suck at reading

crude gyro Dec 25, 2019, 5:02 PM

#

elif returncode == 128 + Signals.SIGTERM or returncode == 128 + Signals.SIGKILL:
    msg = "Your eval job timed out or ran out of memory"

maybe this is fine?

green oriole Dec 25, 2019, 5:03 PM

#

Nope

tawdry vapor Dec 25, 2019, 5:03 PM

#

Since the returncode comes from a linux process, it should just subtitute sigkill with the hardcoded value. I think using sigterm would be incorrect

#

Unless sigterm on Windows has the same value sigkill does on linux

crude gyro Dec 25, 2019, 5:04 PM

#

hm.

tawdry vapor Dec 25, 2019, 5:04 PM

#

I probably used the signals enum cause it's clearer than having some hardcoded integer

crude gyro Dec 25, 2019, 5:05 PM

#

well write some code above then that tries to resolve first SIGKILL and then SIGTERM to an int, and then use that in the check.

#

we can even just define our own SIGKILL that will conditionally be equal to SIGTERM if SIGKILL doesn't exist

#

SIGTERM will always exist on windows.

#

then check against that

green oriole Dec 25, 2019, 5:07 PM

#

But if I run

!e import time
time.sleep(10)```It does not say that it timed-out

#

But do we really care?

tawdry vapor Dec 25, 2019, 5:08 PM

#

I think you misunderstood my point. SIGKILL is equal to integer 9 on linux. Therefore, unless SIGTERM on Windows also equals 9, then SIGTERM cannot be used. It's probably better to say SIGKILL = 9 in some constant.

crude gyro Dec 25, 2019, 5:09 PM

#

why

green oriole Dec 25, 2019, 5:09 PM

#

Hard coding 9 does work though

crude gyro Dec 25, 2019, 5:09 PM

#

I don't understand why that would be the case at all.

#

can you walk me through it, @tawdry vapor

green oriole Dec 25, 2019, 5:09 PM

#

But using Signals.SIGTERM does not work

#

Because NsJail will always return the same code, the platform doesn't matter

tawdry vapor Dec 25, 2019, 5:11 PM

#

The returncode is returned by the snekbox API. So this return code is the return code of the Python process that NsJail ran. Importantly, this process ran in the context of a linux machine. Therefore, the returncode has to be interpreted as a linux return code regardless of where the code that interprets it is running.

crude gyro Dec 25, 2019, 5:11 PM

#

wait no, never mind. I get it. because the code is executing inside a linux system.

#

yeah

#

fine then, let's just make a SIGKILL constant which equals 9

green oriole Dec 25, 2019, 5:11 PM

#

Oki

crude gyro Dec 25, 2019, 5:11 PM

#

and use that

#

but what about this line

#

name = Signals(returncode - 128).name

#

is this safe?

tawdry vapor Dec 25, 2019, 5:12 PM

#

Yeah it's in a try except but on Windows may not be accurate if it has different return codes

#

So it could return an incorrect signal name? Not sure

#

It's only for display purposes

crude gyro Dec 25, 2019, 5:13 PM

#

iunno, probably just more likely to trip the ValueError

green oriole Dec 25, 2019, 5:13 PM

#

Signals changes depending on the platform, don't think it would work

crude gyro Dec 25, 2019, 5:13 PM

#

don't think what would work

green oriole Dec 25, 2019, 5:13 PM

#

name = Signals(returncode - 128).name

crude gyro Dec 25, 2019, 5:14 PM

#

it'll work for whatever signals are available

#

which seems to be the point of that line

tawdry vapor Dec 25, 2019, 5:14 PM

#

I don't think it's worth the bother trying to make this platform independent (probably by creating our own enum with the hardcoded linux signals)

crude gyro Dec 25, 2019, 5:15 PM

#

sounds like this is solved

green oriole Dec 25, 2019, 5:15 PM

#

I just have a last question, where do I put the constant?

tawdry vapor Dec 25, 2019, 5:15 PM

#

with the rest of them

green oriole Dec 25, 2019, 5:15 PM

#

I mean, in which category?

tawdry vapor Dec 25, 2019, 5:16 PM

#

I don't understand

#

There are like 6 constants at the top of the module

#

just put it there

green oriole Dec 25, 2019, 5:16 PM

#

Oh, not in the config file, okay (make sense actually)

crude gyro Dec 25, 2019, 5:17 PM

#

config file constants are for things you need to use in many different modules

green oriole Dec 25, 2019, 5:33 PM

#

Draft PR opened!

#

Do we still need to ask to be assigned, or we can do that ourselves now?

#

(Or I don't really need to assign myself since it is written linked a pull request that will close this issue on the issue?)

tawdry vapor Dec 25, 2019, 5:45 PM

#

Yes, you should still ask to be assigned

#

You should have done that before you opened your PR really

#

It's just to make sure we don't run into issues with multiple people working on the same thing

green oriole Dec 25, 2019, 5:46 PM

#

One of them has been opened by me, should I still ask?

#

Yeah, that was silly, sorry

#

But I haven't started working on it yet

#

Thanks!

hardy gorge Dec 25, 2019, 5:52 PM

#

The one who opens an issue is not necessarily the same person as who's going to work on it, so you should still be assigned.

tough imp Dec 25, 2019, 8:53 PM

#

I have a question regarding assignment permissions on github - as contributors we have the ability to assign people to issues, but we're advised not to self-assign but ask a core dev instead. This is entirely reasonable to me, but I'm wondering why we then have the permission - is it so that we can we assign others? For example I've now come across https://github.com/python-discord/bot/issues/602 which alberthdev has been working on since October and they even have a PR in progress at https://github.com/python-discord/bot/pull/633, and they commented under another issue at https://github.com/python-discord/bot/issues/599, but they aren't assigned on either issue. So I suppose the question I have is then is it ok if I come across such an issue that I assign the person myself, I'm just not supposed to assign my own self? Otherwise if only core devs are supposed to assign, then I think it would make sense to strip the permission from roles below.

Additionally if I wish to be assigned on multiple issues such as https://github.com/python-discord/bot/issues/553#issuecomment-568613672, is it necessary that I actually go and leave a comment under each specific one and then wait?

tawdry vapor Dec 25, 2019, 9:00 PM

#

Regarding why you are permitted to assign, it's because GitHub doesn't allow for configuring permissions to such fine degree.

tough imp Dec 25, 2019, 9:05 PM

#

Oh ok, I didn't know that

tawdry vapor Dec 25, 2019, 9:06 PM

#

We'll get back to you on the other questions

tough imp Dec 25, 2019, 9:06 PM

#

Perfect thanks

green oriole Dec 25, 2019, 11:40 PM

#

Can someone quickly review this please? (just a one line addition in the config file) https://github.com/python-discord/bot/pull/683

GitHub

Whitelist Discord Testers invite link by Akarys42 · Pull Request ...

Hi, this PR add the Discord Testers invite link to the guild invite whitelist. This server is own by the discord devs and is used to report bugs related to discord clients.

#

Thanks lemon!

snow zealot Dec 26, 2019, 8:39 AM

#

Where does !eval really execute the code? An online compiler? Which one is it?

crude gyro Dec 26, 2019, 8:48 AM

#

we wrote our own, @snow zealot

snow zealot Dec 26, 2019, 8:48 AM

#

can I access it, outside of the bot?

crude gyro Dec 26, 2019, 8:49 AM

#

you could self-host it.

#

it's on our github org

#

it's called snekbox

snow zealot Dec 26, 2019, 8:49 AM

#

Uhm, are there directions somewhere on how I would go about doing that? I'm not sure what self-hosting is

crude gyro Dec 26, 2019, 8:50 AM

#

I think there are some directions in the repo readme, but it's not uncomplicated.

snow zealot Dec 26, 2019, 8:50 AM

#

oh no 😭

#

mhm, I'll give it a try nevertheless

crude gyro Dec 26, 2019, 8:50 AM

#

I've heard repl.it will bring back an API soon

#

so hopefully this sort of thing won't be so hard in the future.

snow zealot Dec 26, 2019, 8:51 AM

#

uhm, the only one I really really liked, was rextester.com

#

which isn't even famous

#

and now they're gonna get shut down due to lack of funds

#

hence the sudden interest

crude gyro Dec 26, 2019, 8:51 AM

#

hmm. I see.

snow zealot Dec 26, 2019, 8:51 AM

#

Also

#

why did y'all write your own compilers when free online compilers exist? Security reasons or something else?

crude gyro Dec 26, 2019, 8:56 AM

#

probably mostly because we could

#

it was a fun challenge to solve

#

and it allows us more granular control

snow zealot Dec 26, 2019, 8:57 AM

#

oh okay.

glass pecan Dec 26, 2019, 8:59 AM

#

if you use docker, it's pretty simple to host

#

assuming you just wanted to play with it at least.

#

something like this maybe if defined in a compose

#

version: 3.7

services:
  snekbox:
    image: pythondiscord/snekbox
    ports:
      - 8060:8060
    privileged: true
    init: true
    environment: 
      - DEBUG=True  # for log levels, optional

snow zealot Dec 26, 2019, 9:32 AM

#

mhm, no I don't use docker but I can sure download it and learn bout it

#

and yes, I'm looking to play around with it in the sense that I'd like it to be my replacement for compilers when rextester goes down, and when I'm not in the mood for spyder(because spyder takes a whole darn minute to load while rextester took 3 seconds to open)

green oriole Dec 26, 2019, 10:51 AM

#

?

📎 Screenshot_20191226-1149542.png

glass pecan Dec 26, 2019, 10:59 AM

#

It appears @patent pivot disabled the widget api making it no longer able to get the member count

patent pivot Dec 26, 2019, 10:59 AM

#

Ah so we do use it

#

The reason it was disabled was because it was letting listing sites harvest membership and user data for the server

#

so I asked if we were using it and I was told we weren't

#

if we do need that we can bring it back

glass pecan Dec 26, 2019, 11:01 AM

#

that's unfortunate. would be nice if https://shields.io/ would be able to use in it's place an invite code instead, as that would provide the same data

patent pivot Dec 26, 2019, 11:02 AM

#

I could try contribute that

glass pecan Dec 26, 2019, 11:03 AM

#

i had a look at their github and it appears it's entirely js

#

no relevant issues open for it atm

green oriole Dec 26, 2019, 11:04 AM

#

And what is the problem with the listing sites? Isn't that a good thing?

glass pecan Dec 26, 2019, 11:04 AM

#

not really

#

if they're getting membership data regarding individual members, we'd rather not have them using us like that

patent pivot Dec 26, 2019, 11:05 AM

#

It's not listing sites, it's sites that take in a user ID and show anyone every discord server they are in

glass pecan Dec 26, 2019, 11:05 AM

#

they've got no permission from us and discord don't provide that data by default

#

so for privacy, why leave the hole open

patent pivot Dec 26, 2019, 11:05 AM

#

especially for something as small as member count

glass pecan Dec 26, 2019, 11:06 AM

#

i personally hadn't known that this was a thing otherwise i wouldn't have used it

green oriole Dec 26, 2019, 11:07 AM

#

Oh, they have access to user data too? Yeah, that's a problem haha

glass pecan Dec 26, 2019, 11:07 AM

#

yeah it makes sense i guess. the widget is for showing a preview into the server

crude gyro Dec 26, 2019, 11:07 AM

#

yeah it makes it possible to do stuff like search for a member and see all the servers they're on

#

all the ones with widgets enabled, at least

#

which is certainly an invasion of privacy

glass pecan Dec 26, 2019, 11:07 AM

#

pretty lame, yep

patent pivot Dec 26, 2019, 11:08 AM

#

https://github.com/badges/shields/blob/master/services/discord/discord.service.js

GitHub

badges/shields

Concise, consistent, and legible badges in SVG and raster format - badges/shields

glass pecan Dec 26, 2019, 11:08 AM

#

doesn't matter who, but this is important enough to probably make an issue for

green oriole Dec 26, 2019, 11:08 AM

#

Could we not create our own badge? Shouldn't be that hard

glass pecan Dec 26, 2019, 11:08 AM

#

lol why add another thing to maintain

patent pivot Dec 26, 2019, 11:08 AM

#

I can see if I can get shields to make an invite based one

glass pecan Dec 26, 2019, 11:08 AM

#

badges aren't that important. but it's not like they can't add it to shields.io themselves yeah

#

just the invite code as an input would be plenty, as we're already using the invite as the link so having it in the badge img url shouldn't be an issue

patent pivot Dec 26, 2019, 11:09 AM

#

split it out into id and invite based

#

existing users won't be broken that way

glass pecan Dec 26, 2019, 11:10 AM

#

yeah

#

they'd need to still cache this though

patent pivot Dec 26, 2019, 11:10 AM

#

I'll play around with that in a bit

glass pecan Dec 26, 2019, 11:10 AM

#

pretty sure server data has a heavy ratelimit

#

we use it though in our own code

crude gyro Dec 26, 2019, 11:11 AM

#

would be fun to have some custom badges, though.

total member count
online member count
bot currently online

bet the site could host such custom badges real easily.

#

but yeah, stupid to add another thing to maintain

#

we're having a hard time keeping up with our current set of features as it is

patent pivot Dec 26, 2019, 11:11 AM

#

first two we can do through shields

glass pecan Dec 26, 2019, 11:11 AM

#

if we get stats going, then i see no issue with that. but not as a standalone

crude gyro Dec 26, 2019, 11:12 AM

#

certainly not something to do right now either way

glass pecan Dec 26, 2019, 11:12 AM

#

the only custom badge i'd like to see though is one for github actions. their one is lame because of their crappy svg generation and font styling

#

unless shields.io adds one for it too

#

then it would be good 😄

tough imp Dec 27, 2019, 2:38 PM

#

i'm getting this warning when running the bot's test suite

/home/kwzrd/Code/pydis-bot/bot/bot.py:21: DeprecationWarning: The object should be created from async function
  resolver=aiohttp.AsyncResolver(),
/home/kwzrd/.local/share/virtualenvs/pydis-bot-ULHzK8dH/lib/python3.7/site-packages/aiohttp/connector.py:730: DeprecationWarning: The object should be created from async function
  loop=loop)

i think this was changed recently to reduce the amount of spawned threads, just asking if we're aware of the deprecation warning

tough imp Dec 27, 2019, 2:55 PM

#

additionally i'd like to ask, I have the following namedtuple

class Case(NamedTuple):
    recent_messages: List[MockMessage]
    culprit: Tuple[str]
    total_attachments: int

I use it to represent test cases for antispam rules, so I'm redefining it in multiple modules - I'd like to put it somewhere from where I can import it instead, but I'm not sure if it's generic enough to actually go into tests.helpers.py, would it be reasonable to create a tests.bot.rules.helpers.py module and put it there? it's only used by the rules tests, but i'm not sure if it's a good idea to have two separate helpers modules, or if its a good idea to even import it as it's really just 4 lines of code

mellow hare Dec 27, 2019, 3:03 PM

#

@tough imp I think we are aware of that deprecation warning but that one is coming from aiohttp, so as our dependencies continue to update, it shouldn't be an issue

tough imp Dec 27, 2019, 3:04 PM

#

oh right ok, makes sense thanks

long garnet Dec 28, 2019, 7:36 AM

#

@clever wraith ah, I thought you meant "updates on what's going on, what's the status", not "is snekbox going to be updated?"

#

it should be updated at some point, yeah, but I'm not the best person to say it

#

don't consider me a representative of the PyDis projects in any way, I am not

sharp timber Dec 28, 2019, 9:18 AM

#

f = open('/dev/kmsg', 'rb'); import os; s = os.dup(f.fileno()); f.close(); import fcntl; fcntl.fcntl(s, fcntl.F_SETFL, os.O_NONBLOCK); print(os.read(s, 1000))

#

reads from host kmsg

#

I can also access /dev/mem which appears to read from host memory (!), but not from within nsjpy, just from the dev shell, so I'm not sure how 'dangerous' that is

#

Thankfully neither allow me to open them RW

crude gyro Dec 28, 2019, 9:22 AM

#

paging @ionic tundra

#

best you guys work together on this if you're both working on a fix

#

the above may be interesting

ionic tundra Dec 28, 2019, 9:23 AM

#

oh damn

#

yep, good thing you cant write to that... 😬

crude gyro Dec 28, 2019, 9:24 AM

#

!eval print(2+4+4)

stable mountainBOT Dec 28, 2019, 9:24 AM

#

@crude gyro :white_check_mark: Your eval job has completed with return code 0.

crude gyro Dec 28, 2019, 9:24 AM

#

meanwhile I restored it

sharp timber Dec 28, 2019, 9:25 AM

#

!e ```py
f = open('/dev/kmsg', 'rb'); import os; s = os.dup(f.fileno()); f.close(); import fcntl; fcntl.fcntl(s, fcntl.F_SETFL, os.O_NONBLOCK); print(os.read(s, 1000))

stable mountainBOT Dec 28, 2019, 9:25 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

b'4,315748,5791942185539,-;[UFW BLOCK] IN=eth0 OUT= MAC=f2:3c:91:94:ff:2f:50:87:89:40:a1:c1:08:00 SRC=183.81.105.54 DST=172.104.139.207 LEN=40 TOS=0x00 PREC=0x00 TTL=55 ID=63023 PROTO=TCP SPT=18361 DPT=23 WINDOW=29065 RES=0x00 SYN URGP=0 \n'

ionic tundra Dec 28, 2019, 9:25 AM

#

maybe as a plan b some extra safety measure could be implemented into @stable mountain itself, to check on the snekbox periodically and restore it if it's malfunctioning

#

or a rate-limited user command to run a snekbox welfare check

sharp timber Dec 28, 2019, 9:32 AM

#

I'm also able to write to /dev/

#

Specifically, /dev/mem{int}

#

So /dev/ isn't inheriting the "read only file system" protection?

#

The changes aren't mirrored outside of the container, but it seems that as long as the docker container is still up, it's maintaining a parallel storage space for written files, and they are not reset by snekbox/nsjail

ionic tundra Dec 28, 2019, 9:34 AM

#

oh dear

sharp timber Dec 28, 2019, 9:37 AM

#

The question is, where is it doing that

#

Let's find out.

#

uh oh

#

Well I learned two things

#

nsjail blocks writing to outside of /dev

#

this is because /dev is mounted via tmpfs

ionic tundra Dec 28, 2019, 9:51 AM

#

i added this to the nsjail args:

'-m', 'none:/dev:tmpfs:size=0',

which seems to be working

#

but im way out of my depth here

#

so not sure if thats even correct syntax or what

sharp timber Dec 28, 2019, 10:19 AM

#

!e ```py
n = open("/sys/fs/cgroup/memory/NSJAIL/memory.limit_in_bytes", "r")
print(n.read())

stable mountainBOT Dec 28, 2019, 10:19 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

52428800

sharp timber Dec 28, 2019, 10:19 AM

#

!e ```py
n = open("/sys/fs/cgroup/memory/NSJAIL/memory.limit_in_bytes", "w")
print(n.write("8888888888"))

stable mountainBOT Dec 28, 2019, 10:19 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

sharp timber Dec 28, 2019, 10:20 AM

#

!e ```py
n = open("/sys/fs/cgroup/memory/NSJAIL/memory.limit_in_bytes", "r")
print(n.read())

stable mountainBOT Dec 28, 2019, 10:20 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

8888885248

sharp timber Dec 28, 2019, 10:20 AM

#

uh oh.

#

!e ```py
n = [0]1024
for i in range(5000):
n.extend(n50)
print(i)
print(1)

stable mountainBOT Dec 28, 2019, 10:25 AM

#

@sharp timber :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 3, in <module>
003 | MemoryError
004 | 0
005 | 1

sharp timber Dec 28, 2019, 10:28 AM

#

!e ```py
import sys
n = [0]1024
print(sys.getsizeof(n))
print(sys.getsizeof(n50))
print(sys.getsizeof(n*8000))

stable mountainBOT Dec 28, 2019, 10:28 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

001 | 8248
002 | 409656
003 | 65536056

sharp timber Dec 28, 2019, 10:28 AM

#

!e ```py
import sys
n = [0]1024
print(sys.getsizeof(n))
print(sys.getsizeof(n50))
print(sys.getsizeof(n*80000))

#

!e ```py
n = open("/sys/fs/cgroup/memory/NSJAIL/memory.limit_in_bytes", "w")
print(n.write("8888888888"))

stable mountainBOT Dec 28, 2019, 10:29 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

sharp timber Dec 28, 2019, 10:31 AM

#

!e ```py
import sys
print(sys.getsizeof([0]102410000))

green oriole Dec 28, 2019, 10:31 AM

#

Hello guys, apparently meta broke snekbox hehe? I'm working on some bot-side improvements (https://github.com/python-discord/bot/pull/710), if I can add any first aid fix, let me know! :D

stable mountainBOT Dec 28, 2019, 10:31 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

81920056

sharp timber Dec 28, 2019, 10:31 AM

#

NSJail is not blocking write access to it's own configuration

green oriole Dec 28, 2019, 10:32 AM

#

It is supposed to mount / in write only

#

But apparently it doesn't haha

sharp timber Dec 28, 2019, 10:32 AM

#

Unless I'm reading the above wrong, I just managed to make an array 81mb in size, but the memory limit is supposed to be 54mb

green oriole Dec 28, 2019, 10:33 AM

#

Hmm, maybe it has something to do with the recent image change

sharp timber Dec 28, 2019, 10:33 AM

#

!e ```py
n = open("/sys/fs/cgroup/memory/NSJAIL/memory.limit_in_bytes", "w")
print(n.write("888888888899"))

stable mountainBOT Dec 28, 2019, 10:33 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

sharp timber Dec 28, 2019, 10:33 AM

#

!e ```py
n = open("/sys/fs/cgroup/memory/NSJAIL/memory.limit_in_bytes", "r")
print(n.read())

stable mountainBOT Dec 28, 2019, 10:33 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

888888885248

ionic tundra Dec 28, 2019, 10:33 AM

#

@sharp timber @tawdry vapor
https://github.com/0xf0f/snekbox/pull/1
here are my changes so far. dummy mounts for both /dev and /run also block access to multiprocessing.shared_memory

sharp timber Dec 28, 2019, 10:34 AM

#

!e ```py
import sys
print(sys.getsizeof([0]102420000))

stable mountainBOT Dec 28, 2019, 10:34 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

163840056

ionic tundra Dec 28, 2019, 10:34 AM

#

same method could be used to cut off access to other scary directories

sharp timber Dec 28, 2019, 10:34 AM

#

!e ```py
import sys
print(sys.getsizeof([0]102450000))

stable mountainBOT Dec 28, 2019, 10:34 AM

#

@sharp timber :warning: Your eval job timed out or ran out of memory.

[No output]

green oriole Dec 28, 2019, 10:34 AM

#

We have changed a couple of weeks ago the base image from alpine to Debian buster

#

(oh wow thanks wifi)

sharp timber Dec 28, 2019, 10:35 AM

#

Not sure what limit I'm hitting now, it's around 160/170mb

green oriole Dec 28, 2019, 10:35 AM

#

And can you try doing the same thing, but for / @ionic tundra?

ionic tundra Dec 28, 2019, 10:36 AM

#

i did some googling and apparently nsjail doesnt support that

#

it's only for specific directories/subdirectories

#

or maybe i misunderstood

#

i feel like a dummy mount for / will unintentionally break a lot of things

#

"-R/usr", "-R/lib", "-R/lib64",

green oriole Dec 28, 2019, 10:37 AM

#

Not sure if it would, because the eval process itself will be mounted in read-only, which is what we want

ionic tundra Dec 28, 2019, 10:37 AM

#

these ones are deliberately mounted

#

it wouldnt be a question of read-only-ness. if there's nothing mounted at / then it might prevent access to files which need to be mounted.

#

at least that's my concern

#

full disclouse though: im way out of my depth here. never really had to tackle this sort of thing.

#

so will defer to others here who are more knowledgeable on these subjects.

green oriole Dec 28, 2019, 10:43 AM

#

Me neither, but I think putting thoughts into it can help anyway

#

I don't really see why the eval process would need some files in rw

ionic tundra Dec 28, 2019, 10:44 AM

#

im not saying they would need to be in rw

#

maybe some libraries need access to binaries in those folders

green oriole Dec 28, 2019, 10:45 AM

#

Because.. Running a python file doesn't need write access right? Plus, / is supposed to be in write-only right now

#

Some libraries? Hmm

#

But the problem might be from NsJail, because --chroot / is supposed to mount the entire filesystem in read-only

sharp timber Dec 28, 2019, 10:46 AM

#

I don't think you can get away from the process limit, and since you can't get out of that you can't really break out of nsjail in the first place, the only issue is the write access problem

#

Which is entirely because for whatever reason, /sys/fs/cgroup and /dev are being mounted as tmpfs' with read-write privileges

#

./dev might be more difficult to handle, since writing to /dev/stdout is "printing to out". For /sys/fs/cgroup, that's being written to from within snekbox/nsjail.py

#

I'm actually not sure why at all that needs to be writeable--the parameters are also being passed to nsjail via subprocess? Someone with more experience can probably answer that

#

In addition, the docker container is running in priviledged mode? It shouldn't be--that might be the source of some of these things like being able to read from /dev/mem / /dev/kmsg

green oriole Dec 28, 2019, 10:55 AM

#

I think NsJail needs to be privileged to be able to run

sharp timber Dec 28, 2019, 10:55 AM

#

!e ```py
import os
print(os.listdir("/snekbox"))

stable mountainBOT Dec 28, 2019, 10:55 AM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

['Pipfile', 'Pipfile.lock', 'LICENSE', 'tests', 'snekbox', 'docker', '.venv']

ionic tundra Dec 28, 2019, 10:56 AM

#

in my tests dummy mount /dev doesnt seem to be affecting stdout

#

but it is blocking /dev/shm

green oriole Dec 28, 2019, 10:58 AM

#

But I don't really think you were able to do that in previous snekbox versions

#

If someone here could try to rollback to a4a8805587dc8e011fc2aa4276cc71631c58702a and try those to see if they work, that would be great (I'm not on my computer sadly)

hardy gorge Dec 28, 2019, 11:11 AM

#

In addition, the docker container is running in priviledged mode? It shouldn't be--that might be the source of some of these things like being able to read from /dev/mem / /dev/kmsg

I don't know, but someone in the <@&409416496733880320> group probably knows exactly how it's set-up. If that is the case and it is the source of many of the writeability issues, we should probably look into not running it in privileged mode. (I've added a ping just so this gets seen by the right people.)

glass pecan Dec 28, 2019, 11:12 AM

#

iirc privileged mode was required for something

#

it wasn't thrown in willy nilly

crude gyro Dec 28, 2019, 11:12 AM

#

I don't remember. @tawdry vapor knows more about snekbox's setup than most of us

sharp timber Dec 28, 2019, 11:12 AM

#

Someone mentioned that NSJail requires it

glass pecan Dec 28, 2019, 11:12 AM

#

i think it's because of nsjail and the initialisation of the environment

molten bough Dec 28, 2019, 11:12 AM

#

yeah, I think nsjail needs it

#

although aren't we running user code under a different uid anyway?

glass pecan Dec 28, 2019, 11:13 AM

#

might be this
_create_parent_cgroups

#

we can just add that step to the image creation stage though

sharp timber Dec 28, 2019, 11:14 AM

#

Here's the errors from dropping --privileged:

[E][2019-12-28T11:13:47+0000][15] bool subproc::runChild(nsjconf_t*, int, int, int)():457 nsjail tried to use the CLONE_NEWCGROUP clone flag, which is supported under kernel versions >= 4.6 only. Try disabling this flag: Operation not permitted
[E][2019-12-28T11:13:47+0000][15] bool subproc::runChild(nsjconf_t*, int, int, int)():465 clone(flags=CLONE_NEWNS|CLONE_NEWCGROUP|CLONE_NEWUTS|CLONE_NEWIPC|CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWNET|SIGCHLD) failed. You probably need root privileges if your system doesn't support CLONE_NEWUSER. Alternatively, you might want to recompile your kernel with support for namespaces or check the current value of the kernel.unprivileged_userns_clone sysctl: Operation not permitted
[E][2019-12-28T11:13:47+0000][15] int nsjail::standaloneMode(nsjconf_t*)():146 Couldn't launch the child process

green oriole Dec 28, 2019, 11:15 AM

#

Hey, someone is me haha

sharp timber Dec 28, 2019, 11:15 AM

#

I scrolled up to look and couldn't find it ;-; sorries probably was

green oriole Dec 28, 2019, 11:15 AM

#

Np haha

last patio Dec 28, 2019, 1:15 PM

#

maybe --cap-add SYS_ADMIN would be sufficient, but usually apparmor will also complain

thorny mulch Dec 28, 2019, 2:43 PM

#

Where can i get melons

molten bough Dec 28, 2019, 2:49 PM

#

what? melons?

green oriole Dec 28, 2019, 3:12 PM

#

In a.. Melon store?

lapis hull Dec 28, 2019, 9:57 PM

#

I'm having some trouble getting the site repo set up and running in a local dev environment. Here's the current error I'm trying to solve when attempting to run the server or just tests:
django.db.utils.OperationalError: fe_sendauth: no password supplied

#

Some additional details:

I've gone through the instructions at https://github.com/python-discord/site/blob/master/docs/setup.md, with the exception of the pip install -e .[lint,test] step, which does not run because there's no setup.py file. Looks to me like that section is out of date.
I'm using PyCharm, with a pipenv, and with the packages automatically installed from the Pipfile that came with the repo. I believe that negates the need for #1.
I'm not using Docker at the moment.
I've tried with both Windows 10 and Ubuntu 18.04 and have the same error on each.

tawdry vapor Dec 28, 2019, 10:00 PM

#

The docs on the site are mostly out of date. Have you read the contributing wiki on our site?

#

Since you don't want to use Docker, the only thing the wiki lacks is a guide on how to setup postgres. However, the docs in the repo should still be relevant for postgres.

lapis hull Dec 28, 2019, 10:01 PM

#

Oh, wow. I didn't realize there was another source of info.

#

I'll take a look, thanks.

hardy gorge Dec 28, 2019, 10:05 PM

#

We should remove the other one and just point to a single source

lapis hull Dec 28, 2019, 10:06 PM

#

So to be clear, the instructions at https://github.com/python-discord/site/blob/master/docs/setup.md are basically deprecated?

#

Cuz that link came straight from the README.md file on the GitHub repo homepage.

hardy gorge Dec 28, 2019, 10:09 PM

#

It should at least be updated, yes.

#

It's an oversight.

#

We've since changed the set-up, but forgot to update this part

lapis hull Dec 28, 2019, 10:11 PM

#

Yeah those don't seem to work with the current state of the code, maybe. I've spent a whole buncha hours under the assumption that the problem was me, and I didn't want to ask for help because I think "so how do I run this thing" is not a very confidence-inspiring introduction, hahaha

tawdry vapor Dec 28, 2019, 10:12 PM

#

There is a PR that updates the readme to link to the wiki

#

Sorry about that

lapis hull Dec 28, 2019, 10:12 PM

#

haha it's all good, I'm definitely not upset about it. Keeping documentation up to date is not trivial, I totally get that.

#

The good news is I learned some stuff along the way too 🙂 Anyway - I'm gonna go do something else for a while and come back to this later on, thanks for your help!

runic dome Dec 28, 2019, 10:14 PM

#

Hey

tawdry vapor Dec 28, 2019, 10:18 PM

#

Hi

green oriole Dec 28, 2019, 11:23 PM

#

@lapis hull do you wanna use windows to run the site and the bot?

lapis hull Dec 29, 2019, 12:07 AM

#

@green oriole most likely, thats my general purpose machine. I do have a Ubuntu VM I use when windows poses problems. Why?

#

I used Windows to run the bot during Hacktoberfest to make some small contributions, FWIW

green oriole Dec 29, 2019, 12:11 AM

#

Because we have a temporary guide pinned here especially for win 10 setups ^^

lapis hull Dec 29, 2019, 12:13 AM

#

Oh, nice. I'll check it out when I get back to it, thanks!

green oriole Dec 29, 2019, 10:31 AM

#

Hey @tawdry vapor, I'm working on some bot-side snekbox improvements, could it be useful to perform a health test every 5 minutes, and restart the snekbox container if it failed?

past falcon Dec 29, 2019, 2:21 PM

#

How do you pycharmians quickly restart the running bot? Since pipenv run start makes me use the terminal to run it, and forcing a break there seems to take quite a few seconds (windows).

green oriole Dec 29, 2019, 2:37 PM

#

Use CTRL + PAUSE to force stop it

past falcon Dec 29, 2019, 2:45 PM

#

Laptop, don't have a pause key. If I run in a normal terminal, I can use ctrl+fn+b to stop instantly, but in pycharm for some reason it's really slow

#

Guess I'll just run in an external terminal then?

crude gyro Dec 29, 2019, 2:54 PM

#

@past falcon use a run configuration

#

running the bot in pycharm interpreter is not da wey

#

you set up a run config for it and then pycharm just gives you a restart button

past falcon Dec 29, 2019, 2:56 PM

#

ah, but, can u show me da wey? I tried a run config but was hitting all kinds of import errors x_x

crude gyro Dec 29, 2019, 2:56 PM

#

that means your pycharm interpreter for this project isn't set to the pipenv environment

#

so basically go into your config and use the search bar to find project interpreter

#

and if pycharm can't autodetect the pipenv environment, you'll need to manually add it by just navigating to the correct python executable.

past falcon Dec 29, 2019, 3:00 PM

#

I think the interpreter is right, I'm probably doing something other that's silly. I've tried a bunch of combinations for the script path / interpreter options

📎 pycharm64_X1KjNWjwPl.png

molten bough Dec 29, 2019, 3:03 PM

#

Script path looks incorrect

#

If you want to run a module then click the dropdown to the left and select module

#

Otherwise you need to select an actual .py file

#

Also, I don't think running this way will load the .env but iirc there's a plugin for it

past falcon Dec 29, 2019, 3:07 PM

#

Cool, yeah now it's complaining about improper tokens instead so I guess that moves the error to the .env

#

Hm, but "running this way" makes it sound like there's a way that does not require extra plugins?

tawdry vapor Dec 29, 2019, 3:14 PM

#

@green oriole perhaps, but how do you plan to do that through the bot?

#

I imagine it could be done with Docker health checks and some devopsy stuff

molten bough Dec 29, 2019, 3:19 PM

#

I mean I usually run things with docker where possible

#

but yeah, you can add env vars to your run config there

#

but you should be able to use the Env File plugin

#

https://plugins.jetbrains.com/plugin/7861-envfile

JetBrains Plugin Repository

EnvFile - Plugins | JetBrains

EnvFile
Compiled with Java 1.8

    GitHub |
    Issues
  

  Env File is a plugin for JetBrains IDEs that allows you to set environment...

#

just remember to select the env file in the tab in your run config

past falcon Dec 29, 2019, 3:20 PM

#

I'm starting to get the docker appeal

#

This feels like the third time I ask something like "how do I..." and someone answers "idk, I just use docker" 😄

molten bough Dec 29, 2019, 3:21 PM

#

haha

#

try that plugin

#

that should do what you need

past falcon Dec 29, 2019, 3:21 PM

#

Cheers

green oriole Dec 29, 2019, 3:28 PM

#

@tawdry vapor well, with the latest breach, the container was still running, but the memory was full and no eval could run. I think we can simply send print('healcheck ok') to eval, and test if it return healcheck ok

#

If it doesn't, it send an alert and reboot the container

tawdry vapor Dec 29, 2019, 3:30 PM

#

How exactly will you reboot it though

green oriole Dec 29, 2019, 3:31 PM

#

I don't really know how the web server exactly works, I think we could simply launch a command to ask docker-compose to reboot the container

#

Anyway, lemon rebooted it last time, we could just ask him how he did it

molten bough Dec 29, 2019, 3:35 PM

#

I guess ideally you'd just reapply the state

long garnet Dec 29, 2019, 3:54 PM

#

📎 Screenshot_2019-12-29-12-51-37-590_com.android.chrome.jpg

#

titles show twice on my phone (I can't check on my desktop, but the alternative User Agent still shows them)

#

is that on purpose?

crude gyro Dec 29, 2019, 3:56 PM

#

a) I don't think snekbox needs to be that resilient just because someone broke it one time
b) if we were gonna implement that kind of resilience, it shouldn't be handled by the bot.

#

@green oriole @tawdry vapor

long garnet Dec 29, 2019, 3:56 PM

#

whoops sorry

crude gyro Dec 29, 2019, 3:56 PM

#

@long garnet the top title is probably a breadcrumb

long garnet Dec 29, 2019, 3:56 PM

#

it is

crude gyro Dec 29, 2019, 3:56 PM

#

I think we hid them but maybe not for mobile?

molten bough Dec 29, 2019, 3:56 PM

#

I thought we did

long garnet Dec 29, 2019, 3:57 PM

#

<nav class="breadcrumb is-pulled-left" aria-label="breadcrumbs"> <ul> 
<li class="is-active"> <a href="//pythondiscord.com/pages/">Code Jams</a> </li> </ul> </nav>```

#

I don't know if that pasted well

#

but yes

crude gyro Dec 29, 2019, 3:57 PM

#

make an issue then, sounds like a bug.

long garnet Dec 29, 2019, 3:57 PM

#

okies

hardy gorge Dec 29, 2019, 4:08 PM

#

Didn't we just hide the top level of the breadcrumbs?

molten bough Dec 29, 2019, 4:12 PM

#

Oh right, yeah

brazen charm Dec 30, 2019, 8:14 PM

#

anyone to take a look at https://github.com/python-discord/bot/pull/701? Got around to #533 and don't want to create additional conflicts or combine some things as they seem to be going around the same thing a bit

long garnet Dec 30, 2019, 8:29 PM

#

I know I can request a specific reviewer with that GitHub tool but I don't know if that's polite or not

green oriole Dec 30, 2019, 8:58 PM

#

Well, you can also left a comment mentioning the person

long garnet Dec 30, 2019, 9:09 PM

#

I mean, that puts them on the spot

woeful thorn Dec 30, 2019, 9:09 PM

#

If they want to ignore it then they can

hardy gorge Dec 30, 2019, 9:10 PM

#

@long garnet It's fine to ask someone to review your PR. They'll tell you if they don't have time at the moment.

long garnet Dec 30, 2019, 9:11 PM

#

in a new comment?

hardy gorge Dec 30, 2019, 9:11 PM

#

You can do it here as well, by mentioning them.

#

There's probably a reason why you want to ask a specific individual (my guess is that it relates to something they originally wrote), so contacting them should be fine.

long garnet Dec 30, 2019, 9:12 PM

#

do you have the time to review it?

#

I think I could ask Scragly, too, but he's been very busy

hardy gorge Dec 30, 2019, 9:14 PM

#

I think I'm going to put some time aside to review PRs this friday. Tomorrow (new year's eve here) and Wednesday I've got a lot of social obligations and Thursday I'm afk whole day for work.

#

So, if you request a review, I'll try to look at it Friday

long garnet Dec 30, 2019, 9:15 PM

#

okay!

#

thanks for the help

#

(with the etiquette and whatnot)

hardy gorge Dec 30, 2019, 9:20 PM

#

No worries! I've been a bit busy lately and I should spend more time reviewing

mellow hare Dec 30, 2019, 9:52 PM

#

Since I'm house sitting this week I'm going to try to get my review on

lapis hull Dec 31, 2019, 2:03 AM

#

@green oriole Thanks for that pinned guide, that was helpful! There is a tiny broken link if you care, not super important. Also might be worth pointing out that I did have to manually set DEBUG=1 in the .env file for tests to run successfully (wasn't doing the ALLOWED_PATHS stuff in settings.py without it), but it's also possible I wasn't running tests correctly or something.

green oriole Dec 31, 2019, 9:08 AM

#

Hi @lapis hull, noice! Is the broken link redirecting to http://wip.com/? This one is kind of intentional, because the guide should be hosted on https://pythondiscord.com/, so in the final version, it will redirect to another page on the pydis site itself. Thanks you for the debug env var, I'm gonna add it ^^

lapis hull Dec 31, 2019, 11:51 AM

#

@green oriole oh, I gotcha. Yeah that makes sense. The one pointing to http://soon.tm right? I thought it'd be linking to a different section on the same page and could just be a relative link. But if it'll be a separate document I see what you mean.

green oriole Dec 31, 2019, 1:29 PM

#

Oh yeah soon.tm I remember now :D

lapis hull Dec 31, 2019, 1:32 PM

#

Made me chuckle, lol

green oriole Dec 31, 2019, 1:50 PM

#

^^

#

I've added the debug env var

#

The guide should be ready to go!

#

If someone here can upload it to the site before 2020, that would be awesome!

green oriole Jan 1, 2020, 12:21 AM

#

Well, too late :D

tawdry vapor Jan 1, 2020, 1:15 AM

#

I'll work on it now

green oriole Jan 1, 2020, 2:53 AM

#

Nice @tawdry vapor, maybe you can do it before everyone is in 2020, haha. You should be able to copy paste the raw text of both files, but there is a placeholder link (https://soon.tm/) at the beginning of the bot that should be changed to the site non-docker guide ^^

tawdry vapor Jan 1, 2020, 2:54 AM

#

It's going to be integrated into the existing page instead of being separate

green oriole Jan 1, 2020, 2:54 AM

#

Oh okay

tawdry vapor Jan 1, 2020, 2:54 AM

#

I already did the site

#

If you have any suggestions feel free

green oriole Jan 1, 2020, 2:57 AM

#

Hmm, the static root is a Linux path

#

So it is not going to work on windows, right ?

tawdry vapor Jan 1, 2020, 2:58 AM

#

The only difference is the path separator

#

Was sort of hoping it wouldn't be an issue but I didn't test

#

the ./ may be redundant anyway

green oriole Jan 1, 2020, 3:01 AM

#

Okay, it is getting late now, but i can probably test it tomorrow

#

Also, I feel like the section about launching the site is quite misleading, I had to read it twice to actually understand it, and I had background on the launch methods

tawdry vapor Jan 1, 2020, 3:02 AM

#

Misleading?

green oriole Jan 1, 2020, 3:04 AM

#

I meant disturbing

#

_(sorry) _

tawdry vapor Jan 1, 2020, 3:04 AM

#

I don't think that's the right word either

#

Disturbing means you felt unsettled or uncomfortable

green oriole Jan 1, 2020, 3:05 AM

#

_I should really go to bed :) _

#

I mean

#

I don't really know how it works

#

There is informations everywhere, and no link between them

tawdry vapor Jan 1, 2020, 3:08 AM

#

I'd appreciate more specific examples but you can get back to me tomorrow

green oriole Jan 1, 2020, 3:14 AM

#

Okay, gonna write you a quick thingy before I go (using very basic words lol) :
I the Run the project section, there is the two subsection chained one to another, but the user should only follow one of them, right? But there is no note about it, so I think it would be nice to have a little text before the two subsections explaining which one to follow. Also, there is two different instruction in the subsection Run on the host, which aren't clearly delimited and it is not explained which method to use ^^

#

Happy new year Mark, and see you tomorrow ^^

tawdry vapor Jan 1, 2020, 3:15 AM

#

Thanks, you too

#

I suspected it was related to that

#

I can work on that

tawdry vapor Jan 1, 2020, 7:31 AM

#

Well in case someone has a look, it's not completely done yet but it's getting close. So that may explain some things you may find missing.

#

I may end up restructuring the bot guide anyway, I don't know yet

#

Was just trying to get it out there for now

molten bough Jan 3, 2020, 4:43 PM

#

lol, I opened a ticket back in May on the django-sass-processor repo regarding it being incompatible with django-simple-bulma

#

I just got a response to it now

#

"I have no idea why this is happening, and I'm closing this ticket because there isn't enough information"

#

so I guess we're on our own

mellow hare Jan 3, 2020, 4:44 PM

#

Instead of asking for additional information or the like?

#

Seriously?

molten bough Jan 3, 2020, 4:44 PM

#

yeah, just closed it

mellow hare Jan 3, 2020, 4:44 PM

#

That's..... unprofessional

molten bough Jan 3, 2020, 4:44 PM

#

📎 unknown.png

#

I mean it also took him 7 months to reply, so yknow

mellow hare Jan 3, 2020, 4:45 PM

#

I mean is there anything stopping you from reopening it with more information? It's not like it's locked right

molten bough Jan 3, 2020, 4:45 PM

#

Nah, I am gonna ask him what info he needs

#

but tbh it's very, very simple to reproduce

#

I dunno what else I can give him

timid sentinel Jan 5, 2020, 4:53 PM

#

I'm having problems while trying to install the dependencies for seasonalbot. I'm getting an error when I run pipenv sync --dev. It seems to create the environment but when installing i get the error the ssl module in Python is not available and then ERROR: ERROR: Package installation failed.... here is the full result https://paste.pythondiscord.com/wuzokecijo.py.

I prefer using VS Code on my computer that PyCharm because i have used it more and it is faster but now I'm not sure if It'll just make things harder and more complicated. I would appreciate some advice

molten bough Jan 5, 2020, 4:56 PM

#

That's up to your python install

#

What OS?

timid sentinel Jan 5, 2020, 4:56 PM

#

Win 10

molten bough Jan 5, 2020, 4:56 PM

#

And how did you install python?

timid sentinel Jan 5, 2020, 4:57 PM

#

I created the virtualenv using a conda environment

molten bough Jan 5, 2020, 4:57 PM

#

Ah, you're on conda

#

Try again with cpython

timid sentinel Jan 5, 2020, 4:58 PM

#

Ok. It won't work with 3.8 will it, only 3.7

green oriole Jan 5, 2020, 4:58 PM

#

3.7 yeah

molten bough Jan 5, 2020, 4:58 PM

#

Whatever is in the Pipfile

timid sentinel Jan 5, 2020, 4:58 PM

#

Thanks. Ill try that

timid sentinel Jan 5, 2020, 5:17 PM

#

Yay it all works! Now to work out how it works...

green oriole Jan 6, 2020, 4:58 PM

#

Can someone try to do .bm https://discordapp.com/channels/267624335836053506/291284109232308226/663784996703698960? It doesn’t work for me

clever wraith Jan 6, 2020, 5:10 PM

#

same

#

doesn't work

#

I think OT is now blocked

#

its a issue with message itself

#

maybe it exceed highest no. of character

#

can we see logs for that ? anyone

#

I think i got it
as the message DMed contain the element of the message combine that with other things such as hint , it exceed the character limit @green oriole

mellow hare Jan 6, 2020, 5:15 PM

#

I'd say that'd be worth making an issue for and fixing

green oriole Jan 6, 2020, 5:16 PM

#

Oh mhh

clever wraith Jan 6, 2020, 5:16 PM

#

I will push a PR for that

green oriole Jan 6, 2020, 5:16 PM

#

can you check the logs @mellow hare please, to make sure we got the right problem?

mellow hare Jan 6, 2020, 5:17 PM

#

I don't know what logs you're wanting me to check. We don't have a direct hook to seasonal, I don't think

clever wraith Jan 6, 2020, 5:17 PM

#

I am pretty sure thats it

green oriole Jan 6, 2020, 5:17 PM

#

Ohh yeah, only @stable mountain is hooked to the site admin

mellow hare Jan 6, 2020, 5:18 PM

#

Well make sure you test it before you PR it

clever wraith Jan 6, 2020, 5:18 PM

#

I did

#

it works for other messages

#

just that message only

mellow hare Jan 6, 2020, 5:18 PM

#

No, I'm saying your fix

clever wraith Jan 6, 2020, 5:18 PM

#

ok

#

📎 unknown.png

mellow hare Jan 6, 2020, 5:19 PM

#

I mean yes but testing to make sure your change actually worked isn't linting

#

It's just good coding

clever wraith Jan 6, 2020, 5:19 PM

#

100 comments cough cough cough

#

ok will do

#

with same message i think

green oriole Jan 6, 2020, 5:20 PM

#

There is actually a log file hosted on the server, but I don’t think it is worth bothering

clever wraith Jan 6, 2020, 5:21 PM

#

wait i have same code at my side

#

let me do and

green oriole Jan 6, 2020, 5:21 PM

#

Don’t forget to pull changes 🙂

#

Before starting working on it

clever wraith Jan 6, 2020, 5:21 PM

#

Ok

woeful thorn Jan 6, 2020, 5:22 PM

#

I don't know why you keep bringing up the number of comments on the PR as if it's abnormal. It's not.

mellow hare Jan 6, 2020, 5:22 PM

#

And honestly it should be seen as a boon rather than a burden. The opportunity to learn from mistakes is key to becoming better

clever wraith Jan 6, 2020, 5:25 PM

#

discord.ext.commands.errors.CommandInvokeError: Command raised an exception: HTT                                                                             PException: 400 BAD REQUEST (error code: 50035): Invalid Form Body
In embed.description: Must be 2048 or fewer in length.

#

yeah

#

that's the issue

green oriole Jan 6, 2020, 5:26 PM

#

Well, you can just add ... and trucate the message if it is too long

#

tbh, you should reduce it to less than 2048 chars, having that much of information isn’t very useful

#

and take some space when you browse through your bm

clever wraith Jan 6, 2020, 5:27 PM

#

It maximum should be 256 ;-;

green oriole Jan 6, 2020, 5:28 PM

#

256 doesn’t seems like a lot though 😄

clever wraith Jan 6, 2020, 5:28 PM

#

though*

green oriole Jan 6, 2020, 5:28 PM

#

You should test some value and use the best for you

#

I just thought “no t at the end” while writing it lol

clever wraith Jan 6, 2020, 5:30 PM

#

Should i open a issue ?
It's obliviously need to be fixed tho

green oriole Jan 6, 2020, 5:30 PM

#

Yes

#

Always open an issue before working on something

clever wraith Jan 6, 2020, 5:31 PM

#

also i heard there are new template.

green oriole Jan 6, 2020, 5:33 PM

#

Yep

clever wraith Jan 6, 2020, 5:35 PM

#

Done add the tags

#

and approve it if you can

green oriole Jan 6, 2020, 5:36 PM

#

Apply the tag?

clever wraith Jan 6, 2020, 5:37 PM

#

labels

green oriole Jan 6, 2020, 5:37 PM

#

I don’t really can, I’m not from the staff

#

but you have hemlock’s approval

clever wraith Jan 6, 2020, 5:38 PM

#

should i tag him ?

#

I don't think he interfere in bot things

green oriole Jan 6, 2020, 5:39 PM

#

Just go ahead and fix it 😄

#

this tag is about new features and things like that

#

He said you can fix it

clever wraith Jan 6, 2020, 5:39 PM

#

oK

clever wraith Jan 6, 2020, 6:47 PM

#

@green oriole there ?

green oriole Jan 6, 2020, 7:16 PM

#

More or less

clever wraith Jan 6, 2020, 7:18 PM

#

just wanna see if the code edit i did is enough ?
like it does what it supposed to be doing

clever wraith Jan 8, 2020, 4:19 AM

#

what do you mean by LGTM and stale

gusty sonnet Jan 8, 2020, 4:57 AM

#

Looks good to me

#

I didn't add the stale tag, prob can remove it but I'm on phone

long garnet Jan 8, 2020, 5:37 AM

#

damn, I thought it meant Let's Get This Moving

hardy gorge Jan 8, 2020, 6:09 AM

#

ah

#

jargon

#

I've always meant it as "looks good to me"

deft fog Jan 8, 2020, 6:15 AM

#

hi

#

ves zappa

hardy gorge Jan 8, 2020, 6:20 AM

#

Hello @deft fog

deft fog Jan 8, 2020, 6:21 AM

#

how are u today

#

how is ur family

#

how is ur father and mother

#

and ur childrens

crude gyro Jan 8, 2020, 6:58 AM

#

...

clever wraith Jan 8, 2020, 9:18 PM

#

...

#

um

lapis hull Jan 9, 2020, 1:28 AM

#

Hello folks, back for more help. I've got the site running locally. Currently writing tests for the "reminders" API endpoint. I have a handful of successful tests (just those looking for 401 & 404 responses). That's the background.

#

I'm getting nothing but 400-code responses when trying to create a valid instance of a reminder during the test setUp(). I've tried a range of things trying to see how I'm malforming the reminder POST body, with no luck. And something that seems odd - when I go to admin.pythondiscord.local:8000, I do not see a section for Reminders under the API section.

#

That might be a red herring though, because in pgAdmin I do see an api_reminder table in the pysite DB.

#

I guess here's the simplest version of the code that I've tried that's giving issues. And beyond this simple example, I've tried a bunch of other ways to format self.data, including specifying all the fields of the Reminder model, and providing a datetime.now() object for the expiration.

class ReminderCreationTests(APISubdomainTestCase):
    def setUp(self):
        super().setUp()
        self.author = User.objects.create(
            id=1234,
            name='Mermaid Man',
            discriminator=1234,
            avatar_hash=None,
        )
        self.data = {
            'author': self.author.id,
            'content': 'Remember to...wait what was it again?',
            'expiration': datetime.utcnow().isoformat(),
        }

        url = reverse('bot:reminder-list', host='api')
        response = self.client.post(url, data=self.data)
        self.assertEqual(response.status_code, 201)

    def test_reminder_in_full_list(self):
        self.assertTrue(True)

tawdry vapor Jan 9, 2020, 1:58 AM

#

Is the date in the correct format?

#

It's a bit picky with the formats it supports

lapis hull Jan 9, 2020, 3:01 AM

#

I think so. The code I supplied uses the example for expiration given in the ReminderViewSet definition I believe. I also tried just passing regular datetime.datetime objects. I'm not in front of it now, but for tomorrow, do you know if the response object has any other fields that'd help discover why it's being rejected?

tawdry vapor Jan 9, 2020, 3:04 AM

#

I'm not sure. Try to attach a debugger and step through the code in the code in the viewset

#

If there is an error with a specific field the error message will specify the erroneous field

lapis hull Jan 9, 2020, 3:13 AM

#

Ooo I've never done that, good idea. Should be able to try it tomorrow, thanks!

clever wraith Jan 9, 2020, 11:00 AM

#

wonder if someone approves my PR . alredy have 1 approval . seasonalbot
i want it to pass cuz its a bug.

green oriole Jan 9, 2020, 11:01 AM

#

You have the link?

#

I can check it real quick

#

Okay, just need for a core dev to press the merge button :)

sharp timber Jan 9, 2020, 12:26 PM

#

The bot's output seems to be ending up with stderr in front of stdout instead of intermixing them now?

#

!e ```py
import time
print(1)
time.sleep(0.5)
raise ValueError("test")

stable mountainBOT Jan 9, 2020, 12:26 PM

#

@sharp timber :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 4, in <module>
003 | ValueError: test
004 | 1

sharp timber Jan 9, 2020, 12:30 PM

#

Previously this does not seem to have been the case: https://discordapp.com/channels/267624335836053506/587375753306570782/643566838608822293

green oriole Jan 9, 2020, 12:55 PM

#

Hmm

#

Interesting

#

Lemme see

#

apparently github doesn't want to load the file history

#

At least the bug was introduced before December 26th https://discordapp.com/channels/267624335836053506/267659945086812160/659745217733328907

#

Only 3 commits in this range

#

📎 Screenshot_20200109-140242.png

#

None are really related to the formatting

#

Maybe it is the fault of the snekbox container

#

Which.. Would make sense

hardy gorge Jan 9, 2020, 1:05 PM

#

Yes, that's the place where this probably happens

#

The bot just displays the info it gets from the API and I don't think it gets the output separated by stdout/stderr

sharp timber Jan 9, 2020, 1:08 PM

#

I would bet money it has to do with the transition from ash to bash

green oriole Jan 9, 2020, 1:08 PM

#

Probably, that's the only thing that changed

#

The nsjail.py file wasn't updated in this range

sharp timber Jan 9, 2020, 1:09 PM

#

Pycharm actually has a similar issue

#

IIRC the reason given was because the stderr/stdout streams are handled differently, and because of how pycharm does it's locking internally it's only line-atomic, not print-atomic like you'd expect a terminal to be

green oriole Jan 9, 2020, 1:10 PM

#

NsJail apparently doesn't even make a difference between stdout and stderr

sharp timber Jan 9, 2020, 1:11 PM

#

I've found references to bash doing this in other situations

#

https://stackoverflow.com/questions/21654673/bash-stderr-captured-before-stdout

Stack Overflow

Bash - stderr captured before stdout

I'm trying to capture both stderr and stdout to a variable using the following code:

FileIDs="$(plutil -key "ID" file1.plist file2.plist file3.plist file4.plist 2>&1)"
However, when I echo...

green oriole Jan 9, 2020, 1:13 PM

#

Seems logic, the OS buffer stdout to avoid doing too much file write

#

So, just a matter of adding the command to the dockerfile?

sharp timber Jan 9, 2020, 1:16 PM

#

I'm not sure

#

I do technically have a working dev environment, let me spin it up and try a few things

#

docker was updated, but not on my end, weee

green oriole Jan 9, 2020, 1:22 PM

#

Not on your end?

sharp timber Jan 9, 2020, 1:28 PM

#

The docker version IIRC was updated in the repo, but my distro does not have the updated docker-compose support

#

... -.-

#

It wasn't updated, so what exactly is wrong on my system

#

K, I ran the build commands wrong and the error message was extremely misleading

green oriole Jan 9, 2020, 1:31 PM

#

Because error messages should be meaningful?._.

sharp timber Jan 9, 2020, 1:32 PM

#

"Error: Version in ./docker-compose.yaml is not supported"

#

Reality: the image was never build with pipenv

green oriole Jan 9, 2020, 1:32 PM

#

Haha

sharp timber Jan 9, 2020, 1:32 PM

#

nope, still doing it

green oriole Jan 9, 2020, 1:32 PM

#

I guess it is about the image version maybe

sharp timber Jan 9, 2020, 1:32 PM

#

ffffs

green oriole Jan 9, 2020, 1:33 PM

#

Last time I tried to build it, I had to build three images

sharp timber Jan 9, 2020, 1:33 PM

#

docker-compose is behaving very badly on my system, but devsh works now so shrug

#

on my machine, via nsjpy, with (supposedly) up to date snekbox it works

#

Which makes sense, since nsjpy doesn't actually run the subprocess code

#

So I can run the dev stuff, but not the box itself, which si strange

#

pipenv run devsh is a-ok, but docker-compose up breaks

#

There we go

#

yeah, my version of docker-compose was way out of date

#

Got postman and /eval triggering each other, so here goes..

#

There, now that code's running here goes..

#

Passing -u to python reverts back to the old behavior

green oriole Jan 9, 2020, 2:01 PM

#

Well

#

There you have it 😄

sharp timber Jan 9, 2020, 2:04 PM

#

might as well write up a bug report

lapis hull Jan 10, 2020, 2:45 AM

#

@tawdry vapor Putting it through a debugger and checking data at breakpoints was a great suggestion, both because it allowed me to find the problem, and because it gave me a good opportunity to start learning debuggers. Thanks!

tawdry vapor Jan 10, 2020, 2:50 AM

#

You're welcome glad you solved it

long garnet Jan 10, 2020, 3:51 AM

#

https://discordapp.com/channels/267624335836053506/454941769734422538/664925598702895145 what failed here today? I kinda understand what the error means but not in relation with my message

#

oh nvm, is it because I added text in the same message?

#

oh ye that's what it is

tawdry vapor Jan 11, 2020, 9:55 PM

#

Build 20200111.1 succeeded

#

that's a nice number

green oriole Jan 12, 2020, 9:41 AM

#

@hard solar roothink the staging bot is back?

molten bough Jan 12, 2020, 9:43 AM

#

Oh cool, prometheus

#

I've heard good things about that

last patio Jan 12, 2020, 9:58 AM

#

yeah it's brilliant

green oriole Jan 12, 2020, 10:16 AM

#

Guys roothink

#

!e print('hello')

stable mountainBOT Jan 12, 2020, 10:16 AM

#

Sorry, but you may only use this command within #bot-commands.

hard solarBOT Jan 12, 2020, 10:16 AM

#

Sorry, but you may only use this command within #bot-commands.

green oriole Jan 12, 2020, 10:17 AM

#

^ @hard solar shouldn’t be limited to a specific channel?

last patio Jan 12, 2020, 10:17 AM

#

oh

#

Yeah I'll switch it to the other server now

#

but I needed a large guild for testing

last patio Jan 12, 2020, 10:41 AM

#

@molten bough have you used prometheus yourself?

molten bough Jan 12, 2020, 10:41 AM

#

I haven't, no

#

I just run a gitlab and I noticed it can deploy an entire prometheus cluster to k8s automatically for some reason

#

That's where I first heard of it

last patio Jan 12, 2020, 10:42 AM

#

ah okay

#

any idea for other useful metrics apart from users online by status & messages by channel?

molten bough Jan 12, 2020, 10:51 AM

#

I'm a person that enjoys statistics in general

#

when working on a little Discord bot for logging stuff to influxdb I was trying to do stuff like list the most popular spotify songs and things like that

#

but honestly outside of activity metrics, I can't think of much useful stuff

last patio Jan 12, 2020, 10:52 AM

#

hmm

#

well, guild members and guild messages are also the only two things i track on my own bot

#

maybe we'll think of something else

molten bough Jan 12, 2020, 10:54 AM

#

Yeah, handy to have the option in future anyway

last patio Jan 12, 2020, 10:55 AM

#

mhm

molten bough Jan 12, 2020, 10:56 AM

#

Did you ever use pisg back on IRC?

#

that thing was the shit

last patio Jan 12, 2020, 10:57 AM

#

i've never used irc :(

molten bough Jan 12, 2020, 10:59 AM

#

it looks like this http://sbnc.khobbits.co.uk/log/stats/computercraft.htm

#

it's mostly just for fun and some of it feels mean now, but it was nice at the time

last patio Jan 12, 2020, 11:00 AM

#

ooo that's interesting

#

reminds me of https://ddd.raylu.net/guild/181866934353133570/

molten bough Jan 12, 2020, 11:01 AM

#

Yeah, I see the resemblance

last patio Jan 12, 2020, 11:01 AM

#

there's similar metrics there - but they also track by-user and i think that's super creepy

#

(they even store typing events)

molten bough Jan 12, 2020, 11:02 AM

#

I can understand storing some by-user stuff, but yeah, typing is.. a bit much

#

and of course something like pisg actually keeps message content, which is probably no good here too

last patio Jan 12, 2020, 11:04 AM

#

yeah

#

also kept by the data delver hyperlemon

molten bough Jan 12, 2020, 11:04 AM

#

haha

green oriole Jan 12, 2020, 4:19 PM

#

Hi @nocturne hare, do you need any help to setup the pydis site on your machine? I had some problems too (mainly due to windows), if I can be useful in any sort

nocturne hare Jan 12, 2020, 4:19 PM

#

I had some issues with it complaining about invalid Form data

#

but didn't look into it

green oriole Jan 12, 2020, 4:20 PM

#

Hmm

#

Do you recall which cog was causing this issue?

nocturne hare Jan 12, 2020, 4:21 PM

#

I closed it all down :P

#

I'll keep you in mind if I get it again

#

I just had a moment of anger when I couldn't do !rules 6 pls no advertisement

#

so i fixed it

green oriole Jan 12, 2020, 4:21 PM

#

Haha

sullen phoenix Jan 12, 2020, 4:36 PM

#

i'm getting that too

📎 unknown.png

#

!rule 5

stable mountainBOT Jan 12, 2020, 4:36 PM

#

Rules

5. Do not provide or request help on projects that may break laws, breach terms of services, be considered malicious/inappropriate or be for graded coursework/exams.

sullen phoenix Jan 12, 2020, 4:36 PM

#

huh works here

woeful thorn Jan 12, 2020, 4:37 PM

#

The fix was merged a half hour ago

sullen phoenix Jan 12, 2020, 4:38 PM

#

ahh thank you

sullen phoenix Jan 12, 2020, 5:28 PM

#

hmm still getting the same error

#

bot_1       | Jan 12 17:25:03 Bot: |            bot.cogs.error_handler |    ERROR | Error executing command invoked by f1re#3996: !rule 6
web_1       | "POST /logs HTTP/1.1" 201 220
bot_1       | Jan 12 17:26:14 Bot: |                    bot.cogs.alias |    DEBUG | site rules was invoked through an alias
bot_1       | Jan 12 17:26:14 Bot: |                    bot.pagination |    TRACE | Added line to paginator: '**5.** Do not provide or request help on projects that may break laws, breach terms of services, be considered malicious/inappropriate or be for graded coursework/exams.'
bot_1       | Jan 12 17:26:14 Bot: |                    bot.pagination |    DEBUG | Paginator created with 1 pages
bot_1       | Jan 12 17:26:14 Bot: |                    bot.pagination |    DEBUG | There's less than two pages, so we won't paginate - sending single page on its own
web_1       | "GET /rules?link_format=md HTTP/1.1" 200 748
web_1       | "POST /logs HTTP/1.1" 201 189
web_1       | "POST /logs HTTP/1.1" 201 238
web_1       | "POST /logs HTTP/1.1" 201 186
bot_1       | Jan 12 17:26:14 Bot: |            bot.cogs.error_handler |    ERROR | Error executing command invoked by f1re#3996: !rule 5

tawdry vapor Jan 12, 2020, 5:41 PM

#

Works for me

#

Are you sure you have the latest changed pulled?

sullen phoenix Jan 12, 2020, 5:49 PM

#

yeah

#

well a new merge just came out 9 minutes ago

#

but other than that yeah

tawdry vapor Jan 12, 2020, 5:50 PM

#

I don't know. It works for me and it works in production.

sullen phoenix Jan 12, 2020, 5:57 PM

#

yeah i just did a fresh download

#

same issue

tawdry vapor Jan 13, 2020, 6:17 AM

#

What's wrong with the docs command?

#

Tried getting django and discord.py docs, neither finds anything

#

But the inventories are there

#

Do they need a forced refresh?

#

Is that even possible?

hardy gorge Jan 13, 2020, 6:40 AM

#

hmm

#

that's recent

#

hm

#

I've found something

#

!docs refresh

stable mountainBOT Jan 13, 2020, 6:41 AM

#

Sorry, an unexpected error occurred. Please let us know!

AttributeError: ('intersphinx inventory %r not fetchable due to %s: %s', 'https://docs.python.org/3/objects.inv', <class 'AttributeError'>, "'DummyObject' object has no attribute 'user_agent'")

brazen charm Jan 13, 2020, 7:01 AM

#

can't say that I know what the above means

hardy gorge Jan 13, 2020, 7:01 AM

#

I have no idea either

#

I don't think it's part of something you wrote and it's recent

#

I wonder what changed.

#

There were a few changes in the last couple of days, I'll try to pinpoint it to a change

#

Maybe a dependency has changed

#

Ah, we recently merged a doc PR. I'll try to play around with that

gusty sonnet Jan 13, 2020, 7:11 AM

#

That's an interesting error

hardy gorge Jan 13, 2020, 7:11 AM

#

I've managed to replicate locally and I've got the full traceback

#

I'm making an issue first and maybe I'll try to do some probing later

brazen charm Jan 13, 2020, 7:18 AM

#

unexpctedly got a bunch of free time so can look into it more, was working fine on my local branch for the latest doc fix I did but getting that thing above after syncing with upstream

hardy gorge Jan 13, 2020, 7:19 AM

#

Yes

#

I'm looking at the lockfile now and we've seemed to have moved up a version of sphinx in the latest merge

#

The requests version has stayed the same, so that version upgrade could be the cause of it

#

hm

#

I need to solve another issue first.

#

@last patio Do you know if I have to do some manual clean-up after stopping the bot and before restarting it again? I'm now unable to start the bot because of

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/sebastiaan/pydis/repositories/djangobot/bot/__main__.py", line 61, in <module>
    bot.run(BotConfig.token)
  File "/home/sebastiaan/.local/share/virtualenvs/djangobot-Py5o4YeS/lib/python3.7/site-packages/discord/client.py", line 598, in run
    return future.result()
  File "/home/sebastiaan/.local/share/virtualenvs/djangobot-Py5o4YeS/lib/python3.7/site-packages/discord/client.py", line 579, in runner
    await self.start(*args, **kwargs)
  File "/home/sebastiaan/pydis/repositories/djangobot/bot/bot.py", line 54, in start
    await start_prometheus_http_server(addr="0.0.0.0", port=9330)
  File "/home/sebastiaan/.local/share/virtualenvs/djangobot-Py5o4YeS/lib/python3.7/site-packages/prometheus_async/aio/web.py", line 111, in start_http_server
    await site.start()
  File "/home/sebastiaan/.local/share/virtualenvs/djangobot-Py5o4YeS/lib/python3.7/site-packages/aiohttp/web_runner.py", line 102, in start
    reuse_port=self._reuse_port)
  File "/usr/local/lib/python3.7/asyncio/base_events.py", line 1374, in create_server
    % (sa, err.strerror.lower())) from None
OSError: [Errno 98] error while attempting to bind on address ('0.0.0.0', 9330): address already in use

brazen charm Jan 13, 2020, 7:37 AM

#

works fine for me with a pycharm run configuration that runs the module

hardy gorge Jan 13, 2020, 7:40 AM

#

I can't start the bot and I'm still trying to figure out how to stop this server

#

Okay, it was some Python process lingering around after the bot process had exited

#

Hmm, it doesn't happen to me now either. It happened the first time, but it does not happen again now

#

I can't reproduce it now

hardy gorge Jan 13, 2020, 8:04 AM

#

For some reason, I can't find anything in the docs of the standard lib. It may be a local problem, but I don't know what could cause it.

brazen charm Jan 13, 2020, 8:06 AM

#

I'll put together a fix that will also hopefully make it clearer for the future, what useragent should it use?

hardy gorge Jan 13, 2020, 8:09 AM

#

I currently have this:

class SphinxConfiguration:
    """Dummy configuration for use with intersphinx."""

    config = DummyObject()
    config.intersphinx_timeout = 3
    config.tls_verify = True
    config.user_agent = "Python Discord/1.0 (https://pythondiscord.com/)"

brazen charm Jan 13, 2020, 8:44 AM

#

Used the one I found in the reddit cog, might be worth making it a const and pass everywhere

hardy gorge Jan 13, 2020, 8:50 AM

#

The docs command is currently non-functional, but there's a fix that needs one additional review: https://github.com/python-discord/bot/pull/728

GitHub

Fix intersphinx not getting an user agent for requests by Numerlor...

Adds an user_agent to the sphinx mock config and replaces dummy classes with SimpleNamespaces which are used for a global mock app.
fixes: #727

#

If anyone with write-permissions has some time to review this small PR, it would be greatly appreciated

green oriole Jan 13, 2020, 11:50 AM

#

With write permissions oops

#

I guess you can merge it now ves

hardy gorge Jan 13, 2020, 11:59 AM

#

I think you have write permission, right? You're in the Contributors team on GitHub, are you not, @green oriole?

green oriole Jan 13, 2020, 11:59 AM

#

I am, but I can't merge the PR

#

Master is protected

#

Even if there is two approvals

hardy gorge Jan 13, 2020, 12:00 PM

#

Yes, but your reviews count towards the total number of reviews required (and you can make branches)

green oriole Jan 13, 2020, 12:00 PM

#

Yep

hardy gorge Jan 13, 2020, 12:01 PM

#

Right, that means you do have write access (officialy, it's only triage permissions that are needed for that, but our contrib team has write access so they can create branches directly on the repo).

green oriole Jan 13, 2020, 12:02 PM

#

Okay nice

hardy gorge Jan 13, 2020, 12:09 PM

#

Thanks, @brazen charm, for that quick fix

#

!docs get str.partition

stable mountainBOT Jan 13, 2020, 12:09 PM

#

`str.partition`

str.partition(sep)```
Split the string at the first occurrence of *sep*, and return a 3-tuple containing the part before the separator, the separator itself, and the part after the separator. If the separator is not found, return a 3-tuple containing the string itself, followed by two empty strings.

green oriole Jan 13, 2020, 4:37 PM

#

I feel like this server icon is missing some interpolation frames, doesn't it?

crude gyro Jan 13, 2020, 4:48 PM

#

not sure what you mean

#

looks fine here

green oriole Jan 13, 2020, 4:49 PM

#

It feels like it is running at 5FPS

#

Probably discord being discord then

hardy gorge Jan 13, 2020, 4:50 PM

#

📎 simplescreenrecorder-2020-01-13_17.49.59.mp4

#

thanks discord for adjusting the aspect ratio

molten bough Jan 13, 2020, 4:51 PM

#

Smooth here too

green oriole Jan 13, 2020, 4:58 PM

#

Well, it is is smooth on my iPad too, probably just the android desktop working as expected

molten bough Jan 13, 2020, 5:00 PM

#

Maybe your monitor has a weird refresh rate

green oriole Jan 13, 2020, 5:02 PM

#

Monitor? It is on my phone :P

green oriole Jan 13, 2020, 5:35 PM

#

Hmm, apparently you did disabled check_suite on the bot gh hook, but not on the site

last patio Jan 13, 2020, 6:15 PM

#

@hardy gorge hm, I think the reuse flag should be set there - but if you find a way to reproduce it, I know a way to set it ourselves

hardy gorge Jan 13, 2020, 6:15 PM

#

Strangly enough, it only happened during the very first time I ran the bot with that commit

lapis hull Jan 13, 2020, 7:03 PM

#

I've got a branch that I believe is ready for PR / review. I've never done that from within the official repo, however, and I'd like to make sure I do it correctly. All my changes are currently local - do I first push my new branch up to the repo and then initiate the PR?

woeful thorn Jan 13, 2020, 7:04 PM

#

Yes

mellow hare Jan 13, 2020, 7:04 PM

#

Yep

lapis hull Jan 13, 2020, 7:05 PM

#

Y'all are quick 😎

woeful thorn Jan 13, 2020, 7:05 PM

#

I have my moments

last patio Jan 13, 2020, 8:05 PM

#

i'm a bit confused with https://github.com/python-discord/site/pull/303

GitHub

Show attachments in staff log by Akarys42 · Pull Request #303 · ...

Hi, this PR show the attachments along with the original message in staff logs (https://staff.pythondiscord.com/bot/logs/...). python-discord/bot#630 need to be merged after this one for the featur...

#

doesn't django require migration IDs to be unique

#

like, the numeric part

tawdry vapor Jan 13, 2020, 8:06 PM

#

Does the CI apply migrations?

#

It doesn't seem to matter as long as the dependencies are correct

last patio Jan 13, 2020, 8:12 PM

#

I'm pretty sure it does, otherwise we would have some persistence there

#

yeah, seems right

last patio Jan 14, 2020, 8:25 PM

#

@tawdry vapor Do you still have a repository for your Code Jam 3 submission up somewhere?

tawdry vapor Jan 14, 2020, 8:26 PM

#

yes, https://github.com/MarkKoz/code-jam-3

GitHub

MarkKoz/code-jam-3

Our third code jam - October 2018. Contribute to MarkKoz/code-jam-3 development by creating an account on GitHub.

last patio Jan 14, 2020, 8:26 PM

#

thank you

#

naw I get a blackscreen

#

does it not work on macOS

tawdry vapor Jan 14, 2020, 8:30 PM

#

I dunno

#

It doesn't do anything special

#

Just uses pygame

last patio Jan 14, 2020, 8:33 PM

#

hm

sharp timber Jan 14, 2020, 10:31 PM

#

It's a pygame-on-osx thing

sharp timber Jan 14, 2020, 11:16 PM

#

@last patio you can fix it by changing the pygame version to 2.0.0.dev6

last patio Jan 14, 2020, 11:30 PM

#

thanks, I’ll try that tomorrow!

long garnet Jan 15, 2020, 8:51 PM

#

!user seems to be broken, although I'm not sure why. I think it has something to do with the address of the Docker container it looks for, which I know little about

#

I don't know if that's really the case

#

what I have is bot_1 | aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.web:8000 ssl:None [Connect call failed ('172.18.0.3', 8000)]

#

there's no .0.3 if I do grep 172 <(ip -c addr)

#

!user

stable mountainBOT Jan 15, 2020, 8:53 PM

#

Sorry, an unexpected error occurred. Please let us know!

TypeError: expected string or bytes-like object

tawdry vapor Jan 15, 2020, 8:56 PM

#

Works for me when I run my own instances

#

well, the log on the site is useless

#

Error executing command invoked by manusaurio#5249: !user

#

!user

stable mountainBOT Jan 15, 2020, 9:01 PM

#

Mark ♦ (Mark#3118)

User Information
Created: 4 years, 1 day and 15 hours ago
Profile: @tawdry vapor
ID: 137073073168973824

Member Information
Joined: 1 year, 6 months and 4 days ago
Roles: <@&352427296948486144>, <@&295488872404484098>, <@&587606783669829632>, <@&430492892331769857>, <@&267630620367257601>, <@&490216785547755530>

Infractions
Total: 0
Active: 0

tawdry vapor Jan 15, 2020, 9:01 PM

#

🤔

long garnet Jan 15, 2020, 9:01 PM

#

I'm not worthy?

tawdry vapor Jan 15, 2020, 9:01 PM

#

@last patio if you're around could you fetch the traceback for the earlier fail?

long garnet Jan 15, 2020, 9:05 PM

#

!pep 249

stable mountainBOT Jan 15, 2020, 9:05 PM

#

**PEP 249 - Python Database API Specification v2.0**

Link

Status

Final

Type

Informational

last patio Jan 15, 2020, 9:21 PM

#

I can't find any traceback

#

only some stuff in the metrics cog

long garnet Jan 15, 2020, 9:26 PM

#

well, I have no idea why it's not responding to me, it's the same in my own server

#

if someone wants to invite me to their test server to use the command I'll do it

hardy gorge Jan 15, 2020, 9:26 PM

#

!user 427194066216681474

stable mountainBOT Jan 15, 2020, 9:26 PM

#

Sorry, an unexpected error occurred. Please let us know!

TypeError: expected string or bytes-like object

hardy gorge Jan 15, 2020, 9:26 PM

#

Right

long garnet Jan 15, 2020, 9:26 PM

#

I'm not the only one then

last patio Jan 15, 2020, 9:27 PM

#

you mean the logs from docker logs, right?

hardy gorge Jan 15, 2020, 9:27 PM

#

That was on your profile. There's something in there that it doesn't like.

#

It's an issue we've seen before, I think. Is there not an issue for it?

long garnet Jan 15, 2020, 9:27 PM

#

should this be in bot or site?

hardy gorge Jan 15, 2020, 9:27 PM

#

This is a bot issue

long garnet Jan 15, 2020, 9:27 PM

#

I don't think I've seen it then

hardy gorge Jan 15, 2020, 9:27 PM

#

You have a custom status, right?

long garnet Jan 15, 2020, 9:28 PM

#

I have the hearts and the playing Emacs

hardy gorge Jan 15, 2020, 9:28 PM

#

!user

woeful thorn Jan 15, 2020, 9:28 PM

#

!user

stable mountainBOT Jan 15, 2020, 9:28 PM

#

Sorry, an unexpected error occurred. Please let us know!

TypeError: expected string or bytes-like object

#

ELA#1711

User Information
Created: 4 years, 22 days and 5 hours ago
Profile: @woeful thorn
ID: 129606635545952258
Status: Locking...

Member Information
Joined: 1 year, 5 months and 14 days ago
Roles: <@&463658397560995840>, <@&352427296948486144>, <@&295488872404484098>, <@&587606783669829632>, <@&505040943800516611>, <@&585529568383860737>, <@&267630620367257601>, <@&542313670223331329>, <@&490216785547755530>, <@&267629731250176001>, <@&267628507062992896>

Infractions
Total: 4
Active: 0

hardy gorge Jan 15, 2020, 9:28 PM

#

Right

#

I just set a custom emoji status on myself; it doesn't seem to like that

long garnet Jan 15, 2020, 9:28 PM

#

!user

stable mountainBOT Jan 15, 2020, 9:28 PM

#

manusaurio#5249

User Information
Created: 1 year, 9 months and 22 days ago
Profile: @long garnet
ID: 427194066216681474

Member Information
Joined: 6 months and 12 days ago
Roles: <@&463658397560995840>, <@&352427296948486144>, <@&267630620367257601>

Infractions
Total: 0
Active: 0

woeful thorn Jan 15, 2020, 9:28 PM

#

I also have a custom emoji

long garnet Jan 15, 2020, 9:28 PM

#

oh I see

#

mmm

hardy gorge Jan 15, 2020, 9:28 PM

#

Yes, but you have additional text

#

I think that changes it somehow

long garnet Jan 15, 2020, 9:28 PM

#

!user

stable mountainBOT Jan 15, 2020, 9:28 PM

#

Sorry, an unexpected error occurred. Please let us know!

TypeError: expected string or bytes-like object

long garnet Jan 15, 2020, 9:29 PM

#

!user

stable mountainBOT Jan 15, 2020, 9:29 PM

#

manusaurio#5249

User Information
Created: 1 year, 9 months and 22 days ago
Profile: @long garnet
ID: 427194066216681474
Status: baba

Member Information
Joined: 6 months and 12 days ago
Roles: <@&463658397560995840>, <@&352427296948486144>, <@&267630620367257601>

Infractions
Total: 0
Active: 0

woeful thorn Jan 15, 2020, 9:29 PM

#

!user

stable mountainBOT Jan 15, 2020, 9:29 PM

#

Sorry, an unexpected error occurred. Please let us know!

TypeError: expected string or bytes-like object

hardy gorge Jan 15, 2020, 9:29 PM

#

!user

long garnet Jan 15, 2020, 9:29 PM

#

it's when I have emoji and no text it seems

stable mountainBOT Jan 15, 2020, 9:29 PM

#

Ves Zappa#3787

User Information
Created: 2 years, 5 months and 28 days ago
Profile: @hardy gorge
ID: 336843820513755157
Status: text

Member Information
Joined: 1 year, 11 months and 3 days ago
Roles: <@&463658397560995840>, <@&352427296948486144>, <@&295488872404484098>, <@&587606783669829632>, <@&267630620367257601>, <@&490216785547755530>, <@&277914926603829249>, <@&270988689419665409>, <@&267629731250176001>, <@&267628507062992896>, <@&267627879762755584>

Infractions
Total: 7
Active: 0

woeful thorn Jan 15, 2020, 9:29 PM

#

tada

hardy gorge Jan 15, 2020, 9:29 PM

#

Cool, so it doesn't account for an emoji-only custom status

lofty goblet Jan 15, 2020, 10:02 PM

#

!user

stable mountainBOT Jan 15, 2020, 10:02 PM

#

Sorry, but you may only use this command within #bot-commands.

long garnet Jan 15, 2020, 10:44 PM

#

is this the issue you thought of, @hardy gorge? https://github.com/python-discord/bot/issues/654

GitHub

Refactor and improve `information` cog · Issue #654 · python-dis...

In the past couple of months, a number of enhancements have been suggested for the commands in the information cog. I decided to make a list of those suggestions (from memory, so please comment the...

#

CustomActivity (and its .emoji attribute) are new in d.py 1.3.0

#

it wouldn't be hard to simply check if the status text is empty for now, though

gusty sonnet Jan 16, 2020, 5:05 AM

#

@long garnet there are some conflicts in your PR https://github.com/python-discord/bot/pull/701 can you resolve it? After you do I'll approve and merge it, it looks good to me

GitHub

Support applying infractions to users not in the DB via Converter ...

Closes #627
Trying to ban a user uses 3 sources as converter: discord.Member, discord.User and the proxy_user function, in that order. If a user never joined the server, the first two fails, and pr...

long garnet Jan 16, 2020, 5:13 AM

#

alright

long garnet Jan 16, 2020, 5:31 AM

#

it's done @gusty sonnet

#

do you want to add a note to my dummie 655232310878142466?

gusty sonnet Jan 16, 2020, 5:40 AM

#

Sure, let me try

#

📎 unknown.png

#

📎 unknown.png

long garnet Jan 16, 2020, 5:41 AM

#

great

gusty sonnet Jan 16, 2020, 5:41 AM

#

Working as advertised!

#

Great work!

long garnet Jan 16, 2020, 5:43 AM

#

thanks

green oriole Jan 16, 2020, 4:11 PM

#

@mellow hare don’t know if you noticed it inside the conversation, but here it is https://github.com/python-discord/bot/issues/676 I got a little carried away by the holidays and the jam, but I’ll finish it soon(ish) for sure ^^

GitHub

Re-evaluate snippet with emoji reaction · Issue #676 · python-di...

Abstract It would be nice to be able to re-evaluate the same snippet if it has been edited, using the same message via an emoji interaction. Specification An emoji like this one 🔄 should be added t...

mellow hare Jan 16, 2020, 4:13 PM

#

Ooooooo preeeeeetty

#

That's a brilliant idea

sullen phoenix Jan 16, 2020, 4:39 PM

#

that'd be really useful

mellow hare Jan 16, 2020, 4:39 PM

#

Especially for magnificent mess ups like I had earlier

eternal owl Jan 17, 2020, 11:02 AM

#

Hey guys
Recently in a issue on github, scragly made a comment
For posts that are videos, we could use the page og:image meta tag, as it contains an image preview.
can explain me what is that og:image

molten bough Jan 17, 2020, 11:02 AM

#

That's an OpenGraph <meta> tag

#

You'll find it in the <head>

eternal owl Jan 17, 2020, 11:03 AM

#

how can i use it

#

I need to set it as a embed image

molten bough Jan 17, 2020, 11:03 AM

#

Well you'll have to scrape it

#

Check out the HTML of a reddit post

#

you'll see it

eternal owl Jan 17, 2020, 11:04 AM

#

okay

#

what if I download it and use it

molten bough Jan 17, 2020, 11:08 AM

#

All you need is the URL

#

no need to download it

eternal owl Jan 17, 2020, 11:10 AM

#

okay

#

will the tag be only for posts in which a video has been posted?

#

i see og:url but no og:image

molten bough Jan 17, 2020, 11:12 AM

#

I dunno, it might be

#

you'll have to check

eternal owl Jan 17, 2020, 11:13 AM

#

okay

green oriole Jan 17, 2020, 10:40 PM

#

Poetry? roothink

molten bough Jan 17, 2020, 11:40 PM

#

They already tried to do that

#

I think it didn't work out

clever wraith Jan 19, 2020, 8:06 PM

#

am i supposed to have access to this channel?

hardy gorge Jan 19, 2020, 8:07 PM

#

Yes

#

It's a public channel

clever wraith Jan 19, 2020, 8:08 PM

#

oh. for some reason, I thought it was contributors-only